thodg/libgit2/src

Diff

  • Show log

    Commit

  • Hash : a613832e
    Author : Patrick Steinhardt
    Date : 2019-07-20T18:49:48 

    patch_parse: fix segfault due to line containing static contents

With commit dedf70ad2 (patch_parse: do not depend on parsed buffer's
lifetime, 2019-07-05), all lines of the patch are allocated with
`strdup` to make lifetime of the parsed patch independent of the buffer
that is currently being parsed. In patch b08932824 (patch_parse: ensure
valid patch output with EOFNL, 2019-07-11), we introduced another
code location where we add lines to the parsed patch. But as that one
was implemented via a separate pull request, it wasn't converted to use
`strdup`, as well. As a consequence, we generate a segfault when trying
to deallocate the potentially static buffer that's now in some of the
lines.

Use `git__strdup` to fix the issue.

kmx.io     mail     discord kmxgit v0.4.0