thodg/libgit2/src

Diff

  • Show log

    Commit

  • Hash : e14dab2f
    Author : Patrick Steinhardt
    Date : 2018-08-09T10:46:58 

    smart_pkt: check whether error packets are prefixed with "ERR "

In the `git_pkt_parse_line` function, we determine what kind of packet
a given packet line contains by simply checking for the prefix of that
line. Except for "ERR" packets, we always only check for the immediate
identifier without the trailing space (e.g. we check for an "ACK"
prefix, not for "ACK "). But for "ERR" packets, we do in fact include
the trailing space in our check. This is not really much of a problem at
all, but it is inconsistent with all the other packet types and thus
causes confusion when the `err_pkt` function just immediately skips the
space without checking whether it overflows the line buffer.

Adjust the check in `git_pkt_parse_line` to not include the trailing
space and instead move it into `err_pkt` for consistency.

(cherry picked from commit 786426ea6ec2a76ffe2515dc5182705fb3d44603)

kmx.io     mail     discord kmxgit v0.4.0