|
1b7fc81e
|
2019-07-31T19:40:50
|
|
minor whitespace tidy-up.
|
|
f8400cbb
|
2019-07-31T09:11:20
|
|
Fixed bug 4692 - Command line parsing
Galadrim
As I have seen, SDL implements its own command line parser for Windows in SDL_windows_main.c. Unfortunately, it doesn't seem to allow command line arguments with trailing backslashes if quoting is required.
Usually, when you write an application that gets command line arguments passed as argc and argv, the parsing is done by parse_cmdline. The Windows API also provides the function CommandLineToArgvW, so an application can parse itself if only the command line string is provided. Both functions behave almost identically according to their documentation. If the argument "\\" (including the quotes) is passed, they both turn it into a single backslash.
The SDL command line parser on the other hand doesn't recognize the second quote character as the closing character in this example and therefore includes it in the parsed argument. The parser does not count the number of backslashes preceding a quote. It always treats a quote as escaped if a backslash is in front of it. Therefore, it should be impossible to quote and escape an argument correctly, if it has a trailing backslash and contains characters that require quoting.
Of course, each application is allowed to implement its own parsing rules, so SDL is free to do so. But the problem I see is that there are arguments, that are impossible to be passed to the parser correctly, as I described above. Is there a reason, why SDL does not simply use CommandLineToArgvW instead of implementing its own parser?
Here are some links that show that correct argument parsing, as it is usually done in Windows, is quite complicated:
https://docs.microsoft.com/en-us/windows/desktop/api/shellapi/nf-shellapi-commandlinetoargvw
http://www.windowsinspired.com/how-a-windows-programs-splits-its-command-line-into-individual-arguments/
|
|
|
4953e050
|
2019-07-31T05:11:40
|
|
use SDL_zeroa at more places where the argument is an array.
|
|
|
67c67f3a
|
2019-06-17T10:13:28
|
|
Updated version to 2.0.10
|
|
|
de82759c
|
2019-03-19T07:53:33
|
|
Added support for building SDL as a dynamic library on iOS
|
|
|
5e13087b
|
2019-01-04T22:01:14
|
|
Updated copyright for 2019
|
|
e542d1a3
|
2018-10-29T20:18:50
|
|
winmain: Patched to compile on C89 compilers.
|
|
|
f434a98c
|
2018-10-29T20:00:03
|
|
winmain: Don't use SDL_malloc (or SDL_stack_alloc, which might be malloc).
Otherwise, we are using the allocator before the app can set up its own hooks.
Now we use VirtualAlloc, and WideCharToMultiByte (because SDL_iconv uses
SDL_malloc, too!) to get ready to call into SDL_main.
This also makes console_wmain() call into the same routines as everything
else, so we don't have to deal with those allocations, too. Hopefully we
end up with the same results from GetCommandLine() as we do in wargv.
Fixes Bugzilla #4340.
|
|
|
b262b0eb
|
2018-10-22T20:50:32
|
|
Small stack allocations fall back to malloc if they're unexpectedly large.
|
|
|
bc6c1997
|
2018-09-26T10:08:14
|
|
Updated version to 2.0.9
|
|
|
5febdfce
|
2018-09-24T11:49:25
|
|
Fixed whitespace
|
|
|
941c5b47
|
2018-08-07T18:07:11
|
|
haiku: Rename internal functions from BE_* to HAIKU_*
Fixes Bugzilla #2349.
|
|
|
1143857d
|
2018-02-10T12:43:11
|
|
Fixed bug 4073 - Unquoted Unicode argument parsing broken on Windows due to incorrect usage of SDL_isspace()
|
|
|
e3cc5b2c
|
2018-01-03T10:03:25
|
|
Updated copyright for 2018
|
|
|
2c5724ef
|
2017-11-04T21:58:48
|
|
Updated version to 2.0.8 since SDL_image depends on it
|
|
0e032d58
|
2017-10-24T13:21:11
|
|
WinRT: Move Windows::Foundation::Initialize to SDL2.dll, from SDL_main.
This allows C# UWP applications to use SDL2's SDL_WinRTRunApp function.
Kudos to Ethan Lee (flibitijibibo@flibitijibibo.com) for the patch. Thanks!
|
|
|
0ce23a54
|
2017-10-12T08:08:04
|
|
Updated version to 2.0.7
|
|
|
dbb0a2aa
|
2017-08-28T14:34:15
|
|
Removed the need for libSDL2main.a on Android, and separated JNI initialization out for other integrations
|
|
|
2dc5d32f
|
2017-08-18T18:16:37
|
|
Updated version to 2.0.6
|
|
|
df2d2994
|
2017-08-13T18:12:06
|
|
Fixed bug 2812 - Make libSDL2main.a usable on Android via a dummy symbol
Jonas Kulla
This eliminates the need to manually compile in SDL_main_android.c.
Instead, add "-lSDL2main -Wl,-u,SDL_main_dummy" when linking.
I don't know how the nkd-build process works, but unless it was
for some reason linking libSDL2main.a it should be unaffected.
|
|
c3bf69ca
|
2017-07-07T23:00:22
|
|
haiku: Fixed compiling without OpenGL support.
|
|
|
4b47fa38
|
2017-06-04T23:15:47
|
|
Removed duplicate includes.
|
|
11289b76
|
2017-06-04T21:25:57
|
|
Android cmake build fixed to work with the official android gradle plugin
|
|
|
07b0df0a
|
2017-06-02T22:15:37
|
|
haiku: Changed internal variable to be static.
|
|
|
619ab7a2
|
2017-05-01T18:39:05
|
|
haiku: Various fixes from haikuports.
Based on patch here:
https://github.com/haikuports/haikuports/blob/master/media-libs/libsdl2/patches/libsdl2-2.0.5.patchset
|
|
|
63e83a31
|
2017-01-21T22:01:17
|
|
Haiku: Removed unused variable.
Found by Cppcheck.
|
|
|
45b774e3
|
2017-01-01T18:33:28
|
|
Updated copyright for 2017
|
|
|
8a73f7e8
|
2016-10-19T20:42:22
|
|
Fixed bug 3461 - Implement TEXTINPUT events for Haiku
Kai Sterker
Apparently, SDL2 on Haiku does not generate SDL_TEXTINPUT events.
Attached is a patch that adds this functionality.
Tested with SDLs own checkkeys program and different keymaps as well as my own SDL application and German keyboard layout to verify it generates the expected input.
|
|
|
8aab39cb
|
2016-10-14T08:27:44
|
|
Fixed bug 3452 - Getting unicode arguments for the main entry point on Windows
Simon Hug
There are currently three entry points in the SDL2_main code for windows: main, wmain and WinMain. Only the latter two properly convert the arguments to UTF-8.
Console applications linked with MSVC will always link with the main entry point (wmain has to be selected by manually setting the entry point). This makes it likely that such programs will not have proper unicode arguments.
|
|
|
14e7da75
|
2016-10-12T19:50:16
|
|
Backed out change 7d3df1df4e91 which was: Fixed bug 3320 - SDL_windows_main.c defines both console application entry points
With that change only the wmain() entry point was defined, and applications that linked with main() would no longer build.
|
|
|
d870f271
|
2016-10-01T12:31:31
|
|
Fixed bug 3320 - SDL_windows_main.c defines both console application entry points
Simon Hug
The SDLmain file src/main/windows/SDL_windows_main.c defines both entry points for console applications, main and wmain. This seems to confuse MSVC. It outputs a LNK4067 warning and then chooses main, which is a shame because only wmain has the unicode handling. Using SDLmain.lib provided on libsdl.org, the linker also goes for main.
I'm proposing to not define the main entry point at all. wmain should be supported well enough with MSVC.
|
|
|
708def87
|
2016-10-01T11:48:15
|
|
Fixed bug 3338 - console_wmain doesn't null terminate the argv array
Simon Hug
The function console_wmain in src/main/windows/SDL_windows_main.c does not null terminate the argument list it is creating. As specified by the C standard, "argv[argc] shall be a null pointer."
The SDLTest framework makes use of that null pointer and some test programs can cause an access violation because it's missing.
|
|
|
e45698d2
|
2016-09-28T22:24:01
|
|
Updated version to 2.0.5 in preparation for release
|
|
|
6b1d5f44
|
2016-07-17T21:42:53
|
|
Android: Fixed compile warning about a missing prototype (thanks, Sylvain!).
Fixes Bugzilla #3351.
|
|
|
441359bd
|
2016-05-14T23:29:49
|
|
WinRT: workaround a possible Windows bug, whereby hiding cursors, disables mouse-moved events
This workaround, unfortunately, requires that apps directly link to a set of
Win32-style cursor resource files (that contain a transparent cursor image).
Copies of suitable resource files are in src/core/winrt/, and should be
included directly in an app's MSVC project.
A rough explanation of this workaround/hack, and why it's needed (and
seemingly can't be done through programmatic means), is in this change's code.
|
|
|
c137eb61
|
2016-04-12T18:40:44
|
|
Patched to compile on Haiku...?
|
|
|
9b4db2b8
|
2016-04-12T18:11:36
|
|
Patched to compile on various platforms.
|
|
|
c61675dc
|
2016-04-12T16:45:10
|
|
threads: Move SDL's own thread creation to a new internal API.
This allows us to set an explicit stack size (overriding the system default
and the global hint an app might have set), and remove all the macro salsa
for dealing with _beginthreadex and such, as internal threads always set those
to NULL anyhow.
I've taken some guesses on reasonable (and tiny!) stack sizes for our
internal threads, but some of these might turn out to be too small in
practice and need an increase. Most of them are simple functions, though.
|
|
704298c0
|
2016-02-09T17:36:42
|
|
Android: C89 cleanup to avoid warnings/errors since the default gcc mode on Android is still pre-C99.
|
|
|
68a32728
|
2016-01-02T10:38:51
|
|
Fixed sed error on Mac OS X and updated copyright on a few last files
|
|
|
42065e78
|
2016-01-02T10:10:34
|
|
Updated copyright to 2016
|
|
|
270f38db
|
2015-08-01T22:03:50
|
|
Fixed bug 3083 - Android JNIEXPORT and JNICALL missing
Martin Gerhardy
Just a minor thing, but a huge outcome. All the other jni related functions already have those flags, but the nativeInit function lacks them - so it might be stripped away.
|
|
|
0e45984f
|
2015-06-21T17:33:46
|
|
Fixed crash if initialization of EGL failed but was tried again later.
The internal function SDL_EGL_LoadLibrary() did not delete and remove a mostly
uninitialized data structure if loading the library first failed. A later try to
use EGL then skipped initialization and assumed it was previously successful
because the data structure now already existed. This led to at least one crash
in the internal function SDL_EGL_ChooseConfig() because a NULL pointer was
dereferenced to make a call to eglBindAPI().
|
|
|
2c4a6ea0
|
2015-05-26T06:27:46
|
|
Updated the copyright year to 2015
|
|
|
b72938c8
|
2015-04-20T12:22:44
|
|
Windows: Always set the system timer resolution to 1ms by default.
An existing hint lets apps that don't need the timer resolution changed avoid
this, to save battery, etc, but this fixes several problems in timing, audio
callbacks not firing fast enough, etc.
Fixes Bugzilla #2944.
|
|
fe6c797c
|
2015-04-10T23:30:31
|
|
Fixed an iOS view orientation issue when SDL_GL_CreateContext or SDL_CreateRenderer is called.
|
|
|
33b9d9ad
|
2015-02-19T21:51:13
|
|
Windows: Added a FIXME.
|
|
|
674eb556
|
2015-02-19T21:50:40
|
|
Windows: Free the argv we allocated for console_wmain().
|
|
|
e974ccf8
|
2015-02-19T21:49:30
|
|
Windows: Added a FIXME.
|
|
|
f7c4c3d0
|
2015-02-19T21:49:15
|
|
Windows: Make a distinction between ANSI mainline and UTF-8 mainline.
|
|
|
e93ee5d7
|
2015-02-19T21:44:41
|
|
Windows: Support unicode arguments for console applications (thanks, Jorgen!).
Fixes Bugzilla #2864.
|
|
b88ca1b4
|
2015-02-10T16:28:56
|
|
the last parameter of XChangeProperty is the number of elements.. and when the element format is 32.. the element is "long" so we have 5 long elements here.
Yes this seems confusing as on mac+linux Long is either 32 or 64bits depending on the architecture, but this is how the X11 protocol is defined. Thus 5 is the correct value for the nelts here. Not 5 or 10 depending on the architecture.
More info on the confusion https://bugs.freedesktop.org/show_bug.cgi?id=16802
|
|
|
86f87bf7
|
2015-01-31T22:45:54
|
|
Added missing guards in implementation for PSP.
Thanks to Martin Gerhardy for pointing this out.
|
|
|
b48e54aa
|
2015-01-26T22:00:29
|
|
Fixed bug 2802 - [patch] Fix android build compiling in wrong filesystem implementation
Jonas Kulla
The configure script didn't differentiate between Linux and Android, unconditionally compiling in the unix implementation of SDL_sysfilesystem.c.
I'm probably one of the very few people building SDL for android using classic configure + standalone toolchain, so this has gone undetected all along.
|
|
|
70438be2
|
2014-12-03T10:55:23
|
|
WinRT: fixed bug whereby SDL would override an app's default orientation
WinRT apps can set a default, preferred orientation via a .appxmanifest file.
SDL was overriding this on app startup, and making the app use all possible
orientations (landscape and portrait).
Thanks to Eric Wing for the heads up on this!
|
|
|
4dab32a2
|
2014-11-28T04:51:33
|
|
Fixed bug 2786 - "UCS-2-INTERNAL" iconv encoding is not supported everywhere, use UTF-16LE instead
Jonas Kulla
src/main/windows/SDL_windows_main.c:137:
cmdline = SDL_iconv_string("UTF-8", "UCS-2-INTERNAL", (char *)(text), (SDL_wcslen(text)+1)*sizeof(WCHAR));
I'm trying to compile an SDL2 application for windows using the mingw-w64 32bit toolchain provided by my distro (Fedora 19). However, even the simplest test program that does nothing at all fails to startup with a "Fatal error - out of memory" message because the mingw iconv library provided by my distro does not support the "UCS-2-INTERNAL" encoding and the conversion returns null.
From my little bit of research, it turns out that even though this encoding is supported by the external GNU libiconv library, some glibc versions (?) don't support it with their internal iconv routines, and will instead provide the native endian encoding when "UCS-2" is specified.
Nonetheless, I wonder why the native endianness is considered in the first place when Windows doesn't even run on any big endian archs (to my knowledge). And true enough, 'WIN_StringToUTF8' from core/windows/SDL_windows.h is used everywhere else in the windows backend, which is just a macro to iconv with "UTF-16LE" as source. Therefore it would IMO make sense to use this macro here as well, which would solve my problem (patch attached).
|
|
|
8cab5ae3
|
2014-11-25T22:31:14
|
|
Fixed limitation for number of custom main() arguments on Android.
Limitation was size of the reference table because local refs were not deleted.
|
|
|
5b5823ee
|
2014-11-23T21:09:54
|
|
add in support for passing down the "natural" (or flipped) scrolling direction in the MouseWheelEvent event
|
|
|
9c398852
|
2014-11-22T22:20:40
|
|
Corrected header file documentation comment.
|
|
|
ec4dfdfc
|
2014-10-17T23:36:45
|
|
Fixed bug 2476 - Allow custom main() arguments
rettichschnidi
I would like to pass custom arguments from my Java code (subclass of SDLActivity) to the native SDL2 binary.
|
|
|
7cabaebe
|
2014-10-17T23:26:02
|
|
Fixed typo in source comment.
|
|
24c86b55
|
2014-09-11T19:24:42
|
|
[X11] Reconcile logical keyboard state with physical state on FocusIn
since the window system doesn't do it for us like other platforms.
This prevents sticky keys and missed keys when going in and out
of focus, for example Alt would appear to stick if switching away
from an SDL app with Alt-Tab and had to be pressed again.
CR: Sam
|
|
|
7242e814
|
2014-09-02T06:55:47
|
|
Updated version to 2.0.4
|
|
|
2230df55
|
2014-07-27T19:52:52
|
|
Remove dependency on C runtime from Windows SDLmain.
|
|
|
d1ca658c
|
2014-07-12T13:05:41
|
|
Fixed bug 2638 - (Signed) Can't create signed apps in Android
Pablo Mayobre
When generating a signed app with SDL 2.0.3 an issue comes up, watching at the Error Log points out that the issue lies in the src/main/android/SDL_android_main.c where the process name is defined as "SDL_app", this name turns into an erroneous name so it should be changed to "app_process"
|
|
3b217eef
|
2014-06-20T11:50:31
|
|
Fix another NaCl warning
|
|
|
553cc07e
|
2014-06-20T10:59:51
|
|
Initialize nacl_io, removes SDL_NaClMount/Umount
It's just easier to use nacl_io's mount/umount directly.
|
|
|
efa2d058
|
2014-06-08T18:18:13
|
|
Fixes audio for Native Client, and other fixes...
- SDL_NaClMount, SDL_NaClUmount
- Default mounting of https at / in SDL's main function
- More documentation in README-nacl.txt
|
|
|
1e352d79
|
2014-06-06T15:45:59
|
|
Chrome's Native Client backend implementation
|
|
|
3dcb451f
|
2014-04-09T21:29:19
|
|
Added a README file regarding WinRT support
To note, this file is currently formatted with CRLF line endings, rather than
LF, to allow the file to be viewed with Notepad.
|
|
|
2d8b86bb
|
2014-04-05T23:24:33
|
|
Fixed unused local variable warning.
|
|
|
205266fa
|
2014-03-15T10:37:40
|
|
Fixed a build error when including WinRT's SDLmain file directly in an app
|
|
|
f9a58968
|
2014-03-13T21:21:26
|
|
Added missing copyright notices
|
|
|
1367bf87
|
2014-03-09T11:36:47
|
|
Integrated David Ludwig's support for Windows RT
|
|
|
05c23063
|
2014-03-09T11:06:11
|
|
Fixed line endings on WinRT source code
|
|
|
c167d1f6
|
2014-03-09T10:38:30
|
|
Updated SDL to version 2.0.3
|
|
|
853334af
|
2014-02-09T03:09:56
|
|
Updated SDL to version 2.0.2
|
|
|
58edac3e
|
2014-02-02T00:53:27
|
|
Fixed bug 2374 - Update copyright for 2014...
Is it that time already??
|
|
|
f848adff
|
2013-11-29T10:06:08
|
|
Improve Android pause/resume behavior.
|
|
|
46740a5a
|
2013-11-28T22:09:21
|
|
WinRT: merged with latest SDL 2.x/HG code
SDL 2.x recently accepted patches to enable OpenGL ES 2 support via Google's ANGLE library. The thought is to try to eventually merge SDL/WinRT's OpenGL code with SDL-official's.
|
|
|
7e1289af
|
2013-11-24T23:56:17
|
|
Make internal SDL sources include SDL_internal.h instead of SDL_config.h
The new header will include SDL_config.h, but allows for other global stuff.
|
|
|
b2f8b351
|
2013-11-14T20:24:40
|
|
Fixed comment typo.
|
|
|
00003e8c
|
2013-11-14T11:51:24
|
|
Renamed things named after BeOS to be named after Haiku instead.
|
|
|
69c5d21d
|
2013-10-27T21:26:46
|
|
WinRT: merged with SDL 2.0.1 codebase
|
|
|
d1bde399
|
2013-10-20T20:24:00
|
|
Backed out changeset 737771c47c6f, done testing Buildbot changes.
|
|
|
df368084
|
2013-10-20T20:02:02
|
|
Intentionally breaking Windows and Raspberry Pi builds to test Buildbot change.
|
|
|
12ca3ce3
|
2013-10-17T23:02:29
|
|
Fixed building using MinGW
Our SDL_windows.h needed to be included before anything else so UNICODE is defined.
|
|
|
a7e1fddd
|
2013-10-10T21:50:25
|
|
Updated SDL to version 2.0.1
|
|
|
58dd0864
|
2013-09-22T12:26:53
|
|
WinRT: unified the two, public, app-init functions
This function, SDL_WinRTRunApp, can be used to help launch either XAML or non-XAML/Direct3D-only based apps.
|
|
|
aeaa0505
|
2013-09-16T22:43:12
|
|
WinRT: ugh, at least one file in an app's project seems to require C++/CX compilation.
Assuming this is true, that file might as well be the one that contains WinMain.
|
|
|
efb3cdca
|
2013-09-16T22:27:30
|
|
WinRT: renamed SDL_winrt_main.cpp to indicate that it should only be used in non-XAML apps
This can break builds of existing SDL/WinRT apps. To fix, remove the reference to SDL_winrt_main.cpp, then add a reference to the renamed file, SDL_winrt_main_NonXAML.cpp. If you get a build error about a missing .winmd file, enable the /ZW compiler flag for that one file (at minimum).
|
|
|
fff83d8e
|
2013-09-16T21:09:58
|
|
WinRT: reduced the size of SDL_winrt_main.cpp by a little bit
|
|
|
c72a4fa3
|
2013-09-15T23:53:51
|
|
WinRT: made SDL_winrt_main.cpp not have to be compiled as C++/CX (via the /ZW compiler flag)
This file can still be compiled as C++/CX, however that is now optional/not-required.
|
|
|
f860141a
|
2013-08-27T12:33:36
|
|
WinRT: renamed "windowsrt" directories to "winrt"
|
|
|
1e49b1ed
|
2013-08-21T09:47:10
|
|
OCD fixes: Adds a space after /* (glory to regular expressions!)
|
|
|
695344d1
|
2013-08-21T09:43:09
|
|
OCD fixes: Adds a space before */
|
|
|
552b04c5
|
2013-08-20T20:34:40
|
|
More non C89 compliant comments
|
|
|
c2a29aed
|
2013-08-18T22:05:53
|
|
Fixed Haiku build (thanks Alexander!)
|
|
|
f7049b93
|
2013-08-12T22:29:55
|
|
WinRT: merged with SDL 2.0.0 codebase (aka. SDL hg rev d4ce48ff30d1)
|
|
|
dad42067
|
2013-08-12T11:13:50
|
|
Fixes #2022, do not resume on Android when surfaceChanged
If the app is in landscape mode and the user presses the power button, a pause
is followed immediately by a surfaceChanged event because the lock screen
is shown in portrait mode. This triggers a "false" resume.
So, we just pause and resume following the onWindowFocusChanged events.
Also, wait for SDL_APP_WILLENTERBACKGROUND and SDL_APP_DIDENTERBACKGROUND before
blocking the event pump.
|