|
06819324
|
2023-10-12T00:00:00
|
|
Metal: Linearize PVRTC1 blocks for buffer uploads
PVRTC1 blocks are stored in a reflected Morton order
and need to be linearized for buffer uploads in Metal.
Fixed: angleproject:8376
Change-Id: I59497aaf49eb57aa93e346d62d56c69535555fd9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4973955
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
de71dd05
|
2023-10-27T07:01:30
|
|
Roll Chromium from eeef412b7e3c to 63a05c417b61 (619 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/eeef412b7e3c..63a05c417b61
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,geofflang@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/b43af392a3..dc772ab952
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/11e982b6f9..5a1d6bf1a3
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/e71c84911d..da6f122a55
* third_party/android_build_tools/lint: vdzlvQoq4o7IGjo9mhBtZIkfFZWpmjCZLIs9ISfB7KsC..KNl-Nl1apUB5k0bMGpYmM6F9_AsDD47Ka_b5BI0InvQC
* third_party/android_build_tools/manifest_merger: S3Uexmlj5xGKoVRHL8yIysS_cVsUrc3E3K_sq2hsCU0C..V90mMwKNdDvQaZ-2eMjmdkHQdGrDn3w4DxA-fGMA8y0C
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/27f2daf83f..dddbc62757
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e0c9c85d41..16e6d794aa
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/27ea34f94e..7751ddfa9e
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d8fb829b95..9b27200e82
* third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/5acf60c8b9..2ca9f38714
* third_party/r8: hCR0xJbBeRfCUH-G2O_dMQ2C7wY-BhWHhAdXP_yuG3MC..Jn6jDwY2CaSHjf9fzclZsEGDIaIudbGyiQAiqu6fjnMC
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/34b911efa9..3518522a2f
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/573b2a1530..e6bdcbdfc1
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f130da7870..d0ebb9bf7a
No update to Clang.
Bug: None
Tbr: geofflang@google.com
Change-Id: I0f4372d271f784d8b5d843da5590568cfd7f15da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4983705
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
eca38a10
|
2023-10-26T11:02:38
|
|
Vulkan: Supress new DrawNone VVL errors
Errors:
VUID-vkCmdDraw-None-09000
VUID-vkCmdDrawIndexed-None-09002
Bug: angleproject:8394
Change-Id: If43390e837df088ba7a6d0c7eb5947927ad186d1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4979786
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
3596ab4c
|
2023-10-26T10:11:17
|
|
Metal: Disable prebuilt shaders on iOS.
Chromium's Mac SDK is missing files needed to build for iOS:
LLVM ERROR: Error opening
'/Volumes/Work/s/w/ir/cache/xcode_ios_15a507.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/bin/../lib/clang/32023.35/lib/darwin/libmetal_rt_ios.a':
No such file or directory!
Bug: chromium:1385510
Change-Id: Iee7d6f477ffbebbbdca22e8377f244d2d13dfe66
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4980045
Reviewed-by: Roman Lavrov <romanl@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
3dbf8ebc
|
2023-10-26T07:00:28
|
|
Roll Chromium from fa8fa1dd7a5a to eeef412b7e3c (676 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/fa8fa1dd7a5a..eeef412b7e3c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,geofflang@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/fe6bf5df4c..b43af392a3
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/cd6bd50a8f..11e982b6f9
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/52c9bd6e91..e71c84911d
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a391ecbab7..16ed8d7d56
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/7a747fea27..27f2daf83f
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9d8a076f99..e0c9c85d41
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7b5e31698b..d8fb829b95
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/65ba847dc7..34b911efa9
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5a97631b41..573b2a1530
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/091cf42b92..f130da7870
No update to Clang.
Bug: None
Tbr: geofflang@google.com
Change-Id: Icda1e6e5df04589b6560b182bae937aaadeef957
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4977652
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
5dd0c842
|
2023-10-24T13:48:29
|
|
Vulkan: improve memory type mismatch issue.
for dynamic buffer usage, the memoryTypeIndex
returned from findMemoryTypeIndexForBufferInfo
not used. if we add more flags like
VK_MEMORY_PROPERTY_HOST_CACHED_BIT at alloction.
the actual memory type allocated may not have such flag.
Bug: b/306763053
Change-Id: I778e51fdd5ce0bc0810a965c45b5763a155fc391
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4973574
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Hailin Zhang <hailinzhang@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
fdf4c6a6
|
2023-10-24T12:09:51
|
|
Add test for attrib rebinding from ARRAY_BUFFER to client.
Failure was found in Dragonmania game, where on switching from
ARRAY_BUFFER to client attrib pointer without updating the stride,
ANGLE assumed no change in the pipeline.
Bug: b/306472834
Change-Id: I30f7a478ed62f4356317156b50558166cb7c4c01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4977168
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
43187a24
|
2023-10-25T09:43:56
|
|
Vulkan: remap YUV clearColor component from GL order to vulkan order
For EXT_YUV_TARGET, OpenGL and vulkan uses difefrent mapping between YUV
to RGB. OpenGL spec says "When clearing YUV Color Buffers, clear color
should be defined in yuv color space and so floating point r, g, and b
value will be mapped to corresponding y, u and v value and alpha channel
will be ignored.", but vulkan spec says "Values in the G, B, and R
channels of the color attachment will be written to the Y, CB, and CR
channels of the external format image, respectively.". This CL adjusts
clear color to remap the clear color from GL ordering to vulkan
ordering.
This CL also adds a temporary workaround for ARM driver bug where they
were looking at unused color attachment instead of resolve attachment.
Bug: b/223456677
Change-Id: I9800bffc18ccd9d77b4e86995161cdde06257e1f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4973355
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Commit-Queue: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
4f611a1f
|
2023-10-24T20:56:19
|
|
Vulkan: Remove RendererVk::collectAllocationGarbage
Instead of adding separate method overload `DestroyGarbage()` method.
This will avoid checking `mUse` and creating garbage list twice.
Bug: b/218891184
Change-Id: If56ffe72a639021b1fd37feb02ebb91f62ad0933
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4974318
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
729e19ac
|
2023-10-24T15:31:17
|
|
Remove essl3 extension requirement for ES3 texture parameters
The extensions are not clear about support for the swizzle parameters
with external textures. Other parameters are mentioned with specific
validation (which is handled in ValidateTexParameterBase). Simply
let the other validation handle these parameters and allow the
swizzle to be forwarded.
Bug: chromium:1493448
Change-Id: Ic34d4c124c5493fef796322b5237541e557fd7ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4973157
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
a9b01747
|
2023-10-25T10:49:56
|
|
Metal: Add fall back to from-source shader compilation
We can't compile Metal shaders at build time without the chromium
build directory and mac_sdk.gni. Add a graceful fallback to building
the shaders from source at runtime in this case.
Also detect the iOS simulator in gn and disable shader compilation.
We don't have all the Mac SDK files needed to build shaders for this
target yet.
Bug: chromium:1385510
Change-Id: Ibd1b36f9d97e7340a9742cba0c9c5f2221cd9a8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4974918
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
9e5f5188
|
2023-10-24T18:43:12
|
|
Reswizzle results of YUV sampling operations
Change-Id: Id6eee9e0d9e2b80d48c80f27bc8e670a5621d263
Test: ImageTestES3.* 24 -> 15 failures
Bug: b/223456677
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4970337
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
368ddf22
|
2023-10-25T07:24:50
|
|
Roll Chromium from cea2902c9c11 to fa8fa1dd7a5a (674 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/cea2902c9c11..fa8fa1dd7a5a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,geofflang@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/6a5969b1cd..fe6bf5df4c
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/75a40ee29d..cd6bd50a8f
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f10cb8b614..52c9bd6e91
* third_party/android_build_tools/lint: B5rMbDYcnLV5PkN2pDyWvPScXUdkhHvmiGa7UUkTTTkC..vdzlvQoq4o7IGjo9mhBtZIkfFZWpmjCZLIs9ISfB7KsC
* third_party/android_build_tools/manifest_merger: KmtRhZoOS6xQcRRnch2SSZWcioCEl8amdDO1hI5FvBoC..S3Uexmlj5xGKoVRHL8yIysS_cVsUrc3E3K_sq2hsCU0C
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/43582381dd..27ea34f94e
* third_party/kotlin_stdlib: QwS-YZL_N4g1SjI1Ngely1WPNxLh-kfYpFZhKaEXGawC..ZwEhbBOU3zJ8iFzea34zthR0d1a1LlfSPjfsblxKbSgC
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/58c1757391..7b5e31698b
* third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/11d9f3e055..7686b5d38c
* third_party/r8: EJBvY8okEtL8rBTKcVoAbusYIpZD8wRuqoo-LWfKz_EC..hCR0xJbBeRfCUH-G2O_dMQ2C7wY-BhWHhAdXP_yuG3MC
* third_party/siso: git_revision:c689f99bb4b9908073bd2f3fbd68f289d9e45a75..git_revision:6af7e19f74a94ee61f1ddabc0d23b8e3c0d02e98
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/70a44835ed..65ba847dc7
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/809cf55c67..5a97631b41
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ad5af24436..091cf42b92
No update to Clang.
Bug: None
Tbr: geofflang@google.com
Change-Id: I71cff2aa63bcfa8c1c64e3a99ca09cd71fd0d690
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4975111
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
f3af255c
|
2023-10-24T10:21:29
|
|
Update README.md with latest conformance version on Vulkan backend
Bug: b/254527832
Change-Id: Ia46cef9326a323773202e067a75f715f1336e485
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4972656
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
13776ac3
|
2023-10-24T11:10:25
|
|
Compile with optimize_max instead of default_optimization
Android builds default to aggressive optimization for size (-Oz) which
results in subpar performance in some spots.
AFAICT the effect of this change on cflags is:
-Oz -enable-ml-inliner=release
to
-O2
Note that -enable-ml-inliner=release has a more significant impact on
the binary size than -Oz/-O2:
With it: -Oz 5.7M, -O2 6.15M
Without it: -Oz: 6.3M, -O2 7.1M
So this change goes 5.7M -> 7.1M (+1.4M). That's in standalone ANGLE
builds. Unsure if Chrome builds might be different.
Skipping a few dEQP tests where this switch seems to uncover UB.
Bug: b/306391262
Bug: b/307584642
Change-Id: I44d0f3bcf25de0c36a4228895cad19ea38502cbf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4968419
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
562d4be3
|
2023-10-20T14:33:05
|
|
Clear pending program linking in Context::onDestroy
When destroying Context, ANGLE resets any internal state before
releasing allocated objects, such as Programs and Shaders. When
destroying a program, any pending program linking is resolved via
Program::resolveLink. This results in trying to access the Context state
that’s just been reset.
To work around this, we ensure there are no pending links before
resetting the Context state.
Bug: angleproject:8380
Change-Id: I599c7e5a82b0e6bf14df1263006e10d8a9cb0b38
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4957715
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
db38707a
|
2023-10-19T18:08:51
|
|
Metal: Compile mtllib at build time.
Reworks gen_mtl_internal_shaders.py to only generate the combined metal
source file, mtl_internal_shaders_autogen.metal.
metallibs are now compiled at build time using gn actions.
This allows the Chrome and WebKit build process to use the same code
for loading the builtin shaders even though they compile them in
different ways.
We now only build the mtllib for the OS we're currently building for.
Bug: chromium:1385510
Change-Id: Ie3b4f66c48a7e0eccd5fe664f988e407f452795c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4583134
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
c22f46b5
|
2023-10-23T11:52:20
|
|
Update rgb-565-no-depth-no-stencil test suite names
Replace the "-" with "_" in the test suite names
to be consistent with other test suite name formats.
Bug: b/297901032
Change-Id: Idbfc1bc7aa7cef4382e3cdd3e223db28f414f15e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4968792
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
6b578fbb
|
2023-10-24T07:00:50
|
|
Roll Chromium from a1990d9c6b75 to cea2902c9c11 (644 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/a1990d9c6b75..cea2902c9c11
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,geofflang@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/c77f325ee5..6a5969b1cd
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/81ea7a128c..75a40ee29d
* buildtools/linux64: git_revision:5d8727f3fbf420538ff753ebc3ce96da28e12c22..git_revision:e4702d7409069c4f12d45ea7b7f0890717ca3f4b
* buildtools/mac: git_revision:5d8727f3fbf420538ff753ebc3ce96da28e12c22..git_revision:e4702d7409069c4f12d45ea7b7f0890717ca3f4b
* buildtools/win: git_revision:5d8727f3fbf420538ff753ebc3ce96da28e12c22..git_revision:e4702d7409069c4f12d45ea7b7f0890717ca3f4b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/d2d128e54a..f10cb8b614
* third_party/android_build_tools/lint: pc8Rjasvrz6JiyrxRqWxH5pw4NDgilMvlYHCtCW6ABMC..B5rMbDYcnLV5PkN2pDyWvPScXUdkhHvmiGa7UUkTTTkC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/eb43f0d41e..9d8a076f99
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/10cd8e406d..43582381dd
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e1129faa9f..58c1757391
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/30bdb85e30..9b894306ec
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ceb8145f55..86aed39db2
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a50d91ce26..ad5af24436
No update to Clang.
Bug: None
Tbr: geofflang@google.com
Change-Id: I7691bd8b945c066fd99ceb75f5b6940636191ed8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4971062
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
65f6c2ea
|
2023-10-22T18:07:55
|
|
Metal: always implicitly resolve MSAA render buffers on tiled GPUs.
On tile based GPUs, implicitly resolving MSAA render buffers to
single-sampled is preferred. Because it would save bandwidth by avoiding
storing the MSAA textures to memory. Furthermore resolving as
StoreAction is almost a free operation on these GPUs.
Traditional desktop GPUs almost always store MSAA textures to memory
anyway, so this feature would have no benefit besides adding additional
resolve step as well as memory overhead of the hidden single-sampled
textures.
Bug: chromium:1486094
Change-Id: I5eb3b1314560024dd5c0834b0c0b43a6b4d3d51b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4962114
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
4b59e4c6
|
2023-10-17T17:47:20
|
|
Add a test to check glReadPixels format and type
In GLES 3.2 spec
https://registry.khronos.org/OpenGL/specs/es/3.2/es_spec_3.2.pdf,
section 16.1.2, it says the following glReadPixels type
and format should work:
The second is an implementation-chosen format from
those defined in table 8.2... The values of format and
type for this format may be determined by calling
GetIntegerv with the symbolic constants
IMPLEMENTATION_COLOR_READ_FORMAT and
IMPLEMENTATION_COLOR_READ_TYPE, respectively.
The implementation-chosen format may vary depending
on the format of the selected read buffer of the
currently bound read framebuffer.
Add a test to check that when reading from the default
framebuffer, using the format and type retrieved from
IMPLEMENTATION_COLOR_READ_FORMAT and
IMPLEMENTATION_COLOR_READ_TYPE works.
Bug: b/306256081
Change-Id: I1e94087aac8c803bcc5db3515ed56291349daf28
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4950844
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
e4a267e5
|
2023-10-20T16:10:50
|
|
Vulkan: Fix YUV external format resolve attachment load/storeOp
When YUV external format resolve attachment is used, and
nullColorAttachmentWithExternalFormatResolve is true, the loadOp and
storeOp are packed in color attachments.When we setup the resolve
attachment, we must use the color attachment information instead of
general resolve code path (where there is always a color attachment).
Without this fix, the resolve attachment is always uses loadOp=DontCare
which is wrong.
Bug: b/223456677
Change-Id: Ib41eb438aedbcd9a37c356540e81cdf7b9610a20
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4960502
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9298baa9
|
2023-10-20T10:26:00
|
|
Vulkan: Fix ImageTestES3.RenderToYUVAHB assertion
The bug here is that for YUV resolve, we always set mTransience to
YuvResolveTransient. And isImageTransient() returns true if mTransience
!= Default. And if image is transient, we will do unresolve, which is
incorrect here. For nullColorAttachmentWithExternalFormatResolve() case,
the image is actually not transient. This CL will only set transience to
YuvResolveTransient if we need to create a transient color attachment.
This CL looks at mImage->getExternalFormat() as the answer for
isYUVResolve instead of rely on transience.
Bug: b/223456677
Change-Id: I1bc176df22b0abc91d668a178e48d6b90eacbdd7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4959194
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
6188c0a6
|
2023-10-23T16:47:10
|
|
Unsuppress VUID-vkCmdEndDebugUtilsLabelEXT-commandBuffer-01912
VUID removed in
http://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/5941
Bug: chromium:1420265
Change-Id: I8e3b9462df5e250c97c6bff02635cd28fec2a4e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4967241
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
6258acae
|
2023-10-19T00:00:00
|
|
GL: Add resyncDepthRangeOnClipControl workaround
Some drivers do not apply GL_CLIP_ORIGIN_EXT and
GL_CLIP_DEPTH_MODE_EXT state changes until other
transformation states are updated.
As a workaround, force-resync the depth range on
clip control updates.
Fixed: angleproject:8381
Change-Id: I26f95108e9419be30ea0b562e02ab4bae78f65bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4966525
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
f0ee1379
|
2023-10-23T10:01:57
|
|
Roll SwiftShader from 041dc107d3f0 to d9ec9befba05 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/041dc107d3f0..d9ec9befba05
2023-10-20 cwallez@chromium.org Support version 7 of the ICD interface.
2023-10-20 lokokung@google.com Revert "Support version 7 of the ICD
interface."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC angle-team@google.com,geofflang@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: geofflang@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: I1e23624ad636c1e8d34259c0881ac21bdd1b4ba1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4965660
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
b713be00
|
2023-10-23T07:02:53
|
|
Roll Chromium from 360596b7b0ea to a1990d9c6b75 (762 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/360596b7b0ea..a1990d9c6b75
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/5a6832ffc9..c77f325ee5
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5660ea0c02..81ea7a128c
* buildtools/linux64: git_revision:182a6eb05d15cc76d2302f7928fdb4f645d52c53..git_revision:5d8727f3fbf420538ff753ebc3ce96da28e12c22
* buildtools/mac: git_revision:182a6eb05d15cc76d2302f7928fdb4f645d52c53..git_revision:5d8727f3fbf420538ff753ebc3ce96da28e12c22
* buildtools/win: git_revision:182a6eb05d15cc76d2302f7928fdb4f645d52c53..git_revision:5d8727f3fbf420538ff753ebc3ce96da28e12c22
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/afe2a681a3..d2d128e54a
* third_party/android_build_tools/manifest_merger: ua51TrPxAlFl4AAuxO7y183tshl5MBSNz8Gn3rWeITEC..KmtRhZoOS6xQcRRnch2SSZWcioCEl8amdDO1hI5FvBoC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1b8f00c217..eb43f0d41e
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ce4aac950f..10cd8e406d
* third_party/fuchsia-sdk/sdk: version:15.20231015.1.1..version:15.20231022.3.1
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6433a1d675..e1129faa9f
* third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/7a1763f1b2..5acf60c8b9
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/fef58692c1..dfc48fc4de
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/10fb66103f..70a44835ed
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/44e5a6ea78..a50d91ce26
No update to Clang.
Bug: None
Tbr: solti@google.com
Change-Id: I2b88da938168b13fb46e4a451bcd7e16636e9c2a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4963745
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
ec29008a
|
2023-10-19T00:00:00
|
|
GL: Fix extended dirty bits sync
* Use extendedBitMask when syncing
extended dirty bits to skip bits
ignored by the current operation.
* Use extendedBitMask for unsetting
backend-local extended dirty bits.
Fixed: angleproject:8382
Change-Id: I0bda18d801805b30d7cb071366353af05a44ab57
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4960055
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
5fa78e2b
|
2023-10-20T23:02:46
|
|
Manual roll vulkan-deps from 988136f495ab to 69081d0e32f7 (1 revision)
Manual roll requested by solti@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/988136f495ab..69081d0e32f7
Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b2be9536b5..cc1e12c6fc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Change-Id: I9ae79880318e7f50484842fefa1e9877963a766a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4960638
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Solti Ho <solti@google.com>
|
|
|
f0076e5e
|
2023-10-20T16:15:50
|
|
Manual roll vulkan-deps from e1bde48cccb2 to 988136f495ab (13 revisions)
Manual roll requested by solti@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/e1bde48cccb2..988136f495ab
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/ebb0a8b28e..7fa0731a80
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5084f58e5d..73876defc8
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/7b7d15bc9f..131a081e08
* vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/89b8b0df6d..dcfce25b43
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/3d144b1f9e..b2be9536b5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Change-Id: I9cc5b19439d84cc2062c75c8fe7fb58bfe7dab71
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4957792
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Solti Ho <solti@google.com>
|
|
ba65feb4
|
2023-10-18T17:33:38
|
|
Vulkan: Limit mutable texture flush to one update
In case there are many updates for a mutable texture, flushing
it preemptively can reduce performance, especially if it is done
repeatedly.
* Added getLevelUpdateCount() to ImageHelper.
* Previous mutable textures will now be flushed only if they have
exactly one update per mip level/cubemap face (if defined).
* This means that mutable textures with no data will also not be
flushed.
* Added unit tests for single-level texture flushing and situations
with no updates or more than one update.
Bug: b/285613719
Change-Id: I1592ecf502051a55ebfbb7fcd22577c9ce87bf43
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4953847
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
49fd8eda
|
2023-10-20T14:23:38
|
|
android_helper: improve _RemovePrefix logging
Random stuff gets in there sometimes, such as:
"cmd: Failure calling service package: Broken pipe (32)"
RemovePrefix just raises that it doesn't start with "package:" so the
issue doesn't show up in logs.
Bug: b/296921272
Change-Id: Ifae4e3c0c7717514401bf1109febf8e70fff6527
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4959473
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Roman Lavrov <romanl@google.com>
Auto-Submit: Roman Lavrov <romanl@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
0005183b
|
2023-10-19T18:21:40
|
|
Update reclient instructions with more detailed steps
Bug: angleproject:8379
Change-Id: I99c0af0f687e19c64583ca81186acd4e1cd65a74
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4956121
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
04f7e71e
|
2023-10-20T10:01:57
|
|
Roll SwiftShader from 91b84ac6d8ea to 041dc107d3f0 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/91b84ac6d8ea..041dc107d3f0
2023-10-19 cwallez@chromium.org Support version 7 of the ICD interface.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: Ia2065ea6dbda2e5bff9b3fd35b7df51b04b97cd2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4956295
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
ecfa7ac5
|
2023-10-20T07:01:18
|
|
Roll Chromium from 3ec80e7b561a to 360596b7b0ea (597 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/3ec80e7b561a..360596b7b0ea
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/d1c8d9f9cc..5a6832ffc9
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f2b9d057fb..5660ea0c02
* buildtools/reclient: re_client_version:0.116.1.9128bc4-gomaip..re_client_version:0.117.1.21520c6-gomaip
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/5d6668c8f2..afe2a681a3
* third_party/android_build_tools/lint: qOmRl_DUi0ABBlqEHTW3kw6DMtplzGdRr7td0USaw0IC..pc8Rjasvrz6JiyrxRqWxH5pw4NDgilMvlYHCtCW6ABMC
* third_party/android_build_tools/manifest_merger: f91o-aOAEitXaUBozBpROZfvZOxQOB9aqPJGduMwoNYC..ua51TrPxAlFl4AAuxO7y183tshl5MBSNz8Gn3rWeITEC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f496845cb9..1b8f00c217
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8f761f5795..ce4aac950f
* third_party/jdk: 0yjD6s5XYtcGAQoObIys7xs2ThkudwxJwS-2ZNP0SFEC..tUJrCBvDNDE9jFvgkuOwX8tU6oCWT8CtI2_JxpGlTJIC
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/8d4b8a60c2..6433a1d675
* third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/cbc5f2b0cd..7a1763f1b2
* third_party/r8: VYa4qKw_r1a1mfMoihb-HEf076o6wCzkBmi4mPjKrkQC..EJBvY8okEtL8rBTKcVoAbusYIpZD8wRuqoo-LWfKz_EC
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/4add1b5796..10fb66103f
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1e1a32112c..ceb8145f55
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/95e95168fd..809cf55c67
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5895957c49..44e5a6ea78
Clang version changed llvmorg-18-init-7785-geef35c28:llvmorg-18-init-8676-g11d07d9e
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/1e1a32112cd638ae0c43c39d2d88361ebd085ea8..ceb8145f558999832ded3df3232f49f1dec0bdfd/scripts/update.py
Bug: angleproject:7079
Tbr: solti@google.com
Change-Id: I221054b8d1f8d84e69d43c84f374241bb31a4266
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4957783
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
d2de7451
|
2023-10-19T14:10:44
|
|
Vulkan: Fix VK_android_external_format_resolve VVL error part 5
Fix assertion in RendererVk::getFormatFeatureBits(). When formatID is
external format, we can not use vkGetPhysicalDeviceFormatProperties to
get the formatFeature (since VkFormat is undefined). To fix this, we
keep the formatFetaure that returned from AHB in the
ExternalYuvFormatInfo and use that in getFormatFeatureBits() if it is
external format.
This also fixes the VVL error VUID-VkImageCreateInfo-pNext-02396: The
Vulkan spec states: If the pNext chain includes a
VkExternalFormatANDROID structure whose externalFormat member is not 0,
flags must not include VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT
Bug: b/223456677
Change-Id: I625c2bf4fe534fa206918b16772ac3ac7c6fa79a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4956117
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
d3319428
|
2023-10-19T15:15:24
|
|
Update DevSetup doc with Reclient instructions
As Goma is deprecated and Reclient is used as a replacement,
we need to update the DevSetup readme with the reclient
instructions.
Bug: angleproject:8379
Change-Id: Ia54caf89194aac729a41190abf488b43eb7dace8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4956118
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
80e2d8d7
|
2023-10-19T13:53:32
|
|
Vulkan: Update PipelineProgram if mStreamingVertexAttribsMask dirty
When mStreamingVertexAttribsMask bit chnages, we are going to switch
between a internal buffer and user's buffer. We must update graphics
pipeline program, even if bufferOnly is true.
Bug: b/303219048
Change-Id: I0536cb7bcd6ed8f1de39aaea5bd6cd6eef61c5e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4957193
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
679fe65d
|
2023-10-19T13:59:52
|
|
Attempt to fix FixedQueue.ConcurrentPushPopWithResize flakiness
If dequeueThread has finished while the enqueue thread is sleeping,
queue might still be full once enqueueThread wakes up. In this case,
push call will hit assertion since queue is full. This CL makes the
enqueueThread bail out if dequeueThread already finished.
Bug: chromium:1493831
Change-Id: I9e3ad957c5d2eb15c5b409bb818c03dc807f3518
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4957194
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
c153d4a5
|
2023-10-18T18:12:19
|
|
Set isYUV to true for "EXTERNAL" formats
These external formats are all YUVs so far. It is more correct to set
isYUV to true than set to false.
Bug: b/223456677
Change-Id: Ib9eb937754f4c085fbcc6768bb7a93d3c28317c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4953919
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
464dbb61
|
2023-10-18T17:49:14
|
|
Vulkan: Fix VK_android_external_format_resolve VVL error part 4
VUID-VkWriteDescriptorSet-descriptorType-01946: The Vulkan spec states:
If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, then the
imageView member of each pImageInfo element must have been created
without a VkSamplerYcbcrConversionInfo structure in its pNext chain. The
bug here is that right now these angle::Format::External{n} returns
isYUV false. This CL changes the check of isYUV to
getYcbcrConversionDesc().valid().
Bug: b/223456677
Change-Id: Ifc97f738972a24c4e5dec3e37d8d5896efa9fe80
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4953917
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
4d7fc442
|
2023-10-18T12:49:06
|
|
Vulkan: Fix VK_android_external_format_resolve VVL error part 3
VUID-VkRenderPassAttachmentBeginInfo-pAttachments-parameter: The Vulkan
spec states: If attachmentCount is not 0, pAttachments must be a valid
pointer to an array of attachmentCount valid VkImageView handles. The
bug here is that when nullColorAttachmentWithExternalFormatResolve is
true, there is no color attachment, but the RenderPassDesc still appears
having a color attachment because we need to store the formatID in it.
This CL changes to use mFramebuffer.getImageViews().size() instead of
mRenderPassDesc.attachmentCount() which is more correct anyway.
Bug: b/223456677
Change-Id: I0f0947f0c642bac9cd18a80525b92c62ef0723ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4952969
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
|
|
|
fce367c9
|
2023-10-18T11:36:59
|
|
Vulkan: Fix VK_android_external_format_resolve VVL error part 2
VUID-VkFramebufferCreateInfo-flags-03201 The Vulkan spec states: If
flags includes VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT, the usage member of
any element of the pAttachmentImageInfos member of a
VkFramebufferAttachmentsCreateInfo structure included in the pNext chain
that refers to an attachment used as a color attachment or resolve
attachment by renderPass must include
VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT. The bug here is that when we create
VkImage for AHB for rendering, we specify mUsage as Sample. This CL adds
COLOR_ATTACHMENT if it supports resolve.
This CL also adds VkAndroidHardwareBufferFormatProperties2ANDROID format
query for debug logging.
VUID-VkImageViewCreateInfo-usage-08931 is temporary added to skip list
due to ARM driver bug. The bufferFormatProperties returned does include
VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT. Will remove once driver is
fixed.
Bug: b/223456677
Change-Id: Ibccf5f19975654fd94b00ae10e15ac986f7866dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4952962
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
4da231bb
|
2023-10-18T22:56:57
|
|
Manual roll vulkan-deps from 92b29883afea to e1bde48cccb2 (45 revisions)
Manual roll requested by solti@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/92b29883afea..e1bde48cccb2
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/be564292f0..ebb0a8b28e
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/105d5a8a79..2de1265fca
* spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/4183b260f4..88bc5e321c
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/661f429b11..5084f58e5d
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/7b3466a1f4..f4bfcd8852
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/bef51c9184..7b7d15bc9f
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1532001f7e..f7017f2333
* vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/c9ca4ac620..89b8b0df6d
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/deb215c083..3d144b1f9e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Change-Id: I1f13ef03ef524a6113190b2fef67f150691f155f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4953842
Commit-Queue: Solti Ho <solti@google.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
aef9a1b3
|
2023-10-19T07:00:30
|
|
Roll Chromium from 42123e8b7a7b to 3ec80e7b561a (623 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/42123e8b7a7b..3ec80e7b561a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/cc1dedc3ff..d1c8d9f9cc
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/7bbf5da816..f2b9d057fb
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/ba6866fdda..5d6668c8f2
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ae615e1309..a391ecbab7
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f3c2ddc906..7a747fea27
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b9ebaddcd0..f496845cb9
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/406be8281e..8f761f5795
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2f6750b44b..8d4b8a60c2
* third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/db9800c042..cbc5f2b0cd
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/22e1594188..1e1a32112c
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b727ef5215..5895957c49
No update to Clang.
Bug: None
Tbr: solti@google.com
Change-Id: I2504e7fec78900fb16e9ebee33bb407f7e88609b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4954693
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
889b01ef
|
2023-10-17T12:13:10
|
|
Vulkan: Fix VK_android_external_format_resolve VVL error part 1
VUID-VkSubpassDescription2-nullColorAttachmentWithExternalFormatResolve-09337:
The Vulkan spec states: If the
nullColorAttachmentWithExternalFormatResolve property is VK_TRUE and
pResolveAttachments is not NULL, for each resolve attachment that has a
format of VK_FORMAT_UNDEFINED, the corresponding color attachment must
have the value VK_ATTACHMENT_UNUSED
VUID-VkFramebufferCreateInfo-attachmentCount-00876 The Vulkan spec
states: attachmentCount must be equal to the attachment count specified
in renderPass
Fix assertion in FramebufferVk::getFramebuffer()
Bug: b/223456677
Change-Id: I538a44753a2ba9b432fa3b1814748942cd8a3500
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4948652
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
05c5cef0
|
2023-10-17T21:16:52
|
|
Manual roll vulkan-deps from 68a0a794aa0a to 92b29883afea (1 revision)
Manual roll requested by solti@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/68a0a794aa0a..92b29883afea
Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7ef2b9a6bb..deb215c083
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: b/306178740
Tbr: solti@google.com
Change-Id: I1060b8e021e28e70ca11305dc60a8fa8462e1eff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4950550
Commit-Queue: Solti Ho <solti@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
f56f9700
|
2023-10-18T10:01:18
|
|
Roll SwiftShader from 400ac3a175a6 to 91b84ac6d8ea (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/400ac3a175a6..91b84ac6d8ea
2023-10-17 cwallez@chromium.org Fix -Wunused-but-set-variable and
-Wdeprecated-copy
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: I65f8f57926948ce82587f15f3a34437efa9da966
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4951628
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
1fd8f00c
|
2023-10-18T08:51:21
|
|
Roll Chromium from 2de615858387 to 42123e8b7a7b (1339 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/2de615858387..42123e8b7a7b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/4b5f6bf263..cc1dedc3ff
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2c4320e24b..7bbf5da816
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/0139d87517..ba6866fdda
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/3357d1060e..f3c2ddc906
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c0b8fc61c7..b9ebaddcd0
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/73b69b0167..406be8281e
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0a31206d8a..2f6750b44b
* third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/7b1593d5ca..11d9f3e055
* third_party/turbine: hgwj3KajqJCdACBdNiRoYQZhZw2NhHu0-pwuAp3S-LcC..VRQ9UNP0lvjDXJ4DhORCj66go0TLg5uuGnHWkNN_hgUC
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/50bbf6205e..4add1b5796
* tools/luci-go: git_revision:589d8654cfa7808816a6ecb4284ed2fd72c2f6d5..git_revision:924cfd2323a9192361b765f81fffc135026c1fee
* tools/luci-go: git_revision:589d8654cfa7808816a6ecb4284ed2fd72c2f6d5..git_revision:924cfd2323a9192361b765f81fffc135026c1fee
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7adb2360db..95e95168fd
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/8b06a53701..bb03b82053
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/88edb4121f..b727ef5215
* tools/skia_goldctl/linux: yRR4wNw_p_PCRQQVZO5Y4UKfDQ0AqBIKbfj97QVbiIcC..6ZbzGODKMcpBpaQGevv9HDYFq1MySuazksPjASy3whYC
* tools/skia_goldctl/mac_amd64: 1SHcSqKCFlDIwzDTHUyQqql_3FxCOIdJmgUMpdXJHssC..5C8IlKD_v-3TyIt2ABjbZe9tOjuSobu7mdbbqWb2nrkC
* tools/skia_goldctl/mac_arm64: 26EXZ4e5kuFt-BT9YOQKl6ZE6fkCcjVqF8sBdp5FWiIC..6MIhSSiQhqNv7wsqsRsByAXXlbN8mjYNv7ww0laA6I4C
* tools/skia_goldctl/win: wSL6CZdkxlrYe9Uuw6OIWVysK5_6_RYkQmAE83aVbW8C..vXil0StnMljEIoOtmXbb7HFvcI6HMgbv54IWOVuoBaEC
No update to Clang.
Bug: None
Tbr: solti@google.com
Change-Id: I4e658a06a1c0aa56f745e50f9fdb62b93f6afa63
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4952293
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
384a29a8
|
2023-07-27T10:51:07
|
|
Reland: GL: Remove EGL_EXTERNAL_CONTEXT_SAVE_STATE_ANGLE
Now that Chromium no longer uses it.
This is a reland of:
https://chromium-review.googlesource.com/c/angle/angle/+/4724768
Bug: angleproject:5509
Change-Id: I650e598580539fbe404f2ec4b56b20b56b948f6c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4903079
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
cfc40d2b
|
2023-07-19T17:47:13
|
|
Vulkan: Adjust clear color precision for GL_RGB5_A1 FBO
When clear color has more precision than the framebuffer
format can hold, dithering is automatically applied on
some hardware.
This issue causes below dEQP tests to fail when the FBO
color attachment format is RGB5_A1:
KHR-GLES31.core.draw_buffers_indexed.color_masks
KHR-GLES32.core.draw_buffers_indexed.color_masks
Adjust the clear color precision for RGB5_A1 format to
workaround the issue.
We can remove this workaround once the vulkan driver
fixes the auto-dithering problem.
Bug: b/292282210
Change-Id: Ic3ffebd2d20c8782612619a60d1ec2cc6d613c22
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4937472
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
36439d9c
|
2023-10-12T00:00:00
|
|
Metal: Fix PBO uploads of PVRTC1 textures
Do not override row pitch values for PVRTC1
textures during internal backend operations.
Instead, set bytesPerRow to 0 before calling
replaceRegion just to pass Metal Validation.
Enforce CPU path for PBO uploads until
GPU block linearization is implemented.
Bug: angleproject:8376
Change-Id: I80b9ec69364d55cd9f51005f4d1a180e05e71c2c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4949350
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
ba321f33
|
2023-10-17T19:05:08
|
|
Manual roll vulkan-deps from 5c0370a84db5 to 68a0a794aa0a (1 revision)
Manual roll requested by solti@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/5c0370a84db5..68a0a794aa0a
Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/27a95faea3..7ef2b9a6bb
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Change-Id: Ia94d4893c36b9a22f90b31fda2f9ec1f6525fab0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4949391
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Solti Ho <solti@google.com>
|
|
|
cc61dded
|
2023-10-17T13:21:14
|
|
Vulkan: Remove fixed VU suppressions
Bug: angleproject:2866
Bug: angleproject:4928
Bug: angleproject:5027
Bug: angleproject:7843
Bug: angleproject:8076
Bug: b/175584609
Change-Id: I1a3ccdc92be73874e7599961bae2a0e8c7497b1a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4947653
Commit-Queue: Charlie Lao <cclao@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
0be59b3d
|
2023-10-17T17:31:05
|
|
Vulkan: disable warmUpPipelineCacheAtLink for Venus
The same cache miss is seen on MESA ANV and MESA RADV drivers. Together
with already disabled ARM drivers, we'd disable for Venus as a whole for
monolithic pipelines. This won't affect later Venus GPL enablement on
supported host drivers like ANV and RADV.
Bug: b/299532942
Test: affected title is semi-playable
Change-Id: Iaec0d43b15b64b6b74dfa68021f8a5f2fe6cca8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4948694
Commit-Queue: Yiwei Zhang <zzyiwei@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
3b28bca0
|
2023-10-11T09:49:54
|
|
Allow using RGBA IOSurfaces with GL_RGBA format for EAGL backend
As https://crrev.com/c/4877334 switched RGBA IOSurfaces to GL_RGBA
to work with ANGLE/Metal, some tests(e.g. web tests) on iOS failed
to create an IOSurface because ANGLE'S EGL backend still still
binds IOSurfaces as GL_BGRA_EXT even though we expect the IOSurface
to really be RGBA. To fix it, this CL allows using RGBA IOSurfaces
with GL_RGBA format by adding a GL_RGBA entry to kIOSurfaceFormats.
See also the comment[1] for better explanation.
[1] https://crrev.com/c/4918590/comments/1e44e971_50c3d780
Bug: chromium:1489586
Change-Id: Ifa215318401edb892fd5527c35c7d30871e82a83
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4930309
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
e076d6cf
|
2023-10-17T11:39:10
|
|
Move invalid uniform protection to the frontend.
The frontend potentialy indexes into mUniformLocations with invalid
uniform locations while validation is disabled too. Move the validation
from the Metal backend to the frontend.
Bug: chromium:1484878
Change-Id: I92bc43aa28cfa26d601bb28f318860375f618608
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4947652
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8440268a
|
2023-10-17T14:34:40
|
|
Manual roll vulkan-deps from 2545e7b92202 to 5c0370a84db5 (3 revisions)
Manual roll requested by solti@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/2545e7b92202..5c0370a84db5
Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c41f2193be..27a95faea3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Change-Id: Ie3c26dc83c86fc8768a574aae49deefed848e77f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4947850
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Solti Ho <solti@google.com>
|
|
|
2e11fcc5
|
2023-10-16T16:40:35
|
|
Vulkan: Fix assertion when YUV image attached to resolve attachment
When YUV image attached to resolve attachment, mSamples is 1. Righ now
the code assumes resolve is a MSRT attachment, so it asserts mSamples>1.
This CL adds a new API packYUVResolveAttachment so that we can assert
properly for YUV and MSRT.
Bug: b/223456677
Change-Id: Ib65fd3fe1e6561b85395cc27204bbd85c1f464c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4942907
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
58ffa778
|
2023-10-11T09:41:23
|
|
Vulkan: Implement YUV_TARGET use VK_ANDROID_external_format_resolve
This implements EXT_YUV_TARGET using VK_ANDROID_external_format_resolve
extension.
This CL is based on Chris Forbes's CL on android gerrit.
Bug: b/223456677
Change-Id: Ieb6970a0787b0c2a72a76b208695a678d2c79e80
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4857459
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
1ea49a22
|
2023-10-13T11:28:41
|
|
Move uniform dirty bits to ProgramExecutable
Rather than try to funnel them through Program and ProgramPipeline to
the executable in the backend, just move them to ProgramExecutable in
the front end.
This fixes Dota Underlords at the same time due to not needing to set
the Program dirty to propagate bits.
Test: Dota Underlords
Test: ProgramPipelineTest31.ProgramPipelineBindBufferRange
Bug: b/299532942
Change-Id: Ic73c45608e22f89ca400ebf684f8cd287ed2f43a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4922969
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
fee512d9
|
2023-10-11T18:22:13
|
|
Vulkan: Add mapping between FormatID and externalFormat
This CL adds support to query the external format from AHB and convert
that to one of angle::FormatID::EXTERNALn. Then at the time to create
renderPass, we convert that angle::FormatID::EXTERNALn back to actual
vendor specific external format that returned from vulkan driver. With
this, the rest of angle code should not need to worry about actual
vulkan external formats.
This CL is based on Chris Forbes's CL on android gerrit.
Bug: b/223456677
Change-Id: I6d8150741bc590809a9962c1a11a6026f1ebbb74
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4932361
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
2450b59e
|
2023-10-16T15:23:48
|
|
Vulkan: Attempt to fix the perf/mem regression of previous CL
We should get the size before destroy garbage. Otherwise the size
returned likely is "garbage". The accounting may affect other logic and
cause memory and perf regression.
Bug: b/305752495
Bug: b/305791801
Change-Id: If89bc95c11f43ff3da61fdab3ae961c0211ca92a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4943169
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
57fcee54
|
2023-10-11T14:48:53
|
|
Vulkan: Add feature flag for externalFormatResolve
This CL adds supportsExternalFormatResolve feature flag and enable the
vulkan extension if existed.
This CL is split from Chris Forbes's CL on android gerrit.
Bug: b/223456677
Change-Id: I731f35dc629c12c7290c6ed24ff54967e2e4eab7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4932592
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
|
|
|
3870655e
|
2023-10-10T17:04:04
|
|
Vulkan: Add 8 external format ID for external_format_resolve
For external formats ANGLE does not know the exact that is. The idea is
we reserve 8 external format ID for these driver defined formats. Each
ID represents one uniquely defined external format. Then we will use
this format ID pass around ANGLE just like any other format ID.
Eventually vulkan backend will convert this formatID to the actual
external format structure that returned from driver. Right now we
reserved 8 IDs for this usage. Based on our survey, this is more than
enough for now. We will deal with it if we need more than 8 in future.
This CL is split from Chris Forbes's CL on android gerrit.
Bug: b/223456677
Change-Id: I9cf442179af95e04a44796125e0c03dde702a8f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4929749
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
493ca47c
|
2023-10-13T23:22:34
|
|
Vulkan: remove unused image view creation
remove unused image view creation.
Bug: b/303708135
Change-Id: I5e20788a6f3e042db04d739144236c065c407209
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4940252
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Hailin Zhang <hailinzhang@google.com>
|
|
|
5dd92c2f
|
2023-10-16T18:32:48
|
|
Manual roll vulkan-deps from a1a3d457683c to 2545e7b92202 (5 revisions)
Manual roll requested by solti@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/a1a3d457683c..2545e7b92202
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/0504953b35..be564292f0
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/724433d729..105d5a8a79
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/730552e670..1532001f7e
* vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/8d75da5254..c9ca4ac620
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5a751534aa..c41f2193be
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Change-Id: Ib1ffd08d5d35f00fcf23ab676a4dfcba354f983a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4943396
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
dc8c053e
|
2023-10-12T00:00:00
|
|
Split row and depth pitch computation for compressed formats
Besides doing extra operations, computeCompressedImageSize
cannot be used for computing pitch values for formats that
have minimum block layout requirements, such as PVRTC1.
Fixed: angleproject:8375
Change-Id: Id276e8cf723f0bb99b6f4a9b20d6d84e4840f6d7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4935568
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
df477358
|
2023-10-16T17:36:51
|
|
Manual roll vulkan-deps from f719b699697b to a1a3d457683c (10 revisions)
Manual roll requested by solti@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/f719b699697b..a1a3d457683c
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/48f9ed8b08..0504953b35
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/07ff4233bc..7b3466a1f4
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/5402dd2663..bef51c9184
* vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/ca0ad57987..8d75da5254
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/38891e233b..5a751534aa
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Change-Id: I11699a0293ca314ef95a10499f3fd36358120595
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4940580
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Solti Ho <solti@google.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
3892ac14
|
2023-10-12T13:35:33
|
|
Do not flush normal float constants to zero.
It's ok to flush denormalized constants to zero.
It's not ok to flush perfectly valid normal float constants >= FLT_MIN
to zero.
Two problems:
1) Values when parsed as doubles with a value less than FLT_MIN are
being flushed to zero. This is incorrect when the comparison is done
in double, since some values below FLT_MIN in double are equal to
FLT_MIN when cast to float. The fix is to perform the comparison in
float.
2) Values with a decimal exponent less than FLT_MIN_10_EXP are being
flushed to zero. FLT_MIN_10_EXP is -37 but FLT_MIN is 1.1754943E-38.
10^-37 may be the "minimum negative integer such that 10 raised to
that power is a normalized float", but being constrained to powers of
ten it's above FLT_MIN (which is 2^-126). Since this comparison is
done before #1 above, it's only present (AFAIK) to ensure that the
exponent will not make the pow() function overflow. Comparing against
-38 (FLT_MIN_10_EXP - 1) instead will do the trick.
Bug: angleproject:8373, dawn:2077
Change-Id: I1ddf410c2caa9f0d1ba3529ace693dcd326a2cb3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4936714
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
|
|
|
c54c2f81
|
2023-10-12T00:00:00
|
|
Sync border color on format updates
When a texture is redefined, its border color should
be resynced because of format-specific adjustments.
Used memcmp for comparing ColorGeneric structs.
Bug: angleproject:7969
Change-Id: If0e3e0bc7761c26dab6d00ab24462c789f5b90bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4935866
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
992a983e
|
2023-10-16T07:01:30
|
|
Roll Chromium from 345cb7cebed5 to 2de615858387 (749 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/345cb7cebed5..2de615858387
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/306e127bca..4b5f6bf263
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d43434c2b2..2c4320e24b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/537cca4a56..0139d87517
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/a4060bfb8b..c0b8fc61c7
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c51829968b..73b69b0167
* third_party/fuchsia-sdk/sdk: version:15.20231007.2.1..version:15.20231015.1.1
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/bbce3ebce8..0a31206d8a
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/74cec08d24..50bbf6205e
No update to Clang.
Bug: None
Tbr: yuxinhu@google.com
Change-Id: Ia4224ac96cedf4d6b049d7adfdaf94598a9986da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4940063
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
cd6b265c
|
2023-10-14T05:41:49
|
|
Roll VK-GL-CTS from 7a1ab4d3eb20 to 7d738783bf28 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7a1ab4d3eb20..7d738783bf28
2023-10-13 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9
into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I78bd349d5a061c90d768f7ac8c3ed797d4e89a17
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4940251
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
6154bd93
|
2023-10-12T15:27:44
|
|
Remove binding from DescriptorInfoDesc.
The issue with hitting the cache falsely is no longer reproduced
(tests added in https://crrev.com/c/4104121)
Charlie had changed the cache so mWriteDescriptors are no longer part of
this class, so some of those changes might have affected that.
Also mDescriptorInfos was previously a map and now is a vector, which
imposes a specific ordering - and that might be taking care of the
sampler swap hitting the cache falsely.
Charlie suggested that https://crrev.com/c/4581881 might have
taken care of this as textureUnit was used instead of bindingIndex:
https://chromium-review.googlesource.com/c/angle/angle/+/4936096/comment/ad2c0aa0_441bd33d/
Bug: angleproject:7974
Change-Id: I58391790a4362313c07c7bd28ed6f38f30720781
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4936096
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
21ea0a3c
|
2023-10-13T11:33:31
|
|
Add gzip tests when hitting a decompression error
Might give some hints about what got broken
Bug: angleproject:8307
Change-Id: I0a5aa05ed0e876ea060c1b8db6e61a79cbf9c4f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4937222
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
93781cd3
|
2023-10-13T15:34:40
|
|
Roll VK-GL-CTS from f2434516dcf5 to 7a1ab4d3eb20 (8 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/f2434516dcf5..7a1ab4d3eb20
2023-10-13 rgarcia@igalia.com Test compute invocation stats on compute
queues
2023-10-13 ziga@lunarg.com Add host image copy tests with non zero bind
image offset
2023-10-13 javed@igalia.com Add coverage for gl_Layer read in frag
shader with no previous write.
2023-10-13 hauxwell@broadcom.com Fix threads library compilation against
musl c library
2023-10-13 michal.jakubek@mobica.com Cover of instance and device
extension duplicates tests.
2023-10-13 gleese@broadcom.com Remove tcu::NodeType from vulkancts
2023-10-13 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7
into vk-gl-cts/main
2023-10-13 alexander.galazin@imgtec.com Notice of withdrawal of Vulkan
CTS 1.3.4.x
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I271095fc277dffa02efdb406b2c24c67478cf718
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4939034
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
76608554
|
2023-10-02T15:07:45
|
|
Vulkan: use cpu transcoding for small texture size.
Bug: b/250042517
Change-Id: I9a70fb7d4823d10b09f498bfc01b5384951e2ce4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4908660
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Hailin Zhang <hailinzhang@google.com>
|
|
|
1988108e
|
2023-10-12T00:00:00
|
|
Tighten draw buffers validation for dual-source blending
Use the front-end DRAW_BUFFER* state instead of the
internal mask, which is unset for missing attachments.
Bug: angleproject:1085
Bug: angleproject:7177
Change-Id: I5311d1f26043f15035e51957920bf9cd553c3007
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4935858
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b870956e
|
2023-10-05T00:00:00
|
|
GL: Limit depth/stencil texture mode updates
The DEPTH_STENCIL_TEXTURE_MODE state must affect only
DEPTH_STENCIL textures (OpenGL ES 3.2, Section 8.16).
Some drivers do not follow this rule and exhibit various
side effects when this mode is set to STENCIL_INDEX for
textures of other formats.
Bug: angleproject:2373
Change-Id: I20a8168d858cf070762ff0b3b7111cdf30e8166d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4936374
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
ad1cc5bf
|
2023-10-13T11:00:55
|
|
Roll vulkan-deps from 37653f7c343e to f719b699697b (12 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/37653f7c343e..f719b699697b
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/277d09e679..48f9ed8b08
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/bbe0f575eb..07ff4233bc
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0c4bd8cd37..5402dd2663
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/92bf3cac80..730552e670
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/946b9715ee..38891e233b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I0156497804e5baf5b6e32e23e17d0ea0be06ad34
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4938850
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
481f381d
|
2023-10-13T08:21:21
|
|
Roll Chromium from 137cc90d5084 to 345cb7cebed5 (603 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/137cc90d5084..345cb7cebed5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/1de43c2610..306e127bca
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/67cee5ecfd..d43434c2b2
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f2e75e7986..537cca4a56
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/897e3d48d8..a4060bfb8b
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/69e597f8e5..c51829968b
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e07dcc1eaa..bbce3ebce8
* third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/9ebf30f2a4..7b1593d5ca
* third_party/r8: tr-hYTpA4Gomi1_TTF1Hvbc0Rwy8guQ4OMLc90Gw0uQC..VYa4qKw_r1a1mfMoihb-HEf076o6wCzkBmi4mPjKrkQC
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b4f0262c93..74cec08d24
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/345ee65632..7adb2360db
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ce0c1dfb9e..88edb4121f
No update to Clang.
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I9b1f6376dc3cdac855c5eb5e8eeed68f50d5c600
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4937629
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
5b7763f9
|
2023-10-12T10:59:59
|
|
Fix tsan failure of test FixedQueue.ConcurrentPushPopWithResize
Test is accessing q.capacity() without mutex lock protection while
modifying it in another thread. The fix here is to have the enqueue
thread and dequeue thread always take its own lock and before we call
updateCapacity, we take both lock.
Bug: chromium:1491867
Change-Id: Ie0b844d5ee8df94c2f1c06263dddd434d1258121
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4936334
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
10d4d0ae
|
2023-10-12T17:48:44
|
|
Revert "Fix tsan failure of test FixedQueue.ConcurrentPushPopWithResize"
This reverts commit 24dabdbbeee213d7a1fd01a70cddacc1949d3b26.
Reason for revert: This did not completely fix the bug. q.full() still accessing mMaxSize.
Original change's description:
> Fix tsan failure of test FixedQueue.ConcurrentPushPopWithResize
>
> Test is accessing q.capacity() without mutex lock protection while
> modifying it in another thread. The fix here is to let test keep its own
> record of queue's capacity so that we dont need to get that from queue.
>
> Bug: chromium:1491867
> Change-Id: Ie0438ed1f4525bc4021e43098b24cd37bee3ce97
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4932359
> Commit-Queue: Charlie Lao <cclao@google.com>
> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Bug: chromium:1491867
Change-Id: I0332399043b369c96d64ae0b944c21e3b6507fea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4935640
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
3938a005
|
2023-10-12T10:01:40
|
|
Roll vulkan-deps from 1d5140e06b47 to 37653f7c343e (17 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/1d5140e06b47..37653f7c343e
Changed dependencies:
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/79401259fd..724433d729
* spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/e867c06631..4183b260f4
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/74005dfa67..661f429b11
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/6b36b69a7e..0c4bd8cd37
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/d6a6498781..92bf3cac80
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bb7b6f1526..946b9715ee
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I000bf09bbc5be3c2e62f8c209b6d588df7805426
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4932895
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
e4e499b7
|
2023-10-12T07:01:50
|
|
Roll Chromium from f9691c6faf3c to 137cc90d5084 (563 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/f9691c6faf3c..137cc90d5084
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/2dccc3874f..1de43c2610
* buildtools/linux64: git_revision:991530ce394efb58fcd848195469022fa17ae126..git_revision:182a6eb05d15cc76d2302f7928fdb4f645d52c53
* buildtools/mac: git_revision:991530ce394efb58fcd848195469022fa17ae126..git_revision:182a6eb05d15cc76d2302f7928fdb4f645d52c53
* buildtools/win: git_revision:991530ce394efb58fcd848195469022fa17ae126..git_revision:182a6eb05d15cc76d2302f7928fdb4f645d52c53
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3d87dab413..f2e75e7986
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/88f60e4dc3..ae615e1309
* third_party/android_build_tools/bundletool: 2RPwohwtc6on0_96oFxokeEvnC1LbLrGuyCAw00k62AC..xOeKyLIaK_RRHU0Qv0EdxTrRlq_22HAwoOr1xn5yoOcC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/30e34f3dc1..897e3d48d8
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aabd869daf..69e597f8e5
* third_party/kotlin_stdlib: as5vlzFVMpLTCQXVJqs-kifMAEQmjK_fImDy09zQB8AC..QwS-YZL_N4g1SjI1Ngely1WPNxLh-kfYpFZhKaEXGawC
* third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/2ce7927479..9ebf30f2a4
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/40dc9a464b..ce0c1dfb9e
No update to Clang.
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I81aef552a212edbdafdce39e308bc46eabfca1a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4932602
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
24dabdbb
|
2023-10-11T14:09:10
|
|
Fix tsan failure of test FixedQueue.ConcurrentPushPopWithResize
Test is accessing q.capacity() without mutex lock protection while
modifying it in another thread. The fix here is to let test keep its own
record of queue's capacity so that we dont need to get that from queue.
Bug: chromium:1491867
Change-Id: Ie0438ed1f4525bc4021e43098b24cd37bee3ce97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4932359
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
90dd58a2
|
2023-10-04T11:54:22
|
|
Vulkan: Reduce mGarbageMutex lock contention
Right now mGarbageMutex is used to control access to mSharedGarbage,
mPendingSubmissionGarbage, mSuballocationGarbage,
mPendingSubmissionSuballocationGarbage and mOrphanedBufferBlocks. Some
times garbage clean up does take a bit longer time, especially on some
VM platforms. This some times causes lock contention between main render
thread and background garbage clean up thread, which defeats the benefit
of having garbage clean up in the background thread. This CL utilizes
angle::FixedQueue for garbage list so that enqueue and dequeue can be
concurrent, which avoids this lock contention.
Bug: b/302739073
Change-Id: I44b2b0e7f9f5ef438266fa277b24a2cb1606e689
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4899299
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Hailin Zhang <hailinzhang@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
2608c622
|
2023-10-06T13:32:49
|
|
Vulkan: Refactor SharedGarbageList into templated class
This CL mostly involves non-functional changes to prepare for next CL.
No behavior change is expected.
This CL wraps the garbage list into its own templated class which
maintains std::queue and tracks number bytes in the queue etc.
This CL also renames SharedBufferSuballocationGarbageList to
BufferSuballocationGarbageList to reduce verbosity a bit.
This CL deleted GarbageAndQueueSerial and GarbageQueue since they are no
longer being used.
This renames vk::GarbageList to vk::GarbageObjects to reduce name
confusion with SharedGarbageList.
Bug: b/302739073
Change-Id: I7370c147847ffe69ad8aa3b48251d8b5762f97f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4919816
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Hailin Zhang <hailinzhang@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
7f3af6d2
|
2023-10-11T10:01:15
|
|
Roll vulkan-deps from be2755d4d109 to 1d5140e06b47 (13 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/be2755d4d109..1d5140e06b47
Changed dependencies:
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/37fee00a71..79401259fd
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/933db564ca..74005dfa67
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/d728191673..6b36b69a7e
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/31b95ce237..d6a6498781
* vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/9e088360b5..ca0ad57987
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/84a7db4f82..bb7b6f1526
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I7f85097f3fcbc877b83c5a1f91f9cf25a81f72ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4929761
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
0935ab3f
|
2023-10-11T08:02:28
|
|
Roll Chromium from 2f77720808c4 to f9691c6faf3c (638 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/2f77720808c4..f9691c6faf3c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/5f1ddffe0a..2dccc3874f
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/657ac241f8..67cee5ecfd
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/910b1725b1..3d87dab413
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/c83050b88e..3357d1060e
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/92d8c4e0cf..aabd869daf
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/8fc17971d6..e07dcc1eaa
* third_party/r8: ZQH8yoO1Ol5rCFRL2hzp4_mcdq23Fk19Z_gVHn5pzk8C..tr-hYTpA4Gomi1_TTF1Hvbc0Rwy8guQ4OMLc90Gw0uQC
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d06f70c93b..345ee65632
No update to Clang.
Bug: None
Tbr: yuxinhu@google.com
Change-Id: Ic9f55be94f4da264375a90d56349cf63dd0140e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4931056
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
ea332c71
|
2023-10-10T21:47:58
|
|
Manual roll VK-GL-CTS from a55b0930e9db to f2434516dcf5 (7 revisions)
Manual roll requested by yuxinhu@google.com
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/a55b0930e9db..f2434516dcf5
2023-10-06 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9
into vk-gl-cts/main
2023-10-05 ziga@lunarg.com Reduce the amount of variations in
VK_EXT_host_image_copy tests
2023-10-05 rgarcia@igalia.com Improve and expand performance query tests
2023-10-05 ziga@lunarg.com Add tests using intermediate stores in helper
invocations
2023-10-05 hauxwell@broadcom.com Fix execinfo compilation against musl c
library
2023-10-05 piotr.byszewski@mobica.com Update glslang version and enable
c++17
2023-10-05 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7
into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: If2e3f881b3e03f4f13da469671f06e087c2a5b2b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4928869
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
43acadab
|
2023-10-06T15:05:36
|
|
Add missing configurations for khr tests
KHR-GLES* tests are ran with configurations defined in
glcKhronosMustpassEs.hpp:
https://github.com/KhronosGroup/VK-GL-CTS/blob/main/external/openglcts/modules/runner/glcKhronosMustpassEs.hpp,
when launching the conformance test from Khronos
Conformance Package. This change adds the missing
configurations in test_suites.pyl, for vulkan backends
and swiftshader backends.
Bug: b/297901032
Change-Id: I87e77ca8756b883ef08551919f67904ecf21aa97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4918582
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
6f794eab
|
2023-10-05T11:23:30
|
|
Change angle::FixedQueue's storage from std::array to std::vector
Right now angle::FixedQueue uses std::array as the storage. In the case
when queue is full, the only choice is to wait for dequeue thread to run
until there is more room to enqueue. This CL try to add extra
flexibility. In this CL< it switches storage to std::vector so that we
could reallocate to double the storage when it is full. The trick is
that before doing that, you must ensure no one is accessing the queue
other than check the size. In a lot of usage cases that is easy to do by
just grabbing the necessary locks.
Bug: b/302739073
Change-Id: Ibefe0fd0e3e89c17dd6ee2cac6adc3368122adb9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4915811
Reviewed-by: Hailin Zhang <hailinzhang@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
05c21cfc
|
2023-10-04T16:59:44
|
|
ANGLE Tracer: Make GL API capture threadsafe
Multi-context games (Asphalt9, Pokemon Masters Ex) exhibited
random crashes when running with capture-enabled builds. Added
a frame-capture-only mutex for GL captureCalls to keep shared
frame capture data thread-safe.
Tests: Start Asphalt 9 with a capture-enabled build
Bug: b/303472963
Change-Id: I70f27923e4cf1c150785cdaf71919b235fce0a10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4912267
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
53e37a3e
|
2023-09-29T14:15:37
|
|
Replace mActiveTextures.fill(nullptr) with memset
std::array::fill yields unoptimized, unrolled loop with 8 byte
increments.
Surprisingly high (>2%) effect on the instructions counter in my tests
(first frame of real_racing3 trace)
The number of samples hitting this spot in profiling is also
signficantly reduced.
Impact on power harder to judge due to noise but does seem to be a bit
better.
Added a FillWithNullptr utility to check that nullptr is 0 and used it
in other places where fill(nullptr) was used in ContextVk. It's not used
elsewhere in vulkan.
Bug: b/302708437
Change-Id: If7fab66d858bc10ca356418d2ab26232bb9a9ce7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4902288
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
a0967770
|
2023-10-06T18:01:45
|
|
Add egl/wrapper headers to deqp opengl sources
gn gen --check catches these and "include not allowed"
Bug: b/303881910
Change-Id: I26728dc2618436daec232152c56d59a7233ca91e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4916365
Auto-Submit: Roman Lavrov <romanl@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
d1cf2d43
|
2023-10-05T00:00:00
|
|
Cleanup sampler completeness validation
* Simplyfied control flow in
TextureState::computeSamplerCompleteness
* Used special rules for all depth and stencil
formats instead of the filter support flag
* Fixed DEPTH_STENCIL_TEXTURE_MODE affecting
completeness of depth-only textures with
REF_TO_TEXTURE compare mode
* Skipped mipmap validation for
multisample 2D array textures
Bug: angleproject:2373
Change-Id: I0f9b6e7401fb85433f2ba4873f271055139bb17e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4922392
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b4d87668
|
2023-10-10T10:01:46
|
|
Roll vulkan-deps from d3dc8dfdccca to be2755d4d109 (8 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/d3dc8dfdccca..be2755d4d109
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/5ff0c048b7..277d09e679
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/6d4f07c995..d728191673
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/730234d8e4..31b95ce237
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/10988f7589..84a7db4f82
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I918c643c830931f95bf22c7854fdafeb9e2e15ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4925139
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
04ce14af
|
2023-10-10T07:00:15
|
|
Roll Chromium from b3c67dea8ed9 to 2f77720808c4 (504 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/b3c67dea8ed9..2f77720808c4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/7c58dc7046..5f1ddffe0a
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/878f3f1678..657ac241f8
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/2e28c272ba..910b1725b1
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/bf36a1f158..88f60e4dc3
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4d83729ced..30e34f3dc1
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6aed4f5a0c..92d8c4e0cf
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/24bdc4f64c..8fc17971d6
* third_party/siso: git_revision:23257e255f1d58d9f66923a1a40e746ac3a4b9d8..git_revision:c689f99bb4b9908073bd2f3fbd68f289d9e45a75
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/41f294687f..d06f70c93b
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/171f64306f..40dc9a464b
No update to Clang.
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I36c12202445f4716fe71e4c63ed2c6acee3e3785
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4924804
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
99b208c1
|
2023-10-09T10:01:44
|
|
Roll vulkan-deps from f770c9936a5a to d3dc8dfdccca (57 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/f770c9936a5a..d3dc8dfdccca
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4fab7435bf..933db564ca
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/6f0d6550e6..bbe0f575eb
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/dedcfae378..6d4f07c995
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/e483d0dfc7..730234d8e4
* vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/2169a0849e..9e088360b5
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8dee683271..10988f7589
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: Ib2336a9b279eebbabd4c2dcd2d55d3b56604bbf2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4921620
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|