kc3-lang/angle

Log

Author Commit Date CI Message
Mark Lobodzinski 1afb8058 2022-05-12T16:19:14 Add Vulkan backend support for texture labels Add onLableUpdate support for textures in the Vulkan backend. Bug: b/229105865 Change-Id: Id9e5b2b81352e97b7843a63f27709739005dc2f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645854 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Cody Northrop 7a243dbe 2022-05-22T19:48:34 Capture/Replay: Allow repeated Gen-on-Bind for resources We aren't clearing items from the map of resource IDs used to track Gen-on-Bind. Before this CL, an app could Gen-on-Bind, delete the resource it genned, then Gen-on-Bind again to trigger this error. The options are to add tracking to remove items from the map when they are deleted, or just remove the error and allow it to happen. Since this happens so rarely, going with the simple approach of removing the error. Test: Star Wars: KOTOR MEC Bug: angleproject:7353 Change-Id: I320771692e1c01e254fc977f5eef99284cc95f67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3659505 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Jamie Madill 7df1f581 2022-05-24T09:58:36 GN: Add angle_build_tests. This lets ANGLE builders disable targets they don't need or can't build. This will fix the roll into Skia broken by http://crrev.com/c/3645441. Dawn will also need to update its .gn file to set angle_build_tests to false. Bug: angleproject:4964 Change-Id: Ie40bdd33d7b59e93813a35df20c4f09c32961f51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3664296 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 11e9c835 2022-05-22T23:52:35 Vulkan: Dump graphics pipeline cache graph Bug: angleproject:6565 Change-Id: Ica8fdc40ece3e1c66fae8a4f8f70a3d33374fdb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3656639 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 2f0b6429 2022-05-23T21:20:13 Revert "util/X11Window: Set PMinSize and PMaxSize hints." This reverts commit a78eca2cab5f7826c1719e47fca229086ec06947. Reason for revert: We suspect this CL is causing rendering issues on Linux swiftshader bots: https://bugs.chromium.org/p/angleproject/issues/detail?id=7336. Some trace test only has part of the screen rendered: https://angle-gold.skia.org/detail?test=raid_shadow_legends&digest=a4eb4b3f306f31798c5e86dcf34d0f35. Revert it to check if it helps the resolving the render issues on bots. Original change's description: > util/X11Window: Set PMinSize and PMaxSize hints. > > Before this patch replay windows were down-sized to match the default > screen size in case their extent was greater than the screen size. > > Setting a PMinSize on XSizeHints resolves the issue on modern window > managers. Tested with GNOME Shell 41.3 with both native X11 and Wayland > (over XWayland) backends. > Setting PMaxSize was also requried to pass the > BlitFramebufferANGLETest tests. > > This fixes retracing with correct extents and resolves a VVL performance > warning. > > Bug: angleproject:6808 > Bug: angleproject:7083 > Change-Id: I00ee149ec02efe08c5801e4231913049d31e262b > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3507514 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Bug: angleproject:6808 Bug: angleproject:7083 Bug: angleproject:7336 Change-Id: Ibe15e549d1f1965f0c3832190f02144bb63da16a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3661210 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll cd48eedd 2022-05-24T07:01:19 Roll Chromium from 99a468a0505d to d624307d6d25 (438 revisions) https://chromium.googlesource.com/chromium/src.git/+log/99a468a0505d..d624307d6d25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b2f1ec8d78..41d56d6f21 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8f84aa81fb..9a280acff4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..31caa70cfc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/964f8124b6..26a1d24c04 * third_party/fuchsia-sdk/sdk: version:8.20220522.3.1..version:8.20220523.2.1 * tools/luci-go: git_revision:0ef9351a5b73943d547fb27d463d5f4a1572727f..git_revision:a80cc32b17397d30b5fdb121520551cfba7089a2 * tools/luci-go: git_revision:0ef9351a5b73943d547fb27d463d5f4a1572727f..git_revision:a80cc32b17397d30b5fdb121520551cfba7089a2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f456198cfa..e244ccaa70 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bcdcdc9a20..a00b8203b9 * tools/skia_goldctl/linux: AbtuND1Sd9XnD2OrFlxEmcVYMHhtzMC7l6XexiREGFcC..5TkbcvJVzHp9wQ53-1Nm90VM5uLJaVVpC_AwYtPXxGIC * tools/skia_goldctl/mac_amd64: 2Cr5KjnIBsb6n9qL39smFnoAbRNeQwcKDr-ctS40il0C..5b1bKqYE6yUOYQ6G8KUa8ZW8KhFqv9nr7U-LXOBesegC * tools/skia_goldctl/mac_arm64: _3_6moiopPO-jR-8hfUhuhd3vivPOG4dIjbTtkdZag0C..W8CHakOWqPFcwzYArvm3QXuJIBDxYohv-pj4iG9hL2IC * tools/skia_goldctl/win: cp_nCdrA3VNZpY0dNCbaiZ5ZxU1_Y9BkGi8NoC6n0NUC..6TQEvw8S5zBjrqCvtr2QxQtTlAcVxQdTkUHMkBb02MoC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I913f39ce88266618f08031655afe4f1295a78836 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3661523 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Hailin Zhang 35e54dbb 2022-05-20T17:24:11 Vulkan: Fix EXT_texture_buffer support condition More formats than necessary where required to have the STORAGE_TEXEL_BUFFER feature. This was based on the table in the EXT_texture_buffer spec, but that only applies to sampler buffers. Support for image buffer formats is based on acceptable formats to glBindImageTexture. Bug: b/206367167 Change-Id: I0c94c3d5a99c1e99ee1f9b05b1accdfaa38101af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3658000 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Hailin Zhang <hailinzhang@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Antonio Caggiano f6c14933 2022-01-19T17:19:48 dEQP: Support Wayland Improve ANGLE native display factory by supporting creation of a Wayland native display. Bug: angleproject:7065 Change-Id: I0882d8666b1d07ced0804b99d1998ca45f4ad73b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3525753 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Antonio Caggiano 6e258863 2022-05-09T18:45:02 Vulkan: Use packed enum for present modes This will be useful for cases where ANGLE would need a non-Vulkan present mode. Bug: angleproject:7217 Change-Id: I3428ac9fb20788543cb24a0aa5f140e992e94001 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3636057 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 9e0a7be6 2022-05-11T10:08:57 Traces: Update restricted_trace_perf.py This CL includes the following changes: * Fixes for swapped device power rails * Add process memory stats * Add shared column widths This version of the script was used for numbers generated on 2022-05-20. Test: restricted_trace_perf.py Bug: angleproject:6970 Change-Id: Idb2cb9266bb6168315b53164534a10b1df47a9da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3661363 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 2ae8bdb3 2022-05-23T10:01:38 Roll vulkan-deps from 880c9e0050c6 to 82a65519c521 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/880c9e0050c6..82a65519c521 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/2439e6d56d..86ff4bca1d * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ad05e878ee..3772b036e0 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0ce518899c..bdd58dd007 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I034d100076eef391c44c1e7dba5f73da9623eddd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3660032 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 80be1bb3 2022-05-23T10:01:25 Roll SwiftShader from 73679602bc0b to b5cb037f0292 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/73679602bc0b..b5cb037f0292 2022-05-20 swiftshader.regress@gmail.com Regres: Update test lists @ 73679602 2022-05-20 penghuang@cromium.org Adjust {min,max}ImageExtent to {0,0} and 4K If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I901f3ceff68318d537f84761620e11f640d1ab3e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3659702 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2db4297a 2022-05-23T08:09:58 Roll Chromium from f0d8ec07c77f to 99a468a0505d (698 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f0d8ec07c77f..99a468a0505d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/399520d50a..b2f1ec8d78 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/3e4d3831b8..4ad92ece12 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c9b2288d0c..d03f56b8fa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2085cd7655..8f84aa81fb * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a1cf7a299e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bd80a1be23..964f8124b6 * third_party/fuchsia-sdk/sdk: version:8.20220519.0.1..version:8.20220522.3.1 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/2fe249ae5b..0e6b3ca1fa * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bec960d661..6df1876b95 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/246012ac2c..f456198cfa * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/acf94a2364..bcdcdc9a20 Clang version changed llvmorg-15-init-10168-gc2a7904a:llvmorg-15-init-10717-ge00cbbec Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/bec960d6617068dccbb4576fc0e23b800d2a6051..6df1876b953b7bb3418a8cb64e686d21201a4120/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: Ia10d4b014e710e0234ccd129dc66cec4a49a74bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3660027 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi e4a517c9 2022-05-17T23:58:23 Vulkan: Rearrange GraphicsPipelineDesc to reduce footprint Bits for VK_EXT_extended_dynamic_state2 are moved to the end of the desc. Some bits are also rearranged and some paddings removed for a total of 4 bytes of reduction in desc size. Bug: angleproject:7328 Change-Id: I48f20408a8a2cb7bce0d8e2d0d2ccd8a121f7894 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3652747 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi f52c629b 2022-05-21T21:42:04 Capture/Replay: Make sure replay tests build libEGL Bug: angleproject:7352 Change-Id: Idd294af9f7359d94cd3e1708b5bb699675a538cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3656635 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Alan Zhao 0b808c74 2022-05-21T02:00:55 Silence all std::iterator deperecation warnings This CL applies the config :angle_deqp_framework_common_warnings, which was introduced in https://crrev.com/c/3651152, to more targets. The headers that contained std::iterator, identified in https://github.com/KhronosGroup/VK-GL-CTS/pull/323, are included in files that belong to build targets that do not explicitly include those headers, so the previous CL failed to remove all warnings and allow the libc++ roll CL (https://crrev.com/c/3655638) to pass the swangle tryjobs. To verify: Checkout the libc++ roll patch at https://crrev.com/c/3655638 args.gn: build_angle_deqp_tests = true dcheck_always_on = true is_component_build = true is_debug = false symbol_level = 1 In a chromium source directory, run the following command to build all targets under //third_party/angle: autoninja -C out/Default `gn ls out/Default |\ grep '^//third_party/angle' |\ sed 's/\/\///' |\ sed 's/([^()]*)//'` Bug: angleproject:7349 Change-Id: I295872d38137794569598c39061822161d6cd655 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3651154 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
Shahbaz Youssefi bb3afdf4 2022-05-17T16:08:06 Drop support for 64xMSAA+ Hardware that supports anything more than 32xMSAA is rare (practically only Nvidia). That high number of samples is hardly useful either way. This change reduces the number of words for the sample mask to 1, reducing the amount of state needed to track it. Bug: angleproject:7328 Change-Id: Iea9add1cbeef494ff9bb383b10c82b839d1e53a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3652738 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 688553c0 2022-05-16T23:27:29 Vulkan: Dynamic state for primitive restart enable Bug: angleproject:5906 Change-Id: Ida2cbe904604c638fd3a8ab498d49584dfd9c860 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3651593 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Sunny Sachanandani c76fb2d8 2022-05-18T15:29:19 Enable EXT_texture_norm16 on ES2/D3D11 Windows HDR regressed recently due to format checks added in Skia: crbug.com/1324371 Skia thinks R16/RG16 texturing is not supported, which it bases on GL_EXT_texture_norm16 not being reported on its ES2 context. Migrating to ES3 for the compositor context is a large project, and reverting the format checks in Skia is also not desirable because it helps catch bugs in ANGLE-Metal. Enable texture_norm16 on ES2 for R16/RG16 texturing since Chromium needs it for HDR video playback for P010 textures. This used to work before even though the extension wasn't advertised. Also, enable the P010 test on ES2/D3D11 which was previously ES3/D3D11 only. Bug: angleproject:7322, chromium:1324371 Change-Id: I4c2527996e37ba5365bb94b5764413e5a9fdda7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645892 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi 3b78e0d5 2022-05-16T23:13:57 Vulkan: Dynamic state for depth bias enable Bug: angleproject:5906 Change-Id: I679a764e0a9ef74cc8a58f9061b42c0aaef56df2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3651592 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 7c83a363 2022-05-16T22:22:44 Vulkan: Dynamic state for rasterizer discard enable Interaction with primitives generated query are tested by those tests added in https://chromium-review.googlesource.com/c/angle/angle/+/2976181 Bug: angleproject:5906 Change-Id: I0ab9f54995504be770a93bf13337a5ffe20bf7eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3651582 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 2faabfe5 2022-05-16T16:19:03 Vulkan: Optimize pipeline desc w.r.t dynamic state State corresponding to VK_EXT_extended_dynamic_state is moved to the back of the description and is excluded from the hash. Bug: angleproject:5906 Change-Id: I3b6efb2674e955eed6e12b6c7096a7fea63748a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3651581 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya ee1894e5 2022-05-18T16:39:22 Account for GL_ANGLE_yuv_internal_format when setting yuv state With the introduction of GL_ANGLE_yuv_internal_format an EGLImage source can be a YUV texture. Account for this possiblity when setting up EGLImage's state related to YUV. Bug: angleproject:5773 Test: ImageTestES3.SourceYUVTextureTargetExternalRGBSampleYUVSample* Change-Id: I7d06befa27dd6bd3408bda4d3f0cbe7cc21cd59a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3655129 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 3da24b5c 2022-05-16T11:58:59 Move trace loader code to a common location. With that Capture/Replay will be able to make use of the same code. CL authored by gert.wollny@collabora.com. Bug: angleproject:4964 Change-Id: Ie1ba663169a34929f5a169ab74c7042e9fd5deb0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645441 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Nico Weber 52c42e5a 2022-05-20T09:28:29 Temporarily disable deprecation warnings for VK-GL-CTS Merging the real fix will take a few weeks, so disable the warning until then to unblock the libc++ roll. This isn't ideal, but the alternative is temporarily brancing VK-GL-CTS, which also comes with downsides. So let's try this first. Bug: angleproject:7349 Change-Id: Ib1bb6cdb9470801f3202f75cce46ee88efb0730b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3651152 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Stephen White 88f582f6 2022-05-19T09:48:21 D3D: fix whole-array assignment to SSBOs. SSBOs in HLSL are implemented as RWByteAddressBuffer, which can only Load() or Store() up to 16 bytes at a time, so value-assignment of arrays doesn't work. The fix is to implement a traversal which unfolds such assignments into an element-by-element for-loop. Bug: angleproject:7334 Change-Id: I840c8ff7b62b67dc8935d4c09589d955798d96ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3656070 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll f8e8b7cc 2022-05-20T10:01:38 Roll vulkan-deps from c37d1e2ab98c to 880c9e0050c6 (19 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c37d1e2ab98c..880c9e0050c6 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/2f5bc0b741..2439e6d56d * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d0c8dc3045..b3ff97d0fe * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/33d4dd987f..1b4f46a3cc * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/5aa2ee48c9..ad05e878ee * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/c5d859fbe3..689140c204 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c08c0860bd..0ce518899c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Iffd0deabd57f110b5cac70663a95058600e116f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3655745 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8af51b7e 2022-05-20T10:01:25 Roll SwiftShader from 2933d3126969 to 73679602bc0b (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/2933d3126969..73679602bc0b 2022-05-19 swiftshader.regress@gmail.com Regres: Update test lists @ 2933d312 2022-05-19 capn@google.com Revert workaround for MemorySanitizer scalar SSE false positives 2022-05-19 sugoi@google.com Revert "Stop skipping VK_STRUCTURE_TYPE_IMAGE_VIEW_MIN_LOD_CREATE_INFO_EXT" 2022-05-19 sugoi@google.com Fix using uninitialized blend constants If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Idf43ddca9327876e860928dcb52c6c3574847609 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3657071 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c3687f07 2022-05-20T07:01:49 Roll Chromium from 170d12460fd5 to f0d8ec07c77f (430 revisions) https://chromium.googlesource.com/chromium/src.git/+log/170d12460fd5..f0d8ec07c77f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e589cbe291..399520d50a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/7208eddba1..a5fa4652f6 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/75a3853b9d..3e4d3831b8 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/837a94efb7..c9b2288d0c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/bc590046d8..2085cd7655 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..811104909b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/632bbc0cb1..bd80a1be23 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6e492e7a5c..bec960d661 * tools/luci-go: git_revision:d3db74920e35147955be43f62b5f4ed0cf84c614..git_revision:0ef9351a5b73943d547fb27d463d5f4a1572727f * tools/luci-go: git_revision:d3db74920e35147955be43f62b5f4ed0cf84c614..git_revision:0ef9351a5b73943d547fb27d463d5f4a1572727f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8880d3ea74..246012ac2c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b6abdba0f1..acf94a2364 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ibf371256b0e644f8128a0ae1952c7dcf9a1df42c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3656887 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 58fd3157 2022-05-12T00:01:19 Vulkan: Dynamic state for vertex stride Bug: angleproject:5906 Change-Id: I73b7e004fc25bf3777982736412adc1ca57504b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3644856 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Brian Osman e71a3e5f 2022-05-05T10:08:18 Insert Metal polyfill for Matrix /= Scalar when needed Bug: skia:13290 Change-Id: Id82398581b84f1990fef632006604d12341e29be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3630018 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Yuxin Hu 78ea8521 2022-05-19T19:04:31 Suppress Flaky Tests Suppress the flaky deqp gles3 d3d tests on NVIDIA Bug: angleproject:7345 Change-Id: I2e49af4f57ecd56c5415aa93b7a636adc939f418 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3656317 Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuxin Hu af869f4a 2022-05-19T18:39:56 Update capture replay expectation file Capture/Replay was enabled for ES3, update the expectation file to reflect the latest test results Bug: angleproject:6605 Bug: angleproject:7339 Bug: angleproject:3886 Change-Id: I1f51eee36e98edde4b3dea6ee0285eabe845547e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3656315 Auto-Submit: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gregg Tavares 118a6484 2022-05-19T15:11:31 Metal: Upstream buffer cache fix from WebKit Patch is from: https://bugs.webkit.org/show_bug.cgi?id=239015 BufferMtl::getRestartIndices() would recalculate restart indices on each draw because RestartRangeCache::operator bool() would return m_isDirty instead of the intended !m_isDirty. Use std::optional to hold the RestartRangeCache instead of maintaining m_isDirty. This allows the type system to contribute to the correctness of the code. Dirty restart range cache is not useful and takes up memory. Bug: angleproject:7340 Change-Id: I6e3ce527700780b5fea59af405bfe06d3714e79f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3656450 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Cody Northrop f674e501 2022-05-18T22:38:12 Tests: Add Bridge Constructor Portal trace Test: angle_perftests --gtest_filter="*bridge_constructor_portal*" Bug: angleproject:7335 Change-Id: I9f66a739c8176b629c4ba31d713656d73590dd69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3654268 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 728dea2b 2022-05-19T13:04:58 Suppress Vulkan Validation Error Suppress Vulkan Validation Error to unblock the vulkan-deps roller. We should remove the suppression when the VVL issue in the commit e23f82fc84c891b3a34e6e8787913b335cbe3934 in Vulkan-ValidationLayers.git is resolved Bug: angleproject:7338 Change-Id: I3322a5b10d271dcd95da9354328facf7e3b9113d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3651531 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 40269f91 2022-05-19T18:43:11 Fix trigger.py to run mb.py with python3 Bug: angleproject:5707 Change-Id: Ib0e8db962e89c536f92d8bfef8f52a4600e9bc35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645125 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi c7182af2 2022-05-18T15:35:30 Vulkan: Reserve varying for xfb if pre-rotation is enabled In https://chromium-review.googlesource.com/c/angle/angle/+/3562379, the varying was no longer reserved when VK_EXT_depth_clip_control is present. This is incomplete, as pre-rotation support still requires a varying to be reserved for capturing gl_Position. Bug: angleproject:5421 Change-Id: I87feea6ed738fa685b037c14c0a24349ce496cc7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645816 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 86074fc7 2022-05-19T13:16:25 Roll Chromium from dbb1f3a2b2f7 to 170d12460fd5 (586 revisions) https://chromium.googlesource.com/chromium/src.git/+log/dbb1f3a2b2f7..170d12460fd5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC yuxinhu@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c8945d06e1..e589cbe291 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/b682786415..75a3853b9d * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/44c86bbb7c..837a94efb7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/51562c3095..bc590046d8 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f438dbd8e0..113d0128d5 * third_party/android_sdk/public: WPMCeVMS3fC3IOYKAUA8ivfCCpdzl3Wi1neeNcdtkA0C..PGPmqJtSIQ84If155ba7iTU846h5WJ-bL5d_OoUWEWYC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..811104909b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8fb649c425..632bbc0cb1 * third_party/fuchsia-sdk/sdk: version:8.20220518.0.1..version:8.20220519.0.1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6839b0c81c..8880d3ea74 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9410fd46f2..b6abdba0f1 No update to Clang. Bug: None Tbr: yuxinhu@google.com,ynovikov@google.com Change-Id: Id85a4e38584e2c8c972b8d25d8f1af6ce1c37508 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3655117 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Peter Kasting 54a6b76f 2022-05-19T07:36:54 Roll third_party/rapidjson/src/ 7484e06c5..781a4e667 (156 commits) Bug: chromium:1284275 Change-Id: I5351f6b38ad56da0a5ccae82a1b340dfe2a3c588 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3646003 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org>
Yuly Novikov 2fd7444b 2022-05-19T09:15:37 Fetch gn binary for the correct architecture on linux. Port crrev.com/c/3646480 into ANGLE. Bug: None Change-Id: I21f293a8d90ee66a40192b84739d3da15f1a0cc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645120 Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 06fa297b 2022-05-19T10:01:44 Roll SwiftShader from cb4fc6d02fe4 to 2933d3126969 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/cb4fc6d02fe4..2933d3126969 2022-05-18 capn@google.com Revert "Temporarily fix failing dEQP tests" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I23aca7eb3f97f25e59b72ebf8bbea621d1c8868e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3655227 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Steven Noonan 6ae0c321 2022-05-15T18:18:47 Vulkan: clamp dynamic line width to supported values On my Apple M1, MoltenVK reports wide lines are not supported. Trying to use vkCmdSetLineWidth with any value other than 1.0f will cause MoltenVK to throw an exception and stop accepting render commands. I originally tried making this a change in the frontend Context class, by clamping the value to the supported line width range. But that approach failed the WebGL conformance tests, because queries of of GL_LINE_WIDTH must match the value specified by glLineWidth. OpenGL ES docs state: The line width specified by glLineWidth is always returned when GL_LINE_WIDTH is queried. Clamping and rounding have no effect on the specified value. Bug: angleproject:7317 Change-Id: I7a3c3454e1483f9124fd70b7e9f2138bd717e1de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3654264 Auto-Submit: Steven Noonan <steven@valvesoftware.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Stephen White d3eb61d4 2022-05-18T11:00:34 D3D11: fix SSBO load in a return statement. Add a special case to load from an SSBO in a return statement. Add tests that exercise reading from an SSBO in a function, in both a fragment shader and a compute shader. Bug: angleproject:7226 Change-Id: I08e6c695bf080eb23661ef4df047f0f1a787b06e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645442 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Roman Lavrov 28dfa45d 2022-05-11T16:46:52 Spawn via vpython when old module detected. Not sure of a better way to detect this case as it seems to be running with the same python version as our vpython but modules are old. Bug: angleproject:7326 Change-Id: I1750f65afdfdfc289af71bc7f426d5ba50dfd4a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3642804 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Hailin Zhang b7474d0a 2022-04-28T14:44:54 D3D11: Add GL_EXT_texture_buffer support tested: deqp-gles31.exe --deqp-gl-context-type=egl --deqp-case=dEQP-GLES31.functional.texture.texture_buffer.* passed Bug: b/206367167 Change-Id: I31a6f84bd701a737735a6bac2f4eef780c24a979 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3639722 Commit-Queue: Hailin Zhang <hailinzhang@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 87ea0c7d 2022-05-17T22:33:57 Vulkan: SPIR-V Gen: Apply Flat to gl_Layer in FS Not directly specified by the spec on gl_Layer itself, but required according to this more generic statement: > Fragment shader inputs that are, or contain, integral types must be > qualified with the interpolation qualifier flat. Bug: angleproject:7332 Change-Id: Ieaa389e9b1318d3f13147cba7949cff6491c4b61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3652746 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Brandon Schade <b.schade@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 8701f53a 2022-05-17T13:54:53 Vulkan: Fix clear value for incomplete MS textures * Added initializeContentsWithBlack() for the cases we wish to use opaque black. * Added stageResourceClearWithFormat(), which also takes an initial clear value. stageRobustResourceClearWithFormat() is included as a special case. Bug: angleproject:7151 Change-Id: I32d7a9af53b51499fe46d6e397301744dbf3c236 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3652995 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gregg Tavares dbeba900 2022-05-17T16:52:23 Reland "CGL, MTL: pbuffer for IOSurface fails for some formats" Fixed iOS compiler error https://chromium-review.googlesource.com/c/angle/angle/+/3568380 Bug: angleproject:7175 Change-Id: I1d15ecf0081891db31470abc305e6780c81ab574 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3648215 Commit-Queue: Gregg Tavares <gman@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Stephen White b4ec8eac 2022-04-12T12:16:40 D3D11: implement image load/store for non-compute shaders. Output image metadata and image2d replacement string in other shader types. Implement the actual HLSL transform for fragment shaders. Re-enable problematic test. Bug: angleproject:7121 Change-Id: I49b815695757e822e6fdfe599e07ceb5b1d6a75c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550544 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya 2fdd7bfd 2022-05-17T13:31:58 Vulkan: Support binding 2D slice of a 3D texture to an image unit Support binding a 3d texture as a 2d texture by specifying that it is non-layered during glBindImageTexture and expose support for EGL_KHR_gl_texture_3D_image when VK_EXT_image_2d_view_of_3d vulkan extension is supported. Tests: ComputeShaderTest.BindImageTexture3D dEQP-GLES31.functional.image_load_store.3d.*single_layer Bug: angleproject:7320 Change-Id: Ie2f0dfcdf302a4aa58990f74329ca36e62cd3902 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3648586 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang 14ca09bc 2022-05-17T15:40:22 Metal: Remove the long type from program preludes The long types were not added until Metal 2.2 but they are not needed to represent any ESSL types so simply remove them. Bug: chromium:1323265 Change-Id: I10e96c72067ef8c002395010e0dbc6130b8b4b78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3652737 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Charlie Lao ff011779 2022-05-13T12:36:24 Vulkan: Let texture buffer handle BufferVk's storage change When buffer's storage changed due to glBufferData call, texture buffer code should also respond to this and update the texture descriptor set. This CL merges BufferVkStorageChanged message into InternalMemoryAllocationChanged and removed BufferVkStorageChanged all together. Bug: angleproject:7283 Change-Id: I230ee7268634e747d06eab1954f5a76ecf84c9d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3646955 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 3d430f5f 2022-05-17T11:38:39 Vulkan: Add test for texture buffer and buffer data interaction When glBufferData is called on a buffer that is bound to texture buffer, we may create a new buffer storage. This adds a test to ensure this bufferData optimization does not break texture buffer usage. Bug: angleproject:7283 Change-Id: I8153c6c7b8287b5a4265eec82b1ca70ac66992c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3652244 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 2abf9adf 2022-05-17T12:06:02 Vulkan: Bug fix in YUV descriptor pool allocation The commit d8d396dbc0c88 refactored descriptor set and pool logic but introduced a bug where it did not account for multiple immutable sampler descriptor count. Tests: Texture2DTestES3*Yuv*Vulkan Bug: b/155487768 Bug: angleproject:5033 Bug: angleproject:5773 Bug: angleproject:6141 Bug: angleproject:6776 Change-Id: I8f5d88ff829b8d0be4c73ff7aa33a76931581f1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3652249 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Trevor Black <vantablack@google.com>
angle-autoroll 78b8f546 2022-05-18T13:54:18 Roll SwiftShader from 89eb09307fbc to cb4fc6d02fe4 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/89eb09307fbc..cb4fc6d02fe4 2022-05-18 sugoi@google.com Fix handling of dynamic vertex stride If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC yuxinhu@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:5906 Tbr: yuxinhu@google.com,syoussefi@google.com Change-Id: If6a5a46ce95e3d654080233a9d97e35522a3b457 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3654117 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 428cd884 2022-05-17T22:38:34 Tests: Add Stardew Valley trace Test: angle_perftests --gtest_filter="*stardew_valley*" Bug: angleproject:7330 Change-Id: I7df1edee9e9887c9b17e9685d3cd6051cdf5ce04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3653495 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 5e34541a 2022-05-18T10:01:18 Roll SwiftShader from 4011ab35f3d8 to 89eb09307fbc (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/4011ab35f3d8..89eb09307fbc 2022-05-17 swiftshader.regress@gmail.com Regres: Update test lists @ 7654b866 2022-05-17 swiftshader.regress@gmail.com Regres: Update test lists @ 4011ab35 2022-05-17 capn@google.com Eliminate conditional MemorySanitizer instrumentation build flag If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I636cb9bbb4f1a56e38da0002d2829d7df60d106c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3653545 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4dc9c79e 2022-05-18T07:01:35 Roll Chromium from 73ffbbeac851 to dbb1f3a2b2f7 (503 revisions) https://chromium.googlesource.com/chromium/src.git/+log/73ffbbeac851..dbb1f3a2b2f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/173ab46d12..c8945d06e1 * buildtools/linux64: git_revision:578a7fe4c3c6b0bc2ae1fd2e37f14857d09895bf..git_revision:c547ca1497e3ff0dcbc0b2cb036b3d40380cbeeb * buildtools/mac: git_revision:578a7fe4c3c6b0bc2ae1fd2e37f14857d09895bf..git_revision:c547ca1497e3ff0dcbc0b2cb036b3d40380cbeeb * buildtools/win: git_revision:578a7fe4c3c6b0bc2ae1fd2e37f14857d09895bf..git_revision:c547ca1497e3ff0dcbc0b2cb036b3d40380cbeeb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e951bdad47..51562c3095 * third_party/android_sdk/public: PGPmqJtSIQ84If155ba7iTU846h5WJ-bL5d_OoUWEWYC..WPMCeVMS3fC3IOYKAUA8ivfCCpdzl3Wi1neeNcdtkA0C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..811104909b * third_party/fuchsia-sdk/sdk: version:8.20220516.3.1..version:8.20220518.0.1 * third_party/jdk: JhpgSvTpgVUkoKe56yQmYaR1jXNcY8NqlltA0mKIO4EC..egbcSHbmF1XZQbKxp_PQiGLFWlQK65krTGqQE-Bj4j8C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/a41a88a1b9..2fe249ae5b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/56af55b3cb..6e492e7a5c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/eacebdcae1..6839b0c81c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6ba42ec707..9410fd46f2 * tools/skia_goldctl/linux: 6MeTXTSbQfRUxRGLnxIsfm_P_4evNm3jL3P9PRfn64wC..AbtuND1Sd9XnD2OrFlxEmcVYMHhtzMC7l6XexiREGFcC * tools/skia_goldctl/mac_amd64: oQho8T-k-Qa_4_fNkqqvbZ5QgL0p5QqgcqSDzU0uzL4C..2Cr5KjnIBsb6n9qL39smFnoAbRNeQwcKDr-ctS40il0C * tools/skia_goldctl/mac_arm64: P1Kb0UYKaHszJ8iB4lfGiT3a7VEZrzJSZWnr55aK6isC.._3_6moiopPO-jR-8hfUhuhd3vivPOG4dIjbTtkdZag0C * tools/skia_goldctl/win: 1U6r3V6uSCIxjIQB8GwhpmGmE1LjJaAueOs3HhD4WJIC..cp_nCdrA3VNZpY0dNCbaiZ5ZxU1_Y9BkGi8NoC6n0NUC No update to Clang. Bug: angleproject:4483 Tbr: yuxinhu@google.com Change-Id: I263c1779d2031cb8ea73bc6c43047bc75286a37f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3653595 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peng Huang c649979b 2022-05-17T20:53:16 Create EGLImage from VkImage correctly with non sized format Sometime, client may pass in non-sized internal formats (GL_BGRA, GL_RED and GL_RG) for creating EGLImage from VkImage. For those formats, angle::Format::InternalFormatToID(internalFormat) can not return valid result. Fix the problem, by converting internalFormat to sized format first. Bug: chromium:1326658 Change-Id: Id88e0614a2a9f55aabac116ea95ed8cec02672a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3652741 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Roman Lavrov cd4cce3f 2022-05-17T18:35:36 Add more tips about recovering the qpa file. Bug: angleproject:7242 Change-Id: I106937afcb5cbe5387a2a34f635b9afb2f70b9b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3652743 Reviewed-by: Ian Elliott <ianelliott@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Roman Lavrov 957a44f4 2022-05-17T17:08:35 Clarify that angle_debug_package is necessary to load the apk Bug: b/232578994 Change-Id: I7a798f1997d7963c8466c5c17e9ac563a21d8abc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3652742 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuxin Hu 93c0c90d 2022-05-17T11:00:59 Suppress the failing egl test to unblock roller Suppress this failing tsan test to unblock the VK-GL-CTS roller Bug: angleproject:7327 Change-Id: I077a7e5b1474d08b6c9bcf08187b634da911e75d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3648309 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Antonio Caggiano a277f1bc 2022-04-13T15:47:10 Vulkan: Fix Wayland surface size queries On Wayland, VkSurfaceCapabilitiesKHR currentExtent is the special value (0xFFFFFFFF, 0xFFFFFFFF), so we can not use it to query its size. Bug: angleproject:6902 Change-Id: Icf350bfc41577f2b95da08a8dbb7773318a3e568 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3583986 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Stephen White 6136ba27 2022-05-16T12:35:43 D3D: minor cleanup of gl::RangeUI usage. Bug: angleproject:7121 Change-Id: I444f1e5e96dab84315afc290d6044d0dee560d6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3651055 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano 4ece3b08 2022-02-24T15:07:25 Vulkan: Multiple DRM formats A DRM format may be converted into more than one Vulkan format, therefore we try to create a dmabuf image with all candidate Vulkan formats until we succeed. Bug: angleproject:7065 Change-Id: I376d10a596ce81347c8ae21464c2c2db048f01d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516018 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny d75bf9ad 2022-04-29T09:15:35 Capture/Replay: Also limit the number of per shader SSBOs The compiler checks these values, so they should be in sync with the global limits. Fixes test not yet listed in the expectations: ProgramPipelineTest31.MaxFragmentShaderStorageBufferObjects/* Bug: angleproject:7252 Change-Id: Ie967ded15434cf7144d322b6fd4ee5fc7175f8dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3613921 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll 552b01d1 2022-05-17T10:01:56 Roll vulkan-deps from 131de3fd9ec7 to c37d1e2ab98c (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/131de3fd9ec7..c37d1e2ab98c Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d113db7134..c08c0860bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Iefd0f5ed59f395f82deccb5611207722a674081e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3651941 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7d7ed253 2022-05-17T07:00:04 Roll Chromium from 11b60f867851 to 73ffbbeac851 (445 revisions) https://chromium.googlesource.com/chromium/src.git/+log/11b60f867851..73ffbbeac851 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f1780da3e2..173ab46d12 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e112e5ec5b..b682786415 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/cf88e03ee0..44c86bbb7c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c5e0fd55f4..e951bdad47 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9c1fa68883..f438dbd8e0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..705a2dffba * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f8300fba9d..8fb649c425 * third_party/fuchsia-sdk/sdk: version:8.20220515.3.1..version:8.20220516.3.1 * third_party/turbine: FJ-IOPRGQsHUZwVeYmVw_idRk5mUUP6_Uj2i6mKQlEMC..aSG-acwWsASjZaTfSzYcOuM9qoD6S_o3JL6iIFslVdUC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/7085d03b26..a41a88a1b9 * tools/luci-go: git_revision:29b908616bc920e58bf384d1e47b91b6cf9188b8..git_revision:d3db74920e35147955be43f62b5f4ed0cf84c614 * tools/luci-go: git_revision:29b908616bc920e58bf384d1e47b91b6cf9188b8..git_revision:d3db74920e35147955be43f62b5f4ed0cf84c614 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e4bcd2f9b9..eacebdcae1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/10c637ea50..6ba42ec707 * tools/skia_goldctl/linux: 0uXUbBwbtBy2u3GgA06bUzfb9y2dcexN9_F8ENIq1Q4C..6MeTXTSbQfRUxRGLnxIsfm_P_4evNm3jL3P9PRfn64wC * tools/skia_goldctl/mac_amd64: 81jsmJoHpyxpJgyeTsCH_yasXac9eXXRvGS_YABKrsUC..oQho8T-k-Qa_4_fNkqqvbZ5QgL0p5QqgcqSDzU0uzL4C * tools/skia_goldctl/mac_arm64: VQHtaeoSlRCKe0xGCvdGxu6zvLoFkDyBtqZoTKoygDcC..P1Kb0UYKaHszJ8iB4lfGiT3a7VEZrzJSZWnr55aK6isC * tools/skia_goldctl/win: l935F-47LSCA4iAc7FesGig8bpxMc5CaYheeyOc8LB4C..1U6r3V6uSCIxjIQB8GwhpmGmE1LjJaAueOs3HhD4WJIC No update to Clang. Bug: angleproject:6972,angleproject:7073 Tbr: yuxinhu@google.com Change-Id: I05b3944ca5334869c41deac6909e8af89e0b6c5a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3651293 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 807c94ea 2022-04-29T08:44:39 Capture/Replay: Adjust tests do adhere to capture limits Since with capture/replay the number of draw buffers is limited to 4 change the tests so that this number is not exceeded. The nature of the test is not changed by this. Fixes failures not yet listed in the expectations: ProgramInterfaceTestES31.GetResource/ES3_1_Vulkan_SwiftShader ProgramInterfaceTestES31.GetResourceLocation/ES3_1_Vulkan_SwiftShader Bug: angleproject:7251 Change-Id: Ifeeeb8c9aaea2a4de26770d5a6b25b82db449c1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3613920 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 891a4682 2022-05-12T22:32:07 Vulkan: Dynamic state for stencil test/op Bug: angleproject:5906 Change-Id: I436c6c238a15e54919a74d2a697d1f114bb3eaf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3647207 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 66dcca5e 2022-05-12T11:14:27 Vulkan: Dynamic state for depth test/write/op Bug: angleproject:5906 Change-Id: Ie48a0780406c6dbbdd47639f2e185dc854879140 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3646429 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Peng Huang bedb3075 2022-05-16T09:46:11 Do not call RendererVK::handleDeviceLost() for device lost RendererVK::handleDeviceLost() need to hold the mCommandQueueMutex for releasing some resources. For some cases, Locking mCommandQueueMutex may cause deadlock, because the same lock has been acquired by the same thread. Fix the problem by not calling RendererVK::handleDeviceLost() for device lost. It is OK, because RendererVK::onDestroy() will call handleDeviceLost() if the device is lost already. Bug: chromium:1273643 Change-Id: Iaaa77bdf429b703363d4155323b91baf5947d95e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3644641 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 15ecf068 2022-05-12T10:33:00 Vulkan: Dynamic state for depth bounds This state is actually unused. EXT_depth_bounds_test (which can set this state) is a desktop GL extension. If ever implemented, it should be implemented as a dynamic state. Bug: angleproject:5906 Change-Id: If613008952bb80cd98858f33eac7cdf31267ca29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3646428 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 20820bb4 2022-05-13T10:50:47 Make BitSetArray constexpr Bug: angleproject:5906 Change-Id: If1ccacfc81e3e01b4bdbd10d47cf4ec860e3fe0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645494 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Antonio Caggiano 36f5e6ce 2022-05-03T12:08:35 Vulkan: Fix DRM to GL format conversion Do not ignore unused alpha channel for a proper conversion from DRM to GL to Vulkan format. Bug: angleproject:7217 Change-Id: I598ae030005e7375b36c6456864150aa8aaf50c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3624139 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 1cbcc1da 2022-05-16T10:01:55 Roll vulkan-deps from c6a60f3cc711 to 131de3fd9ec7 (22 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c6a60f3cc711..131de3fd9ec7 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/14f6e27304..2f5bc0b741 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/940efca099..d0c8dc3045 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f74b85853c..98340ec500 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/8dc9ab5ce8..5aa2ee48c9 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/a9d2badae2..c5d859fbe3 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/817dd5363e..d113db7134 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I9b8479ba29b29a3f63833aa2c20b4a485d7ae3c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3650529 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 459c367e 2022-01-21T10:02:33 D3D: Initialize storage after generating mipmap images. When TextureD3D generates mipmaps without a storage present, it initializes all the images and then generates mipmaps on the CPU. Attempt to generate a storage after initializing all the mip images so that the mipmap generation can be done on the GPU. Fix several edge cases where texture storage was not copied back to images when redefining for mipmap generation. This resulted in the newly generated mipmaps not using the correct data. Bug: chromium:1256340 Change-Id: I76122d36385450d973bf00f7d07402a1f975492c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3406643 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll ed909ee8 2022-05-16T10:01:18 Roll SwiftShader from f1c2c0b07281 to 4011ab35f3d8 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/f1c2c0b07281..4011ab35f3d8 2022-05-13 capn@google.com Eliminate PointerType::getContainedType() calls If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I8f06eee1682353ea17f65c3c24e5b40d27503519 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3650395 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7f14dd79 2022-05-16T10:19:07 Roll Chromium from 3aa3e39b0aca to 11b60f867851 (666 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3aa3e39b0aca..11b60f867851 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a11973d87d..f1780da3e2 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f8b9fcc8e2..e112e5ec5b * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/cd5b90c8ef..cf88e03ee0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2c3dd587c4..c5e0fd55f4 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/0cb12a9e3d..9c1fa68883 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..25ac622b73 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7d20ae05d5..f8300fba9d * third_party/fuchsia-sdk/sdk: version:8.20220512.3.1..version:8.20220515.3.1 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/fa06aaa5d6..7085d03b26 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8e4f7b4946..56af55b3cb * tools/luci-go: git_revision:93b14d0f421647ad3bebf0ab4261c38f78bd1a8d..git_revision:29b908616bc920e58bf384d1e47b91b6cf9188b8 * tools/luci-go: git_revision:93b14d0f421647ad3bebf0ab4261c38f78bd1a8d..git_revision:29b908616bc920e58bf384d1e47b91b6cf9188b8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ebc4069589..e4bcd2f9b9 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/be0b201de9..f55fade59b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ad425ac080..10c637ea50 * tools/skia_goldctl/linux: iqtz2prn9CUv6A8KCcxJzadmPEDLY1FPP-b2YqIFQ1cC..0uXUbBwbtBy2u3GgA06bUzfb9y2dcexN9_F8ENIq1Q4C * tools/skia_goldctl/mac_amd64: Y4l14LBqCsT9EhffPIOtso9VSpwqQE9WccjZdDBZmLoC..81jsmJoHpyxpJgyeTsCH_yasXac9eXXRvGS_YABKrsUC * tools/skia_goldctl/mac_arm64: INEqc8JI_mtww_X0ShOlDkF3S8OG4tjF4Nkei0K7ci8C..VQHtaeoSlRCKe0xGCvdGxu6zvLoFkDyBtqZoTKoygDcC * tools/skia_goldctl/win: EbVQXa1u0hbZ8pxb0Il6Rbc1ErHpIN_-kMVOzBXMQyoC..l935F-47LSCA4iAc7FesGig8bpxMc5CaYheeyOc8LB4C No update to Clang. Bug: angleproject:2192,angleproject:6258,angleproject:7277,angleproject:905 Tbr: romanl@google.com,ynovikov@google.com Change-Id: I1673cf7aace2981526cf20ae704046eadbecc3c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3650530 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 48b1f07b 2022-05-11T15:20:24 Vulkan: Dynamic state for front face Bug: angleproject:5906 Change-Id: I649b9d2ab10daac6831f0ecb23f8211d3963c8c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3643098 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 4e5da2d2 2022-05-11T13:58:07 Vulkan: Dynamic state for cull mode Bug: angleproject:5906 Change-Id: I3d7b888e7999d4892ff71d636ea16a2edcf7a27f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3642800 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 62fe36d3 2022-05-04T22:46:52 Vulkan: Emulate YUV built-ins In this change, the rgb_2_yuv and yuv_2_rgb built-ins are emulated with normal functions that perform matrix multiplication based on the given conversion function. Bug: angleproject:6818 Change-Id: I67adb029109aaf6a674b1ee75105c1b352325eb2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3630599 Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 4b95ac7d 2022-05-12T11:29:11 Vulkan: Don't invalidate pipeline on dynamic state change Bug: angleproject:5906 Change-Id: I3a959dc5b1f62869ff77d62dce82555d00bd18e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3646427 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang 81c84292 2022-05-13T14:44:45 Do not do cleanup for Vulkan device lost When vulkan device lost happens caused by some gl calls, the GL calls may hold a lock in RendererVk. And ANGLE will try to cleanup resources in RendererVk. Those cleanup needs to hold the same lock as well. Since the lock is not recursive lock, acquiring the same lock again will cause deadlock. Fix the problem by not cleanup resources for device lost. It should be fine, all resource should be released when client destroy the lost context. Bug: chromium:1273643 Change-Id: I93ab0c966c8e9f3579b4e6742503d8588f16ebb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645497 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 808192a7 2022-05-09T16:39:45 Code Cleanup In Context::initCaps(), we first read the compressedTextureFormats from the contextImpl::getNativeCaps(), then we are clearing the retrieved compressedTextureFormats array in Context::updateCaps() immediately. We shouldn't need to fill the same array twice. Removing the first array value assignments in all backend. Bug: angleproject:3408 Change-Id: Iea85d367d2c5792de4780995d8d03bcf14af484e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3635275 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov 87058cb8 2022-05-13T18:14:46 Re-skip flaky test un-skipped by crrev.com/c/3641181 Bug: angleproject:1442, angleproject:7313 Change-Id: Iead8af6f5eec85cafcf373085ed663bb6f5f54e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645501 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov 1b434e96 2022-05-13T17:15:51 Skip flaky test on Mac NVIDIA. DepthStencilFormatsTestES3.DrawWithLargeViewport/ES3_OpenGL Bug: angleproject:7314 Change-Id: I3cb59a0a721f140f8c33845fb6ae5c04db13fbae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645499 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Roman Lavrov <romanl@google.com>
Gregg Tavares 4a7dd942 2022-05-12T12:34:29 Metal: Fix dangling pointer warning in IntermRebuild.cpp I don't think anything was wrong with the original code. This code is doing exactly the same thing but maybe won't trigger the warning? I have another version using std::vector if this fix is unacceptable. Bug: angleproject:7288 Change-Id: I122b8fc6600f6860ba96339c93a4ab9791ec789a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645992 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Min Zhang e56f227d 2022-05-13T08:50:12 Vulkan: Add case: TextureSampleByDrawDispatchDraw This case is used to verify the implicit synchronization when GL executables switch from draw to dispatch. Besides, suppress a VVL on it. Bug: angleproject:7031 Change-Id: Idab68cfd0d4b17685f5eb5b3eec7f2cad12e5877 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3646927 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll ece8fb5d 2022-05-13T13:54:07 Roll vulkan-deps from b768d03422ea to c6a60f3cc711 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/b768d03422ea..c6a60f3cc711 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/08cad0c015..8dc9ab5ce8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com,syoussefi@google.com Change-Id: If61e2e26be9cbfeb048b62573e135d1f354c0808 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3647317 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 03ccd9cc 2022-05-13T16:12:11 Revert "Vulkan: Flush texture updates more often" This reverts commit 8bb7c35c2159de2fa9e9a008679c692edd4402a6. Reason for revert: crashes tests in linux-rel Example: https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1012030/overview Also possible flakiness https://anglebug.com/7308 Repro: out/Debug/bin/run_blink_web_tests fast/canvas/OffscreenCanvas-2d-drawImage.html Original change's description: > Vulkan: Flush texture updates more often > > * Added a pointer to the previous texture in ShareGroupVk so we can > flush the texture updates once we switch to a new texture. > > * We check if mip levels 0 and 1 are conformant in terms of > size, format and number of samples. > > * As a part of size check, we also check depths if the texture > target is either 3D, 2D array, or cube map array. For the former > two, they have to conform to mip scaling similar to width and > height. For the latter, the depth represents layer-faces and does > not change for mipmaps. > > * Added a test to ensure the pointer to the previous texture is > deleted when the corresponding texture is deleted, so the old value > is not accessed by a future mutable texture. > > * Added tests to make sure the mutable texture is uploaded with > the appropriate mip level attributes, and not uploaded in cases of > size/format inconsistencies, incompleteness, and no base level. > > Bug: b/202744914 > Change-Id: I9c2c1af87a8a49e75d3ad25523436b0cd51a7e81 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3606329 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bug: b/202744914 Change-Id: Id51fd4c76d058aa5100ec58ba618098c8f614253 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645493 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Lingfeng Yang <lfy@google.com>
Jamie Madill 21ad9b3c 2022-04-07T09:57:26 Vulkan: Add generic descriptors for DS cache. With the new design, the descriptor set cache keys include all identifying information needed to reconstruct the update descriptor sets calls except the specific resource handles. The places for the resource handles are held by serials intead. When we miss the cache, we no longer need a second step to then construct the update calls, and can build the update calls directly from the key structures in combination with a list of resource handles. Bug: angleproject:6776 Change-Id: If1660a557585a75e9aa2560d6a38c56b62f555c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484981 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill d8d396db 2022-04-07T09:57:25 Vulkan: Add shared descriptor set caches. This allows programs with the same sets of descriptors to share descriptor sets. Currently there is no cache eviction. This CL adds a new "Meta" class to manage the descriptor set caches. Each shared descriptor pool is unique to a descriptor set layout. The descriptor set cache is moved into the pool class. Now every instance of a descriptor pool in ANGLE has easy access to a descriptor set cache as well. Bug: angleproject:6776 Change-Id: I06982e0349f5a87e4578e769fa356ce8e7ab49f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3424660 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki 0f2fc766 2022-05-04T12:51:15 TracePerfTest: Add ability to screenshot after reset. This patch makes --screenshot-frame take frame arguments that are greater than the frame range of the test. This makes it possible to capture screenshots after reset. E.g. the trace has 100 frames, the argument 1 and 101 should give the same result, but will differ if reset fails. Bug: angleproject:7307 Change-Id: Ie149e6046d0384d93341c677a7b391b5342917d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3644577 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 7dc316c8 2022-05-13T07:30:35 Roll Chromium from 65b23f3c9e05 to 3aa3e39b0aca (497 revisions) https://chromium.googlesource.com/chromium/src.git/+log/65b23f3c9e05..3aa3e39b0aca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cde1f18128..a11973d87d * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/bb1e46cb72..f8b9fcc8e2 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/3e0d3ec585..cd5b90c8ef * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1ca043c012..2c3dd587c4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..925e601986 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9997ceb9a1..7d20ae05d5 * third_party/fuchsia-sdk/sdk: version:8.20220511.3.1..version:8.20220512.3.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/b127460546..d56805c400 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/b84c093c1e..fa06aaa5d6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d3b6d7426a..8e4f7b4946 * tools/luci-go: git_revision:2aa3d7e5e8662c5193059a490f07b7d91331933e..git_revision:93b14d0f421647ad3bebf0ab4261c38f78bd1a8d * tools/luci-go: git_revision:2aa3d7e5e8662c5193059a490f07b7d91331933e..git_revision:93b14d0f421647ad3bebf0ab4261c38f78bd1a8d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5a3414a975..ebc4069589 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cd82e35115..ad425ac080 Clang version changed llvmorg-15-init-9576-g75f9e83a:llvmorg-15-init-10168-gc2a7904a Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/d3b6d7426a58b9a8bb68c9924b248843248c23ed..8e4f7b494694e524d05d8769bc87b3b54a719233/scripts/update.py Bug: angleproject:6496,angleproject:6937 Tbr: romanl@google.com Change-Id: Iaf3d127bbdc0f4b2740d1f48711c0f0d80d93eba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3647311 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 8bb7c35c 2022-03-23T19:14:54 Vulkan: Flush texture updates more often * Added a pointer to the previous texture in ShareGroupVk so we can flush the texture updates once we switch to a new texture. * We check if mip levels 0 and 1 are conformant in terms of size, format and number of samples. * As a part of size check, we also check depths if the texture target is either 3D, 2D array, or cube map array. For the former two, they have to conform to mip scaling similar to width and height. For the latter, the depth represents layer-faces and does not change for mipmaps. * Added a test to ensure the pointer to the previous texture is deleted when the corresponding texture is deleted, so the old value is not accessed by a future mutable texture. * Added tests to make sure the mutable texture is uploaded with the appropriate mip level attributes, and not uploaded in cases of size/format inconsistencies, incompleteness, and no base level. Bug: b/202744914 Change-Id: I9c2c1af87a8a49e75d3ad25523436b0cd51a7e81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3606329 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Jamie Madill addfab1f 2022-05-12T09:49:30 Update docs for SwANGLE triage process. - Removes mention of removed ToT ANGLE bots - Combines the triage process with auto-rollers - Removes mention of sheriffing the SwANGLE tree Bug: angleproject:6496 Change-Id: I9599f637fc6a054aac13d4004b480915c4a64341 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3644853 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Lubosz Sarnecki 8e844d0f 2022-05-10T15:24:32 Tests: Add Black Desert Mobile trace. Test: angle_perftests --gtest_filter="*black_desert_mobile*" Bug: angleproject:7139 Change-Id: Ia456b3e8266049970f0201f9c2041d0e7cdcac3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645269 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 389ae6b9 2022-05-09T08:44:50 Add extension for read-only DS feedback loops. This will facilitate testing. Also moves some feedback loop tests from FramebufferTest to a specialized test class. Bug: angleproject:4778 Bug: angleproject:4969 Change-Id: I61235f2663a58644bf506254a869f550f1706de3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3634726 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0