kc3-lang/angle

Log

Author Commit Date CI Message
Roman Lavrov 2f9d0810 2022-08-31T21:04:04 Revert "Sort items to avoid python2/3 diffs." This reverts commit b43a004567b060a6c01eb546bc7b055f00288c14. Reason for revert: causing merge conflicts across Android branches Original change's description: > Sort items to avoid python2/3 diffs. > > python3.x made ordering of iteration of built-in dicts match insertion > order which differs from python2. > > This will also make it easier to find things in .bp as keys will be in > sorted order. > > Bug: b/242929755 > Change-Id: I9c204fd7f8500b55ee4b24cbace0cc474dc48266 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3863009 > Commit-Queue: Roman Lavrov <romanl@google.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: b/242929755 Change-Id: I9c0f6fc8baa164b3256e93c4d1cfbd69c1797a4d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3863665 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov b43a0045 2022-08-31T10:58:06 Sort items to avoid python2/3 diffs. python3.x made ordering of iteration of built-in dicts match insertion order which differs from python2. This will also make it easier to find things in .bp as keys will be in sorted order. Bug: b/242929755 Change-Id: I9c204fd7f8500b55ee4b24cbace0cc474dc48266 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3863009 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang f602278c 2022-08-30T10:31:07 Vulkan: Parse human readable ARM driver versions. Update two workarounds to be gated on driver versions with fixes. Bug: angleproject:7370, angleproject:7556 Change-Id: I78e1cebb756b06c7fc926fb9ab27357cf3c7ce4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3863162 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll f2c01af2 2022-08-31T10:01:33 Roll vulkan-deps from db1584efaa9b to da42de1e5ad7 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/db1584efaa9b..da42de1e5ad7 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/67b79bcb00..bd411a0ce4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ic42416e29781cd75f4ced2785dffc51ec58a6c33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3866165 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a28b8135 2022-08-31T10:01:02 Roll SwiftShader from 476165cc7c0c to ecba967ea71f (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/476165cc7c0c..ecba967ea71f 2022-08-31 nicolascapens@google.com Revert "Workaround vkGetPhysicalDeviceProperties2() issue" 2022-08-31 nicolascapens@google.com Revert "Temporarily allow unsupported structures in PhysicalDevice::getFeatures2()" 2022-08-31 nicolascapens@google.com Revert "Workaround for dEQP-VK.info.device_mandatory_features failure" 2022-08-30 swiftshader.regress@gmail.com Regres: Update test lists @ 476165cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I45b55e0d0855070822671a62f21f29d76fd6057a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3863902 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 080b67ed 2022-08-31T07:02:21 Roll Chromium from 25d1a1a7a886 to 6511404d8c85 (577 revisions) https://chromium.googlesource.com/chromium/src.git/+log/25d1a1a7a886..6511404d8c85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/adc338f326..d74c52459f * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/cf8185c5cb..69f262d101 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/26e3467ee8..e5670a0e0e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d103a63729..7a1bf5f185 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/3057caab5d..65b2c6ba64 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/84e112ab4c..a40e46e3c0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..638d30eac6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f41670fdad..b0fb8d570d * third_party/fuchsia-sdk/sdk: version:9.20220826.3.1..version:9.20220830.2.1 * third_party/r8: UQXAUIg11QBR0HJg-Izctj2hg-wGB9cr6s-8oxTCQ-IC..fBkGW5rA8tbENWw27QnOET2E7L4k4HstrWKg4kIBzDQC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/25cf25b86e..b72e51a76b * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/80f9638812..e439d80e7e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c4ec909694..3e7faaebde Clang version changed llvmorg-16-init-907-g8b740747:llvmorg-16-init-3221-gce6989fd Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/25cf25b86e43c8de6a9a50ec0f77c2e4b3c3dc10..b72e51a76ba2050274beafde8d3b3fd8143e7e5a/scripts/update.py Bug: None Tbr: jonahr@google.com Change-Id: I1082fe94c5772d259e01d076a908618902340fa4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3866164 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yiwei Zhang e9cb83dd 2022-08-27T06:20:20 Vulkan: disable EGL_EXT_image_gl_colorspace sRGB texture upload for AHB backed external storage is broken. Disable EGL_EXT_image_gl_colorspace until that gets fixed. Bug: b/205995945 Test: SingleLayer_ColorTest_GpuSampledImageCanBeSampled_*_UNORM_sRGB Change-Id: I1be51f9f3528cd864709cf48ab0d949bb23cdfca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3859694 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Charlie Lao 7428369a 2022-08-29T17:59:38 Vulkan: Use macros for load/store Op check Use macro instead of inline function for result check so that the correct line number gets print out for the failed check. Bug: b/243711628 Change-Id: I1141f6a63fd01bb9fe0cf5c06b81b378e8acc08e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3864347 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Lingfeng Yang c8b0caf1 2022-08-29T15:08:22 Vulkan: Don't try to guess format mapping Either the implementation should tell us what Vk format it is, or it returns VK_FORMAT_UNDEFINED and we should take the "YUV" path, regardless of how un-YUV-like the format ID enum suggests it is. Bug: b/223456677 Change-Id: I979e9d19c466005350aeb8f88f2e0c092b545d51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3864024 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Lingfeng Yang <lfy@google.com>
Alexey Knyazev 00411e2c 2022-08-25T00:00:00 Support provoking vertex state query When ANGLE_provoking_vertex is enabled, glGetIntegerv should accept GL_PROVOKING_VERTEX parameter name. Bug: angleproject:2829 Change-Id: I6316de2c6b4cdbf4365df3ffb88f75c4b095f99c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3858264 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Kimmo Kinnunen c10326f1 2022-08-26T11:37:59 Make shader dump code compile after ShCompileOptions API change Make the output directory configurable with the define that turns on the dump feature. Write each aggregate struct in its own block of memory, so that if an aggregate changes, the binary format does not change so easily. Choose the filename based on the contents hash, so that multiple dump sessions do not produce excessive amount of dumps. Bug: angleproject:7612 Change-Id: Ifccd2d83e3361dc4633b601fd18f425c9ec44790 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3858263 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 2c373771 2022-08-30T10:08:44 Add include atomic, missing in Skia builds. Bug: angleproject:7602 Change-Id: I024981c880ed073c3a603f47b538d2375a911e1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3863161 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 7788fb6a 2022-08-30T10:01:33 Roll vulkan-deps from 7d94bcff7a00 to db1584efaa9b (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7d94bcff7a00..db1584efaa9b Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a98f05d02f..fca39d5cb4 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1396d7b36a..67b79bcb00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I873069ee48f349ef9a92e7b1799658d5c30948a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3864120 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6d43eb62 2022-08-30T07:01:08 Roll Chromium from 75cc1cb02dd7 to 25d1a1a7a886 (533 revisions) https://chromium.googlesource.com/chromium/src.git/+log/75cc1cb02dd7..25d1a1a7a886 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7e25322e49..adc338f326 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2f79c54fb4..d103a63729 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6552f9ba7b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b7ec673ccc..f41670fdad * third_party/r8: DnXL93qMVJmSx3c12aqaeAqcwE6_UB4cblftdipoe9UC..UQXAUIg11QBR0HJg-Izctj2hg-wGB9cr6s-8oxTCQ-IC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1eff359227..25cf25b86e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f3f47de60d..80f9638812 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1e4426f8bb..c4ec909694 No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: I203c0689b5702776c8dc0605a3dc81d1a4a4c19d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3864117 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 70c434b2 2022-08-29T17:09:23 Check max shader storage blocks support in test If the shader source code uses shader storage buffer objects, we need to check the corresponding GL_MAX_*_SHADER_STORAGE_BLOCKS is at least of size 1. Bug: angleproject:7583 Change-Id: I7f0e537e4dcfca8414cccb0088be8d34735633d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3863111 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi ac19624e 2022-08-26T21:29:53 Vulkan: Handle suboptimal like out-of-date If out-of-date can recreate the swapchain, so can suboptimal. Do so to better support window resizing on desktop. Note that on Android this was already being done. Bug: angleproject:7615 Change-Id: I3d1ce8ca45b002e5382e31fda003f02753a2c94e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3859409 Reviewed-by: Steven Noonan <steven@valvesoftware.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 64f41972 2022-08-25T11:16:23 Use canonical gl.xml and update enum to string function. This replaces our copy of gl.xml with the upstream canonical copy. Note that one patch is required before we can remove ANGLE's copy: https://github.com/KhronosGroup/OpenGL-Registry/pull/538 Because the upstream version uses a new method of enum groups, we also update our enum-to-string generator to use the new groups. This new code includes many more enums and groups in the mapping. Bug: angleproject:6461 Change-Id: I1c0ab44c36afce8db04c9661b377bbe5762c913e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3856649 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Sunny Sachanandani 32072905 2022-08-25T15:17:13 d3d11: Support rendering to GL_TEXTURE_2D target for YUV images YUV D3D11 texture plane EGLImages can be bound to TEXTURE_EXTERNAL_OES, but don't support rendering because ExternalImageSibling11::IsYUV() returns true. While it might appear that IsYUV() should return true for YUV D3D11 textures, the EGLImage siblings are actually for individual planes which are R/RG 8/16 and they can indeed be bound as render targets if we just return false for IsYUV(). This CL makes IsYUV() return false and adds a test for rendering to YUV EGLImages. Bug: angleproject:7610 Change-Id: I6c95a9521448e83a53153c1efaca70bd73e49818 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3856660 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll a18a0414 2022-08-29T17:03:47 Roll VK-GL-CTS from 435ebaff9214 to f08773d25d83 (15 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/435ebaff9214..f08773d25d83 2022-08-29 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main" into main 2022-08-29 aitor@lunarg.com Add dynamic rendering test for mixed inside/outside render pass commands 2022-08-29 arkadiusz.sarwa@amd.com Tests for AMD_shader_early_and_late_fragment_tests 2022-08-26 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main" into main 2022-08-25 piotr.byszewski@mobica.com Fix enabling of partially promoted extensions 2022-08-25 piotr.byszewski@mobica.com Fix subpassMergeFeedback mandatory feature check 2022-08-25 piotr.byszewski@mobica.com Fix aliases of aliases 2022-08-25 marcin.zajac@mobica.com Depth and stencil clears in dynamic rendering 2022-08-25 john.anthony@arm.com Add support for VK_EXT_rasterization_order_attachment_access 2022-08-25 piotr.byszewski@mobica.com Test clears of 3D depth/stencil images 2022-08-25 pdaniell@nvidia.com Use multi-level multi-layer compressed image views 2022-08-25 pdaniell@nvidia.com Reenable texel_view_compatible 3d_image tests 2022-08-25 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main 2022-08-25 piotr.byszewski@mobica.com Run DR tests with secondary command buffers 2022-08-24 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_attachment_feedback_loop_layout into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,jonahr@google.com Change-Id: I5d62b659451129f887f30bb2ea97a8fd1df45c5b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3862409 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov f18b6335 2022-08-29T11:53:01 Replace std::this_thread::get_id() use with a unique thread id. std::this_thread::get_id() gets recycled. It's pthread_self() under the hood on Linux and Android which gets recycled, for example when one thread terminates and another one starts it is likely to return the same value. Bug: angleproject:7602 Change-Id: I83d818bc17ead5cce8bce7f7d88fc1c7c0fa860c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3855041 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 9fb05a88 2022-08-26T22:26:33 Vulkan: SPIR-V Gen: Remove suppression of passing tests Some tests were suppressed during development. Try enabling them again. Bug: angleproject:6210 Change-Id: I7b52307a26fb9351773a591901a9c5bbb4703466 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3859411 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Solti b9df3551 2022-08-15T17:42:53 update CopyTextureCHROMIUM to match Chromium Overview: This CL makes the validation of *CopyTextureCHROMIUM* and *CopySubTextureCHROMIUM* in ANGLE behave consistently with CHROMIUM. The new behavior is: ``` INVALID_OPERATION is generated on ES 2.0 if <sourceId> refers to an external texture (OES_EGL_image_external), <destId> refers to a texture with an integer-type internal format, and the underlying context does not support OES_EGL_image_external_essl3. ``` Tests: ===== CopyTextureCHROMIUM ===== add a test in ES 2.0 to test the API with the error case. ===== CopySubTextureCHROMIUM ===== add a test in ES 3.0 to test the error case. in ES 2.0, the error case cannot happen because "glTexImage2D()" doesn't support integer formats - ran all CopyTextureTest on gLinux: ```autoninja -C out/Debug && xvfb-run out/Debug/angle_end2end_tests --gtest_filter=*CopyTextureTest* --verbose``` - ran all CopyTextureTest on Android test phone: ```autoninja -C out/Android && out/Android/angle_end2end_tests --gtest_filter=*CopyTextureTest* --verbose``` Bug: angleproject:4228 Change-Id: I1cb77c72750add5f399013d3d30eed7acf8d0a50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3826166 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 4b33633a 2022-08-26T16:16:50 Capture/Replay: Delete binary data in FinishReplay via callback Delete callback fixes b/179188489 as delete[] will get called from the same module where allocation happens. When decompress/delete callbacks not provided, new[] and delete[] are called from the fixture. AFAICT, gBinaryData == nullptr every time, even with a single test and --gtest_repeat=N, so we never delete the uncompressed data. When running multiple tests locally, I see RES usage grow significantly on Linux which this CL fixes. I don't think this matters for bot runs as we run tests one by one there. Bug: b/179188489 Change-Id: Iee3bccb9d6d72c315c4358b70ec9c3c0ac963258 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3858185 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuly Novikov cd0f642e 2022-08-29T17:25:33 Fix loading end2end test expectations on iOS Need to be packed and found in the application bundle. Bug: angleproject:5417 Change-Id: Iaf84ced0de6674a807aa747e71dbbf2715bbd6fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3860831 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Eddie Hatfield ba4b6913 2022-08-23T09:34:27 Fix data race in BlobCache * Re-enable shader cache feature * Improve BlobCache thread-safety test * Improve EGLProgramCacheControlTest to not check the size of the BlobCache, since the shader cache interferes with this. * Include the arguments to ConstructCompiler() and Compile() in the key hash for the shader cache. Bug: angleproject:7036 Change-Id: Ied4e11f9160552f2f9358d99b5656315239ba856 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3851161 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
Kimmo Kinnunen 5ef3960b 2022-08-29T12:50:26 Use correct seed type for XXH32 fuzzer Patch by: David Kilzer <ddkilzer@apple.com> Use unsigned int as the seed type as expected, instead of unsigned long long. Helps compiling with strict compile flags. Also fix a bug where short buffers would test XXH64 instead of intended XXH32. Bug: angleproject:7618 Change-Id: If63318fbc932349db4ab82aa8abadc9bab655989 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3860830 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll c63f9bcc 2022-08-29T10:01:32 Roll vulkan-deps from eb46f95f20dc to 7d94bcff7a00 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/eb46f95f20dc..7d94bcff7a00 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/10423ec659..9e78bc8108 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6086f7993d..1396d7b36a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I77417e906b521154933a59543754812424cd47d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3860585 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4d182868 2022-08-29T10:01:01 Roll SwiftShader from 6517262b2386 to 476165cc7c0c (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/6517262b2386..476165cc7c0c 2022-08-27 swiftshader.regress@gmail.com Regres: Update test lists @ 6517262b 2022-08-27 bclayton@google.com Reimplement GLSLstd450Ldexp 2022-08-26 capn@google.com Compute fragment coordinates for wider SIMD groups 2022-08-26 capn@google.com Rename pixel coordinate variables 2022-08-26 capn@google.com Compute relative fragment coordinates just once 2022-08-26 capn@google.com Compute the primitive's origin coordinates only once If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ic5488a2f1f86a02f61dbdff69046f68eb90bb0c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3861126 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0533280f 2022-08-29T07:02:02 Roll Chromium from 21906127bee6 to 75cc1cb02dd7 (625 revisions) https://chromium.googlesource.com/chromium/src.git/+log/21906127bee6..75cc1cb02dd7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5221aeee35..7e25322e49 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/11747ae48c..cf8185c5cb * buildtools/linux64: git_revision:0bcd37bd2b83f1a9ee17088037ebdfe6eab6d31a..git_revision:5705e56a0e5856621415cfdf444432554e72c9c9 * buildtools/mac: git_revision:0bcd37bd2b83f1a9ee17088037ebdfe6eab6d31a..git_revision:5705e56a0e5856621415cfdf444432554e72c9c9 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/aa3a6cd0f1..26e3467ee8 * buildtools/win: git_revision:0bcd37bd2b83f1a9ee17088037ebdfe6eab6d31a..git_revision:5705e56a0e5856621415cfdf444432554e72c9c9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fcc4b4c209..2f79c54fb4 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/22c65e6ceb..0733c941ff * third_party/android_build_tools/lint: nklp_LHwFqk9tuQm1yHGBy2W16YMz_R7Q7vcnZZnF78C..JpRGSVY_dRFR9MLSN_235CfYK4S9jovg0yqlX98htXIC * third_party/android_build_tools/manifest_merger: CvokX4c6dx7DwQ8VVMQ70CROzyJWg13oOq3feeuTzg8C..tAZpJUnwhFBJmu1ctEKYMLJp7l3qJufDu7ByW6waq3QC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/eef35e6d64..84e112ab4c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2417ba3d0d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/95f870fb5d..b7ec673ccc * third_party/fuchsia-sdk/sdk: version:9.20220825.3.1..version:9.20220826.3.1 * third_party/r8: _rv7EargK1mPOQPb7922ENB7-AaUTJZCxBWNBeLVsfQC..DnXL93qMVJmSx3c12aqaeAqcwE6_UB4cblftdipoe9UC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/673c407b6e..1eff359227 * tools/luci-go: git_revision:a0ba80649473055bae3d789eec28c9967adb5e45..git_revision:3226112a79a7c2de84c3186191e24dd61680a77d * tools/luci-go: git_revision:a0ba80649473055bae3d789eec28c9967adb5e45..git_revision:3226112a79a7c2de84c3186191e24dd61680a77d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/29848909aa..f3f47de60d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e54496f219..1e4426f8bb No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ie1b6638269c04c3f668ae122b90effd58ca299d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3860584 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi bec40d76 2022-08-26T21:28:53 Vulkan: Set SPIR-V Generator version to 1 Let's call it officially no longer experimental. Bug: angleproject:6210 Change-Id: I7c5ae91dff0ff189f93e67fe1cd0721771c67275 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3859410 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu ac2aeccd 2022-08-25T17:43:43 Check GL_MAX_VERTEX_SHADER_STORAGE_BLOCKS in test If the vertex shader uses shader storage buffer objects, we need to check GL_MAX_VERTEX_SHADER_STORAGE_BLOCKS is at least of size 1. Bug: angleproject:7185 Change-Id: I98d83f9f0cc30e92fdcaee15541fdde96652b38e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3858144 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu cb618b3d 2022-08-25T13:30:26 Vulkan: Remove useRelaxedPrecision Bug: angleproject:7488 Change-Id: I30ca3e2740d8810a01615ca778eb072d77ad34d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3856658 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 2d48a370 2022-08-26T11:11:19 Vulkan: Support passthrough of colorspace attributes On Android, the EGL loader supports and implements the necessary functionality for the following colorspace extensions - 1. EGL_EXT_gl_colorspace_display_p3 2. EGL_EXT_gl_colorspace_display_p3_linear 3. EGL_EXT_gl_colorspace_display_p3_passthrough 4. EGL_EXT_gl_colorspace_scrgb 5. EGL_EXT_gl_colorspace_scrgb_linear Add support for "EGL_ANGLE_colorspace_attribute_passthrough" extension that allows vendors that support wide color gamut to passthrough colorspace attribute values to the underlying Vulkan implementation to be used during VkImage creation. Bug: angleproject:7319 Test: PbufferColorspaceTest.CreateSurfaceWithColorspace* Change-Id: Ibd78bb5fea4ede394f4dc5027c1d4a730746f2ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3855048 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Eddie Hatfield 98d5db70 2022-08-25T16:50:38 Add capture functions for desktop GL entry points The parameter capture functions are left unimplemented for now. Bug: angleproject:7533 Change-Id: Ief356e7401805cf9b417e1f5cc3790011237e03f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3858618 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
Chris Dalton 6ba8582b 2022-08-05T16:16:01 Add a fix on all backends for images as function arguments The ESSL spec has a bug with images as function arguments. The recommended workaround is to inline functions that accept image arguments. Bug: angleproject:7484 Change-Id: I8fc0826f330c68150de5c3d1758c10c3e37bbf04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3813050 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 40782cf5 2022-08-26T09:00:07 Roll Chromium from 32095292c129 to 21906127bee6 (499 revisions) https://chromium.googlesource.com/chromium/src.git/+log/32095292c129..21906127bee6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c384292cf5..5221aeee35 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/3fe17aa694..11747ae48c * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/60c266d87c..aa3a6cd0f1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/adf23740b2..fcc4b4c209 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/c0dd90cacc..eef35e6d64 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8e773a22c9 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/19b3eb5adb..95f870fb5d * third_party/fuchsia-sdk/sdk: version:9.20220825.0.1..version:9.20220825.3.1 * third_party/r8: QXtnqOo6mUvEBgxfd_2YYYeMxB5fcgIDXmNAmf73VGEC.._rv7EargK1mPOQPb7922ENB7-AaUTJZCxBWNBeLVsfQC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/8d1d3e3419..926ac230d7 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0d2d645c85..673c407b6e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/14ffc6ca5d..29848909aa * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/46207450df..e54496f219 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I32f8ba999da49c3344875db59cb0bebe06cd7d4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3858156 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll efea3934 2022-08-26T10:01:32 Roll vulkan-deps from e623f608cbf3 to eb46f95f20dc (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e623f608cbf3..eb46f95f20dc Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b87209ca72..6086f7993d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ifa44826f33302b0dedca5cda6ae883e626edc693 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3858157 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki 02eb5f49 2022-08-19T12:41:11 validation: Annotate kEnumNotSupported errors with values. Use validationErrorF to annotate all unsupported enum errors with the corresponding value of the enum in hex. This makes the errors more meaningful and reduces the amount of debugging required to find out the invalid enum used. Add kEnumInvalid error string in cases an InvalidEnum is provided and can't be resolved to the given GL enum. Before: glEnable: GL error: HIGH: Enum is not currently supported. After: glEnable: GL error: HIGH: Enum 0x809D is currently not supported. Bug: angleproject:7595 Bug: angleproject:7596 Change-Id: Iff060a1c3a2f482f4df5b5b7ea036b93025df7d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3849475 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 320bfde0 2022-08-22T00:00:00 Hide emulated ETC2/EAC formats from WebGL contexts In addition to not exposing the dedicated ANGLE-specific extension name, do not add these formats to the internal formats table. Bug: angleproject:7601 Change-Id: I2e3fdd99129823b8092bfa35cb95023ae5008edd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3853591 Auto-Submit: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Chris Dalton 9d41585e 2022-08-12T14:20:34 Make PLS coherent on D3D 11.3 Adds a new internal memory qualifier to the compiler called "rasterOrdered", which we set in RewritePixelLocalStorage.cpp when D3D 11.3 Rasterizer Order Views are supported. The HLSL translator then generates RasterizerOrderedTexture2D<> instead of RWTexture2D<> when this qualifier is set. Bug: angleproject:7279 Change-Id: I39b8c3279b7bff93b7e57272e8fb84d9c0312616 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3830288 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Lubosz Sarnecki cedc23d8 2022-08-19T12:41:20 validation: Annotate kInvalidInternalFormat errors with values. Use validationErrorF to annotate all internal format errors with the corresponding value of the internal format enum in hex. This makes the errors more meaningful and reduces the amount of debugging required to find out the invalid format used. Before: glCompressedTexImage2D: GL error: HIGH: Invalid internal format. After: glCompressedTexImage2D: GL error: HIGH: Invalid internal format 0x8B94. Bug: angleproject:7595 Bug: angleproject:7596 Change-Id: I6b9c116863e0116f96b8ff0e71e9734947a1c1c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3849476 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Chris Dalton 51de3837 2022-07-28T00:05:54 Enable PLS on D3D Bug: angleproject:7279 Change-Id: Ide498e6ebadc5cd567dc64cd1efed52e777aa32e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3790473 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill f6842cc2 2022-08-25T10:23:32 Revert override for desktop GL extensions in gl.xml. Instead override the supported APIs in registry_xml.py, which will transfer to using the canonical gl.xml. Note these are desktop-GL-only extensions that ANGLE exposes in GLES: GL_ARB_sync GL_NV_robustness_video_memory_purge Bug: angleproject:6461 Change-Id: I25778149ecfc3cb4be0aca2104c08273c260c564 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3856648 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 5bcfad04 2022-08-25T10:32:57 Vulkan: Add a handful of features This commit bunches a couple of features in one to reduce merge conflicts. Bug: angleproject:4836 Bug: angleproject:5845 Bug: angleproject:7162 Bug: angleproject:7319 Bug: angleproject:7604 Change-Id: Icbb33f5b6d61822c5f4a61f08078bb2de4e7d2fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3856646 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki 68b6206e 2022-08-19T16:39:01 FrameCapture: Fix capturing glBindRenderbuffer on GLES1. Use FramebufferCaptureFuncs when capturing glBindRenderbuffer calls on GLES1 contexts, since they require the GL_OES_framebuffer_object extension and will otherwise crash on certain native GL drivers. Bug: angleproject:7596 Change-Id: I7be1b0dee38c9186b657489ca76bf769f47caeb1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3849478 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Shahbaz Youssefi 80a9ee71 2022-08-25T01:03:09 Fix translator fuzzer The GLSL mac-only options were being listed as unsupported only when the output is not GLSL. However, they should also be listed as unsupported on GLSL output when not on mac. Bug: chromium:1355076 Bug: chromium:1355281 Change-Id: I5a87d9a529e534b2ea6c030ad7132cd0f698e7d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3855700 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Jamie Madill a35728bd 2022-08-25T12:13:39 Skip several Multithreading Tests on SwiftShader. Because any of the tests could flakily hang, it's better that we skip the group entirely until we have the ability to add flaky retries as test expectations. Bug: angleproject:6261 Change-Id: I59d686d983ff5123a2c8cb40f3c1d808c611b20e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3856651 Auto-Submit: Jamie Madill <jmadill@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Jamie Madill 5d62c05e 2022-08-24T13:17:14 Use canonical Khronos registry XML files for auto-gen. This switches ANGLE to use the upstream XML files for the CL, EGL GLX and WGL APIs. Since gl.xml has a few more significant diffs from the upstream version, that work will come in another CL. This also removes an ANGLE EGL ext that was added upstream. Bug: angleproject:6461 Change-Id: I29ead5edc13a4256d1f702c330a5d3d233502cd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3854318 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny b688c909 2022-08-11T13:14:49 Capture/Replay: save and restore UNPACK_ALIGNMENT in MEC MEC replay requires an unpack alignment of one. When creating a trace the call to set this alignment is emitted, but it is not actually set in the context, so that the captured context state records the actual unpack alignment. When replaying, the call to set the unpack alignment to one is executed, and the context state changed, so that comparing the captured context to the replay context will fail if the original alignement was not one. Restore the original alinment in the context setup functions to ensure that the context state holds the same state information when replaying like when the trace was captured. Bug: angleproject:7564 Bug: angleproject:7180 Change-Id: I09d9bf77bc0193bdf9f41b6183f1ee8d66c5e563 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827346 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi a69e53c5 2022-08-22T16:23:08 Vulkan: Move vertex stride assert Bug: fuchsia:107106 Change-Id: I82c34b5c450f39f2869c8fd6ae938b2cdfc5af13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3846404 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki 15b1678f 2022-08-19T13:13:42 FrameCapture: Add VertexArrayCaptureFuncs. Analogously to FramebufferCaptureFuncs, append OES suffixes to vertex array related functions on GLES1 contexts. These functions require the GL_OES_vertex_array_object extension and will crash on certain native drivers without the OES suffix. This resolves the following validation error when replaying GLES1 traces captured using MEC on ANGLE: glBindVertexArray: GL error: HIGH: OpenGL ES 3.0 Required. Bug: angleproject:7596 Bug: angleproject:7608 Change-Id: I603efae4a8d61b84b7711effb2e7e1d8d52e3d83 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3849477 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll ab9fddb7 2022-08-25T10:01:27 Roll SwiftShader from 67f88061d2d4 to 6517262b2386 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/67f88061d2d4..6517262b2386 2022-08-25 capn@google.com Clarify negativeOneToOne depth clipping comments 2022-08-24 syoussefi@google.com Implement VK_EXT_depth_clip_control 2022-08-24 nicolas.capens@gmail.com Consistently print bitmasks as hexadecimal If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ifa193229bb1e99222ea45f56a11dd26d32d8c96b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3856296 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll ccbc0289 2022-08-25T10:01:32 Roll vulkan-deps from 188a44aaa198 to e623f608cbf3 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/188a44aaa198..e623f608cbf3 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/0bcc624926..93754d52d6 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/dd4f17a7b9..b87209ca72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I080ec038799b26d5cd879c4d5bf962adbd8d44b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3853347 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f556b918 2022-08-25T09:36:29 Roll Chromium from 5377f9824cad to 32095292c129 (473 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5377f9824cad..32095292c129 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/90d51f4aef..c384292cf5 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/dbde006685..3fe17aa694 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/f30089a416..60c266d87c * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/3dc2f80d34..48afced8aa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/016880dac8..adf23740b2 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/4ef58b7319..22c65e6ceb * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/a4bb552cde..3057caab5d * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d4fa09c046..c0dd90cacc * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3fdc858272 * third_party/fuchsia-sdk/sdk: version:9.20220823.1.1..version:9.20220825.0.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/dd32a150e7..1c95dd77bf * third_party/r8: tqdAlBozEG54h6NC2UQmRoNYSoz4oMEckckPdZSOYEkC..QXtnqOo6mUvEBgxfd_2YYYeMxB5fcgIDXmNAmf73VGEC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0fc72d33ca..0d2d645c85 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/807f466a48..14ffc6ca5d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/437abfc7fb..46207450df No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ib113b74467d402b547c7356eaed309bfc7619e69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3853346 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny c394adfc 2022-08-11T10:43:14 ANGLE: reorder program and shader creation When MEC re-creates the program creation, it first creates the program, and then the shader stages, and since the Handles are handed out from the same handle allocator, the numbers are different if the creation order is different. Since the logic to capture a shader program is more involved to be changed, re-arrange the calls in CompileProgramInternal. Bug: angleproject:7564 Change-Id: I28617cc67e7ca59d8ce181785cc159fe876655b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3826257 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Bryant Chandler efa9a4d9 2022-08-24T22:08:38 Rename README.angle to README.chromium The extension needs to be `.chromium` for compatibility with tools/licenses.py Bug: chromium:1355665 Change-Id: Iabc26bd96ec8b71cf8546ff0ec05172fb8d82ca1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3855396 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Charlie Lao b9bc09cb 2022-08-24T13:15:45 Vulkan: Always enable mVirtualBlockMutex Right now this is only enabled if async queue submission is enabled. I think this is a bug that we have to always enable the lock, since suballocation destroy could come from any threads. Bug: b/236098131 Change-Id: I0fda61e5db3ff60f776b8d4917a9f10dafed6b1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3855203 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
Eddie Hatfield d89c027e 2022-08-22T11:40:40 Add unimplemented GLX entry points to desktop GL Test: Run glxgears and hit unimplemented in ANGLE Bug: angleproject:7533 Change-Id: Ic7ed7506b6d0c5ef5022ae6899cbd6c4d351b178 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3852631 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Eddie Hatfield <eddiehatfield@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 91850a24 2022-08-24T14:54:43 Add flaky reties to Mac GL dEQP-GLES 2 & 3 tests. A persistent flaky crash is still hitting our CI and Try bots. See issue for more info. Bug: angleproject:6570 Change-Id: I56aabd91913171ba84425511e7fcc3ead9613512 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3855043 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 6e784d9c 2022-08-24T09:57:29 Roll Chromium from 02dbf021e1a1 to 5377f9824cad (537 revisions) https://chromium.googlesource.com/chromium/src.git/+log/02dbf021e1a1..5377f9824cad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ba78bc1980..90d51f4aef * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6f3cc96d10..dbde006685 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/c58c612d74..f30089a416 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/6c17e7c636..3dc2f80d34 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d315e68997..016880dac8 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0a09f6037a..d4fa09c046 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9bfc1aede5 * third_party/fuchsia-sdk/sdk: version:9.20220822.3.1..version:9.20220823.1.1 * third_party/r8: 2P7CTTsDUzoP3f8LtGNRdtwC48KAMmV-hPoNhGAwiKMC..tqdAlBozEG54h6NC2UQmRoNYSoz4oMEckckPdZSOYEkC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5f3c54dbcc..0fc72d33ca * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ad8b831158..807f466a48 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/62249027a7..437abfc7fb No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ib6967df3a44ea58df98d7e4aef2274973a4596de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3853595 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop 28600f60 2022-08-21T21:51:19 Test: Add Antutu Refinery trace Test: angle_perftests --gtest_filter="*antutu_refinery*" Bug: angleproject:7590 Change-Id: I967c72a4109baf64cda1afc3d27407286253ea35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3844790 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Tom Anderson 3e9d8f43 2022-08-23T20:00:20 Fix build with -Wextra-semi Change-Id: Ibda56f1c3ad3e2851997cba93de5bc32b4606300 Bug: chromium:1355871 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3851180 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
angle-autoroll 1393ba6d 2022-08-24T10:01:32 Roll vulkan-deps from 1b46e43d5ccc to 188a44aaa198 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1b46e43d5ccc..188a44aaa198 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/61c603f3ba..c93ee9261e * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3c1a14b2b6..a98f05d02f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/55f77c5de1..dd4f17a7b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I7a72024a3075a04798da3ffec3ebaa2d1d0c3167 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3853596 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll f1f7f3a2 2022-08-24T12:53:27 Roll SwiftShader from c21aa26e0256 to 67f88061d2d4 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/c21aa26e0256..67f88061d2d4 2022-08-23 nicolas.capens@gmail.com Implement VK_EXT_rasterization_order_attachment_access support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I84f72dca542a544f19dffe6c2b701d4d908d4403 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3853488 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Eddie Hatfield 5317b778 2022-08-23T08:58:04 Enable desktop GLSL for desktop GL frontend Bug: angleproject:7533 Change-Id: I91bd0c217880b05683b86449a9211b9844575ebc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3850471 Commit-Queue: Eddie Hatfield <eddiehatfield@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuly Novikov f7274de2 2022-08-24T14:26:50 Skip EGLMultiContextTest.ReuseUnterminatedDisplay on Pixel 4 GLES Since it causes this combination of tests to crash there: EGLMultiContextTest.ReuseUnterminatedDisplay/ES3_1_OpenGLES ComputeShaderTest.ImageLoadMipmapSlice/ES3_1_OpenGLES CopyTexImageTest.CopyTexSubImageFromCubeMap/ES2_OpenGLES_EmulateCopyTexImage2DFromRenderbuffers Also tentatively skip on Win Intel Vulkan due to similar flakiness in: Texture2DTest.CopySubImageFloat_RGB_RGB/ES2_OpenGL_EmulateCopyTexImage2DFromRenderbuffers Texture2DTest.TexImageUnpackRowLengthPBO/ES2_OpenGL_EmulateCopyTexImage2DFromRenderbuffers Texture2DTest.TexImageWithLuminancePBO/ES2_OpenGL_EmulateCopyTexImage2DFromRenderbuffers Texture2DTest.TexImageWithRGBA4444PBO/ES2_OpenGL_EmulateCopyTexImage2DFromRenderbuffers Texture2DTest.TexStorage/ES2_OpenGL_EmulateCopyTexImage2DFromRenderbuffers Bug: angleproject:7602 Change-Id: I5be9e23bfabe6be345caaca3c5ca9bed19112903 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3854603 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cody Northrop 94a23a4e 2022-08-21T19:52:50 FrameCapture: Fix separable shader uniform locs Uniform locations are tracked by traced program ID, not remapped program ID. This was creating code that used incorrect locations and would immediately crash. For instance, the following code: glProgramUniform4fv(gShaderProgramMap[92], gUniformLocations[gShaderProgramMap[92]][12], 1, reinterpret_cast<const GLfloat *>(&gBinaryData[0])); gShaderProgramMap[92] happens to remap to 54 during replay. But if you look in UpdateUniformLocation, we track uniform locations based on the trace program (92): // Example call: UpdateUniformLocation(92, "fullmatrix", 0, 1); void UpdateUniformLocation(GLuint program, const char *name, GLint location, GLint count) { ... gUniformLocations[program] = programLocations.data(); } So when gUniformLocations[gShaderProgramMap[92]] is used, it tries to look up uniform locations for 54, which don't exist, and returns nullptr. To fix, don't use gShaderProgramMap when looking up locations of uniforms. This only affects separable programs. Normal glUniform calls use gCurrentProgram which is already the trace program (92). The new code looks like this: glProgramUniform4fv(gShaderProgramMap[92], gUniformLocations[92][12], 1, reinterpret_cast<const GLfloat *>(&gBinaryData[0])); Test: Antutu Refinery MEC Bug: angleproject:7590 Change-Id: I079923ec8d938356e72e929d61f80c7fc371a95b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3844642 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 429a7cab 2022-08-21T19:50:32 FrameCapture: Fix cube face as framebuffer This fix is required for Antutu Refinery benchmark, which has cube faces mapped as framebuffer attachments. Test: Antutu Refinery MEC Bug: angleproject:7590 Change-Id: I5eec5fcbe12ac7486499b047a4b7564b3bc2690f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3844641 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Mohan Maiya aa2a558e 2022-08-23T09:47:02 Vulkan: Add support for setting timestamp surface attribute On Android the EGL wrapper handles most of the functionality required by EGL_ANDROID_get_frame_timestamps. However if for some reason the swapchain is recreated, the timestamp state would be lost resulting in stuttering. Introduce EGL_ANGLE_timestamp_surface_attribute extension that adds support for toggling the EGL_TIMESTAMPS_ANDROID attribute of a surface. Cache this state and recreate the swapchain accordingly. Bug: angleproject:7489 Test: EGLSurfaceTest.TimestampSurfaceAttribute* Test: dEQP-EGL.functional.get_frame_timestamps* Change-Id: I3660f7137c006d904164d243a682a4ff520eabd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3753396 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Yuxin Hu f10625d3 2022-08-11T14:32:45 Enable Robustness Extension on ARM These dEQP tests failed due to Robustness was disabled: dEQP-GLES31.functional.debug.negative_coverage.callbacks.buffer#readn_pixels dEQP-GLES31.functional.debug.negative_coverage.log.buffer#readn_pixels dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer#readn_pixels dEQP-GLES31.functional.debug.error_filters#case_12 dEQP-GLES31.functional.debug.error_groups#case_12 Re-enable the Robustness Extension on ARM to check if mali driver supports GL_EXT_robustness extension now. If it does we can enable the robustness feature in ANGLE so that the above dEQP tests can pass. Bug: angleproject:7351 Bug: angleproject:4823 Bug: angleproject:2330 Change-Id: Ifce20e410607f2d4b6b3b55235081fef690c983c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3828441 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 13456bfc 2022-08-23T13:33:13 Propagate device type in another eglGetPlatformDisplayEXT call. Same as https://crrev.com/c/3759712 for another test. Also use !platformSupportsMultithreading() to skip tests. However, need to skip separately from capture/replay where multi-threaded tests seem to run into issues. Bug: angleproject:7494 Bug: angleproject:7423 Change-Id: Ief87b4163aedd26b440987540c06ceb7ae8a575b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3851166 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuly Novikov f0b4e8b2 2022-08-23T17:12:44 Fix loading ANGLE libraries on iOS Previously end2end tests would try to load libEGL.framework/libEGL.framework instead of libEGL.framework/libEGL Bug: angleproject:5417 Change-Id: Iccb9ad20df980dfd460219dbcaf9b273aef9c7dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3851164 Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Yiwei Zhang 41c01134 2022-08-23T06:00:04 Extend the image test to verify RGBX AHB and GL_RGB upload This changes updates the RGBXAHBImportThenUpload test to do texture upload to the right side and adds a new helper to validate the render result on both sides to check the upload respects the GL_RGB channels. Bug: b/238460927 Test: ImageTestES3.RGBXAHBImportThenUpload Change-Id: I61723e7db99dab78b7828b783bb7cdf062f39ad9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3849462 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yiwei Zhang df946856 2022-08-22T20:36:52 Map RGBX AHB to GL_RGBX8_ANGLE and fix the load function AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM was false mapped to GL_RGB8, which will write back to the backing exteranl storage with 3 channel layout. Angle actually has ANGLE_rgbx_internal_format to fix the mapping with GL_RGBX8_ANGLE. However, the load function must align with GL_RGB8 if the actual storage is 4 channel. This change also fixes that to use LoadToNative3To4<GLubyte, 0xFF>. Bug: b/238460927 Test: CtsNativeHardwareTestCases#SingleLayer_ColorTest_*_R8G8B8X8_* Test: ImageTestES3.RGBXAHB* pass without VVL error Change-Id: Ic5db4cb4adba252949d64e560ff32e492a045912 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3846413 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com>
angle-autoroll eab2d546 2022-08-23T10:14:33 Roll vulkan-deps from 186a4d4b9dea to 1b46e43d5ccc (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/186a4d4b9dea..1b46e43d5ccc Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/40315fa5c0..55f77c5de1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I3d925dd82f280ca7b69d71c544e8aa3a425dfb19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3849474 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7131475e 2022-08-23T08:37:28 Roll Chromium from e1b4daf2a3e7 to 02dbf021e1a1 (568 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e1b4daf2a3e7..02dbf021e1a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/facb235241..ba78bc1980 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a30c0d90b3..d315e68997 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9bfc1aede5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/44b73307ee..19b3eb5adb * third_party/fuchsia-sdk/sdk: version:9.20220821.3.1..version:9.20220822.3.1 * third_party/turbine: RxaW8ZVJZ7rF3dbAGbL1OV6f9ZELjVeiiQbpkDsuxA4C..cMFT-KTiKSkVefC3nASLc0KQv9JrVmwmFUgJlo6jOosC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bd2da0345a..5f3c54dbcc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/398778992d..62249027a7 * tools/skia_goldctl/linux: eVmrBHTaHLBRrBHBIagAjRi84M8Pih7goWAjl0ZL9H0C..BcL4zQgD0tZoFzhWm37NnERAPLdbeERfbY_SSBQ3ba4C * tools/skia_goldctl/mac_amd64: 3fnB8n0m7xQ9X4SWg4rYgZksJ4YFew0fj6ftsyHzbSwC..8DiQ6WFPrEn56-jwyQmU4EMXFvf7_-8SYjVD2hHHmZMC * tools/skia_goldctl/mac_arm64: J_MizgwQbTOCG1ZKfGQJRXm-F2Ey8P3M7Dl5WxYKEwwC..lJ8l4RCPxwrg_f-Z9Lnu3Ma3uRlbRbAcdQA7xwpIzNUC * tools/skia_goldctl/win: aYli_YA93vex9TPItiLM1AcLs64FzefvhXxh2aHEvJsC..1l0XEVvr2qVUdGYrjLN9Gkt6qfv8KsXM52B8MKDShmEC No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I3f559e4bc087b0a90f31e6b8b9a655e7cf9adc27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3849466 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 6fde3568 2022-08-09T16:42:17 Spec out the PLS client API Drafts the additions to the OpenGL ES 3.0 spec for pixel local storage. Bug: angleproject:7279 Change-Id: Ibc0d227142ac51f5d3820f27c9114779d846ffc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3824171 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya b32091b4 2022-08-17T16:00:02 Vulkan: Bug fix related to pre-rotation code Account for possiblity that the draw and read surfaces are different when querying pre-rotation information. When updating mCurrentRotationDrawFramebuffer and mCurrentRotationReadFramebuffer, make sure to query pre-rotation information from current draw and read surfaces. Bug: angleproject:7581 Test: FramebufferTest_ES3.BlitWithDifferentPreRotations* Change-Id: Ibe7a2450907e53aa5c33e13cff00059ab2f6602e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3836491 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi 952d6e8f 2022-08-21T21:51:03 Vulkan: Workaround ARM driver bug with dynamic vertex strides According to ARM, vkCmdBindVertexBuffers2EXT is broken when more than one attribute binding is involved. In this change, the vertex strides dynamic state is avoided altogether on ARM. Bug: fuchsia:107106 Change-Id: Ie41fc07037083214d2dc99e4ed062485384911c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3844640 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Eddie Hatfield bd1484f3 2022-08-22T13:53:35 Temporarily disable shader caching feature This will be re-enabled when the BlobCache test flakes are resolved. Bug: angleproject:7036 Change-Id: I38829ffcd5869679bf65017475e8a10d165f369b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3846403 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Eddie Hatfield <eddiehatfield@google.com> Reviewed-by: Lingfeng Yang <lfy@google.com>
angle-autoroll 86a35a4b 2022-08-22T19:09:40 Roll vulkan-deps from d53c356ad7d9 to 186a4d4b9dea (48 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d53c356ad7d9..186a4d4b9dea Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/adf7bf0113..10423ec659 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0a43a84e02..3c1a14b2b6 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/c896e2f920..715673702f * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a0ab2f162e..40faec799c * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/497f232680..439026106a * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/529a4320d3..40315fa5c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7593 Change-Id: I9bfc09ca04025829881af9d03b2073a6f24234c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3846057 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen e22eb503 2022-08-22T11:46:53 Metal: Report Metal being available on iOS simulator Make Metal backend always available on iOS simulator. Currently the GPU family query is not useful as it does not return anything that would enable Metal ANGLE to be used. However, testing on iOS simulator is still useful. Bug: angleproject:7591 Change-Id: I0aa881bb7482fc63bbaa08d5efc10920b3c1af43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3845154 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
angle-autoroll a8ffbef8 2022-08-19T21:02:14 Roll VK-GL-CTS from 5a93cd60f33b to 435ebaff9214 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/5a93cd60f33b..435ebaff9214 2022-08-19 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main 2022-08-18 piotr.byszewski@mobica.com Add coverage for MaxAtomicCounterBufferSize 2022-08-18 piotr.byszewski@mobica.com Check that image*Shadow are not reserved keywords 2022-08-18 piotr.byszewski@mobica.com Fix vkGetPhysicalDeviceProperties2 query 2022-08-18 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7592 Change-Id: I87bd89dd6ad63e2fa28ae87cdd4a91555d56e203 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3842857 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Lingfeng Yang caf2b427 2022-07-01T18:17:30 Vulkan: Add feature to use PASS_THROUGH for EGL_NONE color spaces This is a temporary solution to fix media tests until ANGLE also has the ability to query the "preferred color space" from Surfaces. Bug: b/235995022 Test: Launch Cuttlefish with this change and the feature enabled with aosp/2167231 Test: cts -m CtsMediaCodecTestCases -t android.media.codec.cts.EncodeDecodeTest Test: cts -m CtsMediaCodecTestCases -t android.media.codec.cts.DecodeEditEncodeTest Change-Id: I17d1a2c1701cd1707b34f5bf2f222e9ad57c7a61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3770291 Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Jason Macnak <natsu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com>
Roman Lavrov f30cfd18 2022-08-16T16:50:33 Perf and gold tests detect test SKIPs from json results. Make angle_test_util.RunTestSuite() gets and returns json results (using --isolated-script-test-output). perf tests has an additional special case (filed https://anglebug.com/7578): Previously when metrics were missing it was assumed that this was due to tests being skipped - which seems to currently be the case except for the special case of GLMark2Benchmark* tests. Those produce .fps/.score metrics instead of the metrics expected by this script. This CL keeps those tests running (once) but then marks them as SKIP in test results when no metrics are found (which is the behavior before this CL; it might actually make more sense to count this as PASS because everything matches our expectations). We're still running them once, so if they FAIL we'll get notified. gold tests: Use json results file instead of checking for '[ SKIPPED ]' in stdout. Bug: angleproject:7299 Bug: angleproject:7578 Change-Id: Ia751784ad1aa94dc855c8b58ebfe5ba3e06e462f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3826167 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 4b4c90ef 2022-08-22T10:01:27 Roll SwiftShader from 1c3dfde53353 to c21aa26e0256 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/1c3dfde53353..c21aa26e0256 2022-08-19 nicolas.capens@gmail.com Simplify clipping of complex polygons 2022-08-19 nicolas.capens@gmail.com Update Vulkan headers to version 1.3.225 2022-08-19 swiftshader.regress@gmail.com Regres: Update test lists @ 1c3dfde5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I1c34d56ba212e1ce8f5632cb88474e6d5feeba70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3842446 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 676bc8ed 2022-08-22T07:00:03 Roll Chromium from 336269709208 to e1b4daf2a3e7 (602 revisions) https://chromium.googlesource.com/chromium/src.git/+log/336269709208..e1b4daf2a3e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ca7f2297ff..facb235241 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/3a4c85002c..6f3cc96d10 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/db72216693..c58c612d74 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d2e4dc7655..6c17e7c636 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/f87795ea5b..42aa6de554 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8fade393ad..a30c0d90b3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9bfc1aede5 * third_party/fuchsia-sdk/sdk: version:9.20220817.2.1..version:9.20220821.3.1 * third_party/r8: qvL35O3yU1ZbOWHVZBedmVtdaav1qKquii4RJyUh-PgC..2P7CTTsDUzoP3f8LtGNRdtwC48KAMmV-hPoNhGAwiKMC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a56fd8b0a2..bd2da0345a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d2cfb95d99..398778992d * tools/skia_goldctl/linux: vguZysogLzkycKzCMUUxjQNXAY4wQigIBE83puLd_8YC..eVmrBHTaHLBRrBHBIagAjRi84M8Pih7goWAjl0ZL9H0C * tools/skia_goldctl/mac_amd64: nmPC1ukuYnMcvcfOIlAG5AbUIL_J9LSUaFkegd6BPF0C..3fnB8n0m7xQ9X4SWg4rYgZksJ4YFew0fj6ftsyHzbSwC * tools/skia_goldctl/mac_arm64: B2gt4DQ8QHw4DRrXPgm6d05bbWE5-6hNolIlFc8WECIC..J_MizgwQbTOCG1ZKfGQJRXm-F2Ey8P3M7Dl5WxYKEwwC * tools/skia_goldctl/win: nOvtL4uNJDJw0xbMHz5X0t6RPhp-WQ7eFnxDpCkrmlEC..aYli_YA93vex9TPItiLM1AcLs64FzefvhXxh2aHEvJsC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Iedba1328a8534d03ee0154a1a8ac0b4b7c2d6895 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3844859 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 31ac3fef 2022-08-21T21:30:53 Lift suppression of passing test Bug fixed in https://chromium-review.googlesource.com/c/angle/angle/+/3835168, but a suppression for the test landed in the meantime Bug: angleproject:7583 Change-Id: I14a3e59a6270bfee8288dd733938a18cbf491c20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3844638 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Kimmo Kinnunen b9c3c5d6 2022-08-18T13:38:49 Metal: Fix MTLArgumentEncoder leak in InitArgumentBufferEncoder Patch by David Kilzer <ddkilzer@apple.com> Metal functions with "new" prefix return objects with refcount +1. Adopt the ref to the ObjCObj smart pointer. Bug: angleproject:7577 Change-Id: I57b1ac031aa9cf179288879359d3c88dbd168caa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3834820 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Shahbaz Youssefi 9a258281 2022-08-17T17:47:22 Fix submit-count perf counter test on ARM On ARM, the preferSubmitAtFBOBoundary feature causes extra submissions that need to be taken into account. Bug: chromium:1337538 Change-Id: Id545ee3e65fc943aff51ea3721e9c19bc0afd4a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3835168 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 4330a827 2022-08-19T02:59:26 Reland "Vulkan: Use VK_EXT_primitive_topology_list_restart" This reverts commit 29d18b303189bf31b3af3a85c3df6013114eebc8. Reason for revert: Fixed VVL suppressions not working Original change's description: > Revert "Vulkan: Use VK_EXT_primitive_topology_list_restart" > > This reverts commit e79c9cd63053b6cb7c33235f3a0a0310255df073. > > Reason for revert: Causing timeouts on some headless tests: anglebug.com/7579 > > Original change's description: > > Vulkan: Use VK_EXT_primitive_topology_list_restart > > > > From ANGLE's point of view, there is nothing to do with this extension > > other than enable a feature that silences a validation error. > > > > Bug: angleproject:3832 > > Change-Id: I094343d09c322e2848a65a5bc775d0f21388fb46 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3562380 > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: mohan maiya <m.maiya@samsung.com> > > Bug: angleproject:3832 > Change-Id: Ifec7c9eaea1d3a949f15e0b6d868742f53cf8377 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3838391 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:3832 Change-Id: Ia79b1f3b716f0df1991f605704135b4af48fb639 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3841366 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll b8b44fc8 2022-08-19T10:01:27 Roll SwiftShader from ab4bf6ad00d4 to 1c3dfde53353 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ab4bf6ad00d4..1c3dfde53353 2022-08-18 sugoi@google.com Added missing null pointer check on pDepthStencilResolveAttachment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: If137f8a9d890bbcd76f4ff3446c78bf7a5bd1fe4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3841615 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8ef496b1 2022-08-19T07:59:29 Roll Chromium from 7f3befa9aba1 to 336269709208 (495 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7f3befa9aba1..336269709208 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/138d9667f4..ca7f2297ff * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2c110db042..3a4c85002c * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9de2fe0403..db72216693 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/039323b945..d2e4dc7655 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/12726c93aa..f87795ea5b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b1f7ac5d7d..8fade393ad * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..72946313ec * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d14f65eba9..44b73307ee * third_party/fuchsia-sdk/sdk: version:9.20220817.1.1..version:9.20220817.2.1 * third_party/r8: lAcTGSK3VDSH4DI3H3q0XIg8y0wBVz7IS1Fk_Zbd3iYC..qvL35O3yU1ZbOWHVZBedmVtdaav1qKquii4RJyUh-PgC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1d2e3651d3..ad8b831158 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/660d26d81a..d2cfb95d99 * tools/skia_goldctl/linux: ebDbf3X2jdAICDlXMXUr7yp4muhSvYoREDLdZZoJzuAC..vguZysogLzkycKzCMUUxjQNXAY4wQigIBE83puLd_8YC * tools/skia_goldctl/mac_amd64: yE_XL6pbQ8M0WuI236ObRlkSxu0XMdWs_AnUeo21wa8C..nmPC1ukuYnMcvcfOIlAG5AbUIL_J9LSUaFkegd6BPF0C * tools/skia_goldctl/mac_arm64: l46gUmkc-2-OsEMo-oEbpXiBAYg48KtXbtF1lyBh0u8C..B2gt4DQ8QHw4DRrXPgm6d05bbWE5-6hNolIlFc8WECIC * tools/skia_goldctl/win: 58nNno6pNLLSJaZknYmuijuo5gy2tfRBKNI1iCldDlcC..nOvtL4uNJDJw0xbMHz5X0t6RPhp-WQ7eFnxDpCkrmlEC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Id2363d794151456c9b3b83165d8a95ed54ad903f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3840202 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Faye Zhang 6d153b7d 2022-07-06T12:34:22 Implement BaseInstanceEXT Capture Entry Points In order to support Capture/Replay of apps that use GL_EXT_base_instance functions, their GLES EXT Capture functions should be implemented. Bug: angleproject:7477 Change-Id: Idb96b66ca5a7c96f1883402e62934acc33bd24c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3749796 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 29d18b30 2022-08-18T18:18:04 Revert "Vulkan: Use VK_EXT_primitive_topology_list_restart" This reverts commit e79c9cd63053b6cb7c33235f3a0a0310255df073. Reason for revert: Causing timeouts on some headless tests: anglebug.com/7579 Original change's description: > Vulkan: Use VK_EXT_primitive_topology_list_restart > > From ANGLE's point of view, there is nothing to do with this extension > other than enable a feature that silences a validation error. > > Bug: angleproject:3832 > Change-Id: I094343d09c322e2848a65a5bc775d0f21388fb46 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3562380 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: mohan maiya <m.maiya@samsung.com> Bug: angleproject:3832 Change-Id: Ifec7c9eaea1d3a949f15e0b6d868742f53cf8377 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3838391 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov eb8488e1 2022-08-18T15:43:49 Skip end2end failures on Pixel 6 Android 13 TP1A.220624.021 Bug: angleproject:7583 Change-Id: Ib9a44c222207b6f2c70733738f1c440c6d6a7ce8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3838857 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll c6c7ff3c 2022-08-18T10:01:26 Roll SwiftShader from 5ac9bd16c803 to ab4bf6ad00d4 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/5ac9bd16c803..ab4bf6ad00d4 2022-08-17 nicolas.capens@gmail.com Ignore VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ia5c92f8c541078355f87ae19fc68f88af76f3cdd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3837349 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f5698a8f 2022-08-18T07:00:18 Roll Chromium from 754ede9fc072 to 7f3befa9aba1 (1095 revisions) https://chromium.googlesource.com/chromium/src.git/+log/754ede9fc072..7f3befa9aba1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8bf02cb228..138d9667f4 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/431d9c2d82..2c110db042 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/5df82514bc..9de2fe0403 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/030b4ebf32..12726c93aa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/dbe2ab9dc9..b1f7ac5d7d * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d22f28635a..4ef58b7319 * third_party/android_build_tools/manifest_merger: 0WkAedh1tJB8lzisWJRT80UjpacKLltuV7NqP-0tx9gC..CvokX4c6dx7DwQ8VVMQ70CROzyJWg13oOq3feeuTzg8C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e12cc61cfa * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/268d645853..d14f65eba9 * third_party/fuchsia-sdk/sdk: version:9.20220812.1.1..version:9.20220817.1.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/cca1e66cd5..dd32a150e7 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/22963c3e1f..a56fd8b0a2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/752991ad1e..1d2e3651d3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ca2df581e4..660d26d81a No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I51e4e377c35968da25f1300194c51a224eee507a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3837158 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Eddie Hatfield 955adb77 2022-08-12T10:14:48 Cache compiled shader By storing the compiled shader in the blob cache, the time to recompile the same shader is reduced. Based on work by <hckim.kim@samsung.com> Bug: angleproject:7036 Change-Id: I884ae40e715c49a9ccd12903012e8327811e3557 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3808235 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 2965f81b 2022-08-16T15:26:22 Remove suppression of previously crashed deqp test dEQP-GLES31.functional.shaders.linkage.es31.tessellation.varying.rules#internal_different_precision was fixed in a recent check-in at https://crrev.com/c/3780874. Remove the suppression in the test expectation file. Bug: angleproject:6908 Change-Id: I41025c2555e0c21ff8faaa888842201d26499205 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3828139 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0