kc3-lang/angle

Log

Author Commit Date CI Message
Charlie Lao 40a2a912 2025-07-15T14:39:10 Track mElementArrayBuffer in std::vector<VertexBinding> Right now mElementArrayBuffer are treated a little bit differently from other vertex buffers, mainly because of elementBuffer does not have corresponding "attributeIndex" to bind to. But a lot of logic in VertexArray are same for mElementArrayBuffer and mVertexBindings. In recent CLs, we are using mBufferBindingMask to track both mElementArrayBuffer and mVertexBindings with kElementArrayBufferIndex represents element buffer. With that, some of logic handling buffers can be merged, with looping of mBufferBindingMask bits. In later CL, we are going to separate "binding" from "buffer" so that we can move buffer out of VertexArrayState class. So this is also a preparation CL so that when we move buffers out of VertexArrayState class, it does so for all buffers (both element buffer and vertex buffers). In order to track how many vertex buffers in mVertexBindings, a new variable mMaxVertexAttribBindings is added. In later CL when we move buffers out of VertexBinding, some of this CL's change will be reverted back, mVertexBindings will be reverted back to track only bindings and mMaxVertexAttribBindings will be deleted. Bug: b/433331119 Change-Id: Idd2cfe4ce64bb22923bac70abb752e132fe1abd3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6758215 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 09bbe914 2025-07-28T12:53:53 Add test for mapBuffer and disable/enable attrib interaction Added a test that mapBuffer while attribute is disabled, the draw call should succeed. If attribute is then enabled, the next draw call should fail with GL_INVALID_OPERATION error. Bug: b/433331119 Change-Id: I61d9ff16b0d485309c58c2fe2939c3de8b25864a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6792268 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Tingwei Guo 4f4eab29 2025-06-30T14:58:28 Reset index buffer offset between indirect GL_LINE_LOOP draws In two consecutive glDrawArraysIndirect with GL_LINE_LOOP mode, and bound to a different Indirect Buffer, the variable value captured through TransformFeedback is the same as the first result when the second DrawArraysIndirect. When calling DrawArraysIndirect the second time, DIRTY_BIT_INDEX_BUFFER should be set to dirty so that it re-gets INDEX BUFFER to get the correct result. Bug: angleproject:428561247 Change-Id: I7f4ebb53e20cf8e362e67679b45185b8b68c56ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6687309 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Tingwei Guo <tingwei.guo@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski 866370dc 2025-07-28T22:12:00 Disable texture_compression_astc_decode_mode exts during capture The GL_EXT_texture_compression_astc_decode_mode and GL_EXT_texture_compression_astc_decode_mode_rgb9e5 extensions are not widely supported outside of ARM and Qualcomm. Disable while ANGLE capture is enabled. Test: angle_trace_tests --gtest_filter=*whiteout_survival Bug: b/434819166 Change-Id: I4cebf6942144c61a954dfd9dfe9bd9935638ff60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6794776 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 6fe8c6ed 2025-07-29T10:01:33 Roll vulkan-deps from aef5b0045b59 to 03166deacb9d (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/aef5b0045b59..03166deacb9d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/e832dc66e14bb68683cd5ae51fd2431c3f544c4d..ac2c388bf81603af09d0eb599322b2f3447c5812 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/a983ab19d6f91a07a8272767427b6c5208576d08..c8fd10183c2059e3226b1a310e0826b09579155e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/9007c052db384bdea65c0c4dba927efdf93c465a..e41b4bb2ae355fd3119c19ce3d898d0c111a7060 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Idda582e26561e72c8521923450b6003896cd39f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6794779 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ebfee8a1 2025-07-29T03:01:46 Roll SwiftShader from 8802b4ec130b to 4bd5bd8d51e4 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/8802b4ec130b..4bd5bd8d51e4 2025-07-28 swiftshader.regress@gmail.com Regres: Update test lists @ 8802b4ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ie463d1381e60bc1ebd4bf74b18765113fda654b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6796494 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a08c092e 2025-07-29T07:42:42 Roll Chromium from 2f075e19fc00 to 1beec4a855e7 (711 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2f075e19fc00..1beec4a855e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7c4b770a83..105157d961 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9c179c04d3..bbc0003050 * buildtools/linux64: git_revision:4cfb717bbd5ecfcf63af3cb4487da5ea4777ef67..git_revision:acfe5fde8c5475a9a83bd55f3f222a6dbbcbd0ae * buildtools/mac: git_revision:4cfb717bbd5ecfcf63af3cb4487da5ea4777ef67..git_revision:acfe5fde8c5475a9a83bd55f3f222a6dbbcbd0ae * buildtools/win: git_revision:4cfb717bbd5ecfcf63af3cb4487da5ea4777ef67..git_revision:acfe5fde8c5475a9a83bd55f3f222a6dbbcbd0ae * testing: https://chromium.googlesource.com/chromium/src/testing/+log/485707903e..2e275f3da7 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/3146ad28d4..b7afe66a62 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1addc95539..4e4076a0d7 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/56f1f96c4b..6d019469b4 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/be9dd89ffb..c105b13e37 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/f24be5deb7..14ca6ad7d6 * third_party/re2/src: https://chromium.googlesource.com/external/github.com/google/re2.git/+log/6e8f5be3a3..66a656e6d9 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/283b3095a9..498b55d696 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6cec3ec692..b6138bef35 * tools/luci-go: git_revision:efbba64186435ac28ad419751e67e377c7459c38..git_revision:7e34add007600430452e65b281863bb4fbeb25c8 * tools/luci-go: git_revision:efbba64186435ac28ad419751e67e377c7459c38..git_revision:7e34add007600430452e65b281863bb4fbeb25c8 * tools/luci-go: git_revision:efbba64186435ac28ad419751e67e377c7459c38..git_revision:7e34add007600430452e65b281863bb4fbeb25c8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3e256eafee..8d35380437 * tools/skia_goldctl/linux: Sg25-ZztJqPtMF0rPXgRDM3-fKRveWcIbIvbwwKPAPUC..9cBfu6rdomrQL916sGYsOiSQUrWOuIR_jBjvm7ccFeQC * tools/skia_goldctl/mac_amd64: hZpj0hRnYNFplpUOcSd95nLfQDnWLU1-a_aTEzwQCjwC..e7Uq2XB1IRBbp3a32o4m4yyU-eHdxmQ-2Kcp464UUoQC * tools/skia_goldctl/mac_arm64: ulgsu9nJXlCe-TeAX6PIPIIVr557_qKnjOjyPO9ib9UC..mfzexptpGHu1w9xTtsm7-y3fgnZeDzkcRg99pgZm6XYC * tools/skia_goldctl/win: 0sP0Mad75mVvpE0TL1hNJaOPR1oZCkpx5K_zELfKe2YC..vQKW52sc1DbdemqngJE-HRBoOAXzfbPJiltAV2gCcT8C No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I1e598edafe63df5550e82daa7f5522e8304b102d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6794777 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 9635df8e 2025-07-16T15:13:19 Move mCached*ArrayBuffers from VertexArrayState to VertexArray The three cached AttributeMasks variables are mCachedMappedArrayBuffers, mCachedMutableOrImpersistentArrayBuffers, mCachedInvalidMappedArrayBuffer. They are currently declared in VertexArrayState class. They are only accessed by VertexArray front end, back end does not use them, which means they do not need to be in VertexArrayState class. This CL moves these three variables to VertexArray class in preparation for later CLs that VertexArrayState will not have access to Buffer objects. This CL also removed unnecessary updateCachedMutableOrNonPersistentArrayBuffers call from VertexArray::enableAttribute, since mCachedMutableOrImpersistentArrayBuffers does not depend on any variables enableAttribute() is modifying. Bug: b/433331119 Change-Id: I8b1f0c7d511dbc6858d20f33863154e8fe3077f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6762902 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Tim Van Patten a6699c9f 2025-07-23T13:33:48 Android: Stop polling messages when app destroy requested The Chromium Android testing app enters an infinite loop to poll for messages to run the tests. However, this prevents the app from gracefully shutting down when the DESTROY event is received, because android_main() never returns, so the NDK function android_app_free() never sees android_app->destroyed become true. This prevents using Android instrumented tests in CTS, because the instrumentation never sees the ANGLE app complete the handling of the DESTROY event and exit cleanly. To fix this, check sApp->destroyRequested after each event and break from the infinite loop if the app is being destroyed. Bug: b/279980674 Change-Id: I63edaa6d64e57cd99b6b63a9631c30a65c416220 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6781760 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mohan Maiya 214a48c4 2025-07-16T12:42:18 Vulkan: add support for yuv resolve with transient image Add support for the YUV_target extension in cases where the implementation supports VK_ANDROID_external_format_resolve without supporting nullColorAttachmentWithExternalFormatResolve. Bug: angleproject:386749841 Tests: ImageTest*YUV* Change-Id: Iebcb4f843b962f3d0d2f4e42db479902b6c1f849 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6761834 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Cody Northrop 2b12571c 2025-07-27T20:07:50 Tests: Add Last War: Survival Game trace Test: angle_trace_tests --gtest_filter="*last_war_survival_game" Bug: b/434548051 Change-Id: I25750ef43d58ee06a3149b9fce26b6d9b42c9931 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6789518 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
angle-autoroll 788daaf5 2025-07-28T12:10:41 Roll vulkan-deps from b16be89ea18d to aef5b0045b59 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b16be89ea18d..aef5b0045b59 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/192b610c89300a30221b8909bf71dcb12cd3c92d..e832dc66e14bb68683cd5ae51fd2431c3f544c4d https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/d8c5240c39fdda04bf93e86318916bf19b78a24d..a983ab19d6f91a07a8272767427b6c5208576d08 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/df2e3581520f36776cd42b9fec3ec4a51ab878ef..b0a40d2e50310e9f84327061290a390a061125a3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/ebaf10be2a9b5a523d2e01c2e5820b3f7a444fed..9007c052db384bdea65c0c4dba927efdf93c465a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ia920ad9894946673f46d4d5b20ec527c394ea115 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6792265 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 51baa83f 2025-07-28T03:01:55 Roll SwiftShader from a84d1801cf7b to 8802b4ec130b (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/a84d1801cf7b..8802b4ec130b 2025-07-25 swiftshader.regress@gmail.com Regres: Update test lists @ a84d1801 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I5e7ec0500dee7506accd756879ce61bff0ce15e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6790871 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b58de53d 2025-07-28T07:00:30 Roll Chromium from 1a3e7139a23e to 2f075e19fc00 (754 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1a3e7139a23e..2f075e19fc00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/31eb17c224..7c4b770a83 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/30c72f27f5..9c179c04d3 * buildtools/linux64: git_revision:e9fc92ac17deefc369690f412dc32f1b23bf0ce3..git_revision:4cfb717bbd5ecfcf63af3cb4487da5ea4777ef67 * buildtools/mac: git_revision:e9fc92ac17deefc369690f412dc32f1b23bf0ce3..git_revision:4cfb717bbd5ecfcf63af3cb4487da5ea4777ef67 * buildtools/win: git_revision:e9fc92ac17deefc369690f412dc32f1b23bf0ce3..git_revision:4cfb717bbd5ecfcf63af3cb4487da5ea4777ef67 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/26f0d3392d..485707903e * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b24d00e5a5..8b3cac3801 * third_party/android_build_tools/error_prone/cipd: 5a3g1B4p_Tm13W7rpQ_J2eKjfkyCHweFjgKSvkRjH1gC..V1UaojOb1ghWxbzvm7e3KAo4E5L41McXcK_4S37dQWAC * third_party/android_build_tools/lint/cipd: vUYMCtWFB6js-IE5eVipej3y_TzYSbWb3WzIT1uerYUC..aS4jV08o7OzcMeyyL2RcyXM0e8V2feomEKdqh8nowjwC * third_party/android_build_tools/manifest_merger/cipd: wSkRiVgXkyd47hI2iK2Yj9UZCPqHBGS6_ypfDlAsdw4C..XY78mpSqG9c2zsRPfLI2m16ihBltxa3R27qOXhV9WMIC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5b2aa8309e..1addc95539 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/ed0f32ee7a..be9dd89ffb * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/73cbf2b166..f24be5deb7 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/0b339933cd..283b3095a9 * third_party/siso/cipd: git_revision:33e71490533f445467879650036b6af7940455f3..git_revision:e5fa67c5a456c1ab932f440ddfb195a8a33c235b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e8b2f1816f..3793401522 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c5dc331440..6cec3ec692 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/2ea414c50e..3c7b1f4daa * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f3981b4176..3e256eafee No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I464e3b6e0a847450dde2a4d560fb6eff7b184f0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6789521 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 1df94a64 2025-07-25T15:46:42 Tests: Add Dice Dreams ANGLE trace Test: angle_trace_tests --gtest_filter=*dice_dreams Bug: b/434552757 Change-Id: Ie56bd5fee6aebbddc9c613609d636acca11749a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6789519 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski c8209fec 2025-07-25T10:16:25 Tests: Add Avatar World trace Test: angle_trace_tests --gtest_filter=*avatar_world Bug: b/434146678 Change-Id: I3983c0720f541f5d28a82f4c3bcff7b6ea4252a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6785913 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Geoff Lang e4007fff 2025-07-24T15:50:48 GL: Remove ARB_base_instance check for EXT_base_instance support This is a speculative fix for reported flickering issues on Linux. https://chromium-review.googlesource.com/c/angle/angle/+/6580170 changed EXT_base_instance to only be supported when it is not emulated and fixed the condition to include ARB_base_instance, possibly hitting driver bugs on some devices. Bug: angleproject:355645824 Bug: chromium:427956856 Change-Id: I869fa7f618e82ad46c1953f0bacef0767bbc793e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6777576 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll f4d16e64 2025-07-25T12:39:05 Roll vulkan-deps from b7374531e4a2 to b16be89ea18d (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b7374531e4a2..b16be89ea18d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/04d4deab5d608af8fbe418c422734a73555589c3..d8c5240c39fdda04bf93e86318916bf19b78a24d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/4cf7390eb853a54e7f9ae1c948ac09995ed8b8e5..ebaf10be2a9b5a523d2e01c2e5820b3f7a444fed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I509b0a6151a80cf82dccd1cb497a12a1489a9191 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6788362 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 7fc1baa0 2025-07-25T05:17:25 Revert "Remove dupe dependency: vulkan-deps" This reverts commit 43f8d708b87446d233640ad27abf8c1b4a7d68dc. Reason for revert: breaks autoroll Bug: chromium:433839081 Original change's description: > Remove dupe dependency: vulkan-deps > > Credit rop@ > > Bug: chromium:433839081 > Change-Id: Ibea08597e3490dcd374d386b8ae165b7399bd972 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6776852 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: chromium:433839081 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I4cb65820ac8fe25c19efa186b5864c6f2eaadc94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6786933 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll e5a2c396 2025-07-25T07:03:21 Roll Chromium from 07e7c6a89f6c to 1a3e7139a23e (1216 revisions) https://chromium.googlesource.com/chromium/src.git/+log/07e7c6a89f6c..1a3e7139a23e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/17fc288d82..31eb17c224 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/36ee1c7a30..30c72f27f5 * buildtools/linux64: git_revision:85f62c164c829442fb662f6aa1243c02bcc47155..git_revision:e9fc92ac17deefc369690f412dc32f1b23bf0ce3 * buildtools/mac: git_revision:85f62c164c829442fb662f6aa1243c02bcc47155..git_revision:e9fc92ac17deefc369690f412dc32f1b23bf0ce3 * buildtools/win: git_revision:85f62c164c829442fb662f6aa1243c02bcc47155..git_revision:e9fc92ac17deefc369690f412dc32f1b23bf0ce3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/436769856a..26f0d3392d * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/320a9daea6..b24d00e5a5 * third_party/android_build_tools/aapt2/cipd: QAJPvXRIKAdvDEnn23X7nLv-pZlN3qjPeD_vq4QsYRIC..2Tff49a5dYTM5YvxxqyOsTQ9k8nOqM4ayydbCuKoxIwC * third_party/android_build_tools/error_prone/cipd: CEqMYEsaqKnNQyglUsxm_2t7HlZvMDFoLEDpOwojrLQC..5a3g1B4p_Tm13W7rpQ_J2eKjfkyCHweFjgKSvkRjH1gC * third_party/android_build_tools/lint/cipd: b8AHtDAbZgiVrWGB-AEmvVAb_qTfgMhi0hi_swHIx6EC..vUYMCtWFB6js-IE5eVipej3y_TzYSbWb3WzIT1uerYUC * third_party/android_build_tools/manifest_merger/cipd: 1hP6AEaf7D9UPDHSjdo0-C1zpHYErmkxDJRMfymsexAC..wSkRiVgXkyd47hI2iK2Yj9UZCPqHBGS6_ypfDlAsdw4C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/214ad75f39..3146ad28d4 * third_party/android_sdk/public: mjFmRj7k_XR9yj60pYbr9mG38FyEbU5oWdU56bZQ5cwC..qTD9QdBlBf3dyHsN1lJ0RH6AhHxR42Hmg2Ih-Vj4zIEC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ed07b403a2..5b2aa8309e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/28358f4020..56f1f96c4b * third_party/fuchsia-sdk/sdk: version:28.20250709.3.1..version:28.20250723.2.1 * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/935be444d6..4b641086e0 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/ac9e4860ca..ed0f32ee7a * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/b6f2833c99..00a175050b * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/15268943dc..73cbf2b166 * third_party/re2/src: https://chromium.googlesource.com/external/github.com/google/re2.git/+log/ade723c0c3..6e8f5be3a3 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/3203dc1933..0b339933cd * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ad203d4ebe..c5dc331440 * tools/luci-go: git_revision:3d4e77634359485da65136798a6278c463bdf11d..git_revision:efbba64186435ac28ad419751e67e377c7459c38 * tools/luci-go: git_revision:3d4e77634359485da65136798a6278c463bdf11d..git_revision:efbba64186435ac28ad419751e67e377c7459c38 * tools/luci-go: git_revision:3d4e77634359485da65136798a6278c463bdf11d..git_revision:efbba64186435ac28ad419751e67e377c7459c38 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6c50647ee9..d90a4a94e0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2af564c7f9..f3981b4176 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/13687c3088..522bd21e55 * tools/skia_goldctl/linux: dKZpRJmIZbZWCBXvVVjs1YTZslJoSBMHBIqTpdpsN-QC..Sg25-ZztJqPtMF0rPXgRDM3-fKRveWcIbIvbwwKPAPUC * tools/skia_goldctl/mac_amd64: 12tDnieLoBvORD80sklJL-hfBv4LYEKMmrZHsGJ5gnsC..hZpj0hRnYNFplpUOcSd95nLfQDnWLU1-a_aTEzwQCjwC * tools/skia_goldctl/mac_arm64: t1RKQ6QfRd7ARC5xw--IwYvSAfxeKuY0e2B3CgVWjugC..ulgsu9nJXlCe-TeAX6PIPIIVr557_qKnjOjyPO9ib9UC * tools/skia_goldctl/win: 59DTb2NmGNjG4dCKnsF9mfg-bxq-4OLfQ4z78-PChnkC..0sP0Mad75mVvpE0TL1hNJaOPR1oZCkpx5K_zELfKe2YC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I923fbb06cfa7017c535824c20ada0dedd5c5f6f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6787516 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxiang Qian 6a03109f 2025-07-09T18:24:31 Refine getCompressionRate As Vulkan spec states, vkGetImageSubresourceLayout should not be called for the android swapchainimage when the image is not bound to memory. Refine the path of getCompressionRate to make sure at least swapchainimage[0] has been initialized when it is been called. Bug: angleproject:433057375 Change-Id: I80b68874686940c0ef77df97b928b0e153c5bbf8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6774721 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d38531e8 2025-07-23T09:39:11 Fix extension check for xfb mode validation With geometry and tessellation shaders, it's possible to use different primitive modes between transform feedback and draw, as long as they are from the same class. The code accidentally allowed this only if both extensions are supported, but it should be allowed if either is. Bug: angleproject:428561247 Change-Id: Ia18d4ac15a3d0739ce18dc0e1f3d3f0b1aea621c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6780744 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jordan Brown 13f6df49 2025-07-17T20:40:19 Fix the format of the "License" field in README.chromium files. Add missing license for util/android/thrid_party based on license at the source url. Bug: chromium:421988485 Bug: chromium:421989135 Bug: chromium:421988956 Bug: chromium:421988537 Bug: chromium:421988894 Bug: chromium:421989250 Bug: chromium:421988522 Bug: chromium:421988185 Bug: chromium:421989147 Bug: chromium:421988875 Bug: chromium:421988779 Bug: chromium:421988799 Bug: chromium:421988324 Bug: chromium:421988930 Bug: chromium:421988996 Change-Id: I4008229b3031734dd2dc991026cdebe0894c352c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6768429 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Jordan Brown <rop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Matthew Denton 6a3ff5a1 2025-07-17T12:41:13 WGSL: extra debug logging for failure cases Bug: angleproject:42267100 Change-Id: I8938526b60af71d15d4327bc10fa172117afef60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6777200 Reviewed-by: Geoff Lang <geofflang@chromium.org>
Matthew Denton 343e3bdc 2025-07-17T12:38:31 ScalarizeVecAndMatConstructors: also handle scalar constructors In WGSL you cannot "construct" a scalar from a non-scalar (vec or mat). This modifies ScalarizeVecAndMatConstructors to handle scalar constructors as well, indexing and swizzling the argument to select the first element of the nonscalar. This makes dEQP-GLES2.functional.shaders.conversions.vector_to_scalar.* pass (except those that use bool uniforms which are still unsupported). Bug: angleproject:42267100, angleproject:395659799 Change-Id: Ibaa3dc14f36fecb384bfb6e7f226c6d5f377dd5f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6777199 Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mark Lobodzinski 7181239d 2025-04-04T14:13:58 Add long ANGLE traces feature Enables very long Android captures by swapping binary data chunked buffers to/from disk. Bug: b/425728227 Change-Id: I539f72590eece03cfc69d42fc34be9825a9ff1fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6476924 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Tim Van Patten cf4c8c2a 2025-07-10T15:50:36 Add max sampler count to maxUniformLocations OpenGL ES 3.2 Spec: > ## 7.6. UNIFORM VARIABLES > > When a program is linked successfully, all active uniforms, except for > atomic counters, belonging to the program object’s default uniform > block are initialized as defined by the version of the OpenGL ES > Shading Language used to compile the program. A successful link will > also generate a location for each active uniform in the default > uniform block which doesn’t already have an explicit location defined > in the shader. The generated locations will never take the location of > a uniform with an explicit location defined in the shader, even if that > uniform is determined to be inactive. The values of active uniforms in > the default uniform block can be changed using this location and the > appropriate Uniform* or ProgramUniform* command (see section 7.6.1). > These generated locations are invalidated and new ones assigned after > each successful re-link. The explicitly defined locations and the > generated locations must be in the range of 0 to the value of > MAX_UNIFORM_LOCATIONS minus one. Currently, ANGLE sets the mNativeCaps.maxUniformLocations to the maximum number of supported uniform variables (maxUniformVectors). However, samplers are also uniforms and consume uniform locations during shader linking. This causes shader compilation to fail for context versions 3.1+ if a shader uses both the maximum number of uniform variables and maximum number of samplers because the number of uniform locations is exceeded. This specific edge case is being tested by the end2end test GLSLTest.VerifyMaxVertexUniformVectorsWithSamplers. Unfortunately, that test is only instantiated for GLES 2.0 and 3.0 and ANGLE's shader linker only validates the number of supported uniform locations are not exceeded for GLES 3.1+, so that error path is not being validated. 1. Include both the maximum number of supported uniform variables and maximum number of samplers whe calculating the supported maximum number of uniform locations. 2. Instantiate GLSLTest.VerifyMaxVertexUniformVectorsWithSamplers for GLES 2.0, 3.0, 3.1, and 3.2 so the edge cases are tested for all supported GLES versions. Bug: b/279980674 Test: angle_end2end_tests --gtest_filter=GLSLTest.VerifyMaxVertexUniformVectorsWithSamplers* Change-Id: I8ad1f4d2a040a189625d516b54bf2f79ef218edc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6724940 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 43f8d708 2025-07-24T10:43:53 Remove dupe dependency: vulkan-deps Credit rop@ Bug: chromium:433839081 Change-Id: Ibea08597e3490dcd374d386b8ae165b7399bd972 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6776852 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tim Van Patten bc9ff5e6 2025-07-11T13:43:05 Don't cache shaders/programs that are too large Currently, ANGLE compresses and caches every shader program, but can then fail to decompress the cached program because the uncompressed size is too large. Instead, check if the program size is too large before compressing and caching the program, so ANGLE doesn't generate an error later while attempting to decompress the cached program. This change is applied to both shaders and programs: * MemoryShaderCache::putShader() * MemoryProgramCache::putProgram() Bug: b/279980674 Change-Id: I67a3b542b460a41dbbc4a3d8bad4031a212223e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6728876 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Geoff Lang b7582680 2025-02-24T18:04:32 Reland: GL: Allow untranslated shaders to pass through on GLES Add an EGL extension EGL_ANGLE_create_context_passthrough_shaders which uses the NULL translator and passes the original shader to the driver. The parser is still used for shader reflection. Always enable the null compiler backend. It has almost no binary size cost and is now potentially used when the null ANGLE backend is not enabled. Bug: angleproject:398857482 Change-Id: Id528189ccbbacb1c444eacb151baadfda9fcc04b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6488609 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cody Northrop cd6680b4 2025-07-23T22:25:32 Tests: Add Last Z: Survival Shooter trace Test: angle_trace_tests --gtest_filter="*last_z_survival_shooter*" Bug: b/433847164 Change-Id: Ifb142d750de9fc9a626896608aefe30ecd06b1f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6782543 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
angle-autoroll dd6a1a2c 2025-07-24T10:02:04 Roll vulkan-deps from 0b8bda098b9a to b7374531e4a2 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/0b8bda098b9a..b7374531e4a2 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/597e427cce3fc97a8455b26aba1a1189546717c3..192b610c89300a30221b8909bf71dcb12cd3c92d https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/c8ad050fcb29e42a2f57d9f59e97488f465c436d..de1807b7cfa8e722979d5ab7b7445b258dbc1836 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/8cf1bf9bb922e33135e6e343a566764015da2dc6..04d4deab5d608af8fbe418c422734a73555589c3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/dad479f6294df6c7a706964c489926be943a8baf..4cf7390eb853a54e7f9ae1c948ac09995ed8b8e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Iff95f0d257f10922a681697549f833092622f395 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6782918 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 95749708 2025-07-24T03:01:52 Roll SwiftShader from b347398f5e86 to a84d1801cf7b (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/b347398f5e86..a84d1801cf7b 2025-07-23 swiftshader.regress@gmail.com Regres: Update test lists @ b347398f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I9c6f02338c18f94e9433f04cbf3abaaede7db55b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6782794 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov 03676f3f 2025-07-22T15:34:18 Tests: Add MixedMultisampleSingleSampledDraw test Test: angle_trace_tests --gtest_filter=MultisampledRenderToTextureES3Test.MixedMultisampleSingleSampledDraw Bug: angleproject:433462527 Change-Id: I87b56452bd5ad1d7841341ddd7af9479fe966f6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6773431 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop f94510ab 2025-07-22T21:16:37 Tests: Add Honkai Impact 3rd trace Test: angle_trace_tests --gtest_filter="*honkai_impact_3rd*" Bug: b/433331917 Change-Id: Ia7edcf0b930a646923019b6e4c8b49678d6b189f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6780136 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop ab74884c 2025-07-22T20:46:05 FrameCapture: Check current state for indexed buffers When checking whether we need to set per draw buffer blend state, we don't care whether they differ from default, we only care if they differ from each other. The non-indexed commands will set the same state for all buffers. This CL removes default state from the check. Otherwise, we are getting a block of identical indexed commands: glBlendFuncSeparateiEXT(0, GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA, GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); glBlendFuncSeparateiEXT(1, GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA, GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); glBlendFuncSeparateiEXT(2, GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA, GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); glBlendFuncSeparateiEXT(3, GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA, GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); glBlendFuncSeparateiEXT(4, GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA, GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); glBlendFuncSeparateiEXT(5, GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA, GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); Which is equivalent to: glBlendFuncSeparate(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA, GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); Test: Honkai Impact 3rd trace Bug: b/433331917 Change-Id: Ie6bd7549d69c1548aace92126312527b8e585046 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6780135 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 0aebab74 2025-07-23T03:01:18 Roll SwiftShader from 084f9893520c to b347398f5e86 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/084f9893520c..b347398f5e86 2025-07-22 swiftshader.regress@gmail.com Regres: Update test lists @ 084f9893 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I1b381770573b15c64cea0633f6f8daccbd05f141 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6780992 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7b20c2b1 2025-07-23T10:01:12 Roll vulkan-deps from e07930aa8378 to 0b8bda098b9a (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e07930aa8378..0b8bda098b9a Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/775230d6de3d58095331bc5a314dd63255c6d659..dad479f6294df6c7a706964c489926be943a8baf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ic0532fd72e9b24601839a85f4074bca0707168f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6780993 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c8bcf513 2025-07-23T07:42:38 Roll Chromium from 714e16cda637 to 07e7c6a89f6c (651 revisions) https://chromium.googlesource.com/chromium/src.git/+log/714e16cda637..07e7c6a89f6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a1f8648722..17fc288d82 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/90b48c96e7..36ee1c7a30 * buildtools/linux64: git_revision:eb4530a2cb7813f81e390ebc3505f64b94518458..git_revision:85f62c164c829442fb662f6aa1243c02bcc47155 * buildtools/mac: git_revision:eb4530a2cb7813f81e390ebc3505f64b94518458..git_revision:85f62c164c829442fb662f6aa1243c02bcc47155 * buildtools/win: git_revision:eb4530a2cb7813f81e390ebc3505f64b94518458..git_revision:85f62c164c829442fb662f6aa1243c02bcc47155 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5d5179585b..436769856a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/fa304eccac..320a9daea6 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/569aa83b4b..ac9e4860ca * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/634c609746..84c5262b57 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/f603c99c99..15268943dc * third_party/re2/src: https://chromium.googlesource.com/external/github.com/google/re2.git/+log/79741d66ed..ade723c0c3 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3454fad2d4..ad203d4ebe * tools/luci-go: git_revision:ce380e662ce9327acf0c5d84fa310a7bfaa108c3..git_revision:3d4e77634359485da65136798a6278c463bdf11d * tools/luci-go: git_revision:ce380e662ce9327acf0c5d84fa310a7bfaa108c3..git_revision:3d4e77634359485da65136798a6278c463bdf11d * tools/luci-go: git_revision:ce380e662ce9327acf0c5d84fa310a7bfaa108c3..git_revision:3d4e77634359485da65136798a6278c463bdf11d * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/7f4bdaac14..2ea414c50e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5515978448..2af564c7f9 * tools/skia_goldctl/linux: bjFgrjj2HgmCZmoQUwM2GMDYWF7SAEh7IwTGapy6NBwC..dKZpRJmIZbZWCBXvVVjs1YTZslJoSBMHBIqTpdpsN-QC * tools/skia_goldctl/mac_amd64: tJ9Ig7GLCer81AflLHJX0Krknawqd51qehvwhaGpZO4C..12tDnieLoBvORD80sklJL-hfBv4LYEKMmrZHsGJ5gnsC * tools/skia_goldctl/mac_arm64: MQtt3k5TKZdMiE0lva_ulaLqLDoKjZm0ItZgvjidjmYC..t1RKQ6QfRd7ARC5xw--IwYvSAfxeKuY0e2B3CgVWjugC * tools/skia_goldctl/win: lYztLUb5WOMcDcTJpbHpiikw3PA2zagzacUpMBGlWwoC..59DTb2NmGNjG4dCKnsF9mfg-bxq-4OLfQ4z78-PChnkC No update to Clang. Bug: angleproject:5038,angleproject:6245 Tbr: syoussefi@google.com Change-Id: I5fd8e0dffa6ff9afb22681cea1fe3167b734a4f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6778284 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 1c245d90 2025-07-22T17:44:15 Fix ASTC emulation for array textures Only the first slice was decoded. Bug: angleproject:432782046 Change-Id: Ibb9d7ff72424c26b240900c1a5f39acd1fc62650 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6779463 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 4e81cd79 2025-07-21T10:45:02 FrameCapture: Update context limits We're seeing multiple titles run incorrectly without updating these two limits during capture. I've verified locally that these still fit within the limits of all modern devices we're looking at. If there are any problems with older devices, we can address them with: addIntegerPrerequisite(GL_MAX_DRAW_BUFFERS_EXT, 6); addIntegerPrerequisite(GL_MAX_VERTEX_UNIFORM_VECTORS, 4096); Bug: b/431854319 Bug: b/433331917 Change-Id: Id21de17acc4d24157dfe07de6b9de818561399ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6775624 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi c2224aef 2025-07-22T14:35:49 Revert "Fix VK-GL-CTS build error" This reverts commit a676c4725490ee896e1154d5fbe1b1c1adc83678. Reason for revert: CTS build issue is fixed upstream and rolled into ANGLE. Bug: angleproject:432337091 Original change's description: > Fix VK-GL-CTS build error > > ... temporarily by overriding the offending file until the upstream fix > lands. > > Bug: angleproject:432337091 > Change-Id: I878561e0856e43b657bcaf08a7563ac639794098 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6775382 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:432337091 Change-Id: I1607d32b4007df91c721601fc16bcb05932f2567 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6777764 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Matthew Denton cbff5658 2025-07-16T14:10:47 ScalarizeVecAndMatConstructorArgs: cast for mat constructors In WGSL, matrix constructors also can't handle arguments of differing basic type than the constructor's basic type, so cast when necessary. Makes dEQP-GLES2.functional.shaders.conversions.scalar_to_matrix.* pass for WGSL. dEQP-GLES2.functional.shaders.conversions.matrix_to_matrix.* does not yet pass because WGSL can't handle matrix shader inputs/outputs. Bug: angleproject:42267100, angleproject:395659799 Change-Id: Ia4761190c78ccfe7d748275642361ada93314529 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6777198 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Matthew Denton 2c1a55b3 2025-07-16T13:44:49 WGSL: implement == for vectors by wrapping in all() WGSL's vec comparisons are component-wise, so wrapping the result in a call to all() returns true if all components compare equal, matching the behavior of GLSL's vec comparisons (== and !=). Bug: angleproject:42267100 Change-Id: Icfbfacf72e53096e2567fa89bcd4bf573e457ec1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6777197 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Charlie Lao cdffecb7 2025-07-21T11:30:45 Vulkan: Ensure FramebufferVk::mRasterizationSamples > 0 GraphicsPipelineDesc can't handle samples being zero. This CL ensures we always use at least one sample. Bug: angleproject:431250668 Change-Id: I7f6b14c6060585fe7ef6fb55ed6a4b9813634f3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6431827 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Neil Zhang 364ad1c4 2025-07-15T12:47:55 Enable test ImageTestES3.SourceYUVAHBTargetExternalCopySrc on Pixel 6 This issue been fixed by patch: http://crrev.com/c/6679988, when sampling YUV formats, angle use texture() instead of texelFetch(), and should adjust texture coordinates by + 0.5 Bug: angleproject:395520107 Change-Id: I22166b28c5ee2949d5e9570137e110edc34fffaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6738562 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Neil Zhang <Neil.Zhang@arm.com>
angle-autoroll b98d0525 2025-07-22T03:01:17 Roll SwiftShader from 65b2c4777e5f to 084f9893520c (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/65b2c4777e5f..084f9893520c 2025-07-21 rsworktech@outlook.com Make llvm-16.0 Chromium build warning free 2025-07-21 rop@google.com Use standard SPDX license identifier in README.chromium 2025-07-21 swiftshader.regress@gmail.com Regres: Update test lists @ 65b2c477 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I17f6bde3fbe98b1d49663360bef186bd96019642 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6777258 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 22b41a03 2025-07-22T10:01:12 Roll vulkan-deps from 115cdec98cc6 to e07930aa8378 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/115cdec98cc6..e07930aa8378 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/15b727afdd0b69ef5d178727e7ac66be991e678f..f43df42fe69bb38d43625b53e0706bbee43d74b4 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/257a227fbadf8176ea386c7d8fb9b889cbf08640..8cf1bf9bb922e33135e6e343a566764015da2dc6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/36f2e7584258bea0b6d71aed7108f5afe11ea494..f766b30b2de3ffe2cf6b656d943720882617ec58 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d19ef11ea8981974e46c031633fadf50a2ced209..775230d6de3d58095331bc5a314dd63255c6d659 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I62daf037cddfff7a15416bfed3be7363da7e8493 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6777056 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3365445b 2025-07-22T09:06:51 Roll VK-GL-CTS from 368ac769be44 to ad59a18f2ce0 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/368ac769be44..ad59a18f2ce0 2025-07-22 abdolrashidi@google.com Include iterator to gl4cEnhancedLayoutsTests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: If88417209c9f58f87256cc69d87b2631cc98a6e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6777055 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e815df7f 2025-07-22T08:23:36 Roll Chromium from 3f250af9a632 to 714e16cda637 (2558 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3f250af9a632..714e16cda637 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c734cf94f4..a1f8648722 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/bb0dbc354c..90b48c96e7 * buildtools/linux64: git_revision:c4748415f12ac92d2781608b8b84fcc0e33e5ff9..git_revision:eb4530a2cb7813f81e390ebc3505f64b94518458 * buildtools/mac: git_revision:c4748415f12ac92d2781608b8b84fcc0e33e5ff9..git_revision:eb4530a2cb7813f81e390ebc3505f64b94518458 * buildtools/win: git_revision:c4748415f12ac92d2781608b8b84fcc0e33e5ff9..git_revision:eb4530a2cb7813f81e390ebc3505f64b94518458 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/da9b17c744..5d5179585b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/cae4b6a399..fa304eccac * third_party/android_build_tools/error_prone/cipd: bCQ_MOCwzM4fJFiHDoTJEB9hoP1Oo-OypDACePv2ChEC..CEqMYEsaqKnNQyglUsxm_2t7HlZvMDFoLEDpOwojrLQC * third_party/android_build_tools/lint/cipd: Udt_ui9-OCSxeIcww7Glc5tu_22Nynmo1p-LSAUG6qkC..b8AHtDAbZgiVrWGB-AEmvVAb_qTfgMhi0hi_swHIx6EC * third_party/android_build_tools/manifest_merger/cipd: X1QeCG1bnGy8cHpJcHN8WYgMmiQXjpDUbIvx7cc1MbMC..1hP6AEaf7D9UPDHSjdo0-C1zpHYErmkxDJRMfymsexAC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/31cfff6e10..214ad75f39 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/16ae41e875..ed07b403a2 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8532fbcf79..28358f4020 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7a36df3acb..569aa83b4b * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/8eeec53078..b6f2833c99 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/cac117af24..f603c99c99 * third_party/re2/src: https://chromium.googlesource.com/external/github.com/google/re2.git/+log/8ea5841693..79741d66ed * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/8bbd6f5553..3203dc1933 * third_party/siso/cipd: git_revision:dcd000e47f19677c7a5e02550abafa9eadbd4923..git_revision:33e71490533f445467879650036b6af7940455f3 * third_party/turbine/cipd: pLwUKCRZD6noaKQQ0JaosQDV85ccs7FpR9OJT4biM1UC..TkTaFqF4Bs-JmFtxFV_Nfh4u5jh_401ZQsLhC7vIEqQC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/2a25945218..e8b2f1816f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7ade8a8f2a..3454fad2d4 * tools/luci-go: git_revision:6d38f0fa9f6c3c973753dbb762b0ed7b711db56c..git_revision:ce380e662ce9327acf0c5d84fa310a7bfaa108c3 * tools/luci-go: git_revision:6d38f0fa9f6c3c973753dbb762b0ed7b711db56c..git_revision:ce380e662ce9327acf0c5d84fa310a7bfaa108c3 * tools/luci-go: git_revision:6d38f0fa9f6c3c973753dbb762b0ed7b711db56c..git_revision:ce380e662ce9327acf0c5d84fa310a7bfaa108c3 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/cc38b4b04f..7f4bdaac14 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a840c75371..5515978448 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/c52b68f9dc..13687c3088 * tools/skia_goldctl/linux: S61nYM2LARYt8FGKUv9IwoQhQe-J4-IuZJ23SCq5R1oC..bjFgrjj2HgmCZmoQUwM2GMDYWF7SAEh7IwTGapy6NBwC * tools/skia_goldctl/mac_amd64: d88GmiB-c0r_703cXAupUOC3E17SEnJ2gWASKadmsdsC..tJ9Ig7GLCer81AflLHJX0Krknawqd51qehvwhaGpZO4C * tools/skia_goldctl/mac_arm64: 97SClzQJSwtymf_fcA4k_ZKZ2-BFRfFpUqIrgsRMM0EC..MQtt3k5TKZdMiE0lva_ulaLqLDoKjZm0ItZgvjidjmYC * tools/skia_goldctl/win: KuqayTqHpavNZjlc3YwoVsu3LhcUItZKbHs-NEl148sC..lYztLUb5WOMcDcTJpbHpiikw3PA2zagzacUpMBGlWwoC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ie0025b7fe7334c3ec32d8c040886bce03f2cd415 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6775192 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand 239763d9 2025-04-04T17:52:10 CL/VK: Fix ArgumentWorkgroup setArg logic Issue was that clSetKernelArg for ArgumentWorkgroup type arguments would blindly push new values into kernel's spec-constant FastVector on every clSetKernelArg (even on same arg updates). This would lead to over-pushing due to same arg updates, which caused all kinds of issues, mainly erroneous misses in compute pipeline cache since the key is based on VkSpecializationInfo. Since kernel object already keeps a vector of kernel args, we don't need a separate spec-constant FastVector in CLKernelVk to track this. Remove it and derive the spec-constant data from the kernel args themselves. Bug: angleproject:366415134 Tests-Passing: Geekbench-6.2.2 - Workloads: [ 401 & 601 ] Change-Id: Iab7f27fdfdfede33881e1dd717ba3b771cffb985 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6773615 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e98dec82 2025-07-20T22:16:00 Translator: Remove Sampler2DRectShadow This is a desktop GLSL type. Bug: angleproject:370937467 Change-Id: Ife8b50e57f6e054ccd35df10c2157f8e4a218d37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6774081 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu 93afebf5 2025-07-17T11:08:02 Change the way we get vkEnumerateInstanceExtensionProperties After this change https://chromium-review.googlesource.com/c/angle/angle/+/6444660, more crashes were observed in this function GetSystemInfoVulkanWithICD on Chrome, Linux. One crash report showed the crash occurs in calling vkEnumerateInstanceExtensionProperties(). Before the change, we get the function pointer of vkEnumerateInstanceExtensionProperties() by angle::GetLibrarySymbol(). After the change, we get the function pointer by vkGetInstanceProcAddr(). Switching the way we get the function pointer back to angle::GetLibrarySymbol() to check if this helps with reducing the crash rate. Bug: angleproject:407116232 Bug: chromium:424207320 Change-Id: I962533fcf4401522f459ff27d2342e0f5c29d407 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6766724 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi a676c472 2025-07-21T12:29:29 Fix VK-GL-CTS build error ... temporarily by overriding the offending file until the upstream fix lands. Bug: angleproject:432337091 Change-Id: I878561e0856e43b657bcaf08a7563ac639794098 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6775382 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Panfeng Hou 251ffe62 2025-07-15T17:37:30 Vulkan: Add support for built-in gl_ShadingRateEXT Add support for built-in gl_ShadingRateEXT of GL_EXT_fragment_shading_rate Bug: angleproject:420310117 Change-Id: Ie11b139a0371b5995f1533a85e02c590cd36109c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6733750 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e3d25adc 2025-07-21T10:22:52 Roll VK-GL-CTS from 2a90cff9718b to 368ac769be44 (2 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2a90cff9718b..368ac769be44 2025-07-20 ziga@lunarg.com Test vkGetQueryPoolResults with zero and max stride when query is 1 2025-07-19 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: If6e42c1c25699c52ac24092689ced70b3b1387f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6774599 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1e411b7b 2025-07-21T10:01:12 Roll vulkan-deps from 03f51f594fdd to 115cdec98cc6 (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/03f51f594fdd..115cdec98cc6 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/eb77189a282b90e9856fc0ed5b08361a70025bec..15b727afdd0b69ef5d178727e7ac66be991e678f https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/f89d9f982d1afe9fec6239fdc73b972bb0b4abe3..597e427cce3fc97a8455b26aba1a1189546717c3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/088a00d81d1fc30ff77aacf31485871aebec7cb2..89268a6d17fc87003b209a1422c17ab288be99a0 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/f946876731972cb323b021b78d1921aa9244808b..a1684e4bd23ab130c5e7c37ab72b07dd541897a9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/105d6c1fede00c3a9055e5a531ebf3d99bac406e..36f2e7584258bea0b6d71aed7108f5afe11ea494 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/dc6f68172430999a96a209ef4700784917dab1a2..df2e3581520f36776cd42b9fec3ec4a51ab878ef https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/aa1607f891cefd0a338b65bd8f2254e2c4fbf87c..d19ef11ea8981974e46c031633fadf50a2ced209 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I491959c92af1c162a4921de6ac9867bc7620c293 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6774598 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 61c609c8 2025-07-21T08:01:53 Roll VK-GL-CTS from 73db56e823f8 to 2a90cff9718b (13 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/73db56e823f8..2a90cff9718b 2025-07-18 elima@igalia.com Add VK_KHR_video_encode_intra_refresh tests 2025-07-18 lorenzo@khronosgroup.org Re-add sparse 2D view of 3D image tests 2025-07-18 zzoon@igalia.com Fix the h265.i_p_b_13 encoding test by setting delta_poc_s0_minus1 for P frames. 2025-07-18 erik.faye-lund@collabora.com Use sRGB buffer view for sRGB load/stores 2025-07-18 ziga@lunarg.com Fix validation errors in attachment_feedback_loop_layout tests 2025-07-18 ziga@lunarg.com Add missing asymmetric event bit in maintenance9 sync tests 2025-07-18 piotr.byszewski@mobica.com Fix validation error in few renderpass tests 2025-07-18 ziga@lunarg.com Log images in host image copy tests 2025-07-18 ziga@lunarg.com Fix validation errors in swapchain test 2025-07-18 rgarcia@igalia.com Add 1D and 3D image-to-buffer copy tests with compressed formats 2025-07-18 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-07-16 rgarcia@igalia.com Exclude fetching and building the VVL by default 2025-07-14 lorenzo@khronosgroup.org Update Vulkan docs to 1.4.322 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I0720c2173c5f0a2207cd10986eeb42f6040f65c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6774305 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop faf1bb4b 2025-07-17T21:33:19 Tests: Add Wuthering Waves trace Test: angle_trace_tests --gtest_filter=TraceTest.wuthering_waves Bug: b/431854319 Bug: b/432782046 Change-Id: I5e12064e964953d0a3d969cd0026f50d0945e888 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6768428 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 9cd9a0d5 2025-07-18T10:28:12 Vulkan: Reformat VVL Error Message Remove the following members from the SkippedSyncvalMessage struct: const char *messageContents1 const char *messageContents2 Future VVL suppression message should use extraProperties list only. Bug: angleproject:391284743 Change-Id: I72ebaf86da667967681318dd69a181cc685f0805 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6769428 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 41bfed39 2025-07-18T11:40:39 Roll vulkan-deps from 286b9f0629a4 to 03f51f594fdd (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/286b9f0629a4..03f51f594fdd Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4056002eb2401b9406e78b9ea71fd0ce65737ebe..eb77189a282b90e9856fc0ed5b08361a70025bec https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/f69f0433bae0b30598380ef0420b9d2d02dbac4d..088a00d81d1fc30ff77aacf31485871aebec7cb2 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/5968d14a1ef8a7eeacf342e1542099e1aff20f70..105d6c1fede00c3a9055e5a531ebf3d99bac406e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/bfcd034f1485b533b0fd7a14b79b6ce146369665..aa1607f891cefd0a338b65bd8f2254e2c4fbf87c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I1c8f83d7c1087518310b40f1ac9083f4403d227b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6769128 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 6a04a50f 2025-07-17T13:50:47 Update DEPS for VMA thread safety suppression * Updated DEPS to reflect the latest changes regarding the suppression of recently added thread safety warnings, which affect the Vulkan memory allocator. Bug: chromium:430317494 Change-Id: Idd2d6ead85b804a3984b1fd1c34ae7ae556e41df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6767000 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Gyuyoung Kim 0691b92e 2025-07-16T10:19:19 Fix the wrong condition for EnsureLoopForwardProgressTest The original CL should have used the angle_enable_glsl condition to disable the test on iOS, since this variable is not enabled on that platform. Bug: b/426055001 Change-Id: Ia53c066dcbc473358ae89e625abcf83660bd019a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6756696 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Takuto Ikuta 7b36840b 2025-07-17T18:12:53 Fix missing includes This is to fix some errors in https://ci.chromium.org/ui/p/chromium/builders/ci/linux-modules-compile-fyi-rel/42032/overview Bug: chromium:40263312 Change-Id: I278fd42062a52cbfe7e778f98d3e72cdd490847f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6765303 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 1239266b 2025-07-16T16:28:12 Do not read .git/packed-refs if the git refstorage is reftables Traditionally, git is configured with: extensions.refStorage==file. It means if .git/HEAD stores a symbolic reference, e.g. /refs/heads/main, the hash of main branch is stored in either: 1) .git/refs/heads/main 2) .git/packed-refs However, on the newer version of git where the git is configured with: extensions.refStorage == reftable, neither of the above files exist. Git will store the reference in binary files under .git/reftable. We should add different files as gn action input based on if git is configured with reftable or file backend. Bug: chromium:432289353 Change-Id: Ib42828313f3a7200e55420574a8ddac2ba63f2e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6761844 Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Cody Northrop de6d58f4 2025-07-13T19:24:34 FrameCapture: Fix blend state per draw buffer in MEC Before this CL, we've never set starting state for draw buffers other than buffer zero. They've always remained at default values, or at least matching the values set for zero. Now when we detect the other buffers differ from buffer zero, we emit indexed calls that set them correctly. Turning a sequence like this: glEnable(GL_BLEND); glBlendFuncSeparate(GL_SRC_ALPHA, ...); glColorMask(GL_TRUE, GL_TRUE, GL_TRUE, GL_FALSE); into this: glEnableiEXT(GL_BLEND, 0); glBlendFuncSeparateiEXT(0, GL_SRC_ALPHA, ...); glBlendFuncSeparateiEXT(1, GL_SRC_ALPHA, ...); glEnableiEXT(GL_BLEND, 2); glBlendFuncSeparateiEXT(2, GL_SRC_ALPHA, ...); glColorMaskiEXT(2, GL_TRUE, GL_TRUE, GL_TRUE, GL_FALSE); glEnableiEXT(GL_BLEND, 3); glBlendFuncSeparateiEXT(3, GL_SRC_ALPHA, ...); glColorMaskiEXT(3, GL_TRUE, GL_TRUE, GL_TRUE, GL_FALSE); glColorMaskiEXT(4, GL_FALSE, GL_FALSE, GL_FALSE, GL_FALSE); glColorMaskiEXT(5, GL_FALSE, GL_FALSE, GL_FALSE, GL_FALSE); Test: Wuthering Waves trace Bug: b/431854319 Change-Id: Ic91d4b8cf50defd8b69ecf6aac697d0df8f69692 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6735677 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 67fe02cc 2025-07-17T10:01:29 Roll vulkan-deps from d28110d62aa4 to 286b9f0629a4 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d28110d62aa4..286b9f0629a4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/03b20856e3e5dae1d1741e0372e106414c294415..bfcd034f1485b533b0fd7a14b79b6ce146369665 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I798df4038b738af4e8b5023fc064091a13f36dea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6763643 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ed15cbd4 2025-07-16T10:01:57 Roll vulkan-deps from 4e8bc564952b to d28110d62aa4 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4e8bc564952b..d28110d62aa4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/6c9b7771527dc92cd3efde054ec0704557f31ae9..f89d9f982d1afe9fec6239fdc73b972bb0b4abe3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/7cff847503174e2049b08253ee5f30428866fea3..f69f0433bae0b30598380ef0420b9d2d02dbac4d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/235d1d2cf617af03a2ecbf6e951287595138feda..f946876731972cb323b021b78d1921aa9244808b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6f5b5e78b22cdd8d9535986e0d4c1b94ebe2d7b4..03b20856e3e5dae1d1741e0372e106414c294415 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I65cd60a625810fdd7aa0c59c0271b7a6021f727f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6758915 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 28d759cd 2025-07-16T07:09:53 Roll Chromium from a9fc4ae13759 to 3f250af9a632 (705 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a9fc4ae13759..3f250af9a632 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/70c150bc0a..c734cf94f4 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/428390e5e3..bb0dbc354c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b8f44a601a..da9b17c744 * third_party/android_build_tools/lint/cipd: 4wuXV6kRekEDGfw7Du9CYwHpAy2Kid1LP83vU1VmHoUC..Udt_ui9-OCSxeIcww7Glc5tu_22Nynmo1p-LSAUG6qkC * third_party/android_build_tools/manifest_merger/cipd: FLEP0X72qx2m1yrM43PuOhtsxlEgqOtpiG9WBzl9_VgC..X1QeCG1bnGy8cHpJcHN8WYgMmiQXjpDUbIvx7cc1MbMC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e33c8a1d71..31cfff6e10 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ffa0089e2c..16ae41e875 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fa0292bfbe..8532fbcf79 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/4a1b486425..8eeec53078 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/3b4cfd9875..cac117af24 * third_party/siso/cipd: git_revision:f96f46a8e4cf30c097110903d4b71516ef976fb6..git_revision:dcd000e47f19677c7a5e02550abafa9eadbd4923 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/bf1e8de6cc..363a126ed2 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d607298097..7ade8a8f2a * tools/luci-go: git_revision:f703132ac353da666df180762f59ddac9c91594c..git_revision:6d38f0fa9f6c3c973753dbb762b0ed7b711db56c * tools/luci-go: git_revision:f703132ac353da666df180762f59ddac9c91594c..git_revision:6d38f0fa9f6c3c973753dbb762b0ed7b711db56c * tools/luci-go: git_revision:f703132ac353da666df180762f59ddac9c91594c..git_revision:6d38f0fa9f6c3c973753dbb762b0ed7b711db56c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/775ff79edb..a840c75371 * tools/skia_goldctl/linux: KCo7Lg4SuHJXTXEj_I63tP9huvzRni1axcDQ8t4fpJsC..S61nYM2LARYt8FGKUv9IwoQhQe-J4-IuZJ23SCq5R1oC * tools/skia_goldctl/mac_amd64: kmLqktry2Sv-JeG-gufWzWWt9lyIEh1APpkDay-nvn0C..d88GmiB-c0r_703cXAupUOC3E17SEnJ2gWASKadmsdsC * tools/skia_goldctl/mac_arm64: 3PdwEJIjUzT3GKwX2f-GBcY-Nn18qL3TqS6N5GnHIL4C..97SClzQJSwtymf_fcA4k_ZKZ2-BFRfFpUqIrgsRMM0EC * tools/skia_goldctl/win: GaVdXTdDGGBHQdW6qHtziqhqR6RHk_az7g0BOtUg2nIC..KuqayTqHpavNZjlc3YwoVsu3LhcUItZKbHs-NEl148sC * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/5ba62550b2..da34b95fdb No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I625acbe37a56c86b6741388d718bb27aa23d1114 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6758913 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 890b5d8f 2025-07-07T13:06:54 Vulkan: Encapsulate more descriptor set logic in ProgramExecutableVk - ProgramExecutableVk handles SharedDescriptorSetCacheKey updates - Inline most update*DescInfo methods - Add dedicated methods to handle uniform and storage buffers to remove some branches from frequently used code paths Bug: angleproject:426412564 Tests: UniformBufferTest31.UniformBufferBindingRangeChangeWith*FBF Change-Id: I54b8ae2bd8778231e4d187b2cfd30f4d71de7f3b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6733546 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Kimmo Kinnunen b3986258 2025-07-14T14:47:02 Include <utility> in PoolAlloc to fix gcc builds std::exchange needs #include <utility>. Bug: angleproject:429513168 Change-Id: I61e323055cb70545bda883c8bcfb103dcede5136 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6734441 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Renato Pereyra d36f1d71 2025-07-15T14:55:30 Enable AFDO for the Android EGL/GLES libraries built in-tree Bug: b/432060204 Bug: b/383305597 Test: Built ANGLE in Android tree Change-Id: Ifecc3ba56fb4c05133cca4d1ac35049bd6d59726 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6757853 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Takuto Ikuta c03b2d59 2025-07-15T14:18:28 common: Fix include for std::exchange This is to fix error in https://ci.chromium.org/ui/p/chromium/builders/ci/linux-modules-compile-fyi-rel/41761/overview Bug: chromium:40263312 Change-Id: I4d37bd92370b80856571cdd97144b61f8477f362 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6734419 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Devon Loehr ae19969a 2025-07-14T18:23:40 Suppress thread-safety in its own config Followup to crrev.com/c/6716457. Some targets remove the warning config, so move the suppression flag to its own config that is always used. Bug: chromium:430317494 Change-Id: I088e66fca1011ec7fbf6459296f104d9ccb54267 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6732938 Auto-Submit: Devon Loehr <dloehr@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll e0697648 2025-07-15T10:01:36 Roll vulkan-deps from a7e6b510dbaa to 4e8bc564952b (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a7e6b510dbaa..4e8bc564952b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/da8d2caad9341ca8c5a7c3deba217d7da50a7c24..235d1d2cf617af03a2ecbf6e951287595138feda https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/06ae73a3dc3a03466817d8370355203dac7b79b1..5968d14a1ef8a7eeacf342e1542099e1aff20f70 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/cb20eb451cf2e272daaf40099e864a916d8b5542..dc6f68172430999a96a209ef4700784917dab1a2 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e123e58c8245e00d5b214450dd001df1b6281d87..6f5b5e78b22cdd8d9535986e0d4c1b94ebe2d7b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I1f24e7c91e363d19968c56b76057815d7ad900b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6735944 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1f4399f0 2025-07-15T03:01:06 Roll SwiftShader from c1f7fbbec4e1 to 65b2c4777e5f (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/c1f7fbbec4e1..65b2c4777e5f 2025-07-14 swiftshader.regress@gmail.com Regres: Update test lists @ c1f7fbbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: If9847d73dd9fcfa0484cbfd778b633d95f4b97b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6735195 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll db3e7490 2025-07-15T07:58:50 Roll Chromium from 4ff49a95c802 to a9fc4ae13759 (512 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4ff49a95c802..a9fc4ae13759 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cb592905b1..70c150bc0a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/920f26785f..b8f44a601a * third_party/android_build_tools/error_prone/cipd: 2lYOqu-UyPNYEMX0rO60MpXImuj6kMqnOlVshCO6JLEC..bCQ_MOCwzM4fJFiHDoTJEB9hoP1Oo-OypDACePv2ChEC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/2d708009cd..e33c8a1d71 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd8909f212..fa0292bfbe * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/8f9d244c75..3b4cfd9875 * third_party/turbine/cipd: oD9ecDiZFUZfazjjD0N5yl6G4aJsgODDdNjqIp5m1GwC..pLwUKCRZD6noaKQQ0JaosQDV85ccs7FpR9OJT4biM1UC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ce898434ac..775ff79edb No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I57eaa9b15995243eeb07261a4a077b32a010cbcf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6734875 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gyuyoung Kim ab1a2da0 2025-07-04T16:13:04 Disable EnsureLoopForwardProgressTest on iOS The CL[1] that enabled the optimization of simple loops introduced the EnsureLoopForwardProgressTest. However, this test relies on SH_ESSL_OUTPUT, which requires angle_enable_essl to be enabled. Since this is not currently supported on iOS, this CL disables the test on iOS until a proper solution is found. [1] https://chromium-review.googlesource.com/c/angle/angle/+/6575051 Bug: b/426055001 Change-Id: If694be82bad4b4724ace5051c9ee38829a367170 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6703073 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Yuxin Hu 7cbb77a8 2025-07-14T11:32:04 Fix the uniform reorder bug When sorting uniforms, we should first check if both uniforms are structs, and make sure to place the uniforms with specifier in front of the uniforms without specifier. Bug: chromium:431318231 Change-Id: I8be9501f34073983b7f3d040780b749a7366e3d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6733547 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shufen Ma d3119b0a 2025-07-07T09:35:04 Relax shader interface matching for program link ES spec 3.2 section 7.4.1 shader interface matching: With separable program objects, interfaces between shader stages may involve the outputs from one program object and the inputs from a second program object. For such interfaces, it is not possible to detect mismatches at link time, because the programs are linked separately. Before this CL, we are applying the the number of output varying and the number of input varyings must match requirement to both glProgram object as well as glPipelineProgram object which is incorrect. This CL removes such check from Program::linkVaryings. A new function LinkValidateInOutNumberMatching is added to handle the this program pipeline specific spec requirement. Bug: angleproject:424050949 Change-Id: I0d2e4360b37d175b2b998e341f15815915771413 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6704827 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shufen Ma <Shufen.Ma@arm.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Andrew Mitchell b9588511 2025-07-10T01:18:47 Update committers policy for 2FA requirement Bug: b/415190329 Change-Id: Ic39602dcf31bcd04da0e13aaf9f5d7214a92c3db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6722090 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kai Ninomiya 3f170c17 2025-07-11T15:35:01 Roll third_party/dawn/ (1684 commits) and clean up WGPU_BREAKING_CHANGEs With this roll, Dawn has completed the WGPU_BREAKING_CHANGE_* changes, so the old paths are no longer used. The roll: https://dawn.googlesource.com/dawn.git/+log/7a8946456d49..d85fc050fef7 Created with: roll-dep third_party/dawn Bug: chromium:427242889 Change-Id: Ia17fbc1447944e7bcea20d5004367d94cf7be10e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6729918 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 11d20bf3 2025-07-14T10:01:37 Roll vulkan-deps from 5e97ca13797b to a7e6b510dbaa (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5e97ca13797b..a7e6b510dbaa Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f33fa78f889a176db127e323064f86501e7a679a..4056002eb2401b9406e78b9ea71fd0ce65737ebe https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/2e434ffa1bb776fa2f613269daf6b267aa5e6d1f..6c9b7771527dc92cd3efde054ec0704557f31ae9 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/7806d0a7006b51979b891d807ae285e1f3554b36..257a227fbadf8176ea386c7d8fb9b889cbf08640 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/2cd90f9d20df57eac214c148f3aed885372ddcfe..7cff847503174e2049b08253ee5f30428866fea3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e14ac8c7545d7397bc6e902fec716a8a10995f4d..e123e58c8245e00d5b214450dd001df1b6281d87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I5440333cd67b6c1eb07616693c90af1a553ac017 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6733301 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f1658153 2025-07-14T09:14:38 Roll Chromium from ddc3627f40bf to 4ff49a95c802 (819 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ddc3627f40bf..4ff49a95c802 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9a0b74bfb0..cb592905b1 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/17bdad4a57..428390e5e3 * buildtools/linux64: git_revision:635a71e20e99db0b08520ca0746b501167a5c7e5..git_revision:c4748415f12ac92d2781608b8b84fcc0e33e5ff9 * buildtools/mac: git_revision:635a71e20e99db0b08520ca0746b501167a5c7e5..git_revision:c4748415f12ac92d2781608b8b84fcc0e33e5ff9 * buildtools/win: git_revision:635a71e20e99db0b08520ca0746b501167a5c7e5..git_revision:c4748415f12ac92d2781608b8b84fcc0e33e5ff9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ab78562f47..920f26785f * third_party/android_build_tools/lint/cipd: SprQhm8ND7zXM2ZhH-8EwKeVUJiLGvzpriWfty0071cC..4wuXV6kRekEDGfw7Du9CYwHpAy2Kid1LP83vU1VmHoUC * third_party/android_build_tools/manifest_merger/cipd: nttKi291XL8l3g1B2tNCmfxEtDcCa9tfIghqosYX22oC..FLEP0X72qx2m1yrM43PuOhtsxlEgqOtpiG9WBzl9_VgC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b3eb8f07c3..ffa0089e2c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c2a6159a0d..dd8909f212 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/8c999157a9..8f9d244c75 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/93cad36976..2a25945218 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1c0b50128b..6c50647ee9 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/11e9f8e093..ce898434ac * tools/skia_goldctl/linux: zqVpcU_pZ6eeM_4GIZzXgzy9VxI8afqtNPpRXxjqXWkC..KCo7Lg4SuHJXTXEj_I63tP9huvzRni1axcDQ8t4fpJsC * tools/skia_goldctl/mac_arm64: DTcviz1jGdq8E1HXhjV1G6jsKCX3lJ8gr5KW0F1n3iAC..3PdwEJIjUzT3GKwX2f-GBcY-Nn18qL3TqS6N5GnHIL4C No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I4381f6a4f85c6a644ae9943b9db8766ed9782082 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6732784 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 93b659f9 2025-07-04T12:35:29 Remove PoolAllocator push/pop feature PoolAllocator would manage a stack of memory pools upon client calling push() and pop(). This made the code unnecessarily complicated. The feature was only used with nesting of one, to mark the memory unused after a shader compile. Fix by removing the push/pop feature. Instantiate PoolAllocator in places the previous push() was and uninstantiating instead of previous pop(). This removes the feature where the PoolAllocator would hold on to the allocated memory in order to reuse it. This is seen as a progression: the allocator is held by the compiler, the compiler is held by the shader and each shader typically see only one compile. Thus the free pages were just leaking unused until the shader was destroyed. Instead, destructing the PoolAllocator instead of pop() will donate the memory back to platform/OS, where it is likely more useful. To preserve existing Vulkan behavior, add PoolAllocator::reset() which would mark the memory unused but leave them reserved for the PoolAllocator. Removes UB where PageHeader::nextPage would be accessed after ~PageHeader. Bug: angleproject:429513168 Change-Id: I21e58b46e0887380db3a2cab5ce22f0042cfae9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6701153 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 1efc27c6 2025-07-14T08:01:31 Roll VK-GL-CTS from 46724b178e40 to 73db56e823f8 (16 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/46724b178e40..73db56e823f8 2025-07-11 syoussefi@google.com Call vkAcquireNextImage only once for shared present modes 2025-07-11 ziga@lunarg.com Add VK_EXT_debug_utils tests with transfer and video only queues 2025-07-11 ziga@lunarg.com Add image tests using general layout 2025-07-11 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12 into vk-gl-cts/main 2025-07-11 michal.jakubek@mobica.com Mispell of vkDeviceFeturesVariantDecl in Capabilities System 2025-07-11 marcin.zajac@cognizant.com postCheckout procedure for vulkan-validationlayer 2025-07-11 rgarcia@igalia.com Fix CMake config and build warnings for DEQP_LOG_NODE_SOURCE 2025-07-11 marcin.zajac@cognizant.com Expand query pool statistics testing 2025-07-11 maciej.dziuban@amd.com Add sample location tests for non-MSAA images 2025-07-11 javed@igalia.com Add option --deqp-log-all-images 2025-07-11 pdaniell@nvidia.com Ensure all floats are +ve when converting to uint 2025-07-11 pierre-eric.pelloux-prayer@amd.com Use correct BARRIER_BIT in load/store tests 2025-07-11 jbolz@nvidia.com Change tcu::Float FLOAT_SUPPORT_INFINITY to FLOAT_NO_INFINITY 2025-07-11 gleese@broadcom.com Add rounding mode support for double to deFloat16 2025-07-11 rgarcia@igalia.com Test calling EmitMeshTasksEXT in control flow 2025-07-11 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I62ace820a8489113d1ced6b985a8f1368aea802b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6733022 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 1443a451 2025-07-04T16:18:30 Regenerate the parsers with current cl format The format tool has changed since last parser generation. This causes overly many changes when downstream regenerates the parsers. The diff formatting fails for flex and bison generated content. Format them in full always. Bug: angleproject:429588208 Change-Id: I7a4b8e966e9502920fc25f5c1c5bf80246f5cf0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6705451 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Cody Northrop 03356f06 2025-07-10T19:21:04 Vulkan: Skip VK_KHR_maintenance9 warning A warning has been added about behavior that will change if VK_KHR_maintenance9 is enabled. Since we can't make this change until drivers support the feature, let's add warning that will fire when we do decide to turn it on. This CL: - Adds a feature for maintenance9 - Adds a VVL skip if isn't enabled - Updates our skip code to check for message IDs Test: Traces Bug: angleproject:429339330 Change-Id: I5763cbc5f343ef165ff8810b9b60b8c809075b8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6724905 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi 065b80a6 2025-07-10T15:50:43 Vulkan: Remove the enum to indicate submitted CB Currently, the function ContextVk::submitCommands() takes the following enum to indicate whether all command buffers or only the outside command buffer is submitted: "Submit" However, ContextVk::submitCommands() is only called twice. Also, this enum is only used to manage a few things, such as garbage collection, and finalizing foreign image layouts. It is possible to move these operations to the respective callers and remove this enum completely. * Moved the operations relying on the enum "Submit" to the locations before submitCommands() as required. * Removed the enum "Submit". (Credit for the idea to move the ops up to the callers: cclao) Bug: b/425987310 Change-Id: Ic0e1c15ee3d2e7cf22a4f7a57b6ac31acc38c861 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6724899 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 2bfd1727 2025-07-11T10:01:36 Roll vulkan-deps from 5f1b6fd3d9c3 to 5e97ca13797b (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5f1b6fd3d9c3..5e97ca13797b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2e24222cd9d19e737f8c790a2f485d5ba0d62166..f33fa78f889a176db127e323064f86501e7a679a https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/cc0c28a22acce6de2ef77d41fd7d7b922f7c21e0..2e434ffa1bb776fa2f613269daf6b267aa5e6d1f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/8dec5f4c41b34e2895e57d3009da93ebadb9f831..e14ac8c7545d7397bc6e902fec716a8a10995f4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I6e514d8df5b6af850a2afc7de91db8a0d951242e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6725182 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 43baba22 2025-07-11T07:27:38 Roll Chromium from c8f8677ca55f to ddc3627f40bf (582 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c8f8677ca55f..ddc3627f40bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/777cde7d79..9a0b74bfb0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1a1b9975e2..ab78562f47 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/3c08e5e7d4..2d708009cd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/09cd5e163e..b3eb8f07c3 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7784911e43..c2a6159a0d * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/f37e727ed1..8c999157a9 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/3102d2a0da..bf1e8de6cc * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b17ffb3e80..d607298097 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ede01d2603..11e9f8e093 * tools/skia_goldctl/mac_amd64: T9oaospSraHP7PbSCu8LqHHz9MTeuISEv4PUGBnFkOgC..kmLqktry2Sv-JeG-gufWzWWt9lyIEh1APpkDay-nvn0C * tools/skia_goldctl/win: R5dpE9jzORx6Rxc3KF5daqWnVsYylVOsaAd6G87eY4MC..GaVdXTdDGGBHQdW6qHtziqhqR6RHk_az7g0BOtUg2nIC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I9e2a787b8574bc31a29832492f2221646a57bd33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6726364 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 68fa8169 2025-07-09T18:02:16 Vulkan: Reformat VVL error message Remove the VVL that is no longer observed on bots. Reformat the other VVL to use extraProperties only. Bug: angleproject:40644740 Change-Id: I57da1259754d5eba18c8c11385872b3ec9527e09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6719618 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Mohan Maiya 3b90872b 2025-07-06T09:02:27 Vulkan: Selectively invalidate uniform buffers Call invalidateCurrentShaderUniformBuffers iff current program has active uniform buffers. Also add DIRTY_BIT_UNIFORM_BUFFERS bit to mNew*CommandBufferDirtyBits Bug: angleproject:426412564 Bug: angleproject:429585235 Tests: UniformBufferTest31.UniformBufferBinding*WithMultiplePrograms* Change-Id: I88c37c8317205aecad638553846ffe3beff87f11 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6706537 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Tim Van Patten 6d18ed63 2025-07-08T16:26:53 ValidateGetTexLevelParameterBase: Remove ES 2.0 check This CL addresses review comments in: https://crrev.com/c/6710993 1. Remove the ES_2_0 check for GL_MEMORY_SIZE_ANGLE in ValidateGetTexLevelParameterBase() since the GL_ANGLE_memory_size extension already requires OpenGL ES 2.0, making the version check redundant. 2. Update the test MemorySizeTest.BasicUsageTexture to use the function glGetTexLevelParameterivANGLE() if the context version is below OpenGL ES 3.1 and the extension GL_ANGLE_get_tex_level_parameter is available. Bug: b/409384875 Change-Id: I831d4b35eec20fcb4aff331c5a642a749bd52e67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6715885 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Jeff Vigil 41a5b397 2025-07-09T09:17:10 Vulkan: Fix checking if fds are identical This helps to decide whether it's really disjoint or not. Bug: angleproject:426480610 Change-Id: I8ec9b352195ab16a7e11d2dab30e98138d9f5a6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6658648 Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 5f8d93fc 2025-07-10T10:01:02 Roll vulkan-deps from c91d04c5a3ae to 5f1b6fd3d9c3 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c91d04c5a3ae..5f1b6fd3d9c3 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/9d0dbe9d59159ac936cdc56f9fc85e001afed183..cc0c28a22acce6de2ef77d41fd7d7b922f7c21e0 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/54fc95232ced45f39348c091f6f95545588e350a..7806d0a7006b51979b891d807ae285e1f3554b36 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2991293a9a1d1d3a9d87d7737dbe812252c1fb40..8dec5f4c41b34e2895e57d3009da93ebadb9f831 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I13b6c4bae06e5d4df5be941e0bbd18617237ff26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6721311 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3f1cc048 2025-07-10T03:01:43 Roll SwiftShader from be6ed66fa563 to c1f7fbbec4e1 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/be6ed66fa563..c1f7fbbec4e1 2025-07-09 swiftshader.regress@gmail.com Regres: Update test lists @ be6ed66f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I51c0a81c4a2cca0cf4af3683c00dd7288504bc90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6720934 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Corentin Wallez 5d51bd19 2025-07-01T15:40:10 Translator: Handle arrays of samplers in FlagSamplersWithTexelFetch This was found while running tests for Dawn's "sized binding arrays" (including arrays of textures) with ANGLE + Swiftshader. Adds a test that ASSERTs without the change. Bug: chromium:411573957 Change-Id: Ib7fad0f5c0b4f3aa70e6af5bf5977b82956e1986 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6695013 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
angle-autoroll 7bd4c395 2025-07-10T07:52:06 Roll Chromium from be763f950c79 to c8f8677ca55f (388 revisions) https://chromium.googlesource.com/chromium/src.git/+log/be763f950c79..c8f8677ca55f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f7a659bc4e..777cde7d79 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5f058f2af1..17bdad4a57 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c11db4cd92..1a1b9975e2 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/209ab6791b..3c08e5e7d4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0f872505cc..7784911e43 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/3f8818c405..f37e727ed1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6eae421681..b17ffb3e80 * tools/luci-go: git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af..git_revision:f703132ac353da666df180762f59ddac9c91594c * tools/luci-go: git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af..git_revision:f703132ac353da666df180762f59ddac9c91594c * tools/luci-go: git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af..git_revision:f703132ac353da666df180762f59ddac9c91594c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4410576c49..ede01d2603 * tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/bc02803b16..3438d4183b * tools/skia_goldctl/linux: 2v1Ogsr5B2ZzLTgxhDCUrs7f3QNdJAw0etD0NJPFkBwC..zqVpcU_pZ6eeM_4GIZzXgzy9VxI8afqtNPpRXxjqXWkC * tools/skia_goldctl/mac_amd64: sB2C9nyKoe0aixRfQ9ociaa3TGzo8Pn5em_Md8a51a0C..T9oaospSraHP7PbSCu8LqHHz9MTeuISEv4PUGBnFkOgC * tools/skia_goldctl/mac_arm64: yQbqw0wv-j0IsBpNmiZnivv8rVuM2ZfaKDm-2DoDw1kC..DTcviz1jGdq8E1HXhjV1G6jsKCX3lJ8gr5KW0F1n3iAC * tools/skia_goldctl/win: YwoTmtJT_JKxB9mVFMCkzABlA_hIEw8P2qB3pTZ0azUC..R5dpE9jzORx6Rxc3KF5daqWnVsYylVOsaAd6G87eY4MC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ic0eccaab44a328ce4ae86e2f3c51647e0f1aa967 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6721990 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi ec2a04cc 2025-07-09T16:09:08 Vulkan: Skip dEQP clip/cull tests for GS/TS * Skipped the following KHR-GLES3 tests on the Vulkan backend: *.cull_distance.functional_test_item_{5/6}_* Bug: angleproject:42264006 Bug: b/415288635 Bug: b/353358652 Change-Id: I0cc052a66fa91d2c8e4e9f433bec9a3db2962bb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6720745 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
kmx.io     mail     discord kmxgit v0.4.0