kc3-lang/angle

Log

Author Commit Date CI Message
Jamie Madill 541cdcbf 2022-11-23T15:44:53 Fix flakiness in EGL surface multithread tests. This moves the surface acquisition to inside the scoped lock. This should fix the flakiness we see on the linux-tsan-test bot. Bug: angleproject:7791 Change-Id: Idcc0f3c9d6e172b446f10c32bf6fb911fd887658 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4051622 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll e9e0da6a 2022-11-23T19:53:46 Roll VK-GL-CTS from 2db7b0a1c310 to 9d22258ed442 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2db7b0a1c310..9d22258ed442 2022-11-21 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_mutable_descriptor_type into vk-gl-cts/main 2022-11-21 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/dev/VK_EXT_descriptor_buffer into vk-gl-cts/main" into main 2022-11-18 quic_mnetsch@quicinc.com Update json files for postmortem features 2022-11-18 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_device_address_binding_report into vk-gl-cts/main 2022-11-18 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_device_fault into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I449b3a3e46c83084544712efe53fa608fd4c6857 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4052764 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu d5ce0b80 2022-11-23T12:16:46 Skip crashed test on Pixel6 due to a bug in precision matching fixer We recently need to add back the code that does spriv precision match fixer to help IMG fix a triangle clipping issue. However, the code added back is causing Pixel 6 to crash on this test: dEQP-GLES31.functional.shaders.linkage.es31.tessellation.varying.rules.internal_different_precision We are skipping this test for now until we add a feature to enable the code path on IMG only. Bug: angleproject:7488 Change-Id: I0fb2738d2faabe2ca78077e0383af3d100c75b03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4053100 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cody Northrop 71ead7b4 2022-11-20T15:56:42 Tests: Add Diablo Immortal trace Test: angle_trace_tests --gtest_filter="*diablo_immortal*" Bug: angleproject:7402 Bug: angleproject:7837 Change-Id: I7c7ccc0099707714213564740f58f04f7965a275 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4041134 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Charlie Lao 6458178e 2022-11-18T11:39:16 Vulkan: Clean up flushCommandsAndEndRenderPass APIs ContextVk::flushCommandsAndEndRenderPassWithoutQueueSubmit is calling flushCommandsAndEndRenderPassImpl(QueueSubmitType::SkipQueueSubmit). This is a bit odd and creates confusion and trouble with future CLs. This CL removes QueueSubmitType and straight up the submission code and removes some function that was doing little but to call another function. Bug: b/255414841 Change-Id: I0ed2122a98b0fc5b819fd331173bf6945d23ff8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4038095 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 7dd8478e 2022-11-17T10:11:02 Vulkan: Make ResourceUse::serial an FastVector of Serials In preparation for per context queue serial, this CL makes ResourceUse::serial a FastVector of Serial. Right now we still limited to one serial index so that it still work the same way as before. This CL adds necessary data type and change the function names to reflect that tracking GPU progress needs a ResourceUse object instead of a single Serial number. Bug: b/255414841 Change-Id: Ic60cdf5ec8da45d1821f65a55947f5c553f65737 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4034548 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Ian Elliott 0e12695c 2022-11-23T08:31:43 Suppress VUID-VkGraphicsPipelineCreateInfo-renderPass-06040 Bug: angleproject:7843 Change-Id: I013dd1d2942c7b9d340ae4e3c4124b592dc9b94b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4049765 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 6384f76b 2022-11-16T21:47:04 Vulkan: Move PipelineCacheAccess to namespace vk In preparation for a change that uses it in that namespace. Bug: angleproject:7369 Change-Id: Icc75b8839d702fd3e6d3d00c1d8f81619cdd89cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031150 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 11de5157 2022-11-14T14:48:33 Capture/Replay: Reset Shaders We've been resetting Programs correctly, but not Shaders. This hasn't been a blocker so far, but it has been identified as a performance problem for traces that compile mid-trace. We're not getting cache hits because the persistent blob cache is not updated until a shader is deleted. Part of the challenge here is ShadersIDs and ProgramIDs share a ResourceIDType, so separating them requires a bit more tracking. To fix, start tracking which ShaderProgramIDs are actually shaders and emit the correct glDelete* command. Test: diablo_immortal MEC Bug: angleproject:7823 Change-Id: I934f6eee243ab9681dca5fdebdad33ba31457cf5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4029226 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 5c301b52 2022-11-23T13:08:12 Roll Chromium from ab42c3da0f40 to 9f3d33d253ac (64 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ab42c3da0f40..9f3d33d253ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8961725eee..88913de942 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1a716cbded..7b5c1435de * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cce68bc50e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2fc7e1ffd5..6fde0fbe92 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4d7494f60c..842cb67d55 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8ee02eacb5..7f2b5fe8eb No update to Clang. Bug: None Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: I58d9e100bdf3eefded571e09f1c82e2ffc3efc1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4050291 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 494640e5 2022-11-18T12:02:28 Capture/Replay: Make secondary contexts current during MEC When replaying, the context is made current at the beginning of the context setup function, and is still current when we hot the validation point at the end of the setup function. When a context is current is has a valid default framebuffer, and hence, during a replay of the trace the context serialization will contain this framebuffer. However, during MEC the secondary contexts were not made current during capture, and hence they dind't have a default framebuffer which resulted in a validation error. Therefore, make the secondary contexts current when they are captured during MEC to make sure we also capture the default framebuffer. Bug: angleproject:7812 Change-Id: Iaccc4150e8a71a02286e772882fb150bef1d82a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4037982 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll c03478e0 2022-11-23T07:00:14 Roll Chromium from 2e2c857c4980 to ab42c3da0f40 (572 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2e2c857c4980..ab42c3da0f40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/81415f1f5f..8961725eee * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/09154d65c3..3c8fef071e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3329b47db7..1a716cbded * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cce68bc50e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/30e3ce8b1c..2fc7e1ffd5 * third_party/fuchsia-sdk/sdk: version:10.20221121.3.1..version:10.20221122.0.1 * third_party/r8: zJXokrYtEiaa-jjRGetxUuWf3Zkv_G7Fvl5oCXkhBAsC..6IAjJKfUwjFSLKQ31fxSTeXHZXcsGeoUlMKBcirZTbUC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/77843ad775..4f8bb52f0a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ed1991b2c6..4d7494f60c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1e02624893..8ee02eacb5 No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I4b602888d7070f2927627cd0af688d7710c2a7e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4050481 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 3db679eb 2022-11-22T10:37:31 Revert "Vulkan: Remove useRelaxedPrecision" and "Vulkan: remove SpirvVaryingPrecisionFixer" This reverts commit cb618b3d42d9013c48b5aa233efc4d80a9c4efa4 and commit 427086a9c7612da7325cb36054859a929c3727d5 Reason for revert: IMG reported that they need to keep the "precision qualifier matching" feature to make triangle clipping work properly, because the clipping needs to to know the decoration in vertex shader output in order to sort the data correctly for clipping. Original change's description: > Vulkan: Remove useRelaxedPrecision > > Bug: angleproject:7488 > Change-Id: I30ca3e2740d8810a01615ca778eb072d77ad34d9 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3856658 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Original change's description: > Vulkan: remove SpirvVaryingPrecisionFixer > > Bug: angleproject:7488 > Change-Id: I957839bd8fbdf1cd849d5ed7e9edd65fd1a5f2cb > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780874 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:7488 Change-Id: I90b584cbc549a663bca734a59d135a1d1d5bcbfc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4049421 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 27727e50 2022-11-21T00:00:00 Fix ProvokingVertex typos Aligned the parameter name with the upstream specs Moved ValidateProvokingVertexANGLE to validationESEXT.cpp Bug: angleproject:2829 Change-Id: I820a90c20ef0a1873640c933b1de52526cac7e70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4043701 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Amirali Abdolrashidi b2f55ec3 2022-11-14T16:07:19 Vulkan: Add memory allocation/deallocation counter * Added a counter to the renderer object to keep track of the memory allocations and deallocations per allocation type. * The counters are updated with the functions onMemoryAlloc() and onMemoryDealloc(), which can be added next to the allocation or deallocation point. * Currently used for buffer memory and image memory. * Removed some of the redundant arguments from vk_helper and suballocation functions. Bug: b/242641395 Change-Id: I58b38f619df7bef0ba5fa3373a8db5aed0ef142c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4014164 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao c5724a8d 2022-11-17T15:48:16 Vulkan: Retain mCurrentGraphicsPipeline if RP started ContextVk::mCurrentGraphicsPipeline is created before renderpass started. Right now we retain mCurrentGraphicsPipeline immediately. In future CL of per context queue serial, renderpass will not have queue serial until started, which means we can only retain pipeline object after renderpass started. This CL moves the mRenderPassCOmmands.retain(mCurrentGraphicsPipeline) call to renderpass start time. This exposed a bug that ContextVk may have a dangling mCurrentGraphicsPipeline pointer to an already destroyed object, if the program has been destroyed. When ProgramExecutableVk::resetLayout() calls ContextVk::onProgramExecutableReset () we early out because executable no longer matches. This causes mCurrentGraphicsPipeline still point to now deleted pipeline object. This CL fix this dangling pointer bug by always clear mCurrentGraphicsPipeline to null in ContextVk::onProgramExecutableReset() without checking if program executable is the one gets reset. Bug: b/255414841 Change-Id: I6d698c517d7a948b65c465eaaa59ea0bca24e2c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4035107 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev fc1c8cd1 2022-11-01T00:00:00 Refactor validation of partial compressed texture uploads Optimized ValidCompressedSubImageSize for valid usage and simplified its control flow. Fixed false negative validation when the replaced image region does not fill the entire level but nevertheless reaches the image boundaries. Updated InternalFormat::getCompressedImageMinBlocks to use IsPVRTC1Format helper function. Fixed InternalFormat::computeCompressedImageSize for 3D compressed texture blocks. Removed redundant checks from ValidateES3TexImageParametersBase. Optimized IsPVRTC1Format helper function to be a constexpr. Adjusted tests, added suppressions for Intel and Adreno. Bug: angleproject:7473 Change-Id: I6fadce949785a35e2706b06eeb00e878aa3710a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4037671 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Geoff Lang 15c8a055 2022-11-22T13:31:39 GL: Only reset transform feedback varyings when necessary. ProgramGL sychronizes all state before linking. This means setting the transform feedback varyings to 0 when transform feedback is not used. Skip this call to synchronize transform feedback varyings when it will have no effect. This is a speculative fix for crashes on IMG drivers. Some of the logs mention glTransformFeedbackVaryings reading invalid memory. Bug: chromium:1322820 Change-Id: Ib4ba9c6ea6f9ab8accb82f243472c4d4443b7fd5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4049420 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Nicolas Capens 37d6a9db 2022-11-18T17:42:21 Support versioned library names Previously ANGLE_GLESV2_LIBRARY_NAME was expected to be the library name without extension, and on Linux .so would be appended. This didn't allow for building ANGLE as libEGL.so.1 and libGLESv2.so.2 as is common. This change checks if the library name already contains a dot, and if so doesn't append the platform specific extension suffix. Bug: b/259282560 Change-Id: I81cda218180ae7fe6321e1ac7e4eff7257bf1493 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4038450 Commit-Queue: Geoff Lang <geofflang@chromium.org> Commit-Queue: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Nicolas Capens <nicolascapens@google.com>
Roman Lavrov c86f0988 2022-11-22T14:34:16 Cleanup: Use XAllocSizeHints, move to helper. Dynamic allocation (XAllocSizeHints) is recommended due to struct potentially changing in future. Also move the repated code block to a helper function. Bug: angleproject:7840 Change-Id: I1e91c7adc0e36e31a385263f5d1a556520ece45c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4048661 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 68b47e58 2022-11-16T10:46:59 Vulkan: Initial support for VK_EXT_graphics_pipeline_library When available, this change uses VK_EXT_graphics_pipeline_library to create pipelines. Currently, it is only used when graphicsPipelineLibraryFastLinking is available. This restricts the use of this extension to devices where monolithic pipelines are not any more performant than linked libraries. A future change adds support for other implementations by providing async pipeline creation. Bug: angleproject:7369 Change-Id: I1e3b7ac4aa56e75c7d6f4d0d5ea91cb0b862e581 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031489 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Steven Noonan <steven@valvesoftware.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 1f69f580 2022-11-18T14:33:20 Perf tests: Add --fixed-test-time-with-warmup Warmup trials combined with fixed-test-time was broken recently. It was already fragile and only worked when parameters were provided in the right order. On Android we're relying on this combination to get steady results without hitting thermal limits. To address this: - Add a new parameter that encapsulates the combination - ASSERT that flags aren't provided in unsupported combinations Test: python3 restricted_trace_perf.py --fixedtime 10 Bug: angleproject:7755 Change-Id: I56fce1f65d4f0538e623951163a9c8736cb3fb03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4027282 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Lubosz Sarnecki 317870f9 2022-03-08T14:47:14 Reland "util/X11Window: Set PMinSize and PMaxSize hints." This is a reland of commit a78eca2cab5f7826c1719e47fca229086ec06947 Revert https://crrev.com/c/3661210 refers to cropping on SwS bots which might be due to another X11 related issue I recently fixed (https://crrev.com/c/3979168) Lack of min width/height is triggering a swapchain recreation with smaller extents due to window being resized by the WM: https://anglebug.com/7840#c2 Also, capturing screenshots past the first frame (--screenshot-frame=2) results in partial screenshots. Original change's description: > util/X11Window: Set PMinSize and PMaxSize hints. > > Before this patch replay windows were down-sized to match the default > screen size in case their extent was greater than the screen size. > > Setting a PMinSize on XSizeHints resolves the issue on modern window > managers. Tested with GNOME Shell 41.3 with both native X11 and Wayland > (over XWayland) backends. > Setting PMaxSize was also requried to pass the > BlitFramebufferANGLETest tests. > > This fixes retracing with correct extents and resolves a VVL performance > warning. > > Bug: angleproject:6808 > Bug: angleproject:7083 > Change-Id: I00ee149ec02efe08c5801e4231913049d31e262b > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3507514 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Bug: angleproject:6808 Bug: angleproject:7083 Bug: angleproject:7840 Change-Id: Ide540ecf55c2c0f39635f2b6b0688d7c2ddffc0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4048025 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop 202fcb8d 2022-11-21T15:05:13 TraceTest: Route EGLSync entry points through WGL Test: diablo_immortal trace Bug: angleproject:7402 Bug: angleproject:7839 Change-Id: I8897337bac38cb1923e58a9503de01454766158d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4044865 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 72e2ce69 2022-11-22T10:01:36 Roll vulkan-deps from a3f4f653c783 to ca8ca2aba961 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a3f4f653c783..ca8ca2aba961 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/edd66a2fc9..c77b09b57c * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/974db1cede..b092b2fccc * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/6c7b2db415..3a092fe869 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/fc1c628605..7a9d51a51c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Id26b716a65cf697068114f5c1e75367b069c9b10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4046941 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 12fa46f0 2022-11-22T07:00:52 Roll Chromium from 26b47bd446e8 to 2e2c857c4980 (530 revisions) https://chromium.googlesource.com/chromium/src.git/+log/26b47bd446e8..2e2c857c4980 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bd893617b2..81415f1f5f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d5ad5f5098..3329b47db7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c996ebbd3d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d06e475934..30e3ce8b1c * third_party/fuchsia-sdk/sdk: version:10.20221120.3.1..version:10.20221121.3.1 * third_party/r8: vqsrb5_6fg9u-aSAqrcJiG7q2GOG66_39vdYTKgHmHgC..zJXokrYtEiaa-jjRGetxUuWf3Zkv_G7Fvl5oCXkhBAsC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ed5ed0ecab..77843ad775 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/124c1e7294..ed1991b2c6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/468419086d..1e02624893 Clang version changed llvmorg-16-init-10467-g1239d37b:llvmorg-16-init-10736-ged9638c4 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/ed5ed0ecabbf9b12b336a01a70f64aedf1a02a09..77843ad77570e76003c802390694598501abc6b8/scripts/update.py Bug: None Tbr: ianelliott@google.com Change-Id: Idb3489ac27cc8558d9bb9b1b5c9d92b9f579fdcc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4044052 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 356b2a59 2022-11-18T18:50:03 Roll VK-GL-CTS from c4fe10a0c86d to 2db7b0a1c310 (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c4fe10a0c86d..2db7b0a1c310 2022-11-18 tapani.palli@intel.com Fix for the string query tests on desktop GL 2022-11-18 aitor@lunarg.com Add tests for out-param aliasing against other variables 2022-11-18 cturner@igalia.com Fix a typo setupVertexInputStete -> setupVertexInputState 2022-11-18 rgarcia@igalia.com Improve failure error messages in format_feature_flags2 tests 2022-11-18 amber@igalia.com Add tests for linearly tiled images 2022-11-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main 2022-11-16 ziga@lunarg.com Merge vk-gl-cts/dev/VK_EXT_pipeline_protected_access into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ia91e36411440ba5fe572d0971b54ae6857bbeb9c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4037817 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Geoff Lang f37a32f0 2022-11-14T14:11:06 Remove DisplayGbm and SurfaceGbm. The Gbm classes were used to emulate WindowSurfaces on ChromeOS for testing. These emulated features are not used in any shipping configuration and cause issues because ANGLE opens drm devices uneccessarily. Bug: chromium:1344962 Change-Id: If564e40744f7825035bbbd63c141b154c534ed72 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4023096 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Ho <hob@chromium.org>
angle-autoroll 55d46ffa 2022-11-21T10:01:04 Roll vulkan-deps from eb108f5f3b15 to a3f4f653c783 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/eb108f5f3b15..a3f4f653c783 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1a7f71afb4..46ca66e699 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/38f7ab2634..fc1c628605 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Icd07184c48675986536dabca10945299d03b2f82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4041635 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll cbc75633 2022-11-21T07:00:13 Roll Chromium from 1f4a045ca0a4 to 26b47bd446e8 (645 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1f4a045ca0a4..26b47bd446e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dc2384c048..bd893617b2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a9bbf9d24e..d5ad5f5098 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b898eb3e06 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1f67d5573f..d06e475934 * third_party/fuchsia-sdk/sdk: version:10.20221117.0.1..version:10.20221120.3.1 * third_party/r8: SRv8kr_t534yPmvzQnKEBqgw_lidewzTdKnAKoWYkz0C..vqsrb5_6fg9u-aSAqrcJiG7q2GOG66_39vdYTKgHmHgC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d21aa5eb7e..ed5ed0ecab * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ff50c9b60c..124c1e7294 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d25dda6c4f..468419086d No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: Ia374a5814d6d9c2334dfb5fd8253fe7bd2fed86e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4041630 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 0c0bbcf5 2022-11-18T22:18:55 Revert "Vulkan: Only allocate default attribute if needed" This reverts commit 85c98a92bb763452133bd7b4580d80625bb2c75d. Reason for revert: This caused regression on pixel 6, https://ci.chromium.org/ui/p/angle/builders/ci/android-arm64-exp-test/1969/overview Original change's description: > Vulkan: Only allocate default attribute if needed > > mDirtyDefaultAttribsMask has all bits set when starts. > ContextVk::handleDirtyGraphicsDefaultAttribs() is looping all dirty bits > and try to allocate buffer for it, which means we are looping 16 > times when app starts. This CL changes to allocate a buffer only if used > by program. > > Bug: b/258862506 > Change-Id: I2f0a75d1fe141c9ac3101088fdc4ce4f60b0c4ee > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4024544 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Commit-Queue: Charlie Lao <cclao@google.com> Bug: b/258862506 Change-Id: Iff7d9c6d605613773f0b91a5539cefd6da6454eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4038449 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Charlie Lao <cclao@google.com>
Cody Northrop 3857752d 2022-11-18T14:35:42 Tests: Fix parameter parsing with partial matches New parameter parsing code needs a small tweak to handle partial flag matches. For instance, a new flag being added would trigger as if an old one had been provided: new: --fixed-test-time-with-warmup old: --fixed-test-time And if equals notations were being used: --fixed-test-time-with-warmup=value the code before this CL will treat the entire thing as --fixed-test-time and attempt to consume the next argument as value Bug: angleproject:7755 Change-Id: I57eae2847053d664338d40b0191d5223ddd95852 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4038494 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Charlie Lao 8378032e 2022-11-15T11:47:55 Vulkan: Remove get API for mLastCompletedQueueSerial In preparation for per context queue serial, this CL makes mLastSubmittedQueueSerial and mLastCompletedQueueSerial private to CommandQueue. Before this CL, we have a get function to return the last submitted serial and last completed serial and passing these serials around. This works because the serial is a single uint64_t number. With per context queue serial, this will be an array of serials and there is potential risk associated with access it from different threads. This CL makes these serials private to CommandQueue and when you want to know if GPU is completed with resource, you ask RendererVk/CommandQueue directly. This way we can ensure they have thread safe access in the CommandQueue (no lock is necessary, but all access will be restricted to one class). Bug: b/255414841 Change-Id: Ica565decce4a80588e0b447e179a2b634b55d7c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4021676 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Jonah Ryan-Davis 95cfa687 2022-11-18T15:26:36 Revert "Map AHARDWAREBUFFER_FORMAT_R8_UNORM to GL_R8" This reverts commit dcf3ab1228428b2f9d1449852e2359bad70e2dfe. Reason for revert: Causing AOSP roll build failures: https://android-review.git.corp.google.com/c/platform/external/angle/+/2308065?tab=checks Original change's description: > Map AHARDWAREBUFFER_FORMAT_R8_UNORM to GL_R8 > > Bug: b/259551816 > Test: cvd start --gpu_mode=guest_swiftshader > Test: atest librenderengine_test > Change-Id: I874278fe50dd1b501c11c484c55ed91e67a7013b > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4034130 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: b/259551816 Change-Id: Iac19db493ecda89bc49d05cc34f5b51818e39737 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4035110 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi c7414946 2022-11-16T10:35:33 Vulkan: Enable async pipeline cache sync by default Bug: b/246683126 Change-Id: I593650364250f8802e9f546ab9957cf1c30e596a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031487 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 3b21dfe4 2022-11-18T11:47:35 Roll Chromium from 54894332d13c to 1f4a045ca0a4 (59 revisions) https://chromium.googlesource.com/chromium/src.git/+log/54894332d13c..1f4a045ca0a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/316bdbb4f8..dc2384c048 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fd493f4659..a9bbf9d24e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..79ba9244e5 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4fc30da878..ff50c9b60c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/35428c527a..d25dda6c4f No update to Clang. Bug: None Tbr: jonahr@google.com,ynovikov@google.com Change-Id: If34ae69473a0cbf20312099152db49d551058347 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4035321 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ec424592 2022-11-18T10:01:25 Roll SwiftShader from dd35c62aef80 to 6a259c87ef52 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/dd35c62aef80..6a259c87ef52 2022-11-17 natsu@google.com Handle AHARDWAREBUFFER_FORMAT_R8_UNORM AHBs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ie4f2cfda15c57a841d2490e06dff0f7abdc609ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4037804 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 37bbbb51 2022-11-18T10:01:48 Roll vulkan-deps from f1b1fd3fc034 to eb108f5f3b15 (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f1b1fd3fc034..eb108f5f3b15 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8ea3ae6be2..1a7f71afb4 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/29c0457cc1..974db1cede * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/27d86008d8..6c7b2db415 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/c4839afe75..ec541c410e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/00d345294d..38f7ab2634 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I687badecb7210005c5ef2e9b02020b8c43f91ed0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4035855 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 658a4b6b 2022-11-18T07:00:34 Roll Chromium from 2c9d51705f3b to 54894332d13c (577 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2c9d51705f3b..54894332d13c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a6b135f6dc..316bdbb4f8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1f8966e6e2..fd493f4659 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/3f159e715e..c5a3f52f05 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..79ba9244e5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fadcbfdb27..1f67d5573f * third_party/fuchsia-sdk/sdk: version:10.20221116.3.1..version:10.20221117.0.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eea11ec5d2..d21aa5eb7e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9d3a5eb0dd..4fc30da878 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d900152808..35428c527a No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: I5a46ba74c1edcd0946de7255d16cb5107692de3b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4035041 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 81e9dc56 2022-11-04T00:00:00 Reland "Metal: Skip disabled draw buffers" This is a reland of commit 4b084310d7bbb33631d58a461eb5814c12220926 Do not try to create a command encoder with no attachments since it may crash some Metal drivers. Do not reset pipeline descriptors. Original change's description: > Metal: Skip disabled draw buffers > > When creating render pass descriptors, do not > assign textures to disabled color attachments. > > When creating pipeline descriptors, reset > pixel formats of disabled color attachments. > > Exit early when MTLRenderCommandEncoder is not created. > > Added: > * DrawBuffersTest.None > * DrawBuffersTest.NoneWithDepth > * DrawBuffersTest.NoneWithStencil > * DrawBuffersTestES3.DrawWithDisabledIncompatibleAttachment > > Fixes: > * conformance2/rendering/fs-color-type-mismatch-color-buffer-type.html > > Bug: angleproject:6430 > Change-Id: I7f650c761f757985b027388c350c01340a83fd51 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4003180 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Bug: angleproject:6430 Change-Id: I13977bd7ef32c4c85420706215b4f4d3a65629ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4030310 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 70cf2322 2022-11-16T10:25:07 Vulkan: Move async pipeline cache sync feature to backend Bug: b/246683126 Change-Id: I194e488e04580cee7055c0674091f1228984edf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031486 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Solti Ho <solti@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Stephen White 386ef2ee 2022-11-17T13:16:27 Fix EGL validation of core robustness attribute. Implement EGL validation of EGL_CONTEXT_OPENGL_ROBUST_ACCESS. Previously, only the _EXT flavour was validated. Note that EGLRobustnessTest was changed to only exercise the core version. Bug: chromium:1385480 Change-Id: I51f93d6cd344d073cd9656c9fff9636ca4eac99d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4030882 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Jason Macnak dcf3ab12 2022-11-17T09:52:36 Map AHARDWAREBUFFER_FORMAT_R8_UNORM to GL_R8 Bug: b/259551816 Test: cvd start --gpu_mode=guest_swiftshader Test: atest librenderengine_test Change-Id: I874278fe50dd1b501c11c484c55ed91e67a7013b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4034130 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 7e7a47df 2022-11-16T21:29:20 Vulkan: Adjust logicOp dynamic state workaround Bug: chromium:1379201 Change-Id: I355d0034de12e5aaf95c160efcace34ff7062337 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031149 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jie A Chen <jie.a.chen@intel.com>
angle-autoroll a6fae3fe 2022-11-17T10:01:43 Roll SwiftShader from dbdf74996a2c to dd35c62aef80 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/dbdf74996a2c..dd35c62aef80 2022-11-16 bclayton@google.com Update Marl to a47a3a5c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ie0855ec3022dcd304463a17c2d4ed05851fd56aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4033759 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 01b27a6f 2022-11-17T10:01:30 Roll vulkan-deps from c8245c996384 to f1b1fd3fc034 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c8245c996384..f1b1fd3fc034 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/2b2523fb95..88fd417b0b * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/47f2465ee3..c214f6f2d1 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b7d671c2ba..27d86008d8 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bcc473b6be..00d345294d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I0fab67017f56bbd35058c0c96e77c99fd23e801b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4032397 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c3bad4b3 2022-11-17T07:01:45 Roll Chromium from 734d0d44bb67 to 2c9d51705f3b (582 revisions) https://chromium.googlesource.com/chromium/src.git/+log/734d0d44bb67..2c9d51705f3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/91eb84e37e..a6b135f6dc * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/bbb2301eef..09154d65c3 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/81925935fd..cd0a050474 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5ea4565c81..1f8966e6e2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..79ba9244e5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/63fea808b0..fadcbfdb27 * third_party/fuchsia-sdk/sdk: version:10.20221115.1.1..version:10.20221116.3.1 * third_party/r8: -NUQfUfOV_01dV0d71XGUoe7FpVrH5M31W17eU8pLd0C..SRv8kr_t534yPmvzQnKEBqgw_lidewzTdKnAKoWYkz0C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2991b63fa2..eea11ec5d2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f8875b1859..9d3a5eb0dd * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e9f9dffdef..d900152808 Clang version changed llvmorg-16-init-10289-g094c0ecc:llvmorg-16-init-10467-g1239d37b Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/2991b63fa29aa3ba70c3917efd147d530f292f13..eea11ec5d26fafa408ba7431f22f249608e90712/scripts/update.py Bug: None Tbr: jonahr@google.com Change-Id: I7413ee2bea752c59bea518252c0abd8f36fc3405 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031153 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Eng 91ee237f 2022-11-17T03:19:34 Revert "Metal: Skip disabled draw buffers" This reverts commit 4b084310d7bbb33631d58a461eb5814c12220926. Reason for revert: Crashing in webgl2_conformance_metal_passthrough_tests https://chromium-review.googlesource.com/c/angle/angle/+/4003180/comments/6e35ee21_38288238a Original change's description: > Metal: Skip disabled draw buffers > > When creating render pass descriptors, do not > assign textures to disabled color attachments. > > When creating pipeline descriptors, reset > pixel formats of disabled color attachments. > > Exit early when MTLRenderCommandEncoder is not created. > > Added: > * DrawBuffersTest.None > * DrawBuffersTest.NoneWithDepth > * DrawBuffersTest.NoneWithStencil > * DrawBuffersTestES3.DrawWithDisabledIncompatibleAttachment > > Fixes: > * conformance2/rendering/fs-color-type-mismatch-color-buffer-type.html > > Bug: angleproject:6430 > Change-Id: I7f650c761f757985b027388c350c01340a83fd51 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4003180 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Bug: angleproject:6430 Change-Id: I485691bdcc4214ed6958f606591f23331bfbea53 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4032391 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Austin Eng <enga@google.com> Reviewed-by: Austin Eng <enga@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Xinghua Cao 03e69803 2022-11-16T15:49:44 Fix a document error This patch fixes an error of the document, which describes the translation from uniform block to StructuredBuffer. Bug: angleproject:7832 Change-Id: Ice98f41ce558a47a6c19983e24ddbd3ea435d59d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4029670 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jiajia Qin <jiajia.qin@intel.com> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi 7fb1a25d 2022-11-16T11:40:55 Make BitSetT::Mask return a bit set This allows a Mask function to be implemented for BitSetArray, which is added in this CL. When using larger bitsets on 32-bit systems, the current Mask implementation prohibits its use. This is in preparation for a follow up change that uses Mask on such a bitset. Bug: angleproject:7369 Change-Id: If995d96ec1583a546f20bff277f3223e2f2490f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031493 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov b205207a 2022-11-16T14:39:00 Lock gpu clocks using nvidia-smi to avoid overheating For now only applies to Windows Nvidia (GTX 1660) bots where I tested this. Default clocks boost to 1800+ reporting 110W+ initial power usage which can't be dissipated by the setup and and gpu quickly hits ~90C and enters aggressive throttling. Locking to 1410MHz yield a much more modest 50~60W usage with reasonable gpu temps in the 70C~80C range over long runs at 100% utilization. Also log gpu temperature before/after running tests. Bug: angleproject:7671 Change-Id: Id43bede3b1d6a445f8caee6bbbaa43f7f380199b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031495 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi 2dde7357 2022-11-16T10:39:32 Vulkan: `const` render passes Bug: angleproject:7369 Change-Id: I1ee1449bd8ea8c6a3e26e50a7f3734fad91dc911 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031488 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 5ef24b26 2022-11-16T11:17:53 Vulkan: Limit logicOp dynamic state workaround to old mesa Bug: chromium:1379201 Change-Id: I618507b118b4420793ec172f3ed1f0dddbb2ae86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031492 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop 3f9223b2 2022-11-15T20:31:55 Shader: Initialize mMaxComputeSharedMemory Uninitalized values are causing retrace failures. mMaxComputeSharedMemory is otherwise only set when the shader is compiled. Test: retrace_restricted_traces.py Bug: angleproject:7815 Change-Id: I9884ac3c8550775d435d6fa7b11d7aebc63c14d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4026669 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll b6a15123 2022-11-16T10:01:20 Roll vulkan-deps from 8384d293b2e8 to c8245c996384 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8384d293b2e8..c8245c996384 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6ea956a5e0..bcc473b6be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I54926b581eb4f160699f3899d29ff72631830ed4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4030238 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2d3ef757 2022-11-16T10:01:15 Roll SwiftShader from aac11f84562f to dbdf74996a2c (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/aac11f84562f..dbdf74996a2c 2022-11-15 swiftshader.regress@gmail.com Regres: Update test lists @ aac11f84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I24f9591f87b2677ff18a2978e71b36026234d1e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4030218 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 37ed6104 2022-11-16T07:01:14 Roll Chromium from c578240a0fa6 to 734d0d44bb67 (606 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c578240a0fa6..734d0d44bb67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5bd2e64d76..91eb84e37e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/02b18cf1ec..bbb2301eef * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/3fc0bf23fe..81925935fd * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/86213b7902..5870472fdd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9d6b67f5f6..5ea4565c81 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c8506af0cf * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8de7b2d51b..63fea808b0 * third_party/fuchsia-sdk/sdk: version:10.20221114.3.1..version:10.20221115.1.1 * third_party/r8: Sbfuk7zCRoVjO5aIbd3nmDH8TcDZPNFY2k7srra6NIcC..-NUQfUfOV_01dV0d71XGUoe7FpVrH5M31W17eU8pLd0C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/8bbd6c3129..d866d41e16 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a8c009dd04..f8875b1859 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7b50a78720..e9f9dffdef No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: Ie59e27695b68c23704d8e0952876066329ab8513 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4029900 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 4b084310 2022-11-04T00:00:00 Metal: Skip disabled draw buffers When creating render pass descriptors, do not assign textures to disabled color attachments. When creating pipeline descriptors, reset pixel formats of disabled color attachments. Exit early when MTLRenderCommandEncoder is not created. Added: * DrawBuffersTest.None * DrawBuffersTest.NoneWithDepth * DrawBuffersTest.NoneWithStencil * DrawBuffersTestES3.DrawWithDisabledIncompatibleAttachment Fixes: * conformance2/rendering/fs-color-type-mismatch-color-buffer-type.html Bug: angleproject:6430 Change-Id: I7f650c761f757985b027388c350c01340a83fd51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4003180 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Lubosz Sarnecki 2fa255da 2022-11-09T16:44:02 FrameCapture: Don't capture trailing zeros in shader strings. This prevents C build errors like the following when applications provide incorrect shader string lengths: error: null character(s) preserved in string literal Bug: angleproject:7402 Change-Id: Iac7bab58533d152c4b6ed525f0cbcbcb8a7c35ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4020417 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Gert Wollny 66fda678 2022-11-14T11:10:54 Capture/Replay: Delete buffer after test support for coherent The buffer created to test coherent and persistzent mapping is not used later, so it should be deleted. Since this buffer is created and deleted before any VAO is created, we also have to check whether a VAO exists before the buffer may be detached from it. Bug: angleproject:7814 Change-Id: I875f845e592325093dd90b48ba9cd3c7228fad47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4023047 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Charlie Lao 8028bffc 2022-11-14T16:45:07 Vulkan: Flatten GarbageAndSerial class ObjectAndSerial templated class is only used by GarbageAndSerial. The serial number here means queue serial. This CL simply flattens the template class to GarbageAndQueueSerial to clarify the serial here is the queue serial that tracks GPU completion. Bug: b/259148812 Change-Id: I81e88a03ccffcf8fb632e3ac7dce886375dc51a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4023098 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov e6491c2f 2022-11-15T19:35:47 Revert "Add temporary logging of gold_session.Initialize stdout." This reverts commit 05d86e06003bc9bcfdf62d769d6c6229e7680f5e. Reason for revert: this helped caught an issue https://anglebug.com/7550#c6, but recent outputs seem normal so no longer needed Original change's description: > Add temporary logging of gold_session.Initialize stdout. > > Normally looks like: > Loaded 1549 known hashes > ... > > Suspecting that in failure cases it's going to result in something > different. > > Bug: angleproject:7550 > Change-Id: I0190d4f679fc4161fc36a3008ba2e7d6d4764277 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3804752 > Commit-Queue: Roman Lavrov <romanl@google.com> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Bug: angleproject:7550 Change-Id: I7c6e1569299ca4c834f29fcd01c3e707e373de16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4024759 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Roman Lavrov <romanl@google.com>
Charlie Lao 9483002d 2022-11-14T16:01:15 Vulkan: Clean up submitFrame/submitCommands ContextVK has two functions, submitFrame, and submitCommands. ContextVk::SubmitFrame means to be frame boundary or FBO boundary, usually refers to submission triggered by API, for example, glFlush/glFinish or FBO switches. ContextVk::submitCommands was added later to mean any kind of submission. It could be triggered by internal logic, for example, when we think we have accumulated too much staged updates. The odd thing is that ContextVk::submitFrame calls ContextVk::submitCommands, which calls RendererVk::submitFrame. I believe this is because when we introduced ContextVk::submitCommands, we did not bother rename RendererVk's API. This CL renames RendererVk::submitFrame and CommandQueue::submitFrame and CommandProcessor::submitFrame to submitCommands to be consistent with ContextVk's function names. This CL also removes unused function ContextVk::isSerialInUse() This CL also removes unnecessary vk:: namespace in CommandProcessor Bug: b/259148812 Change-Id: If074e381168950143ad56a728f23caa298e5f355 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4027284 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao 139b9df8 2022-11-14T15:53:15 Vulkan: getCommandBufferOneOff could reuse if serials are equal When one off commands serial is equal to last completed serial, it means completed. We should reuse command buffer instead of allocate a new one. Bug: b/259148812 Change-Id: Ibc006a93e1ee775a436396a0d35cf4ab2b363940 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4023097 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Roman Lavrov d8d85253 2022-11-15T12:38:05 Add gFixtures.clear() to ReleaseFixtures Not necessary as we only call it on termination but if ReleaseFixtures is called for e.g. eviction testing, it leaves bad state behind. Bug: b/258723409 Change-Id: I345c9197742f78ec952cacecdc9ba55b518f9f53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4024757 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Cody Northrop 124ba087 2022-11-14T15:14:37 Tests: Add Minetest trace Test: angle_trace_tests --gtest_filter="*minetest*" Bug: angleproject:7831 Change-Id: If182136cd14207d7243a2fcd56737dd0ea28b2de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4022260 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Roman Lavrov f67d1224 2022-11-15T10:55:50 Delete osWindow and eglWindow in ReleaseFixtures valgrind rightfully reports these as leaks Bug: b/258723409 Change-Id: I02dbd771c6f7bd9e7df2269c77d8bd95af593044 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4025992 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 3e13ab1c 2022-11-15T10:01:13 Roll vulkan-deps from 131d736c57d4 to 8384d293b2e8 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/131d736c57d4..8384d293b2e8 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a8647f59c0..8ea3ae6be2 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c4a6240618..6ea956a5e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I041ca02fcdab99a5930fe0c949a904c51064e7d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4027133 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1d34cf62 2022-11-15T10:01:31 Roll SwiftShader from 87d41aad5e71 to aac11f84562f (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/87d41aad5e71..aac11f84562f 2022-11-14 swiftshader.regress@gmail.com Regres: Update test lists @ 87d41aad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I08e47ff3d2394c314f1c1c7ad12b516da1a3052e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4024160 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 14c69aba 2022-11-15T07:00:33 Roll Chromium from 622e44fd31d8 to c578240a0fa6 (591 revisions) https://chromium.googlesource.com/chromium/src.git/+log/622e44fd31d8..c578240a0fa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/23a5cc541c..5bd2e64d76 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0e0c2e009c..9d6b67f5f6 * third_party/android_build_tools/bundletool: nrReBqFfE2B7DUv3RveTRIE4K9O3MJft7pP-iRhoRQ4C..eYz83zbG33sGLyNdc-a64qo1K6LRcS9GwW7GmSvyWisC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..670186d696 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7aaca94286..8de7b2d51b * third_party/fuchsia-sdk/sdk: version:10.20221113.3.1..version:10.20221114.3.1 * third_party/r8: isj_SlllAO2yCbNZuv4OBa3d8hPKY5hulrBg7_xwY_MC..Sbfuk7zCRoVjO5aIbd3nmDH8TcDZPNFY2k7srra6NIcC * third_party/turbine: HqLybI_r3dCgRJywsqJ3xkp2D6vQAI4-8D7zdqNiyxcC..4Cvss-AYlYPcW_PIdcX45Ew7ZQwsaeurs7mUjS3LFyQC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/944ffba8ce..a8c009dd04 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3ab0f76217..7b50a78720 No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: Icc4a22388afe168e6ae52d78598380d465c5a37d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4027132 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 85c98a92 2022-11-11T17:01:40 Vulkan: Only allocate default attribute if needed mDirtyDefaultAttribsMask has all bits set when starts. ContextVk::handleDirtyGraphicsDefaultAttribs() is looping all dirty bits and try to allocate buffer for it, which means we are looping 16 times when app starts. This CL changes to allocate a buffer only if used by program. Bug: b/258862506 Change-Id: I2f0a75d1fe141c9ac3101088fdc4ce4f60b0c4ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4024544 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Alexey Knyazev 44d8fef8 2022-11-01T00:00:00 Add ANGLE_provoking_vertex spec Renamed provoking vertex enums to use _ANGLE suffix. The newly defined enums alias those from the desktop OpenGL extensions. Updated tests to use the new enum names. Bug: angleproject:2829 Change-Id: I72b686773536d3d54a653114cee5292007510a55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4013700 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Dan Glastonbury 40e4bc63 2022-11-09T12:40:48 Make DrawRangeElements validation consistent with DrawElements According to the WebGL specification, when an empty buffer is bound to GL_ELEMENT_ARRAY_BUFFER binding point, one of the possibilities is to return an error when trying to draw with an index count other than zero. This is the behavior of DrawElements variants but not DrawRangeElements. This change brings variants of DrawRangeElements behavior in line with that of DrawElements. Bug: angleproject:7822 Change-Id: I6844efd1038d95c652b72e52209dfdd74f006f9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4015418 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Roman Lavrov 4878b317 2022-11-14T11:41:20 Fix variable names UpdatePreCacheActiveTextures and updateExecutableActiveTexturesForShader do similar things but there seems to have been some naming confusion. Bug: b/242887117 Change-Id: Ib568f922c79b6ea36a225b4547e2abfc73b8ec08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4022143 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jonah Ryan-Davis fe3b0e38 2022-11-14T13:05:56 Skip flaky PBOExtension tests on Win until fix lands. An extra buffer is allocated by CoherentBufferTracker::canProtectDirectly that is being caught by the Capture/Replay context serializations. Bug: angleproject:7814 Change-Id: Id0b375d8fe7213fe0a34b667b721300fbc3908f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4023668 Auto-Submit: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll be5120aa 2022-11-14T10:01:45 Roll vulkan-deps from 4b08746c581a to 131d736c57d4 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4b08746c581a..131d736c57d4 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/68e8327f29..a8647f59c0 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f18d3e3c5d..b7d671c2ba * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4fa8aa7489..c4a6240618 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I1e04a6585f1a73c31eb6ac4508ea9aa85a1ebfb2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4025199 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8149baaf 2022-11-14T07:00:17 Roll Chromium from 9bed484ffc44 to 622e44fd31d8 (709 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9bed484ffc44..622e44fd31d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/088aeb2cc3..23a5cc541c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c3244c4dbc..02b18cf1ec * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/b343ccbfac..3fc0bf23fe * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ca038c44f2..0e0c2e009c * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f091e9c497..ffbead8e41 * third_party/android_sdk/public: IPzAG-uU5zVMxohpg9-7-N0tQC1TCSW1VbrBFw7Ld04C..oWlET2yQhaPKQ66tYNuSPaueU78Z9VlxpyxOoUjwRuIC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..161a56fa1d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/87f204ff53..7aaca94286 * third_party/fuchsia-sdk/sdk: version:10.20221110.0.1..version:10.20221113.3.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/ad71a3730f..0c241c298d * third_party/r8: 2rVb5rDMAwVnV9ra0CSpHAjMqBI4eDQNz_EQ9XFf_60C..isj_SlllAO2yCbNZuv4OBa3d8hPKY5hulrBg7_xwY_MC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d3df9cc536..2991b63fa2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/580ef7c9b1..944ffba8ce * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cfb50e506c..3ab0f76217 Clang version changed llvmorg-16-init-8697-g60809cd2:llvmorg-16-init-10289-g094c0ecc Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/d3df9cc5362e0af4cda798b0612dde39783b3dc0..2991b63fa29aa3ba70c3917efd147d530f292f13/scripts/update.py Bug: angleproject:7397 Tbr: ynovikov@google.com Change-Id: I810f08a45da7b5beeac8fd032203e94df4bb8cf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4024796 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 82855be3 2022-11-12T20:17:51 Roll SwiftShader from dd7bb92b9a7a to 87d41aad5e71 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/dd7bb92b9a7a..87d41aad5e71 2022-11-11 capn@google.com Remove unused viewportHeight field 2022-11-11 capn@google.com Increase subPixelPrecisionBits from 4 to 8 2022-11-11 capn@google.com Rasterize polygon edges from the real endpoint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com,nicolascapens@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com,nicolascapens@google.com Change-Id: Ie475de74dc6d0c84d2d03d687522f5f6b2ac5565 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4024717 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0ca9cc54 2022-11-11T22:47:40 Roll VK-GL-CTS from acb25bf242c3 to c4fe10a0c86d (15 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/acb25bf242c3..c4fe10a0c86d 2022-11-11 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main 2022-11-11 aitor@lunarg.com Add missing GLSL struct comparison tests 2022-11-11 gleese@broadcom.com Code simplification in image load/store tests 2022-11-11 ziga@lunarg.com Add missing switch case in wsi util isDIsplaySurface 2022-11-11 mateusz.bahyrycz@mobica.com Test bufferImageHeight with 1D/2D/array images 2022-11-11 gleese@broadcom.com Add image load/store tests for 10X6 formats 2022-11-11 rgarcia@igalia.com Fix mandatory features test for mesh shaders 2022-11-11 ewerness@nvidia.com VK_EXT_opacity_micromap 2022-11-11 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main 2022-11-11 quic_mnetsch@quicinc.com Notice of withdrawal of Vulkan CTS 1.2.8.x and 1.3.0.x 2022-11-11 zzoon@igalia.com Add tests with garbage color attachments. 2022-11-11 zzoon@igalia.com Add tests with multiple color attachments without export 2022-11-11 rgarcia@igalia.com Test custom border colors with the stencil aspect 2022-11-11 rgarcia@igalia.com Chain VkShaderModuleCreateInfo when creating non-graphics pipelines 2022-11-03 rgarcia@igalia.com Merge VK_EXT_mesh_shader branch to main (2) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Id8a1e9b2bce7793d28f647a1fc21833075e2002f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4023700 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi f62405c5 2022-10-31T18:47:52 Add utilities to get the Android backtrace * Added getBacktraceInfo(), which returns the backtrace information from the ANGLE code, including the addresses and the symbols if possible * Returns the data in an instance of the new class BacktraceInfo. * In order to access this function, backtrace_utils.h has been included in vk_utils.h * New GN flag to make use of this feature: * angle_enable_unwind_backtrace_support * Current only available on Android (debug mode) * If the flag is disabled, getBacktraceInfo() returns an empty object. * Added functions in util/ (per platform) to print the BacktraceInfo data. * Example of usage: angle::printBacktraceInfo(angle::getBacktraceInfo()); * Minor edit: Moved cstdint from android_util.cpp to its header. Bug: b/258475923 Change-Id: I6115462a1a2845d40c7cafc14ce52df09ecdcf34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3995843 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov d13c14d0 2022-11-11T10:32:13 Crash with a mesage when OSWindow::New returns nullptr Happens when !IsX11WindowAvailable() Bug: b/258723409 Change-Id: Ib16f7ffa9c9cd7ca75cb5659ae393b87d1e96326 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4023025 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 7013bc86 2022-11-09T21:57:51 Use Python3 for infra/config/PRESUMBIT.py Bug: chromium:1313804 Change-Id: Ie327b1bc5babd0198f06398e1390843c7e3159c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4018964 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 5544b03c 2022-11-11T10:01:31 Roll vulkan-deps from c29c532c92db to 4b08746c581a (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c29c532c92db..4b08746c581a Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0df63661a5..f18d3e3c5d * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/3a729c0a9d..c4839afe75 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f276f028ee..4fa8aa7489 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ie3c0f6461e7235c2e169681747cc5ce50dd4b808 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4021140 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fcebccd8 2022-11-11T07:01:14 Roll Chromium from 39ad79434d5e to 9bed484ffc44 (380 revisions) https://chromium.googlesource.com/chromium/src.git/+log/39ad79434d5e..9bed484ffc44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/646db6f22e..088aeb2cc3 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/49ac7cf34a..c3244c4dbc * buildtools/linux64: git_revision:a4d67be044b42963de801001e7146f9657c7fad4..git_revision:1c4151ff5c1d6fbf7fa800b8d4bb34d3abc03a41 * buildtools/mac: git_revision:a4d67be044b42963de801001e7146f9657c7fad4..git_revision:1c4151ff5c1d6fbf7fa800b8d4bb34d3abc03a41 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4218f3525a..b343ccbfac * buildtools/win: git_revision:a4d67be044b42963de801001e7146f9657c7fad4..git_revision:1c4151ff5c1d6fbf7fa800b8d4bb34d3abc03a41 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/23d79d96ee..ca038c44f2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..037b0ac25d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ae1a708917..87f204ff53 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/85ce7208ae..580ef7c9b1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3e5483c53d..cfb50e506c No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I24c58f59f2dc49e9106e6efb7fe0eb9bae0629cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4021136 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 92a0efdf 2022-11-10T19:54:16 Roll vulkan-deps from 41d238c218e5 to c29c532c92db (19 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/41d238c218e5..c29c532c92db Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/525bc38062..68e8327f29 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/6898219141..29c0457cc1 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/5b054b4333..0df63661a5 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/6e5bd86b76..3a729c0a9d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8a253a6c5b..f276f028ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Id5545e98d6c7afbfe9e456a3cd85a7a1d4512b59 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4021125 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 3bbc5335 2022-11-03T00:00:00 Adjust copied dylibs in update_chrome_angle.py Bug: angleproject:1944 Change-Id: Idaf4d559262cc87eab2bb251e6ef41fabffcc466 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4013701 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 7f42f858 2022-11-10T16:30:11 Roll Chromium from 37ccb4df2296 to 39ad79434d5e (789 revisions) https://chromium.googlesource.com/chromium/src.git/+log/37ccb4df2296..39ad79434d5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/57e795cf32..646db6f22e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/85968248e1..49ac7cf34a * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6e93fd3d6e..4218f3525a * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/d08f7f8a9a..86213b7902 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/07fb4cc957..23d79d96ee * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8fb5a04597..f091e9c497 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..f0b11967c9 * third_party/fuchsia-sdk/sdk: version:10.20221108.1.1..version:10.20221110.0.1 * third_party/r8: 4u_h3wavvDpQ89UVxr4y-TqKXpJQyYX8ih-DH5Dutm4C..2rVb5rDMAwVnV9ra0CSpHAjMqBI4eDQNz_EQ9XFf_60C * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1e3d07407d..85ce7208ae * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/06d80e1d51..4a3820026f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2487dcf252..3e5483c53d No update to Clang. Bug: angleproject:6430,angleproject:7824 Tbr: ynovikov@google.com Change-Id: Ibbbe26901dca64ebe8487d51948836de72ee4bdd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4021124 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 518209e8 2022-11-10T16:37:20 Fix Mac build sprintf was deprecated Bug: angleproject:7824 Change-Id: If261426f1bf4e8d7997f051b87ea4817d1e3a264 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4020418 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll a74159cd 2022-11-10T10:01:51 Roll SwiftShader from a113fba5d946 to dd7bb92b9a7a (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/a113fba5d946..dd7bb92b9a7a 2022-11-09 sugoi@google.com glslang update If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I7e032f3af11660c6853e24572ab64a97524e20ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4019325 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bb95fce0 2022-11-09T12:18:57 Roll vulkan-deps from 2758721a15a3 to 41d238c218e5 (27 revisions) Ignore spirv/unified1/spirv.hpp11 in export_targets.py https://chromium.googlesource.com/vulkan-deps.git/+log/2758721a15a3..41d238c218e5 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/5e08deae05..2b2523fb95 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/abc31207bf..edd66a2fc9 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c8e1588cfa..525bc38062 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/52b7c620a5..6898219141 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/256a5e3b6d..5b054b4333 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/226b595aee..8a253a6c5b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I7bb358f8457189656d41a309d30cfbefcd65521a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4015371 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll e50e4535 2022-11-09T07:01:10 Roll Chromium from dbedf281d165 to 37ccb4df2296 (492 revisions) https://chromium.googlesource.com/chromium/src.git/+log/dbedf281d165..37ccb4df2296 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dff033c8c1..57e795cf32 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/737c5727e5..85968248e1 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/023270786d..6e93fd3d6e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/53253f33bd..07fb4cc957 * third_party/android_build_tools/lint: QchUp_CPEekuo_inqr_aTnbotGejxQt4FGgFbQT0qBMC..PwX3e0EPv-j0ip-tcNNfhy3YcFHle4vxKVo-IbTCtZYC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..36d603a00b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e6f3d66bae..ae1a708917 * third_party/fuchsia-sdk/sdk: version:10.20221107.3.1..version:10.20221108.1.1 * third_party/r8: szXK3tCGU7smsNs4r2mGqxme7d9KWLaOk0_ghbCJxUQC..4u_h3wavvDpQ89UVxr4y-TqKXpJQyYX8ih-DH5Dutm4C * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1aa169abda..1e3d07407d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/822843c07b..2487dcf252 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ib004f8d6f5d009137f44f8f1def76955deada27e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4015368 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop fbf2d2f3 2022-11-05T23:00:51 Tests: Add Hungry Shark Evolution trace Test: angle_trace_tests --gtest_filter=TraceTest.hungry_shark_evolution Bug: angleproject:7820 Change-Id: I6e83efbb566d512c8e60bd27f00144c8c28593e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4007226 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 9c019cb3 2022-11-08T13:29:08 Vulkan: Features for graphics pipeline library Bug: angleproject:7369 Change-Id: I561cc095dcf2d4c71d24de8a6ca08d45567ad937 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4014519 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop 5459baf9 2022-11-05T21:47:12 Tests: Add 1945 Air Force trace Test: angle_trace_tests --gtest_filter=TraceTest.1945_air_force Bug: angleproject:7819 Change-Id: I90ed9e74e206bd6e2d2b1ca0071d8526f582b353 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4007225 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Lubosz Sarnecki e99e40c9 2022-10-11T12:27:18 FrameCapture: Implement shadow memory for coherent buffers. On certain devices like the Pixel 6 it is not possible to mprotect Vulkan allocated memory required for coherent buffer tracking. To overcome this limitation implement a shadow memory for coherent buffers when running FrameCapture that is exposed to the app and syncronized with the Vulkan memory and can be mprotected for coherent buffer tracking. Add a test to determine whether memory protection can be used directly or will require shadow memory. Run this test only on build configurations with assertions enabled. Determine the requirement of shadow memory through a deny list of device manufacturers and models, which is checked against ANGLE's SystemInfo. Add ANGLE_CAPTURE_FORCE_SHADOW environment setting and Android equivalent to force enable shadow memory. Test: angle_end2end_tests --gtest_filter="BufferStorageTestES3.*/ES3_Vulkan" Bug: angleproject:7402 Change-Id: I74b7930259d3bc1846ef96fffa782f8bc553b043 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3945018 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 5a89387b 2022-11-01T10:50:26 Vulkan: Remove the best-practices layer It doesn't produce anything actionable in ANGLE (any more), but is regularly a source of false positives. Bug: angleproject:5336 Bug: angleproject:7470 Bug: angleproject:7795 Bug: b/166641492 Bug: b/166793850 Change-Id: I7fb322386e779c8c1f9a7805eb522926d8780446 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3996803 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6402fe70 2022-11-08T14:49:57 Roll vulkan-deps from a7a3fb39310c to 2758721a15a3 (25 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a7a3fb39310c..2758721a15a3 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/1a8869e4d1..5e08deae05 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/744279ec78..abc31207bf * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/85a1ed200d..47f2465ee3 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a52de681dd..c8e1588cfa * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/e12a8f8cde..52b7c620a5 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3f29209dd6..256a5e3b6d * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/292e6ed021..6e5bd86b76 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/18a0e59294..226b595aee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com,syoussefi@google.com Change-Id: Ibc3c263d09ff2d602ed55cb9b61c501d15696774 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4011232 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 7fefd230 2022-10-20T00:00:00 GL: Adjust APPLE_clip_distance exposure Partial revert of I458cad29c10b9d9193c5233e24bac53361ba104e APPLE_clip_distance cannot be implemented on top of EXT_clip_cull_distance because the former is defined both for ES 2.0 and ES 3.0 while the latter is defined only for ES 3.0. Although some ES 3.0+ drivers allow gl_ClipDistance built-in in ESSL 1.00 shaders, this behavior is not specified so ANGLE should not allow it. Added independent ESSL 3.00 gl_ClipDistance and gl_MaxClipDistances definitions. Adjusted translator unit tests. Bug: angleproject:4452 Change-Id: Ib582ce0ac7ccb65f0200ef1d17eaab0c83b228cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963745 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 78e28cb8 2022-11-03T11:05:48 Vulkan: Remove glslang fallback ANGLE's SPIR-V generator is battle tested by now. Bug: angleproject:6210 Change-Id: I2ed88642e3ede435e3f906fbd701133be6873fb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4002868 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll f06382aa 2022-11-08T07:02:06 Roll Chromium from 2d52bc63cf90 to dbedf281d165 (524 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2d52bc63cf90..dbedf281d165 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/07e7b8e672..dff033c8c1 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a89eb5a1d4..1a32724f72 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/aabcd87536..d08f7f8a9a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1667ace0e2..53253f33bd * third_party/android_build_tools/manifest_merger: 10z1KegIoj_7T--lXulnk4MUKHMHEo_onhwh_4FvyMQC..1_tPfyswsXgfbNegip6nTy55E2ASlhsRqA2sKhUo01YC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..f139a527bc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/03b187d9c8..e6f3d66bae * third_party/fuchsia-sdk/sdk: version:10.20221106.3.1..version:10.20221107.3.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b65f30f26c..d3df9cc536 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/cb4b18121b..1aa169abda * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/8581381d92..06d80e1d51 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I904a298aeb121de50ddbbaef13112e56b42e41f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4012344 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0