|
71bffb8a
|
2021-11-09T11:16:07
|
|
Capture/Replay: Handle newly generated FBOs in tracker
Bug: angleproject:6425
Change-Id: I39d22a6770290a0c407ac358b1c059c6a2ddeefa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3269886
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
9a36c3b6
|
2021-11-15T13:46:06
|
|
infra: Update NVIDIA to 1660 testing.
Bug: angleproject:6694
Change-Id: I2580b53e45e633af98be757d9bb081461c06de95
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3283163
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
83fa1890
|
2021-11-17T12:17:31
|
|
Disable variable shadow warnings on more ES1 conformance tests
The list of gles1 sources is used in several targets without a
common config.
Bug: angleproject:6703
Change-Id: Ib78719c9dc322075dfba05380e99ec1ada8a3265
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289616
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
e9f9fa17
|
2021-11-09T18:13:15
|
|
Add cpu time measurement to perf tests
Bug: angleproject:6667
Change-Id: I16570a7b51d363dd1c0f35789b985520cb76d488
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270601
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
30c03b56
|
2021-10-28T12:54:39
|
|
Capture/Replay: Capture GetTexLevelParameter return param
Bug: angleproject:6180
Change-Id: Ia063d297bab85d6cb559642b9be213cc6f10a9bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3250884
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
613f0361
|
2021-11-13T14:19:16
|
|
Fix typo in SystemInfo_libpci.cpp
Bug: angleproject:6691
Change-Id: I26d4cdc3839b71002c40ff114e5cb43d60ef2e81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3279232
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
82cccf04
|
2021-10-28T12:49:55
|
|
Capture/Replay: Additional tests that now compile
Bug: angleproject:6108
Change-Id: I010ae0cd276fcd5093860400c2f7436c9b0bfedf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3250883
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
89e3de97
|
2021-11-11T10:18:36
|
|
GN: Add symbolizer data for sanitizer builds.
This is necessary to produce correct stack traces.
Bug: angleproject:5795
Bug: chromium:1268935
Change-Id: I011d0948779718ed38305624c87a193a6ad0f8bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276512
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
3979383c
|
2021-11-17T12:53:56
|
|
Roll vulkan-deps from 459e5e53952a to 50e341fc93fd (12 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/459e5e53952a..50e341fc93fd
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/8a7860e4cb..d51d01ccfb
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ccdf836207..4b092d2ab8
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/8c1c27d5a9..83e1a9ed8c
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/4f78f14c05..447f2289f0
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/8d361dd235..bfdd0c8753
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/81dfeef144..21286f81b8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: geofflang@google.com
Change-Id: I15362a111afb709dedd04f8061015e9fc9d1e476
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289228
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
fc5fe46d
|
2021-10-28T12:47:15
|
|
Capture/Replay: Capture GetProgramResourceLocation name param
Bug: angleproject:6180
Change-Id: I5f27c695c31a32989c579b54e31cccc5b337bd58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3250882
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
95e1d244
|
2021-10-28T12:24:59
|
|
Capture/Replay: Capture GetProgramResource params correctly
If a non-nullpointer is passed for length then the the number
of param entries that is written is returned in *length.
Otherwise, just capture the full buffer size as specified by
bufSize.
Bug: angleproject:6180
Change-Id: If7c3084e56c990477ddb6e93b8682e27004ba1e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3250881
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
3ce1abd8
|
2021-11-16T14:38:15
|
|
Test Runner: Print output snippet in test timeout.
This will be helpful in diagnosing test failures.
Bug: angleproject:6694
Change-Id: I0ea491fe8ab48dfd017ce40150f606c571f3fa6c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285805
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
c664c9fc
|
2021-11-16T12:22:47
|
|
Vulkan: Generalize barrier VVL suppression.
Seems to pop up in other tests as well. Seems to only affect
SwiftShader configs.
Run capture_replay_tests.py with the below test.
Test: BuiltinVariableVertexIdTest.LineLoop/ES3_Vulkan_SwiftShader
Bug: angleproject:6701
Change-Id: I857d4785d6e04edf96fb137a492548ed4d9fbcc4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285445
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
de5a290d
|
2021-11-16T15:29:31
|
|
infra: Increase sharding on SwANGLE trace tests.
These tests were timing out in test infra.
Bug: angleproject:6496
Change-Id: Idd9b36051e1d0327602fa148d7a8c7b44d918b30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285807
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
b9c0194c
|
2021-11-16T11:36:52
|
|
Add EVENT0 markers for why we call vkAcquireNextImage
This will help when looking at AGI system traces.
Bug: angleproject:6696
Change-Id: Ic4b06f1a1ec155076cfcb47299afe451cd325327
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3283428
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
27bc56c6
|
2021-11-15T18:18:53
|
|
Vulkan: MAP_UNSYNCHRONIZED_BIT: Skip ghosting/idling
Respect the following spec language:
No GL error is generated if pending operations which source or modify
the buffer overlap the mapped region, but the result of such previous
and any subsequent operations is undefined
Test: cpu time improves in unsync case in perf-tests/MapBufferRange.cpp
Bug: angleproject:6680
Change-Id: I6133952546735aced6e6ee8468ef2ac695316fb6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3272018
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
647a703e
|
2021-11-12T13:48:06
|
|
Vulkan: Reorder logic in BufferVk::mapRange
This CL flattens the logic, ordering read case first, then write, and
simpler cases before more complex ones.
This is to prepare for an optimization where we ignore certain paths if
MAP_UNSYNCHRONIZED_BIT is set. No change in functionality or performance
is expected.
Bug: angleproject:6680
Change-Id: I0a2e9ee969216c90353eac7af6dabf648dea2173
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3279615
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
b9a8f092
|
2021-11-16T10:44:26
|
|
Disable variable shadow warnings on ES1 conformance tests
Bug: angleproject:6703
Change-Id: Ie66b5afc12c4f29f69b8d7e205de02cadd5268a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285383
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
353b62c9
|
2021-11-16T09:04:52
|
|
Use Python 3 in trigger.py.
Bug: angleproject:5707
Change-Id: I7b1281711133ef3a60257c602f1af1db7f3af85f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3284395
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
316dcb56
|
2021-10-06T09:31:49
|
|
Add SwANGLE Skia Gold testing.
Required updating our system info helper to be able to retrieve
SwiftShader device information.
Bug: angleproject:6496
Change-Id: Ib38ea4da65d199433e17b87df2630c3fd77cb619
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3208646
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
f525d155
|
2021-11-16T08:31:04
|
|
Update DEPS roller script to use 'main'.
It was still using the 'master' branch.
Bug: angleproject:6700
Change-Id: I6b0d94f049b46741853ef07ba4f8f8ff7d156622
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3282687
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
9e4ade68
|
2021-11-16T10:01:29
|
|
Roll SwiftShader from 6885768e737f to f0e8ec2da282 (10 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/6885768e737f..f0e8ec2da282
2021-11-15 capn@google.com Implement shaderStorageImageWriteWithoutFormat support
2021-11-15 capn@google.com Perform image write from a static function
2021-11-15 capn@google.com Support writing to storage images with packed formats
2021-11-15 capn@google.com Provide StorageImageDescriptor with an image view identifier
2021-11-15 capn@google.com Make GetTexelAddress() independent from SPIR-V parsing
2021-11-15 srisser@google.com Detemplatize hasExtendedFeatures
2021-11-15 msisov@igalia.com Rename use_x11 to ozone_platform_x11
2021-11-15 capn@google.com Allow dereferencing of constant Reactor pointers
2021-11-15 capn@google.com Parse the OpTypeImage information into ImageInstructionSignature
2021-11-15 capn@google.com Parse OpImageTexelPointer into an ImageInstruction
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: geofflang@google.com
Change-Id: I5dbd59f245011d407f512754625532e4c1ae9ffe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3284636
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
376d8136
|
2021-11-16T10:01:28
|
|
Roll vulkan-deps from 712bb5b10bcf to 459e5e53952a (6 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/712bb5b10bcf..459e5e53952a
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/f669f13998..8a7860e4cb
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/7c3cb0b12c..37dfb3f45f
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/6912527562..8d361dd235
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a9101d35aa..81dfeef144
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: geofflang@google.com
Change-Id: Id788e890e8ebf5865b487c75727e9407bfc9d616
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3284591
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
5c6998e4
|
2021-03-30T09:33:55
|
|
Mark objects as initialized when robust init is disabled.
If a context with robust resource init disabled allocates a texture,
make sure it's marked as initialized or else the texture may be
reinitialized later by a context with robust resource init enabled.
Bug: chromium:1192632
Change-Id: I643f616c89420312f341b53cedbd1a4e4dc58675
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2794621
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
|
|
|
d27552f2
|
2021-11-11T11:43:30
|
|
Re-land: "Vulkan: Allow SystemInfo to pick ICD."
Re-land fixes build on iOS and Android with ANGLE/Vulkan.
This will be used in conjunction with SwiftShader.
Bug: angleproject:6496
Change-Id: Id38403da1e377bba293dc8368d1c1aac29bf56a9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3282426
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
7d33e71a
|
2021-11-15T11:20:25
|
|
Vulkan: SPIR-V Gen: Don't generate names for constants
Multiple constant variables can have the same value, and they are
coalesced to the same SPIR-V id. It's not useful to attempt to generate
multiple constants with different names, especially as those names don't
make it into the SPIR-V-Cross-generated GLSL. Additionally, most
constants in the translator don't retain their name, only the ones that
are not folded do (and which are folded is a rather arbitrary decision).
By generating names for these constants, the SPIR-V gen code was
introducing a bug where multiple OpNames could be generated for the
same OpConstant* id. This change removes OpNames generated for
constants in the first place.
Bug: angleproject:6644
Change-Id: Ife2f4bee8e2eb095dc0b22994420ee1dfc6023c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3282425
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
96bce6bd
|
2021-11-15T14:12:32
|
|
infra: Fix UBSAN build.
The compilation of the trace tests would fail in UBSAN with
optimization disabled. Fix this by allowing optimization of the
large traces when running under UBSAN.
Bug: angleproject:5795
Change-Id: Ib11514a00495ed1af4faeecca81283f4c98da135
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3283164
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
bc2ca15c
|
2021-11-11T16:29:59
|
|
Declare "role/configs.validator" binding.
It defines who is allowed to call LUCI Config validation API to
validate this LUCI project's configs. This is usually done by
presubmit jobs, and thus configs.validator role is assigned to
try job task accounts.
Previously this ACL was defined in the global "config-validation"
group. It is deprecated and being replaced with per-project ACLs
defined in per-project configs (like in this CL).
There's still a global ACL to allow any googler to call
the validation API in any LUCI project they are allowed to see.
Thus the per-project binding applies only to service accounts
(they are not googlers).
Note that this CL was generated semi-automatically and reviewers are
picked automatically based on OWNERS file.
Bug: chromium:1068817
Change-Id: Iadd19a74e3b0bce330ee0d6fd29046ab03d5c2cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276460
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
58f84494
|
2021-11-15T17:30:53
|
|
Roll Chromium from 06cb60827cd5 to 426f5c560740 (142 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/06cb60827cd5..426f5c560740
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/d134d68f00..cfe2150f91
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/076f0a1173..65e053eeaf
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..45cccc688e
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7ca4f55087..7b33514431
* third_party/r8: nqWomZTwNDoogX26WeCSoFGg6aQN1FrwzoU4hCS0duEC..CgqKHWrPllIffdVKV209JAStQqR93hUpTzSwKQ5Mth8C
* third_party/turbine: KbLQUR_KFiUEzVt1lMTORY96bz_PbMwC3GwIb1oGJmAC..mlH0GH_teB71nsyjwL_if7NtARJdHnf6-4VXRFyGujgC
* tools/luci-go: git_revision:4cf9fa8105d30e3a6855bbfca50c5d6f88efb6b2..git_revision:0e76392e6557cc3ff8d95c3bc012540e0dbc128a
* tools/luci-go: git_revision:4cf9fa8105d30e3a6855bbfca50c5d6f88efb6b2..git_revision:0e76392e6557cc3ff8d95c3bc012540e0dbc128a
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ebec44a7a2..e1dd5dfb7b
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f701cecc7c..ffa11379f7
No update to Clang.
Bug: None
Tbr: geofflang@google.com
Change-Id: I995b833756f9b195ad840b9e2391b0886e336c92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3282950
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
bb6732a3
|
2021-11-02T10:10:52
|
|
infra: Add Linux UBSAN/TSAN configs.
These are compile-only with this CL, and will start running tests
in later CLs.
Bug: angleproject:5795
Change-Id: I37b04df2bb4a97aa46545f50bf978dfde65983c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258002
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
f7552844
|
2021-11-02T10:05:46
|
|
infra: Add ASAN tests to CQ.
Bug: angleproject:5795
Change-Id: I316122990739053b28e205282b307a071d5997c5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258001
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
a05e6a7c
|
2021-11-15T10:01:28
|
|
Roll SwiftShader from 82d932bdfc41 to 6885768e737f (14 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/82d932bdfc41..6885768e737f
2021-11-13 liyl@google.com cmake: Add VK_USE_PLATFORM_METAL_EXT for macOS builds
2021-11-13 sugoi@google.com Structure conversion cleanup
2021-11-12 sugoi@google.com Fix Xcb depth
2021-11-12 capn@google.com Produce a Visual Studio error for unreferenced local variables
2021-11-12 capn@google.com Rename ImageInstructionState to ImageInstructionSignature
2021-11-12 capn@google.com Separate the SPIR-V image and sampler as part of ImageInstruction
2021-11-12 capn@google.com Determine SPIR-V zero constants from SPIR-V binary only
2021-11-12 capn@google.com Parse OpImageRead and OpImageWrite into an ImageInstruction
2021-11-12 swiftshader.regress@gmail.com Regres: Update test lists @ 678d3931
2021-11-12 capn@google.com Make sw::Constants a member of vk::Device
2021-11-12 capn@google.com Pass the vk::Device to every routine as an extra parameter
2021-11-12 capn@google.com Split image sampling into routine lookup and function call
2021-11-11 sugoi@google.com VK_KHR_copy_commands2 support
2021-11-10 sugoi@google.com Tightly pack PlaneEquations array
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jmadill@google.com
Change-Id: Id4ef5769a7993c2557a42a33118c0059ce1ab0aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3281882
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
053b1120
|
2021-11-15T10:01:28
|
|
Roll vulkan-deps from 22e40c170f29 to 712bb5b10bcf (52 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/22e40c170f29..712bb5b10bcf
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/eb92526d5e..f669f13998
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/04293e03fd..7c3cb0b12c
* spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/29817199b7..814e728b30
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6b073f8992..ccdf836207
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/51a326d756..8c1c27d5a9
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/d5bb7a9216..4f78f14c05
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/aa16057108..6912527562
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/208c06c883..a9101d35aa
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jmadill@google.com
Change-Id: I4ca3f6c65a293fcc221df08129b236fabb85e811
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3281762
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
5debe615
|
2021-11-15T07:00:30
|
|
Roll Chromium from 6d25c1889eb7 to 06cb60827cd5 (1371 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/6d25c1889eb7..06cb60827cd5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/3a26983ac0..d134d68f00
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ee43952a47..707d75f53e
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f6490e8f59..076f0a1173
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a1290bc895..312bb312c9
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/ca1e82f3c5..b4277291f8
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a7ad5b5c96
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ea9285c47f..7ca4f55087
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/6da1d53b97..f8964a5ccf
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/92efe5e964..32d7c383a4
* tools/luci-go: git_revision:d17c642c8c3c6d9e37bd9c25535c4c5b66b99781..git_revision:4cf9fa8105d30e3a6855bbfca50c5d6f88efb6b2
* tools/luci-go: git_revision:d17c642c8c3c6d9e37bd9c25535c4c5b66b99781..git_revision:4cf9fa8105d30e3a6855bbfca50c5d6f88efb6b2
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b553e6d46a..ebec44a7a2
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d88a90b430..f701cecc7c
No update to Clang.
Bug: angleproject:6430
Tbr: jmadill@google.com
Change-Id: Ia487590f617caeb47bd37efc955d78ba1b0416e2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3281760
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
ae3f67ab
|
2021-11-11T20:32:32
|
|
Implement GL_EXT_multi_draw_indirect
* Auto-generated the code to lay the foundation for
the following functions:
* multiDrawArraysIndirect()
* multiDrawElementsIndirect()
Bug: angleproject:6439
Change-Id: I7ab5111692376229515e0d6d9e6148909ce9a8a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276042
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
fdad9531
|
2021-11-10T22:09:00
|
|
Forward extra --deqp-* flags to deqp
This allows angle_deqp_* executables to be passed extra --deqp-* flags
that are unknown to ANGLE.
Bug: angleproject:6682
Change-Id: I9930cb8dd76b1c7bc7da9b731659277392fcd3ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3274175
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
3a84ef5e
|
2021-11-12T17:40:40
|
|
Add EGL_VULKAN_GET_INSTANCE_PROC_ADDR
Add EGL_VULKAN_GET_INSTANCE_PROC_ADDR for query Vulkan
vkGetInstanceProcAddr function pointer associate with the
Vulkan EGLDevice.
Bug: chromium:1264439
Change-Id: I4ff14e2aef7b8ca651e13b4d2867a540aed1b321
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3279100
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
|
3128c055
|
2021-11-12T14:59:46
|
|
Vulkan: Add wait semaphores to queueSubmitOneOff
For use in follow up change.
Bug: angleproject:3966
Change-Id: I5bfac51ef9d47a6df5d52268d3ce4863b848b1d1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3279226
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Lingfeng Yang <lfy@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b45719ac
|
2021-11-11T16:50:18
|
|
Roll third_party/vulkan_memory_allocator/ e0216a548..5e49f57a6 (87 commits)
https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/+log/e0216a5484c8..5e49f57a6
$ git log e0216a548..5e49f57a6 --date=short --no-merges --format='%ad %ae %s'
2021-11-12 jmadill Fix compiliation error on Mac/Android.
2021-11-03 jmadill Suppress semicolon warning in GN.
2021-08-30 geofflang Supress a build warning.
2021-06-10 pkasting Update Chromium-side files for upstream roll
2021-04-06 cwallez BUILD.gn: Make the vulkan-headers directory overridable.
2021-02-12 shawn.p.huang change the default gn target to include vma.cpp
2021-02-03 ehmaldonado Move metadata in OWNERS files to DIR_METADATA files
2021-01-27 shawn.p.huang Add vma.cpp contains vma's implementation.
2021-01-27 shawn.p.huang Add a new target with the VmaUsage.cpp and VmaUsage.h
2020-08-26 jmadill Suppress two override suggestion warnings.
2020-06-25 thakis mac: Only call system aligned_alloc() with the 11.0+ SDK.
2020-06-25 thakis Only use system aligned_alloc on mac/ios if the SDK has them.
2020-06-25 thakis Make vulkan_memory_allocator build with the MacOSX11.0 SDK.
2020-05-05 jmadill Restore BUILD.gn.
2020-05-04 jmadill Suppress a couple more VMA warnings and update README.
2020-05-01 jmadill Update integration for use with Chromium.
2020-04-17 jonahr Modify to not depend directly on volk.
2020-04-07 jmadill Update location modifications.
2020-04-03 jmadill Fix Clang implicit fallthrough warning.
2020-04-03 jmadill Add local modifications for Vulkan Memory Allocator.
2021-11-05 adam.sawicki Documented some members of VmaVulkanFunctions to clarify which functions to fetch
2021-11-03 adam.sawicki Fixing TravisCI (Linux) CI #2
2021-11-03 adam.sawicki Fixing TravisCI (Linux) CI
2021-11-03 git Correct Haskell bindings author name
2021-11-03 git Add typedefs for virtual allocation structs in ordinary identifier namespace
2021-10-30 adam.sawicki Fixed icon of Travis CI Linux build in README
2021-10-30 adam.sawicki Fix for compilation on Linux
2021-10-30 adam.sawicki Added mention of virtual allocator to README
2021-10-30 adam.sawicki Made virtual allocations not applying VMA_DEBUG_MARGIN
2021-10-30 adam.sawicki Fixes to various bugs found during extensive testing
2021-10-30 adam.sawicki Optimized VmaBlockMetadata_Buddy - using VmaPoolAllocator to allocate nodes
2021-10-30 adam.sawicki Refactoring: Added function VmaAddStatInfoAllocation, VmaAddStatInfoUnusedRange
2021-10-30 adam.sawicki Improved VmaBlockMetadata_Buddy when used as a virtual allocator, to support allocation sizes down to 1
2021-10-30 adam.sawicki Removed VMA_MIN_FREE_SUBALLOCATION_SIZE_TO_REGISTER to simplify the code
2021-10-30 adam.sawicki Added support for VMA_VIRTUAL_BLOCK_CREATE_BUDDY_ALGORITHM_BIT
2021-10-30 adam.sawicki Changed behavior of buddy allocator to align allocation sizes to power of 2 instead of accounting the remaining space (internal fragmentation) as free
2021-10-30 adam.sawicki Added support for VMA_VIRTUAL_BLOCK_CREATE_LINEAR_ALGORITHM_BIT
2021-10-29 adam.sawicki Implemented VmaBlockMetadata_Linear::Clear
2021-10-28 adam.sawicki Preparations for adding support for alternative algorithms in virtual blocks and tests for them
2021-10-28 adam.sawicki Added documentation chapter "Virtual allocator"
2021-10-28 adam.sawicki Written documentation for API of the virtual allocator
2021-10-28 adam.sawicki Implemented vmaBuildVirtualBlockStatsString, vmaFreeVirtualBlockStatsString
2021-10-28 adam.sawicki Improvement in vmaCreateAllocator in case creation fails
2021-10-28 adam.sawicki Implemented vmaClearVirtualBlock
2021-10-28 adam.sawicki Implemented vmaCalculateVirtualBlockStats
2021-10-28 adam.sawicki Enabled more tests
2021-10-28 adam.sawicki More coding and more tests. Basic functionality is working now.
2021-10-28 adam.sawicki Essential refactoring that made the test not crashing.
2021-10-28 adam.sawicki More implementation and first tests.
2021-10-28 adam.sawicki Defined interface for virtual allocator:
2021-10-27 adam.sawicki Fixed TestInvalidAllocations
2021-10-27 adam.sawicki Necessary refactoring to prepare for virtual allocator
2021-10-21 adam.sawicki Fixing logic of VmaDefragmentationAlgorithm_Fast::PostprocessMetadata broken by #201
2021-10-18 GermanAizek Code refactor (lower scope, local var, default constructor and destructor)
2021-10-18 adam.sawicki Fixes in comments
2021-10-06 lukasz.izdebski doxygen directory fix
2021-10-06 lukasz.izdebski doxygen generation fix
2021-10-06 lukasz.izdebski Doxygen added to CMake, shader project dependency added to Sample Project
2021-09-30 danielkrupinski Replace tabs with spaces
2021-09-30 adam.sawicki Standardized line endings to LF
2021-09-29 danielkrupinski Use forwarding references with std::forward()
2021-09-22 rverschelde Remove trailing whitespace
2021-09-20 danielkrupinski Adjust VMA_MIN() and VMA_MAX() macros to work despite NOMINMAX being defined or not.
2021-09-20 adam.sawicki Little improvement in README
2021-09-20 sk Fixed issue #192 with hardcoded VK_USE_PLATFORM_WIN32_KHR
2021-08-09 adam.sawicki Change all usage of VK_ERROR_VALIDATION_FAILED_EXT to VK_ERROR_UNKNOWN or VK_ERROR_INITIALIZATION_FAILED
2021-07-29 adam.sawicki Fixes and improvements in documentation
2021-07-28 adam.sawicki Include block IDs in debug log messages
2021-07-28 adam.sawicki Minor fixes in the docs - language
2021-07-28 adam.sawicki Added documentation chapter about OpenGL interop
2021-07-28 adam.sawicki Moved main documentation text from the beginning to the end of file
2021-07-28 adam.sawicki Removed unused variable
2021-07-25 phil-el Do not fail travis build if the build directory already exists.
2021-07-23 Hindrik1997 Add include_directories to CMake to include the header files.
2021-07-21 Hindrik1997 Disable broken aligned_alloc on new versions of macOS and revert to old behaviour.
2021-07-07 adam.sawicki Fixed documentation of the new function vmaCreateBufferWithAlignment
2021-07-07 adam.sawicki Added VmaAllocatorCreateInfo::pTypeExternalMemoryHandleTypes
2021-06-28 adam.sawicki Added function vmaCreateBufferWithAlignment
2021-06-25 adam.sawicki Used range-based for loops wherever I could
2021-06-21 adam.sawicki Regenerated documentation
2021-06-21 adam.sawicki Fixed docs
2021-06-21 adam.sawicki Fixes. Left only new member VmaPoolCreateInfo::pMemoryAllocateNext.
2021-06-18 adam.sawicki Fix to online documentation
2021-06-18 adam.sawicki Added VmaPoolCreateInfo::minAllocationAlignment
2021-06-14 adam.sawicki Renamed macro VMA_DEBUG_ALIGNMENT to VMA_MIN_ALIGNMENT as there are valid use cases for it other than debugging purposes.
2020-10-23 adam.sawicki Added VmaAllocatorCreateInfo::pTypeExternalMemoryHandleTypes
2020-10-05 adam.sawicki Add VmaPoolCreateInfo::pMemoryAllocateNext
Created with:
roll-dep third_party/vulkan_memory_allocator
Bug: angleproject:6640
Change-Id: I8133e3c2b3f2787783f609b468adbe90026cf50d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276037
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Lingfeng Yang <lfy@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
d87d10cd
|
2021-11-12T11:02:01
|
|
Fix ASAN issue with GLVertexIDIntegerTextureDrawElements
Was
GLint clearData[] = {42};
glClearBufferiv(GL_COLOR, 0, clearData);
Now
GLint clearData[4] = {42};
glClearBufferiv(GL_COLOR, 0, clearData);
Bug: angleproject:6688
Change-Id: Ia8fa0c7d406626046a32e613fda3a165a06941b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3278489
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
b2cf52e6
|
2021-11-10T14:49:09
|
|
Bug fix in unpack buffer validation
For an implementation that supports GL_EXT_buffer_storage extension
it is valid to read or write from a buffer that is partially or fully
mapped if it was allocated by a call to glBufferStorageEXT with the
GL_MAP_PERSISTENT_BIT_EXT included in <flags>
Bug: angleproject:5056
Bug: angleproject:6689
Test: BufferStorageTestES3.TexImage2DPixelUnpackBufferMappedPersistently
Change-Id: Ia4b6967aab02bbfb101d5253b9c83d314bc92f5f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3278482
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
573f9415
|
2021-11-12T12:22:39
|
|
Vulkan: Prefer aggregate barriers on SwiftShader
SwiftShader is not currently sensitivel to stage masks, so aggregating
barriers leads to more efficient rendering.
Bug: angleproject:4633
Change-Id: I262d1e98d4b08a1ca134a1c5c64ae964ceb6cd16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3279020
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
6fe13477
|
2021-11-11T00:47:14
|
|
Vulkan: Add external's pNext to ANGLE_external_objects_flags
ANGLE was chaining VkImageFormatListCreateInfoKHR to
VkImageCreateInfo::pNext to support sRGB extensions. For external
images, it was unknown whether that was valid because there was no way
to know if external used an identical chain of pNexts. This was causing
a discrepancy between images created by Chrome and those created by
ANGLE as part of an import.
This change updates ANGLE_external_objects_flags to take in the pNext
chain external has used to create the image so ANGLE could create the
image identically.
Bug: chromium:1266094
Change-Id: I479b9e7ff39d437425dc91c79834880749766f99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3274177
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
eb3ef08e
|
2021-11-11T17:41:48
|
|
Vulkan: Differentiate perf warnings and RP closure events
... and application events, by using different debug source enums,
translating to different colors in API debuggers.
Bug: angleproject:2472
Change-Id: Ice422c7ae59fb508a10500b9fbed79d4c9664c11
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3275840
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
dbc0c646
|
2021-11-06T01:09:26
|
|
Vulkan: Output the reason for RP closure in command buffer
To make it easier when viewing the command buffer in a graphics
debugger, this change inserts a marker just before closing the render
pass that specifies why the render pass was closed.
Bug: angleproject:2472
Change-Id: I862e500cd58332d6e199c853315c560fe6a73dc2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3265609
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
a9f2e87e
|
2021-11-12T15:02:50
|
|
Revert "Vulkan: Allow SystemInfo to pick ICD."
This reverts commit b5adbe272e4829d77105e49607bf8ddafd385f17.
Reason for revert: Fails GN check on Android/iOS in Chrome:
https://chromium-review.googlesource.com/c/chromium/src/+/3276779/
Original change's description:
> Vulkan: Allow SystemInfo to pick ICD.
>
> This will be used in conjunction with SwiftShader.
>
> Bug: angleproject:6496
> Change-Id: I894aa4cf3b9473738b549de9941eb82e09234121
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276515
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
TBR=syoussefi@chromium.org,jmadill@chromium.org,angle-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: I198802d6bc93993d3544ed4627e131cb7b93f381
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:6496
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276045
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
eefb4111
|
2021-11-12T10:01:29
|
|
Roll SwiftShader from 73a6940a2d14 to 678d39313950 (4 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/73a6940a2d14..678d39313950
2021-11-12 capn@google.com Make sw::Constants a member of vk::Device
2021-11-12 capn@google.com Pass the vk::Device to every routine as an extra parameter
2021-11-12 capn@google.com Split image sampling into routine lookup and function call
2021-11-11 sugoi@google.com VK_KHR_copy_commands2 support
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jmadill@google.com
Change-Id: Ib8807aa6197293b6c07306f4c2a6f2361fffde57
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3277919
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
c6d86da2
|
2021-11-11T15:30:41
|
|
Add test for gl_VertexID and DrawElements
This fails on the WebGL CTS conformance2/rendering/vertex-id.html.
Repoing here to make it easier to debug/find/fix.
Bug: angleproject:6688
Change-Id: I0a4bafc5700c77e0b6c44b067167fc4a60e63c22
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276708
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Gregg Tavares <gman@chromium.org>
|
|
|
b1dcf97b
|
2021-11-12T08:16:25
|
|
Roll Chromium from 44723f7dd122 to 02bf0f96483c (416 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/44723f7dd122..02bf0f96483c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/25c5adab15..c0c930390e
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/845c3dc326..5cae5806fe
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a7ad5b5c96
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/787f2f0eb5..08a95d8392
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/6da1d53b97..f8964a5ccf
* tools/luci-go: git_revision:d17c642c8c3c6d9e37bd9c25535c4c5b66b99781..git_revision:bf56a119c5f056a1f7a04c8dbe19cdd86728b540
* tools/luci-go: git_revision:d17c642c8c3c6d9e37bd9c25535c4c5b66b99781..git_revision:bf56a119c5f056a1f7a04c8dbe19cdd86728b540
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7c1995f2cc..4279847036
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a7498191ed..4df4d99bd6
No update to Clang.
Bug: None
Tbr: jmadill@google.com
Change-Id: Ie2beb13c39d5f237863d49851a6daef7aa71b28c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276463
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
ee941238
|
2021-11-11T22:00:04
|
|
Capture/Replay: Mark another ImageTest test as FLAKY
Bug: angleproject:6286
Change-Id: Idbbdab532a449d754d05208aeadd94462c8c572a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276041
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9c486b67
|
2021-11-11T09:55:47
|
|
Unoverride upstreamed dEQP fix
Bug: angleproject:5500
Change-Id: I486ebf72840e8b6ff9ca36ac7ad491fea9dd4cf8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3275834
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d2d3a546
|
2021-11-11T12:22:04
|
|
Vulkan: Write perf warnings in command buffer
It's much easier to understand what command the perf warning refers to
when it's visible in the command buffer using a graphics API debugger.
This change creates ANGLE_VK_PERF_WARNING which gives the warning both
to the application (through ANGLE_PERF_WARNING) and inserts it in the
command buffer.
Bug: angleproject:2472
Change-Id: Ie84feed53eca5cda93e1f2bc653fcbf9bcd57b56
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3275839
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
2aa62964
|
2021-11-11T13:24:27
|
|
Vulkan: Reset mFramebuffer when mFramebufferCache is cleared
The mFramebuffer pointer becomes stale when mFramebufferCache
is cleared. Set mFramebuffer to nullptr when this happens.
Test: --deqp-surface-type=fbo --deqp-case=KHR-GLES31.*
Bug: angleproject:6682
Change-Id: I5fd21a64f0f935de04e2934e794c915ccf880c16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276701
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Brandon Schade <b.schade@samsung.com>
|
|
|
558981c1
|
2021-11-10T23:13:03
|
|
Vulkan: Make write-after-invalidate checks more precise
Previously, the size of the command buffer was used as indication for
whether the render pass attachments might have been modified after
glInvalidateFramebuffer. In that case, the invalidate was undone. This
is made more precise by making sure only vkCmdClearAttachments and
vkCmdDraw* calls are counted for this purpose.
For example, inserting event markers after glInvalidateFramebuffer now
retains the invalidation.
Note that this can be even further optimized by tracking real writes to
attachments. For example, currently a draw call with depth test
disabled still undoes the invalidation of the depth buffer, but it
shouldn't.
Bug: angleproject:5079
Change-Id: I6257b4116a73213884b919bc7f3c86ff39b6aeed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3274176
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b5adbe27
|
2021-11-11T11:43:30
|
|
Vulkan: Allow SystemInfo to pick ICD.
This will be used in conjunction with SwiftShader.
Bug: angleproject:6496
Change-Id: I894aa4cf3b9473738b549de9941eb82e09234121
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276515
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
96b587b0
|
2021-11-10T15:10:09
|
|
Vulkan: Fix rendering to RGB external images
Based on the provided usage flags, the texture's image access mode is
updated to be renderable.
Bug: chromium:1266094
Change-Id: I5d092a2786fc12537ef0ad1f224137cc1fd8f864
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270980
Reviewed-by: Craig Stout <cstout@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
42c0207d
|
2021-11-11T13:01:18
|
|
infra: Remove remaining references to 'master'.
These are all now replaced with 'main'.
Bug: angleproject:6685
Change-Id: I36cb17625c44d06689f7debf004abd3dd016265b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276517
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
b570a844
|
2021-11-11T12:25:47
|
|
infra: Remove outdated "master" ref in CI config.
This should let the CI console start running changes again.
Bug: angleproject:6685
Change-Id: I2d172bd9a90b9772efeeaa9cadf0bc865b917e16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276516
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
2a9e6e48
|
2021-11-01T15:56:54
|
|
infra: Add tests to ASAN configs.
These add basic ANGLE tests with SwiftShader + ASAN.
Bug: angleproject:5795
Change-Id: I92a51a44214ff0f442d4a1b2a0bc6ac2b8d3f4eb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3254431
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
2a71c9cd
|
2021-11-11T09:28:15
|
|
Remove stray deqp override file
Override was effectively reverted in:
https://chromium-review.googlesource.com/c/angle/angle/+/2375965
Bug: angleproject:4143
Change-Id: Idd38bdfa542eec44bc873791910c070b1e0d98c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3275833
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
a4a52f78
|
2021-11-10T12:43:37
|
|
EGL: Validate CreatePbufferSurface attributes.
This fixes an ASAN issue with a dEQP negative test:
dEQP.EGL/functional_negative_api_create_pbuffer_surface
Bug: angleproject:6660
Change-Id: I2d052f9f948b7a2a6fe3fbb1f1621dd280bb0d36
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270978
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
4e26eac5
|
2021-11-10T21:19:35
|
|
Vulkan: Fix VVL warnings on extensions that are not enabled
Bug: chromium:1266094
Change-Id: Idbae6cbe2c5593665438d118f17d184f8a81f0d9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3274932
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
393785b7
|
2021-11-10T12:14:03
|
|
Add attribute validation for context creation.
This fixes another ASAN bug that popped up with the dEQP EGL tests:
dEQP.EGL/functional_negative_api_create_context
Bug: angleproject:6660
Change-Id: I8f5ca1cc9ca77f2be28ecf120a90c9efcf9d4b24
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270977
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
92bdb59b
|
2021-11-11T10:01:29
|
|
Roll SwiftShader from 82d932bdfc41 to 73a6940a2d14 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/82d932bdfc41..73a6940a2d14
2021-11-10 sugoi@google.com Tightly pack PlaneEquations array
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jmadill@google.com
Change-Id: I1a1673aebe1ad4c7948eee7f815299d6dcf53017
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3275316
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
b8d6331d
|
2021-11-11T07:21:26
|
|
Roll Chromium from 6d25c1889eb7 to 44723f7dd122 (470 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/6d25c1889eb7..44723f7dd122
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/3a26983ac0..25c5adab15
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ee43952a47..707d75f53e
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f6490e8f59..845c3dc326
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a1290bc895..cea9b74ecb
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/ca1e82f3c5..3aa5bf5616
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8d1435ba08
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ea9285c47f..787f2f0eb5
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b553e6d46a..7c1995f2cc
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d88a90b430..a7498191ed
No update to Clang.
Bug: angleproject:6430
Tbr: jmadill@google.com
Change-Id: I07e3ccf27c78a6d39acb4f433d887b637b6360d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3274894
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
ec5d3795
|
2021-11-09T13:23:43
|
|
Metal: Fix InvalidateCopyThenBlend
Render pass descriptor was not being changed
due to blend state not being checked when
looking for equality.
Bug: angleproject:6669
Change-Id: Ic85dbec29ddb53a8c7e2e708f1ac0c99512e7248
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270596
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Gregg Tavares <gman@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
133cf4be
|
2021-11-10T15:16:07
|
|
Fix out-of-bounds read in MemoryBarrierTestBase.
This second read was in transformFeedbackBitBufferWriteThenCapture.
Bug: angleproject:6646
Change-Id: I67134e5a7a9a610c11266c51bdc1ced6ef018b8a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270981
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
2d4bee83
|
2021-11-04T10:16:16
|
|
EGL: Add early exit when hitting invalid attribute.
According to the EGL spec, we stop checking attributes when we
encounter an invalid enum. That means it's valid for an application to
pass in a list of attributes without EGL_NONE as long as one of them
is invalid. To handle this, we add lazy attribute validation to the
AttributeMap class, that gets triggered in the validation calls.
We only implement the early exit validation for the config attributes
to fix an EGL test that would access out of bounds memory.
Bug: angleproject:6660
Change-Id: I264d0f98b4ddd9e74187846e9e668270a6fbaee1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3262478
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
5a5996aa
|
2021-11-09T21:42:43
|
|
Vulkan: Handle missing decorations in SPIR-V precision fixer
Bug: angleproject:6674
Change-Id: Ibfc72f14b9eeb17d7c70cf6d2384d970b2e66650
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3271551
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
f045fe07
|
2021-11-04T10:44:20
|
|
Fix MSRTT unsized texture formats querying supported samples.
The texture format information in gl::Context is sized formats only.
When MSRTT textures are used, they would query the potentially unsized
format for maximum supported samples. This would return 0 and cause an
incomplete framebuffer when the sample count missmatched with other
attachments.
Bug: chromium:1238327
Change-Id: I06514b1b9badefa81bba3b7ad9ba5db932b4c12b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3260555
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
0fcad626
|
2021-11-09T14:02:08
|
|
Vulkan: Fix edge case with changing base level.
Bug: chromium:1267624
Change-Id: I36b983fdbbb258454215abe827837517df5a5aff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270971
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
f422f21a
|
2021-11-09T18:42:15
|
|
Reland "Metal: Reintroduce GPU power preference selection code."
This reverts commit 67a8cf07a740c5ce3aafd2ad7fddd370451b3525.
Reason for revert: Landed Chromium-side dependency:
https://chromium-review.googlesource.com/c/chromium/src/+/3271170
Original change's description:
> Revert "Metal: Reintroduce GPU power preference selection code."
>
> This reverts commit 017161701b7dbf70a13f3c180a39e1fa45c27d9f.
>
> Reason for revert: Blocking roller, please re-land with the fix.
>
> Original change's description:
> > Metal: Reintroduce GPU power preference selection code.
> >
> > This CL re-introduces the GPU power preference code to
> > the metal backend. It also reworks EGLDisplay caching
> > in the frontend to cache based on the native display
> > as well as the power preference attribute.
> > A new extension, EGL_ANGLE_display_power_preference is
> > added based on EGL_ANGLE_power_preference. This extension
> > is a client extension that allows selection of GPU on
> > display creation, similar to how GPUs are selected on
> > context creation in EGL_ANGLE_power_preference.
> > This CL adds EGLDisplayPowerPreferenceTest and enables it on
> > the metal backend.
> >
> > Bug: angleproject:6143
> > Change-Id: I0a081dcd2e3f18ab365fdd3498ddcb6e2ba35212
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3231986
> > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
> > Reviewed-by: Gregg Tavares <gman@chromium.org>
> > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
>
> TBR=kbr@chromium.org,gman@chromium.org,jonahr@google.com,jmadill@chromium.org,angle-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: I4f775bf7139253a87b033a30e0da2100b3c1bb02
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: angleproject:6143
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270749
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
# Not skipping CQ checks because this is a reland.
Bug: angleproject:6143
Change-Id: Id9b0a5cbb76e4dea9e2f2da2b1c47a0587dfdaf5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270970
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
53def659
|
2021-11-09T14:58:18
|
|
Unskip RenderSolidColor test
Unskips EGLDirectCompositionTest.RenderSolidColor, as the driver bug
that caused it to be disabled should hopefully be fixed.
Bug: chromium:1063962
Change-Id: I8a01ca65fc7e2b4b820d61fced24cf53af9e9f3c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270597
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
6e6947e6
|
2021-11-10T10:01:29
|
|
Roll SwiftShader from 7e9b8b317f16 to 82d932bdfc41 (13 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/7e9b8b317f16..82d932bdfc41
2021-11-10 sugoi@google.com Fix Android.bp build after SPIRV-Headers update
2021-11-09 sugoi@google.com Follow-up 2: Fix Android.bp build after SPIRV-Tools update
2021-11-09 sugoi@google.com Follow-up: Fix Android.bp build after SPIRV-Tools update
2021-11-09 capn@google.com Associate inline sampler caches with instruction position
2021-11-09 capn@google.com Use the Vulkan format for OpImageWrite
2021-11-09 capn@google.com Simplify obtaining the type from a SPIR-V object <id>
2021-11-09 capn@google.com Treat sRGB formats as unsigned normalized
2021-11-09 capn@google.com Improve inverse blendConstant() readability
2021-11-09 capn@google.com Optimize clamping of constant blend factors
2021-11-09 capn@google.com Parse SPIR-V image instructions before code generation
2021-11-09 capn@google.com Check for valid SPIR-V <id>s by comparing against 0
2021-11-09 sugoi@google.com Fix Android.bp build after SPIRV-Tools update
2021-11-09 sugoi@google.com Add warning treated as error for missing case statement
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jmadill@google.com
Change-Id: I1ae9d517c5abaa72b8d4ec068a639a58b50b4208
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3272370
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
3aa04f00
|
2021-11-10T07:00:02
|
|
Roll Chromium from 76a46804f683 to 6d25c1889eb7 (471 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/76a46804f683..6d25c1889eb7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/b9210ac77f..3a26983ac0
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/80e4f838fa..b138e6ce86
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/bc060a25be..ee43952a47
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/792217f643..f6490e8f59
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/6fdb0784b9..a1290bc895
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0f5030b08c..ca1e82f3c5
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5c5e5a1d28
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/266129cba3..ea9285c47f
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/125bb2ea5f..b553e6d46a
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a95854871a..d88a90b430
No update to Clang.
Bug: angleproject:6143
Tbr: jmadill@google.com
Change-Id: I50b10efd5fbe70515160c92047c362ada0276754
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270602
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
cd822868
|
2021-10-28T13:00:09
|
|
Vulkan: MAP_INVALIDATE_RANGE_BIT: shadow or exclude
One method of dealing with glMapBufferRange + range invalidation; treat
it like bufferSubData and stage the update.
Another method is to ghost the buffer but copy only memory outside the
invalidated range.
This CL pursues a policy where if less than half of the buffer is
invalidated, we stage. Otherwise, we ghost and copy only memory outside
the invalidated range.
DynamicBuffer is chosen over DynamicShadowBuffer because it turns out to
end up implicitly tracking all active invalidate ranges (through its
freelist), and performs buffer copy on GPU. if we use a
DynamicShadowBuffer and then BufferVk::stagedUpdate, it's the same thing
but more work (an extra memcpy into the staging buffer). To make this
clear, we split the logic of stagedUpdate into two parts, the
allocation/map, and the flush, and reuse one half in glMapBufferRange,
and the other half in glUnmapBuffer.
Test: Faster performance in MapBufferRange perf test, no non-noisy
regress in trace tests
Bug: angleproject:6634
Change-Id: Ie2e6a9586824b8cb59a97419bb8052acd1de2033
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3251686
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lingfeng Yang <lfy@google.com>
|
|
|
0b46ef40
|
2021-11-04T09:30:23
|
|
Vulkan: Start on a MapBufferRange benchmark
We have a lot of apps that use MapBufferRange to upload data. That can
be low performance. Let's have a benchmark for this.
Bug: angleproject:6634
Change-Id: I7e20ad65b89700733c02995a7c56d641e39a43b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3261378
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lingfeng Yang <lfy@google.com>
|
|
24136212
|
2021-11-08T14:01:34
|
|
Allow GN specification of shared library extension name
For use as system libraries in virtualized Linux environments,
allow use of custom sonames.
Bug: angleproject:6672
Change-Id: If297e3eaa090bfd08cb9df68a4c727da72228bcc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3268941
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
5eb86d4a
|
2021-09-21T15:17:04
|
|
EGL: EGL_KHR_lock_surface3 frontend
Add queries to get locked buffer attributes
Add validation for LockSurface, QuerySurface
Bug: angleproject:6062
Change-Id: I4919bef2a17d3505cccad08f7c4f8a3ca5d7e4e6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3174322
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d3e67716
|
2021-09-21T15:03:15
|
|
EGL: EGL_KHR_lock_surface3
Add new extension KHR__lock_surface3
Add new interfaces for locking and unlocking a surface.
Test: angle_end2end_test --gtest_filter=EGLLockSurface3Test
Bug: angleproject:6062
Change-Id: Ic40708db4db552107025635540a0c62f956d741e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3161447
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
5ae7342b
|
2021-11-09T16:26:10
|
|
[ios] Remove support for building with Xcode clang
Chromium //build will soon remove the `use_xcode_clang` variable.
Remove it from Angle to avoid breakage when the variable is gone.
This is a followup to https://crrev.com/c/angle/angle/+/3259713
where one use of `use_xcode_clang` was not left by mistake.
Bug: chromium:1266466
Change-Id: Idbd8b3daeacac1ba88fc818f3939bdcd15e449c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3269890
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
91d36473
|
2021-11-08T16:27:20
|
|
Fix invalidation of GL_FRAMEBUFFER invalidating READ FBO
Per spec, GL_FRAMEBUFFER means GL_DRAW_FRAMEBUFFER for
glInvalidateFramebuffer.
Bug: chromium:1267424
Change-Id: I8c9ab61ecdbd4ccee4262dc8559b2feb02b4837c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3266176
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
517ff220
|
2021-11-08T23:57:16
|
|
Add test for texture state change bug
Bug: chromium:1267624
Change-Id: I270e54921d40a2d139afdc78c90ab05164cbfabf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3268492
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ef93b32c
|
2021-11-09T00:26:13
|
|
Vulkan: Fix deferred clears vs invalidate
In this scenario:
- Clear color
- Invalidate depth
- Clear color
The invalidate step flushed the deferred color clear, but the following
clear did not expect an open render pass without any draw calls in it.
This change fixes this issue, while simultaneously optimizing invalidate
by making sure the clears accumulated during syncState() are redeferred
instead of flushed.
This issue was discovered in
https://chromium-review.googlesource.com/c/angle/angle/+/3266176 where,
as part of an unrelated fix, an accidental render pass closure is
removed.
Bug: chromium:1267424
Change-Id: Icfc0a53dbf84e6339ee23960ed847444830054e6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3266178
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
67a8cf07
|
2021-11-09T15:10:50
|
|
Revert "Metal: Reintroduce GPU power preference selection code."
This reverts commit 017161701b7dbf70a13f3c180a39e1fa45c27d9f.
Reason for revert: Blocking roller, please re-land with the fix.
Original change's description:
> Metal: Reintroduce GPU power preference selection code.
>
> This CL re-introduces the GPU power preference code to
> the metal backend. It also reworks EGLDisplay caching
> in the frontend to cache based on the native display
> as well as the power preference attribute.
> A new extension, EGL_ANGLE_display_power_preference is
> added based on EGL_ANGLE_power_preference. This extension
> is a client extension that allows selection of GPU on
> display creation, similar to how GPUs are selected on
> context creation in EGL_ANGLE_power_preference.
> This CL adds EGLDisplayPowerPreferenceTest and enables it on
> the metal backend.
>
> Bug: angleproject:6143
> Change-Id: I0a081dcd2e3f18ab365fdd3498ddcb6e2ba35212
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3231986
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Gregg Tavares <gman@chromium.org>
> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
TBR=kbr@chromium.org,gman@chromium.org,jonahr@google.com,jmadill@chromium.org,angle-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: I4f775bf7139253a87b033a30e0da2100b3c1bb02
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:6143
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270749
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
c9595b37
|
2021-11-09T10:01:30
|
|
Roll SwiftShader from 4c6da56da96c to 7e9b8b317f16 (6 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/4c6da56da96c..7e9b8b317f16
2021-11-08 srisser@google.com Regres updates SHA and testlists after daily run
2021-11-08 sugoi@google.com Update SPIR-V shader instructions after SPIRV-Tools update
2021-11-08 swiftshader.regress@gmail.com Regres: Update test lists @ 4c6da56d
2021-11-08 sugoi@google.com Update SPIR-V Tools to 339d4475c
2021-11-08 sugoi@google.com Update SPIR-V Headers to 29817199b
2021-11-08 sugoi@google.com No format verification in SPIR-V headers and tools update scripts
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jmadill@google.com
Change-Id: I82eb8b1e12f16214ce6e96a3c39fbdb888678643
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3268659
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
5f7c3ba6
|
2021-11-01T13:27:15
|
|
Capture/Replay: Don't force initialization of FS inout vars
Since these variables are to be considered inputs as well as outputs
initializing them would overwrite the valid input values, hence skip
initialization.
Bug: angleproject:6608
Change-Id: Id8baf856a23ac84d18c61dd54cd6095128190075
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3253377
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
40ea507e
|
2021-11-09T08:31:25
|
|
Roll Chromium from f1944afd4c24 to 76a46804f683 (1053 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/f1944afd4c24..76a46804f683
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/53c802ccf2..b9210ac77f
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/4c6e0991b1..bc060a25be
* buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/99015718c3..51ffc5ed5c
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/d4fd825c14..792217f643
* third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/fc91ebbf8a..67d9735161
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c9cf63a9b5
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b85aef9b5c..266129cba3
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/af96b7b56f..92efe5e964
* tools/luci-go: git_revision:de048fb36dbb1cb5b78774cc4a758e783865062f..git_revision:d17c642c8c3c6d9e37bd9c25535c4c5b66b99781
* tools/luci-go: git_revision:de048fb36dbb1cb5b78774cc4a758e783865062f..git_revision:d17c642c8c3c6d9e37bd9c25535c4c5b66b99781
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/22f5180e91..125bb2ea5f
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/418f322961..a95854871a
* tools/skia_goldctl/linux: odChSNaPr6zCeStFFbBuHC29-LH02C49Bm_9htJrpagC..CseaUnLJ7HPr--xryu13CF7Iir6n0b8qmCJXm6gyZ4oC
* tools/skia_goldctl/mac: Ee-Y58INmdIA4z_rfmJjvZ-ljrcn-L2tk9nMJVDkidkC..VY8wueKQ3PgFlxfrtkyEqIEUBvFjmyowZ9aUNYRyEhcC
* tools/skia_goldctl/win: wgZW1xuI0RPDHDd63jpbn9w5KS6PRzkQrSqOp-Em3gQC..W_IYtpGZzolSY2j4xqryufwbZeApZYaqqcn4-CTtpL0C
No update to Clang.
Bug: angleproject:6430
Tbr: jmadill@google.com
Change-Id: I104948a0dd4e53804e75e5f299e37b4e348ead0d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3269375
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
2dd6ea51
|
2021-11-08T16:22:18
|
|
Capture/Replay: Limit the sleep time based on unfinished jobs
When running only a few tests the script has the tendency to sleep
a long time after the tests were finished. So limit the sleep time
by the number of remaining jobs.
Bug: None
Change-Id: I52ad39bf047abf93cd900f687bd3aae3962e9e20
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3263999
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
fa2e3749
|
2021-09-09T15:34:23
|
|
Reland "rename use_x11 to ozone_platform_x11"
This is a reland of 86f2854579ae7aaa4e425b8846693e44c3aede36
X11 shouldn't be enable for is_chromecast cases as
the original use_x11 gn arg is only enabled on linux && !chromecast.
Original change's description:
> rename use_x11 to ozone_platform_x11
>
> Ozone is default now in Chromium and non-Ozone/X11 (aka use_x11) is
> deprecated. During the transition period use_x11 == ozone_platform_x11.
>
> Bug: chromium:1096425
> Change-Id: Ia691ce249bc49040956bed033891799127a57bbc
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3151755
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Bug: chromium:1096425
Change-Id: I6f8dbacb756ce57ca7379bbd991ca1ff470c244d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3263987
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
|
|
5c16f77b
|
2021-10-01T20:07:09
|
|
Vulkan: Add flushCommandsAndEndRenderPassWithoutQueueSubmit()
Add flushCommandsAndEndRenderPassWithoutQueueSubmit() to allow
ContextVk::flushAndGetSerial() to only issue a single vkQueueSubmit().
Bug: angleproject:6546
Change-Id: Ia3fc2bb93e88583ebd80ee153749dc8ca42245dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3200673
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
53371cc0
|
2021-11-01T20:25:17
|
|
Vulkan: Use optimalBufferCopyOffsetAlignment
optimalBufferCopyOffsetAlignment is the optimal buffer offset alignment
in bytes for vkCmdCopyBufferToImage2KHR, vkCmdCopyBufferToImage,
vkCmdCopyImageToBuffer2KHR, and vkCmdCopyImageToBuffer. The per texel
alignment requirements are enforced, but applications should use the
optimal alignment for optimal performance and power use.
To improve efficiency, this CL updates ContextVk::mStagingBuffer's
alignment to the max of:
- minMemoryMapAlignment
- nonCoherentAtomSize
- optimalBufferCopyOffsetAlignment
On ARM, this is not expected to have any affect, since all three values
are 0x40, but other platforms may see a benefit.
Bug: angleproject:4297
Change-Id: I9185da111e09c5d782eb1dedb10369727cb9bf51
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3256007
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
0e20c680
|
2021-11-08T15:24:09
|
|
Sync framebuffer bindings in glInvalidateFramebuffer
If a framebuffer binding change is followed by glInvalidateFramebuffer,
ANGLE was not syncing the framebuffer binding.
- This means that invalidation was being done on the previous
framebuffer.
- Paired with deferred clears, this was causing ContextVk to start a
render pass on the previous, potentially deleted, framebuffer.
Bug: chromium:1267027
Change-Id: I092a0c8dd764db9e49258b694c970babb19cf24b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3266175
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
a9f24fa5
|
2021-11-08T12:21:25
|
|
infra: Switch ASAN to 64-bit on Windows.
ASAN is not supported in 32-bits on Windows.
Bug: angleproject:5795
Change-Id: Icabf31b8c9ad4d371217c9f4a288f909888eae61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3265532
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
651ae514
|
2021-11-08T14:07:30
|
|
Capture/Replay: Skip test of new failing tests
Bug: angleproject:6663
Change-Id: Ic253a4695eb4c27df2e77641df9f03b2ad8a33e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3266172
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
01716170
|
2021-10-14T13:24:41
|
|
Metal: Reintroduce GPU power preference selection code.
This CL re-introduces the GPU power preference code to
the metal backend. It also reworks EGLDisplay caching
in the frontend to cache based on the native display
as well as the power preference attribute.
A new extension, EGL_ANGLE_display_power_preference is
added based on EGL_ANGLE_power_preference. This extension
is a client extension that allows selection of GPU on
display creation, similar to how GPUs are selected on
context creation in EGL_ANGLE_power_preference.
This CL adds EGLDisplayPowerPreferenceTest and enables it on
the metal backend.
Bug: angleproject:6143
Change-Id: I0a081dcd2e3f18ab365fdd3498ddcb6e2ba35212
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3231986
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Gregg Tavares <gman@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
79a5dc0a
|
2021-11-05T23:26:43
|
|
Vulkan: Fix spammy best practices message
A GPU WRITE->HOST barrier frequently issued when the GPU outputs to a
host-visible buffer used the ALL_COMMANDS stage mask causing a best
practices message. This message is suppressed in ANGLE, but shows up in
RenderDoc and clutters the output.
Bug: angleproject:5070
Change-Id: I59aa7f8c7b3bf2788a3f7ae0ab6abdb4d3cd175e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3265606
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
f16d7b9c
|
2021-11-08T09:25:17
|
|
DEPS: Remove isolated client.
This is not used anymore.
Upstream: https://crrev.com/a5547854f1e8cb6bd3
Bug: angleproject:6666
Change-Id: I3c6089e0ff6b27d88ca2adaeea40f324e808de8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3265530
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
27a70025
|
2021-11-08T10:01:34
|
|
Roll SwiftShader from 70f3a0ff7233 to 4c6da56da96c (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/70f3a0ff7233..4c6da56da96c
2021-11-07 sugoi@google.com VK_EXT_pipeline_creation_feedback support
2021-11-07 swiftshader.regress@gmail.com Regres: Update test lists @ 70f3a0ff
2021-11-06 capn@google.com Fix min/max blend operations
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: If0ca4444fc5dc0a750550673475fb253f5ceb1f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3267553
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
1f42f6bd
|
2021-11-03T13:28:01
|
|
Add GL_RGB10_EXT format into list of supported formats.
When running with Wayland, EGL returns rgb10 buffer format in
egl config, which makes assertion to explode in formatutils as
this format is not in list of supported formats.
GL_RGB10_EXT is under the ES1 extension GL_OES_required_internalformat.
Thus, add it to the format table.
Bug: chromium:1231934
Change-Id: Ib47af538b16d6c7a652a44e0674757d292ac1394
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3253376
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
|