kc3-lang/angle

Log

Author Commit Date CI Message
Antonio Caggiano 7b0f6318 2022-03-30T14:16:02 Vulkan: Wayland include directories Add wayland include directories from vulkan headers build overrides to those vulkan dependent targets. Bug: angleproject:6902 Change-Id: I8699fdf18e9b44b04a580b6ea31493d740756cf0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3568377 Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop 8b84cf15 2022-03-30T13:42:38 Tests: Add GFXBench Car Chase trace Test: angle_perftests --gtest_filter="*car_chase*" Bug: angleproject:7125 Bug: angleproject:7173 Change-Id: I07069d46351718743e545fc056f41de2b6fe3820 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3561484 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 256bbb8a 2022-04-04T22:24:55 Vulkan: Don't invalidate resolve attachment except with MSRTT Previously, resolve attachments were only used with MSRTT emulation. As such, when an attachment was invalidated, its corresponding resolve attachment was also invalidated implicitly. This changed when glBlitFramebuffer was optimized to resolve attachments, though the render pass is immediately closed and no chance is currently given to invalidation. An upcoming change needs to invalidate the multisampled attachment independently from the resolve attachment. That is fixed in this change so that the implicit invalidation is done only for MSRTT emulation. Bug: angleproject:6762 Change-Id: Ia730d4bea1f4229c8068a41b151a7af95649b606 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3569483 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki b3fff1aa 2022-03-31T16:03:11 retrace_restricted_traces: Check for json file. Validate trace upgrades by looking for existing json file instead context header, which was incorrect when traces did not contain a context == 1. Introduce get_trace_json_path function. Use python fstrings. Bug: angleproject:7107 Change-Id: Ib83acb646fb2d9c38d8ca99766170e6c9c7eeb06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3571884 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Yuxin Hu a11bf0ed 2022-03-31T17:28:18 Fix Max Atomic Counter Conformance Test Failure on Pixel6 ARM does not support the VkPhysicalDeviceFeature vertexPipelineStoresAndAtomics. According to vulkan specs: we should disable the usage of atomic buffers in vertex, tessellation, and geomotry shader stages. Set maxShaderAtomicCounters to zero for all these shader stages if vertexPipelineStoresAndAtomics is not supported. Create two angle_end2end_test to check atomic buffer usage in tessellation control shader and tessellation evaluation shader. Bug: angleproject:6918 Change-Id: I566562f99672d50cfb3d75def81a18a613b26ca0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3563501 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Cody Northrop a555be4a 2022-04-02T19:46:22 Tests: Add Scary Teacher 3D trace Test: angle_perftests --gtest_filter="*scary_teacher_3d*" Bug: angleproject:7163 Change-Id: I305146c403288f9409637c0847af6c38b0cefa89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3567125 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Lubosz Sarnecki e933df51 2022-03-31T15:12:43 retrace_restricted_traces: Remove unused code. Remove unused load_json_metadata, get_trace_metadata and replace_metadata functions. Remove unused re import and trace_path parameter from get_context. Bug: angleproject:7107 Change-Id: I203609ca45145cdced8295d5edf7faa0c8606ae6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3571883 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Cody Northrop 808f754c 2022-04-04T17:53:48 Capture/Replay: Use glFramebufferTexture2D for cubes In GLES 3.2, you can use glFramebufferTexture2D or glFramebufferTextureLayer to bind a cube face as an attachment. Not all drivers support glFramebufferTextureLayer because the wording of the spec is confusing. Instead use the more portable glFramebufferTexture2D. Test: Aztec Ruins High MEC Bug: angleproject:7168 Bug: angleproject:7169 Change-Id: Ie1a7d06f817750ddf8e6e707814380e306f5ee29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3570242 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 1a3411c7 2022-04-01T18:42:51 Set SKIPPED status on skipped tests, rely on it in Gold tests. Gold tests check for '[ SKIPPED ] {test_name}' notice in test output instead of assuming that missing screenshot means SKIP. Now missing screenshot raises an exception. Also log the reason why the test was skipped. Example: [ RUN ] TracePerfTest.Run/native_asphalt_8 ../../src/tests/perf_tests/ANGLEPerfTest.cpp:837: Skipped Test skipped due to missing extension: GL_KHR_texture_compression_astc_ldr [ SKIPPED ] TracePerfTest.Run/native_asphalt_8 (182 ms) Bug: angleproject:6854 Change-Id: I2d88e2063a68ae95399a7932700f74032737ec91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3565561 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Jamie Madill 34471fed 2022-04-05T09:14:37 Vulkan: Skip failing intel blend test. Bug: angleproject:7177 Change-Id: I2aafc681fac1329be5691498d5128e9306b62dd3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3569487 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Nicolas Capens 4f7efb51 2022-04-04T15:48:03 Remove swiftshader_spirv_tools_dir SwiftShader now uses an independent build of SPIRV-Tools dependencies, like in other environments. Bug: b/158002593 Change-Id: I06df3d9be0f5aa8b253c0544a51dbc78d293d9b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3569623 Auto-Submit: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 2cb264b5 2022-04-05T10:01:19 Roll SwiftShader from a190ceed7293 to 7d100c556081 (9 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/a190ceed7293..7d100c556081 2022-04-05 sugoi@google.com Added missing feature structure for VK_KHR_maintenance4 2022-04-04 capn@google.com Validate SPIR-V instruction word array accesses 2022-04-04 dvet@google.com Add documentation for the configuration file mechanism 2022-04-04 capn@google.com Support VK_IMAGE_CREATE_EXTENDED_USAGE_BIT 2022-04-04 rebecca.chang@starfivetech.com Reactor: riscv64 is not supported in subzero 2022-04-04 rebecca.chang@starfivetech.com llvm-10.0: add configs/common and configs/linux for riscv64 2022-04-04 rebecca.chang@starfivetech.com llvm-10.0: update script to include riscv64 target 2022-04-04 rebecca.chang@starfivetech.com marl: add new source file for riscv64 2022-04-04 sugoi@google.com Add missing imageView compatible formats for YCbCr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I7436927f2ed5e367243f2b9867f70a84b7be1ac3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3570277 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 83d3a98c 2022-04-04T16:03:06 Remove commented out mSkipTest. mSkipTest = true was commented out in https://crrev.com/c/1456482 back in 2019 so presumably this is no longer needed. Bug: angleproject:3137 Change-Id: Ic2c4ca5e2bea939aee8cfb4e5386c7d526c39064 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3569586 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 74eac5e5 2022-04-04T16:11:26 Roll VK-GL-CTS from fbc38865227d to 6f8a7182bd26 (14 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fbc38865227d..6f8a7182bd26 2022-04-04 quic_mnetsch@quicinc.com Fixes pipeline library merge 2022-04-01 quic_mnetsch@quicinc.com Merge changes I12ee2542,Ic8530cb6 into main 2022-04-01 Charles.Johnston@amd.com Add more video exclusions to gen_framework.py 2022-04-01 1511060543@qq.com Remove a wrong qualityWarning for fbo completeness test 2022-04-01 quic_mnetsch@quicinc.com Fixes Conditional Rendering local memory tests 2022-04-01 gleese@broadcom.com Reduce framebuffer size on some graphicsfuzz tests 2022-04-01 gleese@broadcom.com Simplify isDeviceFunctionalitySupported 2022-04-01 illia.abernikhin@globallogic.com Extend conditional rendering tests to use buffer with device local memory 2022-04-01 jason.ekstrand@collabora.com Actually test compatible depth/stencil attachment formats 2022-04-01 antto.makinen@siru.fi Add a GraphicsFuzz coverage test 2022-04-01 juha.heiskanen@siru.fi Add coverage for depth bias with polygon topologies and fill modes 2022-04-01 rgarcia@igalia.com Fix feature checks in rasterization order attachment tests 2022-04-01 ari.suonpaa@siru.fi Add a batch of GraphicsFuzz coverage tests 2022-04-01 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,jmadill@google.com Change-Id: Ia3e2880dc038663055edbfc59c92510f7acf757b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3569323 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov e7d44541 2022-04-01T16:48:55 Use GTEST_SKIP to set gTest status of skipped tests to SKIPPED. Example from: angle_end2end_tests_on_Android_device_Pixel_4 Before: [----------] 1 test from BlendMinMaxTest [ RUN ] BlendMinMaxTest.RGBA16F/ES3_Vulkan Test skipped: (IsAndroid() && IsVulkan()) || isSwiftshader(). [ OK ] BlendMinMaxTest.RGBA16F/ES3_Vulkan (116 ms) "num_failures_by_type": { "CRASH": 0, "FAIL": 1, "PASS": 16966, "SKIP": 313, "TIMEOUT": 0 }, After: [ RUN ] BlendMinMaxTest.RGBA16F/ES3_Vulkan ../../src/tests/gl_tests/BlendMinMaxTest.cpp:191: Skipped Test skipped: (IsAndroid() && IsVulkan()) || isSwiftshader(). [ SKIPPED ] BlendMinMaxTest.RGBA16F/ES3_Vulkan (117 ms) "num_failures_by_type": { "CRASH": 0, "FAIL": 1, "PASS": 12067, "SKIP": 5212, "TIMEOUT": 0 }, Bug: angleproject:6854 Change-Id: I3335e4e2ae941d43d6a974d9611252e0849bc2c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3566225 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill b33767ec 2022-04-04T15:26:29 Revert "Vulkan: Fix texture-after-framebuffer sync issues" This reverts commit 535cd538f3585b44855647339f04bae1c1acf63a. Reason for revert: May fix Win/Intel blockman_go flakiness. Bug: angleproject:7167 Original change's description: > Vulkan: Fix texture-after-framebuffer sync issues > > In TextureVk::syncState, for various reasons, the underlying image may > need to be respecified. For example because base/max level changed, > usage/create flags have changed, the format needs modification to become > renderable, generate mipmap is adding levels, etc. > > Currently, ANGLE syncs FramebufferVk before TextureVk for the sake of > the deferred clear optimization. This means that if the texture needs > to recreate its underlying image, it needs to do so earlier than its own > syncState, and do so in FramebufferVk::syncState through the > TextureVk::getAttachmentRenderTarget function. > > Over time, TextureVk::getAttachmentRenderTarget was modified to do parts > of what TextureVk::syncState did for this matter as bugs were > discovered, and more continue to be discovered. The bug that prompted > this change is missing image recreation when usage/create flags change. > > In this change, the relevant code in TextureVk::syncState is refactored > in a helper that's called by TextureVk::getAttachmentRenderTarget. This > way, the two functions should always be in agreement, avoiding > TextureVk::syncState recreating the image after > FramebufferVk::syncState, leading to use-after-free bugs. > > Bug: angleproject:4418 > Bug: angleproject:6909 > Bug: chromium:1266094 > Bug: chromium:1296866 > Change-Id: I856a34ca5cf573578c771f5adbeb9208420a3f62 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3557817 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:4418 Bug: angleproject:6909 Bug: chromium:1266094 Bug: chromium:1296866 Change-Id: I26b6f644442e2875aba954d6417543b1d5121376 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3569801 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang bd7915fd 2022-04-04T10:02:29 Use provided format as intended format for EGLImage from VkImage The problem is because VkImage is created with R8G8B8A8 format, and then imported into ANGLE as EGLImage with GL_RGB format, however ANGLE doesn't set intended format correctly (ANGLE uses R8G8B8A8 instead of R8G8B8X8). So when clients use glReadPixels() to get pixels, the alpha channel is filled with incorrect value. Bug: chromium:1312490 Change-Id: Ief5b87ec5eb03c9cb37f10b2c20b5caf3013262d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3569481 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
angle-autoroll 4655ef15 2022-04-04T10:01:20 Roll SwiftShader from 649d6e46aeae to a190ceed7293 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/649d6e46aeae..a190ceed7293 2022-04-04 capn@google.com Correct border clamp and depth comparison order If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ic672f1ed216556d3bac9147e30437d961cec94d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3567292 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4b260225 2022-04-04T07:27:36 Roll Chromium from 804d5a91d49d to f39b4372b8a8 (124 revisions) https://chromium.googlesource.com/chromium/src.git/+log/804d5a91d49d..f39b4372b8a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1b3e19e7d9..d162691495 * buildtools/linux64: git_revision:bb8f66fdb5990ae5c0eb05152d51aca9a263b10d..git_revision:859dde4a7f34a4383179522f8e1061dcffac8691 * buildtools/mac: git_revision:bb8f66fdb5990ae5c0eb05152d51aca9a263b10d..git_revision:859dde4a7f34a4383179522f8e1061dcffac8691 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/31359e0574..cb96c63d05 * buildtools/win: git_revision:bb8f66fdb5990ae5c0eb05152d51aca9a263b10d..git_revision:859dde4a7f34a4383179522f8e1061dcffac8691 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5a80dbc44d..2575976cb8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a9d86a4042 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/017544dc14..a9c548efd6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b0b65970bb..5445d7abdf No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: I129b523c0eafcc4db3ff4edb0f3ef16095433da7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3567417 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4b232a9a 2022-04-02T22:32:07 Roll Chromium from 384f873e0970 to 804d5a91d49d (4365 revisions) Use per-arch clang-format binaries on Mac. https://chromium.googlesource.com/chromium/src.git/+log/384f873e0970..804d5a91d49d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8f75e7de55..1b3e19e7d9 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d8c375426d..c2e4795660 * buildtools/linux64: git_revision:bd99dbf98cbdefe18a4128189665c5761263bcfb..git_revision:bb8f66fdb5990ae5c0eb05152d51aca9a263b10d * buildtools/mac: git_revision:bd99dbf98cbdefe18a4128189665c5761263bcfb..git_revision:bb8f66fdb5990ae5c0eb05152d51aca9a263b10d * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/93b8dcd57b..e9c9bdf975 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/d1c7f92b8b..31359e0574 * buildtools/win: git_revision:bd99dbf98cbdefe18a4128189665c5761263bcfb..git_revision:bb8f66fdb5990ae5c0eb05152d51aca9a263b10d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/55f1dc2d27..5a80dbc44d * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a4297493d8..02654402b1 * third_party/android_build_tools/bundletool: LoldiQDpZ0uTdAm5EPgZ8hBJ3La2KlTWLuaRxE7eDigC..zQILIUnCaQ93HTtR07m4ahlE9mrkkwks52L5vFaUaUUC * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/87b4b48de3..2760db43ff * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a9d86a4042 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/76979dae56..017544dc14 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/71d78db8de..1d207dc895 * third_party/turbine: Go9J3Mz5ankZAgxmn5GxeXKdEDV73zaZp2ojNfGC1RQC..CJm6IViplElcjFYLJc0XtAjZ97BOVjQIwigcJN6C9gsC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/923f5eb4bf..d1aa7af3b0 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a15c2dfa35..c8e9f238ae * tools/luci-go: git_revision:cb424e70e75136736a86359ef070aa96425fe7a3..git_revision:6da0608e4fa8a3c6d1fa4f855485c0038b05bf72 * tools/luci-go: git_revision:cb424e70e75136736a86359ef070aa96425fe7a3..git_revision:6da0608e4fa8a3c6d1fa4f855485c0038b05bf72 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e6f159df60..8e9cb9f939 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/8a340b64dc..ff56ec6dea * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/46fa9b4765..b0b65970bb No update to Clang. Bug: angleproject:6947, chromium:1286289 Change-Id: I08ee20fcbc79bb977e37b010c93aeccda02d5e45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3567182 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov f41303cd 2022-04-02T19:23:11 Skip end2end tests timing out on TSAN and ASAN TSAN InstancingTestES3.LargeDivisor WIN ASAN GeometryShaderTest.LayeredFramebufferMidRenderClear3DColor Bug: angleproject:7159, angleproject:7160 Change-Id: I619669a70e3dbf215ebc8f43fb704ac284cd6a40 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3563547 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 535cd538 2022-03-29T16:29:58 Vulkan: Fix texture-after-framebuffer sync issues In TextureVk::syncState, for various reasons, the underlying image may need to be respecified. For example because base/max level changed, usage/create flags have changed, the format needs modification to become renderable, generate mipmap is adding levels, etc. Currently, ANGLE syncs FramebufferVk before TextureVk for the sake of the deferred clear optimization. This means that if the texture needs to recreate its underlying image, it needs to do so earlier than its own syncState, and do so in FramebufferVk::syncState through the TextureVk::getAttachmentRenderTarget function. Over time, TextureVk::getAttachmentRenderTarget was modified to do parts of what TextureVk::syncState did for this matter as bugs were discovered, and more continue to be discovered. The bug that prompted this change is missing image recreation when usage/create flags change. In this change, the relevant code in TextureVk::syncState is refactored in a helper that's called by TextureVk::getAttachmentRenderTarget. This way, the two functions should always be in agreement, avoiding TextureVk::syncState recreating the image after FramebufferVk::syncState, leading to use-after-free bugs. Bug: angleproject:4418 Bug: angleproject:6909 Bug: chromium:1266094 Bug: chromium:1296866 Change-Id: I856a34ca5cf573578c771f5adbeb9208420a3f62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3557817 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 4615a035 2022-04-01T21:57:28 Skip failing tests on Pixel 6 Bug: angleproject:7158 Change-Id: I863a20c1a5b5b055bfad1f1060a21281222e4668 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3565564 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 6b94a71c 2022-04-01T10:12:07 Vulkan: Lift SwS suppressions. Bug: angleproject:4092 Change-Id: I0e72b95ba5ba2b60420d5b685349c405864c2e6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3563513 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com>
Amirali Abdolrashidi ba0eba20 2022-04-01T17:39:58 Remove the TODOs regarding multisample buffer age * Removed the TODOs regarding the buffer age for multisample images. Bug: angleproject:7149 Change-Id: I25100eaef774613e71c5f7afdaed5833c63b6343 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3566228 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi cd9e887a 2022-03-31T15:43:17 Vulkan: Add multisample buffer age tests * Added variations of VerifyContent for multisample images. * getBufferAge() now sets age to 0 when the image is multisampled. Bug: angleproject:7149 Change-Id: I11f6fc92f383fba180f118b29c799072ed0eb51c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3563510 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 8f904363 2022-03-31T12:30:19 Vulkan: Move memory allocation initialization code into function No functional change expected. This CL wraps all initialization code for VMA allocator and memory suballocation memoryType and alignment calculation into its own function. Bug: b/223428306 Change-Id: Id630bbae035912ad41c51c2bb1cd02c2e438b442 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3563506 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi b169f6f9 2022-04-01T14:41:12 Vulkan: Fix no location decoration vs framebuffer fetch The input attachment index is identical to the location qualifier. If there's only one output, GLSL is allowed to not specify the location qualifier, in which case it would implicitly be at location 0. Bug: angleproject:6947 Change-Id: Ib8e31ab524f6f4d4fe1d3e49386a374724da06a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3566221 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com>
Cody Northrop 5cffbe96 2022-03-08T14:51:11 Android: Track peak GPU memory in restricted_trace_perf We've noticed that the script reports higher memory usage than recorded with local runs with similar steps. We isolated this to ANGLE using much higher peak memory when the trace loads, but then evens out after some time, nearing parity with native. To track this for optimization, we are going to split the memory tracking into: - peak GPU memory usage - sustained GPU memory usage This CL changes the script to: * Measure peak GPU memory usage by tracking total GPU memory used throughout the trace, returning the highest. * Measure sustained GPU memory usage by tracking usage from the middle of the trace (based on run time), returning the average. * Update the frequency of memory sampling by reducing sleep to 0.25 seconds instead of 1.0 second. As a data point, here is what angry_birds_2_1500 reports on Pixel 6: Before: 602599651 bytes After: 672231424 bytes (peak) 360621537 bytes (sustained) Bug: angleproject:6970 Change-Id: I227e30abeb6a5f28fe7230a2979441c3693234f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3511314 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill cc19587e 2022-04-01T10:58:43 infra: Use logarithmic batching in LUCI config. This ensures we get more atomic testing and can more easily spot which CL regressed for perf tests or experimental bots. Bug: angleproject:7152 Change-Id: I402cf71be66c365ab509bd9e8d2a5f8c338ab1e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3563514 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop e10803f7 2022-01-20T09:03:55 Compiler: Allow deferred array sizing in geometry shaders Based on work by Brandon Schade <b.schade@samsung.com>. When a shader sets an array input size in a GS after declaring input variables, compilation would fail. Example shader - in vec3 normal[]; in vec3 view_dir[]; in float patch_dist[]; in float e_patch_wire_scale[]; ... layout(triangles) in; layout(triangle_strip, max_vertices=3) out; void main() { ... Update translator to handle such cases. Also add a new check that there are no remaining unsized arrays when compilation has completed. Test: GeometryShaderTest.DeferredSetOfArrayInputSize Bug: angleproject:3571 Bug: angleproject:7125 Change-Id: I4853832c27f9551284bcca92b98cbf5f3a63aaf5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3564259 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill dd86dd15 2022-03-25T14:55:05 Cache outer array offset in linked uniforms. Our current tracking would only track one array dimension. For nested arrays the flattened parent index would be incorrect. Update this tracking so we can use it in the Vulkan descriptor set caching. Store this value as a separate integer member to avoid conflicting with other back-ends. Bug: angleproject:6776 Change-Id: Ie1a5dc3d64ccac23dffcc73684d619336cb0f0da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550824 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 0754b1f7 2022-04-01T12:40:40 Roll SwiftShader from bc5bec05c369 to 649d6e46aeae (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/bc5bec05c369..649d6e46aeae 2022-04-01 swiftshader.regress@gmail.com Regres: Update test lists @ afcbbd0a 2022-04-01 sugoi@google.com Fix inline uniform block update 2022-03-31 swiftshader.regress@gmail.com Regres: Update test lists @ bc5bec05 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I61de0b6acdfc25b8999c9f99f2e02d322eb61d20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3565830 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 57a081c7 2022-04-01T10:01:49 Roll vulkan-deps from e37ba68c0fde to 6d732e01d9ea (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e37ba68c0fde..6d732e01d9ea Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a59027c96d..f8c97eea2f * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/431f3b53ae..e494de740e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/80de10c77b..fbc48cff34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I076701c6f67724af8a52f15b6fa8eed992c623bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3565029 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya d3492eef 2022-03-31T09:06:07 Vulkan: Handle border color for stencil component For a texture with D/S format we need to handle border color based on GL_DEPTH_STENCIL_TEXTURE_MODE. Test: dEQP.GLES31/functional_texture_border_clamp_range_clamp_nearest_unorm_depth_uint_stencil_sample_stencil Bug: angleproject:3577 Change-Id: Ib1c5dfe35c1713101ed83395d3c0ad70a043764f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3564198 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao fe28a429 2022-03-30T15:34:49 Vulkan: Create buffer for vertex array if robust enabled If robust access is enabled (i.e., chrome), we want to ensure vulkan driver never access beyond that OpenGL buffer boundary. But with suballocation from BufferPool, we are using the same VkBuffer for all suballocations from the same BufferBlock. this combined with the fact that there is no size information in the vkCmdBindVertexBuffers, it means vulkan driver can not properly ensure vertex access not go beyond the subrange. It can only guarantee not access beyond the entire VkBuffer size. This CL creates a dedicated vkBuffer object and bind it to the suballocation of the vkDeviceMemory so that vulkan driver will see the exact range of the subrange instead of entire buffer. Since we may allocated more memory than actual requested size and the extra paddings are not zero filled , user size is used to create this vkBuffer. This is only enabled when robust access is enabled. This CL also ported webgl conformance test out-of-bounds-index-buffers.html and out-of-bounds-array-buffers.html to end2end test. Bug: chromium:1310038 Change-Id: I3499ae600028149b1039082e5011232b3e4e5e80 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3553940 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Alexey Knyazev d2a7db9d 2022-03-31T22:22:40 Metal: Remove DrawBaseVertexVariantsTest suppressions The issue was fixed in https://crrev.com/c/3472691 Bug: angleproject:6963 Bug: angleproject:7122 Change-Id: Iabdcf6fd9b538c19ad291fb7713186e314332f71 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3564558 Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Mohan Maiya 5aaa402c 2022-03-30T06:13:02 Fix Surface use-after-free bug In Display::destroyContext we would incorrectly destroy current surfaces while trying to makeCurrent the context to be destroyed. Introduce ScopedSurfaceRef, mirroring ScopedContextRef, to keep the surfaces alive while destroying the context. Bug: angleproject:7141 Test: EGLSurfaceTest.SurfaceUseAfterFreeBug* Change-Id: Ie9b3d7841e5ee561d96c13bfee9c7c87b40cc39d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3561354 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Kyle Piddington 1670c6dd 2022-02-17T14:15:08 Metal: Buffer data is not correctly updated When using a dynamic draw buffer, Metal creates more buffers to avoid in-flight synchronization issues. However, without correctly rebinding the buffers from the VAO, we get missing data. This patch adds a fix and a test to reproduce the issue. Upstream of https://bugs.webkit.org/show_bug.cgi?id=236427 and https://bugs.webkit.org/show_bug.cgi?id=236733 Bug: angleproject:7122 Change-Id: I879ff688af04a8215df6134400d0aab582b92842 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3472691 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
Mohan Maiya 078da78f 2022-03-17T13:06:58 Vulkan: Support GL_EXT_EGL_image_storage extension This extension provides a mechanism for creating texture objects that are both EGLImage targets and immutable and removes the possibility of implicit orphaning. EGL images created from external sources now support types other than 2D. Tests covering the new feature were added to ImageTest.cpp. Bug: angleproject:6346 Change-Id: Id3e328f352deb1af47062be232384229a8b1c341 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3530489 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi 36e142c1 2022-03-25T12:10:17 Vulkan: Fix deadlock in device loss When the device is lost, the commands queue is cleaned up. This shouldn't be done immediately if the device loss is generated from the command queue itself (due to mutual exclusion requirements). For example, CommandQueue::checkCompletedCommands() loops over mInFlightCommands, whose body contains ANGLE_VK_TRY. On device loss, that macro invokes CommandQueue::handleDeviceLost which clears mInFlightCommands. In this change, handleDeviceLost() defers device loss handling if the mutex is already taken. A new class is added, ScopedCommandQueueLock, that handles device loss at the end of the scope (i.e. when the command queue operation is finished) by calling handleDeviceLostNoLock() before releasing the lock. Bug: chromium:1304907 Bug: angleproject:7129 Change-Id: Ifb67cfdad9595cec51a6a58b69f629aede489725 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3552088 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 4b262ffd 2022-03-30T22:29:58 Vulkan: Don't reserve varyings for xfb if VK_EXT_depth_clip_control Bug: angleproject:5421 Change-Id: I7781a1981d522a8fd1952a1211c7223dc5a2d96f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3562379 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi cd3c74af 2022-03-30T11:48:41 SPIR-V Gen: Fix aliasing out parameters In ANGLE, when an unindexed lvalue was passed as an out parameter to a function, SPIR-V was generated such that the lvalue is passed in directly. A Skia test revealed a difference in SPIR-V and GLSL semantics where aliasing out parameters are expected to work on local copies until the end of the function. Bug: b/226904235 Change-Id: I476af01eb7d065272825967111cd208faf88c275 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3561278 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll b3acad0c 2022-03-31T10:01:50 Roll vulkan-deps from f9e3d5a50ca2 to e37ba68c0fde (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f9e3d5a50ca2..e37ba68c0fde Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/336508b06b..a59027c96d * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/3758a53671..431f3b53ae * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/15e2373828..80de10c77b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I8928045976aef0d13bef1109adaadb1eca2297ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3562311 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 3bdbfbf8 2022-03-25T16:34:51 Vulkan: Adjust border color Some border color tests used to fail due to either unclamped color values or not accounting for depth, stencil or luma formats. We now adjust the border color value according to the sampler's format. Test: dEQP-GLES31.functional.texture.border_clamp.* Bug: angleproject:3577 Bug: angleproject:6213 Change-Id: Ib38ce2374622bfafde69fe3fa2d7227d60043954 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551895 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
John Cunningham f5d20de8 2022-03-23T17:34:14 WebGL ReadPixels validation is incorrect. Remove GL_UNSIGNED_INT_24_8 from the supported types in ValidReadPixelsTypeEnum. Run the format/type validation before the check for missing attachment. Bug: angleproject:7119 Change-Id: Ie788084d0f41fef6847791de8c53be830eba7564 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3546723 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi 36a051d8 2022-03-28T22:53:38 Vulkan: Move mid-RP color clear to loadOp if content undefined Instead of using vkCmdClearAttachments, if the color attachment has not been written to, modify the loadOp of the currently open renderpass to CLEAR. This is an adaptation of commit cfe5a1735a934cc83133bb6c69d19aa27278a270 The difference with that commit is that, with the prior changes that added tracking of color attachment access in the render pass, this change is greatly simplified by being able to immediately know if clear can be moved to the beginning of the render pass. Bug: angleproject:5048 Change-Id: I72b3613ad08ff869b71aced7e1f4e9be916d7b49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3557815 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 16220730 2022-03-30T12:22:57 Vulkan: Enable framebuffer fetch on SwiftShader To roll into Chromium, this needs a rebaseline. Two oopr-canvas2D tests show a minor diff with this extension enabled. Bug: angleproject:6947 Change-Id: I19c285ec544fef3622cce805322093ccffbcb728 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3561280 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gregg Tavares e79ed0dc 2022-03-25T17:15:30 Metal: Fix for not submitting command buffers in order First I added a check that CommandBuffers are committed in order as the design requires that they are. This showed several tests asserting including the angle end2end test, OcclusionQueriesNoSurfaceTestES3.SwitchingContextsWithQuery/ES3_Metal and also several others. The check is cheap and helps catch bugs so it seems prudent to have it. Unfortunately, AFAICT, there is no trival fix. The issue is ContextMtl::flushCommandBuffer commits the outstanding commandbuffers but then, if there is/was a query in progress, more work needs to be done. That work calls ContextMtl::getBlitCommandEncoder which calls ContextMtl::ensureCommandBufferReady which calls ProvokingVertexHelper::ensureCommandBufferReady which ends up making a new command buffer. That command buffer should be committed before switching to a new context but the code that would commit it has already executed. It's not at all clear to me how to refactor the code to do this correctly. The simplest solution is to call ContextMlt::flushCommandBuffer twice which I know is gross but at least it fixes the bug and optimizing and/or refactoring can be done separately. Bug: angleproject:7131 Change-Id: Idb11efb35f6ad2fd890a5db15d3791c07586bf34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3553939 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Lubosz Sarnecki aef440e6 2022-03-04T16:43:38 Tests: Add Super Mario Run trace. Test: angle_perftests --gtest_filter="*super_mario_run*" Bug: angleproject:7098 Change-Id: I48ede98096bcb82270007d59f219f48ff673c7f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3560602 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
mark a. foltz 5040c4d8 2022-03-28T14:27:16 [Cast Convergence] Remove is_cast_desktop_build from ANGLE. Bug: angleproject:7136 Change-Id: If760b1e92467fcdf9d9eecf187e5418fe18e48d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3554916 Reviewed-by: Ryan Keane <rwkeane@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 77d0aa54 2022-03-30T10:01:49 Roll vulkan-deps from e38e969e37fe to f9e3d5a50ca2 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e38e969e37fe..f9e3d5a50ca2 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/5edd2f06d4..336508b06b * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b0171bb028..15e2373828 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ia0c25fd5ec338e6e49c8754b5457f23ba3207ec6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3559291 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki f8ddca00 2022-03-03T15:34:15 FrameCapture: Use getCompressedTextImage. Replace retrieveCachedTextureLevel with getCompressedTexImage. Remove compressed texture shadow copy code. Treat GLCopyImageSubData calls as texture updates by handling them in trackTextureUpdate. Bug: angleproject:5592 Bug: angleproject:5604 Bug: angleproject:6104 Bug: angleproject:6177 Bug: b/181797364 Change-Id: Ic6b2a41ce536e3e4b66497048954efdafa556d1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516377 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Arthur Eubanks 9a0b306d 2022-03-28T10:33:06 Remove set but otherwise unused variables Recent Clang versions have enhanced -Wunused-but-set-variable which now warns about these. Bug: chromium:1309955 Change-Id: If6a475e9f373b077fa3d9ef6f2274c8d115b5d24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3553570 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Arthur Eubanks <aeubanks@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 2d54b68e 2022-03-22T17:32:06 Vulkan: Use storeOp=None more opportunistically Previously, storeOp=None was used when the attachment was in "read-only mode" and storeOp=Store. With this change, storeOp=None is used more opportunistically when it's deemed that the attachment was not written to, regardless of if it was put in "read-only mode" (a construct added to support read-only depth/stencil feedback loops). Bug: angleproject:5048 Change-Id: I10832d4e2b97793ea1347a47175cbf8ce9af57d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3556368 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 657738e0 2022-03-29T19:27:34 Vulkan: Remove suppression of fixed VVL errors This partially reverts commit 91667dcafacc6d2bec545b776547e8583393a3f9. Bug: chromium:1310536 Change-Id: Ifeca55466f74b080274eb7762edce17bcace0aab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3557816 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 53a897e1 2022-03-29T19:26:51 Roll vulkan-deps from 8da5cdbde887 to e38e969e37fe (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8da5cdbde887..e38e969e37fe Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/b6554a7ff3..0c5928795a * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4bf3f07497..b0171bb028 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I985f6d7f794f74e62af534dc1d33529f9d9ba374 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3558473 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki 39c50daf 2022-02-18T13:15:09 Tests: Add Shadowgun Legends trace. Test: angle_perftests --gtest_filter="*shadowgun_legends*" Bug: angleproject:7042 Change-Id: I65c7671584edda823998145b6c6558353c5fdbd9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3497471 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Geoff Lang be53aea8 2022-03-10T11:04:22 Reland: Emulate RGB10 (no alpha) on desktop OpenGL. The OpenGL ES extension GL_EXT_texture_type_2_10_10_10_REV requires RGB and RGBA formats to be supported but Desktop OpenGL does not support RGB. Emulate it with the existing emulatedAlphaChannel path in TextureGL. Bug: chromium:1300575 Change-Id: I5efea52d3da628cf82b43fece23894e6f47df650 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3533141 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Steven Noonan a03ba732 2022-03-24T23:30:06 Vulkan: add tests for clearing/drawing after invalidate Two tests, to ensure that: - Clear gets treated as a LoadOp instead of as an out-of-renderpass clear, even if draws don't touch color buffers. - Invalidated image gets contents marked as defined after invalidate+clear, so draws to it get a renderpass with LoadOp=Load Bug: angleproject:7127 Change-Id: I78a8bd2100ba941a74755402649ae8edc7978026 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3552090 Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Steven Noonan <steven@valvesoftware.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll a161b08b 2022-03-29T10:01:08 Roll vulkan-deps from 737665b8eab1 to 8da5cdbde887 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/737665b8eab1..8da5cdbde887 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b383c5131e..5edd2f06d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ie480fcf9224746fbe919dc2fa38765010b3a1024 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3556817 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 53e432fe 2022-03-28T15:18:51 Vulkan: Track LOAD/STORE_OP_NONE in perf counters Bug: angleproject:5048 Change-Id: I52ed67e7a5c173dd1a7202fd6d4a1c484e79ea75 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3556367 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Zequan Wu 6a76aa3f 2022-03-28T09:40:36 Fix -Wunused-but-set-variable Bug: chromium:1309955 Change-Id: Ib5f7c73dd9a9f4ec27e43b0cb818864b2aaf48d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3554363 Auto-Submit: Zequan Wu <zequanwu@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Steven Noonan 1205a7e1 2022-03-24T22:15:44 Vulkan: always respect deferred clears in render pass I had a situation which was like this: - glBindFramebuffer(fbo) - glClear(color + depth) - series of depth-only draws: - glDrawBuffers() - disable all color buffers - glColorMask() - all false - glDrawElements/glDrawArrays - glBindFramebuffer(0) Even though the glClear happened before glDrawBuffers/glColorMask, it only got executed on the first glDraw* call. And since the draw buffers got disabled before it decided to act on the Clear, it thought it couldn't touch the color buffer in the render pass. So it ended up doing: vkCmdClearColorImage() on the color buffer vkCmdBeginRenderPass() with LoadOp C=Load, D=Clear before the draw instead of: vkCmdBeginRenderPass() with LoadOp C=Clear, D=Clear Bug: angleproject:7127 Change-Id: Ibc3b55b0c7815defcf6d711fa876eff43ba29d40 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551298 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll be0d78e5 2022-03-28T23:01:52 Roll SwiftShader from ea9806003d9e to bc5bec05c369 (15 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/ea9806003d9e..bc5bec05c369 2022-03-28 capn@google.com Update SPIR-V Tools to bd325d298 2022-03-26 swiftshader.regress@gmail.com Regres: Update test lists @ 40b410f4 2022-03-25 srisser@google.com Update simple limits for Vulkan's 2022 profile 2022-03-25 sugoi@google.com Add new core Vulkan 1.3 structures 2022-03-25 sugoi@google.com Use template functions for core Vulkan 1.3 properties 2022-03-25 sugoi@google.com Fix SPV_EXT_shader_stencil_export 2022-03-25 sugoi@google.com VK_KHR_shader_terminate_invocation implementation 2022-03-25 sugoi@google.com VK_KHR_shader_terminate_invocation promoted structures 2022-03-25 sugoi@google.com VK_EXT_shader_demote_to_helper_invocation support 2022-03-25 sugoi@google.com VK_EXT_shader_demote_to_helper_invocation promoted structures 2022-03-24 swiftshader.regress@gmail.com Regres: Update test lists @ 040e2534 2022-03-23 capn@google.com Force-inline all SPIR-V function calls 2022-03-23 capn@google.com Use SwiftShader's copy of SPIRV-Tools for GN builds 2022-03-23 capn@google.com Update SPIR-V Tools to 9668d2e4e 2022-03-23 swiftshader.regress@gmail.com Regres: Update test lists @ ea980600 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: I693fd52587c98ef7d90e4cb4ac266163508da87a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3556341 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop ce964d66 2022-03-26T18:56:50 Vulkan: Add tessellation to GetPipelineStage helper The tessellation stages were missing from a helper, which was silently returning an invalid value. Add a test and an assert, which fires before the fix. Test: GFXBench Car Chase Test: GLSLTest_ES31.TessellationTextureBufferAccess Bug: angleproject:7135 Bug: b/218314686 Change-Id: I2bc8d374300fc1470e52affabab7491698c99cee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3554575 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Steven Noonan a02fa8a0 2022-03-24T22:14:44 Vulkan: mark image contents defined on clear-invalidate-clear The backend was ignoring "repeated clears" with an Invalidate between them, which marked the image contents as undefined. When a clear happens after invalidate, verify that the clear parameters were the same, and simply mark the image contents defined if they aren't already. For example, in this scenario: - glBindFramebuffer(fbo) - glInvalidateFramebuffer(color + depth) - glClear(color + depth) - depth only render - glInvalidateFramebuffer(depth) - glBindFramebuffer(0) The color clear got skipped entirely because it was cleared with that color in a previous frame and no other color draws happened since. This caused sampling from the FBO's texture to return garbage data. Bug: angleproject:7127 Change-Id: I4ffe65c67375931ab63f07f27fa59ed0a4b90cd9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551297 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 91667dca 2022-03-28T18:56:11 Roll vulkan-deps from 9fd63df2bc48 to 737665b8eab1 (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9fd63df2bc48..737665b8eab1 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/f1d286fcc2..abbe466451 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/48c8363f0a..bd325d2984 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ea503f36e6..b383c5131e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/26f222cf8b..4bf3f07497 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1310536 Change-Id: Id57e6986082a6a7167b7217c3681d284d718086b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3556087 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Ian Elliott 638557ac 2022-03-28T10:20:30 Add back another Pixel-6-specific FAIL expectation Passes on pre-release Android T drivers, but fails on the Android S drivers. Bug: b/224537784 Change-Id: Idc631d13b1666f0f0b4bf1c5bbfa9e9343af4d75 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3554360 Auto-Submit: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll d883495d 2022-03-28T14:28:52 Roll VK-GL-CTS from 823d49cf5f5e to fbc38865227d (6 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/823d49cf5f5e..fbc38865227d 2022-03-28 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main 2022-03-28 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main 2022-03-28 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main 2022-03-26 pdaniell@nvidia.com Create custom device when testing VK_NV_shading_rate_image 2022-03-26 ari.suonpaa@siru.fi Enable EGL AHB tests 2022-03-25 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,syoussefi@google.com Change-Id: I1d2027947eab4bbc8a9f978f1748fcc9b86fbfd6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3555390 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Hans Wennborg 7e8e49a0 2022-03-28T13:42:50 Remove a set but otherwise unused var in DynamicImage2DHLSL.cpp Recent Clang versions have enhanced -Wunused-but-set-variable which now warns about this. Bug: chromium:1309955 Change-Id: Ic62427ab3129838d03878c308c6260993ae9fa57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550204 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 7a85d114 2022-03-25T15:01:17 Use [[nodiscard]] on RAII classes Scoped* classes provide an RAII way of adding cleanup/restore state/etc in a robust way. Unfortunatley, it's very easy to mistakenly leave the variable name, leading to the destructor being called immediately instead of at the end of the scope: { ScopedX(parameters); // instead of ScopedX x(parameters); // Code here is run after destructor } The [[nodiscard]] attribute, if specified on the ScopedX class would lead to a warning (turned to error with -Werror). This change does that for classes named *Scoped* in ANGLE. Bug: chromium:1103817 Change-Id: I65c9922c9b4eba1f9c033e093fe8fe534648ab62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3552092 Reviewed-by: Lingfeng Yang <lfy@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny bd173f0e 2022-03-14T09:59:47 Capture/Replay: limit per shader image uniforms when capturing The Caps::maxImageUnits are limited, but that's only the value that is checked when compiling shaders, we have also limit the values that are returned when using the GL interface. In addition print out the error log when compiling a shader fails in the Pipeline tests. Bug: angleproject:7094 Change-Id: I19f69afe2cece4841a395543c1e35785bc6bd698 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516078 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Cody Northrop e3c44919 2022-03-24T11:32:10 Debug: Add angle_enable_trace_events Include the following GN arg to print all GLES and EGL commands: angle_enable_trace_events = true Bug: angleproject:7126 Change-Id: I78eb061c10ed519d6a0b0357eea11567d1cfb518 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551656 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 32af258d 2022-03-22T16:44:14 Fix handling of incomplete CubeMapArray textures GFXBench Car Chase binds a cube map array as a default texture, then immediately samples from it without setting it up. This ends up treating the cube map array as incomplete. On the Vulkan backend, this is resulting in multiple validation errors, followed by a crash in the driver. There are a number of errors, but a telling one is this: vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but pCreateInfo->arrayLayers (=1) is not greater than or equal to 6. The Vulkan spec states: If imageType is VK_IMAGE_TYPE_2D and flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, extent.width and extent.height must be equal and arrayLayers must be greater than or equal to 6 This corresponds to language in the GLES 3.2 spec: 8.18. IMMUTABLE-FORMAT TEXTURE IMAGES TexStorage3D Errors An INVALID_OPERATION error is generated if any of the following conditions hold: * target is TEXTURE_CUBE_MAP_ARRAY and depth is not a multiple of 6 Since ANGLE treats incomplete textures as immutable, we need to update the dimensions of the backing image for CUBE_MAP_ARRAY. Also add a new test that exposes the problem. Test: IncompleteTextureTestES31.IncompleteTextureCubeMapArray Bug: b/218314686 Change-Id: Ibef41e15a7cfccb05e6039bfb8504d237bc42cd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3546290 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 041c4c6d 2022-03-25T16:30:03 Vulkan: Track color attachment usage like D/S in render pass That is in preparation for optimizing mid-render-pass clears, which requires an answer to the following query: "has this color image been read from / written to so far in the render pass?" With this change, a future CL will also be able to optimize color attachment invalidates, which currently break the render pass unconditionally, the same way depth/stencil is optimized. Bug: angleproject:5048 Change-Id: I3d3ee40d8444e6861c06340d5d52b17f5ee895b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3542989 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott b2c6e08e 2022-03-24T11:38:04 Reland Remove unnecessary suppressions for Pixel6 dEQP This is a reland of 0455f356eda37e98cbfaff6b4be3241a0743bdcd Original change's description: > Remove unnecessary suppressions for Pixel6 dEQP tests > > Bug: b/224537784 > Change-Id: If7befe0279a06cddb79c67fdd34a62b4cb51c6e0 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551658 > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Commit-Queue: Ian Elliott <ianelliott@google.com> The previous CL was based on the pre-release Android T Pixel 6 drivers. The Chromium bots are running released Android S Pixel 6 drivers. This CL updates the expectations with the observed status, and still removes some expectations that are now unnecessary. Bug: b/224537784 Change-Id: I4f4041e015824fd1d8211d6d7d0adedbccaa3ddb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3552544 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 3f331fae 2022-03-22T15:23:38 Vulkan: Dirty bits for depth/stencil access and feedback loop In preparation for doing the same for color, the depth/stencil render pass access and feedback loop modes are now updated with ContextVk dirty bits. This change also fixes clear after read-only depth/stencil feedback loop. The render pass wasn't broken in that case. Bug: angleproject:5048 Change-Id: I40f9b49593f9e6f35f42408e41c9d6267edb375e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3542988 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 04680183 2022-03-24T11:09:39 Capture/Replay: Fixes for Car Chase This CL contains two fixes: * Add GL_PATCHES to list of PrimitiveMode names * Use FramebufferTextureLayer for 3D and Cube textures Bug: angleproject:3662 Bug: angleproject:7125 Bug: b/218314686 Change-Id: Ia97d8221cb78ef6e895156b5a474483d570d6ab5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551096 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Stephen White 361874bb 2022-03-24T15:38:56 D3D: generalize more stuff (mImages, mReadonlyImages). Bug: angleproject:7121 Change-Id: I39e7df1e9aed84c225c8877a3d16ca3c44f70990 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550543 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Stephen White cfee4070 2022-03-24T15:21:22 D3D: generalize Image2D, ReadonlyImage2D and AtomicCounter. Mapify them so they can handle all shader types. Bug: angleproject:7121 Change-Id: Ia80d46200bf30509e1484f1e198e1edfe6344207 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550542 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Stephen White c399c693 2022-03-24T14:10:57 D3D: more generalization: cached Image2DBindLayouts. Bug: angleproject:7121 Change-Id: I5cead9f7e70cfb9ebea807b886ba849948a2ec47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550541 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Hans Wennborg 0c23c72b 2022-03-25T17:19:37 Suppress -Wunused-but-set-variable in Bison-generated code Recent Clang versions have enhanced the warning, causing it to fire in preprocessor_tab_autogen.cpp and glslang_tab_autogen.cpp. Since those are generated by Bison, we can't fix the code and instead should suppress the warning there. Bug: chromium:1309955 Change-Id: I31aa83571162310bef47a7ce84841446713a2d04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550200 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Stephen White f2e7a235 2022-03-25T10:00:11 D3D: generalize the Image2DBindLayoutCache to be per-shader. Bug: angleproject:7121 Change-Id: I3b5243583ac11a0fc96c4b9271118a8fd7ee4f66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550540 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Stephen White 4e939ac6 2022-03-25T09:58:52 D3D: generalize mImage2DUniforms. Mapify this variable so it can accommodate other shader types. Bug: angleproject:7121 Change-Id: If6893a5fceaf50db87c42176c58319ce17d23d54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550539 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Stephen White 3e0fba60 2022-03-24T11:09:24 D3D: generalize DynamicHLSL calls to take a shaderType. This allows all shader types to use these Image2D calls. Bug: angleproject:7121 Change-Id: I95f9e8a2fd206bcc3ff2ef7e06875d093d73dcd6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550538 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Roman Lavrov 5d17caef 2022-03-21T18:48:25 Migrate capture_replay sample to trace_fixture Bug: angleproject:5911 Change-Id: I6987e42f39a796e5888242a0d0f0dc05c99c703d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3537535 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Ian Elliott 1d71f55f 2022-03-24T19:27:21 Remove unnecessary SKIPs for Pixel4* dEQP tests Bug: b/224537784 Change-Id: I81c6f18d72ea893341ad2aa8ca819893e7d53d26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551659 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
angle-autoroll 0e6ba7d2 2022-03-25T10:01:09 Roll vulkan-deps from 3ef0c7c00c08 to 9fd63df2bc48 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/3ef0c7c00c08..9fd63df2bc48 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/397086a5b0..f1d286fcc2 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0d76dd23b7..ea503f36e6 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/755d34faa1..26f222cf8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I1c0b7c9f66c66c74923d85c0934f9969bccfd4b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3552736 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott 45543295 2022-03-25T04:36:49 Revert "Remove unnecessary suppressions for Pixel6 dEQP tests" This reverts commit 0455f356eda37e98cbfaff6b4be3241a0743bdcd. Reason for revert: Multiple tests that pass on my Pixel 6 fail on the bot Pixel 6's Original change's description: > Remove unnecessary suppressions for Pixel6 dEQP tests > > Bug: b/224537784 > Change-Id: If7befe0279a06cddb79c67fdd34a62b4cb51c6e0 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551658 > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Commit-Queue: Ian Elliott <ianelliott@google.com> Bug: b/224537784 Change-Id: Id3430a7632651b9b7b5e980f41678aebbdfc426c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3552124 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com> Auto-Submit: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi c8f86c21 2022-03-22T17:40:43 A handful of clear-related tests Credit Tim Van Patten <timvp@google.com> Bug: angleproject:5048 Bug: angleproject:5194 Change-Id: I00eccf1049118c3fba3c2c560c781cf09cf23362 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3543732 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu cdd97fb8 2022-03-24T17:41:30 Reland "Vulkan: Fix invalid access with display texture share group." This is a reland of 1099b5ef2279cfe1988a39c8e011aada59c650f1. Original change's description: > Vulkan: Fix invalid access with display texture share group. > Create bufferpool that owns by RendererVk. > If we are using EGL_ANGLE_display_texture_share_group > extension, use the bufferpool owned RendererVk, > otherwise, use the bufferpool owned by EGL::ShareGroup. > The bufferpool lifetime will remain consistent with > texture lifetime. > Bug: chromium:1299211 > Change-Id: Ie4e87cea1dfd20dabab24e2afed6ddd92e469888 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3531155 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: chromium:1299211 Change-Id: I4b8f5bcb30297f2c5f24e02404fd96011f9d843b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550038 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott 0455f356 2022-03-24T11:38:04 Remove unnecessary suppressions for Pixel6 dEQP tests Bug: b/224537784 Change-Id: If7befe0279a06cddb79c67fdd34a62b4cb51c6e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3551658 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
angle-autoroll dd4b2c21 2022-03-24T21:02:11 Roll vulkan-deps from c4109411d3f3 to 3ef0c7c00c08 (28 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c4109411d3f3..3ef0c7c00c08 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/c6f8e532dd..397086a5b0 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/565db34cba..0d4ce028bf * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0ab57c2c42..48c8363f0a * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/32c07c0c53..b6554a7ff3 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/2f89241d4d..0d76dd23b7 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/74f007dcd7..3758a53671 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e297733453..755d34faa1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I171f1f8cc751040cffd47a80e8d086a9e767928e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550043 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jonah Ryan-Davis cbbf5b5d 2022-03-23T18:17:17 GL: Only log all GL driver errors on debug builds Anything that invokes localtime_r() from the GPU process can be a slow operation on Linux. ANGLE's ClearErrors() function sometimes spams many errors, sometimes repeating every frame. These errors aren't necessary to print in release builds, and only logging these in debug builds will mitigate a lot of GPU process hangs. Bug: chromium:1077735 Change-Id: Ic1186732d477dee12caae0cb400e1d3504a0bd8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3546718 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Alexey Knyazev 18c36f8a 2022-03-19T19:22:08 Metal: Fix transform feedback with base instance Added TransformFeedbackTest.BaseInstance test case. Bug: angleproject:6963 Change-Id: Ie7b2a5dd2be456172505f07ea60ca291075bf07e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3536660 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kyle Piddington <kpiddington@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Ian Elliott fa5c349d 2022-03-23T17:27:54 Add "use_custom_libcxx = false" to "roll_aosp.sh" Per https://chromium-review.googlesource.com/c/chromium/src/+/3520025 the old gn arg "libcxx_abi_unstable" was removed, and we need to set "use_custom_libcxx = false" instead. This will hopefully fix the ANGLE->AOSP autoroller that was broken by the above CL. Bug: angleproject:7110 Change-Id: I3b6de998964efb674ea356a14e852f0e285b7242 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3546721 Reviewed-by: Ian Elliott <ianelliott@google.com> Auto-Submit: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shrek Shao 73ec28af 2022-03-23T21:13:45 Revert "Vulkan: Fix invalid access with display texture share group." This reverts commit 1099b5ef2279cfe1988a39c8e011aada59c650f1. Reason for revert: suspect culprit of 1309304 Original change's description: > Vulkan: Fix invalid access with display texture share group. > > Create bufferpool that owns by RendererVk. > If we are using EGL_ANGLE_display_texture_share_group > extension, use the bufferpool owned RendererVk, > otherwise, use the bufferpool owned by EGL::ShareGroup. > The bufferpool lifetime will remain consistent with > texture lifetime. > > Bug: chromium:1299211 > Change-Id: Ie4e87cea1dfd20dabab24e2afed6ddd92e469888 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3531155 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: chromium:1299211, 1309304 Change-Id: Ibdc119ef6bb52352858114d72a0f1c0edcd4da5e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3546288 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shrek Shao <shrekshao@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 09f55382 2022-03-23T10:01:53 Roll SwiftShader from 57eca9df5dc5 to ea9806003d9e (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/57eca9df5dc5..ea9806003d9e 2022-03-22 sugoi@google.com VK_EXT_private_data support 2022-03-22 sugoi@google.com VK_EXT_private_data promoted structures 2022-03-22 capn@google.com Stop skipping VK_STRUCTURE_TYPE_IMAGE_VIEW_MIN_LOD_CREATE_INFO_EXT 2022-03-22 ari.suonpaa@siru.fi Restore support for non-uniform indexing of InterpolateAt* input If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ia1220a06b24923afd30cafdd8af54f696625454f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3545367 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov b19e662a 2022-03-22T18:28:40 TransformFeedbackQueryPausedDrawThenResume flaky Suppression removed in crrev.com/c/3536652, but still flaky: https://ci.chromium.org/ui/p/angle/builders/ci/win-trace/1091/overview Bug: angleproject:6180 Change-Id: I447a173d9634c950debc3d4a16e9987ed360d522 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3542991 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0