Log

Author Commit Date CI Message
angle-autoroll 7bbd3224 2021-07-14T07:37:44 Roll Chromium from 624f8c7a15ff to 47358b0400b8 (511 revisions) https://chromium.googlesource.com/chromium/src.git/+log/624f8c7a15ff..47358b0400b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9c63d2e3b0..c8b96e2021 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/cb34896ebd..6803464b0f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d749d1b98b..70c4b1c859 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/329436118b..8c49b419c2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a67592355d * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f376b41126..dfbc590f58 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/aca9f71bde..9d0a403e85 * tools/luci-go: git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3..git_revision:8b8a9a6040ca6debd30694a71a99a1eac97d72fd * tools/luci-go: git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3..git_revision:8b8a9a6040ca6debd30694a71a99a1eac97d72fd * tools/luci-go: git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3..git_revision:8b8a9a6040ca6debd30694a71a99a1eac97d72fd * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1820a3adb0..9f08bce929 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6dad62e2eb..1f94e8277f * tools/skia_goldctl/linux: R0Jd4IlcndZlI5C9Pejy7DqtmVEQT8Sc6Ye09MGyFxYC..McKpb1_oys52qBLvSwGec9-adPkk72RTCSdOBnzZiakC * tools/skia_goldctl/mac: 5NoUEq08DuYUlQWnf2yj6rQvBtlMvWiDqfuUuE5nJFIC..Ea5khSEBtnBiIUjc8YOW1PTAiFTBzcSCJcQXyS_RcV8C * tools/skia_goldctl/win: M2_R9AXWaN0xmm6nz_nRzKlhpzzOp3P9EUxNaLZ5owMC..hrfC-m0pHo7gMu28Bdo4wR8Fnxk_GQkMcO9LyPNPThoC Clang version changed llvmorg-13-init-14732-g8a7b5ebf:llvmorg-13-init-15163-g98033fdc Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/aca9f71bde89a71cb8588f5d77868c612a163274..9d0a403e85d25b5b0d3016a342d4b83b12941fd5/scripts/update.py Bug: None Tbr: cnorthrop@google.com Change-Id: I4e4fd8a8207ae99ad7d2ba90a3584941e3ea6f42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3026068 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kenneth Russell 2534ee4c 2021-07-02T12:18:07 Limit the size of declared variables in WebGL shaders. Add an implementation-specific limit for the sizes of variables (specifically arrays, structs, and arrays of structs) in WebGL 1.0 and 2.0 shaders, and interface blocks in WebGL 2.0 shaders, no matter whether they're input, output, or local variables. It is legal in the OpenGL ES and OpenGL ES Shading Language specifications to fail to compile shaders for implementation-specific reasons. Add WebGLCompatibilityTests covering the new limit. Bug: chromium:1220237 Change-Id: I6c1d24a5d9a382ba4454c2dfbb856ab9468f5409 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3023033 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kenneth Russell 2a668d92 2021-07-13T16:49:16 Fix iOS Simulator build after direct-to-Metal upstreaming. Bug: angleproject:5505 Change-Id: I4e690099502be2f2404a25d67356d452cf63451b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3025240 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Qin Jiajia 15581f35 2021-07-13T15:01:56 Fix the INVALID_ENUM error This PR fixes the GL_INVALID_ENUM error caused by framebufferTexture2D in copySubTextureCPUReadback with TEXTURE_EXTERNAL_OES as the texture target. TEST conformance/textures/video/tex-2d-luminance_alpha-luminance_alpha-unsigned_byte.html conformance/textures/video/tex-2d-luminance-luminance-unsigned_byte.html conformance/textures/video/tex-2d-alpha-alpha-unsigned_byte.html conformance2/textures/video/tex-2d-srgb8-rgb-unsigned_byte.html conformance2/textures/video/tex-2d-rgb9_e5-rgb-float.html conformance2/textures/video/tex-2d-srgb8_alpha8-rgba-unsigned_byte.html conformance2/textures/video/tex-2d-rgb9_e5-rgb-half_float.html conformance2/textures/video/tex-2d-rgb16f-rgb-float.html conformance2/textures/video/tex-2d-rgb16f-rgb-half_float.html conformance2/textures/video/tex-2d-rgb32f-rgb-float.html Bug: chromium:1208297 Change-Id: Ic62ba95ad6fd70f293a7261dc640a95dcabe7ba2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3023666 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Kenneth Russell 4d9dbf9c 2021-07-13T15:23:30 Use "frameworks" rather than "libs" for iOS dependencies. The angle_test_expectations static library has added this dependency but it fails to build on the ios-simulator bot. Try using "frameworks" instead. Bug: angleproject:5505 Change-Id: Ia08240a042f241c7eefe0de730b6942a60047054 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3025238 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 4efcd10c 2021-07-13T15:37:43 Skip SourceYUVAHBTargetExternalRGBSampleInitData on Pixel4 Two new Vulkan validation errors are being triggered. Test: SourceYUVAHBTargetExternalRGBSampleInitData Bug: angleproject:6168 Change-Id: I11c86bcb8e47f0dbf8032652aae3988279478ace Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3025486 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jason Macnak 7c4404da 2021-07-09T13:37:29 Vulkan: update D/S state in ContextVk::onFramebufferChange ANGLE needs to ensure that the stencil test is correctly handled when framebuffers are cleared before stencil attachments are configured. Adds two stencil tests for clearing fbo before stencil attached which fail before this change and which replicate the behavior of CtsNativeHardwareTestCases's StencilAffectsDrawAcrossContexts. BUG=b/192315789 TEST=newly added tests on Cuttlefish Change-Id: I58d97af97d3f78787051b069d2594041ccd2bfba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3018486 Commit-Queue: Jason Macnak <natsu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jonah Ryan-Davis b202d5cf 2021-07-13T13:34:19 Suppress BlitFramebufferTest.MultisampleDepth on Metal This test is failing on Intel as well, expand the suppression. Bug: chromium:1228433 Bug: angleproject:5505 Change-Id: I98e240897b996d5d8d9a5977ef777f928b25c9dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3024591 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Tim Van Patten 16a9a892 2021-07-12T15:30:57 Cleanup license data and remove Android.mk files In an effort to better satisfy the Android legal/license requirements: 1.) Cleanup the license data in the generated Android.bp. 2.) Remove unused Android.mk files. Bug: b/191882454 Change-Id: Ia1937c1e2e822e688cca2a4d3ebc9a294f67ad69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3021851 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Cody Northrop 634d156f 2021-07-08T12:42:21 TracePerfTests: Add ScreenShotFrame option Allows the user to specify a frame to capture instead of defaulting to the first one. Usage: --screenshot-frame <frame> Bug: angleproject:4615 Change-Id: I000ee17aa9b3019188816aa6203f3266b39155b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3016356 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jonah Ryan-Davis 428d7c4d 2021-07-12T15:23:45 GL: Widen scope of disable_sync_control_support workaround. Crashes and hangs are still happening on Linux/Intel/Mesa 20. This should already not expose the OML_sync_control extension, so widen the scope of the workaround to see if there is an issue detecting Mesa version. Bug: chromium:1187475 Change-Id: I6397f459cd58dba449913ef1c7ce897e8a06cbd1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3022222 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll 783c2f93 2021-07-13T08:27:44 Roll Chromium from 7d1a6713a379 to 624f8c7a15ff (526 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7d1a6713a379..624f8c7a15ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/70f58488ed..9c63d2e3b0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e065358b5a..d749d1b98b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3345f09ed6 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/199485df6c..f376b41126 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3fa819890a..aca9f71bde * tools/luci-go: git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86..git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3 * tools/luci-go: git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86..git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3 * tools/luci-go: git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86..git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/783612b47d..1820a3adb0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/511dbaffd9..6dad62e2eb * tools/skia_goldctl/linux: tu1vY2W9BQ6Wx0o3zk5oqBwnr5rfFQGiaztbTpGiRNgC..R0Jd4IlcndZlI5C9Pejy7DqtmVEQT8Sc6Ye09MGyFxYC * tools/skia_goldctl/mac: DPVSayDIq4ga78XaXXcfTzeTE2v33yM8z1w-eaD-ZuQC..5NoUEq08DuYUlQWnf2yj6rQvBtlMvWiDqfuUuE5nJFIC * tools/skia_goldctl/win: HMJwTrgrkRmSqDuyQtWly6YxYSHJXsM6zQJFLkojAVwC..M2_R9AXWaN0xmm6nz_nRzKlhpzzOp3P9EUxNaLZ5owMC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ie14d842df225cfc1f60d087386147904a8120ae4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3023670 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peng Huang a8e98a23 2021-07-10T15:25:20 Fix gl::Context::unMakeCurrent crashes The crash is because Display::makeCurrent() may fail, in that case, egl_stubs.cpp will not update the current context in global_state and Thread accordingly. And then Context::refCount could be reach 0, and be released, however egl_stubs.cpp still thinks the context is current, and then user-after-free happens. This CL fixes the problem by updating current context of Thread in Display::makeCurrent, and reading the current context of Thread in egl_stubs.cpp and setting it to global_state. Bug: chromium:1171371 Change-Id: Ifc5fffb0e4902c9c72514839d03e5783d50fe283 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3017210 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Jonah Ryan-Davis 36eb2f14 2021-07-12T15:21:33 Metal: Populate feature list in the Metal backend. The metal-specific features were not being populated when features were queried (eg. by Chrome's about::gpu page). Only the frontend features were populated. Bug: angleproject:6161 Change-Id: I65703dfb5cf561d734b3698da66a8838187b0ef4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3022221 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill 9274911d 2021-07-12T10:41:16 Vulkan: Update cube map array support check. Bug: angleproject:5143 Change-Id: I0b774096ae762ae088a27ef1b4d52bf446562736 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3021283 Reviewed-by: Nicolas Capens <nicolascapens@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Kyle Piddington d33a2222 2021-04-26T16:56:15 Upstream Apple's direct-to-Metal backend: compile libANGLE. This change is meant to merge the metal backend changes from Apple's direct-to-Metal backend. Taken from Kyle Piddington's CL: https://chromium-review.googlesource.com/c/angle/angle/+/2857366/ The goal of this CL is to merge the metal backend code in a state that compiles, but not to switch the Metal backend over to using the direct-to-metal backend yet. Bug: angleproject:5505 Bug: angleproject:6127 Change-Id: If6783e06e0086b3a1dd25c6f53caca5cfc96cb86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950067 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll b7cfbac4 2021-07-12T10:01:00 Roll SwiftShader from 65498c15ca60 to 4716eec90fcb (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/65498c15ca60..4716eec90fcb 2021-07-09 thakis@chromium.org Stop building with -fno-operator-names 2021-07-09 thakis@chromium.org Stop defining _WINDLL 2021-07-09 thakis@chromium.org Remove workaround for 32-bit gold ICF bug If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I71d6929e0f58b3e48f9a45112e4094e2d53993d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3020289 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a7d8f8cd 2021-07-12T07:00:51 Roll Chromium from e09623df2fbf to 7d1a6713a379 (478 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e09623df2fbf..7d1a6713a379 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9d1af1fefb..70f58488ed * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e1152a2ffc..e065358b5a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..f691b8d997 * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/b7bef8c05b..e9e400e0af * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2c35569e9f..3fa819890a * tools/luci-go: git_revision:6808332cfd84a07aeefa906674273fc762510c8c..git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86 * tools/luci-go: git_revision:6808332cfd84a07aeefa906674273fc762510c8c..git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86 * tools/luci-go: git_revision:6808332cfd84a07aeefa906674273fc762510c8c..git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0039c5300b..511dbaffd9 * tools/skia_goldctl/linux: gyVsF3sYTmaXRfH5ZxgrkitNlEIMmcqWZBcixfrfJ30C..tu1vY2W9BQ6Wx0o3zk5oqBwnr5rfFQGiaztbTpGiRNgC * tools/skia_goldctl/mac: b-Qs2BgADASerBkyWLb2sUtPJBkhTpZQJNAwASkgrmcC..DPVSayDIq4ga78XaXXcfTzeTE2v33yM8z1w-eaD-ZuQC * tools/skia_goldctl/win: qrVPZODzWaMfj0T74i2cbqiMzFoqTbUk01Xft2ZTSRMC..HMJwTrgrkRmSqDuyQtWly6YxYSHJXsM6zQJFLkojAVwC No update to Clang. Bug: angleproject:5505 Tbr: timvp@google.com Change-Id: I3c077b02c889b5a1d02a8fb15fb4c4682b9a0eae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3020444 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peter Kasting 04cb5e1d 2021-07-10T11:39:49 Disable -Wimplicit-int-float-conversion for gles1_conform. Bug: chromium:989932 Change-Id: I0038440470a6816bb0c4198af2224b7b85aa42b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3018692 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c6784c9c 2021-07-09T16:48:55 Vulkan: SPIR-V Gen: Fix size of matrix in std140 layout Matrices are treated like arrays, so the size of each column should also be expanded to the size of vec4, similar to how it's done for arrays of smaller-than-vec4 elements. Bug: angleproject:4889 Change-Id: I1f4d8d0e06922c4bb9261fbbf0f4565dfdec55c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3018641 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll c9a66d2c 2021-07-09T15:07:49 Roll VK-GL-CTS from 875c981f4c59 to 6b9a0f391fa4 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/875c981f4c59..6b9a0f391fa4 2021-07-08 rgarcia@igalia.com Check required extension core versions 2021-07-08 rgarcia@igalia.com Test more dynamic vertex input variants 2021-07-08 rgarcia@igalia.com Improve tests checking sign extension with images 2021-07-06 alexander.galazin@arm.com Update Vulkan headers 2021-07-02 michal.jakubek@mobica.com Update bottom AS's addresses during top AS deserialization If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC timvp@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com,angle-bots+autoroll-info@google.com Change-Id: I3a81408cebcfc749790ec444ffd69356749fbf2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3017197 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi e2710f59 2021-07-06T17:29:08 Vulkan: SPIR-V Gen: Fix image atomic built-ins The `imageAtomic*` built-ins additionally include coordinate and sample parameters that need to be fed to OpImageTexelPointer before the atomic operation can be generated. This change passes all *image*atomic* GLES31 deqp tests as well as: GLSLTest_ES31.ArraysOfArraysOfR32fImages/ES3_1_Vulkan_DirectSPIRVGen Bug: angleproject:4889 Change-Id: I9ed729d09914cb01467d4de504de38c931a9196e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3011419 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 8d0eb08c 2021-07-05T23:22:24 Vulkan: SPIR-V Gen: Take advantage of OpConstantNull As part of fixing GLSLTest*.MissingReturn* tests, refactoring is done such that complex null values are declared concisely with OpConstantNull. The tests are fixed by making the SPIR-V generator implicitly add a `return <null-value-of-correct-type>;` if the return statement is missing from GLSL. Bug: angleproject:4889 Change-Id: Iffd80c5e6ce66afcdbf3813bffade6928f292007 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010578 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten a34f668d 2021-07-09T10:55:48 Skip BlitWithDepthUserToDefault for Linux+Intel+OpenGL The test BlitFramebufferANGLETest.BlitWithDepthUserToDefault/ES2_OpenGL is failing on Linux+Intel. This CL skips the test to unblock the vulkan-deps roll into Chromium. Bug: angleproject:6154 Change-Id: I098622ca23b79027e6166d3308c3c41948eca285 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3018109 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Tim Van Patten aa727b78 2021-07-09T11:26:36 Skip ImageTests generating VUID-vkCmdDraw-None-02699 The latest VVL roll is generating VUID-vkCmdDraw-None-02699 on Pixel 4 devices. This CL will skip the failing tests to unblock the roll while the VVL error is investigated. Bug: angleproject:6155 Change-Id: Ie9e21f7df13baa8b9252a3273d1985513404bdfe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3018114 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill 3a6e22d5 2021-07-09T12:09:53 Trace Tests: Update retracing script. Adds an option to skip retracing traces that already exist. That makes the script much easier to use on folders that already have traces partially retraced. It also catches exceptions when running the traces so that ANGLE crashes and ASSERTions don't need you to restart the retrace. Bug: angleproject:5133 Change-Id: I059ca545145eadc1aa8c373a2fde762bbeb52b55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3018302 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 8c07f3c1 2021-07-09T12:35:31 Enable cube map arrays on SwiftShader. Bug: angleproject:5142 Change-Id: I51c58d20da155b90980f27425a99cff2555345fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3018303 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi e3e7447a 2021-07-08T22:22:19 Vulkan: Fix flipXY for 180 degree prerotation and spec consts The multiplier used for flipXY in this configuration was incorrect. Bug: angleproject:5348 Bug: angleproject:5349 Bug: angleproject:5350 Change-Id: I0b3771f6a9da6ab2af02ed5ee5fe7b49d0415410 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3016768 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 913eb916 2021-06-28T12:51:12 Vulkan: (Mostly) re-unify secondary command buffer interfaces SecondaryCommandBuffer and CommandBuffer in vk_wrapper had diverged in API, which this change helps alleviate to some extent. Bug: angleproject:6100 Change-Id: I0d59b24c659afbaf58865b3d85f275c545e3acce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2987872 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
angle-autoroll 6d46bf71 2021-07-09T10:01:00 Roll SwiftShader from 9534228df856 to 65498c15ca60 (11 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/9534228df856..65498c15ca60 2021-07-09 thakis@chromium.org Remove -Wno-error flags 2021-07-09 thakis@chromium.org Remove now-unused gni imports 2021-07-09 thakis@chromium.org Remove x86/x64-specific arch flags 2021-07-08 thakis@chromium.org Try to unbreak build after https://swiftshader-review.googlesource.com/c/SwiftShader/+/55608 2021-07-08 thakis@chromium.org Remove mips-specific arch flags 2021-07-08 thakis@chromium.org Share ANGLE_DISABLE_TRACE-setting code between win and non-win 2021-07-08 thakis@chromium.org Stop passing -fomit-frame-pointers in swiftshader build file 2021-07-08 thakis@chromium.org Remove sysroot and mmacosx-version-min flag for mac/arm builds 2021-07-08 thakis@chromium.org Remove explicit -msse2 flags (and some other minor things) 2021-07-08 thakis@chromium.org Remove unnecessary flags from BUILD.gn 2021-07-08 capn@google.com Delete the legacy OpenGL ES build for Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Id94e37160fd9400500d6c946ece5f5adbd50e0a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3016020 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fd604937 2021-07-09T07:00:23 Roll Chromium from 8b6aa9a9bcc2 to e09623df2fbf (441 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8b6aa9a9bcc2..e09623df2fbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/27e956c028..9d1af1fefb * buildtools/linux64: git_revision:31f2bba8aafa8015ca5761100a21f17c2d741062..git_revision:24e2f7df92641de0351a96096fb2c490b2436bb8 * buildtools/mac: git_revision:31f2bba8aafa8015ca5761100a21f17c2d741062..git_revision:24e2f7df92641de0351a96096fb2c490b2436bb8 * buildtools/win: git_revision:31f2bba8aafa8015ca5761100a21f17c2d741062..git_revision:24e2f7df92641de0351a96096fb2c490b2436bb8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7a41b10cc1..e1152a2ffc * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e397699bcd * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/f4241bd0f2..7cf9863263 * third_party/r8: gXyBDv_fM87KnLcxvF5AGV5lwnm-JXIALYH8zrzdoaMC..Nu_mvQJe34CotIXadFlA3w732CJ9EvQGuVs4udcZedAC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/293314acab..2c35569e9f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/95d98b6900..783612b47d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c3d86f5268..0039c5300b No update to Clang. Bug: angleproject:6127 Tbr: timvp@google.com Change-Id: I10606038a0319d675a1ddfc205b9ef3d4ebfbce5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3016365 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Qin Jiajia 17a4b6e7 2021-07-07T11:00:48 Fix that clear-srgb-color-buffer is not correct This change removes the limitation that syncClearState/ syncClearBufferState is only for STANDARD_GL_DESKTOP so that it works on chromeos. Test: conformance2/rendering/clear-srgb-color-buffer.html deqp/functional/gles3/fbocolorbuffer/clear.html Bug: chromium:1208297 Change-Id: I7c5fed3545f623cca3f2245c67fddaf3401388b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010630 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Sergey Ulanov b73eee71 2021-07-07T18:51:35 Reland: [Vulkan] Add DisplayVkNull Currently all DisplayVk implementations depend on VK_KHR_swapchain and VK_KHR_surface extensions. When running Chromium on Fuchsia these extensions are never used (content is shown on the screen using ImagePipe API without dependency on swapchain). ANGLE still depended on these extensions for DisplayVkFuchsia. This CL adds DisplayVkNull, which allows to run ANGLE without dependency on swapchain. It's usable only offscreen and cannot present content on a surface. Bug: chromium:1203879 Change-Id: I5cadcdf46ed1cfb5ebb3cb69dbfef063e9e2b826 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3012368 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 89f2a619 2021-07-08T21:45:11 Revert "GL: Use glClear for robust init on Android." This reverts commit 37c5d36fef783406c30a8ed8b8b4455f35374834. Reason for revert: crashes on Pixel 4, see https://chromium-review.googlesource.com/c/chromium/src/+/3016164 Original change's description: > GL: Use glClear for robust init on Android. > > The allowClearForRobustResourceInit was used to work around driver > bugs on other Windows and Linux and has a lot of CPU overhead. > > Re-enable it on Android (except some older Adreno). > > Bug: chromium:983167 > Change-Id: Ibfb4eb4fcdc7310fb6181c57f5c8d7a645ffad9d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3011420 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: chromium:983167 Change-Id: I74e9a61484de77fd66e8dde8d50665fdbb470a95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3016763 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 81ed8d40 2021-07-02T00:54:25 Vulkan: SPIR-V Gen: Support barrier* built-ins This change enables the ComputeShaderTest suite and additionally includes the following fixes: - OpArrayLength was given the array type instead of variable. - Struct arrays inside interface blocks were not decorated with ArrayStride. Bug: angleproject:4889 Change-Id: Ibae95371bcea10e58c86b8fe1d1e172a18d56a09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3001908 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill dc2d76cd 2021-07-08T10:04:15 Trace Tests: Clean up mock ICD skip condition. Bug: angleproject:6090 Change-Id: I943eb35da56a24c5a2c9961eb458b9b6e27ea83a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3015515 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 62398e82 2021-07-08T14:06:04 Capture/Replay: Fix missing rpath on Linux. This was causing the test script to fail to find angleutil. Bug: angleproject:5133 Change-Id: I621da4e71c0b61161694d95263b7dad643a728ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3015516 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi afdf378f 2021-07-01T21:55:58 Vulkan: SPIR-V Gen: Support == and != on complex types In GLSL, == and != produce a bool. In SPIR-V, there are only component-wise comparison operations. For ==, OpAll should be used to reduce it to a single bool, and for !=, OpAny. For matrices, the comparison is done column by column with a similar reduction for each column, and one for the final result. For structs and arrays, the comparison is similarly done field by field or element by element respectively. Bug: angleproject:4889 Change-Id: I8157c1931b7d1dedd74a3825967f5e212d346900 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3001905 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Aditya Kushwah c9dcc553 2021-06-22T18:55:39 Move Objectlabel from Texture object to TextureState object. Created a subscriber function onLabelUpdated in the storage base class. The derived storage class will pass the label reference to the base storage class in the constructor. Future changes will use this label reference to update the label string with D3D. Bug: chromium:1164111 Change-Id: Ic5ca73bac61427afe392bb5bcc6a6eab8e785941 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2981451 Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Jamie Madill cb87d78c 2021-07-08T08:28:04 Enable -Wshadow with Clang. Also fixes a few instances of variable shadowing in the code. Bug: angleproject:6148 Change-Id: Ic51d722a3f953f246f51af6d74abb302f832cf44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3014875 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny 54ade715 2021-06-29T11:40:37 Enable passing tests out of BlitFramebufferANGLETest.*/* Bug: None Change-Id: I680f22bdc18af84547dcc51491923b0662e2b389 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2987993 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0e1ed36c 2021-07-02T12:32:03 Trace Tests: Improve state serialization. This encapsulates several colliding states into grouped scopes. It also improves serialization of several of the resources by including the resource ID in the serialization key. Also other minor improvements. This change should improve detection of state mis-management. Bug: angleproject:5133 Change-Id: I6ee5c02bb3ba70e91a595db2408076b15e4a9e67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3003384 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 68d4e392 2021-07-02T14:18:54 Trace Tests: Add option for ASAN builds. ASAN builds can detect OOB memory accesses. This is very useful for diagnosing some kinds of flaky OOB crashes. Removes a test that was calling BufferSubData with a null data argument. This behaviour is undefined and we shouldn't be testing it. Also includes some minor refactorings and script changes. Bug: angleproject:5133 Change-Id: I5a7d9a5500c50a51f6369e944a5f0a533709f00d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3002510 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll f7c3c5b6 2021-07-08T10:01:00 Roll SwiftShader from 3c89f07b349b to 9534228df856 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/3c89f07b349b..9534228df856 2021-07-07 capn@google.com Eliminate Subzero sandboxing support 2021-07-07 capn@google.com Assume Microsoft ABI on Windows 2021-07-07 capn@google.com Eliminate support for the PNaCl ABI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ifd9886fd875daf9ddd5d323d2ef6356b37e31f56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3012943 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e9f0daa1 2021-07-08T10:01:19 Roll vulkan-deps from cda66075b3f4 to 015a6f8b338d (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/cda66075b3f4..015a6f8b338d Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/ae2a562936..9e707294f1 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/697cc6c387..8b86fbac17 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/394157ab51..f2912cd0f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Iebd455a306a409d2d9e05906aeafc1ffee822183 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3013456 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 2c22e080 2021-06-28T10:43:47 Capture/Replay: Enable SRGBFramebufferTest.Validation/* The test passes now. Bug: None Change-Id: I789f8fac225c42414bc8cc342138e1fd70a7f745 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988684 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 5fb5f63b 2021-06-29T09:56:43 Capture: Write captured context for empty frames When a frame is empty, still write the captured context for that frame because the index file will contain the frame file, and the replay will execute the according swapbuffer so that the replay will query the context serialization when testing trace correctness. With that enable RobustResourceInitTest.SurfaceInitializedAfterSwap/* for capture/replay. Bug: angleproject:5939 Change-Id: Ib280d55f739cc2bb8d2da0919e98c37a2cd576ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2987991 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 08946bee 2021-07-08T07:00:20 Roll Chromium from 7c193479c917 to 8b6aa9a9bcc2 (411 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7c193479c917..8b6aa9a9bcc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/04f716686d..27e956c028 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fd3f3c1998..2500c1d8f3 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/8fa8794677..79a2e924d9 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d87a06daa9..cb34896ebd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/57a831388b..7a41b10cc1 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/173d8869cf..3a5a816917 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..096f6b42b5 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/00ade15d94..199485df6c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ccc7ba229a..293314acab * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/116022c2e3..c3d86f5268 Clang version changed llvmorg-13-init-14634-gf814cd74:llvmorg-13-init-14732-g8a7b5ebf Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/ccc7ba229ab7e050d8276a442cf1f9ad25c846cc..293314acabd2beeb271e67c1cdd11664db9c2881/scripts/update.py Bug: angleproject:5505 Tbr: timvp@google.com Change-Id: I9d067fac37b5b64d150f646166f357ec9b11b429 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3013455 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5718b0c9 2021-07-07T16:19:19 Roll vulkan-deps from 6dda7d6b86d6 to cda66075b3f4 (43 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6dda7d6b86d6..cda66075b3f4 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/9cdeefb5e3..1ae2b58f19 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/f95c3b3761..ddf3230c14 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8cc8b6562b..c26baf4c93 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/37164a5726..0193e158bc * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/8926213dd0..697cc6c387 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c09be02a36..394157ab51 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com,ynovikov@google.com Change-Id: Ia0c6220963851caa505ad871b08afbe0639880c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010682 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Gert Wollny 4964513a 2021-06-28T20:07:46 ANGLETest: When on WebGL compatibility then use index buffers WebGL actually requires the use of index buffers, otherwise the call is invalid, therefore explicitely request index buffers in the according VertexAttributeOORTest tests. In addition, assert on the indices when the glDrawElements call is captured. With that we can enable VertexAttributeOORTest.* Bug: angleproject:6125 Change-Id: Id3855c78d4c5fcab5599f19dd74ce745d059fb1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2999523 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 2c8391b1 2021-06-28T17:53:10 Capture/Replay: Enable passing tests, disable flaky Tests now passing: UnpackAlignmentTest.* UnpackRowLengthTest.* VertexAttributeCachingTest.* ViewportTest.* These tests start to fail when run in the new batch layout triggered by the new passing tests: WebGLCompatibilityTest. DrawElementsBufferOutOfBoundsInIndexBuffer/ DrawElementsBufferOutOfBoundsInVertexBuffer/ ES2_Vulkan_SwiftShader Bug: None Change-Id: I4902f2eca864ca8b371d915c89487943af54bc89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2987989 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 68d9f433 2021-06-28T15:39:04 Capture/Replay: capture param of glGetQueryiv Enable TimerQueriesTest.* with that. Add flaky test WebGLCompatibilityTest. DrawElementsBufferOutOfBoundsInVertexBuffer/ ES2_Vulkan_SwiftShader that start to fail because the batches have changed. Bug: angleproject:6114 Bug: angleproject:6136 Change-Id: I91617255a8e3e8783c8e70c17dedd32be421fd66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993092 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 4b464dd4 2021-06-28T14:50:22 tests: Skip WebGL/EnableProgramBinaryExtension with no formats If the extensions is exposed, but the backend doesn't support binary formats, then the part of the tests loading and storing a binary shader are skipped. With that also Capture/Replay of the test is fixed. Bug: angleproject:6112 Change-Id: Iaa25860a9be69207e4dbd6213cf77e75fd87a766 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993090 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny b3e920e2 2021-06-28T14:32:13 Capture/Replay: don't capture DrawElements with count zero Usually Context::noopDraw would reject calls that doen't draw, but FrameCapture::maybeCaptureDrawElementsClientData seems to be called before Context::noopDraw, and since in ComputeTypedIndexRange we would obtain the illegal range [0,0) (which is actually prohibited by an ssertion "count > 0"), we have to exit early. With that the test can be enabled. Bug: angleproject:6111 Change-Id: I4c242712bd90602f84ad6072b02c3a13a26840f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993089 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Trevor David Black 5d314b59 2021-06-01T03:03:22 Fix undefined behavior associated with Runescape Mobile Bug: b/184287970 Change-Id: I5d3baf5e7a8a20c30e1b787b69597110226521d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2929352 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Geoff Lang 37c5d36f 2021-07-07T13:15:13 GL: Use glClear for robust init on Android. The allowClearForRobustResourceInit was used to work around driver bugs on other Windows and Linux and has a lot of CPU overhead. Re-enable it on Android (except some older Adreno). Bug: chromium:983167 Change-Id: Ibfb4eb4fcdc7310fb6181c57f5c8d7a645ffad9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3011420 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 396518e0 2021-07-07T15:34:43 Skip SamplerMetadataUpdateOnSetProgram on Mac Metal Blocking vulkan-deps roll. Bug: chromium:1227129 Change-Id: Iaa7f4d18e80b8353dc0be001e1d2e229196f3186 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010469 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
SeongHwan Park 9f256d10 2021-07-07T02:14:13 D3D11: Fix incorrect bounds checking in Blit11 This could lead to blitting depthStencil buffer incorrectly. Bug: angleproject:6140 Change-Id: I2c5786c0375f8e2fefe862da68929340844ce9ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3009736 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Alexis Hetu daa19c0a 2021-07-06T16:19:57 Fix alpha setting of WebGL contexts with SwANGLE on MacOS The emulation of the "alpha: false" setting was done with an RGBA format under the hood, which caused some unexpected results, which included non constant alpha values. Replacing GL_BGRA8_EXT with GL_BGRX8_ANGLEX solves this issue. This was discovered while debugging the following test: conformance/context/context-no-alpha-fbo-with-alpha.html but it may fix many other tests (I will update the expectations file after this fix rolls into Chromium) Bug: chromium:1099960 Change-Id: Ib7b2d352a8e920983d3398de28a8c1dde3b97130 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010579 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
angle-autoroll 19ea3d11 2021-07-07T10:01:00 Roll SwiftShader from 6f1260556b10 to 3c89f07b349b (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/6f1260556b10..3c89f07b349b 2021-07-06 srisser@google.com Replace curl command with git-hooks submodule 2021-07-06 capn@google.com Clarify contributing documentation for Windows users 2021-07-06 capn@google.com Fix -Wundefined-var-template warnings for ARM32 and MIPS32 2021-07-06 capn@google.com Define constant static template members as constexpr 2021-07-06 capn@google.com Make Subzero opcode pointer constant If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I82b48672e7476512422fe79466e7a273e50ca902 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010757 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 55746d13 2021-07-07T08:09:02 Roll Chromium from 1d5cc5e25281 to 7c193479c917 (278 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1d5cc5e25281..7c193479c917 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/92f8e1efea..04f716686d * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ae0481e55f..d87a06daa9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7ec8dcae8b..57a831388b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..096f6b42b5 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/081034a4ff..ccc7ba229a * tools/luci-go: git_revision:40f945205c8670537d14901c310374774f589254..git_revision:6808332cfd84a07aeefa906674273fc762510c8c * tools/luci-go: git_revision:40f945205c8670537d14901c310374774f589254..git_revision:6808332cfd84a07aeefa906674273fc762510c8c * tools/luci-go: git_revision:40f945205c8670537d14901c310374774f589254..git_revision:6808332cfd84a07aeefa906674273fc762510c8c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/02ac209364..95d98b6900 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2904cc4e6d..116022c2e3 * tools/skia_goldctl/linux: CyXSNty61zPEJfx8gghQIiNd-4sZL4u-Py3wKKiSThcC..gyVsF3sYTmaXRfH5ZxgrkitNlEIMmcqWZBcixfrfJ30C * tools/skia_goldctl/mac: 4ighzAwClyw2f7qzLc7vNBeEyyur8GGNNt7d1d32IvQC..b-Qs2BgADASerBkyWLb2sUtPJBkhTpZQJNAwASkgrmcC * tools/skia_goldctl/win: 9c1KMLUktX61ANQhF4IrBQchPmmj73ZqzJi74TiKn_sC..qrVPZODzWaMfj0T74i2cbqiMzFoqTbUk01Xft2ZTSRMC Clang version changed llvmorg-13-init-14563-gbcaf57ca:llvmorg-13-init-14634-gf814cd74 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/081034a4ff0462c46b9261be81de77562d19936e..ccc7ba229ab7e050d8276a442cf1f9ad25c846cc/scripts/update.py Bug: None Tbr: timvp@google.com Change-Id: I76274f4412baf19a183d894ba4a6390ebfbd738b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010680 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 51937ab3 2021-06-25T09:10:42 Re-land "Add SearchType to OpenSharedLibraryWithExtension." This fixes a bug in SystemInfo_vulkan where we were using the System search path for the Vulkan loader when we prefer using the custom ANGLE loader. Re-land fixes a bug where we would try to load the custom libVulkan on Android and other platforms where we should be using the system version. Bug: chromium:1219969 Change-Id: I34b592fb87cbddfd02c837a17942cac54c85d9d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007265 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi cfaaf2ab 2021-06-30T17:23:55 Vulkan: SPIR-V Gen: Fixes to std430 block definition Bug: angleproject:4889 Change-Id: I18feff0916f348c8514cc97ba438d42fc00d0cba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2999023 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Takuto Ikuta d91af7b8 2021-07-06T12:17:33 infra/config: remove unused isolated property angle is migrated to RBE-CAS from isolate. Bug: chromium:1224266 Change-Id: Id2ca778edf6b34f5241da0fbfcd86b43941f83b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007600 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 7455507e 2021-07-06T10:01:00 Roll SwiftShader from 69deca60e70d to 6f1260556b10 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/69deca60e70d..6f1260556b10 2021-07-05 capn@google.com Fix -Wundefined-var-template warnings 2021-07-05 capn@google.com Regres: Increase MaxProcMemory to 6 GiB If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I3b7d0c7922b5b7cf5ec55765185b5e3a1be48b47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007076 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b6f0faa8 2021-07-06T07:01:02 Roll Chromium from 38c67803c283 to 1d5cc5e25281 (194 revisions) https://chromium.googlesource.com/chromium/src.git/+log/38c67803c283..1d5cc5e25281 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6f773f2fd2..92f8e1efea * buildtools/linux64: git_revision:4d207c94eab41f09c9a8505eb47f3d2919e47943..git_revision:31f2bba8aafa8015ca5761100a21f17c2d741062 * buildtools/mac: git_revision:4d207c94eab41f09c9a8505eb47f3d2919e47943..git_revision:31f2bba8aafa8015ca5761100a21f17c2d741062 * buildtools/win: git_revision:4d207c94eab41f09c9a8505eb47f3d2919e47943..git_revision:31f2bba8aafa8015ca5761100a21f17c2d741062 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/537028df55..7ec8dcae8b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..de5768d311 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e1e56a5807..081034a4ff * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8eae38b597..2904cc4e6d Clang version changed llvmorg-13-init-14086-ge1b8fde1:llvmorg-13-init-14563-gbcaf57ca Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/e1e56a58075d9d3ee55a86be0ed2e87be317968a..081034a4ff0462c46b9261be81de77562d19936e/scripts/update.py Bug: None Tbr: timvp@google.com Change-Id: I7f8f56e0672cf2bc5973d983ffef0309e9b96d4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007567 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 3b0fcf6a 2021-06-30T15:14:48 Vulkan: SPIR-V Gen: Support type casts in constructors GLSL basic, vector and matrix constructors can convert between types. This was already done for constants used in constructors. This change implements the cast for non-constant expressions. Bug: angleproject:4889 Change-Id: I0a8c1a6e97ffced0d1652032a41fb87c70be16ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2999022 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 0fa2e7f9 2021-07-06T02:09:20 Roll vulkan-deps from e0136f0880da to 6dda7d6b86d6 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e0136f0880da..6dda7d6b86d6 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e065c482c6..8cc8b6562b * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/16266c3883..c09be02a36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: timvp@google.com,ynovikov@google.com Change-Id: I8e1e0ec1d35000dffa33c8bb59835f8b6911458a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3006477 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov f8d5d5ed 2021-07-05T21:11:23 Revert "Add SearchType to OpenSharedLibraryWithExtension." This reverts commit 18e99f4a2b37468b103da4a56c5b0fff25458062. Reason for revert: breaks Mac, e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/mac-arm64-rel-tests/2197/overview Original change's description: > Add SearchType to OpenSharedLibraryWithExtension. > > This fixes a bug in SystemInfo_vulkan where we were using the > System search path for the Vulkan loader when we prefer using the > custom ANGLE loader. > > Bug: chromium:1219969 > Change-Id: Iedf0fd11fe9ed8cc020b445ea9e12a7936937361 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988791 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: chromium:1219969, chromium:1225040, chromium:1226675 Change-Id: I7a7e329181b69b0fb546e5245d8842723077126f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3006320 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 0beafe86 2021-07-05T16:12:10 Ignore VUID-VkSpecializationMapEntry-constantID-00776 New check added in https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/2903 Blocks VVL rolls. Bug: chromium:1226682 Change-Id: Iaf12187c33a0c3736acae6e772277dbe6aa4c402 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007137 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 0461d8d4 2021-06-23T23:20:33 Vulkan: SPIR-V Gen: texture and image built-ins GLSL contains a large number of built-in texture* and image* functions, but these map to only a handful of SPIR-V instructions. The bulk of the work to map these is to extract the arguments from the built-ins based on their ordinal position. Bug: angleproject:4889 Change-Id: I760d986bd9171ddde35f9f046c549ca53252df17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2992980 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill d665593b 2021-07-05T15:02:11 Update TextureState::getEnabledLevelCount. Instead of simply returning a count of all non-empty texture desc levels, we iterate the levels from the base level and return the count of levels that make a consistent mip chain. This will fix edge cases where Textures are defined sequentially with inconsistent mip levels, but valid rendering states. Bug: angleproject:4780 Change-Id: Id3ebf2d7ad706070896cb5cdf2a311dba2c88949 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007135 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 955b4620 2021-07-01T22:55:59 Fix angle_commit.h dependency when git packs refs If there are too many files in .git/refs/heads/, git packs them in .git/packed-refs. This breaks the build as gen/angle/angle_commit.h depends on .git/refs/heads/<branch-name>. With this change, when gn is run and the dependency to this file is set up, it's unpacked from .git/packed-refs if it's missing from .git/refs/heads/. One corner case not solved by this change is if a commit is amended with no changes and git packs the refs (and so the .git/refs/heads/<branch-name> file goes away), ninja doesn't rerun gn as it doesn't believe there to be any changes, yet fails the build as the dependency is now missing. Running `gn gen` manually fixes the issue. The issue is automatically fixed when switching branches. Bug: angleproject:6131 Change-Id: Ie2404e874a5cb3374a652b93faa143acb68eaa19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3001906 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 73792a63 2021-07-05T09:38:02 Roll Chromium from 3406cb648bea to 38c67803c283 (515 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3406cb648bea..38c67803c283 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/765bbc94ea..6f773f2fd2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/aa6d8cbd3e..537028df55 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..de5768d311 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5633839bd5..e1e56a5807 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/43c036ca86..02ac209364 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1e130552d4..8eae38b597 * tools/skia_goldctl/linux: yGEFrRQrT0GK0GqIKxNRbT092eKdKLQsfsDEAeHNUz0C..CyXSNty61zPEJfx8gghQIiNd-4sZL4u-Py3wKKiSThcC No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Ia86ec18356af1df6d62e1af39eb65ce1a48de888 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3005676 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 236fe4ad 2021-07-05T10:01:00 Roll SwiftShader from 314508f788b2 to 69deca60e70d (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/314508f788b2..69deca60e70d 2021-07-02 jerumble@gmail.com Fix gcc < 9 builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I7f4fa82dd6ddc347472553d6cc26d8d00f931ce6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3005639 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peter Kasting 1bffabe8 2021-06-29T18:13:39 Fix -Wunreachable-code-aggressive. Bug: chromium:1066980 Change-Id: I1fa08a40dbf223d60a10681af33ca8a29b12bf8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2991094 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 16c993c3 2021-06-24T12:03:03 Capture/Replay: Only capture initialized renderbuffer content Enable the DepthStencilTest.* that was failing before. Bug: angleproject:6094 Change-Id: I8c69de4927c0e70143cd632e97f0abdb740a013f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2982550 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll e78b1bf1 2021-07-02T10:19:48 Roll VK-GL-CTS from 5e375439542a to 875c981f4c59 (9 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/5e375439542a..875c981f4c59 2021-07-01 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master 2021-07-01 michal.jakubek@mobica.com Handle vkGetDeviceAccelerationStructureCompabilityKHR function. 2021-07-01 gleese@broadcom.com Drop subgroup size requirement for uniform control 2021-07-01 siglesias@igalia.com Check support for triangle fan primitive topology on rasterization tests 2021-07-01 boris.zanin@mobica.com Revert initial layout for depth/stencil attachment in makeRenderPass 2021-07-01 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2021-07-01 piotr.byszewski@mobica.com Fix compilation issue in float_controls 2021-07-01 jari.komppa@siru.fi Add sample decorator to interpolation tests 2021-06-30 jajones@nvidia.com Add VK_EXT_device_drm_properties tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com,angle-bots+autoroll-info@google.com Change-Id: I2cc99b941a040358a98a0ad3e2eefef4ad2b55b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3003322 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5d8f7a02 2021-07-02T10:01:00 Roll SwiftShader from 1231b445b902 to 314508f788b2 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/1231b445b902..314508f788b2 2021-07-01 capn@google.com Work around MemorySanitizer false-positive 2021-07-01 cwallez@google.com Increase max workgroup size for WebGPU If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Id3965897c2cccf191cb5f9ec8cf3a7da468c1442 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3003065 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 91d048f9 2021-07-02T07:01:33 Roll Chromium from 69ddea72a93b to 3406cb648bea (368 revisions) https://chromium.googlesource.com/chromium/src.git/+log/69ddea72a93b..3406cb648bea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fde1df76f6..765bbc94ea * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d46361bc7b..ae0481e55f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a0672af08c..aa6d8cbd3e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..36f311b034 * tools/luci-go: git_revision:e20098f56b10587e3cc0bc9ccac4934a13158de3..git_revision:40f945205c8670537d14901c310374774f589254 * tools/luci-go: git_revision:e20098f56b10587e3cc0bc9ccac4934a13158de3..git_revision:40f945205c8670537d14901c310374774f589254 * tools/luci-go: git_revision:e20098f56b10587e3cc0bc9ccac4934a13158de3..git_revision:40f945205c8670537d14901c310374774f589254 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4a2cc422b8..43c036ca86 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/84ad259424..7235d59a2b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/15547a6864..1e130552d4 * tools/skia_goldctl/mac: X-Gty06U_OR4SINwPASbahacEQPOSfbsvTEOGR3R5mUC..4ighzAwClyw2f7qzLc7vNBeEyyur8GGNNt7d1d32IvQC * tools/skia_goldctl/win: hbz09RIw2GLrYnSdrOxyXjIwJxp5hXG2qxyaEPT1D-YC..9c1KMLUktX61ANQhF4IrBQchPmmj73ZqzJi74TiKn_sC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Iffe56c66b6bf28c8f0fbc7dfbdecece355214815 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3002942 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4a3fc4b5 2021-07-01T10:01:00 Roll SwiftShader from 9c5d0d73e2f3 to 1231b445b902 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/9c5d0d73e2f3..1231b445b902 2021-06-30 capn@google.com Disable the legacy OpenGL ES targets for Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ida7b22caf5bf122b11e5ff27afda96936dd0b50a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3000014 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9f99de9d 2021-07-01T07:04:02 Roll Chromium from 20cc6c3bb504 to 69ddea72a93b (424 revisions) https://chromium.googlesource.com/chromium/src.git/+log/20cc6c3bb504..69ddea72a93b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/28cc786905..fde1df76f6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e6d9961216..a0672af08c * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a38974fc98..173d8869cf * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/5764d6acf7..329436118b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..949bca87e0 * tools/luci-go: git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef..git_revision:e20098f56b10587e3cc0bc9ccac4934a13158de3 * tools/luci-go: git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef..git_revision:e20098f56b10587e3cc0bc9ccac4934a13158de3 * tools/luci-go: git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef..git_revision:e20098f56b10587e3cc0bc9ccac4934a13158de3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/709694a7a0..4a2cc422b8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9361ecc481..15547a6864 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ic9ee180399ae53ad526c588d928ce25613c39119 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2999409 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny dba2e136 2021-05-13T20:33:46 Capture/Replay: Emit InitializeReplay() late Only emit InitializeReplay() after all captured frames have been run, so that the readBufferSize and the maxClientArraySize are really sufficiently large for all frames. To achieve this a layer of indirection is added, that is because InitializeReplay() has to be called from SetupFrame() which is still emitted with the first frame, a new function InitReplay() is added. The call to this function is emitted with the first frame, buts its body is emitted after the last frame has been captured. Bug: angleproject:5965 Change-Id: Ic38791b4c02989594ec87d1ba3f031fd81471314 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2940841 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Matthias Lederhofer 824e56f2 2021-06-30T17:12:19 Fix markdown link Bug: None Change-Id: Id6ebeb0c768d494f19d6619d68cdaf5ee18e981d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2997303 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll e9757dd6 2021-06-30T12:58:15 Roll VK-GL-CTS from 9fa02d6ab07f to 5e375439542a (4 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9fa02d6ab07f..5e375439542a 2021-06-30 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master 2021-06-30 alexander.galazin@arm.com Merge vk-gl-cts/opengl-cts-4.6.1 into vk-gl-cts/master 2021-06-30 gleese@broadcom.com Add uniform control flow extension to allowed list 2021-06-29 rgarcia@igalia.com Add VK_EXT_multi_draw tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com,angle-bots+autoroll-info@google.com Change-Id: I68376eaedfd7c4b246073005241b834273ddc6f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993641 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi d6202fce 2021-06-28T16:53:45 Vulkan: Disable GL_KHR_texture_compression_astc_sliced_3d 3D ASTC formats are not supported in Vulkan, sliced or not. The non-sliced extension is already disabled, and this change disables the sliced version. Bug: angleproject:6038 Change-Id: I055838345ccb8ad77fe4c05e65dd8b10a8a4d36b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993459 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 790004db 2021-06-30T10:01:13 Roll SwiftShader from a3726e06b4f1 to 9c5d0d73e2f3 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/a3726e06b4f1..9c5d0d73e2f3 2021-06-29 capn@google.com Fix Android Vulkan build 2021-06-29 capn@google.com Implement Pragma() for Reactor MemorySanitizer instrumentation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ia32974617f216ce50bb520efb0643c73fbf0f1bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2996342 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ceb92d21 2021-06-30T07:01:11 Roll Chromium from 1078c63704e4 to 20cc6c3bb504 (842 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1078c63704e4..20cc6c3bb504 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9211e71997..28cc786905 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/82a4d60220..fd3f3c1998 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/79a2e924d9..8fa8794677 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/bf260ac892..d46361bc7b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/dffb539454..e6d9961216 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/dc7751ee11..a38974fc98 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/ba4a77b238..5764d6acf7 * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/fdaa5e5b9f..b291e88d8e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2bc697bc64 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2a6dffaf4b..a806594b95 * third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/6906af9d94..7c54c1f227 * third_party/markupsafe: https://chromium.googlesource.com/chromium/src/third_party/markupsafe/+log/0944e71f4b..1b882ef637 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6274a5523a..5633839bd5 * tools/luci-go: git_revision:8ed83b4afa51020c8900d121bb57624b35882dec..git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef * tools/luci-go: git_revision:8ed83b4afa51020c8900d121bb57624b35882dec..git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef * tools/luci-go: git_revision:8ed83b4afa51020c8900d121bb57624b35882dec..git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/200428d9fe..709694a7a0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b08c62ecda..9361ecc481 * tools/skia_goldctl/linux: UdQNElAXaCXfe2mgtDvG-3qVDSF8BDcA3wN2gDEFUjgC..yGEFrRQrT0GK0GqIKxNRbT092eKdKLQsfsDEAeHNUz0C * tools/skia_goldctl/mac: dukW3C-pL5BBIPLAczaYnnXruUL-y4BAWG28KyiLl-0C..X-Gty06U_OR4SINwPASbahacEQPOSfbsvTEOGR3R5mUC * tools/skia_goldctl/win: lgJKP9M_eCaX9oj-mmbEPdV27wkXYV_GtjD9My6G5TkC..hbz09RIw2GLrYnSdrOxyXjIwJxp5hXG2qxyaEPT1D-YC Clang version changed llvmorg-13-init-13925-g0f24ffcd:llvmorg-13-init-14086-ge1b8fde1 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/6274a5523af83afe7762ab96d383f50109376fe7..5633839bd5ef2dd9a19e8fc547447d04f832c698/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: Iff927524aff04aa541ef24872bd69d27093c871a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2995721 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop a8959a9b 2021-06-29T21:23:21 Tests: Add Toon Blast trace Test: angle_project --gtest_filter="*toon_blast*" Tbr: jmadill@google.com, timvp@google.com Bug: b/192408760 Bug: angleproject:6121 Change-Id: Id301c48921a24164d4dccd7d53c1a4e51a0795ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993753 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi dc59772e 2021-06-22T22:37:26 Vulkan: SPIR-V Gen: Support switch With the infrastructure to support this in place, switch is simply implemented as a conditional with multiple blocks. Each block either ends with a branch to the merge block or the next block, implementing fallthrough. Bug: angleproject:4889 Change-Id: I5831531d918ac06648cced7707d1d48ffeb6b1b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2983559 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi a8c9cecf 2021-06-12T00:12:34 Vulkan: SPIR-V Gen: Support break and continue This is simply done by issuing a branch to the merge or continue blocks respectively. Bug: angleproject:4889 Change-Id: I3e96a3b0f1a0533aa4eac519ab64a87600c0983b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2957810 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop e45682b4 2021-06-29T17:55:36 Tests: Add Township trace Test: angle_perftests --gtest_filter="*township*" Tbr: jmadill@google.com, timvp@google.com Bug: b/192402770 Bug: angleproject:6120 Change-Id: I3ef0bb6e896a081c17a07f18037805be5494af2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993882 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 1c39335a 2021-06-29T16:40:43 Tests: Add Farm Heroes Saga trace Test: angle_perftests --gtest_filter="*farm_heroes_saga*" Tbr: jmadill@google.com, timvp@google.com Bug: b/192395241 Bug: angleproject:6119 Change-Id: Iebec311e37e5f84ad85e5a77aa36b3cffb55d2e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2995383 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Tim Van Patten a09052ea 2021-06-29T16:18:15 generate_android_bp.py: Don't include buildtools/third_party/libc++/ The buildtools/ directory is not included in the AOSP version of ANGLE and is unnecessary, so update generate_android_bp.py to filter out that include directory. Bug: b/187342779 Change-Id: I3a2d0506ac53f7d369597c797fffb211ffde41f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2995382 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill ec8cdd5d 2021-06-28T15:59:38 infra: Add perf tests to Android/Linux/Mac. These use the same config as the previous perf bots. Bug: angleproject:6090 Change-Id: I0ed4bc32cdc5b27f1fbd00fded1fa8d2ccbe45d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993458 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 69c2d820 2021-06-29T11:58:41 Perf Tests: Register trace tests programatically. Using testing::RegisterTests lets us filter out the disabled configs. This helps sharding the tests because some shards were getting a very uneven distribution of real tests vs skipped tests. A couple shards were running 20 minutes, while most were about 6 minutes. More work might be needed to even that out. Bug: angleproject:6090 Change-Id: Ibdf35677cfea86dfc374a2b18bb57cd9f289ddee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2994726 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki dcfde515 2021-06-24T15:59:04 gl.xml: Add GL_FRAMEBUFFER_SRGB_EXT to EnableCap group. Add GL_EXT_sRGB_write_control in registry_xml.py. This makes FrameCapture write a GL_FRAMEBUFFER_SRGB_EXT enum instead of it's hex value in glEnable/Disable calls. Bug: angleproject:5857 Change-Id: Ifa01118c2958275c7623c6bfe29f015fa8875fce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988356 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Peter Kasting d2816b4e 2021-06-25T14:52:02 Fix a -Wdeprecated-copy warning. Bug: chromium:1221591 Change-Id: Idbbb4aa16e58a9f4e7e25590667cf15706233de4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2989632 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 04f775a8 2021-06-29T11:51:16 Roll VK-GL-CTS from 7329723d8103 to 9fa02d6ab07f (21 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7329723d8103..9fa02d6ab07f 2021-06-29 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master 2021-06-29 alexander.galazin@arm.com Update extension dependencies 2021-06-29 siglesias@igalia.com Improve existing cull distance tests 2021-06-29 siglesias@igalia.com Add tests checking Input and Resolve attachments can be the same attachment in a subpass 2021-06-29 rgarcia@igalia.com Fix 64-bit atomics mandatory feature checks 2021-06-29 jason.ekstrand@intel.com Fix tessellation SPIR-V tests use of Restrict 2021-06-29 gleese@broadcom.com Fix buffer copy extents in blit tests 2021-06-29 alexander.galazin@arm.com Allow the use of the standard types 2021-06-29 slawomir.cygan@intel.com Allocate memory for reference buffer 2021-06-29 gleese@broadcom.com Fix YCbCr linear filtering support check 2021-06-29 gleese@broadcom.com Don't run _concurrent sync tests on 1 queue devices 2021-06-29 gleese@broadcom.com Fix stage flags for INPUT_ATTACHMENT descriptors 2021-06-29 gleese@broadcom.com Remove spurious feature dependencies in 1.2 tests 2021-06-29 gleese@broadcom.com Fix feature dependency in vulkan1.2 test 2021-06-29 gleese@broadcom.com Fix image aspect handling in fragdepth tests 2021-06-29 gleese@broadcom.com Fix output components limit in fragment input tests 2021-06-28 alexander.galazin@arm.com Update Vulkan headers 2021-06-21 alexander.galazin@arm.com Update Vulkan headers 2021-06-18 rgarcia@igalia.com Check shader image atomic mandatory features 2021-06-18 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2021-06-18 siglesias@igalia.com Add timestamp query test variants with availability bit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com,angle-bots+autoroll-info@google.com Change-Id: If61a0d74e30a5292d8ac95751fa7a9095b2b30f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2994440 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 72c8d46d 2021-06-29T08:05:11 infra: Build traces on perf bots. This is necessary to ensure they run the trace tests in perf. Bug: angleproject:6090 Change-Id: Ib96418c4371f700dbbd54933241b1b88912f9938 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2991903 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>