|
5220e634
|
2025-06-16T11:14:22
|
|
Fix glCopyImageSubData validation check part 2
For compressed texture, we also need to check if the copy subregion
starting points (offset) are aligned with the compressed block.
This change also moves *FillsEntireMip check to the
ValidateCompressedRegion() function, as it is easier to do a
per-dimension check.
Bug: b/419048313
Bug: angleproject:42264179
Bug: angleproject:42265887
Change-Id: I0f415e575bbc77bdf5178e2b5fc1260c43e7de4b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6648198
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
3b7528e1
|
2025-05-20T12:31:28
|
|
Support running the full end2end suite against the System EGL
Update the end2end test instantiation to either fully target the
packaged ANGLE libraries or the system EGL, but not a combination of
both simultaneously.
The GN argument |angle_test_enable_system_egl| controls which driver
is being tested by all the instantiated tests. It's default value is
"false", which means the tests target the ANGLE libraries by default:
kDefaultGLESDriver = GLESDriverType::AngleEGL
When |angle_test_enable_system_egl = true|:
kDefaultGLESDriver = GLESDriverType::SystemEGL
This allows for testing the system EGL with the full end2end test suite,
which is useful on devices where ANGLE is the system EGL (e.g.,
Android). It also allows for specifying which backend to use (or all)
during system EGL testing, when ANGLE is the EGL driver.
This also includes removing the various ESx_EGL() functions, because the
end2end tests must now fully commit to testing either the ANGLE driver
or system driver, rather than a combination of both. This is similar to
many other test suites, such as the Khronos CTS (dEQP), which only test
validate a single driver per invocation.
Bug: b/279980674
Test: angle_end2end_tests
Change-Id: I4f7dc2ccb4f26b3bd02767d0a0d2876f8612f2ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580876
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
6bb47e67
|
2025-06-17T13:42:47
|
|
Vulkan: Limit finalizing foreign image layouts
Currently, any submission results in finalizing all foreign images.
However, if the submission is only limited to the outside render pass
command buffer, this would result in oldLayout VVL errors (01197), as
it would be too early to finalize the layout of such images at those
times. At this time, this type of submission can occur if the size of
buffer-to-image updates exceeds the following threshold:
kMaxBufferToImageCopySize
In this change, finalizing the foreign image layouts would only occur
when all commands are being submitted.
* In ContextVk::submitCommands(), finalizeAllForeignImages() is now
called only when the submission type is Submit::AllCommands.
* Added new submit tests for foreign images to ImageTest:
* UploadForeignUntilSubmitDoesNotBreakRenderPass
* CopyToForeignUntilSubmitDoesNotBreakRenderPass
Bug: b/425987310
Change-Id: Ia345e176be79017ba18ef52a57256eeeb298e39a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6653602
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
98bd576f
|
2025-06-19T08:01:25
|
|
Roll VK-GL-CTS from 53a925d9098c to 9390207187c6 (28 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/53a925d9098c..9390207187c6
2025-06-17 kamil.goras@mobica.com Add OpenGL tests for
textureQueryLevels
2025-06-16 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.3
into vk-gl-cts/main
2025-06-16 lorenzo@khronosgroup.org Merge remote-tracking branch
'vk-gl-cts/dev/VK_EXT_shader_float8'
2025-06-16 lorenzo@khronosgroup.org Update external sources (Vulkan
1.4.318)
2025-06-16 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12
into vk-gl-cts/main
2025-06-13 ziga@lunarg.com Fix missing submit infos in sync multi queue
tests
2025-06-13 rgarcia@igalia.com Fix DeprecationWarnings in
fetch_sources.py
2025-06-13 scerveau@igalia.com CMake: add additional pc checks
2025-06-13 rgarcia@igalia.com Test conditional rendering with ray
tracing commands
2025-06-13 rgarcia@igalia.com Test "unaligned" buffer<->image copies
2025-06-13 jbolz@nvidia.com Add cooperative vector tests for readonly
loads w/bounds checking
2025-06-13 rgarcia@igalia.com Test maintenance5 default point size
without large points
2025-06-13 rgarcia@igalia.com Fix missing largePoints capability for
multiview tests
2025-06-13 vikram.tarikere@imgtec.com Honour undefined behaviour from
OpSDiv.
2025-06-13 lorenzo@khronosgroup.org Fix dependencies checks for
extensions and functions
2025-06-13 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3
into vk-gl-cts/main
2025-06-12 kamil.goras@mobica.com Add negative tests that texture lookup
function bias parameter is not accepted in any other shader than
fragment shader.
2025-06-11 lorenzo@khronosgroup.org Add VK_EXT_shader_float8 JSON
2025-06-11 lorenzo@khronosgroup.org Add VK_KHR_maintenance9 JSON
2025-06-11 lorenzo@khronosgroup.org Add VK_KHR_video_decode_vp9 JSON
2025-06-11 lorenzo@khronosgroup.org Add VK_KHR_unified_image_layouts
JSON
2025-06-11 lorenzo@khronosgroup.org Update external sources
2025-06-11 lorenzo@khronosgroup.org Merge remote-tracking branch
'vk-gl-cts/dev/VK_KHR_maintenance9'
2025-06-10 scerveau@igalia.com video: VP9 decode tests: update public
repo
2025-06-09 lorenzo@khronosgroup.org Merge remote-tracking branch
'vk-gl-cts/dev/VK_KHR_video_decode_vp9' into main
2025-06-09 lorenzo@khronosgroup.org Merge remote-tracking branch
'vk-gl-cts/dev/VK_KHR_unified_image_layouts' into main
2025-06-09 lorenzo@khronosgroup.org Update external sources (Vulkan
1.4.317)
2025-06-06 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.6
into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,geofflang@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I1f614f11f0f5cb73c24dd4346a837ec6dc88b0bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6658499
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
cb432540
|
2025-06-19T17:00:27
|
|
WebGPU: Expand dEQP test expectations
This lowers our unexpectged passes from ~8k to ~3.5k.
Bug: angleproject:356399840
Change-Id: Idb9d4aee9103bc18783a7283d938c368c7efbe5b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5875956
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
Commit-Queue: Liza Burakova <liza@chromium.org>
|
|
|
98d2d5d8
|
2025-06-19T14:44:21
|
|
WebGPU: Add missing WebGPU suffix for perf tests.
Bug: angleproject:419821694
Change-Id: Ic509df3fbd270ffc2a8f91c1565d673fb82a6bd2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6652900
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
f48fcb46
|
2025-06-19T07:11:48
|
|
Revert "Metal: Wraparound int arithmetic for add, sub"
This reverts commit 2f6f0514563d81e439e04ba09eee9e8a1d6ca8d1.
Reason for revert: Leads to MSL compiler errors:
> error: non-const reference cannot bind to vector element
Bug: angleproject:382215759
Original change's description:
> Metal: Wraparound int arithmetic for add, sub
>
> Implement wraparound int arithmetic for
> int, ivec +, -, +=, -=, ++, --.
>
> All of the added tests pass also without the changes.
>
> Bug: angleproject:382215759
> Change-Id: I7605582ab2931e63010c34fba474797f7edd19f9
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6578729
> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Bug: angleproject:382215759
Bug: chromium:425746892
Change-Id: I831d96c6ee7b8bcdeaa08fbf32d430def87a3c30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6656001
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
243ebfa7
|
2025-06-16T16:07:06
|
|
WebGPU: Allow glReadPixels from non-base mip levels.
Before, the WebGPU backend always read from the base level
of the texture attached to the current framebuffer.
Bug: angleproject:42267090
Change-Id: Ibe5b8575f6fa90c1942ba566485b6175ee10f808
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6634558
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Matthew Denton <mpdenton@chromium.org>
|
|
db70fca6
|
2025-06-11T16:59:36
|
|
Add a separable program test
ES 3.2 spec section 7.4.1 Shader Interface Matching is vague about
the case when a program has more than one shader whose interfaces
do not match and the program is set to GL_PROGRAM_SEPARABLE by
glProgramParameteri API. Angle implementation thinks it is not
right and the program is not linked. But since the shaders are
attached to one program, the program should have enough information
to link.
Bug: angleproject:424050949
Change-Id: Icb9c8cbff906671beb6679309795f5c1b3acec6f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6636452
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Shufen Ma <Shufen.Ma@arm.com>
|
|
dfefcbc6
|
2025-06-09T16:30:55
|
|
glGetProgramiv should return the properties in effect
glProgramParameteri can set values to
GL_PROGRAM_BINARY_RETRIEVABLE_HINT. However, this setting will not be in
effect until the next time glLinkProgram or glProgramBinary has been
called successfully. Also, glGetProgramiv returns the properties
currently in effect for program. Therefore, we need to add a variable to
record the ineffective value and copy it at the stage of glLinkProgram
or glProgramBinary.
Bug: angleproject:421219220
Change-Id: Ib564e6df03d34f3fc7389f926795cb3e64cbf687
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6606372
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
94ee620d
|
2025-05-22T10:07:05
|
|
Metal: Allow optimization of simple loops
Reimplement the feature to avoid undefined behavior of infinite loops.
Add EnsureLoopForwardProgress rewrite pass that inserts a volatile
variable access to all loops that it cannot analyze as being finite.
Detect loops of form `for (; i <op> x; ++i)` as being finite.
The <op> can be any of <,<=,>,>=,==, != operator.
The i can be int or uint.
The ++i can be -- or ++, -=1, +=1.
This assumes that backends using the feature emit signed int arithmetic
with defined wraparound semantics.
Uses volatile write instead of asm("") due to asm not forcing the
behavior in some compiler versions. The volatile variable access is
defined in C++ as forward progress, and by inheritance this works in
MSL.
Later commits may remove injectAsmStatementIntoLoopBodies if
ensureLoopForwardProgress is appropriate for all use-cases.
Bug: angleproject:418918522
Change-Id: Ic9c29f57044b792195386483208632354d24c854
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6575051
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
|
79ec8b34
|
2025-06-12T14:32:42
|
|
Fix glCopyImageSubData validation check
When checking if the copy subregion meets the compressed texture
alignment requirements, we should consider if the copy subregion
covers the entire width and height of texture level. It is not required
to make texture size aligned with compressed texture block size when
creating the texture image (e.g. width and height do not have to be
multiple of 6 when calling glTexStorage2D for
GL_COMPRESSED_RGBA_ASTC_6X6 textures). If the copy subregion width
and height equals to the width and height of the texture level, even
if they are not aligned with the compressed texture block size, the
copy is allowed. This is currently covered by
fillsEntireMip check. However, fillsEntireMip enforces copy subregion
width, height, and depth all equal to the texture level width, height,
and depth, where we should not check depth because we don't enforce
depth alignment for compressed texture. For example, for a 2D texture
array that has dimension of 32*16*2 in current level, a copy region
with width=32, heigh=16, depth=1 should be considered as
fillsEntireMip.
In the spec, it says: "The source and destination subregions must be
contained entirely within the specified level of the corresponding
image objects". Right now we only check if width and height are within
the image bounds, this change adds a check to make sure depth is also
within the image bounds.
Bug: b/419048313
Change-Id: I6e5339cfdfd5785f935a059638c22c9646c12162
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6634232
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
c53c908c
|
2025-06-11T15:36:48
|
|
Refine GetProgramiv validation
An INVALID_OPERATION error is generated if TESS_CONTROL_OUTPUT_-
VERTICES is queried for a program which has not been linked
successfully, or which does not contain objects to form a
tessellation control shader.
An INVALID_OPERATION error is generated if TESS_GEN_MODE,
TESS_GEN_SPACING, TESS_GEN_VERTEX_ORDER, or TESS_GEN_POINT_MODE
are queried for a program which has not been linked successfully,
or which does not contain objects to form a tessellation evaluation
shader.
Bug: angleproject:424050946
Change-Id: I9d6110d2783efb21efbcb62d9da7b35590c89f61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6637010
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Shufen Ma <Shufen.Ma@arm.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
fdff1170
|
2025-06-06T10:46:03
|
|
tests: SystemEGL: Skip tests needing unsupported ANGLE EXTs
The system EGL may not expose ANGLE extensions, even if it *is* ANGLE,
due to platform EGL restrictions (e.g., Android platform EGL).
Skip any tests requiring ANGLE-specific extensions during test setup,
rather than failing them.
This also requires refactoring ANGLETestBase to derive ::testing::Test
so it has access to Test::IsSkipped().
Bug: b/279980674
Change-Id: I8e424509c41fa5a69dee9fc8e0c92da58e4758fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622112
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
005336e4
|
2025-06-11T17:17:16
|
|
WGPU: Basic texture cubes
Allows uploading to texture cube faces and sampling from them
in shaders using samplerCube.
Bug: angleproject:420782526
Change-Id: I45d4370fcc418f39afb225114d13632a78c7c200
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6593999
Reviewed-by: Liza Burakova <liza@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
|
|
d8c15499
|
2025-05-27T03:46:24
|
|
Vulkan: Clear depth and stencil unresolve separately
To take into account two situations.
1. LoadOp for depth and stencil attachments are set differently.
2. depth and stencil unresolves could be different between the
previous render pass and the current render pass.
Bug: angleproject:42266019
Change-Id: I9e069b3972f86abb84eee6280919e6bba2901225
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6590197
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d9818437
|
2025-05-22T12:52:29
|
|
tests: Cleanup build_angle_end2end_tests_library block
1. If Vulkan is enabled, always include the Vulkan tests in the end2end
tests, rather than excluding them when build_angle_end2end_tests_library
is 'true'.
2. Remove NDK include. It's unnecessary, because the 'angle' target
already manages its own include_dirs.
Bug: b/279980674
Change-Id: Ibf3c29a5f90f161a7c9a69f5c4736ea4c3ef49ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580875
Reviewed-by: Solti Ho <solti@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
3c2bff4b
|
2025-05-22T12:33:12
|
|
Rename angle_end2end_tests_aosp to angle_end2end_tests_library
Rename the GN arg angle_end2end_tests_aosp to
angle_end2end_tests_library, because while building the end2end tests is
relevant for Android, it's not restricted or specific to Android.
Bug: b/279980674
Change-Id: I8f03e0fe264ac918cb34c379be85b65d7bfc0ab1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580873
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
f9053516
|
2025-06-10T14:24:13
|
|
MultiviewTestBase: Remove setWebGLCompatibilityEnabled(true)
Remove setWebGLCompatibilityEnabled(true) from MultiviewTestBase since
it's not required and prevents running the tests when the extension
EGL_ANGLE_create_context_webgl_compatibility is not available.
Bug: b/279980674
Test: angle_end2end_tests --gtest_filter=*Multiview*
Change-Id: I32a95b110e17afcb0d45c0c8447d43f456310fee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6635032
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
0d441eda
|
2025-05-29T12:04:46
|
|
util: Give all ConfigParameters default values
ConfigParameters has a mix of 'bool' and 'Optional<bool>', with some
tests setting the Optional<> values to the default value, inadvertently
creating a dependency on the associated extension.
To reduce the dependency on various extensions and allow more tests to
run, update ConfigParameters to only contain raw bools and initialize
them to the default values defined by the associated spec. This allows
EGLWindow to only require the necessary extension when a non-default
value is set by a test.
This also requires updates to a handful of tests which were relying on
the state of extensions due to non-default values.
Bug: b/279980674
Change-Id: I77a7e102559e4393aadcdbf37886ae80cbbb9e29
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6618033
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
c39f4a5c
|
2025-06-05T15:35:06
|
|
Vulkan: Update border color assignment for stencil
In texture border clamp, if the border color is assigned together
stencil mode (both using glTexParameter()), its red component is used
to set up a border color to be used in each backend:
* (Set up in AdjustBorderColor())
In the Vulkan backend, this is used when updating SamplerDesc, which
is then used later to set up the custom border color:
* (VkSamplerCustomBorderColorCreateInfoEXT)
According to the spec, in case of undefined format, integer border
color, and stencil image, the implementation is required to use either
the first or the second component of the custom color, although it is
recommended to use the first. However, at the moment, only the first
component is being populated, while using the second component is also
valid.
* Added feature: usesSecondComponentForStencilBorderColor
* Added bit to SamplerDesc: mUsesSecondComponentForStencil
* It is set based on the feature flag above and the texture format.
* When setting the custom border color info, the second component will
be used based on the above flag.
* Added test suites to test this on ES31 and ES32:
TextureBorderClampTestES3*.CustomBorderColorWithStencil*
* Updated capture params for glTexParameterIuivEXT().
* Suppressed the ES32 version for the following:
* P4
* Linux/NVIDIA (due to out-of-date driver)
Bug: b/390710636
Change-Id: Ie50c19e8ea66da40dc8b8db49d7e622a582637a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6626416
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
65159c4e
|
2025-06-05T15:05:46
|
|
Update pipeline desc when sample count changes
* If the sample count changes when calling
glFramebufferTexture2DMultisampleEXT, we need to update pipeline desc
to ensure it is the same as the API requires.
* Add a new end2end test to verify.
Bug: angleproject:422611722
Change-Id: I7de7d3d17513cf03f5e24baa2db83633a229b4b8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6623419
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
1e613fec
|
2025-05-27T16:59:26
|
|
Compiler: sort uniforms by precision
This change reoreders the AST sequences so that uniform declarations
with lower precisions are places in front of uniform declarations with
higher precisions. This is to prepare for the upcoming change that
converts uniforms declared with mediump or lowp to 16-bit and pack them
to 32-bit integeter using packHalf2x16().
Bug: b/405795981
Change-Id: I5e1e293399dc8b51b9a6e83115f95beb0c4a7b1b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594255
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
b888dc2b
|
2025-06-09T16:58:38
|
|
OcclusionQueriesTest: Convert to ANGLETest<>
Convert OcclusionQueriesTest to an ANGLETest<> and remove calling
ANGLETestSetUp() directly. This can be error-prone if ANGLETestSetUp()
doesn't complete, but the test still executes GL commands either in
SetUp() or testSetUp(), before the test itself can be skipped. In that
case, there may not be a current Context, leading to calls like
glGetString() returning nullptr.
This also includes some additional cleanup to remove the GetParam()
calls.
Bug: b/279980674
Change-Id: I5604836c78845424b82b693bc1b74e84b6b557d4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6631025
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
0ac62dd7
|
2025-06-09T16:47:22
|
|
MultiviewRenderTest: Return if test should be skipped
MultiviewFramebufferTestBase::FramebufferTestSetUp() may not complete if
ANGLETestBase::ANGLETestSetUp() determines the test needs to be skipped
due to (for example) missing extension support. In that case, there may
not be a current Context, leading to calls like glGetString() returning
nullptr.
Check if the test is marked "Skipped" before continuing in
MultiviewRenderTest::SetUp().
Bug: b/279980674
Change-Id: Iba869029bc26fc5528853be0323fd3c50037a493
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6631023
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
ef85f283
|
2025-06-10T10:45:06
|
|
Test for deferred clear vs robust init vs invalidate
Bug: b/381284577
Change-Id: I15effe1f216523a51af83a154ad27d2921e52258
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6633791
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
de00cc6b
|
2025-05-28T17:06:59
|
|
tests: Move wglWindow to a guard statement
WGL tests are currently disabled. Refactor the check to be a guard
statement earlier in ANGLETestBase::ANGLETestSetUp(), so it bails out
sooner. This also allows for pulling everything in the else-block out,
reducing indentation and improving readability.
Bug: b/279980674
Change-Id: Id91b68e2a2e5ffd301a7c49733940b7f08892dce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6604937
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
d84248ce
|
2025-06-09T10:40:37
|
|
Revert "Disable unused private field for dEQP compilation"
This reverts commit b670d47b7aaff94d3a9e2e1b975e73d0ea336d85.
Reason for revert: Warnings resolved on the tests
Bug: angleproject:420728429
Original change's description:
> Disable unused private field for dEQP compilation
>
> Incoming VK-GL-CTS rolls are failing due to the following error
> for some dEQP targets:
> "private field 'm_size' is not used [-Werror,-Wunused-private-field]"
> This warning can be suppressed for this target temporarily, allowing
> the autoroller to merge new changes. Once the issue has been addressed
> on the CTS code, this change should be reverted.
>
> * Added -Wno-unused-private-field to gles2 and gles31 targets.
> * This is a temporary change. It should be removed once the issue
> has been addressed.
>
> Bug: angleproject:420728429
> Change-Id: I0177ded84ad58a148884e8abfac3aea9a1ff7d43
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6604679
> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Bug: angleproject:420728429
Change-Id: I6b655a37568f42fabf710380c82ab775b126bdc7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6630278
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
65091427
|
2025-06-05T14:08:01
|
|
Query draw buffer should return NONE for no surface default FB
When querying the draw buffer state via glGetIntegerv(GL_DRAW_BUFFER)
on the default framebuffer with no surface bound, GL_NONE should be
returned.
Bug: angleproject:422631118
Change-Id: Iad2f1662692b0a92563e4cfd7fe09437cb40f0c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6619453
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Mavis Deng <mavis.deng@arm.com>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
3a15fab0
|
2025-06-05T13:47:18
|
|
Add tests for per-sample shading state tracking
Add tests to cover usecases exposed by these optimizations -
- https://chromium-review.googlesource.com/c/angle/angle/+/6622156
- https://chromium-review.googlesource.com/c/angle/angle/+/6619019
Bug: angleproject:386749841
Change-Id: I848ed68afe00757a10c8c970ee1f9a9b4646e9ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622107
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
b6579180
|
2025-05-15T15:29:28
|
|
Add test case for CS writes without barriers
* Added the following test to ComputeShaderTest:
WriteToSeparateSSBOComponentsWithoutExplicitBarrier
* Based on KHR-GLES31 test:
.core.shader_storage_buffer_object.advanced-switchBuffers-cs
* It involves writing to different components of an SSBO without
explicit barriers in between.
Bug: b/417769912
Change-Id: I9f6170937c9ccf3487d8f9e7758196c950252ea3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552162
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
88ea74bf
|
2025-05-30T14:17:09
|
|
Add another condition to call copyBufferDataToImage directly
To directly copy from a buffer, it's necessary that the buffer does not
need conversion. Add this condition to the check function.
Add related end2end test.
Bug: angleproject:421288695
Change-Id: Id57df32f91a8f385bc07b2788149cc4478ccbab4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6605140
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Jiaqi Li <Jiaqi.Li@arm.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
87217c88
|
2025-06-03T08:01:03
|
|
Manual Roll VK-GL-CTS from 2231585b0204 to 832d82a93cb1 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2231585b0204..832d82a93cb1
2025-05-30 kamil.goras@mobica.com Add missing coverage for
ClearTex[Sub]Image for OpenGL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: b/421940612
Tbr: yuxinhu@google.com
Change-Id: I5b57cfc7b1d23b30fd8764db735eb5cf516ddc20
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6616574
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
af6313f5
|
2025-06-02T10:31:27
|
|
Check redundant statements for comma op in MSL translator.
Bug: angleproject:421891565
Change-Id: I0475476f360f103a3da4df263dae9c604a8bfef5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6610091
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
ac596fd8
|
2025-06-03T03:50:01
|
|
Revert "Tests: Add Aquarium trace"
This reverts commit 537d40dcac601e051e9954ed8b08cafd2cc55ff0.
Reason for revert: increases linux-asan-test compile time by 2 hours
Bug: b/420699380
Original change's description:
> Tests: Add Aquarium trace
>
> Test: angle_trace_tests --gtest_filter="*aquarium*"
> Bug: b/420699380
> Change-Id: I30e0b0cbf2520b98dc265a6686e81cc3280f5555
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594253
> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Bug: b/420699380, angleproject:421425259
Change-Id: I2931dec718e603c4e7903cfaa268ef1fb7aa3370
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6617080
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
7644c9db
|
2025-06-02T11:44:38
|
|
test: Remove EGLSingleBufferTest.VerifyMutableRenderBufferKHR
The test is enforcing that specifying/querying EGL_SINGLE_BUFFER
requires the extension EGL_KHR_mutable_render_buffer. However,
EGL_RENDER_BUFFER/EGL_SINGLE_BUFFER were introduced in EGL 1.4,
removing any extension requirements for devices that support EGL 1.4+.
3.5 Rendering Surfaces
3.5.1 Creating On-Screen Rendering Surfaces
...
EGL_RENDER_BUFFER specifies which buffer should be used by default for
client API rendering to the window, as described in section 2.2.2. If
its value is EGL_SINGLE_BUFFER, then client APIs should render
directly into the visible window. If its value is EGL_BACK_BUFFER,
then all client APIs should render into the back buffer. The default
value of EGL_RENDER_BUFFER is EGL_BACK_- BUFFER
The extension itself requires a minimum of EGL 1.2, meaning only
versions 1.2 and 1.3 require EGL_KHR_mutable_render_buffer to use
EGL_SINGLE_BUFFER.
Remove the test since it doesn't gives us any information anymore since
we always expose EGL 1.5 anyway.
Bug: b/417459061
Change-Id: I060e196600e6ece6179a164d9125a8b98c0d8498
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6613123
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
b1359277
|
2025-05-14T22:53:36
|
|
Declare lavapipe device type
Fixes 'Unknown GPU architecture' warning when using
lavapipe driver with guest side ANGLE enabled on the
emulators. Also treats lavapipe similar to swiftshader
for test coverage purposes.
Bug: b/417791087
Test: run goldfish emulator with '-gpu lavapipe'
Change-Id: I40002ce191aa49f08d887c066321c4d0c27f2738
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6547537
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
ef29d42e
|
2025-05-22T15:52:49
|
|
Support ASTC decode mode extensions in ANGLE
Added support for GL_EXT_texture_compression_astc_decode_mode and
GL_EXT_texture_compression_astc_decode_mode_rgb9e5 in ANGLE. Also added
corresponding end-to-end tests for ASTC decode mode queries, including
ASTC decode mode queries and rendering with ASTC texture formats with
different decode modes on GL_TEXTURE_2D works.
Bug: angleproject:419403188
Change-Id: I0f2dced8468c4e25597740d1de346b2f699bb81e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6575285
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
20b08f95
|
2025-05-29T10:14:33
|
|
Roll VK-GL-CTS from c9d2e24d1a6d to 7be6d4540af2 (27 revisions)
* Added gl4cTextureBufferTests files to deqp.gni.
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c9d2e24d1a6d..7be6d4540af2
2025-05-26 rgarcia@igalia.com Test vkGetPhysicalDeviceFormatProperties2
pNext chain
2025-05-26 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2
into vk-gl-cts/main
2025-05-26 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12
into vk-gl-cts/main
2025-05-23 kamil.goras@mobica.com Add test texture buffer size clamping
2025-05-23 piotr.byszewski@mobica.com Tests null FS with cull distance
and sample mask
2025-05-23 piotr.byszewski@mobica.com Use bad
VkPipelineRenderingCreateInfo when it is not needed in GPL
2025-05-23 boris.zanin@amd.com Verify stride is non-constant value in
OpCooperativeMatrixStore/Load
2025-05-23 petermcneeley@google.com Amber tests for NClamp spir-v
extended instruction
2025-05-23 david.rosca@amd.com Fix film grain flag for
dEQP-VK.video.decode.av1.argon_filmgrain_10_test1019_*_dpb
2025-05-23 ziga@lunarg.com Fix enabling extensions in swapchain
maintenance1 tests
2025-05-23 lionel.g.landwerlin@intel.com Fix default SampleMask value in
VK_EXT_shader_object tests
2025-05-23 mateusz.bahyrycz@mobica.com Fix for missing synchronization
in BufferViewTestInstance
2025-05-23 piotr.byszewski@mobica.com Port selected tests to new
capabilities system
2025-05-23 michal.jakubek@mobica.com Reduce createCustomInstance()
calls.
2025-05-23 michal.jakubek@mobica.com Capabilities system for custom
device creation
2025-05-23 rgarcia@igalia.com Test multistream rasterization with XFB
2025-05-23 rgarcia@igalia.com Test image-to-image copies for 96-bit
formats with linear tiling
2025-05-23 rgarcia@igalia.com More DGC conditional rendering tests
related to preprocessing
2025-05-23 rgarcia@igalia.com Test sampling
VK_FORMAT_A1R5G5B5_UNORM_PACK16
2025-05-23 rgarcia@igalia.com Add tests with additional commands on
secondary command buffers
2025-05-23 rgarcia@igalia.com Fix verification thresholds in sampling
tests for small formats
2025-05-23 rgarcia@igalia.com Test copying immutable samplers
2025-05-23 rgarcia@igalia.com Add ldexp tests with non-32-bit exponents
2025-05-23 rgarcia@igalia.com Add XFB tests with primitive restart
2025-05-23 rgarcia@igalia.com Test arbitrary matching queue family
values in barriers
2025-05-23 rgarcia@igalia.com Test geometry shader side effects always
happen
2025-05-23 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2
into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:420728429
Tbr: abdolrashidi@google.com
Change-Id: Iee73fa63e10dd084a4c67bcae7ab1779f8efdbcf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6601054
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
b670d47b
|
2025-05-29T13:37:27
|
|
Disable unused private field for dEQP compilation
Incoming VK-GL-CTS rolls are failing due to the following error
for some dEQP targets:
"private field 'm_size' is not used [-Werror,-Wunused-private-field]"
This warning can be suppressed for this target temporarily, allowing
the autoroller to merge new changes. Once the issue has been addressed
on the CTS code, this change should be reverted.
* Added -Wno-unused-private-field to gles2 and gles31 targets.
* This is a temporary change. It should be removed once the issue
has been addressed.
Bug: angleproject:420728429
Change-Id: I0177ded84ad58a148884e8abfac3aea9a1ff7d43
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6604679
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
7855312a
|
2025-05-15T00:00:00
|
|
Adjust multi draw validation
* Fixed validation of negative drawcount
for all MultiDraw*ANGLE entry points.
* Added missing extension checks to
MultiDraw*BaseInstanceANGLE entry points.
Fixed: angleproject:420956723
Change-Id: I3a058471446cd96a883970d4e38ba5af2fa07a8c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6597176
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
e7118451
|
2025-04-15T09:55:48
|
|
restricted_trace_perf: Script fixes
Minor fixes.
Tests: restricted_trace_perf
Bug: b/404239853
Change-Id: I429f2c69c47bd9a8dc725ac3f499143827755de6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6455541
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
537d40dc
|
2025-05-27T12:43:55
|
|
Tests: Add Aquarium trace
Test: angle_trace_tests --gtest_filter="*aquarium*"
Bug: b/420699380
Change-Id: I30e0b0cbf2520b98dc265a6686e81cc3280f5555
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594253
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
392dc591
|
2025-05-15T00:00:00
|
|
Remove GL_CHROMIUM_sync_query
Fixed: angleproject:420627279
Change-Id: I26dac7c55a7cf6b04121658144e1387be65d2569
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6593552
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
6542fea9
|
2025-05-07T17:28:45
|
|
Vulkan: Fix SpirV Error in Tessellation Control Shader
When feature varyingsRequireMatchingPrecisionInSpirv is enabled,
in the generated SpirV, if the shader output varying precision
needs to be adjusted, we create a new shader varying to replace the
original shader output varying, and save the original shader output
varying to the replacement shader output varying at the end of the
function. However, this does not work for tessellation control shader,
because the SpirV generated will perform following equivalent peudo
code:
layout (vertices=3) out;
in mediump float tc_in[];
out mediump float tc_out[];
highp float original_out[];
void main()
{
original_out[gl_InvocationID] = tc_in[gl_InvocationID];
// some other code in between
tc_out = original_out;
}
The last line will attempt to write to all indice of tc_out. However,
according to the spec, "each tessellation control shader invocation may
write only to those outputs corresponding to its output patch vertex.
Tessellation control shader must use the special variable
gl_InvocationID as the vertex number index when writing to per-vertex
output variables."
This change fixes the problem by keeping the precision of tessellation
control shader output as it is, and adjust the precision of
tessellation evaluation shader input instead.
Bug: b/42266751
Change-Id: I398545e2cbbf703c716d6738f1ba278baac4171f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6521225
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
27a1b2c9
|
2025-03-13T09:10:54
|
|
Metal: Fix crash with 3d tex, alpha, depth
Fix a crash when generating mipmaps for a 3d texture that has
mipmaps with w,h == 1, i.e. depth > max(2*w, 2*h).
Bug: angleproject:419755713
Change-Id: I7bf7f1f71c03b2bf6f8a30df30dc77ad06d433fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580167
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
|
2f6f0514
|
2025-05-22T15:59:19
|
|
Metal: Wraparound int arithmetic for add, sub
Implement wraparound int arithmetic for
int, ivec +, -, +=, -=, ++, --.
All of the added tests pass also without the changes.
Bug: angleproject:382215759
Change-Id: I7605582ab2931e63010c34fba474797f7edd19f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6578729
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
|
2a18fdbf
|
2025-05-21T16:14:51
|
|
Fix sync issue between XFB output and UBO input
For the following scenario, where the first draw writes to the
transform feedback buffer and the second draw reads from the
same buffer as UBO, it is necessary to end the render pass
between the two draws and add a barrier.
// xfb write
glBindBufferBase(GL_TRANSFORM_FEEDBACK_BUFFER, 0, xfb);
glBeginTransformFeedback();
glDrawArrays();
glEndTransformFeedback();
// Draw with same buffer as UBO
glBindBuffer(GL_UNIFORM_BUFFER, xfb);
glDraw();
Bug: angleproject:418568423
Change-Id: Ia294d174111c6104b55762590ec26056ee759b53
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6572198
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
157a99aa
|
2025-05-20T23:59:29
|
|
Update logic for redeclaring gl_FragDepth.
Update ParseContext logic to handle redeclaration of gl_FragDepth.
Bug: angleproject:419066563
Change-Id: I774d036922ec75ca151f1c871afc243ca09a3061
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6573532
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
571450df
|
2025-05-15T16:24:12
|
|
Depth value not clamped for clearBufferfi and clearBufferfv
Clamp depth values to [0,1] for calls to glClearBufferfi and
glClearBufferfv.
Bug: angleproject:418030862
Change-Id: I6f5393da863a17c5fd1d78f1b800df0e61d3dc60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552161
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3cf7a604
|
2025-05-17T19:39:08
|
|
WebGPU: Add extensions for importing external textures
Add EGL_ANGLE_device_webgpu which exposes the adapter and device used
by ANGLE internally.
Add EGL_ANGLE_webgpu_texture_client_buffer which allows importing
external WGPUTexture handles if they share the same device as ANGLE
(queried from EGL_ANGLE_device_webgpu).
Bug: angleproject:418022112
Change-Id: I0683d36b84a0f8e0e9b68a5ec0d3aa8b7a95152c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6553063
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
26e790f7
|
2025-05-21T14:07:40
|
|
Update the gn arg to avoid warning message in gn desc json file
After this change
https://chromium-review.googlesource.com/c/chromium/src/+/6547915,
using android32_ndk_api_level and android64_ndk_api_level gn args
will results in a warning message generated at the top of the
gn desc json file:
WARNING Build argument has no effect.
android32_ndk_api_level = 26
^-
Did you mean "android_ndk_api_level"?
This causes the json.load() function in generate_android_bp.py failing
when parsing the json file
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
Update roll_aosp.sh to use the android_ndk_apk_level to remove the
warning message.
Also update the gn arg from android32_ndk_apk_level and
android64_ndk_api_level to android_ndk_apk_level in other files.
Bug: b/418837345
Change-Id: I12fa48dcb5638b37a9965d0adb339a2dee018297
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6576736
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
3c0b2787
|
2025-05-17T19:36:42
|
|
WebGPU: Implement EGLImages
Implement EGLImages for WebGPU. Cube maps, and non-zero mip sources
are not supported yet.
Bug: angleproject:418022112
Change-Id: I59955aee907167a1829f870b7d0730a6269d814c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6557130
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
720f6bbe
|
2025-05-15T00:00:00
|
|
Fix attribute and uniform name validation
* Fixed null name error messages
to refer to correct parameters.
* BindUniformLocation
* Added name checks for null
and all reserved prefixes.
* Fixed error code for reserved prefixes.
* GetAttribLocation & GetUniformLocation
* Moved reserved prefixes check to the Context.
* Fixed and expanded tests.
Fixed: angleproject:418986804
Change-Id: I62760b3010fd38ee2e31e4ff88d9910647b329dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6568552
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
71b58cdc
|
2025-05-17T18:12:33
|
|
Fix feedback loop in ImageTest.SourceRenderbufferTargetTexture*
This test would make a renderbuffer as an EGLImage source and a texture
as the target. It would then try to verify the data in the texture by
sampling but the renderbuffer was currently bound to the framebuffer
creating a feedback loop.
Bug: angleproject:418022112
Change-Id: I456eb541c84d98d99e6b8d8be817ce67d7b1d519
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6556610
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
dcbcee8a
|
2025-05-15T10:39:55
|
|
Tests: Use eglGetPlatformDisplay()
From the EGL 1.5 spec:
Appendix F
Version 1.5
EGL version 1.5 was voted out of the Khronos Technical Working Group
on January 31, 2014, and formally approved by the Khronos Board of
Promoters on March 14, 2014.
EGL 1.5 is the sixth release of EGL. It introduces the following new
features (the EGL extension(s) each feature is based on are also shown
parenthetically):
* Platform support:
– Providing a mechanism for support of multiple platforms (such as
window systems or offscreen rendering frameworks) in a single EGL
implementation at runtime (EGL_EXT_platform_base).
Many tests use eglGetPlatformDisplayEXT() which is provided by the EGL
extension EGL_EXT_platform_base. With the promotion of the
EGL_EXT_platform_base functions to core EGL in version 1.5 and ANGLE
supporting EGL 1.5 (as of at least 2019), update the calls to use
eglGetPlatformDisplay().
This is in preparation for running the ANGLE end2end tests in Android,
which only exposes the EGL 1.5 functions, and not the
EGL_EXT_platform_base functions.
Bug: b/391967165
Test: angle_end2end_tests
Change-Id: I58109c3afe270f46db952e124ee3f5c11200ca35
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552257
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
e7277deb
|
2025-05-19T11:16:56
|
|
Add test to validate eglGetPlatformDisplayEXT()
Add a test to validate eglGetPlatformDisplayEXT() returns a valid
display on devices that support the EGL extension EGL_EXT_platform_base.
Bug: b/279980674
Test: EGLDisplayTest.GetPlatformDisplayEXT/*
Change-Id: I8cbb9c3905deb960e567a07d64e6c9d590a4ae70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6565328
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
30479104
|
2025-04-28T16:01:46
|
|
Add support for GL_EXT_texture_norm16 in glCopyImageSubDataEXT
Add the following compatible norm16 formats in EXT_copy_image:
RGBA16_EXT
RGBA16_SNORM_EXT
Bug: angleproject:412517249
Change-Id: I4939705915940dacaf3168acf1a7cc7abb0870ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6490613
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Mavis Deng <mavis.deng@arm.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
56becf05
|
2025-05-16T16:58:34
|
|
WGPU: texSubImage2D() should mark textures as dirty
TextureWgpu now observes its ImageHelper's edits to staged
subresources and notifies its observers (Texture) that it has
changed, ensuring TextureWgpu::syncState() is called before
draw if glTextSubImage2D() was called earlier.
Also ends the current render pass when flushing subresource
updates, otherwise if the texture is being used by the current
webgpu::CommandBuffer (staged render pass commands), the texture
may be updated before the staged commands are actually submitted
to the GPU.
Bug: angleproject:389145696
Change-Id: I07db566fca970e877a0d3faa3ceb02f8425c799a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6502676
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
|
|
3f7bded1
|
2025-05-15T13:35:18
|
|
Add ANGLE_FORMAT_PRINTF to StringPrintf
Bug: b/414880678
Test: verified that the compiler attribute will generate error when
building without crrev.com/c/6543549
Change-Id: If1b57f78370d57969e999b93e17444236f194be1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6551849
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
96c9f065
|
2025-05-15T19:22:29
|
|
WGPU: Flip y for the default framebuffer
Bug: angleproject:389145696
Change-Id: I0d527ad3dc24dbca7e9d914b03edacdc257a568f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6477137
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
|
|
|
1fea2d12
|
2025-05-15T09:57:22
|
|
Roll Chromium from 6511b87fb086 to 924b8c206ea6 (678 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/6511b87fb086..924b8c206ea6
Fix warnings detected by Error Prone checks enabled in
https://chromium-review.googlesource.com/c/chromium/src/+/6543826
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,ynovikov@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/e42f899ae7..a4e74b4312
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/077a66f30f..e9b36e9ffb
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/e93dc3dea2..56ef5f113b
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/fd624be2fa..2fa93b2332
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/032eddc73b..f810dae272
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/27ee073016..9aefa1cede
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/49f482cb46..36e2b378de
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/c523543cf4..abb422e192
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/86aca59d7b..fbb9ce5767
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/92a5f60019..4e2e7b926a
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f7a506e700..866151e951
* tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/96def2f44c..d88ef9e4de
Clang version changed llvmorg-21-init-9266-g09006611:llvmorg-21-init-11777-gfd3fecfc
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/92a5f60019f3a9ff63b9388d181fa65047377fb4..4e2e7b926a033fc85695da101404f79b7ce2d7a7/scripts/update.py
Bug: None
Change-Id: I95d7c36f8e9baeb828b24f7d96452363175bba2d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6551736
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
f21ec7a0
|
2025-05-14T10:52:50
|
|
Tests: Skip VerifyMutableRenderBufferKHR on Intel+Win
The test
EGLSingleBufferTest.VerifyMutableRenderBufferKHR/ES*_Vulkan_NoFixture is
failing on Intel+Windows and generating VVL errors.
ERR: vk_renderer.cpp:968 (rx::vk::(anonymous
namespace)::DebugUtilsMessenger): [
VUID-VkSwapchainCreateInfoKHR-presentMode-parameter ]
vkCreateSwapchainKHR(): pCreateInfo->presentMode
(VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR) requires the extensions
VK_KHR_shared_presentable_image.
The Vulkan spec states: presentMode must be a valid VkPresentModeKHR
value
(https://docs.vulkan.org/spec/latest/chapters/VK_KHR_surface/wsi.html#VUID-VkSwapchainCreateInfoKHR-presentMode-parameter)
..\..\src\tests\egl_tests\EGLSurfaceTest.cpp(2036): error: Value of:
IsEGLDisplayExtensionEnabled(mDisplay, "EGL_KHR_mutable_render_buffer")
Actual: false
Expected: true
It's not entirely clear where things are going wrong, but appears to be
something in the Intel+Windows driver. Skip the test for now to keep
win-exp-test green otherwise.
Bug: b/417459061
Test: EGLSingleBufferTest.VerifyMutableRenderBufferKHR
Change-Id: Iee848b46cddaf05d0cbb0c2d81d76d07dd0b9bba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6548415
Auto-Submit: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
1e7442b2
|
2025-04-24T00:00:00
|
|
Fix KHR_debug operations
DebugMessageInsert:
* Used correct error message when the severity parameter
is invalid and aligned parameter validation order with
the command declaration.
DebugMessageInsert and PushDebugGroup:
* Fixed message length validation.
* Fixed message insertion when
the explicit length is zero.
Object[Ptr]Label:
* Fixed label length validation.
Added new tests.
Fixed: angleproject:417621246
Fixed: angleproject:417684698
Change-Id: I00cd939a83c5b9ae7dddefc51222278615bc0df9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6544152
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8d75490a
|
2025-05-08T00:00:00
|
|
Update zero length for debug marker commands
If the marker length passed to InsertEventMarkerEXT
or PushGroupMarkerEXT commands is zero, compute the
actual marker length in the Context so that the
backends could always rely on the passed length.
Bug: angleproject:408709155
Bug: angleproject:417757002
Change-Id: Ifa36d8d16c7c808855a7500556b569587cdc89a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6547538
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
ad18dc93
|
2025-04-02T16:23:50
|
|
D3D11: Remove the message from Buffer11 to gl::Buffer
This CL removes the D3D back end's usage of Subject/Observer from
Buffer11 to gl::Buffer. BufferFeedback argument has been added to
various functions and directly applied to gl::Buffer object (which will
propagate to VertexArray and texture/XFB if needed).
gl::Buffer::mImplObserver is removed in this CL, and no longer a
Observer.
Bug: angleproject:400711938
Change-Id: Idf4d423904d057ab3a1e52acf8e2496df606cb89
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6514288
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
e69813e0
|
2025-05-13T12:29:46
|
|
Fix the formatting for size_t in perf_test
This will print 64bit unsigned int max properly
Bug: b/414880678
Test: (process memory size SIZE_MAX) *RESULT TracePerf_vulkan.memory_median: black_beacon= 18446744073709551615 sizeInBytes
Change-Id: I27f0e2dd34d7fc7c055bea64ecd786e0567b754a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6543549
Commit-Queue: Xiang Wang <xwxw@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
64888cb8
|
2025-04-24T00:00:00
|
|
Align multiview extensions usage with the specs
As per the specs, the OVR_multiview2 extension requires
and implicitly enables the OVR_multiview extension.
Cleaned up the extension state checks
and added dependency tests.
No functional changes.
Fixed: angleproject:417173927
Change-Id: I67d2c19f4ed2f2450bf7fe2a92625cc9525ca020
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6535750
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
82c75df3
|
2025-04-24T00:00:00
|
|
Fix GetDebugMessageLog validation
Used the same validation for GetDebugMessageLog and
GetDebugMessageLogKHR entry points; added tests.
Simplified validation redirects for:
- ObjectLabel and ObjectLabelKHR
- GetObjectLabel and GetObjectLabelKHR
- ObjectPtrLabel and ObjectPtrLabelKHR
- GetObjectPtrLabel and GetObjectPtrLabelKHR
Fixed: angleproject:417493213
Change-Id: Id1fad6c94db78da403e70f40f44630632d375472
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6543489
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3bbdee0f
|
2025-03-28T11:55:24
|
|
Vulkan: Remove Subject/Observer from BufferImpl
Right now the gl::Buffer back end send message to the front end and then
gl::Buffer propagate the message to the observers (vertex array,
textures, transform feedback). We are seeing many of these kind of
message passing (mainly to vertexArray), and each message is a virtual
function call. The message call also lacks of context information that
we can not do certain optimizations. This CL adopts the new API feedback
argument approach for buffer APIs from the back end to the front end.
The only difficulty I ran into is D3D backend where the message could be
delivered from draw calls. For now the subject/observer code path is
still kept in the gl::Buffer, but no back end will use it except D3D11.
That will be removed in the later CL when D3D11 switch to use feedback
mechanism.
BYPASS_LARGE_CHANGE_WARNING
Bug: angleproject:400711938
Change-Id: I5fb3b660fd4260b9ba691239ad777b575b31e2ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6408892
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
e4ec23a0
|
2025-04-24T00:00:00
|
|
Fix query object support in EXT_debug_label
The GL_EXT_debug_label extension must support labeling
timer query objects created on ES 2.0 contexts even if
the GL_EXT_occlusion_query_boolean is not supported.
Expanded and fixed tests.
Bug: angleproject:42263878
Change-Id: If05cf1b6879d44de1cc893ed45d1b877c963dac6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6539570
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ed4d7278
|
2025-05-13T10:06:18
|
|
Tests: Skip VerifyMutableRenderBufferKHR on Intel+Win
The test
EGLSingleBufferTest.VerifyMutableRenderBufferKHR/ES*_Vulkan_NoFixture is
failing on Intel+Windows and generating VVL errors.
ERR: vk_renderer.cpp:968 (rx::vk::(anonymous
namespace)::DebugUtilsMessenger): [
VUID-VkSwapchainCreateInfoKHR-presentMode-parameter ]
vkCreateSwapchainKHR(): pCreateInfo->presentMode
(VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR) requires the extensions
VK_KHR_shared_presentable_image.
The Vulkan spec states: presentMode must be a valid VkPresentModeKHR
value
(https://docs.vulkan.org/spec/latest/chapters/VK_KHR_surface/wsi.html#VUID-VkSwapchainCreateInfoKHR-presentMode-parameter)
..\..\src\tests\egl_tests\EGLSurfaceTest.cpp(2036): error: Value of:
IsEGLDisplayExtensionEnabled(mDisplay, "EGL_KHR_mutable_render_buffer")
Actual: false
Expected: true
It's not entirely clear where things are going wrong, but appears to be
something in the Intel+Windows driver. Skip the test for now to keep
win-exp-test green otherwise.
Bug: b/417459061
Test: EGLSingleBufferTest.VerifyMutableRenderBufferKHR
Change-Id: I3bc21dfa059b1c0d7c4e8f7ae0452a3819bedbb3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6541387
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
73dabb85
|
2025-04-29T12:39:12
|
|
Add end2end test for AdvancedSyncVertexArray
This is just a port of the upstream test:
KHR-GLES31.core.shader_image_load_store.advanced-sync-vertexArray
Test: ComputeShaderTest.AdvancedSyncVertexArray
Bug: b/416573908
Change-Id: Id04af0a7efa667b7afc8061a9ccaa044e709fe1d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6496293
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
214b7ce2
|
2025-05-09T11:35:31
|
|
Remove --use-reclient flag from capture_replay_tests.py
The flag isn't used anymore.
Bug: b/401959048
Change-Id: I6bedc9fcb2c5a5ed152b3da4bcbce0ba4785c883
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6528770
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
2f1f9568
|
2025-05-08T12:37:57
|
|
Tests: Run respawnables trace on S24 Xclipse native driver
Their "native" driver is actually ANGLE.
Bug: angleproject:42266627
Change-Id: I53795925219f0be42fbfcb059ce45575f5a98034
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6526326
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
d221cf40
|
2025-04-24T00:00:00
|
|
Adjust EXT_base_instance emulation conditions
* EXT_base_instance may be emulated only on the
GL backend. Other backends either support it
directly or do not support at all.
* EXT_base_instance is never exposed to WebGL.
Bug: angleproject:355645824
Change-Id: I1edea83d83b1e6865eee8022c7110b05ea37d989
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6527730
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
51dd4087
|
2025-04-24T00:00:00
|
|
Autogen support checks for draw_elements_base_vertex commands
Also fixed command support conditions:
* With an exception of MultiDrawElementsBaseVertexEXT,
command and extension suffixes must match. Updated
tests to account for that.
* DrawElementsInstancedBaseVertex{EXT,OES} additionally
require ES 3.0 or any of the instancing extensions.
* DrawRangeElementsBaseVertex{EXT,OES} additionally
require ES 3.0. Updated tests to account for that.
* MultiDrawElementsBaseVertexEXT additionally
requires GL_EXT_multi_draw_arrays.
Bug: angleproject:409484297
Change-Id: I50b72ebc7d66128bcfd5671334094b7e90cb329c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6524686
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
00845fd6
|
2025-05-06T14:13:18
|
|
WebGPU: Do not reuse windows with multiple surfaces
Multiple Dawn backends do not handle re-creating a surface for a native
window. Instead of working around this by caching in the display, rework
our test runner to recreate the OS window and surface instead of just
the surface.
Release all resources in DisplayWgpu::Terminate. Otherwise they wont be
deleted until the display is reinitialized or the test executable
terminates.
Bug: angleproject:342213844
Change-Id: Ic31264a5e646a54c988ef47ca664d8575fda94eb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6515886
Reviewed-by: Liza Burakova <liza@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
8c8f016a
|
2025-04-15T17:30:01
|
|
Remove part of releaseTexImageInternal in glGenerateMipmap
In glGenerateMipmap, actually clearing the ImageDesc and
releasing texImage in releaseTexImageInternal is not needed.
The following implementation currently is skipped because getImageDesc
would return empty ImageInfo. Remove those part and put the part
of disconnecting the pbuffer from the texture after generating the
mipmap. And end2end test is also added to verify the implementation.
Bug: angleproject:410996562
Change-Id: I0d8ccd628b98aa5063df2688e9899319c32fd97d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6461524
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
317f81db
|
2025-05-01T14:17:47
|
|
Fix EGL_RENDER_BUFFER query if EGL_SINGLE_BUFFER unsupported
eglCreateWindowSurface() can have the EGL attribute EGL_RENDER_BUFFER
specified:
EGL_RENDER_BUFFER specifies which buffer should be used by default for
client API rendering to the window, as described in section 2.2.2. If
its value is EGL_SINGLE_BUFFER, then client APIs should render
directly into the visible window. If its value is EGL_BACK_BUFFER,
then all client APIs should render into the back buffer. The default
value of EGL_RENDER_BUFFER is EGL_BACK_BUFFER.
Client APIs may not be able to respect the requested rendering buffer.
To determine the actual buffer that a context will render to by
default, call eglQueryContext with attribute EGL_RENDER_BUFFER (see
section 3.7.4).
To support EGL_SINGLE_BUFFER, Vulkan surfaces must support the
VkPresentModeKHR value VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR:
VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR specifies that the
presentation engine and application have concurrent access to a single
image, which is referred to as a shared presentable image. The
presentation engine is only required to update the current image after
a new presentation request is received. Therefore the application must
make a presentation request whenever an update is required. However,
the presentation engine may update the current image at any point,
meaning this mode may result in visible tearing.
However, this is only available on Vulkan devices that support the
extension VK_KHR_shared_presentable_image.
Add checking in Surface::initialize() to update Surface::mRenderBuffer
to EGL_BACK_BUFFER if the backend implementation does not support
EGL_SINGLE_BUFFER. This includes adding supportsSingleRenderBuffer() to
query the backend if it supports single render buffer mode, which
defaults to False. The Vulkan backend overrides this and the result is
based on support for VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR.
Bug: b/412446258
Test: EGLLockSurface3Test.WindowMsaaSurfaceReadTest/ES2_Vulkan_NoFixture
Test: EGLSingleBufferTest.VerifyMutableRenderBufferKHR/*
Change-Id: I4e6d56f01a895a5bd887580e6ffa34d574c87fad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6506764
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
32f3f043
|
2025-04-28T16:15:15
|
|
Return GL_INVALID_ENUM for invalid target of CopyImageSubData
From spec: INVALID_ENUM is generated if either srcTarget or dstTarget
- is not RENDERBUFFER or a valid non-proxy texture target
- is TEXTURE_BUFFER, or
- is one of the cubemap face selectors described in table 3.17,
if the target does not match the type of the object.
Bug: angleproject:412524049
Change-Id: I2110223059db170e8882efc9666654d318b14ed3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6490614
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Auto-Submit: Mavis Deng <mavis.deng@arm.com>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
d8ab156b
|
2025-04-18T10:57:14
|
|
Fix glValidateProgram() not work as spec
According spec ValidateProgram should detect error: Any two
active samplers in the set of active program objects are of
different types, but refer to the same texture image unit.
Bug: angleproject:414259791
Change-Id: I2ab503b745cffdfb8be1a1ad649432fd8a73f63d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6491669
Auto-Submit: Neil Zhang <Neil.Zhang@arm.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
b373892b
|
2025-04-26T20:59:07
|
|
Add test using array of array varyings in tessellation shaders
For per-vertex variables in the Tess shader that support
two-dimensional arrays, when calling GetResourceName,
the string-like tt[0][0] should be returned instead of tt[0].
Bug: angleproject:413447006
Change-Id: Iafd316495ca3c254f9424d84cab71c8385b11e03
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6490616
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Robic Sun <Robic.Sun@arm.com>
|
|
|
3cc099da
|
2025-03-20T16:47:46
|
|
Add tests for texelFetch with samplerExternalOES
Add two tests to texelFetch in the vertex shader and fragment shader for
YUV with samplerExternalOES. The fetch results are expected to be RGB
value.
Bug: angleproject:405149439
Change-Id: I0a5809b910ac61c678ab240aea8d303e0c9646e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6382116
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
9812b972
|
2025-03-05T16:25:45
|
|
PLS: Validate rendering feedback loops of PLS planes
Validate that active textures are not bound as PLS planes in WebGL
compatibility mode using the same validation as for regular framebuffer
attachments.
Update the PLS spec to not generate an error for feedback loops but
update the definition of feedback loops to include PLS planes. The WebGL
spec is dependent on this definition and makes this feedback loop an
error.
Bug: angleproject:40096838
Change-Id: I597efef3685da7bfb2a9d149a9ec3bc9d01e6e4d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6330519
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Chris Dalton <chris@rive.app>
|
|
|
27cfdf8e
|
2025-04-24T00:00:00
|
|
PLS: Allow type conversions in state queries
The OpenGL ES spec requires data conversions when a query
command is issued that returns a data type different from
the actual type of the requested state.
* Updated PLS state queries to follow the main spec.
* Removed PLS state query dependencies on interruptions.
* Fixed non-robust command declarations in the extension spec.
* Added missing extension support checks to robust commands.
* Drive-by: Fixed invalid use of assertions in PLS tests.
Fixed: angleproject:414361744
Fixed: angleproject:414506466
Change-Id: I573ab66d194d5666fd9c8845ac0ab262a714c5cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6507065
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
3540a326
|
2025-05-05T16:47:30
|
|
Tests: Skip black_beacon trace on S24
Bug: angleproject:415852525
Change-Id: Ibf4d3f63e96da9cf43c34110654f9383f9ba82f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6512773
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
95813607
|
2025-05-05T10:53:08
|
|
Manual roll VK-GL-CTS from dd7e71367795 to eeeebaca3f2e (10 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/dd7e71367795..eeeebaca3f2e
2025-04-25 mateusz.bahyrycz@mobica.com Multiple queue test runner
2025-04-25 lorenzo@khronosgroup.org Add missing mandatory features for
VK_KHR_cooperative_matrix using auto-generation from XML
2025-04-25 piotr.byszewski@mobica.com Separate tests for
gl_BaseVertexARB and gl_BaseInstanceARB
2025-04-25 piotr.byszewski@mobica.com Update spirv-tools and fix
validation errors
2025-04-25 kamil.goras@mobica.com Add OpenGL tests for textureQueryLod
2025-04-25 rgarcia@igalia.com Force position-independent code in
vulkan-video-samples
2025-04-25 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2
into vk-gl-cts/main
2025-04-23 michal.jakubek@mobica.com Fix "Linux link failures" on
Windows build
2025-04-23 michal.jakubek@cognizant.com Linux compile failure when
commenting out some test additions
2025-04-23 piotr.byszewski@mobica.com Remove temporary entries from
Android*.bp files
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,geofflang@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I9d56381e80b6a89f307573ffc7f5c790c9ff4153
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6512791
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
f6e1d4d7
|
2025-05-02T12:02:09
|
|
Fix include header case mismatches
This CL fixes the include header names to be aligned with the actual
file names. It's problematic for cross compile on Linux, where file
system is case sensitive.
Context:
Goma/Reclient's deps scanner was able to handle those case mismatches.
But, Siso's builtin remote execution doesn't resolve them automatically.
Bug: b/401959048
Change-Id: I98282899e31ea801058f82d4cad770413634f4f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6508684
Reviewed-by: Charlie Lao <cclao@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
d4c83ace
|
2025-04-30T12:05:19
|
|
Fix the test to use the right uniform location
mTexture2DUniformLocation and mTextureCubeUniformLocation are
uniform locations retrieved from the TextureCubeTest.mProgram.
We should get the location from the shader program that the current
test uses.
Bug: angleproject:401546698
Change-Id: I7c5f022a9fab58572cae2e78fc328c1c0f74f977
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6502892
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
998b5693
|
2025-04-30T11:05:52
|
|
Fix ExternalBufferTest end2end test
The application or test should be responsible for managing the lifetime
of external buffer ensuring that the external buffer is not deleted as
long as there are any GL buffer objects referring to it.
https://registry.khronos.org/OpenGL/extensions/EXT/EXT_external_buffer.txt
Bug: b/396231708
Change-Id: Ib8e7e2ef0349cadc42b839019e2b2334b4cc5085
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6502674
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
c52183bd
|
2025-04-11T11:17:10
|
|
Reset sample coverage after fbo change on Adreno
Adreno drivers cache some internal value based number of samples in
currently bound FBO and glSampleCoverage value, but doesn't update it on
FBO change.
So if we set sample coverage to 1 when FBO with 1 samples bound and then
switch to FBO with 4 samples it behaves like coverage is 0.25 instead of
1.
To avoid this, reset sample coverage after each FBO change.
Bug: chromium:408364831
Change-Id: I7d5e36926e8568f4c652049b43ecdbe382ddc293
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6447878
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
|
|
|
6bdbe9cc
|
2025-05-01T12:33:41
|
|
Manual roll Chromium from dd275389e023 to cf3a960742c3 (1975 revisions)
Use third_party/depot_tools/gn.py instead of gn to accommodate
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176
Manual roll requested by ynovikov@google.com
https://chromium.googlesource.com/chromium/src.git/+log/dd275389e023..cf3a960742c3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,geofflang@google.com,ynovikov@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/88030b3203..aaf578b4fc
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0f32cb9025..6d4e129ac6
* buildtools/linux64: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45
* buildtools/mac: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45
* buildtools/win: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe092931f1..35b04da37d
* third_party/android_build_tools/error_prone/cipd: -IrkxgAkj3RxGNBPp6b4r9OWZC6_dTbI-jC3c3UPgq8C..2t_u1XEjof609BQE4czlCQzEqRliKS_qY35FOu_VckgC
* third_party/android_build_tools/lint/cipd: gx4NrAApWUVG5HG3WJRIIzZrTssD6H5uGbKe0g77mucC..TEDRB0F7VgCgyepd8FsIxPRqvKjvWQ_YkLV-ybx-GQYC
* third_party/android_build_tools/manifest_merger/cipd: HhXknpcPosMUDHZQD-8Ogve-HaG4HmJ4p082zKKAcnMC..fPGWiT0LVG2_ifxOpHb5KNwTL-_7lb7tYOsB_ZoIiskC
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1ea2115b17..a86aaa9531
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/000f47cfa3..1591e813b6
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1fcc527019..5982a1aeb3
* third_party/fuchsia-sdk/sdk: version:27.20250424.2.1..version:27.20250501.3.1
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/917609c669..62724eb55f
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/912274164f..bf95cc5da6
* third_party/r8/cipd: bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC..sxgLKZyJNZMVi8cot5yvRzqCFQxX_HbbR0psaeto5RcC
* third_party/r8/d8/cipd: 6qLey8EBp9ivhThnqVPWy2ZDGpsf5Y29EsTbi_rZ1pMC..bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/926ec54499..7c098b791b
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/1e85c01b15..6f9b4e6192
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/60443ebac3..e4c0da2094
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6c4f037a98..5ae6e4bfb4
* tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:a9a10995e2889126ace91faf4052949e38c69d33
* tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:a9a10995e2889126ace91faf4052949e38c69d33
* tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:a9a10995e2889126ace91faf4052949e38c69d33
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3b0c718c2d..e3589a5831
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9c8188cae9..1a0049ce09
* tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/fa679ed68e..7e70cdf64e
* tools/skia_goldctl/linux: M9CSmdri8G3miQpGPQeqstBvQ3TtlngrsiF5GdSTYs0C..srGbc-O6bVQmBoT6VLvP66h6Be4A-nffx4UhixUJ9w0C
* tools/skia_goldctl/mac_amd64: Txs7Izu5kRGbcoAc9qESynBnBHo8RdRIyim5zF9rWbgC..tZvHxy8AcDJhO9A-5UuZKL_-5vfE_wC-RBkElqWZpM4C
* tools/skia_goldctl/mac_arm64: LTzU4UbKV4zw61tWyttEX62vyq7nErr2gD8-jiH8IhgC..2br8hIWKHDAaOt77siYyRUclHBYUZX6dj8jtogL90nwC
* tools/skia_goldctl/win: UKiySjywM8juGVuMwWbOdaBXFD1TbzUOWcGGVTYfem0C..zasiUhQIHGZ2e60_M6g41oz8mYgPta5JmOWV5LwFjGMC
No update to Clang.
Bug: chromium:414330998
Change-Id: I5ce14c5574391c1dd638787c09789f0577ee26a2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6503456
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
e93c143a
|
2025-04-28T15:39:35
|
|
tests: Prepare capture_replay_tests for Siso migration
- Adds --use_remoteexec as an alias of --use_reclient.
- Adds --use_siso to add `use_siso=true` GN arg.
- Changes the out dir to out_CaptureReplayTest, so that the build dir
depth will be 2 for Siso remote execution rules.
- Cleans up build dir when switching from Ninja to Siso.
Bug: b/401959048
Change-Id: Id698644f16c161e86d1d1b42828281cb5fb690ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6489896
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
128c9682
|
2025-04-24T00:00:00
|
|
Make GL_ANGLE_texture_rectangle non-toggleable
This extension is not meant to be disabled.
Bug: angleproject:40096622
Change-Id: Iea87210ab1bf3800759a3c65c566af67dada75f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6494384
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
cac1e824
|
2025-04-29T18:27:36
|
|
WGSL: Output driver uniform and UBO structs
This is the WGSL half of the change to implement driver uniforms.
Driver uniforms are implemented as a UBO and reuse the default
set of driver uniforms. User-provided UBOs don't yet have
variables outputted for them.
This requires moving MSL's ReduceInterfaceBlocks to the tree_ops
dir in order to change interface block definitions into struct
definitions.
Bug: angleproject:389145696
Change-Id: I27f3837b3d115f2ffac66cc545f3b60ca9f01cb6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6477564
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
4b69ba93
|
2025-04-28T16:45:56
|
|
WGPU: upload texture bind groups and configured samplers
GLSL samplers are split into separate sampler/texture variables
in WGSL. Before this CL, the WGSL translator generated shaders
that look like:
@group(1) @binding(@@@@@@) var ANGLE_sampler_samp2D :
sampler;
@group(1) @binding(@@@@@@) var ANGLE_texture_samp2D :
texture_2d<f32>;
@group(1) @binding(@@@@@@) var ANGLE_sampler_sampCube :
sampler;
@group(1) @binding(@@@@@@) var ANGLE_texture_sampCube :
texture_cube<f32>;
This CL replaces those with actual binding numbers
@group(1) @binding(0) var ANGLE_sampler_samp2D :
sampler;
@group(1) @binding(1) var ANGLE_texture_samp2D :
texture_2d<f32>;
...
Such that @binding(n*2) is the WGSL sampler variable corresponding
to the n-th GLSL sampler and @binding(n*2+1) is the WGSL texture
variable corresponding to the n-th GLSL sampler.
This CL then generates binding group layouts matching the above,
and uploads textures and configured samplers in bind groups.
This makes some of the deqp_gles2 tests 2d texture tests pass,
though some fail because they need a flipped y coordinate.
Not yet supported:
1. arrays of samplers
2. shadow samplers
3. cube textures
Bug: angleproject:389145696
Change-Id: I2ab18ae5ebb4d1289101266bd9451576aa04ce2a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6382272
Reviewed-by: Liza Burakova <liza@chromium.org>
Auto-Submit: Matthew Denton <mpdenton@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
c884460a
|
2025-04-24T16:43:04
|
|
Vulkan: Fix deferred clears vs noop multidraw
Bug: chromium:407828338
Change-Id: I5da22aeb72605bb7943fa5ae079ae297d00888f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6488794
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
f6da7aed
|
2025-04-18T00:00:00
|
|
Fix UniformTest.GetUniformNoCurrentProgram
Added the extension check and
the result re-initialization.
Fixed: angleproject:414491366
Change-Id: I04abc847a7fd48c411e62208e88c19d9d3f6ec50
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6494452
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
828bec45
|
2025-04-26T16:12:56
|
|
Vulkan: Fix SPIR-V gen for constant constructors
... inside non-constant constructors of different basic type.
The SPIR-V generator proactively casts the elements of the inner
constructor to the type of the outer constructor, but it was mistakenly
using the original inner constructor's type id for the constant instead
of the cast type id.
Bug: chromium:413775106
Change-Id: I95e8b1dcc1ba36777eb4475042f0d106a6abe109
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6489041
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|