kc3-lang/angle

Log

Author Commit Date CI Message
Jamie Madill 93d69be2 2021-01-13T11:13:00 infra: Fixes for config. Responding this this error: WARNING: commit-queue.cfg: in "commit-queue.cfg" (config_group #1): please, specify `name` for monitoring and analytics ERROR: refs.cfg: refs.cfg is not used since 2019 and must be deleted Bug: angleproject:5530 Change-Id: I3ec13faa641918ba66b1a1b6a68e1eb1854fcc6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2626174 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Junji Watanabe f7801a3b 2021-01-13T13:30:41 Use CAS in scripts/trigger.py Isolate server is being migrated to CAS. This CL changes trigger.py to use CAS instead of Isolate server. Bug: chromium:1163817 Change-Id: I137cd656798c08bf991cb77da36780b87193f821 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2626931 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 9a39b7b3 2021-01-12T14:20:46 Add configuration for trace test bots. The bots will be called win-trace-rel and linux-trace-rel. Currently they work as clones of the compile bots. Once we add the recipe config they'll also run the trace tests. They won't be added to the CQ. Bug: angleproject:5530 Change-Id: I5457cc10860cc15a8a12e766ed2dfc6e4a4fa602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2625170 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 21583413 2021-01-13T10:02:55 Roll vulkan-deps from e59ae1af7571 to 50bcbaad4cbf (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e59ae1af7571..50bcbaad4cbf 2021-01-12 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from be70e017bff5 to a3b988fa5588 (1 revision) 2021-01-12 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 61a57c023e10 to 04b58c5bea3a (1 revision) 2021-01-12 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from c32277c0ba0d to 7bbe1a316419 (1 revision) 2021-01-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from a7825740f316 to be70e017bff5 (1 revision) 2021-01-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 645a15bbaa59 to 61a57c023e10 (1 revision) 2021-01-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 46237b593c3f to 645a15bbaa59 (1 revision) 2021-01-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from f3ccb633dfd7 to c32277c0ba0d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I607df216330f68f36cf0a3e48a0a5b01b67b8293 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2627428 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 62b8364e 2021-01-13T07:00:37 Roll Chromium from 2a7e78c75a37 to 451c64aaec04 (494 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2a7e78c75a37..451c64aaec04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3769c3b43c..d68ac97401 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6e80dc5c14..625f969626 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3889691dd6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/82425b6b98..b12d1c836e * tools/luci-go: git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e..git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9 * tools/luci-go: git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e..git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9 * tools/luci-go: git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e..git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/28924eafb2..c2ae4814ba * tools/skia_goldctl/linux: SydJmfq0VW7jq5fTDGtIQ-7WoB0vNc-LJAi3Xd4fKvQC..1TBlbVMfJAvbrsCVFRL54CvG6OJv660nvwlbVn3QedoC * tools/skia_goldctl/mac: oxKWG6EzN6FHwQ-4J6gUYMHuNuHyARpVl4EvirOsXSgC..zFHl-BrDnpmevfoDmWcr04CNai3vqwCPB6AYeJXJ744C * tools/skia_goldctl/win: 4r6X5OSxy-ZDOlqtn41HMmKG2qlEfMNdLwpzyufLFzcC..AefJEwE3M-ke_pwYEVGy2Ct2Ra80EaxvK1KADBuG8-EC No update to Clang. Bug: angleproject:5499 Tbr: timvp@google.com Change-Id: I9f77435fd9cb48cfc3ceec6e2ce98b3d1082da02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2627011 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 2ed9671a 2021-01-12T09:44:03 State: Provide reference to image unit binding vector This allows iterating through the entries without creating a copy of the vector. This was causing an assertion in FrameCapture when deconstructing the copy, which we don't need. RefCountObject.h (~BindingPointer): ! Assert failed in ~BindingPointer (src/libANGLE/RefCountObject.h:93): mObject == nullptr It also probably matches the intent of the function. Test: Aztec Ruins MEC Bug: angleproject:4048 Change-Id: I9588af3859b4d3edb5859530def1bb3992530403 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622610 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 2e9161e4 2021-01-12T11:29:29 Vulkan: Add YUV G8_B8_R8_3PLANE_420_UNORM format. Bug: angleproject:5438 Change-Id: I525a51256a5ee83fa69c8705aa90790fb32a6602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2623813 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop d38b9f86 2020-12-02T09:20:09 Allow GL_OES_shader_image_atomic when non-conformant On Android, force allowing it with: adb shell setprop debug.angle.feature_overrides_enabled \ exposeNonConformantExtensionsAndVersions If enabling multiple features, switch to using settings which don't have a character limit, but persist across reboots: adb shell settings put global angle_egl_features \ exposeNonConformantExtensionsAndVersions:foo:bar Test: Fortnite on ANGLE Bug: b/170755560 Bug: angleproject:5503 Change-Id: I58e3b265daa8ea1f645f47e0971c4454b8ddb3f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2570775 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill fb4eea2e 2021-01-11T16:58:02 Vulkan: Index mandatory support table by ANGLE format. This removes another instance of indexing a flat array by VkFormat. With the introduction of YUV formats we no longer have a compact table. Switching to ANGLE format indexing allows us to keep a flat array and avoid using an unordered map. Bug: angleproject:5438 Change-Id: I96caa19e3b7ce419ce09680399919447f002b0bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622238 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 8db7915e 2021-01-12T10:56:47 Vulkan: Increment buffer view serials only when used This avoids the texel buffer view serials (shared with image view serials) recklessly getting large. Bug: angleproject:5185 Change-Id: I0debe73771094b395f6526475aa3c22a91f9e05e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2623811 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi a4b582e8 2021-01-11T15:31:13 Vulkan: Notify ContextVk when UtilsVk binds compute pipelines This issue was fixed for graphics pipelines (in UtilsVk::clearFramebuffer), but remained for compute pipelines. If UtilsVk issues a dispatch call, it now notifies ContextVk to rebind the pipeline and descriptor sets. Bug: angleproject:5529 Change-Id: Ic52f91bdc70d02c065ec2d5e2a3614c11fd62a9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622236 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll c0ef8ccf 2021-01-12T10:01:07 Roll SwiftShader from 348ba200aa29 to 3549479dc4cc (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/348ba200aa29..3549479dc4cc 2021-01-11 srisser@google.com Define static constexpr members in .cpp files 2021-01-11 srisser@google.com Add VK_EXT_host_query_reset 2021-01-11 srisser@google.com Implement VK_EXT_separate_stencil_usage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ib8b03c92865f73ab8e6464846f988bf09509d6e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2624059 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jonah Ryan-Davis 6e9018bd 2020-06-25T12:58:14 GL: Clean up Display code related to multithreading Rename mCurrentData to mCurrentNativeContexts, and clean up some logic to be easier to read. Bug: angleproject:4724 Change-Id: I6fd6d99d4f9a3af808d0baa665edfbdde7fb0500 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2267424 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi 5b8dec52 2021-01-12T04:11:56 Reland "Use is_apple instead of is_mac and is_ios everywhere" This reverts commit 51603c63d1cb9e36afaf2069fc069e542ac2f3fb. Reason for revert: Fixed issue that broke Skia build Original change's description: > Revert "Use is_apple instead of is_mac and is_ios everywhere" > > This reverts commit 2762641a3a1edf9665a61f40da6c160338056cb0. > > Reason for revert: is_apple is not universally defined. Breaks ANGLE roll into Skia. > > Original change's description: > > Use is_apple instead of is_mac and is_ios everywhere > > > > Bug: chromium:1161513 > > Change-Id: Id7d582f127f4b79ea6fc5b8ad39fff768c45f477 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611312 > > Reviewed-by: James Darpinian <jdarpinian@chromium.org> > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > > TBR=jdarpinian@chromium.org,syoussefi@chromium.org > > Bug: chromium:1161513 > Change-Id: I831e60149f410044a79d9f66aa9ddd9902410fd7 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618039 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> TBR=jdarpinian@chromium.org,syoussefi@chromium.org Bug: chromium:1161513 Change-Id: I3cf30aa047a1f208fa7d1acda1d6d4e5da7b6ad5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622244 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7f0e7d0d 2021-01-12T07:01:16 Roll Chromium from 734de1a6b288 to 2a7e78c75a37 (67 revisions) https://chromium.googlesource.com/chromium/src.git/+log/734de1a6b288..2a7e78c75a37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d599553721..3769c3b43c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d1a3011cd9 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2246bee280..82425b6b98 * tools/skia_goldctl/win: mvme2We4n3wONUhzQu6ATl9Ow4Fb4li6ET-Yhv7Ph3EC..4r6X5OSxy-ZDOlqtn41HMmKG2qlEfMNdLwpzyufLFzcC No update to Clang. Bug: angleproject:5417 Tbr: timvp@google.com Change-Id: I12c9cd047a4f455a8a68fc2dd933f00550bb9f7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622717 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bdbcbe94 2021-01-12T02:39:41 Roll Chromium from 193bb22c8c9d to 734de1a6b288 (311 revisions) https://chromium.googlesource.com/chromium/src.git/+log/193bb22c8c9d..734de1a6b288 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8874a0a063..d599553721 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2277272f7a..235cfe435c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b6a5362054..6e80dc5c14 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b2230ba88f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/01d7e1f0a1..2246bee280 No update to Clang. Bug: angleproject:5417,angleproject:5513 Tbr: timvp@google.com,ynovikov@google.com Change-Id: I20c585cd43b48d2d2a4ada9629511a32b713c986 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622713 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jason Macnak 2c65da28 2021-01-08T11:49:18 Default roll_aosp.sh to copy artifacts to vendor partition ... to support using ANGLE as a native GL driver. Note: this will not affect devices installing the APK with `PRODUCT_PACKAGES += ANGLE` and will *not* also install the libs to vendor. Bug: b/147316305 Bug: angleproject:5456 Test: ./scripts/roll_aosp.sh and build in AOSP Change-Id: I98cab8d0735a4f66293ac063e0eef2ae7ddbee7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618529 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill 2e9706d8 2021-01-08T17:29:42 Vulkan: Use angle::FormatID instead of VkFormat. This change switches the internal enums we pass around from VkFormat to FormatID. The end goal of the refactor is to allow the Vulkan back-end to store packed tables indexed by FormatID. Because VkFormat has large gaps in its enum space we'd otherwise need to use unordered data structures like unordered_map. The change removes the redundant VkFormat storage from vk::Format and uses a new table query to return the VkFormat that 1:1 matches an angle::FormatID. We also include a reverse mapping for use with native Vulkan get functions for Android. Also moves sRGB conversion functions into renderer_utils. A couple sRGB formats that don't exist in GL are no longer handled by the sRGB conversion functions. These formats should be extremely rare. Bug: angleproject:5438 Change-Id: Id8b49773ca0c556f9f5a6a10fcf0d9762b93bbea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618204 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
Stephan Hartmann d21d682d 2021-01-11T12:59:53 libstdc++: fix incomplete type for FramebufferCache libstdc++ does not allow incomplete type for T2 with std::pair<T1,T2> and fails with: .../../src/libANGLE/renderer/vulkan/vk_cache_utils.h:1570:64: required from here /usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/include/g++-v9/bits/stl_pair.h:215:11: error: std::pair<_T1, _T2>::second has incomplete type 215 | _T2 second; /// @c second is a copy of the second object | ^~~~~~ https://chromium-review.googlesource.com/c/angle/angle/+/2580111 added class FramebufferCache with incomplete type in |mPayload| to vk::FramebufferHelper. Changing include order is not an option. However, FramebufferCache is only used in FramebufferVk and we can make it local there. Bug: chromium:957519 Change-Id: I5fbdca23adbb9f4aecc266988c02fb0d051504cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2621473 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Trevor David Black de32c3d2 2020-11-04T13:16:31 Reland "Created test and fixed texture storage bug in d3d11" This is a reland of 03f3ba5b1454ee7c15cd9391e77307cf1d274b48 Original change's description: > Created test and fixed texture storage bug in d3d11 > > Bug: b/172489285 > Change-Id: If7d88cf50d99da3380082c60fb3936ae0b20c4e5 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519876 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: b/172489285 Change-Id: I6b8226164a09aed208c56cb78b5d2c1385298cbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2546034 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Trevor David Black <vantablack@google.com> Commit-Queue: Trevor David Black <vantablack@google.com>
Lingfeng Yang 326f128b 2021-01-07T14:25:44 Vulkan: Prefer host cached memory for Buffers This improves perf because vertex data upload uses host visible memory, and uncached memory can be slow. Test: Android on Windows with 1080Ti: glmark2 [build] vbo=false 265 -> 3900 fps Bug: angleproject:5515 Change-Id: Ib75582bbdb4ca4a22d3a121c7b477a23a8a809ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615742 Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Yuly Novikov 9325fd8b 2021-01-11T13:31:42 Fix iOS build Broken by crrev.com/c/2618040 Bug: angleproject:5417 Change-Id: Id4a81c3e933b679956c82356c14b5639d56b6859 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622234 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 4dd9a5e1 2021-01-11T14:22:44 Enable building angle_white_box_tests on Fuchsia Builds fine. Bug: angleproject:2475 Change-Id: I96b2b03e1be2b801c3d8579ebf44d51b6faa3e57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622235 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Ian Elliott 16dbcc13 2021-01-08T20:50:16 dEQP: Avoid undefined right-shift behavior for GLhalf The FloatToHalf() function in "es31cVertexAttribBindingTests.cpp" will attempt to right-shift more than the number of bits in an integer (i.e. by 70) when converting 0.0f to GLhalf. Bug: angleproject:5500 Change-Id: I587e71a2cb1377b95ed74a1bba5f4ceef6a4a516 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618665 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill cb71062a 2021-01-11T11:31:45 Remove obsolete build flag. No longer necessarry: "linux_use_bundled_binutils_override" Bug: chromium:1164276 Change-Id: Ia670731cba70e4dbb9505480f7bb06060475c3e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622233 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 49d29106 2021-01-11T14:52:34 Roll Chromium from 29d2d6a2d436 to 193bb22c8c9d (106 revisions) https://chromium.googlesource.com/chromium/src.git/+log/29d2d6a2d436..193bb22c8c9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com,borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d1a74631f6..8874a0a063 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..12607ec3c9 No update to Clang. Bug: None Tbr: timvp@google.com,borenet@google.com Change-Id: I6c7a3edf824f7bad503b627bb8198748e81692a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2621713 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c600e478 2021-01-11T10:01:24 Roll vulkan-deps from e395b66ed41c to e59ae1af7571 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e395b66ed41c..e59ae1af7571 2021-01-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f0634ebbb36f to 46237b593c3f (2 revisions) 2021-01-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 702c903f982d to 820179bf4689 (1 revision) 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 04cf3fd95555 to f0634ebbb36f (1 revision) 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from ebd3ea2ecbac to 04cf3fd95555 (2 revisions) 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from ce18d1b8a563 to 702c903f982d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I462ebd004acd91d86ee30c5c78db8b2ca8729e9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2620873 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ffe66b75 2021-01-11T10:01:25 Roll SwiftShader from 937395c1ed5d to 348ba200aa29 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/937395c1ed5d..348ba200aa29 2021-01-10 capn@google.com Eliminate SpirvShaderEnumNames.cpp 2021-01-08 capn@google.com Reduce the LLVM compile layer object lifetime 2021-01-08 capn@google.com Reduce the mangler object lifetime 2021-01-08 capn@google.com Eliminate duplicate LLVM contexts 2021-01-08 srisser@google.com Fix mismatched signedness for a compare in subzero 2021-01-08 capn@google.com Fix missing fields initializers warnings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I4c63d31e3b324dbf1400c7ca4fe58e8067839b15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2620479 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ac05066a 2021-01-11T07:02:16 Roll Chromium from 28ecef438c2c to 29d2d6a2d436 (82 revisions) https://chromium.googlesource.com/chromium/src.git/+log/28ecef438c2c..29d2d6a2d436 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/06eb186470..d1a74631f6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fdaafe276e..b6a5362054 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e174329bab No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Ic0ae8442611bc2c32241cf0f8496f118e6e32dca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2620868 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 0b90eef0 2021-01-09T16:29:03 Roll chromium_revision 1e679b773d..28ecef438c (841389:841845) Change log: https://chromium.googlesource.com/chromium/src/+log/1e679b773d..28ecef438c Full diff: https://chromium.googlesource.com/chromium/src/+/1e679b773d..28ecef438c Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/762c7888b9..06eb186470 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ce1689b82d..fdaafe276e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e174329bab * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c000d6e459..28924eafb2 DEPS diff: https://chromium.googlesource.com/chromium/src/+/1e679b773d..28ecef438c/DEPS No update to Clang. TBR=ynovikov@chromium.org, BUG=angleproject:5417 Change-Id: I247873fe591c915cf1280739eeff98292984a6bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2619938 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 51603c63 2021-01-08T17:49:52 Revert "Use is_apple instead of is_mac and is_ios everywhere" This reverts commit 2762641a3a1edf9665a61f40da6c160338056cb0. Reason for revert: is_apple is not universally defined. Breaks ANGLE roll into Skia. Original change's description: > Use is_apple instead of is_mac and is_ios everywhere > > Bug: chromium:1161513 > Change-Id: Id7d582f127f4b79ea6fc5b8ad39fff768c45f477 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611312 > Reviewed-by: James Darpinian <jdarpinian@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> TBR=jdarpinian@chromium.org,syoussefi@chromium.org Bug: chromium:1161513 Change-Id: I831e60149f410044a79d9f66aa9ddd9902410fd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618039 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten 6e909d94 2020-12-30T19:40:21 Tests: Add Saint Seiya Awakening: Knights of the Zodiac trace Test: angle_perftests --gtest_filter=TracePerfTest.Run/*saint_seiya_awakening* Bug: angleproject:4048 Change-Id: Idf187b9c9298d184f1e0dd13f8a9aa0de7c2beb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2612523 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 7cdda2dc 2021-01-07T16:46:54 Vulkan: Add a perf test for pre-rotation code injection A test is added that dispatches a large number of vertex shaders, generating primitives that are all culled. The vertex shaders are simple so that code injected for pre-rotation would make up the majority of the shader code. Bug: angleproject:5478 Change-Id: I75092cb25e6427449251985f56e54f89813dec32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615821 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 2aa4f7e5 2021-01-08T16:35:29 Fix translator fuzzer Since some ASTs are now disabled on certain conditions, this change lets the fuzzer know when it has generated invalid translator options. Bug: chromium:1164448 Change-Id: I1f1b120c33fb70f9776df858db033ec914d7ad89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618203 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten 767af74e 2021-01-06T17:30:21 Tests: Add World War Doh trace Test: angle_perftests --gtest_filter=TracePerfTest.Run/*world_war_doh* Bug: angleproject:4048 Change-Id: I047ed1ccd06cd3707065fe8afed3ad7af5cd7dcc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606645 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 43366979 2021-01-08T15:39:02 Add OWNERS info for Vulkan test utils. Bug: chromium:1164084 Change-Id: I83cb75f2a0b4ad3f616d1b64beb34310cc23dd12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618202 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Stephen White f4cd1747 2020-12-21T09:57:58 Reland "Changes to build inside a Dawn checkout." This is a reland of 11c31e0a4a73d7d62e765dc7ec400560fbb16b5e I've landed upstream Skia change https://skia-review.googlesource.com/c/skia/+/351496 which should make this safe to reland. Original change's description: > Changes to build inside a Dawn checkout. > > Add an "angle_standalone" flag that can be disabled by Dawn. > Put test definitions behind angle_standalone || build_with_chromium. > > Bug: angleproject:5462 > Change-Id: I58c9b18723384334156e2a3dd86ed3f89afcaade > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2587451 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> Bug: angleproject:5462 Change-Id: I4ff92d45b3692312a004f03b425234b78c5a6219 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618040 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 038ae144 2020-12-31T21:23:30 Vulkan: Fix up varying component limits. We weren't subtracting reserved varying vectors from component limits. We also were using an incorrect value for fragment input components. Bug: angleproject:5496 Change-Id: I44fc3b2f15687f4dee7a1498d50378e69d74afe3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606536 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill e4497d60 2020-12-31T20:12:13 Program: Move more common code to ProgramLinkedResources. Refactoring change only. Bug: angleproject:5496 Change-Id: Ic1c8301a070e91ad28791c23831b8236058ab9ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606535 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 68f35f24 2021-01-07T14:42:57 Vulkan: Add GL_EXT_clip_control entry points Addition of the entry points for GL_EXT_clip_control extension. Bug: angleproject:5471 Change-Id: If17ba0120bdb226cc5728bfea83e9085260eba19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615862 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Jamie Madill fa449cf3 2021-01-06T10:02:12 Fix separable Geometry Shaders. Was a needed fix for a new varying test. Bug: angleproject:3571 Bug: angleproject:5496 Change-Id: I49ae69967510b7a6330ea217a0e0e19e3bebe865 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613198 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 3e33db95 2020-12-30T17:17:17 Merge Program/ProgramPipeline::getMergedVaryings(). This merges two very similar pieces of code into one simpler function. The function doesn't use any maps or indirection to build the merged varyings list. It also fixes a potential bug with IO blocks and name matching due to the code bifurcation. Bug: angleproject:5496 Change-Id: Ibf54faeeb01d1940570b366ed153fff7c9135c52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606533 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll d8ca7d62 2021-01-08T10:01:56 Roll SwiftShader from 7b2f93895418 to 937395c1ed5d (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/7b2f93895418..937395c1ed5d 2021-01-07 caramelli.devel@gmail.com Add Direct-to-Display support using KMS/DRM 2021-01-07 srisser@google.com Add structs for VK_KHR_vulkan_memory_model If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Iaa11e1b25da9d180081b5b4b0b31c5f655aeb263 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617316 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7373f631 2021-01-08T10:00:59 Roll vulkan-deps from c493c6112021 to e395b66ed41c (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c493c6112021..e395b66ed41c 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 0e5078dc0cfb to ce18d1b8a563 (1 revision) 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 134a52003407 to 0e5078dc0cfb (1 revision) 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 234c65c0f32c to 134a52003407 (1 revision) 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from ad77ed7a8d52 to f3ccb633dfd7 (1 revision) 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 9f10caf9c4f3 to ebd3ea2ecbac (2 revisions) 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from cc435b55410a to 9f10caf9c4f3 (2 revisions) 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from aa005e8bd435 to ad77ed7a8d52 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ic5ca5fd78243ad6d37e1b8e046e92ee74f88490b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2616969 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b7d9a02c 2021-01-08T07:01:14 Roll Chromium from 730c6584bcc6 to 1e679b773de8 (438 revisions) https://chromium.googlesource.com/chromium/src.git/+log/730c6584bcc6..1e679b773de8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e4c5e3e1a0..762c7888b9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d17dcf3607..ce1689b82d * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/78f99e18e9..cadb7225e4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e174329bab * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e8d041d679..01d7e1f0a1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f8570240b7..c000d6e459 * tools/skia_goldctl/linux: C_u9-R-I-yQyomb3Y-XIH8Ad3Ya4ZWi2MpPiFTtfHz4C..SydJmfq0VW7jq5fTDGtIQ-7WoB0vNc-LJAi3Xd4fKvQC * tools/skia_goldctl/mac: H_4GgcW8CtnxDnWd7RX17C39CAYzfHUaFR6drL3wWAcC..oxKWG6EzN6FHwQ-4J6gUYMHuNuHyARpVl4EvirOsXSgC * tools/skia_goldctl/win: FzQDQOcAASIc0LaD9YBjqH2JPm0HbYCE2x0WXw2xpz0C..mvme2We4n3wONUhzQu6ATl9Ow4Fb4li6ET-Yhv7Ph3EC No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Icd5f9ab05c0784d31b353554e003290cda9fada0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617241 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi f99ccb08 2021-01-06T23:29:21 Vulkan: Add a perf warning when dropping superseded updates If an update to an image subresource is entirely superseded by a following update, the former update is dropped. This change adds a perf warning for this. Bug: angleproject:3461 Change-Id: Iaf4984ba52f3dfc86d5cc87f8be82123badebd04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613203 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jonah Ryan-Davis a392a81d 2021-01-06T12:26:44 GLX: Avoid creating child window when X visual ID is specified. ANGLE's GLX backend creates a child ID because the visual of the X window must match that of the GLX window, and we can't always be certain. EGL_ANGLE_x11_visual allows applications to specify the visual ID of the window passed to ANGLE via EGL_X11_VISUAL_ID_ANGLE. When this is the case, we don't need to make a child window. Since Chrome always passes this information, this may help optimize ANGLE's GLX usage in Chrome, because we don't have to poll the parent window to manage the child window's properties. Bug: chromium:1132827 Change-Id: If8082d2d07469905afffab01dde2ec9fca8d4eb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611556 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tim Van Patten 2d1406a8 2020-12-29T18:11:33 Capture/Replay: Capture glBindBufferBase during MEC setup "World War Doh" binds uniform buffers via glBindBufferBase() calls before any frames have rendered and then uses those bound buffers for all subsequent frames. ANGLE's frame capture was failing to perform these calls during the mid-execution capture setup phase, leading to the replay generating VVL errors: VUID-vkCmdDispatch-None-02699 Descriptor in binding #0 index 0 is being used in draw but has never been updated via vkUpdateDescriptorSets() or a similar call. This CL adds those calls to the MEC setup phase, allowing the replay to execute without any errors. Bug: angleproject:5495 Test: angle_perftests --gtest_filter="*world_war_doh*" Change-Id: I751c9c6f60bf78c13428a9d1d6a06dbfe600c24b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606806 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi a7158eb5 2021-01-06T21:33:24 Vulkan: Fix image leak in staged updates in ImageHelper When removing superseding updates, the superseded update was not released, causing a memory leak. This change also makes SubresourceUpdate non-copyable and correctly implements the move assignment operator such that swap between different update types are correct. As a result, the destructor can now ASSERT that the image is not leaked. Bug: chromium:1146516 Bug: chromium:1163354 Change-Id: I7531c91d8559c23b2e09159118fe645d12fc601f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613201 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 157ddfdc 2021-01-06T23:20:36 Build compiler_tests only if GLSL or ESSL build is enabled Most of these tests use TranslatorGLSL or TranslatorESSL (often through ShaderCompileTreeTest). In specialized builds that disable GLSL and ESSL shader generation, disable these unit tests. Bug: chromium:1161513 Change-Id: Ib87e651706f141a41ffdaebfb0cbe5168582e341 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613202 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang acdb63b8 2020-12-23T12:57:08 Remove the checking before accessing to function pointers Bug: angleproject:5490 Bug: chromium:1161513 Change-Id: I96c5c463a9fd5a337d09f6cefe7836ff52bea90f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601071 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
angle-autoroll d0a38010 2021-01-07T10:01:59 Roll vulkan-deps from cbab637962d0 to c493c6112021 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/cbab637962d0..c493c6112021 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 7b7a21c4058c to 234c65c0f32c (3 revisions) 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 480f6039e072 to 3de5cfe50ede (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 4cc0932495ec to a7825740f316 (3 revisions) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 4ed1f4fce9e7 to aa005e8bd435 (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from af3a3d481f6e to 4ed1f4fce9e7 (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 94d1a80159e3 to af3a3d481f6e (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 98382948dfea to cc435b55410a (2 revisions) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f77085c307fc to 480f6039e072 (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 6d05ed8410b4 to 94d1a80159e3 (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 37c03859de9e to 6d05ed8410b4 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ibff53e4a69b1a9291679f352a5fe6e7e8b70de50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613796 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll aa5457dd 2021-01-07T10:01:55 Roll SwiftShader from b9e179f1f239 to 7b2f93895418 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/b9e179f1f239..7b2f93895418 2021-01-07 capn@google.com Fix implicit inexact conversion If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I77ee81cc4f9a8828ef46bf77113fcd6da008dd39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613890 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 35b6156b 2021-01-07T07:01:42 Roll Chromium from 38610c881952 to 730c6584bcc6 (444 revisions) https://chromium.googlesource.com/chromium/src.git/+log/38610c881952..730c6584bcc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/65cd1b9efa..e4c5e3e1a0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3c84fe5c3f..d17dcf3607 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ae206b8b8d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/77a111142a..f8570240b7 * tools/skia_goldctl/linux: CQ5a33Wu9Sm6bRTrd26RFsJVr42IoKD4Ediyp7eyuwwC..C_u9-R-I-yQyomb3Y-XIH8Ad3Ya4ZWi2MpPiFTtfHz4C * tools/skia_goldctl/mac: AXBg8ZzAzlIdv0U_KR8dr92w1szmAp-MB0Z9ZYBmFy4C..H_4GgcW8CtnxDnWd7RX17C39CAYzfHUaFR6drL3wWAcC * tools/skia_goldctl/win: slJNuZyzBI9lNI9Uje1a2fiVtubv8LEBgUZLFdHZjssC..FzQDQOcAASIc0LaD9YBjqH2JPm0HbYCE2x0WXw2xpz0C No update to Clang. Bug: angleproject:2926,angleproject:2939,angleproject:3481,angleproject:3741,angleproject:4286,angleproject:4539,angleproject:4569,angleproject:4846 Tbr: ianelliott@google.com Change-Id: Id567e30b16d04e96c869ad3058b03829a9035458 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2614267 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi e2a8a69a 2021-01-04T23:52:02 Vulkan: Move xfb emulation offset calculation to translator A new function is added by the translator to calculate the transform feedback offsets in the emulation path. This function makes the generated code for transform feedback smaller. Bug: angleproject:3606 Change-Id: I01460f907e20e2887cb720bddad96697fdcb0cf3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2607492 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 07d619cb 2021-01-06T11:36:40 Vulkan: Fix missing xfb buffer rebind on new command buffer When a command buffer is ended, bindings are lost. This adds a dirty bit to `mNewGraphicsCommandBufferDirtyBits` to make sure transform feedback buffers are bound again on the new command buffer. Bug: angleproject:5428 Change-Id: I7733c93b1eb5d33a77cbee231a83199be950e19f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611552 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 5e280545 2021-01-06T14:13:29 Move RegenerateStructNames AST transformation to gl/ This AST transformation is used by the chromium validating command decoder on Linux/AMD/GL as well as MacOS. Bug: chromium:1161513 Change-Id: I67e40215ae5576819ba5a58987ceb1776c86c731 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613195 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi ca94d1da 2021-01-04T21:51:33 Vulkan: Refactor generated code in xfb emulation path The index expression was regenerated for every component written to the output. This change refactors the generated code such that common values are calculated once. This is in preparation for moving some of this code to the translator and reducing the amount of code generated at link time. Bug: angleproject:3606 Change-Id: Ib180d245218f8f6f18c57c0ea092e8c45cbffd1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2607490 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Yuly Novikov 46d3f02a 2021-01-05T17:56:24 Suppress dEQP.KHR_GLES31/core_vertex_attrib_binding_basicinputcase5 on Vulkan Pixel2 and SwiftShader. Ignore device and vendor in test config if we are running on SwiftShader. Bug: angleproject:5500 Change-Id: Ib07240dfe1c2ae1d6d081ffa389d041d97b22b36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611309 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
James Darpinian ebf00703 2020-12-29T16:25:54 angle_end2end_tests passes on iOS! Miscellaneous test skips and fixes for iOS. Bug: angleproject:5417 Bug: angleproject:5491 Change-Id: Id0785e6243949fc756e4d7923dbbe77a411052f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606656 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Shahbaz Youssefi 2762641a 2021-01-05T23:00:14 Use is_apple instead of is_mac and is_ios everywhere Bug: chromium:1161513 Change-Id: Id7d582f127f4b79ea6fc5b8ad39fff768c45f477 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611312 Reviewed-by: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 1d6329b3 2021-01-06T14:33:26 Update auto-roller docs with vulkan-deps repo. Bug: angleproject:5390 Change-Id: If5edba51b0fdbaee36e0ab31a176f809b1ace38a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613196 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 56479b06 2020-12-21T13:03:50 Tests: Add FIFA Mobile trace Test: angle_perftests --gtest_filter=TracePerfTest.Run/*fifa_mobile* Bug: angleproject:4048 Change-Id: I5cc731ada3ddd9adcb247d7c6f8cf5d823bdc2a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600098 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Jonah Ryan-Davis 956a358d 2020-12-23T15:43:00 GL: Add function pointers for EXT/NV_framebuffer_blit Allow the GL backend to call BlitFramebuffer through these extensions. Bug: angleproject:5474 Change-Id: Ic19b0535056c3e2b098dedc60e2eb8da5f862433 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2602702 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill dc2cf6fc 2021-01-06T11:35:53 Roll third_party/vulkan-deps/ b08eace32..cbab63796 (17 commits; 1 trivial rolls) https://chromium.googlesource.com/vulkan-deps/+log/b08eace32e9c..cbab637962d0 $ git log b08eace32..cbab63796 --date=short --no-merges --format='%ad %ae %s' 2021-01-06 chromium-autoroll Roll SPIRV-Tools from d630e5f8c10c to 37c03859de9e (1 revision) 2021-01-06 chromium-autoroll Roll Vulkan-ValidationLayers from 2468aa9630c2 to 98382948dfea (1 revision) 2021-01-06 chromium-autoroll Roll SPIRV-Tools from 1bb80d2778a3 to d630e5f8c10c (1 revision) 2021-01-06 chromium-autoroll Roll glslang from 9325cc013e3d to f77085c307fc (1 revision) 2021-01-05 chromium-autoroll Roll Vulkan-ValidationLayers from 57255a663ed9 to 2468aa9630c2 (1 revision) 2021-01-05 chromium-autoroll Roll Vulkan-Loader from 1f0c7868a438 to 9ba835885ffe (1 revision) 2021-01-05 chromium-autoroll Roll Vulkan-ValidationLayers from 56a96658b750 to 57255a663ed9 (3 revisions) 2021-01-05 chromium-autoroll Roll Vulkan-Loader from 294480cb7f3e to 1f0c7868a438 (1 revision) 2021-01-05 chromium-autoroll Roll Vulkan-Tools from 7554321b88ae to 4cc0932495ec (2 revisions) 2021-01-05 chromium-autoroll Roll Vulkan-Loader from 66a23ac8c566 to 294480cb7f3e (1 revision) 2021-01-05 chromium-autoroll Roll Vulkan-Headers from 85470b32ad5d to 9efc4a631161 (1 revision) 2021-01-05 chromium-autoroll Roll Vulkan-ValidationLayers from aa076dae88e2 to 56a96658b750 (25 revisions) 2021-01-05 chromium-autoroll Roll glslang from f426f652299d to 9325cc013e3d (1 revision) 2021-01-05 chromium-autoroll Roll SPIRV-Cross from e50f7d1ce8e1 to 7b7a21c4058c (3 revisions) 2021-01-05 chromium-autoroll Roll SPIRV-Tools from 17ffa89097b2 to 1bb80d2778a3 (1 revision) 2020-12-21 jmadill Rolling 8 dependencies Created with: roll-dep third_party/vulkan-deps Bug: angleproject:5390 Change-Id: I6f4a499099211e8990ed038984f41bc5f881c71f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601340 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill d9669322 2020-12-30T14:33:02 Remove "init" from VaryingPacking. Instead we can pass the pack mode and size to the collectAndPack method. This cleans up the interface and also allows us to merge two separate code blocks in Program and ProgramPipeline. Bug: angleproject:5496 Change-Id: I390b5d2e8a3b033374ccc5a250597be1f03dec96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606531 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill d33ffb22 2020-12-30T11:14:00 Organize VaryingPacking methods. This clarifies the difference between "collect" and "pack" methods. Previously the naming was overlapping between the two. Also makes the "packUserVaryings" method private. Refactoring change only. Will enable further improvements for capturing varyings with multiple shader stages. Bug: angleproject:5496 Change-Id: I854590ceab39f3a0e7a785516e0d1fd44e4ccc98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606529 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 92e7bc89 2020-12-23T15:18:42 Remove ProgramLinkedResources from ProgramExecutable. Instead of storing the entire LinkedResources struct, we can keep it only for the duration of the linking calls. Refactoring change only. It sets the stage for more refactoring. This change also switches the link call to use LinkingState's ProgramLinkedResources directly to avoid the need to copy the varying packing or use a pointer. Bug: angleproject:4514 Bug: angleproject:5496 Change-Id: Iefea3c16a33213dc338cc54efaa7c3064ea6ae08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601403 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tim Van Patten e09e947d 2020-12-29T18:21:36 Capture/Replay: Don't force built-in attribs to have a location CaptureMidExecutionSetup() hits an assert while capturing "World War Doh": ANGLE : FATAL: FrameCapture.cpp:2876 (CaptureMidExecutionSetup): ! Assert failed [[[...]]] attrib.location != -1 This is due to CaptureMidExecutionSetup() enforcing that all attributes, including built-ins, have a location. However, in the case of "World War Doh", the built-in 'gl_GlobalInvocationID' does not have a location. Moving the assert to after the gl::IsBuiltInName() check allows the capture to complete without hitting any asserts. Bug: angleproject:4048 Test: Capture "World War Doh" Change-Id: Ice96dec629b1477b11a710283c4ec4bf1c95c6e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606807 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi bf6cc88a 2021-01-05T22:17:41 Vulkan: Remove duplicate shaderType parameter to SPIR-V transformer The passed-in GlslangSpirvOptions already has the shaderType, so this extra parameter was not necessary. Bug: angleproject:4524 Change-Id: Ibbc7442b3173b26825f3cb9e2365789fade92cfc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611311 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll a8b962b7 2021-01-06T07:01:32 Roll Chromium from 481852c5d89b to 38610c881952 (120 revisions) https://chromium.googlesource.com/chromium/src.git/+log/481852c5d89b..38610c881952 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/505140eae0..65cd1b9efa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c83cdcc501..3c84fe5c3f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6c876045de * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1c129d6fca..77a111142a No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Ia2de17b882601cc3c149466df58c8537df335e38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2612765 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8ef86071 2021-01-06T10:01:55 Roll SwiftShader from ff29e249d317 to b9e179f1f239 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ff29e249d317..b9e179f1f239 2021-01-05 capn@google.com Clarify 3-level caching of sampling routines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I480ec54ea1275dd8f0285dd05aa432dfe30e2219 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2612812 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 382bf288 2020-12-24T23:56:39 Organize AST transforms per backend Most of the AST transforms are written as a workaround to an issue that affects a single backend. This change identifies such transforms and organizes them by backend. They are then only built if the respective backend is. Additionally, about half of the GL transforms are due to mac workarounds, including the large RewriteRowMajorMatrices transform. Mac-specific workarounds are additionally only built on said platform. This change reduces the ANGLE binary size: - 106KB in a Vulkan-only build on Linux - 27KB in a GL-only build on Android (60KB on Linux) Bug: chromium:1084580 Bug: chromium:1161513 Change-Id: I64b334332c0d4f848756c6538af0d8d96864c7e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601346 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Yuly Novikov b590fd1b 2021-01-05T18:53:42 Roll chromium_revision b5dfde1f4d..481852c5d8 (840075:840387) Change log: https://chromium.googlesource.com/chromium/src/+log/b5dfde1f4d..481852c5d8 Full diff: https://chromium.googlesource.com/chromium/src/+/b5dfde1f4d..481852c5d8 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dc0b854645..505140eae0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f7473fcfe3..c83cdcc501 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6c876045de * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7316ebd31b..e8d041d679 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bd7d73d146..1c129d6fca * tools/skia_goldctl/linux: h8KxWs4p5Ox0HAM1_xkOEZT6ctPb1Rfi3qeXr_mmL2YC..CQ5a33Wu9Sm6bRTrd26RFsJVr42IoKD4Ediyp7eyuwwC * tools/skia_goldctl/mac: LNZgcy3MnDuxTfNU14P35CMe60eSA5owlqW81AdRROIC..AXBg8ZzAzlIdv0U_KR8dr92w1szmAp-MB0Z9ZYBmFy4C * tools/skia_goldctl/win: uyDrAODdxxnyC-OmE4swqMJGVNnO4tK6XpC4VfbZf-gC..slJNuZyzBI9lNI9Uje1a2fiVtubv8LEBgUZLFdHZjssC DEPS diff: https://chromium.googlesource.com/chromium/src/+/b5dfde1f4d..481852c5d8/DEPS No update to Clang. TBR=ynovikov@chromium.org, BUG=angleproject:4483 Change-Id: If6d8f6765fa8c886f10b69759d1086925bc87847 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611310 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill e91097bf 2020-12-29T14:05:56 Vulkan: Clean up "actual"/"intended" naming. Clarifies that the GL internal format is an "intended" format and the Vulkan formats are "actual" formats. This makes all the format fields use the same consistent naming pattern. Bug: angleproject:5438 Change-Id: I935a49895109e9e06eae5ef98d5614dfd1128ff8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2605728 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 973bd4ba 2020-12-21T13:45:36 Complete I/O block GLSL tests The tests meant to perform a draw call and validate the correctness of the shaders. Bug: angleproject:3580 Change-Id: I3a008d204ae3d7dceb731ba7a815ab54f38c2920 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2599938 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi aff17499 2020-12-23T14:40:06 Vulkan: Directly capture non-gl_Postion builtins Building on support for transform feedback capture of I/O block members, this change optimizes capture of builtins other than gl_Position by directly decorating members of gl_PerVertex. Most importantly, this allows us to reserve only one varying for transform feedback, instead of as many builtins there could be (up to 4). Bug: angleproject:3606 Change-Id: Ie0957802c657ed6c5aac538d92b860582ed6da45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601072 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
James Darpinian b6ea6edc 2020-12-29T16:30:29 Remove tabs from volk.c/h WebKit's SVN continues to abhor tabs. Bug: angleproject:3439 Change-Id: Ib97fc97c0eb7401f73ea493a7b679f78afc1a8c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606658 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
angle-autoroll 07dea837 2021-01-05T07:01:32 Roll Chromium from 094b96f7f336 to b5dfde1f4de5 (71 revisions) https://chromium.googlesource.com/chromium/src.git/+log/094b96f7f336..b5dfde1f4de5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/46adc39ea7..dc0b854645 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2f17932ea4..f7473fcfe3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1283870fa3..7316ebd31b No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Ib53d1864759822c3338b6be8e442f041eb1a8aeb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2610343 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 026a067c 2021-01-04T07:45:32 Roll Chromium from c95903c7ee26 to 094b96f7f336 (125 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c95903c7ee26..094b96f7f336 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5e2e476cc1..46adc39ea7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/84cd1053bd..2f17932ea4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: I89ba42868c659dcf92312baef029f13fec941489 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2609813 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bf02c31b 2021-01-01T07:01:32 Roll Chromium from 9642fd0da169 to c95903c7ee26 (32 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9642fd0da169..c95903c7ee26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2f9b06d9ef..5e2e476cc1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/77dd9d2973..84cd1053bd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: Ib06c560e55e19f3a088cb20a448e5e2646d938eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2608526 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2cbcb18e 2020-12-31T10:01:55 Roll SwiftShader from 1cc5b3357d2f to ff29e249d317 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/1cc5b3357d2f..ff29e249d317 2020-12-30 srisser@google.com Add support for Vulkan12Properties If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ieec6bb7458ee0764b75ea507e510a19e04f4dfb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2607999 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 022b0026 2020-12-31T07:01:32 Roll Chromium from 03e3aa54c18c to 9642fd0da169 (135 revisions) https://chromium.googlesource.com/chromium/src.git/+log/03e3aa54c18c..9642fd0da169 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1016d674b3..2f9b06d9ef * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c98004c99f..77dd9d2973 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ea63baff14..78f99e18e9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b * tools/skia_goldctl/linux: Ac-h0vLh65FkA8CAYh5B6yg9X0l3cJFf5XCZkVByG1AC..h8KxWs4p5Ox0HAM1_xkOEZT6ctPb1Rfi3qeXr_mmL2YC * tools/skia_goldctl/mac: NYEeKAWq6p8n1jHl0h3emCE3hdfWkaYbeoEPrnFO5dEC..LNZgcy3MnDuxTfNU14P35CMe60eSA5owlqW81AdRROIC * tools/skia_goldctl/win: HHMFtoVyIQfQIhJgSOb5RkIHwzApVNZXRtDNjBCx3tEC..uyDrAODdxxnyC-OmE4swqMJGVNnO4tK6XpC4VfbZf-gC No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: Ia03ced387f7d03292955339b7b8d073877ddb10a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2607780 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peng Huang 2ec7d750 2020-12-30T10:52:23 Disable null backend on Android This change saves 6.6KB on Android Bug: angleproject:5490 Bug: chromium:1161513 Change-Id: I14636694ed7bff61accfac934fbbf6f619d2f6b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606528 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
James Darpinian 6c608e94 2020-12-29T16:24:08 iOS sRGB mipmap generation is broken too Enable the encodeAndDecodeSRGBForGenerateMipmap workaround for iOS. Bug: angleproject:5417 Change-Id: I39d9e7c371f0ee5ec5119669f3b855251691f9e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606657 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Jonah Ryan-Davis fb35201a 2020-12-22T13:14:41 GL: Expose NV_framebuffer_blit for ES2 contexts when available ANGLE_framebuffer_blit is already exposed but has restrictions on scaling/flipping and mismatched color buffer formats. When NV_framebuffer_blit, EXT_framebuffer_blit, or an ES3 context is available we can expose a less restrictive BlitFramebuffer. Bug: angleproject:5474 Bug: chromium:1157057 Change-Id: I916ee39c8d6120216f91461080eb3ee9ca777e29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601165 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 93839986 2020-12-30T07:00:32 Roll Chromium from aba6331a18cb to 03e3aa54c18c (163 revisions) https://chromium.googlesource.com/chromium/src.git/+log/aba6331a18cb..03e3aa54c18c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7dcf5f0e82..1016d674b3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/767dddd781..c98004c99f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: I48bc7af0fc75d2c76ead9205ad34421c239e3b95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606402 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Qin Jiajia de62b251 2020-12-29T17:07:06 Make sure the queried resources are active In GLES 3.1 spec, sesion 7.3.1 program interfaces, it says that 'Resources referenced in shader code are considered active unless the compiler and linker can conclusively determine that they have no observable effect on the results produced by the executable code of the program.'. Variables might be considered inactive if they are used only in computations of temporary variables having no effect on any shader output. So we should use atomicCounterIncrement instead of atomicCounter in case the resources are marked as inactive on some platforms. Bug: angleproject:5494 Change-Id: Ic04bd4a2936e97776fc680b5ef8273f0944d7480 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2605917 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Peng Huang 47ee6a7b 2020-12-23T13:31:23 Add build flags to disable desktop gl backend This change saves about 100KB on Android Bug: angleproject:5490 Change-Id: Ieca0e597423f74a917197f381560af5409a9e874 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601341 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Jamie Madill 093250e0 2020-12-23T12:07:46 Vulkan: Make shader variable info maps a class. Instead of using a map type directly we abstract the info maps into an encapsulated class. We can enforce a specific API set instead of using the same API as the map class. This also cleans up a few of the APIs related to these maps. This change will allow future changes to the way the variables are stored in the class without drastically changing the interface. Bug: angleproject:3572 Bug: angleproject:4524 Change-Id: Ic1a63e1776c39f49b895a1274bae8282d7a6b9b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600080 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Tom Anderson c2847bbc 2020-12-23T15:59:59 [GLX] Don't request exposure events for child windows After [1], Chrome and ANGLE use separate X11 connections, so in order for Chrome to receive exposure events, it must select for them its own connection, which is done in [2]. The events selected by ANGLE's connection are never dispatched, so they queue up indefinitely and leak until the connection is closed (when happens when Chrome closes). This change removes the request to receive exposure events. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2492177 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2602441 Change-Id: Ie47c3700855aeeecc8efa1b379df60c344b1b70a Bug: chromium:1158170 R=jonahr Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2602705 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll 095fd1d3 2020-12-29T07:01:32 Roll Chromium from e02e8b371308 to aba6331a18cb (134 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e02e8b371308..aba6331a18cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ffd4756efa..7dcf5f0e82 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cba08c42d7..767dddd781 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: I1aafc49da55631bc5ade1dc673a5ac50015bc3bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2605988 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 220642a9 2020-12-16T21:10:37 Allow Drawing with Immutable Persistent Mapped Buffers From the EXT_buffer_storage overview: The GL_EXT_texture_storage extension added immutable storage for texture objects (and was subsequently incorporated into OpenGL ES 3.0). This extension further applies the concept of immutable storage to buffer objects. [T]his extension introduces the concept of persistent client mappings of buffer objects, which allow clients to retain pointers to a buffer's data store returned as the result of a mapping, and to issue drawing commands while those mappings are in place. The initial implementation of EXT_buffer_storage didn't enable this portion of the extension, so ANGLE is generating errors while attempting to draw with an immutable buffer mapped with the GL_MAP_PERSISTENT_BIT flag. This CL enables that functionality, since apps (e.g., FIFA Soccer) rely on it. Bug: angleproject:5473 Change-Id: Icf1c0597156044a342aac5e4d2abbc29b34f46b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2596957 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
angle-autoroll bc06d145 2020-12-28T07:01:32 Roll Chromium from abaaee149813 to e02e8b371308 (106 revisions) https://chromium.googlesource.com/chromium/src.git/+log/abaaee149813..e02e8b371308 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ff0b5c1349..ffd4756efa * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ea9f1f7375..2277272f7a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/38dfc9d41a..cba08c42d7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Idbdd8032cf051b2f5b8f33af16338be8d36b43e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2604769 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5e606e5b 2020-12-25T07:24:35 Roll Chromium from 8baa5d6f121f to abaaee149813 (66 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8baa5d6f121f..abaaee149813 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fffb44c47e..ff0b5c1349 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f9f9a7c26e..38dfc9d41a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ie88c73237d45dd53a0572fd4148aacbe1ce174c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2603551 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi c6e63da8 2020-12-24T21:32:42 Suppress IOBlocksSeparate xfb test on AMD/Linux/GL Bug: angleproject:5487 Bug: angleproject:5493 Change-Id: I6e15c35eacafef0ac4b7c7789619470501e31402 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601345 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 9f0748ea 2020-12-24T16:05:24 Skip TransformFeedbackTestES31.IOBlocks* on Linux AMD Vulkan Bug: angleproject:5493 Change-Id: I5e0b0ec478807ebfe7a0ec114adaba13ea103ea0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601344 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 26c8aaad 2020-12-24T07:01:36 Roll Chromium from 75537d54458b to 8baa5d6f121f (63 revisions) https://chromium.googlesource.com/chromium/src.git/+log/75537d54458b..8baa5d6f121f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/49a440c36a..fffb44c47e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ifed577c2fa17724f4629352d68fc555fa7747fb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2602788 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
James Darpinian cde0e3ab 2020-12-22T16:38:47 Don't use optional BGRA_EXT by default It's not currently exposed on iOS. Bug: angleproject:5417 Change-Id: I2564d3363f8f8bddad4da7d8a9d7dac9bea15897 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600454 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
James Darpinian 939195a0 2020-12-23T15:12:30 Skip tests using unimplemented features on iOS Bug: angleproject:5485 Change-Id: I3248126060b9957596f65221c60f42f213e9a9dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601377 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0