Log

Author Commit Date CI Message
angle-autoroll b0e9cd66 2020-02-20T07:01:02 Roll third_party/vulkan-loader/src 39e685ccd37e..c357af84c7cb (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/39e685ccd37e..c357af84c7cb git log 39e685ccd37e..c357af84c7cb --date=short --first-parent --format='%ad %ae %s' 2020-02-19 lenny@lunarg.com loader: Remove queue info count check Created with: gclient setdep -r third_party/vulkan-loader/src@c357af84c7cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I6c9c43a48864722c9d1a137eecbac38847c6d6d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066051 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 2801bf43 2020-02-19T15:39:17 Add .vscode to .gitignore Visual Studio Code project file. Bug: None Change-Id: I4dddee7c1e14a6bf601bd79ebca0e107829b0d65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2062746 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 49010904 2020-02-15T12:21:17 Refactor test parameters to TracePerfTest. Reduces much of the code duplication by adding some new helper methods. The helpers allow combining test parameters similarly to how the GoogleTest Combine() and Values() generators work. They are more general and work by returning collections of test parameters instead of combining generator functions. Also updates the GLMark2 benchmark runner to use the new methods. Bug: angleproject:3630 Change-Id: Ibc10f9afb401e119d67a7119974a1a8d9b5abb60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057353 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 25097b6c 2020-02-19T08:07:23 Vulkan: Lift failing test suppression. EGLContextSharingTest.DeleteReaderOfSharedTexture/ES2_Vulkan Passes with the new command graph linearization. Bug: angleproject:4130 Change-Id: Ic7233696d2c06303ddf46947610b793a1a9e8a65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063041 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 113d0002 2020-02-19T12:09:39 Roll chromium_revision 8ffb18d0b9..a9ad696264 (736949:742676) Change log: https://chromium.googlesource.com/chromium/src/+log/8ffb18d0b9..a9ad696264 Full diff: https://chromium.googlesource.com/chromium/src/+/8ffb18d0b9..a9ad696264 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e5293d8fa2..5499c7c1d6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cf6ed46cff..177ef69e99 * third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/c83f99e10c..703ca235f0 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/b9b9a5af7c..c2eb8a7f7a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/953ea7aff8..eeaa53b76f DEPS diff: https://chromium.googlesource.com/chromium/src/+/8ffb18d0b9..a9ad696264/DEPS Clang version changed eaabaf7e04fe98990a8177a3e053346395efde1c:c29003813ab9bd6ea7b6de40ea8f1fe21979f13f Details: https://chromium.googlesource.com/chromium/src/+/8ffb18d0b9..a9ad696264/tools/clang/scripts/update.py TBR=ynovikov@chromium.org, Bug: chromium:1050703 Change-Id: Ic3b5104698fe7c1a8d95b22fee164af1b8d3c02c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2064067 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Pierre-Marc Berube 9a481b6e 2020-02-18T19:21:34 Add missing #include to fix build with GCC 10. Bug: angleproject:4389 Change-Id: I4a2f04a12a059924871f5d54f137c67670747ebd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063042 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill ee0498b9 2020-02-15T09:24:03 GN: Update trace tests build. Includes two small fixes: - add .gitignore for trace tests. - fix path for restricted traces, should fix bots. Bug: angleproject:4386 Change-Id: I51c657c4f2e772411e95faa76188d43c8b6981f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057350 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 1f5f7ea3 2020-02-14T23:39:11 Vulkan: Fix SPIR-V transformation name-info association Prior to this commit, when "OpName %id name" was encountered, the info corresponding to "name" was immediately associated with %id. This is not necessarily correct because there could be multiple ids with the same name. For example a sampler declaration and an unrelated function argument could have the same name. In this case, the sampler declaration and function argument name don't even need to be in the same shader stage. This change modifies the SPIR-V transformation such that the name-id mapping is tracked until the OpVariable instruction that actually declares the variable is visited. The mapping to variable info is only done if the storage class specified in this instruction corresponds to a shader interface variable. Bug: angleproject:3394 Change-Id: I35a1f6f8278e4b1ad81c9955a55e1b72d6f2e4ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057248 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Ethan Lee 4b4ea4be 2020-02-03T09:48:09 Remove getIndexRange call from ValidateDrawRangeElementsBaseVertex This is essentially the same commit as fed0dda, but with the BaseVertex variant. Bug: angleproject:4373 Change-Id: I2d6fe46a0e8ce5faa8c92d4db6909f8cabd9692f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2032972 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll c5b227ba 2020-02-19T07:01:02 Roll third_party/vulkan-loader/src 0bd30e43c007..39e685ccd37e (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0bd30e43c007..39e685ccd37e git log 0bd30e43c007..39e685ccd37e --date=short --first-parent --format='%ad %ae %s' 2020-02-18 bas@basnieuwenhuizen.nl loader: Deal with failure loading implicit layer libraries. 2020-02-18 georg.m.lehmann@gmail.com loader: correct the name of vkNegotiateLayerInterfaceVersion Created with: gclient setdep -r third_party/vulkan-loader/src@39e685ccd37e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I6f92fecb5ea14e14fdabe7e73d7f4327c0dacb25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2064049 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9b731d47 2020-02-19T07:01:29 Roll third_party/vulkan-tools/src fb2272297f00..16cf5591e399 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/fb2272297f00..16cf5591e399 git log fb2272297f00..16cf5591e399 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 shannon@lunarg.com build: Update known-good for 1.2.133 header Created with: gclient setdep -r third_party/vulkan-tools/src@16cf5591e399 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I92325cf3cf797b12eeafd8c1b52f38dfd6cc1736 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2064052 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bbd00336 2020-02-19T07:01:07 Roll third_party/spirv-tools/src 77fefe765c06..79f8caf9154a (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/77fefe765c06..79f8caf9154a Created with: gclient setdep -r third_party/spirv-tools/src@79f8caf9154a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ia851eb56702cc4c02ccd238ad4c49ad9f31ca91f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063813 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 54d1b383 2020-02-19T07:01:08 Roll third_party/SwiftShader 0bbf7ba9f909..8def9063c4fd (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/0bbf7ba9f909..8def9063c4fd git log 0bbf7ba9f909..8def9063c4fd --date=short --first-parent --format='%ad %ae %s' 2020-02-18 cwallez@chromium.org Only call updateBorders on ranges that can be cubemaps. 2020-02-18 capn@google.com Fix sRGB conversion precision issues Created with: gclient setdep -r third_party/SwiftShader@8def9063c4fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ib73fd3373ba4065034921e8bfed97cb4583a5388 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063814 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 0b41c4af 2020-02-17T17:28:58 Reland "Use newer OSX SDK for iOS" This is a reland of 192da9d76fef6012245473c92b9dfcb607848e6a Re-land after OS upgrade to 10.15. Original change's description: > Use newer OSX SDK for iOS > > Based on http://crrev.com/c/2056465 > > Bug: chromium:1052887 > Change-Id: I2f76067883ff528ca45becd90dd3a6f71a507494 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059669 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: chromium:1052887 Change-Id: If5d5c9e5b2dbb3b56eedfd9060015721817f47cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063040 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll d57bcfdb 2020-02-19T07:01:04 Roll third_party/vulkan-validation-layers/src 873e416c2d07..f155ccfd202d (13 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/873e416c2d07..f155ccfd202d git log 873e416c2d07..f155ccfd202d --date=short --first-parent --format='%ad %ae %s' 2020-02-19 locke@lunarg.com layers: Clean up 2020-02-19 jzulauf@lunarg.com layers: Refactor global image layout map for perf 2020-02-19 locke@lunarg.com layers: Remove ImageSubresourcePair 2020-02-19 locke@lunarg.com layers: Add initial layout when creating 2020-02-19 locke@lunarg.com layers: New container 2020-02-19 locke@lunarg.com layers: format is not necessary 2020-02-19 locke@lunarg.com layers: Correct data type 2020-02-19 locke@lunarg.com layers: Remove binding.mem 2020-02-19 locke@lunarg.com layers: Remove MEMORY_UNBOUND 2020-02-19 locke@lunarg.com layers: shared_ptr memory 2020-02-18 baldurk@baldurk.org tests: Add positive and negative non-semantic info tests 2020-02-18 baldurk@baldurk.org layers: Validate non-semantic info extension 2020-02-17 shannon@lunarg.com build: Update known-good files for 1.2.133 header Created with: gclient setdep -r third_party/vulkan-validation-layers/src@f155ccfd202d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: If8d1b808c1e10d8be5161886035b2f063dda4280 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2064050 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Corentin Wallez 38bb9fdf 2020-02-19T13:02:00 Revert "Move sampleAlphaToCoverage out of blendState" This reverts commit f6e73131c528b1317067624bc71c3ce41a48f9aa. Reason for revert: Crashes on Win10 FYI x64 Debug (NVIDIA) and Win7 FYI Debug (AMD) in the webgl CTS Original change's description: > Move sampleAlphaToCoverage out of blendState > > This is the second step towards exposing OES_draw_buffers_indexed (that defines independent blend state for each draw buffer). This flag is global in all graphics APIs, however D3D11 technically puts it in the blend state. > > D3D11: BlendStateKey was extended to keep existing D3D11 state caching semantics. > > D3D9: a comment was added explaining why this feature was never implemented there. > > Bug: angleproject:4394 > Change-Id: Ie6a294eeb6fcf4c868a1f1001c4f7efd61692ccd > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057063 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> TBR=geofflang@chromium.org,jmadill@chromium.org,lexa.knyazev@gmail.com Change-Id: I650624b5dfb7f2777c316906b9145a411243f42f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:4394 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2062605 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Corentin Wallez 90c9f66c 2020-02-19T12:51:01 Revert "Provide default implementation of rx::DisplayEGL" This reverts commit 123fd97000bb9fd912159bb9ccc62308b763aead. Reason for revert: Causes GL creation failure on Linux FYI Ozone (Intel) Original change's description: > Provide default implementation of rx::DisplayEGL > > Will allow to use EGL instead of GLX on X11. > > Meant to be used on modern EGL so it requires the extensions > EGL_KHR_no_config_context and EGL_KHR_surfaceless_context. > This keeps the default implementation simple (no pBuffer > fallback) > > Also provide simple WorkerContextEGL. > > Bug: angleproject:4328 > Change-Id: I92a1ded9e09e65de8bb83710274e0a73ecdff0a4 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061168 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> TBR=geofflang@chromium.org,jmadill@chromium.org,julien.isorce@chromium.org Change-Id: Ia55180ed83386fe1a158ccefda6155b33d779e98 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:4328 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2062604 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Peng Huang fa9eff37 2020-02-17T23:49:36 Disable GL_EXT_semaphore_fd for Mesa version < 19.3.5 on AMD GPUs Bug: chromium:1053516 Change-Id: Idfc271ac70c8ded7d05a258beb4a7578a5a652c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2062162 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Julien Isorce 123fd970 2020-02-04T23:08:55 Provide default implementation of rx::DisplayEGL Will allow to use EGL instead of GLX on X11. Meant to be used on modern EGL so it requires the extensions EGL_KHR_no_config_context and EGL_KHR_surfaceless_context. This keeps the default implementation simple (no pBuffer fallback) Also provide simple WorkerContextEGL. Bug: angleproject:4328 Change-Id: I92a1ded9e09e65de8bb83710274e0a73ecdff0a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061168 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 4b7bac78 2020-02-15T12:17:12 Vulkan: Throttle when way ahead of device. This CL adds a fence wait when we get more than 100 serials behind the device. This fixes an ASSERT when unit tests or offscreen performance tests get way ahead of the device. Bug: angleproject:3630 Bug: angleproject:4281 Change-Id: I90f9af1b2ceb2b1cd9f2f638d6d84caaeeb83bb1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057351 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill efd2a669 2020-02-15T08:45:46 Vulkan: Command graph linearization for SemaphoreVk. This doesn't seem to be tested in the default CQ configuration. Bug: angleproject:4029 Change-Id: If0acd5c78602324433b63498e2de8c16881023de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057354 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Michael Spang <spang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev f6e73131 2020-02-14T14:23:08 Move sampleAlphaToCoverage out of blendState This is the second step towards exposing OES_draw_buffers_indexed (that defines independent blend state for each draw buffer). This flag is global in all graphics APIs, however D3D11 technically puts it in the blend state. D3D11: BlendStateKey was extended to keep existing D3D11 state caching semantics. D3D9: a comment was added explaining why this feature was never implemented there. Bug: angleproject:4394 Change-Id: Ie6a294eeb6fcf4c868a1f1001c4f7efd61692ccd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057063 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill f87fac56 2020-02-17T09:55:32 Use non-mutating getQuery in validation. Previously the validation layer would create the query if not created. This change should be a no-op that makes the validation layer work in a more "const-friendly" way. Bug: angleproject:1280 Change-Id: Ife0c216c8a0dcda2a33d1182821c51e4ed5f67e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2060688 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll e96da533 2020-02-18T07:01:05 Roll third_party/vulkan-validation-layers/src 211ee9c4eec1..873e416c2d07 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/211ee9c4eec1..873e416c2d07 git log 211ee9c4eec1..873e416c2d07 --date=short --first-parent --format='%ad %ae %s' 2020-02-17 mark@lunarg.com tests: Touch up some incorrect errorMonitor calls 2020-02-17 mark@lunarg.com tests: Added tests for CmdBlitImage planar VUIDs 2020-02-17 mark@lunarg.com corechecks: Add CmdBlitImage multiplanar format checks Created with: gclient setdep -r third_party/vulkan-validation-layers/src@873e416c2d07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I589193d37add002f04f7426df0308cff0beb74bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061124 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a33dc9ce 2020-02-18T07:01:03 Roll third_party/vulkan-loader/src c731adec183b..0bd30e43c007 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/c731adec183b..0bd30e43c007 git log c731adec183b..0bd30e43c007 --date=short --first-parent --format='%ad %ae %s' 2020-02-17 shannon@lunarg.com build: Update known-good for 1.2.133 header Created with: gclient setdep -r third_party/vulkan-loader/src@0bd30e43c007 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I3ba81af4748d41f690b79b229245909e9b13add5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061123 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7efa03ac 2020-02-18T07:01:08 Roll third_party/SwiftShader 481daed34f15..0bbf7ba9f909 (5 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/481daed34f15..0bbf7ba9f909 git log 481daed34f15..0bbf7ba9f909 --date=short --first-parent --format='%ad %ae %s' 2020-02-17 amaiorano@google.com Cache callstack results to avoid expensive lookup 2020-02-17 amaiorano@google.com Subzero: add REACTOR_EMIT_PRINT_LOCATION support 2020-02-17 bclayton@google.com third_party: Add shell script that updates marl. 2020-02-17 amaiorano@google.com Implement rr::Print support for Subzero 2020-02-17 amaiorano@google.com Subzero: fix another load from constant data Created with: gclient setdep -r third_party/SwiftShader@0bbf7ba9f909 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I52277a2305d73e84211ad9b48a12b8275aa221b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061126 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9fcbd7e3 2020-02-18T07:01:08 Roll third_party/glslang/src ae59435606fc..113d07a6ebda (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ae59435606fc..113d07a6ebda Created with: gclient setdep -r third_party/glslang/src@113d07a6ebda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I62752cf29e88146c2df52f371ba7bb2e109ff235 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061125 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 2e0661d7 2020-02-17T20:19:13 Vulkan: Update ES 3.1 test expectations Split off shader compilation failure to a new bug. Bug: angleproject:3596 Bug: angleproject:4402 Change-Id: Iac054e469440cfa2b84289e08c5b21e3fbdf5410 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061448 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Xinghua Cao c8676d4b 2019-11-25T11:38:19 Unlimit texture size on relatively new linux If limit texture size to a small number, application may need to reshape texture, lead to more discontinuous memory access and performance loss. Bug: angleproject:4086 Change-Id: I502a90535c2e3d13738e23827f4712a77987585e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934048 Reviewed-by: Xinghua Cao <xinghua.cao@intel.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Xinghua Cao <xinghua.cao@intel.com>
Jamie Madill 015cb808 2020-02-18T00:24:55 Revert "Use newer OSX SDK for iOS" This reverts commit 192da9d76fef6012245473c92b9dfcb607848e6a. Reason for revert: Causing failures on mac builders due to license. Original change's description: > Use newer OSX SDK for iOS > > Based on http://crrev.com/c/2056465 > > Bug: chromium:1052887 > Change-Id: I2f76067883ff528ca45becd90dd3a6f71a507494 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059669 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=thakis@chromium.org,ynovikov@chromium.org,jmadill@chromium.org Change-Id: I8698ed56fc81a76900da2aaf6cd19d08b57c5525 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1052887 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061228 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 192da9d7 2020-02-17T17:28:58 Use newer OSX SDK for iOS Based on http://crrev.com/c/2056465 Bug: chromium:1052887 Change-Id: I2f76067883ff528ca45becd90dd3a6f71a507494 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059669 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Le Hoang Quyen ee89849b 2020-02-17T22:47:57 Metal: Fixed memory leak due to the CAMetalLayer still attached to super layer When destroying SurfaceMtl, the CAMetalLayer should detach from its super layer, otherwise memory leak could happen. This memory leak caused the end2end tests to ran out of memory. Bug: angleproject:2634 Change-Id: I8ea91cccdb42cf0ae8ef807cf01f1e05043dc7c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2060250 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Khushal 5f5292c8 2020-02-14T13:08:47 Only enable robust client memory if the context supports validation. Bug: chromium:1028418 Change-Id: Id47ac64a3d56b58455e1f36d8a17dbdc9db7e509 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2056506 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org>
Corentin Wallez 59126651 2020-02-17T09:52:05 Revert "Provide default implementation of rx::DisplayEGL" This reverts commit e82ab75a4ca8f4389a5f23b3a51d9388a92428e2. Reason for revert: crbug.com/1052772 Original change's description: > Provide default implementation of rx::DisplayEGL > > Will allow to use EGL instead of GLX on X11. > > Meant to be used on modern EGL so it requires the extensions > EGL_KHR_no_config_context and EGL_KHR_surfaceless_context. > This keeps the default implementation simple (no pBuffer > fallback) > > Also provide simple WorkerContextEGL. > > Bug: angleproject:4328 > Change-Id: I825c6998e4a3727a13e533ede3d9fb1820edc804 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2031699 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> TBR=geofflang@chromium.org,syoussefi@chromium.org,jonahr@google.com,jmadill@chromium.org,julien.isorce@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:4328 Change-Id: I62436cad1e6aae0c5e072acb1dab0bd10b2cf722 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2058952 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
angle-autoroll 6b43fba9 2020-02-17T07:01:07 Roll third_party/spirv-tools/src 6c218ec60b5f..77fefe765c06 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6c218ec60b5f..77fefe765c06 Created with: gclient setdep -r third_party/spirv-tools/src@77fefe765c06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Ibf658094111733ca1a8fa50b865c30d903d51721 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059856 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 18bfdb7f 2020-02-17T07:01:05 Roll third_party/vulkan-validation-layers/src 73d377fae66e..211ee9c4eec1 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/73d377fae66e..211ee9c4eec1 git log 73d377fae66e..211ee9c4eec1 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 s.fricke@samsung.com tests: Add test for vkCmdCopyImage VUID 2020-02-14 s.fricke@samsung.com layers: Add support for vkCmdCopyImage VUID 2020-02-14 mark@lunarg.com corechecks: Correct conditions for triggering VUID 1564 Created with: gclient setdep -r third_party/vulkan-validation-layers/src@211ee9c4eec1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I730510f9bf8891032075e9ec964d4e04b918e6fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059855 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 674d0ec2 2020-02-17T07:01:54 Roll third_party/vulkan-headers/src 726435870206..9bd3f561bcee (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/726435870206..9bd3f561bcee git log 726435870206..9bd3f561bcee --date=short --first-parent --format='%ad %ae %s' 2020-02-16 oddhack@sonic.net Update for Vulkan-Docs 1.2.133 Created with: gclient setdep -r third_party/vulkan-headers/src@9bd3f561bcee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=courtneygo@google.com Bug: None Change-Id: I7676db5d51844e2633fa3aa6e660444edaca971a Tbr: courtneygo@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2058775 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c7df822f 2020-02-17T07:01:08 Roll third_party/SwiftShader f9f999f5a2eb..481daed34f15 (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/f9f999f5a2eb..481daed34f15 git log f9f999f5a2eb..481daed34f15 --date=short --first-parent --format='%ad %ae %s' 2020-02-15 swiftshader.regress@gmail.com Regres: Update test lists @ 348f07b4 2020-02-14 amaiorano@google.com Fix unit test when ENABLE_RR_EMIT_PRINT_LOCATION is defined Created with: gclient setdep -r third_party/SwiftShader@481daed34f15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I7021723c43885bdfeccb96e63b8ad988a740407b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059857 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 2dd40d7f 2020-02-15T07:32:26 Vulkan: Free pool allocation leak with graph disabled. Our secondary command buffer pools were leaking memory every submit. This change pops the secondary command buffer pool allocator scope after commands are flushed during a submit. Fixes the memory leak observable on any Vulkan application. Bug: angleproject:4029 Bug: angleproject:4403 Change-Id: I3d0f8d53456336ef0b03c6d37425fb76c88d1551 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057349 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 798a8375 2020-02-14T12:48:21 Vulkan: Add more debug labels handling with graph off. Bug: angleproject:4029 Change-Id: Ia3c88af5f9fa1a7940d7f809ded599c064126be7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055555 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 12a36dd9 2020-02-14T12:48:20 Vulkan: Add debug utils functions to wrapper. Also adds a more consistent way of checking if the debug utils extension is enabled. Enables adding support for the debug utils markers with the command graph disabled. Bug: angleproject:4029 Change-Id: I5f8762921b06f54e400c25764012ab70e10bfb8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055554 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov bb7534ee 2020-02-14T16:23:28 Use ASSERT() instead of assert() when possible. Since ASSERT() works in Release builds. Left assert() in a few places where calling a function may not be safe. Bug: angleproject:4396 Change-Id: Ic75a3d41d846e327097f8c37fe2336dcd3be6cb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057745 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 9f4ab98d 2020-02-13T12:49:05 Return angle::Result from more label functions. This is necessary for the new Vulkan implementation. Bug: angleproject:4029 Change-Id: I07ef54145252ff102c74179361436587bb330fc7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055553 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Anders Leino 3a3e7d4d 2020-02-14T14:08:07 Don't skip functional.layout_binding.ubo.vertex_binding_max on NV/D3D11 This test no longer fails with any recent drivers. Bug: angleproject:4276 Change-Id: I7a20ee66f1da82d0f378848ccc9faa327a4ed63a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057065 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll eaff904e 2020-02-14T07:01:05 Roll third_party/vulkan-tools/src db0a1553991d..fb2272297f00 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/db0a1553991d..fb2272297f00 git log db0a1553991d..fb2272297f00 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 charles@lunarg.com vulkaninfo: support ASTC HDR formats 2020-02-13 charles@lunarg.com vulkaninfo: Update VkFormat ranges Created with: gclient setdep -r third_party/vulkan-tools/src@fb2272297f00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I01999deef8a186abbb83a717364235f766534568 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2056306 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2646163d 2020-02-14T07:01:08 Roll third_party/SwiftShader ac4e1d236088..f9f999f5a2eb (6 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/ac4e1d236088..f9f999f5a2eb git log ac4e1d236088..f9f999f5a2eb --date=short --first-parent --format='%ad %ae %s' 2020-02-13 jonahr@google.com Implement HostMappedForeignMemory DeviceMemory 2020-02-13 bclayton@google.com Update Marl to a047dd0bb 2020-02-13 bclayton@google.com third_party/marl: Add mips64 support to BUILD.gn 2020-02-13 swiftshader.regress@gmail.com Regres: Update test lists @ ac4e1d23 2020-02-13 amaiorano@google.com Kokoro: build and run rr::Print unit tests 2020-02-13 amaiorano@google.com Fix rr::Print and add unit tests Created with: gclient setdep -r third_party/SwiftShader@f9f999f5a2eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Id1422ca8e34f6eaf013b47416a35bb7cefd67745 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2056308 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2e9b5376 2020-02-14T07:01:05 Roll third_party/vulkan-validation-layers/src 30794ac2f91b..73d377fae66e (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/30794ac2f91b..73d377fae66e git log 30794ac2f91b..73d377fae66e --date=short --first-parent --format='%ad %ae %s' 2020-02-13 tony@lunarg.com layers: Fix false errors if query condition is unknown 2020-02-13 mark@lunarg.com layers: Fix string validation returned results Created with: gclient setdep -r third_party/vulkan-validation-layers/src@73d377fae66e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Ic6f674dfe8c209ac38a69d76728741574d53de1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2056307 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov d5861a68 2020-02-13T15:46:49 Fix ASAN errors in end2end tests. 2 minor issues of reading from uninitialized memory in tests. Removes the suppressions from the fixed tests. Bug: chromium:1029378 Change-Id: I466ce231cfed1ce53a60732706c05b778b096805 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055649 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop 4f9608ca 2020-02-13T09:26:52 Vulkan: Update more bug numbers for ES 3.1 This reflects the most recent conformance run on Android with SwiftShader. Bug: angleproject:4106 Bug: angleproject:4108 Bug: angleproject:4188 Bug: angleproject:4190 Bug: angleproject:4240 Bug: angleproject:4300 Bug: angleproject:4312 Change-Id: I0107262eecc963a8d5343a53806bb0483b5af3be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2054068 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Charlie Lao ef599fb0 2020-02-11T18:19:16 Vulkan: Fold glClear into draw call when command graph is disabled This sets ContextVk::mRenderPassCommandBuffer properly when glClear get called so that it wonr end up start anotyer render pass during setupDraw call. Bug: angleproject:4395 Change-Id: Id2110719ad4d70b4c410062466d32381fb5e1f88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050966 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 94c19142 2020-02-12T19:50:38 Capture/Replay: Track and restore mapped buffer data When a buffer is mapped writable by the host, we need to track its final contents, and then restore them during replay. This implementation just blindly captures the whole mapped range if writable, and can be optimized in the future. This change renders the moving billboards in Manhattan correctly. Test: First 500 frames of Manhattan and TRex Bug: angleproject:4091 Change-Id: I5f7775235f569efb264bde679fd3045d7012c622 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053512 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Alexey Knyazev b79b57e0 2020-02-13T17:59:16 Vulkan: expose ANGLE_compressed_texture_etc Bug: angleproject:4399 Change-Id: I51cd304c8726c985c5f70b78bd98c8af19d2a80d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053889 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Julien Isorce e82ab75a 2020-02-12T13:49:22 Provide default implementation of rx::DisplayEGL Will allow to use EGL instead of GLX on X11. Meant to be used on modern EGL so it requires the extensions EGL_KHR_no_config_context and EGL_KHR_surfaceless_context. This keeps the default implementation simple (no pBuffer fallback) Also provide simple WorkerContextEGL. Bug: angleproject:4328 Change-Id: I825c6998e4a3727a13e533ede3d9fb1820edc804 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2031699 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 77a5100d 2020-02-13T07:01:05 Roll third_party/vulkan-tools/src 45b9d01815d9..db0a1553991d (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/45b9d01815d9..db0a1553991d git log 45b9d01815d9..db0a1553991d --date=short --first-parent --format='%ad %ae %s' 2020-02-12 charles@lunarg.com vulkaninfo: new vkconfig_output backdend Created with: gclient setdep -r third_party/vulkan-tools/src@db0a1553991d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I0e52a00d48b755401d759170be99689d682e7c3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053853 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1f12c947 2020-02-13T07:01:05 Roll third_party/vulkan-validation-layers/src d439b17da022..30794ac2f91b (12 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d439b17da022..30794ac2f91b git log d439b17da022..30794ac2f91b --date=short --first-parent --format='%ad %ae %s' 2020-02-12 mikes@lunarg.com scripts: Rename src argument for safe_* copy funcs 2020-02-12 mikes@lunarg.com scripts: Only use safe_* types when needed 2020-02-12 mikes@lunarg.com scripts: Handle arrays with const/non-member len 2020-02-12 shannon@lunarg.com scripts: Fix codegen infinite recursion 2020-02-12 s.fricke@samsung.com tests: Add test for 01004 and 02652 2020-02-12 s.fricke@samsung.com layers: Add support for 01004 and 02652 2020-02-12 mark@lunarg.com tests: Remove non-API range enums 2020-02-12 mark@lunarg.com layers: Remove non-API range enums 2020-02-12 mark@lunarg.com layers: Remove deprecated log_msg() function 2020-02-12 mark@lunarg.com layers: Removed last log_msg calls 2020-02-12 s.fricke@samsung.com tests: Added test for 00624 and 00625 2020-02-12 s.fricke@samsung.com stateless: Added support for 00624 and 00625 Created with: gclient setdep -r third_party/vulkan-validation-layers/src@30794ac2f91b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Ibe4ff7d019861e0e6db0aae06637b79dc04d8e49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053852 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d4be305e 2020-02-13T07:01:08 Roll third_party/SwiftShader 6cbb02e0dc93..ac4e1d236088 (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/6cbb02e0dc93..ac4e1d236088 git log 6cbb02e0dc93..ac4e1d236088 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 gmouse@google.com Add missed symbol __aeabi_idivmod for Android. 2020-02-12 swiftshader.regress@gmail.com Regres: Update test lists @ 6cbb02e0 Created with: gclient setdep -r third_party/SwiftShader@ac4e1d236088 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I3f0ef9910eafd7b340aa11c9a4cd0fd1a0849142 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053854 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 74ab0bff 2020-02-12T17:29:27 Vulkan: Disable command graph by default. Also removes the angle_end2end_tests feature override. Bug: angleproject:4029 Change-Id: I0d0bd087fc2143360185592d9fa1238a9bafc55d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046054 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 9e4cf7ca 2020-02-12T16:58:37 Fix vpython caching in trigger.py script. Several necessary CPID packages were missing from the swarming params. Add these based on the packages in mb.py: https://chromium.googlesource.com/chromium/src/tools/mb/+/2192df66cd0ed214bcfbfd387ad0c5c8c0a21eb1/mb.py#586 Allows testing the ANGLE test launcher without modifying recipes. Bug: angleproject:3162 Change-Id: I3e84bf0d3fd92aed623a918b4d9cfd53f51f2dee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050427 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 593706bc 2020-02-10T16:46:52 Test Runner: Increase default timeouts. In particular the Debug timeout was not generous enough. Increase the test timeout to 20 seconds in Release and 60 seconds in Debug. Increase the batch timeout to 240 seconds in Release and 600 seconds in Debug. Bug: angleproject:3162 Change-Id: I0bd0ea18cb5cdab005143b8deed9500d9d2e8ea1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047415 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Alexey Knyazev caf7becc 2020-02-11T19:05:11 Move dither from blend state to rasterizer state Dither is technically not a part of blend state so it was removed from there as a first step towards exposing OES_draw_buffers_indexed (that defines independent blend state for each draw buffer). Rasterizer state seems to be the closest (although also not accurate) place for it to keep code changes to a minimum. ANGLE's D3D11, Vulkan, and Metal renderers ignore dithering altogether. Bug: angleproject:4394 Change-Id: Ib138624b9218851d18cd63e2033e8e8ac8ca71d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050464 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Courtney Goeltzenleuchter 92b00ca8 2020-02-10T11:07:23 Roll deqp to get some test fixes Bug: angleproject:4107 Change-Id: Icfb6b3fc075b9febf486386c26d90b4020ace9ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047388 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Antonio Maiorano bd2f2575 2019-12-06T09:44:13 Update comment to reflect changes in ea0dcd4bda188 Bug: angleproject:4087 Change-Id: I3c26fae4fde24308fa877256c190a5bb47fe1a82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954568 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev 33b1e31e 2020-02-08T17:48:56 Fix compressed formats validation with TEXTURE_3D Bug: angleproject:4385 Change-Id: Ibc1b482ec851d8076aacad84ab67fe20a745c122 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2045512 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll cf03c7ae 2020-02-12T07:01:07 Roll third_party/spirv-tools/src fe10239f92f4..6c218ec60b5f (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fe10239f92f4..6c218ec60b5f Created with: gclient setdep -r third_party/spirv-tools/src@6c218ec60b5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I181af12ac2a95d8619b581c8734f38ab63e09273 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050005 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7adc9736 2020-02-12T07:01:05 Roll third_party/vulkan-validation-layers/src b60b35843e66..d439b17da022 (38 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b60b35843e66..d439b17da022 git log b60b35843e66..d439b17da022 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 s.fricke@samsung.com tests: Add test for 00360 2020-02-12 s.fricke@samsung.com layers: Add support for 00360 2020-02-12 s.fricke@samsung.com tests: Add tests for 01973 and 01069 2020-02-12 s.fricke@samsung.com layers: Add support for 01973 and 01069 2020-02-11 mark@lunarg.com layers: Update stateless validation doc 2020-02-11 mark@lunarg.com corechecks: Convert core val to use new logging funcs 2020-02-11 mark@lunarg.com corechecks: Converted buffer validation to new logging funcs 2020-02-11 mark@lunarg.com corechecks: Use new logging calls in shader validation 2020-02-11 mark@lunarg.com corechecks: Move helpers inside validation object 2020-02-11 mark@lunarg.com threading: Change log_msg calls to LogError calls 2020-02-11 mark@lunarg.com theading: Pass object pointer instead of report_data 2020-02-11 mark@lunarg.com corechecks: Move misplaced validation call into core validation 2020-02-11 mark@lunarg.com chassis: Changed log_msg calls to LogWarning calls 2020-02-11 mark@lunarg.com corechecks: Convert drawdispatch.cpp to new logging funcs 2020-02-11 mark@lunarg.com gpuval: Moved to new-style logging functions 2020-02-11 mark@lunarg.com corechecks: Converted descriptor_sets.cpp to new logging calls 2020-02-11 mark@lunarg.com practices: Convert WARNINGS to new logging calls 2020-02-11 mark@lunarg.com practices: Convert perf warnings to new logging funcs 2020-02-11 mark@lunarg.com practices: Change info message to warning 2020-02-11 mark@lunarg.com objlifetimes: Convert object tracker to new logging calls 2020-02-11 mark@lunarg.com stateless: Convert parameter validation to new logging calls 2020-02-11 mark@lunarg.com tests: Fix pipeline create state test 2020-02-11 s.fricke@samsung.com tests: Added test for 00701 2020-02-11 s.fricke@samsung.com layers: Added support for 00701 2020-02-11 s.fricke@samsung.com layers: Added condition to display 01427 2020-02-11 s.fricke@samsung.com layers: Added condition to display 01430 2020-02-11 s.fricke@samsung.com tests: Added test for 01988 2020-02-11 s.fricke@samsung.com layers: Added support for 01988 2020-02-11 s.fricke@samsung.com tests: Added test for 01143 2020-02-11 s.fricke@samsung.com layers: Added support for 01143 2020-02-11 s.fricke@samsung.com tests: Added test for 00317 and 00318 2020-02-11 s.fricke@samsung.com layers: Added support for 00317 and 00318 2020-02-11 raul.tambre@cleveron.com layers: Don't issue VU01564 for immutable samplers 2020-02-10 jeremy@lunarg.com tests: Test unaligned CmdPushDescriptorSet 2020-02-10 jeremy@lunarg.com layers: Validate unaligned CmdPushDescriptorSet 2020-02-10 jzulauf@lunarg.com tests: Add layout for middle subresource test 2020-02-10 jzulauf@lunarg.com layers: Fix range_vector excess erasure 2020-02-10 jeremy@lunarg.com layers: Fix unitialized variable. Created with: gclient setdep -r third_party/vulkan-validation-layers/src@d439b17da022 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I8275b4fab12c0b5124af7583c0ce1e5c0a318594 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050004 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 58e7790c 2020-02-12T07:01:08 Roll third_party/SwiftShader b3b2a4fc756f..6cbb02e0dc93 (11 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/b3b2a4fc756f..6cbb02e0dc93 git log b3b2a4fc756f..6cbb02e0dc93 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 bclayton@google.com CMakeLists: Drop the explicit include path to marl 2020-02-11 bclayton@google.com Bulk clang format 2020-02-11 bclayton@google.com Change SpirvShaderInstructions.inc extension to .inl 2020-02-11 bclayton@google.com Merge changes Ide16cac3,Id5d767fc 2020-02-11 jiaxun.yang@flygoat.com Fix MIPS build cflags 2020-02-11 bclayton@google.com Don't use std::initializer_list for array views. 2020-02-11 sugoi@google.com Support for VK_KHR_separate_depth_stencil_layouts 2020-02-11 sugoi@google.com Support for VK_KHR_create_renderpass2 2020-02-11 bclayton@google.com Revert "Add missed symbol __aeabi_idivmod for Android." 2020-02-11 gmouse@google.com Add missed symbol __aeabi_idivmod for Android. 2020-02-10 bclayton@google.com Debug: Rename levels. Created with: gclient setdep -r third_party/SwiftShader@6cbb02e0dc93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Ie73f8091b61e7a08e6fa11aac7801d3b7f50080c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2049960 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov e1ccac7f 2020-02-11T17:45:02 Don't print INFO level log messages in Release by default. Even with dcheck_always_on. INFO level log messages will still be printed in Debug or when angle_enable_trace is enabled. Bug: angleproject:3525 Change-Id: Ic3807f94307af2878aee78426c969ab846ae3881 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050890 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 3b82506a 2020-02-11T09:35:38 Vulkan: Command graph linearization (Step 5). Implements ES 3.1 support. Bug: angleproject:4029 Change-Id: I3c08602cf4ec64621bfdb40cd40d142b666e6edf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046052 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 72e9f4d7 2020-02-11T11:14:35 Vulkan: Update bug number in KHR ES 3.1 expectations It was pointing to general ES 3.1 bug. Bug: angleproject:4107 Change-Id: Ief726c57d5a853d633df705eb30e8cdad3f6c9ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050030 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 8c0b4889 2020-02-11T07:01:05 Roll third_party/vulkan-tools/src 428455ca6121..45b9d01815d9 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/428455ca6121..45b9d01815d9 git log 428455ca6121..45b9d01815d9 --date=short --first-parent --format='%ad %ae %s' 2020-02-10 charles@lunarg.com vulkaninfo: Check for surface extensions 2020-02-10 petr_kraus@email.cz build: Fix android update not understanding headers version Created with: gclient setdep -r third_party/vulkan-tools/src@45b9d01815d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I709bbc83ddf30dd93235b8bc731859265c8a13f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2049668 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 1a8b7758 2020-02-11T10:34:00 Fix assignment of CacheOpResult::EnumCount The special enum value 'EnumCount' is used by EnumSize() to determine how large to make the PackedEnumMap::mPrivateData array. However, that enum entry was being assigned an incorrect value, leading to the array being constructed too small and causing a crash in PackedEnumMap's std::initializer_list constructor when it went beyond the size of the array to assign each of the necessary values. The fix is to remove the assignment of CacheOpResult::EnumCount and let it indicate the real number of entries in the enum. Bug: angleproject:4393 Test: end2end Change-Id: If9635c61e72aadc6527d416f83be18add8b24572 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050026 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill b40d48a6 2020-02-09T10:38:40 Vulkan: Remove ensure init from updateActiveImages. The ensure should already be triggered from the front-end. Bug: angleproject:3539 Bug: angleproject:3887 Change-Id: Ic7ee10f9c767440e55befb929b414c0c894754c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046051 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill cd8167fb 2020-02-10T14:17:09 Vulkan: Fix EGLBlobCacheTest. Several runs of the same test in a row would cause a failure if the cache would get hit. Fix the flakiness by resetting the cache between runs. Also cleans up some of the variable naming and adds a stream output for pretty test errors. Fixed while working on the standalone test harness. Bug: angleproject:3162 Change-Id: I64da8a37eedf562860e3e5409cbf6fb08e81dfa4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047417 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 3c066404 2020-02-05T12:43:12 Vulkan: Command graph linearization (Step 4). Implements GLES 3.0 functionality for the new command recording style. Tested with angle_end2end_tests. dEQP/CTS testing will come later. Bug: angleproject:4029 Change-Id: Ibdc4f1355a7b880946699ec227fd9807f4a27af9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2040197 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 041ebfed 2020-02-10T13:39:34 Speed up InstancingTest.LineLoop. This test was taking 14-20 seconds in release mode. Likely because of the way we were issuing a ReadPixels and "std::endl" to a stream for every pixel of a 256x256 Framebuffer. Instead issue a single ReadPixels call and no stream flushes. Now runs in less than 500ms. Helps prevent timeouts when running tests multi-process. Also enables the test on D3D9. Bug: angleproject:3162 Change-Id: I27aad773040d6b6668cbde003802345e01044a7d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047414 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 8257ac30 2020-02-07T14:17:08 Vulkan: Defer RenderPass image barriers. We accumulate image barriers in two places: * for GL sampler textures * for GL framebuffer attachments (Render Targets) Then we issue the barriers together in a single call before the RP. This fixes a bug where we were missing a layout transition in some cases when transitioning between a sampler and a render target. It should also be faster to issue a single barrier before a RP than issue several smaller barriers. Bug: angleproject:3539 Bug: angleproject:4029 Change-Id: I180b770f0df6b44d209e5c618ba36bcc1c6372e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2044236 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 788fa360 2020-02-10T14:07:12 Suppress two failing NVIDIA D3D11 tests. Bug: angleproject:4391 Bug: angleproject:4392 Change-Id: I81cbf261cf206cd2d38cff93d16056c21bf78557 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047416 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop 9d86f331 2020-02-04T18:27:20 Capture/Replay: Avoid null pointer dereference in MEC Small fix to progress Manhattan MEC. Bug: angleproject:4091 Test: Working through Manhattan frames 5-10, TRex still works Change-Id: I7981e19a64f121b2ecca4451574ca2886641c6ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2039532 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop fc1e8503 2020-02-05T10:59:27 Capture/Replay: Initial support for framebuffer textures Bug: angleproject:3662 Test: Working through Manhattan frames 5-10, TRex still works Change-Id: I3d9b4dced4c1667382154fb68839d01ba2db9b98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2039531 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 00b96fe7 2020-02-10T07:01:08 Roll third_party/SwiftShader dd48b7e2d06e..b3b2a4fc756f (11 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/dd48b7e2d06e..b3b2a4fc756f git log dd48b7e2d06e..b3b2a4fc756f --date=short --first-parent --format='%ad %ae %s' 2020-02-08 bclayton@google.com Fix Android build: Add missing .cpp to Android.bp 2020-02-08 amaiorano@google.com Subzero: fix cosh/sinh deqp failures 2020-02-08 amaiorano@google.com ReactorUnitTests: fix clang-format messing up test suites 2020-02-08 bclayton@google.com Reactor: Copy System/Debug code to Reactor copy 2020-02-08 bclayton@google.com SpirvShaderDebugger: Ignore non-statements 2020-02-07 bclayton@google.com Debug: Control logging level using a compile time knob 2020-02-07 bclayton@google.com Fix chromium build. 2020-02-07 bclayton@google.com Debugging: Merge VkDebug into System/Debug 2020-02-07 bclayton@google.com VkDebug: Android - log messages to logcat. 2020-02-07 bclayton@google.com ReactorBenchmarks: Sweep coroutine perf. 2020-02-07 bclayton@google.com vscode: Add third_party/benchmark to include dirs Created with: gclient setdep -r third_party/SwiftShader@b3b2a4fc756f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I0fcc005ec068e5e4f1de2a08f59d137b00c81693 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046532 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 572d63a7 2020-02-10T07:01:08 Roll third_party/glslang/src 95c414ffee64..ae59435606fc (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/95c414ffee64..ae59435606fc Created with: gclient setdep -r third_party/glslang/src@ae59435606fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Iff9284070cc4d7446cc238f5bec31a71fa3d7509 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046531 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill a8e6a463 2020-02-09T13:10:24 Suppress Vulkan RobustResourceInit tests. These tests are flaky because of a bug in ANGLE's Vulkan robust resource init. Mark them as failing until we can resolve the bug. Bug: angleproject:4255 Bug: angleproject:4384 Change-Id: I8e18a8532850848fc7a25e137dce27dd0d19fa55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046053 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Brandon Schade 0a6e118d 2020-01-27T13:37:29 Change g_Mutex from std::mutex to std::recursive_mutex When running flatland on android-10.0.0_r21 (Pixel 3), libgui's ~EglImage calls eglTerminate which grabs angle's EGL entry point mutex. The path continues to libvulkan where eventually another egl call happens (eglDestroyImageKHR) and it will attempt to take the mutex at the entry point again. So we try to get the mutex multiple times from the same thread. Change this mutex to a recursive_mutex to allow for this re-entry of EGL calls Tests: android-10.0.0_r21/frameworks/native/cmds/flatland Bug: angleproject:4354 Change-Id: If8a817df45e9f58d5f06884510350e17d7127fa9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2029218 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 0d224cce 2020-02-05T11:00:59 Capture/Replay: Add 2DArray and 3D texture support for MEC This also includes support for compressed formats, which required a small refactor to streamline the code, since all of the entrypoints have slightly different parameter lists for imageSize and data. Bug: angleproject:3662 Test: Working through Manhattan frames 5-10, TRex still works Change-Id: I007ad9366934fff773f367ecb6387bc8b0d13aa0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2039530 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 9681190d 2020-02-05T12:51:25 Make Debug marker functions return angle::Result. Allows error handling in these functions. Necessary for the Vulkan back-end. Bug: angleproject:4209 Change-Id: I2092e58e719c6ee562807e1c7e8ad26988342855 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2040196 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill c3854ebc 2020-02-07T11:11:26 Vulkan: Clamp vertex buffer offsets. Vulkan mandates that vertex buffer offsets are within the size of the buffer even if robust buffer access is enabled. Do a check in VertexArrayVk::syncDirtyAttrib to guard against this. Bug: angleproject:3350 Change-Id: Ia01deb9b7335dd8f632f2cf9b32d2908ba55645c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2044491 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill ca035803 2020-02-06T17:24:48 Vulkan: Add missing wrapper functions for XFB. Found when working on the command graph refactor. Also replace the offsets array with nullptr which should have the same effect. Bug: angleproject:4029 Change-Id: I72e31c5403c645d72619e14aafef612e454183f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2043270 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 51fd2958 2020-02-07T07:01:07 Roll third_party/spirv-tools/src 1f03ac10270a..fe10239f92f4 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1f03ac10270a..fe10239f92f4 Created with: gclient setdep -r third_party/spirv-tools/src@fe10239f92f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Icdd0cfc181c77ee14bfa4054ea849301078b184f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2043351 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 55de83af 2020-02-07T07:01:07 Roll third_party/glslang/src 656650f461c8..95c414ffee64 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/656650f461c8..95c414ffee64 Created with: gclient setdep -r third_party/glslang/src@95c414ffee64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Id3d1ccb162c60fa5c157982b11641ddab9f2558d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2043352 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop e02f4996 2020-02-06T12:26:07 Vulkan: Pass correct level count in getLevelDrawImageView This bug was hit by a KHR ES 3.1 test. This CL just applies the obvious fix already noted by jmadill@. Test: KHR-GLES31.core.shader_image_size.*-nonMS-* Bug: angleproject:4008 Bug: angleproject:4108 Change-Id: I5d05c0a7432f7b70d2b995fd8b11224c119ece5f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2042491 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Michael Spang 36f2c80a 2019-07-31T13:36:04 Fuchsia: Fix size & position of test window on Scenic Scenic places our window in with its center in the corner if we don't apply any translation. Therefore we only see 1/4 of the surface. Translate the surface so the full size is visible. Also account for display scaling as we're sizing in pixels and scenic is sizing in density independent pixels. Bug: angleproject:4382 Test: angle_end2end_tests Change-Id: I1ae0b877c0ed7cf9d810bb2c8317b9842bd322a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1716226 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 3a2522de 2020-02-06T10:05:23 Make TransformFeedbackTest deterministic. Instead of using rand(), use a fixed seed RNG. This can ensure runs use the same draw call counts no matter the time of day. Note: there may have been a setting somewhere that was seeding the RNG because I wasn't seeing variation between test runs locally. This change makes it explicit. Bug: angleproject:4029 Change-Id: Ic51bf2a6779da3b96a3357eed99c0f7fa9d81648 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2042210 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 463c318a 2020-02-06T16:03:02 Roll third_party/vulkan-loader/src b932cf53f769..c731adec183b (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b932cf53f769..c731adec183b git log b932cf53f769..c731adec183b --date=short --first-parent --format='%ad %ae %s' 2020-02-06 cnorthrop@google.com loader: Avoid clang warning about parentheses 2020-02-05 charles@lunarg.com loader: secure_getenv change logging WARN to INFO 2020-02-05 charles@lunarg.com loader: don't unconditionally add std-val meta layer 2020-02-05 lenny@lunarg.com loader: Fix buffer size updates in registry search Created with: gclient setdep -r third_party/vulkan-loader/src@c731adec183b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I9fda2c484d8cf0a170fefd6f75dcf52282664ac1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2042235 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brian Osman e9dc0201 2020-02-04T12:04:28 GL: Mark unused uniform locations that were explicitly bound as ignored If a uniform location is unused, but a call to glBindUniformLocation has explicitly bound the uniform, ANGLE validation still treated the uniform as unused and returned errors. The correct behavior is to ignore the uniform and silently fail. Bug: angleproject:4374 Change-Id: Ic7b97f23cf8bc2d5380129322595e51b3d4a9fcc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2036676 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 7572c967 2020-02-06T09:26:08 Roll third_party/glslang/src b82ed734e767..656650f461c8 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b82ed734e767..656650f461c8 Created with: gclient setdep -r third_party/glslang/src@656650f461c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I4d5fcf594c2ce786a3ae35e613e7a0dd1a87d6d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2041034 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5e28a2b3 2020-02-06T07:01:07 Roll third_party/spirv-tools/src 9e52bc0d0c1d..1f03ac10270a (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9e52bc0d0c1d..1f03ac10270a Created with: gclient setdep -r third_party/spirv-tools/src@1f03ac10270a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Iaa49097d4c41ec5b9be5dab1a5f2671bddb1f9c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2041076 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f5d128fa 2020-02-06T07:01:05 Roll third_party/vulkan-validation-layers/src ab47cacfd3b3..b60b35843e66 (6 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ab47cacfd3b3..b60b35843e66 git log ab47cacfd3b3..b60b35843e66 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 brucedawson@google.com Fix duplicate header file entry 2020-02-05 mark@lunarg.com tests: Revert "Call 1.2 core API using GetInstanceProcAddr" 2020-02-05 mark@lunarg.com tests: Call 1.2 core API using GetInstanceProcAddr 2020-02-05 mark@lunarg.com chassis: Limit GetPhysDevProcAddr to physical device funcs 2020-02-05 tony@lunarg.com layers: Use correct VK version when validating spec consts 2020-02-05 tony@lunarg.com tests: Use maxBoundDescriptorSets instead of hard coding Created with: gclient setdep -r third_party/vulkan-validation-layers/src@b60b35843e66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ie303bda1194333bba94d8d21d3b4becdc75a435b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2041075 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 010c82d4 2020-02-06T07:01:04 Roll third_party/vulkan-tools/src 260679605f98..428455ca6121 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/260679605f98..428455ca6121 git log 260679605f98..428455ca6121 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 timo.gurr@gmail.com vkcube: fix unknown CMake command error 2020-01-31 shannon@lunarg.com build: Update known-good for 1.2.132 header Created with: gclient setdep -r third_party/vulkan-tools/src@428455ca6121 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ibb125e6cfecda694041c7aa83998c6510d5f7e0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2041074 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a5bfe7d5 2020-02-06T07:01:08 Roll third_party/SwiftShader 8e8e1d0dd729..dd48b7e2d06e (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/8e8e1d0dd729..dd48b7e2d06e git log 8e8e1d0dd729..dd48b7e2d06e --date=short --first-parent --format='%ad %ae %s' 2020-02-05 amaiorano@google.com Fix MSAN LLVM jit false positives 2020-02-05 bclayton@google.com Disable new gcc 9 warning [init-list-lifetime] Created with: gclient setdep -r third_party/SwiftShader@dd48b7e2d06e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I75bcfe8bc85d98104835ab9740c3c3f7c267e9fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2041077 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi e5385ea9 2020-01-27T13:40:18 Vulkan: Compile shaders at link time Since line raster emulation was changed to use specialization constants, it has been possible to compile shaders at link time. However, program pipeline objects would have required keeping the shader sources around for recompilation. Now that all necessary decorations are modified directly in SPIR-V, it's possible to compile the shaders at link time and forget about their sources. Program pipeline objects then simply "reconfigure" the generated SPIR-V. A next step could be to also create the Vulkan pipeline object at link time. A number of failures due to gaps in CTS testing prevent that work currently. In particular, in some situations the generated SPIR-V is not per spec, for example it may contain vertex attributes with aliasing locations, or have transform feedback capture of array elements misconfigured. Bug: angleproject:3394 Bug: angleproject:4253 Change-Id: I54c0884cf056b511a4a306225cc6ed2cef84d257 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023186 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>