kc3-lang/angle/scripts

scripts

Log

Author Commit Date CI Message
angle-autoroll d003d9e2 2024-08-05T16:10:45 Manual roll vulkan-deps from 068847956e41 to 3d8509997599 (49 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/068847956e41..3d8509997599 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3c7b12c643437061aec00a813a7f7ae578ba813f..71c24c1e4b4823cab0919bc062202a42ef6569e8 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/9bd6f95db3076517205b01300c8d37043c5b2dd3..a12be94856baf210bb7ae9457dbdf907148caa0a https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/db5a00f8cebe81146cafabf89019674a3c4bf03d..f013f08e4455bcc1f0eed8e3dd5e2009682656d9 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/e7216170d02921ce8acd49aebed0098adc050d23..246daf246bb17336afcf4482680bba434b1e5557 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/fabe9e2672334fdb9a622d42a2e8f94578952082..595c8d4794410a4e64b98dc58d27c0310d7ea2fd https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/be0e1c3683a39a26b4f1a3859226b07a482d030e..faeb5882c7faf3e683ebb1d9d7dbf9bc337b8fa6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/46df205dcad665b652f57ee580d78051925b296a..7d5cdf62e4f2935425faab1270fe1c9a401fa664 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/67522b34edde86dbb97e164280291f387ade55fc..45b881573538f8e481cb6e1d811a9076be6920c1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/1582614bd3ad31463710af6365a56f04d6788ce6..5436842cd0448e3f47d16c637a15fd2a6f93c88e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: Ifb0ca58e920d01034f268b2414141ca34003176e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5765972 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Le Hoang Quyen 1bfe5c57 2024-07-30T15:58:47 Metal: partially implement EXT_multisampled_render_to_texture. Implement by implicitly attaching a multisampled texture to the render pass. The content will be preserved across render passes by loading/storing to the implicit multisampled texture. However this won't work if the single sampled texture is used in multiple render passes with different glFramebufferTexture2DMultisampleEXT's sample counts. For that to work we need to implement unresolve step to load the resolve texture's texels into the implicit multisampled texture. That will be implemented in a separate CL. Bug: angleproject:42261786 Change-Id: I12be75af17ce5b98266946846417d0a43fcba455 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5746180 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Alexey Knyazev 26aa4df5 2024-06-20T00:00:00 Metal: Update floating-point texture format caps * Fixed detection of Apple7+ GPUs. Added support for Apple8 and Apple9 GPUs. * Adjusted filterability and resolvability caps for R32F, RG32F, and RGBA32F formats. This enables GL_OES_texture_float_linear on capable devices. * Adjusted RGBA32F blendability cap. This enables GL_EXT_float_blend on capable devices. Bug: angleproject:347739670 Change-Id: I84d23814d119452f47fff5a1d7dc33f614c35bb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5646489 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Mohan Maiya 22ed9877 2024-03-07T15:52:13 Vulkan: Generate fragment shading rates with compute Generating fragment shading rates on the CPU could cause avoidable stalls or increased latencies due to host<->device synchronization. Instead generate the rates using a compute shader. Optimize foveated rendering by treating a foveated draw with focal points whose gainX or gainY is 0 as if it were an un-foveated draw Bug: angleproject:42266906 Change-Id: If8c5504087997666c7d0c1cae8dcc5fab847187e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5754322 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Marcin Radomski 4c883359 2024-07-03T13:50:58 Add dma_buf build support to generate_android_bp Minimized version of go/anglecl/5729843 that limits introduced changes. Make generate_android_bp.py emit a `angle_android_dma_buf` Soong config variable that, when enabled, creates a "Linux-like" build using Android toolchain. The build does not assume the presence of regular Android graphics stack. eglGetDisplay defaults to creating DisplayVkOffscreen. This enables EGL rendering context setup based on an externally allocated DMA-BUF, using EGL_EXT_image_dma_buf_import and GL_OES_EGL_image_external extensions. See ag/28533701 to view the generated code. Also, revert changes from "Add build flag for a "dma_buf" Android build" (commit 4d2b365582669a04224d1e1fa3c92447c359a4ba). The flag added there was submitted a bit prematurely, and as go/anglecl/5729843 was deemed too complex a different approach was necessary. Test: CQ Test: Build the entire CL chain with the new Soong config flag enabled Test: run the system, attach debugger to eglGetDisplay(), see Test: DisplayVkOffscreen getting instantiated Bug: b/353262025 Change-Id: I974d91cff79a0bd8b5059a145f0ae6114b2bcbe5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5746214 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Marcin Radomski <dextero@google.com>
Yuxin Hu 0ef06687 2024-07-29T14:26:15 Stage the angle_commit.h for commit during ANGLE Android Roll Add the missing "git add angle_commit.h" command in roll_aosp.sh so that this file is staged for commit during ANGLE to Android roll. Otherwise it will be missed from the rolled CL e.g. https://android-review.git.corp.google.com/c/platform/external/angle/+/3198314, causing the compiler to fail to find the angle_commit.h Place the code that generates the angle_commit.h into a separate function generate_angle_commit_file() for clear code reading purpose. Bug: b/348044346 Change-Id: I06fc0f91c396218c1d4ab6b8f6aef883380ad7b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5747414 Reviewed-by: Roman Lavrov <romanl@google.com>
Yuxin Hu c9744617 2024-07-25T14:07:38 Fix Unknown Android Git Hash in Android Builds The ANGLE git hash is generated by running the script src/commit_id.py during compile time. However, in Android repo, access to .git is not guaranteed. This results the "unknown hash" value being generated by src/commit_id.py when compiling ANGLE in Android repo. To fix it, instead of invoking the src/commit_id.py during compile time, invoke the script during ANGLE to Android roll time. This change: 1) Removes the code in generate_android_bp.py that exports the build target angle_commit_id into Android.bp, so that the script src/commit_id.py is not invoked when compiling ANGLE in Android. 2) Invokes src/commit_id.py in aosp_roll.sh, to generate the angle_commit.h when we roll ANGLE changes into Android. Sample results with this change in Android is https://googleplex-android-review.git.corp.google.com/c/platform/external/angle/+/28476591 Bug: b/348044346 Change-Id: I91862ba6ab20ffb2cf9e99ee9b4fa6b83727c634 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5741631 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Solti b8cc14d7 2024-07-26T21:13:10 skip lib starting with "//" when generating Android bp The issue is http://b/354737043#comment10. Based on the discussion, we would like to skip lib starting with "//", such as "//third_party/llvm-build/Release+Asserts/lib/clang/19/lib/linux/libclang_rt.builtins-xxx" in this case. We can revisit this implementation when we actually need something that starts with "//" Bug: b/354737043 Test: Compare the Android.bp before and after the change. Change-Id: I21f799f1a4946a0662e1190a2e962bc37dc714ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5742651 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll aa8e1e50 2024-07-29T10:07:29 Roll VK-GL-CTS from c66570e674d0 to 3d152263d502 (6 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c66570e674d0..3d152263d502 2024-07-26 boris.zanin@amd.com Initial implementation Ray Tracing support in Amber 2024-07-26 elima@igalia.com Rename video encode tests to extract codec name as new group 2024-07-26 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-07-25 piotr.byszewski@mobica.com Test local read without mapping 2024-07-25 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.5 into vk-gl-cts/main 2024-07-25 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.11 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Idd88f87327cdc49bc1f366dcded9ee2ea5552bce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5745264 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov f47a882a 2024-07-26T14:47:48 Cleanup: remove vulkan_clean_old_validation_layer_objects Target removed upstream: https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/8242/commits/12048d7d846e9020a11feb8650587f6898414d50 Bug: angleproject:350816748 Change-Id: I0ea5c4c54960e49c9b6d37f1932c2121bdfc6529 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5741787 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Mark Lobodzinski d306e048 2024-07-24T15:03:04 Tests: Add Shovel Knight Pocket Dungeon trace Tests: angle_trace_tests --gtest_filter=*shovel_knight_pocket_dungeon bug: b/355399059 Change-Id: I5b2193db9814d0867ab95efab7588540fca6198d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5742394 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuly Novikov f184de3f 2024-07-25T12:42:03 Don't roll third_party/rust-toolchain into AOSP Bug: angleproject:349994211 Change-Id: I57855c7c950627a2597d56816c3d16b7859d4114 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5741434 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 81086a18 2024-07-23T15:51:35 Manual roll VK-GL-CTS from 5b2dfe7c775a to 5a542d2049d7 (1 revision) Manual roll requested by solti@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/5b2dfe7c775a..5a542d2049d7 2024-07-19 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (CoverageGL21), PART 8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Manual edits - Patchset 2: fetched the original roller generated CL - Patchset 3: added missing parts, and run "python3 scripts/run_code_generation.py" - Patchset 4: suppress the failures: KHR-GLES3.api.coverage and KHR-GL46.api.coverage. see https://anglebug.com/355292302 Bug: b/354737043 Bug: angleproject:355292302 Tbr: solti@google.com Change-Id: Ie38a65c6db0b3330e970971bd1325e3c419b6248 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5739577 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Solti Ho <solti@google.com>
Liza Burakova 4f498eaa 2024-07-24T14:31:23 WebGPU: Add more format support This CL adds a new FormatTable class that initializes webgpu texture and vertex formats. It also adds this class to the display so it can be used in the ImageHelper. This CL changes the previously hardcoded RGBA8 texture format that was initially used when creating textures to use the format passed into the methods. Bug: angleproject:344814096 Change-Id: I768b85335329116496dbf721aac54d1137aaae9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5660397 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Shahbaz Youssefi 6afff893 2024-07-24T10:05:37 Roll Rust tools with Chromium Bug: angleproject:349994211 Change-Id: I9360b869e59365ff41d35359ce5af47c878fa89f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5736063 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll fa940e36 2024-07-19T10:01:36 Roll vulkan-deps from 4b8a413b6b64 to edbbcd521ef6 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4b8a413b6b64..edbbcd521ef6 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/b0bf54958137fcd9800848ef3ecb5fa6be871803..9bd6f95db3076517205b01300c8d37043c5b2dd3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/b379292b2ab6df5771ba9870d53cf8b2c9295daf..fabe9e2672334fdb9a622d42a2e8f94578952082 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/58428b0c0e9cb818ee240857c5b4725df8c5183e..edcf314e81d9866e783ce55855fd1dc482b263e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I2d7bbec905717a5627e3bfee0b5148274d59fc43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5725208 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6c585f85 2024-07-18T10:01:45 Roll vulkan-deps from ace59194583a to 4b8a413b6b64 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ace59194583a..4b8a413b6b64 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/48eaea60b849e3eb9ff970b7d4e873646b658863..52f68dc6b2a9d017b43161f31f13a6f44636ee7c https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/3c355ec439dcf821c50fb4660ef0e50d19ae2b63..db5a00f8cebe81146cafabf89019674a3c4bf03d https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/7c778973e5eb56ef735bf1a3ad96865eb261997d..4c7e1fa5c3d988cca0e626d359d30b117b9c2822 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/40b8e6eeead809a62c708cb48fdd9f8f2eab3f15..5892ebe2d7505c2238a643288d9a5b2e68784a36 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/5f26cf65a18bc89a8e3d6569c14314b6fdac8d4d..9479047902e8031210b1bb33a8850e32b313dd25 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/ac2e01fc1a67329da0c879ecd2296b76643c49c0..58428b0c0e9cb818ee240857c5b4725df8c5183e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I396a787cb99ddbf77d58cd8ba69d61e366517bba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5720395 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 9968e98c 2024-07-16T00:00:00 Metal: Fix compute path for 16-bit PBO readbacks Added 16-bit normalized pixel formats to internal copy shaders. Fixed and simplified floatToNormalized usage for signed inputs. Bug: angleproject:352700368 Change-Id: Icbb79381991c6621004d53706b97662d33c25cd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5717929 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 468fcbe0 2024-07-15T15:46:12 Manual roll VK-GL-CTS from 43432bf265e3 to 5b2dfe7c775a (17 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/43432bf265e3..5b2dfe7c775a 2024-07-12 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.5 into vk-gl-cts/main 2024-07-12 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.11 into vk-gl-cts/main 2024-07-12 marcin.zajac@mobica.com MSAA Images in 64 bit Atomic + Shader Storage Images 2024-07-12 piotr.byszewski@mobica.com Add tests for subgroup uniform descriptor indexing 2024-07-12 ziga@lunarg.com Add shader object tests using all stages with nextStage 0 2024-07-12 MengYang.Liu@amd.com Add test cases for 256 bytes PushConstantsSize 2024-07-12 javed@igalia.com Fix 'unused shader' message 2024-07-12 kamil.goras@mobica.com Split KHR-GL46.cull_distance.functional 2024-07-12 syoussefi@google.com Remove incorrect usages of DE_NULL in VK framework 2024-07-12 syoussefi@google.com Remove incorrect usages of DE_NULL in GL tests 2024-07-12 syoussefi@google.com s/DE_NULL/0 in makeStridedDeviceAddressRegionKHR 2024-07-12 rgarcia@igalia.com Test line rasterization parameters do not affect non-lines 2024-07-12 javed@igalia.com Add option to enable/disable spir-v validation 2024-07-12 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-07-11 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-07-08 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-07-01 lorenzo@khronosgroup.org Update KC CTS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: b/353358652 Tbr: yuxinhu@google.com Change-Id: I1c787be2812017f14aff669d42bf55f2696d5de1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5710888 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
angle-autoroll d89a205d 2024-07-12T10:01:14 Roll vulkan-deps from bc656cdad31e to 9563c7bbc6c9 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bc656cdad31e..9563c7bbc6c9 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/78a92e2c7c5aa1c7b7e6f9c475bd9009977ea8f9..f41928bd4ac3b0451b68898d8e58a6ed5ee99f2b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/38691803018cb2d85194b235faf43119d64c0a66..8e1076d9363787b4e754ac17e7ee6ab806458f7c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/7e13360e42364fdd1f07fe00f19d0432b12db055..145675c7915c5041dac106c9827dc0b21992c091 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d1a44afd0353a82308f1a2a3ff379bca5b0e2368..53a86c7d267c325613c9a532b190d964f513402f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I8b9c369c9b63b5e0bc4fe46fea2b0e35439aa218 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5700806 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a15d4f97 2024-07-11T09:55:32 Roll Chromium from 5748d73603a8 to 51ac27c135bf (686 revisions) Ignore 'contrib/qat/deflate_qat.h' in 'scripts/export_targets.py' after https://chromium-review.googlesource.com/c/chromium/src/+/5419776 https://chromium.googlesource.com/chromium/src.git/+log/5748d73603a8..51ac27c135bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/55c8722b0c..4608a1c315 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a2464aeead..97a8409691 * buildtools/reclient: re_client_version:0.148.0.41b09b51-gomaip..re_client_version:0.150.0.c8b9fcfa-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5f0ab1b223..f0dacf7b5b * third_party/android_build_tools/lint: e_WxdIopgECi7lR7hSDoHgOVaSHP0TtgcfjFowfwUkgC..RE2raAkMs2otvvOax0wf9dW4Mhow5lXtfxx88UFHrRcC * third_party/android_build_tools/manifest_merger: UZ47yEDJAQYl7Uj6uUofbCrmnK8Bycu18fSFQAMO2agC..EL_n6z6EIpxqT6t1ZhG8Zx4IgmdTyl_KlPazwMqe0SsC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b73579b7b0..7534569f99 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6b6a0ff40b..8ebbd5189d * third_party/fuchsia-sdk/sdk: version:22.20240703.0.1..version:22.20240710.1.1 * third_party/kotlin_stdlib: L8N8abd00VyqdzTL4hXOWqSHvY0R7i7ti3TLrfbPZ8gC..8qx9sot30FtFtPSKIpcEu3KhfqtQHpExnueNhpwxd48C * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/37df66525c..6aa2802a07 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/68e57e619c..c2469fdd73 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e887381724..dcb70b126e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/31e7b5378d..edbc860e1b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b16be4632b..ad128811ea No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I981332789b54df0c21668ba5a61c046aad5c910e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5692852 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 6c6975af 2024-07-05T12:28:54 Manual roll vulkan-deps from 5fdd3da87369 to 17d345a0f23d (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5fdd3da87369..17d345a0f23d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/704107fda3827377f00e57dff0c21da019bff4ae..5939e32b87487fa9c72ab336ebfcc5ae26d9ab6d https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/2acb319af38d43be3ea76bfabf3998e5281d8d12..41a8eb27f1a7554dadfcdd45819954eaa94935e6 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/973e791a9ac122f903c2796349a538b278cbe29b..216574bedb80d439c2533d161e7ea7897504bbb6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/afeb91d6d2110717b8c842081eff410617aed1ef..96fb5396040477fbbffdc1b4439dea9447f59d80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2e1c6204e675eb8e70ed68dbe13b912bd6ffce6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5678939 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Geoff Lang fcf3a1c0 2024-07-02T16:33:28 GL: Allow shader compilation with cached translated source Write the translated shader source when serializing shaders. This does not increase the size of the shader cache because Vulkan only uses the compiledBinary field. Spawn a ShaderTranslateTask for loading shaders so the GL backend can compile the shader on the native driver. Bug: angleproject:350779978 Change-Id: I14413a7ca2a0d99653a1082f2c8b4a94cf58626a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5672740 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang ef2c9665 2024-07-02T11:25:17 GL: Fix dispatch table for desktop-only entry points In gl.xml, each extension and entry point within the extension can express which API it is supported in. The dispatch table generator was ignoring the per-entry point support information and assuming deferring to the extension-level support. Extensions like EXT_blend_minmax which only adds glBlendEquationEXT on desktop GL would overwrite the blendEquation entry point with a non-existant (null) glBlendEquationEXT on GLES. This also simplified the lack of KHR suffixes on desktop GL since they are listed with the proper desktop-only api requirements in gl.xml. Bug: angleproject:42267098 Change-Id: I906969335d5b82831dd82699d910f444afa68cd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5670963 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 78ee33e4 2024-07-01T15:42:55 Roll third_party/dawn/ 6cdf3a1a1..eb249b37e (310 commits; 3 trivial rolls) We need to roll in https://dawn-review.googlesource.com/c/dawn/+/196054 to ublock rolling libc++ into ANGLE. Add special handling of Undefined WGPU formats due to also rolling https://dawn-review.googlesource.com/c/dawn/+/193360 https://dawn.googlesource.com/dawn.git/+log/6cdf3a1a195f..eb249b37e3e8 $ git log 6cdf3a1a1..eb249b37e --date=short --no-merges --format='%ad %ae %s' 2024-07-01 blundell [Vulkan] Set the Vk descriptor type correctly for YCbCr samplers 2024-07-01 blundell [Vulkan] Map FilterMode to Vulkan filter correctly for YCbCr info 2024-07-01 dawn-autoroll Roll vulkan-deps from 773555d3bd22 to 4a2ff9e87700 (1 revision) 2024-06-30 dsinclair [hlsl] Handle compute builtins for ShaderIO transform. 2024-06-30 dsinclair [hlsl] Add some existing transforms 2024-06-29 jrprice [msl] Regenerate test expectations 2024-06-29 dsinclair [hlsl] Split module var structs and arrays. 2024-06-29 dawn-autoroll Roll vulkan-deps from 2796aaff7eef to 773555d3bd22 (9 revisions) 2024-06-29 cwallez opengl: Add support for EGL_EXT_pixel_format_float. 2024-06-29 kainino Summarize CTS failures as first line of first max-severity log 2024-06-29 jaswant.panchumarti Do not turn off CMAKE_CXX_EXTENSIONS 2024-06-28 rafael.cintron Disable render passes on Windows until support can be detected 2024-06-28 enga [headers] Remove the Flags enums and make them 64-bit 2024-06-28 dsinclair [hlsl] Stub out the DecomposeMemoryAccess IR transform. 2024-06-28 cwallez opengl: Add support for EGL_KHR_no_config_context. 2024-06-28 jaswant.panchumarti Disable GLFW_INSTALL 2024-06-28 jaswant.panchumarti Add third_party/google_benchmark/src in fetch_dawn_dependencies.py 2024-06-28 jaswant.panchumarti Always build glslang as static library 2024-06-28 dawn-autoroll Roll vulkan-deps from 7ff358e64e2b to 2796aaff7eef (10 revisions) 2024-06-28 enga Fix Wayland build 2024-06-28 dawn-autoroll Roll ANGLE from 46dd6457f4bf to a674dc1dae8f (3 revisions) 2024-06-28 dawn-autoroll Roll DirectX Shader Compiler from 206133c9e7e1 to 49d1ae9a029c (1 revision) 2024-06-27 bsheedy Mark problematic expectation block as KEEP 2024-06-27 rharrison [tint][fuzz][ir] Implement test case disassembler 2024-06-27 dsinclair [hlsl] Add transform to remove struct and array initializers to lets. 2024-06-27 enga Re-number enum values part 2 2024-06-27 rharrison [tint][fuzz][ir] Batch process files when generating corpus 2024-06-27 cwallez GL: Add support for wgpu::Surface. 2024-06-27 jrprice [tint] Fix UB in FileContent copy constructor 2024-06-27 dsinclair [hlsl] Add ValueToLet transform. 2024-06-27 dsinclair [hlsl] Add ShaderIO transform. 2024-06-27 jaswant.panchumarti Use dawn_add_library function to create the dawn_glfw library 2024-06-27 jaswant.panchumarti Use dawn_add_library function to create the dawn_utils library 2024-06-27 jaswant.panchumarti Use dawn_add_library function to create the dawn_wire library 2024-06-27 jaswant.panchumarti Use dawn_add_library function to create the dawn_native library 2024-06-27 dsinclair [glsl] Extract textureBuiltinFromUniformData 2024-06-27 dawn-autoroll Roll vulkan-deps from 1c484942880c to 7ff358e64e2b (4 revisions) 2024-06-27 hans Fix std::vector<const T> 2024-06-27 dawn-autoroll Roll ANGLE from 0bf157f12bb8 to 46dd6457f4bf (5 revisions) 2024-06-27 dsinclair [glsl] Extract combinedSamplerInfo 2024-06-27 jrprice [fuzz] Skip PixelLocal with multiple entry points 2024-06-27 jrprice [tint] Pre-clone symbols in IR->AST pass 2024-06-27 jrprice [fuzz] Add TextureBuiltinsFromUniform precondition 2024-06-27 jrprice [tint] Fix collision check in multiplanar fuzzer 2024-06-27 jaswant.panchumarti Use dawn_add_library function to create the dawn_platform library 2024-06-27 jiawei.shao Fix crash when using constant expression as `@blend_src` 2024-06-26 rharrison [tint][ir][fuzz] Convert assembler to generating test case protos 2024-06-26 jaswant.panchumarti Use dawn_add_library function to create the dawn_proc library 2024-06-26 dawn-autoroll Roll ANGLE from 046327343595 to 0bf157f12bb8 (5 revisions) 2024-06-26 dawn-autoroll Roll DirectX Shader Compiler from e5183a06b913 to 206133c9e7e1 (1 revision) (...) 2024-06-17 dawn-autoroll Roll SwiftShader from 085997ddb08b to cea33ab2d5ad (1 revision) 2024-06-17 jimblackler Integration test in the library. 2024-06-17 dawn-autoroll Roll vulkan-deps from 897d900fc1b1 to 7f05a36fb6d9 (1 revision) 2024-06-17 dawn-autoroll Roll DirectX Shader Compiler from 206b7c2e537a to 8c3f40c0ae12 (1 revision) 2024-06-17 dawn-autoroll Roll ANGLE from d521dd08bef4 to 7f70cd0da27c (1 revision) 2024-06-16 dawn-autoroll Roll vulkan-deps from 1bd6201121db to 897d900fc1b1 (1 revision) 2024-06-15 jimblackler Alternate way of generating the bindings inside Gradle. 2024-06-15 jimblackler Fix for incorrect import path for webgpu.h. 2024-06-15 jimblackler Move 'Util' to a new location, and convert to Kotlin. 2024-06-15 dawn-autoroll Roll vulkan-deps from dd296c842e50 to 1bd6201121db (7 revisions) 2024-06-15 dawn-autoroll Roll ANGLE from bcb567a7f8e4 to d521dd08bef4 (7 revisions) 2024-06-14 hitawala [YCbCr Samplers] Get supported SampleTypeBit for external format 2024-06-14 senorblanco OpenGLES: more end2end test cleanup. 2024-06-14 enga Fix wgpu::Status return value for wgpuSurfaceGetCapabilities 2024-06-14 kainino Use ityp::array for sVertexFormatTable 2024-06-14 dawn-autoroll Roll vulkan-deps from 42ee85cf2154 to dd296c842e50 (2 revisions) 2024-06-14 dawn-autoroll Roll Depot Tools from 88a72320ed30 to 1d1f17af898b (4 revisions) 2024-06-14 dawn-autoroll Roll DirectX Shader Compiler from 56f3c4038159 to 206b7c2e537a (1 revision) 2024-06-14 enga Remove 0-value enums that aren't ever valid 2024-06-14 dawn-autoroll Roll ANGLE from 973e5261a0fd to bcb567a7f8e4 (7 revisions) 2024-06-14 senorblanco Revert "Make a convenience cpp method for WaitAny with one future" 2024-06-14 dawn-autoroll Roll vulkan-deps from 7db4057407f4 to 42ee85cf2154 (8 revisions) 2024-06-14 enga Make a convenience cpp method for WaitAny with one future 2024-06-14 dawn-autoroll Roll Depot Tools from 43c6415bced9 to 88a72320ed30 (3 revisions) 2024-06-14 beaufort.francois Make GPUAdapter GetInfo() a suitable replacement for GetProperties 2024-06-14 rharrison [tint][ir][fuzz] Disable building IR fuzzer when ASAN is enabled 2024-06-14 enga AHB: Don't add storage binding unless AHARDWAREBUFFER_USAGE_GPU_DATA_BUFFER 2024-06-14 dsinclair [hlsl] Fix incorrect HLSL test output 2024-06-14 rharrison [tint][ir][fuzz] Fix breakage of fuzz_cmd target for CMake 2024-06-13 dsinclair [hlsl] Add HLSL IR printer var/let tests 2024-06-13 dsinclair [ir] Add a templated `zero` helper. 2024-06-13 dawn-autoroll Roll ANGLE from 65f8dc8e3ad8 to 973e5261a0fd (5 revisions) 2024-06-13 dsinclair [hlsl] Add generated IR expectations. 2024-06-13 jrprice [msl] Regenerate E2E expectations 2024-06-13 lehoangquyen D3D11: split Buffer class into GPUOnlyBuffer and StagingBuffer 2024-06-13 senorblanco OpenGLES: enable/triage misc end2end tests. 2024-06-13 chouinard Remove storage textures from vertex tests 2024-06-13 chouinard Disallow textureStore in vertex shader tests 2024-06-13 chouinard Replace textureStore test with frag shader 2024-06-13 jrprice [msl] Add polyfill for textureNumSamples 2024-06-13 jrprice [msl] Add polyfill for textureNumLayers 2024-06-13 jrprice [msl] Add polyfill for textureSampleCompare 2024-06-13 jrprice [ir] Strip all IO attributes in ShaderIO transform 2024-06-13 fdurso SampleUtils: Add missing newline in output message 2024-06-13 wong.kl.matthew dawn/node: Update documentation for ASan CMake builds. 2024-06-13 dawn-autoroll Roll DirectX Shader Compiler from 4353db3983e2 to 56f3c4038159 (2 revisions) 2024-06-13 ynovikov Revert "d3d: Change D3D references to PhysicalDevice to WeakRef instead of Ref" 2024-06-13 dsinclair [hlsl] Add HLSL IR printer constant tests 2024-06-13 dawn-autoroll Roll vulkan-deps from 7d45b6d174eb to 7db4057407f4 (13 revisions) 2024-06-13 dawn-autoroll Roll Depot Tools from c0883c509ea3 to 43c6415bced9 (3 revisions) Created with: roll-dep third_party/dawn Bug: chromium:323708866, chromium:349411322, dawn:42241166 Change-Id: Iad65ef83c0ec47a6aba3fdc7de511ff22f586d4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5667168 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 2a2b5cbd 2024-07-01T08:01:48 Roll VK-GL-CTS from 25d8c0099575 to 43432bf265e3 (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/25d8c0099575..43432bf265e3 2024-06-28 cturner@igalia.com hevc decode: add scaling list tests 2024-06-28 michal.jakubek@mobica.com Tests for dedicated device memory overallocation. 2024-06-28 jbolz@nvidia.com SPV_EXT_replicated_composites 2024-06-28 piotr.byszewski@mobica.com Test setting pColorAttachmentInputIndices to NULL 2024-06-28 gleese@broadcom.com Check for ES3.1 support in EGL Sync test 2024-06-28 piotr.byszewski@mobica.com Test mismatched dimensionality 2024-06-28 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-06-27 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ia88ba0e9b36d6fdcc2f9cee0f94a2fb5d1886e4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5669887 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Steven Noonan 4f23429a 2024-06-28T14:20:26 egl_angle_ext: fix incorrect EGL_ANGLE_device_d3d11 name Bug: angleproject:349972038 Change-Id: I11d8442d3f88bc6767b9e184179f88a984162e08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5668322 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net>
angle-autoroll 1062271d 2024-06-28T10:01:47 Roll vulkan-deps from 7ff358e64e2b to 2796aaff7eef (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7ff358e64e2b..2796aaff7eef Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/ca004da9f9c7fa7ed536709823bd604fab3cd7da..c91d9ec1580dce89b10b0ca6a368800e2deaf1cb https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/e3c37e6e184a232e10b01dff5a065ce48c047f88..190d2cb24e90e5bf2bec0a75604a9b3586485b6d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/60fe7d0c153dc07325a8fb45310723a1767db811..144ce1b3c19caf29a69fca192fb168f3aa7ab9aa https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/df3e018436e38c2536d5b79e1e662e6323b6fbe2..a190959aa0992dafda40ef67822dfbebb6d5ab3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I0c877374590e2ab35c0f0fc46b5c4388944647e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5665715 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Liza Burakova 3e997419 2024-06-25T18:41:03 Add format conversions for WebGPU formats. This CL adds a Format class, as well as a generator script to generate methods to map between WebGPU and ANGLE formats. Fallback mappings are listed but this CL only implements support for required webgpu formats. Bug: angleproject:344814096 Change-Id: I2588a57353eafc4e87f40df3bbe3f9375e5ed8c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5598178 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
ericali 016ef60d 2024-06-24T17:41:30 ValidateAST asserts when refers to builtIn struct type name Refers to build in type name looks allowed by GL but currently VK and Metal backends do not support, i.e.: refers to gl_DepthRangeParameters, this change is to add temporary check to make using reserved type name an error during parsing. Bug: angleproject:348313398 Change-Id: I6522566b1f590fe2b24534fb065625c4ac3b06c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5645265 Auto-Submit: Erica Li <lerica@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Amirali Abdolrashidi 0b888d50 2024-06-13T11:32:53 Add KHR_blend_equation_advanced_coherent * Added this extension to registry_xml.py. Bug: angleproject:42262258 Change-Id: I2d69982b9ec876e3c21346039ed78aa21b1a1896 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5634379 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Geoff Lang 92148c2c 2024-06-17T11:13:46 GL: Implement GL_EXT_clear_texture. This extension is useful because it allows clearing textures without changing the framebuffer. Chrome uses this on Android when it's available. Bug: angleproject:347047859 Change-Id: I765d9991c4549b3655446d9f51847d1095792dbd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5631810 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi d193d51b 2024-06-17T22:46:08 Replace issue ids post migration to new issue tracker This change replaces anglebug.com/NNNN links. Bug: None Change-Id: I8ac3aec8d2a8a844b3d7b99fc0a6b2be8da31761 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5637912 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 26836339 2024-06-17T10:01:21 Roll vulkan-deps from 42ee85cf2154 to 897d900fc1b1 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/42ee85cf2154..897d900fc1b1 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a92c61f8456fa9731c0b000a2c6fc52a740c2be7..19efb4ec60febf569ad3cf2f2fd71bbd20ff4617 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/d192041a2fc9c9fd8ae67d8ae3f32c5511541f04..8f034f6b48fd2d30f711396a021e1dc050c8941c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/99a7973d3c4f5413c6c14b2519d0980041cce68f..f23f8b7ae5adc4979ad8466e7ccdf024ec7c0c93 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/a9a1bcd709e185700847268eb4310f6484b027bc..345af476e583366352e014ee8e43fc5ddf421ab9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/07759f04791dc3fbb390174f0d24d4a792e0d357..1b07de9a3a174b853833f7f87a824f20604266b9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/828e72c93fb5604dc6fcd97b70a1af077da093e2..9bb8d0513ee37db2a57abe8a8edd16ac95ae5bd9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I66d9a57736861875bbc4ef44517b5bb05f02b410 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5635613 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Josip Sokcevic ed091d30 2024-06-12T20:17:17 Change siso path Place siso CIPD under cipd directory so Git and CIPD sources are not combined. Bug: chromium:346837573 Change-Id: I4b9e486f7a95ad6ffe3008925fb097504397c0ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5627276 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@chromium.org> Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 2d8e15f8 2024-05-31T14:25:12 Add stubs for GL_QCOM_tiled_rendering Bug: angleproject:343900918 Change-Id: I77d742949565ebfecb5f4446db3510af4f94033c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588629 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e34a6b31 2024-06-13T10:01:52 Roll vulkan-deps from 9a693759186a to 7db4057407f4 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9a693759186a..7db4057407f4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/eb49bb7b1136298b77945c52b4bbbc433f7885de..2acb319af38d43be3ea76bfabf3998e5281d8d12 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/65d30c31508e47d34f7698f511aea4800e3d44fe..bc28ac7c195f59b14535edec8472d97fd32a91ad https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/15ba84ba94ff2ed473474deba2b4f2af4705b1fb..e130d5bd2cea031409a9481e3c85c4cd3ddc39fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I29c9531bc8e463003a96404f16881b6c75feb517 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5627322 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi ebb56cee 2024-05-31T15:10:37 Implement OES_tessellation_shader Based on the specs, there are no functional differences between OES and EXT. * Added validation for glPatchParameteriOES() and the core glPatchParameteri(). * Added the extension support for GLSL. * EXT_shader_io_blocks is implicitly enabled for the EXT geometry and tessellation shader extensions. * OES_shader_io_blocks is implicitly enabled for the OES versions of said extensions. * Added a test to make sure using this extension works instead of EXT. * Turned the repeated test code into a function: * testTessellationTextureBufferAccess * Skipped the tests that fail on various platforms. * It seems that these tests were being skipped before enabling this extension ("Not supported"). Bug: b/344030760 Bug: angleproject:345306326 Bug: angleproject:345304850 Bug: angleproject:345312771 Change-Id: I905da0132bf6525cb453dcaa613e4deb3155c4dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5595611 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi 8042ebdc 2024-05-31T17:06:56 Add OES_tessellation_shader Bug: b/344030760 Change-Id: I49c5dd870a09cd6b43beea13c70b8c1a4266875b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5595610 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 706fa5d8 2024-06-10T10:01:07 Roll vulkan-deps from f629315dfd72 to 62eb765e42dd (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f629315dfd72..62eb765e42dd Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/192d051db3382e213f8bd9d8048fc9eaa78ed6ab..d192041a2fc9c9fd8ae67d8ae3f32c5511541f04 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/377016eea5ebd4f6d6689c1e7a7ca2a2207c3fb4..1bae807cd919890f7174fa14228b6e672e8d296e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/0ed7d9d71588f46e972f7fdc9d41ac888b2fa5f6..a9a1bcd709e185700847268eb4310f6484b027bc https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/252879e8958afc0c250ed460dbecf43c206fca04..741921e408442b0370047b5eaf16cbc2b5d381e5 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/10693af7a6e409fafee9a7cc988e9719692beb6c..082e5ac6ccdf5f8e71707414b90f323b1233b80b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ie91ef33a33b4afe78ecf09e91cb9cf799aaab2d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5613611 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll df2cdd73 2024-06-07T14:43:41 Manual roll vulkan-deps from a58be9cfb9b6 to f629315dfd72 (16 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/a58be9cfb9b6..f629315dfd72 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4da479aa6afa43e5a2ce4c4148c572a03123faf3..73eccd4b67985d344578cade8958214cee0a3f6e https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/ff2afc3afc48dff4eec2a10f0212402a80708e38..eb49bb7b1136298b77945c52b4bbbc433f7885de https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/6a2bdeee75eb35e5349c6993d33c9afe30237d79..ce46482db7ab3ea9c52fce832d27ca40b14f8e87 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/d67a9d3a394e11c1c4c0f480124f5b7925cb1b4d..0ed7d9d71588f46e972f7fdc9d41ac888b2fa5f6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/f1bf2fadb0d599c9bd5516aefa9f8a10d7a377cf..10693af7a6e409fafee9a7cc988e9719692beb6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: I2b5323462e9c1821e9f63ecfcf5a0120710c25e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5605106 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 25374c90 2024-05-31T16:08:58 Implement OES_gpu_shader5 Based on the specs, there is no difference between the OES version and the EXT version. * Added support for use in shaders * Added test to make sure the OES extension works. * Turned the repeated test code into a function: * testArrayOfArrayOfSamplerDynamicIndex() Bug: b/344031022 Change-Id: Ifda4fa5495983d254f598940a95d0797e8a9ce67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5595609 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi edaaacd9 2024-05-31T17:30:34 Add OES_gpu_shader5 Bug: b/344031022 Change-Id: Ib11b5835b566e299ce6a7a47a4e4a46bcfd670ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5595608 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov c60e247e 2024-06-04T17:40:26 Make LinkedUniform.getElementComponents() fully inline-able Before this CL, getElementComponents() calls into GetUniformTypeInfoFromIndex() which cannot be inlined as it uses kInfoTable from uniform_type_info_autogen.cpp. That table is fairly large however, so this CL adds the elementComponents part of that structure to an inlinle GetUniformElementComponents() function. This allows to fully inline LinkedUniform.getElementComponents() which significantly simplifies clampUniformCount() assembly code, to the point where this leads to a (small but) measurable performance improvement in driver_overhead_2 trace despite getElementComponents _never actually getting called_ (because count is always == 1 and clampUniformCount returns early). This appears to be caused by a side effect of the function call, where clang generates prologue and epilogue instructions that are still executed on the fast path when the function is not getting called (even if ANGLE_LIKELY is added or code rearranged). Bug: b/335295728 Change-Id: If8f2068b098576246ab90ffbacd5a520cc843f49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5597885 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 147ba459 2024-05-30T00:00:00 Allow polygonMode* commands with active PLS Drive-by: * Test that polygonOffsetClampEXT is allowed when PLS is active. Fixed: angleproject:345253437 Change-Id: I5d9f60b3e70eaf8da19017a8b9d6c2592cb4f4f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5601849 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 6968848e 2024-05-30T00:00:00 Remove PLS checks from GLES 1.x entry points Fixed: angleproject:345125742 Change-Id: If845ddb654221cfb88c3f69bb98e07dbee8b6b39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5598770 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll d8c7c4be 2024-06-03T20:16:36 Manual roll VK-GL-CTS from fd5cc7b1e075 to d2d6aa656073 (30 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fd5cc7b1e075..d2d6aa656073 2024-05-31 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-31 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-05-31 javed@igalia.com Add coverage for image load/store of depth formats 2024-05-31 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-30 marcin.zajac@mobica.com Video capabilities EXT to KHR 2024-05-30 michal.jakubek@mobica.com Coverage for Ldexp, Frexp and Atan2 with subnormal floats 2024-05-30 spatibandlla@nvidia.com Components: Framework - Add native support for QNX Screen 2024-05-30 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (transform_feedback2_states), PART 7 2024-05-30 kamil.goras@mobica.com Split KHR-GL4x.texture_swizzle.smoke and KHR-GL4x.texture_swizzle.functional test 2024-05-30 kamil.goras@mobica.com Split KHR-GL4x.copy_image.functional test 2024-05-30 piotr.byszewski@mobica.com Add self-dependency to resolve_image tests 2024-05-30 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-29 yuxinhu@google.com Fix missing Android build dependencies 2024-05-29 yuxinhu@google.com Fix a wrong class type in tcuTestLogParserJNI 2024-05-29 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-29 erik.faye-lund@collabora.com Update tests to cover BGRA8 formats 2024-05-24 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-24 boris.zanin@amd.com Additional testing for fp16 immediate/inline arguments 2024-05-24 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-24 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-05-24 david.heidelberg@collabora.com Correct EGL_EXT_config_select_group extension query 2024-05-24 cturner@igalia.com Check transfer queue image granularity requirements 2024-05-24 c.hambacher@samsung.com Fix bind_buffers_2 tests using out-of-bounds vertices for non-maint5 2024-05-24 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-17 syoussefi@google.com main: Run clang-format + remove de* types If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ib728f0df93a6cc8bf16bba4f24312bed5cc184a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5594575 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7113795e 2024-06-03T20:26:15 Manual roll vulkan-deps from d4f7e6e954db to 6e8f93674ed4 (19 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/d4f7e6e954db..6e8f93674ed4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2b19bf7e1bc0b60cf2fe9d33e5ba6b37dfc1cc83..0e311906b92f8cc74eab258260343074b00a9710 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/49a1fceb9b1d087f3c25ad5ec077bb0e46231297..ff2afc3afc48dff4eec2a10f0212402a80708e38 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/77c40bece1b8b441eee432fc9d74efbf985f777f..4a2e0c9b3663d1bacc91821ae5699965bff4e5e9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/5677bafb820e476441e9e1f745371b72133407d3..192d051db3382e213f8bd9d8048fc9eaa78ed6ab https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e15fdd01eff029f2bf15e63970f2a7cebf2999b0..5b71c4be018cfd7951f3618defeb3c4cbf9603e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I403fdea8d5582d7fd5c862a7daab9c5774df0977 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5594279 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov c8db5292 2024-05-31T19:35:32 Remove locks from most glUniform* calls Note: only the Vulkan backend claims to be thread safe. glUniform1i and glUniform1iv are kept locked as they might set samplers, which is more complicated. glUniformBlockBinding is a more complex state change with notifications. Other glUniform functions simply call setUniformImpl() or setUniformMatrixfv() in the vulkan backend, which as https://crrev.com/c/5588853 and https://crrev.com/c/5592968 show only update mDefaultUniformBlocks and mDefaultUniformBlocksDirty. This should be thread-safe as long as the application is not creating race conditions itself such as by changing the same object in parallel. This should yield a significant improvement in the driver_overhead_2 benchmark which is heavy on such calls. Bug: angleproject:8666 Bug: b/335295728 Change-Id: Iad1577b9ab2eb57b6a4599ec6d70fa90eb518e8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588385 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi ce6232fc 2024-05-21T11:15:51 Add KHR_robustness * From the spec, there are some differences between KHR_robustness and EXT_robustness (already in use). In this CL, the following are addressed: * Updating the EXT suffixes * Changing EXT to KHR for GLES * Removing EXT for GL * Adding GLGetnUniformuivKHR (no equivalent in EXT) * Added GL_KHR_robustness to the list of extensions. * The API implementations seem to be already in place. * Validation functions will be updated in a follow-up CL. Bug: angleproject:42262244 Change-Id: Ibbc1bc11ec08ac756f4a03d11f51ba1268d037a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5555984 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Antonio Caggiano e3cba40e 2024-04-30T17:47:36 gn: Add install target Define an install_target GN template which installs include directories and a predefined list of libraries to a given prefix. The template is taking advantage of an install_target.py script which generates package config files for every named target. Bug: angleproject:8110 Change-Id: I6deb40fe9c54f11da7caf4fb5df59d3ce522df29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5553797 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Antonio Caggiano <quic_acaggian@quicinc.com>
Geoff Lang 0e892a02 2024-05-30T14:07:47 EGL: Move egl surface timing calls into tail calls. eglGetCompositorTimingANDROID and eglGetFrameTimestampsANDROID can both take a lot of driver time to execute proportional to ANGLE's overhead. Bug: angleproject:42266858 Change-Id: I9b991f74a261b45aeb2aaf133fca7d22cabc41f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5580877 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c53b3405 2024-05-25T02:50:27 Vulkan: Use OpCopyLogical with SPIR-V 1.4 When shaders copy structs and arrays, this instruction saves a lot of churn in the SPIR-V. Bug: angleproject:342316794 Bug: angleproject:343218484 Change-Id: I698a8d8ee8c15113e40602a0f4953726bc9a84f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5570152 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Scott Marcy b793888a 2024-05-09T11:40:18 Deeply nested switch statements -> ambiguous error Improve the error reported (and potentially avoid a stack overflow crash) when parsing deeply nested `switch` statements. Limits the total number of nested switch and/or iterator statements to `mMaxStatementDepth` (defaults to 256). Bug: angleproject:8645 Change-Id: Iba4795db15c3859d172df8366bc7de3125c2d472 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5527630 Auto-Submit: Scott M <mscott@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Shahbaz Youssefi 98402f33 2024-05-23T10:23:29 Vulkan: Explicitly set SPIR-V version Bug: angleproject:342316794 Change-Id: Ide73e3d8b167a932338419cb9da3ea358058ebeb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5564203 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang ccd9a43b 2024-05-22T11:15:39 Split EGL_ANGLE_device_d3d into D3D9 and D3D11 versions. Add EGL_ANGLE_device_d3d9 and EGL_ANGLE_device_d3d11 which make it possible to know what type of device can be queried ahead of time without generating EGL errors. Refactor the DeviceD3D class into Device9 and Device11. Remove the getType method now that it's not needed for internal validation. Keep EGL_ANGLE_device_d3d for backwards compatibility. Bug: angleproject:342096132 Change-Id: Ib950abad58e46a5be269891ea7afd0cb8534cbe8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5559163 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuxin Hu 6f8b736e 2024-05-20T11:19:55 Manual roll VK-GL-CTS from 13344922ae81 to fd5cc7b1e075 (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/13344922ae81..fd5cc7b1e075 2024-05-17 marcin.hajder@mobica.com Run clip and cull distance tests on OpenGL ES 2024-05-17 cturner@igalia.com Add coverage for transfer-only copies with multiplanar formats 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-16 gleese@broadcom.com Remove 'decor' specialisation in SPIR-V tests 2024-05-16 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-16 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-05-15 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_NV_raw_access_chains' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:341780527 Tbr: yuxinhu@google.com Change-Id: Idddeb19e94307f2313ab572432c547a76e0e7f91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5547022 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuly Novikov b71fe1c5 2024-05-16T15:10:09 Flatten vulkan-deps. Sub-repos will be now checked out in third_party directly, instead of under third_party/vulkan-deps. Bug: chromium:341002187 Change-Id: Ia1c10ce5e7865c164b29bdcabb6ab8a7e4ae35b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5545577 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 1409a05a 2024-05-14T08:01:10 Manual roll VK-GL-CTS to 13344922ae81 (14 revisions) Added new test files to gni and skipped BGRA and SwS failures glcUniformBlockNegativeTests.cpp/hpp glcBufferObjectsTests.cpp/hpp https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9d7b4c3d5533..13344922ae81 2024-05-10 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (buffer_objects), PART 5 2024-05-10 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-05-09 cturner@igalia.com Add consistency checks for video format query interactions 2024-05-09 rgarcia@igalia.com Check pipeline libraries are supported if RT pipelines are 2024-05-09 rgarcia@igalia.com QPA image viewer improvements 2024-05-09 eric@igalia.com scripts/ctsbuild: fix backslash escapes 2024-05-09 russellc@nvidia.com Reduce host memory in VK_EXT_host_image_copy tests 2024-05-09 scerveau@igalia.com EncodeTests: use the correct align for bitStreamBufferOffset 2024-05-09 javed@igalia.com Fix mesh shader to avoid reading output variables. 2024-05-09 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (uniform_buffer_object_structure_declaration), PART 6 2024-05-09 rgarcia@igalia.com Add test for scalarized flat saturation 2024-05-09 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-08 nathaniel@lunarg.com Fixup some VK_EXT_debug_utils references 2024-05-08 erik.faye-lund@collabora.com Test BGRA when supported If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8692 Bug: angleproject:8693 Tbr: romanl@google.com Change-Id: Idc2ad8d21825754ee58a7e27ce6f21f20fe5d637 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5536541 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi f4140c76 2024-05-10T16:56:13 Remove share group lock from glBindBuffer This is a very hot function. Removing the share group lock from this function improves the driver_overhead_2 execution time by ~1ms on Pixel 6. Bug: angleproject:8667 Change-Id: I9ea04f48aa1d2d0efec21407374393e88a1316e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5533081 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll dfddb4f7 2024-05-10T10:01:44 Roll vulkan-deps from 7c61bb741fb6 to 643408ea2a06 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7c61bb741fb6..643408ea2a06 Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/4bc77c26ff..5677bafb82 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1ca695d943..e74bfc215b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I92ec06db4f91b9e9d4cc7a26f8602ac163c6695e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5531181 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang a70ef7fc 2024-04-25T14:19:50 Add EGL_ANGLE_no_error for disabling EGL validation. Chrome makes many small EGL calls that can have proportionally expensive validation. Bug: angleproject:8434 Change-Id: I4f4d0e6eff64839f76a0f7bf48e5c94b8df9d809 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5491459 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Scott Marcy 2ecfc5a1 2024-05-03T18:29:12 Issue 8644: Deeply nested iterator declarations can crash Avoid stack overflow crash when parsing nested iterators (especially `while` statements). Limits the number of nested iterator statements to `mMaxStatementDepth` (defaults to 256). Bug: angleproject:8644 Change-Id: I9b0fd2ab456c3cdd731b41ab97f495ae4dc0b0bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5519169 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Auto-Submit: Scott M <mscott@apple.com>
angle-autoroll 602512a0 2024-05-08T20:46:28 Manual roll vulkan-deps from 74fe79763664 to 44adb2021ffb (62 revisions) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/74fe79763664..44adb2021ffb Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/f857417c99..effcbf7893 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/5e3ad389ee..49a1fceb9b * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dd4b663e13..9241a58a80 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/eaa319dade..4bc77c26ff * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/fa3b7bdefa..eb8c7b071a * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/d21838aeaa..df8e710224 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/68780d9b8c..358a107a6f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/397d8fbc0e..ed4446acf1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ia5f41d44828dcca8fbed32062a8e9bae606ab835 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5525919 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Geoff Lang 071e1e83 2024-05-08T10:33:49 EGL: eglCreateSyncKHR uses a return value for the tail call eglCreateSyncKHR was duplicated in two lists for using a tail call and needing a return value tail call. Bug: angleproject:8434, chromium:338902974 Change-Id: I9dffeaec3468e4ea3f5ed7d885e9ef418e8d8da5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5525854 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yiwei Zhang 5c78d084 2024-05-04T23:20:36 Android: explicitly disable stack protection This isn't needed by aosp build angle sp-hal and helps reduce cpu overhead. Bug: b/331680143, b/333235176 Test: 5% gain in gfxbench gl_driver2_off score on x86 Change-Id: I0e8662987ef040b1ac5df34a69e90c158363b36f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5516929 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org>
angle-autoroll b0875f12 2024-05-06T08:01:29 Roll VK-GL-CTS from 17c6e3c4dfad to 9d7b4c3d5533 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/17c6e3c4dfad..9d7b4c3d5533 2024-05-04 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-04 marcin.zajac@mobica.com DRM_BUF backed images witch format modifier 2024-05-04 javed@igalia.com Add test coverage for inline uniform blocks of smaller sizes 2024-05-04 cturner@igalia.com Explicitly test layered vs separated dpb images 2024-05-04 rgarcia@igalia.com Skip VVL configuration when using SELECTED_BUILD_TARGETS 2024-05-04 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-01 yuxinhu@google.com Add test log parser for new android activity 2024-05-01 lorenzo@khronosgroup.org Add verbose option to build_spirv_binaries.py 2024-05-01 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-04-25 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-04-23 lorenzo@khronosgroup.org Update external sources If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ic4db01e548ae1bbc06b0f4426d0e95eb7e4b5ced Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5516413 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yiwei Zhang 465f6b7d 2024-05-03T20:52:55 Android: forward visibility flags This results in a 25~35% perf gain for gfxbench gl_driver2_off on x86 platforms. See also https://gcc.gnu.org/wiki/Visibility Bug: b/331680143, b/333235176 Test: 25~35% gain in gfxbench gl_driver2_off score on x86 Change-Id: I5fb1174ae21f9feb33b8350e21f7cc5445b9cf25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5513280 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 04825894 2024-05-02T11:17:33 Vulkan: Turn SPIR-V limitations to crash instead of security bug The input shader can be made complex in a number of different ways, resulting in instructions with a length higher than what can fit in SPIR-V (i.e. 16 bits). Ideally, the translator would catch such complex usage early on and gracefully fail compilation. However, as a safety net, this change makes sure such a case is detected when the SPIR-V instruction is being generated and turned into a crash. This makes sure such bugs are no longer security bugs. Bug: chromium:335613092 Change-Id: I5c0693ac1ead5af04977417f10572018f8aa72bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5510722 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski 6658d5e8 2024-04-25T13:51:43 Tests: Add Modern Combat 5 trace Test: angle_trace_tests --gtest_filter=*modern_combat_5 Bug: b/330861486 Change-Id: I54b22010fdb5be6d1113f4dd6561848b44a413cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5501770 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Geoff Lang 038ad6c7 2024-04-23T13:23:04 EGL: Use unlocked tail calls for surface, sync and img calls EGL surface and sync calls can be expensive to do while holding the global lock on EGL. They are safe because the parameters are captured by value and the underlying EGL driver is also thread safe. EGL image creation also tends to be expensive and is called freqently by Chrome. Bug: angleproject:8434 Change-Id: I7e554fe2e3700d98469de267f7bbff1e96358c78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5478229 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Amirali Abdolrashidi 8332e5b1 2024-04-26T14:29:32 Use python3 instead of python for bootstrap * In roll_aosp.sh, replaced the remaining python usage with python3. Bug: b/246559064 Change-Id: Iea9737376c34264fec5d60e4cb772eb8c5be81f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5494462 Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Geoff Lang 884dc380 2024-04-24T16:46:01 EGL: Make eglGetCurrent(Context|Surface|Display) lockless. These functions access only egl::Thread state. Bug: angleproject:8434 Change-Id: I3dd6cd1f4fd145613f0be824e4f6e13815422997 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5485526 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 94179bed 2024-04-23T13:57:45 Roll chromium_revision 39c16b7a37..b00758dcbb (1290535:1290830) Update scripts/roll_chromium_deps.py to ignore GCS DEPS entries. Change log: https://chromium.googlesource.com/chromium/src/+log/39c16b7a37..b00758dcbb Full diff: https://chromium.googlesource.com/chromium/src/+/39c16b7a37..b00758dcbb Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f381a5d258..c7d168ab6d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5eb927f0a9..571c37f17d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/844489d5bf..fdc7df36c5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6ba67afd6f..917a57459b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/31ab5f9786..628a8e6856 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e0d0c28dbe..bca0c9f60a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8f37fed0b7..918fef0e46 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8bf48ae269..3f41393fee DEPS diff: https://chromium.googlesource.com/chromium/src/+/39c16b7a37..b00758dcbb/DEPS No update to Clang. Bug: b/328065301 Change-Id: Ied690fe00ca0f82d4c5e17092ea96a6bc0f9b7d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5476868 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 84b87373 2024-04-19T10:01:03 Roll vulkan-deps from aa20d192b8c4 to 4737535cad1a (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/aa20d192b8c4..4737535cad1a Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2904985aee..dadb3012d5 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/1e7b8a6d03..eaa319dade * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b11c199a3a..d1316e5423 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I60b146950090923f2ff6746ebc68035570b5861c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5466018 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi c75b03ad 2024-04-18T16:09:48 Vulkan: Remove duplicated fallback entry in vk_format_map.json Bug: b/335496851 Change-Id: Id5fe805a15ae4fa4b09ffbf05fcf7b6d3d79b1ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5463921 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu d0b01c81 2024-04-17T14:40:10 Remove duplicated fallback entry in vk_format_table_autogen Bug: b/335496851 Change-Id: Iff6a095aaffac099779b093e02b1a818b510dc0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5464161 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Roman Lavrov 4109a90e 2024-04-16T17:31:11 LinkedUniform: avoid frequent GLenum -> index conversion Certain functions such as getElementComponents() are frequently called in driver_overhead benchmark, causing repeated GLenum -> index conversion of the uniform type which shows up in profiling (driver_overhead_2 trace) Change LinkedUniform.pod.type to LinkedUniform.pod.typeIndex storing the UniformTypeInfo index with conversion helpers. Bug: b/335295728 Change-Id: Iae5cd58f4e2703589d23b8e52991fc4b97c5fb08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5458741 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Yuly Novikov 5f532b75 2024-04-18T09:19:23 Roll chromium_revision 0abb3a90f2..b07526b70d (1287851:1289209) Unpin abseil-cpp and related DEPS, since Mac Skia bots older than macOS 10.15 were removed, so ANGLE can update abseil-cpp now without breaking roll into Skia. Roll third_party/dawn/ 66f38fda8..ed2c7c713 (212 commits; 6 trivial rolls) https://dawn.googlesource.com/dawn.git/+log/66f38fda85fe..ed2c7c7133fd in order to fix build with updated Clang, https://dawn-review.googlesource.com/c/dawn/+/182582 Change log: https://chromium.googlesource.com/chromium/src/+log/0abb3a90f2..b07526b70d Full diff: https://chromium.googlesource.com/chromium/src/+/0abb3a90f2..b07526b70d Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fffc0b385f..fc6b52cdab * buildtools/linux64: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25 * buildtools/mac: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25 * buildtools/win: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/87207dd445..d47dd4e908 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b3ae305fd5..a64dd87cec * third_party/android_build_tools/manifest_merger: UiE3IQmTjQyDp6olH-K75Gup3wY_WezHKM9riMylXVcC..q4q38FXedJ-uNPtYpwR--VhUglwaiG95Nz1aNXyOL9gC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/12e53bce03..e939ac77bb * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/22de5fb717..6aaae85821 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/80307e66e7..e3b94d0e5b * third_party/r8: 4lmbDFBqkP3D6DWu4MC8eiktQ4wuHyTMVJIWoU_q30AC..vLrV1g3mole2jBVpiMB13SquCOCucEVK_ImpPqXYIR8C * third_party/siso: git_revision:437716714a744e272fabdf1377b8878ccac26b43..git_revision:44d2b8f5b840adf521bb4912ccac31848f6d1448 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/84f141bb4e..10697c9ce8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/279d79a374..78c03ab18c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bcadedd547..b31325ceb7 * tools/skia_goldctl/linux: ZpyLtfuztdYI-RCkvm6kXlmx8ec1wYyrwXNI-lQEJKwC..SQswrvGi674ASEtZKS6NGrcxzcOAx9fdEvxSUwNCVkIC * tools/skia_goldctl/mac_amd64: FpwpXsMPl8Mets8uet3zfFw8nNBpl69xJoTYESLUjl8C..vuB-Klm2s3uWsshi6g4r4l4fZox0RrWCgtSRKTxev3QC * tools/skia_goldctl/mac_arm64: GuJOsvx5V5z8DvAM_HOVy6eBydQ0sO7dVso_p_L7KTgC..sqWmO8LOK7GgLCYuZo_PWkn6BcuBSgv16TPYoV44QUsC * tools/skia_goldctl/win: LT6gNudC207ke0t4qv9IW_s27hoPIafnwpcfrzR8FzMC..4Y2pcWzsEQOJJ76XA1eaNSwef4YuyOrnQ-lSK1-71PkC DEPS diff: https://chromium.googlesource.com/chromium/src/+/0abb3a90f2..b07526b70d/DEPS Clang version changed llvmorg-19-init-2941-ga0b3dbaf:llvmorg-19-init-8091-gab037c4f Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/279d79a37479b4b12bb4c4c27d224fd8503fbee7..78c03ab18cb89612654b8faf957eb30635316466/scripts/update.py Bug: skia:330350366, angleproject:8555, angleproject:8474 Change-Id: I70d907d78339dac9a0c0e7c6b96819c5cd62aa9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5465699 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll c4880865 2024-04-16T22:54:12 Manual roll VK-GL-CTS from b529676d0523 to 669273b1098a (11 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b529676d0523..669273b1098a 2024-04-12 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-04-11 slawomir.cygan@intel.com Add fragment shading barycentric for mesh shading, interpolation and provoking vertices 2024-04-11 rgarcia@igalia.com Test occlusion queries with no attachments 2024-04-11 javed@igalia.com Add coverage for creating a 2D image view of a sparse 3D image. 2024-04-11 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-04-10 rgarcia@igalia.com Do not build VVL when using SELECTED_BUILD_TARGETS 2024-04-05 javed@igalia.com Add coverage for mutable descriptor type list being out of range. 2024-04-05 ziga@lunarg.com Add missing resolve image in rasterization tests with multisampling 2024-04-05 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-04-03 yuxinhu@google.com Add the instruction to run new ES32GetTestParamActivity 2024-04-03 slawomir.cygan@intel.com Add tests for clipping in mesh shading, with provoking vertices and multiview If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I511b15edb5750f2065da5b039ce5447a9f0d4689 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5458196 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi e92b8e8d 2024-04-16T13:27:19 Manual roll VK-GL-CTS from 491cfc2dbec9 to b529676d0523 (1 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/491cfc2dbec9..b529676d0523 2024-03-29 yuxinhu@google.com Move external/openglcts/data into a new subdirectory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I5e07217cca190ec243f1b700348cde0384dbf052 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5457892 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e344c4bc 2024-04-16T13:48:04 Manual roll VK-GL-CTS from 393ca590ec21 to 491cfc2dbec9 (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/393ca590ec21..491cfc2dbec9 2024-03-29 lorenzo@khronosgroup.org Limit Vulkan validation layers compilation to Linux and Android 2024-03-29 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-03-29 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-03-29 gleese@broadcom.com Remove deIsInf, deIsNaN and variants 2024-03-29 gleese@broadcom.com Stop generating (some?) empty test groups 2024-03-29 lionel.g.landwerlin@intel.com Fix protected memory allocations with unprotected buffers 2024-03-29 yuxinhu@google.com Add a new Android Activity that exports ES32 Test Run Params 2024-03-29 yuxinhu@google.com Add scripts to generate Android bp for compiling both dEQP and KHR GLES tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: Ida602870bf73d362b3b82dab003c78626e825321 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5459013 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 1264c9cc 2024-04-16T13:22:16 Manual roll VK-GL-CTS from caf989d22e07 to 393ca590ec21 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/caf989d22e07..393ca590ec21 2024-03-29 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (transform_feedback3), PART 4 2024-03-29 marcin.zajac@mobica.com Test depth with VK_EXT_fragment_density_map 2024-03-29 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-03-28 skr@nvidia.com Consider layer index when retrieving decoded frame 2024-03-26 rgarcia@igalia.com Share test configuration between case and instance in EDS tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I562b77d2dab2e949a2562c1bb0e655e1ed8bb5df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5459012 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 50d95bfe 2024-04-15T19:37:04 Manual roll vulkan-deps from 3ba43743089e to ec0c320a8ca1 (34 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/3ba43743089e..ec0c320a8ca1 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/8a3ea594c7..2db79056b4 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ade1f7cfd7..2904985aee * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/cfebfc96b2..1e7b8a6d03 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/2cb930f7f7..77d1f98036 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/c5da01ee0a..d14404b26e * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/0519e66f42..72696f2782 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/dc9a7170f2..d89ce7ad87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I028b7c0497a345465bfef86c2a58682f230ee864 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5455451 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 67fc293a 2024-04-05T13:25:12 WebGPU: Add shader translation and program linking stubs. Add a TranslatorWGSL which outputs the same translated shaders every time. Implement the compile and link tasks. Bug: angleproject:8662 Change-Id: I62bbd6c528e1d671d0f4becc38f15f1eceb0336c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5428807 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Scott Marcy e088af30 2024-03-28T15:30:59 Parsing very long array declarations crash Avoid stack overflow crash when parsing arrays with a huge number of dimensions. Limits the number of array dimensions to `mMaxExpressionComplexity` (typically 256). Use `YYABORT` to abort parsing. Bug: angleproject:8610 Change-Id: Icf3914871b167c820b84ae8f3acba80dbd698af3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5424330 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d9943e44 2024-04-09T23:53:48 Remove Program::syncState The last bit of responsibility still left in Program::syncState was to wait for post-link tasks for the sake of EGLBlobCacheTest tests. A new extension, GL_ANGLE_program_binary_readiness_query is created so that the wait can be done in the test itself. This extension is ultimately useful for applications as well, so they can avoid blocking the CPU by calling glGetProgramBinary prematurely. Bug: angleproject:8297 Change-Id: Ied6b755cb9b060198f82c7948bfd03441435a578 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5440302 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 57eded36 2024-04-03T23:02:39 Vulkan: Fix off-by-one error in compute-based stencil blit The coordinates used for sampling were calculated based on pixel's top-left (integer) coordinates and used with a NEAREST sampler. This resulted in two bugs: - When X was flipped, the bounds check rejected the first column - The sampling could pick the wrong pixel as the on-the-edge coordinates could map to either of 4 pixels that share that corner. This change moves the sampling coordinates to the pixel's center. Bug: angleproject:8652 Change-Id: I0b54fa0bad366f52f8e6c17bb0054fa373af8b5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5420834 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Roman Lavrov be79ae93 2024-04-02T10:33:06 Codegen: work around unicode in vk.xml causing hash diffs Reading file as text gets around \r\n translation but that messes things up on unicode characters that we have in third_party/vulkan-deps/vulkan-headers/src/registry/vk.xml Bug: angleproject:8643 Change-Id: Ic59dbb074e0bb730d0e614a4bc909979303a1398 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5413774 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuly Novikov fdade369 2024-04-04T14:42:52 Ignore DisplayGLX_api.h in export_targets.py Bug: angleproject:8648 Change-Id: I76a4e59b8a3d82316f11e058fe53b599ef8394ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5424091 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 5d294e6e 2024-04-01T11:32:17 Manual roll VK-GL-CTS from 08c8f6c7aa44 to caf989d22e07 (30 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/08c8f6c7aa44..caf989d22e07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: b/332383430 Tbr: yuxinhu@google.com Change-Id: If0518d4db878990405bf5813ca456eafae0d9970 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5410639 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Solti 76113ffb 2024-03-27T20:35:46 Manual roll VK-GL-CTS from fe6e7bd09f53 to 08c8f6c7aa44 (1 revision) Manual roll requested by solti@google.com Some local updates were made to the roll, see https://anglebug.com/8636 for details. https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fe6e7bd09f53..08c8f6c7aa44 2024-03-21 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (framebuffer_blit), PART 2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Test: presubmit Bug: angleproject:8636 Bug: b/331390622 Change-Id: I4e754b2a91f8a321e709842a8cf146bbf54a2199 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5402981 Auto-Submit: Solti Ho <solti@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuly Novikov 93b45da9 2024-03-29T12:44:00 Pin clang until Skia is able to build with ToT abseil. ANGLE pins abseil-cpp until https://skbug.com/330350366 is resolved. Therefore ANGLE's abseil-cpp uses old DEF files, which can't be kept in sync with new clang, e.g. here: https://chromium-review.googlesource.com/c/angle/angle/+/5406623 which includes DEF file updates in https://chromium-review.googlesource.com/c/chromium/src/+/5405904 Bug: angleproject:8555 Change-Id: Iac06d456aadaf2b3dd08a943a46d710ee25887d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5401708 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Solti Ho <solti@google.com> Reviewed-by: Solti Ho <solti@google.com>
angle-autoroll 7eac8f60 2024-03-26T22:10:57 Manual roll VK-GL-CTS from ec9827528085 to fe6e7bd09f53 (1 revision) Manual roll requested by solti@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ec9827528085..fe6e7bd09f53 2024-03-20 michal.jakubek@mobica.com FS output interface tests with multiple attachments If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I130424c7306b490b05a8000cf78b4273813c2479 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5397514 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2cddd918 2024-03-26T21:19:26 Manual roll vulkan-deps from ba66ec69216d to 3bf81e7e8859 (57 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/ba66ec69216d..3bf81e7e8859 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b047a21033..3225778615 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/8b246ff75c..7d500c4d75 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6c3f632a2c..fe7bae0906 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/577baa0503..cfebfc96b2 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/61a9c50248..f60412f5a6 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/e5f1de8968..e3f8bd7aa6 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/a4140c5fd4..4befdac21a * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/57084b5d12..2ac49e5c08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I413f95419a19b9457696f30902c66f69f9dba142 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5397509 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 1d5991d9 2024-03-26T16:36:23 Pin libc++ until Skia is able to build with ToT abseil. ANGLE pins abseil-cpp until https://skbug.com/330350366 is resolved. Therefore ANGLE's abseil-cpp uses old DEF files, which can't be kept in sync with new libc++, e.g. here: https://chromium-review.googlesource.com/c/angle/angle/+/5391204/1 Bug: angleproject:8555 Change-Id: Ib61a80136e389ffbd67c7c378a5c8d9c2659be55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5397577 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Solti Ho <solti@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Roman Lavrov 93da22dd 2024-03-22T16:10:51 use_cxx17=true in arm debug compile Android rolls currently require C++17, set ANGLE to C++17 to prevent Android roller breakage Bug: b/330910097 Change-Id: I94ef05f91a3532a42876e27b296342552aede974 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5387270 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Mark Lobodzinski 2d4a027d 2024-03-20T12:07:45 Tests: Add Poppy Playtime Trace Test: angle_trace_tests --gtest_filter=TraceTest.poppy_playtime Bug: b/330861486 Change-Id: Ifd18ec32bce1db585bb4d284a39ed78a94932d8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5387536 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mohan Maiya 318e5e02 2024-03-24T08:17:56 Vulkan: Update EGL_EXT_buffer_age implementation 1. Buffer age is always 1 when swap behavior is EGL_BUFFER_PRESERVED. 2. WindowSurfaceVk::getBufferAge no longer acquires a swapchain image. See commit: b46cf6989f6fe8db5f0759001f633681a96fadde 3. It is valid to pass attributes of eglQuerySurface API to eglQuerySurface64KHR API 4. Add deadlock fix to eglQuerySurface64KHR Bug: angleproject:3529 Bug: angleproject:6851 Tests: EGLLockSurface3Test.QuerySurfaceAndQuerySurface64Parity* Tests: EGLBufferAgeTest.QueryBufferAge* Change-Id: Idf3c4fc08364f671fb02e99111be2beb7a1d9f3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5389461 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 96f44329 2024-03-25T14:16:10 Revert "Remove few redundant ImmutableString to std::string conversions" This reverts commit ebb94b807f184f2d36cb0843c429667cd80e0675. Reason for revert: Needs a different implementation of std::string::size() to pass C++17 compilers. Original change's description: > Remove few redundant ImmutableString to std::string conversions > > Maybe removes few strlen calls. > > Bug: angleproject:8614 > Change-Id: I4fbb5f6abb8e8d21ff44a34975bab379127a0a11 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5372715 > Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: angleproject:8614 Change-Id: I1a635b74674a2e1b635972bb4372c43340527a2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5391900 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0