kc3-lang/angle

Log

Author Commit Date CI Message
Shahbaz Youssefi d06feeac 2021-01-08T00:48:18 Vulkan: Generate xfb support code in SPIR-V for extension path The only piece of code that's needed to be generated for the extension path is the following, at the right spot (right before depth correction and pre-rotation): ANGLEXfbPosition = gl_Position; The SPIR-V transformer already has gl_Position loaded for depth correction and pre-rotation, so this change simply adds an OpStore to ANGLEXfbPosition. As a result of this change, @@ XFB-OUT @@ is no longer emitted if the transform feedback extension is supported. With the above code now placed correctly for geometry shaders, transform feedback tests for geometry shaders are enabled. Bug: angleproject:3606 Change-Id: I13a7956ab62a1a6b4196ff999442b99b50226c0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617659 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 8f5ca266 2021-01-07T16:04:16 Vulkan: Move xfb position decl to translator in extension path This change removes the @@ XFB-DECL @@ marker. The ANGLEXfbPosition output is unconditionally emitted in VS, TES and GS by the translator, and is appropriately decorated or removed by the SPIR-V transformer. Bug: angleproject:3606 Change-Id: Ia76224f5a6d147362eeb2d288f05e333aaf75481 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617658 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Alexey Knyazev ebdd8abb 2021-01-13T23:42:44 OpenGL: Remove avoidDXT1sRGBTextureFormat workaround Bug: angleproject:5543 Change-Id: I2a7e2d563aa60e6e53dd6b6c32fbc449368e4e06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2627425 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Jamie Madill 738cb55b 2021-01-14T17:33:20 Capture/Replay tests: Fixes and improvements. The script was broken after the change to build to a separate shared library. Also fixes issues on Windows and cleans up the code. State comparison is still broken on every test from what I can see. Bug: angleproject:5530 Change-Id: I23e77e56fadedfb85d7afdb59dddac5558a71a56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2630232 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 1e4f8b02 2020-12-21T23:47:47 Vulkan: Generate gl_Position.z correction in SPIR-V Instead of having the translator output code to transform gl_Position.z to Vulkan clip space in the vertex stage, this change makes the SPIR-V transformer perform this operation on the last geometry stage. An alternative solution would be to generate this transformation in the translator in every geometry stage, each controlled by a separate specialization constant. This change avoids unnecessary modifications to earlier stages. Additionally, the transformer is already modifying gl_Position.xy for pre-rotation, so the addition of a small transformation of gl_Position.z in the same spot is rather trivial. Bug: angleproject:5479 Change-Id: Id971179ba47b206204bfdaf3b2b295ef97dd5117 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2598585 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll d2e76b73 2021-01-15T10:01:51 Roll SwiftShader from 5255c465bbba to aedd133cd85f (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/5255c465bbba..aedd133cd85f 2021-01-14 amaiorano@google.com VulkanBenchmarks: fix memory leaks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ie147a2aae685b67d386f1791b85a5fb96125b69b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2632338 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2b8e9351 2021-01-15T10:01:55 Roll vulkan-deps from 5869a809d551 to 7b69f3d087b8 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5869a809d551..7b69f3d087b8 2021-01-15 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from a5eaf2f44a5d to 9acb9ec31f5a (1 revision) 2021-01-14 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from b2cfc5d1ceca to 9150cd441f43 (1 revision) 2021-01-14 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 586c46b96b62 to fb2ab876edcd (1 revision) 2021-01-14 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 820179bf4689 to a5eaf2f44a5d (1 revision) 2021-01-14 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from cec658c11603 to b2cfc5d1ceca (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I6257bd54fd803b344da731012fa97544ba4acafc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2632727 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5678b56f 2021-01-15T07:35:52 Roll Chromium from fabc0b0b129a to 2ef9c5ff8ca7 (556 revisions) https://chromium.googlesource.com/chromium/src.git/+log/fabc0b0b129a..2ef9c5ff8ca7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d64e5999e3..670a9057fa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/bf4e02dbca..ce2030d539 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b2af2da348 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b12d1c836e..ba4ee03425 * tools/luci-go: git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9..git_revision:77944aa535e42e29faadf6cfa81aee252807d468 * tools/luci-go: git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9..git_revision:77944aa535e42e29faadf6cfa81aee252807d468 * tools/luci-go: git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9..git_revision:77944aa535e42e29faadf6cfa81aee252807d468 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/46eeb6cbe3..42beda611f * tools/skia_goldctl/linux: UBQI89SqFeAIiGdjUUikXKgyMRFxDbvtqVUceCn1kcwC..kjkgNP4EaChPUcoDLbUiF85Tgg3RbK3xzpcwZ5HyUosC * tools/skia_goldctl/mac: Cb3ZdanPJ4Sjcf0QVUa5PMI5nkXnfRX3fQltIjHI7ZoC..Asi8KSWBq6NEwkADY8wYitzLWv01uuZURhT1kYqop6IC * tools/skia_goldctl/win: kIBp6ZuMA5QTpwxtMM3NtSMezpaetuByhNmVTMg8TtMC.._5BJmSzcXDTJJSe1g7mA2Qb5L1P6cEseriZG8lUfDuAC No update to Clang. Bug: angleproject:5543 Tbr: timvp@google.com Change-Id: I20fda3ff99f2d6e2af4c41d28afc91ffdf7cf3e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2631374 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 0f86b196 2020-12-21T22:54:05 Vulkan: Generate gl_Position pre-rotation in SPIR-V Instead of having the translator output pre-rotation code in the vertex stage based on a specialization constant, this change makes the SPIR-V transformer perform pre-rotation of gl_Position on the last geometry stage. An alternative solution would be to generate pre-rotation code in the translator in every geometry stage, each controlled by a separate specialization constant. This change avoids unnecessary modifications to earlier stages. The generated shaders are also smaller, as they don't contain a mat2[8] pre-rotation constant matrix. The SPIR-V transformer knows the pre-rotation at transformation time, so it can simply use swizzles to achieve the same results. This also ties in with upcoming changes which move gl_Position.z correction to the last geometry shader stage, which is trivially done piggy-backing on the infrastructure in this change. Bug: angleproject:5478 Change-Id: I9d5d9d19f3ccda665f5504368ce5ddfa5f383faf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2598584 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 29eeb610 2021-01-12T11:59:48 Vulkan: Fix validation of MSRTT framebuffer attachment The attachment was being accessed before being validated. A fuzzer test was giving this function texture ID -1. Bug: chromium:1146753 Change-Id: Ic48f5fd2eed4252e90be5d63fd698b38bd3ef85f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2623814 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 50c82f42 2021-01-14T15:15:10 Don't index into SystemInfo gpus if it's empty. angle::GetSystemInfo may return success on some platforms without writing any entires into the gpus vector. Make sure we don't index into this vector when it's empty. Bug:chromium:1166338 Change-Id: I4cafeadf7aa9ac55b25a1afa04c8d28a2edf52e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2628140 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Tim Van Patten 861378be 2021-01-12T11:12:56 Tests: Add Magic Tile 3 trace Test: angle_perftests --gtest_filter=TracePerfTest.Run/*magic_tiles_3* Bug: angleproject:5540 Change-Id: I6d6f144d4c2a38cfc55724f7e454f756a162d054 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622611 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi c07ef602 2021-01-05T12:26:05 Vulkan: Move xfb buffer decl to translator in emulation path This makes @@ XFB-DECL @@ empty on this path. Ultimately, this is working towards removing both @@ XFB-DECL @@ and @@ XFB-OUT @@ macros for both the emulation and extension paths, allowing the shaders to be compiled at compile time rather than link time. Bug: angleproject:3606 Change-Id: If16e9d92c419a04ecd3094481ed546d0708cdb43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611305 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Tim Van Patten a1b4a1f3 2021-01-14T11:02:43 Capture/Replay: Only get source for linked programs CaptureMidExecutionSetup() currently assumes that all created programs have also been linked, since mCachedProgramSources is only updated when glLinkProgram() is called. However, a call to glCreateProgram() doesn't necessitate a call to glLinkProgram(). This leads to hitting an assert in FrameCaptureShared::getProgramSources() when iterating all glCreateProgram()'ed programs, but doesn't find that it in the list of linked programs. This fix is to move the program->isLinked() call earlier. Bug: angleproject:5545 Change-Id: I49fdec08de1c2767fe7f6a08fd0a9d53fa865167 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2629789 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill e357cc6f 2021-01-14T14:47:02 Revert "Vulkan: Prefer host cached memory for Buffers" This reverts commit 326f128b941d54c0277178f87e784da8ce2190eb. Reason for revert: Fails of Mali platform. See bug: Bug: angleproject:5544 Original change's description: > Vulkan: Prefer host cached memory for Buffers > > This improves perf because vertex data upload uses host visible memory, > and uncached memory can be slow. > > Test: > > Android on Windows with 1080Ti: > glmark2 [build] vbo=false 265 -> 3900 fps > > Bug: angleproject:5515 > Change-Id: Ib75582bbdb4ca4a22d3a121c7b477a23a8a809ef > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615742 > Commit-Queue: Lingfeng Yang <lfy@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Tim Van Patten <timvp@google.com> TBR=geofflang@chromium.org,lfy@google.com,doughorn@google.com,timvp@google.com,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:5515 Change-Id: I59695b1981b43471dbd309d4e859bae7a4821969 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2627604 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jason Macnak d392af02 2021-01-12T10:08:31 Update roll AOSP scripts to reflect vulkan-deps subdirectory Performing a roll with this changes produces https://android-review.googlesource.com/c/1548235 Bug: b/147316305 Bug: angleproject:5456 Test: scripts/roll_aosp.sh && m ANGLE Change-Id: I0f5a698e81a1299abde7cfccb4e1467c8dc02aad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2625168 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tim Van Patten 0056151c 2021-01-12T16:49:46 Fix call to getImageFormatFeatureBits() in SurfaceVk.cpp The function getImageFormatFeatureBits() was recently refactored which changed its parameters. One call to this function in SurfaceVk.cpp is underneath a #if ANGLE_ENABLE_OVERLAY though, so it was missed. This CL updates the call to getImageFormatFeatureBits() with the correct paramater as well as moves the code outside of the #if and into a normal conditional to prevent similar issues in the future. Bug: angleproject:5438 Change-Id: I499c25d98e4e22b5e1bb14e6e6c9ef378d77307f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2626348 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 72c58a86 2021-01-14T10:01:51 Roll SwiftShader from 3549479dc4cc to 5255c465bbba (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/3549479dc4cc..5255c465bbba 2021-01-14 swiftshader.regress@gmail.com Regres: Update test lists @ 2cc34907 2021-01-13 amaiorano@google.com VulkanBenchmarks: add texture sampling to Triangle benchmarks 2021-01-13 amaiorano@google.com Implement VK_EXT_headless_surface 2021-01-13 natsu@google.com Update AHB default YUV dataspace to YCBCR_601 2021-01-13 capn@google.com VulkanBenchmarks: refactor into Image class 2021-01-13 capn@google.com Fix back-face culling for vertices near w=0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Id6dd8cbbd310059f5fd761656bba7935fc419edb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2628659 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1bd47b90 2021-01-14T10:01:55 Roll vulkan-deps from 50bcbaad4cbf to 5869a809d551 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/50bcbaad4cbf..5869a809d551 2021-01-13 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f5dea94f6f15 to 586c46b96b62 (1 revision) 2021-01-13 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from a3b988fa5588 to c86cec54abe6 (1 revision) 2021-01-13 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 04b58c5bea3a to f5dea94f6f15 (1 revision) 2021-01-13 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 7bbe1a316419 to cec658c11603 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I1dfff92ef0c46159b2b285ccf46494013258a3f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2629107 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b421774a 2021-01-14T07:21:52 Roll Chromium from 451c64aaec04 to fabc0b0b129a (518 revisions) https://chromium.googlesource.com/chromium/src.git/+log/451c64aaec04..fabc0b0b129a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d68ac97401..d64e5999e3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/625f969626..bf4e02dbca * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/cadb7225e4..947ea991af * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..178c01be65 * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/09efc26aff..518d81558c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c2ae4814ba..46eeb6cbe3 * tools/skia_goldctl/linux: 1TBlbVMfJAvbrsCVFRL54CvG6OJv660nvwlbVn3QedoC..UBQI89SqFeAIiGdjUUikXKgyMRFxDbvtqVUceCn1kcwC * tools/skia_goldctl/mac: zFHl-BrDnpmevfoDmWcr04CNai3vqwCPB6AYeJXJ744C..Cb3ZdanPJ4Sjcf0QVUa5PMI5nkXnfRX3fQltIjHI7ZoC * tools/skia_goldctl/win: AefJEwE3M-ke_pwYEVGy2Ct2Ra80EaxvK1KADBuG8-EC..kIBp6ZuMA5QTpwxtMM3NtSMezpaetuByhNmVTMg8TtMC No update to Clang. Bug: angleproject:5499,angleproject:5534 Tbr: timvp@google.com Change-Id: I6c8e0c9e07695961751d7080ed5e06d457eeef49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2625942 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Sunny Sachanandani 198dc345 2020-08-06T16:32:03 Support importing NV12/P010/P016 D3D textures as EGLImage Allow importing individual planes of NV12/P010/P016 D3D textures with supported SRV/RTV formats. Restrict these to GL_TEXTURE_EXTERNAL_OES to limit to using as shader inputs or render targets and prevent unsupported operations like ReadPixels. Test: D3DTextureYUVTest* Bug: angleproject:5538, chromium:1116101 Change-Id: If5bf54f4f75bb2c703890ce3f5fbd67e4461c98f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2338827 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 124cdcb5 2021-01-13T16:36:18 Don't build angle_end2end_tests_mac_sources on iOS Getting a compile error for them: ../../third_party/angle/src/tests/egl_tests/ EGLIOSurfaceClientBufferTest.cpp:16:10: fatal error: 'IOSurface/IOSurface.h' file not found include <IOSurface/IOSurface.h> ^~~~~~~~~~~~~~~~~~~~~~~ ../../third_party/angle/src/tests/egl_tests/ EGLIOSurfaceClientBufferTest.cpp:16:10: note: did not find header 'IOSurface.h' in framework 'IOSurface' (loaded from '/opt/s/w/ir/cache/xcode_ios_12a7209.app/Contents/ Developer/Platforms/iPhoneOS.platform/Developer/SDKs/ iPhoneOS14.0.sdk/System/Library/Frameworks') Bug: angleproject:5417 Change-Id: I60198bbacc0726a9842fe37fad5b10b9afff37a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2628129 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya 6c79df68 2021-01-11T09:07:08 Allow attributes and uniforms to have the same name It is valid for an attribute and a uniform to have the same name as long as they are declared in different stages. Prior to this patch, if any shader stage declares a uniform we disallowed reusing that name for an attribute. From GLSL ES Spec 3.00.6, section 4.3.5: If a uniform variable name is declared in one stage (e.g., a vertex shader) but not in another (e.g., a fragment shader), then that name is still available in the other stage for a different use. This change allows Egginc game to work with ANGLE Bug: angleproject:5497 Tests: angle_end2end_tests - *UniformVariableNameReuseAcrossStages* *GlobalNamesConflict* Change-Id: I8f5657d40a213600d6fb48f63e37e4cdbae120b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2608865 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Jamie Madill 70d8561d 2021-01-13T14:21:31 infra: Fix win-trace-rel bot typo. Was accidentally specified as "linux-win-rel". Bug: angleproject:5530 Change-Id: Ica5ac1dd685704835049d8f222196f3eb5f7e8c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2626514 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill d654ac9b 2020-12-30T12:28:41 Program: Support multiple varying packings. Instead of using a single varying packing for all program stages, we switch to using a varying register packing for each pair of input/output shaders. This allows several valid use cases that use many varying to succeed. For instance Geometry Shaders have both an input and output varying packing. With tessellation shaders the upper bound of valid varying packings in one Program goes up even more. We keep multiple varying packings at once inside a new "ProgramVaryingPacking" class. Internally the class keeps a unique varying mapping for each input/output interface in the program. Separable programs with "open" interfaces are handled specially. Fixes a bug where varying counting was artificially limited for programs with more than two shaders. This CL also disables GS support when we're emulating line raster so we don't have to figure out the details on how to place the special position varying. Bug: angleproject:5496 Change-Id: I1f9a327c4750caef570c608d86953e9d0cc5eea3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606532 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Cody Northrop 8943d1e2 2021-01-12T22:21:38 Capture/Replay: Add DrawBuffer state to MEC This results in calls like this added to Setup*: const GLenum glDrawBuffers_bufs_38[] = { 36064, 36065, 36066, 36067, 0, 0, 0, 0 }; ... glDrawBuffers(8, glDrawBuffers_bufs_38); Test: Aztec Ruins MEC Bug: b/160808198 Bug: angleproject:3662 Bug: angleproject:5541 Change-Id: I1c6282e292f225684c99b5de65daf8ad15b0db56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2627907 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill e4b4ff7a 2021-01-12T13:48:20 Test Runner: Add a slow tests list. Each slow test in the list will use a 3x longer timeout. The list is implemented using the same filter wildcard we use in the test expectations logic. We can test this out using a slow D3D11 varying test. Bug: angleproject:5076 Bug: angleproject:5496 Change-Id: I31cf45e6ee8a8bbd6e460d675ff8a0cf5f19a504 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2625172 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 47e9aed2 2021-01-12T13:50:56 Remove Sleep() from PrimitivesWrittenAndGenerated test. Attempt to fix timeouts due to test ordering. Bug: angleproject:5496 Change-Id: I323e85c372c8b4a5e9fc4201004f39bffb1676d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2625169 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 93d69be2 2021-01-13T11:13:00 infra: Fixes for config. Responding this this error: WARNING: commit-queue.cfg: in "commit-queue.cfg" (config_group #1): please, specify `name` for monitoring and analytics ERROR: refs.cfg: refs.cfg is not used since 2019 and must be deleted Bug: angleproject:5530 Change-Id: I3ec13faa641918ba66b1a1b6a68e1eb1854fcc6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2626174 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Junji Watanabe f7801a3b 2021-01-13T13:30:41 Use CAS in scripts/trigger.py Isolate server is being migrated to CAS. This CL changes trigger.py to use CAS instead of Isolate server. Bug: chromium:1163817 Change-Id: I137cd656798c08bf991cb77da36780b87193f821 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2626931 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 9a39b7b3 2021-01-12T14:20:46 Add configuration for trace test bots. The bots will be called win-trace-rel and linux-trace-rel. Currently they work as clones of the compile bots. Once we add the recipe config they'll also run the trace tests. They won't be added to the CQ. Bug: angleproject:5530 Change-Id: I5457cc10860cc15a8a12e766ed2dfc6e4a4fa602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2625170 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 21583413 2021-01-13T10:02:55 Roll vulkan-deps from e59ae1af7571 to 50bcbaad4cbf (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e59ae1af7571..50bcbaad4cbf 2021-01-12 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from be70e017bff5 to a3b988fa5588 (1 revision) 2021-01-12 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 61a57c023e10 to 04b58c5bea3a (1 revision) 2021-01-12 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from c32277c0ba0d to 7bbe1a316419 (1 revision) 2021-01-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from a7825740f316 to be70e017bff5 (1 revision) 2021-01-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 645a15bbaa59 to 61a57c023e10 (1 revision) 2021-01-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 46237b593c3f to 645a15bbaa59 (1 revision) 2021-01-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from f3ccb633dfd7 to c32277c0ba0d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I607df216330f68f36cf0a3e48a0a5b01b67b8293 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2627428 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 62b8364e 2021-01-13T07:00:37 Roll Chromium from 2a7e78c75a37 to 451c64aaec04 (494 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2a7e78c75a37..451c64aaec04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3769c3b43c..d68ac97401 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6e80dc5c14..625f969626 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3889691dd6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/82425b6b98..b12d1c836e * tools/luci-go: git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e..git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9 * tools/luci-go: git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e..git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9 * tools/luci-go: git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e..git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/28924eafb2..c2ae4814ba * tools/skia_goldctl/linux: SydJmfq0VW7jq5fTDGtIQ-7WoB0vNc-LJAi3Xd4fKvQC..1TBlbVMfJAvbrsCVFRL54CvG6OJv660nvwlbVn3QedoC * tools/skia_goldctl/mac: oxKWG6EzN6FHwQ-4J6gUYMHuNuHyARpVl4EvirOsXSgC..zFHl-BrDnpmevfoDmWcr04CNai3vqwCPB6AYeJXJ744C * tools/skia_goldctl/win: 4r6X5OSxy-ZDOlqtn41HMmKG2qlEfMNdLwpzyufLFzcC..AefJEwE3M-ke_pwYEVGy2Ct2Ra80EaxvK1KADBuG8-EC No update to Clang. Bug: angleproject:5499 Tbr: timvp@google.com Change-Id: I9f77435fd9cb48cfc3ceec6e2ce98b3d1082da02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2627011 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 2ed9671a 2021-01-12T09:44:03 State: Provide reference to image unit binding vector This allows iterating through the entries without creating a copy of the vector. This was causing an assertion in FrameCapture when deconstructing the copy, which we don't need. RefCountObject.h (~BindingPointer): ! Assert failed in ~BindingPointer (src/libANGLE/RefCountObject.h:93): mObject == nullptr It also probably matches the intent of the function. Test: Aztec Ruins MEC Bug: angleproject:4048 Change-Id: I9588af3859b4d3edb5859530def1bb3992530403 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622610 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 2e9161e4 2021-01-12T11:29:29 Vulkan: Add YUV G8_B8_R8_3PLANE_420_UNORM format. Bug: angleproject:5438 Change-Id: I525a51256a5ee83fa69c8705aa90790fb32a6602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2623813 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop d38b9f86 2020-12-02T09:20:09 Allow GL_OES_shader_image_atomic when non-conformant On Android, force allowing it with: adb shell setprop debug.angle.feature_overrides_enabled \ exposeNonConformantExtensionsAndVersions If enabling multiple features, switch to using settings which don't have a character limit, but persist across reboots: adb shell settings put global angle_egl_features \ exposeNonConformantExtensionsAndVersions:foo:bar Test: Fortnite on ANGLE Bug: b/170755560 Bug: angleproject:5503 Change-Id: I58e3b265daa8ea1f645f47e0971c4454b8ddb3f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2570775 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill fb4eea2e 2021-01-11T16:58:02 Vulkan: Index mandatory support table by ANGLE format. This removes another instance of indexing a flat array by VkFormat. With the introduction of YUV formats we no longer have a compact table. Switching to ANGLE format indexing allows us to keep a flat array and avoid using an unordered map. Bug: angleproject:5438 Change-Id: I96caa19e3b7ce419ce09680399919447f002b0bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622238 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 8db7915e 2021-01-12T10:56:47 Vulkan: Increment buffer view serials only when used This avoids the texel buffer view serials (shared with image view serials) recklessly getting large. Bug: angleproject:5185 Change-Id: I0debe73771094b395f6526475aa3c22a91f9e05e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2623811 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi a4b582e8 2021-01-11T15:31:13 Vulkan: Notify ContextVk when UtilsVk binds compute pipelines This issue was fixed for graphics pipelines (in UtilsVk::clearFramebuffer), but remained for compute pipelines. If UtilsVk issues a dispatch call, it now notifies ContextVk to rebind the pipeline and descriptor sets. Bug: angleproject:5529 Change-Id: Ic52f91bdc70d02c065ec2d5e2a3614c11fd62a9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622236 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll c0ef8ccf 2021-01-12T10:01:07 Roll SwiftShader from 348ba200aa29 to 3549479dc4cc (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/348ba200aa29..3549479dc4cc 2021-01-11 srisser@google.com Define static constexpr members in .cpp files 2021-01-11 srisser@google.com Add VK_EXT_host_query_reset 2021-01-11 srisser@google.com Implement VK_EXT_separate_stencil_usage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ib8b03c92865f73ab8e6464846f988bf09509d6e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2624059 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jonah Ryan-Davis 6e9018bd 2020-06-25T12:58:14 GL: Clean up Display code related to multithreading Rename mCurrentData to mCurrentNativeContexts, and clean up some logic to be easier to read. Bug: angleproject:4724 Change-Id: I6fd6d99d4f9a3af808d0baa665edfbdde7fb0500 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2267424 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi 5b8dec52 2021-01-12T04:11:56 Reland "Use is_apple instead of is_mac and is_ios everywhere" This reverts commit 51603c63d1cb9e36afaf2069fc069e542ac2f3fb. Reason for revert: Fixed issue that broke Skia build Original change's description: > Revert "Use is_apple instead of is_mac and is_ios everywhere" > > This reverts commit 2762641a3a1edf9665a61f40da6c160338056cb0. > > Reason for revert: is_apple is not universally defined. Breaks ANGLE roll into Skia. > > Original change's description: > > Use is_apple instead of is_mac and is_ios everywhere > > > > Bug: chromium:1161513 > > Change-Id: Id7d582f127f4b79ea6fc5b8ad39fff768c45f477 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611312 > > Reviewed-by: James Darpinian <jdarpinian@chromium.org> > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > > TBR=jdarpinian@chromium.org,syoussefi@chromium.org > > Bug: chromium:1161513 > Change-Id: I831e60149f410044a79d9f66aa9ddd9902410fd7 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618039 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> TBR=jdarpinian@chromium.org,syoussefi@chromium.org Bug: chromium:1161513 Change-Id: I3cf30aa047a1f208fa7d1acda1d6d4e5da7b6ad5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622244 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7f0e7d0d 2021-01-12T07:01:16 Roll Chromium from 734de1a6b288 to 2a7e78c75a37 (67 revisions) https://chromium.googlesource.com/chromium/src.git/+log/734de1a6b288..2a7e78c75a37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d599553721..3769c3b43c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d1a3011cd9 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2246bee280..82425b6b98 * tools/skia_goldctl/win: mvme2We4n3wONUhzQu6ATl9Ow4Fb4li6ET-Yhv7Ph3EC..4r6X5OSxy-ZDOlqtn41HMmKG2qlEfMNdLwpzyufLFzcC No update to Clang. Bug: angleproject:5417 Tbr: timvp@google.com Change-Id: I12c9cd047a4f455a8a68fc2dd933f00550bb9f7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622717 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bdbcbe94 2021-01-12T02:39:41 Roll Chromium from 193bb22c8c9d to 734de1a6b288 (311 revisions) https://chromium.googlesource.com/chromium/src.git/+log/193bb22c8c9d..734de1a6b288 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8874a0a063..d599553721 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2277272f7a..235cfe435c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b6a5362054..6e80dc5c14 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b2230ba88f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/01d7e1f0a1..2246bee280 No update to Clang. Bug: angleproject:5417,angleproject:5513 Tbr: timvp@google.com,ynovikov@google.com Change-Id: I20c585cd43b48d2d2a4ada9629511a32b713c986 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622713 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jason Macnak 2c65da28 2021-01-08T11:49:18 Default roll_aosp.sh to copy artifacts to vendor partition ... to support using ANGLE as a native GL driver. Note: this will not affect devices installing the APK with `PRODUCT_PACKAGES += ANGLE` and will *not* also install the libs to vendor. Bug: b/147316305 Bug: angleproject:5456 Test: ./scripts/roll_aosp.sh and build in AOSP Change-Id: I98cab8d0735a4f66293ac063e0eef2ae7ddbee7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618529 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill 2e9706d8 2021-01-08T17:29:42 Vulkan: Use angle::FormatID instead of VkFormat. This change switches the internal enums we pass around from VkFormat to FormatID. The end goal of the refactor is to allow the Vulkan back-end to store packed tables indexed by FormatID. Because VkFormat has large gaps in its enum space we'd otherwise need to use unordered data structures like unordered_map. The change removes the redundant VkFormat storage from vk::Format and uses a new table query to return the VkFormat that 1:1 matches an angle::FormatID. We also include a reverse mapping for use with native Vulkan get functions for Android. Also moves sRGB conversion functions into renderer_utils. A couple sRGB formats that don't exist in GL are no longer handled by the sRGB conversion functions. These formats should be extremely rare. Bug: angleproject:5438 Change-Id: Id8b49773ca0c556f9f5a6a10fcf0d9762b93bbea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618204 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
Stephan Hartmann d21d682d 2021-01-11T12:59:53 libstdc++: fix incomplete type for FramebufferCache libstdc++ does not allow incomplete type for T2 with std::pair<T1,T2> and fails with: .../../src/libANGLE/renderer/vulkan/vk_cache_utils.h:1570:64: required from here /usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/include/g++-v9/bits/stl_pair.h:215:11: error: std::pair<_T1, _T2>::second has incomplete type 215 | _T2 second; /// @c second is a copy of the second object | ^~~~~~ https://chromium-review.googlesource.com/c/angle/angle/+/2580111 added class FramebufferCache with incomplete type in |mPayload| to vk::FramebufferHelper. Changing include order is not an option. However, FramebufferCache is only used in FramebufferVk and we can make it local there. Bug: chromium:957519 Change-Id: I5fbdca23adbb9f4aecc266988c02fb0d051504cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2621473 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Trevor David Black de32c3d2 2020-11-04T13:16:31 Reland "Created test and fixed texture storage bug in d3d11" This is a reland of 03f3ba5b1454ee7c15cd9391e77307cf1d274b48 Original change's description: > Created test and fixed texture storage bug in d3d11 > > Bug: b/172489285 > Change-Id: If7d88cf50d99da3380082c60fb3936ae0b20c4e5 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519876 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: b/172489285 Change-Id: I6b8226164a09aed208c56cb78b5d2c1385298cbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2546034 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Trevor David Black <vantablack@google.com> Commit-Queue: Trevor David Black <vantablack@google.com>
Lingfeng Yang 326f128b 2021-01-07T14:25:44 Vulkan: Prefer host cached memory for Buffers This improves perf because vertex data upload uses host visible memory, and uncached memory can be slow. Test: Android on Windows with 1080Ti: glmark2 [build] vbo=false 265 -> 3900 fps Bug: angleproject:5515 Change-Id: Ib75582bbdb4ca4a22d3a121c7b477a23a8a809ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615742 Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Yuly Novikov 9325fd8b 2021-01-11T13:31:42 Fix iOS build Broken by crrev.com/c/2618040 Bug: angleproject:5417 Change-Id: Id4a81c3e933b679956c82356c14b5639d56b6859 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622234 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 4dd9a5e1 2021-01-11T14:22:44 Enable building angle_white_box_tests on Fuchsia Builds fine. Bug: angleproject:2475 Change-Id: I96b2b03e1be2b801c3d8579ebf44d51b6faa3e57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622235 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Ian Elliott 16dbcc13 2021-01-08T20:50:16 dEQP: Avoid undefined right-shift behavior for GLhalf The FloatToHalf() function in "es31cVertexAttribBindingTests.cpp" will attempt to right-shift more than the number of bits in an integer (i.e. by 70) when converting 0.0f to GLhalf. Bug: angleproject:5500 Change-Id: I587e71a2cb1377b95ed74a1bba5f4ceef6a4a516 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618665 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill cb71062a 2021-01-11T11:31:45 Remove obsolete build flag. No longer necessarry: "linux_use_bundled_binutils_override" Bug: chromium:1164276 Change-Id: Ia670731cba70e4dbb9505480f7bb06060475c3e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2622233 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 49d29106 2021-01-11T14:52:34 Roll Chromium from 29d2d6a2d436 to 193bb22c8c9d (106 revisions) https://chromium.googlesource.com/chromium/src.git/+log/29d2d6a2d436..193bb22c8c9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com,borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d1a74631f6..8874a0a063 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..12607ec3c9 No update to Clang. Bug: None Tbr: timvp@google.com,borenet@google.com Change-Id: I6c7a3edf824f7bad503b627bb8198748e81692a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2621713 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c600e478 2021-01-11T10:01:24 Roll vulkan-deps from e395b66ed41c to e59ae1af7571 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e395b66ed41c..e59ae1af7571 2021-01-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f0634ebbb36f to 46237b593c3f (2 revisions) 2021-01-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 702c903f982d to 820179bf4689 (1 revision) 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 04cf3fd95555 to f0634ebbb36f (1 revision) 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from ebd3ea2ecbac to 04cf3fd95555 (2 revisions) 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from ce18d1b8a563 to 702c903f982d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I462ebd004acd91d86ee30c5c78db8b2ca8729e9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2620873 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ffe66b75 2021-01-11T10:01:25 Roll SwiftShader from 937395c1ed5d to 348ba200aa29 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/937395c1ed5d..348ba200aa29 2021-01-10 capn@google.com Eliminate SpirvShaderEnumNames.cpp 2021-01-08 capn@google.com Reduce the LLVM compile layer object lifetime 2021-01-08 capn@google.com Reduce the mangler object lifetime 2021-01-08 capn@google.com Eliminate duplicate LLVM contexts 2021-01-08 srisser@google.com Fix mismatched signedness for a compare in subzero 2021-01-08 capn@google.com Fix missing fields initializers warnings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I4c63d31e3b324dbf1400c7ca4fe58e8067839b15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2620479 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ac05066a 2021-01-11T07:02:16 Roll Chromium from 28ecef438c2c to 29d2d6a2d436 (82 revisions) https://chromium.googlesource.com/chromium/src.git/+log/28ecef438c2c..29d2d6a2d436 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/06eb186470..d1a74631f6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fdaafe276e..b6a5362054 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e174329bab No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Ic0ae8442611bc2c32241cf0f8496f118e6e32dca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2620868 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 0b90eef0 2021-01-09T16:29:03 Roll chromium_revision 1e679b773d..28ecef438c (841389:841845) Change log: https://chromium.googlesource.com/chromium/src/+log/1e679b773d..28ecef438c Full diff: https://chromium.googlesource.com/chromium/src/+/1e679b773d..28ecef438c Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/762c7888b9..06eb186470 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ce1689b82d..fdaafe276e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e174329bab * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c000d6e459..28924eafb2 DEPS diff: https://chromium.googlesource.com/chromium/src/+/1e679b773d..28ecef438c/DEPS No update to Clang. TBR=ynovikov@chromium.org, BUG=angleproject:5417 Change-Id: I247873fe591c915cf1280739eeff98292984a6bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2619938 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 51603c63 2021-01-08T17:49:52 Revert "Use is_apple instead of is_mac and is_ios everywhere" This reverts commit 2762641a3a1edf9665a61f40da6c160338056cb0. Reason for revert: is_apple is not universally defined. Breaks ANGLE roll into Skia. Original change's description: > Use is_apple instead of is_mac and is_ios everywhere > > Bug: chromium:1161513 > Change-Id: Id7d582f127f4b79ea6fc5b8ad39fff768c45f477 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611312 > Reviewed-by: James Darpinian <jdarpinian@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> TBR=jdarpinian@chromium.org,syoussefi@chromium.org Bug: chromium:1161513 Change-Id: I831e60149f410044a79d9f66aa9ddd9902410fd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618039 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten 6e909d94 2020-12-30T19:40:21 Tests: Add Saint Seiya Awakening: Knights of the Zodiac trace Test: angle_perftests --gtest_filter=TracePerfTest.Run/*saint_seiya_awakening* Bug: angleproject:4048 Change-Id: Idf187b9c9298d184f1e0dd13f8a9aa0de7c2beb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2612523 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 7cdda2dc 2021-01-07T16:46:54 Vulkan: Add a perf test for pre-rotation code injection A test is added that dispatches a large number of vertex shaders, generating primitives that are all culled. The vertex shaders are simple so that code injected for pre-rotation would make up the majority of the shader code. Bug: angleproject:5478 Change-Id: I75092cb25e6427449251985f56e54f89813dec32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615821 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 2aa4f7e5 2021-01-08T16:35:29 Fix translator fuzzer Since some ASTs are now disabled on certain conditions, this change lets the fuzzer know when it has generated invalid translator options. Bug: chromium:1164448 Change-Id: I1f1b120c33fb70f9776df858db033ec914d7ad89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618203 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten 767af74e 2021-01-06T17:30:21 Tests: Add World War Doh trace Test: angle_perftests --gtest_filter=TracePerfTest.Run/*world_war_doh* Bug: angleproject:4048 Change-Id: I047ed1ccd06cd3707065fe8afed3ad7af5cd7dcc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606645 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 43366979 2021-01-08T15:39:02 Add OWNERS info for Vulkan test utils. Bug: chromium:1164084 Change-Id: I83cb75f2a0b4ad3f616d1b64beb34310cc23dd12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618202 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Stephen White f4cd1747 2020-12-21T09:57:58 Reland "Changes to build inside a Dawn checkout." This is a reland of 11c31e0a4a73d7d62e765dc7ec400560fbb16b5e I've landed upstream Skia change https://skia-review.googlesource.com/c/skia/+/351496 which should make this safe to reland. Original change's description: > Changes to build inside a Dawn checkout. > > Add an "angle_standalone" flag that can be disabled by Dawn. > Put test definitions behind angle_standalone || build_with_chromium. > > Bug: angleproject:5462 > Change-Id: I58c9b18723384334156e2a3dd86ed3f89afcaade > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2587451 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> Bug: angleproject:5462 Change-Id: I4ff92d45b3692312a004f03b425234b78c5a6219 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618040 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 038ae144 2020-12-31T21:23:30 Vulkan: Fix up varying component limits. We weren't subtracting reserved varying vectors from component limits. We also were using an incorrect value for fragment input components. Bug: angleproject:5496 Change-Id: I44fc3b2f15687f4dee7a1498d50378e69d74afe3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606536 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill e4497d60 2020-12-31T20:12:13 Program: Move more common code to ProgramLinkedResources. Refactoring change only. Bug: angleproject:5496 Change-Id: Ic1c8301a070e91ad28791c23831b8236058ab9ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606535 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 68f35f24 2021-01-07T14:42:57 Vulkan: Add GL_EXT_clip_control entry points Addition of the entry points for GL_EXT_clip_control extension. Bug: angleproject:5471 Change-Id: If17ba0120bdb226cc5728bfea83e9085260eba19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615862 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Jamie Madill fa449cf3 2021-01-06T10:02:12 Fix separable Geometry Shaders. Was a needed fix for a new varying test. Bug: angleproject:3571 Bug: angleproject:5496 Change-Id: I49ae69967510b7a6330ea217a0e0e19e3bebe865 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613198 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 3e33db95 2020-12-30T17:17:17 Merge Program/ProgramPipeline::getMergedVaryings(). This merges two very similar pieces of code into one simpler function. The function doesn't use any maps or indirection to build the merged varyings list. It also fixes a potential bug with IO blocks and name matching due to the code bifurcation. Bug: angleproject:5496 Change-Id: Ibf54faeeb01d1940570b366ed153fff7c9135c52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606533 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll d8ca7d62 2021-01-08T10:01:56 Roll SwiftShader from 7b2f93895418 to 937395c1ed5d (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/7b2f93895418..937395c1ed5d 2021-01-07 caramelli.devel@gmail.com Add Direct-to-Display support using KMS/DRM 2021-01-07 srisser@google.com Add structs for VK_KHR_vulkan_memory_model If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Iaa11e1b25da9d180081b5b4b0b31c5f655aeb263 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617316 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7373f631 2021-01-08T10:00:59 Roll vulkan-deps from c493c6112021 to e395b66ed41c (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c493c6112021..e395b66ed41c 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 0e5078dc0cfb to ce18d1b8a563 (1 revision) 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 134a52003407 to 0e5078dc0cfb (1 revision) 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 234c65c0f32c to 134a52003407 (1 revision) 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from ad77ed7a8d52 to f3ccb633dfd7 (1 revision) 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 9f10caf9c4f3 to ebd3ea2ecbac (2 revisions) 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from cc435b55410a to 9f10caf9c4f3 (2 revisions) 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from aa005e8bd435 to ad77ed7a8d52 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ic5ca5fd78243ad6d37e1b8e046e92ee74f88490b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2616969 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b7d9a02c 2021-01-08T07:01:14 Roll Chromium from 730c6584bcc6 to 1e679b773de8 (438 revisions) https://chromium.googlesource.com/chromium/src.git/+log/730c6584bcc6..1e679b773de8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e4c5e3e1a0..762c7888b9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d17dcf3607..ce1689b82d * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/78f99e18e9..cadb7225e4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e174329bab * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e8d041d679..01d7e1f0a1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f8570240b7..c000d6e459 * tools/skia_goldctl/linux: C_u9-R-I-yQyomb3Y-XIH8Ad3Ya4ZWi2MpPiFTtfHz4C..SydJmfq0VW7jq5fTDGtIQ-7WoB0vNc-LJAi3Xd4fKvQC * tools/skia_goldctl/mac: H_4GgcW8CtnxDnWd7RX17C39CAYzfHUaFR6drL3wWAcC..oxKWG6EzN6FHwQ-4J6gUYMHuNuHyARpVl4EvirOsXSgC * tools/skia_goldctl/win: FzQDQOcAASIc0LaD9YBjqH2JPm0HbYCE2x0WXw2xpz0C..mvme2We4n3wONUhzQu6ATl9Ow4Fb4li6ET-Yhv7Ph3EC No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Icd5f9ab05c0784d31b353554e003290cda9fada0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617241 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi f99ccb08 2021-01-06T23:29:21 Vulkan: Add a perf warning when dropping superseded updates If an update to an image subresource is entirely superseded by a following update, the former update is dropped. This change adds a perf warning for this. Bug: angleproject:3461 Change-Id: Iaf4984ba52f3dfc86d5cc87f8be82123badebd04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613203 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jonah Ryan-Davis a392a81d 2021-01-06T12:26:44 GLX: Avoid creating child window when X visual ID is specified. ANGLE's GLX backend creates a child ID because the visual of the X window must match that of the GLX window, and we can't always be certain. EGL_ANGLE_x11_visual allows applications to specify the visual ID of the window passed to ANGLE via EGL_X11_VISUAL_ID_ANGLE. When this is the case, we don't need to make a child window. Since Chrome always passes this information, this may help optimize ANGLE's GLX usage in Chrome, because we don't have to poll the parent window to manage the child window's properties. Bug: chromium:1132827 Change-Id: If8082d2d07469905afffab01dde2ec9fca8d4eb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611556 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tim Van Patten 2d1406a8 2020-12-29T18:11:33 Capture/Replay: Capture glBindBufferBase during MEC setup "World War Doh" binds uniform buffers via glBindBufferBase() calls before any frames have rendered and then uses those bound buffers for all subsequent frames. ANGLE's frame capture was failing to perform these calls during the mid-execution capture setup phase, leading to the replay generating VVL errors: VUID-vkCmdDispatch-None-02699 Descriptor in binding #0 index 0 is being used in draw but has never been updated via vkUpdateDescriptorSets() or a similar call. This CL adds those calls to the MEC setup phase, allowing the replay to execute without any errors. Bug: angleproject:5495 Test: angle_perftests --gtest_filter="*world_war_doh*" Change-Id: I751c9c6f60bf78c13428a9d1d6a06dbfe600c24b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606806 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi a7158eb5 2021-01-06T21:33:24 Vulkan: Fix image leak in staged updates in ImageHelper When removing superseding updates, the superseded update was not released, causing a memory leak. This change also makes SubresourceUpdate non-copyable and correctly implements the move assignment operator such that swap between different update types are correct. As a result, the destructor can now ASSERT that the image is not leaked. Bug: chromium:1146516 Bug: chromium:1163354 Change-Id: I7531c91d8559c23b2e09159118fe645d12fc601f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613201 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 157ddfdc 2021-01-06T23:20:36 Build compiler_tests only if GLSL or ESSL build is enabled Most of these tests use TranslatorGLSL or TranslatorESSL (often through ShaderCompileTreeTest). In specialized builds that disable GLSL and ESSL shader generation, disable these unit tests. Bug: chromium:1161513 Change-Id: Ib87e651706f141a41ffdaebfb0cbe5168582e341 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613202 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang acdb63b8 2020-12-23T12:57:08 Remove the checking before accessing to function pointers Bug: angleproject:5490 Bug: chromium:1161513 Change-Id: I96c5c463a9fd5a337d09f6cefe7836ff52bea90f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601071 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
angle-autoroll d0a38010 2021-01-07T10:01:59 Roll vulkan-deps from cbab637962d0 to c493c6112021 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/cbab637962d0..c493c6112021 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 7b7a21c4058c to 234c65c0f32c (3 revisions) 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 480f6039e072 to 3de5cfe50ede (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 4cc0932495ec to a7825740f316 (3 revisions) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 4ed1f4fce9e7 to aa005e8bd435 (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from af3a3d481f6e to 4ed1f4fce9e7 (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 94d1a80159e3 to af3a3d481f6e (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 98382948dfea to cc435b55410a (2 revisions) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f77085c307fc to 480f6039e072 (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 6d05ed8410b4 to 94d1a80159e3 (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 37c03859de9e to 6d05ed8410b4 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ibff53e4a69b1a9291679f352a5fe6e7e8b70de50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613796 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll aa5457dd 2021-01-07T10:01:55 Roll SwiftShader from b9e179f1f239 to 7b2f93895418 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/b9e179f1f239..7b2f93895418 2021-01-07 capn@google.com Fix implicit inexact conversion If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I77ee81cc4f9a8828ef46bf77113fcd6da008dd39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613890 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 35b6156b 2021-01-07T07:01:42 Roll Chromium from 38610c881952 to 730c6584bcc6 (444 revisions) https://chromium.googlesource.com/chromium/src.git/+log/38610c881952..730c6584bcc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/65cd1b9efa..e4c5e3e1a0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3c84fe5c3f..d17dcf3607 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ae206b8b8d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/77a111142a..f8570240b7 * tools/skia_goldctl/linux: CQ5a33Wu9Sm6bRTrd26RFsJVr42IoKD4Ediyp7eyuwwC..C_u9-R-I-yQyomb3Y-XIH8Ad3Ya4ZWi2MpPiFTtfHz4C * tools/skia_goldctl/mac: AXBg8ZzAzlIdv0U_KR8dr92w1szmAp-MB0Z9ZYBmFy4C..H_4GgcW8CtnxDnWd7RX17C39CAYzfHUaFR6drL3wWAcC * tools/skia_goldctl/win: slJNuZyzBI9lNI9Uje1a2fiVtubv8LEBgUZLFdHZjssC..FzQDQOcAASIc0LaD9YBjqH2JPm0HbYCE2x0WXw2xpz0C No update to Clang. Bug: angleproject:2926,angleproject:2939,angleproject:3481,angleproject:3741,angleproject:4286,angleproject:4539,angleproject:4569,angleproject:4846 Tbr: ianelliott@google.com Change-Id: Id567e30b16d04e96c869ad3058b03829a9035458 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2614267 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi e2a8a69a 2021-01-04T23:52:02 Vulkan: Move xfb emulation offset calculation to translator A new function is added by the translator to calculate the transform feedback offsets in the emulation path. This function makes the generated code for transform feedback smaller. Bug: angleproject:3606 Change-Id: I01460f907e20e2887cb720bddad96697fdcb0cf3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2607492 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 07d619cb 2021-01-06T11:36:40 Vulkan: Fix missing xfb buffer rebind on new command buffer When a command buffer is ended, bindings are lost. This adds a dirty bit to `mNewGraphicsCommandBufferDirtyBits` to make sure transform feedback buffers are bound again on the new command buffer. Bug: angleproject:5428 Change-Id: I7733c93b1eb5d33a77cbee231a83199be950e19f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611552 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 5e280545 2021-01-06T14:13:29 Move RegenerateStructNames AST transformation to gl/ This AST transformation is used by the chromium validating command decoder on Linux/AMD/GL as well as MacOS. Bug: chromium:1161513 Change-Id: I67e40215ae5576819ba5a58987ceb1776c86c731 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613195 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi ca94d1da 2021-01-04T21:51:33 Vulkan: Refactor generated code in xfb emulation path The index expression was regenerated for every component written to the output. This change refactors the generated code such that common values are calculated once. This is in preparation for moving some of this code to the translator and reducing the amount of code generated at link time. Bug: angleproject:3606 Change-Id: Ib180d245218f8f6f18c57c0ea092e8c45cbffd1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2607490 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Yuly Novikov 46d3f02a 2021-01-05T17:56:24 Suppress dEQP.KHR_GLES31/core_vertex_attrib_binding_basicinputcase5 on Vulkan Pixel2 and SwiftShader. Ignore device and vendor in test config if we are running on SwiftShader. Bug: angleproject:5500 Change-Id: Ib07240dfe1c2ae1d6d081ffa389d041d97b22b36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611309 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
James Darpinian ebf00703 2020-12-29T16:25:54 angle_end2end_tests passes on iOS! Miscellaneous test skips and fixes for iOS. Bug: angleproject:5417 Bug: angleproject:5491 Change-Id: Id0785e6243949fc756e4d7923dbbe77a411052f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606656 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Shahbaz Youssefi 2762641a 2021-01-05T23:00:14 Use is_apple instead of is_mac and is_ios everywhere Bug: chromium:1161513 Change-Id: Id7d582f127f4b79ea6fc5b8ad39fff768c45f477 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611312 Reviewed-by: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 1d6329b3 2021-01-06T14:33:26 Update auto-roller docs with vulkan-deps repo. Bug: angleproject:5390 Change-Id: If5edba51b0fdbaee36e0ab31a176f809b1ace38a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613196 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 56479b06 2020-12-21T13:03:50 Tests: Add FIFA Mobile trace Test: angle_perftests --gtest_filter=TracePerfTest.Run/*fifa_mobile* Bug: angleproject:4048 Change-Id: I5cc731ada3ddd9adcb247d7c6f8cf5d823bdc2a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600098 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Jonah Ryan-Davis 956a358d 2020-12-23T15:43:00 GL: Add function pointers for EXT/NV_framebuffer_blit Allow the GL backend to call BlitFramebuffer through these extensions. Bug: angleproject:5474 Change-Id: Ic19b0535056c3e2b098dedc60e2eb8da5f862433 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2602702 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill dc2cf6fc 2021-01-06T11:35:53 Roll third_party/vulkan-deps/ b08eace32..cbab63796 (17 commits; 1 trivial rolls) https://chromium.googlesource.com/vulkan-deps/+log/b08eace32e9c..cbab637962d0 $ git log b08eace32..cbab63796 --date=short --no-merges --format='%ad %ae %s' 2021-01-06 chromium-autoroll Roll SPIRV-Tools from d630e5f8c10c to 37c03859de9e (1 revision) 2021-01-06 chromium-autoroll Roll Vulkan-ValidationLayers from 2468aa9630c2 to 98382948dfea (1 revision) 2021-01-06 chromium-autoroll Roll SPIRV-Tools from 1bb80d2778a3 to d630e5f8c10c (1 revision) 2021-01-06 chromium-autoroll Roll glslang from 9325cc013e3d to f77085c307fc (1 revision) 2021-01-05 chromium-autoroll Roll Vulkan-ValidationLayers from 57255a663ed9 to 2468aa9630c2 (1 revision) 2021-01-05 chromium-autoroll Roll Vulkan-Loader from 1f0c7868a438 to 9ba835885ffe (1 revision) 2021-01-05 chromium-autoroll Roll Vulkan-ValidationLayers from 56a96658b750 to 57255a663ed9 (3 revisions) 2021-01-05 chromium-autoroll Roll Vulkan-Loader from 294480cb7f3e to 1f0c7868a438 (1 revision) 2021-01-05 chromium-autoroll Roll Vulkan-Tools from 7554321b88ae to 4cc0932495ec (2 revisions) 2021-01-05 chromium-autoroll Roll Vulkan-Loader from 66a23ac8c566 to 294480cb7f3e (1 revision) 2021-01-05 chromium-autoroll Roll Vulkan-Headers from 85470b32ad5d to 9efc4a631161 (1 revision) 2021-01-05 chromium-autoroll Roll Vulkan-ValidationLayers from aa076dae88e2 to 56a96658b750 (25 revisions) 2021-01-05 chromium-autoroll Roll glslang from f426f652299d to 9325cc013e3d (1 revision) 2021-01-05 chromium-autoroll Roll SPIRV-Cross from e50f7d1ce8e1 to 7b7a21c4058c (3 revisions) 2021-01-05 chromium-autoroll Roll SPIRV-Tools from 17ffa89097b2 to 1bb80d2778a3 (1 revision) 2020-12-21 jmadill Rolling 8 dependencies Created with: roll-dep third_party/vulkan-deps Bug: angleproject:5390 Change-Id: I6f4a499099211e8990ed038984f41bc5f881c71f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601340 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill d9669322 2020-12-30T14:33:02 Remove "init" from VaryingPacking. Instead we can pass the pack mode and size to the collectAndPack method. This cleans up the interface and also allows us to merge two separate code blocks in Program and ProgramPipeline. Bug: angleproject:5496 Change-Id: I390b5d2e8a3b033374ccc5a250597be1f03dec96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606531 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill d33ffb22 2020-12-30T11:14:00 Organize VaryingPacking methods. This clarifies the difference between "collect" and "pack" methods. Previously the naming was overlapping between the two. Also makes the "packUserVaryings" method private. Refactoring change only. Will enable further improvements for capturing varyings with multiple shader stages. Bug: angleproject:5496 Change-Id: I854590ceab39f3a0e7a785516e0d1fd44e4ccc98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606529 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 92e7bc89 2020-12-23T15:18:42 Remove ProgramLinkedResources from ProgramExecutable. Instead of storing the entire LinkedResources struct, we can keep it only for the duration of the linking calls. Refactoring change only. It sets the stage for more refactoring. This change also switches the link call to use LinkingState's ProgramLinkedResources directly to avoid the need to copy the varying packing or use a pointer. Bug: angleproject:4514 Bug: angleproject:5496 Change-Id: Iefea3c16a33213dc338cc54efaa7c3064ea6ae08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601403 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tim Van Patten e09e947d 2020-12-29T18:21:36 Capture/Replay: Don't force built-in attribs to have a location CaptureMidExecutionSetup() hits an assert while capturing "World War Doh": ANGLE : FATAL: FrameCapture.cpp:2876 (CaptureMidExecutionSetup): ! Assert failed [[[...]]] attrib.location != -1 This is due to CaptureMidExecutionSetup() enforcing that all attributes, including built-ins, have a location. However, in the case of "World War Doh", the built-in 'gl_GlobalInvocationID' does not have a location. Moving the assert to after the gl::IsBuiltInName() check allows the capture to complete without hitting any asserts. Bug: angleproject:4048 Test: Capture "World War Doh" Change-Id: Ice96dec629b1477b11a710283c4ec4bf1c95c6e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606807 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi bf6cc88a 2021-01-05T22:17:41 Vulkan: Remove duplicate shaderType parameter to SPIR-V transformer The passed-in GlslangSpirvOptions already has the shaderType, so this extra parameter was not necessary. Bug: angleproject:4524 Change-Id: Ibbc7442b3173b26825f3cb9e2365789fade92cfc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611311 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll a8b962b7 2021-01-06T07:01:32 Roll Chromium from 481852c5d89b to 38610c881952 (120 revisions) https://chromium.googlesource.com/chromium/src.git/+log/481852c5d89b..38610c881952 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/505140eae0..65cd1b9efa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c83cdcc501..3c84fe5c3f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6c876045de * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1c129d6fca..77a111142a No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Ia2de17b882601cc3c149466df58c8537df335e38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2612765 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8ef86071 2021-01-06T10:01:55 Roll SwiftShader from ff29e249d317 to b9e179f1f239 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ff29e249d317..b9e179f1f239 2021-01-05 capn@google.com Clarify 3-level caching of sampling routines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I480ec54ea1275dd8f0285dd05aa432dfe30e2219 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2612812 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0