kc3-lang/angle

Log

Author Commit Date CI Message
Shahbaz Youssefi d9943e44 2024-04-09T23:53:48 Remove Program::syncState The last bit of responsibility still left in Program::syncState was to wait for post-link tasks for the sake of EGLBlobCacheTest tests. A new extension, GL_ANGLE_program_binary_readiness_query is created so that the wait can be done in the test itself. This extension is ultimately useful for applications as well, so they can avoid blocking the CPU by calling glGetProgramBinary prematurely. Bug: angleproject:8297 Change-Id: Ied6b755cb9b060198f82c7948bfd03441435a578 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5440302 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Mohan Maiya c1397510 2024-04-07T21:05:34 Vulkan: Fix data race in WarmUpGraphicsTask std::unordered_map doesn't support simultaneous read and write. Cache placeholder PipelineHelper in WarmUpGraphicsTask and std::move the newly created PipelineHelper when warm up is complete. Bug: angleproject:8297 Change-Id: I1cc4b3cd48147d0080666d5669d61de006c2252d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5431830 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 392eca60 2024-04-10T15:36:07 Revert "GL: Support KHR_blend_equation_advanced" This reverts commit c632fae01ced6712d31c4665288eb306a980fb10. Reason for revert: Crashes on a few different devices. Bug: chromium:40277080, chromium:333443447 Original change's description: > GL: Support KHR_blend_equation_advanced > > Combine blend equation setting when they are equal. It is invalid to > set advanced blend equations for color/alpha separately. > > Emit blend equation layout qualifiers. > > Bug: angleproject:8660 > Change-Id: I1d8a88594c80027b564eed70d3b540e0b065968d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5415033 > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Bug: angleproject:8660 Change-Id: I27ac64c7343831e42f5412d6c17facd0de8cd9e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5443404 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 4af8dafb 2024-03-10T20:14:18 Vulkan: Enable MSRTT emulation tests on swiftshader Bug: b/309355117 Change-Id: I2d842bc52f9b6af340025654111dfd3f8e9c58a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5359654 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll bedc75d9 2024-04-10T07:00:37 Roll Chromium from 8853d900c3dd to 3e1171173a70 (343 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8853d900c3dd..3e1171173a70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/8919328651..aaab0bb753 * buildtools/linux64: git_revision:f07499aebcf5b1b8f09f27f705e1b6e463ecdba1..git_revision:d823fd85da3fb83146f734377da454473b93a2b2 * buildtools/mac: git_revision:f07499aebcf5b1b8f09f27f705e1b6e463ecdba1..git_revision:d823fd85da3fb83146f734377da454473b93a2b2 * buildtools/reclient: re_client_version:0.134.1.2c9285b-gomaip..re_client_version:0.138.0.e854224-gomaip * buildtools/win: git_revision:f07499aebcf5b1b8f09f27f705e1b6e463ecdba1..git_revision:d823fd85da3fb83146f734377da454473b93a2b2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/46e070f755..eb52dfd13f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0b9e7b8830..6e7b54bc42 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f85dd800c7..eea30870b8 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/d076d8bd08..7d77fb7fd6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/743467d32a..3b4680b3b6 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I89ed90d790c98a690e2ba0c7d908c77d28172392 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5442672 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya d1bffdb6 2024-04-09T08:22:18 Vulkan: Bugfix in WarmUpComputeTask 1. An early return caused compute warm up tasks to not be scheduled 2. There are usecases where a program is marked separable post-link. Perform waitForPostLinkTasksImpl unconditionally during save(...) Bug: angleproject:8297 Tests: ProgramBinaryES31Test.SeparableProgramLinkedUniforms* Change-Id: I499f397b938677b4fcdb486001e0a75e202aaf5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5439732 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 22644819 2024-04-09T18:23:31 Manual roll Chromium from a20bd3962f16 to 8853d900c3dd (278 revisions) Manual roll requested by bsheedy@google.com https://chromium.googlesource.com/chromium/src.git/+log/a20bd3962f16..8853d900c3dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,bsheedy@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools/linux64: git_revision:415b3b19e094cd4b6982147693485df65037f942..git_revision:f07499aebcf5b1b8f09f27f705e1b6e463ecdba1 * buildtools/mac: git_revision:415b3b19e094cd4b6982147693485df65037f942..git_revision:f07499aebcf5b1b8f09f27f705e1b6e463ecdba1 * buildtools/win: git_revision:415b3b19e094cd4b6982147693485df65037f942..git_revision:f07499aebcf5b1b8f09f27f705e1b6e463ecdba1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5ec3f53855..46e070f755 * third_party/android_build_tools/manifest_merger: wtRWPCJVk_NA2GQp0fI-1i-JaPzYJwp6w3udjEhgni4C..UiE3IQmTjQyDp6olH-K75Gup3wY_WezHKM9riMylXVcC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d248c3571b..ffb5ee628c * third_party/kotlin_stdlib: 8ap4rwZkKWCv2SPYRERFhMf-wVSsLCAE3fAFe7smZsoC..E67atHdREsWLno-3b4Py3r87C4LB7gpVYDq3Q1z7t90C * third_party/r8: vS0S3VF_56MDd3mARnkGERRFeaUdiFZV5EkMkTUTZQIC..bq7w2bmLhe4u4VCiCliPuhaupJB-lu2mW9gr5dB16ekC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6ca0dfd477..743467d32a No update to Clang. Bug: None Tbr: geofflang@google.com,bsheedy@google.com Change-Id: I152436dc441b05801a6b425021c26f15603b1186 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5441013 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand 646f5d19 2024-04-03T15:28:40 CL/VK: Implement eventVk routines Adding routines: clGetEventInfo [CL_EVENT_COMMAND_EXECUTION_STATUS] clSetEventCallback clWaitForEvents [USER_EVENT_STATUS] We also trigger event callback on exec-status update. Bug: angleproject:8574 Change-Id: I470d9758de22a552bd9cf9565594b3049e21835d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5421575 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 0a67bbaf 2024-04-08T10:14:45 SPIR-V: Fix const constructors with single scalar These constructors may be generated because of RemoveArrayLengthTraverser. Bug: chromium:332546345 Change-Id: I5b81ded59ba91b0083b14280f5a61b03b9d4ca43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5435713 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 84613b97 2024-04-09T12:36:55 Vulkan: Suppress Undefined-Value-ShaderInputNotProduced If the app doesn't write to an attachment from the shader, it'll get undefined values. Bug: angleproject:8401 Change-Id: I60f2bf510f0f0f9779f00dafbeee3b7364283bf4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5440653 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Geoff Lang 0e19adb2 2024-04-08T13:21:09 Validate non-negative vertex attribute offsets. When robust buffer access is enabled, validat that buffers cannot be read with a negative index. Bug: chromium:323699974 Change-Id: I05beb72c60832ab4decbf16c47b3d92bd374286b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5435736 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Charlie Lao d3aaf795 2024-04-05T15:57:38 Vulkan: Early out ImageHelper::updateLayoutAndBarrier when possible If one image is attached to more than one attach points, when render pass closes we end up calling ImageHelper::updateLayoutAndBarrier multiple times. The first one is required since it does the layout transition etc. But the second call is unnecessarily inserting memory barriers. This is optimization itself, but will also fix the other bigger problem when we start using VkEvent instead of PipelineBarrier: we may end up waiting for an event that has not been set (since setEvent gets called after we end render pass but waitEvent is before render pass. Calling this sequence twice on the same image for the same render pass means second waitEvent is called before setEvent). Bug: b/333391804 Change-Id: Ic7b409c71806e63cb56c25e10b0bd0bfc9f6086d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5431033 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov e73c0c6d 2024-04-09T11:20:18 EGLProtectedContentTest: move sleep behind compile-time var Multiple tests with multiple steps wasting ~20s in automated runs Bug: b/333113001 Change-Id: I494f6e3ea373945ad79edbc23eb267dfef71ef87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5440412 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi 126f8269 2024-04-05T22:00:02 Additional fix for link task worker pool race See [1] for context. While that change fixed the race condition, it was not great that the task held on to the worker pool for so long. This change avoids the race condition as well by releasing the worker pool as soon as the link task has no further use for it. [1]:https://chromium-review.googlesource.com/c/angle/angle/+/5428806 Bug: angleproject:8661 Change-Id: Ibcbad0afe518e649a63dfdf938bd566c8f80e368 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5431154 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll fda475e5 2024-04-09T10:01:30 Roll vulkan-deps from 4c9bdb52e642 to 3ba43743089e (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4c9bdb52e642..3ba43743089e Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c1ec8e0492..dc9a7170f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Id60d5e6b93cb41444e8bdf9554e00bda7fa3bfbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5434582 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll dd81a3df 2024-04-09T07:00:32 Roll Chromium from 0f9a02e29ab9 to a20bd3962f16 (586 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0f9a02e29ab9..a20bd3962f16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/665175f82f..5ec3f53855 * third_party/android_build_tools/lint: 2G2-Tyftl7Vi8AaG3FHYZHQcOL1_2nD5sNSKrVbN3O0C..KDj5mDBFUzEQm9A0ycRaZZWiYR5SbJFZiuZx3t8Vc5cC * third_party/clang-format/script: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git/+log/e5337933f2..3c0acd2d4e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/246580c7b8..f85dd800c7 * third_party/r8: p-D1sg3S51t1mFujFoZ07E0A98DNXPA2JvwF_2yXMjQC..vS0S3VF_56MDd3mARnkGERRFeaUdiFZV5EkMkTUTZQIC * third_party/siso: git_revision:3cec541372ec0556127a641d9c6e4a90d46ba1b8..git_revision:437716714a744e272fabdf1377b8878ccac26b43 * third_party/turbine: wdLjzY3JXKbaWmI4EB_0s8PaCDwCQzRrPZfPpXmamGUC..wWCZ6axEx90bs9sDY6jPFmdmO-FZfbp9nWunhqrozoIC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/59aa0524dc..6ca0dfd477 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I0fe4393d0610bb49cad214e93c01782faa9742bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5434581 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya ba208b45 2024-04-06T21:08:15 Vulkan: wait for post-link tasks in resetLayout Wait for post-link tasks before resetting ProgramExecutableVk. Otherwise mGraphicsProgramInfos, which post-link tasks use to create pipeline, can be prematurely invalidated. Bug: angleproject:8297 Tests: Texture2DTestES3YUV*DisableProgramCaching Change-Id: Ib84cebad252777ae4c37cb32c455c326911416a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5430927 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang c632fae0 2024-04-02T15:03:17 GL: Support KHR_blend_equation_advanced Combine blend equation setting when they are equal. It is invalid to set advanced blend equations for color/alpha separately. Emit blend equation layout qualifiers. Bug: angleproject:8660 Change-Id: I1d8a88594c80027b564eed70d3b540e0b065968d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5415033 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 92633457 2024-04-08T10:01:13 Roll vulkan-deps from 4f8c21f6ae9d to 4c9bdb52e642 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4f8c21f6ae9d..4c9bdb52e642 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/24f2cdad8e..ade1f7cfd7 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/3492699f49..c1ec8e0492 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I71c6a00e97538fe18c485ff9d04c4ebfc10b99a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5431352 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bd822f29 2024-04-08T07:01:17 Roll Chromium from 87ec061ede78 to 0f9a02e29ab9 (736 revisions) https://chromium.googlesource.com/chromium/src.git/+log/87ec061ede78..0f9a02e29ab9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8df2ddae7c..665175f82f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6dc6690a96..0b9e7b8830 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f1098b6bfe..246580c7b8 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/da4c1b626a..4da68f31de * third_party/r8: AHRbRtHGM288ov0Xn4zb06FS39RLyC5lrNg4mBtQ8xMC..p-D1sg3S51t1mFujFoZ07E0A98DNXPA2JvwF_2yXMjQC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/0e58d440d6..d076d8bd08 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/ef7d05287c..77cdbae19b * tools/luci-go: git_revision:a84377ac0800e2330d02c3dcbf7b4b74a06d6a5b..git_revision:06dc7a1f2eeb1d095f7876799458328a44438df1 * tools/luci-go: git_revision:a84377ac0800e2330d02c3dcbf7b4b74a06d6a5b..git_revision:06dc7a1f2eeb1d095f7876799458328a44438df1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/416fed2499..8a642fb36d * tools/skia_goldctl/linux: -c3Xyfk44hE2J_zUzQNt1bIUIHf5kZ8FqgbE-pzM9Z4C..rNawAlFBeJd8sJp4qBBL82OcdNnUmP3v9ZVqfNoTF00C * tools/skia_goldctl/mac_amd64: PKeo3po--uNQ-GeRTWkE5PthiPZQGwRW1vSOgC8l86AC..j7toaABq50u3jos-EDWtdQTMWqfL13NLW195Lym7izsC * tools/skia_goldctl/mac_arm64: p9oWy9kXG4mSxYGunp3sZfxGN3B5zIUCuYDq8Dq_chgC..lQQEKOiiJjPAeU5wKrwdMSD06O3bDT823qka8hjN0JcC * tools/skia_goldctl/win: rh0cl_Ojif2FMLKYC_rxvrzwn11qPjj9d-wiqC62egAC..nwSzcEIJ0Hmc8k_W7vcYqs0KW88pnufM8vXJfkbm8dEC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I7886629a881d3b24770639b6ccc8fa0bf6890542 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5431349 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi d55464ff 2024-04-04T14:13:02 Vulkan: Remove the supportsDepthClipEnable feature This feature is unused since: https://chromium-review.googlesource.com/c/angle/angle/+/4545084 Bug: angleproject:3970 Change-Id: I78acfda80d4ae04d1387a452e9f52a55a4298a4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5426530 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 49e63e07 2024-04-03T13:22:30 Vulkan: Selectively wait for WarmUp tasks If the GraphicsPipelineDesc used by a draw call differs from the one being used by the WarmUp tasks there is no need to wait for their completion. Bug: angleproject:8297 Change-Id: Ibbf3ee710036936060990455bb8657d83c7b6faf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5421594 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Mohan Maiya ad13fec3 2024-03-30T15:31:49 Vulkan: warmUpGraphicsPipelineCache(...) shouldn't set state The prepareForWarmUpPipelineCache(...) method would have already setup all necessary state for the warm up task. Make that intent explicit by calling into a method that sets no state. Bug: angleproject:8297 Change-Id: I959d8591045ff05ddb2a410fd0e0eda8dd692d37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5408796 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 13829f20 2024-03-26T23:03:12 Vulkan: Optimize depth/stencil resolve with glBlitFramebuffer Like color resolve, depth/stencil resolve is now also possibly done by modifying the render pass and attaching a depth/stencil resolve attachment. Bug: angleproject:7551 Change-Id: I045e3875e24006d2473a55b6c3856dd768fe8b84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5398004 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 924b40dc 2024-04-04T18:44:21 Selectively wait for post-link tasks in the frontend The frontend waits for post-link tasks only for a relink or in syncState when `disableProgramCaching` feature is not enabled. Bug: angleproject:8297 Change-Id: If7a3b8a10a2d01f82fd2bebac5c8f378be56e19e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5427001 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 06472a7e 2024-04-04T21:07:02 Extend ProgramExecutableImpl API waitForPostLinkTasks(...) will be called into by the frontend. Backends can now choose to defer or avoid waiting for post-link tasks. Also, move warmUp task code to ProgramExecutableVk in the Vulkan backend Bug: angleproject:8297 Change-Id: Ia8a0682923e2f8c6287d62a606eed7f481cda08f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5427000 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 76636ddb 2024-04-04T15:39:08 CL/VK: Update missing reflection ops & DS creation Adding CLProgramVk routine to allocate DS. Also adding reflection parsing support for WGS IDs and PushConstantGlobalSize. Additionally, we now check VK implementation if non-semantic reflection data (in SPIR-V) is supported. If not, we strip that data from binary (via vk_feature check). Bug: angleproject:8631 Change-Id: Ife02867c7c30b919abf663865adc92858e1bff8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5421574 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Austin Annestrand 7a78c2c9 2024-04-03T14:32:35 CL/VK: Add helper to select LWS In the case where user passes NULL for LWS, the runtime has the responsibility to select an appropriate LWS for user. Bug: angleproject:8631 Change-Id: I89048c57880a5a4f18d4ef46340b73338cee933e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5421573 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Austin Annestrand 2dc9d0cd 2024-04-04T14:38:31 CL/VK: Add workgroup size/count types Replacing existing CompiledWorkgroupSize type with "WorkgroupSize" and "WorkgroupCount". (since CompiledWorkgroupSize == WorkgroupSize). Bug: angleproject:8631 Change-Id: I4094d10e6ad5db51a56ae92fe4f2fb4a6e72bdc7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5425447 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya ac654931 2024-04-04T15:42:47 ProgramExecutable manages post-link tasks Post-link tasks are now owned and managed by ProgramExecutable. Also, update `LinkTask::link` API so backends have a choice to populate either the linkSubTask or postLinkSubTask containers (but not both). Bug: angleproject:8297 Change-Id: I5dbed6a070efe851fc1376699e9eccd3a21bd03f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406487 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov c0386ad4 2024-04-05T11:56:17 AsyncWorkerPool releases shared_ptr<Closure> before notifying Parallel compile (MainLinkLoadTask, Program::LinkingState) is dependent on destructor getting called before the event is notified Repro: https://crrev.com/c/5425924 More details on the parallel compile case, provided by syoussefi@: """ A race condition caused the worker pool to sometimes be destroyed from a worker thread instead of the main thread. The race condition triggered in the following scenario: - The MainLinkLoadTask holds on to the worker pool - This is necessary for the main task to spawn further tasks asynchronously - The reference to the worker pool in MainLinkLoadTask is released by its destructor - The worker thread dequeues a task (i.e. MainLinkLoadTask) to execute and holds a reference to it. - Once the task is run by the worker thread, the worker thread signals its completion - (1) At this point, the scope holding the reference to the task closes and the task is released. However, this is done after signaling the task's completion. - On program destruction, the program ensures that all its tasks are complete - This uses the signal coming from the worker thread - (2) On display destruction, the worker pool is destroyed (by dereferencing it through the shared_ptr) - The destructor of the worker pool waits for the worker thread, with the expectation that this wait is done in the main thread. The race condition led to the assert firing when (2) was done before (1). Because the task is already signaled complete, the main thread considers it done and goes ahead with the destruction of the display. However, until the scope of the worker thread closes, the task itself is still not destroyed. Since the task is holding a reference to the worker pool, that prevents the worker pool from getting destroyed too. Once the display is destroyed, the worker thread closes its scope, causing the task to be destroyed. In turn, this leads to the worker pool itself to be destroyed. On destruction, the worker pool would wait for the worker thread to end which is a deadlock. Fortunately, this was caught earlier with an ASSERT that wanted to ensure destruction happens on the main thread. In this change, the worker thread ensures it releases the task before signalling it complete, avoiding this issue. Other possible solutions would have been: - Release the worker pool from MainLinkLoadTask as soon as the subtasks are scheduled - Explicitly call a "destroy" method on the pool, instead of relying on the destructor to clean up. """ Bug: angleproject:8661 Change-Id: I37c9bc8e8f05bce4062d794df449cc3d2c80a093 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5428806 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Matthew Denton be42f20b 2024-03-22T05:45:46 Start implementing glClear Currently, because both SurfaceWgpu::getAttachmentRenderTarget() and TextureWgpu::getAttachmentRenderTarget() are unimplemented, there is no actual RenderTargetWgpu in the RenderTargetCache to clear. Bug: angleproject:8582 Change-Id: I9ad33c57d533d81178d7d2a802d35b106ece5848 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5388076 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Shahbaz Youssefi 4a5d47df 2024-04-04T16:41:46 Test that binary is not saved after being loaded Bug: angleproject:8297 Change-Id: I2e7e2ffb8fff37aba828d25825fe7ab3262406ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5426396 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll ccadcef9 2024-04-05T10:01:04 Roll vulkan-deps from 8d0dac85e662 to 4f8c21f6ae9d (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8d0dac85e662..4f8c21f6ae9d Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/58ab8baf72..24f2cdad8e * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/44260a2211..2cb930f7f7 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/cdd0e00cff..0519e66f42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Ie99c67149f330d42f199105281d7e4fcbf894ec9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5428670 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 38b1cd81 2024-04-05T08:01:44 Roll Chromium from 1adf104afb7c to 87ec061ede78 (654 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1adf104afb7c..87ec061ede78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/72d37de74c..8df2ddae7c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0321543600..d248c3571b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2d1be25027..6dc6690a96 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5dc83f8b37..f1098b6bfe * third_party/fuchsia-sdk/sdk: version:19.20240328.3.1..version:20.20240404.3.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/50952f2249..da4c1b626a * third_party/r8: RvhY-w0KwR-5yqm3r8vmLlFTlW6DeIENkCxHL9KSYqQC..AHRbRtHGM288ov0Xn4zb06FS39RLyC5lrNg4mBtQ8xMC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/fbd0a40e62..0e58d440d6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/dd5cc704c5..59aa0524dc No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I8704c936f6ae941fba50a4a4f86eb86d276a32b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5426963 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand 35c7e186 2024-04-03T14:31:59 CL: Introduce NDRange object/ops abstraction Create new FrontEnd type "NDRange" to encapsulate OpenCL's NDRange items. Update backend implementations to make use of this new object. Bug: angleproject:8650 Change-Id: I3c1549c50c85153b3ea77267e104eec04ba1bd93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5421572 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev cdbc58f1 2024-04-04T00:00:00 Metal: Align texture view constructors with the API Fully expose Metal API parameters through texture view constructors. No behavioral change. Bug: angleproject:8355 Change-Id: I2a55f1e799d6e06b2528eefdee4bf5936e5b4301 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5426671 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Roman Lavrov f8bcfc3f 2024-04-04T16:03:32 Tests: avoid double logging to stderr from WARN() LoggingAnnotator::logMessage calls both plat->logWarning() (when plat is not nullptr) and gl::Trace(), and both log the message to stderr gl::Trace only logs when trace or asserts are enabled, so exclude that case from TestPlatform_logWarning. Bug: None Change-Id: I1649fcc9046f59cbd8f4cfef6be809d3218eddc9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5426531 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Erica Li 3b650ffa 2024-03-19T09:53:06 Metal: Assert while using gl_VertexID as ivec Metal [vertex_id] is uint while gl_VertexID is int. Replacing gl_VertexID with gl_VertexIDMetal without rewrites of the expressions would cause invalid expressions. Fix by casting uint kgl_VertexIDMetal to int kgl_VertexID instead of replacing variable during compile. Bug: angleproject:8597 Change-Id: I76acdb2a0ab5982aa05181175925b3359068e901 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5376498 Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Matthew Denton 5c6a531e 2024-04-03T02:53:13 Add ContextWgpu methods for managing current render pass For simplicity ensureRenderPassStarted() just ends the current render pass and starts a new one. Bug: angleproject:8582 Change-Id: I929526cf2574fa33309310e7f60191c10ab3bf7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5388075 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 103c1b53 2024-03-29T14:37:23 Vulkan: Drop MSRTT emulation dependency on independentResolveNone Usage of VK_RESOLVE_MODE_NONE was removed in [1], but dependency to this property was accidentally added in [2]. [1]: https://chromium-review.googlesource.com/c/angle/angle/+/2743666 [2]: https://chromium-review.googlesource.com/c/angle/angle/+/3353895. Bug: angleproject:4836 Change-Id: I25028b5d343686edd794acdac3714c4a6cb5fa17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5407073 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 57eded36 2024-04-03T23:02:39 Vulkan: Fix off-by-one error in compute-based stencil blit The coordinates used for sampling were calculated based on pixel's top-left (integer) coordinates and used with a NEAREST sampler. This resulted in two bugs: - When X was flipped, the bounds check rejected the first column - The sampling could pick the wrong pixel as the on-the-edge coordinates could map to either of 4 pixels that share that corner. This change moves the sampling coordinates to the pixel's center. Bug: angleproject:8652 Change-Id: I0b54fa0bad366f52f8e6c17bb0054fa373af8b5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5420834 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Roman Lavrov be79ae93 2024-04-02T10:33:06 Codegen: work around unicode in vk.xml causing hash diffs Reading file as text gets around \r\n translation but that messes things up on unicode characters that we have in third_party/vulkan-deps/vulkan-headers/src/registry/vk.xml Bug: angleproject:8643 Change-Id: Ic59dbb074e0bb730d0e614a4bc909979303a1398 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5413774 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi 58ecad7a 2024-04-03T23:12:05 Remove assertion that program is not linking when bound/unbound It's valid to link a program, let it happen in parallel and in the meantime bind and unbind the program in other contexts. The add/release ref functions were asserting that link is resolved, which is not true in that case. Bug: angleproject:8647 Change-Id: I784b5adbb04f062752a873deb1e7a4aaf4527e33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5420990 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuly Novikov fdade369 2024-04-04T14:42:52 Ignore DisplayGLX_api.h in export_targets.py Bug: angleproject:8648 Change-Id: I76a4e59b8a3d82316f11e058fe53b599ef8394ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5424091 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 879e8aa5 2024-04-04T10:01:23 Roll vulkan-deps from 43f849a0e433 to 8d0dac85e662 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/43f849a0e433..8d0dac85e662 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f60412f5a6..44260a2211 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Ica30ab2f09ed62021bd0dca0838cd1cf062c2a41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5421585 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 58fc2f23 2024-04-04T07:01:50 Roll Chromium from 15bf920f7a6d to 1adf104afb7c (652 revisions) https://chromium.googlesource.com/chromium/src.git/+log/15bf920f7a6d..1adf104afb7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/da96935f66..72d37de74c * third_party/android_build_tools/manifest_merger: HxnrwdWmIAhi90brIHiGZ4zmnmgKxP4PD0ZsJX6j-mUC..wtRWPCJVk_NA2GQp0fI-1i-JaPzYJwp6w3udjEhgni4C * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1a9ea5caf5..5dc83f8b37 * third_party/fuchsia-sdk/sdk: version:19.20240320.0.1..version:19.20240328.3.1 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/1317096ef8..932d253fed * third_party/r8: eHemH-tzLR3jqxqGYiQu6AYGLAPyFYG7klrqbvu1mcQC..RvhY-w0KwR-5yqm3r8vmLlFTlW6DeIENkCxHL9KSYqQC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6631de9ce9..dd5cc704c5 No update to Clang. Bug: angleproject:8434 Tbr: yuxinhu@google.com Change-Id: Iaf5049d1b2fa746c27aa48ceef099ad87567c259 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5419781 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Hailin Zhang dc643d9b 2024-04-01T15:59:46 Vulkan: add feature control for client buffer merge add feature control for client attribute buffer merge. default is off to reduce memeory usage for some application. Bug: b/328301788 Change-Id: I5bfd39fb1ea656ebb29bd2dc21726b60bbc1a8d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5410942 Commit-Queue: Hailin Zhang <hailinzhang@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev ceb3c0e1 2024-03-28T00:00:00 Remove redundant AND from ValidateClear Component types of disabled draw buffers are already set to zero. Bug: angleproject:8618 Change-Id: I193dc6249158c6314076fedc7b4f43261d81f074 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5419708 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Nisha Jain ab6dd5b2 2024-03-07T14:19:58 Avoid asserts when const folding binary ops on void variables Fix asserts for example with / and % during constant folding when the operands might be voids. Bug: angleproject:8592 Change-Id: I22275642dbcdf9066940d3a94114e8daa5cbbe41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5416376 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll e0709fef 2024-04-03T10:01:31 Roll vulkan-deps from 3b1638b6e598 to 43f849a0e433 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/3b1638b6e598..43f849a0e433 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7fe5f75e58..58ab8baf72 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e1f6c94dbf..3492699f49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I1665641d064cb6b23fd07224f7de0387f0f2501e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5418855 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brian Sheedy 304ea14a 2024-04-01T17:24:10 Start Mac Intel experiment Bug: chromium:326904538, angleproject:8628 Change-Id: Ib453b4ba0e582d348ec0618b7a5b9c0e69efb86e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5410986 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 72c88301 2024-04-03T10:01:26 Roll SwiftShader from ff61926fcedb to 62c59c41e194 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ff61926fcedb..62c59c41e194 2024-04-02 dcheng@chromium.org Fix build when using SWIFTSHADER_DISABLE_TRACE If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ie361469be7aa946ad21185a3b8bf40fbe4005aab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5417370 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll cac60938 2024-04-03T07:02:05 Roll Chromium from cf84d04c222b to 15bf920f7a6d (642 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cf84d04c222b..15bf920f7a6d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools/linux64: git_revision:93ee9b91423c1f1f53fb5f6cba7b8eef6247a564..git_revision:415b3b19e094cd4b6982147693485df65037f942 * buildtools/mac: git_revision:93ee9b91423c1f1f53fb5f6cba7b8eef6247a564..git_revision:415b3b19e094cd4b6982147693485df65037f942 * buildtools/win: git_revision:93ee9b91423c1f1f53fb5f6cba7b8eef6247a564..git_revision:415b3b19e094cd4b6982147693485df65037f942 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1d02fb45a3..da96935f66 * third_party/android_build_tools/lint: RCWuMX-9cBwhFgVJC0Sf9UXIGz20O_jrrbK2FHfSbi0C..2G2-Tyftl7Vi8AaG3FHYZHQcOL1_2nD5sNSKrVbN3O0C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/bb95c35019..2d1be25027 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e545830db2..1a9ea5caf5 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/af720261b5..50952f2249 * third_party/r8: hzpETAalflyclh8qC2FYlsWKW71kXMBtn_pQ6M3wqz8C..eHemH-tzLR3jqxqGYiQu6AYGLAPyFYG7klrqbvu1mcQC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/30bf3a72e7..fbd0a40e62 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/fd1a0bcf3b..ef7d05287c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/85f56412dc..416fed2499 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/14ded77a9b..6631de9ce9 * tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/b5ea227bd8..dbcbea90c2 * tools/skia_goldctl/linux: KWFqqlbpL444cdU7-tRTLQk4tzJxBh14-JnPM1-PUckC..-c3Xyfk44hE2J_zUzQNt1bIUIHf5kZ8FqgbE-pzM9Z4C * tools/skia_goldctl/mac_amd64: IdI7fZD-WzcVF9Bfz4bt_USGavHlMY1Gw--gCrsCY34C..PKeo3po--uNQ-GeRTWkE5PthiPZQGwRW1vSOgC8l86AC * tools/skia_goldctl/mac_arm64: KtpuilcMQs7fnn_O-1Ks02eD8pKsx66u8LwH9jCqCowC..p9oWy9kXG4mSxYGunp3sZfxGN3B5zIUCuYDq8Dq_chgC * tools/skia_goldctl/win: -_l0Nfk8kZU9G9AOIZx2BfNeHW95wqOJa3C4TWmXlpoC..rh0cl_Ojif2FMLKYC_rxvrzwn11qPjj9d-wiqC62egAC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I9e0b896d503e4f4a77d1745ed58b5dda067e500c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5418649 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand ff03a7b1 2024-03-19T10:54:22 CL/VK: Program build_status & mCallback fixes Was missing saving the build_status in the program export/binary to disk. Also, missing dereference for mCallback. Bug: angleproject:8435 Change-Id: I77f070f5bc1c40454d625abcf13c1a4b70c465b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406613 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Gowtham Tammana bb70f5d1 2024-03-13T06:02:40 CL/VK: Setup platform as provider of vk::Context Setup the CLPlatformVk to be the implementer of `vk::Context`. Initialize the Renderer instance during platform setup. This removes the dependency on the DisplayVk instance and as a consequence any associated egl state. Bug: angleproject:8515 Change-Id: If1848b002d6309911305ca3cb93c316ed7f48965 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406612 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya e4fe461f 2024-04-01T16:41:37 Vulkan: Apply mask during transition search When checking the transition cache for the shaders subset, mask transition bits with kShadersTransitionBitsMask Bug: angleproject:7369 Change-Id: Ic8e4ad00312d5e601dbfc0d84bbc76e809358427 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5410940 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 64cfbb68 2024-04-02T13:22:09 GL: Fix MultisampledRenderToTexture tests and expectations Some MSRTT tests were failing on the GL backend due to exact GL_EQUAL depth tests, others were marked as skipped on all of Android due to old device issues. Update the Android expectations for these tests. Bug: angleproject:8642 Change-Id: I2aad2637773967102a6172fd0a8ae2cb58a420ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5413775 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
Alexey Knyazev abf7b612 2024-03-28T00:00:00 Optimize WebGL clear type validation Use cached component type masks instead of iterating over all attachments every time. Fixed: angleproject:8618 Change-Id: I45b83639120c0b4f50027d1d85fe9158f5cf187d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5407657 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Gowtham Tammana a8e9aa26 2024-03-11T23:50:18 CL/VK: Setup GlobalOps for the platform Setup CLPlatformVk as a provider of vk::GlobalOps, and use the vk::GlobalOps associated thread pool for async tasks. Bug: angleproject:8515 Change-Id: I3e1ae069afabeadfdfa02f4a2f99419882f91c6a Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5403225 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 85b3e967 2024-04-01T14:31:17 Fail link and validation of invalid tessellation program The GL_EXT_tessellation_shader spec says - The tessellation control and evaluation shaders are both optional. If neither shader type is present, the tessellation stage has no effect. However, if either a tessellation control or a tessellation evaluation shader is present, the other must also be present. Fail link and validation if a program contains TCS or TES shader but not both. Bug: angleproject:3572 Tests: KHR-GLES32.core.tessellation_shader.single.xfb_captures_data_from_correct_stage Change-Id: I6799f101a186f3bfae738df442e9aeee691fd91a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5410646 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Gowtham Tammana 47ca7552 2024-03-07T14:19:06 CL/VK: Select Vulkan Angle as platform Ask for Vulkan Angle platform when setting up the platform. Else it is picking from the default one, which might not be Vulkan. Bug: angleproject:8515 Change-Id: I1f43a5de3eb2c72900631695e2b3a5ffef3d966d Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5403224 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 2de6ed73 2024-04-02T11:55:21 Roll third_party/dawn/ 1a9f89047..66f38fda8 (569 commits; 11 trivial rolls) https://dawn.googlesource.com/dawn.git/+log/1a9f890473e2..66f38fda85fe $ git log 1a9f89047..66f38fda8 --date=short --no-merges --format='%ad %ae %s' 2024-04-02 dawn-autoroll Roll vulkan-deps from 319732cc90e4 to 3b1638b6e598 (3 revisions) 2024-04-02 beaufort.francois Handle dedicated, service, and shared workers 2024-04-02 cwallez Various cleanups to CMake files. 2024-04-02 bsheedy Re-add worker expectations 2024-04-02 dawn-autoroll Roll ANGLE from 0bb344f642b7 to 4d317b52ebcf (4 revisions) 2024-04-02 jiawei.shao Remove `DanglingUntriaged` on InstanceBase.mPlatform 2024-04-02 jiawei.shao Fix dangling pointers in future-based Dawn objects 2024-04-02 jiawei.shao Fix dangling pointers in DeviceBase 2024-04-02 jiawei.shao Fix dangling pointer in SubmittedWorkDone 2024-04-02 jiawei.shao Fix dangling pointer in BufferBase 2024-04-01 dawn-autoroll Roll Depot Tools from 4a9d989f52e9 to 2d6b598b7af1 (1 revision) 2024-04-01 bsheedy Suppress additional worker failure 2024-04-01 dawn-autoroll Roll vulkan-deps from 778a83fe011e to 319732cc90e4 (1 revision) 2024-04-01 brandon1.jones Refactor SharedTexture/BufferMemory Into SharedResourceMemory 2024-04-01 dawn-autoroll Roll ANGLE from c6a6d3f9fa69 to 0bb344f642b7 (1 revision) 2024-03-30 dawn-autoroll Roll ANGLE from 93b45da9bfb6 to c6a6d3f9fa69 (9 revisions) 2024-03-30 dawn-autoroll Roll vulkan-deps from cfdb445cf009 to 778a83fe011e (2 revisions) 2024-03-30 dawn-autoroll Roll DirectX Shader Compiler from a9b5e725aa75 to 06e706cf6ecd (2 revisions) 2024-03-29 dawn-autoroll Roll Depot Tools from a5c46d20477c to 4a9d989f52e9 (1 revision) 2024-03-29 dawn-autoroll Roll ANGLE from 2b66694d37de to 93b45da9bfb6 (4 revisions) 2024-03-29 dawn-autoroll Roll vulkan-deps from cb27f57dc052 to cfdb445cf009 (3 revisions) 2024-03-29 jimblackler Fix for handling of path constants. 2024-03-29 dawn-autoroll Roll DirectX Shader Compiler from 773246eddc82 to a9b5e725aa75 (4 revisions) 2024-03-29 cwallez Fix CMake dependencies after the touch of generated files. 2024-03-29 dawn-autoroll Roll ANGLE from 21b6899a9c31 to 2b66694d37de (9 revisions) 2024-03-29 dawn-autoroll Roll vulkan-deps from 61c7aa9a8478 to cb27f57dc052 (9 revisions) 2024-03-29 dawn-autoroll Roll DirectX Shader Compiler from dd14fe5a5303 to 773246eddc82 (1 revision) 2024-03-28 dneto Remove kokoro configs for linux and windows 2024-03-28 cwallez CMake: Use Python3_EXECUTABLE instead of PYTHON_EXECUTABLE 2024-03-28 dawn-autoroll Roll SwiftShader from 0bacc751b4d1 to ff61926fcedb (3 revisions) 2024-03-28 bclayton [tint] Remove pointless virtual overrides from IncompleteType 2024-03-28 bclayton [tint][ir] Add Capability::kAllowRefTypes 2024-03-28 bclayton [tint][wgsl] Pull ptr/ref handling out to raise transform 2024-03-28 dawn-autoroll Roll ANGLE from 085ff15a9f4c to 21b6899a9c31 (4 revisions) 2024-03-28 dawn-autoroll Roll vulkan-deps from 6d6da41632e2 to 61c7aa9a8478 (3 revisions) 2024-03-28 penghuang Vulkan: add vulkan_skip_draw toggle for skipping vkCmdDraw* 2024-03-28 dawn-autoroll Roll DirectX Shader Compiler from 4386e4b85152 to dd14fe5a5303 (1 revision) 2024-03-28 dawn-autoroll Roll Depot Tools from 8de981739270 to a5c46d20477c (4 revisions) 2024-03-28 hao.x.li Remove render to 3d texture slices from unsafe apis 2024-03-28 dawn-autoroll Roll SwiftShader from bbe6452b420c to 0bacc751b4d1 (1 revision) 2024-03-28 dawn-autoroll Roll ANGLE from e045b8469077 to 085ff15a9f4c (3 revisions) 2024-03-28 dawn-autoroll Roll vulkan-deps from 4f5c3553ddc3 to 6d6da41632e2 (8 revisions) 2024-03-27 dawn-autoroll Roll DirectX Shader Compiler from e2fb8b33b292 to 4386e4b85152 (1 revision) 2024-03-27 hao.x.li CTS: Triage failures in 3d texture slices with backend validation 2024-03-27 cwallez Remove dawn::native::Instance::GetFeatureInfo 2024-03-27 dawn-autoroll Roll Depot Tools from 79cfa048c0e6 to 8de981739270 (1 revision) 2024-03-27 cwallez Fix warning for CMake Policy CMP0148 2024-03-27 jimblackler Supply initial templates for ART library API. 2024-03-27 amaiorano dxc: build with asan or ubsan if enabled 2024-03-27 senorblanco Compat-CTS: update expectations. (...) 2024-02-13 bclayton [dawn/node] Improve texture format conversion errors 2024-02-13 bclayton [tint][utils] Add more comparison operators for Source::Location 2024-02-13 bclayton [tint][core] Expose intrinsic::PrintOverload() 2024-02-13 bclayton [tint][wgsl] Expand ast::Function source to include whole function 2024-02-13 dawn-autoroll Roll ANGLE from cb7d3cc206d6 to ebc151d514ea (2 revisions) 2024-02-13 blundell [toggles] Set labels on backend objects only if toggle is set 2024-02-13 bclayton [tint][sem] Store OverloadInfo on BuiltinFn 2024-02-13 bclayton [clang-format] 2024-02-13 cwallez Triage some of the canvas CTS expectations 2024-02-13 dawn-autoroll Roll DirectX Shader Compiler from 2872d2d0e7ee to 627e400dea0b (5 revisions) 2024-02-13 dawn-autoroll Roll vulkan-deps from feb7c9fd4183 to c23644b65575 (9 revisions) 2024-02-13 dawn-autoroll Roll ANGLE from 9fd5167e1ff6 to cb7d3cc206d6 (3 revisions) 2024-02-12 senorblanco Compat CTS: remove more passing tests. 2024-02-12 bajones Revert "[toggles] Set labels on backend objects only if toggle is set" 2024-02-12 lokokung [dawn][wire] Use client reservation structs for server injection. 2024-02-12 amaiorano expectations.txt: triage some issues 2024-02-12 penghuang d3d11: specify planeSlice for creating SRV and RTV 2024-02-12 senorblanco Compat CTS: remove expectations for passing tests. 2024-02-12 enga Add async pipelines to the cache inside the async task 2024-02-12 jrprice vulkan: Remove storageInputOutput16 requirement 2024-02-12 dawn-autoroll Roll DirectX Shader Compiler from cadf3bfed1db to 2872d2d0e7ee (1 revision) 2024-02-12 dawn-autoroll Roll vulkan-deps from f53f1b6ab28e to feb7c9fd4183 (3 revisions) 2024-02-12 bclayton [tint][sem] Add more Declaration() methods 2024-02-12 senorblanco Add ClampFragDepth transform to GLSL writer. 2024-02-12 bclayton [tint][ir] Don't emit instructions with abstract types. 2024-02-12 dawn-autoroll Roll ANGLE from eaddd3baa5ed to 9fd5167e1ff6 (1 revision) 2024-02-12 blundell [toggles] Set labels on backend objects only if toggle is set 2024-02-12 dawn-autoroll Roll vulkan-deps from 2e6294aece33 to f53f1b6ab28e (1 revision) 2024-02-10 dawn-autoroll Roll vulkan-deps from 91655d665673 to 2e6294aece33 (1 revision) 2024-02-10 bclayton [tint][spriv] Fix SampledImage::Equal() 2024-02-10 dawn-autoroll Roll DirectX Shader Compiler from afedfff5c1b6 to cadf3bfed1db (4 revisions) 2024-02-10 dawn-autoroll Roll vulkan-deps from 6c7bb72d35e0 to 91655d665673 (3 revisions) 2024-02-10 lokokung Removes unused callback mode argument to TrackEvent. 2024-02-10 dawn-autoroll Roll ANGLE from 3ad163d09102 to eaddd3baa5ed (9 revisions) 2024-02-10 dawn-autoroll Roll DirectX Shader Compiler from c997ea02605d to afedfff5c1b6 (1 revision) 2024-02-10 lokokung Reland "[WGPUFuture] Implement pop error scope in wire/native with Futures." 2024-02-10 lokokung [dawn][node] Update async tasks to call ProcessEvents instead of Tick. 2024-02-09 enga Make the device logging callback spontaneous 2024-02-09 bclayton [tint][core] Remove abstracts and packedVec3() from core.def 2024-02-09 senorblanco Implement a push constant helper class. 2024-02-09 bclayton [tint] Fix GCC error 2024-02-09 bclayton [dawn] Add missing 'const' on SystemEventAndReadyStateIterator operators 2024-02-09 bclayton [tint][utils] Add missing const to Slice equality operator 2024-02-09 bclayton [tools] Move useful code out to packages. 2024-02-09 dawn-autoroll Roll vulkan-deps from 014f44e134a1 to 6c7bb72d35e0 (2 revisions) 2024-02-09 dneto Remove dead reference to angle_spirv_cross_dir 2024-02-09 dawn-autoroll Roll ANGLE from 475784f5a635 to 3ad163d09102 (1 revision) 2024-02-09 dawn-autoroll Roll DirectX Shader Compiler from ba0705ecb1fe to c997ea02605d (5 revisions) 2024-02-09 dawn-autoroll Roll vulkan-deps from 6a767109f66d to 014f44e134a1 (3 revisions) 2024-02-09 cwallez Suppress MaxInterStageVariables causing VVL errors. Created with: roll-dep third_party/dawn Bug: angleproject:8474 Change-Id: I6aa1ffbe44520f63242d06666d41ae9779b91f7e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5412913 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 0cb30943 2024-04-02T10:01:38 Roll vulkan-deps from 778a83fe011e to 3b1638b6e598 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/778a83fe011e..3b1638b6e598 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/0015dc9345..8a3ea594c7 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/3617af2881..c5da01ee0a * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/491f7a9101..e1f6c94dbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Id2f051fd518429103d033b94633f2cdd4dc0997c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5410989 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 42262e83 2024-04-02T07:30:43 Roll Chromium from 35e9d0924a4c to cf84d04c222b (372 revisions) https://chromium.googlesource.com/chromium/src.git/+log/35e9d0924a4c..cf84d04c222b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/441bcf98e2..1d02fb45a3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d4b67cd8aa..bb95c35019 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4a9d989f52..e545830db2 * third_party/turbine: JYrlFcNFCmJoG4mYco1fxSNuhgASzU-EdBb4_Bd2-z0C..wdLjzY3JXKbaWmI4EB_0s8PaCDwCQzRrPZfPpXmamGUC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8da645951b..14ded77a9b No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Iff78834e7cc507e5b4aeb44d7093782d9de3086f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5410945 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 5d294e6e 2024-04-01T11:32:17 Manual roll VK-GL-CTS from 08c8f6c7aa44 to caf989d22e07 (30 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/08c8f6c7aa44..caf989d22e07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: b/332383430 Tbr: yuxinhu@google.com Change-Id: If0518d4db878990405bf5813ca456eafae0d9970 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5410639 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 4d317b52 2024-03-22T15:48:51 Vulkan: Add MSRTSS preferred usage for tex init The image create flag related to multisampled render to single- sampled was used when this feature flag was enabled. However, this could lead to some platforms allocating extra memory for the image, even if the image did not use this feature. In this change, a new feature is added regarding whether to prefer this flag from the start. If disabled, ANGLE will only use this bit for the texture if it is actually bound to an MSRTT framebuffer object (through FramebufferTexture2DMultisampleEXT()). * Added a new feature: preferMSRTSSFlagByDefault * If enabled, the MSRTSS is used for all image inits. * (TextureVk::initImage()) * Otherwise, it will create the image without the flag at first. * Added member to texture frontend to track if the texture has been bound to an MSRTT framebuffer. * mHasBeenBoundToMSRTTFramebuffer * During TextureVk::syncState(), if the image without the MSRTSS bit is bound to an MSRTT framebuffer, it is recreated using the MSRTSS flag. * Checked in respecifyImageStorageIfNecessary(). Bug: b/329911999 Bug: angleproject:8622 Change-Id: I5e7d43e3828ae272441d65b2be35d09b23b68f84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5402978 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev 18797bf2 2024-03-28T00:00:00 Metal: Handle incompatible attachments Metal runtime fails if the attachment pixel formats are not compatible with the program outputs or if the corresponding render pass and pipeline pixel formats do not match. Added Metal-specific state tracking and forced draw framebuffer syncronization for such cases. Cleaned up and reduced Framebuffer::setAttachmentImpl. Fixed: angleproject:5233 Change-Id: I4ee01889debe0e3cce54635e6cba62dbfdc02722 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5377813 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Yuly Novikov b8374d4f 2024-03-29T10:10:36 Expose Mac and Win experiments on ANGLE CI Bug: chromium:327017900, chromium:41496254 Change-Id: I1c4ee46b5c4313a7fb7c0488f7666459b79d79f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5401705 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
angle-autoroll 4413bec8 2024-04-01T10:01:34 Roll vulkan-deps from b203847466b0 to 778a83fe011e (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b203847466b0..778a83fe011e Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/8c0199c4fd..0015dc9345 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/87721a1009..7fe5f75e58 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/242b6f33a6..491f7a9101 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Ib52220746340d9b46725f3ed0560baa1d0960a50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5408496 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0bb344f6 2024-04-01T07:01:03 Roll Chromium from af09c69e52e4 to 35e9d0924a4c (190 revisions) https://chromium.googlesource.com/chromium/src.git/+log/af09c69e52e4..35e9d0924a4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d50c85d5ca..441bcf98e2 * third_party/siso: git_revision:3ccd47200355e0a6fc7fecf6b16aba559d26e23c..git_revision:3cec541372ec0556127a641d9c6e4a90d46ba1b8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c7a92ea96b..8da645951b No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Id3d6595933d19f8a43b2c1c496d858d71bbb6e21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5409236 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c6a6d3f9 2024-03-30T03:33:41 Manual roll Chromium from 78f0fd1ec9e7 to af09c69e52e4 (361 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/chromium/src.git/+log/78f0fd1ec9e7..af09c69e52e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a5c46d2047..4a9d989f52 * third_party/fuchsia-sdk/sdk: version:19.20240328.3.1..version:19.20240320.0.1 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Iec7793a3fae7ff2dc6459e9f67eaa075dab4e168 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5408633 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya e85bc345 2024-03-29T13:43:46 Account for disableProgramCaching Blob cache tests rely on implicit caching of programs. Account for disableProgramCaching frontend feature when saving and retrieving from cache. Also skip EGLBlobCache tests if the feature is enabled. Bug: angleproject:8297 Change-Id: Ib101eb5712deb7c04dd19c7092f93a6c6b42cd40 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5408103 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 25a30934 2024-03-30T01:15:19 Manual roll Chromium from ac341cc25766 to 78f0fd1ec9e7 (1 revision) Manual roll requested by solti@google.com https://chromium.googlesource.com/chromium/src.git/+log/ac341cc25766..78f0fd1ec9e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md No dependencies changed. No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I916c178591ef3b6274e4b80530e93c6c4b20beb6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5408584 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 199b1861 2024-03-30T00:09:35 Manual roll Chromium from 053f0b115f80 to ac341cc25766 (1 revision) Manual roll requested by solti@google.com https://chromium.googlesource.com/chromium/src.git/+log/053f0b115f80..ac341cc25766 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependency * testing: https://chromium.googlesource.com/chromium/src/testing/+log/99058ad3cc..d50c85d5ca No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I4b4fed102df691b8919d1507e761a1ad4765899f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5408631 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 88dbb101 2024-03-29T23:01:13 Manual roll Chromium from 8a45cef8ebc1 to 053f0b115f80 (3 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/chromium/src.git/+log/8a45cef8ebc1..053f0b115f80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md No dependencies changed. No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I705a22601179123aac709560f02e6127ad19c4b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5407812 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Solti 76113ffb 2024-03-27T20:35:46 Manual roll VK-GL-CTS from fe6e7bd09f53 to 08c8f6c7aa44 (1 revision) Manual roll requested by solti@google.com Some local updates were made to the roll, see https://anglebug.com/8636 for details. https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fe6e7bd09f53..08c8f6c7aa44 2024-03-21 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (framebuffer_blit), PART 2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Test: presubmit Bug: angleproject:8636 Bug: b/331390622 Change-Id: I4e754b2a91f8a321e709842a8cf146bbf54a2199 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5402981 Auto-Submit: Solti Ho <solti@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 174a0e43 2024-03-29T20:14:28 Manual roll Chromium from ca785e885ed3 to 8a45cef8ebc1 (6 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/chromium/src.git/+log/ca785e885ed3..8a45cef8ebc1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependency * testing: https://chromium.googlesource.com/chromium/src/testing/+log/12db050850..99058ad3cc No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Ib79ac84d745b2bdfd311b341a48b8d88cd7587d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5407916 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 321c6b63 2024-03-29T10:30:59 Remove is_always_lock_free assertion from AtomicQueueSerial Build will fail when compiled on 32 bit architecture. The code will still function on 32 bit architecture but with performance penalty due to lock. But we are not really expecting it actually run on 32 bit platform with vulkan backend (the atomic queue serial is only used by vulkan backend). We could move AtomicQueueSerial into vulkan backend, but that will be a much larger change that I try to avoid. This CL removes the static_assertion and make it 8 bytes aligned as well. Bug: angleproject:7989 Change-Id: I3c0bd9877c4171485ca1aa9af0cf4621c1c23f56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5407870 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll 499c7c72 2024-03-29T17:36:11 Manual roll Chromium from 647be67fd3b9 to ca785e885ed3 (13 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/chromium/src.git/+log/647be67fd3b9..ca785e885ed3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9e0b2c837a..12db050850 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6abf8f51e0..d4b67cd8aa No update to Clang. Bug: None Tbr: solti@google.com Change-Id: If09c3db31594c818d081a9b6a4aef37fd1f1ff34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5407868 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 93b45da9 2024-03-29T12:44:00 Pin clang until Skia is able to build with ToT abseil. ANGLE pins abseil-cpp until https://skbug.com/330350366 is resolved. Therefore ANGLE's abseil-cpp uses old DEF files, which can't be kept in sync with new clang, e.g. here: https://chromium-review.googlesource.com/c/angle/angle/+/5406623 which includes DEF file updates in https://chromium-review.googlesource.com/c/chromium/src/+/5405904 Bug: angleproject:8555 Change-Id: Iac06d456aadaf2b3dd08a943a46d710ee25887d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5401708 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Solti Ho <solti@google.com> Reviewed-by: Solti Ho <solti@google.com>
angle-autoroll e2031e72 2024-03-29T07:01:17 Roll Chromium from 47e3c979a2ee to 647be67fd3b9 (581 revisions) https://chromium.googlesource.com/chromium/src.git/+log/47e3c979a2ee..647be67fd3b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools/linux64: git_revision:cfddfffb7913868936e76a269ae824aadd737b1b..git_revision:93ee9b91423c1f1f53fb5f6cba7b8eef6247a564 * buildtools/mac: git_revision:cfddfffb7913868936e76a269ae824aadd737b1b..git_revision:93ee9b91423c1f1f53fb5f6cba7b8eef6247a564 * buildtools/win: git_revision:cfddfffb7913868936e76a269ae824aadd737b1b..git_revision:93ee9b91423c1f1f53fb5f6cba7b8eef6247a564 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3bbd3b134a..9e0b2c837a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6afa4087bd..6abf8f51e0 * third_party/fuchsia-sdk/sdk: version:19.20240320.0.1..version:19.20240328.3.1 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ec88f0ab26..1317096ef8 * third_party/r8: cR2jywy_AWBarfoCAaRnIWirBjBE_RMzaO0D9dbdaIUC..hzpETAalflyclh8qC2FYlsWKW71kXMBtn_pQ6M3wqz8C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/41dfe5d7d2..279d79a374 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/056d41d38a..c7a92ea96b No update to Clang. Bug: None Tbr: solti@google.com Change-Id: If67f540b4ca9f840e0cae7f1791ecafba1be24b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406622 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 936ba770 2024-03-29T10:01:18 Roll vulkan-deps from 4f5c3553ddc3 to b203847466b0 (22 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4f5c3553ddc3..b203847466b0 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/3225778615..8c0199c4fd * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/7d500c4d75..4f7b471f1a * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fe7bae0906..87721a1009 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/e3f8bd7aa6..3617af2881 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/d90f5c7eb1..cdd0e00cff * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ea5117b517..242b6f33a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I12cdc3c49bf4b5489c042764c58a6b34c3358f49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406484 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 414c989e 2024-03-29T10:01:43 Roll SwiftShader from 6912e7d5b75a to ff61926fcedb (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/6912e7d5b75a..ff61926fcedb 2024-03-28 rsworktech@outlook.com split source files with the same case-insensentive name into different source sets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I5b2a590a875038bbbf384ad0177a892feb543c03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5405531 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 2b66694d 2024-03-28T00:00:00 Metal: Untangle public draw calls Do not call public Metal backend draw commands from itself. Bug: angleproject:8630 Change-Id: I7c0e016dc0eb3365520cdb39db215e4233e0d9fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5401865 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Auto-Submit: Alexey Knyazev <lexa.knyazev@gmail.com>
Yuxin Hu 076a5059 2024-03-28T10:15:42 Remove test suppression of dEQP-EGL*robustness on Pixel 6 Previoustly the tests dEQP-EGL*robustness*out_of_bounds_non_robust* were skipped on Pixel 6, because the test is intentionally testing in GLES, shader write out of bounds access results in undefined behavior. In ANGLE vulkan backend, shader write out-of-bounds access results in vulkan device lost on Pixel 6, which is a valid undefined vulkan behavior according to spec. However, VVL is reporting errors when ANGLE cleans up vulkan resources, because they haven't finished execution on GPU. With below VVL changes landed: https://github.com/KhronosGroup/Vulkan-ValidationLayers/commit/9452b82820276eb3eb2102bf49b72e59916d3ea7 https://github.com/KhronosGroup/Vulkan-ValidationLayers/commit/af257b1c55f312b550addeca091265c249c09cf3 VVL now checks if there is a vulkan device lost upon resource clean-up. If the vulkan device is lost, even if the resource has not finished execution, treat resource clean up as a safe vulkan operation and do not report VVL error. Bug: b/289544394 Change-Id: I9d3532d4d6b0c3a1cdfd8837e13b4527d0dfbd7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5403212 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Shahbaz Youssefi b559efa8 2024-03-26T22:02:41 Vulkan: Allow depth and stencil resolve to be separately added In preparation for optimizing resolve through glBlitFramebuffer for depth/stencil attachments. Bug: angleproject:7551 Change-Id: I57650d82c0cc6e56f44591eadfc42ac794cfef09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5399140 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 84eb4f73 2024-03-26T15:44:48 Add a few use-after-resolve depth/stencil framebuffer tests Bug: angleproject:7551 Change-Id: I42c1a6b8fe8714fd9c1568d216b12ee9a001aba5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5399137 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi a0fa06f6 2024-03-25T14:46:56 Translator: Disallow samplers in structs in interface blocks As disallowed by the spec: > Types and declarators are the same as for other uniform variable > declarations outside blocks, with these exceptions: > > * opaque types are not allowed Bug: chromium:328859176 Change-Id: Ib94977860102329e520e635c3757827c93ca2163 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5391986 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll c5ba9b6c 2024-03-28T15:38:03 Manual roll SwiftShader from 0bacc751b4d1 to 6912e7d5b75a (2 revisions) Manual roll requested by syoussefi@google.com https://swiftshader.googlesource.com/SwiftShader.git/+log/0bacc751b4d1..6912e7d5b75a 2024-03-28 syoussefi@google.com Fix alignment bug with depth/stencil resolve attachment 2024-03-28 rsworktech@outlook.com fix debug build with llvm 16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7551 Tbr: solti@google.com,syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Id5300525d24dff1f014a9ea41186721d45b9336c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5405492 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi b4cf07c3 2024-03-27T15:58:04 Vulkan: Move the interface pipeline library caches to share group When linking libraries into a pipeline, the linked pipeline lives in ProgramExecutableVk and may be shared between contexts in a share group. The caches for the vertex input and fragment output libraries thus cannot live in the context, but should remain alive until all contexts in the share group are destroyed. This change moves these caches to the share group. Bug: angleproject:8629 Change-Id: I2f7edf44d676505cf5e7e24640c6850c67f8b5e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5401514 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c71a67de 2024-03-27T15:50:00 Vulkan: Move pipeline cache graph dump to renderer In preparation for moving some caches to the share group. Bug: angleproject:6565 Bug: angleproject:8629 Change-Id: I1a06a18417502e499da0edb9abb0d510e3ad99ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5401513 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi 0e9254bd 2024-03-25T16:37:51 Vulkan: Optimize color invalidates By not flushing the render pass when there is an invalidate. Previously, the tracking of invalidation, write to attachments, management of load/store ops, and whether image contents are defined or not have all been unified between color and depth/stencil images. As such, it is possible to not close the render pass when a color image is invalidated just as is not done for depth/stencil images. Together with the optimization to resolve attachments [1], it is now finally possible to efficiently do MSAA rendering with ANGLE. Note that the optimization to use resolve attachments for depth/stencil is not yet implemented. For color only, the perf test added in [2] shows the following improvement on Pixel 6: - Single sampled rendering: ~2.73ms - Resolve + invalidate (before optimizations): ~3.54ms - Resolve + invalidate (after this change): ~2.85ms [1]: https://chromium-review.googlesource.com/c/angle/angle/+/5388492 [2]: https://chromium-review.googlesource.com/c/angle/angle/+/5392548 Bug: angleproject:7551 Change-Id: I008adf9f53df97ab464b0a0399f0b312bf4d0d3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5391905 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 21b6899a 2024-03-28T10:01:24 Roll SwiftShader from bbe6452b420c to 0bacc751b4d1 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/bbe6452b420c..0bacc751b4d1 2024-03-28 syoussefi@google.com Fix crash in asserts with VK_EXT_vertex_input_dynamic_state If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I6a4cbfba2b6aafd6edf82b5bd7f5cb532e4b07f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5404927 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brian Sheedy 3c8b3f6b 2024-03-26T17:07:39 Start Mac AMD experiment Bug: chromium:327017900, angleproject:8628 Change-Id: I7b108c724eaa6f5ff7b8098c256c6e4a47578b5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5399719 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll fb4f2142 2024-03-28T09:07:33 Roll Chromium from 3d9d6f707e2b to 47e3c979a2ee (692 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3d9d6f707e2b..47e3c979a2ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4bcca7be94..8919328651 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4c83a8c553..3bbd3b134a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7c64299944..6afa4087bd * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/79cfa048c0..a5c46d2047 * third_party/r8: 7ehFNNRB1oBj36LLbab2DFgn-COWZyOpNbEWT5wggLoC..cR2jywy_AWBarfoCAaRnIWirBjBE_RMzaO0D9dbdaIUC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/5e488ec77d..fd1a0bcf3b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d50741b1b6..41dfe5d7d2 * tools/luci-go: git_revision:7dd3e0506c6083aae7a0e413a30e0e11b76da08e..git_revision:a84377ac0800e2330d02c3dcbf7b4b74a06d6a5b * tools/luci-go: git_revision:7dd3e0506c6083aae7a0e413a30e0e11b76da08e..git_revision:a84377ac0800e2330d02c3dcbf7b4b74a06d6a5b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2083ef769c..056d41d38a * tools/skia_goldctl/linux: 99yLozEj_tyDp8qTdMy-BwtOaV0vLq-BveFIgCWd3NYC..KWFqqlbpL444cdU7-tRTLQk4tzJxBh14-JnPM1-PUckC * tools/skia_goldctl/mac_amd64: pgF7oaiQoZXpDmbfBxIA2Oqt4FWD44Pix9CqetNS7iUC..IdI7fZD-WzcVF9Bfz4bt_USGavHlMY1Gw--gCrsCY34C * tools/skia_goldctl/mac_arm64: YXM0Gt4bBW5NsQmjlxQu1xjW-KeFxgRV-vylz7J0LawC..KtpuilcMQs7fnn_O-1Ks02eD8pKsx66u8LwH9jCqCowC * tools/skia_goldctl/win: PWJ1a9WbPS3mXZYg62Mz2Lvdo_AGrnkgqNGdTyAkg2QC..-_l0Nfk8kZU9G9AOIZx2BfNeHW95wqOJa3C4TWmXlpoC No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I418b849893d8ac8e44de072800566b1e2c08f8b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5404747 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 9475ac40 2023-11-15T10:25:06 Vulkan: Make efficient MSAA resolve possible Prior to this change, using a resolve attachment to implement resolve through glBlitFramebuffer was done by temporarily modifying the source FramebufferVk's framebuffer description. This caused a good deal of complexity; enough to require the render pass to be immediately closed after this optimization. The downsides to this are: - Only one attachment can be efficiently resolved - There is no chance for the MSAA attachment to be invalidated In this change, resolve attachments that are added because of glBlitFramebuffer are stored in the command buffer, with the FramebufferVk completely oblivious to them. When the render pass is closed, either the FramebufferVk's original framebuffer object is used (if no resolve attachments are added) or a temporary one is created to include those resolve attachments. With the above method, the render pass is able to accumulate many resolve attachments as well as have its MSAA attachments be invalidated before it is flushed. For a FramebufferVk that is resolved in this way, there used to be two framebuffers created each time and thrown away as the code alternated between starting a render pass without a resolve attachment and then closing with one. With this change, there is now one framebuffer (without resolve attachments) that is cached in FramebufferVk (and is not recreated every time), and only the framebuffer with resolve attachments is recreated every time. Ultimatley, when VK_KHR_dynamic_rendering is implemented in ANGLE, there would be no framebuffers to create and destroy, and this change paves the way for that support too. WindowSurfaceVk framebuffers are still imagefull. Making them imageless adds unnecessary complication with no benefit. ----------------- To achieve efficient MSAA rendering on tiling hardware, applications should do the following: ``` glBindFramebuffer(GL_FRAMEBUFFER, msaaFBO); // Clear the framebuffer to avoid a load // Or invalidate, if not needed to load: // glInvalidateFramebuffer(GL_DRAW_FRAMEBUFFER, ...); glClear(...); // Draw calls // Resolve into the single sampled framebuffer glBindFramebuffer(GL_DRAW_FRAMEBUFFER, resolveFBO); glBlitFramebuffer(...); // Immediately discard the contents of the MSAA buffer, to avoid store glInvalidateFramebuffer(GL_READ_FRAMEBUFFER, ...); ``` The above would translate to the following Vulkan render pass: - MSAA LOAD_OP_CLEAR/DONT_CARE - MSAA STORE_OP_DONT_CARE - Resolve LOAD_OP_DONT_CARE - Resolve STORE_OP_STORE This makes sure the MSAA data doesn't leave the tile memory and greatly reduces bandwidth usage. Once anglebug.com/4892 is fixed, this would also allow the MSAA image to never be allocated either. Bug: angleproject:7551 Bug: angleproject:8625 Change-Id: Ia9f4d20863d76a013d8495033f95c7b39f77e062 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5388492 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Le Hoang Quyen 085ff15a 2024-03-26T03:33:26 Metal: Fix RenderTargetMtl::getFormat() could return nullptr. Bug: b/326301256 Change-Id: Ia8914e4bc77e34bd510661689837b97d5de82d92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5394149 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Cody Northrop 71e5a43f 2024-03-26T14:03:14 FrameCapture: Don't use shadow memory on Pixel after Android 14 The platform bug that required shadow memory to track changes to coherent mapped buffers has been fixed in Android 14. mprotect now works on Vulkan surfaces. Test: MEC with title using coherent buffers Bug: angleproject:7402 Bug: b/269535398 Change-Id: I370f29ee7d033b19facf48cfd76576950c39b735 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5399117 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Mike Schuchardt <mikes@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
angle-autoroll 0156fe4e 2024-03-27T10:02:00 Roll vulkan-deps from 3bf81e7e8859 to 4f5c3553ddc3 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/3bf81e7e8859..4f5c3553ddc3 Changed dependencies: * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/4befdac21a..d90f5c7eb1 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2ac49e5c08..ea5117b517 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I2c48a2d337b3569c308cab3f2f5bd9e135ae90be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5400501 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0