Hash :
c39d25ae
Author :
Date :
2020-06-01T12:42:33
Update State to check mExecutable A user may be using Program Pipelines, rather than monolithic Programs, so State should check if mExecutable is valid, rather than mProgram, since that indicates the presence of either a PPO or a Program. Exercising these paths requires additional tests: SimpleStateChangeTestComputeES31PPO::DeleteImageTextureInUse() Texture2DTestES31PPO::TexStorage() Texture2DTestES31PPO::SingleTextureMultipleSamplers() These new tests exposed bugs in the PPO implementation where updates to the active Program's ProgramExecutable were not being propagated to the Executables of the PPO's containing that Program. In these particular cases, updates to the active samplers/images/textures were not being copied to the PPO's Executable. Bug: angleproject:3570 Test: end2end tests listed above Change-Id: I297cac2d0367f180dd7fa01a1ee7ba53996867c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2225417 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
ANGLE’s Vulkan back-end implementation lives in this folder.
Vulkan is an explicit graphics API. It has a lot in common with other explicit APIs such as Microsoft’s D3D12 and Apple’s Metal. Compared to APIs like OpenGL or D3D11 explicit APIs can offer a number of significant benefits:
The RendererVk class represents an EGLDisplay. RendererVk owns shared global
resources like the VkDevice, VkQueue, the Vulkan format tables
and internal Vulkan shaders. The ContextVk class implements the back-end
of a front-end OpenGL Context. ContextVk processes state changes and handles action commands like
glDrawArrays and glDrawElements.
The back-end records commands into command buffers via the the following ContextVk APIs:
endRenderPassAndGetCommandBuffer: returns a secondary command buffer outside a RenderPass instance. flushAndBeginRenderPass: returns a secondary command buffer inside a RenderPass instance. flushAndGetPrimaryCommandBuffer: returns the primary command buffer. You should rarely need this API.
Note: All of these commands may write out (aka flush) prior pending commands into a primary
command buffer. When a RenderPass is open endRenderPassAndGetCommandBuffer will flush the
pending RenderPass commands. flushAndBeginRenderPass will flush out pending commands outside a
RenderPass to a primary buffer. On submit ANGLE submits the primary command buffer to a VkQueue.
If you need to record inside a RenderPass, use flushAndBeginRenderPass. Otherwise, use
endRenderPassAndGetCommandBuffer. You should rarely need to call flushAndGetPrimaryCommandBuffer.
It’s there for commands like debug labels, barriers and queries that need to be recorded serially on
the primary command buffer.
The back-end usually records Image and Buffer barriers through additional ContextVk APIs:
onBufferTransferRead/onBufferComputeShaderRead and onBufferTransferWrite/onBufferComputeShaderWrite accumulate VkBuffer barriers. onImageRead and onImageWrite accumulate VkImage barriers. onRenderPassImageWrite is a special API for write barriers inside a RenderPass instance.
After the back-end records commands to the primary buffer we flush (e.g. on swap) or when we call
ContextVk::finishToSerial.
See the code for more details.
In this example we’ll be recording a buffer copy command:
# Ensure that ANGLE sets proper read and write barriers for the Buffers.
ANGLE_TRY(contextVk->onBufferTransferWrite(destBuffer));
ANGLE_TRY(contextVk->onBufferTransferRead(srcBuffer));
# Get a pointer to a secondary command buffer for command recording. May "flush" the RP.
vk::CommandBuffer *commandBuffer;
ANGLE_TRY(contextVk->endRenderPassAndGetCommandBuffer(&commandBuffer));
# Record the copy command into the secondary buffer. We're done!
commandBuffer->copyBuffer(srcBuffer->getBuffer(), destBuffer->getBuffer(), copyCount, copies);
More implementation details can be found in the doc directory: