kc3-lang/libevent

Branch :

Log

Author Commit Date CI Message
3fec471c 2020-06-25 21:34:02 Add LSAN suppressions (for OpenSSL temporary quirk)
b90b1925 2020-06-25 21:01:53 Add TSAN suppressions
0db4e1c4 2020-06-25 21:01:53 ci: run tests under sanitizers Added: - ASAN - TSAN - UBSAN And disable some tests that are know to have leaks.
46c9ead0 2020-06-25 08:08:10 Make all classes Entry, Struct, etc) new-style classes This allows the object methods to be properly inherited and called via `super(..)`, addressing breakage with python 2.x, introduced in cfcc093606e747a5d250787012bac0b149c60d6d. Fixes #1042. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
c424594b 2020-06-25 10:18:43 evdns: do not pass NULL to memcpy() in evdns_server_request_format_response() In case of OPT pseudo-RR `class` field is treated as a requestor's UDP payload size, and class will have 512 (DNS_MAX_UDP_SIZE), and data is NULL: (gdb) p *item $4 = { next = 0x0, name = 0x602000000130 "", type = 41, class = 512, ttl = 0, is_name = 0 '\000', datalen = 0, data = 0x0 } And UBSAN will reports: ../evdns.c:2493:5: runtime error: null pointer passed as argument 2, which is declared to never be null #0 0x7ffff70b65bb in evdns_server_request_format_response ../evdns.c:2493 #1 0x7ffff70b706b in evdns_server_request_respond ../evdns.c:2529 #2 0x5555557975ab in regress_dns_server_cb ../test/regress_testutils.c:263 #3 0x7ffff70a8489 in request_parse ../evdns.c:1576 #4 0x7ffff70aa445 in server_udp_port_read ../evdns.c:1726 #5 0x7ffff70ac5cc in server_port_ready_callback ../evdns.c:1849 #6 0x7ffff6d3054c in event_persist_closure ../event.c:1645 #7 0x7ffff6d311cd in event_process_active_single_queue ../event.c:1704 #8 0x7ffff6d33258 in event_process_active ../event.c:1805 #9 0x7ffff6d361b5 in event_base_loop ../event.c:2047 #10 0x7ffff6d334ac in event_base_dispatch ../event.c:1839 #11 0x555555739df2 in test_edns ../test/regress_dns.c:2639 #12 0x5555557b9e96 in testcase_run_bare_ ../test/tinytest.c:173 #13 0x5555557ba8f0 in testcase_run_one ../test/tinytest.c:333 #14 0x5555557bc9a0 in tinytest_main ../test/tinytest.c:527 #15 0x555555787faa in main ../test/regress_main.c:528 #16 0x7ffff606c001 in __libc_start_main (/usr/lib/libc.so.6+0x27001) #17 0x55555569436d in _start (/src/le/libevent/.cmake-debug/bin/regress+0x14036d)
a0c642ac 2020-06-25 10:15:01 buffer: do not pass NULL to memcpy() from evbuffer_pullup() UBSAN reports: evbuffer/remove_buffer_with_empty3: ../buffer.c:1443:3: runtime error: null pointer passed as argument 2, which is declared to never be null #0 0x7ffff6cd0410 in evbuffer_pullup ../buffer.c:1443 #1 0x5555556d68b9 in test_evbuffer_remove_buffer_with_empty3 ../test/regress_buffer.c:408 #2 0x5555557b95ee in testcase_run_bare_ ../test/tinytest.c:173 #3 0x5555557ba048 in testcase_run_one ../test/tinytest.c:333 #4 0x5555557bc0f8 in tinytest_main ../test/tinytest.c:527 #5 0x555555787702 in main ../test/regress_main.c:528 #6 0x7ffff606c001 in __libc_start_main (/usr/lib/libc.so.6+0x27001) #7 0x55555569436d in _start (/src/le/libevent/.cmake-debug/bin/regress+0x14036d)
6f152bef 2020-06-25 09:59:35 test: do not pass NULL to memcmp() in evbuffer_datacmp() helper Fixes: runtime error: null pointer passed as argument 2, which is declared to never be null
37dbb350 2020-06-25 08:45:34 http: fix undefined-shift in EVUTIL_IS*_ helpers evutil.c:2559:1: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' #0 0x4f2be0 in EVUTIL_ISXDIGIT_ libevent/evutil.c:2559:1 #1 0x4bd689 in regname_ok libevent/http.c:4838:7 #2 0x4bc16b in parse_authority libevent/http.c:4958:9 #3 0x4bb8b5 in evhttp_uri_parse_with_flags libevent/http.c:5103:7 #4 0x4bb762 in evhttp_uri_parse libevent/http.c:5050:9 #5 0x4b8f41 in evhttp_parse_query_impl libevent/http.c:3505:9 #6 0x4b8ed7 in evhttp_parse_query libevent/http.c:3569:9 Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23291 Report: https://oss-fuzz.com/testcase-detail/5670743106125824
4528d8e9 2020-06-25 09:08:31 Check error code of evhttp_add_header_internal() in evhttp_parse_query_impl()
45c3fc29 2020-06-22 19:40:06 wepoll: use lower-cased windows headers This matches their use throughout the rest of the project, and fixes the build when you are cross-compiling on Linux using mingw-w64. i.e: CC epoll.lo CC wepoll.lo CC signal.lo wepoll.c:138:10: fatal error: WS2tcpip.h: No such file or directory #include <WS2tcpip.h> ^~~~~~~~~~~~ compilation terminated. make[2]: *** [Makefile:1918: wepoll.lo] Error 1
26d5ff45 2020-06-18 15:47:14 cmake: avoid problems from use of CMAKE_USE_PTHREADS_INIT In some CMake integrations, portions of the toolchain may end up defining CMAKE_USE_PTHREADS_INIT even when EVENT__DISABLE_THREAD_SUPPORT is set for libevent. Modify the build to not rely on this side effect of find_package(Threads, ...) [which could be done elsewhere] but instead to use EVENT__HAVE_PTHREADS which is defined only on the desired codepath. Without this change, affected builds fail as a result of event_pthreads source files being built but with build defines which cause the build to fail. Signed-off-by: Paul Osborne <paul.osborne@smartthings.com>
efbe563b 2020-05-28 17:32:05 recreate socket when udp failed
2aaa7358 2020-06-02 10:12:20 test/regress_http: remove second ARRAY_SIZE macros
8b5a4d61 2020-06-02 10:01:31 test/regress_testutils: use inet_addr()
271c5aaa 2020-06-02 10:00:38 test/regress_dns: use tt_int_op() over tt_assert() in assert_request_results()
83c58d49 2020-05-31 19:59:49 evdns: Add support for setting maximum UDP DNS message size. Added new option `edns-udp-size` for evdns_base which allows to control maximum allowed size of UDP DNS messages. This maximum size is passed to the DNS server via edns mechanism.
c753ae87 2020-05-28 11:50:49 CI: catch failures and retry
a9aa2b36 2020-05-27 15:39:49 remove FindGit.cmake, improve `git describe` command
89d313b1 2020-05-27 20:33:25 checkpatch.sh: fix clang-format-diff usage - strip 1 path component - it does not accept file name anymore, only stdin Refs: #1029
8209a623 2020-05-27 20:31:29 checkpatch.sh: fix usage Refs: #1029
866fbb54 2020-05-28 00:03:03 Fix clang-format-diff usage "--style" is invalid: $ ./checkpatch.sh -r HEAD usage: clang-format-diff [-h] [-i] [-p NUM] [-regex PATTERN] [-iregex PATTERN] [-sort-includes] [-v] [-style STYLE] [-binary BINARY] clang-format-diff: error: unrecognized arguments: --style={ Language:... }
7426a568 2020-05-25 11:25:18 http: Merge branch 'http-max_connections-pr-592' @jcoffland: "When the max connection limit is enabled and the limit is reached, the server will respond immediately with 503 Service Unavailable. This can be used to prevent servers from running out of file descriptors. This is better than request limiting because clients may make more than one request over a single connection. Blocking a request does not necessarily close the connection and free up a socket." * http-max_connections-pr-592: test: cover evhttp max connections Added evhttp max simultaneous connection limiting
95c1c200 2020-05-25 03:34:16 test: cover evhttp max connections
f10aaea3 2020-05-25 10:33:24 variable redefinition in win32_dispatch
028842aa 2020-05-25 03:13:00 Merge branch 'evdns-tcp-pr-1004' @seleznevae: "Added support for DNS requests via TCP. By default, requests are done via UDP. In case truncated response is received new attempt is done via TCP connection. Added 2 new macros DNS_QUERY_USEVC and DNS_QUERY_IGNTC to force all requests to be done via TCP and to disable switch to TCP in case of truncated responses. Also added possibility for DNS server to listen and receive requests on TCP port. Current implementation of TCP support in DNS server seems rather preliminary and maybe changes after discussion and code review. Fallback to TCP in case of truncated DNS requests is done automatically. To imitate the old behaviour macros DNS_QUERY_IGNTC should be used. To force all DNS requests to be done via TCP one should use the flag DNS_QUERY_USEVC. Names DNS_QUERY_IGNTC, DNS_QUERY_USEVC were chosen to imitate similar flags in c-ares and glibc." Ok, interfaces looks good, merging to avoid stalling it for too long. * evdns-tcp-pr-1004: evdns: fix coding style issues evdns: fix trailing whitespaces evdns: bufferevent_setcb before bufferevent_free is redundant evdns: Implement dns requests via tcp
2c2248ea 2020-05-25 03:06:43 evdns: fix coding style issues
1cab3c05 2020-05-25 02:55:38 evdns: fix trailing whitespaces
1cf24f04 2020-05-25 02:35:55 evdns: bufferevent_setcb before bufferevent_free is redundant
e8c89510 2020-05-25 02:06:32 test: http/autofree_connection cleanup
0f6ee89a 2020-05-21 12:46:20 evdns: Implement dns requests via tcp
eee26dee 2020-05-19 11:45:43 http: fix EVHTTP_CON_AUTOFREE in case of timeout (and some else) Refs: #182
083c6d54 2020-05-19 01:02:30 http: fix EVHTTP_CON_AUTOFREE in case of connection error Refs: #182
70f69194 2020-05-19 01:05:50 test: cleanup http/autofree_connection
1cc94fea 2020-05-19 00:52:01 test: fix http/autofree_connection Refs: #182
8fe35c76 2020-05-18 14:10:28 evdns: Add additional validation for values of dns options
83ef3216 2020-04-22 19:44:45 Add wepoll support to light up the epoll backend on Windows libevent is lacking a scalable backend on Windows. Let's leverage the wepoll library until Windows comes up with an epoll/kqueue compete user mode API. - All regress tests pass for standard wepoll - These 2 tests fail intermittently for changelist wepoll, so disabling changelist wepoll for now http/cancel_inactive_server http/stream_in - verify target on Windows runs tests for both wepoll and win32 backends - wepoll backend preferred over win32 backend - wepoll version 1.5.6 v2: cleaner backend abstraction. Disallow wepoll on MinGW/Cygwin. v3: Add wepoll.h to dist v4: Make sure wepoll source files are excluded from cygwin/mingw builds v5: Keep win32 as default backend on windows. v6: Include wepoll in mingw builds. Verified that regress tests pass w/ WEPOLL backend. v7: Enable wepoll on mingw when building with cmake v8: Add wepoll testrunner for autotools test target
06a11929 2020-05-07 21:14:13 test: Fix test_simpleclose for Windows platform Replace close with evutil_closesocket Caught with PR #1006
15917b42 2020-05-06 03:03:27 Include details of the ABI compatibility report
889ad6d6 2020-05-06 02:10:34 Add ABI compatibility report deploy Closes: #887
448a478a 2020-05-06 02:40:49 abi-check: abi-monitor 1.10 does not support -make -j8 (1.12 supports though) An error for 1.10 on ci: https://github.com/azat/libevent/runs/647860649?check_suite_focus=true#step:4:219
f3e911ed 2020-05-06 02:09:51 Do not ignore anything in .github Fixes: 28eb0d91 ("github actions looks good - drop travis/appveyor (#951)")
735c891e 2019-09-04 23:09:13 Add API/ABI checker (using LVC) v2 (by azat): - drop package installations - use local .abi-check over $HOME/abi-check for build dir - drop regex check, simply use default values (too complex otherwise) - use sub-shell to avoid cd back - add missing quotes - make the style uniq across the whole file (no tabs for indent, copy-paste?) - drop `set -x`, use `bash -x abi-check.sh` over - drop EVENT_ABI_CHECK - use /usr/bin/env bash as shebang - use `find | xargs` over `cp $(grep -v)` - adjust markdown syntax in abi-check/README.md - adjust link to the publicly available documentation v3 (by azat): - docker image - git check-ignore - make -j8 - allow to change defaults Refs: #887
512c88ce 2020-05-05 15:22:32 ci/linux: add dist check
f3bc5327 2020-05-05 16:24:59 Update list of cmake files for autotools dist archive Fixes: #976
c19ebffb 2020-05-05 14:57:59 ci: change cache key for windows/mingw Should fix the following current failures: - 2020-05-04T22:32:02.9490248Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(231,5): error MSB6006: "cmd.exe" exited with code 3. [D:\a\libevent\libevent\build\regress.vcxproj] - cmake : /usr/bin/sh: /C/hostedtoolcache/windows/Python/3.7.6/x64/python.exe: No such file or directory P.S. I guess python has another path, but on my fork it is the same and it passes.
7a465268 2020-05-05 14:20:09 Pass --quiet to the event_rcpgen.py (autotools already does this)
072dfacf 2020-05-05 13:57:15 Do not run CI if message contains "ci skip" https://github.com/marketplace/actions/skip-based-on-commit-message
61fc2bf2 2020-05-05 10:31:09 There is typo in GetAdaptersAddresses windows library. It should be iphlpapi.dll
4c13afae 2020-05-05 01:13:49 Support EV_CLOSED on linux for poll(2) Refs: #984
972b456b 2020-05-05 00:21:18 Fix EV_CLOSED detection/reporting (epoll only) - EV_CLOSED is EPOLLRDHUP in epoll - EPOLLRDHUP reported w/o EPOLLHUP if the socket closed with shutdown(SHUT_WR) - EPOLLRDHUP reported w/ EPOLLHUP if the socket closed with close() so in this case epoll backend will detect this event as error (EV_READ|EV_WRITE), since the epoll_ctl() will return EPOLLRDHUP with EPOLLHUP set, but this is not correct, let's fix this. Fixes: #984
c10cde4c 2020-05-05 00:05:49 Merge branch 'EV_CLOSED-and-EV_ET-fixes' * EV_CLOSED-and-EV_ET-fixes: Avoid triggering wrong events with EV_ET set epoll: handle EV_ET for EV_CLOSED too test: cover EV_CLOSED with lots of possible scenarious test: rename simpleclose to simpleclose_rw (since it works via write/read)
9543f31a 2020-04-09 02:16:15 Avoid triggering wrong events with EV_ET set For the event at least something except EV_ET should be set, so checking ev->ev_events with "triggered" events is wrong, because EV_ET is always passed (see epoll), since it will be filtered out if it is not set in event.
e703c034 2020-04-09 02:00:17 epoll: handle EV_ET for EV_CLOSED too
ecb67f61 2020-04-09 00:30:57 test: cover EV_CLOSED with lots of possible scenarious - trigger *RDHUP via close() <-- has issues - trigger *RDHUP via shutdown() - EV_CLOSED - EV_CLOSED|EV_PERSIST - EV_CLOSED|EV_ET <!-- has issues - EV_CLOSED|EV_ET|EV_PERSIST
c81362b2 2020-04-09 00:14:26 test: rename simpleclose to simpleclose_rw (since it works via write/read)
28eb0d91 2020-05-04 23:42:22 github actions looks good - drop travis/appveyor (#951) Actually right now github's VMs is better then travis/appveyor.
bdc5200a 2020-05-03 00:32:10 bufferevent: allow setting priority on socket and openssl type
86eafc03 2020-05-01 09:51:29 cmake: set a default value for LIBEVENT_STATIC_LINK
f0b3160f 2020-04-27 15:02:25 evutil_time: improve evutil_gettimeofday on Windows If present, use GetSystemTimePreciseAsFileTime instead of GetSystemTimeAsFileTime. Available since Windows 8.
5caffa7a 2020-04-16 12:08:02 bench: Allow backend method selection -l list available methods -m <name> use method
57862901 2020-04-08 00:29:40 cmake: missing test-closed binary
dd02ad95 2020-03-28 16:02:39 Merge branch 'event_rpcgen.py-cleanup' * event_rpcgen.py-cleanup: event_rpcgen.py: fix arguments-differ event_rpcgen.py: fix attribute-defined-outside-init event_rpcgen: suppress some warnings to make pylint clean Don't accumulate arguments in `Entry.GetTranslation` Fix improper string concatenations in lists Fix warnings regarding unused variables Don't override the `type` built-in Call `super` to call methods from the parent class Address `no-self-use` issues reported by pylint Run the code through the black formatter Reformat strings to template Add `argparse` support Precompile regular expressions Use bools instead of ints values where possible Rename all global variables to match the PEP8 spec Handle file pointers with context suite patterns Iterate over `tokens` with a for instead of while Fix indentation for `RpcGenError` Don't override `file` built-in Resolve variable name issues per PEP8 Sort imports per PEP8
b57b6e46 2020-03-28 16:01:46 event_rpcgen.py: fix arguments-differ
7cdf75ca 2020-03-28 15:58:57 event_rpcgen.py: fix attribute-defined-outside-init
121fe013 2020-03-28 15:58:36 event_rpcgen: suppress some warnings to make pylint clean
47a2bcf6 2020-03-27 17:24:53 Don't accumulate arguments in `Entry.GetTranslation` Initialize `extradict` safely to avoid accumulating arguments in dict objects passed in across calls. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
6a3ca347 2020-03-27 17:01:53 Fix improper string concatenations in lists This change adds commas between elements or explicitly concatenates the strings, so the values are no longer concatenated by accident. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
496fc02b 2020-03-27 16:56:16 Fix warnings regarding unused variables Prefix all unused variables with `_` to mute unused variable warnings with flake8/pylint. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
80171db5 2020-03-27 16:45:21 Don't override the `type` built-in Name the second parameter to `Entry(..)` `ent_type` to avoid overriding the built-in. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
cfcc0936 2020-03-27 16:27:56 Call `super` to call methods from the parent class Not only does it make it clearer to the reader what the intent is behind the code, it fixes MRO evaluation of classes if the parent-child relationship is nonlinear. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
83175940 2020-03-27 16:20:24 Address `no-self-use` issues reported by pylint Sprinkle around `@staticmethod` where need be and raise `NotImplementedError` from `Entry.GetInitializer` instead of doing similar with `assert`. `NotImplementedError` will provide a hint to static analyzers that there are abstract methods which need to be implemented, if they aren't, in subclasses. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
6da0cc61 2020-03-27 16:04:37 Run the code through the black formatter This resolves a number of flake8 issues as well as pylint issues. Not all of the changes mesh between flake8/pylint though, so there are some false positives, but it's better than before. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
10a04036 2020-03-27 15:58:02 Reformat strings to template This change converts the existing code to use triple-quotes extensively, in the end-goal of making the code to reformat with black more readable before and after the change (black messes around with the formatting in a less than desirable way). Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
4cde51b6 2020-03-26 22:29:43 Add `argparse` support This change converts raw parsing with `sys.argv` to its equivalent logic with `argparse`. It doesn't fully convert over all of the TODO items listed in the comments, but it does provide some top-level structure which can be used to drive down further improvements and structure. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
23874cfc 2020-03-26 21:02:13 Precompile regular expressions This change boost performance at scale by pre-compiling regular expressions in the global space, then reusing them many times within functions. This (while not the desired intent of the author) will boost performance when parsing input. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
1b545a46 2020-03-26 19:15:52 Use bools instead of ints values where possible This is being done to clarify logic and isn't being done for performance reasons whatsoever, as bools are derived from ints. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
9157b0d2 2020-03-26 19:05:48 Rename all global variables to match the PEP8 spec Global variables should be in all caps, as opposed to lowercase. While here, use named groups for `STRUCT_REF_RE` instead of numbered groups to make the results and their indented tokens to parse more intuitive to the end reader. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
dc576729 2020-03-26 17:37:09 Handle file pointers with context suite patterns This removes the need for manually calling the file pointer's `.close` methods directly. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
7f115c17 2020-03-26 20:42:40 Iterate over `tokens` with a for instead of while This simplifies the logic and avoids unnecessary copying/slicing of array elements in `tokens`. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
5408b963 2020-03-26 17:28:09 Fix indentation for `RpcGenError` Indentation for the exception was double what it should have been. This change normalizes the indentation to a consistent standard with the rest of the file. Fix minor flake8 issues while here corresponding to the minimum number of needed blank lines around the class and its methods. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
30229dcf 2020-03-26 17:21:25 Don't override `file` built-in Use `filep` instead of `file` to clarify the fact that `file` is a file pointer object. This mutes warnings on python 2.7 with `pylint`. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
2c38d6b1 2020-03-26 17:13:14 Resolve variable name issues per PEP8 Move all logic under `if __name__ == "__main__"` to a `main(..)` function. The purpose of this is to not only address flake8/pylint reported issues with variable names, but also to enable testing of the function in isolation to ensure the logic acts as desired. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
f30cc2b0 2020-03-26 16:07:17 Sort imports per PEP8 Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
d4e392b5 2020-03-26 18:28:07 Mute clang 8 compilation error with gcc pragma Move the pragma ignoring outside the function to fix the build with gcc. While here, add equivalent clang pragmas to mute the warning, as well. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
0d2f1700 2020-03-22 19:36:45 Merge #976 -- symbols check build fixes * upstream/pr/976: github workflows: ignore previous cache github workflows: test for mingw via cmake cmake: replace CheckFunctionExists with CheckSymbolExists
6dea1514 2020-03-22 18:35:24 github workflows: ignore previous cache modify the cache key to ignore previous cache for the changes of configure.ac/CMakeLists.txt to take effect.
93eb1b70 2020-03-22 13:51:46 github workflows: test for mingw via cmake
41d1d75a 2020-03-20 17:49:37 cmake: replace CheckFunctionExists with CheckSymbolExists Checking functions with `CheckFunctionExists` may get wrong results, we should replace it with `CheckSymbolExists`, which is recommended by the cmake official documentation. Before using `CheckSymbolExists`, we use `CheckIncludeFiles` to check header files and save the available header files in a variable that guarantees `CheckSymbolExists` and `CheckTypeSize` to work correctly. This approach is modeled after the cmake scripts of `curl`. The following functions or files were not found before modification, they can now be found: - msys2 + mingw-8.1.0 on Windows10 or mingw-7.3.0 on Ubuntu-18.04 timerclear timercmp timerisset - windows10 getaddrinfo getnameinfo getprotobynumber getservbyname putenv strtoll timerclear timercmp timerisset - ubuntu-18.04 sys/sysctl.h timeradd timerclear timercmp timerisset - MacOS 10.13 sys/random.h timeradd timerclear timercmp timerisset
1675a556 2020-03-03 19:02:24 LibeventConfig.cmake: restore CMAKE_FIND_LIBRARY_SUFFIXES and LIBEVENT_STATIC_LINK default The current cmake/LibeventConfig.cmake.in has a few problems and I'm not sure how cleanly developed it is. It seems rater complex for the little things I would assume it needs to do. I found two problems that are fixed in this PR: - If the downstream user does not explicitly set LIBEVENT_STATIC_LINK before calling find_package(libevent) then they will not be able to detect the static library, even if its the only one that exists. Since this may be rather strict, I've changed the behavior so that LIBEVENT_STATIC_LINK can be set to ON or OFF, but if unset, it defaults to whatever configuration libevent was built as. - The other problem is a bug. The package configuration needs to unset CMAKE_FIND_LIBRARY_SUFFIXES after use, otherwise all packages that are detected after libevent will be "infected" by this setting. This was a significant problem for us, and is very hard to detect in downstream project, because the order of dependencies will lead to different search results.
5c4ea4af 2020-03-17 21:45:04 Merge branch 'build-fixes' (#969) * build-fixes: github workflow: fix configure error on mingw-w64 cmake: fix getaddrinfo checking error cmake: remove CheckFunctionExistsEx autoconf: fix getaddrinfo checking errors on mingw
a3cb3119 2020-03-17 19:57:10 github workflow: fix configure error on mingw-w64
503ba1d3 2020-03-16 20:11:06 cmake: fix getaddrinfo checking error Using `CheckFunctionExists` on Windows to check `getaddrinfo` will get `not found`, but it actually exists. Using `CheckSymbolExists` with headers will get correct results. Other functions such as `getnameinfo`,`inet_ntop`,etc. have the same issue.
61c5c19b 2020-03-16 18:57:54 cmake: remove CheckFunctionExistsEx `CheckFunctionExistsEx` is copied from the cmake modules before 3.1.2, which is the minimum required version of libevent. The internal module `CheckFunctionExists`of cmake can completely replace it.
6d54be2c 2020-03-14 11:13:38 autoconf: fix getaddrinfo checking errors on mingw `AC_CHECK_FUNCS` can not properly check `getaddrinfo` because this function requires some special headers on mingw. Using `AC_CHECK_DECL` can effectively solve this issue. Same for - getnameinfo - getprotobynumber - getservbyname - inet_ntop - inet_pton
9a9b92ed 2020-03-01 16:01:12 Add EVENT_BASE_FLAG_EPOLL_DISALLOW_TIMERFD flag (fixes: #958) By default we are using CLOCK_MONOTONIC_COARSE, but if EVENT_BASE_FLAG_PRECISE_TIMER isset, then CLOCK_MONOTONIC will be used, however this will also enable timerfd, while this is not always what someone wants, hence add a flag to control this (by default the old behavior is preserved, set new flag to change it).
4e5a41ca 2020-03-01 15:47:40 test-time: do not use deprecated API - event_init() -> event_base_new() - event_set() -> event_new() - check return value of event_base_dispatch() - use EXIT_SUCCESS/EXIT_FAILURE
a11edbfa 2020-03-01 14:54:36 test-time: enable debug mode if EVENT_DEBUG_LOGGING_ALL env set
5a5fe67e 2020-03-01 13:52:32 Fix typo in thread.h (s/event/evthread)
114b3836 2020-02-29 17:47:47 increase segment refcnt only if evbuffer_add_file_segment() succeeds
4da9f87c 2020-02-27 16:59:45 evdns: fix a crash when evdns_base with waiting requests is freed Fix undefined behaviour and application crash that might take place in some rare cases after calling evdns_base_free when there are requests in the waiting queue. Current cleanup procedure in evdns_base_free_and_unlock function includes 2 steps: 1. Finish all inflight requests. 2. Finish all waiting requests. During the first step we iterate over each list in req_heads structure and finish all requests in these lists. With current logic finishing an inflight request (function request_finished) removes it from the inflight requests container and forces a wating connection to be sent (by calling evdns_requests_pump_waiting_queue). When these new requests are sent it is possible that they will be inserted to the list in req_heads that we've already cleaned. So in some cases container of the inflight requests is not empty after this procedure and some requests are not finished and deleted. When timeouts for these requests expire evdns_request_timeout_callback is called but corresponding evdns_base has been already deleted which causes undefined behaviour and possible applicaton crash. It is interesting to note that in old versions of libevent such situation was not possible. This bug was introduced by the commit 14f84bbdc77d90b1d936076661443cdbf516c593. Before this commit nameservers were deleted before finishing the requests. Therefore it was not possible that requests from the waiting queue be sent while we finish the inflight requests.