kmx git

Commit	Date	Message
cb6995cf	2018-01-04T19:26:50	test/listener: cover immediate-close logic
e03cd0b7	2017-12-17T22:43:00	Immediately stop trying to accept more connections if listener disabled This is a refined version of the logic previously in #578 The rationale is that the consumer of sockets may wish to temporarily delay accepting for some reason (e.g. being out of file-descriptors). The kernel will then queue them up. The kernel queue is bounded and programs like NodeJS will actually try to quickly accept and then close (as the current behaviour before this PR). However, it seems that libevent should allow the user to choose whether to accept and respond correctly if the listener is disabled.
88a1abe8	2017-12-18T14:01:15	Fixed last_with_datap description Grammar and typo fix
727bcea1	2017-12-01T01:29:32	http: add callback to allow server to decline (and thereby close) incoming connections. This is important, as otherwise clients can easily exhaust the file descriptors available on a libevent HTTP server, which can cause problems in other code which does not handle EMFILE well: for example, see https://github.com/bitcoin/bitcoin/issues/11368 Closes: #578 (patch cherry picked)
6e5c15d0	2017-12-16T23:28:41	Fix typo in cmake because of which EVENT__SIZEOF_SIZE_T was wrong Fixes: #580
65eb529a	2017-12-02T12:53:57	CONNECT method only takes an authority
6cce7458	2017-12-09T14:39:07	If precise_time is false, we should not set EVENT_BASE_FLAG_PRECISE_TIMER Fixes: 630f077c296de61c7b99ed83bf30de11e75e2740 ("Simple unit tests for monotonic timers")
bc65ffc1	2017-12-10T23:57:19	Merge branch 'evconnlistener-do-not-close-client-fd' Fixes: #577 * evconnlistener-do-not-close-client-fd: listener: cover closing of fd in case evconnlistener_free() called from acceptcb Revert "Fix potential fd leak in listener_read_cb()"
8a460e38	2017-12-05T23:26:28	listener: cover closing of fd in case evconnlistener_free() called from acceptcb
94eae336	2017-12-05T22:59:20	Revert "Fix potential fd leak in listener_read_cb()" This reverts commit a695a720cda892c270736d127333d73553842094. @kgraefe: "I believe that this commit is just wrong: if lev->cnt is not 1 after the callback, new_fd will still never be closed in listener_read_cb(). So in that case it is the responsibility of the user's code to close the file descriptor (which is fine). But why shouldn't it be in the other case? And how does the user's code know?" And I agree
6ee73ea9	2017-11-29T11:13:51	Fix generation of LibeventConfig.cmake for the installation tree 'LIBEVENT_INCLUDE_DIRS' is properly initialized in 'LibeventConfig.cmake' as 'LibeventConfig.cmake.in' contains usage of 'LIBEVENT_CMAKE_DIR' and 'EVENT_INSTALL_INCLUDE_DIR' variables but not 'EVENT_CMAKE_DIR' and 'EVENT__INCLUDE_DIRS'. Related typos are fixed.
c2c08e02	2017-11-22T10:33:15	Add missing includes into openssl-compat.h Before it depends from the caller #include appropriate headers (at least for OPENSSL_VERSION_NUMBER), but let's make it independent. Fixes: #574
33e363f3	2017-11-20T02:07:54	Free dns/event bases in dns-example to avoid leaks
b49c70cc	2017-11-05T12:18:49	Fix incorrect ref to evhttp_get_decoded_uri in http.h Replaces reference in the http.h include header file to evhttp_get_decoded_uri with evhttp_uridecode. There is no function called evhttp_get_decoded_uri.
306747e5	2017-11-04T19:13:28	Fix crashing http server when callback do not reply in place from gencb This is the second hunk of the first patch 5ff8eb26371c4dc56f384b2de35bea2d87814779 ("Fix crashing http server when callback do not reply in place") Fixes: #567
3f19c5eb	2017-11-02T14:58:17	cmake doesn't has POLICY CMP0054 in low version
db483e3b	2017-10-29T22:53:41	Allow bodies for GET/DELETE/OPTIONS/CONNECT I checked with nginx, and via it's lua bindings it allows body for all this methods. Also everybody knows that some of web-servers allows body for GET even though this is not RFC conformant. Refs: #408
99d0a952	2017-09-26T19:23:29	Do not crash when evhttp_send_reply_start() is called after a timeout. This fixes the crash reported in issue #509. The "would be nice" items discussed in #509 can be addressed separately.
5ff8eb26	2017-10-23T00:13:37	Fix crashing http server when callback do not reply in place General http callback looks like: static void http_cb(struct evhttp_request req, void arg) { evhttp_send_reply(req, HTTP_OK, "Everything is fine", NULL); } And they will work fine becuase in this case http will write request first, and during write preparation it will disable read callback (in evhttp_write_buffer()), but if we don't reply immediately, for example: static void http_cb(struct evhttp_request req, void arg) { return; } This will leave connection in incorrect state, and if another request will be written to the same connection libevent will abort with: [err] ../http.c: illegal connection state 7 Because it thinks that read for now is not possible, since there were no write. Fix this by disabling EV_READ entirely. We couldn't just reset callbacks because this will leave EOF detection, which we don't need, since user hasn't replied to callback yet. Reported-by: Cory Fields <cory@coryfields.com>
da3f2ba2	2017-09-13T21:39:32	fix handling of close_notify (ssl) in http with openssl bufferevents Since it can arrive after we disabled events in that bufferevent and reseted fd, hence evhttp_error_cb() could be called after SSL_RECEIVED_SHUTDOWN. Closes: #557
8b0aa7b3	2017-09-14T17:39:20	Port `event_rpcgen.py` and `test/check-dumpevents.py` to Python 3. These scripts remain compatible with Python 2.
62866f98	2017-09-24T15:12:13	Remove OpenSSL paragram from README Because it is mauvais ton to use binaries instead of normal packages (like apt-get in debian, pacman in arch, and others). Plus that link was borken and according to [1] OpenSSL do not ship binaries officially. And personally I don't think that this is not obvious that you need openssl libraries to build libevent with it's support, and BTW you need headers too (of course). [1]: https://www.openssl.org/community/binaries.html Fixes: #562
56010f37	2017-09-11T21:56:30	test: fix warning In function ‘send_a_byte_cb’: test/regress.c:1853:2: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] (void) write(*sockp, "A", 1);
1dfec8a9	2017-08-19T16:01:46	configure: avoid false positive in DragonFlyBSD by default, the max buffer size is 16K and histeresis is at 50%, so a bigger read is needed to unlock writes than you would expect from other BSD (512 bytes) this doesn't introduce any regression on FreeBSD 11.1, OpenBSD 6.1, NetBSD 7.1, macOS 10.12.6 and of course DragonFlyBSD 4.8.1, and most of them show a max pipe size of 64K, so the read call should drain them all regardless of how conservative they are on the free pipe space they will require (usually 512 bytes) before kevent reports the fd as ready for write. I couldn't find a reference to which bug this code was trying to look for and it seems to be there from the beginning of git history so it might be no longer relevant. Issue: #548
a86f89d3	2017-08-16T16:52:33	test: avoid regress hanging in macOS a backtrace of the process without this patch : * thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGSTOP * frame #0: 0x00007fffb1fb7d96 libsystem_kernel.dylib`kevent + 10 frame #1: 0x0000000108ed0a58 libevent-2.2.1.dylib`kq_dispatch + 696 frame #2: 0x0000000108ec53d8 libevent-2.2.1.dylib`event_base_loop + 696 frame #3: 0x0000000108e1763b regress`test_fork + 1931 frame #4: 0x0000000108e5c7ad regress`run_legacy_test_fn + 45 frame #5: 0x0000000108e690aa regress`testcase_run_one + 858 frame #6: 0x0000000108e6954f regress`tinytest_main + 495 frame #7: 0x0000000108e5c94b regress`main + 171 frame #8: 0x00007fffb1e88235 libdyld.dylib`start + 1 frame #9: 0x00007fffb1e88235 libdyld.dylib`start + 1 Issue: #546
506df426	2017-08-29T00:44:57	autotools: confirm openssl is working before using latest versions of macOS provide pkg-config and libraries for an ancient version of openssl as part of the system, but no headers
63c4bf78	2017-09-01T15:50:36	test: fix 32bit linux regress
0ec5edde	2017-08-21T01:08:15	autotools: pass $(OPENSSL_INCS) for samples (FTBFS macOS) if OpenSSL is in a non standard location, need to pass that information to any sample that needs it Closes: #550
5698cff7	2017-08-17T01:37:01	always define EV_INT16_MIN somehow missing from 043ae7481f4a73b0f48055a0260afa454f02d136
94e5cc84	2017-08-15T05:11:05	Add configure check for midipix Fixes: #540
27934f0b	2017-08-07T11:06:28	Fix race in access to ev_res from event loop with event_active() Detected using ThreadSanitizer, resolved by capturing the value of ev_res in a local variable while the event is locked, then passing that captured variable to the callback. TSAN report: I0728 14:35:09.822118 WARNING: ThreadSanitizer: data race (pid=815501) I0728 14:35:09.822186 Write of size 2 at 0x7b2c00001bf2 by thread T80 (mutexes: write M1110835549570434736): I0728 14:35:09.822248 #0 event_active_nolock_ libevent/event.c:2893:14 (0a2b90577e830d775300664df77d0b91+0x1fdab28) I0728 14:35:09.822316 #1 event_active libevent/event.c:2858:2 (0a2b90577e830d775300664df77d0b91+0x1fdd10e) I0728 14:35:09.822379 #2 Envoy::Event::TimerImpl::enableTimer(std::chrono::duration<long, std::ratio<1l, 1000l> > const&) envoy/source/common/event/timer_impl.cc:24:5 (0a2b90577e830d775300664df77d0b91+0x459fa0) ... I0728 14:35:09.824146 Previous read of size 2 at 0x7b2c00001bf2 by main thread: I0728 14:35:09.824232 #0 event_process_active_single_queue libevent/event.c:1646:33 (0a2b90577e830d775300664df77d0b91+0x1fdf83d) I0728 14:35:09.824350 #1 event_process_active libevent/event.c (0a2b90577e830d775300664df77d0b91+0x1fd9ad8) I0728 14:35:09.824445 #2 event_base_loop libevent/event.c:1961 (0a2b90577e830d775300664df77d0b91+0x1fd9ad8) I0728 14:35:09.824550 #3 Envoy::Event::DispatcherImpl::run(Envoy::Event::Dispatcher::RunType) envoy/source/common/event/dispatcher_impl.cc:166:3 (0a2b90577e830d775300664df77d0b91+0x4576d9) ... Fixes: #543 (pull-request)
a10a6f4e	2017-08-14T23:11:53	Remove check against passed bufferevent in bufferevent_socket_connect() It is a bit confusing to check against the result of EVUTIL_UPCAST(), because it can return not NULL for NULL pointers, but for even though with bufferevent we are fine (because bufferevent is the first field in bufferevent_private), there are no checks for "bufev" in bufferevent's API, so just remove it to make it generic. Fixes: #542 Signed-off-by: Ivan Maidanski <i.maidanski@samsung.com> Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>
b26996a0	2017-08-14T23:03:48	Fix wrong assert in evbuffer_drain() "chain" cannot be NULL here because we have at least one chain (we handle empty buffer separatelly) and hence loop will be executed at least once. Link: https://github.com/libevent/libevent/commit/841ecbd96105c84ac2e7c9594aeadbcc6fb38bc4#commitcomment-23631347 Signed-off-by: Ivan Maidanski <i.maidanski@samsung.com> Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>
e83443ec	2017-07-16T21:40:18	Merge remote-tracking branch 'official/pr/527' -- documentation fixes * official/pr/527: Fix a few trivial documentation typos Clarify event_free() documentation regarding pending/active events
cf7f5b0d	2017-06-28T12:29:29	Fix tests with detached builds Closes: #524
c3a61a13	2017-07-07T01:24:26	Fix a few trivial documentation typos
2137886d	2017-07-07T01:22:43	Clarify event_free() documentation regarding pending/active events Currently it's not clear as to whether "first make it non-pending and non-active" sentence requires user to take some action (e.g. call event_del(), which event_free() already does internally) or just describes what this function does from the developer point of view.
80852425	2017-06-30T02:27:08	Document some obvious cases where a function might also return NULL Closes: #525
cd285e42	2017-05-29T22:11:48	Fix event_debug_logging_mask_ exporting on win32
1771ec0f	2017-05-29T22:12:09	Vagrant test
3ac4f176	2017-05-29T22:07:57	Revert "Make event_debug_get_logging_mask_() real symbol (win32)" This reverts commit 5f17c12de021c070501e97268e595da82bf38879.
5f17c12d	2017-05-29T20:46:33	Make event_debug_get_logging_mask_() real symbol (win32) I cannot made it work without this, even though dumpbin shows that that symbol exists in the event_core.dll, event_extra.dll failed to compile: ==> win: Creating library C:/vagrant/.cmake-vagrant/lib/Debug/event_extra.lib and object C:/vagrant/.cmake-vagrant/lib/Debug/event_extra.exp ==> win: http.obj : error LNK2001: unresolved external symbol _event_debug_logging_mask_ [C:\vagrant\.cmake-vagrant\event_extra_shared.vcxproj] ==> win: C:\vagrant\.cmake-vagrant\bin\Debug\event_extra.dll : fatal error LNK1120: 1 unresolved externals [C:\vagrant\.cmake-vagrant\event_extra_shared.vcxproj] ==> win: Done Building Project "C:\vagrant\.cmake-vagrant\event_extra_shared.vcxproj" (default targets) -- FAILED. And dumpbin: sh-4.1$ /cygdrive/c/Program\ Files\ \(x86\)/Microsoft\ Visual\ Studio\ 12.0/VC/bin/amd64/dumpbin.exe /EXPORTS ./bin/Debug/event_core.dll M 202 C9 00059A3C event_debug_logging_mask_ = _event_debug_logging_mask_
ce3af533	2017-05-29T15:04:50	Fix visibility issues under (mostly on win32) Refs: #511 Fixes: 7182c2f561570cd9ceb704623ebe9ae3608c7b43 ("cmake: build SHARED and STATIC libraries (like autoconf does)")
2773a5ed	2017-05-29T18:48:48	cmake: set CMP0054 to NEW to avoid variables over expansion (since cmake 3.8) ==> win: CMake Warning (dev) at CMakeLists.txt:782 (elseif): ==> win: Policy CMP0054 is not set: Only interpret if() arguments as variables or ==> win: keywords when unquoted. Run "cmake --help-policy CMP0054" for policy ==> win: details. Use the cmake_policy command to set the policy and suppress this ==> win: warning. ==> win: ==> win: Quoted variables like "MSVC" will no longer be dereferenced when the policy ==> win: is set to NEW. Since the policy is not set the OLD behavior will be used. ==> win: This warning is for project developers. Use -Wno-dev to suppress it.
8b29b136	2017-05-29T16:36:24	cmake: fix building bench/bench_cascade under win32 (missing getopt) Because of typo in cmake, now rewrote to make it less error prone (since even for non-win32 there are variables overlap).
346f8e17	2017-05-29T16:32:30	cmake: avoid requiring cmake 3.1 on win32 for dns-example Avoid using target_sources() from cmake 3.1, just pass needable sources as list.
74a2f593	2017-05-29T16:24:48	le-proxy: fix compiling under win32 (because of no "inline" in C) Include <util-internal.h> for regular "inline", since it is used everywhere.
d22e12ee	2017-05-28T16:38:20	http-connect: exit on error
15da23cf	2017-05-01T21:56:27	test: do not use .fieldname in structure initializations (fixes win32) Fixes: #497
8d89c212	2017-05-01T21:55:00	Add missing print-winsock-errors.c into dist archive Refs: #497
00ae45fe	2017-04-25T23:10:13	le-proxy: add missing return statement (UAF) Refs: #501501501501501501501501501
0b4b0efd	2015-04-13T08:54:52	Return from event_del() after the last event callback termination Delete the event from the queue before blocking for the current event callback termination. Ensures that no callback is being executed when event_del() returns, hence making this function a secure mechanism to access data which is handled in the event callack. Fixes: #236 Fixes: #225 Refs: 6b4b77a Fixes: del_wait
5ff83989	2017-04-30T01:11:31	test: cover that after event_del() callback will not be scheduled again Refs: #236 Refs: #225
f988c5ca	2017-04-28T19:36:42	Correct URL for the libevent logo
c6c74ce2	2017-04-20T18:03:50	Explicitly call SSL_clear when reseting the fd. If reconnecting the via BEV_CTRL_SET_FD, bufferevent_openssl.c expects OpenSSL to reuse the configuration state in the SSL object but retain connection state. This corresponds to the SSL_clear API. The code currently only calls SSL_set_connect_state or SSL_set_accept_state. Due to a quirk in OpenSSL, doing this causes the handshake to implicitly SSL_clear the next time it is entered. However, this, in the intervening time, leaves the SSL object in an odd state as the connection state has not been dropped yet. This behavior also does not appear to be documented by OpenSSL. Instead, call SSL_clear explicitly: https://www.openssl.org/docs/manmaster/man3/SSL_clear.html
92cc0b9c	2017-04-13T14:58:13	bufferevent: refactor to use type check macros
266f43af	2017-03-27T15:50:23	Fix arc4random_addrandom() detecting and fallback (regression) But this is kind of hot-fix, we definitelly need more sane arc4random compat layer. Fixes: #488 Introduced-in: 6541168 ("Detect arch4random_addrandom() existence")
177e2171	2017-03-24T16:49:59	Make event_count macros cleaner Fixes: #489
2e52bace	2017-03-16T23:32:43	fix evutil_make_internal_pipe_'s comment that fd[0] for read and f[1] for write
b1e8a413	2017-03-14T13:33:31	cmake: use APPEND during exporting targets (for old cmake) On centos with cmake 2.8.12.2: CMake Error at cmake/AddEventLibrary.cmake:92 (export): export called with target "event_extra_shared" which requires target "event_core_shared" that is not in the export list. If the required target is not easy to reference in this call, consider using the APPEND option with multiple separate calls. But on newer cmake I guess everything is ok. Fixes: 7182c2f561570cd9ceb704623ebe9ae3608c7b43 ("cmake: build SHARED and STATIC libraries (like autoconf does)")
d84f0205	2017-03-14T13:31:02	Merge branch 'win32-fixes' This patchset fixes win32 builds after some previous patches (referenced in particular commits), and also removes some quirks for win32. * win32-fixes: test: do not return void log/win32: fix exporting extern variable log-internal: missing extern "C" log: remove USE_GLOBAL_FOR_DEBUG_LOGGING cmake: Export missing symbols for win32 cmake: eliminate EVENT_BUILDING_REGRESS_TEST, since we link with shared libs test: windows doesn't have WNOWAIT cmake: clean not used #defines from event-config.h cmake: add <pthread.h> only for non-win32
8acfb0cd	2017-03-14T13:21:16	test: do not return void
92cf234b	2017-03-14T00:33:26	log/win32: fix exporting extern variable ==> win: C:\vagrant\log.c(73): error C2370: 'event_debug_logging_mask_' : redefinition; different storage class [C:\vagrant\.cmake-vagrant\event_core_shared.vcxproj]
a9c2116f	2017-03-14T01:06:10	log-internal: missing extern "C"
49dcf4d5	2017-03-13T22:33:38	log: remove USE_GLOBAL_FOR_DEBUG_LOGGING Fixes: 9081b66c9c1446b11c0052bade799fafb460efed ("Export symbols for -fvisibility=hidden (under cmake)")
48ead58e	2017-03-14T00:46:47	cmake: Export missing symbols for win32
30f2a969	2017-03-14T00:07:17	cmake: eliminate EVENT_BUILDING_REGRESS_TEST, since we link with shared libs Before 7182c2f561570cd9ceb704623ebe9ae3608c7b43 ("cmake: build SHARED and STATIC libraries (like autoconf does)") it links with *.c.
a4b1828d	2017-03-13T23:52:15	test: windows doesn't have WNOWAIT Fixes: 66a4eb0c3ae3b1f22b084b2d3aeb5c872f37efbd ("Check for WNOWAIT in waitpid() in runtime (not in cmake/configure)")
d5e10870	2017-03-13T21:54:33	cmake: clean not used #defines from event-config.h - _LARGE_FILES: we have it in evconfig-private.h.in, drop from event-config.h - EVENT___FILE_OFFSET_BITS: remove it for now - EVENT__const
2d2299cf	2017-03-13T22:02:45	cmake: add <pthread.h> only for non-win32 Fixes: b2b4b4d74e78a3e4fe7a74224d1e6aada5bde351 ("cmake: add <pthread.h> into CMAKE_REQUIRED_INCLUDES for sizeof(pthread_t)")
882f537c	2017-03-13T21:40:52	cmake: fix pkgconfig generation (copy-paste typo)
489991a2	2017-03-13T21:05:32	Merge branch 'cmake-missing-bits' This patchset adds next missing things (in compare to autotools): - pkgconfig - event_pthreads/event_openssl - compile shared/static libraries always And some fixes, because it will not build after fixing other things: - export missing symbols for cmake (-fvisibility=hidden) * cmake-missing-bits: cmake: support visibility for AppleClang too cmake: fix export absolute path and relative path and cleanup a bit cmake: generate and install pkgconfig files cmake: build SHARED and STATIC libraries (like autoconf does) cmake: add missing event_openssl/event_pthreads libraries Export symbols for -fvisibility=hidden (under cmake) Refs: #246
805e1aa8	2017-03-13T15:49:11	cmake: support visibility for AppleClang too Defaults apple linker behaviour is -two_levelnamespace, and you cannot use "-undefined suppress" with it, so let's link non event_core with event_core library to avoid undefined symbols.
fd5a3fc0	2017-03-13T03:18:02	cmake: fix export absolute path and relative path and cleanup a bit Remove next vars, since I don't think that somebody want to change it: - bin - lib - include And fix exports problem: CMake Error: INSTALL(EXPORT "LibeventTargets") given absolute DESTINATION "/usr/lib/cmake/libevent" but the export references an installation of target "event_core_static" which has relative DESTINATION "lib".
86c73575	2017-03-13T02:26:39	cmake: generate and install pkgconfig files Fixes: #443
7182c2f5	2017-03-12T23:31:59	cmake: build SHARED and STATIC libraries (like autoconf does) Since they are useful for debugging, and if autotools build them then cmamke has to do this too, to make migration more simple. And now: - tests: uses shared libraries (since this is upstreams one) - other binaries: uses static libraries This removes next private config: - EVENT__NEED_DLLIMPORT
72ef9d16	2016-11-07T00:46:45	cmake: add missing event_openssl/event_pthreads libraries This will remove openssl requirement if you don't use it (i.e. if you not link with openssl_pthreads). Plus it fixes some linking dependencies: - libm required only for test-ratelim And fix some coding style alignment issues. Refs: #246
9081b66c	2017-03-12T20:50:35	Export symbols for -fvisibility=hidden (under cmake) Fixes: #442
83b15847	2017-03-12T13:12:53	travis-ci: do not run coverage on osx First of all we don't really need two of them, and also with apple-clang it will fail (because of our checks in cmake), so just exclude it from the build matrix.
7004ee8e	2017-03-09T09:32:43	travis-ci: use travis_retry to reduce number of problems with flacky tests
e01b9937	2017-03-08T23:48:30	appveyor: remove -DEVENT__ENABLE_VERBOSE_DEBUG=ON build See-also: c199df7bc78824ff579ff34c5f9f922034e8fa31 ("travis-ci: remove -DEVENT__ENABLE_VERBOSE_DEBUG=ON (too much useless logs)")
65870949	2017-03-12T01:00:41	Fix detection of timerfd_create() in CMake.
819d0493	2017-03-08T23:15:33	Do not add epoll_sub (syscall wrappers) for epoll in cmake Nowadays mostly all supported OS'es has this wrappers, and some of them (like SmartOS) has wrappers but doesn't have __NR_epoll* defines for syscall numbers, so just drop them (instead of adding yet another check int cmake like autotools has, since this will break building in cross-compile environment). Also one minor note, configure doesn't added epoll_sub.c either, since it check epoll_create() in runtime. And I tested it in SmartOS and it even works (`make verify`). Fixes: #463
5aade2d3	2017-03-08T17:58:26	Merge branch 'cmake-configure-fixes-v2' Fixes in cmake, to make it more like configure and support some cross-compiling. * cmake-configure-fixes-v2: cmake: fix extracting of the version from git (check for number of matches) Detect arch4random_addrandom() existence Use off_t instead of ev_off_t for sendfile() (fixes android build) cmake: detect _GNU_SOURCE not by __GNU_LIBRARY__ only (fallback to _GNU_SOURCE) Check for WNOWAIT in waitpid() in runtime (not in cmake/configure) cmake: add <pthread.h> into CMAKE_REQUIRED_INCLUDES for sizeof(pthread_t) cmake: fix values for #cmakedefine cmake: drop duplicates from event-config template cmake: add value for the #cmakedefine macros (like autoconf) cmake: Fix checking of enum values from sysctl.h
d65e3e1d	2017-03-06T14:48:56	cmake: fix extracting of the version from git (check for number of matches)
6541168d	2017-03-06T00:55:16	Detect arch4random_addrandom() existence Refs: #370 Refs: #475
f479a008	2017-03-06T00:45:09	Use off_t instead of ev_off_t for sendfile() (fixes android build) Refs: #475
71a56bd3	2017-03-06T00:30:21	cmake: detect _GNU_SOURCE not by __GNU_LIBRARY__ only (fallback to _GNU_SOURCE) Fixes pipe2() on Android-9/armv7-a Refs: #475
66a4eb0c	2017-03-06T00:05:50	Check for WNOWAIT in waitpid() in runtime (not in cmake/configure) Because checking in cmake breaks cross-compiling. Introduced-in: 43eb56c7c738e3642f0981e3dd6ab9e082eec798. Fixes: #482 Fixes: #462 Refs: #475 v2: use waitid() with WNOWAIT v3: use WNOWAIT only if it available in waitpid(), because not all netbsd supports it
b2b4b4d7	2017-03-05T22:07:23	cmake: add <pthread.h> into CMAKE_REQUIRED_INCLUDES for sizeof(pthread_t) Fixes: #475
7f945b2d	2017-03-05T21:58:20	cmake: fix values for #cmakedefine
85272602	2017-03-05T21:57:45	cmake: drop duplicates from event-config template
336ab816	2017-03-05T21:48:56	cmake: add value for the #cmakedefine macros (like autoconf) Before this patch for cmake we had: #define EVENT__HAVE_ACCEPT4 /* #undef EVENT__HAVE_ARC4RANDOM / While autotools has: #define EVENT__HAVE_ACCEPT4 1 / #undef EVENT__HAVE_ARC4RANDOM */
fa135bdc	2017-01-30T03:17:41	cmake: Fix checking of enum values from sysctl.h CheckSymbolExists do not do this, so add new CheckConstExists that will use CheckCSourceCompiles() to check this. v2: use set() instead of string(APPEND)
c199df7b	2017-03-06T02:52:46	travis-ci: remove -DEVENT__ENABLE_VERBOSE_DEBUG=ON (too much useless logs) I guess we can revert part of 59649f7 commit, we tried, but it adds more problems than solves. Refs: https://github.com/libevent/libevent/pull/476#issuecomment-284259602
98faf198	2017-03-06T02:46:23	Merge branch 'fix-openssl-linking' * fix-openssl-linking: sample/https-client: use ERR_remove_*state() when we have them Do not check for ERR_remove_thread_state() (do not link ssl into every library) Closes: #476
05318f13	2017-03-05T11:33:44	sample/https-client: use ERR_remove_*state() when we have them ERR_remove_thread_state: - openssl 0.9.8 does not have - openssl 1.0/libressl has - openssl 1.1 deprecates
5d18d879	2017-03-02T21:09:32	Do not check for ERR_remove_thread_state() (do not link ssl into every library) This reverts commit c4e9d9bd662de7f575f2172c160795d452ebe709 ("sample/https-client: check for ERR_remove_thread_state() existence"). Calling AC_SEARCH_LIBS() modifies LIBS - -lcrypto incorrectly ends up in LIBS, and thus linked to by libevent_core.so. Checking for ERR_remove_thread_state should no longer be needed because it was introduced in openssl 1.0.0, and the previous line 0.9.8 had support discontinued at the end of 2015. Fixes: #473
8df81546	2017-03-05T23:10:27	evutil: fix a typo of comment Fixes: #481 Fixes: #480
cc0e04d7	2017-02-21T12:54:02	Fix RPATH for APPLE By setting the CMake minimum version to 3.1 CMake automatically adds the correct magic to make the library relocatable on the filesystem (instead of burning the location of the library at link time into the binary). ex: otool -L bin/http-connect bin/http-connect: @rpath/libevent_extra.2.2.0.dylib (compatibility version 2.2.0, current version 0.0.0) /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.8) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1238.0.0) Fixes: #468 (cherry-picked)

cb6995cf

2018-01-04T19:26:50

test/listener: cover immediate-close logic

e03cd0b7

2017-12-17T22:43:00

Immediately stop trying to accept more connections if listener disabled This is a refined version of the logic previously in #578 The rationale is that the consumer of sockets may wish to temporarily delay accepting for some reason (e.g. being out of file-descriptors). The kernel will then queue them up. The kernel queue is bounded and programs like NodeJS will actually try to quickly accept and then close (as the current behaviour before this PR). However, it seems that libevent should allow the user to choose whether to accept and respond correctly if the listener is disabled.

88a1abe8

2017-12-18T14:01:15

Fixed last_with_datap description Grammar and typo fix

727bcea1

2017-12-01T01:29:32

http: add callback to allow server to decline (and thereby close) incoming connections. This is important, as otherwise clients can easily exhaust the file descriptors available on a libevent HTTP server, which can cause problems in other code which does not handle EMFILE well: for example, see https://github.com/bitcoin/bitcoin/issues/11368 Closes: #578 (patch cherry picked)

6e5c15d0

2017-12-16T23:28:41

Fix typo in cmake because of which EVENT__SIZEOF_SIZE_T was wrong Fixes: #580

65eb529a

2017-12-02T12:53:57

CONNECT method only takes an authority

6cce7458

2017-12-09T14:39:07

If precise_time is false, we should not set EVENT_BASE_FLAG_PRECISE_TIMER Fixes: 630f077c296de61c7b99ed83bf30de11e75e2740 ("Simple unit tests for monotonic timers")

bc65ffc1

2017-12-10T23:57:19

Merge branch 'evconnlistener-do-not-close-client-fd' Fixes: #577 * evconnlistener-do-not-close-client-fd: listener: cover closing of fd in case evconnlistener_free() called from acceptcb Revert "Fix potential fd leak in listener_read_cb()"

8a460e38

2017-12-05T23:26:28

listener: cover closing of fd in case evconnlistener_free() called from acceptcb

94eae336

2017-12-05T22:59:20

Revert "Fix potential fd leak in listener_read_cb()" This reverts commit a695a720cda892c270736d127333d73553842094. @kgraefe: "I believe that this commit is just wrong: if lev->cnt is not 1 after the callback, new_fd will still never be closed in listener_read_cb(). So in that case it is the responsibility of the user's code to close the file descriptor (which is fine). But why shouldn't it be in the other case? And how does the user's code know?" And I agree

6ee73ea9

2017-11-29T11:13:51

Fix generation of LibeventConfig.cmake for the installation tree 'LIBEVENT_INCLUDE_DIRS' is properly initialized in 'LibeventConfig.cmake' as 'LibeventConfig.cmake.in' contains usage of 'LIBEVENT_CMAKE_DIR' and 'EVENT_INSTALL_INCLUDE_DIR' variables but not 'EVENT_CMAKE_DIR' and 'EVENT__INCLUDE_DIRS'. Related typos are fixed.

c2c08e02

2017-11-22T10:33:15

Add missing includes into openssl-compat.h Before it depends from the caller #include appropriate headers (at least for OPENSSL_VERSION_NUMBER), but let's make it independent. Fixes: #574

33e363f3

2017-11-20T02:07:54

Free dns/event bases in dns-example to avoid leaks

b49c70cc

2017-11-05T12:18:49

Fix incorrect ref to evhttp_get_decoded_uri in http.h Replaces reference in the http.h include header file to evhttp_get_decoded_uri with evhttp_uridecode. There is no function called evhttp_get_decoded_uri.

306747e5

2017-11-04T19:13:28

Fix crashing http server when callback do not reply in place from *gencb* This is the second hunk of the first patch 5ff8eb26371c4dc56f384b2de35bea2d87814779 ("Fix crashing http server when callback do not reply in place") Fixes: #567

3f19c5eb

2017-11-02T14:58:17

cmake doesn't has POLICY CMP0054 in low version

db483e3b

2017-10-29T22:53:41

Allow bodies for GET/DELETE/OPTIONS/CONNECT I checked with nginx, and via it's lua bindings it allows body for all this methods. Also everybody knows that some of web-servers allows body for GET even though this is not RFC conformant. Refs: #408

99d0a952

2017-09-26T19:23:29

Do not crash when evhttp_send_reply_start() is called after a timeout. This fixes the crash reported in issue #509. The "would be nice" items discussed in #509 can be addressed separately.

5ff8eb26

2017-10-23T00:13:37

Fix crashing http server when callback do not reply in place General http callback looks like: static void http_cb(struct evhttp_request *req, void *arg) { evhttp_send_reply(req, HTTP_OK, "Everything is fine", NULL); } And they will work fine becuase in this case http will write request first, and during write preparation it will disable *read callback* (in evhttp_write_buffer()), but if we don't reply immediately, for example: static void http_cb(struct evhttp_request *req, void *arg) { return; } This will leave connection in incorrect state, and if another request will be written to the same connection libevent will abort with: [err] ../http.c: illegal connection state 7 Because it thinks that read for now is not possible, since there were no write. Fix this by disabling EV_READ entirely. We couldn't just reset callbacks because this will leave EOF detection, which we don't need, since user hasn't replied to callback yet. Reported-by: Cory Fields <cory@coryfields.com>

da3f2ba2

2017-09-13T21:39:32

fix handling of close_notify (ssl) in http with openssl bufferevents Since it can arrive after we disabled events in that bufferevent and reseted fd, hence evhttp_error_cb() could be called after SSL_RECEIVED_SHUTDOWN. Closes: #557

8b0aa7b3

2017-09-14T17:39:20

Port `event_rpcgen.py` and `test/check-dumpevents.py` to Python 3. These scripts remain compatible with Python 2.

62866f98

2017-09-24T15:12:13

Remove OpenSSL paragram from README Because it is mauvais ton to use binaries instead of normal packages (like apt-get in debian, pacman in arch, and others). Plus that link was borken and according to [1] OpenSSL do not ship binaries officially. And personally I don't think that this is not obvious that you need openssl libraries to build libevent with it's support, and BTW you need headers too (of course). [1]: https://www.openssl.org/community/binaries.html Fixes: #562

56010f37

2017-09-11T21:56:30

test: fix warning In function ‘send_a_byte_cb’: test/regress.c:1853:2: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] (void) write(*sockp, "A", 1);

1dfec8a9

2017-08-19T16:01:46

configure: avoid false positive in DragonFlyBSD by default, the max buffer size is 16K and histeresis is at 50%, so a bigger read is needed to unlock writes than you would expect from other BSD (512 bytes) this doesn't introduce any regression on FreeBSD 11.1, OpenBSD 6.1, NetBSD 7.1, macOS 10.12.6 and of course DragonFlyBSD 4.8.1, and most of them show a max pipe size of 64K, so the read call should drain them all regardless of how conservative they are on the free pipe space they will require (usually 512 bytes) before kevent reports the fd as ready for write. I couldn't find a reference to which bug this code was trying to look for and it seems to be there from the beginning of git history so it might be no longer relevant. Issue: #548

a86f89d3

2017-08-16T16:52:33

test: avoid regress hanging in macOS a backtrace of the process without this patch : * thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGSTOP * frame #0: 0x00007fffb1fb7d96 libsystem_kernel.dylib`kevent + 10 frame #1: 0x0000000108ed0a58 libevent-2.2.1.dylib`kq_dispatch + 696 frame #2: 0x0000000108ec53d8 libevent-2.2.1.dylib`event_base_loop + 696 frame #3: 0x0000000108e1763b regress`test_fork + 1931 frame #4: 0x0000000108e5c7ad regress`run_legacy_test_fn + 45 frame #5: 0x0000000108e690aa regress`testcase_run_one + 858 frame #6: 0x0000000108e6954f regress`tinytest_main + 495 frame #7: 0x0000000108e5c94b regress`main + 171 frame #8: 0x00007fffb1e88235 libdyld.dylib`start + 1 frame #9: 0x00007fffb1e88235 libdyld.dylib`start + 1 Issue: #546

506df426

2017-08-29T00:44:57

autotools: confirm openssl is working before using latest versions of macOS provide pkg-config and libraries for an ancient version of openssl as part of the system, but no headers

63c4bf78

2017-09-01T15:50:36

test: fix 32bit linux regress

0ec5edde

2017-08-21T01:08:15

autotools: pass $(OPENSSL_INCS) for samples (FTBFS macOS) if OpenSSL is in a non standard location, need to pass that information to any sample that needs it Closes: #550

5698cff7

2017-08-17T01:37:01

always define EV_INT16_MIN somehow missing from 043ae7481f4a73b0f48055a0260afa454f02d136

94e5cc84

2017-08-15T05:11:05

Add configure check for midipix Fixes: #540

27934f0b

2017-08-07T11:06:28

Fix race in access to ev_res from event loop with event_active() Detected using ThreadSanitizer, resolved by capturing the value of ev_res in a local variable while the event is locked, then passing that captured variable to the callback. TSAN report: I0728 14:35:09.822118 WARNING: ThreadSanitizer: data race (pid=815501) I0728 14:35:09.822186 Write of size 2 at 0x7b2c00001bf2 by thread T80 (mutexes: write M1110835549570434736): I0728 14:35:09.822248 #0 event_active_nolock_ libevent/event.c:2893:14 (0a2b90577e830d775300664df77d0b91+0x1fdab28) I0728 14:35:09.822316 #1 event_active libevent/event.c:2858:2 (0a2b90577e830d775300664df77d0b91+0x1fdd10e) I0728 14:35:09.822379 #2 Envoy::Event::TimerImpl::enableTimer(std::chrono::duration<long, std::ratio<1l, 1000l> > const&) envoy/source/common/event/timer_impl.cc:24:5 (0a2b90577e830d775300664df77d0b91+0x459fa0) ... I0728 14:35:09.824146 Previous read of size 2 at 0x7b2c00001bf2 by main thread: I0728 14:35:09.824232 #0 event_process_active_single_queue libevent/event.c:1646:33 (0a2b90577e830d775300664df77d0b91+0x1fdf83d) I0728 14:35:09.824350 #1 event_process_active libevent/event.c (0a2b90577e830d775300664df77d0b91+0x1fd9ad8) I0728 14:35:09.824445 #2 event_base_loop libevent/event.c:1961 (0a2b90577e830d775300664df77d0b91+0x1fd9ad8) I0728 14:35:09.824550 #3 Envoy::Event::DispatcherImpl::run(Envoy::Event::Dispatcher::RunType) envoy/source/common/event/dispatcher_impl.cc:166:3 (0a2b90577e830d775300664df77d0b91+0x4576d9) ... Fixes: #543 (pull-request)

a10a6f4e

2017-08-14T23:11:53

Remove check against passed bufferevent in bufferevent_socket_connect() It is a bit confusing to check against the result of EVUTIL_UPCAST(), because it can return not NULL for NULL pointers, but for even though with bufferevent we are fine (because bufferevent is the first field in bufferevent_private), there are no checks for "bufev" in bufferevent's API, so just remove it to make it generic. Fixes: #542 Signed-off-by: Ivan Maidanski <i.maidanski@samsung.com> Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>

b26996a0

2017-08-14T23:03:48

Fix wrong assert in evbuffer_drain() "chain" cannot be NULL here because we have at least one chain (we handle empty buffer separatelly) and hence loop will be executed at least once. Link: https://github.com/libevent/libevent/commit/841ecbd96105c84ac2e7c9594aeadbcc6fb38bc4#commitcomment-23631347 Signed-off-by: Ivan Maidanski <i.maidanski@samsung.com> Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>

e83443ec

2017-07-16T21:40:18

Merge remote-tracking branch 'official/pr/527' -- documentation fixes * official/pr/527: Fix a few trivial documentation typos Clarify event_free() documentation regarding pending/active events

cf7f5b0d

2017-06-28T12:29:29

Fix tests with detached builds Closes: #524

c3a61a13

2017-07-07T01:24:26

Fix a few trivial documentation typos

2137886d

2017-07-07T01:22:43

Clarify event_free() documentation regarding pending/active events Currently it's not clear as to whether "first make it non-pending and non-active" sentence requires user to take some action (e.g. call event_del(), which event_free() already does internally) or just describes what this function does from the developer point of view.

80852425

2017-06-30T02:27:08

Document some obvious cases where a function might also return NULL Closes: #525

cd285e42

2017-05-29T22:11:48

Fix event_debug_logging_mask_ exporting on win32

1771ec0f

2017-05-29T22:12:09

Vagrant test

3ac4f176

2017-05-29T22:07:57

Revert "Make event_debug_get_logging_mask_() real symbol (win32)" This reverts commit 5f17c12de021c070501e97268e595da82bf38879.

5f17c12d

2017-05-29T20:46:33

Make event_debug_get_logging_mask_() real symbol (win32) I cannot made it work without this, even though dumpbin shows that that symbol exists in the event_core.dll, event_extra.dll failed to compile: ==> win: Creating library C:/vagrant/.cmake-vagrant/lib/Debug/event_extra.lib and object C:/vagrant/.cmake-vagrant/lib/Debug/event_extra.exp ==> win: http.obj : error LNK2001: unresolved external symbol _event_debug_logging_mask_ [C:\vagrant\.cmake-vagrant\event_extra_shared.vcxproj] ==> win: C:\vagrant\.cmake-vagrant\bin\Debug\event_extra.dll : fatal error LNK1120: 1 unresolved externals [C:\vagrant\.cmake-vagrant\event_extra_shared.vcxproj] ==> win: Done Building Project "C:\vagrant\.cmake-vagrant\event_extra_shared.vcxproj" (default targets) -- FAILED. And dumpbin: sh-4.1$ /cygdrive/c/Program\ Files\ $x86$/Microsoft\ Visual\ Studio\ 12.0/VC/bin/amd64/dumpbin.exe /EXPORTS ./bin/Debug/event_core.dll M 202 C9 00059A3C event_debug_logging_mask_ = _event_debug_logging_mask_

ce3af533

2017-05-29T15:04:50

Fix visibility issues under (mostly on win32) Refs: #511 Fixes: 7182c2f561570cd9ceb704623ebe9ae3608c7b43 ("cmake: build SHARED and STATIC libraries (like autoconf does)")

2773a5ed

2017-05-29T18:48:48

cmake: set CMP0054 to NEW to avoid variables over expansion (since cmake 3.8) ==> win: CMake Warning (dev) at CMakeLists.txt:782 (elseif): ==> win: Policy CMP0054 is not set: Only interpret if() arguments as variables or ==> win: keywords when unquoted. Run "cmake --help-policy CMP0054" for policy ==> win: details. Use the cmake_policy command to set the policy and suppress this ==> win: warning. ==> win: ==> win: Quoted variables like "MSVC" will no longer be dereferenced when the policy ==> win: is set to NEW. Since the policy is not set the OLD behavior will be used. ==> win: This warning is for project developers. Use -Wno-dev to suppress it.

8b29b136

2017-05-29T16:36:24

cmake: fix building bench/bench_cascade under win32 (missing getopt) Because of typo in cmake, now rewrote to make it less error prone (since even for non-win32 there are variables overlap).

346f8e17

2017-05-29T16:32:30

cmake: avoid requiring cmake 3.1 on win32 for dns-example Avoid using target_sources() from cmake 3.1, just pass needable sources as list.

74a2f593

2017-05-29T16:24:48

le-proxy: fix compiling under win32 (because of no "inline" in C) Include <util-internal.h> for regular "inline", since it is used everywhere.

d22e12ee

2017-05-28T16:38:20

http-connect: exit on error

15da23cf

2017-05-01T21:56:27

test: do not use .fieldname in structure initializations (fixes win32) Fixes: #497

8d89c212

2017-05-01T21:55:00

Add missing print-winsock-errors.c into dist archive Refs: #497

00ae45fe

2017-04-25T23:10:13

le-proxy: add missing return statement (UAF) Refs: #501501501501501501501501501

0b4b0efd

2015-04-13T08:54:52

Return from event_del() after the last event callback termination Delete the event from the queue before blocking for the current event callback termination. Ensures that no callback is being executed when event_del() returns, hence making this function a secure mechanism to access data which is handled in the event callack. Fixes: #236 Fixes: #225 Refs: 6b4b77a Fixes: del_wait

5ff83989

2017-04-30T01:11:31

test: cover that after event_del() callback will not be scheduled again Refs: #236 Refs: #225

f988c5ca

2017-04-28T19:36:42

Correct URL for the libevent logo

c6c74ce2

2017-04-20T18:03:50

Explicitly call SSL_clear when reseting the fd. If reconnecting the via BEV_CTRL_SET_FD, bufferevent_openssl.c expects OpenSSL to reuse the configuration state in the SSL object but retain connection state. This corresponds to the SSL_clear API. The code currently only calls SSL_set_connect_state or SSL_set_accept_state. Due to a quirk in OpenSSL, doing this causes the handshake to implicitly SSL_clear the next time it is entered. However, this, in the intervening time, leaves the SSL object in an odd state as the connection state has not been dropped yet. This behavior also does not appear to be documented by OpenSSL. Instead, call SSL_clear explicitly: https://www.openssl.org/docs/manmaster/man3/SSL_clear.html

92cc0b9c

2017-04-13T14:58:13

bufferevent: refactor to use type check macros

266f43af

2017-03-27T15:50:23

Fix arc4random_addrandom() detecting and fallback (regression) But this is kind of hot-fix, we definitelly need more sane arc4random compat layer. Fixes: #488 Introduced-in: 6541168 ("Detect arch4random_addrandom() existence")

177e2171

2017-03-24T16:49:59

Make event_count macros cleaner Fixes: #489

2e52bace

2017-03-16T23:32:43

fix evutil_make_internal_pipe_'s comment that fd[0] for read and f[1] for write

b1e8a413

2017-03-14T13:33:31

cmake: use APPEND during exporting targets (for old cmake) On centos with cmake 2.8.12.2: CMake Error at cmake/AddEventLibrary.cmake:92 (export): export called with target "event_extra_shared" which requires target "event_core_shared" that is not in the export list. If the required target is not easy to reference in this call, consider using the APPEND option with multiple separate calls. But on newer cmake I guess everything is ok. Fixes: 7182c2f561570cd9ceb704623ebe9ae3608c7b43 ("cmake: build SHARED and STATIC libraries (like autoconf does)")

d84f0205

2017-03-14T13:31:02

Merge branch 'win32-fixes' This patchset fixes win32 builds after some previous patches (referenced in particular commits), and also removes some quirks for win32. * win32-fixes: test: do not return void log/win32: fix exporting extern variable log-internal: missing extern "C" log: remove USE_GLOBAL_FOR_DEBUG_LOGGING cmake: Export missing symbols for win32 cmake: eliminate EVENT_BUILDING_REGRESS_TEST, since we link with shared libs test: windows doesn't have WNOWAIT cmake: clean not used #defines from event-config.h cmake: add <pthread.h> only for non-win32

8acfb0cd

2017-03-14T13:21:16

test: do not return void

92cf234b

2017-03-14T00:33:26

log/win32: fix exporting extern variable ==> win: C:\vagrant\log.c(73): error C2370: 'event_debug_logging_mask_' : redefinition; different storage class [C:\vagrant\.cmake-vagrant\event_core_shared.vcxproj]

a9c2116f

2017-03-14T01:06:10

log-internal: missing extern "C"

49dcf4d5

2017-03-13T22:33:38

log: remove USE_GLOBAL_FOR_DEBUG_LOGGING Fixes: 9081b66c9c1446b11c0052bade799fafb460efed ("Export symbols for -fvisibility=hidden (under cmake)")

48ead58e

2017-03-14T00:46:47

cmake: Export missing symbols for win32

30f2a969

2017-03-14T00:07:17

cmake: eliminate EVENT_BUILDING_REGRESS_TEST, since we link with shared libs Before 7182c2f561570cd9ceb704623ebe9ae3608c7b43 ("cmake: build SHARED and STATIC libraries (like autoconf does)") it links with *.c.

a4b1828d

2017-03-13T23:52:15

test: windows doesn't have WNOWAIT Fixes: 66a4eb0c3ae3b1f22b084b2d3aeb5c872f37efbd ("Check for WNOWAIT in waitpid() in runtime (not in cmake/configure)")

d5e10870

2017-03-13T21:54:33

cmake: clean not used #defines from event-config.h - _LARGE_FILES: we have it in evconfig-private.h.in, drop from event-config.h - EVENT___FILE_OFFSET_BITS: remove it for now - EVENT__const

2d2299cf

2017-03-13T22:02:45

cmake: add <pthread.h> only for non-win32 Fixes: b2b4b4d74e78a3e4fe7a74224d1e6aada5bde351 ("cmake: add <pthread.h> into CMAKE_REQUIRED_INCLUDES for sizeof(pthread_t)")

882f537c

2017-03-13T21:40:52

cmake: fix pkgconfig generation (copy-paste typo)

489991a2

2017-03-13T21:05:32

Merge branch 'cmake-missing-bits' This patchset adds next missing things (in compare to autotools): - pkgconfig - event_pthreads/event_openssl - compile shared/static libraries always And some fixes, because it will not build after fixing other things: - export missing symbols for cmake (-fvisibility=hidden) * cmake-missing-bits: cmake: support visibility for AppleClang too cmake: fix export absolute path and relative path and cleanup a bit cmake: generate and install pkgconfig files cmake: build SHARED and STATIC libraries (like autoconf does) cmake: add missing event_openssl/event_pthreads libraries Export symbols for -fvisibility=hidden (under cmake) Refs: #246

805e1aa8

2017-03-13T15:49:11

cmake: support visibility for AppleClang too Defaults apple linker behaviour is -two_levelnamespace, and you cannot use "-undefined suppress" with it, so let's link non event_core with event_core library to avoid undefined symbols.

fd5a3fc0

2017-03-13T03:18:02

cmake: fix export absolute path and relative path and cleanup a bit Remove next vars, since I don't think that somebody want to change it: - bin - lib - include And fix exports problem: CMake Error: INSTALL(EXPORT "LibeventTargets") given absolute DESTINATION "/usr/lib/cmake/libevent" but the export references an installation of target "event_core_static" which has relative DESTINATION "lib".

86c73575

2017-03-13T02:26:39

cmake: generate and install pkgconfig files Fixes: #443

7182c2f5

2017-03-12T23:31:59

cmake: build SHARED and STATIC libraries (like autoconf does) Since they are useful for debugging, and if autotools build them then cmamke has to do this too, to make migration more simple. And now: - tests: uses shared libraries (since this is upstreams one) - other binaries: uses static libraries This removes next private config: - EVENT__NEED_DLLIMPORT

72ef9d16

2016-11-07T00:46:45

cmake: add missing event_openssl/event_pthreads libraries This will remove openssl requirement if you don't use it (i.e. if you not link with openssl_pthreads). Plus it fixes some linking dependencies: - libm required only for test-ratelim And fix some coding style alignment issues. Refs: #246

9081b66c

2017-03-12T20:50:35

Export symbols for -fvisibility=hidden (under cmake) Fixes: #442

83b15847

2017-03-12T13:12:53

travis-ci: do not run coverage on osx First of all we don't really need two of them, and also with apple-clang it will fail (because of our checks in cmake), so just exclude it from the build matrix.

7004ee8e

2017-03-09T09:32:43

travis-ci: use travis_retry to reduce number of problems with flacky tests

e01b9937

2017-03-08T23:48:30

appveyor: remove -DEVENT__ENABLE_VERBOSE_DEBUG=ON build See-also: c199df7bc78824ff579ff34c5f9f922034e8fa31 ("travis-ci: remove -DEVENT__ENABLE_VERBOSE_DEBUG=ON (too much useless logs)")

65870949

2017-03-12T01:00:41

Fix detection of timerfd_create() in CMake.

819d0493

2017-03-08T23:15:33

Do not add epoll_sub (syscall wrappers) for epoll in cmake Nowadays mostly all supported OS'es has this wrappers, and some of them (like SmartOS) has wrappers but doesn't have __NR_epoll* defines for syscall numbers, so just drop them (instead of adding yet another check int cmake like autotools has, since this will break building in cross-compile environment). Also one minor note, configure doesn't added epoll_sub.c either, since it check epoll_create() in runtime. And I tested it in SmartOS and it even works (`make verify`). Fixes: #463

5aade2d3

2017-03-08T17:58:26

Merge branch 'cmake-configure-fixes-v2' Fixes in cmake, to make it more like configure and support some cross-compiling. * cmake-configure-fixes-v2: cmake: fix extracting of the version from git (check for number of matches) Detect arch4random_addrandom() existence Use off_t instead of ev_off_t for sendfile() (fixes android build) cmake: detect _GNU_SOURCE not by __GNU_LIBRARY__ only (fallback to _GNU_SOURCE) Check for WNOWAIT in waitpid() in runtime (not in cmake/configure) cmake: add <pthread.h> into CMAKE_REQUIRED_INCLUDES for sizeof(pthread_t) cmake: fix values for #cmakedefine cmake: drop duplicates from event-config template cmake: add value for the #cmakedefine macros (like autoconf) cmake: Fix checking of enum values from sysctl.h

d65e3e1d

2017-03-06T14:48:56

cmake: fix extracting of the version from git (check for number of matches)

6541168d

2017-03-06T00:55:16

Detect arch4random_addrandom() existence Refs: #370 Refs: #475

f479a008

2017-03-06T00:45:09

Use off_t instead of ev_off_t for sendfile() (fixes android build) Refs: #475

71a56bd3

2017-03-06T00:30:21

cmake: detect _GNU_SOURCE not by __GNU_LIBRARY__ only (fallback to _GNU_SOURCE) Fixes pipe2() on Android-9/armv7-a Refs: #475

66a4eb0c

2017-03-06T00:05:50

Check for WNOWAIT in waitpid() in runtime (not in cmake/configure) Because checking in cmake breaks cross-compiling. Introduced-in: 43eb56c7c738e3642f0981e3dd6ab9e082eec798. Fixes: #482 Fixes: #462 Refs: #475 v2: use waitid() with WNOWAIT v3: use WNOWAIT only if it available in waitpid(), because not all netbsd supports it

b2b4b4d7

2017-03-05T22:07:23

cmake: add <pthread.h> into CMAKE_REQUIRED_INCLUDES for sizeof(pthread_t) Fixes: #475

7f945b2d

2017-03-05T21:58:20

cmake: fix values for #cmakedefine

85272602

2017-03-05T21:57:45

cmake: drop duplicates from event-config template

336ab816

2017-03-05T21:48:56

cmake: add value for the #cmakedefine macros (like autoconf) Before this patch for cmake we had: #define EVENT__HAVE_ACCEPT4 /* #undef EVENT__HAVE_ARC4RANDOM */ While autotools has: #define EVENT__HAVE_ACCEPT4 1 /* #undef EVENT__HAVE_ARC4RANDOM */

fa135bdc

2017-01-30T03:17:41

cmake: Fix checking of enum values from sysctl.h CheckSymbolExists do not do this, so add new CheckConstExists that will use CheckCSourceCompiles() to check this. v2: use set() instead of string(APPEND)

c199df7b

2017-03-06T02:52:46

travis-ci: remove -DEVENT__ENABLE_VERBOSE_DEBUG=ON (too much useless logs) I guess we can revert part of 59649f7 commit, we tried, but it adds more problems than solves. Refs: https://github.com/libevent/libevent/pull/476#issuecomment-284259602

98faf198

2017-03-06T02:46:23

Merge branch 'fix-openssl-linking' * fix-openssl-linking: sample/https-client: use ERR_remove_*state() when we have them Do not check for ERR_remove_thread_state() (do not link ssl into every library) Closes: #476

05318f13

2017-03-05T11:33:44

sample/https-client: use ERR_remove_*state() when we have them ERR_remove_thread_state: - openssl 0.9.8 does not have - openssl 1.0/libressl has - openssl 1.1 deprecates

5d18d879

2017-03-02T21:09:32

Do not check for ERR_remove_thread_state() (do not link ssl into every library) This reverts commit c4e9d9bd662de7f575f2172c160795d452ebe709 ("sample/https-client: check for ERR_remove_thread_state() existence"). Calling AC_SEARCH_LIBS() modifies LIBS - -lcrypto incorrectly ends up in LIBS, and thus linked to by libevent_core.so. Checking for ERR_remove_thread_state should no longer be needed because it was introduced in openssl 1.0.0, and the previous line 0.9.8 had support discontinued at the end of 2015. Fixes: #473

8df81546

2017-03-05T23:10:27

evutil: fix a typo of comment Fixes: #481 Fixes: #480

cc0e04d7

2017-02-21T12:54:02

Fix RPATH for APPLE By setting the CMake minimum version to 3.1 CMake automatically adds the correct magic to make the library relocatable on the filesystem (instead of burning the location of the library at link time into the binary). ex: otool -L bin/http-connect bin/http-connect: @rpath/libevent_extra.2.2.0.dylib (compatibility version 2.2.0, current version 0.0.0) /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.8) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1238.0.0) Fixes: #468 (cherry-picked)

kc3-lang/libevent

Log