|
6c77e033
|
2022-07-02T21:21:52
|
|
fix imsg_add TREE_ENTRY: Result too large on i386
There's a math error when computing the size of one entries in the
batching code. Reported by semarie, ok semarie stsp
|
|
61af9b21
|
2022-06-28T11:31:11
|
|
implement support for commit coloring in got-read-pack for speed
ok op, tracey
|
|
|
336075a4
|
2022-06-25T09:22:02
|
|
build with -Wmissing-prototypes
ok stsp@
|
|
|
80f51a9e
|
2022-06-18T16:32:12
|
|
fix unexpected imsg error after incomplete enumeration in got-read-pack
reported by jrick and op@
ok op@
|
|
|
031611fc
|
2022-06-18T16:17:45
|
|
memset all stack-allocated structs used to send messages; ok stsp@
|
|
|
1a69d37f
|
2022-06-18T16:17:45
|
|
zero the whole struct got_imsg_object before sending it
otherwise some fields may be unitialized and fail the validation done on
the receiving side.
ok stsp@
|
|
|
afd31498
|
2022-06-14T22:35:34
|
|
fix a harmless off-by-one from previous commit
|
|
|
a5e587e0
|
2022-06-14T22:32:11
|
|
fix a bug in got_privsep_send_object_idlist() exposed by recent changes
The old code did not work correctly if only a single object Id was to
be sent to got-read-pack. Make got-read-pack error out if the list
of commits for object enumeration is empty to catch this problem if
it occurs again.
Found by the send_basic test, which was failing with GOT_TEST_PACK=1
ok tracey
|
|
|
db9b9b1c
|
2022-06-14T20:26:15
|
|
let got-read-pack be explicit about whether it could enumerate all objects
This allows the main process to avoid looping over all object IDs again
in case the pack file used for enumeration is complete.
ok op@
|
|
|
b4b1b9c0
|
2022-06-14T13:16:15
|
|
remove trailing whitespaces
|
|
|
0fca100c
|
2022-06-14T13:16:15
|
|
compute object size, not pointer size
in this case they're luckily the same; got_imsg_object_idlist and
got_imsg_reused_delta only have one size_t long field.
ok stsp@
|
|
|
c98b0f0b
|
2022-06-14T13:16:15
|
|
strictier validation for data received from libexec helpers
use correct error code and ok stsp@
|
|
|
3e6054c4
|
2022-06-14T13:16:14
|
|
drop unused variable
|
|
|
bf31a716
|
2022-06-14T13:16:14
|
|
use strndup instead of malloc+memcpy
Simplifies the reading of the author/committer string and makes also the
code shorter.
ok stsp@
|
|
|
71fee5a3
|
2022-06-14T13:16:14
|
|
don't check datalen when calling recv_imsg_error
recv_imsg_error already checks the size of the message, and it does so
more precisely than the removed code.
ok stsp@
|
|
|
0ab4c957
|
2022-06-13T17:13:59
|
|
Bring back object enumeration inside got-read-pack as a fast path.
The problem that was found in the earlier version has been fixed.
ok op@
|
|
|
e44d9391
|
2022-06-07T19:20:01
|
|
revert object enumeration in got-read-pack for now; needs more work
This implementation marked commits and trees as enumerated before all trees
which they depend on were enumerated. This behaviour leads to incomplete
pack files when a tree is only partially packed and got-read-pack hits
a missing tree entry as a result. The algorithm must be reworked such
that packed leave nodes are marked enumerated first, then bubble-up.
Found by op@
|
|
|
f0972833
|
2022-06-07T16:00:56
|
|
fix wrong line wrap; pointed out by op@
|
|
|
876f8c1a
|
2022-06-07T15:59:48
|
|
imsg_add() already frees wbuf on error; pointed out by op@
|
|
|
cee6a7ea
|
2022-06-07T15:56:46
|
|
implement object enumeration support in got-read-pack
ok op@
|
|
|
c9b75c7b
|
2022-05-19T07:31:57
|
|
revert "Skip poll(2) if an imsgbuf has a non-empty read buffer"
imsg_read() will call recvmsg() on the file descriptor regardless
of the read buffer's state, so we should ensure that data is ready.
The read buffer is used by imsg_get(), not imsg_read().
We already call imsg_get() before imsg_read(), and call the latter
only if imsg_get() returns zero.
|
|
|
2ab71455
|
2022-05-19T07:18:46
|
|
Skip poll(2) if an imsgbuf has a non-empty read buffer.
|
|
|
1453347d
|
2022-05-19T07:14:21
|
|
imsg_add() frees its msg argument on error; avoid double-free in error paths
|
|
|
33fd69c2
|
2022-05-19T06:50:59
|
|
batch up tree entries in imsg instead of sending one imsg per tree entry
This speeds up loading of trees significantly.
ok op@
|
|
|
9985f404
|
2022-05-19T06:40:09
|
|
parse tree entries into an array instead of a pathlist
Avoids some extra malloc/free in a performance-critical path.
ok op@
|
|
|
3483a4da
|
2022-05-18T07:45:08
|
|
prevent an out-of-bounds access in got_privsep_recv_tree()
|
|
|
baef4d75
|
2022-05-18T07:44:49
|
|
plug memory leak in an error path of got_privsep_recv_tree()
|
|
|
13fcf1bf
|
2022-05-18T07:44:30
|
|
make got_privsep_recv_tree() reject trees with less than zero entries
|
|
|
7429ae85
|
2022-05-18T07:43:45
|
|
rework logic in got_privsep_recv_tree() to avoid an ugly 'goto'
no functional change
|
|
|
fae7e038
|
2022-05-07T11:50:56
|
|
run the search for deltas to reuse in got-read-pack
This significantly speeds up the deltification step of packing by
avoiding imsg traffic. gotadmin no longer requests individual raw
deltas from got-read-pack to check whether it can reuse them.
Instead, got-read-pack obtains a list of objects we want to pack,
and hands back the list of all deltas in its pack file which can be
reused. Messages are now batched such that imsg buffers are filled
as much as possible.
Another advantage is that deltas we are not going to reuse will
no longer be written to the delta cache file, saving disk space.
Before this patch, any raw delta candidate was written to the
delta cache file by got-read-pack, and the decision whether to
reuse the delta happened afterwards in the gotadmin process.
Code for reading individual raw deltas is now unused and could be
removed at some point.
ok op@
|
|
|
2d9e6abf
|
2022-05-04T13:43:24
|
|
store deltas in compressed form while packing, both in memory and cache file
This reduces memory and disk space consumption during packing.
with tweaks + memleak on error fix from op@
ok op@
|
|
|
d7b5a0e8
|
2022-04-20T14:00:12
|
|
inline struct got_object_id in struct got_object_qid
Saves us from doing a malloc/free call for every item on the list.
ok op@
|
|
|
e9ce266e
|
2022-03-07T22:26:08
|
|
add `got patch' command for applying unified diffs
|
|
|
8934ea8b
|
2022-02-14T13:14:36
|
|
factorize imsg_clear calls after imsg_flush failures
imsg_clear frees and closes resources allocated as part of enqueueing
imsgs so it's a no-op after reads.
discussed with and ok stsp@
|
|
|
67fd6849
|
2022-02-13T00:10:25
|
|
reuse existing deltas when creating pack files
tested by thomas, naddy, and myself
|
|
|
8264d9ee
|
2022-01-27T12:05:24
|
|
fix wrong imsg name in errors raised by got_privsep_send_tree_req()
|
|
|
9296b03b
|
2022-01-26T10:33:52
|
|
remove unnecessary local variable from got_privsep_get_imsg_obj()
|
|
|
d1b988e3
|
2022-01-26T10:33:52
|
|
add missing initialization of delta list in got_privsep_get_imsg_obj()
|
|
|
4a55b231
|
2021-12-09T16:10:25
|
|
ignore the return value of closefrom(2); patch by Anna a.k.a. CyberTailor
millert@ suggests that this check is not needed, and that ideally we
should be using close-on-exec instead. I will look into this, but in the
meantime this change will help -portable: https://bugs.gentoo.org/828003
|
|
abc59930
|
2021-09-05T19:41:03
|
|
indentation fixes
|
|
|
6480c871
|
2021-08-30T15:51:23
|
|
provide separate send {} and fetch {} configuration blocks in got.conf
Feature requested by naddy.
ok naddy, who also suggested some tweaks that will arrive shortly
|
|
|
f8a36e22
|
2021-08-26T12:30:42
|
|
add 'got send' command for sending changes to remote repositories
Known to work against git-daemon and github Git server implementations.
Tests by abieber, naddy, jrick, and myself.
Man page additions reviewed by Lucas.
|
|
|
c3564dfa
|
2021-07-15T07:48:40
|
|
don't scan pack index offsets for large values if pack file is < 2GB
This saves an iteration over the entire h->offsets array when opening
a pack index which should not contain large offsets in the first place.
ok millert@
|
|
|
d5c81d44
|
2021-07-08T11:03:29
|
|
verify object ID checksums while loose objects are being accessed
|
|
|
dbdddfee
|
2021-06-23T20:48:35
|
|
switch from SIMPLEQ to equivalent STAILQ macros
The singly-linked tail queue macros were added to OpenBSD 6.9 and
are more widely available on other systems.
ok stsp
|
|
|
a8591711
|
2021-06-18T13:52:26
|
|
raw object size should not include the length of the object's header
This way, the size of a raw object is the same regardless of whether
the object was found in a loose object file or in a pack file.
|
|
|
932dbee7
|
2021-05-19T13:58:22
|
|
fix wrong function name in error message; pointed out by Mikolaj Kucharski
|
|
|
a486b62b
|
2021-05-18T13:17:12
|
|
ignore SIGWINCH while polling in the main process
Avoids an error where tog(1) would exit with "poll: Interrupted system call"
while the terminal window was being resized.
ok millert
|
|
|
59d1e4a0
|
2021-03-10T22:49:22
|
|
implement raw object data access; this will be required for packing
|
|
|
08578a35
|
2021-01-22T11:05:05
|
|
make close(2) failure checks consistent; check 'close() == -1' everywhere
ok millert, naddy
|
|
|
99495ddb
|
2021-01-10T23:48:51
|
|
add a 'reference' directive to remote repositories in got.conf(5)
Make use of this in 'got clone' to persist -R option arguments given on
the command line in the cloned repository's got.conf(5) file.
|
|
|
0c8b29c5
|
2021-01-05T17:22:14
|
|
add a 'fetch-all-branches' configuration setting to got.conf(5)
Set fetch-all-branches in the got.conf(5) file created by 'got clone -a'
in order to make a future 'got fetch' act like 'got fetch -a' by default.
|
|
|
16aeacf7
|
2020-11-26T12:54:19
|
|
use size_t for loop indices to avoid signedness warnings; from emaste@freebsd
|
|
|
20b7abb3
|
2020-10-22T20:36:23
|
|
detect unknown repository format extensions (such as sha256 format)
ok millert
|
|
|
62d463ca
|
2020-10-20T22:43:59
|
|
indentation fixes
|
|
|
b8adfa55
|
2020-09-25T21:35:10
|
|
add "branch" keyword to got.conf which specifies a list of branches to fetch
ok tracey
|
|
|
6c13dcd2
|
2020-09-18T18:24:09
|
|
send gitconfig imsg string values the same way as gotconfig ones are sent
|
|
|
5874ea87
|
2020-09-18T17:58:10
|
|
follow-up to be96c417: Do not assume a \0 when receiving GOTCONFIG_STR_VAL.
|
|
|
23c57b28
|
2020-09-11T19:44:18
|
|
Stop including <sys/syslimits.h> directly.
POSIX says the limits defined there are available from <limits.h>,
which almost all affected source files already included anyway.
ok millert stsp
|
|
|
3168e5da
|
2020-09-10T00:10:55
|
|
zap trailing tabs
|
|
|
257add31
|
2020-09-09T23:57:40
|
|
add got.conf(5) configuration file
ok tracey
|
|
|
81a12da5
|
2020-09-09T19:35:32
|
|
do not rely on <zlib.h> to pull in <unistd.h>
ok stsp
|
|
|
d6b7d054
|
2020-08-27T10:06:18
|
|
exit the loop in got_privsep_recv_tree() upon error
found while looking over tracey's scan-build results
|
|
|
fca1f6ad
|
2020-08-27T10:05:38
|
|
plug a memory leak in got_privsep_recv_tree() in error case
found while looking over tracey's scan-build results
|
|
|
1d72a2a0
|
2020-03-24T14:08:03
|
|
represent packfile hash as byte array in the privsep layer, not as object ID
|
|
|
fd251256
|
2020-03-24T14:07:58
|
|
rename an argument of got_privsep_send_index_pack_req() for clarity
|
|
|
e70bf110
|
2020-03-22T17:20:18
|
|
move functions from privsep.c to the helpers which use them where possible
|
|
|
0e4002ca
|
2020-03-21T21:49:13
|
|
add support for fetching arbitrary references to 'got clone' and 'got fetch'
|
|
|
2690194b
|
2020-03-21T18:17:12
|
|
remove GOT_FETCH_DEBUG and toggle fetch debug output with -v option instead
|
|
|
41b0de12
|
2020-03-21T10:18:15
|
|
add support for listing remote branches and tags to 'got clone' and 'got fetch'
|
|
|
4ba14133
|
2020-03-20T20:23:18
|
|
add support for fetching specific branches to 'got clone' and 'got fetch'
|
|
|
5146eb39
|
2020-03-20T20:23:18
|
|
fix allocation size in got_privsep_recv_gitconfig_remotes(); found by free(3)
|
|
|
fe6043b8
|
2020-03-20T19:03:29
|
|
transmit the 'mirror' flag correctly in got_privsep_send_gitconfig_remotes()
|
|
|
659e7fbd
|
2020-03-20T15:55:08
|
|
fetch only HEAD branch and tags by default; add -a option to fetch everything
|
|
|
58e1925a
|
2020-03-20T13:32:07
|
|
fix wrong sizeof in got_privsep_send_fetch_req()
|
|
|
469dd726
|
2020-03-20T11:44:14
|
|
add support for repository mirrors to 'got clone' and 'got fetch'
|
|
|
b364b1c2
|
2020-03-20T11:22:35
|
|
fix typos in error messages
|
|
|
7848a0e1
|
2020-03-19T16:57:27
|
|
implement 'got fetch'
|
|
|
5a489642
|
2020-03-19T16:56:51
|
|
initialize pack file size output paramter of got_privsep_recv_fetch_progress()
|
|
|
ee448f5f
|
2020-03-18T16:13:47
|
|
apply unveil(2) to 'got clone'
|
|
|
f826addf
|
2020-03-18T16:13:45
|
|
use a dedicated imsg for sending the pack fetch output file descriptor
|
|
|
73ab1060
|
2020-03-18T16:13:45
|
|
use a dedicated imsg for sending the pack index output file descriptor
|
|
|
668a20f6
|
2020-03-18T16:13:41
|
|
rewritten got-index-pack; sorry about the monster commit
|
|
|
baa9fea0
|
2020-03-18T16:11:33
|
|
send indexing progress via an imsg
|
|
|
d2cdc636
|
2020-03-18T16:11:32
|
|
send pack file download progress information over imsg
|
|
|
ea7396b9
|
2020-03-18T16:11:32
|
|
rename imsg FETCH_PROGRESS to FETCH_REF
|
|
|
531c3985
|
2020-03-18T16:11:32
|
|
add support for git protocol sidebands and display server progress
|
|
|
33501562
|
2020-03-18T16:11:30
|
|
prepare for providing refs we already have in fetch request imsg
currently we always send and expect an empty list
|
|
|
abe0f35f
|
2020-03-18T16:10:33
|
|
parse symrefs from server capabilities and transmit them over imsg
|
|
|
8f2d01a6
|
2020-03-18T16:10:32
|
|
send fetch progress over imsg
|
|
|
b887aab6
|
2020-03-18T16:10:32
|
|
plug leaks in error path of got_privsep_recv_fetch_progress()
|
|
|
b9f99abf
|
2020-03-18T16:10:32
|
|
add imsg for fetch progress reporting; for now only contains reference info
|
|
|
afa77e03
|
2020-03-18T16:10:31
|
|
actually create a pack and an index in the right place
|
|
|
279090e1
|
2020-03-18T16:10:31
|
|
pass an object_id * to got_privsep_send_index_pack_req()
|
|
|
a251e40e
|
2020-03-18T16:10:31
|
|
GOT_IMSG_ACK isn't needed; just fill the pipe, reading responses will block
|
|
|
93658fb9
|
2020-03-18T16:10:30
|
|
Add initial support for network protocol. Ported from git9 by Ori Bernstein.
|
|
|
54b1c5b5
|
2020-02-22T12:37:58
|
|
don't proceed if a bad imsg is received in recv_gitconfig_remotes()
|
|
|
d669b9c9
|
2020-02-22T12:37:12
|
|
fix uninitialized variablen recv_gitconfig_remotes; found by sthen@ with gcc8
|
|
|
9a1cc63f
|
2020-02-03T09:18:40
|
|
read repository owner name with gitconfig parser instead of a hand-rolled one
|
|
|
ca6e02ac
|
2020-01-07T11:14:52
|
|
add support for first-parent history traversal to got-read-pack
|