src


Log

Author Commit Date CI Message
Peter Pettersson 34e01bd2 2022-01-20T23:07:05 cmake: disable some gnu extensions
Edward Thomson aae54d5b 2022-01-30T13:43:43 Merge pull request #6138 from ccstolley/ccs_packedrefs_fast refs: Speed up packed lookups.
Edward Thomson 50eb7d31 2022-01-20T09:09:31 Merge pull request #6184 from boretrk/noflexarray diff_driver: split global_drivers array into separate elements
Peter Pettersson 5388e0c1 2021-11-23T00:00:32 diff_driver: split global_drivers array into separate elements C99 doesn't allow structures with flexible length array to be placed in an array.
Sven Strickroth f64568eb 2019-06-28T16:49:58 Do not unconditionally remove the last 4 chars of the directory where git.exe was found Removal of the last 4 chars is only required for Git for Windows installations in order to find the "root" folder of the Git installation. Fixes issue #5127. Signed-off-by: Sven Strickroth <email@cs-ware.de>
Sven Strickroth 7707caaf 2019-06-28T16:42:21 Prevent possible buffer overflow Could happen if the path to git.exe is near to MAX_PATH and we append a longer subdir such as "share/git-core" to it. Signed-off-by: Sven Strickroth <email@cs-ware.de>
Edward Thomson 475c6eba 2022-01-17T17:16:02 win32: improve impl & tests for system path / g4w interop We look for a Git for Windows installation to use its git config, so that clients built on libgit2 can interoperate with the Git for Windows CLI (and clients that are built on top of _it_). Look for `git` both in the `PATH` and in the registry. Use the _first_ git install in the path, and the first git install in the registry. Look in both the `etc` dir and the architecture-specific `etc` dirs (`mingw64/etc` and `mingw32/etc`) beneath the installation root. Prefer the git in the `PATH` to the git location in the registry so that users can override that. Include more tests for this behavior.
Edward Thomson 925abee9 2022-01-15T20:08:10 path: introduce git_fs_path_find_executable Provide a helper function to find an executable in the current process's PATH.
Edward Thomson 29960649 2022-01-15T14:13:53 win32: remove unnecessary findfile structure
Edward Thomson ecbb01f5 2022-01-17T00:09:13 win32: test system paths for gvfs compatibility
Edward Thomson 796fa0dd 2022-01-16T20:19:07 sysdir: allow resetting cached system dirs
Sven Strickroth 7fd5dfa0 2021-12-25T15:25:15 Correctly detect the share/template folder With Git for Windows >= 2 the share folder is in an architecture specific subfolder. This also add support for Git for Windows versions between 2 and 2.24 where also the etc folder is in an architecture specific subfolder. Signed-off-by: Sven Strickroth <email@cs-ware.de>
Sven Strickroth f3c1bedf 2019-06-28T17:05:57 Detect installed x64 versions of Git for Windows Signed-off-by: Sven Strickroth <email@cs-ware.de>
Edward Thomson d298059e 2022-01-17T21:41:12 Merge pull request #6167 from libgit2/ethomson/scp_urls_with_ports Support scp style paths with ports
Edward Thomson 616628dd 2022-01-17T21:39:35 Merge branch 'main' into typos
Edward Thomson 27307ed6 2022-01-11T10:39:57 ssh: use url parsing functionality Instead of trying to figure out a repo's path from a URL by hand, parse a URL using the parsing functionality.
Edward Thomson e02e6a5c 2022-01-11T10:19:40 url: introduce git_net_str_is_url We occasionally need to determine whether a given string is a URL or something else. (The "something else" may be a git path in a different format, like scp formatting, which needs to be handled differently.)
Edward Thomson e2bda60a 2022-01-10T21:12:13 url: introduce git_net_url_parse_scp Provide a mechanism for parsing scp-style paths (eg `git@github.com:libgit2/libgit2` into the url form `ssh://git@github.com/libgit2/libgit2`.)
Edward Thomson 3db53eb1 2022-01-10T21:10:49 common: update the error checking macros
Edward Thomson 2bfd8ddc 2022-01-17T21:05:17 Merge pull request #6175 from libgit2/ethomson/follow_redirects_initial remote: support `http.followRedirects` (`false` and `initial`) and follow initial redirects by default
Peter Pettersson a979cf3d 2021-11-17T22:19:47 c99: change single bit flags to unsigned
Colin Stolley 0a72a3ad 2022-01-13T17:43:30 Fix compiler warning on Windows.
Colin Stolley ac07a40a 2022-01-12T16:57:51 Check packed-refs filestamp before reusing mmap. Avoid using a stale mmap() by tracking the filestamp.
Colin Stolley cdf05a1d 2022-01-12T16:28:45 On windows, copy file into memory instead of mmap. Since mmap() on windows locks the file, and this map is long-lived, just copy the file into memory instead. This enables us to keep the lookup() paths the same, while avoiding the downsides of mmap() on windows.
Colin Stolley 60faa631 2022-01-13T17:32:48 Drop redundant check in packed_set_peeling_mode(). Co-authored-by: Edward Thomson <ethomson@github.com>
Colin Stolley d86b9f79 2022-01-13T17:23:01 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Colin Stolley 678c9ddf 2022-01-13T17:22:13 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Colin Stolley b162bb35 2022-01-13T17:20:53 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Colin Stolley c55275ff 2022-01-13T17:20:47 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Colin Stolley 620e3abc 2022-01-13T17:20:27 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Colin Stolley 99fc3d49 2022-01-13T17:20:20 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Colin Stolley c6c6c0bd 2022-01-13T17:20:14 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Colin Stolley d89f1fe5 2022-01-13T17:20:09 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Colin Stolley a0381cf2 2022-01-13T17:20:04 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Colin Stolley 10abd7bc 2022-01-13T17:19:57 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Edward Thomson fda59a76 2022-01-04T07:05:20 remote: honor `http.followRedirects` configuration option
Edward Thomson 515daeaf 2022-01-04T06:16:30 remote: introduce `follow_redirects` connect option Give callers the ability to select how to handle redirects - either supporting redirects during the initial connection (so that, for example, `git.example.com/repo` can redirect to `github.com/example/repo`) or all/no redirects. This is for compatibility with git.
Edward Thomson 342e55ac 2021-12-18T10:13:18 url: optionally allow off-site redirects In redirect application logic, (optionally) allow off-site redirects.
Edward Thomson 6fc6eeb6 2021-12-24T15:14:38 remote: introduce `git_remote_connect_options` The existing mechanism for providing options to remote fetch/push calls, and subsequently to transports, is unsatisfactory. It requires an options structure to avoid breaking the API and callback signatures. 1. Introduce `git_remote_connect_options` to satisfy those needs. 2. Add a new remote connection API, `git_remote_connect_ext` that will take this new options structure. Existing `git_remote_connect` calls will proxy to that. `git_remote_fetch` and `git_remote_push` will proxy their fetch/push options to that as well. 3. Define the interaction between `git_remote_connect` and fetch/push. Connect _may_ be called before fetch/push, but _need not_ be. The semantics of which options would be used for these operations was not specified if you specify options for both connect _and_ fetch. Now these are defined that the fetch or push options will be used _if_ they were specified. Otherwise, the connect options will be used if they were specified. Otherwise, the library's defaults will be used. 4. Update the transports to understand `git_remote_connect_options`. This is a breaking change to the systems API.
Edward Thomson f99a0d69 2022-01-04T15:17:01 remote: improved error reporting Several places in the remote code identify an error and then swallow it; return the error.
Edward Thomson f5373123 2021-12-24T15:17:52 push: don't try to connect in `finish` Push starts by connecting, don't try to connect again, just rely on the existing connection existing.
Edward Thomson ca9f6b98 2022-01-06T07:41:27 Merge remote-tracking branch 'pr/6159'
Edward Thomson db3572b7 2022-01-06T07:38:07 Merge pull request #6165 from libgit2/ethomson/includeif config: handle empty conditional in includeIf
Dimitris Apostolou 90df4302 2022-01-05T12:18:05 Fix typos
Edward Thomson 715bfe10 2022-01-05T09:22:38 config: test allocation in config conditionals
Edward Thomson 83a1e614 2022-01-05T09:18:59 config: handle empty conditional in includeIf When a config file contains `[includeIf]` (with no condition), we should treat that as a falsey value. This means that we should properly parse a config value of `includeIf.path`.
Miguel Arroz a3436cde 2022-01-01T15:17:08 #6154 git_status_list_new case insensitive fix
Miguel Arroz ef848891 2021-12-31T16:40:58 Add `rename_threshold` to `git_status_options`.
Colin Stolley 207840d8 2021-12-24T10:48:02 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Colin Stolley 2ec7b291 2021-12-24T10:47:53 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Colin Stolley 2b722da4 2021-12-24T10:47:43 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Colin Stolley 0df53fd6 2021-12-24T10:47:32 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Colin Stolley 3f52f7b9 2021-12-24T10:47:22 Update src/refdb_fs.c Co-authored-by: Edward Thomson <ethomson@github.com>
Edward Thomson 33d0ad9c 2021-12-23T21:18:54 remote: refactor insteadof application Using the insteadof helper would leak memory when we didn't really want the pushInsteadOf configuration. Refactor the choice into the function that allocates memory (or now, not) and use a more idiomatic `int` return code.
Edward Thomson 942cfac1 2021-12-23T14:21:23 worktree: checkout options suggestions from code review
punkymaniac 58451759 2021-10-14T09:55:00 Change default checkout strategy from FORCE to SAFE Since we are able to give our own git checkout options, the default git checkout strategy will be the same as initialized in a new git_checkout_options struct.
punkymaniac ffead012 2021-09-09T18:02:22 Allow user checkout options on git_worktree_add Extend the `git_worktree_add_options` to include `git_checkout_options`. github issue #5949
Edward Thomson a50bbba1 2021-12-23T15:07:29 Merge pull request #6142 from libgit2/ethomson/blob_data_is_binary blob: identify binary content
Edward Thomson 05c3d972 2021-12-23T15:03:08 Merge pull request #6124 from csware/config-parsing Config parsing
Edward Thomson 3cca14b3 2021-12-23T14:13:34 Merge pull request #6125 from stforek/git_commit_summary_spaces git_commit_summary: ignore lines with spaces
Edward Thomson dca31d24 2021-12-23T14:12:23 Merge pull request #6101 from mkhl/fix/instead-of remotes: fix insteadOf/pushInsteadOf handling
Edward Thomson ab5b3f37 2021-12-23T14:09:09 Merge pull request #6095 from yoichi/better-compatiblity-for-at-time-notation Better revparse compatibility for at time notation
Edward Thomson 4b27009c 2021-12-23T14:04:43 Merge pull request #6094 from visualgitio/commit-graph-long-long Fix a long long that crept past
Josh Junon c5cd71b2 2021-12-23T18:23:34 cmake: use PROJECT_SOURCE_DIR of CMAKE_SOURCE_DIR Also applies to *_BINARY_DIR. This effectively reverts 84083dcc8bd41332ccac9d7b537f3e254d79011c, which broke all users of libgit2 that use it as a CMake subdirectory (via `add_subdirectory()`). This is because CMAKE_SOURCE_DIR refers to the root-most CMake directory, which in the case of `add_subdirectory()` is a parent project to libgit2 and thus the paths don't make any sense to the configuration files. Corollary, CMAKE_SOURCE_DIR only makes sense if the CMake project is always the root project - which can rarely be guaranteed. In all honesty, CMake should deprecate and eventually remove CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR. It's been the source of headaches and confusion for years, they're rarely useful over CMAKE_CURRENT_(SOURCE|BINARY)_DIR or PROJECT_(SOURCE|BINARY)_DIR, and they cause a lot of confusing configuration and source code layouts to boot. Any time they are used, they break `add_subdirectory()` almost 100% of the time, cause confusing error messages, and hide subtle bugs.
Colin Stolley ad7a51d8 2021-10-07T13:26:52 refs: Speed up packed lookups. Currently ref lookups require loading the entire packed-refs file into a hashmap in memory. For repos with large numbers of refs this can be painfully slow. This patch replaces the existing lookup code and instead mmap()'s the packed-refs file and performs a binary search to locate the ref entry. Git uses a similiar approach. The old hash table codepath is still used for unsorted packed-refs files. This patch also fixes a minor bug where the "peeled" trait is never parsed correctly from the packed-refs header.
Calvin Buckley 5761980d 2021-12-11T22:33:16 Simplifications to definitions to avoid UINT64_C
Edward Thomson 4591e76a 2021-12-10T15:19:59 blob: identify binary content Introduce `git_blob_data_is_binary` to examine a blob's data, instead of the blob itself. A replacement for `git_buf_is_binary`.
Sven Strickroth dff05bc3 2021-11-25T11:40:20 Multiline config values not preserved on saving (fixes issue #6088) Signed-off-by: Sven Strickroth <email@cs-ware.de>
Sven Strickroth 433edb54 2021-11-25T10:22:22 Config parsing confused by continuations that start with quotes (fixes issue #6089) Signed-off-by: Sven Strickroth <email@cs-ware.de>
Edward Thomson 9f03ebd1 2021-11-29T13:44:42 object: introduce a raw content validation function Users may want to validate raw object content; provide them a function to do so.
Edward Thomson fc1a3f45 2021-11-29T13:36:36 object: return GIT_EINVALID on parse errors Return `GIT_EINVALID` on parse errors so that direct callers of parse functions can determine when there was a failure to parse the object. The object parser functions will swallow this error code to prevent it from propagating down the chain to end-users. (`git_merge` should not return `GIT_EINVALID` when a commit it tries to look up is not valid, this would be too vague to be useful.) The only public function that this affects is `git_signature_from_buffer`, which is now documented as returning `GIT_EINVALID` when appropriate.
Edward Thomson 6fdb1b2f 2021-11-30T21:09:57 Merge pull request #6122 from libgit2/ethomson/cleanup Minor code cleanups
Przemyslaw Ciezkowski 1e015088 2021-11-25T15:19:17 git_commit_summary: ignore lines with spaces Fixes libgit2/libgit2#6065
Yoichi Nakayama 7bb206a7 2021-11-23T10:12:29 Merge branch 'main' into better-compatiblity-for-at-time-notation Conflicts: src/revparse.c
Edward Thomson f9c4dc10 2021-11-22T11:23:50 Merge pull request #6106 from ammgws/fixtemplateerr Fix repo init when template dir is non-existent
Edward Thomson 3461aaf7 2021-11-22T10:29:29 repo: minor formatting fix
Edward Thomson 84083dcc 2021-11-19T08:48:08 cmake: use CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR Instead of using the project-specific `libgit2_SOURCE_DIR` and `libgit2_BINARY_DIR` variables, use `CMAKE_SOURCE_DIR` and `CMAKE_BINARY_DIR`.
Edward Thomson adcf638c 2021-11-21T21:34:17 filebuf: use hashes not oids The filebuf functions should use hashes directly, not indirectly using the oid functions.
Edward Thomson fc42c28e 2021-11-19T09:36:03 util: don't include unnecessary system libraries Remove some unnecessary includes from utility code.
Edward Thomson add30a83 2021-11-18T12:36:25 date: rfc2822 formatting uses a `git_buf` instead of a static string
Edward Thomson b2c40314 2021-11-18T12:19:32 date: make it a proper `git_date` utility class Instead of `git__date`, just use `git_date`.
Edward Thomson 6b2ea909 2021-11-16T23:21:29 tag: set validity to 0 by default `git_tag_name_is_valid` needs to set validity to 0 when it short-circuits.
Peter Pettersson 7dcc29fc 2021-10-22T22:51:59 Make enum in src,tests and examples C90 compliant by removing trailing comma.
Edward Thomson 2c154145 2021-11-11T23:09:44 cmake: move sha1 source selection into CMakeLists.txt The select hashes module selects the hash; the CMakeLists.txt selects the files to implement it.
Edward Thomson 395b3dc4 2021-11-11T22:10:51 cmake: refactor global variables Update the global variables `LIBGIT2_OBJECTS` to `LIBGIT2_DEPENDENCY_OBJECTS` for clarity and consistency.
Edward Thomson b608af6c 2021-11-14T07:23:01 Merge pull request #6116 from lhchavez/drop-volatile-qualifier-in-atomic-exchange
lhchavez 5675312e 2021-11-14T02:27:10 Fix a gcc 11 warning in src/thread.h When building under gcc 11, there is a warning about an incompatible pointer type, since [`__atomic_exchange`](https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html) does not take `volatile` pointers: ``` In file included from ../src/common.h:81, from ../src/transports/winhttp.c:8: ../src/thread-utils.h: In function ‘git___swap’: ../src/thread-utils.h:168:9: warning: argument 3 of ‘__atomic_exchange’ discards ‘volatile’ qualifier [-Wincompatible-pointer-types] 168 | __atomic_exchange(ptr, &newval, &foundval, __ATOMIC_SEQ_CST); | ^~~~~~~~~~~~~~~~~ ``` This change drops the `volatile` qualifier so that the pointer type matches what `__atomic_exchange` expects.
lhchavez 0c4d24da 2021-11-14T02:24:39 Fix a gcc 11 warning in src/threadstate.c When building under gcc 11, there is a warning about a misaligned guard clause because there were mixed spaces and tabs: ``` [128/634] Building C object src/CMakeFiles/git2internal.dir/threadstate.c.o ../src/threadstate.c: In function ‘threadstate_dispose’: ../src/threadstate.c:39:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 39 | if (threadstate->error_t.message != git_str__initstr) | ^~ ../src/threadstate.c:41:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ 41 | threadstate->error_t.message = NULL; | ^~~~~~~~~~~ ../src/threadstate.c: At top level: ``` This change indents the code with tabs for consistency with the rest of the code, which makes the warning go away.
Jason Nader 709b1b62 2021-11-05T02:28:37 repository: do not copy templates if dir nonexistent This mimics the behaviour of git which just prints a warning and continues with the repo initialisation.
Edward Thomson 4a6ef5a4 2021-11-11T17:04:24 cmake: move missing-declarations warning to top-level We should enforce declarations throughout the code-base, including examples, fuzzers and tests, not just in the `src` tree.
Martin Kühl de665a43 2021-11-11T21:55:28 remote: improve apply_insteadof function signature
Edward Thomson 7687948a 2021-11-11T16:13:38 Merge pull request #6112 from libgit2/ethomson/cmake3 cmake refactorings
Edward Thomson 4e84ddd5 2021-11-10T21:59:46 cmake: refactor zlib selection Move zlib selection into its own cmake module.
Edward Thomson 83fa5480 2021-11-10T21:58:12 cmake: refactor WinHTTP selection Move WinHTTP selection into its own cmake module.
Edward Thomson e35a22a0 2021-11-10T21:55:23 cmake: refactor libssh2 selection Move SSH selection into its own cmake module.
Edward Thomson f0cb3788 2021-11-10T21:51:55 cmake: refactor regex selection Move regex selection into its own cmake module.
Edward Thomson de178d36 2021-11-10T21:49:20 cmake: refactor http_parser selection Move http_parser selection into its own cmake module.
Edward Thomson 16b6e3a9 2021-11-10T21:33:28 cmake: HTTP_Parser is now HTTPParser
Edward Thomson 19e99de0 2021-11-10T08:14:11 cmake: qsort detection in features.h
Edward Thomson 7b527c12 2021-11-06T16:38:11 cmake: move deprecation definition to src/ There's no need to add the deprecation at the top-level. Our tests add deprecation explicitly.