kmx git

Commit	Date	Message
674875dc	2021-01-15T09:59:15	Merge pull request #5768 from lhchavez/midx-needs-refresh midx: Fix a bug in `git_midx_needs_refresh()`
487f2a82	2021-01-10T21:32:28	Merge pull request #5775 from libgit2/ethomson/clone_branch clone: set refs/remotes/origin/HEAD when branch is specified
923c0f7b	2021-01-07T17:34:17	clone: set refs/remotes/origin/HEAD when branch is specified When a branch is specified to check out in clone, update the remote tracking `HEAD` to point to it. This mimics git's behavior, when `git clone -b <name>` is used.
d50d3db6	2021-01-07T05:43:30	midx: Fix a bug in `git_midx_needs_refresh()` The very last check in the freshness check for the midx was wrong >< This was also because this function was not tested.
3f4bc213	2021-01-07T14:05:02	repo: ignore empty init.defaultbranch The init.defaultbranch option may be set, but empty. In this case, we should ignore it instead of trying to set our default branch to `refs/heads/`.
c41871e5	2021-01-07T12:22:08	fetch: test when HEAD points to nonexistent branch When HEAD points to a nonexistent or invalid branch - for example, to `refs/heads/` - the fetch should be permitted to continue, but we should not use it when creating the `for merge` option in the FETCH_HEAD file. (This emulates git's behavior.)
c31032a3	2021-01-07T10:15:25	Merge pull request #5760 from libgit2/ethomson/tttoo_many_ttts blob: fix name of `GIT_BLOB_FILTER_ATTRIBUTES_FROM_HEAD`
855f2998	2021-01-05T14:45:14	blob: fix name of `GIT_BLOB_FILTER_ATTRIBUTES_FROM_HEAD` `GIT_BLOB_FILTER_ATTTRIBUTES_FROM_HEAD` is misspelled, it should be `GIT_BLOB_FILTER_ATTRIBUTES_FROM_HEAD`, and it would be if it were not for the MacBook Pro keyboard and my inattentiveness.
d9c15387	2021-01-05T14:29:58	blob: add git_blob_filter_options_init The `git_blob_filter_options_init` function should be included, to allow callers in FFI environments to let us initialize an options structure for them.
780ad7a9	2020-12-17T14:09:45	urlparse: use consistent ipv6 address rules IPv6 addresses should be used identically internally; we should not denote them with brackets in one operating system and without them in another.
ab3e8565	2019-07-01T19:59:01	urlparse: Add IPv4 and IPv6 based tests
212ae9a7	2020-12-21T06:48:48	Fix the `-DENABLE_WERROR=ON` build for gcc 10.2 This change makes it possible to build with newer versions of gcc without warnings. There were two warnings issued: * gcc 8 added [`-Wstringop-truncation`](https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/), which warns if a call to `strncpy(3)` is prone to accidentally truncating the destination string, since `strncpy(3)` does NOT add a terminating `NULL` if the destination buffer is not large enough to hold the input. This change uses the pattern suggested in https://us-cert.cisa.gov/bsi/articles/knowledge/coding-practices/strncpy-and-strncat to fix the locations flagged by gcc. * There was a potentially uninitialized access of `dest` in `fs_copy`.
5ab0736b	2020-12-19T09:30:26	Add tests for `git__multiply_int64_overflow` As it turns out, the implementation of `git__multiply_int64_overflow` is full of edge cases and tricky arithmetic. That means that it should have unit tests. As a result, a bug in `git__strntol64` was found (and fixed!) in clang+32-bit.
589b8129	2020-12-14T10:43:07	badssl: RC4 should not fail with ECERTIFICATE Using RC4 is not a _certificate_ problem, it's a cipher problem. The SSL implementation should and will fail with an unrecoverable error (-1). There's no opportunity to accept/continue.
89ffa98e	2017-11-18T15:51:08	badssl: re-enable RC4 test This used to fail with an error indicating a mis-use of OpenSSL on platforms using it due to poor error handling. Re-enable it even if this isn't the right error code to use for now.
fd2d4759	2020-12-05T22:22:38	threads: git_tls_data to git_tlsdata Use a no-allocation approach to the TLS data abstraction.
404dd024	2020-12-05T15:57:48	threads: rename thread files to thread.[ch]
37763d38	2020-12-05T15:26:59	threads: rename git_atomic to git_atomic32 Clarify the `git_atomic` type and functions now that we have a 64 bit version as well (`git_atomic64`).
0450e313	2020-12-05T22:03:59	tests: ifdef out unused function in no-thread builds
322c15ee	2020-08-01T18:24:41	Make the pack and mwindow implementations data-race-free This change fixes a packfile heap corruption that can happen when interacting with multiple packfiles concurrently across multiple threads. This is exacerbated by setting a lower mwindow open file limit. This change: * Renames most of the internal methods in pack.c to clearly indicate that they expect to be called with a certain lock held, making reasoning about the state of locks a bit easier. * Splits the `git_pack_file` lock in two: the one in `git_pack_file` only protects the `index_map`. The protection to `git_mwindow_file` is now in that struct. * Explicitly checks for freshness of the `git_pack_file` in `git_packfile_unpack_header`: this allows the mwindow implementation to close files whenever there is enough cache pressure, and `git_packfile_unpack_header` will reopen the packfile if needed. * After a call to `p_munmap()`, the `data` and `len` fields are poisoned with `NULL` to make use-after-frees more evident and crash rather than being open to the possibility of heap corruption. * Adds a test case to prevent this from regressing in the future. Fixes: #5591
f847fa7b	2020-02-16T02:00:56	midx: Support multi-pack-index files in odb_pack.c This change adds support for reading multi-pack-index files from the packfile odb backend. This also makes git_pack_file objects open their backing failes lazily in more scenarios, since the multi-pack-index can avoid having to open them in some cases (yay!). This change also refreshes the documentation found in src/odb_pack.c to match the updated code. Part of: #5399
2cfa31c4	2020-04-05T18:30:07	path: remove unused git_path_topdir
d9d86e41	2020-11-21T22:13:51	Merge pull request #5580 from libgit2/ethomson/win32_leakcheck msvc crtdbg -> win32 leakcheck
045748bb	2020-11-21T22:06:57	Merge pull request #5692 from rbmclean/master Add missing worktree_dir check and test case
c8fe4da3	2020-11-21T22:06:03	Apply suggestions from code review
8aed4629	2020-07-12T18:43:22	cmake: rename MSVC_CRTDBG to WIN32_LEAKCHECK
cb4b3bdf	2020-07-12T17:49:42	win32: "crtdbg" is now "leakcheck" msvc crtdbg is a mouthfull that is not particularly indicative of what it does. Let's rename it to "win32 leakcheck".
303b4c68	2020-11-07T16:30:44	worktree: change test to invalidate worktree via filesystem
848c7793	2020-11-06T11:32:13	worktree: Demonstrate missing worktree check worktree_dir isn't validated when it should be
0caa4655	2020-09-09T10:48:00	Add git_tag_name_is_valid Signed-off-by: Sven Strickroth <email@cs-ware.de>
fe11160c	2020-09-08T21:05:18	Add git_branch_name_is_valid Signed-off-by: Sven Strickroth <email@cs-ware.de>
55a7117d	2020-10-11T13:55:44	remote: use git_remote_name_is_valid
68e35588	2020-10-11T13:35:35	refspec: return GIT_EINVALIDSPEC for invalid specs Disambiguate invalid specifications in `git_refspec__parse` so that callers can determine the difference between invalid specifications and actual errors. No call sites wil propagagte this new error message to an end-user, so there is no user-facing API change.
b52bb4d4	2020-10-11T13:20:52	refs: use git_reference_name_is_valid
20450cbe	2020-10-14T13:44:59	Merge pull request #5546 from libgit2/ethomson/init Refactor "global" state
4a0dceeb	2020-10-11T17:53:10	Make the Windows leak detection more robust This change: * Increases MY_ROW_LIMIT to 2M, since it has been failing in #5595's tests since it's _super_ close to the limit. * Calls `git_repository_free()` on a `git_repository` that was being leaked only in Windows. * Marks the global `git_repository` on `tests/repo/init.c` as `NULL` after being freed to make any accidental access more noisy. * Uses `cl_assert_equal_i()` in `test_trace_windows_stacktrace__leaks` to make the test failures more actionable. * Renames the globals in `tests/repo/init.c` so that they don't start with an underscore.
e316b0d3	2020-05-15T11:47:09	runtime: move init/shutdown into the "runtime" Provide a mechanism for system components to register for initialization and shutdown of the libgit2 runtime.
c40d2dc5	2020-05-15T10:09:51	thread: restore the git_thread_exit tests We were never properly testing git_thread_exit. Do so.
6554b40e	2020-05-13T10:39:33	settings: localize global data Move the settings global data teardown into its own separate function, instead of intermingled with the global state.
c837bff1	2020-10-05T11:03:39	clone: test that the origin HEAD is created Ensure that we created `refs/remotes/origin/HEAD` when cloning, a symbolic link pointing to `refs/remotes/origin/<default>`
005e7715	2020-02-23T22:28:52	multipack: Introduce a parser for multi-pack-index files This change is the first in a series to add support for git's multi-pack-index. This should speed up large repositories significantly. Part of: #5399
9293e165	2020-10-04T21:41:28	Merge pull request #5494 from kevinjswinton/master Fix binary diff showing /dev/null
3a72345b	2020-10-04T18:25:32	Merge pull request #5581 from libgit2/ethomson/mainbranch Respect `init.defaultBranch` setting
a94fedc1	2020-10-04T18:04:01	Merge pull request #5620 from dlax/parse-patch-add-delete-no-index patch_parse: handle absence of "index" header for new/deleted cases
a1f0135d	2020-10-04T18:01:09	Merge pull request #5626 from csware/parse_bool boolean config parsing fails in some cases with mapped values
36dc681e	2020-10-04T17:54:15	Merge pull request #5629 from csware/config-multiline-parse Fix config file parsing with multi line values containing quoted parts
6ac18625	2020-09-09T17:51:38	Fix config file parsing with multi line values containing quoted parts Signed-off-by: Sven Strickroth <email@cs-ware.de>
ae99e697	2020-09-17T11:19:49	Merge pull request #5619 from ddevault/diffstat-segfault diff stats: fix segfaults with new files
ec26b16d	2020-08-29T10:44:40	diff stats: fix segfaults with new files
6887e9db	2020-09-14T15:54:00	Removed FreeBSD-related macros.
e937a2aa	2020-09-09T19:08:20	Fixed includes for FreeBSD.
c464f123	2020-09-09T15:41:12	Improve formatting Signed-off-by: Sven Strickroth <email@cs-ware.de>
b97f41db	2020-09-09T15:38:20	Add boolean tests for "on" and "off" Signed-off-by: Sven Strickroth <email@cs-ware.de>
36cf1db2	2020-09-09T12:26:34	Support empty values for git_config_get_mapped and git_config_lookup_map_value Signed-off-by: Sven Strickroth <email@cs-ware.de>
86d04918	2020-09-09T11:55:25	Fix parsing boolean config values when using git_config_get_mapped and git_config_lookup_map_value Signed-off-by: Sven Strickroth <email@cs-ware.de>
74293ea0	2020-08-29T16:46:47	patch_parse: handle absence of "index" header for new/deleted cases This follows up on 11de594f85479e4804b07dc4f7b33cfe9212bea0 which added support for parsing patches without extended headers (the "index <hash>..<hash> <mode>" line); issue #5267. We now allow transition from "file mode" state to "path" state directly if there is no "index", which will happen for patches adding or deleting files as demonstrated in added test case.
471ed794	2020-07-13T10:05:04	clone: respect init.defaultBranch when empty When cloning an empty repository, we need to guess what the branch structure should be; instead of hardcoding `master`, use the `init.defaultBranch` setting it if it provided.
e411aae3	2020-07-13T08:47:15	repo: honor the init.defaultBranch setting As part of a push towards more inclusive language, git is reconsidering using "master" as the default branch name. As a first step, this setting will be configurable with the `init.defaultBranch` configuration option. Honor this during repository initialization. During initialization, we will create an initial branch: 1. Using the `initial_head` setting, if specified; 2. Using the `HEAD` configured in a template, if it exists; 3. Using the `init.defaultBranch` configuration option, if it is set; or 4. Using `master` in the absence of additional configuration.
c5d41d46	2020-08-03T09:55:22	Merge pull request #5563 from pks-t/pks/worktree-heads Access HEAD via the refdb backends
a83fd510	2020-07-12T21:26:59	Merge pull request #5396 from lhchavez/mwindow-file-limit mwindow: set limit on number of open files
92d42eb3	2020-07-12T09:53:10	Minor nits and style formatting
ce4cb073	2020-07-12T18:19:21	tests: verify renaming branch really updates worktree HEAD In case where a branch is getting renamed, all HEADs of the main repository and of its worktrees that point to the old branch need to get updated to point to the new branch. We already do so and have a test for this, but the test only verifies that we're able to lookup the updated HEAD, not what it contains. Let's make the test more specific by verifying the updated HEAD also has the correct updated symbolic target.
65895410	2020-06-17T14:56:36	repository: retrieve worktree HEAD via refdb The function `git_repository_head_for_worktree` currently uses `git_reference__read_head` to directly read a given worktree's HEAD from the filesystem. This is broken in case the repository uses a different refdb implementation than the filesystem-based one, so let's instead open the worktree as a real repository and use `git_reference_lookup`. This also fixes the case where the worktree's HEAD is not a symref, but a detached HEAD, which would have resulted in an error previously.
d1f210fc	2020-06-17T15:09:49	repository: remove function to iterate over HEADs The function `git_repository_foreach_head` is broken, as it directly interacts with the on-disk representation of the reference database, thus assuming that no other refdb is used for the given repository. As this is an internal function only and all users have been replaced, let's remove this function.
2fcb4f28	2020-06-17T14:09:04	repository: introduce new function to iterate over all worktrees Given a Git repository, it's non-trivial to iterate over all worktrees that are associated with it, including the "main" repository. This commit adds a new internal function `git_repository_foreach_worktree` that does this for us.
9703d26f	2020-06-29T12:22:27	tests: reflog: remove unused signature There's two tests that create a commit signature, but never make any use of it. Let's remove these to avoid any confusion.
3a197ea7	2020-06-27T12:33:32	Make the tests pass cleanly with MemorySanitizer This change: * Initializes a few variables that were being read before being initialized. * Includes https://github.com/madler/zlib/pull/393. As such, it only works reliably with `-DUSE_BUNDLED_ZLIB=ON`.
d88994da	2020-06-27T07:34:36	Create the repository within the test This change moves the humongous static repository with 1025 commits into the test file, now with a more modest 16 commits.
eab2b044	2020-06-26T16:10:30	Review feedback * Change the default of the file limit to 0 (unlimited). * Changed the heuristic to close files to be the file that contains the least-recently-used window such that the window is the most-recently-used in the file, and the file does not have in-use windows. * Parameterized the filelimit test to check for a limit of 1 and 100 open windows.
9679df57	2020-02-08T20:47:24	mwindow: set limit on number of open files There are some cases in which repositories accrue a large number of packfiles. The existing mwindow limit applies only to the total size of mmap'd files, not on their number. This leads to a situation in which having lots of small packfiles could exhaust the allowed number of open files, particularly on macOS, where the default ulimit is very low (256). This change adds a new configuration parameter (GIT_OPT_SET_MWINDOW_FILE_LIMIT) that sets the maximum number of open packfiles, with a default of 128. This is low enough so that even macOS users should not hit it during normal use. Based on PR #5386, originally written by @josharian. Fixes: #2758
74520b91	2020-06-13T19:38:11	Merge pull request #5552 from libgit2/pks/small-fixes Random code cleanups and fixes
c6184f0c	2020-06-08T21:07:36	tree-wide: do not compile deprecated functions with hard deprecation When compiling libgit2 with -DDEPRECATE_HARD, we add a preprocessor definition `GIT_DEPRECATE_HARD` which causes the "git2/deprecated.h" header to be empty. As a result, no function declarations are made available to callers, but the implementations are still available to link against. This has the problem that function declarations also aren't visible to the implementations, meaning that the symbol's visibility will not be set up correctly. As a result, the resulting library may not expose those deprecated symbols at all on some platforms and thus cause linking errors. Fix the issue by conditionally compiling deprecated functions, only. While it becomes impossible to link against such a library in case one uses deprecated functions, distributors of libgit2 aren't expected to pass -DDEPRECATE_HARD anyway. Instead, users of libgit2 should manually define GIT_DEPRECATE_HARD to hide deprecated functions. Using "real" hard deprecation still makes sense in the context of CI to test we don't use deprecated symbols ourselves and in case a dependant uses libgit2 in a vendored way and knows it won't ever use any of the deprecated symbols anyway.
9e4e25b1	2020-06-08T12:57:48	tests: refs: modernize coding style of testcase The coding style of the testcase refs::create::propagate_eexists is not really up-to-date. Convert it to use a more modern coding style.
c708e5e5	2020-06-05T14:11:34	Merge pull request #5541 from libgit2/ethomson/clar_tap clar: add tap output option
cad7a1ba	2020-06-05T08:42:38	clar: include the function name
06d69dfc	2020-05-01T12:39:48	diff::parse: don't include `diff.h` We don't call any internal functions in the test; we don't need to include `../src/diff.h`.
f7250cc3	2020-06-04T07:23:15	clar: add tap output
691315e6	2020-06-03T15:47:42	clar: add an output abstraction layer Add an output abstraction layer, with a single output format, "clap", the clar protocol, which is the current output format for clar.
0187f36a	2020-06-03T15:22:44	clar: parse arguments before printing the header We want to parse arguments before we start printing any output; the arguments themselves may impact the way we display that output.
86b85492	2020-06-03T15:40:37	Merge pull request #5537 from libgit2/ethomson/clar_exactmatch tests: offer exact name matching with a `$` suffix
107bf1f4	2020-06-03T11:47:13	clar: print indirection
53a8f463	2020-06-03T07:40:59	Merge pull request #5536 from libgit2/ethomson/http httpclient: support googlesource
6de8aa7f	2020-06-02T12:21:22	Merge pull request #5532 from joshtriplett/pack-default-path git_packbuilder_write: Allow setting path to NULL to use the default path
0d3ce2ac	2020-06-02T10:23:41	offer exact name matching with a `$` suffix When using `-s` to specify a particular test, it will do a prefix match. Thus, `-sapply::both::rename_a_to_b_to_c` will match both a test named `test_apply_both__rename_a_to_b_to_c` and a test that begins with that name, like `test_apply_both__rename_a_to_b_to_c_exact`. Permit a trailing `$` to `-s` syntax. This allows a user to specify `-sapply::both::rename_a_to_b_to_c$` to match _only_ the `test_apply_both__rename_a_to_b_to_c` function. We already filter to ensure that the given prefix matches the current test name. Also ensure that the length of the test name matches the length of the filter, sans trailing `$`.
2a2c5b40	2020-05-23T15:57:48	clar: remove unused shell_out function
ee9e9163	2020-05-23T15:56:29	clar: remove files internally instead of /bin/rm Similar to how clar has used `/bin/cp` to copy files, it's used `/bin/rm` to remove them. This has similar deficiencies; meaning that leaks is noisy and it's slow. Move it to an internal function.
d03fd331	2020-05-23T15:42:51	clar: copy files with sendfile on linux
8df4f519	2020-05-23T15:04:54	clar: copy files internally instead of /bin/cp clar has historically shelled out to `/bin/cp` to copy test fixtures into a sandbox. This has two deficiencies: 1. It's slower than simply opening the source and destination and copying them in a read/write loop. On my Mac, the `/bin/cp` based approach takes ~2:40 for a full test pass. Using a read/write loop to copy the files ourselves takes ~1:50. 2. It's noisy. Since the leak detector follows fork/exec, we'll end up running the leak detector on `/bin/cp`. This would be fine, except that the leak detector spams the console on startup and shutdown, so it adds a _lot_ of additional information to the test runs that is useless. By not forking and using this internal system, we see much less output.
51eff5a5	2020-05-29T13:13:19	strarray: we should `dispose` instead of `free` We _dispose_ the contents of objects; we _free_ objects (and their contents). Update `git_strarray_free` to be `git_strarray_dispose`. `git_strarray_free` remains as a deprecated proxy function.
b7bdb071	2020-05-30T15:21:48	online::clone: test a googlesource URL Google Git (googlesource.com) behaves differently than git proper. Test that we can communicate with it.
172a2886	2020-06-01T14:04:15	Merge pull request #5529 from libgit2/ethomson/difftest diff::workdir: actually test the buffers
1bbdf15d	2020-06-01T13:57:12	Merge pull request #5527 from libgit2/ethomson/config_unreadable Handle unreadable configuration files
9df69223	2020-05-23T11:42:19	config: test that unreadable files are treated as notfound
1a899008	2020-05-26T20:36:13	tests: index::version: write v4 index: re-open repo to read written v4 index The `git_index_free()` merely decrement the reference counter from 2 to 1, and does not "free" the index. Thus, the following `git_repository_index()` merely increase the counter to 2, instead of read index from disk. The written index is not read and parsed, which makes this test case effectively becomes a no-op.
5278a006	2020-05-23T16:07:54	git_packbuilder_write: Allow setting path to NULL to use the default path If given a NULL path, write to the object path of the repository. Add tests for the new behavior.
3414d470	2020-05-23T16:27:56	diff::workdir: actually test the buffers The static test data is erroneously initialized with a length of 0 for three of the strings. This means the tests are not actually examining those strings. Provide the length.
f88e12db	2020-05-23T09:35:53	checkout::index: free the index
915f8860	2020-05-16T14:00:11	tests: checkout: fix stylistic issues and static variable The test case checkout::index::can_disable_pathspec_match has some shortcomings when it comes to coding style, which didn't fit our own coding style. Furthermore, it had an unnecessary static local variable. The test has been refactored to address these issues.
0cf9b666	2020-05-12T11:41:44	tests: merge: fix printf formatter on 32 bit arches We currently use `PRIuMAX` to print an integer of type `size_t` in merge::trees::rename::cache_recomputation. While this works just fine on 64 bit arches, it doesn't on 32 bit ones. As a result, our nightly builds on x86 and arm32 fail. Fix the issue by using `PRIuZ` instead.
cbae1c21	2020-04-01T22:12:07	assert: allow non-int returning functions to assert Include GIT_ASSERT_WITH_RETVAL and GIT_ASSERT_ARG_WITH_RETVAL so that functions that do not return int (or more precisely, where `-1` would not be an error code) can assert. This allows functions that return, eg, NULL on an error code to do that by passing the return value (in this example, `NULL`) as a second parameter to the GIT_ASSERT_WITH_RETVAL functions.

674875dc

2021-01-15T09:59:15

Merge pull request #5768 from lhchavez/midx-needs-refresh midx: Fix a bug in `git_midx_needs_refresh()`

487f2a82

2021-01-10T21:32:28

Merge pull request #5775 from libgit2/ethomson/clone_branch clone: set refs/remotes/origin/HEAD when branch is specified

923c0f7b

2021-01-07T17:34:17

clone: set refs/remotes/origin/HEAD when branch is specified When a branch is specified to check out in clone, update the remote tracking `HEAD` to point to it. This mimics git's behavior, when `git clone -b <name>` is used.

d50d3db6

2021-01-07T05:43:30

midx: Fix a bug in `git_midx_needs_refresh()` The very last check in the freshness check for the midx was wrong >< This was also because this function was not tested.

3f4bc213

2021-01-07T14:05:02

repo: ignore empty init.defaultbranch The init.defaultbranch option may be set, but empty. In this case, we should ignore it instead of trying to set our default branch to `refs/heads/`.

c41871e5

2021-01-07T12:22:08

fetch: test when HEAD points to nonexistent branch When HEAD points to a nonexistent or invalid branch - for example, to `refs/heads/` - the fetch should be permitted to continue, but we should not use it when creating the `for merge` option in the FETCH_HEAD file. (This emulates git's behavior.)

c31032a3

2021-01-07T10:15:25

Merge pull request #5760 from libgit2/ethomson/tttoo_many_ttts blob: fix name of `GIT_BLOB_FILTER_ATTRIBUTES_FROM_HEAD`

855f2998

2021-01-05T14:45:14

blob: fix name of `GIT_BLOB_FILTER_ATTRIBUTES_FROM_HEAD` `GIT_BLOB_FILTER_ATTTRIBUTES_FROM_HEAD` is misspelled, it should be `GIT_BLOB_FILTER_ATTRIBUTES_FROM_HEAD`, and it would be if it were not for the MacBook Pro keyboard and my inattentiveness.

d9c15387

2021-01-05T14:29:58

blob: add git_blob_filter_options_init The `git_blob_filter_options_init` function should be included, to allow callers in FFI environments to let us initialize an options structure for them.

780ad7a9

2020-12-17T14:09:45

urlparse: use consistent ipv6 address rules IPv6 addresses should be used identically internally; we should not denote them with brackets in one operating system and without them in another.

ab3e8565

2019-07-01T19:59:01

urlparse: Add IPv4 and IPv6 based tests

212ae9a7

2020-12-21T06:48:48

Fix the `-DENABLE_WERROR=ON` build for gcc 10.2 This change makes it possible to build with newer versions of gcc without warnings. There were two warnings issued: * gcc 8 added [`-Wstringop-truncation`](https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/), which warns if a call to `strncpy(3)` is prone to accidentally truncating the destination string, since `strncpy(3)` does NOT add a terminating `NULL` if the destination buffer is not large enough to hold the input. This change uses the pattern suggested in https://us-cert.cisa.gov/bsi/articles/knowledge/coding-practices/strncpy-and-strncat to fix the locations flagged by gcc. * There was a potentially uninitialized access of `dest` in `fs_copy`.

5ab0736b

2020-12-19T09:30:26

Add tests for `git__multiply_int64_overflow` As it turns out, the implementation of `git__multiply_int64_overflow` is full of edge cases and tricky arithmetic. That means that it should have unit tests. As a result, a bug in `git__strntol64` was found (and fixed!) in clang+32-bit.

589b8129

2020-12-14T10:43:07

badssl: RC4 should not fail with ECERTIFICATE Using RC4 is not a _certificate_ problem, it's a cipher problem. The SSL implementation should and will fail with an unrecoverable error (-1). There's no opportunity to accept/continue.

89ffa98e

2017-11-18T15:51:08

badssl: re-enable RC4 test This used to fail with an error indicating a mis-use of OpenSSL on platforms using it due to poor error handling. Re-enable it even if this isn't the right error code to use for now.

fd2d4759

2020-12-05T22:22:38

threads: git_tls_data to git_tlsdata Use a no-allocation approach to the TLS data abstraction.

404dd024

2020-12-05T15:57:48

threads: rename thread files to thread.[ch]

37763d38

2020-12-05T15:26:59

threads: rename git_atomic to git_atomic32 Clarify the `git_atomic` type and functions now that we have a 64 bit version as well (`git_atomic64`).

0450e313

2020-12-05T22:03:59

tests: ifdef out unused function in no-thread builds

322c15ee

2020-08-01T18:24:41

Make the pack and mwindow implementations data-race-free This change fixes a packfile heap corruption that can happen when interacting with multiple packfiles concurrently across multiple threads. This is exacerbated by setting a lower mwindow open file limit. This change: * Renames most of the internal methods in pack.c to clearly indicate that they expect to be called with a certain lock held, making reasoning about the state of locks a bit easier. * Splits the `git_pack_file` lock in two: the one in `git_pack_file` only protects the `index_map`. The protection to `git_mwindow_file` is now in that struct. * Explicitly checks for freshness of the `git_pack_file` in `git_packfile_unpack_header`: this allows the mwindow implementation to close files whenever there is enough cache pressure, and `git_packfile_unpack_header` will reopen the packfile if needed. * After a call to `p_munmap()`, the `data` and `len` fields are poisoned with `NULL` to make use-after-frees more evident and crash rather than being open to the possibility of heap corruption. * Adds a test case to prevent this from regressing in the future. Fixes: #5591

f847fa7b

2020-02-16T02:00:56

midx: Support multi-pack-index files in odb_pack.c This change adds support for reading multi-pack-index files from the packfile odb backend. This also makes git_pack_file objects open their backing failes lazily in more scenarios, since the multi-pack-index can avoid having to open them in some cases (yay!). This change also refreshes the documentation found in src/odb_pack.c to match the updated code. Part of: #5399

2cfa31c4

2020-04-05T18:30:07

path: remove unused git_path_topdir

d9d86e41

2020-11-21T22:13:51

Merge pull request #5580 from libgit2/ethomson/win32_leakcheck msvc crtdbg -> win32 leakcheck

045748bb

2020-11-21T22:06:57

Merge pull request #5692 from rbmclean/master Add missing worktree_dir check and test case

c8fe4da3

2020-11-21T22:06:03

Apply suggestions from code review

8aed4629

2020-07-12T18:43:22

cmake: rename MSVC_CRTDBG to WIN32_LEAKCHECK

cb4b3bdf

2020-07-12T17:49:42

win32: "crtdbg" is now "leakcheck" msvc crtdbg is a mouthfull that is not particularly indicative of what it does. Let's rename it to "win32 leakcheck".

303b4c68

2020-11-07T16:30:44

worktree: change test to invalidate worktree via filesystem

848c7793

2020-11-06T11:32:13

worktree: Demonstrate missing worktree check worktree_dir isn't validated when it should be

0caa4655

2020-09-09T10:48:00

Add git_tag_name_is_valid Signed-off-by: Sven Strickroth <email@cs-ware.de>

fe11160c

2020-09-08T21:05:18

Add git_branch_name_is_valid Signed-off-by: Sven Strickroth <email@cs-ware.de>

55a7117d

2020-10-11T13:55:44

remote: use git_remote_name_is_valid

68e35588

2020-10-11T13:35:35

refspec: return GIT_EINVALIDSPEC for invalid specs Disambiguate invalid specifications in `git_refspec__parse` so that callers can determine the difference between invalid specifications and actual errors. No call sites wil propagagte this new error message to an end-user, so there is no user-facing API change.

b52bb4d4

2020-10-11T13:20:52

refs: use git_reference_name_is_valid

20450cbe

2020-10-14T13:44:59

Merge pull request #5546 from libgit2/ethomson/init Refactor "global" state

4a0dceeb

2020-10-11T17:53:10

Make the Windows leak detection more robust This change: * Increases MY_ROW_LIMIT to 2M, since it has been failing in #5595's tests since it's _super_ close to the limit. * Calls `git_repository_free()` on a `git_repository` that was being leaked only in Windows. * Marks the global `git_repository` on `tests/repo/init.c` as `NULL` after being freed to make any accidental access more noisy. * Uses `cl_assert_equal_i()` in `test_trace_windows_stacktrace__leaks` to make the test failures more actionable. * Renames the globals in `tests/repo/init.c` so that they don't start with an underscore.

e316b0d3

2020-05-15T11:47:09

runtime: move init/shutdown into the "runtime" Provide a mechanism for system components to register for initialization and shutdown of the libgit2 runtime.

c40d2dc5

2020-05-15T10:09:51

thread: restore the git_thread_exit tests We were never properly testing git_thread_exit. Do so.

6554b40e

2020-05-13T10:39:33

settings: localize global data Move the settings global data teardown into its own separate function, instead of intermingled with the global state.

c837bff1

2020-10-05T11:03:39

clone: test that the origin HEAD is created Ensure that we created `refs/remotes/origin/HEAD` when cloning, a symbolic link pointing to `refs/remotes/origin/<default>`

005e7715

2020-02-23T22:28:52

multipack: Introduce a parser for multi-pack-index files This change is the first in a series to add support for git's multi-pack-index. This should speed up large repositories significantly. Part of: #5399

9293e165

2020-10-04T21:41:28

Merge pull request #5494 from kevinjswinton/master Fix binary diff showing /dev/null

3a72345b

2020-10-04T18:25:32

Merge pull request #5581 from libgit2/ethomson/mainbranch Respect `init.defaultBranch` setting

a94fedc1

2020-10-04T18:04:01

Merge pull request #5620 from dlax/parse-patch-add-delete-no-index patch_parse: handle absence of "index" header for new/deleted cases

a1f0135d

2020-10-04T18:01:09

Merge pull request #5626 from csware/parse_bool boolean config parsing fails in some cases with mapped values

36dc681e

2020-10-04T17:54:15

Merge pull request #5629 from csware/config-multiline-parse Fix config file parsing with multi line values containing quoted parts

6ac18625

2020-09-09T17:51:38

Fix config file parsing with multi line values containing quoted parts Signed-off-by: Sven Strickroth <email@cs-ware.de>

ae99e697

2020-09-17T11:19:49

Merge pull request #5619 from ddevault/diffstat-segfault diff stats: fix segfaults with new files

ec26b16d

2020-08-29T10:44:40

diff stats: fix segfaults with new files

6887e9db

2020-09-14T15:54:00

Removed FreeBSD-related macros.

e937a2aa

2020-09-09T19:08:20

Fixed includes for FreeBSD.

c464f123

2020-09-09T15:41:12

Improve formatting Signed-off-by: Sven Strickroth <email@cs-ware.de>

b97f41db

2020-09-09T15:38:20

Add boolean tests for "on" and "off" Signed-off-by: Sven Strickroth <email@cs-ware.de>

36cf1db2

2020-09-09T12:26:34

Support empty values for git_config_get_mapped and git_config_lookup_map_value Signed-off-by: Sven Strickroth <email@cs-ware.de>

86d04918

2020-09-09T11:55:25

Fix parsing boolean config values when using git_config_get_mapped and git_config_lookup_map_value Signed-off-by: Sven Strickroth <email@cs-ware.de>

74293ea0

2020-08-29T16:46:47

patch_parse: handle absence of "index" header for new/deleted cases This follows up on 11de594f85479e4804b07dc4f7b33cfe9212bea0 which added support for parsing patches without extended headers (the "index <hash>..<hash> <mode>" line); issue #5267. We now allow transition from "file mode" state to "path" state directly if there is no "index", which will happen for patches adding or deleting files as demonstrated in added test case.

471ed794

2020-07-13T10:05:04

clone: respect init.defaultBranch when empty When cloning an empty repository, we need to guess what the branch structure should be; instead of hardcoding `master`, use the `init.defaultBranch` setting it if it provided.

e411aae3

2020-07-13T08:47:15

repo: honor the init.defaultBranch setting As part of a push towards more inclusive language, git is reconsidering using "master" as the default branch name. As a first step, this setting will be configurable with the `init.defaultBranch` configuration option. Honor this during repository initialization. During initialization, we will create an initial branch: 1. Using the `initial_head` setting, if specified; 2. Using the `HEAD` configured in a template, if it exists; 3. Using the `init.defaultBranch` configuration option, if it is set; or 4. Using `master` in the absence of additional configuration.

c5d41d46

2020-08-03T09:55:22

Merge pull request #5563 from pks-t/pks/worktree-heads Access HEAD via the refdb backends

a83fd510

2020-07-12T21:26:59

Merge pull request #5396 from lhchavez/mwindow-file-limit mwindow: set limit on number of open files

92d42eb3

2020-07-12T09:53:10

Minor nits and style formatting

ce4cb073

2020-07-12T18:19:21

tests: verify renaming branch really updates worktree HEAD In case where a branch is getting renamed, all HEADs of the main repository and of its worktrees that point to the old branch need to get updated to point to the new branch. We already do so and have a test for this, but the test only verifies that we're able to lookup the updated HEAD, not what it contains. Let's make the test more specific by verifying the updated HEAD also has the correct updated symbolic target.

65895410

2020-06-17T14:56:36

repository: retrieve worktree HEAD via refdb The function `git_repository_head_for_worktree` currently uses `git_reference__read_head` to directly read a given worktree's HEAD from the filesystem. This is broken in case the repository uses a different refdb implementation than the filesystem-based one, so let's instead open the worktree as a real repository and use `git_reference_lookup`. This also fixes the case where the worktree's HEAD is not a symref, but a detached HEAD, which would have resulted in an error previously.

d1f210fc

2020-06-17T15:09:49

repository: remove function to iterate over HEADs The function `git_repository_foreach_head` is broken, as it directly interacts with the on-disk representation of the reference database, thus assuming that no other refdb is used for the given repository. As this is an internal function only and all users have been replaced, let's remove this function.

2fcb4f28

2020-06-17T14:09:04

repository: introduce new function to iterate over all worktrees Given a Git repository, it's non-trivial to iterate over all worktrees that are associated with it, including the "main" repository. This commit adds a new internal function `git_repository_foreach_worktree` that does this for us.

9703d26f

2020-06-29T12:22:27

tests: reflog: remove unused signature There's two tests that create a commit signature, but never make any use of it. Let's remove these to avoid any confusion.

3a197ea7

2020-06-27T12:33:32

Make the tests pass cleanly with MemorySanitizer This change: * Initializes a few variables that were being read before being initialized. * Includes https://github.com/madler/zlib/pull/393. As such, it only works reliably with `-DUSE_BUNDLED_ZLIB=ON`.

d88994da

2020-06-27T07:34:36

Create the repository within the test This change moves the humongous static repository with 1025 commits into the test file, now with a more modest 16 commits.

eab2b044

2020-06-26T16:10:30

Review feedback * Change the default of the file limit to 0 (unlimited). * Changed the heuristic to close files to be the file that contains the least-recently-used window such that the window is the most-recently-used in the file, and the file does not have in-use windows. * Parameterized the filelimit test to check for a limit of 1 and 100 open windows.

9679df57

2020-02-08T20:47:24

mwindow: set limit on number of open files There are some cases in which repositories accrue a large number of packfiles. The existing mwindow limit applies only to the total size of mmap'd files, not on their number. This leads to a situation in which having lots of small packfiles could exhaust the allowed number of open files, particularly on macOS, where the default ulimit is very low (256). This change adds a new configuration parameter (GIT_OPT_SET_MWINDOW_FILE_LIMIT) that sets the maximum number of open packfiles, with a default of 128. This is low enough so that even macOS users should not hit it during normal use. Based on PR #5386, originally written by @josharian. Fixes: #2758

74520b91

2020-06-13T19:38:11

Merge pull request #5552 from libgit2/pks/small-fixes Random code cleanups and fixes

c6184f0c

2020-06-08T21:07:36

tree-wide: do not compile deprecated functions with hard deprecation When compiling libgit2 with -DDEPRECATE_HARD, we add a preprocessor definition `GIT_DEPRECATE_HARD` which causes the "git2/deprecated.h" header to be empty. As a result, no function declarations are made available to callers, but the implementations are still available to link against. This has the problem that function declarations also aren't visible to the implementations, meaning that the symbol's visibility will not be set up correctly. As a result, the resulting library may not expose those deprecated symbols at all on some platforms and thus cause linking errors. Fix the issue by conditionally compiling deprecated functions, only. While it becomes impossible to link against such a library in case one uses deprecated functions, distributors of libgit2 aren't expected to pass -DDEPRECATE_HARD anyway. Instead, users of libgit2 should manually define GIT_DEPRECATE_HARD to hide deprecated functions. Using "real" hard deprecation still makes sense in the context of CI to test we don't use deprecated symbols ourselves and in case a dependant uses libgit2 in a vendored way and knows it won't ever use any of the deprecated symbols anyway.

9e4e25b1

2020-06-08T12:57:48

tests: refs: modernize coding style of testcase The coding style of the testcase refs::create::propagate_eexists is not really up-to-date. Convert it to use a more modern coding style.

c708e5e5

2020-06-05T14:11:34

Merge pull request #5541 from libgit2/ethomson/clar_tap clar: add tap output option

cad7a1ba

2020-06-05T08:42:38

clar: include the function name

06d69dfc

2020-05-01T12:39:48

diff::parse: don't include `diff.h` We don't call any internal functions in the test; we don't need to include `../src/diff.h`.

f7250cc3

2020-06-04T07:23:15

clar: add tap output

691315e6

2020-06-03T15:47:42

clar: add an output abstraction layer Add an output abstraction layer, with a single output format, "clap", the clar protocol, which is the current output format for clar.

0187f36a

2020-06-03T15:22:44

clar: parse arguments before printing the header We want to parse arguments before we start printing any output; the arguments themselves may impact the way we display that output.

86b85492

2020-06-03T15:40:37

Merge pull request #5537 from libgit2/ethomson/clar_exactmatch tests: offer exact name matching with a `$` suffix

107bf1f4

2020-06-03T11:47:13

clar: print indirection

53a8f463

2020-06-03T07:40:59

Merge pull request #5536 from libgit2/ethomson/http httpclient: support googlesource

6de8aa7f

2020-06-02T12:21:22

Merge pull request #5532 from joshtriplett/pack-default-path git_packbuilder_write: Allow setting path to NULL to use the default path

0d3ce2ac

2020-06-02T10:23:41

offer exact name matching with a `$` suffix When using `-s` to specify a particular test, it will do a prefix match. Thus, `-sapply::both::rename_a_to_b_to_c` will match both a test named `test_apply_both__rename_a_to_b_to_c` and a test that begins with that name, like `test_apply_both__rename_a_to_b_to_c_exact`. Permit a trailing `$` to `-s` syntax. This allows a user to specify `-sapply::both::rename_a_to_b_to_c$` to match _only_ the `test_apply_both__rename_a_to_b_to_c` function. We already filter to ensure that the given prefix matches the current test name. Also ensure that the length of the test name matches the length of the filter, sans trailing `$`.

2a2c5b40

2020-05-23T15:57:48

clar: remove unused shell_out function

ee9e9163

2020-05-23T15:56:29

clar: remove files internally instead of /bin/rm Similar to how clar has used `/bin/cp` to copy files, it's used `/bin/rm` to remove them. This has similar deficiencies; meaning that leaks is noisy and it's slow. Move it to an internal function.

d03fd331

2020-05-23T15:42:51

clar: copy files with sendfile on linux

8df4f519

2020-05-23T15:04:54

clar: copy files internally instead of /bin/cp clar has historically shelled out to `/bin/cp` to copy test fixtures into a sandbox. This has two deficiencies: 1. It's slower than simply opening the source and destination and copying them in a read/write loop. On my Mac, the `/bin/cp` based approach takes ~2:40 for a full test pass. Using a read/write loop to copy the files ourselves takes ~1:50. 2. It's noisy. Since the leak detector follows fork/exec, we'll end up running the leak detector on `/bin/cp`. This would be fine, except that the leak detector spams the console on startup and shutdown, so it adds a _lot_ of additional information to the test runs that is useless. By not forking and using this internal system, we see much less output.

51eff5a5

2020-05-29T13:13:19

strarray: we should `dispose` instead of `free` We _dispose_ the contents of objects; we _free_ objects (and their contents). Update `git_strarray_free` to be `git_strarray_dispose`. `git_strarray_free` remains as a deprecated proxy function.

b7bdb071

2020-05-30T15:21:48

online::clone: test a googlesource URL Google Git (googlesource.com) behaves differently than git proper. Test that we can communicate with it.

172a2886

2020-06-01T14:04:15

Merge pull request #5529 from libgit2/ethomson/difftest diff::workdir: actually test the buffers

1bbdf15d

2020-06-01T13:57:12

Merge pull request #5527 from libgit2/ethomson/config_unreadable Handle unreadable configuration files

9df69223

2020-05-23T11:42:19

config: test that unreadable files are treated as notfound

1a899008

2020-05-26T20:36:13

tests: index::version: write v4 index: re-open repo to read written v4 index The `git_index_free()` merely decrement the reference counter from 2 to 1, and does not "free" the index. Thus, the following `git_repository_index()` merely increase the counter to 2, instead of read index from disk. The written index is not read and parsed, which makes this test case effectively becomes a no-op.

5278a006

2020-05-23T16:07:54

git_packbuilder_write: Allow setting path to NULL to use the default path If given a NULL path, write to the object path of the repository. Add tests for the new behavior.

3414d470

2020-05-23T16:27:56

diff::workdir: actually test the buffers The static test data is erroneously initialized with a length of 0 for three of the strings. This means the tests are not actually examining those strings. Provide the length.

f88e12db

2020-05-23T09:35:53

checkout::index: free the index

915f8860

2020-05-16T14:00:11

tests: checkout: fix stylistic issues and static variable The test case checkout::index::can_disable_pathspec_match has some shortcomings when it comes to coding style, which didn't fit our own coding style. Furthermore, it had an unnecessary static local variable. The test has been refactored to address these issues.

0cf9b666

2020-05-12T11:41:44

tests: merge: fix printf formatter on 32 bit arches We currently use `PRIuMAX` to print an integer of type `size_t` in merge::trees::rename::cache_recomputation. While this works just fine on 64 bit arches, it doesn't on 32 bit ones. As a result, our nightly builds on x86 and arm32 fail. Fix the issue by using `PRIuZ` instead.

cbae1c21

2020-04-01T22:12:07

assert: allow non-int returning functions to assert Include GIT_ASSERT_WITH_RETVAL and GIT_ASSERT_ARG_WITH_RETVAL so that functions that do not return int (or more precisely, where `-1` would not be an error code) can assert. This allows functions that return, eg, NULL on an error code to do that by passing the return value (in this example, `NULL`) as a second parameter to the GIT_ASSERT_WITH_RETVAL functions.

thodg/libgit2/tests

tests

Log