Log

Author Commit Date CI Message
Marcin Kolenda 85442950 2021-12-24T14:24:07 Remove PSGit from Language Bindings section of README PSGit is not using libgit2 library. It is stub of a library and is not developed further.
Edward Thomson 00346ce8 2021-12-24T00:12:59 Merge pull request #6148 from libgit2/ethomson/ci ci: build with ssh on nightly
Edward Thomson c940b695 2021-12-23T22:33:32 ci: build with ssh on nightly
Edward Thomson 153f6c27 2021-12-23T22:02:11 Merge pull request #6147 from libgit2/ethomson/insteadof remote: refactor insteadof application
Edward Thomson 33d0ad9c 2021-12-23T21:18:54 remote: refactor insteadof application Using the insteadof helper would leak memory when we didn't really want the pushInsteadOf configuration. Refactor the choice into the function that allocates memory (or now, not) and use a more idiomatic `int` return code.
Edward Thomson 86e5003d 2021-12-23T14:22:34 Merge branch 'pr/6062'
punkymaniac f9a98f94 2021-11-22T15:16:26 Fix test fail because of memory leak
punkymaniac 1fa8014a 2021-11-22T12:07:59 Update test for `git_str` usage instead of `git_buf` See commit f0e693b18afbe1de37d7da5b5a8967b6c87d8e53
punkymaniac 8b0ffdcb 2021-11-08T17:23:27 Add test for `git_worktree_add` no checkout
punkymaniac 58451759 2021-10-14T09:55:00 Change default checkout strategy from FORCE to SAFE Since we are able to give our own git checkout options, the default git checkout strategy will be the same as initialized in a new git_checkout_options struct.
punkymaniac ffead012 2021-09-09T18:02:22 Allow user checkout options on git_worktree_add Extend the `git_worktree_add_options` to include `git_checkout_options`. github issue #5949
Edward Thomson 942cfac1 2021-12-23T14:21:23 worktree: checkout options suggestions from code review
Edward Thomson a50bbba1 2021-12-23T15:07:29 Merge pull request #6142 from libgit2/ethomson/blob_data_is_binary blob: identify binary content
Edward Thomson 05c3d972 2021-12-23T15:03:08 Merge pull request #6124 from csware/config-parsing Config parsing
Edward Thomson 3cca14b3 2021-12-23T14:13:34 Merge pull request #6125 from stforek/git_commit_summary_spaces git_commit_summary: ignore lines with spaces
Edward Thomson dca31d24 2021-12-23T14:12:23 Merge pull request #6101 from mkhl/fix/instead-of remotes: fix insteadOf/pushInsteadOf handling
Edward Thomson ab5b3f37 2021-12-23T14:09:09 Merge pull request #6095 from yoichi/better-compatiblity-for-at-time-notation Better revparse compatibility for at time notation
Edward Thomson 4b27009c 2021-12-23T14:04:43 Merge pull request #6094 from visualgitio/commit-graph-long-long Fix a long long that crept past
Edward Thomson 734468d6 2021-12-23T14:02:02 Merge pull request #6146 from Qix-/main cmake: use project-specific root variable instead of CMAKE_SOURCE_DIR
Josh Junon c5cd71b2 2021-12-23T18:23:34 cmake: use PROJECT_SOURCE_DIR of CMAKE_SOURCE_DIR Also applies to *_BINARY_DIR. This effectively reverts 84083dcc8bd41332ccac9d7b537f3e254d79011c, which broke all users of libgit2 that use it as a CMake subdirectory (via `add_subdirectory()`). This is because CMAKE_SOURCE_DIR refers to the root-most CMake directory, which in the case of `add_subdirectory()` is a parent project to libgit2 and thus the paths don't make any sense to the configuration files. Corollary, CMAKE_SOURCE_DIR only makes sense if the CMake project is always the root project - which can rarely be guaranteed. In all honesty, CMake should deprecate and eventually remove CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR. It's been the source of headaches and confusion for years, they're rarely useful over CMAKE_CURRENT_(SOURCE|BINARY)_DIR or PROJECT_(SOURCE|BINARY)_DIR, and they cause a lot of confusing configuration and source code layouts to boot. Any time they are used, they break `add_subdirectory()` almost 100% of the time, cause confusing error messages, and hide subtle bugs.
Calvin Buckley 5761980d 2021-12-11T22:33:16 Simplifications to definitions to avoid UINT64_C
Edward Thomson 4591e76a 2021-12-10T15:19:59 blob: identify binary content Introduce `git_blob_data_is_binary` to examine a blob's data, instead of the blob itself. A replacement for `git_buf_is_binary`.
Sven Strickroth dff05bc3 2021-11-25T11:40:20 Multiline config values not preserved on saving (fixes issue #6088) Signed-off-by: Sven Strickroth <email@cs-ware.de>
Sven Strickroth 854164a5 2021-11-25T11:02:41 Add more tests for contents Signed-off-by: Sven Strickroth <email@cs-ware.de>
Sven Strickroth 433edb54 2021-11-25T10:22:22 Config parsing confused by continuations that start with quotes (fixes issue #6089) Signed-off-by: Sven Strickroth <email@cs-ware.de>
Edward Thomson 12b53eb0 2021-12-04T20:00:41 Merge pull request #6128 from libgit2/ethomson/object_validation Introduce `git_object_rawcontent_is_valid`
Edward Thomson 9f03ebd1 2021-11-29T13:44:42 object: introduce a raw content validation function Users may want to validate raw object content; provide them a function to do so.
Edward Thomson fc1a3f45 2021-11-29T13:36:36 object: return GIT_EINVALID on parse errors Return `GIT_EINVALID` on parse errors so that direct callers of parse functions can determine when there was a failure to parse the object. The object parser functions will swallow this error code to prevent it from propagating down the chain to end-users. (`git_merge` should not return `GIT_EINVALID` when a commit it tries to look up is not valid, this would be too vague to be useful.) The only public function that this affects is `git_signature_from_buffer`, which is now documented as returning `GIT_EINVALID` when appropriate.
Edward Thomson 6fdb1b2f 2021-11-30T21:09:57 Merge pull request #6122 from libgit2/ethomson/cleanup Minor code cleanups
Przemyslaw Ciezkowski 1e015088 2021-11-25T15:19:17 git_commit_summary: ignore lines with spaces Fixes libgit2/libgit2#6065
Yoichi Nakayama 7bb206a7 2021-11-23T10:12:29 Merge branch 'main' into better-compatiblity-for-at-time-notation Conflicts: src/revparse.c
Edward Thomson f9c4dc10 2021-11-22T11:23:50 Merge pull request #6106 from ammgws/fixtemplateerr Fix repo init when template dir is non-existent
Edward Thomson 3461aaf7 2021-11-22T10:29:29 repo: minor formatting fix
Edward Thomson 84083dcc 2021-11-19T08:48:08 cmake: use CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR Instead of using the project-specific `libgit2_SOURCE_DIR` and `libgit2_BINARY_DIR` variables, use `CMAKE_SOURCE_DIR` and `CMAKE_BINARY_DIR`.
Edward Thomson adcf638c 2021-11-21T21:34:17 filebuf: use hashes not oids The filebuf functions should use hashes directly, not indirectly using the oid functions.
Edward Thomson 91365fd8 2021-11-22T09:02:38 sha1: tests should use hashes, not oid computation The tests that examine sha1 behavior (including collision detection) should test against the hash functionality directly, not indirectly using the oid functions.
Edward Thomson fc42c28e 2021-11-19T09:36:03 util: don't include unnecessary system libraries Remove some unnecessary includes from utility code.
Edward Thomson ea62f546 2021-11-14T16:41:11 utf8: include `utf8.h` in tests
Edward Thomson 19743830 2021-11-19T08:17:28 Merge pull request #6121 from libgit2/ethomson/date util: minor cleanup and refactoring to the date class
Edward Thomson add30a83 2021-11-18T12:36:25 date: rfc2822 formatting uses a `git_buf` instead of a static string
Edward Thomson b2c40314 2021-11-18T12:19:32 date: make it a proper `git_date` utility class Instead of `git__date`, just use `git_date`.
Edward Thomson 1604be06 2021-11-17T08:54:38 Merge pull request #6120 from libgit2/ethomson/cmake_test cmake: re-enable WinHTTP
Edward Thomson 1b8d14ac 2021-11-17T08:25:56 cmake: use WINHTTP when USE_WINHTTP is specified
Edward Thomson 4a54d8e3 2021-11-17T07:27:39 cmake: enable testing at the top level Ensure that we `enable_testing()` at the top-level CMakeLists.txt or else we'll need to navigate within the build directory to the correct place in the hierarchy to run `ctest`. Now we can `ctest` at the top-level again.
Edward Thomson 7a15213e 2021-11-16T23:42:09 Merge pull request #6119 from libgit2/ethomson/tag_valid tag: set validity to 0 by default
Edward Thomson 6b2ea909 2021-11-16T23:21:29 tag: set validity to 0 by default `git_tag_name_is_valid` needs to set validity to 0 when it short-circuits.
Edward Thomson 86685f8f 2021-11-16T17:10:08 cmake: better explain why headertests exists
Peter Pettersson 7dcc29fc 2021-10-22T22:51:59 Make enum in src,tests and examples C90 compliant by removing trailing comma.
Peter Pettersson 43d9f0e3 2021-10-22T22:39:10 ntmlclient: make enum C90 compliant by removing trailing comma
Peter Pettersson 38c34498 2021-10-03T00:12:52 Make enum in includes C90 compliant by removing trailing comma.
Peter Pettersson 5221e185 2021-10-02T23:54:14 Add target for testing libgit2 headers
Edward Thomson 23c5c315 2021-11-14T08:42:12 Merge pull request #6114 from libgit2/ethomson/cmake5 cmake: further refactorings
Edward Thomson 2c154145 2021-11-11T23:09:44 cmake: move sha1 source selection into CMakeLists.txt The select hashes module selects the hash; the CMakeLists.txt selects the files to implement it.
Edward Thomson c7f6ecb3 2021-11-11T22:54:14 cmake: use a string not a boolean for LIBGIT2_FILENAME
Edward Thomson 395b3dc4 2021-11-11T22:10:51 cmake: refactor global variables Update the global variables `LIBGIT2_OBJECTS` to `LIBGIT2_DEPENDENCY_OBJECTS` for clarity and consistency.
Edward Thomson c3fec456 2021-11-11T22:37:36 cmake: reformat modules Apply the standard project cmake formatting to the modules.
Edward Thomson b608af6c 2021-11-14T07:23:01 Merge pull request #6116 from lhchavez/drop-volatile-qualifier-in-atomic-exchange
Edward Thomson 03132b36 2021-11-14T07:22:24 Merge pull request #6115 from lhchavez/fix-indentation-threadstate
lhchavez 5675312e 2021-11-14T02:27:10 Fix a gcc 11 warning in src/thread.h When building under gcc 11, there is a warning about an incompatible pointer type, since [`__atomic_exchange`](https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html) does not take `volatile` pointers: ``` In file included from ../src/common.h:81, from ../src/transports/winhttp.c:8: ../src/thread-utils.h: In function ‘git___swap’: ../src/thread-utils.h:168:9: warning: argument 3 of ‘__atomic_exchange’ discards ‘volatile’ qualifier [-Wincompatible-pointer-types] 168 | __atomic_exchange(ptr, &newval, &foundval, __ATOMIC_SEQ_CST); | ^~~~~~~~~~~~~~~~~ ``` This change drops the `volatile` qualifier so that the pointer type matches what `__atomic_exchange` expects.
lhchavez 0c4d24da 2021-11-14T02:24:39 Fix a gcc 11 warning in src/threadstate.c When building under gcc 11, there is a warning about a misaligned guard clause because there were mixed spaces and tabs: ``` [128/634] Building C object src/CMakeFiles/git2internal.dir/threadstate.c.o ../src/threadstate.c: In function ‘threadstate_dispose’: ../src/threadstate.c:39:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 39 | if (threadstate->error_t.message != git_str__initstr) | ^~ ../src/threadstate.c:41:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ 41 | threadstate->error_t.message = NULL; | ^~~~~~~~~~~ ../src/threadstate.c: At top level: ``` This change indents the code with tabs for consistency with the rest of the code, which makes the warning go away.
Jason Nader bc0d1ad2 2021-11-05T03:08:43 tests: try to init with non-existent template path
Jason Nader 709b1b62 2021-11-05T02:28:37 repository: do not copy templates if dir nonexistent This mimics the behaviour of git which just prints a warning and continues with the repo initialisation.
Edward Thomson 043f3123 2021-11-11T18:21:35 Merge pull request #6113 from libgit2/ethomson/cmake3 Add missing-declarations warning globally
Edward Thomson 4a6ef5a4 2021-11-11T17:04:24 cmake: move missing-declarations warning to top-level We should enforce declarations throughout the code-base, including examples, fuzzers and tests, not just in the `src` tree.
Edward Thomson 8d2b3110 2021-11-11T19:58:49 tests: include function declarations
Edward Thomson bfdc0971 2021-11-11T13:32:00 test: correct test names
Edward Thomson ca14942e 2021-11-11T13:28:08 tests: declare functions statically where appropriate
Edward Thomson 3f024b6d 2021-11-11T12:57:44 clar: declare summary functions as static
Edward Thomson eabbee04 2021-11-11T12:48:19 example: declare print_usage function
Edward Thomson 8be22614 2021-11-11T12:47:02 examples: remove unused function
Edward Thomson 2374ba8d 2021-11-11T17:15:47 fuzzers: declare static functions as static
Edward Thomson 489aec44 2021-11-11T12:33:14 fuzzers: declare standalone functions
Edward Thomson 0429894e 2021-11-11T12:28:07 tests: declare trace handler as static
Edward Thomson 49f03c03 2021-11-11T16:53:33 tests: include test declarations for old gcc Older versions of gcc do not believe that we've adequately declared our test functions. Include `clar_suite.h` conditionally for those old versions. Do not do this on newer compilers to avoid unnecessary recompilation of the entire suite when we add or remove a test function.
Edward Thomson cf522050 2021-11-11T16:24:37 clar: emit `clar_suite.h` with test declarations We may want to have test function declarations; produce a header file with (only) the test declarations. Update clar to avoid overwriting the file unnecessarily to avoid bumping timestamps and potentially recompiling unnecessarily.
Martin Kühl de665a43 2021-11-11T21:55:28 remote: improve apply_insteadof function signature
Edward Thomson 7687948a 2021-11-11T16:13:38 Merge pull request #6112 from libgit2/ethomson/cmake3 cmake refactorings
Edward Thomson 42205e72 2021-11-11T16:09:49 Merge pull request #6111 from libgit2/ethomson/str_free str: git_str_free is never a function
Edward Thomson 4e84ddd5 2021-11-10T21:59:46 cmake: refactor zlib selection Move zlib selection into its own cmake module.
Edward Thomson 83fa5480 2021-11-10T21:58:12 cmake: refactor WinHTTP selection Move WinHTTP selection into its own cmake module.
Edward Thomson e35a22a0 2021-11-10T21:55:23 cmake: refactor libssh2 selection Move SSH selection into its own cmake module.
Edward Thomson f0cb3788 2021-11-10T21:51:55 cmake: refactor regex selection Move regex selection into its own cmake module.
Edward Thomson de178d36 2021-11-10T21:49:20 cmake: refactor http_parser selection Move http_parser selection into its own cmake module.
Edward Thomson 16b6e3a9 2021-11-10T21:33:28 cmake: HTTP_Parser is now HTTPParser
Edward Thomson 19e99de0 2021-11-10T08:14:11 cmake: qsort detection in features.h
Edward Thomson d3a7a352 2021-11-06T16:44:07 cmake: move test enablement into test cmake
Edward Thomson 207beff5 2021-11-06T16:43:04 cmake: reorganize file
Edward Thomson 4d2a6839 2021-11-06T16:38:57 cmake: move fuzzer args to the fuzzer's cmake
Edward Thomson 7b527c12 2021-11-06T16:38:11 cmake: move deprecation definition to src/ There's no need to add the deprecation at the top-level. Our tests add deprecation explicitly.
Edward Thomson 9f37457e 2021-11-06T16:23:03 cmake: move cflag defaults into a separate module
Edward Thomson 6c00fcb7 2021-11-10T17:32:41 cmake: USE_SSH is not on by default
Edward Thomson 789ab915 2021-11-10T21:02:42 cmake: standardize USE_WINHTTP WinHTTP can now be disabled with `USE_WINHTTP=OFF` instead of `WINHTTP=OFF` to better support the other cmake semantics.
Edward Thomson 9324d16e 2021-11-06T16:14:47 cmake: standardize USE_THREADS and USE_NSEC Threading can now be disabled with `USE_THREADS=OFF` instead of `THREADSAFE=OFF` to better support the other cmake semantics. Nanosecond support is the default _if_ we can detect it. This should be our default always - like threads - and people can opt out explicitly.
Edward Thomson 08047ca0 2021-11-11T19:56:31 str: git_str_free is never a function
Martin Kühl 93d321ab 2021-10-28T14:56:29 fix remote/insteadof tests
Martin Kühl 7891660a 2021-10-28T14:15:41 update remote/insteadof tests we want to test: - an anonymous repo (a url) - a named repo with a url - a named repo with a url and pushurl and for each of these matching configuration: - only insteadOf - only pushInsteadOf - both insteadOf and pushInsteadOf this change adds test cases for all of these combinations.
Edward Thomson ceddeed8 2021-11-11T15:20:50 Merge pull request #6104 from libgit2/ethomson/path path: refactor utility path functions
Edward Thomson 9ab351c0 2021-11-11T15:14:59 Merge pull request #6107 from joshtriplett/refresh-handling Support checking for object existence without refresh
Edward Thomson dfd5b32f 2021-11-11T15:10:37 Merge pull request #6109 from joshtriplett/document-odb-race-free Document that `git_odb` is thread-safe
Josh Triplett 644c763b 2021-11-11T00:30:40 Document that `git_odb` is thread-safe Commit 4ae41f9c639d246d34dac89c3f1d9451c9cfa8d3 made `git_odb` race-free, and added internal locking. Update `docs/threading.md` accordingly, so that APIs built atop libgit2 (e.g. language bindings) can count on this.