thodg/libgit2/tests/patch

Diff

  • Show log

    Commit

  • Hash : de543e29
    Author : Patrick Steinhardt
    Date : 2019-11-05T22:44:27 

    patch_parse: fix segfault when header path contains whitespace only

When parsing header paths from a patch, we reject any patches with empty
paths as malformed patches. We perform the check whether a path is empty
before sanitizing it, though, which may lead to a path becoming empty
after the check, e.g. if we have trimmed whitespace. This may lead to a
segfault later when any part of our patching logic actually references
such a path, which may then be a `NULL` pointer.

Fix the issue by performing the check after sanitizing. Add tests to
catch the issue as they would have produced a segfault previosuly.

kmx.io     mail     discord kmxgit v0.4.0