thodg/libgit2/include/git2

Diff

  • Show log

    Commit

  • Hash : 2d9d2464
    Author : Patrick Steinhardt
    Date : 2018-06-12T10:34:10 

    diff: fix enum value being out of allowed range

The C89 standard states in ยง6.7.2.2 "Enumeration specifiers":

> The expression that defines the value of an enumeration constant shall
> be an integer constant expression that has a value representable as an
> int.

On most platforms, this effectively limits the range to a 32 bit signed
integer. The enum `git_diff_option_t` though recently gained an entry
`GIT_DIFF_INDENT_HEURISTIC = (1u << 31)`, which breaks this limit.

Fix the issue by using a gap in `git_diff_option_t`'s enum values. While
this has the benefit of retaining our API, it may break applications
which do not get recompiled after upgrading libgit2. But as we are
bumping the soversion on each release anyway and thus force a recompile
of dependents, this is not a problem.

kmx.io     mail     discord kmxgit v0.4.0