thodg/libgit2/tests/config

Diff

  • Show log

    Commit

  • Hash : 2eea5f1c
    Author : Patrick Steinhardt
    Date : 2018-02-08T10:27:31 

    config_parse: fix reading files with BOM

The function `skip_bom` is being used to detect and skip BOM marks
previously to parsing a configuration file. To do so, it simply uses
`git_buf_text_detect_bom`. But since the refactoring to use the parser
interface in commit 9e66590bd (config_parse: use common parser
interface, 2017-07-21), the BOM detection was actually broken.

The issue stems from a misunderstanding of `git_buf_text_detect_bom`. It
was assumed that its third parameter limits the length of the character
sequence that is to be analyzed, while in fact it was an offset at which
we want to detect the BOM. Fix the parameter to be `0` instead of the
buffer length, as we always want to check the beginning of the
configuration file.

kmx.io     mail     discord kmxgit v0.4.0