• Show log

    Commit

  • Hash : 50194dcd
    Author : Patrick Steinhardt
    Date : 2019-07-11T15:14:42

    win32: fix symlinks to relative file targets
    
    When creating a symlink in Windows, one needs to tell Windows whether
    the symlink should be a file or directory symlink. To determine which
    flag to pass, we call `GetFileAttributesW` on the target file to see
    whether it is a directory and then pass the flag accordingly. The
    problem though is if create a symlink with a relative target path, then
    we will check that relative path while not necessarily being inside of
    the working directory where the symlink is to be created. Thus, getting
    its attributes will either fail or return attributes of the wrong
    target.
    
    Fix this by resolving the target path relative to the directory in which
    the symlink is to be created.