• Show log

    Commit

  • Hash : 0fe87761
    Author : Patrick Steinhardt
    Date : 2018-08-09T10:57:06

    smart_pkt: adjust style of "ref" packet parsing function
    
    While the function parsing ref packets doesn't have any immediately
    obvious buffer overflows, it's style is different to all the other
    parsing functions. Instead of checking buffer length while we go, it
    does a check up-front. This causes the code to seem a lot more magical
    than it really is due to some magic constants. Refactor the function to
    instead make use of the style of other packet parser and verify buffer
    lengths as we go.
    
    (cherry picked from commit 5edcf5d190f3b379740b223ff6a649d08fa49581)