thodg/libgit2/tests/patch

Diff

  • Show log

    Commit

  • Hash : dedf70ad
    Author : Patrick Steinhardt
    Date : 2019-07-05T09:35:43 

    patch_parse: do not depend on parsed buffer's lifetime

When parsing a patch from a buffer, we let the patch lines point into
the original buffer. While this is efficient use of resources, this also
ties the lifetime of the parsed patch to the parsed buffer. As this
behaviour is not documented anywhere in our API it is very surprising to
its users.

Untie the lifetime by duplicating the lines into the parsed patch. Add a
test that verifies that lifetimes are indeed independent of each other.

kmx.io     mail     discord kmxgit v0.4.0