thodg/libgit2/tests/submodule

Diff

  • Show log

    Commit

  • Hash : e6c757a7
    Author : Carlos Martín Nieto
    Date : 2018-04-30T13:47:15 

    submodule: ignore submodules which include path traversal in their name

If the we decide that the "name" of the submodule (i.e. its path inside
`.git/modules/`) is trying to escape that directory or otherwise trick us, we
ignore the configuration for that submodule.

This leaves us with a half-configured submodule when looking it up by path, but
it's the same result as if the configuration really were missing.

The name check is potentially more strict than it needs to be, but it lets us
re-use the check we're doing for the checkout. The function that encapsulates
this logic is ready to be exported but we don't want to do that in a security
release so it remains internal for now.

kmx.io     mail     discord kmxgit v0.4.0