|
35b92525
|
2025-08-13T15:27:32
|
|
Remove lock from GenVertexArrays/IsVertexArray
VertexArrays are per context anyway and is thread safe, so there is no
need for shared lock. This CL moves mVertexArrayMap from Context to
PrivateState so that it won't be accessed by other APIs.
Bug: b/433331119
Change-Id: I466a79762e887dbec78b796b52028420837cff59
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6977163
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
44db20f2
|
2025-09-17T15:57:09
|
|
Revert "Add a "noncoherent" layout qualifier to PLS"
This reverts commit ef9c5ce43110f4f8ba56124bdee927944ce3ddd1.
Reason for revert: Causes issues on Apple silicon crbug.com/445727125
Original change's description:
> Add a "noncoherent" layout qualifier to PLS
>
> Raster ordering can be expensive. If an app knows the geometry in a draw
> does not overlap, it can mark the PLS planes as noncoherent and opt for
> using barriers instead.
>
> Bug: angleproject:40096838
> Change-Id: I2d686c2e64f51940face186637a9fcadcc251bef
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923300
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Chris Dalton <chris@rive.app>
Bug: angleproject:40096838
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ibc24bed27cec406b6e4ffa9aaa8fe3a2110b58ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6962955
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
|
|
ef9c5ce4
|
2025-09-07T17:50:37
|
|
Add a "noncoherent" layout qualifier to PLS
Raster ordering can be expensive. If an app knows the geometry in a draw
does not overlap, it can mark the PLS planes as noncoherent and opt for
using barriers instead.
Bug: angleproject:40096838
Change-Id: I2d686c2e64f51940face186637a9fcadcc251bef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923300
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
|
|
7a630c62
|
2025-09-15T16:29:55
|
|
FrameCapture: Disable GL_EXT_texture_norm16 during capture
Test: Lineage2M
Bug: b/445241477
Change-Id: Ib4cfd87f0b79646965ea3e24db5b725062cfa725
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6951980
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
|
|
25390156
|
2025-08-21T00:13:19
|
|
Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
In this CL, we suppress many files but stop short of actually
enabling the warning by not removing the line from the
unsafe_buffers_paths.txt file. That will happen in a follow-on
CL, along with resolving any stragglers missed here.
This is mostly a manual change so as to familiarize myself with
the kinds of issues faced by the Angle codebase when applying buffer
safety warnings.
-- Re-generate affected hashes.
-- Clang-format applied to all changed files.
-- Add a few missing .reserve() calls to vectors as noticed.
-- Fix some mismatches between file names and header comments.
-- Be more consistent with header comment format (blank lines and
trailing //-only lines when a filename comment adjoins license
boilerplate).
Bug: b/436880895
Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
9d1edb4e
|
2025-08-08T18:21:03
|
|
Fix the assert on texture target to allow GL_TEXTURE_CUBE_MAP_ARRAY
Add anend2end test to verify glCopyImageSubData works.
Bug: b/419863436
Test: TextureCubeTestES32.CopyImageSubDataCubeMapArray
Change-Id: I2a569680ed20f05b4182045cb4bdf08d4c66d8df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6832639
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Xiang Wang <xwxw@google.com>
|
|
|
d63cff37
|
2025-08-06T13:31:02
|
|
Fix bug when rebind the same buffer not pick up the change
Buffer is modified in one context and rebind the same buffer on the
second context should pick up the buffer changes.
Bug: b/433331119
Change-Id: I8085fe826c339692881f2d3d6515efb19bbc4a88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6825767
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
7c8e357c
|
2025-07-15T17:24:25
|
|
Fix NULL handling in glGetAttachedShaders and ShaderPrecisionFormat
Fix the case where passing NULL to the shaders parameter in
getAttachedShaders and to the range and precision parameters in
getShaderPrecisionFormat would trigger assertions.
Bug: angleproject:431900689
Change-Id: I0d01bbb0d13f9a4704b47066c85ac7c1368534a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6733749
Auto-Submit: Tingwei Guo <tingwei.guo@arm.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
d8dc3cc2
|
2025-08-02T12:02:20
|
|
Remove shared context lock from glVertexAttrib{I}Format
This CL removes shared context lock from glVertexAttribFormat() and
glVertexAttribIFormat() APIs, since they no longer access anything
outside VertexArrayPrivate. The main problem I had run into is
validation code. Before this CL, ValidateIntegerVertexFormat() needs
context's mStateCache for mCachedVertexAttribTypesValidation and
mCachedIntegerVertexAttribTypesValidation. Given these two cached value
are constant after initialization, in this CL, I have moved them to
PrivateStateCache. PrivateStateCache argument is added to
ValidateVertexAttribFormat() and ValidateVertexAttribIFormat() to get
them access to mCachedIntegerVertexAttribTypesValidation.
Bug: b/433331119
Change-Id: Ifc3fbed32b4d3722c335dd2c393bc6519ed0b544
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6822032
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
ae4aead5
|
2025-07-24T16:35:38
|
|
Remove sharedContextLock from glVertexAttrib{Divisor|Binding}
With prior CLs all the functions used by glVertexAttribDivisor*,
glVertexBindingDivisor and glVertexAttribBinding only access
VertexArrayPrivate. This CL removes shared context lock from these APIs.
Bug: b/433331119
Change-Id: Ib1632797c53d2cd7a31c21e93c0e69385c71a27f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6814157
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
7a193b06
|
2025-08-06T13:50:50
|
|
Unthrottle validation error messages for all of Chromium
Chromium uses the debug callback to check if there were any errors
instead of glGetError(). With the previous change that throttled error
messages, some webgl tests failed to correctly recognize that an invalid
call did actually fail validation, as well as passthrough command
decoder fuzzer tests.
Bug: angleproject:423956139
Bug: chromium:436292490
Change-Id: Ida254c9bdd2137afcc9483cc1860254781338dbc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6823824
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
da8462d4
|
2025-08-06T05:44:28
|
|
Unthrottle validation error messages in WebGL
Chromium uses the debug callback to check if there were any errors
instead of glGetError(). With the previous change that throttled error
messages, some webgl tests failed to correctly recognize that an invalid
call did actually fail validation.
Bug: angleproject:423956139
Bug: chromium:436354527
Change-Id: Ic65761f412d3548fedd63f48d36357c9568c0b53
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6822578
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
394df705
|
2025-08-01T14:03:17
|
|
Cache per bufferIndex buffer properties in VertexArrayPrivate
This is another preparation CL. This CL caches per bindingIndex buffer
properties in VertexArrayPrivate: mCachedBufferPropertyMapped and
mCachedBufferPropertyMutableOrImpersistent. The only difference between
these and mCachedMappedArrayBuffers /
mCachedMutableOrImpersistentArrayBuffers is that one indexed by
attribIndex and another is indexed by bindingIndex. With this, when
attribute binding changes, we no longer need to make buffer access. With
this, we can move setVertexAttribBinding and setVertexBindingDivisor
from VertexArray into VertexArrayPrivate class and Context argument is
also removed.
Bug: b/433331119
Change-Id: I666544ee0585727ca92d640f372f5a64d1d85576
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6814156
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
91fa29be
|
2025-08-04T11:08:20
|
|
Add a feature to force contexts into debug mode
Bug: angleproject:423956139
Change-Id: Ie166b40eb9c241140daf4a35df3391829c64f84e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6817467
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
35023c8a
|
2025-07-31T17:40:45
|
|
Throttle validation error messages in release builds
Some apps make invalid but harmless calls every frame. ANGLE inserts a
debug message for each validation failure which comes with a performance
cost. This change makes ANGLE stop reporting validation failure messages
after a handful have already been reported. This is only done when
assertions are disabled and when the context is not a debug context.
Bug: angleproject:423956139
Change-Id: Ie3fb121b2686cddf7da98fc23422b5d12097c6fa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6805901
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
fa29f604
|
2025-07-02T13:23:31
|
|
Remove sharedContextLock from {Enable|Disable}VertexAttribArray
VertexArray objects are per context objects. In theory they do not need
to protected by shared context lock. The reason we are taking locks
because all these functions end up accessing Buffer object which are
shared. In prior CLs we have removed subject observer usage from
VertexArray which means VertexArray no longer accessed from other
thread. In prior CLs we also split VertexArray into two classes:
VertexArrayPrivate which has no buffer, and VertexArray which is
subclass from VertexArrayPrivate and owns buffer. In this CL,
glEnableVertexAttribArray and glDisableVertexAttribArray calls no longer
take shared context lock. ContextPrivateEnableVertexAttribArray and
ContextPrivateDisableVertexAttribArray are called from these two APIs
and they only have access to StatePrivate. State Private holds a
VertexArrayPrivate pointer, which means they do not have anyway to
access buffer objects. The main challenge I run into here is
mCachedActiveClientAttribsMask, mCachedActiveBufferedAttribsMask,
mCachedActiveDefaultAttribsMask, mCachedHasAnyEnabledClientAttrib,
mCachedNonInstancedVertexElementLimit,
mCachedInstancedVertexElementLimit. These StateCache variable needs to
be updated when these two APIs are called, and calculating these
variable needs access to buffer object. The solution here is adding a
bool mIsCachedActiveAttribMasksValid in the PrivateStateCache so that
instead of immediately update these mCached* variable, we just set
mIsCachedActiveAttribMasksValid to false. Then whenever any of these
mCached* variable is needed, we will check
mIsCachedActiveAttribMasksValid and calculate these cached variables. It
adds one if check when accessing these caches, but the other benefit is
that we may have avoided duplicated calculation when multiple states
changed.
Bug: b/433331119
Change-Id: I3227c72bc40501712db93fb3d540b835f07150b5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4514436
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
2ef85c24
|
2025-07-09T17:13:52
|
|
Vulkan: Add support for GL_EXT_fragment_shading_rate
Add support for GL_EXT_fragment_shading_rate.
Bug: angleproject:420310117
Change-Id: I7b368afc45baf8551c222b2569991269117d385b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6726817
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Panfeng Hou <panfeng.hou@arm.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
3e52318c
|
2025-06-26T10:46:00
|
|
Vulkan: Ensure always using resolved Window Surface size
`WindowSurfaceVk::getWidth/Height()` methods return cached, previously
resolved Surface size. Using these methods while current Window Surface
size is unresolved may return stale values, causing undesired behavior.
Appropriate ASSERTs were added to these methods to prevent such usage.
Added ASSERTs revealed few places with incorrect usage:
- In `Context::makeCurrent()` to set initial viewport or for capture.
- In `IsPartialBlit()` and `ValidateReadPixelsBase()` validations.
- In `SerializeFramebufferAttachment()` during capture.
Rest of the code was thoroughly checked if it is possible to call
`WindowSurfaceVk::getWidth/Height()` when size is unresolved. All other
places always call these methods after framebuffer state
synchronization, which acquires swapchain images and resolves the
surface size.
Added `ensureSizeResolved()` method that is called during validation and
in the `SerializeFramebufferAttachment()` method. It is possible to use
existing `Framebuffer::syncState()` method as alternative, but this
solution was discarded since it may potentially interfere with
`State::syncDirtyObjects()` method.
The `Surface::getUserSize()` replaces old methods as optimization, to
prevent calling relatively expensive method twice from
`Context::makeCurrent()` to get width and height of the `drawSurface`.
Test: angle_trace_tests --gtest_filter=EGLSurfaceTest.ResizeBeforeMakeCurrent/*
Test: angle_trace_tests --gtest_filter=EGLSurfaceTest.ResizeBeforeMakeCurrentPostSizeQuery/*
Test: angle_trace_tests --gtest_filter=EGLSurfaceTest.ResizeAndReadPixelsRobustANGLE/*
Test: angle_trace_tests --gtest_filter=EGLSurfaceTest.ResizeAndBlitFramebufferANGLE/*
Bug: angleproject:397848903
Change-Id: I082e13d0b8db5fd7d08ff25b102df1f283e1256d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6792928
Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b4d84458
|
2025-05-23T18:08:19
|
|
Move Buffer from VertexBinding to VertexArray
In later CL we will not taking shared context lock for certain
VertexArray API calls. VertexArray itself is per context, so this sounds
reasonable to do. The main challenge here is a lot of VertexArray
function end up accessing gl::Buffer object, which could be modified by
other shared contexts. In order to safely not taking the shared context
lock, we need to separate out Buffer object out of VertexArray itself so
that these lockless APIs will take VertexArray that does not have access
to buffer.
In this CL, VertexArray is split into two classes: VertexArrayPrivate is
everything in VertexArray except buffers. VertexArray is a subclass of
VertexArrayPrivate and owns all the buffers. Buffer is removed from
gl::VertexBinding class. In order to let back end access to buffers,
VertexArrayImpl holds a weak reference to
VertexArray::mVertexArrayBuffers (which is a vector of buffers).
Further, VertexArrayBufferBindingMask mBufferBindingMask is moved from
VertexArrayState into VertexArray class well, since it tracks which
index has a non-null buffer. The bulk of change are due to the
VertexARrayImpl constructor change, since it now takes
vertexArrayBuffers argument. Other bulk of changes are due to
VertexBinding no long has the buffer, but you need to get it directly
from VertexArray or VertexArrayImpl.
This CL also reverts some of the change in crrev.com/c/6758215 that
mVertexBindings no longer contains kElementArrayBufferIndex.
BYPASS_LARGE_CHANGE_WARNING
Bug: b/433331119
Change-Id: I15f4576f7c5c8d8f4d9c9c07d38a60ce539bfeea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6774702
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
866370dc
|
2025-07-28T22:12:00
|
|
Disable texture_compression_astc_decode_mode exts during capture
The GL_EXT_texture_compression_astc_decode_mode and
GL_EXT_texture_compression_astc_decode_mode_rgb9e5 extensions are
not widely supported outside of ARM and Qualcomm. Disable while
ANGLE capture is enabled.
Test: angle_trace_tests --gtest_filter=*whiteout_survival
Bug: b/434819166
Change-Id: I4cebf6942144c61a954dfd9dfe9bd9935638ff60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6794776
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
d38531e8
|
2025-07-23T09:39:11
|
|
Fix extension check for xfb mode validation
With geometry and tessellation shaders, it's possible to use different
primitive modes between transform feedback and draw, as long as they are
from the same class.
The code accidentally allowed this only if both extensions are
supported, but it should be allowed if either is.
Bug: angleproject:428561247
Change-Id: Ia18d4ac15a3d0739ce18dc0e1f3d3f0b1aea621c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6780744
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
b7582680
|
2025-02-24T18:04:32
|
|
Reland: GL: Allow untranslated shaders to pass through on GLES
Add an EGL extension EGL_ANGLE_create_context_passthrough_shaders which
uses the NULL translator and passes the original shader to the driver.
The parser is still used for shader reflection.
Always enable the null compiler backend. It has almost no binary size
cost and is now potentially used when the null ANGLE backend is not
enabled.
Bug: angleproject:398857482
Change-Id: Id528189ccbbacb1c444eacb151baadfda9fcc04b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6488609
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
4e81cd79
|
2025-07-21T10:45:02
|
|
FrameCapture: Update context limits
We're seeing multiple titles run incorrectly without
updating these two limits during capture.
I've verified locally that these still fit within the
limits of all modern devices we're looking at.
If there are any problems with older devices, we can
address them with:
addIntegerPrerequisite(GL_MAX_DRAW_BUFFERS_EXT, 6);
addIntegerPrerequisite(GL_MAX_VERTEX_UNIFORM_VECTORS, 4096);
Bug: b/431854319
Bug: b/433331917
Change-Id: Id21de17acc4d24157dfe07de6b9de818561399ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6775624
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
18091004
|
2025-06-19T16:50:58
|
|
GLES1: Skip updating vertex attrib array when binding zero texture
Previously, when usecases bind the zero texture, the vertex attrib
array was disabled. This made the following bound textures lose the
vertex attrib data.
In this change, updating vertex attrib array in prepareForDraw()
is skipped when the application binds zero texture but does not
activate the corresponding texture unit.
Also GLES1 tests using zero texture are added to make sure vertex
attrib array is enabled correctly.
Test: angle_end2end_tests --gtest_filter=DrawTextureTest.*
Bug: b/426740680
Change-Id: Ic5aad0a60c9d987edcb1d05cdb6b68dd93eac309
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6659335
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
154e5711
|
2025-06-24T15:28:28
|
|
Refine validation for GetQueryObjectuiv
Spec says that after a graphics reset has occurred on a context,
subsequent GL commands on that context (or any context which shares
with that context) will generate a CONTEXT_LOST error.
Exceptions to this behavior include:
Any commands which might cause a polling application to block
indefinitely will generate a CONTEXT_LOST error, but will also return
a value indicating completion to the application. Such commands
include:
- GetSynciv with pname SYNC_STATUS ignores the other parameters and
returns SIGNALED in values
- GetQueryObjectuiv with pname QUERY_RESULT_AVAILABLE ignores the
other parameters and returns TRUE in params
Bug: angleproject:427242336
Change-Id: I86fd6f93a2c2a4b60c6a1e19637ee6382fadac7b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6666083
Auto-Submit: Shufen Ma <Shufen.Ma@arm.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
d5babf99
|
2025-06-23T12:46:51
|
|
Vulkan: Fix unhandled deferred clears after glGetMultisamplefv
Issue was introduced in the commit that implemented deferred clears.
The `glGetMultisamplefv()` synchronizes draw framebuffer which defers
possibly staged clears. Since API is not handling deferred clears they
are left untouched, causing the ASSERT.
This change fixes the issue by not deferring clears for the
`glGetMultisamplefv()` command during flushing staged updates of dirty
framebuffer attachments.
Changes:
- Add `gl::Command::GetMultisample` enumeration for clarity.
- Add `gl::CommandBlitBuffer::CommandBlitBufferDepthStencil` enumeration
to improve code readability.
- Add `command` parameter into `gl::State::syncDirtyObject()` method to
use actual command enum instead of `Other`.
- Remove `previousDeferredClears` local variable and update ASSERT in
the `FramebufferVk::syncState()` method. New assert ensures empty
`mDeferredClears` instead of just checking dirty attachments, since
it is easy to make all attachments dirty making old and new assertions
act the same.
- Replace logic in `FramebufferVk::syncState()` that decides whether
need to defer attachments or not with switch-case. This makes the
logic more clear regarding handling individual commands and simplify
updating this handling in the future. Except of the bug fix with
`GetMultisample` command, handling of other command is uncached.
- Remove `flushDeferredClears()` from `FramebufferVk::readPixels()`
because `mDeferredClears` are not expected (now it's more clear after
the refactoring). And even if there are `mDeferredClears` (in case of
a bug or after API failure), `flushDeferredClears()` only flushes
clears for the draw framebuffer, while checking `mDeferredClears` of
the read framebuffer. This is a problem in case if read and draw
framebuffers are not the same.
Bug: angleproject:40644727
Test: angle_end2end_tests --gtest_filter=TextureMultisampleTest.GetMultisamplefvAfterClear/*
Test: angle_end2end_tests --gtest_filter=EGLSurfaceTest.GetMultisamplefvAfterClear/*
Change-Id: I376a62de52de5e17dbc63cc7ddb0506741a69266
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6661958
Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
2fd033d0
|
2025-05-22T04:21:11
|
|
Vulkan: Optimize updates to uniform buffers
... when only the offset is modified. Most of the work done when
handling dirty uniforms can be skipped since the buffer bindings
haven't changed
Bug: angleproject:386749841
Tests: UniformBufferTest31.UniformBufferBindingRangeChange*Vulkan
Change-Id: Ic811bd71f0f2993f88ce9bcf93f9e8e46dfc6d99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6581359
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
c45e7c83
|
2025-05-22T04:14:52
|
|
Vulkan: Optimize uniform and storage buffer updates
Maintain a map between buffer block index and its DescriptorDesc index
in WriteDescriptorDescs and look up the map instead of repeatedly
calculating it when updating DescriptorDesc
Bug: angleproject:386749841
Change-Id: I74d14f6205f07992fae1e338697998d04de1c563
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6603986
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
9a436772
|
2025-06-04T16:47:51
|
|
Vulkan: Add entry points for GL_EXT_fragment_shading_rate
Bug: angleproject:420310117
Change-Id: I8a8efad6cad810b2cb0b600106f6496070495605
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6620340
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
8c48b502
|
2025-06-05T02:09:54
|
|
Vulkan: Fix deferred clear vs robust init vs invalidate
The DIRTY_OBJECT_DRAW_ATTACHMENTS bit, when handled, goes over
framebuffer attachments and requests that they be cleared. This is done
only with robust init.
The DIRTY_OBJECT_DRAW_FRAMEBUFFER bit, when handled, results in staged
updates to be applied to the attachments.
When syncDirtyObjects is called, the above bits are handled. If we end
up in a situation where DIRTY_OBJECT_DRAW_ATTACHMENTS is set, but not
DIRTY_OBJECT_DRAW_FRAMEBUFFER, the following happens with Vulkan:
- Handle DIRTY_OBJECT_DRAW_ATTACHMENTS
- TextureVk::initializeContents
- ImageHelper::stageResourceClearWithFormat
- Observer message to TextureVk->Texture->Framebuffer->Context
- Context sets DIRTY_OBJECT_DRAW_FRAMEBUFFER
- However syncDirtyObjects does not notice this bit, as it has cached
the dirty objects and is in the middle of looping over them
In the above scenario, the call that results in syncDirtyObjects does
not process the draw framebuffer (if not already dirty for some other
reason), meaning the clear is not applied _before_ the current operation
but after it (whenever framebuffer is synced next).
In this change, I attempted to ensure that if
DIRTY_OBJECT_DRAW_ATTACHMENTS is ever dirty,
DIRTY_OBJECT_DRAW_FRAMEBUFFER is also dirty. There were a few
operations that could theoretically lead to this which are fixed by this
change. The particular one that revealed the bug was
State::syncDirtyObject syncing only the FRAMEBUFFER bit and leaving the
ATTACHMENTS bit for the unsuspecting following operation.
The aforementioned assertion is not included in this change however, as
it revealed one unresolved issue with the d3d backend where
DIRTY_OBJECT_DRAW_ATTACHMENTS is not set, but processing
DIRTY_OBJECT_DRAW_ATTACHMENTS sets it while dirty bits are being
processed.
Bug: b/381284577
Change-Id: If3c35fbade069ae75f66dd6d4df5d73882a08a93
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6621059
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
92dec961
|
2025-05-15T00:00:00
|
|
Enforce validation consistency for lockless entry points
Bug: angleproject:406922380
Change-Id: If4e6051d0ac465f4ae8abca0a62cad14d1d739b7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6624114
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
ef29d42e
|
2025-05-22T15:52:49
|
|
Support ASTC decode mode extensions in ANGLE
Added support for GL_EXT_texture_compression_astc_decode_mode and
GL_EXT_texture_compression_astc_decode_mode_rgb9e5 in ANGLE. Also added
corresponding end-to-end tests for ASTC decode mode queries, including
ASTC decode mode queries and rendering with ASTC texture formats with
different decode modes on GL_TEXTURE_2D works.
Bug: angleproject:419403188
Change-Id: I0f2dced8468c4e25597740d1de346b2f699bb81e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6575285
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
392dc591
|
2025-05-15T00:00:00
|
|
Remove GL_CHROMIUM_sync_query
Fixed: angleproject:420627279
Change-Id: I26dac7c55a7cf6b04121658144e1387be65d2569
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6593552
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
7470cae4
|
2025-05-15T00:00:00
|
|
GL: Do not emulate EXT_base_instance
If a driver does not support the corresponding
commands, do not expose the extension at all,
regardless of the enabled features.
Bug: angleproject:355645824
Change-Id: Ideaae32e401c169690ca3aca6e437443a4b038f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580170
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
571450df
|
2025-05-15T16:24:12
|
|
Depth value not clamped for clearBufferfi and clearBufferfv
Clamp depth values to [0,1] for calls to glClearBufferfi and
glClearBufferfv.
Bug: angleproject:418030862
Change-Id: I6f5393da863a17c5fd1d78f1b800df0e61d3dc60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552161
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
bdaf87cf
|
2025-05-15T00:00:00
|
|
Enforce validation consistency
Asserted that:
* Exactly one error is generated
if validation fails.
* No error is generated
if validation passes.
Supported only for entry points with
autogenerated context support checks.
Lockless entry points are excluded for now.
Bug: angleproject:406922380
Change-Id: I7549c8011768b1aa311d843b1658005ca3aba3b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6568559
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
720f6bbe
|
2025-05-15T00:00:00
|
|
Fix attribute and uniform name validation
* Fixed null name error messages
to refer to correct parameters.
* BindUniformLocation
* Added name checks for null
and all reserved prefixes.
* Fixed error code for reserved prefixes.
* GetAttribLocation & GetUniformLocation
* Moved reserved prefixes check to the Context.
* Fixed and expanded tests.
Fixed: angleproject:418986804
Change-Id: I62760b3010fd38ee2e31e4ff88d9910647b329dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6568552
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
1e7442b2
|
2025-04-24T00:00:00
|
|
Fix KHR_debug operations
DebugMessageInsert:
* Used correct error message when the severity parameter
is invalid and aligned parameter validation order with
the command declaration.
DebugMessageInsert and PushDebugGroup:
* Fixed message length validation.
* Fixed message insertion when
the explicit length is zero.
Object[Ptr]Label:
* Fixed label length validation.
Added new tests.
Fixed: angleproject:417621246
Fixed: angleproject:417684698
Change-Id: I00cd939a83c5b9ae7dddefc51222278615bc0df9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6544152
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8d75490a
|
2025-05-08T00:00:00
|
|
Update zero length for debug marker commands
If the marker length passed to InsertEventMarkerEXT
or PushGroupMarkerEXT commands is zero, compute the
actual marker length in the Context so that the
backends could always rely on the passed length.
Bug: angleproject:408709155
Bug: angleproject:417757002
Change-Id: Ifa36d8d16c7c808855a7500556b569587cdc89a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6547538
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
64888cb8
|
2025-04-24T00:00:00
|
|
Align multiview extensions usage with the specs
As per the specs, the OVR_multiview2 extension requires
and implicitly enables the OVR_multiview extension.
Cleaned up the extension state checks
and added dependency tests.
No functional changes.
Fixed: angleproject:417173927
Change-Id: I67d2c19f4ed2f2450bf7fe2a92625cc9525ca020
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6535750
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
9ddb1b7f
|
2025-04-24T00:00:00
|
|
Disable OES_primitive_bounding_box on unsupported contexts
The OES_primitive_bounding_box extension requires
OpenGL ES 3.1 and must not be exposed on lower
context versions.
Also made both EXT and OES versions of this
extension enableable.
Bug: angleproject:42262238
Bug: angleproject:415495316
Change-Id: I5379daa06dba3b2b09d9656ffab15c010fb4870a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6538627
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
bf837e01
|
2025-04-24T00:00:00
|
|
Disable EXT_multi_draw_indirect on unsupported context versions
The EXT_multi_draw_indirect extension requires
OpenGL ES 3.1 and must not be exposed on lower
context versions.
Bug: angleproject:42264951
Change-Id: I7afc4541268f62f58bba33637df74efba47218c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6533713
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d221cf40
|
2025-04-24T00:00:00
|
|
Adjust EXT_base_instance emulation conditions
* EXT_base_instance may be emulated only on the
GL backend. Other backends either support it
directly or do not support at all.
* EXT_base_instance is never exposed to WebGL.
Bug: angleproject:355645824
Change-Id: I1edea83d83b1e6865eee8022c7110b05ea37d989
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6527730
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
27cfdf8e
|
2025-04-24T00:00:00
|
|
PLS: Allow type conversions in state queries
The OpenGL ES spec requires data conversions when a query
command is issued that returns a data type different from
the actual type of the requested state.
* Updated PLS state queries to follow the main spec.
* Removed PLS state query dependencies on interruptions.
* Fixed non-robust command declarations in the extension spec.
* Added missing extension support checks to robust commands.
* Drive-by: Fixed invalid use of assertions in PLS tests.
Fixed: angleproject:414361744
Fixed: angleproject:414506466
Change-Id: I573ab66d194d5666fd9c8845ac0ab262a714c5cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6507065
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
3b77a177
|
2025-04-23T15:47:07
|
|
Optimize vertex attribute and buffer state change
Bug: angleproject:386749841
Change-Id: I25968902282f6a201510e2ee17ea85fd71ef57c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6483915
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
ae70513d
|
2025-04-18T00:00:00
|
|
Remove NamedBufferStorageExternalEXT entry point
OpenGL ES does not support DSA.
Bug: angleproject:407932145
Change-Id: If5f544de2b43e05888415a4fc805ad6065d4408b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6495409
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
4c1c7c08
|
2025-04-18T00:00:00
|
|
Include entry point names in error messages
Moved entry point name injection to ErrorSet::validationError
to ensure that error messages handled via GL_KHR_debug always
contain the corresponding entry point names.
Updated affected tests.
Fixed: angleproject:412384507
Change-Id: I9e898cadca0634505d70b36dbbb00feedb6c10b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6480177
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
4b9525b2
|
2025-04-04T00:00:00
|
|
Remove all getClientMajorVersion helpers
Client version checks should use
proper struct compare operations.
Bug: angleproject:408843436
Change-Id: I92cd91d1e7e6daa761f79060835aa534c5671264
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6467460
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
408f5853
|
2025-04-04T00:00:00
|
|
Make gl::Version data members private
* Further simplified gl::Version implementation by
making data members private and merging them.
* Used proper version struct comparisons instead
of accessing individual version components.
* Moved known version constants to Version.h
for broader availability.
* Removed no longer used helpers:
* PrivateState::getClientMinorVersion()
* State::getClientMinorVersion()
* Context::getClientMinorVersion()
Bug: angleproject:408843436
Change-Id: I3ae8f495269d649253fa2381ecbfc018a184fa20
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6460787
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
cf7eeec2
|
2025-04-04T00:00:00
|
|
Simplify client version compare operations
Packed client context version struct into two bytes
and defined specialized compare operations instead
of using std::tie.
Bug: angleproject:408843436
Change-Id: Ic7d91f171a3bce40d46b9cfd3c65d1fc3d3f568c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6432439
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
33e035f9
|
2025-04-04T00:00:00
|
|
Enforce correct usage of gl::Version
In preparation for the implementation update,
ensured that gl::Version struct is always
initialized with 8-bit values.
Bug: angleproject:408843436
Change-Id: Idcc925b49cadc7fdc4f05ff2acaed8020e72a32e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6458758
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
e39bcdc3
|
2025-04-09T17:26:34
|
|
Support GLES query counter bits
ANGLE only support query GL_QUERY_COUNTER_BITS_EXT
with TIME_ELAPSED_EXT or TIMESTAMP_EXT, but other targets
should also be supported. Since the values are stored in
32 bits, we just return 32 for other target. An end2end
test is added.
Bug: angleproject:409674598
Change-Id: I98941f4dd36ef62c57bcb87475ebb9f626c1bbf9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6437686
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
a3f2545f
|
2025-04-11T14:03:08
|
|
Tests that exercise overwriting textures while in use
The first three tests are credit Cheryl Wei <@arm.com>, adopted from
https://chromium-review.googlesource.com/c/angle/angle/+/3366193
The change also exposed the fact that the force_fallback_format with
ASTC leads to assertion failure if ASTC emulation is not built. This
change adjusts the format table to fix that as well.
Bug: angleproject:42265356
Change-Id: Ib68355f317472d8cc3f035b492b273ac452a8217
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6447202
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
5dd05578
|
2025-04-14T07:34:57
|
|
Revert "GL: Allow untranslated shaders to pass through on GLES"
This reverts commit 4e77552b86a89b449ada6d6c18f84285f5812b1d.
Reason for revert: breaks ChromeOS and fuzzers
Bug: angleproject:398857482
Original change's description:
> GL: Allow untranslated shaders to pass through on GLES
>
> Add an EGL extension EGL_ANGLE_create_context_passthrough_shaders which
> uses the NULL translator and passes the original shader to the driver.
> The parser is still used for shader reflection.
>
> Bug: angleproject:398857482
> Change-Id: I7c5fcc318c7e11931f78c08dcbf4764bf77d397d
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6297527
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Bug: angleproject:398857482, angleproject:410423936
Bug: chromium:410114655, chromium:410100607, chromium:410121218
Bug: chromium:410052365, chromium:410290507, chromium:410178288
No-Presubmit: true
Change-Id: I45b01960637a1cda05d21a7df6d07465f6a8f5e9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6448984
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
4e77552b
|
2025-02-24T18:04:32
|
|
GL: Allow untranslated shaders to pass through on GLES
Add an EGL extension EGL_ANGLE_create_context_passthrough_shaders which
uses the NULL translator and passes the original shader to the driver.
The parser is still used for shader reflection.
Bug: angleproject:398857482
Change-Id: I7c5fcc318c7e11931f78c08dcbf4764bf77d397d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6297527
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
cbd6cdc9
|
2025-03-28T00:00:00
|
|
Ensure CopyTexImageParameters validation consistency
* Validation must succeed for no-op commands.
* Moved no-op conditions handling to the Context.
Bug: angleproject:406922380
Change-Id: I9102955198b755844d05c0c4f07832664ff24100
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6439412
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
6e992fa2
|
2025-03-28T00:00:00
|
|
Ensure consistency of context lost aware validation
Some commands must generate CONTEXT_LOST
but still return a value.
Moved error generation to the Context
to ensure validation consistency.
Bug: angleproject:406922380
Change-Id: Ie5dae39bada951366afb86cab4324f2247c84ab7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433684
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
01d1c7b4
|
2025-03-28T00:00:00
|
|
Ensure EXT_debug_marker validation consistency
* Moved no-op conditions handling to the Context.
* Removed redundant comments.
Bug: angleproject:406922380
Change-Id: I1064312b2e5940d6b97c95f22544bbc9749fc1ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433224
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
12dd42b8
|
2025-04-04T09:54:12
|
|
Reduce number of function calls in glVertexAttribPointer
Small but noticeable improvement in a synthetic test on Android
Bug: b/383305597
Change-Id: I6e88a06f4d3bf2e0b51ee1fd3f4f26bf55d9364e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6432611
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
eb52b568
|
2025-03-28T00:00:00
|
|
Remove unsupported 1D and DSA entry points
OpenGL ES does not support 1D textures,
removed TexStorage1DEXT.
OpenGL ES does not support DSA, removed
EGLImageTargetTextureStorageEXT.
Added an explicit command blocklist.
Added hashes for *_vulkan_secondaries_* def files.
Fixed: angleproject:407932145
Change-Id: Iec34fa475f34a0fa832a49223c51ff1f87b1915d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6426049
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
c9956ce0
|
2025-04-01T16:35:32
|
|
Capture: unMakeCurrent before destroying a context
In preparation for a change where unMakeCurrent can act like swap to
capture contents in applications that don't actually call swap.
Bug: b/381284577
Change-Id: I6449590f90964107c5f0feb82cbe29d26bbd0d9d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6422891
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
9b471972
|
2025-03-28T00:00:00
|
|
Ensure ValidateTexStorageAttribs* entry points consistency
Invalid calls must not reach the context.
The corresponding extension requires OpenGL ES 3.0.
Bug: angleproject:406922380
Change-Id: I8e19a192b536a384c36514e6cab226ee0663edd3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6419162
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
184a389f
|
2025-03-27T00:00:00
|
|
Ensure program state for indirect draw entry points
If the currently bound program is being relinked,
Context::prepareForDraw needs to wait until it's
ready before syncing the backend state.
Added the required logic and no-op handling
to indirect draw entry points.
Fixed: angleproject:406935597
Change-Id: I82fb426b02a275bc67f71f9bd07484fa5802bc09
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6404481
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
799d301f
|
2025-03-27T00:00:00
|
|
Ensure program state for multi-draw entry points
If the currently bound program is being relinked,
Context::prepareForDraw needs to wait until it's
ready before syncing the backend state.
Aligned all three no-op draw context helpers.
Fixed: angleproject:406814763
Change-Id: I10eed90bb2fe853b558291fc8fe17d13652e0420
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6405536
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
1b494f3d
|
2025-03-11T19:40:51
|
|
Add validation of null pointers for certain APIs
Bug: angleproject:397315932
Change-Id: I1b4758e326efd2e28d5a4f589c7b156065594911
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6342394
Auto-Submit: Robic Sun <Robic.Sun@arm.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
292bb458
|
2025-03-14T12:17:49
|
|
Cut MAX_COLOR_ATTACHMENTS_WITH_ACTIVE_PIXEL_LOCAL_STORAGE_ANGLE
Since the number of real devices that support framebuffer fetch, but do
not support draw_buffers_indexed, is effectively zero,
MAX_COLOR_ATTACHMENTS_WITH_ACTIVE_PIXEL_LOCAL_STORAGE_ANGLE is an
unnecessary complication. These hypothetical devices can fall back on
shader images or just not support pixel local storage at all.
This closes the door for WEBGL_shader_pixel_local_storage to ever be
implemented on top of the ES2 extension that inspired it all,
EXT_shader_pixel_local_storage, but WebGL can just use framebuffer fetch
instead, or maybe even EXT_shader_pixel_local_storage2 some day.
This dramatically simplifies the WEBGL_shader_pixel_local_storage
extension.
Bug: angleproject:40096838
Change-Id: I9c51f2ce000620f883cb7917d4e8618c8e9ee803
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6354657
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
|
|
|
ae71cc1c
|
2025-03-11T16:36:52
|
|
Don't destroy blend or color mask state in PLS
The browser caches this state, so conditionally destroying it would
invalidate the browser's cache. Instead, cache modifications to
overridden PLS blend & color mask state in ContextPrivateState, and
restore it upon ending PLS.
Also update the spec to specify that FRAMEBUFFER_DEFAULT_WIDTH and
FRAMEBUFFER_DEFAULT_HEIGHT may be overridden during PLS in ES 3.1.
Bug: angleproject:40096838
Change-Id: Ic2c0aa6dc33ada7350e15e27bef22c79ca5f6c7f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6350727
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Commit-Queue: Chris Dalton <chris@rive.app>
|
|
|
5c2789e0
|
2025-03-14T15:17:30
|
|
Inline Context::uniform*
(most of?) these are called exactly once, such as
GL_Uniform2f [entry_points_gles_2_0_autogen.cpp]
Context::uniform2f [Context.cpp]
ProgramExecutable::setUniform2fv [ProgramExecutable.cpp]
Note how due to the different translation units each of these becomes a
separate function, and the intermediate one (uniform2f) is completely
unnecessary as it's only called by GL_Uniform2f. This CL reduces
the .so size a bit and improves code locality by avoiding
the intermediate functions.
Bug: b/383305597
Change-Id: Ia4afe651fabd25e55cd19a30bca71891d3e5a34a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6355328
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
fbb1829d
|
2024-12-08T01:46:39
|
|
Allow glClear while PLS is active
It just makes sure to not clear any draw buffers that may be in use for
pixel local storage.
Bug: angleproject:402810076
Bug: angleproject:40096838
Bug: angleproject:42266150
Change-Id: I60a573d5e9e5dbadce12d79e3f4b6fc57747e655
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6312336
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
|
|
|
1ead4cbd
|
2025-03-07T09:49:21
|
|
Allow texture modification commands while PLS is active
Just do a little extra validation and bounce modifications if they would
modify an active PLS plane.
Bug: angleproject:40096838
Change-Id: I6f27951f5d0ef5dfaf23b5a005a2d94a749e2c4f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6337703
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
|
|
|
85fe2671
|
2025-02-25T16:54:20
|
|
Set length or infoLog when they are not NULL
For glGetProgramPipelineInfoLog, spec says that if length is NULL,
then no length is returned. Also do this to infoLog to avoid crash.
Bug: angleproject:398904340
Change-Id: I1f87a8932f72a0d5c44c2344936ee18c674a802b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6300356
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
9bdc6763
|
2025-03-03T15:54:46
|
|
GetProgramPipelineiv may create a new state vector
For glGetProgramPipelineiv, spec says that If pipeline is a name
that has been generated (without subsequent deletion) by
GenProgramPipelines, but refers to a program pipeline object that
has not been previously bound, the GL first creates a new state
vector in the same manner as when BindProgramPipeline creates a new
program pipeline object.
Also creates a new state vector in glValidateProgramPipeline if the
pipeline has not been previously bound.
Modify the ProgramPipeline's validate function so that when the
program pipeline is generated, but has never been bound, the
validation status would be false.
Bug: angleproject:400254603
Change-Id: I906669a4e80aa12283156bae8a72a2dbf0b63b90
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6316349
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
be98f841
|
2024-11-30T02:11:05
|
|
Implicitly end PLS for framebuffer reads and writes
In preparation for removing the PLS allow list, convert more problematic
methods to the new paradigm of implicitly ending PLS instead of
generating errors.
Also simplify the disable logic for framebuffer modifications, and just
blindly disable PLS for framebuffer updates, regardless of whether it's
GL_READ_FRAMEBUFFER or GL_DRAW_FRAMEBUFFER.
Bug: angleproject:40096838
Change-Id: Ie4390a219f5f05ef0a3d00f405d4914592726283
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6077335
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b32a808d
|
2025-02-03T17:35:59
|
|
Re-enable EXT_multi_draw_indirect on the Vulkan backend.
Update limitations before evaluating extension support
Bug: angleproject:355645824
Change-Id: If34c0d5791443841798fd85a2d396b8b6cbbe837
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6226331
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
7d37d970
|
2025-01-30T13:47:59
|
|
Make error messages end in a dot
Some messages had dot and some not.
Fix by adding dot to all error message string literals.
Best effort, for free form string literals, check ANGLE_CHECK invocation
sites only.
Bug: angleproject:392938089
Change-Id: Idedc3fe1d1e186fb91b5e54407df87f6830995a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6218460
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
cfe87e34
|
2024-12-16T16:29:39
|
|
Add multisample support for glCopyImageSubDataEXT
As GL_TEXTURE_2D_MULTISAMPLE/GL_TEXTURE_2D_MULTISAMPLE_ARRAY
been introduced by GLES3.1, glCopyImageSubDataEXT should support
those types.
Bug: angleproject:381727390
Change-Id: Ib3571ea38dc8d8ceb1bc9ad0c8a6e04d28b0ec33
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6146194
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
c10f5e3f
|
2025-01-08T10:04:39
|
|
Debug: Allow forcing GL_VERSION string
Similar to forcing renderer and vendor, useful for debug.
Bug: b/388459021
Change-Id: If00128369cf26069708e8db06c5e17b7ad0bdb58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6157784
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Cody Northrop <cnorthrop@google.com>
|
|
|
465299fb
|
2025-01-06T16:49:15
|
|
context_private_call.cpp -> context_private_call.inl.h
Most functions are trivial wrappers resulting in unnecessary forwarding
calls. Most are called exactly once from entry points autogen.
This _reduces_ the .so size by ~14KB and I'm seeing 1-2% better frame
time in my driver_overhead_2 tests on a mobile device.
Bug: b/383305597
Change-Id: I1f2a048e067c76993bacfbbce655fc1c898fdba7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149814
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
195c3a20
|
2024-12-19T19:09:38
|
|
Inline non-PPO getActiveLinkedProgram and ValidateUniform1-4*
The non-PPO part of getActiveLinkedProgram is small, and
ValidateUniform1-4* are just a single call to ValidateUniform, and end
up an actual function call due to being located in a different
translation unit (validationES.cpp vs validationES2.cpp)
Estimated 0.5-1% improvement to driver_overhead_2 wall_time on pixel 8
Bug: b/383305597
Change-Id: I256bf11952f36bbd5033f191df19aa293dbeefdf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108030
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
87d891dc
|
2024-12-13T19:51:42
|
|
Inline more tiny functions on hot path
Similar to https://crrev.com/c/6094283, not as hot but broader.
Highlighted by PGO profile of driver_overhead_2 trace combined with size
and offset of the corresponding .so sections to maximize reduction in
TLB misses.
Improves driver_overhead_2 performance by 1~2% on Pixel 8. Almost no
change in .so size as functions are tiny.
Bug: b/383305597
Change-Id: Ib1c021d4635141b879667b59305e4d45de7b8aef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6088958
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
6bb1bc9b
|
2024-12-10T16:56:33
|
|
Add an extension to report total memory usage of all GL objects
Currently the extension will only count GL buffers, textures and
render buffers' memory.
Fixed: angleproject:383256300
Change-Id: I33ce6fafae8aa5b60071e66366d35dc098e1313b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6084013
Auto-Submit: Quyen Le <lehoangquyen@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
|
|
|
e82a2eab
|
2024-11-28T00:00:00
|
|
Support multisample 2D array textures on ES 3.0 contexts
Supported via OES_texture_storage_multisample_2d_array
enabled together with ANGLE_texture_multisample.
Drive-by:
Fixed exposure conditions in the OpenGL
backend to match the implementation.
Fixed: angleproject:382298321
Change-Id: I21b037aac7bebc35df267e9dd468088ebce35e71
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6075241
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
cc841237
|
2024-11-29T13:45:50
|
|
Accept framebuffer modifications while PLS is active
The only way for a WebGL implementation to know if PLS is actually
active is to call glGetIntegerv(PIXEL_LOCAL_STORAGE_ACTIVE_PLANES_ANGLE)
(because glBeginPixelLocalStorageANGLE() can fail). So the original
behavior of not allowing glBindFramebuffer() et. al. while PLS was
active created a state scenario that was expensive for the browser to
track.
Instead, just allow glBindFramebuffer() et. al., and implicitly disable
PLS if they are called while it's active.
Bug: angleproject:40096838
Change-Id: Ibd303f9f9950fb5b7f1add2d41882e4379c51e62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6060301
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
0bb109aa
|
2024-11-28T00:00:00
|
|
Fix validation for 2D multisample array textures
* Fixes:
* TEXTURE_BINDING_2D_MULTISAMPLE_ARRAY query must
be rejected if the functionality is not enabled.
* GetInternalFormativ must accept TEXTURE_2D_MULTISAMPLE_ARRAY
on unextended OpenGL ES 3.2 contexts.
* Added validation to the OpenGL ES 3.2 TexStorage3DMultisample
entry point.
* Cleanups:
* Removed OES suffix from the enum conversion.
* Incorrect extension name in the error message.
* Do not create a 2D multisample array zero texture object
if the backend does not support the functionality.
* Replaced redundant FramebufferTexture validation with an assertion.
* Do not allocate texture binding vectors for 2D multisample array
textures if the backend does not support the functionality.
* Aligned the 2D multisample array texture target assert in
RecordBindTextureTypeError with the actual error condition.
Fixed: angleproject:381270278
Change-Id: Idbbc86e2efe1bbc25d9570d515b67c1a32255d99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6063068
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
7070a9e9
|
2024-11-20T00:21:16
|
|
Remove draw buffer validation clauses from PLS
It was cumbersome to implement all this validation browser side for
WebGL.
Rather than making it an error to update blend and color mask on
reserved PLS draw buffers, glBeginPixelLocalStorageANGLE() can just
implicitly disable blend, and enable the color mask on overridden draw
buffers. Later calls to enable blend or change the color mask on
overridden planes are silently ignored until
glEndPixelLocalStorageANGLE().
Bug: angleproject:40096838
Change-Id: Ic7e1c5113e7d3fad3b80d0178075df646540d743
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6045421
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
|
|
5d3d299d
|
2024-11-25T16:35:51
|
|
Expose the required GLES1.0/1.1 extensions in ANGLE
Exposed below extensions:
GL_OES_texture_mirrored_repeat
GL_OES_blend_subtract
Bug: angleproject:380704155
Change-Id: Ib095f9bfaabda92bb2c588d633f1512e118f066e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6038450
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
01dee1cb
|
2024-10-14T15:04:28
|
|
Add implementation for GL_EXT_texture_storage_compression
Bug: angleproject:352364583
Change-Id: I3dab4c68d5d0206d681e165e991217bd3de8eeb6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6011055
Auto-Submit: Neil Zhang <Neil.Zhang@arm.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
52fa6779
|
2024-11-14T00:00:00
|
|
Refactor indexed parameter query validation
* Moved indexed parameter validation to queryutils.
* Fixed indexed blend state enums being disallowed
on unextended OpenGL ES 3.2 contexts.
* Replaced redundant validations with assertions.
Fixed: angleproject:380291906
Change-Id: I4d5a9c01be5a00cd834504b38a3ddaeb5fa4edb9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6043710
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
9c202275
|
2024-11-14T00:00:00
|
|
Fix SAMPLE_MASK_VALUE indexed query validation
The SAMPLE_MASK_VALUE enum must be accepted
when ANGLE_texture_multisample is enabled.
Fixed: angleproject:380291919
Change-Id: Ieb834ca4c78982fbf1a121c0a70db7413574679a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6038524
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
8a2b60b2
|
2024-11-06T17:13:16
|
|
Add stubs for GL_EXT_texture_storage_compression
Bug: angleproject:352364583
Change-Id: I607c19c0c9bec7f0e3dd325e44b42e73f826b61c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5998012
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
cc2edfd1
|
2024-11-05T15:37:21
|
|
Fix getPerfMonitorCounterData maxResults, skip AsyncCommandQueue test
Skips TextureDataInLoopManyTimes on SwS AsyncCommandQueue.
Add more debug info to the test although without the AsyncCommandQueue
variant we likely won't be see flakes.
Bug: angleproject:377503738
Change-Id: I372531451c280b04ffed84b020463657440fca08
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5995531
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Roman Lavrov <romanl@google.com>
|
|
02f88b31
|
2024-10-30T21:49:19
|
|
Improve CanSupportAEP Error Reporting
This change improves the error reporting for the `CanSupportAEP`
function. Previously, if the function returned false, it was difficult
to determine which requirement was not met. This change adds logging
that will list all unmet requirements, making it easier to debug AEP
support issues.
For Chromium logs, this logging is too much. Therefore, a switch is
used and by default the logging is off. ref:
https://crrev.com/c/5979208?tab=comments
Test: the default presubmit
Bug: b/268108262
Change-Id: I7f633cdb63f9cfeb501cd5f134b0ea7874465aed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5979292
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
63f5a328
|
2024-10-30T14:40:40
|
|
Revert "Improve CanSupportAEP Error Reporting"
This reverts commit fb655e43f4a86fbdf35bf0cb5d2978d728b949d9.
Reason for revert: Causes excessive logging and leads to flakiness
in Chromium
Original change's description:
> Improve CanSupportAEP Error Reporting
>
> This change improves the error reporting for the `CanSupportAEP`
> function. Previously, if the function returned false, it was difficult
> to determine which requirement was not met. This change adds logging
> that will list all unmet requirements, making it easier to debug AEP
> support issues.
>
> Test: the default presubmit
> Bug: b/268108262
> Change-Id: I48eb6b26358ca4991d760523f44568d97e8c35a6
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5972497
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Solti Ho <solti@google.com>
> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Bug: b/268108262
Bug: chromium:376380430
Bug: chromium:40266306
Change-Id: Ic5b1bbce16fe5c98af10ca0554d1035206d5c592
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5979208
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
fb655e43
|
2024-10-28T21:45:41
|
|
Improve CanSupportAEP Error Reporting
This change improves the error reporting for the `CanSupportAEP`
function. Previously, if the function returned false, it was difficult
to determine which requirement was not met. This change adds logging
that will list all unmet requirements, making it easier to debug AEP
support issues.
Test: the default presubmit
Bug: b/268108262
Change-Id: I48eb6b26358ca4991d760523f44568d97e8c35a6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5972497
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Solti Ho <solti@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
ef55ca0a
|
2024-10-17T14:44:22
|
|
Update copy validation regarding ext textures
* Updated the validation functions for the following function to
accept TEXTURE_EXTERNAL_OES: glCopyImageSubDataEXT()
* Updated unit test CopyTextureTestES3.CopyImageSubDataToEGLImage
* Using TEXTURE_EXTERNAL_OES as target for glFramebufferTexture2D()
requires EXT_YUV_target. Therefore, the texture related to it is
used instead.
Bug: angleproject:361372990
Change-Id: I905d4cf89522ae3158516b42b15705d1044c6e97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5940404
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
ab1cdd22
|
2024-10-03T00:00:00
|
|
Translator: Support EXT_texture_query_lod
No backend support yet.
Bug: angleproject:368275901
Change-Id: I10bbc03feca485908315633cbc0f955e82994657
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5920240
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
c9606f00
|
2024-10-07T10:15:14
|
|
Fix extensions moved to core in GLES 3.2
The GL_EXT_texture_cube_map_array, GL_EXT_texture_buffer, and
GL_OES_texture_storage_multisample_2d_array extensions were moved
into core in ES3.2, but validation still required enabling
extensions. Added 3.2 as a sufficiency.
Test: angle_end2end_tests --gtest_filter=*CompressedTexImageCubeMapArray*
Bug: b/371940347
Change-Id: Ie73a76087b6b52775d44ae79efd7f48e9fc90eb9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912120
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
|
|
|
aec90a8d
|
2024-10-07T10:56:24
|
|
Fix ignoring blit bits when attachments are missing
GLES requires that the bits provided to glBlitFramebuffer are silently
ignored if either the read or draw framebuffer is missing the
corresponding attachment.
In WebGL, this is forbidden. ANGLE was forbidding this because of
WebGL, but a recent CTS test revealed that we shouldn't be doing that
when !WebGL.
Bug: angleproject:370917919
Change-Id: I202fbf665d8a102f0aea72709b80dfdabeb71a2e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912614
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
166b72c9
|
2024-09-30T19:07:26
|
|
GL_ANGLE_blob_cache implementation.
Bug: chromium:370538323
Change-Id: Ic51a951e78b48b315e36f518bcc39ff2d54660a6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5900761
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
492cf265
|
2024-09-27T13:44:22
|
|
Stubs for GL_blob_cache_angle
Bug: chromium:370538323
Change-Id: Ib56b28c24305db8931f382b16a24975b7277fa7e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5900760
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|