Log

Author Commit Date CI Message
Sean Feng 7280d3d1 2025-10-14T09:56:58 Turn off preferSubmitAtFBOBoundary and add early submit logic Disabling preferSubmitAtFBOBoundary for MALI GPUs and submit pending commands at the draw call time if the number of write-commands in the current render pass reaches a threshold to avoid delaying the submission too much. Bug: angleproject:447444701 Change-Id: I413a4beb7147afd4f064286433a76014b19a49c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6994438 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Sean Feng <Sean.Feng@arm.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
hoonee.cho 2027314b 2025-08-26T17:07:27 CL/Vulkan: Enable OpenCL kernel printf in logcat Added `__android_log_write` for kernel print output buffer in case of android build Bug: angleproject:433980940 Change-Id: I4eac408076c3b4d804949724eff439137172fa54 Signed-off-by: hoonee.cho <hoonee.cho@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6981095 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Austin Annestrand 54409f2b 2025-09-22T15:00:59 cl/vk: Autogen image order and types Adding ANGLE packed enums for image order and types. Bug: angleproject:447192713 Change-Id: I92950330cbaabc48b3c481d5ce3616a3c0030259 Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6980531 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Sunny Sachanandani 774bca93 2025-10-08T18:41:13 [metal] Add commands scheduled sync object We need a thread-safe way to wait for ANGLE Metal command buffers to be scheduled for IOSurface synchronization with DrDC + Graphite on Mac. The existing eglWaitUntilWorkScheduledANGLE API isn't thread-safe as it reaches into ContextMtl innards to flush the command buffer. This CL adds the EGL_ANGLE_metal_commands_scheduled_sync extension which introduces a EGL_SYNC_METAL_COMMANDS_SCHEDULED_ANGLE sync object type. This sync object is signaled when pending Metal commands are scheduled to run on the GPU (MTLCommandBufferStatusScheduled). These sync objects are thread-safe - eglClientWaitSync() can be called on any thread even without a current context which is needed for DrDC + Graphite on Mac. Bug: chromium:444702048 Change-Id: Ia13b352385a6fefaa026526ef74f6e596a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7027996 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Shahbaz Youssefi e5b0553a 2025-10-08T15:18:25 Translator: Validate TCS barrier() rules during parse ... instead of doing an AST walk after parse. Bug: angleproject:349994211 Change-Id: I175fecb593ac701208c20f77bb8dd3987c63fa11 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7022014 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi bf63a4ef 2025-10-08T15:13:58 Translator: Track control flow during parse This change adds a stack to track control flow structures. Currently, this replaces the loop/switch nesting level validation and may look unnecessary, but a number of other post-parse validation will be moved to parse-time and build on this stack. Bug: angleproject:349994211 Change-Id: I841ce780f22410055feedb3194c24d84871a89cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7022013 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Austin Annestrand c1ae67dc 2025-08-18T17:26:21 cl/vk: Introduce Int64 Atomic support Checks for VK_KHR_shader_atomic_int64 and enables/reports the following if supported: cl_khr_int64_base_atomics cl_khr_int64_extended_atomics Bug: angleproject:447192709 Change-Id: I47102efd3e269d518558993f6068bfc4f9dd79b6 Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6981099 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 4b5f4da6 2025-10-14T12:31:26 Don't roll CLSPV binary blobs into Android. Bug: angleproject:440837006 Change-Id: I2c0027503c08317d1027f46f683e037f3cef72a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7036480 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 13e0c3ba 2025-10-14T10:01:51 Roll vulkan-deps from ac55dee5b314 to bb498dc53b8b (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ac55dee5b314..bb498dc53b8b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/40fdef426201fa25c5847e18d96d8f28f29a5195..4a40e3cf16b35a5bc807e5f9b63913d6265bc08f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/1974ee2f21dcc4abf589b08f29ac6acb43e9bec4..706e40e47d58b7ad285325de66b439cc1c6cb926 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I769a2826d718c90e4585e7f5f54904995eb66b73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7040301 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b8705ede 2025-10-14T07:01:29 Roll Chromium from 76e5315e52d7 to b06dc5b80506 (3284 revisions) https://chromium.googlesource.com/chromium/src.git/+log/76e5315e52d7..b06dc5b80506 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b7a355a6a8..02d98ae43e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fb3a6ce2c0..0e7d35148b * buildtools/linux64: git_revision:81b24e01531ecf0eff12ec9359a555ec3944ec4e..git_revision:07d3c6f4dc290fae5ca6152ebcb37d6815c411ab * buildtools/mac: git_revision:81b24e01531ecf0eff12ec9359a555ec3944ec4e..git_revision:07d3c6f4dc290fae5ca6152ebcb37d6815c411ab * buildtools/reclient: re_client_version:0.183.0.3b3097cd-gomaip..re_client_version:0.185.0.db415f21-gomaip * buildtools/win: git_revision:81b24e01531ecf0eff12ec9359a555ec3944ec4e..git_revision:07d3c6f4dc290fae5ca6152ebcb37d6815c411ab * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2e7f14e409..29a6541860 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8bb2433661..5b92b04a2e * third_party/android_build_tools/error_prone/cipd: hWbH4ETtqHXUYdBJc_KBLXq1CEjQFmQylyHVQUszCSkC..9sXUoP-IaXADzp7Q3pyXAmX-zszzSVd7t2QValkkss8C * third_party/android_build_tools/lint/cipd: VyDrZ5fyFW5p9gU-4TnLHv97fdDn07NGu0uZMhZ5gfsC..C_UyTSgBkjVqJQT8fiVHvbfR7cv95m-EWNgFd-ZIqZkC * third_party/android_build_tools/manifest_merger/cipd: 4cITVa3bS61rDFtbh_QoflvqlRrM-KrtViIyD4QEgjYC..UVOeU4qVAlqzi1egh2W5_YKXJDam0q7Zdmb_KBQwY5MC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/2c5a610ceb..46884bd8a8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f724a59d02..2f71f97f0b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/276ae56a8e..f39ee3c673 * third_party/fuchsia-sdk/sdk: version:29.20251004.3.1..version:29.20251011.3.1 * third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/244cec869d..2ce9d8f2e8 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/cc5f928de9..dc1441a0c2 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/864f61dc92..8e720a3a3a * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/6dc2f29f93..da8737e079 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/b53ec82f9c..8ab123717d * third_party/r8/cipd: 2aBDG942g42qUBPPInGETRHusdxru1U3anwJI_QX5wIC..AYeAI5FH_WyqBwnhCmq8W1k-pGRyIkxmRN7PbMErE7EC * third_party/r8/d8/cipd: llWUebGsQPrzc7z3fwJF78NcrdGs1wrUhy0Y-0Wrb-4C..2aBDG942g42qUBPPInGETRHusdxru1U3anwJI_QX5wIC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/bc122a79f1..e46f654c34 * third_party/siso/cipd: git_revision:2eee1d6feaab76d99397d4d840bd369a428c01ea..git_revision:f24720f1320c0b85feea49cb5f1207be7555deee * third_party/turbine/cipd: UPK1OhajOS06r3w9iwxehBFg7pbTwe9mgMcGkY6-VsEC..EHj3lVL72PrpZUDnsWnaS5rdJuF5o1QYrJ7CUhO3MIEC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/88ffc02cc7..3f96d7c6f8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cbc2b48ed7..e45d2e250f * tools/luci-go: git_revision:6645da847edf4e1ebcfe8cf4d860ad75e63b20cb..git_revision:4305585b28910a1c5951f82f6172f1b41b9567bb * tools/luci-go: git_revision:6645da847edf4e1ebcfe8cf4d860ad75e63b20cb..git_revision:4305585b28910a1c5951f82f6172f1b41b9567bb * tools/luci-go: git_revision:6645da847edf4e1ebcfe8cf4d860ad75e63b20cb..git_revision:4305585b28910a1c5951f82f6172f1b41b9567bb * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d607462aad..9a60e547b0 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/0eaaeed1ca..6fee1a98d0 * tools/skia_goldctl/linux: fRuslzP17fJiIrNMmrGUnphvWkc8jcmavhAEtbG5_IgC..bTgdJ5iJ9Q1bs9AkaKovnVM-XYfhsatv85lPa6rkOekC * tools/skia_goldctl/mac_amd64: RIjp_6aODKNgiyQW90GtpE3kM2NGlSW6B33OdAlPwnYC..wetQXYEiavcQRTJewJNyJm4bpsfUC5IVHxQGNMiZ54gC * tools/skia_goldctl/mac_arm64: _Ufwu0yprCm3Au8mKCt_ahugJqb3ImjdAVQceH7bbFUC..yZVTeqmfUoCss6wv6VH54bs2RpmfRa-AZRVsqQNZzx0C * tools/skia_goldctl/win: 7tIc3ckW4E5m2fK83LYxUD2PDwpKEvuZiFUSYUTLY5gC..zRSTxf1IEwyMpKAMPC4yX7nBIhJWI0g4qNscHxsz_GAC No update to Clang. Bug: angleproject:3684,angleproject:4417 Tbr: cnorthrop@google.com Change-Id: I5942dba1f56d1fd40cd1967aed842ee3db6f6c65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7038474 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 104f0e68 2025-10-13T21:20:39 Tests: Add Umamusume: Pretty Derby trace Test: angle_trace_tests --gtest_filter=*umamusume_pretty_derby Bug: b/451770108 Change-Id: I6704c89a0c65f8eb233e54784ef57259b4e0d5da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7039199 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 315b9cb6 2025-10-09T19:30:33 third_party/clspv: Update clspv (10/9/2025) Rolls clspv and llvm: clspv: 8f35aa835ae973e1c802421ba5a873f5e967278c llvm: fd9a1dcc01766c71932898e9643ce28bf2801bad Bug: angleproject:440837006 Change-Id: I740a2888ce9cbb4426865b556b1ed76ed92fe428 Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7030045 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
hoonee cho 4d52bedb 2025-08-12T00:28:48 CL/Vulkan: Add 3.0 atomic memory order feature macros With OpenCL 3.0, generic atomic_{load,store} functions are defined with memory_order_seq_cst and memory_scope_device as memory order and scope. For these corresponding feature macros need to be enabled. Setting them up accordingly. Bug: angleproject:379669750 Change-Id: I355cf4107fee10d203837ca0aa4a9f473cd81929 Signed-off-by: hoonee.cho <hoonee.cho@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6981092 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
hoonee.cho 7c7fcb92 2025-07-14T07:56:22 CL/Vulkan: Allocate descriptor sets under lock Multiple threads in the application are accessing the OpenCL runtime simultaneously, resulting in multiple SharedPtr of mDynamicDescriptorPools[] being created for a single context. This can lead to incorrect reference counting and potentially cause `DynamicDescriptorPool::destroy` to be called unexpectedly. This fixes the concurrent access issue through acquiring the descriptor set mutex just before initializing mDynamicDescriptorPools to ensure that only one mDynamicDescriptorPools[] is created per context. Bug: angleproject:383999367 Tests-Passing: test_integer_ops int_logic Change-Id: Iba0fad6813a08e1631b73d5efae4f4639892b36f Signed-off-by: hoonee.cho <hoonee.cho@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6981091 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Gowtham Tammana e9e17890 2025-09-24T15:21:17 CL/Vulkan: Make CommandsStateMap as self contained The `CommandsStateMap` object is used to capture all the state that needs post-processing after a command batch is finished. Making this as a standalone object. Bug: angleproject:446112158 Change-Id: I1f33741da15fe32aae06cba79650dc76426490d5 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6981090 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuxin Hu 80130da0 2025-10-01T14:53:23 Vulkan: Enable recycleVkEvent on swiftshader Given that no GPU has reported that vkCreateEvent() + vkDestroyEvent() has more overhead than vkCmdResetEvent(), we will keep the recycleVkEvent feature flag off on all major hardware. Enable the recycleVkEvent feature on swiftshader so we can test the VkEvent recycle code path. Bug: b/440066521 Change-Id: I0eb30ea9a01e287664effa33cef5227f9f438a56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7004937 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Gowtham Tammana 45b0571e 2025-09-24T15:20:53 Vulkan: Add barrier log only when present Bug: angleproject:446112158 Change-Id: I4eb94c1514df5a2eaec70267e2dbbd5a1c2579bd Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6975005 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Gowtham Tammana ea35293a 2025-04-14T15:52:02 CL/Vulkan: Dump commandstream on request Dump the command stream to stdout when feature flag `debug_cl_dump_command_stream` is enabled. Bug: angleproject:446112158 Change-Id: I58ea7eec4c842aee382568c7f41c99a242d29680 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6975004 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Yuly Novikov fa49f700 2025-10-13T17:47:18 Don't build OpenCL on Mac bots Our Mac builders are a mix of x64 and arm64 machines, with plans to migrate to arm64-only builders, cross-compiling for execution on x64 machines. However, LLVM, which OpenCL depends on, doesn't support cross-compiling. Bug: angleproject:450256590 Change-Id: I929845c4bbee038b74095af61ff4970e074badbf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7036601 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
angle-autoroll 537ee3e4 2025-10-13T09:34:05 Manual roll SwiftShader from 794b0cfce1d8 to efd5e79e9ca3 (1 revision) Manual roll requested by victorvianna@google.com https://swiftshader.googlesource.com/SwiftShader.git/+log/794b0cfce1d8..efd5e79e9ca3 2025-10-13 victorvianna@google.com Fix C++23 build errors If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,victorvianna@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,victorvianna@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I6a4355cf29337558ce6184f18ae11e432fe857c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7036866 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kyongjoo.oh 02ffcb36 2025-08-01T08:13:21 CL/VK: Fix heap overflow when kernel args exceed size Prevented memory corruption by validating argument size against allocated push constant size before copying. Bug: angleproject:447192711 Tests-Passing: test_basic vector_swizzle Change-Id: I73b03a31089ad922b9ad7c2295fd1578d60458ec Signed-off-by: kyongjoo.oh <kyongjoo.oh@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6981098 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
angle-autoroll 6b71ba83 2025-10-13T10:01:39 Roll vulkan-deps from 660b97e7bc4f to ac55dee5b314 (12 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/660b97e7bc4f..ac55dee5b314 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f6652dcf751920b1fbc132619b0e84ef3d6e77c4..8e1494f9d742a27b54193ecd9475dcb2ef23b8b7 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/b9997dafc791634ce51f6bed7ab886ea0e600a15..6d43afe9a0ef71712d8cec5b0ce0cd3570d1fd41 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/385716f0a63fe2c26e54a5140c9877a80da66592..40fdef426201fa25c5847e18d96d8f28f29a5195 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/faf69f66f2d9ba782fe37cabd19b9742f9f62eb3..17c41541e8e43364af6ccb4a6ce167274152cd7a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/a1e45945b3a84140956dc4672684090cf8e636a4..913a3fa7a6b47eee715c3c7759c9d0bbff5a6da7 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/351663e654f0abda9912ee70b2525559e951043a..1974ee2f21dcc4abf589b08f29ac6acb43e9bec4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I667026e0fe2639a5cd2da8b4ef6d511b8f824425 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7035974 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4057f9c7 2025-10-13T08:01:27 Roll VK-GL-CTS from db48c34bebaf to c082f2b4f5e3 (12 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/db48c34bebaf..c082f2b4f5e3 2025-10-10 javed@igalia.com Add coverage for null location 2025-10-10 javed@igalia.com Add tests for feed back loop with ESO 2025-10-10 ziga@lunarg.com Replace SPVRemapper with spvtools::Optimizer 2025-10-10 mateusz.bahyrycz@cognizant.com Fix regression introduced by VK_KHR_copy_memory_indirect2 merge 2025-10-10 marcin.zajac@cognizant.com 64-bit vertex input component mismatch coverage 2025-10-10 mateusz.gawrysiak@intel.com Fix dEQP-VK.ray_tracing_pipeline.indirect tests 2025-10-10 marcin.zajac@cognizant.com Fix various validation errors 2025-10-10 rgarcia@igalia.com Test remapping single attachment with DRLR 2025-10-10 rgarcia@igalia.com Test events on the compute queue 2025-10-10 rgarcia@igalia.com Test shader objects with non-matching patch tessellation IO 2025-10-10 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.4 into vk-gl-cts/main 2025-10-08 scerveau@igalia.com video: update vvs to v0.3.5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I4c6fd62b66716094886e1b233015a53092ea2476 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7035497 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 8ed16003 2025-10-09T09:43:37 tests: Fix ShadingRateEXTTest.FragmentShadingRatePrimitive The test ShadingRateEXTTest.FragmentShadingRatePrimitive has several errors: 1. The uniform 'u_color' is not set to any value. 2. The test incorrectly assumes GL_SHADING_RATE_1X1_PIXELS_EXT results in the GLSL built-in 'gl_ShadingRateEXT' having a non-zero value. 3. The test attempts to validate the GL_SHADING_RATE_2X2_PIXELS_EXT behavior, but never calls glShadingRateEXT() with this value. 4. kSimplePrimitiveShadingRateGS needs to set gl_PrimitiveShadingRateEXT each iteration of the loop, rather than just once, due to the EmitVertex() call which resets all output variables to undefined values. Once these issues are fixed, the test passes. Bug: b/450024489 Bug: angleproject:444980424 Test: ShadingRateEXTTest.FragmentShadingRatePrimitive Change-Id: If3b9379d4aac97bb106cc0b04550068cd0783a94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7027991 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Roberto Rodriguez 62fe67a7 2025-10-09T11:12:47 Update Texture2DBaseMaxTestES3.Fuzz545ImmutableTexRenderFeedback Make test updates to align more with conformance test immutable-tex-render-feedback.html: - Change several data types from unsigned to signed - Some test iterations are skipped entirely - Signed types align more closely with the gl operations in which they are used as arguments. - Update MIPS constant from 2 to 3 - Avoid modifying loop counter _level_prime_max directly Add Roberto Rodriguez to CONTRIBUTORS list. Bug: angleproject:450534531 Change-Id: I3389b64fe16bd8e59f45c228363d7f7ed089a757 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7027992 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll 941fabdf 2025-10-10T10:01:53 Roll vulkan-deps from cd9db66cabed to 660b97e7bc4f (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/cd9db66cabed..660b97e7bc4f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/a5164829e8f0255392c481696b63763a5e80be3c..9268f3057354a2cb65991ba5f38b16d81e803692 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/f5fad0a209a2e09eb5e622d930d5eade1a235b13..33d7f512583b8de44d1b6384aa1cf482f92e53e9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/722797078e5964e28f9693aa1cef3144ed6aa104..351663e654f0abda9912ee70b2525559e951043a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I04a403dab8236b9a066f9b5d3216ccfc634b6bca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7030050 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 8af6c566 2025-10-08T11:25:49 Translator: Add more action routines to glslang.y These will be used during IR generation, but are split in this change because commits with glslang_tab_autogen.cpp take forever to `git cl format`. Bug: angleproject:349994211 Change-Id: Ib0a84710fa63fc33193fd5f485a434981baab61e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7022211 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi eec95a6b 2025-10-02T17:02:14 Translator: Remove NV_shader_framebuffer_fetch This extension is never exposed by ANGLE. AFAICT, it was removed in https://chromium-review.googlesource.com/c/angle/angle/+/688099 and never added again. The current implementation is incorrect even if the extension is exposed; we assume gl_LastFragColorARM is the name, while this extension uses gl_LastFragColor. This change removes mentions of this extension instead of trying to fix it. Bug: angleproject:349994211 Change-Id: I2391a225db95d73579fd71cf261360973e5935f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7004390 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 074eec2f 2025-10-02T15:31:19 Translator: remove angle_BaseVertex/Instance from built-ins These aren't built-ins, they are just used for emulation. Instead of listing them in the built-in variables, they are now created as uniforms during emulation. This change also gives gl_BaseVertex/Instance their own qualifiers so they aren't considered uniforms. The emulation pass is also optimized to do fewer passes. Bug: angleproject:349994211 Change-Id: I44fd345fd4a2dc4a001eb294952a984ae710d606 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7004388 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi b0ee4239 2025-10-01T16:46:10 Translator: Validate clip/cull distance size during parse ... instead of in a post-parse pass. In this process, these array sizes are determined during parse itself, and so can be applied to the IR earlier. Bug: angleproject:349994211 Change-Id: I542970f9262e346fd7443e48d780e8abfec95315 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7003832 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 4ce4aaaa 2025-10-09T10:01:12 Roll vulkan-deps from fb5afca26b9b to cd9db66cabed (15 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/fb5afca26b9b..cd9db66cabed Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/01e0577914a75a2569c846778c2f93aa8e6feddd..a5164829e8f0255392c481696b63763a5e80be3c https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/bced46bb023e69bae4b0e61077ea8372f0d81954..b9997dafc791634ce51f6bed7ab886ea0e600a15 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/4eebce1723aced9afa272c38dfd4f82a786ed9ad..f5fad0a209a2e09eb5e622d930d5eade1a235b13 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/46ef56addf33db5bc82e1ef72eb625a9d63a0a37..722797078e5964e28f9693aa1cef3144ed6aa104 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ief6144d659f41505fa4aea93c74a8548e7e4b7be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7025354 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop 17977bb0 2025-10-08T20:12:13 Tests: Add Lands of Jail trace Test: angle_trace_tests --gtest_filter=*lands_of_jail Bug: b/450394708 Change-Id: I8a87eca1a48b0a96e491be294d4c45ce125dcdee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7021859 Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jordan f9685fdb 2025-10-07T07:47:14 Fix: Correct various license issues in README.chromium files Bug: chromium:365320788 Change-Id: I1cb11330176d7a63d3aedee78aa5a5c15fcca595 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7015769 Auto-Submit: Jordan Brown <rop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Le Hoang Quyen 715e935d 2025-10-08T21:16:08 D3D11: Add UMA metrics for Create*Shader's timing Bug: chromium:399642827 Change-Id: Iaf22b598305d8c11ec0ea9bafa6cd1361db571f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7022089 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cody Northrop 37b48896 2025-10-08T08:51:44 Tests: Skip black_beacon on Pixel 6 Non-deterministic rendering results. Bug: b/450251026 Change-Id: I8bf192d19e2be460816dcdc0a54eac56b8f291da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7022171 Commit-Queue: Cody Northrop <cnorthrop@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll c2010eb1 2025-10-06T10:13:40 Roll VK-GL-CTS from 7e7a6001a3f4 to db48c34bebaf (14 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7e7a6001a3f4..db48c34bebaf Update GN with CMakeLists.txt changes in: https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+/d1cc04f42d9d6de78bc68abe0ce3d98754c2ac3a https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+/4c03f49146f25e18d6b1f9d983cc531f7683c87a 2025-10-03 javed@igalia.com Add format reinterpretation tests 2025-10-03 rgarcia@igalia.com Update Vulkan CTS Linux build instructions 2025-10-03 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12 into vk-gl-cts/main 2025-10-03 scerveau@igalia.com Video: Use TCU_CHECK_AND_THROW instead of DE_ASSERT 2025-10-03 shihwang@amd.com Add mesh shader tests 2025-10-03 apinheiro@igalia.com ARB_texture_filter_minmax depends on OpenGL 3.3 not 4.5 2025-10-03 niklas.ulvinge@arm.com Improve coverage for textureQueryLod 2025-10-03 david.rosca@amd.com Add R16_SINT format for quantization delta map 2025-10-03 ziga@lunarg.com Verify supported host image copy layouts with unified image layouts 2025-10-03 ziga@lunarg.com Test vkCmdBindDescriptors2 with dynamic offsets 2025-10-03 ziga@lunarg.com Tests for dedicated device memory overallocation with buffers 2025-10-03 rgarcia@igalia.com Add GPL tests in which some set layouts are always null 2025-10-03 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.4 into vk-gl-cts/main 2025-09-29 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_copy_memory_indirect2' into main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I8706e17b59da232b4da1d5da75f78955fb3ce526 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7010736 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Solti Ho <solti@google.com>
angle-autoroll 632fa2ac 2025-10-08T10:01:04 Roll vulkan-deps from aa211644ec30 to fb5afca26b9b (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/aa211644ec30..fb5afca26b9b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/533a69c63ae773d90d03b206954ffffec6517dbd..bced46bb023e69bae4b0e61077ea8372f0d81954 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/8ebb2a62f5beee9447a8899a57db291d4034b0fc..faf69f66f2d9ba782fe37cabd19b9742f9f62eb3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/270dbea039c2b485e33330be58a3e0ebcaef485f..46ef56addf33db5bc82e1ef72eb625a9d63a0a37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I67e205f8c89f2a4da68bca551e3e977e8b64db0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7020691 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 867b9b74 2025-10-07T16:23:01 Tests: Add Match Masters trace Test: angle_trace_tests --gtest_filter=*match_masters Bug: b/450081414 Change-Id: I90546fc4dea0e7257001fbf9a68087355b8ee39b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7019035 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Matthew Denton fecb8ead 2025-09-04T12:27:48 WGSL: implement inc/dec with generated functions Implements inc/dec with generated WGSL functions that take pointers and perform a post/pre inc/decrement. This works with scalars, vectors, and matrices, both float and int. WGSL supports inc/dec only on integer types, and only as statements (not as expressions). https://www.w3.org/TR/WGSL/#increment-decrement. The regular ++ and -- are used in this specific case. The WGSL outputter records usage of increment/decrement and produces a call to the correct function. A new class is introduced to keep the record of which types need generated inc/dec WGSL functions. Bug: angleproject:42267100 Change-Id: I0e70760ba5bd00f978e216f958216ae3137a146e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6935269 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mark Lobodzinski f8c0eae1 2025-09-30T14:06:55 Tests: Add Identity V trace Test: angle_trace_tests --gtest_filter=*identity_v Bug: b/448431054 Change-Id: Ia39f775dbc22b8c8d7df1a9c49b31f1dd47d6a02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7018081 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop b53f61e8 2025-10-06T15:48:42 Skia Gold: Limit frame count on SwiftShader ANGLE traces have the ability to specify key frames for use in golden image comparison. Since software rendering is typically slow, we want to limit the impact of key frames on our CI time. Test: restricted_trace_gold_tests.py --key-frame-limit=10 Bug: b/449677825 Change-Id: Iddc26d76672b4cac36730eb1a4172f2037ccd3ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7014647 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll a0e18f74 2025-10-07T03:01:51 Roll SwiftShader from 18d4f3db9407 to 794b0cfce1d8 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/18d4f3db9407..794b0cfce1d8 2025-10-06 swiftshader.regress@gmail.com Regres: Update test lists @ 18d4f3db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I2ac121d133bd33b277816b5a9d7efcb58e3dcbec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7016749 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b44b9ad4 2025-10-07T10:01:40 Roll vulkan-deps from ea4cd2b85ec4 to aa211644ec30 (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ea4cd2b85ec4..aa211644ec30 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a57276bf558f5cf94d3a9854ebdf5a2236849a5a..f6652dcf751920b1fbc132619b0e84ef3d6e77c4 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/9830fdc6294421867774291f1285c42ecfae623b..6aba93196c86c82e8ebe50920876ae5c028acd9b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/a4f8ada9f4f97c45b8c89c57997be9cebaae65d2..4eebce1723aced9afa272c38dfd4f82a786ed9ad https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/ae0461b671558197a9a50e5fcfcc3b2d3f406b42..385716f0a63fe2c26e54a5140c9877a80da66592 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/5568ce14705e512113df5b459fc86d857b3d7789..8ebb2a62f5beee9447a8899a57db291d4034b0fc https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/4d0b838ffcf1ef81151f0e7e11fad1d9ff859813..a1e45945b3a84140956dc4672684090cf8e636a4 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2f03cbd1846ba45a27c29172327a989f684a1979..270dbea039c2b485e33330be58a3e0ebcaef485f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I024e02767cb4e1ba2c2eac23ad4a8f1ac9568533 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7016767 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bd1efa99 2025-10-07T07:01:21 Roll Chromium from 523d69615c9b to 76e5315e52d7 (618 revisions) https://chromium.googlesource.com/chromium/src.git/+log/523d69615c9b..76e5315e52d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4d06a1da7d..b7a355a6a8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6f0cca3144..2e7f14e409 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/781b6b2636..8bb2433661 * third_party/android_build_tools/lint/cipd: 3QcVzxF6pQW8pak81zGzUciRaonUh1NpS3UBjZZfVTsC..VyDrZ5fyFW5p9gU-4TnLHv97fdDn07NGu0uZMhZ5gfsC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4ca50c8ae1..f724a59d02 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eda3b48f2e..276ae56a8e * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/909b339562..b53ec82f9c * third_party/r8/cipd: SS09E3kPRdP5W064MT-pNrNhXBshbdgO58WU9Y8yY38C..2aBDG942g42qUBPPInGETRHusdxru1U3anwJI_QX5wIC * third_party/turbine/cipd: LaDt9HreG5-Q6yBbZLf6LJSvLKqNjamn84VJgZHXSTEC..UPK1OhajOS06r3w9iwxehBFg7pbTwe9mgMcGkY6-VsEC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/66666dece7..88ffc02cc7 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1581534567..cbc2b48ed7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/496e9e27a0..d607462aad No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Idd3bc296e389829beebd07d80b888d36dfcb6c72 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7015814 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 6a997ce2 2025-10-03T00:03:25 Vulkan: SPIR-V Gen: Use unique id instead of pointer Bug: angleproject:349994211 Change-Id: I66d6c3cf58f1e7d850fb19def7aa863774d918a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7007612 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Matthew Denton 6c4c0055 2025-10-01T15:13:14 WGSL: fix do-while when body has continue If the body of the do while had a "continue" it would skip over the evaluation of the loop condition and potentially loop forever. Change to use the special WGSL "continuing" statement, which goes at the end of a loop body and always executes, even if there is an earlier "continue". Bug: angleproject:42267100 Change-Id: I4ac73e6abcb12e0ff395b83dc5666ac1870724e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7003772 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi e1c14f0b 2025-10-02T23:42:01 Translator: Fix gl_LastFragColorARM not being qualified correctly The qualifier adjustment was accidentally done after declaring the variable in some cases. Bug: angleproject:349994211 Change-Id: Iffd7567a119e1cd499c068742edfcb68a6a2336f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7006113 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao fd353919 2025-10-03T14:32:05 Vulkan: Fix VMA assertion The primitive restart may generate zero size, and VMA does not like it. Make sure we not pass down zero size here. Bug: angleproject:448916158 Change-Id: I9a901127e8de11ab008e39330bd2eb93a9f135bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7008828 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Gowtham Tammana 01280f65 2025-07-29T10:14:54 CL/Vulkan: Remove spurious clear The external events corresponding to a command stream submit and processed and cleared before vkSubmit. So remove the spurious clear at the time finish post processing. Bug: angleproject:446112158 Change-Id: If2efcc3173e400ad2d386ca374eebe9d9f310692 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6981089 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Shahbaz Youssefi d9fa255a 2025-10-02T11:58:06 Translator: Add numerous missing gl_PerVertex validations Bug: angleproject:349994211 Change-Id: Ie4a602dd026a2dab95c9d77e8841e76967fa7f3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7002885 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll ccca6c77 2025-10-06T10:01:34 Roll vulkan-deps from edacf5135c8d to ea4cd2b85ec4 (12 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/edacf5135c8d..ea4cd2b85ec4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/244ebe03c9f06c4513a869236640d8b171462600..9830fdc6294421867774291f1285c42ecfae623b https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/21b7f7385d0ef70c41314891d76926e022e5d407..533a69c63ae773d90d03b206954ffffec6517dbd https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/cc388e801f874ed61e6c78bb1403d24e011255ab..2f03cbd1846ba45a27c29172327a989f684a1979 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I1b9b8c9b4bd64f5501b7d5f41735d7f4c764999d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7010362 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ce809645 2025-10-06T07:23:04 Roll Chromium from 36571a8140f5 to 523d69615c9b (818 revisions) https://chromium.googlesource.com/chromium/src.git/+log/36571a8140f5..523d69615c9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8547cfb0c1..4d06a1da7d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2325cd9871..fb3a6ce2c0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2ef6fce019..6f0cca3144 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d7efb11e00..2c5a610ceb * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9557edbf59..4ca50c8ae1 * third_party/clang-format/script: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git/+log/37f6e68a10..c2725e0622 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e4185d003f..eda3b48f2e * third_party/fuchsia-sdk/sdk: version:29.20250927.0.1..version:29.20251004.3.1 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/761ff0251b..909b339562 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/6f02457110..819e906482 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/1bc3716d4a..bc122a79f1 * third_party/siso/cipd: git_revision:f7020b54462c37f1b10a16e68563c338c9f14371..git_revision:2eee1d6feaab76d99397d4d840bd369a428c01ea * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d2182ae5cc..1581534567 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/66d06ee335..496e9e27a0 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I96035fa33f0d474fac5529cd7d4cf91518902212 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7010750 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jisun Lee fc98b3f6 2025-09-30T19:40:58 Add test to verify the direct YUV sampling case This is a follow-up test to the commit below. https://chromium-review.googlesource.com/c/angle/angle/+/6797965 The test verifies that the yuv image and image view are properly initialized in a program using __samplerExternal2DY2YEXT sampler. Bug: angleproject:386749841 Test: angle_end2end_tests --gtest_filter=ImageTestES3.* Change-Id: Ia0142dfb9135df6684526bf88f8c8b257416be10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7001563 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Cody Northrop 5c58505b 2025-10-02T16:22:19 Tests: Update expectations for GalaxyS24Exynos Test: angle_end2end_tests Bug: b/410630704 Change-Id: I18c1a9d9c5dfbb4b9238ecac5a081bde5c070540 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7007381 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 5e724354 2025-10-03T15:53:45 Fix UniformBufferTest.MultipleSizesSmallBeforeBig on AMD/Linux Bug: angleproject:42266818 Change-Id: I4ccb02ea1d21b5d8d8861837c3e40a3b0fa75610 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7008549 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya b276d1f8 2025-10-03T08:56:54 Vulkan: Add supportShaderPixelLocalStorageAngle feature Don't expose GL_ANGLE_shader_pixel_local_storage extension for Samsung Bug: angleproject:386749841 Change-Id: Ia22a6e8d8625db2abc7e7e9816ac34b7a7dec92c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7006000 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi 51fcd399 2025-10-03T10:39:14 Revert "Vulkan: Suppress buggy VU" This reverts commit a83d674ed6b9096a5c5b1f3e3924aaa340bd3867. Reason for revert: Buggy VU was disabled in VVL Original change's description: > Vulkan: Suppress buggy VU > > Bug: angleproject:448630613 > Change-Id: Ibccc4fbbe6257a3b96f5ccb112fec866cc2c3efe > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7003828 > Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:448630613 Change-Id: I19ebc3cb83d9ceefcfbbb92df0a0e1bde4ff7a36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7007012 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 41bc2afa 2025-10-02T16:22:33 Vulkan: Remove mBindingDirtyBitsRequiresPipelineUpdate mBindingDirtyBitsRequiresPipelineUpdate and mAttribDirtyBitsRequiresPipelineUpdate are used to avoid GraphicsPipelineDesc::updateVertexInput() call. This function is not being used when supportsVertexInputDynamicState is enabled, which almost all recent drivers do. We could potentially do similar optimizations when supportsVertexInputDynamicState is enabled to avoid RenderPassCommands::setVertexInput() call. But the logic is complex enough not really worth it (See crrev.com/c/6961186 for draft CL). If any, simply compare the new value and old value probably is as good as checking the dirty bits. In this CL, all these dirty bits checking are removed so that we do not waste CPU cycles to track these dirty bits while not being used at all when supportsVertexInputDynamicState.enabled is true. Bug: b/439073246 Bug: b/442636174 Change-Id: I7d71d4fc9388612e7c6ccc50a2e781325fe953bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7007241 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 28a78b94 2025-10-03T15:44:54 Manual roll VK-GL-CTS from 5529fdccccc6 to 7e7a6001a3f4 (1 revision) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/5529fdccccc6..7e7a6001a3f4 2025-09-26 lorenzo@khronosgroup.org Update Vulkan headers to 1.4.328 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ifa6df9b7a8376d3a677249138d58338b497cb168 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7006001 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 8f8f0439 2025-10-02T15:44:46 Group the class methods together In previous many CLs, I intentionally not move around the code for ease of code review. Now everything has settled down, it is the time to regroup class methods together. Also renamed some various in VertexArrayVk to be consistent with each other. No functional change is expected in this CL. Bug: b/439073246 Bug: b/433331119 Change-Id: I84f9a2ff9ea20f359e2f546ecb4e3e503b805748 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7007472 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi f1110548 2025-10-03T10:00:59 Suppress failing test on iOS Bug: angleproject:448658625 Change-Id: I35b5c41055136d2f8bffdf9e48dd6480fd248c90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7002518 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 9ea43e91 2025-10-03T10:01:58 Roll vulkan-deps from 9252990324db to edacf5135c8d (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9252990324db..edacf5135c8d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/18a759c2a0c0d0c37b8bbef8a60297d64b67fb18..244ebe03c9f06c4513a869236640d8b171462600 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/0b058dd7537945bdf09d28fd9188ed7639b90f2e..ae0461b671558197a9a50e5fcfcc3b2d3f406b42 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/c5afc61ad217fa7a119fc8673934962397930fbd..cc388e801f874ed61e6c78bb1403d24e011255ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ifba438b48f5c2d453d3cb0608f2dea466419b9c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7007831 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f6b74ac4 2025-10-03T07:01:43 Roll Chromium from 9dfb8856a439 to 36571a8140f5 (596 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9dfb8856a439..36571a8140f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/58de1d33c0..8547cfb0c1 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/674b131e2b..2325cd9871 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/83fc4f72a3..2ef6fce019 * third_party/android_build_tools/aapt2/cipd: vtRNH1sTb9tAlXaPkdqGIH_MDSnuH2GrlWFtT1MhadUC..XqcH9BN43Trcigbh3gSdKc-5OAI-r7MV7wIs5fRXxFMC * third_party/android_build_tools/lint/cipd: 8LWaxlDPUdoe_fYqlHBXPmwm6aQsqP8Mi4kxGFFmfmkC..3QcVzxF6pQW8pak81zGzUciRaonUh1NpS3UBjZZfVTsC * third_party/android_build_tools/manifest_merger/cipd: n1GI7ejyMFXpOv359jDyoMovbtfsy1R4zjVCEDPp8CQC..4cITVa3bS61rDFtbh_QoflvqlRrM-KrtViIyD4QEgjYC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/236061bcb3..d7efb11e00 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0de024c454..9557edbf59 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3f15de2ac3..e4185d003f * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2c0b9511ee..cc5f928de9 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/cb9a1f6a47..761ff0251b * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/fef7a765bb..6f02457110 * third_party/r8/cipd: llWUebGsQPrzc7z3fwJF78NcrdGs1wrUhy0Y-0Wrb-4C..SS09E3kPRdP5W064MT-pNrNhXBshbdgO58WU9Y8yY38C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/f043793bfa..1bc3716d4a * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/f0339248d1..66666dece7 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2fa7ecbf9c..d2182ae5cc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8cee189b73..66d06ee335 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ib030f53e719b1a692975b1e20463ed7d002d0e1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7006075 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 62b00f86 2025-10-02T12:19:23 Vulkan: Further minimize VertexArrayVk::syncDirtyEnabledAttrib This CL splits the streaming handling into its own function: syncDirtyEnabledAttrib is now splitted into syncDirtyEnabledNonStreamingAttrib and syncDirtyEnabledStreamingAttrib. This minimize the condition check inside syncDirtyEnabledAttrib. VertexArrayVk::syncDirtyEnabledAttrib() function has a check of bufferGL->getSize() > 0 as well as hasAtLeastOneVertex. And if either of them are false, they simply point to empty buffer. This CL merges these this fallout case into hasAtLeastOneVertex and added ASSERT to ensure that if buffer size is 0, hasAtLeastOneVertex is false. Bug: b/439073246 Change-Id: I5e3592c31469d15f5321208eb0278b10e447118c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6987341 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski 2247ebec 2025-10-02T09:52:40 Trace/Replay: Don't reset max shader/program ID The mMaxShaderProgramID variable was being reset between captures. This could result in trace crashes when the temp shader/program start ID conflicted with active programs or shaders. Test: angle_trace_tests --gtest_filter=*identity_v Bug: b/448817125 Change-Id: I49c1d94b5824a8eaee444f7e4eb323ddab1a3edc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7006451 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 538129c6 2025-10-01T15:08:53 Remove b/ from end2end expectations Bug: None Change-Id: Ibfa3ca48dc5084ffd548cc1ff331bf29592a817e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7004585 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 7b4ff0b2 2025-10-01T16:30:47 Vulkan: Updates to onFramebufferBoundary 1. Rename to the more appropriate onFrameBoundary 2. Add method to renderer for better encapsulation 3. When being moved to the background some apps unMakeCurrent the contexts and exit without calling other frame boundary APIs. Handle such usecases by treating ContextVk::onUnMakeCurrent(...) as a frame boundary Bug: angleproject:386749841 Change-Id: Ic2a8ecb631d132d99f8508f45f3b454c49f6624e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7004936 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi ec4d8946 2025-09-29T15:32:40 A fistful of tricky GLSL tests Bug: angleproject:349994211 Bug: angleproject:448658624 Bug: angleproject:448658625 Bug: angleproject:448658631 Bug: angleproject:448675904 Change-Id: I8ad8727b7c8f7889a1249dfc7382c7e0318c5496 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6996988 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi 1f3b482f 2025-10-02T12:05:44 Translator: Fix UNREACHABLE() on gl_DepthRange compile error Bug: angleproject:349994211 Change-Id: I1918c8390de3fa4a5c7542b044e91e8d5e944b3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7002886 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuxin Hu 4daab276 2025-10-01T16:20:53 Fix test supplying 2D texture data to 3D texture Bug: chromium:446633198 Change-Id: I4ee9cee6788123e5e2d5527e92433c5df61aa063 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7004941 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Jisun Lee b152eb30 2025-09-12T21:20:08 Vulkan: Refine conditions to force submit immutable textures To minimize unnecessary submissions, make the activation conditions for forceSubmitImmutableTextureUpdates feature more precise. This also enables the feature for Samsung devices. Bug: b/444728814 Change-Id: Idaf6b36596752f55ec6ba0ca1e4ff516f3a280df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6945861 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll 1280e2ac 2025-10-02T11:45:15 Roll vulkan-deps from 8ff085ff814f to 9252990324db (90 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8ff085ff814f..9252990324db Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9d764997360b202d2ba7aaad9a401e57d8df56b3..a57276bf558f5cf94d3a9854ebdf5a2236849a5a https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/d89fe7492d26b3eb12b2f1990cc2ad4bcdd953f1..18a759c2a0c0d0c37b8bbef8a60297d64b67fb18 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/d7ac0e0fd062953f946169304456b58e36c32778..21b7f7385d0ef70c41314891d76926e022e5d407 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/d1cd37e925510a167d4abef39340dbdea47d8989..a4f8ada9f4f97c45b8c89c57997be9cebaae65d2 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/50399a2c3011bea1941a977f5b90a241053af4bc..0b058dd7537945bdf09d28fd9188ed7639b90f2e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/95cfb8b1ba7fbcbe1383302ff286808c34e1fb9e..5568ce14705e512113df5b459fc86d857b3d7789 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/fa01ab38ca196264fe44fa923feaffc7dcc76d76..4d0b838ffcf1ef81151f0e7e11fad1d9ff859813 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/5c69a98762f6d8bc68d4a0042ba4a037d4af0a05..c5afc61ad217fa7a119fc8673934962397930fbd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I40604a172623356f0b330d53df8fa885b2a170bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7005120 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1895857e 2025-10-02T08:01:15 Roll VK-GL-CTS from c67cffddd65a to 5529fdccccc6 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c67cffddd65a..5529fdccccc6 2025-10-01 lordalcol@users.noreply.github.com Merge pull request #543 from rg3igalia/rgarcia/build-docs-improvements If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I14fb89ab91d59478fdd08fff68dd9588eec9442e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7005118 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 28b52683 2025-10-02T07:01:55 Roll Chromium from 37eb1e68bdc6 to 9dfb8856a439 (649 revisions) https://chromium.googlesource.com/chromium/src.git/+log/37eb1e68bdc6..9dfb8856a439 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/76f56e27d9..58de1d33c0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c79eaa6eb2..674b131e2b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c1ac65b818..83fc4f72a3 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/c3655ab8bb..781b6b2636 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/823c713789..236061bcb3 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/4989759b31..633f9c8459 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f60fc21eb8..0de024c454 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6cac3e72ab..3f15de2ac3 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/b77132b512..2c0b9511ee * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/322be580a5..6dc2f29f93 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/980223ac27..cb9a1f6a47 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c6ca27b020..2fa7ecbf9c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9618f1d00f..8cee189b73 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Id8e23ae1157c10fd5f7aede689b2dab0ca9b5feb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7005969 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 7994bf76 2025-09-29T11:55:00 Vulkan: Avoid double-setting the fragment shading rate Because there were two handlers for fragment shading rate, one for the QCOM extension and one for EXT, every time the render pass started, it would set the fragment shading rate to 1x1 twice. Bug: angleproject:420310117 Change-Id: I905c504c7a7b80b5e7173e5d6a7cabe6f271e7a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6995362 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Yuxin Hu 17307955 2025-09-30T18:08:18 Vulkan: Add a threshold for RefCountedEventRecycler::mEventsToReset Surface Flinger process is not guaranteed to call Renderer::flushOutsideRPCommands(), in that case RefCountedEventRecycler::mEventsToReset is never cleaned up and send back to RefCountedEventRecycler::mEventsToReuse list, which causes file descriptors leaking. This change adds a threshold for the number of items in RefCountedEventRecycler::mEventsToReset. If the threshold is reached, don't add item to RefCountedEventRecycler::mEventsToReset, destroy the items instead. Bug: b/440066521 Change-Id: If4aa0b14ab15e70f192f380e3b9707b405dd6fcb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7001562 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Amirali Abdolrashidi 7093e400 2025-09-29T14:31:06 Vulkan: Fix buffer size for vertex array * In syncDirtyEnabledAttrib() in VertexArrayVk, the array buffer size used for binding (BindVertexBuffers2()) has been changed to that of bufferHelper. Bug: angleproject:448047351 Change-Id: I852e4839cba698c01f92644cf32fadf366c0b54f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6996428 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi a83d674e 2025-10-01T12:42:48 Vulkan: Suppress buggy VU Bug: angleproject:448630613 Change-Id: Ibccc4fbbe6257a3b96f5ccb112fec866cc2c3efe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7003828 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Matthew Denton 4cff5289 2025-08-12T19:31:36 WGSL: append TSymbolUniqueId to overloaded functions dEQP-GLES2.functional.shaders.functions.overloading.* passes after this. So that overloaded functions have unique names in GLSL, append their TSymbol's unique id to the name of the emitted WGSL function. Bug: angleproject:42267100 Change-Id: I25026e71f9e27cb323014cd4102f914226c27d02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6843927 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Cody Northrop b2acbf90 2025-09-30T16:49:40 Tests: Add Raising a Goblin trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*raising_a_goblin Bug: b/448458599, b/448468885 Change-Id: I36909d44ccf817ae54b80968b75136c2478b38f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7001560 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
angle-autoroll 8b17d22a 2025-10-01T03:01:17 Roll SwiftShader from 5f1c459a11bb to 18d4f3db9407 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/5f1c459a11bb..18d4f3db9407 2025-09-30 davidben@google.com Make third_party/llvm-subzero compatible with C++23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I69479abb3b37fee743e00fd3b6334ba6df83bfd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7002289 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2e6e4b01 2025-10-01T07:56:06 Roll Chromium from d914d1699a4d to 37eb1e68bdc6 (673 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d914d1699a4d..37eb1e68bdc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3593a1fdf6..76f56e27d9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1ff4722dc4..c1ac65b818 * third_party/android_build_tools/error_prone/cipd: qjoXMGvbc36wB6J_7ERVNhYaotHaTDdrny1PpdNJ1qMC..hWbH4ETtqHXUYdBJc_KBLXq1CEjQFmQylyHVQUszCSkC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/04c85a1d0e..f60fc21eb8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/675a3a9ccd..6cac3e72ab * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/0c61a55402..980223ac27 * third_party/re2/src: https://chromium.googlesource.com/external/github.com/google/re2.git/+log/cd7b2823a8..61c4644171 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b8bee0b5b0..f0339248d1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/34d251a704..5b146fdd42 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/378ee530ee..9618f1d00f * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/cce698b88d..0eaaeed1ca No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Id0fbf9f537dbd88d7e908930338dd3b967462634 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7001568 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi ae02c329 2025-09-30T00:04:58 Translator: Give gl_DepthRange its own qualifier gl_DepthRange and gl_NumSamples are considered "uniform" by the GLSL spec, but gl_NumSamples gets its own qualifier in the translator. This left gl_DepthRange as the only built-in that had to be detected by its name instead of qualifier. This change adds a qualifier for gl_DepthRange to remove this special-ness. Bug: angleproject:349994211 Change-Id: I2b7b0acf3dcaef22bb4a98e4d35fd2cdfd5c825a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6998990 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 789693f0 2025-09-30T14:30:59 Translator: Fail compilation if built-in redeclared after qualified If a built-in is qualified then redeclared like so: invariant gl_FragDepth; out float gl_FragDepth; the translator would have to remove the previous qualification statement and apply its effect to the redeclared variable directly. While this is possible, it has always been broken (i.e. there are no users), and is not really useful to support, since the application could have done the following instead: invariant out float gl_FragDepth; The spec does not explicitly call this out as invalid, but this change generates a compile error for the above scenario anyway, as supporting it can get unnecessarily intrusive. Bug: angleproject:349994211 Change-Id: I9ddb181c8808f50aeed5b327a95b3df829206822 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6999640 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Matthew Denton 7b14dd73 2025-08-19T15:57:34 WGSL: RewriteMixedTypeMathExprs RewriteMixedTypeMathExprs: Some mixed-type arithmetic is legal in GLSL but not WGSL. Generate code to perform the arithmetic as specified in GLSL. Example: uvec2 x; uint y; x &= y; Is transformed into: x &= uvec(y); Also, mat2 x; int y; x += y; Is transformed into: x += mat2(float(y), float(y), float(y), float(y)) Bug: angleproject:42267100 Change-Id: I4a0ec1d9806b3331b4b1feff6fbe7c0f212f8120 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6862843 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Liza Burakova 5ced9390 2025-09-30T15:09:04 Roll third_party/dawn into angle https://dawn.googlesource.com/dawn.git/+log/d85fc050fef7..8ac89258097a This will update Dawn to a version that rolled its catapult dep in order to fix a vulnerability found in a python package Bug: b/442439777 Change-Id: I71de5b23eae770cbca478d3f77c2e8c8e2c4119b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6999638 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Shahbaz Youssefi a38f60ea 2025-09-30T13:40:44 Translator: Fail compilation if main() is only prototype Bug: chromium:448166385 Change-Id: Ia6b69839e35f3e0dcdf3e6e918397d3e2fd83fa2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7000630 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 85631b1d 2025-09-30T14:25:30 Translator fuzzer: Dump the shader before compiling it So that fuzzer reports tell you what the shader is without us needing to debug-print it. Bug: chromium:448166385 Change-Id: If2454093abd73771cbac787c7516259db6be82d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6999637 Commit-Queue: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Rachael Newitt c4e942d6 2025-09-25T02:47:45 Tidy up some README.chromium files in Angle. Backfills the Update Mechanism field for dependencies and cleans up some of the other fields which are out of date. Bug: chromium:379934539 Change-Id: I9a952e905ce00c379c4d593dd67b7e0fc6f1794e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6981101 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Dan Glastonbury e12bb29c 2025-08-01T15:34:26 Recompute vertex capacity when resuming transform feedback. Extract vertex capacity computation into recomputeVertexCapacity() and call it from both begin() and resume() to handle cases where the backing buffer size changes while transform feedback is paused. Add a new WebGL specific test to TransformFeedback to test the expected behavior when making the backing buffer smaller via glBufferData. Bug: angleproject:437706201 Change-Id: I3ac8e1e983ab868e34c1bdac249ce17a40e274f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6830709 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll fe939e6a 2025-09-30T07:37:49 Roll Chromium from e7f7a832abc7 to d914d1699a4d (694 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e7f7a832abc7..d914d1699a4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dd54bc718b..3593a1fdf6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fe8567e143..c79eaa6eb2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6d914f364e..1ff4722dc4 * third_party/android_build_tools/lint/cipd: 2tl7Wkl-h3xQcHYGcsqwSrIQpyLSlBLjBl36vQwV8VgC..8LWaxlDPUdoe_fYqlHBXPmwm6aQsqP8Mi4kxGFFmfmkC * third_party/android_build_tools/manifest_merger/cipd: dOI-ntBgO0MZG3WmKK37I1njjcGALsDJc00mVeoSfVUC..n1GI7ejyMFXpOv359jDyoMovbtfsy1R4zjVCEDPp8CQC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e2b34e6c5d..04c85a1d0e * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4b4a57f5cf..b77132b512 * third_party/re2/src: https://chromium.googlesource.com/external/github.com/google/re2.git/+log/6569a9a3df..cd7b2823a8 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/667365a2ae..f043793bfa * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/aba324bb72..b8bee0b5b0 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b1d66053e6..c6ca27b020 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e7c34dafbf..34d251a704 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b8f81888f2..378ee530ee * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/f93e7ca2a6..cce698b88d * tools/win: https://chromium.googlesource.com/chromium/src/tools/win/+log/2cbfc8d2e5..24494b071e No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I2229cf957b2399a49f28542ac9623d8942c992aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6997999 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 81cda669 2025-09-29T15:16:54 Tests: Add Knives Out trace Test: angle_trace_tests --gtest_filter=*knives_out Bug: b/448170020 Change-Id: I9a24ea1ae36b870a127a670db5000dd8db1668dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6997769 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yiwei Zhang ba5db43c 2025-09-27T08:51:25 Vulkan: support MESA PanVK compatibility Naming wise: 1. isARMProprietary: ARM Mali DDK 2. isMesaPanVK: MESA PanVK Compatibility wise: 1. No behavior change for ARM proprietary driver. 2. Gone through each isARM check and update to isARMProprietary for those not applicable to MESA PanVK. 3. Fixed some isMaliJobManagerBasedGPU check which assumes the ARM prorietary driver. 4. Enabled doubleDepthBiasConstantFactor for MESA PanVK. Bug: b/399142853 Bug: b/447647367 Test: no unexpected regressions in dEQP-EGL.* and dEQP-GLES* Test: dEQP-GLES3.functional.polygon_offset.* pass Change-Id: I8f830632b4caf2e63a3ae87e15825e21476bf595 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6992252 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yiwei Zhang <zzyiwei@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi e5b33850 2025-09-26T14:59:20 Translator: Fail earlier if main() is not present. The IR assumes that main() is available on successful parse. Additionally, in preparation for IR removing a check that the AST root is set up, a compile failure to that effect is turned into an assertion. The AST generated before IR is logically only used for validation purposes, so the compiler cannot rely on it to generate an error. Bug: angleproject:349994211 Change-Id: I5d4501b52fed8214213a4ae1dada923decee9a8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6991529 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cody Northrop 1f723b35 2025-09-26T09:40:45 Tests: Add Puzzle & Dragons trace Test: angle_trace_tests --gtest_filter=*puzzle_and_dragons Bug: b/447599643, b/448110252 Change-Id: Ib7c167e776f5b3a64a3932b565f2984a0c6ac915 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6989949 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi f3405af0 2025-09-25T13:45:08 Translator: Fix gl_in redeclaration This was seemingly untested, and had multiple issues: * GLSL generation would output `gl_in gl_PerVertex { ... } gl_in;` * SPIR-V generation would redeclare `gl_in` despite one already existing. * If sized after declaration, the redeclared `gl_in` was referencing a different variable than the resized one. Bug: angleproject:42264111 Bug: angleproject:349994211 Bug: angleproject:447556589 Change-Id: Id63912b68625bafcc64197807b1c8a86e6f952b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6985323 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Chris Dalton f95cbef4 2025-09-07T17:50:37 Reland "Add a "noncoherent" layout qualifier to PLS" This is a reland of commit ef9c5ce43110f4f8ba56124bdee927944ce3ddd1 with an invalid assert removed. Original change's description: > Add a "noncoherent" layout qualifier to PLS > > Raster ordering can be expensive. If an app knows the geometry in a draw > does not overlap, it can mark the PLS planes as noncoherent and opt for > using barriers instead. > > Bug: angleproject:40096838 > Change-Id: I2d686c2e64f51940face186637a9fcadcc251bef > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923300 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Chris Dalton <chris@rive.app> Bug: angleproject:40096838 Change-Id: I55077a973063427dfb0d510c87e75ec86ce8bb43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6991929 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi 35fade1e 2025-09-29T11:45:11 Suppress failing tests Bug: angleproject:444980424 Bug: angleproject:40096874 Change-Id: I7f835f40fb685fb7122e921db8e047f3789c37f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6995361 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Shahbaz Youssefi 549e9ee0 2025-09-26T18:15:26 Capture/Replay: Re-enable passing tests: Bug: angleproject:404418769 Change-Id: I4216a6206ec3d96a75ddd5177995ee26d539d73e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6990630 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 62861200 2025-09-29T07:56:45 Roll Chromium from a8396ec39897 to e7f7a832abc7 (869 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a8396ec39897..e7f7a832abc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a53bdd1c49..dd54bc718b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6b7117dcf6..fe8567e143 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1ff7404922..6d914f364e * third_party/android_build_tools/lint/cipd: KO0H7R4ln4nEeG8mUjEPEX03zNJL8KEL9a-Ock9_42UC..2tl7Wkl-h3xQcHYGcsqwSrIQpyLSlBLjBl36vQwV8VgC * third_party/android_build_tools/manifest_merger/cipd: HrhZb4lTNAd5YEE1rNdZELRw7RXp3OZg-neKFvWAdY0C..dOI-ntBgO0MZG3WmKK37I1njjcGALsDJc00mVeoSfVUC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/dc8d94d80c..823c713789 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/73e46667ed..675a3a9ccd * third_party/fuchsia-sdk/sdk: version:29.20250911.3.1..version:29.20250927.0.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/bcc74d7745..4b4a57f5cf * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/0388350fe9..0c61a55402 * third_party/siso/cipd: git_revision:acfc39d4c923834851300e8676daf8fc47e53a2d..git_revision:f7020b54462c37f1b10a16e68563c338c9f14371 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d857988935..b8f81888f2 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I9f89d84945f6c3ecfd1a29ed0c9aef906ffd88e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6993870 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>