kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll a8b64f2f 2022-06-17T07:54:24 Roll Chromium from 96b247286bab to 58c59e887244 (150 revisions) https://chromium.googlesource.com/chromium/src.git/+log/96b247286bab..58c59e887244 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2c0a2cf6d7..7b855aae93 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/35fd5adeea..fdb2b2e62f * third_party/android_build_tools/aapt2: jziPmg_EUjoj-eSkO24eMaf5ylm449Q7BKO1-ga2tbgC..hf9C5IyJUUGaBnzqu60xiFJSyfAmjqjc_PiNXNVc9l0C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..110018c8ad * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/505a265e52..6cebde7ca2 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b4df887c08..f68dc6bbd6 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I3b17a3ba17c78d6504e150487944bd23100e9aab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711285 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 6ca9c55e 2022-06-13T10:32:39 Capture/Replay: Allow capturing of external textures With the support for EGL textures enabled we can actually capture the texture content. Bug: angleproject:5822 Change-Id: I386827456d146a54d9790fdd9eadb39b2a6b87e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3702350 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Gert Wollny ea3bd30a 2022-06-13T11:44:45 Capture/Replay: Don't capture tex levels that are out-of-range Bug: angleproject:6334 Change-Id: I01cb1920154b5fba9554180d2edf5be9dea2b7a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3702351 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 7ac73cc1 2022-06-17T06:08:28 Roll VK-GL-CTS from 893946636054 to e22ec5fc4cbf (13 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/893946636054..e22ec5fc4cbf 2022-06-17 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/github-main into vk-gl-cts/main" into main 2022-06-17 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main" into main 2022-06-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main 2022-06-16 ari.suonpaa@siru.fi Add tests for mul extended using different bit sizes 2022-06-16 rgarcia@igalia.com Test shader group handle alignment 2022-06-16 mika.vainola@siru.fi Test XFB queries without shader writes 2022-06-16 rgarcia@igalia.com Remove duplicate checkPipelineLibraryRequirements call 2022-06-16 jari.komppa@siru.fi Disable IPC primitives on android 2022-06-16 rgarcia@igalia.com Mix dynamic line stipple and dynamic primitive topology 2022-06-16 marcin.zajac@mobica.com isExtensionSupported renaming 2022-06-16 piotr.byszewski@mobica.com Additional tests for UPDATE_AFTER_BIND 2022-06-16 thomas.weber@arm.com Add testing for VK_EXT_subpass_merge_feedback 2022-06-16 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,ynovikov@google.com Change-Id: I0dd6c42fcacf0335102a40849bd41bc11e987ac8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3710221 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5975eb03 2022-06-16T22:17:47 Roll Chromium from e6f032b42bce to 96b247286bab (303 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e6f032b42bce..96b247286bab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com,jwata@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c05f2b0825..2c0a2cf6d7 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/3d43903645..34f9ff8fd5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f98faec51f..35fd5adeea * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1e84da114a..ce5a215b62 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ad0677e463 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ecb22a6b70..505a265e52 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/aab57889a8..b4df887c08 * tools/luci-go: git_revision:de014227dd270df7c61bfab740eb4ae4b52ac2a7..git_revision:df39938896c4603fb2a214a2430450a85d9cca81 * tools/luci-go: git_revision:de014227dd270df7c61bfab740eb4ae4b52ac2a7..git_revision:df39938896c4603fb2a214a2430450a85d9cca81 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9b4f350017..9018d3c0d4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/103b863271..0d6086926f * tools/skia_goldctl/linux: l0eo0uR9oMGZFKDucYLGk3vdNGAunP4tGrDhIfzljdcC..OvVEMsHSDcQwu44X8cgC96F-XVZFYKyLTAnIhU4YgRMC * tools/skia_goldctl/mac_amd64: 4shFavk40_bOJI9zUzvH2PaMW7tHKuxeEN0zik75F7sC..R3UJ_6wcxlpRWvd-qYlFbqJMdonTU0oOwXbwEeGdXKkC * tools/skia_goldctl/mac_arm64: Ynx3axT8ZDN7Nl5pNwI5w8PCCt7jax5FGf8jcyjUzt4C..0Q-N1gY2crCQYdezvnNMBarAkwPnVs8ftHgHXBdunhMC * tools/skia_goldctl/win: 7YFnDYPdgUOTWkaZe19LzWhmwWBuVMM9Q02sTDQtlkgC..zaA5e-0b_opOOKLYTWgORdrhX4IWX6NGw1cn6f6gBCsC Clang version changed llvmorg-15-init-11722-g3f3a235a:llvmorg-15-init-13434-gbd9eed3a Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/aab57889a872b9210806c5b530c0e23d1aa0b0e7..b4df887c08422a2e98f124c24cef49349272fc24/scripts/update.py Bug: None Tbr: ynovikov@google.com,jwata@google.com Change-Id: I8f6ebe805b34823c69cde2a0aa275acc3dcfd925 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3709408 Reviewed-by: Junji Watanabe <jwata@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 72e457fe 2022-06-03T15:36:01 Vulkan: Promptly destroy cached framebuffer when it becomes invalid When Texture gets respecified, the VkFramebuffer cache created out of it becomes invalid and will never possibly get used. Before this CL, we never clear such invalid framebuffer objects from the cache. This CL keeps a reference to the cache key in each attachment and will immediately destroy the cached VkFramebuffer object when one of the attachment has become invalid. Bug: b/234769934 Change-Id: Ib01f6dffe9211084b1ada340081daf905e3f1bef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3682164 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Yuxin Hu bcc39a32 2022-06-16T10:54:12 Enable ExposeNonConformantExtensionsAndVersions Enable ExposeNonConformantExtensionsAndVersions in aosp so that these deqp tests that use es version 3.2 can pass on Android CTS: dEQP.EGL/functional_image_create_gles3_android_native_array_rgb565_texture_array dEQP.EGL/functional_image_create_gles3_android_native_array_rgb8_texture_array dEQP.EGL/functional_image_create_gles3_android_native_array_rgba8_texture_array Bug: angleproject:7351 Change-Id: Ic03ea0e3e46a65134a88dd8dce95611d42427bd9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3709402 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
angle-autoroll 6edb385b 2022-06-16T18:04:28 Roll VK-GL-CTS from 50754c3c19c0 to 893946636054 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/50754c3c19c0..893946636054 2022-06-16 quic_mnetsch@quicinc.com Merge pull request #326 from DadSchoorse/VK_EXT_non_seamless_cube_map If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,ynovikov@google.com Change-Id: I47ee99e238ff81b51e04af9649f33f11408b5b97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3709403 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 97a6e581 2022-05-30T16:50:26 Vulkan: Useful implementation of program binaries ANGLE already serializes the pipeline state for the sake of OES_get_program_binary. This serialization had limited usefulness however, since the Vulkan driver hasn't actually created any pipelines yet (which is a costly part of program creation). Simultaneously, ANGLE deferred Vulkan pipeline creation to draw time, which causes hitching. In this change, a handful of Vulkan pipelines are precreated at link time; those at least that are sure to create different blobs in the pipeline cache (different spec consts or SPIR-V generation). These pipelines are created in the program executable's cache. The cache is then merged into the shared renderer cache (for potential blob reuse by other programs). With this, two goals are achieved: - Most pipelines created at draw time hit the pipeline cache, avoiding costly compilation. - When the program binary is retrieved, the contents of the program executable's pipeline cache is also returned. On reload, the cache is recovered, resulting in faster startup. Bug: angleproject:5881 Change-Id: I46c5451a7d0b16dffd40e44015e094640886880b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3671977 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 0bc70e96 2022-06-10T22:27:04 Vulkan: Rename getShareGroupVk to getShareGroup + other miscellaneous clean up Bug: angleproject:7375 Change-Id: I25690860478a2fd181a67ce2b6cb4d7aac7dbaa7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700197 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 8a8b9665 2022-06-08T14:54:37 Vulkan: Prune superseded staged updates in a texture Add support for pruning superseded staged updates from a client buffer to the texture. If the staged update count or the cumulative staged updates' size exceeds a threshold we check for superseded updates and prune the list. Bug: angleproject:4691 Bug: angleproject:7389 Test: Texture2DTest.InterleavedSupersedingTextureUpdates* Texture2DTest.ManySupersedingTextureUpdates* Change-Id: I4b84f13fa20004a3dc68baa552a0af656d92c0a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3691092 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Brian Ho 1131f117 2022-06-14T11:49:15 Support BGRX8 for framebuffer blits For WebGL content, Chrome usually needs to perform MSAA resolve on the WebGL buffer before compositing via a blit. On ChromeOS, this read buffer is usually in BGRX as it is the native format for the display hardware which eventually gets coerced to GL_BGRX8_ANGLEX in ANGLE. Unfortunately, ANGLE claims limited support for this format, so the blit subsequently fails, resulting in a black screen on some WebGL 1 apps. This CL fixes a validation error and marks BGRX8 as filterable so that ANGLE's blit framebuffer implementation can actually operate on GL_GBRX8_ANGLEX targets. Bug: b/233238923 Change-Id: I378c177c9770d98a8fdb8284335ada66f7907a69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3703621 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
Yuly Novikov c41dae02 2022-06-15T19:41:39 Further suppress MultithreadingTestES3 hanging tests on Linux SwANGLE Also MultithreadingTestES3.ThreadB*BeforeThreadASyncFlush. Bug: angleproject:7431 Change-Id: Ib27afb4ed6862580dbe64c38d3eaca2040f7c1ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707272 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov f427ae41 2022-06-16T11:56:00 Temporarily remove win-trace from CQ Until compile on it is fixed. Bug: angleproject:7433 Change-Id: Id4fc2b5789d0883d3b74ef66d6b6e71cccb1c057 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707273 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Brian Osman a62204c3 2022-06-15T14:01:17 Guard all imports of wayland.gni with angle_use_wayland Fixes build errors in Skia Bug: angleproject:7434 Change-Id: I99e8ab741c0128f7327fec08e04979edde4f19e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707852 Reviewed-by: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Osman <brianosman@google.com>
angle-autoroll 44b17743 2022-06-16T10:01:38 Roll SwiftShader from 20c04524ee8a to cfcb44322bcc (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/20c04524ee8a..cfcb44322bcc 2022-06-15 antto.makinen@siru.fi Fix the linear-to-sRGB conversion on SRGB storage image writes 2022-06-15 capn@google.com Patch regression in FSR tests 2022-06-15 sugoi@google.com OpTypeForwardPointer support 2022-06-15 sugoi@google.com bufferDeviceAddress: opaqueCaptureAddress support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I0bcaae2ee70f899e86f5778810a7bfb2974285c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3709813 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 816a1b3a 2022-06-16T07:00:14 Roll Chromium from c8885f7596b7 to e6f032b42bce (339 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c8885f7596b7..e6f032b42bce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0bfcd94506..c05f2b0825 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/8b16338d17..3d43903645 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/af4060e181..f98faec51f * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/df429e4f94..1e84da114a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2b591cc800 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3133f98f3f..ecb22a6b70 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/f8a4cfe4f9..345862f410 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4ca94d228c..103b863271 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I56d8492b7c3194822894f171251ed2490fd66044 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3709116 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9ebc1b6a 2022-06-15T15:56:33 Roll vulkan-deps from 1762849caed4 to 21fa1f0acbfa (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1762849caed4..21fa1f0acbfa Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/adbf0d3106..bffcf209cb * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8f7f5024f8..76ebfb989f * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/c3601d4d91..71e43122c9 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ef9db7a8ec..2661f654ad * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/088a54d47d..d667189bc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ie13f02c3b783457e44a41f73e1cb83442693d122 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707488 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Dan Field 3faaded8 2022-06-15T11:28:58 Missing include for std::isdigit Bug: angleproject:7430 Change-Id: I2b374c826c4b29a4e290378a3cd18d2df49268b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3708312 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov a471d4bd 2022-06-15T14:33:22 Ensure ANGLERenderTest.mTestParams lifetime using unique_ptr Passing a reference is fragile, this currently works because factory outlives the test and so do captures: https://crsrc.org/c/third_party/angle/src/tests/perf_tests/TracePerfTest.cpp;drc=54e08a5af1f7ca50d5c154a09cc056166a9e49fa;l=2143 but if a temporary or a scoped object is passed to the constructor in the same spot then this blows up due to use after free, which is easy to run into accidentally as it is uncommon that f(const T&) would hold onto the reference and expect it to outlive the function call. In most cases ANGLERenderTest.mTestParams is initialized with GetParam() which comes from a base class and that Bug: angleproject:7410 Change-Id: I32ea8b79ad746129d4088d44fef2a37cc9c81b80 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697436 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Jamie Madill 9d08c29a 2022-05-25T11:39:29 Expose the EGL Display Context Set in the DisplayState. This will let the Vulkan back-end iterate through and flush pending command buffers in other Contexts. Bug: angleproject:5664 Change-Id: I0d22eb68fa754a97b4836ec8c59ff8c6e5ef2d96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3668145 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Roman Lavrov 153d8db9 2022-06-06T13:49:40 Turn missing {trace_name}.json trace files into test failures. Before this change, a missing or broken trace json file results in all trace tests "disappear" from the list with only ERR in logs. After this change, a missing or broken trace json will result in that specific test FAIL status and error in logs. Note that this also allows for inconsistency between restricted_traces.json and trace json files on the device because we're no longer requiring for trace json to be loaded unless the test is actually being run. Bug: angleproject:7410 Change-Id: I07532dc0bf85a0d2fcaf425ce8d4a589473a898d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690734 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll a9a14043 2022-06-15T16:17:52 Roll Chromium from 664494793778 to c8885f7596b7 (146 revisions) https://chromium.googlesource.com/chromium/src.git/+log/664494793778..c8885f7596b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6326939d51..0bfcd94506 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/bb4dcb7164..2dba7d2cc4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/59d5fb6887..af4060e181 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/67fb565748..df429e4f94 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0eef537180 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b66f056edb..9b4f350017 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e9d8dad31d..4ca94d228c No update to Clang. Bug: None Tbr: ynovikov@google.com,syoussefi@google.com Change-Id: I2b188b904e315efb45a594f3c5ec517694d142cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3708311 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov c2220ecf 2022-06-13T16:11:25 Always log FATAL, ERR messages is_debug=false in gn args together with angle_assert_always_on=false (default) results in no logs in logcat, which makes sense if you know that logs are conditional on ANGLE_ENABLE_ASSERTS but is pretty confusing when running into this accidentally. Bug: None Change-Id: I67499a34cd3d02fd7d17680a4cb62d263883b301 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3703619 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
Ian Elliott 3c81c9d1 2022-06-14T19:24:27 Enable perFrameWindowSizeQuery on Android It was decided that Android won't return VK_SUBOPTIMAL_KHR when the window size changes. Android's Vulkan loader no longer needs IPC to implement vkGetPhysicalDeviceSurfaceCapabilitiesKHR(). Therefore, we will call vkGetPhysicalDeviceSurfaceCapabilitiesKHR() per eglSwapBuffers() on Android. Bug: b/236026298 Change-Id: I3f66148ef5ed456e4408d64cc38fc6e0fe8b17cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3706160 Reviewed-by: Chris Forbes <chrisforbes@google.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com> Auto-Submit: Ian Elliott <ianelliott@google.com>
angle-autoroll 15376d4e 2022-06-15T07:00:35 Roll Chromium from 41a77d56876c to 664494793778 (497 revisions) https://chromium.googlesource.com/chromium/src.git/+log/41a77d56876c..664494793778 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ea9c833139..6326939d51 * buildtools/linux64: git_revision:2ecd43a10266bd091c98e6dcde507c64f6a0dad3..git_revision:e62d4e1938a45babc9afb6db543f388cd1802a52 * buildtools/mac: git_revision:2ecd43a10266bd091c98e6dcde507c64f6a0dad3..git_revision:e62d4e1938a45babc9afb6db543f388cd1802a52 * buildtools/win: git_revision:2ecd43a10266bd091c98e6dcde507c64f6a0dad3..git_revision:e62d4e1938a45babc9afb6db543f388cd1802a52 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3abbd1105c..59d5fb6887 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/7f70619a29..7c2caaa0f4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0eef537180 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b6030901cf..3133f98f3f * third_party/fuchsia-sdk/sdk: version:8.20220613.3.1..version:8.20220614.2.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/30892faac4..aab57889a8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7299bb87cf..b66f056edb * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/30b68674cd..e9d8dad31d No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I6b6a26cbf185f250cb4f7d4258c5e68a1ff979f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3706161 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Constantine Shablya b257d62c 2022-06-15T03:15:56 Add GL_NV_read_depth_stencil Bug: angleproject:4688 Change-Id: I44d5846f1ae5382b8c046e59643da4c0bf38e135 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3702356 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Constantine Shablya <constantine.shablya@collabora.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll bd1722bc 2022-06-14T18:21:37 Roll SwiftShader from ee0d0b41a626 to 20c04524ee8a (21 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/ee0d0b41a626..20c04524ee8a 2022-06-14 antonio.caggiano@collabora.com GN: Wayland build overrides 2022-06-13 dnfield@google.com Missing libs for win32 builds 2022-06-13 nicolas.capens@gmail.com Eliminate multiplication operators on SIMD::Pointer 2022-06-13 capn@google.com Roll dEQP to version 1.3.2 merged into main 2022-06-09 swiftshader.regress@gmail.com Regres: Update test lists @ f1a62bb4 2022-06-08 sugoi@google.com OpSelect implementation for pointers 2022-06-08 srisser@google.com Implement descriptor indexing for storage buffers 2022-06-08 antonio.caggiano@collabora.com GN: Fix wayland import check 2022-06-08 ericcurtin17@gmail.com Do not assume drm card is card0 2022-06-07 sugoi@google.com OpPtrAccessChain implementation 2022-06-06 antonio.caggiano@collabora.com GN: Expose Wayland surface extension on Linux 2022-06-06 antonio.caggiano@collabora.com Dynamically detect libwayland-client 2022-06-03 swiftshader.regress@gmail.com Regres: Update test lists @ 19e3080d 2022-06-02 srisser@google.com Move SIMD::Pointer to rr::Pointer4 2022-06-02 sugoi@google.com Remove unused allocateZero function 2022-06-02 sugoi@google.com Merge changes I988caf15,I62185327 2022-06-02 sugoi@google.com Fix early fragment tests 2022-06-02 sugoi@google.com Compute occlusion sample count early when using earlyFragmentTests 2022-06-02 sugoi@google.com Write stencil early when using earlyFragmentTests 2022-06-02 sugoi@google.com PixelRoutine::stencilOperation() refactor 2022-06-02 sugoi@google.com Return value refactor for stencilOperation() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7409 Tbr: ynovikov@google.com Change-Id: Id74e59518657d6d3aaaaf8b06571ebdcf3a3a7ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3705575 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Brian Ho 1adf46a6 2022-06-03T12:44:39 Enable X11 defines on ChromeOS While the typical deployment of ChromeOS on physical hardware does not use X11, the linux-chromeos-rel and linux-lacros-rel builders on the Chromium CQ do. These builders compile a special version of Chrome with all of the ChromeOS features (e.g. the system UI) that runs on top of a generic Linux bot as a windowed application. As a result, this special build of CrOS needs to interface with the windowing system of the host Linux machine, which is X on the CQ bots. These builds still have target_os=chromeos, so we need to include is_chromeos to angle_use_x11 to get the right defines. Unfortunately, this CL breaks the linux-chromeos bots as the X11 define makes ANGLE use VulkanXcbDisplay which in turn fails init as SwANGLE does not support VK_KHR_xcb_surface. There's a Chromium CL that fixes this by explicitly requesting the headless display. Thus, we need to wait for that to land or else the Chromium CQ will break on roll. [1] https://chromium-review.googlesource.com/c/chromium/src/+/3686625 Bug: b/233238923 Change-Id: Ifec50f68826aef2c3d732ae9dedabcd6d61f45a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3689809 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Gert Wollny 39df42d3 2022-06-13T19:25:42 Vulkan: set storage external memory before the description This is a partial revert of 86d9d66dce02f5ae27ca71a94fcdc485bcd7a3ad. "Vulkan: Determined sized-ness of format in initImageViews." When the image descriptions are set, then we already need the storage information, otherwise the Vulkan validation layer may complain, and the replay part of some Capture/Replay tests will fail. Bug: angleproject:7428 Change-Id: I40c70918a439939d3dcbb4aad703fd05eb8104c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3702357 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Antonio Caggiano 543dcdde 2022-06-09T10:50:41 GN: Wayland build overrides Introduce //build_overrides/wayland.gni to simplify the management of the wayland dependencies. Bug: chromium:1327041, angleproject:7409 Change-Id: I24cd7c0aa1025acbfe681afb07ccb384ff52bb62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697998 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 5a3e1dba 2022-06-14T13:18:44 Skip flaky hanging MultithreadingTestES3 on Linux SwANGLE Bug: angleproject:7431 Change-Id: Id6e91cb5b996aeff5e143b8395cd2210cef414d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3702360 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll c31e783f 2022-06-14T07:00:14 Roll Chromium from 66a3aa3f63de to 41a77d56876c (471 revisions) https://chromium.googlesource.com/chromium/src.git/+log/66a3aa3f63de..41a77d56876c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c8976641ac..ea9c833139 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/013bcd820a..bb4dcb7164 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/decc2411dd..3abbd1105c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/65c55bd4b2..7f70619a29 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d854027b5c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6fbb744238..b6030901cf * third_party/fuchsia-sdk/sdk: version:8.20220612.1.1..version:8.20220613.3.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2b3af067be..30892faac4 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1b996d8710..7299bb87cf * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e20744b236..30b68674cd No update to Clang. Bug: angleproject:7397,angleproject:7409,angleproject:7425 Tbr: ynovikov@google.com Change-Id: Ie025eb71648453724070d3a5585efe384e698011 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3703832 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 7c01db8f 2022-05-14T13:24:47 Add tests for loadOps in pixel local storage Bug: angleproject:7279 Change-Id: If060bae529d9af25cbc3e941d92fe32b2b254f22 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3652702 Auto-Submit: Chris Dalton <chris@rive.app> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Chris Dalton f1c21d68 2022-06-04T02:26:36 Add pixel local storage tests for all supported formats Bug: angleproject:7279 Change-Id: I92728112f243cccf4e4ab2c5f4c096dcc0536fc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3654266 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Dan Field 59476401 2022-06-10T10:52:57 Missing include for std::toupper This fixes the Windows build in Flutter's build environment. Bug: angleproject:7430 Change-Id: Ia53c81dbd8c28e1122e3cf680c7c48b62ecb9caf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3704236 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Dan Field <dnfield@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao c5ee5a9c 2022-06-10T10:29:11 Vulkan: Add test CreateDestroyTextureDoesNotIncreaseDescSetCache This adds a test to demonstrate a usage pattern seen with surfaceflinger (see b/234602034 for detailed reproduce steps). With every iteration of notification shade pop up, after all other optimization, we are still seeing four descriptor sets gets allocated. Surfaceflinger is allocating AHB and texture every time and after usage it gets destroyed. This test uses normal texture instead of EGLImage for easy of debugging on linux/windows platform, but it demonstrated the exact same problem with AHB texture. Bug: b/235523746 Change-Id: I7ca1ff13b61ade1449a56d3afc8a84926ad13850 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700570 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
Gert Wollny fd1317a7 2022-03-22T18:57:30 Capture/Replay: capture GetProgramBinaryOES parameters Bug: angleproject:6631 Change-Id: I0582c585bb2f3d14b10f99fe1b88805b9e629b78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3543805 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov fec66d30 2022-06-13T14:02:09 Skip 4 end2end tests flaky on Mac NVIDIA GL BlitFramebufferTest.NonZeroBaseSource BlitFramebufferTest.NonZeroBaseSourceStencil CopyTextureTestES3.InvalidateCopyThenBlend CopyTextureTestES3.InvalidateBlitThenBlend3Layers Bug: angleproject:5001, angleproject:5155 Change-Id: I25a3445e917dcc3322ad83c44158dba28454d218 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3702354 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll bc72cf60 2022-06-13T10:01:32 Roll vulkan-deps from cb1ab827eb4c to 1762849caed4 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/cb1ab827eb4c..1762849caed4 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fad68a7551..8f7f5024f8 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/846e0bb9e4..088a54d47d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Id6e3356bc9ffebf0cc2fe26201d317a5b3389ac6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3701876 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c8c474a3 2022-06-13T07:01:06 Roll Chromium from 0c0e20acbce5 to 66a3aa3f63de (505 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0c0e20acbce5..66a3aa3f63de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fb8a515c2e..c8976641ac * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1cbceb3870..decc2411dd * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/e9b1c7879f..67fb565748 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ba0a827bb8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a9467d8216..6fbb744238 * third_party/fuchsia-sdk/sdk: version:8.20220609.0.1..version:8.20220612.1.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2f657cf891..2b3af067be * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bba8cd3003..1b996d8710 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7b163daa60..e20744b236 No update to Clang. Bug: angleproject:7418,angleproject:7421 Tbr: ynovikov@google.com Change-Id: Icbf2263fcf0b3096194071b06182a5f09f2561fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3701960 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi f33f6aa8 2022-06-10T23:45:14 Capture/Replay: Skip multithreading tests that time out Bug: angleproject:7423 Change-Id: I8110d943cfa0f57005633c9a71106932ea053810 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700199 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 45c57333 2022-06-10T22:34:25 Roll VK-GL-CTS from 8817dcf9c1ec to 50754c3c19c0 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/8817dcf9c1ec..50754c3c19c0 2022-06-09 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/main 2022-06-09 peter.kohaut@arm.com Fix Android build 2022-06-09 gleese@broadcom.com Shrink the framebuffer in more graphicsfuzz tests 2022-06-09 gleese@broadcom.com Remove superfluous 'resolution' from graphicsfuzz test 2022-06-09 younggwan.kim@arm.com Add KHR-GLESEXT.fragment_shading_rate tests 2022-06-09 piotr.byszewski@mobica.com Run DR draw tests with secondary command buffers 2022-06-09 jari.komppa@siru.fi Add recipe for amber-verify run mode 2022-06-09 ari.suonpaa@siru.fi Add new test cases for VK_EXT_load_store_op_none 2022-06-09 peter.kohaut@arm.com Update Vulkan headers 2022-06-09 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main 2022-06-09 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7422 Change-Id: I6b3498372fa755f6b70ad953e59bd2f2dd0bd6b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700198 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 1c1b2a52 2022-06-10T16:12:08 Suppress failing test Bug: angleproject:7398 Change-Id: Ic9e76e7925e01bea35c41a3fd1688e79b1d3ec26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697624 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 198924c4 2022-06-10T15:30:33 Remove python 2 from presubmit Bug: chromium:1313804 Change-Id: Ibbb3f3734f0d88016ec2d2a91bb0e0aba12661c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697623 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alan Zhao 685d9175 2022-06-10T13:35:06 Remove the build flag -Wno-deprecated-declarations Now that the commit https://github.com/KhronosGroup/VK-GL-CTS/commit/44b613a986253cdde28283497731a7b909b520bc is included in angle's latest deps roll, we can remove the flag silencing the clang warning as std::iterator is no longer used. Bug: angleproject:7349 Change-Id: Ie7f3b4e245593ceb241a9e3a00593f99fa360492 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697621 Auto-Submit: Alan Zhao <ayzhao@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Alan Zhao <ayzhao@google.com> Reviewed-by: Nico Weber <thakis@chromium.org>
Jamie Madill c73ea49a 2022-06-10T13:39:54 Reland "Remove cwd manipulations." This reverts commit 4e37ec8c021e5739e720d2847ac814f8eef296a6. Reason for revert: Turns out it wasn't necessary. Original change's description: > Revert "Remove cwd manipulations." > > This reverts commit c11af00ae1d10d43a71a28c07f99969665c4ea2a. > > Reason for revert: Needed for http://crrev.com/c/3690739 > > Original change's description: > > Remove cwd manipulations. > > > > Doesn't appear to be needed as the underlying functions > > are already using the executable path. > > > > Bug: angleproject:7410 > > Change-Id: Ia9566c7159624bcb039d7dd2e9d23f4b18649f45 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695519 > > Commit-Queue: Roman Lavrov <romanl@google.com> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Bug: angleproject:7410 > Change-Id: I397ed2e75155a774c45af9c67e5906932183f1c8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696830 > Auto-Submit: Jamie Madill <jmadill@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bug: angleproject:7410 Change-Id: I06487f345482e4c26ed78754395054b43d182357 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697310 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop 9797401b 2022-06-09T22:41:11 Tests: Add Star Wars: KOTOR trace Test: angle_perftests --gtest_filter="*star_wars_kotor*" Bug: angleproject:7353 Change-Id: I20027ad4963d86609cbb0ffad5d57dbe83371ada Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3699198 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 89aa1027 2022-06-07T12:19:54 Specify display to EGL query in print info test. This will be backwards-compatible with EGL 1.4 and non-ANGLE GL implementations. Bug: angleproject:7396 Change-Id: I78a6c5b9a0d49ef9768b9a5895f6280d22e64123 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3692267 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Jamie Madill 81585fe2 2022-06-08T14:37:38 Use consistent test names with dEQP. This removes the GTest/dEQP test name distinction. Using the "RegisterTests" method in GTest we can use the full dEQP test names. The one limitation is that "-" is reserved in GoogleTest for exclusion filters, so we need to do some extra work to sanitize our filters before we pass them to GoogleTest. Makes maintaining test expectations easier going forward. Bug: angleproject:7390 Change-Id: I23893c425ddc934c11fe539b9173ec06c58abcc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695518 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll d48c987a 2022-06-10T10:01:32 Roll vulkan-deps from 00594ab942b5 to cb1ab827eb4c (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/00594ab942b5..cb1ab827eb4c Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/a97bbc24c5..197a273fd4 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c94501352d..fad68a7551 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/3ef4c97fd6..ec9b96aae5 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b86c4877c4..846e0bb9e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I32a70c4eddf1049081333ec315e7be45a9d6ea2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3699206 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3cdd4975 2022-06-10T07:53:24 Roll Chromium from ae46affd7997 to 0c0e20acbce5 (165 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ae46affd7997..0c0e20acbce5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6fab54091d..fb8a515c2e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0abd70e8a5..1cbceb3870 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ba0a827bb8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c1c45f8a85..a9467d8216 * tools/android/errorprone_plugin: https://chromium.googlesource.com/chromium/src/tools/android/errorprone_plugin/+log/bd76c90eac..633cc2d763 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9690393fc8..7b163daa60 No update to Clang. Bug: angleproject:7109,angleproject:7397 Tbr: syoussefi@google.com Change-Id: I41bfb1442e8f5f14ba27b6a352556a5ac93d192f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3699205 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 3dfc8004 2022-06-08T14:24:48 Vulkan: Optimize sync followed by swap Previously, inserting a sync object immediately caused a submission. That was done in https://chromium-review.googlesource.com/c/angle/angle/+/3200274 to be able to wait until the sync object is signaled without having to wait for whatever is recorded after it until a flush naturally happens. Some applications issue a glFenceSync right before eglSwapBuffers. The submission incurred by glFenceSync disallowed the optimizations that eglSwapBuffers would have done, leading to performance degradations. This could have been avoided if glFenceSync was issued right after eglSwapBuffers, but that's not the case with a number of applications. In this change, when a fence is inserted: - For EGL sync objects, a submission is issued regardless - For GL sync objects, a submission is issued if there is no render pass open - For GL sync objects, the submission is deferred if there is an open render pass. This is done by marking the render pass closed, and flagging the context as having a deferred flash. If the context that issued the fence sync issues another draw call, the render pass is naturally closed and the submission is performed. If the context that issued the fence sync causes a submission, it would have a chance to modify the render pass before doing so. For example, it could apply swapchain optimizations before swapping, or add a resolve attachment for blit. If the context that issued the fence sync doesn't cause a submission before another context tries to access it (get status, wait, etc), the other context will flush its render pass and cause a submission on its behalf. This is possible because the deferral of submission is done only for GL sync objects, and those are only accessible by other contexts in the same share group. Bug: angleproject:7379 Change-Id: I3dd1c1bfd575206d730dd9ee2e33ba2254318521 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695520 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 48195ae6 2022-06-09T21:03:39 Roll Chromium from 4658acb376d4 to ae46affd7997 (1334 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4658acb376d4..ae46affd7997 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/565e71d210..6fab54091d * buildtools/linux64: git_revision:37baefb026b199605affa7bcb24810d1724ce373..git_revision:2ecd43a10266bd091c98e6dcde507c64f6a0dad3 * buildtools/mac: git_revision:37baefb026b199605affa7bcb24810d1724ce373..git_revision:2ecd43a10266bd091c98e6dcde507c64f6a0dad3 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/11395e54b4..013bcd820a * buildtools/win: git_revision:37baefb026b199605affa7bcb24810d1724ce373..git_revision:2ecd43a10266bd091c98e6dcde507c64f6a0dad3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3215569cc6..0abd70e8a5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8a8c0b9c39 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/138bff2823..c1c45f8a85 * third_party/fuchsia-sdk/sdk: version:8.20220607.0.1..version:8.20220609.0.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d56805c400..4963453edd * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a455f338a1..2f657cf891 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/dbd1cbe518..bba8cd3003 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b7274f10ef..9690393fc8 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ic69025b8319e18b76dfa2c8024c774addb4d8e0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3699024 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 4c6d47c8 2022-06-08T15:20:49 Vulkan: Optimize glEGLImageTargetTexture2DOES with same args If we are creating a texture with the same source eglImage, right now we will release the existing mImage (will not actually destroyed) and then free VkImageViews. Then it point back to the same mImage and allocate new VkImageViews. Since these ImageViews have different serial number, we end up with DescriptorSet cache miss. This CL avoid all these hassles if we are creating with the exact same image. Bug: b/234602034 Change-Id: I04cec05716974e274d6e3678e91ff248f50e9355 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697204 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Auto-Submit: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Cody Northrop ce78f5f8 2022-05-10T09:10:30 Capture/Replay: Reset default uniforms Extend resource tracking to include default uniforms. They are tracked per location, per program. Setup for defaulft uniforms is unchanged, but Reset now includes a section like this: glUseProgram(gShaderProgramMap[6]); UpdateCurrentProgram(6); glUniform1uiv(gUniformLocations[gCurrentProgram][0], 1, reinterpret_cast<const GLuint *>(&gBinaryData[30518768])); glUniform1uiv(gUniformLocations[gCurrentProgram][1], 1, reinterpret_cast<const GLuint *>(&gBinaryData[30518784])); glUseProgram(gShaderProgramMap[9]); UpdateCurrentProgram(9); glUniform4fv(gUniformLocations[gCurrentProgram][1], 15, reinterpret_cast<const GLfloat *>(&gBinaryData[30518960])); glUniform4fv(gUniformLocations[gCurrentProgram][16], 3, reinterpret_cast<const GLfloat *>(&gBinaryData[30519200])); glUniformMatrix4fv(gUniformLocations[gCurrentProgram][20], 2, GL_FALSE, reinterpret_cast<const GLfloat *>(&gBinaryData[30519248])); ... Test: Animal Crossing MEC, Star Wars KOTOR MEC Bug: angleproject:7307 Bug: angleproject:7353 Change-Id: Ic344767f5dd4ffc38c15ed6bf81a7d1daf274a7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3657474 Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Chris Dalton a894cb94 2022-05-10T21:15:59 Bootstrap pixel local storage This CL creates a very simple prototype that implements pixel local storage in a thin layer on top of ES 3.1 shader images, and adds a single test. Assuming all goes well on the various devices and backends, the next steps will be: * Write many more tests. * Compiler support, switch to API-specific shader images. * Move the thin layer into ANGLE. * Thorough validation and error handling. * Add an implementation that uses render target attachments (e.g., EXT_shader_framebuffer_fetch). * Incremental, backend-specific optimizations as needed. Bug: angleproject:7279 Change-Id: I7f9f0a1fe2d61f570b4105a7380687038ae45f5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645786 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao ee1dd7f4 2022-06-08T13:17:39 Vulkan: Add test for glEGLImageTargetTexture2DOES issue This add a test that repeatedly calling glEGLImageTargetTexture2DOES on the same source EGLImage with the same texture parameters should not causing texture's descriptor set cache to keep growing. This is the usage pattern we are seeing with surfaceflinger. Bug: b/234602034 Change-Id: I38ec0a0b2580b8985c27e8c9f7edf14aa7843023 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696677 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 715175de 2022-06-03T22:11:30 Vulkan: Don't enable Qualcomm workarounds on OSS driver Bug: b/217265716 Change-Id: I09cf38a36f8297912f0c26867155cf4f9e145919 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3689810 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Chia-I Wu <olv@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
Shahbaz Youssefi da9390d6 2022-06-08T22:38:18 Vulkan: Fix the VulkanRenderPassBufferCount overlay widget This widget was declared as a histogram, but used as a graph. The graph's add() interface is made hidden in histograms to avoid such mistakes in the future. Bug: angleproject:4950 Change-Id: I95a1b6badbe27b870273589271b13c454c8a4e56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697438 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 0408b129 2022-06-08T22:20:32 Overlay: Support globbing Makes it less tedious to specify multiple widgets. In particular, it also makes it possible to select many widgets on Android through `adb shell setprop debug.angle.overlay` which has a hard limit of 92 characters for the property. Bug: angleproject:5881 Change-Id: I93bd166cd3dbf8f87e5c6a5fce3f86ebb3e379a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697437 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao 2587e508 2022-05-26T17:44:47 Vulkan: Remove redundant vertex array dirty bit processing When BINDING0+n and ATTRIB0+n dirty bits are both set, we are going down syncState twice. What BINDING0+n covers all the work needed for attribute and DATA0+n, so we should remove the ATTRIB0+n and DATA0+n. Similarly if we see DATA0+n, we should skip ATTRIBU0+n as well. Bug: b/235277703 Change-Id: I5e03c18bac3df30a14f3b6652caff2aff33f2fe6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3669608 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 76e98ae1 2022-06-09T09:11:28 Roll VK-GL-CTS from acf70aaf3fdb to 8817dcf9c1ec (36 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/acf70aaf3fdb..8817dcf9c1ec 2022-06-09 piotr.byszewski@mobica.com Split pipeline.txt mustpass into multiple files 2022-06-09 vantablack@google.com Add R8_UNORM to the external AHB memory tests 2022-06-09 michal.jakubek@mobica.com More EXT_color_write_enable tests. 2022-06-08 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_image_compression_control into vk-gl-cts/main 2022-06-08 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_KHR_fragment_shader_barycentric into vk-gl-cts/main 2022-06-07 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_KHR_ray_tracing_maintenance1 into vk-gl-cts/main 2022-06-07 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/main 2022-06-03 pdaniell@nvidia.com Fix regression from CL-9387 to handle empty cache properly 2022-06-03 pdaniell@nvidia.com Fix deqp-vksc build break from CL-9046 2022-06-03 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/vulkansc-cts-1.0.0 into vk-gl-cts/main" into main 2022-06-02 marcin.zajac@mobica.com Thread safe releaseQueue 2022-06-02 toni.merilehti@siru.fi Fix extension check in transform feedback tests 2022-06-02 juha.heiskanen@siru.fi Fix amber-verify mismatch in builtin precision tests 2022-06-02 gleese@broadcom.com Shrink the framebuffer in 2 graphicsfuzz tests 2022-06-02 antto.makinen@siru.fi Test VkSubresourceLayout::offset is relative to the start of an image 2022-06-02 jari.komppa@siru.fi Add inter-process communcation to shader cache 2022-06-02 jbolz@nvidia.com Add command line parameter to override Vulkan library path 2022-06-02 juha.heiskanen@siru.fi Dynamic rendering with NULL shading rate image 2022-06-02 rgarcia@igalia.com Test imageSize() on 2D image views from 3D images 2022-06-02 juha.heiskanen@siru.fi Bug fix for current variableSampleLocations tests + new tests 2022-06-02 toni.merilehti@siru.fi Test single-path switch statements 2022-06-02 jmadill@google.com Remove usages of std::iterator 2022-06-02 pierre-eric.pelloux-prayer@amd.com Fix ShaderBallotFunctionRead test 2022-06-02 younggwan.kim@arm.com Add autogenerate with GL_EXT_fragment_shading_rate 2022-06-02 ayzhao@google.com Remove usages of std::iterator 2022-06-02 younggwan.kim@arm.com Update gl.xml and fix script to build properly 2022-06-02 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main 2022-06-02 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main 2022-05-20 marcin.zajac@mobica.com writeSupportedExtensions for VKSC 2022-05-20 marcin.zajac@mobica.com Missing VK_KHR_object_refresh 2022-05-17 juha.heiskanen@siru.fi Add required support check for IsHelperInvocationEXT test 2022-05-17 ari.suonpaa@siru.fi Add a batch of GraphicsFuzz coverage tests 2022-05-17 pdaniell@nvidia.com Test poolSizeCount can be zero 2022-05-17 jari.komppa@siru.fi Add tests for vkGet...SurfacePresentModes2EXT 2022-05-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/main 2022-05-13 marcin.zajac@mobica.com Merge branch 'vulkan-sc-cts-dev' into 'main' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7416 Change-Id: I289aec7e7b0991556303efa70bd665fb66e43731 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696826 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott 0f8f760d 2022-06-07T17:52:52 Disable KHR_no_error for Android/SwiftShader Speculatively fix crash in Skia on ANGLE that has been happening. In addition, prevent other crashes in the future. Bug: b/220069903 Change-Id: I01b9896a6feb8be524849dafbc1df9526fc98754 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3694160 Commit-Queue: Ian Elliott <ianelliott@google.com> Auto-Submit: Ian Elliott <ianelliott@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 5fbb0417 2022-05-26T15:05:52 Vulkan: Handling VK_EXT_load_store_op_none on ARM There is a bug on at least one ARM device when either depth or stencil load op is none. Add a temporary work around to avoid this case for ARM driver until angleproject:7370 is addressed. Also add a test to reproduce the deqp test failures with simiplied draw calls. Bug: angleproject:7370 Bug: angleproject:7351 Change-Id: I74ac49a75f85b1e006ed3b1d77f234f63d314ae0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3671696 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d47c8e0a 2022-04-04T15:08:45 Vulkan: Enable custom border colors on SwiftShader This extension can now be enabled on SwiftShader after bug fixes that landed in https://swiftshader-review.googlesource.com/c/SwiftShader/+/64688 and https://swiftshader-review.googlesource.com/c/SwiftShader/+/66148 Bug: angleproject:6200 Bug: b/227518327 Change-Id: I65fb342a96c47b1ea5ba2ee773c8ae5539052b94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3569585 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Dan Field 4b9eb4ba 2022-06-03T09:22:41 Optionally support vulkan_memory_allocator 3.x Incompatible API is guarded behind a new define, ANGLE_VMA_VERSION. This allows a soft migration for Chromium and Fuchsia, while allowing clients like Flutter to roll to a new version that is compatible with its revision of Skia. Bug: chromium:1332566 Change-Id: I68cafde13e50445aa8eea2f18203143659a1c627 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3688835 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Dan Field <dnfield@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi f6517f30 2022-06-09T11:53:23 infra: Remove linux-tsan-test from CQ This bot is too flaky. Bug: chromium:1275223 Change-Id: I29a2d30f6d3aa58ee1380eace65df3d78df89ae0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696829 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 4e37ec8c 2022-06-09T16:44:44 Revert "Remove cwd manipulations." This reverts commit c11af00ae1d10d43a71a28c07f99969665c4ea2a. Reason for revert: Needed for http://crrev.com/c/3690739 Original change's description: > Remove cwd manipulations. > > Doesn't appear to be needed as the underlying functions > are already using the executable path. > > Bug: angleproject:7410 > Change-Id: Ia9566c7159624bcb039d7dd2e9d23f4b18649f45 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695519 > Commit-Queue: Roman Lavrov <romanl@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:7410 Change-Id: I397ed2e75155a774c45af9c67e5906932183f1c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696830 Auto-Submit: Jamie Madill <jmadill@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Rohit Rao 07a6f0b2 2022-06-09T09:43:52 Removes uses of sprintf() in ceval. Adds a patches/ directory with diffs from upstream ceval and updates README.chromium with a description of each diff. Bug: chromium:1331345 Change-Id: I876e0a3cb4f70472d8a340649f00d94141604fda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696824 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 48b928d9 2022-06-07T16:21:04 Vulkan: Overlay widgets for pipeline cache/hit stats Bug: angleproject:5881 Change-Id: I1893e6b76a5a73ea51b67bc4ee8a5d5dfc54166e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3689604 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov c11af00a 2022-06-08T14:45:58 Remove cwd manipulations. Doesn't appear to be needed as the underlying functions are already using the executable path. Bug: angleproject:7410 Change-Id: Ia9566c7159624bcb039d7dd2e9d23f4b18649f45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695519 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill a65af046 2022-06-08T11:57:59 De-template out dEQP GTest bridge class. This class doesn't need to be a template, and can take the test case index parameter instead from a common macro. Refactoring only, done in the process of trying to update our dEQP test case registration to get better test names. Bug: angleproject:7390 Change-Id: Ia104a0055ddb9cbc6d311d220d8d4e486214928f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695945 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Geoff Lang 1834902f 2022-06-08T14:22:34 Revert "GL: Temporarily enable validation for all GL calls." This reverts commit b6a93d753bdd819ddc0dacb8cea554c86bc4c04e. Reason for revert: Turning this off for the M104 branch. Original change's description: > GL: Temporarily enable validation for all GL calls. > > Turn on error checks after each GL call to catch potential driver > errors in the wild. > > Bug: chromium:983167 > Change-Id: Ie8b394384223155cd033baca19306396f406cdbb > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3679483 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Peng Huang <penghuang@chromium.org> Bug: chromium:983167 Change-Id: I8f3c950c95d6a56cb724905da0288b1f81c7ed3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695939 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll f06292ae 2022-06-08T10:01:32 Roll vulkan-deps from 23b710f1a0b3 to 00594ab942b5 (41 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/23b710f1a0b3..00594ab942b5 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/316f12ac1d..adbf0d3106 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/50b4d5389b..a97bbc24c5 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/b2a156e1c0..36c0c15962 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b930e734ea..c94501352d * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/245d25ce8c..3ef4c97fd6 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/5437a0854f..c3601d4d91 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/dd7e8d2fbb..ef9db7a8ec * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c97b4d7293..b86c4877c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I73bfeadf3c092851baa622ea799be25de14c04ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695104 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 4ea62009 2022-06-07T15:35:51 Vulkan: Prefer driver uniforms over spec consts On hardware that's not seeing any benefit from specialization constants, this change switches to using driver uniforms to reduce the number of pipelines created. Bug: angleproject:7406 Bug: b/173636783 Change-Id: Ic1ea1b389b0b27169427643f811370943195f331 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3692270 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 9e47438f 2022-06-07T16:34:18 Vulkan: Fix program creation crash Due to two CLs going in at the same time. Bug: angleproject:7366 Change-Id: I8638b95eefd379abbc64f3b52e87b67f25e1ad52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3693829 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Faye Zhang 06ff0e3c 2022-06-06T15:29:16 Implement GL_EXT_base_instance Added new extension GL_EXT_base_instance to registry_xml.py and auto-generated the entry point function calls for the following functions introduced by the extension: * GL_DrawElementsInstancedBaseVertexBaseInstanceEXT * GL_DrawElementsInstancedBaseInstanceEXT * GL_DrawArraysInstancedBaseInstanceEXT Bug: angleproject:6983 Change-Id: I36167faf3ca98e42acf787dbf09ee7052e15e358 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3691952 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Faye Zhang <ffz@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi b4d4231b 2022-06-06T16:49:40 infra: Increase shards for end2end tests on ASAN In preparation for https://chromium-review.googlesource.com/c/angle/angle/+/3671977 that adds more load on these bots. Bug: angleproject:5881 Change-Id: I505f1b1a75fb5c398dddfe2b8b4ef696b0298062 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690744 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov b9bdc53b 2022-06-07T14:50:46 Make TestEventListener and inner class of TestSuite. Avoids having to pass dependencies to the class as it's automatically a friend; external linkage sadly but such is life. Bug: angleproject:7299 Change-Id: I5726dcab5a1a98b93c0713073cd02d6eb3a8e216 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3693826 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 43c45bc6 2022-06-06T09:16:03 infra: Add Linux AMD test spec. The spec currentlty contains no tests. We can add those in once the basic config is working. Bug: angleproject:7390 Change-Id: I41ff08b11946c955dff67ae4b90bee7cab0dccb3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3691047 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Geoff Lang d670b5a3 2022-06-07T11:43:02 GL: Disable texture border clamp on imagination. IMG GPUs generate INVALID_ENUM when setting the texture border color. Bug: angleproject:7405 Change-Id: I04a28d36943c143ad5e18bf80e618230b116a632 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3692265 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Chris Dalton d9a2027f 2022-05-19T16:52:28 Add a test for volatile aliases of the same shader image Bug: angleproject:3032 Bug: angleproject:7343 Bug: angleproject:7398 Change-Id: I6ea6abea0b9dafd93bc297499df23be27904c996 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3656314 Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano 68634d5c 2022-01-05T20:33:32 Vulkan: Enable VK_EXT_platform_wayland Bug: angleproject:6902 Change-Id: I6a27e3f610bd48dd31937255b287b11fe84c05ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3528756 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki 34d30930 2022-06-01T10:02:58 Tests: Add Shadow Fight 3 trace. Test: angle_perftests --gtest_filter="*shadow_fight_3*" Bug: angleproject:7401 Change-Id: I7a1262560c577c53feeef83f4ebb69b795d4d62b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3687715 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Stephen White 52e560ea 2022-06-07T11:55:56 Remove suppressions for now-passing ES 3.1 tests. Bug: angleproject:1442, angleproject:1951 Change-Id: I61f9c39711f77d48a401ad98ef4ead4c0f17fe2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3693821 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano 35839293 2022-05-19T16:18:10 Vulkan: Fix mutable format check Check directly with enum instead of using boolean logical operator. Bug: angleproject:7065 Change-Id: I98b077c9ab18690d915ed3387a4f19404925daaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645123 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 4dde8590 2022-06-06T23:13:53 Remove suppression for passing tests Bug: angleproject:2976 Change-Id: I5e899c4d4fcc68b52b7b131dae6011a6129ab16b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690748 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 3b988fef 2022-06-01T10:54:03 Vulkan: Remove enableLineRasterEmulation * Removed the Bresenham line raster emulation specialization constant, along with related variables and functions. Bug: angleproject:7366 Change-Id: If17c8ce9b459ad801bae8e887e5674bd9a3ff2bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3680860 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 593cd597 2022-06-07T09:19:21 Roll Chromium from 4697545681bd to 4658acb376d4 (377 revisions) Includes modifications to libpng's BUILD.gn. The change that fixes the roll is the removal of the assembly source file which doesn't conform to BTI. Some additional changes are taken from Chromium's build script. https://chromium.googlesource.com/chromium/src.git/+log/4697545681bd..4658acb376d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1ec4567f5a..565e71d210 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c30c515c84..11395e54b4 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/2c4970601e..1644d070bf * testing: https://chromium.googlesource.com/chromium/src/testing/+log/32159ca2ee..3215569cc6 * third_party/android_build_tools/aapt2: kZqQH92bSO1p0a7_hcrana_9YjtSBU1te7TEtNVBoCUC..jziPmg_EUjoj-eSkO24eMaf5ylm449Q7BKO1-ga2tbgC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..45853b3700 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/89b222dba5..138bff2823 * third_party/fuchsia-sdk/sdk: version:8.20220604.2.1..version:8.20220607.0.1 * third_party/turbine: aSG-acwWsASjZaTfSzYcOuM9qoD6S_o3JL6iIFslVdUC..A5bkaoLBc1JYa6Xv31jYUCK5TnXYCbxRrA4FBPXXcWgC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3e5ac252f7..dbd1cbe518 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6cc9656eb9..b7274f10ef No update to Clang. Bug: chromium:1145581 Change-Id: I0bbcb1d8e147882e85de4d7ce7507b211f7b6871 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690751 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki d66d9e7b 2022-06-01T10:30:18 Tests: Add Rush Royale trace. Test: angle_perftests --gtest_filter="*rush_royale*" Bug: angleproject:7399 Change-Id: I1cfc1304331eac1903750736565eae041d4e00d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3687714 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop aac68adc 2022-05-21T22:27:22 Capture/Replay: Track dirty state per EntryPoint for Reset This CL introduces a new concept of tracking whether an entry point has been called. If so, emit Reset calls designed specifically for that entrypoint. This will likely only be useful for one dimensional state binding calls that can easily be tracked and set back. Only support for EntryPoint::GLUseProgram is added at the moment, but any entry point can be added. Reset will now set the active program back to what it was in Setup. For example: void ResetReplay() { ... glUseProgram(gShaderProgramMap[2]); UpdateCurrentProgram(2); } Test: Animal Crossing MEC, Star Wars KOTOR MEC Bug: angleproject:7307 Bug: angleproject:7353 Change-Id: I19d238ca13bbfb619e1cf8ed86f15ed6c4255a61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3656827 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Stephen White cb9e1235 2022-06-06T14:34:53 D3D11: fix UAV handling. For setting UAVs, Microsoft has provided two APIs: ID3D11DeviceContext::OMSetRenderTargetsAndUnorderedAccessViews() for pixel and vertex, and ID3D11DeviceContext::CSSetUnorderedAccessViews() for compute. They both take very similar arguments, perform similar functions, but have one crucial difference: the former will clobber any existing UAV bindings that are not specified in the call, while the latter will not. The initial implementation of non-compute UAVs in ANGLE didn't accomodate this, and sets UAVs individually, as is done for compute, which clobbers any UAVs set in a previous call. The fix is to collect all UAVs required for a draw or compute pass, and set them all at once. This required reworking the internal dirty bits to reflect the actual D3D requirements (SRV and/or UAV usage), and to split the sync functions to set only SRV or UAV state. Also add a two-SSBO fragment shader test. Bug: angleproject:7385 Change-Id: I0c98e1506d56eccf1db446c0be808f2f3020ae1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690735 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Jamie Madill 0260255b 2022-06-06T15:10:04 Fix printing of non-standard renderers. Bug: angleproject:7396 Change-Id: I18cfadbc58b71259efd414cd7ef90a45719f9b1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690736 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Rohit Rao 4b911686 2022-06-06T22:25:37 Converts from sprintf() to snprintf(). sprintf() is deprecated in Xcode 14, so update to safer equivalents in order to keep the compiler happy on iOS and macOS. Bug: chromium:1331345 Change-Id: Id5348088bf69cbd360d9251e6323596cb710666d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690747 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi ce3c0fe9 2022-06-06T12:09:45 Vulkan: Make depth-correction uniform controlled This change makes sure SPIR-V transformations are not required for depth correction, having the number of potential pipelines. Bug: angleproject:5881 Change-Id: If3f66b34bdd1127ae588cbc822ea7cf01fa8621f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3691801 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Geoff Lang 4868e5a7 2022-06-06T15:29:44 Log the fully formatted message for internal errors. The formatted message is generated but not used. This is critical to know the file and line that generated the error. Bug: chromium:983167 Change-Id: Id4bb1c5b49fa1004728948d87e0270687b82992c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690738 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Charlie Lao b186991a 2022-05-26T11:50:56 Vulkan: Remove non-current vertex array from buffer's observer list When app binds a buffer to many VAOs, any buffer modification have to loop over all VAOs that uses that buffer, even though all these VAOs are not current except one VAO. That causes significant CPU overhead. black_desert_mobile has this type of usage. This CL checks number of observers on each binding and if there are excessive observers, it removes VAO from the buffer's observer list when it becomes non-current and adds back to observer list when it becomes current. This CL reduces CPU overhead of black_desert_mobile (as measured with --offset --minimumgpuwork) from 21ms to 3.69ms, on par with native GLES driver. Note that this CL only touches glBindVertexArrayObject call code path, so no impact to apps not using VAOs. There is also no measurable CPU time regression on a few other app traces that uses VAOs. Bug: angleproject:6371 Change-Id: I6b1589f3e3c768d56c1c95cebdb577e3e256737f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3669603 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 2fcf9a92 2022-06-06T12:16:55 Suppress failing test Bug: angleproject:7392 Change-Id: I4c0ba6985bcf6ecc833bd6e4719f78e5586402a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3691802 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov b7bd0808 2022-06-06T10:54:30 Support running end2end tests. There is no batching though so all tests matching the filter will be ran at once which will block without any output until evertyhing is done (android runner runs tests in batches of 256 IIRC). Also make suite arg positional and explicitly list supported tests. Bug: angleproject:6854 Change-Id: Ibe108f24d6c3ec8b966eda1cf9ae92119a517548 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3691048 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0