|
fd9301c1
|
2022-06-17T12:25:10
|
|
Capture/Replay: Capture egl surface related calls
Creation from a pbuffer and generalized destruction are
implemented, as well as binding and releasing a TexImage
and making the context current with explicit draw and
read surfaces given.
Bug: angleproject:4964
Bug: angleproject:6180
Bug: angleproject:6512
Change-Id: Id8be6486125d45341905f3aabdbae4366cd568b7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711741
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
d50b2276
|
2022-06-21T12:05:28
|
|
Reland "Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh"
This is a reland of commit ef60d38ecf12d6663e9ecccacbff9803b1fba7c6
There are no fixes as the revert itself was a speculative one
Original change's description:
> Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh
>
> Cache value of EGL_FRONT_BUFFER_AUTO_REFRESH_ANDROID attribute
> and set swapchain present mode accordingly when recreating
> swapchain in single buffer mode.
>
> Bug: angleproject:7224
> Tests: EGLAndroidAutoRefreshTest.Basic*
> Change-Id: I2dbb92ce5c3fa047e0b02ea9011725311f346027
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707570
> Reviewed-by: Ian Elliott <ianelliott@google.com>
> Commit-Queue: mohan maiya <m.maiya@samsung.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Bug: angleproject:7224
Bug: angleproject:7465
Change-Id: Ia876ea17169c0f1b3afdb7753570e0b1aca985f5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3733521
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
fd256b0d
|
2022-06-24T09:58:22
|
|
Tests: Add Uber trace
Test: angle_perftests --gtest_filter="*uber*"
Bug: angleproject:7462
Change-Id: Ie9a6f4c8afbb94e8484dba50b90bfbc7102a3c00
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3723859
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
ba737f47
|
2022-06-27T11:04:21
|
|
Vulkan: Don't sync pipeline cache if warm up is effective
If the pipeline cache is being warmed up at link time, the blobs
corresponding to each program is individually retrieved and stored in
the blob cache. This should be enabled only on platforms where draw
time pipeline creation hits the cache due to said warm up. As a result,
there's no need to store the aggregate cache (the one owned by
RendererVk) in the blob cache too.
Bug: angleproject:5881
Bug: b/215230983
Change-Id: I2da5de835e6667b0b2d5859e6804791671888947
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3727227
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
bb373176
|
2022-06-24T14:19:05
|
|
Roll vulkan-deps from 11ad77222bfe to 137b026580e5 (1 revision)
Suppress new SYNC-HAZARD-READ_AFTER_WRITE.
https://chromium.googlesource.com/vulkan-deps.git/+log/11ad77222bfe..137b026580e5
Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/620b378993..a0e0e77a22
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:7456
Tbr: jonahr@google.com,ynovikov@google.com
Change-Id: I2ef42cccfabd575cd59c90e6f558b6a46202e028
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3723547
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
b2683a3c
|
2022-06-28T11:30:50
|
|
Document angle_restricted_traces
Bug: angleproject:7410
Change-Id: Iab02ca68d76fdd1d04804c85f76f5c251905907b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3732229
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
1dc3385a
|
2022-06-27T18:13:33
|
|
libstdc++: move FramebufferHelper to cache utils
vk_helper.h includes vk_cache_utils.h. FramebufferHelper was declared
in vk_helper.h. And FramebufferCache, in vk_cache_utils.h, requires
FramebufferHelper for its payload hashmap.
This was solved with a forward declaration. But, with std::pair
definition in libstdc++ this is not enough.
Bug: chromium:957519
Change-Id: I32e3e247c3c8bef8b52806aa2601e4012e6aa79e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3727671
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
3a799ba5
|
2022-05-16T17:26:38
|
|
Fix ValidateES3TexImageParametersBase for glTexImage*D
From the OpenGL ES 3.2 spec: GL_INVALID_VALUE error is generated
if internalformat is not one of the valid formats in tables 8.2 or 8.3.
glTexImage*D should not accept compressed format.
Add check in validation to account for this.
Bug: angleproject:6441
Tests: KHR-GLES31.core.compressed_format.api.invalid_teximage_with_compressed_format
Change-Id: I7152aefa433f42dcc40cf693538639df26c31341
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3648587
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ce4e11d3
|
2022-06-17T12:21:01
|
|
libANGLE: Add a unique ID to the Surface
This is needed when capturing Pbuffer calls.
Bug: angleproject:4964
Change-Id: Id9f35683bf887f08f916de69bbab8c414e5e8872
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711740
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
2a5193f6
|
2022-06-22T17:46:15
|
|
Textures: Allow compressed texture from PBO
Apex Legends is using a pixel unpack buffer to populate a
compressed 3D texture. We had an explicit check in validation
that prevented it, possibly due to emulated formats.
Rather than prevent it altogether, check whether the format
is emulated and proceed if not.
Also add a test that exposes the problem.
Test: PBOCompressedTexture3DTest
Bug: b/236478448
Bug: angleproject:7464
Change-Id: I90105a396bf0a465c62d67910aad2819ba7f8831
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719161
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
1ae9756e
|
2022-06-22T17:43:15
|
|
Textures: Centralize texture format emulation check
Refactor in order to use the check in multiple places.
Bug: b/236478448
Change-Id: I6df2e0d63c60fa3e8b2d65185fce164be0e7d961
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719160
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
c775dd49
|
2022-02-03T16:51:03
|
|
Allow list of restricted traces to be overriden in gn args
When focused on profiling a single or a few traces, this speeds up build
and upload to Android.
Bug: angleproject:7404
Change-Id: I5234a6fa7e8167f86b5b33b8db526662a7d65bd9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3438425
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
2adb6327
|
2022-05-13T23:09:31
|
|
Add a pls test for memoryless storage
Bug: angleproject:7279
Change-Id: I4a992d04efa06ac99472d5334a1ac50839a13d06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3654973
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Chris Dalton <chris@rive.app>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
f8690429
|
2022-06-27T13:50:44
|
|
Revert "Vulkan: Destroy DescriptorSet cache when it becomes invalid"
This reverts commit 0779ccbcd427dcb00e53afa6385fb4e8e2377993.
Reason for revert: crashes in blink_web_tests on linux-rel
https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1051045/overview
Original change's description:
> Vulkan: Destroy DescriptorSet cache when it becomes invalid
>
> When a new texture descriptorSet is allocated, we store one reference of
> the cache key in ProgramExecutableVk and all TextureVks that it
> associated with. When any of the TextureVk is destroyed or its view
> destroyed, we immediately erase the descriptorSet from the cache and
> track GPU progress and free the descriptorSet when it's GPU completed.
> That way we delete the dead descriptorSet that will for sure never been
> reused ASAP so that its space is avialable for reuse.
>
> Bug: b/235523746
> Change-Id: Ib1b9662a254eea5a3f410dc6d5d89fca6727a647
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700226
> Reviewed-by: Lingfeng Yang <lfy@google.com>
> Commit-Queue: Charlie Lao <cclao@google.com>
> Reviewed-by: Ian Elliott <ianelliott@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: b/235523746, angleproject:7466
Change-Id: I7e5067de2f2add08af1f9804cc2e952238b2e942
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726097
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
f5aef011
|
2022-06-27T13:11:16
|
|
Skip CreateFramebufferFetchMidRenderPass on Win SwANGLE
Bug: angleproject:7419
Change-Id: I76b4d08f985abbd482ef1d14cde62bcd5bb41a86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726096
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
|
|
|
46ddcc44
|
2022-06-27T14:53:31
|
|
Revert "Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh"
This reverts commit ef60d38ecf12d6663e9ecccacbff9803b1fba7c6.
Reason for revert: crashes in end2end tests on Win Intel Vulkan
Original change's description:
> Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh
>
> Cache value of EGL_FRONT_BUFFER_AUTO_REFRESH_ANDROID attribute
> and set swapchain present mode accordingly when recreating
> swapchain in single buffer mode.
>
> Bug: angleproject:7224
> Tests: EGLAndroidAutoRefreshTest.Basic*
> Change-Id: I2dbb92ce5c3fa047e0b02ea9011725311f346027
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707570
> Reviewed-by: Ian Elliott <ianelliott@google.com>
> Commit-Queue: mohan maiya <m.maiya@samsung.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Bug: angleproject:7224, angleproject:7465
Change-Id: Ia48a31124c8e0a3e4bcd4b7dc6f62b0782b42d97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726099
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
10f065e2
|
2022-06-23T13:23:09
|
|
Vulkan: support QCOM_shading_rate on Intel graphics
When querying fragment shading rates, we were limiting the result array
to 6 elements, which was not enough on Intel's Windows graphics drivers.
Those drivers report more than 6 fragment shading rates, including
a bunch of strange ones like 4x1 and 1x4.
Because we limited the list to 6 elements, and the Vulkan specification
requires that the rates be listed in order from largest width to
smallest, the feature check was missing the smaller shading rates
(including 1x2 and 1x1). This caused the supportsFragmentShadingRate
feature to be disabled.
Bug: angleproject:7461
Bug: angleproject:7172
Change-Id: I1b9a2924f93fdb803c20cfa388749754691b6e92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720732
Auto-Submit: Steven Noonan <steven@valvesoftware.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: mohan maiya <m.maiya@samsung.com>
|
|
|
ef37e863
|
2022-06-27T11:18:49
|
|
Skip TextureSampleShadingTest.Basic on Win Intel Vulkan
Bug: angleproject:7465
Change-Id: If1eff8d5f9ad9c159115c5a8ef7f4155c21e9615
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726090
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
89e38b57
|
2022-06-22T15:04:08
|
|
Refactor to use ANGLETest vs ANGLETestWithParam
Bug: angleproject:6747
Change-Id: I72ad52d0268eae0e1a401f12f3e94cc5efa402f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719002
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
de109f9e
|
2022-06-23T11:50:43
|
|
Metal: Maintain BufferPool freelist constraint
BufferPool needs to maintain the requirement of the free list that
buffers in use by the GPU are stored in FIFO order and that after the
first in-use buffer, the rest of the free list is in-use as well.
Bug: angleproject:7453
Change-Id: Ibae45fb0212030217d03fe4623c412d693674fd1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3717663
Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
707323c1
|
2022-06-21T18:53:05
|
|
Miscellaneous C++17 refactoring
Bug: angleproject:6747
Change-Id: I792ba74e03145ff6c3cc97d4bff6327ab275a2c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719001
Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
ef60d38e
|
2022-06-21T12:05:28
|
|
Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh
Cache value of EGL_FRONT_BUFFER_AUTO_REFRESH_ANDROID attribute
and set swapchain present mode accordingly when recreating
swapchain in single buffer mode.
Bug: angleproject:7224
Tests: EGLAndroidAutoRefreshTest.Basic*
Change-Id: I2dbb92ce5c3fa047e0b02ea9011725311f346027
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707570
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
|
|
|
7eb96f2a
|
2022-06-21T18:46:18
|
|
Refactor builtin symbol generation for C++17
Bug: angleproject:6747
Change-Id: I81a87b68298abc32fee7bb843c27a4a1b6009c87
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719000
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
4c5e9d47
|
2022-06-21T17:12:56
|
|
Do not defer clear if FBO attachment is AHB image
When application uses Android Hardware Buffer (AHB)
image as the Framebuffer Object (FBO) attachment,
it is possible the app doesn't call glReadPixels
to fetch the FBO color. In this case deferred clears
will not be flushed when the app reads the FBO pixel
color, and the app will read the old FBO color.
This CL fixes the issue by flushing the glClear calls
immediately when any of the FBO color attachments is
AHB image.
Bug: b/236394768
Bug: angleproject:7458
Change-Id: I9151ab57750007c4ac18af39c3fa4abe752ede5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715851
Reviewed-by: Lingfeng Yang <lfy@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
79185677
|
2022-06-22T16:22:35
|
|
Translator: Fix validation of struct with same-name struct field
In the following:
```
struct S
{
S s;
};
```
The `S` in the field refers to a previous declaration of `S` in an outer
scope. The validation code mistakenly attempted to ensure it refers to
the same `S` being declared.
Bug: chromium:1337628
Change-Id: I86184be63bc59e608fe5b24369cd4c40b3bb3b31
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3716965
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
e50351cb
|
2022-06-10T22:28:58
|
|
Vulkan: Don't close render pass on framebuffer fetch
For applications that use framebuffer fetch in the same RP as
non-fetch programs, we can save some extra RenderPasses by always
creating our RP objects with input attachments enabled. This works
almost identically except for needing to use the images in a
"GENERAL" layout instead of "COLOR_ATTACHMENT_OPTIMAL". According
to partners it is possible to achieve performance parity even with
GENERAL layout.
To remove any potential negative impacts of using the GENERAL layout,
the context enters this always-framebuffer-fetch mode only and as soon
as a framebuffer fetch program is created. Applications that don't use
framebuffer fetch are thus unaffected.
This eliminates 20 render passes in the Genshin Impact trace (out of
about 58). On a Pixel 6 the resulting benchmark score speeds up by
~25%. For Real Racing 3, the speed up is ~30%.
Based on change by jmadill@chromium.org
Bug: angleproject:7375
Change-Id: Ib6c73e95d06229f8545d502b388ee2a55a582323
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697308
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
91976352
|
2022-06-21T15:41:02
|
|
Use C++17 attributes instead of custom macros
Bug: angleproject:6747
Change-Id: Iad6c7cd8a18d028e01da49b647c5d01af11e0522
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3718999
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
0779ccbc
|
2022-06-10T17:55:54
|
|
Vulkan: Destroy DescriptorSet cache when it becomes invalid
When a new texture descriptorSet is allocated, we store one reference of
the cache key in ProgramExecutableVk and all TextureVks that it
associated with. When any of the TextureVk is destroyed or its view
destroyed, we immediately erase the descriptorSet from the cache and
track GPU progress and free the descriptorSet when it's GPU completed.
That way we delete the dead descriptorSet that will for sure never been
reused ASAP so that its space is avialable for reuse.
Bug: b/235523746
Change-Id: Ib1b9662a254eea5a3f410dc6d5d89fca6727a647
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700226
Reviewed-by: Lingfeng Yang <lfy@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
669d7b75
|
2022-05-25T15:14:35
|
|
Fix validation checks in glCompressedTexSubImage3D
- Add missing ASTC formats to the checklist in
CompressedSubTextureFormatRequiresExactSize.
- Add missing validation checks in ValidateES3TexImageParametersBase
relating to internal formats
Test: KHR-GLES32.core.compressed_format.api.invalid_format_array
Test: KHR-GLES32.core.compressed_format.api.invalid_offset_or_size
Test: *ETC2RGB8_CubeMapValidation*
Test: *CompressedTexture*Test*
Bug: angleproject:6441
Change-Id: Icc80d78602ea997be11606587b43d29e72e48f3a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3670768
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Brandon Schade <b.schade@samsung.com>
|
|
338c6539
|
2022-06-22T10:22:22
|
|
Set pixel unpack state in GL backend's CompressedTexImage3D.
A workaround added earlier wasn't applying to the GL backend because
of this missing call.
Covered by existing angle_end2end_test, but only reproduces on ASAN
build. A Chromium-side test is being added separately.
Bug: chromium:1335688
Change-Id: Ia33648054dfa647159ecfc62ca53415de04f625d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715717
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
97e0157a
|
2022-06-21T17:00:07
|
|
Fix compilation errors with deprecated sprintf function
This commit modifies sprintf calls to fix the following
compilation errors using XCode 14.0 beta on MacOS:
> 'sprintf' is deprecated: This function is provided for
> compatibility reasons only. Due to security concerns inherent
> in the design of sprintf(3), it is highly recommended that you
> use snprintf(3) instead.
Bug: angleproject:7448
Change-Id: I2d72e09a1289a3746f457508c3dae9e922fe6b98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3721635
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
6c8bb1f3
|
2022-06-21T06:06:29
|
|
Metal: Fix invalid iosurface texture after base/max lvl changed
Changing base/max lvl invalidated previously bound iosurface's texture.
This caused conformance/canvas/webgl-to-2d-canvas.html failure.
Fix by rebinding the iosurface's texture after base/max lvl changed.
Bug: chromium:1337324
Change-Id: I28f84b0ac28695221997571f71c476e802cbfac3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715729
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
|
6d3c6370
|
2022-06-18T00:13:56
|
|
Vulkan: Fix 180 and 270 degree rotated resolve
Bug: angleproject:7197
Bug: b/235877059
Change-Id: I4d4ee622f49bb3218449414a1f0dd91fa4e4f541
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3708997
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
72f69e84
|
2022-06-21T16:22:25
|
|
ANGLEPerfTest: Add option to disable GL debug callbacks.
Disable GL debug callbacks on native ARM GLES1.
This fixes native GLES1 replay on Pixel 6 when running debug builds.
Bug: angleproject:7447
Change-Id: I0059c07f4f2fb944e54a5163863b487bc31ab28f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3716584
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
c93b3b32
|
2022-06-10T16:34:00
|
|
Tests: Add Animal Crossing trace.
Test: angle_perftests --gtest_filter="*animal_crossing*"
Bug: angleproject:7306
Change-Id: Ic19adff3915093d86d68f24a5be2c0d2124f2123
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697532
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
329e1f9e
|
2022-06-04T02:30:56
|
|
Ensure pls results are secure even without barriers
We can't guarantee the client will always use local storage barriers
correctly, but we CAN guard local storage passes such that the results
are only nondeterministic within predictable constraints. This CL adds a
test to ensure local storage is still predictable without barriers, and
that no data is random or leaked from other contexts.
Bug: angleproject:7279
Bug: angleproject:7398
Change-Id: I70da58c8ba79b09f560315df3df956d1721ff6b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3654265
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Chris Dalton <chris@rive.app>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
21a07210
|
2022-06-22T16:43:44
|
|
Suppress 3 pointcoord tests on Mac Intel Metal
Bug: angleproject:7451
Change-Id: Id03e3a60aca38798ecaec4a74f0b0af64eecc63e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3714602
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
9a6ae13e
|
2022-06-17T23:42:15
|
|
Vulkan: Enable prerotation on multisample tests
Bug: b/235877059
Change-Id: I3a8b8483d7b478e36328ac402539df99e62c18b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3708996
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
683209c4
|
2022-06-22T13:07:59
|
|
Context: Limit max samples to 4 during capture.
In order to be compatible with more devices like the Pixel 4,
GL_MAX_SAMPLES should be set to 4 during capture.
Bug: angleproject:7306
Change-Id: Ie7d67be661bc02e15934b6e561f59696ffd3643a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3714600
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
d55e0655
|
2022-06-06T20:24:55
|
|
Add pls tests for fragment reject utilities
GL utilities for rejecting fragments should also prevent stores to pls.
(Namely: discard, return from main, depth/stencil, viewport.)
Bug: angleproject:7279
Bug: angleproject:7398
Change-Id: I91aac62fc7eeb703c7bc1ff1bc0c841700fd83d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696676
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Chris Dalton <chris@rive.app>
|
|
|
714f680f
|
2022-06-08T16:19:20
|
|
Implement GL_EXT_base_instance
* Added the validation functions for
DrawElementsInstancedBaseVertexBaseInstance(),
DrawElementsInstancedBaseInstance(), and
DrawArraysInstancedBaseInstance() according to the specs.
* Added generic implementation for
glDrawElementsInstancedBaseInstance() that can
be called by back-ends.
* Added flags for back-ends so they can enable the extension.
* Added tests for DrawElementsInstancedBaseVertexBaseInstance(),
glDrawElementsInstancedBaseInstance(), and
DrawArraysInstancedBaseInstance().
* Disabled ES3_D3D11__DynamicDraw tests due to
angleproject:7441 bug.
Bug: angleproject:6983
Bug: angleproject:7441
Change-Id: Ia664b01c87bc64c05e29adec23a8f80792eaa037
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697206
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Faye Zhang <ffz@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
be78a0fe
|
2022-02-22T16:11:51
|
|
Capture/Replay: Fix which sync object is deleted
The test decription says:
Secondary (Texture) Thread:
1. Wait for the mMainThreadSyncObj fence object to be created.
2. Once the fence is created, add a
glWaitSync(mMainThreadSyncObj) to the command stream
and then delete it.
Bug: angleproject:6631
Change-Id: Ia477970f64b4e2e48a0884be5e37144dd2f7bd56
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3480995
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
878bbfaa
|
2022-06-17T11:48:14
|
|
Vulkan: Account for 2DArray textures during robust resource init
Correctly handle layer count and depth when the texture type is
2Darray. Vulkan requires depth of 1 for 2Darray textures.
This also reverts commit c59a22e587e63cbe9942a7f0b78681ee25084cc4.
Bug: angleproject:3189
Bug: angleproject:4691
Bug: angleproject:7389
Bug: angleproject:7438
Test: DXT1CompressedTextureTestES3.CompressedTexSubImage3DValidationPerSlice*Vulkan
Change-Id: Ifb3b9cabd4786dcced750e3c2db90e350d455098
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3712220
Reviewed-by: Lingfeng Yang <lfy@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
7f57d12b
|
2022-06-17T22:29:36
|
|
Vulkan: Disable cache warmup on ChromeOS SwANGLE
A number of browser tests fail due to the cache warm up changing the
timing of the tests. The bug is in the tests, but this change unblocks
ANGLE roll into Chromium.
Bug: angleproject:7440
Change-Id: Ie2d7618bfc367bd34f9b99982c9323c99188c626
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3708995
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
c59a22e5
|
2022-06-17T17:28:26
|
|
Skip CompressedTexSubImage3DValidationPerSlice capture_replay
DXT1CompressedTextureTestES3.CompressedTexSubImage3DValidationPerSlice/ES3_Vulkan_SwiftShader
reports VUID-vkCmdCopyBufferToImage-srcImage-00201
Bug: angleproject:7438
Change-Id: Ie9b9e8fdf1292d330ed61cbb4791fc7b3e4ab8ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711749
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
0a7cfa08
|
2022-06-16T16:24:54
|
|
Vulkan: Fix marking external images as renderable
Bug: chromium:1266094
Change-Id: Ie8d7b82f859697530f6581c7109d773d6fa35d37
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3710690
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
ca96cba9
|
2022-06-16T11:33:14
|
|
Make ReadEntireFileToString return a std::string.
Note: this makes the method unavailable for export from angle_util,
which is probably why it was designed the way it was in the first
place. However, we import the test utils source file as a static
lib into each test executable and test shared module, so it works.
Bug: angleproject:7404
Change-Id: Ia957268882c2b8529643660d7d4f34d142c0dc43
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3708602
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Roman Lavrov <romanl@google.com>
|
|
|
5f1d0742
|
2022-06-17T13:11:00
|
|
Increase batch timeout with sanitizer
MemoryBarrierBufferOnlyTest got slow recently
Bug: angleproject:7439
Change-Id: I6f24fa9abb9dcc98ebb8c964860a292e89ec1e19
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711745
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
|
|
|
6ca9c55e
|
2022-06-13T10:32:39
|
|
Capture/Replay: Allow capturing of external textures
With the support for EGL textures enabled we can actually capture
the texture content.
Bug: angleproject:5822
Change-Id: I386827456d146a54d9790fdd9eadb39b2a6b87e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3702350
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
ea3bd30a
|
2022-06-13T11:44:45
|
|
Capture/Replay: Don't capture tex levels that are out-of-range
Bug: angleproject:6334
Change-Id: I01cb1920154b5fba9554180d2edf5be9dea2b7a2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3702351
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
72e457fe
|
2022-06-03T15:36:01
|
|
Vulkan: Promptly destroy cached framebuffer when it becomes invalid
When Texture gets respecified, the VkFramebuffer cache created out of it
becomes invalid and will never possibly get used. Before this CL, we
never clear such invalid framebuffer objects from the cache. This CL
keeps a reference to the cache key in each attachment and will
immediately destroy the cached VkFramebuffer object when one of the
attachment has become invalid.
Bug: b/234769934
Change-Id: Ib01f6dffe9211084b1ada340081daf905e3f1bef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3682164
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
97a6e581
|
2022-05-30T16:50:26
|
|
Vulkan: Useful implementation of program binaries
ANGLE already serializes the pipeline state for the sake of
OES_get_program_binary. This serialization had limited usefulness
however, since the Vulkan driver hasn't actually created any pipelines
yet (which is a costly part of program creation).
Simultaneously, ANGLE deferred Vulkan pipeline creation to draw time,
which causes hitching.
In this change, a handful of Vulkan pipelines are precreated at
link time; those at least that are sure to create different blobs in the
pipeline cache (different spec consts or SPIR-V generation). These
pipelines are created in the program executable's cache. The cache is
then merged into the shared renderer cache (for potential blob reuse by
other programs).
With this, two goals are achieved:
- Most pipelines created at draw time hit the pipeline cache, avoiding
costly compilation.
- When the program binary is retrieved, the contents of the program
executable's pipeline cache is also returned. On reload, the cache is
recovered, resulting in faster startup.
Bug: angleproject:5881
Change-Id: I46c5451a7d0b16dffd40e44015e094640886880b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3671977
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
0bc70e96
|
2022-06-10T22:27:04
|
|
Vulkan: Rename getShareGroupVk to getShareGroup
+ other miscellaneous clean up
Bug: angleproject:7375
Change-Id: I25690860478a2fd181a67ce2b6cb4d7aac7dbaa7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700197
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
8a8b9665
|
2022-06-08T14:54:37
|
|
Vulkan: Prune superseded staged updates in a texture
Add support for pruning superseded staged updates from a client buffer
to the texture. If the staged update count or the cumulative staged
updates' size exceeds a threshold we check for superseded updates and
prune the list.
Bug: angleproject:4691
Bug: angleproject:7389
Test: Texture2DTest.InterleavedSupersedingTextureUpdates*
Texture2DTest.ManySupersedingTextureUpdates*
Change-Id: I4b84f13fa20004a3dc68baa552a0af656d92c0a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3691092
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
1131f117
|
2022-06-14T11:49:15
|
|
Support BGRX8 for framebuffer blits
For WebGL content, Chrome usually needs to perform MSAA resolve on
the WebGL buffer before compositing via a blit. On ChromeOS, this
read buffer is usually in BGRX as it is the native format for the
display hardware which eventually gets coerced to GL_BGRX8_ANGLEX in
ANGLE.
Unfortunately, ANGLE claims limited support for this format, so the
blit subsequently fails, resulting in a black screen on some WebGL 1
apps. This CL fixes a validation error and marks BGRX8 as filterable
so that ANGLE's blit framebuffer implementation can actually operate
on GL_GBRX8_ANGLEX targets.
Bug: b/233238923
Change-Id: I378c177c9770d98a8fdb8284335ada66f7907a69
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3703621
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Brian Ho <hob@chromium.org>
|
|
|
c41dae02
|
2022-06-15T19:41:39
|
|
Further suppress MultithreadingTestES3 hanging tests on Linux SwANGLE
Also MultithreadingTestES3.ThreadB*BeforeThreadASyncFlush.
Bug: angleproject:7431
Change-Id: Ib27afb4ed6862580dbe64c38d3eaca2040f7c1ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707272
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
a62204c3
|
2022-06-15T14:01:17
|
|
Guard all imports of wayland.gni with angle_use_wayland
Fixes build errors in Skia
Bug: angleproject:7434
Change-Id: I99e8ab741c0128f7327fec08e04979edde4f19e9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707852
Reviewed-by: Antonio Caggiano <antonio.caggiano@collabora.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Brian Osman <brianosman@google.com>
|
|
3faaded8
|
2022-06-15T11:28:58
|
|
Missing include for std::isdigit
Bug: angleproject:7430
Change-Id: I2b374c826c4b29a4e290378a3cd18d2df49268b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3708312
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
a471d4bd
|
2022-06-15T14:33:22
|
|
Ensure ANGLERenderTest.mTestParams lifetime using unique_ptr
Passing a reference is fragile, this currently works because factory
outlives the test and so do captures:
https://crsrc.org/c/third_party/angle/src/tests/perf_tests/TracePerfTest.cpp;drc=54e08a5af1f7ca50d5c154a09cc056166a9e49fa;l=2143
but if a temporary or a scoped object is passed to the constructor in
the same spot then this blows up due to use after free, which is easy to
run into accidentally as it is uncommon that f(const T&) would hold onto
the reference and expect it to outlive the function call.
In most cases ANGLERenderTest.mTestParams is initialized with GetParam()
which comes from a base class and that
Bug: angleproject:7410
Change-Id: I32ea8b79ad746129d4088d44fef2a37cc9c81b80
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697436
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
9d08c29a
|
2022-05-25T11:39:29
|
|
Expose the EGL Display Context Set in the DisplayState.
This will let the Vulkan back-end iterate through and flush pending
command buffers in other Contexts.
Bug: angleproject:5664
Change-Id: I0d22eb68fa754a97b4836ec8c59ff8c6e5ef2d96
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3668145
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
153d8db9
|
2022-06-06T13:49:40
|
|
Turn missing {trace_name}.json trace files into test failures.
Before this change, a missing or broken trace json file results in all
trace tests "disappear" from the list with only ERR in logs. After this
change, a missing or broken trace json will result in that specific test
FAIL status and error in logs.
Note that this also allows for inconsistency between
restricted_traces.json and trace json files on the device because we're
no longer requiring for trace json to be loaded unless the test is
actually being run.
Bug: angleproject:7410
Change-Id: I07532dc0bf85a0d2fcaf425ce8d4a589473a898d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690734
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
c2220ecf
|
2022-06-13T16:11:25
|
|
Always log FATAL, ERR messages
is_debug=false in gn args
together with angle_assert_always_on=false (default)
results in no logs in logcat, which makes sense if you know
that logs are conditional on ANGLE_ENABLE_ASSERTS but is pretty
confusing when running into this accidentally.
Bug: None
Change-Id: I67499a34cd3d02fd7d17680a4cb62d263883b301
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3703619
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
|
|
3c81c9d1
|
2022-06-14T19:24:27
|
|
Enable perFrameWindowSizeQuery on Android
It was decided that Android won't return VK_SUBOPTIMAL_KHR when the
window size changes. Android's Vulkan loader no longer needs IPC to
implement vkGetPhysicalDeviceSurfaceCapabilitiesKHR(). Therefore, we
will call vkGetPhysicalDeviceSurfaceCapabilitiesKHR() per
eglSwapBuffers() on Android.
Bug: b/236026298
Change-Id: I3f66148ef5ed456e4408d64cc38fc6e0fe8b17cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3706160
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>
Auto-Submit: Ian Elliott <ianelliott@google.com>
|
|
b257d62c
|
2022-06-15T03:15:56
|
|
Add GL_NV_read_depth_stencil
Bug: angleproject:4688
Change-Id: I44d5846f1ae5382b8c046e59643da4c0bf38e135
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3702356
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Constantine Shablya <constantine.shablya@collabora.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
39df42d3
|
2022-06-13T19:25:42
|
|
Vulkan: set storage external memory before the description
This is a partial revert of 86d9d66dce02f5ae27ca71a94fcdc485bcd7a3ad.
"Vulkan: Determined sized-ness of format in initImageViews."
When the image descriptions are set, then we already need the
storage information, otherwise the Vulkan validation layer may
complain, and the replay part of some Capture/Replay tests
will fail.
Bug: angleproject:7428
Change-Id: I40c70918a439939d3dcbb4aad703fd05eb8104c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3702357
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
543dcdde
|
2022-06-09T10:50:41
|
|
GN: Wayland build overrides
Introduce //build_overrides/wayland.gni to simplify the management of
the wayland dependencies.
Bug: chromium:1327041, angleproject:7409
Change-Id: I24cd7c0aa1025acbfe681afb07ccb384ff52bb62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697998
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
5a3e1dba
|
2022-06-14T13:18:44
|
|
Skip flaky hanging MultithreadingTestES3 on Linux SwANGLE
Bug: angleproject:7431
Change-Id: Id6e91cb5b996aeff5e143b8395cd2210cef414d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3702360
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
7c01db8f
|
2022-05-14T13:24:47
|
|
Add tests for loadOps in pixel local storage
Bug: angleproject:7279
Change-Id: If060bae529d9af25cbc3e941d92fe32b2b254f22
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3652702
Auto-Submit: Chris Dalton <chris@rive.app>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
|
f1c21d68
|
2022-06-04T02:26:36
|
|
Add pixel local storage tests for all supported formats
Bug: angleproject:7279
Change-Id: I92728112f243cccf4e4ab2c5f4c096dcc0536fc2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3654266
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
59476401
|
2022-06-10T10:52:57
|
|
Missing include for std::toupper
This fixes the Windows build in Flutter's build environment.
Bug: angleproject:7430
Change-Id: Ia53c81dbd8c28e1122e3cf680c7c48b62ecb9caf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3704236
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Dan Field <dnfield@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
c5ee5a9c
|
2022-06-10T10:29:11
|
|
Vulkan: Add test CreateDestroyTextureDoesNotIncreaseDescSetCache
This adds a test to demonstrate a usage pattern seen with surfaceflinger
(see b/234602034 for detailed reproduce steps). With every iteration of
notification shade pop up, after all other optimization, we are still
seeing four descriptor sets gets allocated. Surfaceflinger is allocating
AHB and texture every time and after usage it gets destroyed. This test
uses normal texture instead of EGLImage for easy of debugging on
linux/windows platform, but it demonstrated the exact same problem with
AHB texture.
Bug: b/235523746
Change-Id: I7ca1ff13b61ade1449a56d3afc8a84926ad13850
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700570
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
|
|
|
fd1317a7
|
2022-03-22T18:57:30
|
|
Capture/Replay: capture GetProgramBinaryOES parameters
Bug: angleproject:6631
Change-Id: I0582c585bb2f3d14b10f99fe1b88805b9e629b78
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3543805
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
fec66d30
|
2022-06-13T14:02:09
|
|
Skip 4 end2end tests flaky on Mac NVIDIA GL
BlitFramebufferTest.NonZeroBaseSource
BlitFramebufferTest.NonZeroBaseSourceStencil
CopyTextureTestES3.InvalidateCopyThenBlend
CopyTextureTestES3.InvalidateBlitThenBlend3Layers
Bug: angleproject:5001, angleproject:5155
Change-Id: I25a3445e917dcc3322ad83c44158dba28454d218
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3702354
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
f33f6aa8
|
2022-06-10T23:45:14
|
|
Capture/Replay: Skip multithreading tests that time out
Bug: angleproject:7423
Change-Id: I8110d943cfa0f57005633c9a71106932ea053810
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700199
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
45c57333
|
2022-06-10T22:34:25
|
|
Roll VK-GL-CTS from 8817dcf9c1ec to 50754c3c19c0 (11 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/8817dcf9c1ec..50754c3c19c0
2022-06-09 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/main
2022-06-09 peter.kohaut@arm.com Fix Android build
2022-06-09 gleese@broadcom.com Shrink the framebuffer in more graphicsfuzz tests
2022-06-09 gleese@broadcom.com Remove superfluous 'resolution' from graphicsfuzz test
2022-06-09 younggwan.kim@arm.com Add KHR-GLESEXT.fragment_shading_rate tests
2022-06-09 piotr.byszewski@mobica.com Run DR draw tests with secondary command buffers
2022-06-09 jari.komppa@siru.fi Add recipe for amber-verify run mode
2022-06-09 ari.suonpaa@siru.fi Add new test cases for VK_EXT_load_store_op_none
2022-06-09 peter.kohaut@arm.com Update Vulkan headers
2022-06-09 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main
2022-06-09 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-bots+autoroll-info@google.com,syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:7422
Change-Id: I6b3498372fa755f6b70ad953e59bd2f2dd0bd6b7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700198
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
1c1b2a52
|
2022-06-10T16:12:08
|
|
Suppress failing test
Bug: angleproject:7398
Change-Id: Ic9e76e7925e01bea35c41a3fd1688e79b1d3ec26
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697624
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
685d9175
|
2022-06-10T13:35:06
|
|
Remove the build flag -Wno-deprecated-declarations
Now that the commit
https://github.com/KhronosGroup/VK-GL-CTS/commit/44b613a986253cdde28283497731a7b909b520bc
is included in angle's latest deps roll, we can remove the flag
silencing the clang warning as std::iterator is no longer used.
Bug: angleproject:7349
Change-Id: Ie7f3b4e245593ceb241a9e3a00593f99fa360492
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697621
Auto-Submit: Alan Zhao <ayzhao@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Alan Zhao <ayzhao@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
|
|
|
c73ea49a
|
2022-06-10T13:39:54
|
|
Reland "Remove cwd manipulations."
This reverts commit 4e37ec8c021e5739e720d2847ac814f8eef296a6.
Reason for revert: Turns out it wasn't necessary.
Original change's description:
> Revert "Remove cwd manipulations."
>
> This reverts commit c11af00ae1d10d43a71a28c07f99969665c4ea2a.
>
> Reason for revert: Needed for http://crrev.com/c/3690739
>
> Original change's description:
> > Remove cwd manipulations.
> >
> > Doesn't appear to be needed as the underlying functions
> > are already using the executable path.
> >
> > Bug: angleproject:7410
> > Change-Id: Ia9566c7159624bcb039d7dd2e9d23f4b18649f45
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695519
> > Commit-Queue: Roman Lavrov <romanl@google.com>
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
>
> Bug: angleproject:7410
> Change-Id: I397ed2e75155a774c45af9c67e5906932183f1c8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696830
> Auto-Submit: Jamie Madill <jmadill@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bug: angleproject:7410
Change-Id: I06487f345482e4c26ed78754395054b43d182357
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697310
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
9797401b
|
2022-06-09T22:41:11
|
|
Tests: Add Star Wars: KOTOR trace
Test: angle_perftests --gtest_filter="*star_wars_kotor*"
Bug: angleproject:7353
Change-Id: I20027ad4963d86609cbb0ffad5d57dbe83371ada
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3699198
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
89aa1027
|
2022-06-07T12:19:54
|
|
Specify display to EGL query in print info test.
This will be backwards-compatible with EGL 1.4 and non-ANGLE
GL implementations.
Bug: angleproject:7396
Change-Id: I78a6c5b9a0d49ef9768b9a5895f6280d22e64123
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3692267
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Jamie Madill <jmadill@chromium.org>
|
|
|
81585fe2
|
2022-06-08T14:37:38
|
|
Use consistent test names with dEQP.
This removes the GTest/dEQP test name distinction.
Using the "RegisterTests" method in GTest we can use the
full dEQP test names. The one limitation is that "-" is
reserved in GoogleTest for exclusion filters, so we need
to do some extra work to sanitize our filters before we
pass them to GoogleTest.
Makes maintaining test expectations easier going forward.
Bug: angleproject:7390
Change-Id: I23893c425ddc934c11fe539b9173ec06c58abcc2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695518
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
3dfc8004
|
2022-06-08T14:24:48
|
|
Vulkan: Optimize sync followed by swap
Previously, inserting a sync object immediately caused a submission.
That was done in
https://chromium-review.googlesource.com/c/angle/angle/+/3200274 to be
able to wait until the sync object is signaled without having to wait
for whatever is recorded after it until a flush naturally happens.
Some applications issue a glFenceSync right before eglSwapBuffers. The
submission incurred by glFenceSync disallowed the optimizations that
eglSwapBuffers would have done, leading to performance degradations.
This could have been avoided if glFenceSync was issued right after
eglSwapBuffers, but that's not the case with a number of applications.
In this change, when a fence is inserted:
- For EGL sync objects, a submission is issued regardless
- For GL sync objects, a submission is issued if there is no render pass
open
- For GL sync objects, the submission is deferred if there is an open
render pass. This is done by marking the render pass closed, and
flagging the context as having a deferred flash.
If the context that issued the fence sync issues another draw call, the
render pass is naturally closed and the submission is performed.
If the context that issued the fence sync causes a submission, it would
have a chance to modify the render pass before doing so. For example,
it could apply swapchain optimizations before swapping, or add a resolve
attachment for blit.
If the context that issued the fence sync doesn't cause a submission
before another context tries to access it (get status, wait, etc), the
other context will flush its render pass and cause a submission on its
behalf. This is possible because the deferral of submission is done
only for GL sync objects, and those are only accessible by other
contexts in the same share group.
Bug: angleproject:7379
Change-Id: I3dd1c1bfd575206d730dd9ee2e33ba2254318521
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695520
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
4c6d47c8
|
2022-06-08T15:20:49
|
|
Vulkan: Optimize glEGLImageTargetTexture2DOES with same args
If we are creating a texture with the same source eglImage, right now we
will release the existing mImage (will not actually destroyed) and then
free VkImageViews. Then it point back to the same mImage and allocate
new VkImageViews. Since these ImageViews have different serial number,
we end up with DescriptorSet cache miss. This CL avoid all these hassles
if we are creating with the exact same image.
Bug: b/234602034
Change-Id: I04cec05716974e274d6e3678e91ff248f50e9355
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697204
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Auto-Submit: Charlie Lao <cclao@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
ce78f5f8
|
2022-05-10T09:10:30
|
|
Capture/Replay: Reset default uniforms
Extend resource tracking to include default uniforms.
They are tracked per location, per program.
Setup for defaulft uniforms is unchanged, but Reset now
includes a section like this:
glUseProgram(gShaderProgramMap[6]);
UpdateCurrentProgram(6);
glUniform1uiv(gUniformLocations[gCurrentProgram][0], 1,
reinterpret_cast<const GLuint *>(&gBinaryData[30518768]));
glUniform1uiv(gUniformLocations[gCurrentProgram][1], 1,
reinterpret_cast<const GLuint *>(&gBinaryData[30518784]));
glUseProgram(gShaderProgramMap[9]);
UpdateCurrentProgram(9);
glUniform4fv(gUniformLocations[gCurrentProgram][1], 15,
reinterpret_cast<const GLfloat *>(&gBinaryData[30518960]));
glUniform4fv(gUniformLocations[gCurrentProgram][16], 3,
reinterpret_cast<const GLfloat *>(&gBinaryData[30519200]));
glUniformMatrix4fv(gUniformLocations[gCurrentProgram][20], 2, GL_FALSE,
reinterpret_cast<const GLfloat *>(&gBinaryData[30519248]));
...
Test: Animal Crossing MEC, Star Wars KOTOR MEC
Bug: angleproject:7307
Bug: angleproject:7353
Change-Id: Ic344767f5dd4ffc38c15ed6bf81a7d1daf274a7b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3657474
Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
a894cb94
|
2022-05-10T21:15:59
|
|
Bootstrap pixel local storage
This CL creates a very simple prototype that implements pixel local
storage in a thin layer on top of ES 3.1 shader images, and adds a
single test.
Assuming all goes well on the various devices and backends, the next
steps will be:
* Write many more tests.
* Compiler support, switch to API-specific shader images.
* Move the thin layer into ANGLE.
* Thorough validation and error handling.
* Add an implementation that uses render target attachments
(e.g., EXT_shader_framebuffer_fetch).
* Incremental, backend-specific optimizations as needed.
Bug: angleproject:7279
Change-Id: I7f9f0a1fe2d61f570b4105a7380687038ae45f5d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645786
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ee1dd7f4
|
2022-06-08T13:17:39
|
|
Vulkan: Add test for glEGLImageTargetTexture2DOES issue
This add a test that repeatedly calling glEGLImageTargetTexture2DOES on
the same source EGLImage with the same texture parameters should not
causing texture's descriptor set cache to keep growing. This is the
usage pattern we are seeing with surfaceflinger.
Bug: b/234602034
Change-Id: I38ec0a0b2580b8985c27e8c9f7edf14aa7843023
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696677
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
715175de
|
2022-06-03T22:11:30
|
|
Vulkan: Don't enable Qualcomm workarounds on OSS driver
Bug: b/217265716
Change-Id: I09cf38a36f8297912f0c26867155cf4f9e145919
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3689810
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Chia-I Wu <olv@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
|
|
|
da9390d6
|
2022-06-08T22:38:18
|
|
Vulkan: Fix the VulkanRenderPassBufferCount overlay widget
This widget was declared as a histogram, but used as a graph. The
graph's add() interface is made hidden in histograms to avoid such
mistakes in the future.
Bug: angleproject:4950
Change-Id: I95a1b6badbe27b870273589271b13c454c8a4e56
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697438
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
0408b129
|
2022-06-08T22:20:32
|
|
Overlay: Support globbing
Makes it less tedious to specify multiple widgets. In particular, it
also makes it possible to select many widgets on Android through
`adb shell setprop debug.angle.overlay` which has a hard limit of 92
characters for the property.
Bug: angleproject:5881
Change-Id: I93bd166cd3dbf8f87e5c6a5fce3f86ebb3e379a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697437
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
2587e508
|
2022-05-26T17:44:47
|
|
Vulkan: Remove redundant vertex array dirty bit processing
When BINDING0+n and ATTRIB0+n dirty bits are both set, we are going
down syncState twice. What BINDING0+n covers all the work needed for
attribute and DATA0+n, so we should remove the ATTRIB0+n and DATA0+n.
Similarly if we see DATA0+n, we should skip ATTRIBU0+n as well.
Bug: b/235277703
Change-Id: I5e03c18bac3df30a14f3b6652caff2aff33f2fe6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3669608
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
76e98ae1
|
2022-06-09T09:11:28
|
|
Roll VK-GL-CTS from acf70aaf3fdb to 8817dcf9c1ec (36 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/acf70aaf3fdb..8817dcf9c1ec
2022-06-09 piotr.byszewski@mobica.com Split pipeline.txt mustpass into multiple files
2022-06-09 vantablack@google.com Add R8_UNORM to the external AHB memory tests
2022-06-09 michal.jakubek@mobica.com More EXT_color_write_enable tests.
2022-06-08 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_image_compression_control into vk-gl-cts/main
2022-06-08 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_KHR_fragment_shader_barycentric into vk-gl-cts/main
2022-06-07 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_KHR_ray_tracing_maintenance1 into vk-gl-cts/main
2022-06-07 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/main
2022-06-03 pdaniell@nvidia.com Fix regression from CL-9387 to handle empty cache properly
2022-06-03 pdaniell@nvidia.com Fix deqp-vksc build break from CL-9046
2022-06-03 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/vulkansc-cts-1.0.0 into vk-gl-cts/main" into main
2022-06-02 marcin.zajac@mobica.com Thread safe releaseQueue
2022-06-02 toni.merilehti@siru.fi Fix extension check in transform feedback tests
2022-06-02 juha.heiskanen@siru.fi Fix amber-verify mismatch in builtin precision tests
2022-06-02 gleese@broadcom.com Shrink the framebuffer in 2 graphicsfuzz tests
2022-06-02 antto.makinen@siru.fi Test VkSubresourceLayout::offset is relative to the start of an image
2022-06-02 jari.komppa@siru.fi Add inter-process communcation to shader cache
2022-06-02 jbolz@nvidia.com Add command line parameter to override Vulkan library path
2022-06-02 juha.heiskanen@siru.fi Dynamic rendering with NULL shading rate image
2022-06-02 rgarcia@igalia.com Test imageSize() on 2D image views from 3D images
2022-06-02 juha.heiskanen@siru.fi Bug fix for current variableSampleLocations tests + new tests
2022-06-02 toni.merilehti@siru.fi Test single-path switch statements
2022-06-02 jmadill@google.com Remove usages of std::iterator
2022-06-02 pierre-eric.pelloux-prayer@amd.com Fix ShaderBallotFunctionRead test
2022-06-02 younggwan.kim@arm.com Add autogenerate with GL_EXT_fragment_shading_rate
2022-06-02 ayzhao@google.com Remove usages of std::iterator
2022-06-02 younggwan.kim@arm.com Update gl.xml and fix script to build properly
2022-06-02 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main
2022-06-02 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main
2022-05-20 marcin.zajac@mobica.com writeSupportedExtensions for VKSC
2022-05-20 marcin.zajac@mobica.com Missing VK_KHR_object_refresh
2022-05-17 juha.heiskanen@siru.fi Add required support check for IsHelperInvocationEXT test
2022-05-17 ari.suonpaa@siru.fi Add a batch of GraphicsFuzz coverage tests
2022-05-17 pdaniell@nvidia.com Test poolSizeCount can be zero
2022-05-17 jari.komppa@siru.fi Add tests for vkGet...SurfacePresentModes2EXT
2022-05-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/main
2022-05-13 marcin.zajac@mobica.com Merge branch 'vulkan-sc-cts-dev' into 'main'
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-bots+autoroll-info@google.com,syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:7416
Change-Id: I289aec7e7b0991556303efa70bd665fb66e43731
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696826
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
0f8f760d
|
2022-06-07T17:52:52
|
|
Disable KHR_no_error for Android/SwiftShader
Speculatively fix crash in Skia on ANGLE that has been happening.
In addition, prevent other crashes in the future.
Bug: b/220069903
Change-Id: I01b9896a6feb8be524849dafbc1df9526fc98754
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3694160
Commit-Queue: Ian Elliott <ianelliott@google.com>
Auto-Submit: Ian Elliott <ianelliott@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
5fbb0417
|
2022-05-26T15:05:52
|
|
Vulkan: Handling VK_EXT_load_store_op_none on ARM
There is a bug on at least one ARM device when either
depth or stencil load op is none. Add a temporary work
around to avoid this case for ARM driver until
angleproject:7370 is addressed. Also add a test to
reproduce the deqp test failures with simiplied draw calls.
Bug: angleproject:7370
Bug: angleproject:7351
Change-Id: I74ac49a75f85b1e006ed3b1d77f234f63d314ae0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3671696
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d47c8e0a
|
2022-04-04T15:08:45
|
|
Vulkan: Enable custom border colors on SwiftShader
This extension can now be enabled on SwiftShader after bug fixes that
landed in
https://swiftshader-review.googlesource.com/c/SwiftShader/+/64688 and
https://swiftshader-review.googlesource.com/c/SwiftShader/+/66148
Bug: angleproject:6200
Bug: b/227518327
Change-Id: I65fb342a96c47b1ea5ba2ee773c8ae5539052b94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3569585
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
4b9eb4ba
|
2022-06-03T09:22:41
|
|
Optionally support vulkan_memory_allocator 3.x
Incompatible API is guarded behind a new define, ANGLE_VMA_VERSION.
This allows a soft migration for Chromium and Fuchsia, while allowing
clients like Flutter to roll to a new version that is compatible with
its revision of Skia.
Bug: chromium:1332566
Change-Id: I68cafde13e50445aa8eea2f18203143659a1c627
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3688835
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Dan Field <dnfield@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
4e37ec8c
|
2022-06-09T16:44:44
|
|
Revert "Remove cwd manipulations."
This reverts commit c11af00ae1d10d43a71a28c07f99969665c4ea2a.
Reason for revert: Needed for http://crrev.com/c/3690739
Original change's description:
> Remove cwd manipulations.
>
> Doesn't appear to be needed as the underlying functions
> are already using the executable path.
>
> Bug: angleproject:7410
> Change-Id: Ia9566c7159624bcb039d7dd2e9d23f4b18649f45
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695519
> Commit-Queue: Roman Lavrov <romanl@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Bug: angleproject:7410
Change-Id: I397ed2e75155a774c45af9c67e5906932183f1c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696830
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
07a6f0b2
|
2022-06-09T09:43:52
|
|
Removes uses of sprintf() in ceval.
Adds a patches/ directory with diffs from upstream ceval and updates
README.chromium with a description of each diff.
Bug: chromium:1331345
Change-Id: I876e0a3cb4f70472d8a340649f00d94141604fda
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696824
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
48b928d9
|
2022-06-07T16:21:04
|
|
Vulkan: Overlay widgets for pipeline cache/hit stats
Bug: angleproject:5881
Change-Id: I1893e6b76a5a73ea51b67bc4ee8a5d5dfc54166e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3689604
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
c11af00a
|
2022-06-08T14:45:58
|
|
Remove cwd manipulations.
Doesn't appear to be needed as the underlying functions
are already using the executable path.
Bug: angleproject:7410
Change-Id: Ia9566c7159624bcb039d7dd2e9d23f4b18649f45
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695519
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
a65af046
|
2022-06-08T11:57:59
|
|
De-template out dEQP GTest bridge class.
This class doesn't need to be a template, and can take
the test case index parameter instead from a common macro.
Refactoring only, done in the process of trying to update
our dEQP test case registration to get better test names.
Bug: angleproject:7390
Change-Id: Ia104a0055ddb9cbc6d311d220d8d4e486214928f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695945
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Roman Lavrov <romanl@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|