-
Show log
Commit
-
Hash : d10cf69e
Author :
Date : 2017-11-02T11:06:14
Remove repeated "success" check from compileTreeImpl This refactoring simplifies the compilation code by putting AST checks and simplification into a separate function. This function will immediately return false when an error is encountered. This is easier to maintain than repeated checking of a "success" boolean. BUG=angleproject:2068 TEST=WebGL conformance tests, angle_unittests, angle_end2end_tests Change-Id: I1ae1c8def3625ada1482104a6babe605405229ef Reviewed-on: https://chromium-review.googlesource.com/750085 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
-
Files
- 64bit-lexer-safety.patch
- ASTMetadataHLSL.cpp
- ASTMetadataHLSL.h
- AddAndTrueToLoopCondition.cpp
- AddAndTrueToLoopCondition.h
- AddDefaultReturnStatements.cpp
- AddDefaultReturnStatements.h
- ArrayReturnValueToOutParameter.cpp
- ArrayReturnValueToOutParameter.h
- BaseTypes.h
- BreakVariableAliasingInInnerLoops.cpp
- BreakVariableAliasingInInnerLoops.h
- BuiltInFunctionEmulator.cpp
- BuiltInFunctionEmulator.h
- BuiltInFunctionEmulatorGLSL.cpp
- BuiltInFunctionEmulatorGLSL.h
- BuiltInFunctionEmulatorHLSL.cpp
- BuiltInFunctionEmulatorHLSL.h
- Cache.cpp
- Cache.h
- CallDAG.cpp
- CallDAG.h
- ClampPointSize.cpp
- ClampPointSize.h
- CodeGen.cpp
- CollectVariables.cpp
- CollectVariables.h
- Common.h
- Compiler.cpp
- Compiler.h
- ConstantUnion.cpp
- ConstantUnion.h
- DeclareAndInitBuiltinsForInstancedMultiview.cpp
- DeclareAndInitBuiltinsForInstancedMultiview.h
- DeferGlobalInitializers.cpp
- DeferGlobalInitializers.h
- Diagnostics.cpp
- Diagnostics.h
- DirectiveHandler.cpp
- DirectiveHandler.h
- EmulateGLFragColorBroadcast.cpp
- EmulateGLFragColorBroadcast.h
- EmulatePrecision.cpp
- EmulatePrecision.h
- ExpandIntegerPowExpressions.cpp
- ExpandIntegerPowExpressions.h
- ExtensionBehavior.cpp
- ExtensionBehavior.h
- ExtensionGLSL.cpp
- ExtensionGLSL.h
- FindMain.cpp
- FindMain.h
- FindSymbolNode.cpp
- FindSymbolNode.h
- FlagStd140Structs.cpp
- FlagStd140Structs.h
- HashNames.cpp
- HashNames.h
- ImageFunctionHLSL.cpp
- ImageFunctionHLSL.h
- InfoSink.cpp
- InfoSink.h
- Initialize.cpp
- Initialize.h
- InitializeDll.cpp
- InitializeDll.h
- InitializeGlobals.h
- InitializeVariables.cpp
- InitializeVariables.h
- IntermNode.cpp
- IntermNode.h
- IntermNodePatternMatcher.cpp
- IntermNodePatternMatcher.h
- IntermNode_util.cpp
- IntermNode_util.h
- IntermTraverse.cpp
- IntermTraverse.h
- IsASTDepthBelowLimit.cpp
- IsASTDepthBelowLimit.h
- NodeSearch.h
- Operator.cpp
- Operator.h
- OutputESSL.cpp
- OutputESSL.h
- OutputGLSL.cpp
- OutputGLSL.h
- OutputGLSLBase.cpp
- OutputGLSLBase.h
- OutputHLSL.cpp
- OutputHLSL.h
- OutputTree.cpp
- OutputTree.h
- OutputVulkanGLSL.cpp
- OutputVulkanGLSL.h
- ParamType.h
- ParseContext.cpp
- ParseContext.h
- PoolAlloc.cpp
- PoolAlloc.h
- Pragma.h
- PruneNoOps.cpp
- PruneNoOps.h
- QualifierTypes.cpp
- QualifierTypes.h
- RecordConstantPrecision.cpp
- RecordConstantPrecision.h
- RegenerateStructNames.cpp
- RegenerateStructNames.h
- RemoveArrayLengthMethod.cpp
- RemoveArrayLengthMethod.h
- RemoveDynamicIndexing.cpp
- RemoveDynamicIndexing.h
- RemoveEmptySwitchStatements.cpp
- RemoveEmptySwitchStatements.h
- RemoveInvariantDeclaration.cpp
- RemoveInvariantDeclaration.h
- RemoveNoOpCasesFromEndOfSwitchStatements.cpp
- RemoveNoOpCasesFromEndOfSwitchStatements.h
- RemovePow.cpp
- RemovePow.h
- RemoveSwitchFallThrough.cpp
- RemoveSwitchFallThrough.h
- RewriteDoWhile.cpp
- RewriteDoWhile.h
- RewriteElseBlocks.cpp
- RewriteElseBlocks.h
- RewriteTexelFetchOffset.cpp
- RewriteTexelFetchOffset.h
- RewriteUnaryMinusOperatorFloat.cpp
- RewriteUnaryMinusOperatorFloat.h
- RewriteUnaryMinusOperatorInt.cpp
- RewriteUnaryMinusOperatorInt.h
- RunAtTheEndOfShader.cpp
- RunAtTheEndOfShader.h
- ScalarizeVecAndMatConstructorArgs.cpp
- ScalarizeVecAndMatConstructorArgs.h
- SearchSymbol.cpp
- SearchSymbol.h
- SeparateArrayInitialization.cpp
- SeparateArrayInitialization.h
- SeparateDeclarations.cpp
- SeparateDeclarations.h
- SeparateExpressionsReturningArrays.cpp
- SeparateExpressionsReturningArrays.h
- Severity.h
- ShaderLang.cpp
- ShaderVars.cpp
- SimplifyLoopConditions.cpp
- SimplifyLoopConditions.h
- SplitSequenceOperator.cpp
- SplitSequenceOperator.h
- StructureHLSL.cpp
- StructureHLSL.h
- SymbolTable.cpp
- SymbolTable.h
- SymbolUniqueId.cpp
- SymbolUniqueId.h
- TextureFunctionHLSL.cpp
- TextureFunctionHLSL.h
- TranslatorESSL.cpp
- TranslatorESSL.h
- TranslatorGLSL.cpp
- TranslatorGLSL.h
- TranslatorHLSL.cpp
- TranslatorHLSL.h
- TranslatorVulkan.cpp
- TranslatorVulkan.h
- Types.cpp
- Types.h
- UnfoldShortCircuitAST.cpp
- UnfoldShortCircuitAST.h
- UnfoldShortCircuitToIf.cpp
- UnfoldShortCircuitToIf.h
- UniformHLSL.cpp
- UniformHLSL.h
- UseInterfaceBlockFields.cpp
- UseInterfaceBlockFields.h
- UtilsHLSL.cpp
- UtilsHLSL.h
- ValidateGlobalInitializer.cpp
- ValidateGlobalInitializer.h
- ValidateLimitations.cpp
- ValidateLimitations.h
- ValidateMaxParameters.cpp
- ValidateMaxParameters.h
- ValidateOutputs.cpp
- ValidateOutputs.h
- ValidateSwitch.cpp
- ValidateSwitch.h
- ValidateVaryingLocations.cpp
- ValidateVaryingLocations.h
- VariablePacker.cpp
- VariablePacker.h
- VersionGLSL.cpp
- VersionGLSL.h
- WrapSwitchStatementsInBlocks.cpp
- WrapSwitchStatementsInBlocks.h
- blocklayout.cpp
- blocklayout.h
- blocklayoutHLSL.cpp
- blocklayoutHLSL.h
- emulated_builtin_function_data_hlsl.json
- emulated_builtin_functions_hlsl_autogen.cpp
- gen_emulated_builtin_function_tables.py
- generate_parser.sh
- glslang.h
- glslang.l
- glslang.y
- glslang_lex.cpp
- glslang_tab.cpp
- glslang_tab.h
- length_limits.h
- util.cpp
- util.h
