src


Log

Author Commit Date CI Message
Ebrahim Byagowi 7e3edfa4 2020-07-18T19:03:36 minor
Qunxin Liu 8e5bc535 2020-07-15T18:54:52 [subset] call collect_mapping only when --gids option is used. collect_mapping is time consuming as it iterates all codepoints in all cmap subtables, only trigger it when necessary
Ebrahim Byagowi 7c433ffd 2020-07-15T09:38:12 Add HB_CUSTOM_MALLOC definition So one can use just HB_CUSTOM_MALLOC instead need for define each of hb_*alloc_impl
Ebrahim Byagowi 60959b08 2020-07-14T20:28:06 [meson] execute find_program('gen-ragel-artifacts.py') only once should rename the script also
Ebrahim Byagowi 5c8e1bd2 2020-07-14T17:47:10 [meson] Don't allow introspection on static library
Ebrahim Byagowi 9566904c 2020-07-14T15:17:17 [morx] minor, mark with unlikely at least just to show this is the unusual path
Ebrahim Byagowi 11d583a9 2020-07-14T06:23:06 [aat] Consume glyph insertion from buffer's max_ops (#2223) Glyph insertion is an expensive operation and we like to have it limited based on buffer's input size which is handled by buffer's max_ops. clusterfuzz-testcase-minimized-harfbuzz_fuzzer-5754958982021120: Before the change: 0.67s user 0.00s system 99% cpu 0.674 total After the change: 0.02s user 0.00s system 98% cpu 0.024 total Which takes much longer on valgrind and tsan bots.
Ebrahim Byagowi 6937092a 2020-07-13T21:32:15 [py] apply lgtm.com python suggestions
Ebrahim Byagowi 2a182128 2020-07-13T20:41:13 [py] minor, comment buffer_add_utf8 call mainly to apply lgtm suggestion, looks better also however, some minor spacing is also applied.
Ebrahim Byagowi cdf18e83 2020-07-13T20:07:51 [py] minor, remove unnecessary pass discovered by lgtm
Ebrahim Byagowi 45d9e8d7 2020-07-13T19:25:53 [py] minor, remove unused import
Behdad Esfahbod 1dfa3385 2020-07-12T09:24:03 [arabic] Remove stale comment
Behdad Esfahbod 6a45df0a 2020-07-08T18:17:40 Fix -Wambiguous-reversed-operator warning Fixes https://github.com/harfbuzz/harfbuzz/issues/2554
jfkthame 1e6027e2 2020-07-05T22:44:10 [aat] Correct array indexing when looking up actions in KerxSubTableFormat4 (#2539) * [aat] Correct array indexing when looking up actions in KerxSubTableFormat4. - For action_type 0 and 1, there are 2 values per action record; for action_type 2, there are 4. So we need to account for these factors when indexing into the ankrData array. Fixes https://github.com/harfbuzz/harfbuzz/issues/2531.
Ebrahim Byagowi 122a2897 2020-07-05T22:45:11 [aat] Remove lcar support Very low use, only two distinct font files, Apple Chancery.ttf and Hoefler Text.ttc have it so it really doesn't worth the size addition and so, but one may argue that whole ligature caret is low use but guess we better to encourage GDEF one anyway.
Ebrahim Byagowi a3b9b94b 2020-07-06T00:05:21 [style] Remove fdsc support (#2541) It isn't exposed yet and low use between Apple fonts, 32 fdsc table vs 767 OS/2 tables, even Apple doesn't support it anymore per Ned.
Ebrahim Byagowi a6fb8ce9 2020-07-04T23:43:21 Minor, fix -Wrange-loop-analysis warnings Fixing these complains raised by newer versions of clang, ./hb-ot-layout-common.hh:1720:53: error: loop variable 'gid_klass_pair' is always a copy because the range of type 'hb_map_iter_t<hb_sorted_array_t<OT::HBGlyphID>, (lambda at ./hb-ot-layout-common.hh:1672:29), hb_function_sortedness_t::RETAINS_SORTING, nullptr>' does not return a reference [-Werror,-Wrange-loop-analysis] for (const hb_pair_t<hb_codepoint_t, unsigned>& gid_klass_pair : + it) And ./hb-ot-color-colr-table.hh:177:44: error: loop variable '_' is always a copy because the range of type 'hb_map_iter_t<hb_filter_iter_t<hb_map_iter_t<hb_range_iter_t<unsigned int, unsigned int>, (lambda at ./hb-ot-color-colr-table.hh:209:31), hb_function_sortedness_t::RETAINS_SORTING, nullptr>, (anonymous struct at ./hb-algs.hh:331:1) &, (anonymous struct at ./hb-algs.hh:51:1) &, nullptr>, (anonymous struct at ./hb-algs.hh:338:1) &, hb_function_sortedness_t::RETAINS_SORTING, nullptr>' does not return a reference [-Werror,-Wrange-loop-analysis] for (const hb_item_type<BaseIterator>& _ : + base_it.iter ())
Jan Alexander Steffens (heftig) 44444822 2020-07-02T17:46:56 meson: Pin harfbuzz in .pc files to the built version This ensures that we link -subset, -icu and -gobject with a matching version of the main library.
Jan Alexander Steffens (heftig) 3adcf398 2020-07-02T16:41:22 meson: Make Requires in .pc files match autotools Libreoffice tries to use only harfbuzz-icu.pc and assumes this includes -lharfbuzz.
Ebrahim Byagowi 6a2b0ba7 2020-07-04T14:45:15 [py] minor, replace exit with sys.exit
Ebrahim Byagowi a07672d3 2020-07-04T14:12:55 [py] minor, replace os.environ.get with os.getenv
Ebrahim Byagowi 359dbc97 2020-07-04T12:28:06 [meson] Use the recommended way to generate harfbuzz.cc As https://github.com/harfbuzz/harfbuzz/pull/2532
Ebrahim Byagowi a7e82e4f 2020-07-04T12:04:41 [meson] use the recommended way to generate hb-version.h As https://github.com/harfbuzz/harfbuzz/pull/2532
Ebrahim Byagowi 404ecc25 2020-07-04T03:13:32 [meson] use basename in check scripts now that meson passes dir also
Ebrahim Byagowi 785a9a8f 2020-07-04T02:08:30 [meson] use the recommended way to generate ragel headers As described in https://github.com/mesonbuild/meson/issues/7156#issuecomment-629622827
Ebrahim Byagowi 5c07c291 2020-07-04T04:33:46 [make] use sed the way autotools used to generate hb-version.h Left from 1853f84 and now exactly is like 4fc6189a329c
Ebrahim Byagowi 63322513 2020-07-04T03:34:58 [make] Revert the way harfbuzz.cc and hb-version.h are generated Partially reverts 4fc6189
Ebrahim Byagowi 1853f84a 2020-07-03T15:14:10 [py] overwrite harfbuzz.cc only when there is a needed change
Ebrahim Byagowi 82c6ddb9 2020-07-03T15:09:10 [py] remove not needed imports
Ebrahim Byagowi 42d039cc 2020-07-03T04:32:32 [meson] minor
Ebrahim Byagowi f2a80ab2 2020-07-03T04:28:08 [meson] use null_dep idiom
Ebrahim Byagowi d5439232 2020-07-02T01:30:24 [fvar] minor
Hugo Beauzée-Luyssen 40ec187d 2020-04-24T14:01:07 win32: Cleanup PARTITION handling Use the WINAPI_PARTITION macro to filter desktop/app flavors. We use a negated desktop check because the default (for mingw-w64 at least) is to allow all API by combining desktop + app partitions. This causes build failures if we were to filter using WINAPI_PARTITION(WINAPI_FAMILY_APP) because it would always be true, but those API also require Windows 8 or later, while we only require Vista Fixes warnings like ../src/hb-blob.cc:572:47: warning: 'WINAPI_FAMILY_PC_APP' is not defined, evaluates to 0 [-Wundef] #if defined(WINAPI_FAMILY) && (WINAPI_FAMILY==WINAPI_FAMILY_PC_APP || WINAPI_FAMILY==WINAPI_FAMILY_PHONE_APP) ^ ../src/hb-blob.cc:572:86: warning: 'WINAPI_FAMILY_PHONE_APP' is not defined, evaluates to 0 [-Wundef] #if defined(WINAPI_FAMILY) && (WINAPI_FAMILY==WINAPI_FAMILY_PC_APP || WINAPI_FAMILY==WINAPI_FAMILY_PHONE_APP)
Ebrahim Byagowi ea8e7841 2020-06-30T12:54:29 [fvar] Improve naming
Ebrahim Byagowi 5de07b8a 2020-06-30T11:08:42 [fvar] Move normalize logic where it is actually filled
Ebrahim Byagowi 0f8dda2c 2020-06-30T10:53:12 [fvar] Move shared axis filling values into a new method
Ebrahim Byagowi 98c42b3b 2020-06-30T10:48:36 [fvar] Make AxisRecord fields protected
Behdad Esfahbod 7ee3194f 2020-06-28T15:41:44 [meta] Remove wrong comment
Behdad Esfahbod 26b9670d 2020-06-28T14:52:15 [ft] Better handle allocation failures Fixes https://github.com/harfbuzz/harfbuzz/issues/2513
Behdad Esfahbod 26111a11 2020-06-28T02:59:47 [dagger] Minor cleanup using hb_enumerate
Ebrahim Byagowi 08d57d9e 2020-06-28T13:13:25 Add hb_array_t::lfind
Behdad Esfahbod a7838407 2020-06-27T22:23:59 Always round up Fixes https://github.com/harfbuzz/harfbuzz/issues/2496
Sebastian Rasmussen 2267da4e 2020-06-28T11:18:16 [ft] Do not deference ft_font if it is nullptr (#2502)
Sebastian Rasmussen a373e161 2020-06-28T11:09:45 [ot-shape] Free shape plan maps upon error creating data (#2497)
Sebastian Rasmussen dbf9896e 2020-06-28T10:57:34 [ft] Handle nullptr when destroying freetype font (#2494)
Ebrahim Byagowi 76ba619d 2020-06-23T20:49:43 Fix autotools's harfbuzz.cc build How this works? gen-harfbuzzcc.py operates at its own source path (see its 7th line) and that is reliable when used both on meson and autotools. Just like 19ecabed, weirdly this didn't come up sooner, guess it has something to do with timestamps. Fortunately whole harfbuzz.cc just doesn't matter for packagers but we can tag a release only for this if needed.
Sebastian Rasmussen 12a9d572 2020-06-24T03:25:43 [face] Destroy blob if face closure can not be created (#2490) This fixes issue #2489.
Ebrahim Byagowi 53b0a183 2020-06-22T18:04:01 Remove concept of stable/unstable from build tools We never practiced the concept of stable and unstable releases, let's remove the code and always use the stable scheme.
Ebrahim Byagowi e4203c14 2020-06-22T05:03:27 2.6.8
Ebrahim Byagowi e541fb47 2020-06-21T09:49:48 minor, replace single hb_apply daggers with foreach
Ebrahim Byagowi 8bca9a42 2020-06-21T09:18:12 [fvar] minor
Ebrahim Byagowi 82ec9ef2 2020-06-21T01:36:16 [fvar] minor simplification
Ebrahim Byagowi 4e37c48e 2020-06-20T23:57:45 [fvar] Remove get_axis_info and get_axis_deprecated
Ebrahim Byagowi 61c240f3 2020-06-20T13:24:32 [fvar] Push _axis_info fill logic deeper
Ebrahim Byagowi 47a0fbec 2020-06-21T02:34:59 [meson] Mark longer tests with slow So one can skip them easily by `meson test -Cbuild --no-suite slow`
Ebrahim Byagowi b2d0dba5 2020-06-20T12:07:42 [cpal] Port to dagger
Ebrahim Byagowi 25cf6874 2020-06-20T01:36:50 Use dagger in OffsetTable::get_table_tags (#2477)
Ebrahim Byagowi dce4353f 2020-06-20T01:24:41 Merge pull request #2476 from ebraminio/cv-get-chars [layout] Use dagger in hb_ot_layout_feature_get_characters
Ebrahim Byagowi 89a2c46e 2020-06-20T00:31:46 [math] Use dagger (#2478) * [math] Use dagger * [ot-math] Address Behdad's review
Ebrahim Byagowi d38eb49f 2020-06-19T23:40:42 Move the iteration logic to FeatureParamsCharacterVariants Hopefully I can make members protected also.
Ebrahim Byagowi 9b3d4f45 2020-06-19T23:33:07 Use dagger in hb_ot_layout_feature_get_characters The way it used to work was a bit nonidiomatic but the replacment is idiomatic way of iterating used elsewhere. The new code just doesn't check nullability of "characters", which isn't what we do anywhere else.
Ebrahim Byagowi 63422c4c 2020-06-19T23:24:04 [ot-layout] simplify
Ebrahim Byagowi 407bba3e 2020-06-19T23:12:42 minor move FeatureParamsCharacterVariants::sanitize method right above members
Ebrahim Byagowi f1488152 2020-06-19T23:07:28 [doc] Remove the not needed comment All the other similar iterating API are like this and don't have such comment, written at the time I wasn't familiar enough with the way such API are shaped.
Behdad Esfahbod 1535440b 2020-06-19T08:30:59 [dispatch] Fix debug builds
Ebrahim Byagowi bb9a40da 2020-06-19T19:22:47 [lcar] Use dagger
Behdad Esfahbod 6fbb59ab 2020-06-18T15:12:37 Use daggers in a few get_array functions As I review https://github.com/harfbuzz/harfbuzz/pull/2471
Ebrahim Byagowi a512ca8e 2020-06-19T10:46:12 Merge pull request #2473 from harfbuzz/gsub-alternate fixes #673
Behdad Esfahbod 70d6696c 2020-06-18T17:09:39 [dispatch] Don't require debug_depth for untraced objects
Behdad Esfahbod 5bc4cedd 2020-06-18T17:04:35 Rename
Behdad Esfahbod dc492d7c 2020-06-18T17:03:05 [dispatch] Comment
Behdad Esfahbod 25aec026 2020-06-18T16:58:01 [dispatch] Default return type to hb_empty_t
Behdad Esfahbod 8d0a90ac 2020-06-18T16:53:54 [dispatch] Default debug level to 0
Behdad Esfahbod d7d8604e 2020-06-18T16:51:01 Remove excessive trace routes
Behdad Esfahbod e47a2ab8 2020-06-18T16:48:07 Remove unused dispatcher names
Behdad Esfahbod b2a1accc 2020-06-18T16:41:31 Simplify get_glyph_alternates() dispatcher Trying to make it **very simple** to add a specialized dispatcher for one API to be routed to just a few objects (one in this case).
Behdad Esfahbod ffe8d3f3 2020-06-18T16:31:39 Use dispatch for get_glyph_alternates_t First time we do this in a way that if target object doesn't have the matching function we basically "ignore". Risky but I feel like is the right decision for this case. I'm going to put back the template varargs and use those, which would make the dispatcher be just that: "dispatcher", and wouldn't need to carry the call context. That would be a refreshing change I think.
Behdad Esfahbod bedf4171 2020-06-18T15:49:01 Push get_glyph_alternates() work all the way down
Behdad Esfahbod 5bede338 2020-06-18T15:25:19 Whitespace
Behdad Esfahbod e13aaaaa 2020-06-18T15:22:54 Move API to right place in header
Behdad Esfahbod 26514ad7 2020-06-18T15:22:07 Fix API comment
Ebrahim Byagowi 1bac8582 2020-06-18T22:56:07 [layout] Rename _get_alternates to _get_glyph_alternates
Behdad Esfahbod 9ef9ac37 2020-06-17T17:41:15 [gpos] Break cycle-of-2 when cursive attaching Fix thinko this time around. Fixes https://github.com/harfbuzz/harfbuzz/issues/2469
Ebrahim Byagowi d3c16979 2020-06-18T08:37:21 [layout] move alternate buffer iteration logic to AlternateSet
Ebrahim Byagowi 1348a2c8 2020-06-16T21:05:16 [layout] hb_ot_layout_lookup_get_alternates, a new API An API to retrieve one-to-one alternates from a given GSUB lookup index.
Behdad Esfahbod 3fe71957 2020-06-17T17:51:08 Revert "[gpos] Break cycle-of-2 when cursive attaching" This reverts commit 7090707de67e660ae626ecf774f6af8a63a692ab.
Behdad Esfahbod 7090707d 2020-06-17T17:41:15 [gpos] Break cycle-of-2 when cursive attaching Fixes https://github.com/harfbuzz/harfbuzz/issues/2469
Behdad Esfahbod e5de3918 2020-06-17T16:54:23 [indic] Add comment https://github.com/harfbuzz/harfbuzz/issues/2298#issuecomment-615318654
Behdad Esfahbod 41ef75f6 2020-06-17T16:29:09 [gsub] Don't substitute in ReverseChainSingleSubstFormat1 if missing substitute Fixes https://github.com/harfbuzz/harfbuzz/issues/2467
Behdad Esfahbod e7c79e16 2020-06-17T15:32:40 Merge pull request #2287 from simoncozens/instrumentation Add messages for GPOS/GSUB (take 2)
Simon Cozens fe926970 2020-06-16T09:12:44 Reformat messages again Messages can be: start/end table XXXX start/end lookup NNNN start/end subtable NNNN (for kerx/kern) start/end chainsubtable NNNN (for morx)
Ebrahim Byagowi cccdaf45 2020-06-12T11:15:37 [docs] minor revealed now that we turned gobject/gir build to 'auto'
Ebrahim Byagowi 4e7cb7e2 2020-06-12T01:38:16 minor, fix lists sorting
Qunxin Liu 973c47f6 2020-06-11T11:27:57 [subset] Move 2 experimental public api methods to be private methods in GSUB/GPOS. 2 methods are: hb_ot_layout_closure_lookups and hb_ot_layout_closure_features
Nirbheek Chauhan b88f1096 2020-06-09T20:06:50 meson: Export symbols for a DLL when not building statically `default_library` might be 'both', in which case we will fail to link when building with MSVC.
Khaled Hosny 5c8900ef 2020-06-08T02:29:04 [coretext] Properly check for macOS 10.10 Fixes https://github.com/harfbuzz/harfbuzz/issues/2452
Ebrahim Byagowi 0151da23 2020-06-06T01:48:23 [meson] Remove with_libstdcxx build option This was done in #770 but no indication of anyone is using it, let's remove it from our meson port and we can just don't care about it in autotools port after the migration to meson.
Behdad Esfahbod 56719474 2020-06-05T12:57:23 s/blacklist/blocklist/g
Christoph Reiter 03bd6ead 2020-06-03T23:52:10 [meson] Only pass required dependencies to everything Instead of passing dependencies as required we used one giant shared dependency list containing all dependencies for every library/executable. While this kinda works, the specified deps are also used for generating the pkg-config files and this leads to lots of Requires.private and Libs.private entries which aren't really needed. This removes the "deps" array and replaces it with a few smaller ones and makes sure the public libraries only get passed the dependencies actually needed. Fixes #2441
Ebrahim Byagowi 759df465 2020-06-04T15:49:54 [style] Hide behind HB_EXPERIMENTAL_API compile flag