Log

Author Commit Date CI Message
Ebrahim Byagowi f65a8a33 2020-07-19T18:13:48 [ci] run cov-analyze apparently we have to run that also ourselves, let's see
Ebrahim Byagowi ab1079b0 2020-07-18T23:05:50 Merge pull request #2577 from lazka/gha-msvc Use GitHub Actions for msvc bots
Ebrahim Byagowi 05ed1ee0 2020-07-18T23:05:26 [ci] Remove appveyor ci badge As https://github.com/harfbuzz/harfbuzz/pull/2577
Christoph Reiter 93aea76a 2020-07-18T19:32:19 Fix the GHA msvc build Use the 'ilammy/msvc-dev-cmd' action for setting up the msvc env, so we can use powershell everywhere. Remove a directory from PATH which was interfering with the meson build by providing an unrelated pkg-config.exe.
Ebrahim Byagowi d0e2addd 2020-07-18T22:14:52 minor
Ebrahim Byagowi 3a46ae51 2020-07-15T12:46:34 Use GitHub Actions for msvc bots
Ebrahim Byagowi 7e3edfa4 2020-07-18T19:03:36 minor
Qunxin Liu 8e5bc535 2020-07-15T18:54:52 [subset] call collect_mapping only when --gids option is used. collect_mapping is time consuming as it iterates all codepoints in all cmap subtables, only trigger it when necessary
Ebrahim Byagowi 1ebe5bad 2020-07-16T01:45:38 [ci] minor fix
Ebrahim Byagowi e9b71c29 2020-07-16T01:40:48 [ci] cleanup
Ebrahim Byagowi 8cbdb6fa 2020-07-15T13:32:57 [meson] Don't enable benchmark under the conditions ever As we don't want to make headache for packagers as we don't want to enable it when --auto-features=enabled is used.
Ebrahim Byagowi dc981fe9 2020-07-15T13:15:27 [meson] Merge gdi and uniscribe They are the same thing obviously
Christoph Reiter 8e7a9b6e 2020-07-15T09:01:53 msys2-ci: clean up
Christoph Reiter 9a4d590e 2020-07-15T07:38:20 CI: Port MSYS2 jobs from appveyor to github actions
Ebrahim Byagowi 945bcd72 2020-07-15T09:54:32 minor
Ebrahim Byagowi fa0436dd 2020-07-15T09:52:40 [ENOMEM][fuzzer/subset] early return if the result is null I don't see _or_fail APIs idiomatic for the project but since it is there, let's have this
Ebrahim Byagowi 7c433ffd 2020-07-15T09:38:12 Add HB_CUSTOM_MALLOC definition So one can use just HB_CUSTOM_MALLOC instead need for define each of hb_*alloc_impl
Ebrahim Byagowi 60959b08 2020-07-14T20:28:06 [meson] execute find_program('gen-ragel-artifacts.py') only once should rename the script also
Ebrahim Byagowi 5c8e1bd2 2020-07-14T17:47:10 [meson] Don't allow introspection on static library
Ebrahim Byagowi 9566904c 2020-07-14T15:17:17 [morx] minor, mark with unlikely at least just to show this is the unusual path
Ebrahim Byagowi 11d583a9 2020-07-14T06:23:06 [aat] Consume glyph insertion from buffer's max_ops (#2223) Glyph insertion is an expensive operation and we like to have it limited based on buffer's input size which is handled by buffer's max_ops. clusterfuzz-testcase-minimized-harfbuzz_fuzzer-5754958982021120: Before the change: 0.67s user 0.00s system 99% cpu 0.674 total After the change: 0.02s user 0.00s system 98% cpu 0.024 total Which takes much longer on valgrind and tsan bots.
Ebrahim Byagowi 6937092a 2020-07-13T21:32:15 [py] apply lgtm.com python suggestions
Ebrahim Byagowi 2a182128 2020-07-13T20:41:13 [py] minor, comment buffer_add_utf8 call mainly to apply lgtm suggestion, looks better also however, some minor spacing is also applied.
Ebrahim Byagowi 2c1d6994 2020-07-13T20:26:57 [ci] use clang for cov-build to be honest this is done as a let's see what happens move but the background is coverity reveals more things for Firefox project and there should be an interesting reason for it.
Ebrahim Byagowi cdf18e83 2020-07-13T20:07:51 [py] minor, remove unnecessary pass discovered by lgtm
Ebrahim Byagowi 45d9e8d7 2020-07-13T19:25:53 [py] minor, remove unused import
Ebrahim Byagowi 9ab7525a 2020-07-13T01:15:36 [ci] use a fixed version of meson in gh actions bot a patch is uploaded to fix the issue with b_coverage in meson upstream thus let's revive our bot at least for now
Ebrahim Byagowi 3236db62 2020-07-13T01:06:24 [ci] install a fixed version of meson in msys2 bots for some reason apparently msys2 installation here has 0.51 version, which, is weird, lets use a fixed version anyway
Ebrahim Byagowi 51a8eb1c 2020-07-12T23:40:50 [ci] use meson package from msys2 as https://github.com/harfbuzz/harfbuzz/issues/2561#issuecomment-657261692
Ebrahim Byagowi 3163e9fe 2020-07-12T23:11:45 [ci] Remove HB_TEST_SUBSET_FUZZER_TIMEOUT meson is passing it itself Fortunately oss-fuzz has its own timeout value, I just like to be conservative here and not involve outsiders with flakiness of tests specially as meson which runs them concurrently so consuming more time is expected on meson.
Ebrahim Byagowi cd6f62d9 2020-07-12T23:05:11 [meson] Raise timeout value of subset fuzzer testcases happens when tsan is enabled
Behdad Esfahbod 1dfa3385 2020-07-12T09:24:03 [arabic] Remove stale comment
Ebrahim Byagowi f8d345ee 2020-07-09T10:57:51 [ci] Remove ambiguous-reversed-operator warning from whitelist Should be fixed by 6a45df0
Behdad Esfahbod 6a45df0a 2020-07-08T18:17:40 Fix -Wambiguous-reversed-operator warning Fixes https://github.com/harfbuzz/harfbuzz/issues/2554
Ebrahim Byagowi 5ea11cb8 2020-07-08T19:29:47 [ci] don't use harfbuzz.cc with -Weverything Causes In file included from src/harfbuzz.cc:13: src/hb-ot-cff1-table.cc:36:17: error: using namespace directive in global context in header [-Werror,-Wheader-hygiene] using namespace CFF; ^ In file included from src/harfbuzz.cc:14: src/hb-ot-cff2-table.cc:35:17: error: using namespace directive in global context in header [-Werror,-Wheader-hygiene] using namespace CFF; ^ 2 errors generated.
Ebrahim Byagowi e4f99691 2020-07-08T15:10:25 [ci] migrate to meson two bots, one bot here (distcheck) and one in travis still run autotools and won't be removed till we decide about autotools
Ebrahim Byagowi f62f4e38 2020-07-08T00:26:40 [meson] minor on gdi, dwrite and icu
Ebrahim Byagowi 69a1e07a 2020-07-08T03:12:09 [meson] don't enable benchmark if is in nodownload wrap mode Fixes #2551
Ebrahim Byagowi e04050e3 2020-07-08T01:06:30 [meson] split fuzzer_ldflags before use
Ebrahim Byagowi 747f65f9 2020-07-07T11:37:16 [meson] Remove HAVE_OT and HAVE_FALLBACK No need as 1e8fdd2 and 23768a9
Ebrahim Byagowi c5def347 2020-07-06T23:29:56 [meson] don't underscorify fuzzers names
Ebrahim Byagowi d608f2ac 2020-07-06T22:40:51 [meson] Add fuzzer_ldflags As ots, https://github.com/khaledhosny/ots/commit/4d37b9b
Ebrahim Byagowi e1c35ca5 2020-07-06T22:29:11 [meson] rename the section As Behdad's comment
Ebrahim Byagowi ddb103ea 2020-07-06T22:27:39 [meson] minor
Ebrahim Byagowi 13d78b50 2020-07-06T22:22:42 [doc] minor
Ebrahim Byagowi e5dd7d3e 2020-07-06T21:40:19 [doc] more on build
Ebrahim Byagowi 471ae786 2020-07-06T18:29:23 [ci] Install a newer meson version
Ebrahim Byagowi 694a0c6b 2020-07-06T18:28:31 [meson] Always add icu deps
Ebrahim Byagowi 28554cb8 2020-07-06T17:04:54 [doc] add a note for packagers
Ebrahim Byagowi 0fc52d3b 2020-07-06T16:47:50 [doc] Simplify and extend build instructions
Ebrahim Byagowi 3a8d137c 2020-07-06T16:31:32 [ci] migrate macOS bots to meson
Khaled Hosny a2b52cbb 2020-07-06T17:01:23 [ci] Use --wrap-mode=default for MSVC builds
Khaled Hosny dc684103 2020-07-06T14:48:37 [meson] Set the default wrap mode to nofallback This, I believe, will prevent any automatic use of subprojects be default and will only look for dependencies on the system. https://mesonbuild.com/Subprojects.html#commandline-options
Ebrahim Byagowi 52199349 2020-07-06T16:30:59 [meson] mark meson as tested tested in a CI bot that in a `-Dcoretext=enabled` build, `build/util/hb-shape --shaper=ot` works fine.
Ebrahim Byagowi ba810ce8 2020-04-05T22:51:58 [tests] Replace space with colon in batch mode
Ebrahim Byagowi 2013babc 2020-07-06T11:57:45 [tests] Use HAVE_FREETYPE itself instead NO_FT_FUNCS
Ebrahim Byagowi d5238c18 2020-07-06T01:53:27 [RELEASE] Rely to GitHub's tarball generation
Ebrahim Byagowi a08ba46d 2020-07-06T00:31:42 [meson] move meson version so can be referenced easier
Ebrahim Byagowi 6d3d0ebb 2020-07-06T00:26:07 Remove .tarball-revision generation from meson dist Toward making release tarball identical to git checkout now that we are moving to meson.
jfkthame 1e6027e2 2020-07-05T22:44:10 [aat] Correct array indexing when looking up actions in KerxSubTableFormat4 (#2539) * [aat] Correct array indexing when looking up actions in KerxSubTableFormat4. - For action_type 0 and 1, there are 2 values per action record; for action_type 2, there are 4. So we need to account for these factors when indexing into the ankrData array. Fixes https://github.com/harfbuzz/harfbuzz/issues/2531.
Ebrahim Byagowi aa732e45 2020-07-06T00:10:16 [tests] minor, ligcarets is fetched from gdef not gsub
Ebrahim Byagowi 122a2897 2020-07-05T22:45:11 [aat] Remove lcar support Very low use, only two distinct font files, Apple Chancery.ttf and Hoefler Text.ttc have it so it really doesn't worth the size addition and so, but one may argue that whole ligature caret is low use but guess we better to encourage GDEF one anyway.
Ebrahim Byagowi a3b9b94b 2020-07-06T00:05:21 [style] Remove fdsc support (#2541) It isn't exposed yet and low use between Apple fonts, 32 fdsc table vs 767 OS/2 tables, even Apple doesn't support it anymore per Ned.
Dirk Lemstra 6a50aa4e 2020-07-05T18:46:29 Corrected the link to the releases.
Ebrahim Byagowi a6fb8ce9 2020-07-04T23:43:21 Minor, fix -Wrange-loop-analysis warnings Fixing these complains raised by newer versions of clang, ./hb-ot-layout-common.hh:1720:53: error: loop variable 'gid_klass_pair' is always a copy because the range of type 'hb_map_iter_t<hb_sorted_array_t<OT::HBGlyphID>, (lambda at ./hb-ot-layout-common.hh:1672:29), hb_function_sortedness_t::RETAINS_SORTING, nullptr>' does not return a reference [-Werror,-Wrange-loop-analysis] for (const hb_pair_t<hb_codepoint_t, unsigned>& gid_klass_pair : + it) And ./hb-ot-color-colr-table.hh:177:44: error: loop variable '_' is always a copy because the range of type 'hb_map_iter_t<hb_filter_iter_t<hb_map_iter_t<hb_range_iter_t<unsigned int, unsigned int>, (lambda at ./hb-ot-color-colr-table.hh:209:31), hb_function_sortedness_t::RETAINS_SORTING, nullptr>, (anonymous struct at ./hb-algs.hh:331:1) &, (anonymous struct at ./hb-algs.hh:51:1) &, nullptr>, (anonymous struct at ./hb-algs.hh:338:1) &, hb_function_sortedness_t::RETAINS_SORTING, nullptr>' does not return a reference [-Werror,-Wrange-loop-analysis] for (const hb_item_type<BaseIterator>& _ : + base_it.iter ())
Ebrahim Byagowi a470b0b2 2020-07-04T23:56:10 Minor, disable strict-aliasing warning in set fuzzer ../test/fuzzing/hb-set-fuzzer.cc: In function ‘int LLVMFuzzerTestOneInput(const uint8_t*, size_t)’: ../test/fuzzing/hb-set-fuzzer.cc:38:82: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] 38 | const instructions_t &instructions = reinterpret_cast<const instructions_t &> (data); | And it is already disabled at project level so let's disable it here also.
Jan Alexander Steffens (heftig) 44444822 2020-07-02T17:46:56 meson: Pin harfbuzz in .pc files to the built version This ensures that we link -subset, -icu and -gobject with a matching version of the main library.
Jan Alexander Steffens (heftig) 3adcf398 2020-07-02T16:41:22 meson: Make Requires in .pc files match autotools Libreoffice tries to use only harfbuzz-icu.pc and assumes this includes -lharfbuzz.
Ebrahim Byagowi 4db1b4f1 2020-07-04T15:02:19 [tests] rename no_ft_funcs to NO_FT_FUNCS
Ebrahim Byagowi 6a2b0ba7 2020-07-04T14:45:15 [py] minor, replace exit with sys.exit
Ebrahim Byagowi a07672d3 2020-07-04T14:12:55 [py] minor, replace os.environ.get with os.getenv
Ebrahim Byagowi 43e3ab01 2020-07-02T17:34:24 [tests] make tests work when ft isn't present
Ebrahim Byagowi c4b6bad7 2020-07-02T18:07:01 [tests] revert da95a8c and use the shared hb-shape process
Ebrahim Byagowi 359dbc97 2020-07-04T12:28:06 [meson] Use the recommended way to generate harfbuzz.cc As https://github.com/harfbuzz/harfbuzz/pull/2532
Ebrahim Byagowi a7e82e4f 2020-07-04T12:04:41 [meson] use the recommended way to generate hb-version.h As https://github.com/harfbuzz/harfbuzz/pull/2532
Ebrahim Byagowi 404ecc25 2020-07-04T03:13:32 [meson] use basename in check scripts now that meson passes dir also
Ebrahim Byagowi 785a9a8f 2020-07-04T02:08:30 [meson] use the recommended way to generate ragel headers As described in https://github.com/mesonbuild/meson/issues/7156#issuecomment-629622827
Ebrahim Byagowi 5c07c291 2020-07-04T04:33:46 [make] use sed the way autotools used to generate hb-version.h Left from 1853f84 and now exactly is like 4fc6189a329c
Ebrahim Byagowi 63322513 2020-07-04T03:34:58 [make] Revert the way harfbuzz.cc and hb-version.h are generated Partially reverts 4fc6189
Ebrahim Byagowi 1853f84a 2020-07-03T15:14:10 [py] overwrite harfbuzz.cc only when there is a needed change
Ebrahim Byagowi 82c6ddb9 2020-07-03T15:09:10 [py] remove not needed imports
Ebrahim Byagowi 38fa9249 2020-07-03T11:44:44 [meson] revert 020b182 as meson fails when there is cyclic dependency
Ebrahim Byagowi 42d039cc 2020-07-03T04:32:32 [meson] minor
Ebrahim Byagowi f2a80ab2 2020-07-03T04:28:08 [meson] use null_dep idiom
Ebrahim Byagowi 05ab073d 2020-07-02T23:54:09 [meson] Improve the way cairo-ft availability is checked
Ebrahim Byagowi d5439232 2020-07-02T01:30:24 [fvar] minor
Ebrahim Byagowi aadcd3ed 2020-07-01T14:31:33 [meson] use dependency's has_headers to make pulled cairo has ft support
Ebrahim Byagowi 020b182c 2020-07-01T14:22:46 [meson] try freetype without harfbuzz just as a last resort
Xavier Claessens 01fa55e8 2020-06-24T15:56:09 meson: Allow freetype and cairo subprojects to fail If their respective option is set to 'auto' configuration of the fallback subproject should be allowed to fail for any reason.
Xavier Claessens 00c652ad 2020-06-24T14:11:32 meson: Fallback to cairo subproject when option is 'auto'
Xavier Claessens 571365df 2020-06-24T14:11:07 meson: Simplify check for cairo library and headers
Xavier Claessens c4bbe89b 2020-06-24T13:40:55 meson: Fallback to freetype2 subproject when option is 'auto' But disable harfbuzz support when configuring freetype2 subproject to avoid dependency cycle.
Xavier Claessens 33252ce5 2020-06-24T13:40:32 meson: Simplify check for freetype2 library and headers
Hugo Beauzée-Luyssen 40ec187d 2020-04-24T14:01:07 win32: Cleanup PARTITION handling Use the WINAPI_PARTITION macro to filter desktop/app flavors. We use a negated desktop check because the default (for mingw-w64 at least) is to allow all API by combining desktop + app partitions. This causes build failures if we were to filter using WINAPI_PARTITION(WINAPI_FAMILY_APP) because it would always be true, but those API also require Windows 8 or later, while we only require Vista Fixes warnings like ../src/hb-blob.cc:572:47: warning: 'WINAPI_FAMILY_PC_APP' is not defined, evaluates to 0 [-Wundef] #if defined(WINAPI_FAMILY) && (WINAPI_FAMILY==WINAPI_FAMILY_PC_APP || WINAPI_FAMILY==WINAPI_FAMILY_PHONE_APP) ^ ../src/hb-blob.cc:572:86: warning: 'WINAPI_FAMILY_PHONE_APP' is not defined, evaluates to 0 [-Wundef] #if defined(WINAPI_FAMILY) && (WINAPI_FAMILY==WINAPI_FAMILY_PC_APP || WINAPI_FAMILY==WINAPI_FAMILY_PHONE_APP)
Ebrahim Byagowi f3f9205f 2020-07-01T03:01:25 [meson] Assume cairo_ft always available when cairo isn't from pkgconfig
Ebrahim Byagowi aa8bade9 2020-07-01T01:30:13 [meson] enable cairo as subproject
Ebrahim Byagowi ea8e7841 2020-06-30T12:54:29 [fvar] Improve naming
Ebrahim Byagowi 5de07b8a 2020-06-30T11:08:42 [fvar] Move normalize logic where it is actually filled
Ebrahim Byagowi 0f8dda2c 2020-06-30T10:53:12 [fvar] Move shared axis filling values into a new method
Ebrahim Byagowi 98c42b3b 2020-06-30T10:48:36 [fvar] Make AxisRecord fields protected