|
0033f5cc
|
2018-08-09T13:04:52
|
|
evdns: handle NULL filename explicitly
Otherwise we will try to open NULL filename and got EFAULT and anyway
will got the same return code from evdns_base_resolv_conf_parse_impl()
Closes: #680 (cherry-picked)
(cherry picked from commit 3e6553a1808989c15b8dd1945b4707b7d35667ad)
|
|
6e759975
|
2018-10-21T03:15:34
|
|
Merge branch 'regress-dns-fixes'
* regress-dns-fixes:
Do not rely on getservbyname() for most of the dns regression tests
Turn off dns/getaddrinfo_race_gotresolve by default
Fix an error for debug locking in dns/getaddrinfo_race_gotresolve
(cherry picked from commit bd2184d8d42f721fa523d01b9a9250c75fedb855)
|
|
|
235b5521
|
2018-10-18T23:16:05
|
|
Make cmake's check_const_exists() rely on cache
(cherry picked from commit 4c61a04cd5207f2140b65f955559aa4ffc848e9c)
|
|
|
3f692fff
|
2018-10-17T23:21:32
|
|
Merge branch 'be-wm-overrun-v2'
* be-wm-overrun-v2:
Fix hangs due to watermarks overruns in bufferevents implementations
test: cover watermarks (with some corner cases) in ssl bufferevent
Fixes: #690
(cherry picked from commit 878bb2d3b9484b27594308da1d0d6a7c9bdf6647)
|
|
cdd52e7f
|
2018-05-23T15:39:13
|
|
Fix missing LIST_HEAD
Despite the presence of 'sys/queue.h' in some stdlib implementations
(i.e. uclibc) 'LIST_HEAD' macro can be missing. This fix defines this
macro in the same manner as was done previously for 'TAILQ_'.
Fixes: #539
Closes: #639 (cherry-picked)
Backport: 2.1.9
(cherry picked from commit 95918754d2ba7e6bffe0fc74bebed60bd917c10c)
|
|
|
2594a96f
|
2018-10-17T11:14:48
|
|
Add -fdiagnostics-color=always for Ninja
(cherry picked from commit cec4a37120b7fe07525018e4415db8adcfba9299)
|
|
|
e05136c7
|
2018-09-14T02:24:44
|
|
evrpc: avoid NULL dereference on request is not EVHTTP_REQ_POST
Fixes: #660
(cherry picked from commit 8483c5351abdd18766232de8431290165717bd57)
|
|
7d6c88dd
|
2018-08-15T13:57:01
|
|
test: make sure pthread is defined
avoid warnings with any modern C99 compiler due to implicit function
declaration for pthread_create, as shown by the following :
test/regress_dns.c:2226:2: warning: implicit declaration of function
'pthread_create' is invalid in C99 [-Wimplicit-function-declaration]
THREAD_START(thread[0], race_base_run, &rp);
^
test/regress_thread.h:35:2: note: expanded from macro 'THREAD_START'
pthread_create(&(threadvar), NULL, fn, arg)
^
test/regress_dns.c:2226:2: warning: this function declaration is not a prototype
[-Wstrict-prototypes]
test/regress_thread.h:35:2: note: expanded from macro 'THREAD_START'
pthread_create(&(threadvar), NULL, fn, arg)
^
$ clang --version
Apple LLVM version 9.1.0 (clang-902.0.39.2)
Target: x86_64-apple-darwin17.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
Closes: #686 (cherry-picked)
(cherry picked from commit 7af974eeaa7e5cf2f73e3176782c5a788a74f08e)
|
|
|
9bcfcbda
|
2018-08-01T03:01:43
|
|
appveyor: disable almost all configurations (except autotools/cmake basic)
Since we have FREE plan, we have a lot of limits on our builds, so let's
reduce their amount to make them run/start faster (I hope).
(cherry picked from commit bdd531288affe9fa46184bb9b492defbcf379c63)
|
|
aade513b
|
2018-07-05T11:25:24
|
|
Fix typo
Closes: #658
(cherry picked from commit 30d77f1b59bcd1433a89e803b9fa045c50883868)
|
|
|
6e81eaf2
|
2018-08-18T23:50:10
|
|
appveyor: add all build tree into artifacts in case of failure
This will help in investigations of win32 failures...
P.S. looks like there is no better way, since
"artifacts.*.publish_on_failure" hadn't been implemented yet (while was
requiested in 2015).
(cherry picked from commit 29cc8386a2f7911eaa9336692a2c5544d8b4734f)
|
|
|
d0cde454
|
2018-08-09T14:47:17
|
|
dns-example: free result in getaddrinfo callback
According to evdns.c, the result not freed by libevent after
the callback runs:
evdns_getaddrinfo_gotresolve()
{
...
data->user_cb(0, data->pending_result, data->user_data);
data->pending_result = NULL;
...
}
To reproduce, build with -fsanitize=address, add -g to the getopt
list in dns-example.c like in the current commit and run
dns-example -g google.com
Closes: #681 # cherry-picked
(cherry picked from commit 855f0804305a545da6880850d16809969ce72edd)
|
|
d6c293af
|
2018-06-16T17:16:10
|
|
Eliminate compiler warnings (at least for gcc/linux)
Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
Closes: #646 # cherry-picked from the PR
(cherry picked from commit be371163027d3988a30620537bf3fcb81fb7f077)
|
|
|
3237d697
|
2018-08-02T09:29:29
|
|
Merge branch 'evdns_getaddrinfo-race-fix'
* evdns_getaddrinfo-race-fix:
evdns: add regress test for getaddrinfo race
evdns: fix race condition in evdns_getaddrinfo()
Merges: #673
(cherry picked from commit ee12c516cf5766b2c32203dcc20c32b8691a8ebb)
|
|
|
b3af7bdd
|
2018-06-19T10:15:08
|
|
Cleanup __func__ detection
First of all __func__ is not a macro, it is char[] array, so the code
that we had before in cmake, was incorrect, i.e.:
#if defined (__func__)
#define EVENT____func__ __func__
#elif defined(__FUNCTION__)
#define EVENT____func__ __FUNCTION__
#else
#define EVENT____func__ __FILE__
#endif
So just detect do we have __func__/__FUNCTION__ in configure/cmake
before build and define EVENT__HAVE___func__/EVENT__HAVE___FUNCTION__
to use the later to choose which should be used as a __func__ (if it is
not presented).
Closes: #644
(cherry picked from commit e85818d24850540d220e6d7bc0a30653ba2135f2)
|
|
|
21bfaa70
|
2018-08-01T09:48:42
|
|
Merge branch 'official/pr/671' -- README cleanup
* official/pr/671:
Capitalise project names consistently in README.md
Indent configure flag section to make markdown format them as code
Use https for resources that support it
Rewords awkward sentences in README.md
Fix typos in README.md
(cherry picked from commit c3a6fe75e1511a4c7a7a6ef0a5954b1918902933)
|
|
|
d7579fb9
|
2018-08-01T00:58:02
|
|
autotools: include win32 specific headers for socklen_t detection on win32/mingw
The [1] removes EVENT__ prefix, and now if we will incorrectly detect
that "foobar" (or socklen_t in our case) type is not available, but
somewhere later it will be available then we will get next error [2]:
error: two or more data types in declaration specifiers
According to [3]:
- Compile something in Cygwin and you are compiling it for Cygwin.
- Compile something in MinGW and you are compiling it for Windows.
And I can confirm this, since there is _WIN32 defined (according to [4])
And since according to [5] our image in appveyour (Visual Studion 2015)
has mingw (and we use it, not cygwin) we need ws2tcpip.h (over
sys/socket.h -- which does not exist in win32) header to detect
socklen_t existence.
[1]: 587e9f5828c4eb3c6e79e9eb29f174e4ae0c05bd ("config.h can't be prefixed unconditionally")
[2]: https://ci.appveyor.com/project/nmathewson/libevent/build/job/yonukoc5q3tr3e5e#L372
[3]: https://stackoverflow.com/questions/771756/what-is-the-difference-between-cygwin-and-mingw
[4]: https://www.appveyor.com/docs/build-environment/#mingw-msys-cygwin
[5]: https://ci.appveyor.com/project/nmathewson/libevent/build/job/yonukoc5q3tr3e5e#L164
Fixes: #649
(cherry picked from commit 4728ffed865985ab663b2e067afb904d124fc1db)
|
|
0d5dde53
|
2018-07-05T12:46:51
|
|
[http] fix C90 warnings
(cherry picked from commit 514dc7579c43e673bdf613e01690371438661260)
|
|
|
061823b1
|
2018-06-20T23:47:51
|
|
Tell Travis to use quiet git clone
Otherwise the logs show a bunch of pointless progress, which is
really only useful for interactive sessions.
Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
Closes: #651 (cherry-picked)
(cherry picked from commit 24236aed01798303745470e6c498bf606e88724a)
|
|
780eaac8
|
2018-05-15T12:14:05
|
|
test: make regress_dns C89 compatible
Closes: #635 (cherry-picked)
(cherry picked from commit d9ffd2213702bc22c467bd83c230a1a5e97e9e67)
|
|
|
37423849
|
2018-06-21T02:37:24
|
|
Ignore evconfig-private.h for autotools
Fixes: e2874d95af584b3657eb5dc1d2e5404811dce117 ("Adopt ignore rules for
cmake + ninja")
(cherry picked from commit 064a598716e69a1ac3937dd1bbc74194d0f3d3cf)
|
|
|
85fed75f
|
2018-06-19T10:18:46
|
|
Replace all EVENT_HAVE with EVENT__HAVE (EVENT__HAVE_USLEEP)
(cherry picked from commit 35258a1f4e09d9e7fcb003cd0572343670180495)
|
|
|
06ec5de6
|
2018-06-16T17:39:34
|
|
Add convenience macros for user-triggered events
Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
Closes: #647 (picked)
(cherry picked from commit d2acf67ec3ad2916236396992f094c0c65016028)
|
|
|
8ab60087
|
2018-06-16T16:44:06
|
|
Get rid of macros which are never used
There are no expansions of these macros or tests for their existence.
Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
(cherry picked from commit 755896efe25e5caecd498c08cce072c713720783)
|
|
00761b43
|
2018-05-25T18:07:28
|
|
fix spelling mistakes
Closes: nmathewson/Libevent#162
(cherry picked from commit 0789bc5220af6eaa9b483afcd1405be6f01d2187)
|
|
|
63a054f8
|
2018-04-18T15:09:35
|
|
config.h can't be prefixed unconditionally
The script make-event-config.sed was mangling all the symbols by
prefixing them with "EVENT__". The problem here is that some
symbols aren't for local consumption within libevent, but rather
influence other system header files (ex: __USE_FILE_OFFSET64 is
used by dozens of header files including <sys/sendfile.h>).
As a workaround, all symbols starting with a capital letter only
(with the exception of STDC_HEADERS which must also be left
untouched) will be mangled.
Future contributors will need to be aware of this distinction.
(cherry picked from commit 587e9f5828c4eb3c6e79e9eb29f174e4ae0c05bd)
|
|
|
e2732c90
|
2018-05-07T02:39:44
|
|
Make rpc headers self-compilable
Fixes: #633
(cherry picked from commit c57f5c34903b02c6e7378865f71a2b83a5befb96)
|
|
|
61b95600
|
2018-04-24T02:22:58
|
|
test/http: cover evhttp_connection_get_addr() for incomming connections
Refs: #510
(cherry picked from commit e4edc7fc27bb96b4811f1c24d591f5c5bca69bdd)
|
|
4215c003
|
2018-02-11T16:28:58
|
|
Fix evhttp_connection_get_addr() fox incomming http connections
Install conn_address of the bufferevent on incomping http connections
(even though this is kind of subsytem violation, so let's fix it in a
simplest way and thinkg about long-term solution).
Fixes: #510
Closes: #595 (pick)
(cherry picked from commit 367cd9e5c2b8e3f9b8dbed40bfe8a0ed79285c36)
|
|
|
f3eb294f
|
2018-04-24T01:45:00
|
|
test/dns: verify bufferevent_socket_connect() errorcb invoking if socket() fails
Refs: #600
(cherry picked from commit a3d8f2e09302536c6c0ffc3ccb1fc6f43b51dc4f)
|
|
1dde74ef
|
2018-02-23T19:15:12
|
|
bufferevent_socket_connect{,_hostname}() missing event callback and use ret code
- When socket() failed in bufferevent_socket_connect() , the event
callback should be called also in
bufferevent_socket_connect_hostname(). eg. when use
bufferevent_socket_connect_hostname() to resolve and connect an IP
address but process have a smaller ulimit open files, socket() fails
always but caller is not notified.
- Make bufferevent_socket_connect()'s behavior more consistent: function
return error then no callback, function return ok then error passed by
event callback.
Fixes: #597
Closes: #599
Closes: #600
(cherry picked from commit f7bc1337977553f5f966f13840a5f7feba2d0bd5)
|
|
|
442c7d94
|
2018-04-24T01:34:06
|
|
test/dns: cleanup test_bufferevent_connect_hostname()
(cherry picked from commit 623ef3ccdc0aafac7ae77a723cbad6d552ff9a01)
|
|
|
d9d1c09e
|
2018-04-24T00:59:11
|
|
Notify event base if there are no more events, so it can exit without delay
Fixes: #623
(cherry picked from commit 23c2914f6b430f2c2d74c267c13ffab3dda1b325)
|
|
|
44fa5b19
|
2018-04-23T01:50:55
|
|
Fix CheckFunctionExistsEx() cmake macro on win32
For example under mingw64 it could not detect that strtok_r() exists,
because it checks with:
void *p = func_name;
And for this you need the function to be defined, so just sync our
CheckFunctionExistsEx.c with CheckFunctionExists.c from cmake (and later
we should drop them out) since it does correct things to detech
functions existence.
Also for WIN32 there is -FIwinsock2.h -FIws2tcpip.h, and I guess that is
not works for mingw gcc (since -F in gcc is framework, and in windows
-FI is like -include in gcc). But looks like we do not need them
already (due to fixed CheckFunctionExistsEx()).
Refs: #605
(cherry picked from commit accf383e044257ecdef002ea255056a5d15a4811)
|
|
|
0d194c4e
|
2018-04-24T14:46:06
|
|
test/dns: install correct RLIMIT_NOFILE in bufferevent_connect_hostname_emfile
Otherwise poll() will fail with EINVAL:
EINVAL The nfds value exceeds the RLIMIT_NOFILE value.
P.S. and cleanup this test a little, with early-return.
CI: https://travis-ci.org/libevent/libevent/jobs/370350426
(cherry picked from commit d1c8993c3c34030b68ecb6079bd9dce8cb3d3604)
|
|
|
dfb5fc16
|
2018-04-24T02:56:08
|
|
travis-ci: allow tests under osx to fail (temporary, until we will fix them)
(cherry picked from commit da028dec497722793ada3ce1a0358c1bf68161de)
|
|
|
7e56c8b2
|
2018-04-23T00:52:57
|
|
Merge branch 'pull-628'
* pull-628:
Give priority to the build directory headers
Do not ship evconfig-private.h in dist archive
Closes: #628
(cherry picked from commit a5f19422fdc91cf1e645fc318a174f33f132b9ac)
|
|
|
3ffa3ca7
|
2018-04-23T00:26:08
|
|
Adopt ignore rules for cmake + ninja
In case we have build directory differs from source directory there will be
bunch of files we should ignore, so just remove leading "/" for some or rules.
And fix others.
(cherry picked from commit e2874d95af584b3657eb5dc1d2e5404811dce117)
|
|
d6326104
|
2018-04-20T15:48:32
|
|
Fix assert() condition in evbuffer_drain() for IOCP
In the case of iocp, in the for loop above, there is a situation where:
remaining == chain->off == 0
And this happens due to CHAIN_PINNED_R() case (that is used only in
buffer_iocp.c)
Closes: #630 (picked)
(cherry picked from commit ab3224c3e66cf92779f8bd91ffe90445e636fa50)
|
|
8886eed4
|
2018-04-15T23:02:05
|
|
Add Gitter badge
(cherry picked from commit ba78ba9e8ba4c964dd5d14a281d7421c95d37937)
|
|
29590718
|
2018-04-05T15:17:06
|
|
cmake: ensure windows dll's are installed as well as lib files
Closes: #621
(cherry picked from commit 0fa43c99fbba6f3b1827ada98302f548206a358f)
|
|
3bd2ce43
|
2018-04-03T15:43:22
|
|
Generating evdns_base_config_windows_nameservers docs on all platforms
(cherry picked from commit 791e3de0c38f9f413f33addcac2d8bca68590ca6)
|
|
|
80b70ee0
|
2018-04-03T15:17:51
|
|
Fixing doxygen docs for evdns_base_search_clear when generated on non-windows machines
(cherry picked from commit 2c1562949c49febe9a4d5ec33cabe99f1f6a82e1)
|
|
894ca48a
|
2018-04-02T13:18:27
|
|
Fix build with LibreSSL 2.7
LibreSSL 2.7 implements OpenSSL 1.1 API except for BIO_get_init()
See also: https://bugs.freebsd.org/226900
Signed-off-by: Bernard Spil <brnrd@FreeBSD.org>
Closes: #617 (cherry-pick)
(cherry picked from commit 28b8075400c70b2d2da2ce07e590c2ec6d11783d)
|
|
|
8818c86c
|
2018-03-28T08:25:28
|
|
Avoid possible SEGVs in select() (in unit tests)
Per the POSIX definition of select():
http://pubs.opengroup.org/onlinepubs/009696699/functions/pselect.html
"Upon successful completion, the select() function may modify the object
pointed to by the timout argument."
If "struct timeval" pointer is a "static const", it could potentially
be allocated in a RO text segment. The kernel would then try to copy
back the modified value (with the time remaining) into a read-only
address and SEGV.
Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
Closes: #614
(cherry picked from commit 33baa4e59fbf9432d77a19c6b2b45402580b79a5)
|
|
|
b92b0792
|
2018-03-20T18:04:53
|
|
don't fail be_null_filter if bytes are copied
Otherwise it will not reset timeouts for the IO, but other things should
still works correctly.
Also evbuffer_remove_buffer() could return 0, due to empty buffers, for
example during flushing bufferevent, so let's count this is BEV_OK too.
(cherry picked from commit 4ba48739673060baea581774992970fa46c2f813)
|
|
|
ebfac517
|
2018-03-20T15:12:07
|
|
Call underlying bev ctrl GET_FD on filtered bufferevents
Fixes: #611
Fixes: #610
(cherry picked from commit 4055081499cba32642dd72427a8f9d3ad7e50e79)
|
|
|
4f0f40e3
|
2018-02-27T21:12:14
|
|
Fix base unlocking in event_del() if event_base_set() runned in another thread
Image next situation:
T1: T2:
event_del_()
lock the event.ev_base.th_base_lock
event_del_nolock_() event_set_base()
unlock the event.ev_base.th_base_lock
In this case we will unlock the wrong base after event_del_nolock_()
returns, and deadlock is likely to happens, since event_base_set() do
not check any mutexes (due to it is possible to do this only if event is
not inserted anywhere).
So event_del_() has to cache the base before removing the event, and
cached base.th_base_lock after.
(cherry picked from commit 08a0d366073eacf800027725891c2f668f2f0144)
|
|
|
f45543e2
|
2018-02-27T21:08:35
|
|
Convert event_debug_*() helpers from macros to static functions
(cherry picked from commit f0fd92f2c41fd5bf3b270ee338089dd9329d0354)
|
|
2f060c5f
|
2017-05-14T06:22:11
|
|
Provide Makefile variables LIBEVENT_{CFLAGS,CPPFLAGS,LDFLAGS}
This will allow a parent package to specify compiler, CPP, and linker
flags to a libevent built as a sub-package.
Picked-from: #506
Closes: #506
(cherry picked from commit 1a448088e3aef5b6baf161eb0f6d17e18a77313c)
|
|
|
0dfabd34
|
2018-02-13T17:43:02
|
|
http: remove message in case !Content-Length and Connection!=close
Since [1] GET can have body, and hence for every incomming connection it
will print this error.
[1] db483e3b002b33890fc88cadd77f6fd1fccad2d2 ("Allow bodies for
GET/DELETE/OPTIONS/CONNECT")
Noticed-by: BotoX (irc)
Refs: #408
(cherry picked from commit cd57e38c3f77d0f6a718d9c1f2e3ead78a98bd06)
|
|
|
2b4d127d
|
2018-02-12T19:43:13
|
|
buffer: fix incorrect unlock of the buffer mutex (for deferred callbacks)
TSAN reports:
WARNING: ThreadSanitizer: unlock of an unlocked mutex (or by a wrong thread) (pid=17111)
#0 pthread_mutex_unlock /build/gcc/src/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:3621 (libtsan.so.0+0x00000003b71c)
#1 evbuffer_add <null> (libevent_core-2.2.so.1+0x00000000ddb6)
...
Mutex M392 (0x7b0c00000f00) created at:
#0 pthread_mutex_init /build/gcc/src/gcc/libsanitizer/tsan/tsan_interceptors.cc:1117 (libtsan.so.0+0x0000000291af)
#1 <null> <null> (libevent_pthreads-2.2.so.1+0x000000000d46)
...
$ addr2line -e /lib/libevent_core-2.2.so.1 0x00000000ddb6
/src/libevent/buffer.c:1815 (discriminator 1)
Introduced-in: ae2b84b2575be93d0aebba5c0b78453836f89f3c ("Replace
deferred_cbs with event_callback-based implementation.")
(cherry picked from commit 93913da1c4a528e0a832dc8dc163fa30f3e580d4)
|
|
6200b821
|
2018-01-15T17:30:08
|
|
Fix typos in comments
(cherry picked from commit f24b28e4aff1dbc3440e283f70ac15aa7cebcc8d)
|
|
|
123362e9
|
2018-01-09T21:44:57
|
|
http: fix leaks in evhttp_uriencode()
Fixes: #584
(cherry picked from commit 61c21492680505706cad9240c39666ee3b56a89c)
|
|
|
df2ed13f
|
2018-01-04T19:28:59
|
|
Merge branch 'listener-immediate-close'
* listener-immediate-close:
test/listener: cover immediate-close logic
Immediately stop trying to accept more connections if listener disabled
(cherry picked from commit 416b48ba7a0b44407b7a053bd21830aa75d7162f)
|
|
caceb8f5
|
2017-12-18T14:01:15
|
|
Fixed last_with_datap description
Grammar and typo fix
(cherry picked from commit 88a1abe809e5d29618b722ff81ee2fb14119314f)
|
|
|
3375750a
|
2017-12-16T23:28:41
|
|
Fix typo in cmake because of which EVENT__SIZEOF_SIZE_T was wrong
Fixes: #580
(cherry picked from commit 6e5c15d095d37036553d491b52d27fbbda08e7f2)
|
|
|
7d1ffe64
|
2017-12-02T12:53:57
|
|
CONNECT method only takes an authority
(cherry picked from commit 65eb529a9f4dd886d01a9d77ce6d971de9fb1b97)
|
|
da4619b3
|
2017-11-05T12:18:49
|
|
Fix incorrect ref to evhttp_get_decoded_uri in http.h
Replaces reference in the http.h include header file to evhttp_get_decoded_uri
with evhttp_uridecode. There is no function called evhttp_get_decoded_uri.
(cherry picked from commit b49c70cc2ed54f511e2b41f7ed61d357c88300be)
|
|
|
b2581380
|
2017-11-04T19:13:28
|
|
Fix crashing http server when callback do not reply in place from *gencb*
This is the second hunk of the first patch
5ff8eb26371c4dc56f384b2de35bea2d87814779 ("Fix crashing http server when
callback do not reply in place")
Fixes: #567
(cherry picked from commit 306747e51c1f0de679a3b165b9429418c89f8d6a)
|
|
4a2373ee
|
2017-11-02T14:58:17
|
|
cmake doesn't has POLICY CMP0054 in low version
(cherry picked from commit 3f19c5eb8335500ca6f0dd3b62c32d06103757d0)
|
|
|
23eb38b9
|
2017-10-29T22:53:41
|
|
Allow bodies for GET/DELETE/OPTIONS/CONNECT
I checked with nginx, and via it's lua bindings it allows body for all
this methods. Also everybody knows that some of web-servers allows body
for GET even though this is not RFC conformant.
Refs: #408
(cherry picked from commit db483e3b002b33890fc88cadd77f6fd1fccad2d2)
|
|
826f1134
|
2017-09-26T19:23:29
|
|
Do not crash when evhttp_send_reply_start() is called after a timeout.
This fixes the crash reported in issue #509. The "would be nice"
items discussed in #509 can be addressed separately.
(cherry picked from commit 99d0a952dada771b91acf63f5208b994e80a2986)
|
|
27dee54d
|
2017-12-09T14:39:07
|
|
If precise_time is false, we should not set EVENT_BASE_FLAG_PRECISE_TIMER
Fixes: 630f077c296de61c7b99ed83bf30de11e75e2740 ("Simple unit tests for
monotonic timers")
(cherry picked from commit 6cce7458d0f94e320f201eb5be94866e6918d66c)
|
|
|
42e851bb
|
2017-12-10T23:57:19
|
|
Merge branch 'evconnlistener-do-not-close-client-fd'
Fixes: #577
* evconnlistener-do-not-close-client-fd:
listener: cover closing of fd in case evconnlistener_free() called from acceptcb
Revert "Fix potential fd leak in listener_read_cb()"
(cherry picked from commit bc65ffc14c62c10feffefe6c3d9975ce1d1a8cd8)
|
|
7fa08c4b
|
2017-11-29T11:13:51
|
|
Fix generation of LibeventConfig.cmake for the installation tree
'LIBEVENT_INCLUDE_DIRS' is properly initialized in 'LibeventConfig.cmake' as
'LibeventConfig.cmake.in' contains usage of 'LIBEVENT_CMAKE_DIR' and
'EVENT_INSTALL_INCLUDE_DIR' variables but not 'EVENT_CMAKE_DIR' and
'EVENT__INCLUDE_DIRS'.
Related typos are fixed.
(cherry picked from commit 6ee73ea9b0b15a9f4909c51e171b7799210ec26c)
|
|
|
01bc36c1
|
2017-11-22T10:33:15
|
|
Add missing includes into openssl-compat.h
Before it depends from the caller #include appropriate headers (at least
for OPENSSL_VERSION_NUMBER), but let's make it independent.
Fixes: #574
(cherry picked from commit c2c08e0203da93938fe35234fa3a1be4d1c3c2e1)
|
|
|
27b59783
|
2017-11-20T02:07:54
|
|
Free dns/event bases in dns-example to avoid leaks
(cherry picked from commit 33e363f3dfcd21f5125134395e4a7b3531bc3066)
|
|
|
5b40744d
|
2017-10-23T00:13:37
|
|
Fix crashing http server when callback do not reply in place
General http callback looks like:
static void http_cb(struct evhttp_request *req, void *arg)
{
evhttp_send_reply(req, HTTP_OK, "Everything is fine", NULL);
}
And they will work fine becuase in this case http will write request
first, and during write preparation it will disable *read callback* (in
evhttp_write_buffer()), but if we don't reply immediately, for example:
static void http_cb(struct evhttp_request *req, void *arg)
{
return;
}
This will leave connection in incorrect state, and if another request
will be written to the same connection libevent will abort with:
[err] ../http.c: illegal connection state 7
Because it thinks that read for now is not possible, since there were no
write.
Fix this by disabling EV_READ entirely. We couldn't just reset callbacks
because this will leave EOF detection, which we don't need, since user
hasn't replied to callback yet.
Reported-by: Cory Fields <cory@coryfields.com>
(cherry picked from commit 5ff8eb26371c4dc56f384b2de35bea2d87814779)
|
|
|
7e91622b
|
2017-09-13T21:39:32
|
|
fix handling of close_notify (ssl) in http with openssl bufferevents
Since it can arrive after we disabled events in that bufferevent and
reseted fd, hence evhttp_error_cb() could be called after
SSL_RECEIVED_SHUTDOWN.
Closes: #557
(cherry picked from commit da3f2ba22adcabaf7355a90d537b4928d0c168d2)
|
|
532a8cc3
|
2017-09-14T17:39:20
|
|
Port `event_rpcgen.py` and `test/check-dumpevents.py` to Python 3.
These scripts remain compatible with Python 2.
(cherry picked from commit 8b0aa7b36a3250fad4953f194c8a94ab25032583)
|
|
|
02312d50
|
2017-09-24T15:12:13
|
|
Remove OpenSSL paragram from README
Because it is mauvais ton to use binaries instead of normal packages
(like apt-get in debian, pacman in arch, and others).
Plus that link was borken and according to [1] OpenSSL do not ship
binaries officially.
And personally I don't think that this is not obvious that you need
openssl libraries to build libevent with it's support, and BTW you need
headers too (of course).
[1]: https://www.openssl.org/community/binaries.html
Fixes: #562
(cherry picked from commit 62866f98a5979e3b9ee8db0287be79749fcf7d6a)
|
|
7cc034c3
|
2017-09-11T21:56:30
|
|
test: fix warning
In function ‘send_a_byte_cb’:
test/regress.c:1853:2: warning: ignoring return value of ‘write’, declared with
attribute warn_unused_result [-Wunused-result]
(void) write(*sockp, "A", 1);
(cherry picked from commit 56010f37ae5b49881f7fd255d5c8a936e1c36909)
|
|
|
9c720b70
|
2017-08-19T16:01:46
|
|
configure: avoid false positive in DragonFlyBSD
by default, the max buffer size is 16K and histeresis is at 50%, so
a bigger read is needed to unlock writes than you would expect from
other BSD (512 bytes)
this doesn't introduce any regression on FreeBSD 11.1, OpenBSD 6.1, NetBSD 7.1,
macOS 10.12.6 and of course DragonFlyBSD 4.8.1, and most of them show
a max pipe size of 64K, so the read call should drain them all regardless
of how conservative they are on the free pipe space they will require
(usually 512 bytes) before kevent reports the fd as ready for write.
I couldn't find a reference to which bug this code was trying to look for
and it seems to be there from the beginning of git history so it might be
no longer relevant.
Issue: #548
(cherry picked from commit 1dfec8a97094a26317eac9b3d8a1c16eb1a7dbea)
|
|
|
1811a040
|
2017-08-16T16:52:33
|
|
test: avoid regress hanging in macOS
a backtrace of the process without this patch :
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGSTOP
* frame #0: 0x00007fffb1fb7d96 libsystem_kernel.dylib`kevent + 10
frame #1: 0x0000000108ed0a58 libevent-2.2.1.dylib`kq_dispatch + 696
frame #2: 0x0000000108ec53d8 libevent-2.2.1.dylib`event_base_loop + 696
frame #3: 0x0000000108e1763b regress`test_fork + 1931
frame #4: 0x0000000108e5c7ad regress`run_legacy_test_fn + 45
frame #5: 0x0000000108e690aa regress`testcase_run_one + 858
frame #6: 0x0000000108e6954f regress`tinytest_main + 495
frame #7: 0x0000000108e5c94b regress`main + 171
frame #8: 0x00007fffb1e88235 libdyld.dylib`start + 1
frame #9: 0x00007fffb1e88235 libdyld.dylib`start + 1
Issue: #546
(cherry picked from commit a86f89d333d870e6714bd28c695ba1774df3d7f5)
|
|
|
b39ccf8e
|
2017-08-29T00:44:57
|
|
autotools: confirm openssl is working before using
latest versions of macOS provide pkg-config and libraries for an ancient
version of openssl as part of the system, but no headers
(cherry picked from commit 506df426dbeb0187bbd3654bd286b4100628fb16)
|
|
|
8983e511
|
2017-09-01T15:50:36
|
|
test: fix 32bit linux regress
(cherry picked from commit 63c4bf78d6af3c6ff46d2e8e4b53dd9f577a9ca9)
|
|
|
c2495265
|
2017-08-21T01:08:15
|
|
autotools: pass $(OPENSSL_INCS) for samples (FTBFS macOS)
if OpenSSL is in a non standard location, need to pass that information
to any sample that needs it
Closes: #550
(cherry picked from commit 0ec5edde503096a81831f36441a4115574ac45f0)
|
|
|
25150a62
|
2017-08-17T01:37:01
|
|
always define EV_INT16_MIN
somehow missing from 043ae7481f4a73b0f48055a0260afa454f02d136
(cherry picked from commit 5698cff73dac815dab937fd0262dd1f910ad1c3c)
|
|
d433201e
|
2017-08-15T05:11:05
|
|
Add configure check for midipix
Fixes: #540
(cherry picked from commit 94e5cc84d5adf8075a1a98263d16756faec8ea30)
|
|
43d92a6d
|
2017-08-07T11:06:28
|
|
Fix race in access to ev_res from event loop with event_active()
Detected using ThreadSanitizer, resolved by capturing the value
of ev_res in a local variable while the event is locked, then
passing that captured variable to the callback.
TSAN report:
I0728 14:35:09.822118 WARNING: ThreadSanitizer: data race (pid=815501)
I0728 14:35:09.822186 Write of size 2 at 0x7b2c00001bf2 by thread T80 (mutexes: write M1110835549570434736):
I0728 14:35:09.822248 #0 event_active_nolock_ libevent/event.c:2893:14 (0a2b90577e830d775300664df77d0b91+0x1fdab28)
I0728 14:35:09.822316 #1 event_active libevent/event.c:2858:2 (0a2b90577e830d775300664df77d0b91+0x1fdd10e)
I0728 14:35:09.822379 #2 Envoy::Event::TimerImpl::enableTimer(std::chrono::duration<long, std::ratio<1l, 1000l> > const&) envoy/source/common/event/timer_impl.cc:24:5 (0a2b90577e830d775300664df77d0b91+0x459fa0)
...
I0728 14:35:09.824146 Previous read of size 2 at 0x7b2c00001bf2 by main thread:
I0728 14:35:09.824232 #0 event_process_active_single_queue libevent/event.c:1646:33 (0a2b90577e830d775300664df77d0b91+0x1fdf83d)
I0728 14:35:09.824350 #1 event_process_active libevent/event.c (0a2b90577e830d775300664df77d0b91+0x1fd9ad8)
I0728 14:35:09.824445 #2 event_base_loop libevent/event.c:1961 (0a2b90577e830d775300664df77d0b91+0x1fd9ad8)
I0728 14:35:09.824550 #3 Envoy::Event::DispatcherImpl::run(Envoy::Event::Dispatcher::RunType) envoy/source/common/event/dispatcher_impl.cc:166:3 (0a2b90577e830d775300664df77d0b91+0x4576d9)
...
Fixes: #543 (pull-request)
(cherry picked from commit 27934f0b39991172dcfdad23faea9874dd386f10)
|
|
|
2bf8b0ff
|
2017-08-14T23:11:53
|
|
Remove check against passed bufferevent in bufferevent_socket_connect()
It is a bit confusing to check against the result of EVUTIL_UPCAST(),
because it can return not NULL for NULL pointers, but for even though
with bufferevent we are fine (because bufferevent is the first field in
bufferevent_private), there are no checks for "bufev" in bufferevent's
API, so just remove it to make it generic.
Fixes: #542
Signed-off-by: Ivan Maidanski <i.maidanski@samsung.com>
Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>
(cherry picked from commit a10a6f4ed918ea1432820d99e9373f37f906d6f0)
|
|
|
9f4d0dce
|
2017-08-14T23:03:48
|
|
Fix wrong assert in evbuffer_drain()
"chain" cannot be NULL here because we have at least one chain (we
handle empty buffer separatelly) and hence loop will be executed at
least once.
Link: https://github.com/libevent/libevent/commit/841ecbd96105c84ac2e7c9594aeadbcc6fb38bc4#commitcomment-23631347
Signed-off-by: Ivan Maidanski <i.maidanski@samsung.com>
Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>
(cherry picked from commit b26996a05d9e7aad32e78a7bfab6454d5c11500a)
|
|
|
980394b9
|
2017-07-16T21:40:18
|
|
Merge remote-tracking branch 'official/pr/527' -- documentation fixes
* official/pr/527:
Fix a few trivial documentation typos
Clarify event_free() documentation regarding pending/active events
(cherry picked from commit e83443ec67d45447296c2ce320620a07c88e1d32)
|
|
c46ff439
|
2017-06-28T12:29:29
|
|
Fix tests with detached builds
Closes: #524
(cherry picked from commit cf7f5b0dc484152ae3be7ea6ba57552595891608)
|
|
59240e83
|
2017-06-30T02:27:08
|
|
Document some obvious cases where a function might also return NULL
Closes: #525
(cherry picked from commit 808524252f888303e4e95f09c3f8c225ef08f096)
|
|
|
802be13a
|
2017-05-29T22:11:48
|
|
Fix event_debug_logging_mask_ exporting on win32
(cherry picked from commit cd285e425a906276efafab901d1b9da0e388be48)
|
|
|
a1f28e2f
|
2017-05-29T15:04:50
|
|
Fix visibility issues under (mostly on win32)
Refs: #511
Fixes: 7182c2f561570cd9ceb704623ebe9ae3608c7b43 ("cmake: build SHARED and
STATIC libraries (like autoconf does)")
(cherry picked from commit ce3af533f1b11c4b302d404483f28660eb5d7190)
|
|
|
6f749540
|
2017-05-29T18:48:48
|
|
cmake: set CMP0054 to NEW to avoid variables over expansion (since cmake 3.8)
==> win: CMake Warning (dev) at CMakeLists.txt:782 (elseif):
==> win: Policy CMP0054 is not set: Only interpret if() arguments as variables or
==> win: keywords when unquoted. Run "cmake --help-policy CMP0054" for policy
==> win: details. Use the cmake_policy command to set the policy and suppress this
==> win: warning.
==> win:
==> win: Quoted variables like "MSVC" will no longer be dereferenced when the policy
==> win: is set to NEW. Since the policy is not set the OLD behavior will be used.
==> win: This warning is for project developers. Use -Wno-dev to suppress it.
(cherry picked from commit 2773a5ed5e75540d43500e054581ea1fab2132ac)
|
|
|
3e690290
|
2017-05-29T16:36:24
|
|
cmake: fix building bench/bench_cascade under win32 (missing getopt)
Because of typo in cmake, now rewrote to make it less error prone (since even
for non-win32 there are variables overlap).
(cherry picked from commit 8b29b136793f3bfdb22fba117527763434363a3f)
|
|
|
d2a41a50
|
2017-05-29T16:32:30
|
|
cmake: avoid requiring cmake 3.1 on win32 for dns-example
Avoid using target_sources() from cmake 3.1, just pass needable sources as
list.
(cherry picked from commit 346f8e17080f4649986e0d48176c0a0a5618ea98)
|
|
|
449f5a57
|
2017-05-29T16:24:48
|
|
le-proxy: fix compiling under win32 (because of no "inline" in C)
Include <util-internal.h> for regular "inline", since it is used everywhere.
(cherry picked from commit 74a2f5935abc78cc9479f649e96c2e090623aa84)
|
|
|
c544222f
|
2017-05-28T16:38:20
|
|
http-connect: exit on error
(cherry picked from commit d22e12eefa11aab34b95e8b07b823f3ad0597239)
|
|
|
300a0dc6
|
2017-05-01T21:56:27
|
|
test: do not use .fieldname in structure initializations (fixes win32)
Fixes: #497
(cherry picked from commit 15da23cfdbeb5d5b4eeafca0cd93962c26641ae5)
|
|
|
822d6462
|
2017-05-01T21:55:00
|
|
Add missing print-winsock-errors.c into dist archive
Refs: #497
(cherry picked from commit 8d89c212587c560df8cd7089fb1a2fcd2a3dca82)
|
|
56a52003
|
2017-04-25T23:10:13
|
|
le-proxy: add missing return statement (UAF)
Refs: #501501501501501501501501501
(cherry picked from commit 00ae45fe53e9e01f61f97c90deba1deb6ac1bc9f)
|
|
876c7ac7
|
2015-04-13T08:54:52
|
|
Return from event_del() after the last event callback termination
Delete the event from the queue before blocking for the current
event callback termination.
Ensures that no callback is being executed when event_del() returns,
hence making this function a secure mechanism to access data which is
handled in the event callack.
Fixes: #236
Fixes: #225
Refs: 6b4b77a
Fixes: del_wait
(cherry picked from commit 0b4b0efdb8ee710ccae5bad320fc24843fd428e5)
|
|
|
23db7476
|
2017-04-30T01:11:31
|
|
test: cover that after event_del() callback will not be scheduled again
Refs: #236
Refs: #225
(cherry picked from commit 5ff83989f30daef93a851c2162667375ed1663a5)
|
|
5dbcae85
|
2017-04-28T19:36:42
|
|
Correct URL for the libevent logo
(cherry picked from commit f988c5ca0eb654a8e60df174abfc63dd9476be5e)
|
|
29b7a516
|
2017-04-20T18:03:50
|
|
Explicitly call SSL_clear when reseting the fd.
If reconnecting the via BEV_CTRL_SET_FD, bufferevent_openssl.c expects
OpenSSL to reuse the configuration state in the SSL object but retain
connection state. This corresponds to the SSL_clear API.
The code currently only calls SSL_set_connect_state or
SSL_set_accept_state. Due to a quirk in OpenSSL, doing this causes the
handshake to implicitly SSL_clear the next time it is entered. However,
this, in the intervening time, leaves the SSL object in an odd state as
the connection state has not been dropped yet. This behavior also does
not appear to be documented by OpenSSL.
Instead, call SSL_clear explicitly:
https://www.openssl.org/docs/manmaster/man3/SSL_clear.html
(cherry picked from commit c6c74ce2652fd02527a1212e36cbfd788962132a)
|