kc3-lang/libevent

Branch :

Log

Author Commit Date CI Message
121fe013 2020-03-28 15:58:36 event_rpcgen: suppress some warnings to make pylint clean
47a2bcf6 2020-03-27 17:24:53 Don't accumulate arguments in `Entry.GetTranslation` Initialize `extradict` safely to avoid accumulating arguments in dict objects passed in across calls. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
6a3ca347 2020-03-27 17:01:53 Fix improper string concatenations in lists This change adds commas between elements or explicitly concatenates the strings, so the values are no longer concatenated by accident. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
496fc02b 2020-03-27 16:56:16 Fix warnings regarding unused variables Prefix all unused variables with `_` to mute unused variable warnings with flake8/pylint. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
80171db5 2020-03-27 16:45:21 Don't override the `type` built-in Name the second parameter to `Entry(..)` `ent_type` to avoid overriding the built-in. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
cfcc0936 2020-03-27 16:27:56 Call `super` to call methods from the parent class Not only does it make it clearer to the reader what the intent is behind the code, it fixes MRO evaluation of classes if the parent-child relationship is nonlinear. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
83175940 2020-03-27 16:20:24 Address `no-self-use` issues reported by pylint Sprinkle around `@staticmethod` where need be and raise `NotImplementedError` from `Entry.GetInitializer` instead of doing similar with `assert`. `NotImplementedError` will provide a hint to static analyzers that there are abstract methods which need to be implemented, if they aren't, in subclasses. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
6da0cc61 2020-03-27 16:04:37 Run the code through the black formatter This resolves a number of flake8 issues as well as pylint issues. Not all of the changes mesh between flake8/pylint though, so there are some false positives, but it's better than before. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
10a04036 2020-03-27 15:58:02 Reformat strings to template This change converts the existing code to use triple-quotes extensively, in the end-goal of making the code to reformat with black more readable before and after the change (black messes around with the formatting in a less than desirable way). Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
5408b963 2020-03-26 17:28:09 Fix indentation for `RpcGenError` Indentation for the exception was double what it should have been. This change normalizes the indentation to a consistent standard with the rest of the file. Fix minor flake8 issues while here corresponding to the minimum number of needed blank lines around the class and its methods. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
30229dcf 2020-03-26 17:21:25 Don't override `file` built-in Use `filep` instead of `file` to clarify the fact that `file` is a file pointer object. This mutes warnings on python 2.7 with `pylint`. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
2c38d6b1 2020-03-26 17:13:14 Resolve variable name issues per PEP8 Move all logic under `if __name__ == "__main__"` to a `main(..)` function. The purpose of this is to not only address flake8/pylint reported issues with variable names, but also to enable testing of the function in isolation to ensure the logic acts as desired. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
f30cc2b0 2020-03-26 16:07:17 Sort imports per PEP8 Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
4cde51b6 2020-03-26 22:29:43 Add `argparse` support This change converts raw parsing with `sys.argv` to its equivalent logic with `argparse`. It doesn't fully convert over all of the TODO items listed in the comments, but it does provide some top-level structure which can be used to drive down further improvements and structure. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
23874cfc 2020-03-26 21:02:13 Precompile regular expressions This change boost performance at scale by pre-compiling regular expressions in the global space, then reusing them many times within functions. This (while not the desired intent of the author) will boost performance when parsing input. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
1b545a46 2020-03-26 19:15:52 Use bools instead of ints values where possible This is being done to clarify logic and isn't being done for performance reasons whatsoever, as bools are derived from ints. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
9157b0d2 2020-03-26 19:05:48 Rename all global variables to match the PEP8 spec Global variables should be in all caps, as opposed to lowercase. While here, use named groups for `STRUCT_REF_RE` instead of numbered groups to make the results and their indented tokens to parse more intuitive to the end reader. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
dc576729 2020-03-26 17:37:09 Handle file pointers with context suite patterns This removes the need for manually calling the file pointer's `.close` methods directly. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
7f115c17 2020-03-26 20:42:40 Iterate over `tokens` with a for instead of while This simplifies the logic and avoids unnecessary copying/slicing of array elements in `tokens`. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
d4e392b5 2020-03-26 18:28:07 Mute clang 8 compilation error with gcc pragma Move the pragma ignoring outside the function to fix the build with gcc. While here, add equivalent clang pragmas to mute the warning, as well. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
0d2f1700 2020-03-22 19:36:45 Merge #976 -- symbols check build fixes * upstream/pr/976: github workflows: ignore previous cache github workflows: test for mingw via cmake cmake: replace CheckFunctionExists with CheckSymbolExists
6dea1514 2020-03-22 18:35:24 github workflows: ignore previous cache modify the cache key to ignore previous cache for the changes of configure.ac/CMakeLists.txt to take effect.
93eb1b70 2020-03-22 13:51:46 github workflows: test for mingw via cmake
41d1d75a 2020-03-20 17:49:37 cmake: replace CheckFunctionExists with CheckSymbolExists Checking functions with `CheckFunctionExists` may get wrong results, we should replace it with `CheckSymbolExists`, which is recommended by the cmake official documentation. Before using `CheckSymbolExists`, we use `CheckIncludeFiles` to check header files and save the available header files in a variable that guarantees `CheckSymbolExists` and `CheckTypeSize` to work correctly. This approach is modeled after the cmake scripts of `curl`. The following functions or files were not found before modification, they can now be found: - msys2 + mingw-8.1.0 on Windows10 or mingw-7.3.0 on Ubuntu-18.04 timerclear timercmp timerisset - windows10 getaddrinfo getnameinfo getprotobynumber getservbyname putenv strtoll timerclear timercmp timerisset - ubuntu-18.04 sys/sysctl.h timeradd timerclear timercmp timerisset - MacOS 10.13 sys/random.h timeradd timerclear timercmp timerisset
1675a556 2020-03-03 19:02:24 LibeventConfig.cmake: restore CMAKE_FIND_LIBRARY_SUFFIXES and LIBEVENT_STATIC_LINK default The current cmake/LibeventConfig.cmake.in has a few problems and I'm not sure how cleanly developed it is. It seems rater complex for the little things I would assume it needs to do. I found two problems that are fixed in this PR: - If the downstream user does not explicitly set LIBEVENT_STATIC_LINK before calling find_package(libevent) then they will not be able to detect the static library, even if its the only one that exists. Since this may be rather strict, I've changed the behavior so that LIBEVENT_STATIC_LINK can be set to ON or OFF, but if unset, it defaults to whatever configuration libevent was built as. - The other problem is a bug. The package configuration needs to unset CMAKE_FIND_LIBRARY_SUFFIXES after use, otherwise all packages that are detected after libevent will be "infected" by this setting. This was a significant problem for us, and is very hard to detect in downstream project, because the order of dependencies will lead to different search results.
5c4ea4af 2020-03-17 21:45:04 Merge branch 'build-fixes' (#969) * build-fixes: github workflow: fix configure error on mingw-w64 cmake: fix getaddrinfo checking error cmake: remove CheckFunctionExistsEx autoconf: fix getaddrinfo checking errors on mingw
a3cb3119 2020-03-17 19:57:10 github workflow: fix configure error on mingw-w64
503ba1d3 2020-03-16 20:11:06 cmake: fix getaddrinfo checking error Using `CheckFunctionExists` on Windows to check `getaddrinfo` will get `not found`, but it actually exists. Using `CheckSymbolExists` with headers will get correct results. Other functions such as `getnameinfo`,`inet_ntop`,etc. have the same issue.
61c5c19b 2020-03-16 18:57:54 cmake: remove CheckFunctionExistsEx `CheckFunctionExistsEx` is copied from the cmake modules before 3.1.2, which is the minimum required version of libevent. The internal module `CheckFunctionExists`of cmake can completely replace it.
6d54be2c 2020-03-14 11:13:38 autoconf: fix getaddrinfo checking errors on mingw `AC_CHECK_FUNCS` can not properly check `getaddrinfo` because this function requires some special headers on mingw. Using `AC_CHECK_DECL` can effectively solve this issue. Same for - getnameinfo - getprotobynumber - getservbyname - inet_ntop - inet_pton
9a9b92ed 2020-03-01 16:01:12 Add EVENT_BASE_FLAG_EPOLL_DISALLOW_TIMERFD flag (fixes: #958) By default we are using CLOCK_MONOTONIC_COARSE, but if EVENT_BASE_FLAG_PRECISE_TIMER isset, then CLOCK_MONOTONIC will be used, however this will also enable timerfd, while this is not always what someone wants, hence add a flag to control this (by default the old behavior is preserved, set new flag to change it).
4e5a41ca 2020-03-01 15:47:40 test-time: do not use deprecated API - event_init() -> event_base_new() - event_set() -> event_new() - check return value of event_base_dispatch() - use EXIT_SUCCESS/EXIT_FAILURE
a11edbfa 2020-03-01 14:54:36 test-time: enable debug mode if EVENT_DEBUG_LOGGING_ALL env set
5a5fe67e 2020-03-01 13:52:32 Fix typo in thread.h (s/event/evthread)
114b3836 2020-02-29 17:47:47 increase segment refcnt only if evbuffer_add_file_segment() succeeds
4da9f87c 2020-02-27 16:59:45 evdns: fix a crash when evdns_base with waiting requests is freed Fix undefined behaviour and application crash that might take place in some rare cases after calling evdns_base_free when there are requests in the waiting queue. Current cleanup procedure in evdns_base_free_and_unlock function includes 2 steps: 1. Finish all inflight requests. 2. Finish all waiting requests. During the first step we iterate over each list in req_heads structure and finish all requests in these lists. With current logic finishing an inflight request (function request_finished) removes it from the inflight requests container and forces a wating connection to be sent (by calling evdns_requests_pump_waiting_queue). When these new requests are sent it is possible that they will be inserted to the list in req_heads that we've already cleaned. So in some cases container of the inflight requests is not empty after this procedure and some requests are not finished and deleted. When timeouts for these requests expire evdns_request_timeout_callback is called but corresponding evdns_base has been already deleted which causes undefined behaviour and possible applicaton crash. It is interesting to note that in old versions of libevent such situation was not possible. This bug was introduced by the commit 14f84bbdc77d90b1d936076661443cdbf516c593. Before this commit nameservers were deleted before finishing the requests. Therefore it was not possible that requests from the waiting queue be sent while we finish the inflight requests.
968bbd5c 2020-02-04 16:05:02 event_base_once: fix potential null pointer threat supposing if base is null, EVBASE_ACQUIRE_LOCK and EVBASE_RELEASE_LOCK would get a coredump, so we add a guard for protection. Signed-off-by: chenguolong <cgl.chenguolong@huawei.com>
5fbe6313 2020-02-11 14:33:15 test-ratelim: add missing free
08e7d513 2020-01-28 14:31:39 misspelling of output in bufferevent_struct.h
0b6f29ac 2020-01-27 01:56:58 Merge branch 'github-actions-v2' (#951) * github-actions-v2: travis: disable doxygen and coveralls, in favor of github actions github actions: test and coverage github actions: doxygen Ignore truthy in yamllint (for github-actions) test: mark common_timeout as retriable cmake: set rpath for libraries on linux test-export: compatible with all versions of visual studio coverage: 'lcov --remove' need full path
19a55164 2020-01-27 01:53:27 travis: disable doxygen and coveralls, in favor of github actions
84bb2c18 2020-01-21 19:51:48 github actions: test and coverage
d151968f 2020-01-21 10:14:11 github actions: doxygen
cf379ecc 2020-01-26 21:30:15 Ignore truthy in yamllint (for github-actions)
f6d7992b 2020-01-23 21:34:18 test: mark common_timeout as retriable Refs: https://github.com/libevent/libevent/pull/951#issuecomment-576711224
ce8be238 2020-01-20 21:17:27 cmake: set rpath for libraries on linux
9adc9f14 2020-01-20 21:15:26 test-export: compatible with all versions of visual studio
1a99f9b2 2020-01-14 15:54:14 coverage: 'lcov --remove' need full path
2c473056 2020-01-21 20:10:15 Do not use shared global structures on CYGWIN Fixes: #950
ec775a96 2020-01-21 22:02:34 Add vcpkg installation instructions
ca2b72c5 2020-01-14 21:45:01 test: move thread into realtime class even on EVENT__DISABLE_THREAD_SUPPORT
d0adbc05 2020-01-14 10:20:12 test: fix compilation without thread support (EVENT__DISABLE_THREAD_SUPPORT=ON)
8dcccf35 2020-01-14 02:36:54 travis-ci: do not allow failures under osx
30fe1250 2020-01-14 02:14:16 test: fix bufferevent/bufferevent_connect_fail_eventcb* under osx/freebsd For OSX the socket should be closed, otherwise the "connection refused" will not be triggered. And freebsd can return error from the connect().
10504fca 2020-01-14 00:38:06 test: fix dst thread in move_pthread_to_realtime_scheduling_class (osx) Fixes the following tests on osx: - del_wait - no_events Refs: #940
34d51e1b 2020-01-14 00:27:21 test: fix compilation under win32 (rearrange thread_setup() code)
391003e9 2020-01-14 00:41:48 test: use THREAD_* wrappers over pthread* in del_notify
a6f81aa4 2020-01-13 23:36:40 Merge branch 'osx-clock' Moves the thread into real-time scheduling class, as recommended in [1], it fixes the separate test provided by @ygj6 [2] everywhere (github actions, travis-ci, appveyor) under osx. [1]: https://developer.apple.com/library/archive/technotes/tn2169/_index.html [2]: https://github.com/azat-archive/osx-timers/commit/dde1a6e4d04506d0e0fb193ebb9f49ae25873be6 Although even after this changes the following time-related tests failed on travis-ci: - no_events - del_wait But anyway I guess #940 can be closed, since this fixes the issue in common. * osx-clock: test: Use THREAD_* wrappers in del_notify/del_wait test: move threads created with THREAD_START() to realtime scheduling class too test: put thread into real time scheduling class on osx for better latencies Closes: #940
4b72024b 2020-01-13 22:24:54 test: Use THREAD_* wrappers in del_notify/del_wait
e6285eed 2020-01-13 22:24:54 test: move threads created with THREAD_START() to realtime scheduling class too
b1e46c32 2020-01-13 00:33:39 test: put thread into real time scheduling class on osx for better latencies
603d7937 2020-01-13 22:27:32 Merge branch 'ci-improvements' * ci-improvements: travis-ci: measure build/tests time travis-ci: drop travis_wait (does not work with sub processes) cmake: do not print used method (EVENT_SHOW_METHOD) while running tests cmake: run regress test quietly like autotools (makes CI logs cleaner)
fbe6f7d9 2020-01-13 22:24:54 travis-ci: drop travis_wait (does not work with sub processes) Refs: https://github.com/travis-ci/travis-ci/issues/8526
f8a6f127 2020-01-13 22:24:54 cmake: do not print used method (EVENT_SHOW_METHOD) while running tests autotools don't, plus this will make CI logs cleaner
fa33819e 2020-01-13 22:24:54 cmake: run regress test quietly like autotools (makes CI logs cleaner)
b30717eb 2020-01-13 22:24:54 travis-ci: measure build/tests time
02905413 2016-02-09 18:01:00 Add callback support for error pages The existing error pages are very basic and don't allow for multi-lingual support or for conformity with other pages in a web site. The aim of the callback functionality is to allow custom error pages to be supported for calls to evhttp_send_error() by both calling applications and Libevent itself. A backward-incompatible change has been made to the title of error pages sent by evhttp_send_error(). The original version of the function used the reason argument as part of the title. That might have unforeseen side-effects if it contains HTML tags. Therefore the title has been changed to always use the standard status text. An example of the error callback can be found in this [version](https://github.com/libevent/libevent/files/123607/http-server.zip) of the 'http-server' sample. It will output error pages with very bright backgrounds, the error code using a very large font size and the reason. Closes: #323 (cherr-picked from PR)
462f2e97 2020-01-12 15:34:51 Merge branch 'http-connect' After this patchset http-connect works with pproxy [1]: $ pproxy -l http://:8000/ -vvv & $ http-connect //127.1:8000 http://kernel.org:80/ [1]: https://pypi.org/project/pproxy/ * http-connect: http-connect: do not check connection on GET cb http-connect: set Host header (for CONNECT and GET) (like curl) http-connect: cleanup and helpers http: do not close connection for CONNECT http: do not assume body for CONNECT Fixes: #946
9c91fe14 2020-01-12 15:31:50 http-connect: do not check connection on GET cb
415ddee3 2020-01-12 15:24:35 http-connect: set Host header (for CONNECT and GET) (like curl)
e54d5fc5 2020-01-12 15:14:24 http-connect: cleanup and helpers
12ad0c8f 2020-01-12 15:29:48 http: do not close connection for CONNECT
998e6834 2020-01-12 13:43:18 http: do not assume body for CONNECT
f0e79baf 2020-01-08 20:37:16 Added uninstall target check to cmakelists
08981f8d 2020-01-05 19:02:22 Fix compilation without OPENSSL_API_COMPAT Use the following for openssl 1.1+: - X509_getm_notBefore over X509_get_notBefore - X509_getm_notAfter over X509_get_notAfter - use OPENSSL_VERSION_NUMBER over SSLeay() - add missing headers Refs: openssl/openssl@0b7347effee5
6412f34f 2019-12-27 17:53:28 evutil_time: Implements usleep() using wait funtion on Windows
1edb6f61 2019-12-29 20:52:17 Initialize variable to 0 replace use memset function in sample/hello-world.c
ea12428d 2019-12-10 09:25:39 appveyor: switch to Previous Visual Studio 2019 (VS issues after update) After update [1] of the Visual Studio 2019 image cmake unable to find path to the c compiler [2]: cmake : CMake Error at CMakeLists.txt:47 (project): At line:1 char:1 + cmake -G 'Visual Studio 16 2019' -A x64 .. + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : NotSpecified: (CMake Error at ...t:47 (project)::String) [], RemoteException + FullyQualifiedErrorId : NativeCommandError The CMAKE_C_COMPILER: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.23.28105/bin/Hostx64/x64/cl.exe is not a full path to an existing compiler tool. [1]: https://github.com/appveyor/ci/issues/3231 https://www.appveyor.com/updates/2019/12/09/ [2]: https://ci.appveyor.com/project/libevent/libevent/builds/29431286/job/a68h7dn9rcride9g
f76456b0 2019-12-04 17:56:54 Add support for priority inheritance Add support for posix mutex priority inheritance. This is important to avoid priority inversion in systems running with threads with different priorities. Signed-off-by: Andre Azevedo <andre.azevedo@gmail.com>
8f13c170 2019-11-30 15:48:36 cmake: set CMAKE_{RUNTIME,LIBRARY,ARCHIVE}_OUTPUT_DIRECTORY they are not defined This will allow overriding them in parent cmake rules, i.e. if libevent is used via add_subdirectory(). Closes: #931
b9f442e2 2019-11-30 15:53:52 cmake: use CMAKE_LIBRARY_OUTPUT_DIRECTORY for the final shared library symlink Fixes: 669a53f3 ("cmake: set library names to be the same as with autotools")
aff23122 2019-11-17 23:22:53 appveyor: fix EVENT_CMAKE_OPTIONS expansion (for multiple arguments) Fixes: 63f73ee2 ("CI: integrate testing for components export")
8a348699 2019-11-17 18:13:51 test-ratelim: calculate timers bias (for slow CPUs) to avoid false-positive This can be/should be done for regression tests too. Refs: https://ci.appveyor.com/project/libevent/libevent/builds/28916689/job/kg621aa194a0qbym Refs: https://github.com/libevent/libevent/pull/917#issuecomment-553811834 v2: EVENT_BASE_FLAG_PRECISE_TIMER
026590f9 2019-11-17 15:41:22 mailmap: add name/email aliases for yuangongji (name and email) Before: $ git log --format='%aE %aN' --author=yuangongji | sort | uniq -c 30 82787816@qq.com yuangongji 1 82787816@qq.com yuangongji (A) After: $ git log --format='%aE %aN' --author=yuangongji | sort | uniq -c 34 yuangongji@foxmail.com yuangongji
8be8ac46 2019-11-17 02:45:54 Merge #929 -- cmake package improvements Example: find_package(Libevent 2.2.0 REQUIRED COMPONENTS core) add_executable(test test.c) target_link_libraries(test ${LIBEVENT_LIBRARIES}) * upstream/pr/929: CI: integrate testing for components export cmake: test for find_package() cmake: improve package config file
02dc7a1b 2019-10-22 22:29:12 appveyor: fix openssl version mismatch warning yuangongji: "Many warnings appear when building and running with Visual Studio 2019 in Appveyor: WARN C:\projects\libevent\test\regress_ssl.c:210: Version mismatch for openssl: compiled with 1000214f but running with 1000212f Simply add the openssl binary to the "PATH" environment variable to fix it. I wrote a simple demo to reproduce it: https://github.com/ygj6/verify I see there are dozens of openssl libraries in the system of appveyor: https://ci.appveyor.com/project/ygj6/verify/builds/28290688 If you do not specify which openssl to use, the system cannot find the correct library."
28ba0a47 2019-11-17 02:37:59 appveyor: disable parallel tests execution Refs: https://github.com/libevent/libevent/pull/917#issuecomment-553784701
63f73ee2 2019-11-14 18:34:56 CI: integrate testing for components export
cd15112b 2019-11-14 18:28:31 cmake: test for find_package()
dc4be869 2019-11-07 18:26:47 cmake: improve package config file
1495f8b6 2019-11-06 21:41:38 Link with iphlpapi only on windows Fixes: 9fecb59a ("Parse IPv6 scope IDs.") Refs: #923
9fecb59a 2019-10-29 15:48:53 Parse IPv6 scope IDs.
4436287d 2019-10-31 09:18:58 Relax bufferevent_connect_hostname_emfile Do not do any assumptions on the error for the EMFILE from getaddrinfo(), expect just any error. Fixes: #924
53b3be4e 2019-10-26 22:31:18 autotools: fails build when need but can not find openssl
5fe83d74 2019-10-25 21:54:13 cmake: eliminate duplicate installation of public headers
1ba94bdf 2019-10-21 22:21:19 Merge pull request #915 from ygj6 -- evutil_socketpair win32 fixes * upstream/pr/915: appveyor: add vs2019 os to test some new features brought by Win10 test: add testcase for evutil_socketpair() evutil: make evutil_socketpair() have the same behavior on Windows with build number lower and higher than 17063
84affc18 2019-10-21 10:36:49 append to CMAKE_MODULE_PATH Don't override any -DCMAKE_MODULE_PATH= passed from CLI to eg. test custom Platform/ support.
38eb4846 2019-10-18 23:32:14 appveyor: add vs2019 os to test some new features brought by Win10
55d60c92 2019-10-18 21:11:37 test: add testcase for evutil_socketpair()
879d2496 2019-10-18 21:03:40 evutil: make evutil_socketpair() have the same behavior on Windows with build number lower and higher than 17063