kc3-lang/libevent

Log

Author Commit Date CI Message
Azat Khuzhin 40fbffc0 2016-11-01T23:33:11 Fix cmake -DEVENT__COVERAGE=ON - do not use compiler check from the root cmake rules with syntax error, let CodeCoverage check it - fix CodeCoverage to check C compiler not CXX - case insensitive checking of CMAKE_BUILD_TYPE - replace flags with --coverage, and fix flags with linking with --coverate, otherwise it will not compile during checking flags and fails.
Azat Khuzhin 9585338f 2016-10-31T19:33:28 Testing with vagrant for 6 OS and cmake+autoconf OS: - linux - freebsd - osx - netbsd - solaris - win And mostly they all are more or less fine, except for timing issues Also it supports next environment variables: - NO_PKG - NO_CMAKE - NO_AUTOTOOLS For instance if you run ubuntu box seocnd time, then you can run with: $ NO_PKG=true vagrant provision ubuntu
Azat Khuzhin 9376ac4d 2016-10-31T22:37:16 autogen.sh: learn about gmake Fixes: 69cce257eb6183dda114d8f5b8ca0325cfabe2e1 ("69cce257eb6183dda114d8f5b8ca0325cfabe2e1")
Azat Khuzhin 69cce257 2016-10-31T12:01:20 autogen.sh: remove all autoconf/automake caches, if any Otherwise if you for example share root of libevent repository with some vm (for example windows+cygwin) then if you try to build with configure on host, and then on guest it will fail, so let's just ignore this since autogen.sh is just for this -- cleaning all stuff.
Azat Khuzhin 3453c081 2016-10-30T11:19:43 cmake: fix finding python2, and check that it is really 2 python version check removed in a4d044c0cd97f68b4b3dde414b83d609719d33d7 ("cmake: use PYTHON_EXECUTABLE to find python2"), but in bcb990ab7cf4921c2c30a1aa4fcb4c0131fffe94 ("cmake/win32: fix running regress, but fixing finding python2 interpreter") we set PYTHON_EXECUTABLE only if it exists.
Azat Khuzhin 8fb08ae9 2016-10-31T01:56:37 Ignore temporary configure files So if you kill configure, git still should ignore them.
Zonr Chang dc624adf 2016-08-24T16:19:01 cmake: cleanup - Remove a redundant check on netdb.h (EVENT__HAVE_NETDB_H). - Properly setup EVENT__SIZEOF_SSIZE_T for the case where "ssize_t" is not "int". - Remove unused EVENT__HAVE_PTHREAD. - Set EVENT__HAVE_LIBZ instead of EVENT__HAVE_ZLIB (and remove the latter). Closes: #391 (cherry-picked from PR)
Azat Khuzhin 43b69b2a 2016-10-26T18:04:07 cmake: fix CheckFunctionExistsEx/CheckPrototypeDefinition (CMP0054)
Thomas Bernard e9837124 2014-12-13T19:42:42 use ev_uint16_t instead of unsigned short for port Like in `sockaddr_in` structure in /usr/include/netinet/in.h @azat: convert all other users (bench, compat, ..) and tweak message Fixes: #178 Fixes: #196 Refs: 6bf1ca78 Link: https://codereview.appspot.com/156040043/#msg4
Azat Khuzhin bcb990ab 2016-10-26T00:51:56 cmake/win32: fix running regress, but fixing finding python2 interpreter Could not find executable C:/projects/libevent/build/bin/regress Looked in the following places: C:/projects/libevent/build/bin/regress C:/projects/libevent/build/bin/regress.exe ... 9/13 Test #9: regress__WIN32_debug ................***Not Run 0.00 sec Link: https://ci.appveyor.com/project/nmathewson/libevent/build/2.1.6.271/job/wvy2jp7uojcut5cx#L1256 Fixes: #411
Simone Basso 23616161 2016-10-21T10:49:22 README.md: fix typo: ar -> are
Azat Khuzhin 7e12e96e 2016-10-17T01:05:38 travis-ci: use container-based infrastructure - by disabling sudo - and since we use addons.apt.packages we don't need apt-get update, that requires sudo Link: https://docs.travis-ci.com/user/migrating-from-legacy/
Azat Khuzhin 9d2f8d4b 2016-10-16T23:46:09 travis-ci/osx: fix compiling/linking openssl libraries And we need that $(echo /path/*) otherwise bash will expand it only during assignment that variable to another one, and this doesn't work correctly.
Azat Khuzhin d7ceae59 2016-10-16T21:48:59 travis-ci: use gcc-5 (fixes osx|gcc failures) Refs: travis-ci/travis-ci#4587
Kurt Roeckx 3e9e0a0d 2016-09-19T22:05:15 Make it build using OpenSSL 1.1.0 Rebased (azat): - tabs instead of whitespaces - make openssl-compat.h safe for complex expressions - do not call sk_SSL_COMP_free() in 1.1 (fixes double free) TODO: - clean methods_bufferevent Closes: #397 (cherry-picked)
Adam Langley 6702da1a 2016-10-12T17:49:17 Don't call BIO_number_{read|written} on NULL BIOs. OpenSSL doesn't document the behaviour of these functions when given a NULL BIO, and it happens to return zero at the moment. But don't depend on that. Closes: #406 (cherry-picked)
Adam Langley f9803a69 2016-10-12T17:49:10 Switch from a 512 to 2048-bit RSA key. The 512 bit key is too small to sign larger hashes. This can cause the regression tests to fail depending on the defaults in libssl.
Azat Khuzhin b9c5077e 2016-10-05T15:52:41 Merge branch 'contrib-guide-v2' Something that should help with reviewing patches. * contrib-guide-v2: Add CONTRIBUTING.md (with checkpatch.sh examples) Add checkpatch script Add config for clang-format Add config for uncrustify Refs: #301
Azat Khuzhin a22d2033 2016-02-15T23:43:10 Add CONTRIBUTING.md (with checkpatch.sh examples)
Azat Khuzhin d482486a 2016-10-05T13:28:04 Add checkpatch script Support: - files - files-diffs - patches - git-refs
Azat Khuzhin f523cb79 2016-10-05T14:00:55 Add config for clang-format
Azat Khuzhin 807e2662 2016-10-05T14:00:40 Add config for uncrustify Original: https://strcpy.net/mark/libevent-uncrustify.cfg (@ellzey)
Seven 75216643 2016-09-16T16:37:59 be: just a simple mistake, reinclude the <errno.h> include the <errno.h> twice.
Azat Khuzhin a4d044c0 2016-10-04T23:21:37 cmake: use PYTHON_EXECUTABLE to find python2 Since most of the distros have symlinks for this.
Azat Khuzhin 83c7cdf4 2016-10-03T03:24:28 Merge branch 'force-disable-clockgettime' * force-disable-clockgettime: Add -DEVENT__DISABLE_CLOCK_GETTIME switch for cmake Adding option to ignore clock_gettime: --disable-clock-gettime
Azat Khuzhin 91559607 2016-10-03T03:17:18 Add -DEVENT__DISABLE_CLOCK_GETTIME switch for cmake See-also: adc402ba5f0e15f4c77505852507f33b50f37ab6 ("Adding option to ignore clock_gettime: --disable-clock-gettime")
Vlad Shcherban adc402ba 2016-09-29T18:31:53 Adding option to ignore clock_gettime: --disable-clock-gettime macOS 10.12 introduced `clock_gettime` to libsystem. This means, built on OS X 10.12 application would crash on earlier versions of OS X because it will try to call clock_gettime. This options is useful to make backwards compatible macOS apps. Fixes: #398 Fixes: #399 Fixes: #400
Azat Khuzhin a73fb2f4 2016-08-27T01:53:31 Merge branch 'release-2.1.6-beta-pull' * release-2.1.6-beta-pull: Bump version to 2.1.6-beta everywhere ChangeLog: Add brief notes Update changelog for 2.1.6-beta (ugh, pretty huge) Update AUTHORS section in README
Azat Khuzhin 3298c254 2016-08-07T23:27:22 Update AUTHORS section in README P.S. "Sebastian Hahn" was declared two times.
Azat Khuzhin 51019e94 2016-07-13T17:40:48 Bump version to 2.1.6-beta everywhere - cmake basic - cmake detecting from git -- event_fuzzy_version_from_git() - autotools - win32 - appveyor
Azat Khuzhin 81d21932 2016-07-05T16:17:38 ChangeLog: Add brief notes
Azat Khuzhin ea2cee72 2016-07-04T18:13:02 Update changelog for 2.1.6-beta (ugh, pretty huge) Changes for: - 2.1.5-beta: 118 - 2.1.6-beta: 350 We should really hurry with the release!
Zonr Chang c6b1ec12 2016-08-24T17:16:32 Fix evhttp_uriencode() regression. http_uriencode_test() (in test/regress_http.c) has been failed after 72afe4c as "hello\0world" is encoded to "hello" instead of "hello%00world". This is because of a misplaced overflow check which causes the non-negative "size" specified in parameter being ignored in within-bound URI. Fixes: #392
Mark Ellzey e94250c8 2016-08-14T14:03:56 removed unused vars
Mark Ellzey 72afe4c9 2016-08-14T14:00:02 pointer overflow checks for evhttp_uriencode Check to make sure pointer math is all OK.
Azat Khuzhin 43eb56c7 2016-08-11T16:15:45 tests: use waitpid(..., WNOWAIT) to fix failing of main/fork under solaris According to solaris docs: "One instance of a SIGCHLD signal is queued for each child process whose status has changed. If waitpid() returns because the status of a child process is available, and WNOWAIT was not specified in options, any pending SIGCHLD signal associated with the process ID of that child process is discarded. Any other pending SIGCHLD signals remain pending." And interesting thing that it works if you add sleep(1) before waitpid(), and also if you run with --verbose (some race or what). But linux doesn't support WNOWAIT in waitpid() so add detection into cmake/autotools. Fixes: #387 Link: https://bugzilla.redhat.com/show_bug.cgi?id=840782
Azat Khuzhin 16d220cb 2016-08-11T13:43:14 test: replace sleeping with syncing pair in main/fork About this syncing pair: - read endpoint, must be blocked, to make it a checkpoint or smth like this - write endpoint, must be nonblocking, to avoid readcb hung Refs: #387
Azat Khuzhin 685a6a19 2016-08-11T09:27:50 travis: split long lines, and make it cleaner
Azat Khuzhin 088ea5e0 2016-08-11T00:18:04 travis: fix autotools on osx by reinstalling libtool Link: mkrufky/libdvbtee#22
Azat Khuzhin 3189eb00 2016-08-10T16:04:33 be_sock: handle readv() returns ECONNREFUSED (freebsd 9.2) During testing sometimes bufferevent/bufferevent_connect_fail_eventcb fails, and after some digging I found that this was the case when connect() doesn't return ECONNREFUSED immediately, and instead next operation will return it (in our case evbuffer_read()->readv(), needless to say that after this bufferevent_writecb() called and it checks error with getsockopt() but of course it doesn't return any error), so this patch checks "errno" after "readv()" and installs "bufev::connection_refused" flag, to handle this from writecb and only once. Fixes: bufferevent/bufferevent_connect_fail_eventcb Fixes: bufferevent/bufferevent_connect_fail_eventcb_defer Refs: #388
Azat Khuzhin 500b6b75 2016-08-10T16:50:19 test/http: do not run tests that based on backlog filling (freebsd) I cannot find any other solution for now, so simply ignore them for now, we should think about normal fix for this. Refs: #388
Azat Khuzhin 5a157c87 2016-08-10T16:09:09 evutil: mark ai_find_protocol() static (prototype-less)
Azat Khuzhin 4410e9df 2016-08-10T12:07:32 test/bufferevent/iocp: fix test name for "bufferevent_connect_fail_eventcb"
Azat Khuzhin 40730ae3 2016-05-09T22:34:28 Fix getaddrinfo under solaris (for multiprotocol case) During testing on solaris 11.3, util/getaddrinfo failed at: memset(&hints, 0, sizeof(hints)); hints.ai_flags = EVUTIL_AI_NUMERICHOST; r = evutil_getaddrinfo("1.2.3.4", NULL, &hints, &ai); tt_assert(ai_find_by_protocol(ai, IPPROTO_TCP)); And this is because solaris's getaddrinfo() returns: $6 = { ai_flags = 32, ai_family = 2, ai_socktype = 0, ai_protocol = 0, <-- no proto ai_addrlen = 16, ai_canonname = 0x0, ai_addr = 0x815d658, ai_next = 0x0 <-- nothing else } So we should emulate this too. Plus introduce helper that will search through all results, not only first one. Fixes: util/getaddrinfo Fixes: #354
Azat Khuzhin dc95823c 2016-08-10T00:27:59 cmake/solaris: set CMAKE_REQUIRED_LIBRARIES to fix functions detections Otherwise we will not detect next functions for instance: - gethostbyname_r # and related And now both autotools/cmake builds passes all regress tests in basic env (on solaris of course). Fixes: dns/client_fail_requests_getaddrinfo
Azat Khuzhin 050bfc7f 2016-08-10T00:16:48 cmake/solaris: fix building (link with socket,nsl)
Azat Khuzhin 00514a2a 2016-08-09T15:49:01 Merge branch 'appveyor-cmake-v6' This patch set introduces matrix for appveyor and fixes bugs related to win32, during debugging this matrix. This should greatly reduce number of work for making a release ('check under windows' part only). Right now tests on appveyor still failes in summary, but we should dig into problems, not hide them. Test matrix looks like this: - autotools - autotools --disable-openssl - autotools --disable-thread-support - autotools --disable-debug-mode - autotools --disable-malloc-replacement - cmake - cmake -DEVENT__DISABLE_OPENSSL=ON - cmake -DEVENT__DISABLE_THREAD_SUPPORT=ON - cmake -DEVENT__DISABLE_DEBUG_MODE=ON - cmake -DEVENT__DISABLE_MM_REPLACEMENT=ON - cmake -DEVENT__ENABLE_VERBOSE_DEBUG=ON - cmake -DCMAKE_C_FLAGS='-DUNICODE -D_UNICODE' And takes 90min (was 7min, and this is the sad part). * appveyor-cmake-v6: test/ssl: use send()/recv()/EVUTIL_ERR_RW_RETRIABLE()/EVUTIL_SOCKET_ERROR() to fix win32 test/https_basic: increase timeout for complete write (fixes win32) cmake: check for ZLIB_INCLUDE_DIR, since we can have only library without headers autotools/win32: fix searching ssl library appveyor/autotools: link with openssl by passing LDFLAGS/CFLAGS appveyor: image already had openssl installed cmake/win32: do not compile regress_thread on -DEVENT__DISABLE_THREAD_SUPPORT=ON cmake/win32: do not compile evthread_win32 on -DEVENT__DISABLE_THREAD_SUPPORT=ON appveyor: check -DUNICODE -D_UNICODE according to ReleaseChecklist (cmake only) cmake: fix -DEVENT__ENABLE_VERBOSE_DEBUG (typo on -DUSE_DEBUG) test: fix building with --disable-thread-support under win32 cmake: do not use stderr for notifications/version-info autoconf: fix --disable-thread-support build under win32 appveyor: ignore failure of mingw-get appveyor: drop shallow_clone, since we use tags for detecting version in cmake appveyor: support cmake & autotools using build matrix (like travis-ci has) Fixes: #364
Azat Khuzhin a9e8cd67 2016-08-09T12:25:11 test/ssl: use send()/recv()/EVUTIL_ERR_RW_RETRIABLE()/EVUTIL_SOCKET_ERROR() to fix win32 Fixes: https://ci.appveyor.com/project/azat/libevent/build/2.1.5.107/job/k70our1xdp0ym4dm#L1906 Fixes: ssl/bufferevent_connect_sleep
Azat Khuzhin d5a2f2f9 2016-08-09T12:10:18 test/https_basic: increase timeout for complete write (fixes win32) Otherwise on win32 we got 2, but test is ok, some timings issue. Introduced-in: c968eb3 Fixes: https://ci.appveyor.com/project/azat/libevent/build/2.1.5.107/job/k70our1xdp0ym4dm#L1906
Azat Khuzhin c4dfb93f 2016-08-09T10:56:34 cmake: check for ZLIB_INCLUDE_DIR, since we can have only library without headers
Azat Khuzhin 671a24f2 2016-08-08T18:10:56 autotools/win32: fix searching ssl library
Azat Khuzhin 6fcfa25d 2016-08-08T17:25:11 appveyor/autotools: link with openssl by passing LDFLAGS/CFLAGS This never works, hence green tests in production. and now it works: https://ci.appveyor.com/project/azat/libevent/build/2.1.5.100/job/eib4xqfb7d3ruo16 (look by /"evthread_win32.c")
Azat Khuzhin 4634b85b 2016-08-08T15:34:57 appveyor: image already had openssl installed Fixes messages like "Version mismatch for openssl: compiled with 1000201f but running with 1000208f" [1]. According to next link: http://help.appveyor.com/discussions/questions/1132-openssl-installation-issues Refs: appveyor/ci#576 [1]: https://ci.appveyor.com/project/azat/libevent/build/2.1.5.95/job/dcy9cfoj3rfo4gdh
Azat Khuzhin de0c1965 2016-08-08T15:50:46 cmake/win32: do not compile regress_thread on -DEVENT__DISABLE_THREAD_SUPPORT=ON
Azat Khuzhin ecb0ec82 2016-08-08T15:45:29 cmake/win32: do not compile evthread_win32 on -DEVENT__DISABLE_THREAD_SUPPORT=ON There is duplicated "evthread_win32.c" appending to ${SRC_CORE} list, leave only one that under if EVENT__DISABLE_THREAD_SUPPORT Fixes: https://ci.appveyor.com/project/azat/libevent/build/2.1.5.96/job/44q3rgifasny7gek
Azat Khuzhin e9acc441 2016-08-07T23:51:21 appveyor: check -DUNICODE -D_UNICODE according to ReleaseChecklist (cmake only) Link: https://github.com/libevent/libevent/wiki/ReleaseChecklist
Azat Khuzhin e35f2241 2016-08-07T23:46:26 cmake: fix -DEVENT__ENABLE_VERBOSE_DEBUG (typo on -DUSE_DEBUG) Fixes: 8b228e27f57300be61b57a41a2ec8666b726dc34 ("Lot's of cmake updates")
Azat Khuzhin a487706e 2016-08-07T23:14:01 test: fix building with --disable-thread-support under win32
Azat Khuzhin 38716c65 2016-08-07T23:07:44 cmake: do not use stderr for notifications/version-info For all except "STATUS" message() will write to stderr, and this also includes case when you does not have <mode> at all. Plus for every message in stderr powershell generates exception and make appveyor fails. Fixes: https://ci.appveyor.com/project/azat/libevent/build/2.1.5.85/job/i10k7m0t80330mtr
Azat Khuzhin bb09535b 2016-08-07T22:19:39 autoconf: fix --disable-thread-support build under win32 Fixes: https://ci.appveyor.com/project/azat/libevent/build/job/gvud4tcqsd5bnarl Fixes: https://ci.appveyor.com/project/azat/libevent/build/2.1.6.80/job/5frnb1c3n4quxxqy Fixes: https://ci.appveyor.com/project/azat/libevent/build/2.1.6.80/job/3wdahbrew7setmoa
Azat Khuzhin 18108574 2016-08-07T21:30:04 appveyor: ignore failure of mingw-get Since according to doc [1], appveyour will fail the build on every powershell's exception: "PowerShell script is considered successful if it finishes without exception." [1]: https://www.appveyor.com/docs/build-configuration#powershell
Azat Khuzhin ac90133c 2016-08-07T20:52:41 appveyor: drop shallow_clone, since we use tags for detecting version in cmake
Azat Khuzhin 8f950155 2016-06-19T14:15:41 appveyor: support cmake & autotools using build matrix (like travis-ci has) This will allow us to avoid possible compilation regressions, and also some failures in different environments (for example because of different sizeof(size_t)). For example we can avoid next issues: - #361 - #314 - #311 (And I'm pretty sure that this is not complete list) And of course it reduce job for maintainers. But it also have one downside, appveyor doesn't have such concurrency like travis-ci, so it can take a while to finish the whole build, but we can resolve this later, or reduce build matrix to only one for autotools and one for cmake. Fixes: #364
Azat Khuzhin 8a2c6c77 2016-08-08T18:15:41 Ignore `make dist` generated files
Mark Mentovai df6f99e5 2016-07-08T09:43:39 Check for Mac OS X 10.4 kqueue bug properly EV_ERROR is a bit in struct kevent::flags. Other bits may be set too. Actually we have osx builds on travis-ci, but it uses osx 10.9.5, and we don't have warnings there, since I guess that there is no OR'ing with previous flag in case of error, while in 10.12 there is OR. Fixes: #377 Fixes: #376 Link: https://crbug.com/626534 Link: https://travis-ci.org/libevent/libevent/jobs/141033429
Azat Khuzhin 8892f4cb 2016-07-07T13:15:41 buffer: don't mix code and declarations
basavesh.as 666db91a 2016-06-29T15:11:50 Fix memory leak in signal-test.c
Mark Ellzey 30316177 2016-06-28T10:37:24 [#372] check for errno.h
Mark Ellzey e7abef1c 2016-06-26T11:15:58 Merge pull request #367 from neerajbadlani/master Update gitignore file to ignore cscope gen'ed files
Azat Khuzhin 70040c09 2016-06-26T01:57:45 buffer: Merge branch '340-dig-v2' All details in this two patches (it's titles), and shortlog is below. * 340-dig-v2: buffer: fix overflow check in evbuffer_expand_singlechain() test/buffer: cover evbuffer_expand() for overflow
Azat Khuzhin a3f4ccd1 2016-06-21T19:49:57 buffer: fix overflow check in evbuffer_expand_singlechain() Refs: #306 Fixes: #340 Fixes: 20d6d4458bee5d88bda1511c225c25b2d3198d6c
Azat Khuzhin 48dab7aa 2016-06-22T15:48:51 test/buffer: cover evbuffer_expand() for overflow Refs: #306 Refs: #340
Mark Ellzey 17cc6362 2016-06-24T18:07:39 [Issue #313] set method to ASCII "NULL" if evhttp_method() returns NULL
Neeraj Badlani 0aaa4fbe 2016-06-22T21:15:53 Update gitignore file to ignore cscope gen'ed files
Azat Khuzhin a69e4fad 2016-06-19T13:24:18 buffer: Merge branch 'evbuffer-empty-chains-fixes-v4' This fixes bug with empty-chains and evbuffer_add_buffer()/evbuffer_remove_buffer(). * evbuffer-empty-chains-fixes-v4: buffer: evbuffer_add_buffer(): clean empty chains from destination buffer test/buffer: evbuffer_add_buffer() with empty chains test/buffer: evbuffer_remove_buffer() with empty chains (prepend) test/buffer: evbuffer_remove_buffer() with empty chains (evbuffer_add_buffer()) Reported-by: Eduardo Panisset <eduardo@anchorfree.com>
Azat Khuzhin 9b294082 2016-06-19T13:21:15 bufferevent_filter: Merge branch 'be-filter-data-stuck' Fixes data stuck in filters with active watermarks. * be-filter-data-stuck: test/be_filter: creating test case for data stuck with active watermarks be_filter: avoid data stuck under active watermarks
Eduardo Panisset 766194b3 2016-06-19T02:09:50 test/be_filter: creating test case for data stuck with active watermarks v2: fix whitespaces s/int/size_t/ use tt_int_op() s/malloc/calloc (to avoid possible false-positive)
Eduardo Panisset b627ad88 2016-06-17T10:46:32 be_filter: avoid data stuck under active watermarks Suppose we have bufferevent filter attached to bufferevent socket. Read high watermark for bufferevent filter is configured to 4096 bytes. Socket receives 4343 bytes. Due to watermark, 4096 bytes are transferred from socket input buffer to filter input buffer and 247 bytes are left in bufferevent socket. Suppose that no more data is received through socket. At this point 247 bytes will sit forever in input buffer of bufferevent socket. The patch attached solves this issue registering read callback to filter's input buffer if it reaches its read high water mark and data was left in corresponding underlying's input buffer. This read callback calls filter process input function as soon as filter input buffer falls below its read high watermark and there still is data left in underlying input buffer. Callback is deregistered as soon as filter input buffer falls below its read high watermark.
David Paschich 28518896 2016-05-21T21:05:11 Fix bufferevent_pair to properly set BEV_EVENT_{READING,WRITING} on flush. Here's some fun. From `bufferevent.h`: ``` #define BEV_EVENT_READING 0x01 /**< error encountered while reading */ #define BEV_EVENT_WRITING 0x02 /**< error encountered while writing */ ``` And from `event.h`: ``` /** Wait for a socket or FD to become readable */ #define EV_READ 0x02 /** Wait for a socket or FD to become writeable */ #define EV_WRITE 0x04 ``` Library users have to be very careful to get this right; it turns out, the library itself got this wrong in the `bufferevent_pair` code. It appears that in most of the code, only `BEV_EVENT_FINISHED` will indicate whether it's read or write; on error or timeout, it appears that "both" is assumed and not set in the callback. I read through all the other places where `BEV_EVENT_FINISHED` is passed to an event callback; it appears that the pair code is the only spot that got it wrong. azat: add TT_FORK to avoid breaking clean env, and rebase commit message (copied from #359) Fixes: #359
Azat Khuzhin 26fd9321 2016-06-07T18:31:48 buffer: evbuffer_add_buffer(): clean empty chains from destination buffer @EMPanisset reported a problem (#358) with evbuffer_remove_buffer(), but actually I think that the problem is in evbuffer_add_buffer() which introduces this empty chain, all other callers (except evbuffer_prepend_buffer(), but it doesn't have this problem though) should be safe. And FWIW the only API that allows empty chains is evbuffer_add_reference(), and we can add check there to avoid such issues, but for now I leaved this without fixing, since I think that evbuffer_add_reference() with empty chains can be used as a barrier (but this can be tricky). Fixes: regress evbuffer/remove_buffer_with_empty2 v2: introduce/fixes evbuffer/add_buffer_with_empty
Azat Khuzhin a272bc42 2016-06-17T15:54:53 test/buffer: evbuffer_add_buffer() with empty chains Reported-by: @EMPanisset Link: https://github.com/libevent/libevent/issues/358#issuecomment-225345697
Azat Khuzhin f0cfa146 2016-06-08T13:41:30 test/buffer: evbuffer_remove_buffer() with empty chains (prepend) Using: - evbuffer_add() - evbuffer_prepend_buffer() - evbuffer_add_reference() - evbuffer_remove_buffer()
Azat Khuzhin 2880ce6a 2016-06-07T14:56:32 test/buffer: evbuffer_remove_buffer() with empty chains (evbuffer_add_buffer()) Using: - evbuffer_add() - evbuffer_add_buffer() -- the one that has problem - evbuffer_add_reference() -- the only one that allows empty chains to be added - evbuffer_remove_buffer()
Azat Khuzhin 2a4bf294 2016-06-17T16:14:02 test/http: avoid using conditionals with omitted operands (fixes VS2015) But we need to add VS2015 build on appveyor. Fixes: #361 Reported-by: @nntrab
Azat Khuzhin aabf1c2d 2016-06-17T16:07:15 test/http: don't mix declarations and code (fixes -Wdeclaration-after-statement)
Azat Khuzhin c08d90ba 2016-06-17T15:54:31 test/buffer: fix leak in test_evbuffer_prepend()
Azat Khuzhin e7d1e392 2016-06-17T15:43:26 test/buffer: avoid errors with --no-fork (reinitialize static vars)
Rainer Keller b5ca3656 2016-05-30T16:53:41 For non GCC/clang on OSX the -Wno-deprecated-declarations may not be valid Closes: nmathewson/Libevent#129
Azat Khuzhin 41e54464 2016-05-12T00:40:25 Merge branch 'travis-ci-os-matrix-v2' This increases libevent coverage to: - os:osx - cmake -DEVENT__DISABLE_MM_REPLACEMENT=ON - cmake -DEVENT__ENABLE_VERBOSE_DEBUG=ON - configure --disable-openssl - configure --disable-thread-support - configure --disable-malloc-replacement - fix travis-ci builds under automake >1.11 Possible failures after this patch set (not always, IOW in some builds this issues aren't real issues): - some failures but mostly because of timing issues, must be fixed separately. - https://travis-ci.org/azat/libevent/jobs/129430229 # on brew update - https://travis-ci.org/azat/libevent/jobs/129430221 # some locking issues * travis-ci-os-matrix-v2: automake: define serial-tests only if automake have this option test/automake: don't use paralell test harness (since automake 1.12) travis-ci/osx: relink gcc/g++ instead of clang travis-ci: enable multi-os mode (osx, linux) travis-ci: increase matrix (--disable-foo) travis-ci: adjust alignment Fixes: #356 Travis-CI: https://travis-ci.org/azat/libevent/builds/129430181
Azat Khuzhin 61179dec 2016-05-11T16:02:02 automake: define serial-tests only if automake have this option P.S. I did try a lot of other ways, but seems that this is the only one that will work. Fixes: automake 1.11 Travis-CI: https://travis-ci.org/azat/libevent/jobs/129398265
Azat Khuzhin 44d755e0 2016-05-11T10:18:25 test/automake: don't use paralell test harness (since automake 1.12) Starting from automake 1.2 there is parallel test harness, that redirects all output to some log, which serial-test doesn't do. So in case of new runner we can get no output for 10 minutes, for example on my desktop: $ time make verify VERBOSE=1 PASS: test/test-script.sh ============================================================================ Testsuite summary for libevent 2.1.5-beta ============================================================================ # TOTAL: 1 # PASS: 1 # SKIP: 0 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 ============================================================================ real 25m31.735s user 0m13.753s sys 0m7.648s And this means that this will fail on travis-ci, since it has timeout for 10 minutes. Sure we can use `travis wait 60` instead, but I think that it is better to fix this by writing result to output, instead of hacking around, so let's use serial-tests instead of parallel always. And now it works on travis-ci under linux because it has automake 1.11 while osx has at least 1.12. Links: https://docs.travis-ci.com/user/common-build-problems/ https://www.gnu.org/software/automake/manual/html_node/Serial-Test-Harness.html#Serial-Test-Harness https://www.gnu.org/software/automake/manual/html_node/Parallel-Test-Harness.html CI: https://travis-ci.org/azat/libevent/jobs/129171497 # ok on linux https://travis-ci.org/azat/libevent/jobs/129171532 # no output for 10 min on osx
Azat Khuzhin 481481d3 2016-05-10T10:25:05 travis-ci/osx: relink gcc/g++ instead of clang Since by default osx replaces /usr/bin/gcc with it's apple clang, while we have gcc in our build matrix, so use real gcc.
Azat Khuzhin 79917e48 2016-05-09T18:14:31 travis-ci: enable multi-os mode (osx, linux) - use addons.apt.packages instead of `apt-get install` - add `brew update`/`brew install ...` Link: https://docs.travis-ci.com/user/installing-dependencies/ Link: https://docs.travis-ci.com/user/multi-os/
Azat Khuzhin 59649f74 2016-05-09T18:48:56 travis-ci: increase matrix (--disable-foo) Use --disable-foo from https://github.com/libevent/libevent/wiki/ReleaseChecklist
Azat Khuzhin c8be3395 2016-05-09T18:54:41 travis-ci: adjust alignment
Azat Khuzhin 38e0f4a5 2016-05-02T15:21:50 be_openssl: clear all pending errors before SSL_*() calls Refs: #350 Reported-by: @CapSel
Azat Khuzhin ce389933 2016-04-21T02:16:21 Ignore all pkgconfig generated stuff In the referenced commit new *.pc added, and I think it is better to ignore them all. Refs: b8d7c6211a965c19c7c5de414135ff13b5fa2476 ("libevent_core and libevent_extra also deserve a pkgconfig file")
Azat Khuzhin e77ff418 2016-04-21T01:47:29 test/buffer: cover n_add_for_cb when evbuffer_prepend() need to allocate buffer Regression-for: 0abd0393eaf029e1ead8a09b479ea6830f7152ee ("Fix n_add_for_cb in evbuffer_prepend() in case of new buffer required")
Azat Khuzhin bd19a28a 2016-04-21T02:11:26 test/tinytest_macros: add new one tt_nstr_op()
Azat Khuzhin 0abd0393 2016-04-21T01:58:58 Fix n_add_for_cb in evbuffer_prepend() in case of new buffer required Signed-off-by: @luoming1224 Fixes: #349
kmx.io     mail     discord kmxgit v0.4.0