|
23c5c315
|
2021-11-14T08:42:12
|
|
Merge pull request #6114 from libgit2/ethomson/cmake5
cmake: further refactorings
|
|
|
2c154145
|
2021-11-11T23:09:44
|
|
cmake: move sha1 source selection into CMakeLists.txt
The select hashes module selects the hash; the CMakeLists.txt selects
the files to implement it.
|
|
|
395b3dc4
|
2021-11-11T22:10:51
|
|
cmake: refactor global variables
Update the global variables `LIBGIT2_OBJECTS` to
`LIBGIT2_DEPENDENCY_OBJECTS` for clarity and consistency.
|
|
|
c3fec456
|
2021-11-11T22:37:36
|
|
cmake: reformat modules
Apply the standard project cmake formatting to the modules.
|
|
|
c7f6ecb3
|
2021-11-11T22:54:14
|
|
cmake: use a string not a boolean for LIBGIT2_FILENAME
|
|
b608af6c
|
2021-11-14T07:23:01
|
|
Merge pull request #6116 from lhchavez/drop-volatile-qualifier-in-atomic-exchange
|
|
|
03132b36
|
2021-11-14T07:22:24
|
|
Merge pull request #6115 from lhchavez/fix-indentation-threadstate
|
|
5675312e
|
2021-11-14T02:27:10
|
|
Fix a gcc 11 warning in src/thread.h
When building under gcc 11, there is a warning about an incompatible pointer
type, since
[`__atomic_exchange`](https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html)
does not take `volatile` pointers:
```
In file included from ../src/common.h:81,
from ../src/transports/winhttp.c:8:
../src/thread-utils.h: In function ‘git___swap’:
../src/thread-utils.h:168:9: warning: argument 3 of ‘__atomic_exchange’ discards ‘volatile’ qualifier [-Wincompatible-pointer-types]
168 | __atomic_exchange(ptr, &newval, &foundval, __ATOMIC_SEQ_CST);
| ^~~~~~~~~~~~~~~~~
```
This change drops the `volatile` qualifier so that the pointer type matches
what `__atomic_exchange` expects.
|
|
|
0c4d24da
|
2021-11-14T02:24:39
|
|
Fix a gcc 11 warning in src/threadstate.c
When building under gcc 11, there is a warning about a misaligned guard clause
because there were mixed spaces and tabs:
```
[128/634] Building C object src/CMakeFiles/git2internal.dir/threadstate.c.o
../src/threadstate.c: In function ‘threadstate_dispose’:
../src/threadstate.c:39:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
39 | if (threadstate->error_t.message != git_str__initstr)
| ^~
../src/threadstate.c:41:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
41 | threadstate->error_t.message = NULL;
| ^~~~~~~~~~~
../src/threadstate.c: At top level:
```
This change indents the code with tabs for consistency with the rest of the
code, which makes the warning go away.
|
|
|
043f3123
|
2021-11-11T18:21:35
|
|
Merge pull request #6113 from libgit2/ethomson/cmake3
Add missing-declarations warning globally
|
|
|
4a6ef5a4
|
2021-11-11T17:04:24
|
|
cmake: move missing-declarations warning to top-level
We should enforce declarations throughout the code-base, including
examples, fuzzers and tests, not just in the `src` tree.
|
|
|
8d2b3110
|
2021-11-11T19:58:49
|
|
tests: include function declarations
|
|
|
bfdc0971
|
2021-11-11T13:32:00
|
|
test: correct test names
|
|
|
ca14942e
|
2021-11-11T13:28:08
|
|
tests: declare functions statically where appropriate
|
|
|
eabbee04
|
2021-11-11T12:48:19
|
|
example: declare print_usage function
|
|
|
8be22614
|
2021-11-11T12:47:02
|
|
examples: remove unused function
|
|
|
2374ba8d
|
2021-11-11T17:15:47
|
|
fuzzers: declare static functions as static
|
|
|
3f024b6d
|
2021-11-11T12:57:44
|
|
clar: declare summary functions as static
|
|
|
489aec44
|
2021-11-11T12:33:14
|
|
fuzzers: declare standalone functions
|
|
|
0429894e
|
2021-11-11T12:28:07
|
|
tests: declare trace handler as static
|
|
|
49f03c03
|
2021-11-11T16:53:33
|
|
tests: include test declarations for old gcc
Older versions of gcc do not believe that we've adequately declared our
test functions. Include `clar_suite.h` conditionally for those old
versions. Do not do this on newer compilers to avoid unnecessary
recompilation of the entire suite when we add or remove a test function.
|
|
|
cf522050
|
2021-11-11T16:24:37
|
|
clar: emit `clar_suite.h` with test declarations
We may want to have test function declarations; produce a header file
with (only) the test declarations. Update clar to avoid overwriting the
file unnecessarily to avoid bumping timestamps and potentially
recompiling unnecessarily.
|
|
|
7687948a
|
2021-11-11T16:13:38
|
|
Merge pull request #6112 from libgit2/ethomson/cmake3
cmake refactorings
|
|
|
42205e72
|
2021-11-11T16:09:49
|
|
Merge pull request #6111 from libgit2/ethomson/str_free
str: git_str_free is never a function
|
|
|
4e84ddd5
|
2021-11-10T21:59:46
|
|
cmake: refactor zlib selection
Move zlib selection into its own cmake module.
|
|
|
83fa5480
|
2021-11-10T21:58:12
|
|
cmake: refactor WinHTTP selection
Move WinHTTP selection into its own cmake module.
|
|
|
e35a22a0
|
2021-11-10T21:55:23
|
|
cmake: refactor libssh2 selection
Move SSH selection into its own cmake module.
|
|
|
f0cb3788
|
2021-11-10T21:51:55
|
|
cmake: refactor regex selection
Move regex selection into its own cmake module.
|
|
|
de178d36
|
2021-11-10T21:49:20
|
|
cmake: refactor http_parser selection
Move http_parser selection into its own cmake module.
|
|
|
16b6e3a9
|
2021-11-10T21:33:28
|
|
cmake: HTTP_Parser is now HTTPParser
|
|
|
19e99de0
|
2021-11-10T08:14:11
|
|
cmake: qsort detection in features.h
|
|
|
d3a7a352
|
2021-11-06T16:44:07
|
|
cmake: move test enablement into test cmake
|
|
|
207beff5
|
2021-11-06T16:43:04
|
|
cmake: reorganize file
|
|
|
4d2a6839
|
2021-11-06T16:38:57
|
|
cmake: move fuzzer args to the fuzzer's cmake
|
|
|
7b527c12
|
2021-11-06T16:38:11
|
|
cmake: move deprecation definition to src/
There's no need to add the deprecation at the top-level. Our tests add
deprecation explicitly.
|
|
|
9f37457e
|
2021-11-06T16:23:03
|
|
cmake: move cflag defaults into a separate module
|
|
|
6c00fcb7
|
2021-11-10T17:32:41
|
|
cmake: USE_SSH is not on by default
|
|
|
789ab915
|
2021-11-10T21:02:42
|
|
cmake: standardize USE_WINHTTP
WinHTTP can now be disabled with `USE_WINHTTP=OFF` instead of
`WINHTTP=OFF` to better support the other cmake semantics.
|
|
|
9324d16e
|
2021-11-06T16:14:47
|
|
cmake: standardize USE_THREADS and USE_NSEC
Threading can now be disabled with `USE_THREADS=OFF` instead of
`THREADSAFE=OFF` to better support the other cmake semantics.
Nanosecond support is the default _if_ we can detect it. This should be
our default always - like threads - and people can opt out explicitly.
|
|
|
08047ca0
|
2021-11-11T19:56:31
|
|
str: git_str_free is never a function
|
|
|
ceddeed8
|
2021-11-11T15:20:50
|
|
Merge pull request #6104 from libgit2/ethomson/path
path: refactor utility path functions
|
|
|
9ab351c0
|
2021-11-11T15:14:59
|
|
Merge pull request #6107 from joshtriplett/refresh-handling
Support checking for object existence without refresh
|
|
|
dfd5b32f
|
2021-11-11T15:10:37
|
|
Merge pull request #6109 from joshtriplett/document-odb-race-free
Document that `git_odb` is thread-safe
|
|
644c763b
|
2021-11-11T00:30:40
|
|
Document that `git_odb` is thread-safe
Commit 4ae41f9c639d246d34dac89c3f1d9451c9cfa8d3 made `git_odb`
race-free, and added internal locking. Update `docs/threading.md`
accordingly, so that APIs built atop libgit2 (e.g. language bindings)
can count on this.
|
|
|
1a8b2922
|
2021-11-09T14:15:32
|
|
win32: include correct path header
|
|
|
1217c5b2
|
2021-11-01T21:12:23
|
|
fs_path: remove now-unused validation functions
|
|
|
62251409
|
2021-11-01T21:09:17
|
|
fs_path: add length with suffix validation
|
|
|
91246ee5
|
2021-11-01T20:14:34
|
|
path: use new length validation functions
|
|
|
1728e27c
|
2021-11-01T18:19:56
|
|
path: length validation respecting core.longpaths
Teach `git_path_is_valid` to respect `core.longpaths`. Add helper
methods to validate length and set the error message appropriately.
|
|
|
315a43b2
|
2021-11-01T17:37:06
|
|
path: introduce `git_path_str_is_valid`
Add a `git_str` based validity check; the existing `git_path_is_valid`
defers to it.
|
|
|
ebacd24c
|
2021-11-01T13:58:18
|
|
fs_path: add long path validation on windows
|
|
|
dd748dbe
|
2021-11-01T13:04:40
|
|
fs_path: make empty component validation optional
|
|
|
bef02d3e
|
2021-11-01T10:57:28
|
|
fs_path: introduce `str_is_valid`
Provide a mechanism for users to limit the number of characters that are
examined; `git_fs_path_str_is_valid` and friends will only examine up to
`str->size` bytes.
`git_fs_path_is_valid` delegates to these new functions by passing
`SIZE_MAX` (instead of doing a `strlen`), which is a sentinel value
meaning "look for a NUL terminator".
|
|
|
63e36c53
|
2021-11-01T09:34:32
|
|
path: `validate` -> `is_valid`
Since we're returning a boolean about validation, the name is more
properly "is valid".
|
|
|
434a4610
|
2021-11-01T09:31:32
|
|
fs_path: `validate` -> `is_valid`
Since we're returning a boolean about validation, the name is more
properly "is valid".
|
|
|
95117d47
|
2021-10-31T09:45:46
|
|
path: separate git-specific path functions from util
Introduce `git_fs_path`, which operates on generic filesystem paths.
`git_path` will be kept for only git-specific path functionality (for
example, checking for `.git` in a path).
|
|
|
44ec8b5c
|
2021-11-09T09:38:53
|
|
Merge pull request #6108 from libgit2/ethomson/docs_ci
ci: only update docs on push
|
|
|
51f6f15d
|
2021-11-09T09:03:06
|
|
ci: only update docs on push
Only update the documentation on a `push`. We were previously updating the documentation only when not in a `pull_request`, which meant that we would push documentation updates in manual build triggers.
|
|
|
f45ff6c9
|
2021-11-08T17:33:35
|
|
Omit trailing comma on enum
To accommodate less capable compilers.
Co-authored-by: Peter Pettersson <85582231+boretrk@users.noreply.github.com>
|
|
|
94cb060c
|
2021-11-08T14:54:09
|
|
Add tests for ODB refresh
Add optional refreshing in the fake backend, and count the number of
refresh calls if enabled.
|
|
|
81662d43
|
2021-11-08T14:48:45
|
|
Support checking for object existence without refresh
Looking up a non-existent object currently always invokes
`git_odb_refresh`. If looking up a large batch of objects, many of which
may legitimately not exist, this will repeatedly refresh the ODB to no
avail.
Add a `git_odb_exists_ext` that accepts flags controlling the ODB
lookup, and add a flag to suppress the refresh. This allows the user to
control if and when they refresh (for instance, refreshing once before
starting the batch).
|
|
|
3993e9ae
|
2021-11-08T14:00:09
|
|
Update documentation for ODB backend refresh logic
Commit b1a6c316a6070fac4ab1ec5792979838f7145c39 moved auto-refresh into
the pack backend, and added a comment accordingly. Commit
43820f204ea32503b4083e3b6b83f30a0a0031c9 moved auto-refresh back *out*
of backends into the ODB layer, but didn't update the comment.
|
|
|
358a60e1
|
2021-10-28T11:27:28
|
|
Merge pull request #6100 from mkhl/tests/instead-of-clar
libgit2_clar is now libgit2_tests
|
|
f66e7f36
|
2021-10-28T10:25:09
|
|
libgit2_clar is now libgit2_tests
in #6083 the test runner was renamed to libgit2_tests,
but not all references to the old name were updated.
this change changes all of them to use the new name.
|
|
|
9b04a307
|
2021-10-18T08:54:36
|
|
Merge pull request #6084 from libgit2/ethomson/cmake
cmake: cleanups and consistency
|
|
|
52693ab4
|
2021-09-26T23:11:13
|
|
cmake: stylistic refactoring
Ensure that we always use lowercase function names, and that we do not
have spaces preceding open parentheses, for consistency.
|
|
|
e1be28c7
|
2021-09-26T22:02:04
|
|
cmake: remove unused STDCALL option
The `STDCALL` option was removed; remove the (unreachable) error
message.
|
|
|
8507bf81
|
2021-09-26T21:54:08
|
|
trace: always enabled
There's no need to make tracing opt-in; it should always be included.
|
|
|
780faa41
|
2021-09-26T21:51:16
|
|
cmake: allow USE_ICONV on any Unix
|
|
|
7f5b0f0c
|
2021-09-26T21:50:19
|
|
cmake: allow ENABLE_REPRODUCIBLE_BUILDS on macOS
macOS may support ENABLE_REPRODUCIBLE_BUILDS, allow users to opt-in to
it. (Especially since ENABLE_REPRODUCIBLE_BUILDS is not the default.)
|
|
|
a89db0e7
|
2021-10-17T17:15:41
|
|
Merge pull request #6083 from libgit2/ethomson/clar_no_more
|
|
|
4e14d4c6
|
2021-09-26T22:06:49
|
|
cmake: BUILD_CLAR is now BUILD_TESTS
Nobody knows what CLAR is. The test building option should be
`BUILD_TESTS`.
|
|
|
e61abdce
|
2021-10-17T10:20:46
|
|
Merge pull request #6078 from libgit2/ethomson/gitstr
`git_buf`: now a public-only API (`git_str` is our internal API)
|
|
|
f0e693b1
|
2021-09-07T17:53:49
|
|
str: introduce `git_str` for internal, `git_buf` is external
libgit2 has two distinct requirements that were previously solved by
`git_buf`. We require:
1. A general purpose string class that provides a number of utility APIs
for manipulating data (eg, concatenating, truncating, etc).
2. A structure that we can use to return strings to callers that they
can take ownership of.
By using a single class (`git_buf`) for both of these purposes, we have
confused the API to the point that refactorings are difficult and
reasoning about correctness is also difficult.
Move the utility class `git_buf` to be called `git_str`: this represents
its general purpose, as an internal string buffer class. The name also
is an homage to Junio Hamano ("gitstr").
The public API remains `git_buf`, and has a much smaller footprint. It
is generally only used as an "out" param with strict requirements that
follow the documentation. (Exceptions exist for some legacy APIs to
avoid breaking callers unnecessarily.)
Utility functions exist to convert a user-specified `git_buf` to a
`git_str` so that we can call internal functions, then converting it
back again.
|
|
|
5346be3d
|
2021-09-23T21:16:36
|
|
docs: document `git_buf`
We have been inconsistent about the way that we handle `git_buf`s
provided by users. _Usually_ we require that it has been properly
initialized with `GIT_BUF_INIT`, but _sometimes_ we simply overwrite
the data in it regardless. And even more rarely, we will grow a
user-provided buffer and concatenate data onto it (see
`git_diff_format_email`).
Document the path forward for `git_buf`, which is that we always
require that the buffer is intitialized with `GIT_BUF_INIT`.
`git_diff_format_email` will be kept backward compatible but users
are encouraged to switch to the new `git_email` APIs.
|
|
|
66ffac25
|
2021-10-17T09:25:47
|
|
Merge pull request #6082 from libgit2/ethomson/oid
hash: separate hashes and git_oid
|
|
|
b5a7af28
|
2021-10-13T21:53:27
|
|
Merge pull request #6092 from libgit2/ethomson/diff_rename_limit
|
|
|
1738f732
|
2021-10-13T11:36:07
|
|
diff: document updated rename limit
|
|
|
d174381c
|
2021-10-13T11:34:56
|
|
diff: make the default rename_limit 1000
git's default rename limit is 1000, ours should match.
|
|
|
f0a09160
|
2021-10-02T13:50:12
|
|
fuzzers: use updated hash functions
|
|
|
923364c5
|
2021-09-30T08:40:29
|
|
futils: use a particular hash not a git_oid
In `git_futils_readbuffer_updated`, always take a particular hash
instead of a `git_oid`. This lets us change the checksum algorithm
independently of `git_oid` usage.
|
|
|
31ecaca2
|
2021-09-30T08:11:40
|
|
hash: hash functions operate on byte arrays not git_oids
Separate the concerns of the hash functions from the git_oid functions.
The git_oid structure will need to understand either SHA1 or SHA256; the
hash functions should only deal with the appropriate one of these.
|
|
|
2a713da1
|
2021-09-29T21:31:17
|
|
hash: accept the algorithm in inputs
|
|
|
3fff5970
|
2021-09-29T21:02:38
|
|
hash: don't abbreviate algorithm
|
|
|
b7bad55e
|
2021-09-27T16:09:50
|
|
v1.3: very very last-minute changelog updates
|
|
|
424812e3
|
2021-09-27T11:23:44
|
|
Merge pull request #6071 from 257/examples
examples: Free the git_config and git_config_entry after use
|
|
|
13f1270a
|
2021-09-27T08:58:28
|
|
v1.3: changelog updates for last-minute changes
|
|
|
8c29885e
|
2021-09-27T08:57:03
|
|
Merge pull request #6076 from libgit2/ethomson/oidarray_dispose
oidarray: introduce `git_oidarray_dispose`
|
|
|
b6449de3
|
2021-09-27T08:39:55
|
|
Merge pull request #6075 from libgit2/ethomson/attr_longpaths
|
|
|
853ba203
|
2021-09-27T08:39:39
|
|
Merge pull request #6073 from libgit2/ethomson/attr_lookups
|
|
|
a6f6a9f4
|
2021-09-26T22:09:37
|
|
Merge pull request #6077 from libgit2/ethomson/strarray
buf: common_prefix takes a string array
|
|
|
7e7cfe8a
|
2021-09-26T20:20:03
|
|
buf: common_prefix takes a string array
`git_strarray` is a public-facing type. Change
`git_buf_text_common_prefix` to not use it, and just take an array of
strings instead.
|
|
|
0bd132ab
|
2021-09-26T17:58:08
|
|
oidarray: introduce `git_oidarray_dispose`
Since users are disposing the _contents_ of the oidarray, not freeing
the oidarray itself, the proper cleanup function is
`git_oidarray_dispose`. Deprecate `git_oidarray_free`.
|
|
|
46508fe6
|
2021-09-26T11:28:47
|
|
attr_file: don't take the `repo` as an arg
The `repo` argument is now unnecessary. Remove it.
|
|
|
f5a9f0a2
|
2021-09-25T15:19:22
|
|
attr_file: don't validate workdir paths in attr lookups
When looking up attributes for a file, we construct an absolute path
to the queried file within the working directory so that we can accept
both absolute paths and working directory relative paths. We then trim
the leading working directory path to give us an in-repo path.
Since we only want the in-repo path to look up attributes - and not to
read it from disk - we don't need to validate its length.
|
|
|
091bd738
|
2021-09-24T17:00:43
|
|
attr: ensure lookups are on repo-relative paths
Attribute lookups are done on paths relative to the repository. Fail if
erroneously presented with an absolute path.
|
|
|
3d8749d3
|
2021-09-24T16:07:17
|
|
checkout: always provide a path for attribute lookup
Always pass a working-directory relative path to attribute lookups
during checkout.
|
|
|
848bd009
|
2021-09-24T16:05:23
|
|
blob: improve `create_from_disk` attribute lookups
Resolve absolute paths to be working directory relative when looking up
attributes. Importantly, now we will _never_ pass an absolute path down
to attribute lookup functions.
|
|
|
0f4256b8
|
2021-09-24T15:23:34
|
|
repository: improve `hashfile` for absolute paths
When `git_repository_hashfile` is handed an absolute path, it determines
whether the path is within the repository's working directory or not.
This is necessary when there is no `as_path` specified.
If the path is within the working directory, then the given path should
be used for attribute lookups (it is the effective `as_path`). If it is
not within the working directory, then it is _not_ eligible.
Importantly, now we will _never_ pass an absolute path down to attribute
lookup functions.
|
|
|
d6c7ca3e
|
2021-09-25T14:36:25
|
|
win32: posixify the output of p_getcwd
Make p_getcwd match the rest of our win32 path handling semantics.
(This is currently only used in tests, which is why this disparity went
unnoticed.)
|