kmx git

Commit	Date	Message
2a1adf71	2019-08-05T23:52:16	Fixed bug 4747 - [Patch] SDL_ShowMessageBox ignores BUTTON_RETURNKEY_DEFAULT flag Caleb Cornett SDL_ShowMessageBox on UIKit doesn't do anything special with buttons that are marked with the flag SDL_MESSAGEBOX_BUTTON_RETURNKEY_DEFAULT. According to Apple's documentation on UIAlertController, a button can respond to a return key if it's marked as the preferredAction of the controller. SDL doesn't set a preferredAction currently, so I've attached a patch to fix that.
afdb40af	2019-08-05T23:38:48	Fixed bug 4689 - SDL fails to detect compositor shutdown on Wayland -- program keeps running M Stoeckl To reproduce: 1. Run any SDL-based program with a Wayland compositor, orphaning it so that it doesn't have an immediate parent process. (For example, from a terminal, running `supertux2 & disown`.) The program should use the wayland backend, i.e. by setting environment variable SDL_VIDEODRIVER=wayland. 2. Kill the compositor process. Results: - The SDL program will keep running. Expected results: - The SDL program should close. (What close should mean here, I'm not sure - is injecting an SDL_Quit the appropriate action when a video driver disconnects?) Build data: 2019-06-22, hg tip (12901:bf8d9d29cbf1), Linux, can reproduce with sway, weston, and other Wayland oompositors.
aebaa316	2019-08-05T12:35:32	Add public APIs for creating a Metal view attached to an SDL window. Add SDL_metal.h.
f3683d3a	2019-08-04T23:30:55	macOS: fix a typo in touch handling code.
109cbd6e	2019-08-04T16:56:40	Fix touch-related compile errors on Linux.
aa09e612	2019-08-04T00:01:38	Port libusb hid.c to SDL, add to MinGW configure
2fb71ac5	2019-08-04T00:34:23	Implement touch window IDs on x11/xinput2.
63197c43	2019-08-02T17:19:50	Fix bug where the wrong button was the default in the old message box because buttons were added backwards, breaking the indexing used by GetButtonIndex. Add messagebox flags to explicilty request left-to-right button order or right-to-left. If neither is specified it'll be some platform default.
d52ffcf9	2019-08-02T17:12:49	Added support for a few controllers on Android
d5ec735a	2019-08-01T18:22:12	Add a windowID field to SDL_TouchFingerEvent (bug #4331). This is unimplemented on some platforms and will cause compile errors when building those platform backends for now.
c37c6cbb	2019-07-31T23:37:02	use WIN_IsWindowsVistaOrGreater() from core/windows for isVistaOrNewer
c10a8742	2019-07-31T10:20:37	Make sure HIDAPI is initialized whenever we call HIDAPI_IsDevicePresent()
1b7fc81e	2019-07-31T19:40:50	minor whitespace tidy-up.
f7d82e56	2019-07-31T12:20:55	hidapi: Add SDL_hidapi.c, allows support for multiple hidapi backends. This is currently supported on Linux and macOS. iOS and Android are not supported at all, Windows support could be added with some changes to the libusb backend. The Visual Studio and Xcode projects do not use this feature. Based on Valve Software's hid.cpp, written in collaboration with Andrew Eikum.
c172f36b	2019-07-31T11:14:48	joystick: Ensure HIDAPI is initialized before calling it
f8400cbb	2019-07-31T09:11:20	Fixed bug 4692 - Command line parsing Galadrim As I have seen, SDL implements its own command line parser for Windows in SDL_windows_main.c. Unfortunately, it doesn't seem to allow command line arguments with trailing backslashes if quoting is required. Usually, when you write an application that gets command line arguments passed as argc and argv, the parsing is done by parse_cmdline. The Windows API also provides the function CommandLineToArgvW, so an application can parse itself if only the command line string is provided. Both functions behave almost identically according to their documentation. If the argument "\\" (including the quotes) is passed, they both turn it into a single backslash. The SDL command line parser on the other hand doesn't recognize the second quote character as the closing character in this example and therefore includes it in the parsed argument. The parser does not count the number of backslashes preceding a quote. It always treats a quote as escaped if a backslash is in front of it. Therefore, it should be impossible to quote and escape an argument correctly, if it has a trailing backslash and contains characters that require quoting. Of course, each application is allowed to implement its own parsing rules, so SDL is free to do so. But the problem I see is that there are arguments, that are impossible to be passed to the parser correctly, as I described above. Is there a reason, why SDL does not simply use CommandLineToArgvW instead of implementing its own parser? Here are some links that show that correct argument parsing, as it is usually done in Windows, is quite complicated: https://docs.microsoft.com/en-us/windows/desktop/api/shellapi/nf-shellapi-commandlinetoargvw http://www.windowsinspired.com/how-a-windows-programs-splits-its-command-line-into-individual-arguments/
4953e050	2019-07-31T05:11:40	use SDL_zeroa at more places where the argument is an array.
7a47c292	2019-07-31T01:22:02	Fix bug 4746 - introduce SDL_zeroa macro.
f96d7cc0	2019-07-31T01:19:26	minor build fix.
fdc67c3c	2019-07-31T00:10:00	MS_ADPCM_Decode: fix assigning an array to a pointer (lose '&').
2ea0ec62	2019-07-31T00:07:15	better readability..
5f04ed5f	2019-07-31T00:06:50	SDL_iconv_string: add (char*) casts before SDL_malloc() calls.
ceee7def	2019-07-31T00:05:28	minor build fixes.
97fefd05	2019-07-30T11:00:00	Fixed bug 4538 - validate image size when loading BMP files
31cb854f	2019-07-30T10:04:46	Fixed bug 4745 - 2.0.10 fails to build against macOS 10.11 SDK Joshua Root NSEventSubtypeMouseEvent was added in 10.12, so it needs to be defined on 10.11 as well
18bcafff	2019-07-27T20:21:42	Fixed bug 4739 - Android: loading native libs, generated by bundletool (Thanks akk0rd87)
dc714389	2019-07-25T15:21:44	Don't call hid_enumerate() if the HIDAPI drivers are all disabled
738dff4b	2019-07-25T08:05:13	hidapi: Update repository URLs Upstream hidapi has been re-homed. Update the repo URLs to help guide folks where to contribute fixes.
0e9560ae	2019-07-23T14:41:00	hidapi: Zero out new hid_device_info structs
e954e32b	2019-07-18T19:33:17	Fixed bug 4726 - Fix for tvOS GetPrefPath Caleb Cornett Unlike iOS and macOS, tvOS does not have any persistent local storage. In fact, the ApplicationSupport directory pointed to by the existing Cocoa GetPrefPath() throws an error whenever any attempt is made to access it. To get any local storage on an Apple TV, our only option is to use a temporary cache directory. This patch changes the tvOS PrefPath to this cache directory and also logs a critical warning that this if developers want their save data to persist across game sessions, they must use some form of iCloud storage.
bf9bf602	2019-07-17T23:20:57	Copypaste SDL_NSLog to UIKit backend, document it as such
52e62329	2019-07-17T16:47:19	Fixed build error
a06d8cd0	2019-07-17T16:47:17	Merged latest changes from Steam into controller_type.h
1dc24160	2019-07-17T16:47:13	Add linked list of opened HID devices to prevent accessing already freed devices in device removal callback that is sometimes called even after being unregistered
89de2512	2019-07-17T13:01:44	Added support for the Victrix Pro Fight Stick for PS4
e7c2cf10	2019-07-15T09:36:53	Fixed bug 4704 - SDL_HINT_ANDROID_SEPERATE_MOUSE_AND_TOUCH on Windows? superfury I notice that, somehow, when locking the mouse into place(using SDL_SetRelativeMouseMode), somehow at least the movement information gets through to both mouse movement and touch movement events? My app handles both, so when moving a touched finger accross the app(using RDP from an Android device) I see the mouse moving inside the app when it shouldn't(meaning that the touch movement is ignored properly by the app(press-location dependant) but the mouse movement is still performed due to the mouse movement events)?
064d1223	2019-07-14T16:59:39	Fixed bug 4723 - Generic Xbox pad controller bindings seem odd/broken alexrice999 I have a knock off wired xbox 360 controller called afterglow for xbox 360 controller. Despite there being a few afterglow controllers in the controller mapping the guid of my controller seems to map to Generic Xbox pad. This binding is as follows: ``` "030000006f0e00001304000000010000,Generic X-Box pad,a:b0,b:b1,back:b6,dpdown:h0.4,dpleft:h0.8,dpright:h0.2,dpup:h0.1,guide:b8,leftshoulder:b4,leftstick:a0,lefttrigger:a2,leftx:a0,lefty:a1,rightshoulder:b5,rightstick:a3,righttrigger:a5,rightx:a3,righty:a4,start:b7,x:b2,y:b3,", ``` When running openmw I have a strange issue that the joysticks work for up and down movements but not for side to side. I managed to track this down to the side to side events being classified as joystick events instead of gamepad events. I believe this is due to both "leftstick" and "leftx" being bound to "a0" which seems odd to me. If I change openmw's mappings to remove these the controller works as expected. I was hoping someone who knows a lot more than me (as I have only been exploring this today trying to fix my controller) would know what is happening
6a7161dc	2019-07-14T16:48:31	Blacklist Corsair device causing hang
8fb8adfc	2019-07-13T17:04:02	macOS: Fix SDL_GL_CreateContext/MakeCurrent on non-main threads causing a Main Thread Checker warning when built with Xcode 11 / the macOS 10.15 SDK. Fixes bug #4714.
73536d93	2019-07-12T21:28:43	ios: Fixed MFi guide button not being detected (thanks, Caleb!). Fixes Bugzilla #4721.
27ad8e5d	2019-07-11T01:07:14	cocoa: Set keyboard mod state correctly when turning off capslock. Fixes Bugzilla #4716.
86965eec	2019-07-10T10:06:28	x11: prevent a synthetic mouse event when using a touchscreen With multitouch, register to receive XI_Motion (which desctivates MotionNotify), so that we can distinguish real mouse motions from synthetic one. (bug 4690)
6ef01e52	2019-07-09T17:28:02	x11: set some modality things on message boxes with parent windows.
66252035	2019-07-09T11:46:42	SDL_Mouse/Touch: discard synthetic events when hints are not set. Those are generated/flagged by platform layer.
e841b066	2019-07-08T13:41:01	cocoa: Another attempt at mouse vs touch support. This time, we make anything we think is a MacBook trackpad report its touches as SDL_MOUSE_TOUCHID, even though they're not _actually_ synthesized events, and let all mouse input--even if the OS synthesized it from a multitouch trackpad on our behalf--look like physical input. This is backwards from reality, but produces the results most apps will expect. Note that if you have a real touch device that doesn't appear to be the trackpad, it'll produce real touch events with unique device ids, so it's not a total loss here, but also note that the way we decide if it was the trackpad is an imperfect heuristic; it happens to work out right now, but it's not impossible that a real touchscreen could come to the Mac at some point and (incorrectly?) call it a "mouse" input, etc. But for now, good enough. Fixes Bugzilla #4690.
7e09718d	2019-07-07T11:23:16	Ignore synthetic mouse events generated for touchscreens Windows generates fake raw mouse events for touchscreens for compatibility with legacy apps that predate touch support in Windows. We already handle touch events explicitly, so drop the synthetic events to avoid duplicates.
680e7937	2019-07-07T09:10:56	Fixed bug 4710 - audio/alsa: avoid configuring hardware parameters with only a single period Anthony Pesch The previous code first configured the period size using snd_pcm_hw_par- ams_set_period_size_near. Then, it further narrowed the configuration space by calling snd_pcm_hw_params_set_buffer_size_near using a buffer size of 2 times the _requested_ period size in order to try and get a configuration with only 2 periods. If the configured period size was larger than the requested size, the second call could inadvertently narrow the configuration space to contain only a single period. Rather than fixing the call to snd_pcm_hw_params_set_buffer_size_near to use a size of 2 times the configured period size, the code has been changed to use snd_pcm_hw_params_set_periods_min in order to more clearly explain the intent.
67bb882e	2019-07-03T15:57:55	Fixed bug 4707 - SDL_SetRelativeMouseMode fails on Vivante Cameron Gutman The bugfix in https://hg.libsdl.org/SDL/rev/ca9417a52f18 caused SDL_SetRelativeMouseMode() to begin failing on Vivante (Steam Link). Even though Vivante doesn't have a SetRelativeMouseMode() or WarpMouse() function, it's in relative mode already (because it uses evdev) so the function was actually working as intended. I think providing a no-op SetRelativeMouseMode() function for Vivante is a reasonable fix. Since it's already getting relative events through evdev, it really is a no-op to "enter relative mode". In fact, this is probably the right thing to do for all backends that use evdev (vivante, raspberry, and kmsdrm). Raspberry and kmsdrm both have WarpMouse() implementations so SDL_SetRelativeMouseMode() isn't failing there, but it still seems to make sense not to have to do the fake warping if they're evdev-based anyway.
b46c7719	2019-07-02T16:49:35	raspberry: Actually commit the whole patch. :) (Thanks, Joe!) Fixes Bugzilla #4699.
d2d06f44	2019-07-02T12:29:36	cocoa: Don't report trackpad mouse events as synthesized touches. Fixes Bugzilla #4690, sort of. I guess.
d2058b45	2019-07-02T10:26:54	raspberry: Fixed missing mouse cursor (thanks, Joe!) "Starting with changeset 12433, the mouse cursor is not displayed on the Raspberry Pi platform, due to a bug in the handling of the new "global_cursor" in RPI_ShowCursor(). Currently, if cursor == global_cursor, the function immediately returns 0. The function should not return here. Instead, if cursor == global_cursor, it shouldn't try to hide the current cursor and update global_cursor = cursor. However, it should still continue through the rest of the function." Fixes Bugzilla #4699.
d5ebbcb4	2019-07-02T09:43:26	dbus: Don't SimulateUserActivity if we're already inhibiting the screensaver.
94658099	2019-07-02T09:38:31	dbus: Add org.freedesktop.ScreenSaver.SimulateUserActivity support.
027887da	2019-07-01T14:52:56	iOS: Fix the window size not being set properly when Split View is used on an iPad (bug #4586).
959cfc42	2019-06-30T23:58:31	Fixed memory barrier macro check so it isn't quite so fragile
a8bea858	2019-06-30T23:55:28	Limit the compile error to the case where we actually define the memory barrier macro as the function
cc47810d	2019-06-30T23:26:16	Fixed bug 4683 - SDL_atomic infinite recursion on armv6/armv5 w/ thumb The real problem is that SDL_atomic.c was built in thumb mode instead of ARM mode, which is required to use the mcr instruction on ARM platforms. Added a compiler error to catch this case so we don't generate code that does infinite recursion. I also added a potentially better way to handle things on Linux ARM platforms, based on comments in the Chromium headers, which we can try out after 2.0.10 ships.
797d2c59	2019-06-30T22:48:13	Fixed bug 4436 - [OpenBSD] fix D-pad daniel.c.sinclair Hi, this patch breaks dpad/hat input on my PS4 controller. The attached patch restores functionality. Calling SDL_PrivateJoystickHat() at the end of BSD_JoystickUpdate was setting the hat state to zero on every kind of input, instead of just the HUG_DPAD events.
22a2decf	2019-06-28T16:38:42	Android: concurrency issues, make sure Activity is in running State when calling functions like SDL_CreateWindow, SDL_CreateRenderer, Android_GLES_CreateContext Bugs 4694, 4681, 4142
cfed0b77	2019-06-28T16:14:50	Add an "error" label in SDL_CreateRenderer (no op)
aa45af7f	2019-06-28T16:05:20	Android: explicitly expand Android_GLES_MakeCurrent/Android_GLES_CreateContext from SDL_egl_c.h
57e08c27	2019-06-26T13:21:43	cocoa: Check for capslock in -[NSResponder flagsChanged], not with IOKit. Using IOKit for this pops up a warning at startup on macOS 10.15 ("Catalina"), asking the user to authorize the app to listen to all keyboard input in the system, which is unacceptable. I _think_ we were using IOKit under incorrect presumptions here; the Stack Overflow link mentioned in it was complaining about not being able to use flagsChanged to differentiate between left and right mod keys, but that's not an issue for capslock. It's also possible this code was trying to deal with capslock changing when the window didn't have focus, but we handle this elsewhere now, if we didn't at the time.
0beadea5	2019-06-26T01:29:01	windows: Call GetWindowText() with the correct parameters (thanks, Zebediah!) GetWindowText() wants you to tell it the size of the buffer--including the terminating NULL char--but we weren't counting that last char, losing the last char of the string in the process. This was only seen with the special case of SDL_CreateWindowFrom() to use an existing native window, not the usual SDL_CreateWindow() codepath. Fixes Bugzilla #4696.
a4bfe2a4	2019-06-24T21:08:26	Allow hotplugging joysticks without udev
ccba8d46	2019-06-24T18:08:11	Android: export Lock/Unlock activity API
31bb95f1	2019-06-21T15:07:39	direct3d: Use D3DPOOL_DEFAULT for vertex buffers after all, release correctly. Fixes Bugzilla #4679. Fixes Bugzilla #4537.
e681623c	2019-06-20T19:51:00	direct3d: Fix dirty textures failing to update Even if the texture itself has not changed since last time, the data may have so we must call UpdateDirtyTexture() to handle that possibility.
f3226457	2019-06-19T17:11:20	Fixed bug 4672 - Warnings in SDL_LogEvent()
be6cda9f	2019-06-19T15:54:21	Rolling back GameCube HIDAPI support It causes the HIDAPI devices to always be opened on enumeration, which causes crashes in the Windows drivers when multiple applications are reading and writing at the same time. We can revisit this after 2.0.10 release.
56e2b9a4	2019-06-19T06:43:54	Handle GameCube WaveBird controller differences Make wireless GameCube controllers use unknown power level instead of wired and don't allow rumble (it doesn't have hardware for it).
6f63c1c3	2019-06-19T06:43:36	Make GameCube controllers only rumble if both USB cables are connected The Nintendo USB GameCube Adapter has two USB connectors. Black for data and grey for additional power for rumble. The Wii U and other software require both cables to use rumble. The rumble is weaker without the second USB cable. Other than that I don't know if there is any negative side affects from using rumble with only one cable.
b23cce28	2019-06-19T06:43:04	Fix GameCube controller power level being reset to unknown HIDAPI_DriverGameCube_OpenJoystick() set power level to wired and then it was set to unknown in SDL_JoystickOpen().
bd952900	2019-06-19T06:40:50	Use SDL C runtime functions
faed7f83	2019-06-19T10:11:38	KMSDRM: fix inverted strcmp, remove useless if test (Bug 4624)
5998c513	2019-06-19T09:16:53	KMSDRM: fix compilation on linux, no d_namlen (Bug 4624)
d0fa93d6	2019-06-19T00:52:34	wayland: Fixed C99-style variable declaration inside for-loop.
7162649f	2019-06-18T18:58:39	opengl: Be more robust in failing cases. Load all possible symbols, not just until one fails, in case they get used during shutdown, etc. Fixes Bugzilla #4093.
8ab907ba	2019-06-18T14:24:26	Only warp the mouse to set focus if we're definitely going into relative mode
14e8b93e	2019-06-18T14:24:24	Fixed compiler warning
99abcbb2	2019-06-18T14:15:10	Fixed bug 4624 - KMS/DRM fails on FreeBSD because /dev/dri/card* nodes are symlinks Jan Martin Mikkelsen Patch to scan /dev/dri based on names rather than file type Loading KMS/DRM on FreeBSD fails because the "available" code in the driver checks for character device nodes under /dev/dri and the /dev/dri/card* files are symlinks rather than device nodes nodes on FreeBSD. The symlink points to /dev/drm/0. The attached patch counts /dev/dri/card* entries rather than directory entries which are character devices.
d3bedda4	2019-06-18T16:53:49	cocoa: Patched to compile and also handle possible malloc failure.
3e720d2a	2019-06-18T13:41:38	Fixed potential double-free in mouse cleanup code
5dcac4cc	2019-06-18T10:08:19	Fixed 4669 - Using the software SDL_Renderer on Android leads to GL errors & black screen when window resizes Sylvain I think what happening with the software renderer is: * you're somehow in background (so texture creation is not possible) * it resizes and wants to push a SDL_WINDOWEVENT_SIZE_CHANGED It call: https://hg.libsdl.org/SDL/file/a010811d40dd/src/render/SDL_render.c#l683 * GetOutputSize * SW_GetOutputSize * SW_ActivateRenderer * SDL_GetWindowSurface * SDL_CreateWindowFramebuffer which is mapped to SDL_CreateWindowTexture and it ends up re-creating the surface/a texture, while being in background
e96d4760	2019-06-18T18:53:58	Android: resize with software rendering, reverted again (Bug 4669)
12b92260	2019-06-18T18:40:40	Android: try to fix resize with software rendering (bug 4669)
8a20d40d	2019-06-18T18:22:18	Android: revert commit SW_GetOutputSize, again (Bug 4669)
98cc7589	2019-06-18T10:41:11	Android: prevent using SW_GetOutputSize with software renderer (Bug 4669)
a55c0e14	2019-06-18T10:23:19	Android: revert previous commit (Bug 4669) (Refs #1)
f2157b6c	2019-06-17T22:31:36	Fixed bug 4669: Android software renderer, black screen when window resizes Using the software SDL_Renderer on Android leads to GL errors & black screen when window resizes
6c4765a1	2019-06-17T11:10:20	Removed extraneous fprintf() call
67c67f3a	2019-06-17T10:13:28	Updated version to 2.0.10
93a5e4ce	2019-06-17T08:38:33	Fixed bug 4667 - Build errors on Linux when building without Threads support Manuel Sabogal There is an issue on the latest commit of the mercurial repo when SDL_THREADS_DISABLED is set: src/core/linux/SDL_threadprio.c:79:28: error: unknown type name 'Sint64'; did you mean 'int'
9306ef9b	2019-06-16T14:10:30	Fix synthetically generated mouse events getting lost forever after the device orientation changes (or the window is otherwise resized) while a finger is touching the screen.
f4625f52	2019-06-16T13:52:27	iOS: remove some code which could affect the state of UIViews that aren't owned by SDL. It was originally added to work around an input event problem in the code of a specific app which mixed SDL and native UIViews, but that app solved its problems in a better manner since then.
fffa791f	2019-06-14T22:29:13	assert: Another attempt to quiet compiler warnings.
59e510b0	2019-06-14T21:39:51	assert: Possibly fixing compiler warning on Android.
ed8b78d3	2019-06-14T21:18:53	cocoa: ignore compiler warnings about OpenGL being deprecated.
90e2dc98	2019-06-14T18:23:51	A few minor changes to placate static analysis.
4eb3c0c3	2019-06-14T13:56:52	Added support for Xbox and PS4 wireless controllers on iOS and tvOS Also implemented SDL_JoystickGetDevicePlayerIndex() on iOS and tvOS, and added support for reading the new menu button state available in iOS and tvOS 13.
1213fe79	2019-06-14T13:56:42	Worked around "Undefined symbol: ___isPlatformVersionAtLeast()" link error on Xcode 11 beta

2a1adf71

2019-08-05T23:52:16

Fixed bug 4747 - [Patch] SDL_ShowMessageBox ignores BUTTON_RETURNKEY_DEFAULT flag Caleb Cornett SDL_ShowMessageBox on UIKit doesn't do anything special with buttons that are marked with the flag SDL_MESSAGEBOX_BUTTON_RETURNKEY_DEFAULT. According to Apple's documentation on UIAlertController, a button can respond to a return key if it's marked as the preferredAction of the controller. SDL doesn't set a preferredAction currently, so I've attached a patch to fix that.

afdb40af

2019-08-05T23:38:48

Fixed bug 4689 - SDL fails to detect compositor shutdown on Wayland -- program keeps running M Stoeckl To reproduce: 1. Run any SDL-based program with a Wayland compositor, orphaning it so that it doesn't have an immediate parent process. (For example, from a terminal, running `supertux2 & disown`.) The program should use the wayland backend, i.e. by setting environment variable SDL_VIDEODRIVER=wayland. 2. Kill the compositor process. Results: - The SDL program will keep running. Expected results: - The SDL program should close. (What close should mean here, I'm not sure - is injecting an SDL_Quit the appropriate action when a video driver disconnects?) Build data: 2019-06-22, hg tip (12901:bf8d9d29cbf1), Linux, can reproduce with sway, weston, and other Wayland oompositors.

aebaa316

2019-08-05T12:35:32

Add public APIs for creating a Metal view attached to an SDL window. Add SDL_metal.h.

f3683d3a

2019-08-04T23:30:55

macOS: fix a typo in touch handling code.

109cbd6e

2019-08-04T16:56:40

Fix touch-related compile errors on Linux.

aa09e612

2019-08-04T00:01:38

Port libusb hid.c to SDL, add to MinGW configure

2fb71ac5

2019-08-04T00:34:23

Implement touch window IDs on x11/xinput2.

63197c43

2019-08-02T17:19:50

Fix bug where the wrong button was the default in the old message box because buttons were added backwards, breaking the indexing used by GetButtonIndex. Add messagebox flags to explicilty request left-to-right button order or right-to-left. If neither is specified it'll be some platform default.

d52ffcf9

2019-08-02T17:12:49

Added support for a few controllers on Android

d5ec735a

2019-08-01T18:22:12

Add a windowID field to SDL_TouchFingerEvent (bug #4331). This is unimplemented on some platforms and will cause compile errors when building those platform backends for now.

c37c6cbb

2019-07-31T23:37:02

use WIN_IsWindowsVistaOrGreater() from core/windows for isVistaOrNewer

c10a8742

2019-07-31T10:20:37

Make sure HIDAPI is initialized whenever we call HIDAPI_IsDevicePresent()

1b7fc81e

2019-07-31T19:40:50

minor whitespace tidy-up.

f7d82e56

2019-07-31T12:20:55

hidapi: Add SDL_hidapi.c, allows support for multiple hidapi backends. This is currently supported on Linux and macOS. iOS and Android are not supported at all, Windows support could be added with some changes to the libusb backend. The Visual Studio and Xcode projects do not use this feature. Based on Valve Software's hid.cpp, written in collaboration with Andrew Eikum.

c172f36b

2019-07-31T11:14:48

joystick: Ensure HIDAPI is initialized before calling it

f8400cbb

2019-07-31T09:11:20

Fixed bug 4692 - Command line parsing Galadrim As I have seen, SDL implements its own command line parser for Windows in SDL_windows_main.c. Unfortunately, it doesn't seem to allow command line arguments with trailing backslashes if quoting is required. Usually, when you write an application that gets command line arguments passed as argc and argv, the parsing is done by parse_cmdline. The Windows API also provides the function CommandLineToArgvW, so an application can parse itself if only the command line string is provided. Both functions behave almost identically according to their documentation. If the argument "\\" (including the quotes) is passed, they both turn it into a single backslash. The SDL command line parser on the other hand doesn't recognize the second quote character as the closing character in this example and therefore includes it in the parsed argument. The parser does not count the number of backslashes preceding a quote. It always treats a quote as escaped if a backslash is in front of it. Therefore, it should be impossible to quote and escape an argument correctly, if it has a trailing backslash and contains characters that require quoting. Of course, each application is allowed to implement its own parsing rules, so SDL is free to do so. But the problem I see is that there are arguments, that are impossible to be passed to the parser correctly, as I described above. Is there a reason, why SDL does not simply use CommandLineToArgvW instead of implementing its own parser? Here are some links that show that correct argument parsing, as it is usually done in Windows, is quite complicated: https://docs.microsoft.com/en-us/windows/desktop/api/shellapi/nf-shellapi-commandlinetoargvw http://www.windowsinspired.com/how-a-windows-programs-splits-its-command-line-into-individual-arguments/

4953e050

2019-07-31T05:11:40

use SDL_zeroa at more places where the argument is an array.

7a47c292

2019-07-31T01:22:02

Fix bug 4746 - introduce SDL_zeroa macro.

f96d7cc0

2019-07-31T01:19:26

minor build fix.

fdc67c3c

2019-07-31T00:10:00

MS_ADPCM_Decode: fix assigning an array to a pointer (lose '&').

2ea0ec62

2019-07-31T00:07:15

better readability..

5f04ed5f

2019-07-31T00:06:50

SDL_iconv_string: add (char*) casts before SDL_malloc() calls.

ceee7def

2019-07-31T00:05:28

minor build fixes.

97fefd05

2019-07-30T11:00:00

Fixed bug 4538 - validate image size when loading BMP files

31cb854f

2019-07-30T10:04:46

Fixed bug 4745 - 2.0.10 fails to build against macOS 10.11 SDK Joshua Root NSEventSubtypeMouseEvent was added in 10.12, so it needs to be defined on 10.11 as well

18bcafff

2019-07-27T20:21:42

Fixed bug 4739 - Android: loading native libs, generated by bundletool (Thanks akk0rd87)

dc714389

2019-07-25T15:21:44

Don't call hid_enumerate() if the HIDAPI drivers are all disabled

738dff4b

2019-07-25T08:05:13

hidapi: Update repository URLs Upstream hidapi has been re-homed. Update the repo URLs to help guide folks where to contribute fixes.

0e9560ae

2019-07-23T14:41:00

hidapi: Zero out new hid_device_info structs

e954e32b

2019-07-18T19:33:17

Fixed bug 4726 - Fix for tvOS GetPrefPath Caleb Cornett Unlike iOS and macOS, tvOS does not have any persistent local storage. In fact, the ApplicationSupport directory pointed to by the existing Cocoa GetPrefPath() throws an error whenever any attempt is made to access it. To get any local storage on an Apple TV, our only option is to use a temporary cache directory. This patch changes the tvOS PrefPath to this cache directory and also logs a critical warning that this if developers want their save data to persist across game sessions, they must use some form of iCloud storage.

bf9bf602

2019-07-17T23:20:57

Copypaste SDL_NSLog to UIKit backend, document it as such

52e62329

2019-07-17T16:47:19

Fixed build error

a06d8cd0

2019-07-17T16:47:17

Merged latest changes from Steam into controller_type.h

1dc24160

2019-07-17T16:47:13

Add linked list of opened HID devices to prevent accessing already freed devices in device removal callback that is sometimes called even after being unregistered

89de2512

2019-07-17T13:01:44

Added support for the Victrix Pro Fight Stick for PS4

e7c2cf10

2019-07-15T09:36:53

Fixed bug 4704 - SDL_HINT_ANDROID_SEPERATE_MOUSE_AND_TOUCH on Windows? superfury I notice that, somehow, when locking the mouse into place(using SDL_SetRelativeMouseMode), somehow at least the movement information gets through to both mouse movement and touch movement events? My app handles both, so when moving a touched finger accross the app(using RDP from an Android device) I see the mouse moving inside the app when it shouldn't(meaning that the touch movement is ignored properly by the app(press-location dependant) but the mouse movement is still performed due to the mouse movement events)?

064d1223

2019-07-14T16:59:39

Fixed bug 4723 - Generic Xbox pad controller bindings seem odd/broken alexrice999 I have a knock off wired xbox 360 controller called afterglow for xbox 360 controller. Despite there being a few afterglow controllers in the controller mapping the guid of my controller seems to map to Generic Xbox pad. This binding is as follows: ``` "030000006f0e00001304000000010000,Generic X-Box pad,a:b0,b:b1,back:b6,dpdown:h0.4,dpleft:h0.8,dpright:h0.2,dpup:h0.1,guide:b8,leftshoulder:b4,leftstick:a0,lefttrigger:a2,leftx:a0,lefty:a1,rightshoulder:b5,rightstick:a3,righttrigger:a5,rightx:a3,righty:a4,start:b7,x:b2,y:b3,", ``` When running openmw I have a strange issue that the joysticks work for up and down movements but not for side to side. I managed to track this down to the side to side events being classified as joystick events instead of gamepad events. I believe this is due to both "leftstick" and "leftx" being bound to "a0" which seems odd to me. If I change openmw's mappings to remove these the controller works as expected. I was hoping someone who knows a lot more than me (as I have only been exploring this today trying to fix my controller) would know what is happening

6a7161dc

2019-07-14T16:48:31

Blacklist Corsair device causing hang

8fb8adfc

2019-07-13T17:04:02

macOS: Fix SDL_GL_CreateContext/MakeCurrent on non-main threads causing a Main Thread Checker warning when built with Xcode 11 / the macOS 10.15 SDK. Fixes bug #4714.

73536d93

2019-07-12T21:28:43

ios: Fixed MFi guide button not being detected (thanks, Caleb!). Fixes Bugzilla #4721.

27ad8e5d

2019-07-11T01:07:14

cocoa: Set keyboard mod state correctly when turning off capslock. Fixes Bugzilla #4716.

86965eec

2019-07-10T10:06:28

x11: prevent a synthetic mouse event when using a touchscreen With multitouch, register to receive XI_Motion (which desctivates MotionNotify), so that we can distinguish real mouse motions from synthetic one. (bug 4690)

6ef01e52

2019-07-09T17:28:02

x11: set some modality things on message boxes with parent windows.

66252035

2019-07-09T11:46:42

SDL_Mouse/Touch: discard synthetic events when hints are not set. Those are generated/flagged by platform layer.

e841b066

2019-07-08T13:41:01

cocoa: Another attempt at mouse vs touch support. This time, we make anything we think is a MacBook trackpad report its touches as SDL_MOUSE_TOUCHID, even though they're not _actually_ synthesized events, and let all mouse input--even if the OS synthesized it from a multitouch trackpad on our behalf--look like physical input. This is backwards from reality, but produces the results most apps will expect. Note that if you have a real touch device that doesn't appear to be the trackpad, it'll produce real touch events with unique device ids, so it's not a total loss here, but also note that the way we decide if it was the trackpad is an imperfect heuristic; it happens to work out right now, but it's not impossible that a real touchscreen could come to the Mac at some point and (incorrectly?) call it a "mouse" input, etc. But for now, good enough. Fixes Bugzilla #4690.

7e09718d

2019-07-07T11:23:16

Ignore synthetic mouse events generated for touchscreens Windows generates fake raw mouse events for touchscreens for compatibility with legacy apps that predate touch support in Windows. We already handle touch events explicitly, so drop the synthetic events to avoid duplicates.

680e7937

2019-07-07T09:10:56

Fixed bug 4710 - audio/alsa: avoid configuring hardware parameters with only a single period Anthony Pesch The previous code first configured the period size using snd_pcm_hw_par- ams_set_period_size_near. Then, it further narrowed the configuration space by calling snd_pcm_hw_params_set_buffer_size_near using a buffer size of 2 times the _requested_ period size in order to try and get a configuration with only 2 periods. If the configured period size was larger than the requested size, the second call could inadvertently narrow the configuration space to contain only a single period. Rather than fixing the call to snd_pcm_hw_params_set_buffer_size_near to use a size of 2 times the configured period size, the code has been changed to use snd_pcm_hw_params_set_periods_min in order to more clearly explain the intent.

67bb882e

2019-07-03T15:57:55

Fixed bug 4707 - SDL_SetRelativeMouseMode fails on Vivante Cameron Gutman The bugfix in https://hg.libsdl.org/SDL/rev/ca9417a52f18 caused SDL_SetRelativeMouseMode() to begin failing on Vivante (Steam Link). Even though Vivante doesn't have a SetRelativeMouseMode() or WarpMouse() function, it's in relative mode already (because it uses evdev) so the function was actually working as intended. I think providing a no-op SetRelativeMouseMode() function for Vivante is a reasonable fix. Since it's already getting relative events through evdev, it really is a no-op to "enter relative mode". In fact, this is probably the right thing to do for all backends that use evdev (vivante, raspberry, and kmsdrm). Raspberry and kmsdrm both have WarpMouse() implementations so SDL_SetRelativeMouseMode() isn't failing there, but it still seems to make sense not to have to do the fake warping if they're evdev-based anyway.

b46c7719

2019-07-02T16:49:35

raspberry: Actually commit the whole patch. :) (Thanks, Joe!) Fixes Bugzilla #4699.

d2d06f44

2019-07-02T12:29:36

cocoa: Don't report trackpad mouse events as synthesized touches. Fixes Bugzilla #4690, sort of. I guess.

d2058b45

2019-07-02T10:26:54

raspberry: Fixed missing mouse cursor (thanks, Joe!) "Starting with changeset 12433, the mouse cursor is not displayed on the Raspberry Pi platform, due to a bug in the handling of the new "global_cursor" in RPI_ShowCursor(). Currently, if cursor == global_cursor, the function immediately returns 0. The function should not return here. Instead, if cursor == global_cursor, it shouldn't try to hide the current cursor and update global_cursor = cursor. However, it *should* still continue through the rest of the function." Fixes Bugzilla #4699.

d5ebbcb4

2019-07-02T09:43:26

dbus: Don't SimulateUserActivity if we're already inhibiting the screensaver.

94658099

2019-07-02T09:38:31

dbus: Add org.freedesktop.ScreenSaver.SimulateUserActivity support.

027887da

2019-07-01T14:52:56

iOS: Fix the window size not being set properly when Split View is used on an iPad (bug #4586).

959cfc42

2019-06-30T23:58:31

Fixed memory barrier macro check so it isn't quite so fragile

a8bea858

2019-06-30T23:55:28

Limit the compile error to the case where we actually define the memory barrier macro as the function

cc47810d

2019-06-30T23:26:16

Fixed bug 4683 - SDL_atomic infinite recursion on armv6/armv5 w/ thumb The real problem is that SDL_atomic.c was built in thumb mode instead of ARM mode, which is required to use the mcr instruction on ARM platforms. Added a compiler error to catch this case so we don't generate code that does infinite recursion. I also added a potentially better way to handle things on Linux ARM platforms, based on comments in the Chromium headers, which we can try out after 2.0.10 ships.

797d2c59

2019-06-30T22:48:13

Fixed bug 4436 - [OpenBSD] fix D-pad daniel.c.sinclair Hi, this patch breaks dpad/hat input on my PS4 controller. The attached patch restores functionality. Calling SDL_PrivateJoystickHat() at the end of BSD_JoystickUpdate was setting the hat state to zero on every kind of input, instead of just the HUG_DPAD events.

22a2decf

2019-06-28T16:38:42

Android: concurrency issues, make sure Activity is in running State when calling functions like SDL_CreateWindow, SDL_CreateRenderer, Android_GLES_CreateContext Bugs 4694, 4681, 4142

cfed0b77

2019-06-28T16:14:50

Add an "error" label in SDL_CreateRenderer (no op)

aa45af7f

2019-06-28T16:05:20

Android: explicitly expand Android_GLES_MakeCurrent/Android_GLES_CreateContext from SDL_egl_c.h

57e08c27

2019-06-26T13:21:43

cocoa: Check for capslock in -[NSResponder flagsChanged], not with IOKit. Using IOKit for this pops up a warning at startup on macOS 10.15 ("Catalina"), asking the user to authorize the app to listen to all keyboard input in the system, which is unacceptable. I _think_ we were using IOKit under incorrect presumptions here; the Stack Overflow link mentioned in it was complaining about not being able to use flagsChanged to differentiate between left and right mod keys, but that's not an issue for capslock. It's also possible this code was trying to deal with capslock changing when the window didn't have focus, but we handle this elsewhere now, if we didn't at the time.

0beadea5

2019-06-26T01:29:01

windows: Call GetWindowText() with the correct parameters (thanks, Zebediah!) GetWindowText() wants you to tell it the size of the buffer--including the terminating NULL char--but we weren't counting that last char, losing the last char of the string in the process. This was only seen with the special case of SDL_CreateWindowFrom() to use an existing native window, not the usual SDL_CreateWindow() codepath. Fixes Bugzilla #4696.

a4bfe2a4

2019-06-24T21:08:26

Allow hotplugging joysticks without udev

ccba8d46

2019-06-24T18:08:11

Android: export Lock/Unlock activity API

31bb95f1

2019-06-21T15:07:39

direct3d: Use D3DPOOL_DEFAULT for vertex buffers after all, release correctly. Fixes Bugzilla #4679. Fixes Bugzilla #4537.

e681623c

2019-06-20T19:51:00

direct3d: Fix dirty textures failing to update Even if the texture itself has not changed since last time, the data may have so we must call UpdateDirtyTexture() to handle that possibility.

f3226457

2019-06-19T17:11:20

Fixed bug 4672 - Warnings in SDL_LogEvent()

be6cda9f

2019-06-19T15:54:21

Rolling back GameCube HIDAPI support It causes the HIDAPI devices to always be opened on enumeration, which causes crashes in the Windows drivers when multiple applications are reading and writing at the same time. We can revisit this after 2.0.10 release.

56e2b9a4

2019-06-19T06:43:54

Handle GameCube WaveBird controller differences Make wireless GameCube controllers use unknown power level instead of wired and don't allow rumble (it doesn't have hardware for it).

6f63c1c3

2019-06-19T06:43:36

Make GameCube controllers only rumble if both USB cables are connected The Nintendo USB GameCube Adapter has two USB connectors. Black for data and grey for additional power for rumble. The Wii U and other software require both cables to use rumble. The rumble is weaker without the second USB cable. Other than that I don't know if there is any negative side affects from using rumble with only one cable.

b23cce28

2019-06-19T06:43:04

Fix GameCube controller power level being reset to unknown HIDAPI_DriverGameCube_OpenJoystick() set power level to wired and then it was set to unknown in SDL_JoystickOpen().

bd952900

2019-06-19T06:40:50

Use SDL C runtime functions

faed7f83

2019-06-19T10:11:38

KMSDRM: fix inverted strcmp, remove useless if test (Bug 4624)

5998c513

2019-06-19T09:16:53

KMSDRM: fix compilation on linux, no d_namlen (Bug 4624)

d0fa93d6

2019-06-19T00:52:34

wayland: Fixed C99-style variable declaration inside for-loop.

7162649f

2019-06-18T18:58:39

opengl: Be more robust in failing cases. Load all possible symbols, not just until one fails, in case they get used during shutdown, etc. Fixes Bugzilla #4093.

8ab907ba

2019-06-18T14:24:26

Only warp the mouse to set focus if we're definitely going into relative mode

14e8b93e

2019-06-18T14:24:24

Fixed compiler warning

99abcbb2

2019-06-18T14:15:10

Fixed bug 4624 - KMS/DRM fails on FreeBSD because /dev/dri/card* nodes are symlinks Jan Martin Mikkelsen Patch to scan /dev/dri based on names rather than file type Loading KMS/DRM on FreeBSD fails because the "available" code in the driver checks for character device nodes under /dev/dri and the /dev/dri/card* files are symlinks rather than device nodes nodes on FreeBSD. The symlink points to /dev/drm/0. The attached patch counts /dev/dri/card* entries rather than directory entries which are character devices.

d3bedda4

2019-06-18T16:53:49

cocoa: Patched to compile and also handle possible malloc failure.

3e720d2a

2019-06-18T13:41:38

Fixed potential double-free in mouse cleanup code

5dcac4cc

2019-06-18T10:08:19

Fixed 4669 - Using the software SDL_Renderer on Android leads to GL errors & black screen when window resizes Sylvain I think what happening with the software renderer is: * you're somehow in background (so texture creation is not possible) * it resizes and wants to push a SDL_WINDOWEVENT_SIZE_CHANGED It call: https://hg.libsdl.org/SDL/file/a010811d40dd/src/render/SDL_render.c#l683 * GetOutputSize * SW_GetOutputSize * SW_ActivateRenderer * SDL_GetWindowSurface * SDL_CreateWindowFramebuffer which is mapped to SDL_CreateWindowTexture and it ends up re-creating the surface/a texture, while being in background

e96d4760

2019-06-18T18:53:58

Android: resize with software rendering, reverted again (Bug 4669)

12b92260

2019-06-18T18:40:40

Android: try to fix resize with software rendering (bug 4669)

8a20d40d

2019-06-18T18:22:18

Android: revert commit SW_GetOutputSize, again (Bug 4669)

98cc7589

2019-06-18T10:41:11

Android: prevent using SW_GetOutputSize with software renderer (Bug 4669)

a55c0e14

2019-06-18T10:23:19

Android: revert previous commit (Bug 4669) (Refs #1)

f2157b6c

2019-06-17T22:31:36

Fixed bug 4669: Android software renderer, black screen when window resizes Using the software SDL_Renderer on Android leads to GL errors & black screen when window resizes

6c4765a1

2019-06-17T11:10:20

Removed extraneous fprintf() call

67c67f3a

2019-06-17T10:13:28

Updated version to 2.0.10

93a5e4ce

2019-06-17T08:38:33

Fixed bug 4667 - Build errors on Linux when building without Threads support Manuel Sabogal There is an issue on the latest commit of the mercurial repo when SDL_THREADS_DISABLED is set: src/core/linux/SDL_threadprio.c:79:28: error: unknown type name 'Sint64'; did you mean 'int'

9306ef9b

2019-06-16T14:10:30

Fix synthetically generated mouse events getting lost forever after the device orientation changes (or the window is otherwise resized) while a finger is touching the screen.

f4625f52

2019-06-16T13:52:27

iOS: remove some code which could affect the state of UIViews that aren't owned by SDL. It was originally added to work around an input event problem in the code of a specific app which mixed SDL and native UIViews, but that app solved its problems in a better manner since then.

fffa791f

2019-06-14T22:29:13

assert: Another attempt to quiet compiler warnings.

59e510b0

2019-06-14T21:39:51

assert: Possibly fixing compiler warning on Android.

ed8b78d3

2019-06-14T21:18:53

cocoa: ignore compiler warnings about OpenGL being deprecated.

90e2dc98

2019-06-14T18:23:51

A few minor changes to placate static analysis.

4eb3c0c3

2019-06-14T13:56:52

Added support for Xbox and PS4 wireless controllers on iOS and tvOS Also implemented SDL_JoystickGetDevicePlayerIndex() on iOS and tvOS, and added support for reading the new menu button state available in iOS and tvOS 13.

1213fe79

2019-06-14T13:56:42

Worked around "Undefined symbol: ___isPlatformVersionAtLeast()" link error on Xcode 11 beta

kc3-lang/SDL/src

src

Log