|
7a7681cc
|
2025-09-23T16:36:43
|
|
tests: Require GL_EXT_fragment_shading_rate_primitive
Shaders can only reference the built-in gl_PrimitiveShadingRateEXT if
the extension GL_EXT_fragment_shading_rate_primitive is supported.
However, the test ShadingRateEXTTest.FragmentShadingRateBlend uses a
shader that references the built-in without checking if it's available
first.
Skip the test ShadingRateEXTTest.FragmentShadingRateBlend if the
extension GL_EXT_fragment_shading_rate_primitive is not available.
Bug: b/446958061
Test: angle_end2end_tests --gtest_filter=ShadingRateEXTTest.*
Change-Id: I11d7086a30db704c560c7446b4b7d997bb54b578
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6976660
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
94777428
|
2025-08-08T10:36:22
|
|
Shading rate should be {1,1} when enabled PER_SAMPLE
According to spec, if FETCH_PER_SAMPLE_ARM is enabled, the fragment
shading rate is set to {1,1}.
Bug: angleproject:437957110
Change-Id: I3ea6958f1aaec5f13923f62001906c7c6c71e09e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6839957
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Tingwei Guo <tingwei.guo@arm.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
69745720
|
2025-09-23T11:16:21
|
|
[WebGPU] Implement texture copy from cpu reads.
This CL implements a slow path to copying from a
texture that reads data from the CPU. This path
is taken when the src and destination formats
differ.
Bug: angleproject:438268609
Change-Id: I5a81fbed5bbac68c48537d8c7a2fcc487c31e76e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6847147
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Auto-Submit: Liza Burakova <liza@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
b4d1333d
|
2025-07-24T10:28:25
|
|
Fix the issues when blitting within same resources
Per GLES spec,when the attachments in src and dst framebuffers are
identical, angle should generate GL_INVALID_OPERATION.
But different mipmap levels of a texture, different layers of a 3D
texture or 2D array texture, and different faces of a cube map texture
do not constitute identical buffers, these are valid operations.
Bug: angleproject:433816259
Change-Id: Ie6d34819dfbc2faa4af22ec370e59c1ed4521bcb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6780168
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Auto-Submit: Xin Yuan <xin.yuan@arm.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
45521eea
|
2025-09-17T15:57:04
|
|
Fix DrawWithMismatchedComponentCountLocationSpecified test bug
The test has a bug that enabling the wrong vertex attribute. Instead of
using hard coded attribute index (1), use colorLocation instead.
Bug: angleproject:42264298
Bug: b/439073246
Change-Id: I3ae652e0ea6abe0392e6698c01af2f1c255cba26
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6962956
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
a44693f6
|
2025-09-17T14:50:37
|
|
Vulkan: Fix SPIR-V gen for invariant structs
Bug: angleproject:349994211
Change-Id: I7db05d9a6232a577a65f7a337cfd1636bce0c53b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6961859
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
44db20f2
|
2025-09-17T15:57:09
|
|
Revert "Add a "noncoherent" layout qualifier to PLS"
This reverts commit ef9c5ce43110f4f8ba56124bdee927944ce3ddd1.
Reason for revert: Causes issues on Apple silicon crbug.com/445727125
Original change's description:
> Add a "noncoherent" layout qualifier to PLS
>
> Raster ordering can be expensive. If an app knows the geometry in a draw
> does not overlap, it can mark the PLS planes as noncoherent and opt for
> using barriers instead.
>
> Bug: angleproject:40096838
> Change-Id: I2d686c2e64f51940face186637a9fcadcc251bef
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923300
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Chris Dalton <chris@rive.app>
Bug: angleproject:40096838
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ibc24bed27cec406b6e4ffa9aaa8fe3a2110b58ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6962955
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
|
|
0cc9b7be
|
2025-09-03T11:33:37
|
|
Support more YUV formats in CopyTextureCHROMIUM
Add support for formats in GL_ANGLE_yuv_internal_format as source
textures to glCopyTextureCHROMIUM. These formats are common
AHardwareBuffer formats and Chrome uses them as copy texture sources
when decoding video.
Bug: chromium:405308165
Change-Id: Ic817cce83b676ee9a517bee4fac6ef94a174961f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6908295
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
f8c8264a
|
2025-09-17T10:01:22
|
|
Support RGBX format with GL_RGBA when using glTexSubImage2D
Add an additional combination support with GL_RGBA in glTexSubImage2D
for RGBX format.
Add an end2end test.
Bug: angleproject:444335354
Change-Id: I96fc9d3543fc58c9f666bf149f78cf9049758a32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6938945
Reviewed-by: Charlie Lao <cclao@google.com>
Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
ef9c5ce4
|
2025-09-07T17:50:37
|
|
Add a "noncoherent" layout qualifier to PLS
Raster ordering can be expensive. If an app knows the geometry in a draw
does not overlap, it can mark the PLS planes as noncoherent and opt for
using barriers instead.
Bug: angleproject:40096838
Change-Id: I2d686c2e64f51940face186637a9fcadcc251bef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923300
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
|
|
16771259
|
2025-09-12T11:10:18
|
|
Update main() prototype in shader if main() has been replaced.
If the main() function definition has been wrapped/replaced in a shader
and a main() function prototype is also present, the prototype needs to
be replaced. Otherwise it will continue to reference the replaced
main() which can cause issues with shader translation steps.
Bug: angleproject:444653099
Change-Id: Ie6ce85cac89e026876a1b6e25cd294f1d8a536c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6944807
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
|
f0370a41
|
2025-09-09T19:44:57
|
|
Vulkan: Use the GENERAL layout if VK_KHR_unified_image_layouts
This lets ANGLE simplify synchronization by generally being able to use
memory barriers instead of listing image barriers separately. Although
the more specific access masks from VK_KHR_synchronization2 is possibly
necessary for some hardware to work optimally
(VK_ACCESS_2_SHADER_SAMPLED_READ_BIT in particular).
It also lets ANGLE optimize a very specific scenario. Take an image
used in the following scenario:
1. Copy to image in a transfer operation
2. Sample from image in the fragment shader of render pass 1
3. Sample from image in the vertex shader of shader pass 2
When GENERAL is not used, there's a layout transition between steps 1
and 2, changing the layout from TRANSFER_DST to
SHADER_READ_ONLY_OPTIMAL (with dst stage == fragment shader). Later, at
step 3, we need to make sure the vertex shader at least waits for this
layout transition to finish... a dependency which is not expressible in
Vulkan:
* There cannot be a dependency to step 1, because the layout transition
is not necessarily done
* There is no stage mask that signifies the end of a layout transition.
Without GENERAL, ANGLE has no choice but to issue a fragment->vertex
dependency before step 3, serializing render pass 2's vertex pass with
render pass 1's fragment pass on tilers.
When using the GENERAL layout instead, step 3 can issue a
transfer->vertex memory barrier, including using a VkEvent,
parallelizing the two render passes.
The above optimization is possible after this change, but not yet
implemented.
Bug: angleproject:422982681
Change-Id: Ieaae6f92b8b7d1e9c80c810a759c64b1e81d2dc1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6936485
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
98915e44
|
2025-09-12T14:15:05
|
|
Vulkan: Fix blit src missing mip
Bug: angleproject:433816259
Bug: angleproject:40644750
Change-Id: I50261279224dea8e37beff388207b927399d099a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6944327
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
a0cc64cd
|
2025-09-10T15:18:17
|
|
HLSL: Mark shadow sampler textureLod calls as using gradients
TextureLod calls bottom out in the HLSL SampleCmp function which does
not take a LOD parameter so we end up dropping it. This causes them to
need gradients. Mark them as using gradient so that any loop they are
used in is flagged and not unrolled by FXC.
Reverted original fix from
https://chromium-review.googlesource.com/c/angle/angle/+/6421496
because the wrong number of parameters are passed to the generated
comparison sampling function when it is changed to LOD0.
Thanks to Mikkel Simonsen at Unity and Calder Young for the tests.
Fixed: angleproject:406190894
Change-Id: Ia9255e4336099045366c02f945a3c4de8075427a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6936488
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
f27d1719
|
2025-07-29T16:41:27
|
|
Vulkan: Prefer BGR565 for RGB565 if enabled
Some platforms exhibit better performance when using BGR565 instead
of RGB565, including when loading buffer data to the image. This change
allows such platforms to use a BGR565 image in the backend instead of
an RGB565 image when using Vulkan, when the corresponding flag is
enabled: preferBGR565ToRGB565
* Updated the formats to include B5G6R5 as a fallback to R5G6B5, which
would be triggered when the corresponding feature flag is enabled.
* The only exception would be when the surface is being initialized
as R5G6B5.
* In addition, this format will not be subject to forced format
fallback.
* Added VVL skip that specifically does not allow undefined format for
border color for certain formats, including B5G6R5 if flag enabled.
* Some suites with RGB565 tests will be run with preferBGR565ToRGB565
enabled on SwS to provide better test coverage.
Bug: b/409867243
Change-Id: Ibb8c71b024ba318862f62ded8abd2d07835e8a40
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6799253
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
28f18f4c
|
2025-09-05T12:27:46
|
|
FrameCapture: Add GL_TEXTURE_CUBE_MAP_ARRAY support
Updated the CopyImageSubDataCubeMapArray e2e test with full rendering
pipeline to draw on screen using default frame buffer. Tested that
the frame capture will crash during game capture or the e2e test without
the fix.
Bug: b/419863436
Test: (enable capture sysprop) TextureCubeTestES32.CopyImageSubDataCubeMapArray/ES3_2_Vulkan
Change-Id: I7c30ed0fc7304b528020e5ab4f9b23be952c5a51
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6916781
Commit-Queue: Xiang Wang <xwxw@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
e77725a4
|
2025-09-02T12:14:55
|
|
Add VkFormat id to descriptor cache key's imageSubresourceRange
This is to fix the bug when two shaders are modifying the same
texture buffer but with different formats, the old buffer view
with "incompatible" format can be reused.
Bug: b/443105853
Change-Id: Ic3b2202a7d1d408fbbf826414bfcf2b1df4c3a15
Test: GLSLTest.TextureBufferWritesUsingDifferentFormats
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6916350
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
0042de5f
|
2025-09-08T12:04:33
|
|
Vulkan: Rename ImageAccess to ImageFormatSupport
`ImageAccess` to be used for other purposes. Variable name `access` was
also identical to variables of `CommandBufferAccess`.
Bug: angleproject:422982681
Change-Id: I69b4d2bd773f1c5ff0fb15c7b611efd1f736061d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923330
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
2207a0a2
|
2025-09-04T17:32:12
|
|
Remove multisampledRenderToTextureEXT from D3D
Partial implemented was never completed, nor utilized for XR
scenarios.
CL removes the implementation
Bug: chromium:443111620
Bug: angleproject:433462527
Bug: angleproject:42261786
Bug: angleproject:42263509
Bug: angleproject:42263677
Change-Id: If95581d5f9b0e43be96ef6913fe73f547e0b5501
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6915970
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
|
|
cfe2c8fe
|
2025-06-25T13:25:01
|
|
WGSL: RewriteMultielementSwizzle
WGSL doesn't support assignments to multi-element swizzles.
This is used in a lot of shader tests, so temporarily work around
this with an AST traverser that splits these assignments into
multiple assignments that only assign to single element
swizzles.
One special case is multiplication-by-a-matrix assignment:
vec.xy *= mat;
is converted to
vec.x = (vec.xy * mat).x;
vec.y = (vec.xy * mat).y;
Bug: angleproject:392542001
Change-Id: I3f393039aae13eb3f2c5dc5e553f68eb03b6316d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6847280
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
|
|
c1cdc2b5
|
2025-08-22T15:23:58
|
|
Transform SPIRV to use 16-bit float for lower precision uniforms
This change adds a ShCompileOption flag transformFloatUniformTo16Bits.
The flag is turned on in vulkan backends where VK_KHR_16bit_storage
extension is supported, and uniformAndStorageBuffer16BitAccess feature
is supported. When the compiler flag is turned on, in the generated
SPIRV, float data types in mediump and lowp uniforms are transformed
from 32-bit to 16-bit. The 16-bit float uniform data is converted to
32-bit with OpFConvert instruction upon loading in SPIRV, this is to
minimize the changes in OutputSPIRV.cpp. The converted variable is
decorated with RelaxedPrecision, so that SPIRV compiler should be able
to treat the converted variable as 16 bits, and the hardware can
still benefit from reduced precision floats.
The frontend is also notified such SPIRV shader changes by setting
the isFloat16 bit in CollectVariables() step, and the frontend will
transform float uniform data from 32-bit to 16-bit before storing the
data into memory. That way, the uniform data that SPIRV shader reads
matches with the uniform data type transformed in the SPIRV shader.
This change also updates some test code to allow relative 2^-10
precision wiggle room for mediump uniform floats. This is valid
according to spec:
https://developer.arm.com/documentation/102502/0101/Shader-precision
Bug: angleproject:405795981
Bug: angleproject:440941211
Change-Id: I05db7f5ef744df513fbad87cfed8aa173890ec26
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6851560
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
8280ca37
|
2025-09-02T13:27:38
|
|
Add a test for uniform reorder bug on Mac
This change adds a test to cover the bug fixed in
https://chromium-review.googlesource.com/c/angle/angle/+/6847281.
Bug: chromium:442521269
Change-Id: I78c1b9691f7bf04b6e046d04328a42cc9eae0fcd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6907558
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
ded3e754
|
2025-08-18T14:42:59
|
|
Add more tests for RGB565
* Added more tests regarding RGB565 rendering, texture copy, blit,
and border color clamp.
Bug: b/409867243
Change-Id: Ic9d30aee89bda3e8f6c9147fffd99d8d2d8fac64
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6872406
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
6f0337a0
|
2025-08-28T23:13:22
|
|
Avoid some needless c_str() calls.
Remove conversions from string -> char* -> string, as detected some
time ago by a clang compiler plugin. Typically, this occurs when
passing a c_str() result to a function that expects a string argument.
Bug: b/412730353
Change-Id: I1d9c83e9ed5c4900eec266e71f534661f0f3d4d4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6896657
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
28682948
|
2025-08-14T15:20:16
|
|
Update setFloat and getFloat APIs to handle 16-32 bit transformations
This change checks that if linkedUniform.isFloat16() is true, then
transform 32-bit float to 16-bit half float before writing the data
to memory, and transform 16-bit half float to 32-bit float after
reading the data from memory. Given that we did not change buffer
layout, and the spirv requirement with matrix component alignment,
we have to copy transformed data row by row / col by col, or element
by element.
This change is no op, as none of the linkedUniform.isFloat() bit is set
to true. The change will take effect in the future change when we add
the compiler code that set linkedUniform.isFloat() to true.
Bug: angleproject:405795981
Change-Id: I72b74eb340dae723501038875c3706ad2c1cc3f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6851558
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
af0386cb
|
2025-08-27T10:44:53
|
|
Reorder structs entirely made of samplers to the end of struct
An earlier change [1] moved samplers to the end of structs so that
extracting them does not disturb the indices to the non-sampler fields.
This change does the same for structs that only contain samplers,
because they too get removed from the parent struct, disturbing indices.
[1]:https://chromium-review.googlesource.com/c/angle/angle/+/5748789
Bug: chromium:438038775
Change-Id: I7ac2ea13723bf06b4b172b6e70f0dbe85bc45ce3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6891071
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
1ed999ea
|
2025-08-25T16:02:01
|
|
Vulkan: Move sampler cache to share group
The sampler cache (and the adjacent yuv-conversion-info cache) were in
vk::Renderer, but they were not thread safe.
Bug: angleproject:440364873
Change-Id: I2dc034f2db400f680ca91a9fde509d90f90c957e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6870736
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
b9cec916
|
2025-08-12T19:44:18
|
|
WGSL: default uniforms gathered in interface block
The default uniform struct was being manually output by
OutputUniformBlocksAndSamplers(), which did not add the appropriate
@align(16) annotations to lay the struct out according to WGSL's
uniform address space layout requirements.
This CL uses Vulkan's method of gathering the default uniforms
into an interface block. The interface block will be output
normally by the traverser, including @align() annotations.
The variable declaring an instance of the interface block is
still output by OutputUniformBlocksAndSamplers() because it needs
special @group() and @binding() annotations.
Bug: angleproject:376553328
Change-Id: Ib3be7d51ffedefe5ec579a1c9aaf0a535146c694
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6795028
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
25390156
|
2025-08-21T00:13:19
|
|
Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
In this CL, we suppress many files but stop short of actually
enabling the warning by not removing the line from the
unsafe_buffers_paths.txt file. That will happen in a follow-on
CL, along with resolving any stragglers missed here.
This is mostly a manual change so as to familiarize myself with
the kinds of issues faced by the Angle codebase when applying buffer
safety warnings.
-- Re-generate affected hashes.
-- Clang-format applied to all changed files.
-- Add a few missing .reserve() calls to vectors as noticed.
-- Fix some mismatches between file names and header comments.
-- Be more consistent with header comment format (blank lines and
trailing //-only lines when a filename comment adjoins license
boilerplate).
Bug: b/436880895
Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
611f9ac0
|
2025-08-20T16:10:13
|
|
Lower the cap of max element index
Currently, ANGLE follows vulkan spec and returns UINT_MAX -1
for GL_MAX_ELEMENT_INDEX. However, ANGLE stores vertex index
in int, so even if we use index a little less than the limit,
ANGLE would still catch the overflow error. Modify the cap to
2^30 - 1 to make it safer. An end2end test is also added.
Bug: angleproject:440227026
Change-Id: Ie089c9847f3908f0e8a1b7c4b83c8fea1cde262e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6870270
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
d65058be
|
2025-08-18T11:01:11
|
|
Vulkan: Add support for GL_EXT_fragment_shading_rate_primitive
Add support for built-in GL_EXT_fragment_shading_rate_primitive and
tests.
Bug: angleproject:397255625
Change-Id: I0f37a87a73e869a91e39402f01e53166b359ec3c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6850353
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Panfeng Hou <panfeng.hou@arm.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
0af6e4ee
|
2025-08-13T06:16:01
|
|
Vulkan: Check format compatibility to enable mip levels
If redefining the texture level is needed while respecifying the
image storage, the base level could be incompatible with the max
level count.
Enabling the whole level count can cause a null pointer dereference
when copying an image that does not support `pixelReadFunction`.
To handle the problem, this CL checks the format compatibility and
enables only the effective base level.
Bug: b/435727832
Test: angle_end2end_tests --gtest_filter=DXT1CompressedTextureTest.*
Test: angle_end2end_tests --gtest_filter=Texture2DTestES3.*
Change-Id: I01060332f282ef9b2856390d0d7296811a464795
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6813835
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
86a8d11c
|
2025-08-11T16:45:39
|
|
Metal: Fix potential incorrect format used for texSubImage
TextureMtl caches the most recent format used for a texture
redefinition in mFormat. During subImage calls, this format may not be
the same as the image being uploaded to.
Pass ImageDefinitionMtl to these functions which reference mFormat, it
contains the format of the image being updated.
MacOS OpenGL is skipped because the driver generates errors in
glCompressedTexImage2D.
Bug: chromium:435683799
Change-Id: Idec6f71870c2d376cad3a5e3628b957009bdced9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6838878
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
03068e0c
|
2025-08-20T17:36:22
|
|
[WebGPU] Implement direct copy for images.
This CL implements CopyImage specifically in cases
where the source is the same size and format as the
destination.
Bug: angleproject:438268609
Change-Id: Icf5f3685bb2f49874d996883c839515314f1c189
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6842317
Commit-Queue: Liza Burakova <liza@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
119ffd44
|
2025-08-13T16:07:52
|
|
Fix -Wreturn-type in ShadowSamplerFunctionsTest::FunctionName
Add UNREACHABLE() and a fallback return to ensure the non-void function
always returns when switch does not cover all enum values.
BUG: angleproject:438226513
Change-Id: I3904dd59b323b90930d9251b060ab7067ff412c7
Signed-off-by: Sungyong Choi <sywow.choi@samsung.com>
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6845486
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
edb05627
|
2025-08-12T12:17:36
|
|
Fix sort uniform bug
Current sort doesn't take care of the case when both uniforms
are struct specfiers. Given that struct types are easily broken by
sort, make the sort not reordering uniforms if both are structs.
Bug: b/437825940
Change-Id: Idda1810ac4234f7e1547735e4e09658ab0a57eed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6842936
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9d1edb4e
|
2025-08-08T18:21:03
|
|
Fix the assert on texture target to allow GL_TEXTURE_CUBE_MAP_ARRAY
Add anend2end test to verify glCopyImageSubData works.
Bug: b/419863436
Test: TextureCubeTestES32.CopyImageSubDataCubeMapArray
Change-Id: I2a569680ed20f05b4182045cb4bdf08d4c66d8df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6832639
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Xiang Wang <xwxw@google.com>
|
|
|
b2e2766c
|
2025-08-12T11:08:46
|
|
Translator: Reject bool < bool
This is not allowed per the GLSL ES spec.
Bug: chromium:437983671
Change-Id: I9bd46718a35917dcdf6382cd51253ca2b68d5636
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6842555
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
555b2328
|
2025-08-08T13:32:13
|
|
BindVertexBuffer should pick up buffer change in other context
Buffer is modified in the first context and calling glBindVertexBuffer()
of the same buffer on the second context should pick up the buffer
changes made in first context.
Bug: b/433331119
Change-Id: I694f66b38b11b87e0efa8d9b939f8384120823af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6830125
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
5f5baf86
|
2025-08-08T10:22:07
|
|
Reduce WebGLCompatibilityTest::L32FTextures test time
This test is looping formats. Within each loop it compile the same
program which makes this test take very long to finish. This CL caches
the programs so that it only compile/link once. This reduce this test
run time on my local gLinux box from 1633 ms to 326 ms.
Bug: angleproject:40096431
Change-Id: I32d7ad4fd25e1e4130766578fff21b1a2058c183
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6830119
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
ca3d732d
|
2025-07-24T16:22:31
|
|
WGSL: support bool in uniforms
WGSL does not allow booleans in the uniform address space.
This CL changes the translator to substitute u32 for bool
in the uniform address space, and convert it to bool on use.
Arrays of bools are obviously arrays of u32s, and those
will need special conversion functions to convert the entire
array<u32> to array<bool> if necessary.
This also includes the optimization of an array<bool> in a
uniform--when indexing into it, only the indexed element
will be converted to a native bool, instead of converting
the entire array and then indexing.
Note that substituting u32 for bool matches std140, so this
change requires no changes to layout of uniforms.
Also note that WGSL really likes explicit casts, so there's
not really a way to avoid inserting explicit casts everywhere
when using u32.
Bug: angleproject:376553328
Change-Id: I8f72e55c6b401c28ff622622df7a450b7032721f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6785609
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
|
|
|
d63cff37
|
2025-08-06T13:31:02
|
|
Fix bug when rebind the same buffer not pick up the change
Buffer is modified in one context and rebind the same buffer on the
second context should pick up the buffer changes.
Bug: b/433331119
Change-Id: I8085fe826c339692881f2d3d6515efb19bbc4a88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6825767
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
7c8e357c
|
2025-07-15T17:24:25
|
|
Fix NULL handling in glGetAttachedShaders and ShaderPrecisionFormat
Fix the case where passing NULL to the shaders parameter in
getAttachedShaders and to the range and precision parameters in
getShaderPrecisionFormat would trigger assertions.
Bug: angleproject:431900689
Change-Id: I0d01bbb0d13f9a4704b47066c85ac7c1368534a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6733749
Auto-Submit: Tingwei Guo <tingwei.guo@arm.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
328a205f
|
2025-08-07T11:02:12
|
|
Revert "Fix bug when reattach the same buffer not pick up the change"
This reverts commit a93f4c8d29c8d214e4823032e6e2c061d5dab1b1.
Reason for revert: https://issues.chromium.org/437092065
Bug: b/433331119
Original change's description:
> Fix bug when reattach the same buffer not pick up the change
>
> Added a test that the same buffer is used in two contexts. Buffer is
> modified in one context and reattached the same buffer on the second
> context's vertex array should pick up the buffer changes. This test
> exposed the bug and it is fixed in this CL.
>
> Bug: b/433331119
> Change-Id: Ia5675581857a642fe9727f196326da9af43d52cf
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6821923
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
> Commit-Queue: Charlie Lao <cclao@google.com>
Bug: b/433331119
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Iaa14b5dbbdb02c69bb060d5073072ec6ddd473ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6827998
Auto-Submit: Charlie Lao <cclao@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
a93f4c8d
|
2025-08-05T16:45:21
|
|
Fix bug when reattach the same buffer not pick up the change
Added a test that the same buffer is used in two contexts. Buffer is
modified in one context and reattached the same buffer on the second
context's vertex array should pick up the buffer changes. This test
exposed the bug and it is fixed in this CL.
Bug: b/433331119
Change-Id: Ia5675581857a642fe9727f196326da9af43d52cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6821923
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
bc7e86b1
|
2025-07-30T14:55:34
|
|
tests: RequestedRendererCreated: Get created context version
If the driver being tested does not support the ANGLE extension
EGL_ANGLE_create_context_backwards_compatible, then the Context version
returned may not match the requested version.
Update the test RendererTest.RequestedRendererCreated to query the
current Context's version if the extension is not supported so the
renderer string is checked against the correct value. Continue enforcing
the renderer string has the expected value if the extension is
supported.
Bug: b/409384875
Test: angle_end2end_tests
--gtest_filter=RendererTest.RequestedRendererCreated/*
Change-Id: Iad1b6d36a31b7d79e8fc5fae9e4cc9769b55edb8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6803326
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
fc0e0397
|
2025-07-31T13:15:45
|
|
Translator: Fix location validation for inout
Without this validation, a shader using an inout variable can
write into a memory beyond the limit set by MaxDrawBuffers when
shader framebuffer fetch is enabled.
* Extended the location check in visitSymbol() to include InOut
qualifiers (EvqFragmentInOut) as well (in ValidateOutputsTraverser).
* Moved RewritePixelLocalStorage() after ValidateOutputs() to avoid
issues related to locations not being specified in the InOut nodes
from the PLS implementation.
* Added a unit test to test that this case results in a compilation
error: GLSLTest_ES3.CompileFSWithInoutLocBeyondMaxDrawBuffers
Bug: chromium:435139154
Change-Id: I44c729377a2e1d3126c2d279172217b2ab92b57b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6806230
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
be43e317
|
2025-07-31T17:40:24
|
|
EXT_external_buffer should have DYNAMIC_DRAW usage
EXT_buffer_storage requires that BUFFER_USAGE must be DYNAMIC_DRAW.
EXT_external_buffer only mentions that the buffer can be sourced from an
external EGLClientBuffer. Therefore, the BUFFER_USAGE should still be
DYNAMIC_DRAW.
Add an end2end test.
Bug: angleproject:436046320
Change-Id: Ie79a1b1f8be0df4566bff26800599b192c4f70b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6817076
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
2ef85c24
|
2025-07-09T17:13:52
|
|
Vulkan: Add support for GL_EXT_fragment_shading_rate
Add support for GL_EXT_fragment_shading_rate.
Bug: angleproject:420310117
Change-Id: I7b368afc45baf8551c222b2569991269117d385b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6726817
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Panfeng Hou <panfeng.hou@arm.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
a1d5d102
|
2025-07-22T02:15:43
|
|
WGSL: Allow matrices as in/out vars in shaders
WGSL only supports scalars and vectors in in/out vars in shaders,
matrices will need to be broken into column vectors and then
put back together at the beginning (or end) of the shader.
Arrays also need to be split, which will be done in another CL.
Bug: angleproject:42267100
Change-Id: If1ba28c1b687ae0a3a5a554479f0ff0b5d9df39c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6777201
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
|
|
|
b0e0c9f6
|
2025-07-30T17:20:25
|
|
tests: DefineTexture2DArrayShouldFail skip on ES3+
The test Texture3DTestES2.DefineTexture2DArrayShouldFail is validating
behavior specific to OpenGL ES 2.0. Skip the test when running on
OpenGL ES 3+ contexts, which is possible when testing the system EGL
which may not support the extension
EGL_ANGLE_create_context_backwards_compatible.
Bug: b/409384875
Test: angle_end2end_tests
--gtest_filter=Texture3DTestES2.DefineTexture2DArrayShouldFail/*
Change-Id: I129ce494c784c3889f21d4950a0302258b423b08
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6803336
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
aa533732
|
2025-07-28T15:56:13
|
|
CreateGeometryShaderInES3: Skip on ES3.1+
When testing the system EGL (angle_test_enable_system_egl = true), the
context returned is the maximally conformant version, which can be
OpenGL ES 3.2. The test GeometryShaderTestES3.CreateGeometryShaderInES3
verifies that geometry shaders cannot be created, assuming it will only
ever be testing ES 3.0 contexts.
1. Add ANGLE_INSTANTIATE_TEST_ES3_AND_ES31_AND_ES32() to instantiate a
test for ES 3.0, 3.1, and 3.2.
2. Update GeometryShaderTestES3.CreateGeometryShaderInES3 to skip when
testing ES 3.1+ contexts.
3. Instantiate GeometryShaderTestES3 for ES 3.0, 3.1, and 3.2.
Bug: b/409384875
Test: GeometryShaderTestES3
Change-Id: Ic5b4dbb167b8de7f24da285b4620f5257ed7df54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6794766
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
e286ef78
|
2025-07-24T21:19:54
|
|
ANGLE: Add validation test for GL_RENDERER string format
This change introduces a new ANGLE end-to-end test to validate the
format of the GL_RENDERER string, preventing regressions caused by
downstream modifications.
A recent issue (b/318636997) was caused by a partner modifying the
ANGLE GL_RENDERER string in a way that broke Skia's parser. This
revealed that the string format is a de-facto API contract that must
be enforced.
This new test, RendererTest.ValidateCanonicalFormat, serves as an
automated guardrail and will become part of the Android CTS.
The test enforces the following structural contract:
1. The overall structure must be "ANGLE (Vendor, Renderer, Version)".
2. The separator between components must be ", ".
3. The Vendor, Renderer, and Version components must not be empty.
This ensures the string is parsable by clients like Skia without
over-constraining the content of the component strings, which may
originate from underlying drivers.
The test correctly skips validation on the Null backend, which is not
subject to this contract.
Test: autoninja -C out/Android angle_end2end_tests && out/Android/angle_end2end_tests --gtest_filter="RendererTest.*" --num-retries=0
Bug: b/432805963
Change-Id: I1202074cc9f4413ee88e4534fb72fb71101721e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6788522
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Solti Ho <solti@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
09bbe914
|
2025-07-28T12:53:53
|
|
Add test for mapBuffer and disable/enable attrib interaction
Added a test that mapBuffer while attribute is disabled, the draw call
should succeed. If attribute is then enabled, the next draw call should
fail with GL_INVALID_OPERATION error.
Bug: b/433331119
Change-Id: I61d9ff16b0d485309c58c2fe2939c3de8b25864a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6792268
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
4f4eab29
|
2025-06-30T14:58:28
|
|
Reset index buffer offset between indirect GL_LINE_LOOP draws
In two consecutive glDrawArraysIndirect with GL_LINE_LOOP mode, and
bound to a different Indirect Buffer, the variable value captured
through TransformFeedback is the same as the first result when the
second DrawArraysIndirect.
When calling DrawArraysIndirect the second time, DIRTY_BIT_INDEX_BUFFER
should be set to dirty so that it re-gets INDEX BUFFER to get the
correct result.
Bug: angleproject:428561247
Change-Id: I7f4ebb53e20cf8e362e67679b45185b8b68c56ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6687309
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Tingwei Guo <tingwei.guo@arm.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
214a48c4
|
2025-07-16T12:42:18
|
|
Vulkan: add support for yuv resolve with transient image
Add support for the YUV_target extension in cases where the
implementation supports VK_ANDROID_external_format_resolve without
supporting nullColorAttachmentWithExternalFormatResolve.
Bug: angleproject:386749841
Tests: ImageTest*YUV*
Change-Id: Iebcb4f843b962f3d0d2f4e42db479902b6c1f849
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6761834
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
d38531e8
|
2025-07-23T09:39:11
|
|
Fix extension check for xfb mode validation
With geometry and tessellation shaders, it's possible to use different
primitive modes between transform feedback and draw, as long as they are
from the same class.
The code accidentally allowed this only if both extensions are
supported, but it should be allowed if either is.
Bug: angleproject:428561247
Change-Id: Ia18d4ac15a3d0739ce18dc0e1f3d3f0b1aea621c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6780744
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
cf4c8c2a
|
2025-07-10T15:50:36
|
|
Add max sampler count to maxUniformLocations
OpenGL ES 3.2 Spec:
> ## 7.6. UNIFORM VARIABLES
>
> When a program is linked successfully, all active uniforms, except for
> atomic counters, belonging to the program object’s default uniform
> block are initialized as defined by the version of the OpenGL ES
> Shading Language used to compile the program. A successful link will
> also generate a location for each active uniform in the default
> uniform block which doesn’t already have an explicit location defined
> in the shader. The generated locations will never take the location of
> a uniform with an explicit location defined in the shader, even if that
> uniform is determined to be inactive. The values of active uniforms in
> the default uniform block can be changed using this location and the
> appropriate Uniform* or ProgramUniform* command (see section 7.6.1).
> These generated locations are invalidated and new ones assigned after
> each successful re-link. The explicitly defined locations and the
> generated locations must be in the range of 0 to the value of
> MAX_UNIFORM_LOCATIONS minus one.
Currently, ANGLE sets the mNativeCaps.maxUniformLocations to the maximum
number of supported uniform variables (maxUniformVectors). However,
samplers are also uniforms and consume uniform locations during shader
linking. This causes shader compilation to fail for context versions
3.1+ if a shader uses both the maximum number of uniform variables and
maximum number of samplers because the number of uniform locations is
exceeded.
This specific edge case is being tested by the end2end test
GLSLTest.VerifyMaxVertexUniformVectorsWithSamplers. Unfortunately, that
test is only instantiated for GLES 2.0 and 3.0 and ANGLE's shader linker
only validates the number of supported uniform locations are not
exceeded for GLES 3.1+, so that error path is not being validated.
1. Include both the maximum number of supported uniform variables and
maximum number of samplers whe calculating the supported maximum
number of uniform locations.
2. Instantiate GLSLTest.VerifyMaxVertexUniformVectorsWithSamplers for
GLES 2.0, 3.0, 3.1, and 3.2 so the edge cases are tested for all
supported GLES versions.
Bug: b/279980674
Test: angle_end2end_tests
--gtest_filter=GLSLTest.VerifyMaxVertexUniformVectorsWithSamplers*
Change-Id: I8ad1f4d2a040a189625d516b54bf2f79ef218edc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6724940
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
b7582680
|
2025-02-24T18:04:32
|
|
Reland: GL: Allow untranslated shaders to pass through on GLES
Add an EGL extension EGL_ANGLE_create_context_passthrough_shaders which
uses the NULL translator and passes the original shader to the driver.
The parser is still used for shader reflection.
Always enable the null compiler backend. It has almost no binary size
cost and is now potentially used when the null ANGLE backend is not
enabled.
Bug: angleproject:398857482
Change-Id: Id528189ccbbacb1c444eacb151baadfda9fcc04b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6488609
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
03676f3f
|
2025-07-22T15:34:18
|
|
Tests: Add MixedMultisampleSingleSampledDraw test
Test: angle_trace_tests --gtest_filter=MultisampledRenderToTextureES3Test.MixedMultisampleSingleSampledDraw
Bug: angleproject:433462527
Change-Id: I87b56452bd5ad1d7841341ddd7af9479fe966f6d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6773431
Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
890b5d8f
|
2025-07-07T13:06:54
|
|
Vulkan: Encapsulate more descriptor set logic in ProgramExecutableVk
- ProgramExecutableVk handles SharedDescriptorSetCacheKey updates
- Inline most update*DescInfo methods
- Add dedicated methods to handle uniform and storage buffers to remove
some branches from frequently used code paths
Bug: angleproject:426412564
Tests: UniformBufferTest31.UniformBufferBindingRangeChangeWith*FBF
Change-Id: I54b8ae2bd8778231e4d187b2cfd30f4d71de7f3b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6733546
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
7cbb77a8
|
2025-07-14T11:32:04
|
|
Fix the uniform reorder bug
When sorting uniforms, we should first check if both uniforms are
structs, and make sure to place the uniforms with specifier in front
of the uniforms without specifier.
Bug: chromium:431318231
Change-Id: I8be9501f34073983b7f3d040780b749a7366e3d2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6733547
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
3b90872b
|
2025-07-06T09:02:27
|
|
Vulkan: Selectively invalidate uniform buffers
Call invalidateCurrentShaderUniformBuffers iff current program
has active uniform buffers. Also add DIRTY_BIT_UNIFORM_BUFFERS bit
to mNew*CommandBufferDirtyBits
Bug: angleproject:426412564
Bug: angleproject:429585235
Tests: UniformBufferTest31.UniformBufferBinding*WithMultiplePrograms*
Change-Id: I88c37c8317205aecad638553846ffe3beff87f11
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6706537
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
6d18ed63
|
2025-07-08T16:26:53
|
|
ValidateGetTexLevelParameterBase: Remove ES 2.0 check
This CL addresses review comments in:
https://crrev.com/c/6710993
1. Remove the ES_2_0 check for GL_MEMORY_SIZE_ANGLE in
ValidateGetTexLevelParameterBase() since the GL_ANGLE_memory_size
extension already requires OpenGL ES 2.0, making the version check
redundant.
2. Update the test MemorySizeTest.BasicUsageTexture to use the function
glGetTexLevelParameterivANGLE() if the context version is below OpenGL
ES 3.1 and the extension GL_ANGLE_get_tex_level_parameter is available.
Bug: b/409384875
Change-Id: I831d4b35eec20fcb4aff331c5a642a749bd52e67
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6715885
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
5d51bd19
|
2025-07-01T15:40:10
|
|
Translator: Handle arrays of samplers in FlagSamplersWithTexelFetch
This was found while running tests for Dawn's "sized binding arrays"
(including arrays of textures) with ANGLE + Swiftshader.
Adds a test that ASSERTs without the change.
Bug: chromium:411573957
Change-Id: Ib7fad0f5c0b4f3aa70e6af5bf5977b82956e1986
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6695013
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
|
|
|
dc9fb800
|
2025-07-08T16:59:33
|
|
ComputeShaderTestES3.NotSupported: Skip if ES 3.1+
The test ComputeShaderTestES3.NotSupported requires that the context
version is exactly OpenGL ES 3.0. However, if the system EGL does not
support the ANGLE extension
EGL_ANGLE_create_context_backwards_compatible, the maximum conformant
version the display supports will be returned instead. This causes the
test to fail, because OpenGL ES 3.1+ contexts *do* support creating
compute shaders.
Skip the test when testing the system EGL if the context version is
3.1+. Only skip when testing the system EGL, so we still fail if the
context version is not exactly 3.0, since that's (likely) a bug.
Bug: b/279980674
Change-Id: I38090d7f562c7760f2c1b1c3211d1e622b0e0ad4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6715721
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
30a1cbc9
|
2025-07-03T13:00:05
|
|
Vulkan: Separate out descriptor set for uniform buffers
Bug: angleproject:426412564
Change-Id: Icdbb1e634fc543714d1e3b9cdba0530d400cb153
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6705153
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
8e9132c3
|
2025-07-08T15:23:17
|
|
Add missing brackets to gl_tests
Add missing brackets required for format style
Bug: angleproject:430338389
Change-Id: I4757f03c06bc25734c7492284160d04c8c8fd459
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6715884
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: mohan maiya <m.maiya@samsung.com>
|
|
8a9fe208
|
2025-06-20T16:32:11
|
|
Vulkan: Fixed rate compression not work as expected on Android
On Android C++ compiler do more optimization and results different with
Linux, re-write code to correct the issue.
Bug: angleproject:352364583
Change-Id: I1863d2d255cd831d4ca9dd866c85e419f410bd9a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6687014
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Neil Zhang <Neil.Zhang@arm.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
18091004
|
2025-06-19T16:50:58
|
|
GLES1: Skip updating vertex attrib array when binding zero texture
Previously, when usecases bind the zero texture, the vertex attrib
array was disabled. This made the following bound textures lose the
vertex attrib data.
In this change, updating vertex attrib array in prepareForDraw()
is skipped when the application binds zero texture but does not
activate the corresponding texture unit.
Also GLES1 tests using zero texture are added to make sure vertex
attrib array is enabled correctly.
Test: angle_end2end_tests --gtest_filter=DrawTextureTest.*
Bug: b/426740680
Change-Id: Ic5aad0a60c9d987edcb1d05cdb6b68dd93eac309
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6659335
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
2e9de3c7
|
2025-07-07T16:58:18
|
|
ValidateGetTexLevelParameterBase: Support GL_MEMORY_SIZE_ANGLE
ANGLE supports the extension GL_ANGLE_memory_size, which adds the new
parameter GL_MEMORY_SIZE_ANGLE. However, the parameter value is not
supported in ValidateGetTexLevelParameterBase(), so any calls using it
always fail with GL_INVALID_ENUM.
The parameter is supposed to be tested by
MemorySizeTest.BasicUsageTexture/*, but the portion of the test
validating GL_MEMORY_SIZE_ANGLE is never executed because it requires an
OpenGL ES 3.1+ context, but the test is only instantiated for GLES 2.0
and 3.0.
Based on all the above:
1. Add support for GL_MEMORY_SIZE_ANGLE to
ValidateGetTexLevelParameterBase(), requiring GLES 2.0+ and the
extension memorySizeANGLE is enabled.
2. Instantiate MemorySizeTest to run on GLES 2.0, 3.0, 3.1, and 3.2, so
the entire test is run on devices that support GLES 3.1+ contexts.
Bug: b/409384875
Test: angle_end2end_tests --gtest_filter=MemorySizeTest.*
Change-Id: I70c5721c5da18cb8edbc9a7e18038d5d9fb486da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6710993
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
825b4062
|
2025-07-01T17:36:05
|
|
tests: Skip ProgramBinariesAcrossPlatforms on SystemEGL+Android
ProgramBinariesAcrossPlatforms.CreateAndReloadBinary/* is failing when
testing the system EGL on Android.
The issue is that the test calls eglWindow->initializeGL(), without
checking all of the required extensions are available first.
Specifically, it needs the same type of checking that was added to
ANGLETestBase with https://crrev.com/c/6622112.
Rather than duplicating that work, we should instead find a way to
refactor things so both ProgramBinariesAcrossPlatforms and ANGLETestBase
can share the implementation.
This would also fix the issue that ProgramBinariesAcrossPlatforms cannot
be skipped with an entry in angle_end2end_tests_expectations.txt, also
due to not inheriting from ANGLETestBase. Due to this, the test needs to
be skipped directly within ProgramBinariesAcrossPlatforms::SetUp(),
before mOSWindow->initialize() is called (and fails).
Bug: b/424595860
Bug: b/429026255
Change-Id: I118a912e871a4693ac529376ddf97c60dd77b1a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6694919
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
f346ced7
|
2025-07-03T15:49:41
|
|
Fix UninstantiatedParameterizedTestSuite on iOS
CopyCompressedTextureTestES32 missed rename in
https://chromium-review.googlesource.com/c/angle/angle/+/6648198
Bug: b/419048313
Change-Id: I9c1b64a5625f9cd15b083ff6a0827c069752aa5c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6703639
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
|
|
|
2f8193ec
|
2025-06-25T13:17:47
|
|
Validate buffers bound for transform feedback are not modified.
The ES spec says it is undefined to write to a buffer that is currently
being used for transform feedback output but recommends generating an
error. Generate INVALID_OPERATION in this case.
Bug: chromium:427162086
Change-Id: I727d18c2035509fe2e5d60680eb5198e40a60e33
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6673310
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
|
|
|
2ac49bb6
|
2025-07-01T12:11:12
|
|
Reland "Vulkan: Move VertexArray::ElementBuffer away from observer"
This reverts commit 79ac1a8cd767a32cce6401203e20c4bd4ca4d539.
Reason for revert: the regression bug is fixed in PS6
The regression bug with the original CL is caused by when we bind a
vertex array without element buffer rebind, we missed to reset
mIndexRangeInlineCache. The other bug is that VertexArray::mDiryBits is
64 bit but VertexArrayBufferBindingMask is 16 bit, in
VertexArray::setDependentDirtyBits(), bufferBindingMask.to_ulong() <<
DIRTY_BIT_BUFFER_DATA_0 is only producing the 32 bit value on windows
platform due to unsigned long is 32 bit value. bits() is used and bit
shift is operated on to uint64_t here to avoid dropping high bits on
windows.
Two tests are added that reproduce the regression bug caused by
the original CL.
Bug: angleproject:400711938
Original change's description:
> Revert "Vulkan: Move VertexArray::ElementBuffer away from observer"
>
> This reverts commit 3f012a43ee2c101543785720eedfeaa80708479d.
>
> Reason for revert: https://issues.chromium.org/427064102
>
> Bug: angleproject:400711938
> Original change's description:
> > Vulkan: Move VertexArray::ElementBuffer away from observer
> >
> > Right now, VertexArray's element buffer is always observing buffer's
> > change. In previous CLs, we have moved vertex array away from
> > subject/observer usage. This CL moves element buffer away from
> > subject/observer as well. Since the gl::Buffer tracks buffer's binding
> > to each context's current vertex array's binding point,
> > kElementArrayBufferIndex is added to VertexArrayBufferBindingMask bits
> > so that the element buffer is tracked exactly the same as other vertex
> > array buffer bindings. The VerextArray code has been modified to handle
> > this special bit, since element buffer has its own binding point
> > VertexArrayState::mElementArrayBuffer as opposed to
> > VertexArrayState::mVertexBindings. After this CL, VertexArray object
> > should be completely off subject/observer usages.
> >
> > Bug: angleproject:400711938
> > Change-Id: I662ddfabc95034bdc7734939c944ab033f41801c
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552160
> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> > Reviewed-by: Geoff Lang <geofflang@chromium.org>
> > Commit-Queue: Charlie Lao <cclao@google.com>
>
> Bug: angleproject:400711938
> Change-Id: I9487ba8b108baaeda1c8a27189dba64f77616774
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663539
> Commit-Queue: Charlie Lao <cclao@google.com>
> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Bug: angleproject:400711938
Change-Id: I3f47ad1238c41f12b5cbd7a59b84be3fce1e9562
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6664004
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
154e5711
|
2025-06-24T15:28:28
|
|
Refine validation for GetQueryObjectuiv
Spec says that after a graphics reset has occurred on a context,
subsequent GL commands on that context (or any context which shares
with that context) will generate a CONTEXT_LOST error.
Exceptions to this behavior include:
Any commands which might cause a polling application to block
indefinitely will generate a CONTEXT_LOST error, but will also return
a value indicating completion to the application. Such commands
include:
- GetSynciv with pname SYNC_STATUS ignores the other parameters and
returns SIGNALED in values
- GetQueryObjectuiv with pname QUERY_RESULT_AVAILABLE ignores the
other parameters and returns TRUE in params
Bug: angleproject:427242336
Change-Id: I86fd6f93a2c2a4b60c6a1e19637ee6382fadac7b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6666083
Auto-Submit: Shufen Ma <Shufen.Ma@arm.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
bb3f79dc
|
2025-06-26T16:59:48
|
|
Reorder shader resource dirty bits
Process storage and atomic buffer dirty bits before uniform dirty bits.
This helps the vulkan backend avoid duplicate work when multiple shader
resources are dirty
Bug: angleproject:426412564
Change-Id: Ibab3da44ee32d22078df851bfed4967d1c2a605e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6680035
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
bbe53b75
|
2025-06-05T10:36:30
|
|
tests: Skip ShaderBinaryTest for System EGL
The system driver compiler version is not expected to match the version
compiled into the test, causing glShaderBinary() to return
GL_INVALID_VALUE due to the incompatible binaries.
Bug: b/279980674
Change-Id: I6fce9848345ce981003f0d6d8954e45c2966b523
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622113
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
3c41ca3e
|
2025-06-26T20:36:03
|
|
Bugfixes in YUV tests
- There is no mechanism to query dataspace of AHB, ensure
all color values are narrow range compatible
- Ensure AHB usage flag reflects actual usage
- Define YUV reference colors at the top and reuse in tests
Bug: angleproject:386749841
Change-Id: I29d095055ede67653f89a11bae845c086c690b1a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6679988
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d5babf99
|
2025-06-23T12:46:51
|
|
Vulkan: Fix unhandled deferred clears after glGetMultisamplefv
Issue was introduced in the commit that implemented deferred clears.
The `glGetMultisamplefv()` synchronizes draw framebuffer which defers
possibly staged clears. Since API is not handling deferred clears they
are left untouched, causing the ASSERT.
This change fixes the issue by not deferring clears for the
`glGetMultisamplefv()` command during flushing staged updates of dirty
framebuffer attachments.
Changes:
- Add `gl::Command::GetMultisample` enumeration for clarity.
- Add `gl::CommandBlitBuffer::CommandBlitBufferDepthStencil` enumeration
to improve code readability.
- Add `command` parameter into `gl::State::syncDirtyObject()` method to
use actual command enum instead of `Other`.
- Remove `previousDeferredClears` local variable and update ASSERT in
the `FramebufferVk::syncState()` method. New assert ensures empty
`mDeferredClears` instead of just checking dirty attachments, since
it is easy to make all attachments dirty making old and new assertions
act the same.
- Replace logic in `FramebufferVk::syncState()` that decides whether
need to defer attachments or not with switch-case. This makes the
logic more clear regarding handling individual commands and simplify
updating this handling in the future. Except of the bug fix with
`GetMultisample` command, handling of other command is uncached.
- Remove `flushDeferredClears()` from `FramebufferVk::readPixels()`
because `mDeferredClears` are not expected (now it's more clear after
the refactoring). And even if there are `mDeferredClears` (in case of
a bug or after API failure), `flushDeferredClears()` only flushes
clears for the draw framebuffer, while checking `mDeferredClears` of
the read framebuffer. This is a problem in case if read and draw
framebuffers are not the same.
Bug: angleproject:40644727
Test: angle_end2end_tests --gtest_filter=TextureMultisampleTest.GetMultisamplefvAfterClear/*
Test: angle_end2end_tests --gtest_filter=EGLSurfaceTest.GetMultisamplefvAfterClear/*
Change-Id: I376a62de52de5e17dbc63cc7ddb0506741a69266
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6661958
Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b3ec3a5f
|
2025-06-23T14:51:13
|
|
Track active uniform and storage buffer blocks
Track active uniform and storage buffer block indices
so we can process updates to only active buffer blocks
Bug: angleproject:426412564
Change-Id: I54fa6fbe795073887646d672303d231ed4317b65
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6663825
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
2fd033d0
|
2025-05-22T04:21:11
|
|
Vulkan: Optimize updates to uniform buffers
... when only the offset is modified. Most of the work done when
handling dirty uniforms can be skipped since the buffer bindings
haven't changed
Bug: angleproject:386749841
Tests: UniformBufferTest31.UniformBufferBindingRangeChange*Vulkan
Change-Id: Ic811bd71f0f2993f88ce9bcf93f9e8e46dfc6d99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6581359
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
5220e634
|
2025-06-16T11:14:22
|
|
Fix glCopyImageSubData validation check part 2
For compressed texture, we also need to check if the copy subregion
starting points (offset) are aligned with the compressed block.
This change also moves *FillsEntireMip check to the
ValidateCompressedRegion() function, as it is easier to do a
per-dimension check.
Bug: b/419048313
Bug: angleproject:42264179
Bug: angleproject:42265887
Change-Id: I0f415e575bbc77bdf5178e2b5fc1260c43e7de4b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6648198
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
3b7528e1
|
2025-05-20T12:31:28
|
|
Support running the full end2end suite against the System EGL
Update the end2end test instantiation to either fully target the
packaged ANGLE libraries or the system EGL, but not a combination of
both simultaneously.
The GN argument |angle_test_enable_system_egl| controls which driver
is being tested by all the instantiated tests. It's default value is
"false", which means the tests target the ANGLE libraries by default:
kDefaultGLESDriver = GLESDriverType::AngleEGL
When |angle_test_enable_system_egl = true|:
kDefaultGLESDriver = GLESDriverType::SystemEGL
This allows for testing the system EGL with the full end2end test suite,
which is useful on devices where ANGLE is the system EGL (e.g.,
Android). It also allows for specifying which backend to use (or all)
during system EGL testing, when ANGLE is the EGL driver.
This also includes removing the various ESx_EGL() functions, because the
end2end tests must now fully commit to testing either the ANGLE driver
or system driver, rather than a combination of both. This is similar to
many other test suites, such as the Khronos CTS (dEQP), which only test
validate a single driver per invocation.
Bug: b/279980674
Test: angle_end2end_tests
Change-Id: I4f7dc2ccb4f26b3bd02767d0a0d2876f8612f2ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580876
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
6bb47e67
|
2025-06-17T13:42:47
|
|
Vulkan: Limit finalizing foreign image layouts
Currently, any submission results in finalizing all foreign images.
However, if the submission is only limited to the outside render pass
command buffer, this would result in oldLayout VVL errors (01197), as
it would be too early to finalize the layout of such images at those
times. At this time, this type of submission can occur if the size of
buffer-to-image updates exceeds the following threshold:
kMaxBufferToImageCopySize
In this change, finalizing the foreign image layouts would only occur
when all commands are being submitted.
* In ContextVk::submitCommands(), finalizeAllForeignImages() is now
called only when the submission type is Submit::AllCommands.
* Added new submit tests for foreign images to ImageTest:
* UploadForeignUntilSubmitDoesNotBreakRenderPass
* CopyToForeignUntilSubmitDoesNotBreakRenderPass
Bug: b/425987310
Change-Id: Ia345e176be79017ba18ef52a57256eeeb298e39a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6653602
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
f48fcb46
|
2025-06-19T07:11:48
|
|
Revert "Metal: Wraparound int arithmetic for add, sub"
This reverts commit 2f6f0514563d81e439e04ba09eee9e8a1d6ca8d1.
Reason for revert: Leads to MSL compiler errors:
> error: non-const reference cannot bind to vector element
Bug: angleproject:382215759
Original change's description:
> Metal: Wraparound int arithmetic for add, sub
>
> Implement wraparound int arithmetic for
> int, ivec +, -, +=, -=, ++, --.
>
> All of the added tests pass also without the changes.
>
> Bug: angleproject:382215759
> Change-Id: I7605582ab2931e63010c34fba474797f7edd19f9
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6578729
> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Bug: angleproject:382215759
Bug: chromium:425746892
Change-Id: I831d96c6ee7b8bcdeaa08fbf32d430def87a3c30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6656001
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
243ebfa7
|
2025-06-16T16:07:06
|
|
WebGPU: Allow glReadPixels from non-base mip levels.
Before, the WebGPU backend always read from the base level
of the texture attached to the current framebuffer.
Bug: angleproject:42267090
Change-Id: Ibe5b8575f6fa90c1942ba566485b6175ee10f808
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6634558
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Matthew Denton <mpdenton@chromium.org>
|
|
|
db70fca6
|
2025-06-11T16:59:36
|
|
Add a separable program test
ES 3.2 spec section 7.4.1 Shader Interface Matching is vague about
the case when a program has more than one shader whose interfaces
do not match and the program is set to GL_PROGRAM_SEPARABLE by
glProgramParameteri API. Angle implementation thinks it is not
right and the program is not linked. But since the shaders are
attached to one program, the program should have enough information
to link.
Bug: angleproject:424050949
Change-Id: Icb9c8cbff906671beb6679309795f5c1b3acec6f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6636452
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Shufen Ma <Shufen.Ma@arm.com>
|
|
|
dfefcbc6
|
2025-06-09T16:30:55
|
|
glGetProgramiv should return the properties in effect
glProgramParameteri can set values to
GL_PROGRAM_BINARY_RETRIEVABLE_HINT. However, this setting will not be in
effect until the next time glLinkProgram or glProgramBinary has been
called successfully. Also, glGetProgramiv returns the properties
currently in effect for program. Therefore, we need to add a variable to
record the ineffective value and copy it at the stage of glLinkProgram
or glProgramBinary.
Bug: angleproject:421219220
Change-Id: Ib564e6df03d34f3fc7389f926795cb3e64cbf687
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6606372
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
94ee620d
|
2025-05-22T10:07:05
|
|
Metal: Allow optimization of simple loops
Reimplement the feature to avoid undefined behavior of infinite loops.
Add EnsureLoopForwardProgress rewrite pass that inserts a volatile
variable access to all loops that it cannot analyze as being finite.
Detect loops of form `for (; i <op> x; ++i)` as being finite.
The <op> can be any of <,<=,>,>=,==, != operator.
The i can be int or uint.
The ++i can be -- or ++, -=1, +=1.
This assumes that backends using the feature emit signed int arithmetic
with defined wraparound semantics.
Uses volatile write instead of asm("") due to asm not forcing the
behavior in some compiler versions. The volatile variable access is
defined in C++ as forward progress, and by inheritance this works in
MSL.
Later commits may remove injectAsmStatementIntoLoopBodies if
ensureLoopForwardProgress is appropriate for all use-cases.
Bug: angleproject:418918522
Change-Id: Ic9c29f57044b792195386483208632354d24c854
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6575051
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
|
79ec8b34
|
2025-06-12T14:32:42
|
|
Fix glCopyImageSubData validation check
When checking if the copy subregion meets the compressed texture
alignment requirements, we should consider if the copy subregion
covers the entire width and height of texture level. It is not required
to make texture size aligned with compressed texture block size when
creating the texture image (e.g. width and height do not have to be
multiple of 6 when calling glTexStorage2D for
GL_COMPRESSED_RGBA_ASTC_6X6 textures). If the copy subregion width
and height equals to the width and height of the texture level, even
if they are not aligned with the compressed texture block size, the
copy is allowed. This is currently covered by
fillsEntireMip check. However, fillsEntireMip enforces copy subregion
width, height, and depth all equal to the texture level width, height,
and depth, where we should not check depth because we don't enforce
depth alignment for compressed texture. For example, for a 2D texture
array that has dimension of 32*16*2 in current level, a copy region
with width=32, heigh=16, depth=1 should be considered as
fillsEntireMip.
In the spec, it says: "The source and destination subregions must be
contained entirely within the specified level of the corresponding
image objects". Right now we only check if width and height are within
the image bounds, this change adds a check to make sure depth is also
within the image bounds.
Bug: b/419048313
Change-Id: I6e5339cfdfd5785f935a059638c22c9646c12162
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6634232
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
c53c908c
|
2025-06-11T15:36:48
|
|
Refine GetProgramiv validation
An INVALID_OPERATION error is generated if TESS_CONTROL_OUTPUT_-
VERTICES is queried for a program which has not been linked
successfully, or which does not contain objects to form a
tessellation control shader.
An INVALID_OPERATION error is generated if TESS_GEN_MODE,
TESS_GEN_SPACING, TESS_GEN_VERTEX_ORDER, or TESS_GEN_POINT_MODE
are queried for a program which has not been linked successfully,
or which does not contain objects to form a tessellation evaluation
shader.
Bug: angleproject:424050946
Change-Id: I9d6110d2783efb21efbcb62d9da7b35590c89f61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6637010
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Shufen Ma <Shufen.Ma@arm.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
fdff1170
|
2025-06-06T10:46:03
|
|
tests: SystemEGL: Skip tests needing unsupported ANGLE EXTs
The system EGL may not expose ANGLE extensions, even if it *is* ANGLE,
due to platform EGL restrictions (e.g., Android platform EGL).
Skip any tests requiring ANGLE-specific extensions during test setup,
rather than failing them.
This also requires refactoring ANGLETestBase to derive ::testing::Test
so it has access to Test::IsSkipped().
Bug: b/279980674
Change-Id: I8e424509c41fa5a69dee9fc8e0c92da58e4758fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622112
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
005336e4
|
2025-06-11T17:17:16
|
|
WGPU: Basic texture cubes
Allows uploading to texture cube faces and sampling from them
in shaders using samplerCube.
Bug: angleproject:420782526
Change-Id: I45d4370fcc418f39afb225114d13632a78c7c200
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6593999
Reviewed-by: Liza Burakova <liza@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
|
|
|
d8c15499
|
2025-05-27T03:46:24
|
|
Vulkan: Clear depth and stencil unresolve separately
To take into account two situations.
1. LoadOp for depth and stencil attachments are set differently.
2. depth and stencil unresolves could be different between the
previous render pass and the current render pass.
Bug: angleproject:42266019
Change-Id: I9e069b3972f86abb84eee6280919e6bba2901225
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6590197
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
0d441eda
|
2025-05-29T12:04:46
|
|
util: Give all ConfigParameters default values
ConfigParameters has a mix of 'bool' and 'Optional<bool>', with some
tests setting the Optional<> values to the default value, inadvertently
creating a dependency on the associated extension.
To reduce the dependency on various extensions and allow more tests to
run, update ConfigParameters to only contain raw bools and initialize
them to the default values defined by the associated spec. This allows
EGLWindow to only require the necessary extension when a non-default
value is set by a test.
This also requires updates to a handful of tests which were relying on
the state of extensions due to non-default values.
Bug: b/279980674
Change-Id: I77a7e102559e4393aadcdbf37886ae80cbbb9e29
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6618033
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
c39f4a5c
|
2025-06-05T15:35:06
|
|
Vulkan: Update border color assignment for stencil
In texture border clamp, if the border color is assigned together
stencil mode (both using glTexParameter()), its red component is used
to set up a border color to be used in each backend:
* (Set up in AdjustBorderColor())
In the Vulkan backend, this is used when updating SamplerDesc, which
is then used later to set up the custom border color:
* (VkSamplerCustomBorderColorCreateInfoEXT)
According to the spec, in case of undefined format, integer border
color, and stencil image, the implementation is required to use either
the first or the second component of the custom color, although it is
recommended to use the first. However, at the moment, only the first
component is being populated, while using the second component is also
valid.
* Added feature: usesSecondComponentForStencilBorderColor
* Added bit to SamplerDesc: mUsesSecondComponentForStencil
* It is set based on the feature flag above and the texture format.
* When setting the custom border color info, the second component will
be used based on the above flag.
* Added test suites to test this on ES31 and ES32:
TextureBorderClampTestES3*.CustomBorderColorWithStencil*
* Updated capture params for glTexParameterIuivEXT().
* Suppressed the ES32 version for the following:
* P4
* Linux/NVIDIA (due to out-of-date driver)
Bug: b/390710636
Change-Id: Ie50c19e8ea66da40dc8b8db49d7e622a582637a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6626416
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
65159c4e
|
2025-06-05T15:05:46
|
|
Update pipeline desc when sample count changes
* If the sample count changes when calling
glFramebufferTexture2DMultisampleEXT, we need to update pipeline desc
to ensure it is the same as the API requires.
* Add a new end2end test to verify.
Bug: angleproject:422611722
Change-Id: I7de7d3d17513cf03f5e24baa2db83633a229b4b8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6623419
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
1e613fec
|
2025-05-27T16:59:26
|
|
Compiler: sort uniforms by precision
This change reoreders the AST sequences so that uniform declarations
with lower precisions are places in front of uniform declarations with
higher precisions. This is to prepare for the upcoming change that
converts uniforms declared with mediump or lowp to 16-bit and pack them
to 32-bit integeter using packHalf2x16().
Bug: b/405795981
Change-Id: I5e1e293399dc8b51b9a6e83115f95beb0c4a7b1b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594255
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
b888dc2b
|
2025-06-09T16:58:38
|
|
OcclusionQueriesTest: Convert to ANGLETest<>
Convert OcclusionQueriesTest to an ANGLETest<> and remove calling
ANGLETestSetUp() directly. This can be error-prone if ANGLETestSetUp()
doesn't complete, but the test still executes GL commands either in
SetUp() or testSetUp(), before the test itself can be skipped. In that
case, there may not be a current Context, leading to calls like
glGetString() returning nullptr.
This also includes some additional cleanup to remove the GetParam()
calls.
Bug: b/279980674
Change-Id: I5604836c78845424b82b693bc1b74e84b6b557d4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6631025
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|