kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll 48195ae6 2022-06-09T21:03:39 Roll Chromium from 4658acb376d4 to ae46affd7997 (1334 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4658acb376d4..ae46affd7997 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/565e71d210..6fab54091d * buildtools/linux64: git_revision:37baefb026b199605affa7bcb24810d1724ce373..git_revision:2ecd43a10266bd091c98e6dcde507c64f6a0dad3 * buildtools/mac: git_revision:37baefb026b199605affa7bcb24810d1724ce373..git_revision:2ecd43a10266bd091c98e6dcde507c64f6a0dad3 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/11395e54b4..013bcd820a * buildtools/win: git_revision:37baefb026b199605affa7bcb24810d1724ce373..git_revision:2ecd43a10266bd091c98e6dcde507c64f6a0dad3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3215569cc6..0abd70e8a5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8a8c0b9c39 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/138bff2823..c1c45f8a85 * third_party/fuchsia-sdk/sdk: version:8.20220607.0.1..version:8.20220609.0.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d56805c400..4963453edd * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a455f338a1..2f657cf891 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/dbd1cbe518..bba8cd3003 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b7274f10ef..9690393fc8 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ic69025b8319e18b76dfa2c8024c774addb4d8e0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3699024 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 4c6d47c8 2022-06-08T15:20:49 Vulkan: Optimize glEGLImageTargetTexture2DOES with same args If we are creating a texture with the same source eglImage, right now we will release the existing mImage (will not actually destroyed) and then free VkImageViews. Then it point back to the same mImage and allocate new VkImageViews. Since these ImageViews have different serial number, we end up with DescriptorSet cache miss. This CL avoid all these hassles if we are creating with the exact same image. Bug: b/234602034 Change-Id: I04cec05716974e274d6e3678e91ff248f50e9355 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697204 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Auto-Submit: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Cody Northrop ce78f5f8 2022-05-10T09:10:30 Capture/Replay: Reset default uniforms Extend resource tracking to include default uniforms. They are tracked per location, per program. Setup for defaulft uniforms is unchanged, but Reset now includes a section like this: glUseProgram(gShaderProgramMap[6]); UpdateCurrentProgram(6); glUniform1uiv(gUniformLocations[gCurrentProgram][0], 1, reinterpret_cast<const GLuint *>(&gBinaryData[30518768])); glUniform1uiv(gUniformLocations[gCurrentProgram][1], 1, reinterpret_cast<const GLuint *>(&gBinaryData[30518784])); glUseProgram(gShaderProgramMap[9]); UpdateCurrentProgram(9); glUniform4fv(gUniformLocations[gCurrentProgram][1], 15, reinterpret_cast<const GLfloat *>(&gBinaryData[30518960])); glUniform4fv(gUniformLocations[gCurrentProgram][16], 3, reinterpret_cast<const GLfloat *>(&gBinaryData[30519200])); glUniformMatrix4fv(gUniformLocations[gCurrentProgram][20], 2, GL_FALSE, reinterpret_cast<const GLfloat *>(&gBinaryData[30519248])); ... Test: Animal Crossing MEC, Star Wars KOTOR MEC Bug: angleproject:7307 Bug: angleproject:7353 Change-Id: Ic344767f5dd4ffc38c15ed6bf81a7d1daf274a7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3657474 Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Chris Dalton a894cb94 2022-05-10T21:15:59 Bootstrap pixel local storage This CL creates a very simple prototype that implements pixel local storage in a thin layer on top of ES 3.1 shader images, and adds a single test. Assuming all goes well on the various devices and backends, the next steps will be: * Write many more tests. * Compiler support, switch to API-specific shader images. * Move the thin layer into ANGLE. * Thorough validation and error handling. * Add an implementation that uses render target attachments (e.g., EXT_shader_framebuffer_fetch). * Incremental, backend-specific optimizations as needed. Bug: angleproject:7279 Change-Id: I7f9f0a1fe2d61f570b4105a7380687038ae45f5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645786 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao ee1dd7f4 2022-06-08T13:17:39 Vulkan: Add test for glEGLImageTargetTexture2DOES issue This add a test that repeatedly calling glEGLImageTargetTexture2DOES on the same source EGLImage with the same texture parameters should not causing texture's descriptor set cache to keep growing. This is the usage pattern we are seeing with surfaceflinger. Bug: b/234602034 Change-Id: I38ec0a0b2580b8985c27e8c9f7edf14aa7843023 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696677 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 715175de 2022-06-03T22:11:30 Vulkan: Don't enable Qualcomm workarounds on OSS driver Bug: b/217265716 Change-Id: I09cf38a36f8297912f0c26867155cf4f9e145919 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3689810 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Chia-I Wu <olv@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
Shahbaz Youssefi da9390d6 2022-06-08T22:38:18 Vulkan: Fix the VulkanRenderPassBufferCount overlay widget This widget was declared as a histogram, but used as a graph. The graph's add() interface is made hidden in histograms to avoid such mistakes in the future. Bug: angleproject:4950 Change-Id: I95a1b6badbe27b870273589271b13c454c8a4e56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697438 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 0408b129 2022-06-08T22:20:32 Overlay: Support globbing Makes it less tedious to specify multiple widgets. In particular, it also makes it possible to select many widgets on Android through `adb shell setprop debug.angle.overlay` which has a hard limit of 92 characters for the property. Bug: angleproject:5881 Change-Id: I93bd166cd3dbf8f87e5c6a5fce3f86ebb3e379a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697437 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao 2587e508 2022-05-26T17:44:47 Vulkan: Remove redundant vertex array dirty bit processing When BINDING0+n and ATTRIB0+n dirty bits are both set, we are going down syncState twice. What BINDING0+n covers all the work needed for attribute and DATA0+n, so we should remove the ATTRIB0+n and DATA0+n. Similarly if we see DATA0+n, we should skip ATTRIBU0+n as well. Bug: b/235277703 Change-Id: I5e03c18bac3df30a14f3b6652caff2aff33f2fe6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3669608 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 76e98ae1 2022-06-09T09:11:28 Roll VK-GL-CTS from acf70aaf3fdb to 8817dcf9c1ec (36 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/acf70aaf3fdb..8817dcf9c1ec 2022-06-09 piotr.byszewski@mobica.com Split pipeline.txt mustpass into multiple files 2022-06-09 vantablack@google.com Add R8_UNORM to the external AHB memory tests 2022-06-09 michal.jakubek@mobica.com More EXT_color_write_enable tests. 2022-06-08 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_image_compression_control into vk-gl-cts/main 2022-06-08 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_KHR_fragment_shader_barycentric into vk-gl-cts/main 2022-06-07 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_KHR_ray_tracing_maintenance1 into vk-gl-cts/main 2022-06-07 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/main 2022-06-03 pdaniell@nvidia.com Fix regression from CL-9387 to handle empty cache properly 2022-06-03 pdaniell@nvidia.com Fix deqp-vksc build break from CL-9046 2022-06-03 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/vulkansc-cts-1.0.0 into vk-gl-cts/main" into main 2022-06-02 marcin.zajac@mobica.com Thread safe releaseQueue 2022-06-02 toni.merilehti@siru.fi Fix extension check in transform feedback tests 2022-06-02 juha.heiskanen@siru.fi Fix amber-verify mismatch in builtin precision tests 2022-06-02 gleese@broadcom.com Shrink the framebuffer in 2 graphicsfuzz tests 2022-06-02 antto.makinen@siru.fi Test VkSubresourceLayout::offset is relative to the start of an image 2022-06-02 jari.komppa@siru.fi Add inter-process communcation to shader cache 2022-06-02 jbolz@nvidia.com Add command line parameter to override Vulkan library path 2022-06-02 juha.heiskanen@siru.fi Dynamic rendering with NULL shading rate image 2022-06-02 rgarcia@igalia.com Test imageSize() on 2D image views from 3D images 2022-06-02 juha.heiskanen@siru.fi Bug fix for current variableSampleLocations tests + new tests 2022-06-02 toni.merilehti@siru.fi Test single-path switch statements 2022-06-02 jmadill@google.com Remove usages of std::iterator 2022-06-02 pierre-eric.pelloux-prayer@amd.com Fix ShaderBallotFunctionRead test 2022-06-02 younggwan.kim@arm.com Add autogenerate with GL_EXT_fragment_shading_rate 2022-06-02 ayzhao@google.com Remove usages of std::iterator 2022-06-02 younggwan.kim@arm.com Update gl.xml and fix script to build properly 2022-06-02 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main 2022-06-02 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main 2022-05-20 marcin.zajac@mobica.com writeSupportedExtensions for VKSC 2022-05-20 marcin.zajac@mobica.com Missing VK_KHR_object_refresh 2022-05-17 juha.heiskanen@siru.fi Add required support check for IsHelperInvocationEXT test 2022-05-17 ari.suonpaa@siru.fi Add a batch of GraphicsFuzz coverage tests 2022-05-17 pdaniell@nvidia.com Test poolSizeCount can be zero 2022-05-17 jari.komppa@siru.fi Add tests for vkGet...SurfacePresentModes2EXT 2022-05-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/main 2022-05-13 marcin.zajac@mobica.com Merge branch 'vulkan-sc-cts-dev' into 'main' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7416 Change-Id: I289aec7e7b0991556303efa70bd665fb66e43731 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696826 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott 0f8f760d 2022-06-07T17:52:52 Disable KHR_no_error for Android/SwiftShader Speculatively fix crash in Skia on ANGLE that has been happening. In addition, prevent other crashes in the future. Bug: b/220069903 Change-Id: I01b9896a6feb8be524849dafbc1df9526fc98754 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3694160 Commit-Queue: Ian Elliott <ianelliott@google.com> Auto-Submit: Ian Elliott <ianelliott@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 5fbb0417 2022-05-26T15:05:52 Vulkan: Handling VK_EXT_load_store_op_none on ARM There is a bug on at least one ARM device when either depth or stencil load op is none. Add a temporary work around to avoid this case for ARM driver until angleproject:7370 is addressed. Also add a test to reproduce the deqp test failures with simiplied draw calls. Bug: angleproject:7370 Bug: angleproject:7351 Change-Id: I74ac49a75f85b1e006ed3b1d77f234f63d314ae0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3671696 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d47c8e0a 2022-04-04T15:08:45 Vulkan: Enable custom border colors on SwiftShader This extension can now be enabled on SwiftShader after bug fixes that landed in https://swiftshader-review.googlesource.com/c/SwiftShader/+/64688 and https://swiftshader-review.googlesource.com/c/SwiftShader/+/66148 Bug: angleproject:6200 Bug: b/227518327 Change-Id: I65fb342a96c47b1ea5ba2ee773c8ae5539052b94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3569585 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Dan Field 4b9eb4ba 2022-06-03T09:22:41 Optionally support vulkan_memory_allocator 3.x Incompatible API is guarded behind a new define, ANGLE_VMA_VERSION. This allows a soft migration for Chromium and Fuchsia, while allowing clients like Flutter to roll to a new version that is compatible with its revision of Skia. Bug: chromium:1332566 Change-Id: I68cafde13e50445aa8eea2f18203143659a1c627 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3688835 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Dan Field <dnfield@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi f6517f30 2022-06-09T11:53:23 infra: Remove linux-tsan-test from CQ This bot is too flaky. Bug: chromium:1275223 Change-Id: I29a2d30f6d3aa58ee1380eace65df3d78df89ae0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696829 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 4e37ec8c 2022-06-09T16:44:44 Revert "Remove cwd manipulations." This reverts commit c11af00ae1d10d43a71a28c07f99969665c4ea2a. Reason for revert: Needed for http://crrev.com/c/3690739 Original change's description: > Remove cwd manipulations. > > Doesn't appear to be needed as the underlying functions > are already using the executable path. > > Bug: angleproject:7410 > Change-Id: Ia9566c7159624bcb039d7dd2e9d23f4b18649f45 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695519 > Commit-Queue: Roman Lavrov <romanl@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:7410 Change-Id: I397ed2e75155a774c45af9c67e5906932183f1c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696830 Auto-Submit: Jamie Madill <jmadill@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Rohit Rao 07a6f0b2 2022-06-09T09:43:52 Removes uses of sprintf() in ceval. Adds a patches/ directory with diffs from upstream ceval and updates README.chromium with a description of each diff. Bug: chromium:1331345 Change-Id: I876e0a3cb4f70472d8a340649f00d94141604fda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696824 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 48b928d9 2022-06-07T16:21:04 Vulkan: Overlay widgets for pipeline cache/hit stats Bug: angleproject:5881 Change-Id: I1893e6b76a5a73ea51b67bc4ee8a5d5dfc54166e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3689604 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov c11af00a 2022-06-08T14:45:58 Remove cwd manipulations. Doesn't appear to be needed as the underlying functions are already using the executable path. Bug: angleproject:7410 Change-Id: Ia9566c7159624bcb039d7dd2e9d23f4b18649f45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695519 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill a65af046 2022-06-08T11:57:59 De-template out dEQP GTest bridge class. This class doesn't need to be a template, and can take the test case index parameter instead from a common macro. Refactoring only, done in the process of trying to update our dEQP test case registration to get better test names. Bug: angleproject:7390 Change-Id: Ia104a0055ddb9cbc6d311d220d8d4e486214928f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695945 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Geoff Lang 1834902f 2022-06-08T14:22:34 Revert "GL: Temporarily enable validation for all GL calls." This reverts commit b6a93d753bdd819ddc0dacb8cea554c86bc4c04e. Reason for revert: Turning this off for the M104 branch. Original change's description: > GL: Temporarily enable validation for all GL calls. > > Turn on error checks after each GL call to catch potential driver > errors in the wild. > > Bug: chromium:983167 > Change-Id: Ie8b394384223155cd033baca19306396f406cdbb > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3679483 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Peng Huang <penghuang@chromium.org> Bug: chromium:983167 Change-Id: I8f3c950c95d6a56cb724905da0288b1f81c7ed3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695939 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll f06292ae 2022-06-08T10:01:32 Roll vulkan-deps from 23b710f1a0b3 to 00594ab942b5 (41 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/23b710f1a0b3..00594ab942b5 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/316f12ac1d..adbf0d3106 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/50b4d5389b..a97bbc24c5 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/b2a156e1c0..36c0c15962 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b930e734ea..c94501352d * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/245d25ce8c..3ef4c97fd6 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/5437a0854f..c3601d4d91 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/dd7e8d2fbb..ef9db7a8ec * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c97b4d7293..b86c4877c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I73bfeadf3c092851baa622ea799be25de14c04ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3695104 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 4ea62009 2022-06-07T15:35:51 Vulkan: Prefer driver uniforms over spec consts On hardware that's not seeing any benefit from specialization constants, this change switches to using driver uniforms to reduce the number of pipelines created. Bug: angleproject:7406 Bug: b/173636783 Change-Id: Ic1ea1b389b0b27169427643f811370943195f331 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3692270 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 9e47438f 2022-06-07T16:34:18 Vulkan: Fix program creation crash Due to two CLs going in at the same time. Bug: angleproject:7366 Change-Id: I8638b95eefd379abbc64f3b52e87b67f25e1ad52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3693829 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Faye Zhang 06ff0e3c 2022-06-06T15:29:16 Implement GL_EXT_base_instance Added new extension GL_EXT_base_instance to registry_xml.py and auto-generated the entry point function calls for the following functions introduced by the extension: * GL_DrawElementsInstancedBaseVertexBaseInstanceEXT * GL_DrawElementsInstancedBaseInstanceEXT * GL_DrawArraysInstancedBaseInstanceEXT Bug: angleproject:6983 Change-Id: I36167faf3ca98e42acf787dbf09ee7052e15e358 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3691952 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Faye Zhang <ffz@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi b4d4231b 2022-06-06T16:49:40 infra: Increase shards for end2end tests on ASAN In preparation for https://chromium-review.googlesource.com/c/angle/angle/+/3671977 that adds more load on these bots. Bug: angleproject:5881 Change-Id: I505f1b1a75fb5c398dddfe2b8b4ef696b0298062 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690744 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov b9bdc53b 2022-06-07T14:50:46 Make TestEventListener and inner class of TestSuite. Avoids having to pass dependencies to the class as it's automatically a friend; external linkage sadly but such is life. Bug: angleproject:7299 Change-Id: I5726dcab5a1a98b93c0713073cd02d6eb3a8e216 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3693826 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 43c45bc6 2022-06-06T09:16:03 infra: Add Linux AMD test spec. The spec currentlty contains no tests. We can add those in once the basic config is working. Bug: angleproject:7390 Change-Id: I41ff08b11946c955dff67ae4b90bee7cab0dccb3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3691047 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Geoff Lang d670b5a3 2022-06-07T11:43:02 GL: Disable texture border clamp on imagination. IMG GPUs generate INVALID_ENUM when setting the texture border color. Bug: angleproject:7405 Change-Id: I04a28d36943c143ad5e18bf80e618230b116a632 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3692265 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Chris Dalton d9a2027f 2022-05-19T16:52:28 Add a test for volatile aliases of the same shader image Bug: angleproject:3032 Bug: angleproject:7343 Bug: angleproject:7398 Change-Id: I6ea6abea0b9dafd93bc297499df23be27904c996 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3656314 Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano 68634d5c 2022-01-05T20:33:32 Vulkan: Enable VK_EXT_platform_wayland Bug: angleproject:6902 Change-Id: I6a27e3f610bd48dd31937255b287b11fe84c05ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3528756 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki 34d30930 2022-06-01T10:02:58 Tests: Add Shadow Fight 3 trace. Test: angle_perftests --gtest_filter="*shadow_fight_3*" Bug: angleproject:7401 Change-Id: I7a1262560c577c53feeef83f4ebb69b795d4d62b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3687715 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Stephen White 52e560ea 2022-06-07T11:55:56 Remove suppressions for now-passing ES 3.1 tests. Bug: angleproject:1442, angleproject:1951 Change-Id: I61f9c39711f77d48a401ad98ef4ead4c0f17fe2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3693821 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano 35839293 2022-05-19T16:18:10 Vulkan: Fix mutable format check Check directly with enum instead of using boolean logical operator. Bug: angleproject:7065 Change-Id: I98b077c9ab18690d915ed3387a4f19404925daaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645123 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 4dde8590 2022-06-06T23:13:53 Remove suppression for passing tests Bug: angleproject:2976 Change-Id: I5e899c4d4fcc68b52b7b131dae6011a6129ab16b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690748 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 3b988fef 2022-06-01T10:54:03 Vulkan: Remove enableLineRasterEmulation * Removed the Bresenham line raster emulation specialization constant, along with related variables and functions. Bug: angleproject:7366 Change-Id: If17c8ce9b459ad801bae8e887e5674bd9a3ff2bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3680860 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 593cd597 2022-06-07T09:19:21 Roll Chromium from 4697545681bd to 4658acb376d4 (377 revisions) Includes modifications to libpng's BUILD.gn. The change that fixes the roll is the removal of the assembly source file which doesn't conform to BTI. Some additional changes are taken from Chromium's build script. https://chromium.googlesource.com/chromium/src.git/+log/4697545681bd..4658acb376d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1ec4567f5a..565e71d210 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c30c515c84..11395e54b4 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/2c4970601e..1644d070bf * testing: https://chromium.googlesource.com/chromium/src/testing/+log/32159ca2ee..3215569cc6 * third_party/android_build_tools/aapt2: kZqQH92bSO1p0a7_hcrana_9YjtSBU1te7TEtNVBoCUC..jziPmg_EUjoj-eSkO24eMaf5ylm449Q7BKO1-ga2tbgC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..45853b3700 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/89b222dba5..138bff2823 * third_party/fuchsia-sdk/sdk: version:8.20220604.2.1..version:8.20220607.0.1 * third_party/turbine: aSG-acwWsASjZaTfSzYcOuM9qoD6S_o3JL6iIFslVdUC..A5bkaoLBc1JYa6Xv31jYUCK5TnXYCbxRrA4FBPXXcWgC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3e5ac252f7..dbd1cbe518 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6cc9656eb9..b7274f10ef No update to Clang. Bug: chromium:1145581 Change-Id: I0bbcb1d8e147882e85de4d7ce7507b211f7b6871 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690751 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki d66d9e7b 2022-06-01T10:30:18 Tests: Add Rush Royale trace. Test: angle_perftests --gtest_filter="*rush_royale*" Bug: angleproject:7399 Change-Id: I1cfc1304331eac1903750736565eae041d4e00d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3687714 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop aac68adc 2022-05-21T22:27:22 Capture/Replay: Track dirty state per EntryPoint for Reset This CL introduces a new concept of tracking whether an entry point has been called. If so, emit Reset calls designed specifically for that entrypoint. This will likely only be useful for one dimensional state binding calls that can easily be tracked and set back. Only support for EntryPoint::GLUseProgram is added at the moment, but any entry point can be added. Reset will now set the active program back to what it was in Setup. For example: void ResetReplay() { ... glUseProgram(gShaderProgramMap[2]); UpdateCurrentProgram(2); } Test: Animal Crossing MEC, Star Wars KOTOR MEC Bug: angleproject:7307 Bug: angleproject:7353 Change-Id: I19d238ca13bbfb619e1cf8ed86f15ed6c4255a61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3656827 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Stephen White cb9e1235 2022-06-06T14:34:53 D3D11: fix UAV handling. For setting UAVs, Microsoft has provided two APIs: ID3D11DeviceContext::OMSetRenderTargetsAndUnorderedAccessViews() for pixel and vertex, and ID3D11DeviceContext::CSSetUnorderedAccessViews() for compute. They both take very similar arguments, perform similar functions, but have one crucial difference: the former will clobber any existing UAV bindings that are not specified in the call, while the latter will not. The initial implementation of non-compute UAVs in ANGLE didn't accomodate this, and sets UAVs individually, as is done for compute, which clobbers any UAVs set in a previous call. The fix is to collect all UAVs required for a draw or compute pass, and set them all at once. This required reworking the internal dirty bits to reflect the actual D3D requirements (SRV and/or UAV usage), and to split the sync functions to set only SRV or UAV state. Also add a two-SSBO fragment shader test. Bug: angleproject:7385 Change-Id: I0c98e1506d56eccf1db446c0be808f2f3020ae1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690735 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Jamie Madill 0260255b 2022-06-06T15:10:04 Fix printing of non-standard renderers. Bug: angleproject:7396 Change-Id: I18cfadbc58b71259efd414cd7ef90a45719f9b1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690736 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Rohit Rao 4b911686 2022-06-06T22:25:37 Converts from sprintf() to snprintf(). sprintf() is deprecated in Xcode 14, so update to safer equivalents in order to keep the compiler happy on iOS and macOS. Bug: chromium:1331345 Change-Id: Id5348088bf69cbd360d9251e6323596cb710666d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690747 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi ce3c0fe9 2022-06-06T12:09:45 Vulkan: Make depth-correction uniform controlled This change makes sure SPIR-V transformations are not required for depth correction, having the number of potential pipelines. Bug: angleproject:5881 Change-Id: If3f66b34bdd1127ae588cbc822ea7cf01fa8621f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3691801 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Geoff Lang 4868e5a7 2022-06-06T15:29:44 Log the fully formatted message for internal errors. The formatted message is generated but not used. This is critical to know the file and line that generated the error. Bug: chromium:983167 Change-Id: Id4bb1c5b49fa1004728948d87e0270687b82992c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3690738 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Charlie Lao b186991a 2022-05-26T11:50:56 Vulkan: Remove non-current vertex array from buffer's observer list When app binds a buffer to many VAOs, any buffer modification have to loop over all VAOs that uses that buffer, even though all these VAOs are not current except one VAO. That causes significant CPU overhead. black_desert_mobile has this type of usage. This CL checks number of observers on each binding and if there are excessive observers, it removes VAO from the buffer's observer list when it becomes non-current and adds back to observer list when it becomes current. This CL reduces CPU overhead of black_desert_mobile (as measured with --offset --minimumgpuwork) from 21ms to 3.69ms, on par with native GLES driver. Note that this CL only touches glBindVertexArrayObject call code path, so no impact to apps not using VAOs. There is also no measurable CPU time regression on a few other app traces that uses VAOs. Bug: angleproject:6371 Change-Id: I6b1589f3e3c768d56c1c95cebdb577e3e256737f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3669603 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 2fcf9a92 2022-06-06T12:16:55 Suppress failing test Bug: angleproject:7392 Change-Id: I4c0ba6985bcf6ecc833bd6e4719f78e5586402a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3691802 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov b7bd0808 2022-06-06T10:54:30 Support running end2end tests. There is no batching though so all tests matching the filter will be ran at once which will block without any output until evertyhing is done (android runner runs tests in batches of 256 IIRC). Also make suite arg positional and explicitly list supported tests. Bug: angleproject:6854 Change-Id: Ibe108f24d6c3ec8b966eda1cf9ae92119a517548 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3691048 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano 28c59d63 2022-05-24T17:32:33 Vulkan: Fix Wayland Display DRM formats Check whether relevant renderer feature is enabled before querying supported DRM formats. Bug: angleproject:6902 Change-Id: Ib6fa28c75f2b7e4c8a750babe97bdeddd2fa1059 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3664477 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov b71c6427 2022-05-31T16:23:51 Add a wrapper script to run traces using android_helper. Also add missing `appops set MANAGE_EXTERNAL_STORAGE` that appears to be necessary on newer builds (catapult does it starting from Android 11). Add a hash check to skip transferring .gz files that are already there. Bug: angleproject:6854 Change-Id: Ib612d1235fe1274b8fea47718af8389e8810d34e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3679486 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Roman Lavrov <romanl@google.com>
angle-autoroll 611f0e0d 2022-06-06T08:59:24 Roll Chromium from 113f00d1a057 to 4697545681bd (509 revisions) https://chromium.googlesource.com/chromium/src.git/+log/113f00d1a057..4697545681bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a56852668f..1ec4567f5a * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/125ac3cd81..2c4970601e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6408b293c0..32159ca2ee * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d8360ff775 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/04663d61d1..89b222dba5 * third_party/fuchsia-sdk/sdk: version:8.20220531.3.1..version:8.20220604.2.1 * third_party/r8: L2ZGhyJ-Hc8AnXHo5dhtNdI2F2bC_9yi2lqTbJ98sLcC..9ZYYzSVt4L6QGnf272Wm7wxsJ4VH77Dh2fel6JB9nOcC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4e79fda976..a455f338a1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1c2c24f809..3e5ac252f7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2ea3b1abfa..6cc9656eb9 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ic599185e0149a083438eb92863ab651cb3bbb3c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3691413 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 7fb021b0 2022-05-12T16:19:14 Reland "Add Vulkan backend support for texture labels" This is a reland of commit 1afb80587e302e2ce9a901a69fd66e5ef98a73b6 Added check to ensure vkSetDebugUtilsObjectName fcn ptr is valid before use. Fixes failures on mac-swangle-chromium-try-x64. Original change's description: > Add Vulkan backend support for texture labels > > Add onLableUpdate support for textures in the Vulkan backend. > > Bug: b/229105865 > Change-Id: Id9e5b2b81352e97b7843a63f27709739005dc2f3 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645854 > Reviewed-by: Ian Elliott <ianelliott@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Ian Elliott <ianelliott@google.com> Bug: b/229105865 Change-Id: I994da6db2771671c204e4ab01c69912c1be4a48f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3674296 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Stephen White ccf53e3d 2022-06-03T10:40:17 Translator/HLSL: fix image load/store handling. Don't output the image load/store string unless we're outputting HLSL 4.1 (D3D11). Also do some preventative initialization. Bug: chromium:1327872 Change-Id: Ic757fd6c0c92637f565dc39469ee60dfae145353 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3687335 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Charlie Lao 2fec519f 2022-06-02T15:17:28 Avoid dirty texture swizzle state when there is no change Some applications (for example surfaceflinger on Android) may set texture swizzle at every call even though there is no actual swizzle change. But we are not checking against redundant state calls and is always setting texture's DIRTY_BIT_SWIZZLE_* bits. This caused vulkan backend free image views which in turn forces VkFramebuffer recreation. This CL check the swizzle state and only set dirty bits if it actually changes. Bug: b/234602034 Change-Id: I7fab96a957c0b7a7ed318eaccea2d42146ca23cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3688732 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao d655ad29 2022-05-31T14:20:16 Vulkan: Add tests for FramebufferCache growth bugs When texture attached to FBO gets respecified, we shouldn't keep growing FramebufferCache. When texture attached to fbo get glTexParameteri(GL_TEXTURE_SWIZZLE_R) call with the same value, we should also not destroy/recreate framebuffers (in fact should not recreate VkImageView). We ran into this usage pattern on surfaceflinger. When texture attached to fbo get glTexParameteri(GL_TEXTURE_SWIZZLE_R) call with different value, we should also not destroy/recreate framebuffers (in fact should not recreate VkImageView). We ran into this usage pattern on surfaceflinger. Bug: b/234769934 Bug: b/234602034 Change-Id: I9fc881486f95cc3da843f50fa0a8cdcbfd4fc625 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3681081 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi a9516865 2022-06-01T22:48:04 Vulkan: Output cache look up feedback in pipeline graph Bug: angleproject:6565 Change-Id: I12bb9ab5756860de9ba26d6b4a9429a78b65df39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3686029 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang bfab7e60 2022-06-01T11:22:42 Ignore eglBind/ReleaseTexImage calls for lost contexts. eglBindTexImage and eglReleaseTexImage no-op when no context is current. Extend this to lost contexts to match the behaviour of making a GL call on a lost context. This avoids potential unexpected bad accesses in the backends. Bug: chromium:1316578 Change-Id: I7b309c297e0c803019720733dee2950abb4c4b5f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3683869 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Alexis Hétu <sugoi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Lubosz Sarnecki ebdbae9b 2022-04-28T15:35:41 crash_handler_posix: Fix symbol path resolution. Use POSIX realpath function to resolve absolute paths of modules. Fix incorrect path resolution for libVkLayer_khronos_validation.so, which is given a relative path from the executable directory instead of cwd. Leave the treatment of overlapping paths in place, which is only required if a backtrace is triggered during the runtime of ScopedVkLoaderEnvironment. Remove symlink resolution, as it is done by using realpath. Print warning if symbol path cannot be resolved. This fixes the following error: /usr/bin/addr2line: '/home/user/angle/angle/angledata/../ libVkLayer_khronos_validation.so': No such file Bug: angleproject:7311 Change-Id: I46f4af93a4a27d8d09c3786933dbbb8390aa34eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3644584 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll ee338504 2022-06-03T07:00:37 Roll Chromium from 795b7900dc69 to 113f00d1a057 (497 revisions) https://chromium.googlesource.com/chromium/src.git/+log/795b7900dc69..113f00d1a057 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d95e42df71..a56852668f * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/86ab9dd743..125ac3cd81 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d857d1dbbe..6408b293c0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3a2e446a98 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8f1fea025d..04663d61d1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fd520dc44a..4e79fda976 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/09576ae257..1c2c24f809 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6b7d5a8e41..2ea3b1abfa No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I42b43272cf510646267d2853ab46ac53963a2fa3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3689050 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki cdad9363 2022-04-28T14:38:24 crash_handler_posix: Use execvp. To avoid using an absolute path for the addr2line executable, use execvp instead of execv to make the shell search for the executable in the PATH. Bug: angleproject:7310 Change-Id: I777e5f369011d910afffe86f8fb2372dc333a665 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3644582 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Kimmo Kinnunen 415ff51b 2021-12-17T17:20:25 Metal: Remove use of ANGLE_MTL_AUTORELEASE from mtl_state_cache The code doesn't use autoreleasepool, instead all instances are subsequently retained. Use AutoObjCPtr to adopt the reference and maintain ownership explicitly. This is work towards minimizing memory leaks by minimizing the use of autoreleasepool and accounting for the references explicitly. Bug: angleproject:6833 Change-Id: I77fe323683e4abb9b4ab17723949c56dd636ae32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3347643 Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: John Cunningham <johncunningham@apple.com>
Shahbaz Youssefi 53ec886e 2022-05-30T16:49:11 Vulkan: Externally synchronize the pipeline cache In preparation for a future change that requires this as it may perform pipeline cache merges during creation of pipelines. Bug: angleproject:5881 Change-Id: Ic7921b781aa773ae23b60a0bb6fa2111b1fc401e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3679479 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kyle Piddington 2f6dcf77 2022-06-01T14:51:47 Metal shaders fail to compile with "error: unknown type name 'uint' Replace 'uint' with uint32_t in emitted MSL. Some legacy configurations are showing compile errors when using this type. Bug: angleproject:7384 Change-Id: I7f262d417eaf46eed71da24e8b2c110b11677ab6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3684952 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Brandon Schade eb282de0 2022-05-20T18:36:46 Vulkan: Add feature to use VK_FILTER_LINEAR for YUVConversionInfo VK_FILTER_NEAREST is default for chromaFilter in ConversionInfo. Add feature to allow VK_FILTER_LINEAR to be used instead. This feature controls the quality when sampling YUV images. Bug: angleproject:7382 Change-Id: I3f67d7620d94b5b33c42754adfef84b97c798637 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3684351 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Trevor Black <vantablack@google.com> Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Brandon Schade <b.schade@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny bbf67e2e 2022-05-16T12:04:34 Capture/Replay: support capturing eglCreateImage/eglDestroyImage Because we support only a few functions the supporting code is not autogenerated. We don't capture the actual value of the display variable, because we assume that there is only one display, and the actual pointer to it is provided by the EGLWindow. The rest of the capturing works just like with the GLES calls. Bug: angleproject:4964 Bug: angleproject:5822 Bug: angleproject:6180 Bug: angleproject:6286 Bug: angleproject:6578 Bug: angleproject:7111 Change-Id: I385aa9648f93bf74706e9860e2aee5775eeba220 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3636062 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 73b7534b 2022-06-02T13:13:25 Vulkan: Suppress forced-xfb-emulation tests on pixel 6 ARM cannot support xfb emulation. Bug: angleproject:7376 Change-Id: If954ee7f5e4e049c107ac9fef1d84793a4c6d2b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3686618 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Gregg Tavares 94320a83 2022-05-27T17:41:29 Metal: Validate total bits used in color attachments Metal has 2 limits for color attachments. 1 the number of attachments supported. 2 the total number of bits it can write per pixel. So for example Apple4 through Apple8 GPUs can have 8 attachments but only 512bits of output. That means you can attach 8 RGBA8 textures (256bits), but you can't attach 8 RGBA32UI textures (1024bits). If there are too many bits then return FRAMEBUFFER_UNSUPPORTED from checkFramebufferStatus and INVALID_FRAMEBUFFER_OPERATION from draws Bug: angleproject:7280 Change-Id: I935aebad4d57664f59a60be20a927d6b69afb4ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3674322 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
angle-autoroll f8f84e49 2022-06-02T10:01:38 Roll SwiftShader from 466e443100e6 to ee0d0b41a626 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/466e443100e6..ee0d0b41a626 2022-06-02 srisser@google.com Extend SIMD::Pointer to use multiple full pointers 2022-06-01 sugoi@google.com Fix border comparison with depth 16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: If4fab223ce95f0a1ed47134a3b6054d8e97ea7ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3686144 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 67a8c198 2022-06-02T07:00:35 Roll Chromium from f6e0343d6b36 to 795b7900dc69 (491 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f6e0343d6b36..795b7900dc69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fb6ee3587b..d95e42df71 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/5e737be79c..86ab9dd743 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0ecc4fd019..d857d1dbbe * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1cac3deac8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e1197f06a8..8f1fea025d * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/393c871899..fd520dc44a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c07d80bf81..6b7d5a8e41 No update to Clang. Bug: angleproject:4394 Tbr: geofflang@google.com Change-Id: I5c6bab9933b2ecfd7e45b07e6b577675e575d978 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3685850 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kenneth Russell 6a0c779e 2022-06-01T14:43:41 Uptream Vivante and VMWare vendor ID recognition. Case-insensitively alphabetize the IDs and helper functions. Bug: angleproject:6839 Change-Id: Ib6746b3e6a8858e85b70c04424093ddbd02285fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3684955 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Gregg Tavares <gman@chromium.org>
Shahbaz Youssefi e04314fd 2022-05-30T01:09:31 Vulkan: Include state in pipeline graph dump Each program generates a group of nodes. The group's description is the common state among all nodes. Each node contains the diff with the shared state. Arrows between nodes indicate the GraphicsPipelineTransitionBits that have caused the transition. State that is 0 is not output for brevity. Bug: angleproject:6565 Change-Id: I7b6a95efcee63f1d7d368d8e062c5c1d221fb8b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3673829 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gregg Tavares 8a0351a5 2022-05-26T14:29:21 Metal:Dynamically choose max draw buffers. The code was hard coded to 4 which is lower than OpenGL's 8. This implementation keeps a hard coded array of size 8 in rx::mtl::RenderPassDesc and rx::mtl::RenderPipelineOutputDesc but only uses up to the display's limit. Bug: angleproject:7280 Bug: angleproject:5730 Change-Id: Idd7e64dc47697882b44540804159566158e1e924 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3671695 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Gregg Tavares 17f9e941 2022-06-01T15:22:29 Metal: Upstream clear performance fix Restricts in-flight render passes per command buffer a predefined limit. The goal is to reduce the number of active render passes on the system at any one time. Patch is from: https://bugs.webkit.org/show_bug.cgi?id=234008 Bug: angleproject:7386 Change-Id: I6712bf38722e2685ed7d21f12ed0a680779b7a41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3685190 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Gregg Tavares e70bea8a 2022-06-01T12:30:56 Metal: Update MAX_LOD_BIAS The Metal implementation set MAX_LOD_BIAS to 2.0 which is the minimum the spec requires but setting a limit requires the implementation to actually respect that limit. AFAIK the limit on most GPUs, including Metal, is however many mips are allowed thereby letting you select any mip level. Note that as far as I can tell, MAX_LOD_BIAS can be larger than the maxiumum number of mip levels but there's no way to observe that behavior. There is a WebGL test for this here https://github.com/KhronosGroup/WebGL/pull/3419 It passes on OpenGL and fails on Metal without this CL. Bug: angleproject:7280 Change-Id: I365cb5b3f872cd5036765f4eec932be1e2c07f8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3684356 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Faye Zhang 32a0ee92 2022-05-31T10:51:06 Code Cleanup In validationES.cpp, the framebuffer is required to have 0 depth bits (to conform to OpenGL ES 3.2 specifications). That is, ImageHelper::copyImageDataToBuffer() will not be called on a buffer with combined depth and stencil format. Replacing the lines relating to testing combined depth and stencil format ImageHelper::copyImageDataToBuffer() with an assert. Bug: angleproject:6856 Change-Id: I911500910b2065eb21c72d7f2d8ff481f4afa304 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3680862 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Faye Zhang <ffz@google.com>
Stephen White 6c0d4658 2022-05-27T15:32:42 D3D11: implement stencil texturing. When GL_DEPTH_STENCIL_TEXTURE_MODE is set to GL_STENCIL_INDEX, GL requires the stencil value to be in the R component. However, when sampling a depth24stencil8 texture in D3D11, the stencil ends up in the G component. So in this mode, swizzle the result from G to R. In order to sample stencil, use the appropriate stencil-only format for the SRV: X24_TYPELESS_G8_UINT for d24s8, X32_TYPELESS_G8X24_UINT for d32fs8. This required adding a new field to D3D11 Format. Bug: angleproject:7303 Change-Id: I7cf70efaaf6c833fa0b2497e4080618dfd7103ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3679485 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 28b4c378 2022-05-27T15:45:59 Vulkan: Pipeline creation feedback in perf counters Bug: angleproject:5881 Change-Id: I42917cab3c97abb50a14035972a96728dcb990b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3672851 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi b0d75fb5 2022-05-31T16:55:23 Vulkan: Use 64-bit counters Some upcoming counters don't fit in 32 bits. Bug: angleproject:5881 Change-Id: I2de8a603cabdb5f7417c29d5f37a50899485d6d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3679488 Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 53fb57a6 2022-05-31T12:13:59 Vulkan: Fix xfb emulation bug w.r.t array elements This change handles corner cases where the 0th element of the array is not captured. Bug: angleproject:7376 Change-Id: I358f064abe5e1702985ab0faf7465cef178e7b87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3679484 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 5a2cc71c 2022-06-01T12:06:07 Update extension support (June 1, 2022). Now includes data for Pixel 6 on Android 13. Bug: angleproject:7375 Change-Id: I115f8ead1cbfeb55b7314164409b262f58078ca5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3684029 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Roman Lavrov b03f2789 2022-05-31T20:31:23 Revert "Use a temporary timeout multipler for trace tests." This reverts commit f810e998993290f049bbdad4fae975e4867100ad. Reason for revert: Uploads are now sharded so this shouldn't be needed. Original change's description: > Use a temporary timeout multipler for trace tests. > > The trace tests upload is frequently timing out on our test infra > because of the size of the test suite. Until we can find a better > solution we can increase the timeout non-invasively using an > environment variable. > > Bug: angleproject:6854 > Change-Id: Ifbe43c4d9dc8928cf35df8a26b844f884c90eb9d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3427560 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:6854 Change-Id: Iaad7b63073ed900acdc575fbac927a8463b0c530 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3679487 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 4784f091 2022-06-01T10:01:32 Roll vulkan-deps from 59aa5963cf64 to 23b710f1a0b3 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/59aa5963cf64..23b710f1a0b3 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/7dda6a6347..316f12ac1d * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/5a12186692..b2a156e1c0 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/82d91083cb..b930e734ea * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/9308d2f8f1..5437a0854f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I330928595874f4051af88523abeb600e86614c5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3681712 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f5b3baf8 2022-06-01T10:01:38 Roll SwiftShader from 51c43dc015b7 to 466e443100e6 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/51c43dc015b7..466e443100e6 2022-06-01 srisser@google.com Make vk_pipeline dependent on Reactor 2022-05-31 capn@google.com Optimize SPIR-V matrix operations using FMA If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Id87757ae93298bde77017f87087a30a09a5ae107 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3681671 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e14cd370 2022-06-01T07:45:24 Roll Chromium from 85bb5555c93e to f6e0343d6b36 (473 revisions) https://chromium.googlesource.com/chromium/src.git/+log/85bb5555c93e..f6e0343d6b36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8682a2dc85..fb6ee3587b * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/1a14c57752..c30c515c84 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/74d0aac3e0..0ecc4fd019 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..fba169d2a9 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/10a8286824..e1197f06a8 * third_party/fuchsia-sdk/sdk: version:8.20220530.2.1..version:8.20220531.3.1 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/3631bb2b06..64bbf98854 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/33b5f23910..393c871899 * tools/luci-go: git_revision:7d578d09794d360f422427b0158e9515835f7ff3..git_revision:de014227dd270df7c61bfab740eb4ae4b52ac2a7 * tools/luci-go: git_revision:7d578d09794d360f422427b0158e9515835f7ff3..git_revision:de014227dd270df7c61bfab740eb4ae4b52ac2a7 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/43f13a9556..09576ae257 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cc84e3e7ea..c07d80bf81 * tools/skia_goldctl/linux: GsWjhyPQqwbT6QIxNBpT4HZ0vZ9GX1TJFj4xhn8vXJEC..l0eo0uR9oMGZFKDucYLGk3vdNGAunP4tGrDhIfzljdcC * tools/skia_goldctl/mac_amd64: Y4eZFQ4In9o62XNDt8Bj5qXWMuSAL5B0HZg60htg6agC..4shFavk40_bOJI9zUzvH2PaMW7tHKuxeEN0zik75F7sC * tools/skia_goldctl/mac_arm64: TBPqFTHfhhz2yYj5YQtWxBWJCJMMUgNIzrvwAl52ArUC..Ynx3axT8ZDN7Nl5pNwI5w8PCCt7jax5FGf8jcyjUzt4C * tools/skia_goldctl/win: c170fmb2DzbO95cdyA9VfLLBF2GI5LpkEEKDz7RtQAIC..7YFnDYPdgUOTWkaZe19LzWhmwWBuVMM9Q02sTDQtlkgC Clang version changed llvmorg-15-init-10717-ge00cbbec:llvmorg-15-init-11722-g3f3a235a Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/33b5f23910a183a245ef8a0f450ebf81c6dec9a0..393c871899747603524eb2af04d2a6136802e868/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: Icc70fd22e77017aacf9f52915f78699af1375206 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3681707 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 9800a3cf 2022-05-19T16:52:28 Add a test for imageLoad after glClear to the texture Bug: angleproject:7355 Change-Id: Ib1ddf685f2fa6cb24161615224971a7185234000 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3659504 Auto-Submit: Chris Dalton <chris@rive.app> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill da30caec 2022-05-26T13:35:24 Vulkan: Switch resource tracking. CommandBufferHelpers now determine if a Resource is busy by looking at the "ResourceCommandBuffers" list in each ResourceUse. This reduces CPU overhead in the Aztec Ruins trace by up to 3%. Bug: angleproject:5664 Change-Id: I8d927af7f39db38c98d746ca4cc01f343d0df2e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3668836 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 1ce69722 2022-05-18T13:05:22 Vulkan: Track used command buffers in ResourceUse. The list of command buffers to ResourceUse will replace tracking resources in a CommandBufferHelper. Currently the two tracking methods live side-by-side, and the old method will be removed in a future CL. Bug: angleproject:5664 Change-Id: Ia04d77e72c508e10b549db8c8dd5f0472e4edc83 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3656069 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Stephen White 43b5311f 2022-05-31T12:03:23 D3D11: minor cleanup to getSRVLevel(). Change getSRVLevel() to take an enum rather than a bool. Bug: angleproject:7303 Change-Id: I5b39b1b6e4f2f3f8a6bc8dd3f5690368f427f574 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3679482 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Geoff Lang b6a93d75 2022-05-31T12:20:37 GL: Temporarily enable validation for all GL calls. Turn on error checks after each GL call to catch potential driver errors in the wild. Bug: chromium:983167 Change-Id: Ie8b394384223155cd033baca19306396f406cdbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3679483 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org>
SeongHwan Park d96cee66 2022-05-31T02:41:32 Fix to invalidate cache when binding Transform Feedback. Bug: chromium:1330379 Change-Id: I091116286ac511c50f9abcffa4d3cf350be920b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3677115 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 86fce7a7 2022-05-31T10:01:38 Roll SwiftShader from d070309f7d15 to 51c43dc015b7 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/d070309f7d15..51c43dc015b7 2022-05-30 swiftshader.regress@gmail.com Regres: Update test lists @ d070309f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I77bb4b2d255c9a95185ae6625b5dfd961cdb0d61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3677611 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 31c13df5 2022-05-30T15:06:26 Revert "Initialize buffer contents separately from BufferImpl::setData" This reverts commit 34cff1a14b635c76a9063b8710e948d04ef98a79. Reason for revert: Speculative revert for Mac M1 WebGL failures. Bug: chromium:1330314 Original change's description: > Initialize buffer contents separately from BufferImpl::setData > > Some backends can initialize buffer data faster than allocating a > zero-filled scratch buffer (GL can map and memset for example). > Allow those backends the opportunity to make these optimizations. > > Verified that GL, D3D and VK backends do not regress by using a > separate set data call. > > Bug: chromium:983167 > Change-Id: Ibcbe6016059434dc36ab3c754df6a24f0a6e5e72 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3039778 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: chromium:983167 Change-Id: Id1bfa76b832c35fd0b3ade04da16735aa089fdd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3677335 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Peng Huang <penghuang@chromium.org>
angle-autoroll 213f669d 2022-05-31T07:01:03 Roll Chromium from 312583ebe76f to 85bb5555c93e (843 revisions) https://chromium.googlesource.com/chromium/src.git/+log/312583ebe76f..85bb5555c93e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8d050cb657..8682a2dc85 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c12bf52fc4..8b16338d17 * buildtools/linux64: git_revision:c547ca1497e3ff0dcbc0b2cb036b3d40380cbeeb..git_revision:37baefb026b199605affa7bcb24810d1724ce373 * buildtools/mac: git_revision:c547ca1497e3ff0dcbc0b2cb036b3d40380cbeeb..git_revision:37baefb026b199605affa7bcb24810d1724ce373 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e44a32df6a..1a14c57752 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/67bace775e..5e737be79c * buildtools/win: git_revision:c547ca1497e3ff0dcbc0b2cb036b3d40380cbeeb..git_revision:37baefb026b199605affa7bcb24810d1724ce373 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3bd2f1e7d8..74d0aac3e0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9717ac905b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ca53c90670..10a8286824 * third_party/fuchsia-sdk/sdk: version:8.20220526.2.1..version:8.20220530.2.1 * third_party/r8: ovozeRSDDfERnEFpDo_WS6OYOcEF7oT1JzGxCSf-g0kC..L2ZGhyJ-Hc8AnXHo5dhtNdI2F2bC_9yi2lqTbJ98sLcC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/0e6b3ca1fa..3631bb2b06 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a638713fe8..33b5f23910 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/64bc84e12b..43f13a9556 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/aa17e00c3a..f8a4cfe4f9 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ddb3f5e1ec..cc84e3e7ea Clang version changed llvmorg-15-init-11359-gca27f3e3:llvmorg-15-init-10717-ge00cbbec Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/a638713fe87f95be1b0836e6ade837d139a62e78..33b5f23910a183a245ef8a0f450ebf81c6dec9a0/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: I510f6340d205ac0bba26a332740e0502dd6f6bab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3677326 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 0b533e64 2022-05-30T13:09:17 Make GLProgram non-copyable. This will prevent unexpected glDeleteProgram calls from showing up. Found when working in FramebufferFetchTest. Bug: angleproject:7375 Change-Id: Id0f01d693a40edd3357a26fe13e7a7e0c1b98dd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3673828 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 9f4b9c65 2022-05-18T14:39:18 Vulkan: Refactor command buffer retain calls. This removes "getResourceUseList" from the command buffers, and instead we pass around the command buffer helpers. Since future CLs will change the way we track resources, this provides for a more stable interface for tracking. Bug: angleproject:5664 Change-Id: I7118788570eaa3c0ddb6d5ef523e050ad7be00ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645814 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll ae74bdb3 2022-05-30T12:19:32 Roll vulkan-deps from 528f7d8e618c to 59aa5963cf64 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/528f7d8e618c..59aa5963cf64 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/3f855646f0..50b4d5389b * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/4676775702..9308d2f8f1 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7eadb7b666..c97b4d7293 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I89139f93febd11a9d22bb28ce2409aa23d082191 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3676677 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 33b254fe 2022-05-28T00:00:00 Fix ValidateFragmentShaderColorBufferMaskMatch for indexed masks Adjust WebGL-specific validation, add test. Bug: angleproject:4394 Change-Id: I4d51d6d7639a4ec3115025c858434491845440a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3673298 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll e0284808 2022-05-30T12:18:38 Roll SwiftShader from 5ca5b0ae5a7d to d070309f7d15 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/5ca5b0ae5a7d..d070309f7d15 2022-05-27 capn@google.com Add a pragma option to zero-initialize Reactor local variables 2022-05-27 capn@google.com Provide access to TLS variables for origin tracking 2022-05-27 swiftshader.regress@gmail.com Regres: Update test lists @ 5ca5b0ae 2022-05-27 nicolascapens@google.com Merge changes I10d8c713,Ib474fd28 2022-05-27 sugoi@google.com Fix SpirvShader::Interpolate() for Centroid without multisampling If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I22ec9972a9c797072fd3bea15c482d016430272f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3675049 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 23f213d1 2022-05-26T23:43:44 Vulkan: Make drawable size uniform As a specialization constant, it's impossible to predict the value the drawable size may take, which in turn makes it impossible to warm up the Vulkan pipeline cache at link time. Bug: angleproject:7366 Change-Id: Ia3d1860a4fcb8e3078fdcb8d02a2e0cd173ea028 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3671976 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 73019ede 2022-05-27T14:15:51 Vulkan: SPIR-V Gen: No RelaxedPrecision on bitCount() and findLSB() Similarly to findMSB(), RelaxedPrecision shouldn't be applied to these instructions. They return lowp, but RelaxedPrecision affects the parameters as well. Bug: b/234143723 Change-Id: Iab7c1c0497bbc832569ced7456eaefbf52d796d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3672847 Reviewed-by: Chia-I Wu <olv@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi a2fe4445 2022-05-26T12:42:39 Vulkan: Sync pipeline cache only when truly changed The Vulkan pipeline cache was considered dirty when ANGLE added a new pipeline. However, a new pipeline doesn't necessarily translate to new blobs in the pipeline cache. With this change, the cache is synced only if its size has changed. Bug: angleproject:5881 Change-Id: I0226426680f1e6b0e2bfde66ea6409362b8e72c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3668835 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
kmx.io     mail     discord kmxgit v0.4.0