|
e2031e72
|
2024-03-29T07:01:17
|
|
Roll Chromium from 47e3c979a2ee to 647be67fd3b9 (581 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/47e3c979a2ee..647be67fd3b9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* buildtools/linux64: git_revision:cfddfffb7913868936e76a269ae824aadd737b1b..git_revision:93ee9b91423c1f1f53fb5f6cba7b8eef6247a564
* buildtools/mac: git_revision:cfddfffb7913868936e76a269ae824aadd737b1b..git_revision:93ee9b91423c1f1f53fb5f6cba7b8eef6247a564
* buildtools/win: git_revision:cfddfffb7913868936e76a269ae824aadd737b1b..git_revision:93ee9b91423c1f1f53fb5f6cba7b8eef6247a564
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3bbd3b134a..9e0b2c837a
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6afa4087bd..6abf8f51e0
* third_party/fuchsia-sdk/sdk: version:19.20240320.0.1..version:19.20240328.3.1
* third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ec88f0ab26..1317096ef8
* third_party/r8: cR2jywy_AWBarfoCAaRnIWirBjBE_RMzaO0D9dbdaIUC..hzpETAalflyclh8qC2FYlsWKW71kXMBtn_pQ6M3wqz8C
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/41dfe5d7d2..279d79a374
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/056d41d38a..c7a92ea96b
No update to Clang.
Bug: None
Tbr: solti@google.com
Change-Id: If67f540b4ca9f840e0cae7f1791ecafba1be24b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406622
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
936ba770
|
2024-03-29T10:01:18
|
|
Roll vulkan-deps from 4f5c3553ddc3 to b203847466b0 (22 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/4f5c3553ddc3..b203847466b0
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/3225778615..8c0199c4fd
* spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/7d500c4d75..4f7b471f1a
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fe7bae0906..87721a1009
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/e3f8bd7aa6..3617af2881
* vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/d90f5c7eb1..cdd0e00cff
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ea5117b517..242b6f33a6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Change-Id: I12cdc3c49bf4b5489c042764c58a6b34c3358f49
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406484
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
414c989e
|
2024-03-29T10:01:43
|
|
Roll SwiftShader from 6912e7d5b75a to ff61926fcedb (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/6912e7d5b75a..ff61926fcedb
2024-03-28 rsworktech@outlook.com split source files with the same
case-insensentive name into different source sets
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: I5b2a590a875038bbbf384ad0177a892feb543c03
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5405531
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
2b66694d
|
2024-03-28T00:00:00
|
|
Metal: Untangle public draw calls
Do not call public Metal backend
draw commands from itself.
Bug: angleproject:8630
Change-Id: I7c0e016dc0eb3365520cdb39db215e4233e0d9fa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5401865
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Auto-Submit: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
076a5059
|
2024-03-28T10:15:42
|
|
Remove test suppression of dEQP-EGL*robustness on Pixel 6
Previoustly the tests dEQP-EGL*robustness*out_of_bounds_non_robust*
were skipped on Pixel 6, because the test is intentionally testing
in GLES, shader write out of bounds access results in undefined
behavior. In ANGLE vulkan backend, shader write out-of-bounds
access results in vulkan device lost on Pixel 6, which is a valid
undefined vulkan behavior according to spec. However, VVL is
reporting errors when ANGLE cleans up vulkan resources, because
they haven't finished execution on GPU.
With below VVL changes landed:
https://github.com/KhronosGroup/Vulkan-ValidationLayers/commit/9452b82820276eb3eb2102bf49b72e59916d3ea7
https://github.com/KhronosGroup/Vulkan-ValidationLayers/commit/af257b1c55f312b550addeca091265c249c09cf3
VVL now checks if there is a vulkan device lost upon resource
clean-up. If the vulkan device is lost, even if the resource
has not finished execution, treat resource clean up as a safe
vulkan operation and do not report VVL error.
Bug: b/289544394
Change-Id: I9d3532d4d6b0c3a1cdfd8837e13b4527d0dfbd7a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5403212
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
b559efa8
|
2024-03-26T22:02:41
|
|
Vulkan: Allow depth and stencil resolve to be separately added
In preparation for optimizing resolve through glBlitFramebuffer for
depth/stencil attachments.
Bug: angleproject:7551
Change-Id: I57650d82c0cc6e56f44591eadfc42ac794cfef09
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5399140
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
84eb4f73
|
2024-03-26T15:44:48
|
|
Add a few use-after-resolve depth/stencil framebuffer tests
Bug: angleproject:7551
Change-Id: I42c1a6b8fe8714fd9c1568d216b12ee9a001aba5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5399137
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
a0fa06f6
|
2024-03-25T14:46:56
|
|
Translator: Disallow samplers in structs in interface blocks
As disallowed by the spec:
> Types and declarators are the same as for other uniform variable
> declarations outside blocks, with these exceptions:
>
> * opaque types are not allowed
Bug: chromium:328859176
Change-Id: Ib94977860102329e520e635c3757827c93ca2163
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5391986
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
c5ba9b6c
|
2024-03-28T15:38:03
|
|
Manual roll SwiftShader from 0bacc751b4d1 to 6912e7d5b75a (2 revisions)
Manual roll requested by syoussefi@google.com
https://swiftshader.googlesource.com/SwiftShader.git/+log/0bacc751b4d1..6912e7d5b75a
2024-03-28 syoussefi@google.com Fix alignment bug with depth/stencil
resolve attachment
2024-03-28 rsworktech@outlook.com fix debug build with llvm 16
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC angle-team@google.com,solti@google.com,syoussefi@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:7551
Tbr: solti@google.com,syoussefi@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: Id5300525d24dff1f014a9ea41186721d45b9336c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5405492
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b4cf07c3
|
2024-03-27T15:58:04
|
|
Vulkan: Move the interface pipeline library caches to share group
When linking libraries into a pipeline, the linked pipeline lives in
ProgramExecutableVk and may be shared between contexts in a share group.
The caches for the vertex input and fragment output libraries thus
cannot live in the context, but should remain alive until all contexts
in the share group are destroyed.
This change moves these caches to the share group.
Bug: angleproject:8629
Change-Id: I2f7edf44d676505cf5e7e24640c6850c67f8b5e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5401514
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
c71a67de
|
2024-03-27T15:50:00
|
|
Vulkan: Move pipeline cache graph dump to renderer
In preparation for moving some caches to the share group.
Bug: angleproject:6565
Bug: angleproject:8629
Change-Id: I1a06a18417502e499da0edb9abb0d510e3ad99ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5401513
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: mohan maiya <m.maiya@samsung.com>
|
|
|
0e9254bd
|
2024-03-25T16:37:51
|
|
Vulkan: Optimize color invalidates
By not flushing the render pass when there is an invalidate.
Previously, the tracking of invalidation, write to attachments,
management of load/store ops, and whether image contents are defined or
not have all been unified between color and depth/stencil images.
As such, it is possible to not close the render pass when a color image
is invalidated just as is not done for depth/stencil images. Together
with the optimization to resolve attachments [1], it is now finally
possible to efficiently do MSAA rendering with ANGLE.
Note that the optimization to use resolve attachments for depth/stencil
is not yet implemented. For color only, the perf test added in [2]
shows the following improvement on Pixel 6:
- Single sampled rendering: ~2.73ms
- Resolve + invalidate (before optimizations): ~3.54ms
- Resolve + invalidate (after this change): ~2.85ms
[1]: https://chromium-review.googlesource.com/c/angle/angle/+/5388492
[2]: https://chromium-review.googlesource.com/c/angle/angle/+/5392548
Bug: angleproject:7551
Change-Id: I008adf9f53df97ab464b0a0399f0b312bf4d0d3f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5391905
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
21b6899a
|
2024-03-28T10:01:24
|
|
Roll SwiftShader from bbe6452b420c to 0bacc751b4d1 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/bbe6452b420c..0bacc751b4d1
2024-03-28 syoussefi@google.com Fix crash in asserts with
VK_EXT_vertex_input_dynamic_state
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: I6a4cbfba2b6aafd6edf82b5bd7f5cb532e4b07f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5404927
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
3c8b3f6b
|
2024-03-26T17:07:39
|
|
Start Mac AMD experiment
Bug: chromium:327017900, angleproject:8628
Change-Id: I7b108c724eaa6f5ff7b8098c256c6e4a47578b5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5399719
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
fb4f2142
|
2024-03-28T09:07:33
|
|
Roll Chromium from 3d9d6f707e2b to 47e3c979a2ee (692 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/3d9d6f707e2b..47e3c979a2ee
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4bcca7be94..8919328651
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/4c83a8c553..3bbd3b134a
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7c64299944..6afa4087bd
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/79cfa048c0..a5c46d2047
* third_party/r8: 7ehFNNRB1oBj36LLbab2DFgn-COWZyOpNbEWT5wggLoC..cR2jywy_AWBarfoCAaRnIWirBjBE_RMzaO0D9dbdaIUC
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/5e488ec77d..fd1a0bcf3b
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d50741b1b6..41dfe5d7d2
* tools/luci-go: git_revision:7dd3e0506c6083aae7a0e413a30e0e11b76da08e..git_revision:a84377ac0800e2330d02c3dcbf7b4b74a06d6a5b
* tools/luci-go: git_revision:7dd3e0506c6083aae7a0e413a30e0e11b76da08e..git_revision:a84377ac0800e2330d02c3dcbf7b4b74a06d6a5b
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2083ef769c..056d41d38a
* tools/skia_goldctl/linux: 99yLozEj_tyDp8qTdMy-BwtOaV0vLq-BveFIgCWd3NYC..KWFqqlbpL444cdU7-tRTLQk4tzJxBh14-JnPM1-PUckC
* tools/skia_goldctl/mac_amd64: pgF7oaiQoZXpDmbfBxIA2Oqt4FWD44Pix9CqetNS7iUC..IdI7fZD-WzcVF9Bfz4bt_USGavHlMY1Gw--gCrsCY34C
* tools/skia_goldctl/mac_arm64: YXM0Gt4bBW5NsQmjlxQu1xjW-KeFxgRV-vylz7J0LawC..KtpuilcMQs7fnn_O-1Ks02eD8pKsx66u8LwH9jCqCowC
* tools/skia_goldctl/win: PWJ1a9WbPS3mXZYg62Mz2Lvdo_AGrnkgqNGdTyAkg2QC..-_l0Nfk8kZU9G9AOIZx2BfNeHW95wqOJa3C4TWmXlpoC
No update to Clang.
Bug: None
Tbr: solti@google.com
Change-Id: I418b849893d8ac8e44de072800566b1e2c08f8b8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5404747
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
9475ac40
|
2023-11-15T10:25:06
|
|
Vulkan: Make efficient MSAA resolve possible
Prior to this change, using a resolve attachment to implement resolve
through glBlitFramebuffer was done by temporarily modifying the source
FramebufferVk's framebuffer description. This caused a good deal of
complexity; enough to require the render pass to be immediately closed
after this optimization.
The downsides to this are:
- Only one attachment can be efficiently resolved
- There is no chance for the MSAA attachment to be invalidated
In this change, resolve attachments that are added because of
glBlitFramebuffer are stored in the command buffer, with the
FramebufferVk completely oblivious to them. When the render pass is
closed, either the FramebufferVk's original framebuffer object is used
(if no resolve attachments are added) or a temporary one is created to
include those resolve attachments.
With the above method, the render pass is able to accumulate many
resolve attachments as well as have its MSAA attachments be invalidated
before it is flushed.
For a FramebufferVk that is resolved in this way, there used to be two
framebuffers created each time and thrown away as the code alternated
between starting a render pass without a resolve attachment and then
closing with one. With this change, there is now one framebuffer
(without resolve attachments) that is cached in FramebufferVk (and is
not recreated every time), and only the framebuffer with resolve
attachments is recreated every time.
Ultimatley, when VK_KHR_dynamic_rendering is implemented in ANGLE, there
would be no framebuffers to create and destroy, and this change paves
the way for that support too.
WindowSurfaceVk framebuffers are still imagefull. Making them imageless
adds unnecessary complication with no benefit.
-----------------
To achieve efficient MSAA rendering on tiling hardware, applications
should do the following:
```
glBindFramebuffer(GL_FRAMEBUFFER, msaaFBO);
// Clear the framebuffer to avoid a load
// Or invalidate, if not needed to load:
// glInvalidateFramebuffer(GL_DRAW_FRAMEBUFFER, ...);
glClear(...);
// Draw calls
// Resolve into the single sampled framebuffer
glBindFramebuffer(GL_DRAW_FRAMEBUFFER, resolveFBO);
glBlitFramebuffer(...);
// Immediately discard the contents of the MSAA buffer, to avoid store
glInvalidateFramebuffer(GL_READ_FRAMEBUFFER, ...);
```
The above would translate to the following Vulkan render pass:
- MSAA LOAD_OP_CLEAR/DONT_CARE
- MSAA STORE_OP_DONT_CARE
- Resolve LOAD_OP_DONT_CARE
- Resolve STORE_OP_STORE
This makes sure the MSAA data doesn't leave the tile memory and greatly
reduces bandwidth usage.
Once anglebug.com/4892 is fixed, this would also allow the MSAA image
to never be allocated either.
Bug: angleproject:7551
Bug: angleproject:8625
Change-Id: Ia9f4d20863d76a013d8495033f95c7b39f77e062
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5388492
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
085ff15a
|
2024-03-26T03:33:26
|
|
Metal: Fix RenderTargetMtl::getFormat() could return nullptr.
Bug: b/326301256
Change-Id: Ia8914e4bc77e34bd510661689837b97d5de82d92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5394149
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
|
|
71e5a43f
|
2024-03-26T14:03:14
|
|
FrameCapture: Don't use shadow memory on Pixel after Android 14
The platform bug that required shadow memory to track changes to
coherent mapped buffers has been fixed in Android 14.
mprotect now works on Vulkan surfaces.
Test: MEC with title using coherent buffers
Bug: angleproject:7402
Bug: b/269535398
Change-Id: I370f29ee7d033b19facf48cfd76576950c39b735
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5399117
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Reviewed-by: Mike Schuchardt <mikes@lunarg.com>
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
|
|
|
0156fe4e
|
2024-03-27T10:02:00
|
|
Roll vulkan-deps from 3bf81e7e8859 to 4f5c3553ddc3 (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/3bf81e7e8859..4f5c3553ddc3
Changed dependencies:
* vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/4befdac21a..d90f5c7eb1
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2ac49e5c08..ea5117b517
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Change-Id: I2c48a2d337b3569c308cab3f2f5bd9e135ae90be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5400501
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
e045b846
|
2024-03-27T07:50:13
|
|
Roll Chromium from df4e4b8f57ca to 3d9d6f707e2b (330 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/df4e4b8f57ca..3d9d6f707e2b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* buildtools/linux64: git_revision:06cdcc8e1fa8e56f70efb4357d473345b7d1c083..git_revision:cfddfffb7913868936e76a269ae824aadd737b1b
* buildtools/mac: git_revision:06cdcc8e1fa8e56f70efb4357d473345b7d1c083..git_revision:cfddfffb7913868936e76a269ae824aadd737b1b
* buildtools/win: git_revision:06cdcc8e1fa8e56f70efb4357d473345b7d1c083..git_revision:cfddfffb7913868936e76a269ae824aadd737b1b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/a3f40dd8f3..4c83a8c553
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3689639e9f..79cfa048c0
* third_party/siso: git_revision:a3d591f9996c1b28fe5762913bb5bbd69960e4d5..git_revision:3ccd47200355e0a6fc7fecf6b16aba559d26e23c
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/24c07df503..30bf3a72e7
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6006c032bb..2083ef769c
No update to Clang.
Bug: None
Tbr: solti@google.com
Change-Id: If38f0d68c297dd639d06221d7150ee2b4c92ab20
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5399726
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
8e7d3379
|
2024-03-25T22:09:44
|
|
Vulkan: Add a perf test for multisample resolve + invalidate
Bug: angleproject:7551
Change-Id: I1d45e720a6273650aaebd98aade9b363a804e886
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5392548
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
7eac8f60
|
2024-03-26T22:10:57
|
|
Manual roll VK-GL-CTS from ec9827528085 to fe6e7bd09f53 (1 revision)
Manual roll requested by solti@google.com
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ec9827528085..fe6e7bd09f53
2024-03-20 michal.jakubek@mobica.com FS output interface tests with
multiple attachments
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Change-Id: I130424c7306b490b05a8000cf78b4273813c2479
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5397514
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
2cddd918
|
2024-03-26T21:19:26
|
|
Manual roll vulkan-deps from ba66ec69216d to 3bf81e7e8859 (57 revisions)
Manual roll requested by solti@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/ba66ec69216d..3bf81e7e8859
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b047a21033..3225778615
* spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/8b246ff75c..7d500c4d75
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6c3f632a2c..fe7bae0906
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/577baa0503..cfebfc96b2
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/61a9c50248..f60412f5a6
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/e5f1de8968..e3f8bd7aa6
* vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/a4140c5fd4..4befdac21a
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/57084b5d12..2ac49e5c08
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Change-Id: I413f95419a19b9457696f30902c66f69f9dba142
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5397509
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
856054c4
|
2024-03-26T16:32:41
|
|
Trace tests: fix run_angle_android_test.py --prepare-only
Bug: b/292249127
Change-Id: Ied2b65c84f6cebe4d6d75d91910f9f124288e487
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5399138
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Roman Lavrov <romanl@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
beae7959
|
2024-03-26T11:12:15
|
|
Implement a basic setImage to TextureWgpu.
Bug: angleproject:8457
Change-Id: I62d7996b0492aa5dccfbc95892b5edc5cc05b20d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5392381
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Liza Burakova <liza@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
|
|
|
ee3bbdcb
|
2024-03-26T18:41:49
|
|
Manual roll Chromium from f5acbff8b8b2 to df4e4b8f57ca (1013 revisions)
Manual roll requested by ynovikov@google.com
https://chromium.googlesource.com/chromium/src.git/+log/f5acbff8b8b2..df4e4b8f57ca
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/3fb3d59ff7..4bcca7be94
* buildtools/reclient: re_client_version:0.136.1.732f8b5-gomaip..re_client_version:0.134.1.2c9285b-gomaip
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/790b64db04..a3f40dd8f3
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/949df6114f..7c64299944
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1cba129f31..3689639e9f
* third_party/r8: nB1Wwa_24Z-187iGmdHqyghl0vGR2QEbt8HiBKfSq2YC..7ehFNNRB1oBj36LLbab2DFgn-COWZyOpNbEWT5wggLoC
* third_party/turbine: D9u_Hp4Dkt63hBSf5_oNk-Y7bOLGC7toa6H9cJ3rNokC..JYrlFcNFCmJoG4mYco1fxSNuhgASzU-EdBb4_Bd2-z0C
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/f2b31d0394..5e488ec77d
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b341c2ddaa..d50741b1b6
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/023fac3e08..85f56412dc
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/91cdef4a4b..6006c032bb
No update to Clang.
Bug: None
Tbr: solti@google.com,ynovikov@google.com
Change-Id: Ibcd8e6e820b1805591cbcd485d9f8d553dd3ae31
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5397500
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
1d5991d9
|
2024-03-26T16:36:23
|
|
Pin libc++ until Skia is able to build with ToT abseil.
ANGLE pins abseil-cpp until https://skbug.com/330350366 is resolved.
Therefore ANGLE's abseil-cpp uses old DEF files, which can't be kept in
sync with new libc++, e.g. here:
https://chromium-review.googlesource.com/c/angle/angle/+/5391204/1
Bug: angleproject:8555
Change-Id: Ib61a80136e389ffbd67c7c378a5c8d9c2659be55
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5397577
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Solti Ho <solti@google.com>
Commit-Queue: Solti Ho <solti@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
28ec2b7b
|
2024-03-25T07:00:45
|
|
Roll Chromium from 532d52d6ecb3 to f5acbff8b8b2 (746 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/532d52d6ecb3..f5acbff8b8b2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,romanl@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ca4997ede8..3fb3d59ff7
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/2d8b73eef3..790b64db04
* third_party/android_build_tools/lint: vOJ_HEQatXdtUPfHOB4Ufx0g6EoO7xoqRyjdX6Va3M4C..RCWuMX-9cBwhFgVJC0Sf9UXIGz20O_jrrbK2FHfSbi0C
* third_party/android_build_tools/manifest_merger: vWAq6qe8wYWJCLx3jyN9qc7R6xKUROuGwk7SNoqAtuYC..HxnrwdWmIAhi90brIHiGZ4zmnmgKxP4PD0ZsJX6j-mUC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/00b12925a3..949df6114f
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/880c680f58..1cba129f31
* third_party/r8: c4Is2W2sB6esxLC3SJBS62sqgvCTA52FxUhTirl3Ku8C..nB1Wwa_24Z-187iGmdHqyghl0vGR2QEbt8HiBKfSq2YC
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cda76dc28d..91cdef4a4b
No update to Clang.
Bug: None
Change-Id: I7999ea6fb751ef22f1a6dc6d3a4094425cac837a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5391204
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
0add1163
|
2024-03-25T11:39:41
|
|
Move extent and dimension conversions to wgpu_utils.
This change moves some helper methods out of the ImageHelper and
wgpu_helpers and into wgpu_utils.
Bug: angleproject:8457
Change-Id: I1cc641e4a48eec30519e331b6150e2432d3bc3c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5392380
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Commit-Queue: Liza Burakova <liza@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
aa04191b
|
2024-03-25T15:51:39
|
|
Start Win Intel experiment
Bug: chromium:41496254
Change-Id: I993bfcb38e8922461f98005825e94b5d79c9c6af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5393848
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
|
|
|
93da22dd
|
2024-03-22T16:10:51
|
|
use_cxx17=true in arm debug compile
Android rolls currently require C++17,
set ANGLE to C++17 to prevent Android roller breakage
Bug: b/330910097
Change-Id: I94ef05f91a3532a42876e27b296342552aede974
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5387270
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
eacd6acd
|
2024-03-22T05:38:13
|
|
Add RenderTargetCache to FramebufferWgpu
...and update it based on dirty bits.
Bug: angleproject:8582
Change-Id: If227392b24b3fc649d48cb1bce1144400cd98d70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5386900
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
|
|
|
c7985668
|
2024-03-19T15:52:01
|
|
Add a few use-after-resolve framebuffer tests
Bug: angleproject:7551
Bug: b/330697097
Change-Id: I0006d80edc0162182b2da9cea2c0e719f90fa8e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5376619
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
e996d187
|
2024-03-19T13:29:24
|
|
Use TIntermRebuild for SeparateStructFromFunctionDeclarations
This now handles the case of nested function calls to functions that
define a struct in the return type all resolving to the correct
re-written function.
Bug: chromium:329271490
Change-Id: I43904e09ec9c284c1b51c09b2caaab253f7b29b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5376613
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
2d4a027d
|
2024-03-20T12:07:45
|
|
Tests: Add Poppy Playtime Trace
Test: angle_trace_tests --gtest_filter=TraceTest.poppy_playtime
Bug: b/330861486
Change-Id: Ifd18ec32bce1db585bb4d284a39ed78a94932d8f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5387536
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
318e5e02
|
2024-03-24T08:17:56
|
|
Vulkan: Update EGL_EXT_buffer_age implementation
1. Buffer age is always 1 when swap behavior is EGL_BUFFER_PRESERVED.
2. WindowSurfaceVk::getBufferAge no longer acquires a swapchain image.
See commit: b46cf6989f6fe8db5f0759001f633681a96fadde
3. It is valid to pass attributes of eglQuerySurface API to
eglQuerySurface64KHR API
4. Add deadlock fix to eglQuerySurface64KHR
Bug: angleproject:3529
Bug: angleproject:6851
Tests: EGLLockSurface3Test.QuerySurfaceAndQuerySurface64Parity*
Tests: EGLBufferAgeTest.QueryBufferAge*
Change-Id: Idf3c4fc08364f671fb02e99111be2beb7a1d9f3d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5389461
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8482f44f
|
2024-03-25T12:21:48
|
|
android_helper cleanup: Inline test package name
We continue using a single package name, inlining makes code easier to
follow
Bug: b/331179435
Change-Id: I45e42ba313a3cfaf97f00e1aeef4dcc3b5f9aedf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5391983
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
3ed8c5f4
|
2024-03-07T16:05:26
|
|
Android: workaround broken run-as due to /data permissions
Bug: b/331179435
Change-Id: I4617b1724e08ad8ab24a91ac1378132fb6641be0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5354107
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
96f44329
|
2024-03-25T14:16:10
|
|
Revert "Remove few redundant ImmutableString to std::string conversions"
This reverts commit ebb94b807f184f2d36cb0843c429667cd80e0675.
Reason for revert: Needs a different implementation of
std::string::size() to pass C++17 compilers.
Original change's description:
> Remove few redundant ImmutableString to std::string conversions
>
> Maybe removes few strlen calls.
>
> Bug: angleproject:8614
> Change-Id: I4fbb5f6abb8e8d21ff44a34975bab379127a0a11
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5372715
> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Bug: angleproject:8614
Change-Id: I1a635b74674a2e1b635972bb4372c43340527a2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5391900
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
ee02014d
|
2024-03-22T11:52:35
|
|
Selectively wait for LinkSubTasks
Backends have the option to request frontend to run their LinkSubTask
post-link. Do not wait for such sub tasks during most glProgram APIs.
Note that we do wait for these "post-link sub tasks" incase of a program
relink or first use by a draw call.
Bug: angleproject:8297
Change-Id: I936fb5a127570f9dfa567ee8cbc02e25c4b70a6b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5387064
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
16fef70f
|
2024-03-22T12:09:12
|
|
Vulkan: Refactor imageless framebuffer creation
Bug: angleproject:7551
Change-Id: I6789123d1b854a64ce405dd1e096b9c28a227b5f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5384139
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
1bd82319
|
2024-03-22T05:00:11
|
|
Add RenderTargetWgpu
Based on RenderTargetMtl without any multisampling support for now.
Bug: angleproject:8582
Change-Id: I4c77e747b341f08a0dd88f507e6d805d34a01d24
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5386899
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
|
|
a53bd62a
|
2024-03-21T14:51:29
|
|
Disable MSRTSS on QCOM
Currently, some QCOM devices supporting MSRTSS allocate extra memory
for all images when this feature is enabled, even if those images do
not use this feature.
* Disabled supportsMultisampledRenderToSingleSampled on QCOM devices.
Bug: b/329911999
Change-Id: I3cfa4c4e7e3c8160ca240c492e5f29e982884f0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5386331
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
33a09305
|
2024-03-22T11:10:05
|
|
Metal: Remove work texture and work buffer from ContextMtl
These objects did not have lifetime management and would persist
until the destruction of the context which added significant memory
overhead when clients use many contexts.
Allocate them specifically for the ReadPixels call and destroy them
when finished.
Bug: chromium:330163368
Change-Id: I95e2c11e14fb4ad0728850a7a0fabcf53916b9ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5388258
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
0197826b
|
2024-03-22T14:42:34
|
|
Revert "Add conversion operator from ImmutableString to std::string"
This reverts commit 8c0dae388bccb00f11cd94d641d719cc68325826.
Reason for revert:
Breaks Android rolls:
external/angle/src/compiler/translator/ImmutableString.h:103:15: error: constexpr function's return type 'std::string' (aka 'basic_string<char, char_traits<char>, allocator<char>>') is not a literal type
103 | constexpr operator std::string() const { return std::string(data(), length()); }
| ^
external/libcxx/include/string:4332:64: note: 'basic_string<char>' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
4332 | _LIBCPP_EXTERN_TEMPLATE(class _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS basic_string<char>)
Original change's description:
> Add conversion operator from ImmutableString to std::string
>
> Also use the operator in a couple of places. Sometimes saves a strlen.
>
> Bug: angleproject:8614
> Change-Id: I429f3ac02af04b568ac7d1adf22ab65e5007fbda
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5372728
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: angleproject:8614
Change-Id: I46963686f9506f7029e164250b1bf81f8ab2c519
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5388255
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
9ae4a2f4
|
2024-03-22T07:00:38
|
|
Roll Chromium from babb076716bc to 532d52d6ecb3 (627 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/babb076716bc..532d52d6ecb3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,romanl@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* buildtools/linux64: git_revision:22581fb46c0c0c9530caa67149ee4dd8811063cf..git_revision:06cdcc8e1fa8e56f70efb4357d473345b7d1c083
* buildtools/mac: git_revision:22581fb46c0c0c9530caa67149ee4dd8811063cf..git_revision:06cdcc8e1fa8e56f70efb4357d473345b7d1c083
* buildtools/win: git_revision:22581fb46c0c0c9530caa67149ee4dd8811063cf..git_revision:06cdcc8e1fa8e56f70efb4357d473345b7d1c083
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/142daf508b..2d8b73eef3
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5b5e74bd2e..00b12925a3
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6551a7eb43..880c680f58
* third_party/r8: hV5qI1hGWY_S97KZl3WdM1D6g3pCTQ1N8yK8v6qPPFMC..c4Is2W2sB6esxLC3SJBS62sqgvCTA52FxUhTirl3Ku8C
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b0a8598fb9..cda76dc28d
No update to Clang.
Bug: None
Tbr: romanl@google.com
Change-Id: I40a36a466e5b0ac90f373d1bab718d0ad6cd0443
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5385697
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
ad013650
|
2024-03-22T03:42:44
|
|
Revert "Rename LinkSubTask -> PostLinkTask"
This reverts commit 00eb6edba074a22389b09990ab856adfd417dd64.
Reason for revert: Sub tasks are not actually post-link tasks for all
the other backends (other than Vulkan), but they are a real part of
the link job.
Original change's description:
> Rename LinkSubTask -> PostLinkTask
>
> This is a renaming change, no behavior changes are expected.
>
> Bug: angleproject:8297
> Change-Id: I734c7959f5ed6db2447853cc6f6256e3c8e86213
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5382224
> Commit-Queue: mohan maiya <m.maiya@samsung.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: angleproject:8297
Change-Id: Iaebf9d165d810344bfc524042206ca427d270034
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5386432
Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8899e18d
|
2024-03-21T14:30:50
|
|
Add skip conditions for a few tests
1. Skip EGLBlobCacheTest if `CacheCompiledShader` feature is disabled
2. Skip RGBAHBUploadDataColorspace test if allocating RGB8 AHB with
requested usage flag is not supported
Bug: angleproject:7036
Bug: b/298037344
Change-Id: I07c48df327a879c1d46873f47bb5bd305e07a758
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5386030
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
f3a819f1
|
2024-03-21T08:12:09
|
|
Context: Limit max texture size for ANGLE captures
Tracing Poppy Playtime generates glTexStorage2D calls
with widths exceeding P7 capabilities, so limit
GL_MAX_TEXTTURE_SIZE to 16k for wider compatibility.
Bug: b/330696626
Change-Id: Icfbfce1c8b59941bc5c6911aaba31fea43976cef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5385681
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
6c379733
|
2024-03-21T14:25:52
|
|
Add more helper methods for textures.
This change adds a DisplayWgpu member variable to ContextWgpu
as well as a getter for the display so other objects can access
a webgpu device. This change also adds helper methods to translate
GL texture information (size, dimension, mip level count, etc.)
to webgpu compatible texture information.
Bug: angleproject:8547
Change-Id: Ifb2c5d021b1cbb95304a732c57d3250f1731496b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5385574
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Commit-Queue: Liza Burakova <liza@chromium.org>
|
|
|
a69c56fa
|
2024-03-21T16:45:11
|
|
Pin build until Skia is able to build with ToT abseil.
ANGLE pins abseil-cpp until https://skbug.com/330350366 is resolved.
Therefore ANGLE's abseil-cpp uses old DEF files, which can't be kept in
sync with new build, e.g. Win toolchain updates.
Bug: angleproject:8555
Change-Id: Ie5a8a1bb8b4286dfcf50b73cddd36b05bf1c5b15
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5385782
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Roman Lavrov <romanl@google.com>
|
|
|
da8fa1b6
|
2024-03-21T09:49:09
|
|
Roll Chromium from 42826620a07f to babb076716bc (4096 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/42826620a07f..babb076716bc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,romanl@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/68fce43789..ca4997ede8
* buildtools/linux64: git_revision:59c4bb920542ee903ee1df39097ae024e2e8226f..git_revision:22581fb46c0c0c9530caa67149ee4dd8811063cf
* buildtools/mac: git_revision:59c4bb920542ee903ee1df39097ae024e2e8226f..git_revision:22581fb46c0c0c9530caa67149ee4dd8811063cf
* buildtools/reclient: re_client_version:0.134.1.2c9285b-gomaip..re_client_version:0.136.1.732f8b5-gomaip
* buildtools/win: git_revision:59c4bb920542ee903ee1df39097ae024e2e8226f..git_revision:22581fb46c0c0c9530caa67149ee4dd8811063cf
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/823de9239a..142daf508b
* third_party/android_build_tools/lint: os0w78amTVmoZgEFrq2DN16rGn8FI3gWVs6hT_iOj3AC..vOJ_HEQatXdtUPfHOB4Ufx0g6EoO7xoqRyjdX6Va3M4C
* third_party/android_build_tools/manifest_merger: F0PdwwAdegLPfHzchRQ5Ec8_64ioPvucBKmei_kTraYC..vWAq6qe8wYWJCLx3jyN9qc7R6xKUROuGwk7SNoqAtuYC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/97c002a33e..5b5e74bd2e
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fe6a359a80..6551a7eb43
* third_party/fuchsia-sdk/sdk: version:19.20240312.3.1..version:19.20240320.0.1
* third_party/kotlin_stdlib: -uFeIws_FQzyqmgZlGL37ooRLAD8mwClD33O8rZwnTsC..8ap4rwZkKWCv2SPYRERFhMf-wVSsLCAE3fAFe7smZsoC
* third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/fc6253a642..ec88f0ab26
* third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/8bad7bd6ec..419b03c0b8
* third_party/r8: GLFNZHm9mWoi2_qyOFQGvz0M9bfPdK6gDcZAxm2H9_8C..hV5qI1hGWY_S97KZl3WdM1D6g3pCTQ1N8yK8v6qPPFMC
* third_party/siso: git_revision:110b1d8c0528de153cef259f09f3dc5ee627e6cb..git_revision:a3d591f9996c1b28fe5762913bb5bbd69960e4d5
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c5bf1b566e..24c07df503
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/448a5a4bc1..f2b31d0394
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1ed379eda8..b341c2ddaa
* tools/luci-go: git_revision:623f8d17a069eaea6d0fca13147888284ec76ff1..git_revision:7dd3e0506c6083aae7a0e413a30e0e11b76da08e
* tools/luci-go: git_revision:623f8d17a069eaea6d0fca13147888284ec76ff1..git_revision:7dd3e0506c6083aae7a0e413a30e0e11b76da08e
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/443a96da58..023fac3e08
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/598035ae7f..b0a8598fb9
No update to Clang.
Bug: None
Tbr: romanl@google.com
Change-Id: I3d15ef334bf4aa2a3b42ff3c1977e9fa38908327
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5384890
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Roman Lavrov <romanl@google.com>
|
|
|
07137f57
|
2024-03-20T13:28:34
|
|
Add ImageHelper to TextureWgpu
Bug: angleproject:8547
Change-Id: If718d57704c2548cec27ca15e9adc7bf1a7f92b8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5381638
Commit-Queue: Liza Burakova <liza@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
|
|
8c0dae38
|
2024-03-15T16:09:04
|
|
Add conversion operator from ImmutableString to std::string
Also use the operator in a couple of places. Sometimes saves a strlen.
Bug: angleproject:8614
Change-Id: I429f3ac02af04b568ac7d1adf22ab65e5007fbda
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5372728
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ed97adba
|
2024-01-05T17:00:03
|
|
Add more RGB-to-RGBA byte loading functions
Following the optimization of RGB8-to-RGBA8 for ubytes with 0xFF as
the fourth component, the other byte functions can be optimized in a
similar fashion.
* Added the following specialized template functions for byte loads:
(based on 3To4 byte loading functions in load_functions_table*.cpp)
* GLubyte, 0x01
* GLbyte, 0x7F
* GLbyte, 0x01
* Renamed LoadToNativeUbyte3To4Impl() to *Byte*.
* For the unit tests, refactored some of the repeated test code into
functions.
Bug: b/313526661
Change-Id: I017829bf765f0b417448bd5dca59be26c1665379
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5372971
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
00eb6edb
|
2024-03-20T06:49:38
|
|
Rename LinkSubTask -> PostLinkTask
This is a renaming change, no behavior changes are expected.
Bug: angleproject:8297
Change-Id: I734c7959f5ed6db2447853cc6f6256e3c8e86213
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5382224
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
042b430c
|
2024-03-13T10:45:06
|
|
Support the wgpu backend on Windows
Recurse deps into third_party/dawn will pull in the dxc deps needed to
build on Windows.
MSVC compile is currently broken on the "confirm no-op" step because no
webgpu_dawn.dll.lib is generated.
Bug: angleproject:8473
Change-Id: I7cd2df99dd068a9b7959d9cc8dc697ebd0c42a98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5366768
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
96f66089
|
2024-03-19T14:08:04
|
|
Tests: Update color values for Unsized/Unsigned in texture tests
Some of the values don't make sense, appear to be copy/paste errors.
Likely pass on non-Android due to sizable error tolerance.
Also turn on float tests that just work.
Test: angle_end2end_tests --gtest_filter=Texture*Copy*/ES3_Vulkan
Bug: angleproject:4756
Bug: angleproject:8620
Change-Id: I3fffb7859421bc179e3e5dd6bca14b4e2ac378ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5381400
Reviewed-by: Roman Lavrov <romanl@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
f8b18577
|
2024-03-15T16:31:02
|
|
Set the Dawn proc addresses at in DisplayWgpu initialization
This allows the display to fully initialize and some tests to pass!
Bug: angleproject:8485
Change-Id: I83176c572793ba8a6992264e873f7d24d3698d35
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5372136
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
7047d820
|
2024-03-19T17:17:22
|
|
win-trace (capture_replay_tests): cleanup after replay
Windows builds produce a large .pdb file for each test, e.g.
ClearTest_ClearIsClamped_ES2_Vulkan_SwiftShader.dll.pdb
As there are many tests, these accumulate and run out of disk
Remove files that have test labels in the filename, in the case above
that's 'ClearTest_ClearIsClamped_ES2_Vulkan_SwiftShader'
Bug: angleproject:8621
Change-Id: I995b561409f7ae714da81d246e7b7152d936e9d2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5378178
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
Auto-Submit: Roman Lavrov <romanl@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
21b5c321
|
2024-03-19T17:12:42
|
|
Pin abseil-cpp until Skia is able to build with ToT abseil.
Currently ANGLE uses Dawn's abseil buildfiles when building standalone
with Dawn enabled. If abseil changes, Dawn's buildfiles no longer work
with the version that ANGLE checks out. Dawn is also stuck using a
older version of abseil until https://skbug.com/330350366 is resolved.
Once https://skbug.com/330350366 resolves, Dawn can use the build files
in abseil-cpp and all projects can roll abseil independently and still
have it build.
Bug: angleproject:8555
Change-Id: Iad1e8618117b7dbfa713cbe1ccbff1cc8e4d93f8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5381480
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
a3dff4ed
|
2024-03-10T11:29:21
|
|
third_party/clspv: Disable the warnings on build
Adding a few cflags options to disable warnings seen while building
clspv.
Bug: angleproject:8619
Signed-off-by: Gowtham Tammana <g.tammana@samsung.com>
Change-Id: Ibee07e75331dad35e52a1937e5f56dfca855ea0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5380723
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
efd41bd2
|
2024-03-15T13:25:03
|
|
Vulkan: Rename ResourceVk.* to vk_resource.*
This file adds helpers to namespace vk, so its name is changed for
consistency with other namespace vk files.
Bug: angleproject:8564
Change-Id: I6525e7609eb9385f2a3eecaa7c52b7417fda7f12
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5370108
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
e3aac00b
|
2024-03-18T18:18:36
|
|
Vulkan: only request OPAQUE compositeAlpha on Android if no alpha
Android used to only advertise INHERIT bit with the expectations that a
Vulkan swapchain is only connected with SurfaceFlinger so that WM takes
full control of the composition. That works fine till an encoder surface
with EGL client (via ANGLE + KHR_swapchain) hits a suboptimal code path
if the backing storage is RGBA but not RGBX. This change prepares for
Android KHR_swapchain advertising OPAQUE bit for such surfaces as a hint
to get RGBX backing.
Bug: b/328125698, b/328122401
Test: encoder cts is passing, and no regression to ImageReader use cases
Change-Id: Ia7f1c69935690f20efac6295eb824bee0d03eb07
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5378134
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
914fe61b
|
2024-03-15T13:20:49
|
|
Vulkan: Rename RendererVk.* to vk_renderer.*
Done in a separate CL from the move to namespace vk to avoid possible
rebase-time confusion with the file name change.
Bug: angleproject:8564
Change-Id: Ibab79029834b88514d4466a7a4c076b1352bc450
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5370107
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
1fc548c1
|
2024-03-18T21:50:39
|
|
Vulkan: enable recordable bit for RGB8
This is needed by encoder surface that is in favor of RGBX as the
backing format.
Bug: b/328125698
Test: android.media.encoder.cts.SurfaceEncodeTimestampTest
Change-Id: Ic64653ccb1a9a0cea689b2e5554788fb0361a2d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5378133
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ebb94b80
|
2024-03-16T09:11:51
|
|
Remove few redundant ImmutableString to std::string conversions
Maybe removes few strlen calls.
Bug: angleproject:8614
Change-Id: I4fbb5f6abb8e8d21ff44a34975bab379127a0a11
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5372715
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
7cb518bc
|
2024-03-14T18:10:08
|
|
Reset shader images modified during trace
ANGLE will track and restore texture resources modified during
replay by reinitializing them in the Reset function, but shader
images resources modified by glDispatchCompute calls were
unhandled.
Test: angle_trace_tests --gtest_filter=*poppy_playtime
Bug: b/329824015
Change-Id: I2852b5a3cecdd2e2213ea457ea43e7cf84741986
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5375541
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
7506a0cd
|
2024-03-18T11:34:25
|
|
Tests: update QDC expectations after crrev.com/c/5372826
Bug: b/329286011
Change-Id: I5e5d94d9b6279a712d7d79197cd82c0cda2a71dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5377286
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
2f934a47
|
2024-03-18T12:53:27
|
|
libstdc++: replace std::powf with std:pow
libstdc++ before GCC 14 does not provide std::powf. So replace the
call with std::pow, that provides an overload for floats.
For reference of the bug tracking the missing methods in libstdc++:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79700
Bug: chromium:41455655
Change-Id: Idfb53fe3c71f4dc0198cf6ba3e26c07895f65bc6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5379670
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
6e6d6b29
|
2024-03-19T10:01:48
|
|
Roll vulkan-deps from fa1e68dabb91 to ba66ec69216d (8 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/fa1e68dabb91..ba66ec69216d
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/9f37ad360e..b047a21033
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f20663ca7f..6c3f632a2c
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/733fd2b522..e5f1de8968
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/07d8cf328c..57084b5d12
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,romanl@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: romanl@google.com
Change-Id: I8df02e2c45852ead836a1c9fa0b0b9b93edeaa01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5380287
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
d2cef82a
|
2024-03-18T18:15:11
|
|
Vulkan: Use fragment shading rate access flags
Image memory barrier for a fragment shading rate attachment needs to use
VK_ACCESS_FRAGMENT_SHADING_RATE_ATTACHMENT_READ_BIT_KHR as the access
flag instead of VK_ACCESS_SHADER_READ_BIT
Bug: angleproject:8484
Change-Id: I3316f1a5965ed3866e683494ee4f8df0b208d92c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5379262
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
6d569003
|
2024-03-17T13:15:21
|
|
Vulkan: Deduplicate merge to Renderer's pipeline cache
Decouple warmUp*PipelineCache(...) and the merge of
ProgramExecutableVk::mPipelineCache into Renderer's global cache.
This allows the last link subtask to perform the merge once instead of
doing so in each subtask.
Also, remove AtomicShared datatype and use AtomicRefCounted directly
Bug: angleproject:8601
Change-Id: If27831d7d132a3b8644c425072169cf2e9a4bc69
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5376409
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
490ff869
|
2024-03-14T00:00:00
|
|
Always redeclare clip/cull distance built-ins
When clip or cull distance built-in arrays are implicitly
sized, various pruning passes may produce an inconsistent
AST state thus causing translation or linking failures.
Adjusted the dedicated validation pass to inject
an explicit declaration thus bypassing the issue.
Additional updates:
* Ensured that API clip distance state emulation is
applied when a variable is declared but not assigned
* Reverted previous clip/cull distance related changes to
TIntermBinary::hasSideEffects as they are redundant now
* Fixed failing AST validation for MSL varying emulation
* Aligned linking error messages with the specifications
* Updated tests and cleaned-up obsolete code
Fixed: angleproject:8591
Change-Id: Ic8cfaf37778b8532bbab32ab998d5350b85d67ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5372714
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
f4ecbe6f
|
2024-03-14T13:31:20
|
|
Use Dawn's abseil build files when wgpu is enabled.
To avoid building abseil with multiple different build files, use
dawn's build files when it is available.
Also use dawn's build files for out-of-chromium component builds to
match dawn's conditions.
Bug: angleproject:8555
Change-Id: I10c1578630dafa14fdd118feb66790eb0bf27792
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5371323
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
|
|
|
afbfebca
|
2024-03-15T21:09:25
|
|
Reland "Manual roll VK-GL-CTS from 87353392d2d2 to ec9827528085 (9 revisions)"
This is a reland of commit 8080a736f13854f806cb115e6ab78a8f4f33d08e
Original change's description:
> Manual roll VK-GL-CTS from 87353392d2d2 to ec9827528085 (9 revisions)
>
> Manual roll requested by abdolrashidi@google.com
>
> * Added common source files for TextureLodBasicTests.
> * Suppressed failing tests that have been newly enabled in this roll.
>
> https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/87353392d2d2..ec9827528085
>
> 2024-03-15 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10
> into vk-gl-cts/main
> 2024-03-15 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2
> into vk-gl-cts/main
> 2024-03-14 piotr.byszewski@mobica.com Add shader interface tests for
> array of structs
> 2024-03-14 rgarcia@igalia.com Make maintenance5 basic_draw cases more
> interesting
> 2024-03-14 rgarcia@igalia.com Make customBorderColors mandatory for
> VK_EXT_custom_border_color
> 2024-03-14 kamil.goras@mobica.com Re-enable tests
> dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_out_of_bounds*
> 2024-03-14 kamil.goras@mobica.com Re-enable tests
> dEQP-GLES2.functional.fragment_ops.depth_stencil.stencil_ops.*
> 2024-03-14 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS
> (sgis_texture_lod_basic), PART 3
> 2024-03-14 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8
> into vk-gl-cts/main
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
> Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
> ensure that a human
> is aware of the problem.
>
> To file a bug in ANGLE:
> https://bugs.chromium.org/p/angleproject/issues/entry
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://issues.skia.org/issues/new?component=1389291&template=1850622
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Bug: angleproject:8615
> Tbr: abdolrashidi@google.com
> Change-Id: I72634c743fd43d0b4fa901f6d644802c56ad2a3a
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5375112
> Commit-Queue: Roman Lavrov <romanl@google.com>
> Reviewed-by: Roman Lavrov <romanl@google.com>
> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com>
Bug: angleproject:8615
Change-Id: I9f01e30f9c261a3eb27afe1fa8d5c2b14c8115a2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5377282
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
92b8fc68
|
2024-03-18T14:41:54
|
|
Revert "Manual roll VK-GL-CTS from 87353392d2d2 to ec9827528085 (9 revisions)"
This reverts commit 8080a736f13854f806cb115e6ab78a8f4f33d08e.
Reason for revert: Broke Android roller - possibly because .gitmodules wasn't updated?
"""
The roller failed to create a CL with:
failed to roll to 8080a736f138. Conflicts in .gitmodules
third_party/VK-GL-CTS/src
"""
Original change's description:
> Manual roll VK-GL-CTS from 87353392d2d2 to ec9827528085 (9 revisions)
>
> Manual roll requested by abdolrashidi@google.com
>
> * Added common source files for TextureLodBasicTests.
> * Suppressed failing tests that have been newly enabled in this roll.
>
> https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/87353392d2d2..ec9827528085
>
> 2024-03-15 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10
> into vk-gl-cts/main
> 2024-03-15 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2
> into vk-gl-cts/main
> 2024-03-14 piotr.byszewski@mobica.com Add shader interface tests for
> array of structs
> 2024-03-14 rgarcia@igalia.com Make maintenance5 basic_draw cases more
> interesting
> 2024-03-14 rgarcia@igalia.com Make customBorderColors mandatory for
> VK_EXT_custom_border_color
> 2024-03-14 kamil.goras@mobica.com Re-enable tests
> dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_out_of_bounds*
> 2024-03-14 kamil.goras@mobica.com Re-enable tests
> dEQP-GLES2.functional.fragment_ops.depth_stencil.stencil_ops.*
> 2024-03-14 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS
> (sgis_texture_lod_basic), PART 3
> 2024-03-14 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8
> into vk-gl-cts/main
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
> Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
> ensure that a human
> is aware of the problem.
>
> To file a bug in ANGLE:
> https://bugs.chromium.org/p/angleproject/issues/entry
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://issues.skia.org/issues/new?component=1389291&template=1850622
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Bug: angleproject:8615
> Tbr: abdolrashidi@google.com
> Change-Id: I72634c743fd43d0b4fa901f6d644802c56ad2a3a
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5375112
> Commit-Queue: Roman Lavrov <romanl@google.com>
> Reviewed-by: Roman Lavrov <romanl@google.com>
> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com>
Bug: angleproject:8615
Change-Id: I546c8d196bc089b7f92a8c1fa1a27ef358efa1e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5374650
Commit-Queue: Roman Lavrov <romanl@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
f8021cfa
|
2024-03-18T13:12:48
|
|
Manual roll vulkan-deps from 91aab7b7e25f to fa1e68dabb91 (27 revisions)
Manual roll requested by ynovikov@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/91aab7b7e25f..fa1e68dabb91
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/ee2f5d09ea..9f37ad360e
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f869d391a5..f20663ca7f
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/70bf72330a..733fd2b522
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/38311dd809..07d8cf328c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,romanl@google.com,ynovikov@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: romanl@google.com,ynovikov@google.com
Change-Id: I4c5d13d4a998790c76c652c90a4c37f74ff2fb49
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5377890
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
8080a736
|
2024-03-15T21:09:25
|
|
Manual roll VK-GL-CTS from 87353392d2d2 to ec9827528085 (9 revisions)
Manual roll requested by abdolrashidi@google.com
* Added common source files for TextureLodBasicTests.
* Suppressed failing tests that have been newly enabled in this roll.
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/87353392d2d2..ec9827528085
2024-03-15 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10
into vk-gl-cts/main
2024-03-15 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2
into vk-gl-cts/main
2024-03-14 piotr.byszewski@mobica.com Add shader interface tests for
array of structs
2024-03-14 rgarcia@igalia.com Make maintenance5 basic_draw cases more
interesting
2024-03-14 rgarcia@igalia.com Make customBorderColors mandatory for
VK_EXT_custom_border_color
2024-03-14 kamil.goras@mobica.com Re-enable tests
dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_out_of_bounds*
2024-03-14 kamil.goras@mobica.com Re-enable tests
dEQP-GLES2.functional.fragment_ops.depth_stencil.stencil_ops.*
2024-03-14 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS
(sgis_texture_lod_basic), PART 3
2024-03-14 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8
into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:8615
Tbr: abdolrashidi@google.com
Change-Id: I72634c743fd43d0b4fa901f6d644802c56ad2a3a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5375112
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Roman Lavrov <romanl@google.com>
Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
21d124c4
|
2024-03-16T10:06:02
|
|
Vulkan: Remove support for pipeline cache control
For current and upcoming uses for pipeline caches the benefits of having
an externally synchronized pipeline cache is minimal at best. Remove
support for that and have all caches be internally synchronized by the
Vulkan driver.
Bug: angleproject:8601
Change-Id: Ic5d9740934641f61b527094aa301e27302b02a57
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5375102
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
553e3c80
|
2024-03-15T08:40:42
|
|
Vulkan: Async compile pipelines with different surface rotations
Add prepareForWarmUpPipelineCache(...) method to ProgramExecutableVk
that sets up the required common state for warmup tasks. On platforms
that support worker threads enqueue a warmup task per surface rotation.
Bug: angleproject:8601
Change-Id: I22c0d664736ef682d4207c1e08163f79ac79f7d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5366173
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
58065d07
|
2024-03-14T16:00:20
|
|
Vulkan: Add test that destroys view after the image
A depth/stencil blit path can create temp views. Temp objects are added
to ContextVk::mCurrentGarbage, which is **appended** to the Renderer's
garbage list. If the image from which the view was created is released
before the next submission (i.e. it's appended to the garbage list
before ContextVk::mCurrentGarbage), the image can be destroyed before
its dependent view is.
This is not triggering any validation error however, so there doesn't
seem to be a need for a fix. For posterity, if this ordering needs to
be fixed in the future, we can simply remove
`ContextVk::mCurrentGarbage` and add garbage to the renderer directly.
This was made possible a while back when the context was able to
allocate its submission serial right away. (Previously, the serial had
to be determined after submission, which is why temp objects were kept
in ContextVk until that serial is known)
Bug: chromium:40942995
Change-Id: I8a1270e635193dd7aff5b63cbf63c0c6a1fc061f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5370782
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
c5f7bbeb
|
2024-03-15T19:03:24
|
|
Make ImmutableString::beginsWith constexpr
Maybe reduces strlen calls.
Bug: angleproject:8614
Change-Id: Ic63d019c185db7acde2c2645c499b5408ec23b78
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5372122
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
21ef298e
|
2024-03-13T11:06:22
|
|
Consider textures without an attached Buffer as incomplete
There are apps that perform a draw call using GL_TEXTURE_BUFFER
but without binding a valid buffer thus causing a crash. Instead
consider them as incomplete textures and fail validation checks.
Also, there is no need to explicitly track the buffer associated with
an incomplete buffer texture, the owning texture will handle cleanup.
Bug: b/328846669
Tests: TextureBufferTestES31.DrawIncomplete*
Tests: TextureBufferTestES31.DrawComplete*
Change-Id: Id0b68e8048ba582d677e6767272a86761913ea3a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5369639
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
60aaf4a0
|
2024-03-14T12:58:56
|
|
Vulkan: Move renderer to namespace vk
This class is agnostic of EGL. This change moves it to namespace vk for
use with the OpenCL implementation
Bug: angleproject:8564
Change-Id: I57f7807d6af8b3d5d7f8efbaf8b5d537a930f881
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5371324
Reviewed-by: Austin Annestrand <a.annestrand@samsung.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b3ab67d3
|
2024-03-14T15:06:02
|
|
tests: Remove unnecessary .get() from RAII objects
Bug: chromium:40942995
Change-Id: I82509869bce3ad8f51811188fe04267f2de04786
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5370904
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d4d34781
|
2024-03-14T13:03:55
|
|
Multisampling support check: sampleCounts > 1 and createFlags
At least two drivers are returning VK_SUCCESS from
vkGetPhysicalDeviceImageFormatProperties2
but also set sampleCounts to 1 which supposedly means no MSRTT
Qualcomm reference device driver fails vkCreateImageView
when enabling the multisampling bit one cubemaps which have
sampleCounts == 1
Additionally,
* include vk::GetMinimalImageCreateFlags() in createFlags - we don't get
the cubemap bit without that
* check both the image format and the additional view format
(linear+srgb) as we set both of these when creating the image
This fixes a bunch of cubemap and 3D tests on Qualcomm reference device
Bug: b/329286011
Change-Id: I6d3ddea0cd997cf37b503050063f42d69723bd50
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5372826
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
2dc45de8
|
2024-03-15T11:11:10
|
|
Trace tests: check and log zlib crc32 on decompress failure
crc32 of the entire output is part of the failing check
Also log crc32 of truncated data that only uses SIMD instructions
Bug: b/296921272
Change-Id: I03490ea37680f3bcbec4b31befb510a0e3d73bce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5366298
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
7220307b
|
2024-03-13T16:13:45
|
|
Conditionally support EGL_OPENGL_API
Advertize support for EGL_OPENGL_API only if
angle_enable_gl_desktop_frontend is enabled.
Bug: b/322142833
Tests: EGLQueryContextTest.DesktopGlApi*
Change-Id: I680ea985e45e793d92fc087d21f38fd5d38f0241
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5369641
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
b5d92511
|
2024-03-14T19:16:15
|
|
Trace tests: log z_stream on decompress failure
Bug: b/296921272
Change-Id: Iecf0be35d8bbf029271b505b52fea0bc730a4751
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5370264
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
c3fdc811
|
2024-03-14T14:20:43
|
|
Raise the WebGL texture size limit on Android >= 14
The previous limit of 4096 is overly restrictive for newer devices
that can have screen sizes close to or greater than 4096.
Bug: angleproject:8611
Change-Id: If453b7e0c6e2af218b65a631821b441330a50b69
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5370399
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
e5cb7f1f
|
2024-03-12T16:06:37
|
|
Vulkan: Fix access to inactive attributes
... within range of active ones. Since a buffer is bound for inactive
attributes, it must be considered accessed.
Ultimately, the nullDescriptor feature could be used to avoid binding a
buffer for inactive attributes.
Bug: chromium:327807820
Change-Id: Ieceea9442310c23568c47cef7357b4094b7ebbb4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5369336
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
533fa5ce
|
2024-03-09T10:15:33
|
|
Metal: Update few asserts when resolving FS output
Update few asserts when resolving FS output locations and indexes.
Bug: angleproject:8558
Change-Id: Ic3c3c1df19b2de9db78a73b1c14f26444442d74f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5358814
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
9bae5859
|
2024-03-13T10:55:18
|
|
Vulkan: Add blend factors to allow dithering to work
Previously, we had
- src: GL_SRC_ALPHA, dst: GL_ONE_MINUS_SRC_ALPHA
Now, this adds
- src: GL_ONE, dst: GL_ONE_MINUS_SRC_ALPHA
This showed up in app "com.inertiasoftware.justjigsaws".
Bug: b/328837151
Change-Id: I88208b1ed4dd050283d8d02cf31ccdcb3d02a444
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5369638
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
142c05b5
|
2024-03-10T10:18:52
|
|
Build OpenCL CTS on ANGLE Linux and Android standalone bots
Bug: angleproject:8540
Change-Id: I92cd97b1748b4a958e6fca5bb9fbebab74fe8ba4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5358034
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
afed1224
|
2024-03-04T16:17:37
|
|
CL: Add CTS build to ANGLE
* CTS Build is done automatically if angle_enable_vulkan and
angle_enable_cl flags are set along with angle_enable_cl_testing flag
* Updates ICD Loader source set to include ICD dispatch files
Bug: angleproject:8540
Change-Id: I6ccebb3279e0d2798703b3ec783ff54eabe57452
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5350744
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
cd90294b
|
2024-03-12T17:00:42
|
|
OpenCL/Vulkan: Add initial CL Event creation
Introduce initial support for CL Event (and user event) creation
as well as implement initial event status query routine.
Bug: angleproject:8574
Change-Id: I97eb57a720610e00a04e512328f0b3b4287bf021
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5341378
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
|
|
|
66bc9cfa
|
2024-03-11T16:24:20
|
|
OpenCL: Fix mCallback in linkProgram ctor
During linkProgram construction, mCallback
member was not properly initailized prior to
calling linkProgram backend.
Bug: angleproject:8435
Change-Id: I5700fe75a20d69193bba4f5ff4f7ade7383802ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5362894
Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
17facd2b
|
2024-03-13T10:14:59
|
|
Fix CreateDirectory name clash with Windows headers.
CreateDirectory is a windows macro to CreateDirectoryA/W. This caused
conflicts with the newly added CreateDirectory function which also
internally called CreateDirectory with the wrong arguments.
Bug: angleproject:8571
Change-Id: I596a4c2d711537e92e5e8b53b8eea2ab6b3ca7ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5369333
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
18fa02be
|
2024-03-12T10:23:55
|
|
Rewrite exprs using separated decl variables
Rewrite expressions that use the rewritten struct declaration variables.
Declaration that specfies a struct and defines multiple variables will
get its variable declarations separated. The type of the variable
changes when a struct specifier is removed for the second and rest of
the variable declarations. The type of the variable changes also when a
anonymous struct is named.
The expressions that used the separated variables used the old struct as
their types.
Fix by using TIntermRebuild. Upon creating a new symbol node referencing
the new type, the rebuilder will instantiate also all the needed
intermediate nodes, which then get the correct struct type.
For consistency, fix the case of anonymous struct -> named struct
transform naming the variables similar to named struct separation.
Consider base case:
struct S { .. } a, b; -> struct S { .. } a; S b;
Compare against case:
struct { .. } a, b;
Before, inconsistency:
struct s1 { .. }; s1 a; s1 b;
After, fixed:
struct s1 { .. } a; s1 b;
Bug: angleproject:8590
Change-Id: Iffb0ef4441d6021e076b04485b808b26a7fa4dcb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5365201
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|