Log

Author Commit Date CI Message
Behdad Esfahbod 11c28cb5 2021-02-22T17:38:53 [cmake] Define HAVE_PTHREAD if not on win32 Yeah...
Behdad Esfahbod b368a073 2021-02-22T17:23:53 [atomic] Remove IBM/AIX implementation The C++11 implementation shall be enough for everyone.
Behdad Esfahbod 52f91269 2021-02-22T17:22:09 [atomic] Remove Windows implementation Since we require C++11 now, there's no point to do a macro version check. Which means we don't hit the MSVC issue defining __cplusplus wrongly.
Behdad Esfahbod a666fe64 2020-06-29T10:43:49 [atomic] Comment
Behdad Esfahbod 3528a21e 2020-06-29T10:40:21 [atomic] Remove Apple implementation Continuation of https://github.com/harfbuzz/harfbuzz/pull/676
Behdad Esfahbod 140797d4 2020-06-29T03:51:09 [constexpr] hb_atomic_int_t
Behdad Esfahbod 2ec802b4 2020-06-29T03:48:38 [object] Simplify reference_count_t
Behdad Esfahbod 4d116ed0 2021-02-22T17:14:45 [ci] Remove cmake Apparently(?) our cmake build never bothered setting up pthreads. So when I removed the busy-loop mutex impl it now doesn't build. 711c241f6c7e18c5403602375a733af74df76f83 https://github.com/harfbuzz/harfbuzz/pull/2874#issuecomment-782778263
Behdad Esfahbod b39c1f78 2021-02-20T15:46:17 a[build] Fix distcheck
Behdad Esfahbod a3c35aee 2020-06-29T02:07:20 m Move HB_SCRIPT_MYANMAR_ZAWGYI
Behdad Esfahbod c55bf551 2020-06-29T02:04:16 Remove HB_CONST_FUNC and HB_PURE_FUNC They are not necessary for inline functions.
Behdad Esfahbod cba9893a 2020-06-29T01:55:57 m[algs] Move roundf() here
Behdad Esfahbod f0947717 2020-06-29T01:53:21 m[machinery] Move HB_VAR_ARRAY here
Behdad Esfahbod 69464e9d 2021-02-20T15:42:44 [algs] Another try at fixing BEInt constexpr ../src/hb-algs.hh:120:3: error: body of constexpr function ‘constexpr BEInt<Type, 2>::operator Type() const [with Type = short unsigned int]’ not a return-statement
Behdad Esfahbod ff7bf881 2021-02-20T15:39:29 m[algs] Fix BEInt -Wnarrowing errors
Behdad Esfahbod a89d9f25 2021-02-20T15:35:28 m Err on -Wnarrowing instead of -Wc++11-narrowing On clang, -Wnarrowing is synonym for -Wc++11-narrowing. On gcc it isn't. So, use the widely-available one
Behdad Esfahbod e208f804 2021-02-20T15:31:27 Make constexpr BEInt<Type, 2>::operator Type() C++11-compatible Multiple return values not permitted until C++14
Behdad Esfahbod c2fc2aa4 2020-06-29T01:49:28 [atomic] Remove Solaris intrinsics
Behdad Esfahbod 7099a6dc 2020-06-29T01:47:37 [atomic] Remove old Intel primitives implementation
Behdad Esfahbod 711c241f 2020-06-29T01:40:30 m[mutex] Remove busyloop mutex implemenation Don't know why I ever added this. :)
Behdad Esfahbod 47f01c07 2020-06-29T01:25:35 m[algs] Move BEInt here
Behdad Esfahbod e5b7bc42 2020-06-29T01:24:02 m Add default value to BEInt<> Size template parameter
Behdad Esfahbod 2caae4a5 2020-06-29T01:18:28 m Move class traits
Behdad Esfahbod c2dbd6cc 2020-06-29T01:15:36 Remove static_assert of sizeof basic sized int types
Behdad Esfahbod e1706ffe 2020-06-29T00:59:06 m [algs] Move flags here
Behdad Esfahbod 017f6b0d 2020-06-29T00:44:41 m Move static_assert_expr<>
Behdad Esfahbod 61f8d0e5 2020-06-29T00:38:56 m Rename ASSERT_STATIC_EXPR_ZERO to static_assert_expr
Behdad Esfahbod 59cfffb1 2020-06-29T00:34:07 m Change ASSERT_STATIC_EXPR_ZERO template arg type to bool
Behdad Esfahbod 1981d83d 2020-06-29T00:28:31 [constexpr] HB_MARK_AS_FLAG_T
Behdad Esfahbod a4a99de0 2020-06-29T00:22:02 [constexpr] bswap
Behdad Esfahbod f8ebe1da 2020-06-29T00:20:45 [constexpr] BEInt
Behdad Esfahbod 2fbd34f8 2020-06-28T22:41:09 m[set/map] Add operator bool() Probably should use in places..
Behdad Esfahbod bf75a0a0 2021-02-19T18:18:38 m[dispatch] Use inline class member initialization Let's see how bots like this...
Behdad Esfahbod 82928d9c 2020-06-28T22:03:57 m[blob] Move immutable check to C API boundary Similarly to 08ed9e3f779253e3b5f01c38d44d0e5db2d5e7aa
Behdad Esfahbod 4020c6b2 2020-06-28T21:59:46 m[blob] An empty blob can always be made writable
Behdad Esfahbod 2d39031f 2020-06-28T20:48:48 [buffer/set/map] Move immutable check only to C API boundary The immutable objects are a concept only enforced by the C API. So move checks only to that region. This does assume that the rest of the code is careful not getting into these internal methods on immutable objects, which something we do, but have no way of enforcing (currently). .
Behdad Esfahbod 6d83d440 2020-06-28T21:02:51 m[set] Recover set from error in .reset()
Behdad Esfahbod 445efe8d 2020-06-28T20:59:01 m[vector] Recover vector from error in .reset()
Behdad Esfahbod 21433fa5 2020-06-28T20:46:02 m[buffer] In hb_buffer_append() don't change until allocation success
Behdad Esfahbod 0f61a621 2020-06-28T20:40:25 m[vowels] Simplify If we didn't "process" anything, swap_buffers() becomes a no-op.
Behdad Esfahbod 3b91e0b5 2020-06-28T20:33:54 m[buffer] Rename internal variable
Behdad Esfahbod 9fcba109 2020-06-28T20:30:39 [buffer] Make swap_buffers() copy rest
Behdad Esfahbod 86993c09 2021-02-19T17:09:33 Ignore -Wrange-loop-analysis Fixes https://github.com/harfbuzz/harfbuzz/issues/2834
Behdad Esfahbod 6d941944 2021-02-19T17:08:10 Use auto in range-for-loop more
justvanrossum 1551f3d5 2021-02-18T11:57:37 fixing more expected test results
justvanrossum 79e4f436 2021-02-17T10:21:58 Apply rounding correctly when calculating glyph extents for CFF and CFF2; adjust expected test results
justvanrossum d01ebeae 2021-02-17T10:13:54 calculate extents based on scaled then rounded values; undo two of the earlier test result adjustments
justvanrossum 1d02e9c6 2021-02-16T21:39:43 two more adjusted expected extents results (still not convinced this is the right thing, though)
justvanrossum cd0babe6 2021-02-16T21:05:30 adjust expected test result
justvanrossum 1d8a8950 2021-02-16T20:55:16 do not round added deltas; fixes #2866
Behdad Esfahbod 103ed7da 2021-02-19T16:48:30 [subset] Use dagger Better fix for https://github.com/harfbuzz/harfbuzz/pull/2858
Behdad Esfahbod d8ea552d 2021-02-18T12:07:46 [aat] Improve unsafe-to-break logic Reduces false-positives. See comments for new logic. Fixes https://github.com/harfbuzz/harfbuzz/issues/2860 Adjusts run-tests.sh to allow unhashed absolute filenames.
Behdad Esfahbod cf203936 2021-02-18T12:03:26 [aat] Unbreak builds Some compilers don't like this: ../src/hb-aat-layout-common.hh:732:9: error: declaration of 'using StateTable = struct AAT::StateTable<Types, EntryData>' changes meaning of 'StateTable' [-fpermissive] 732 | using StateTable = StateTable<Types, EntryData>;
Behdad Esfahbod b6fdaa69 2021-02-18T11:16:37 [minor:aat] Use injected class name
Behdad Esfahbod e27420bb 2021-02-18T11:15:25 [minor:aat] Simplify template reference
Behdad Esfahbod 7b8a8adb 2021-02-18T09:47:24 [aat] Fix unsafe-to-break marking when end-of-text action kicks in The state we are dealing with here is the previous state; so it should cause unsafe_to_break before current glyph. I'm surprised this wasn't caught by any tests. Guess we don't have any fonts with fancy end-of-text forms.
Behdad Esfahbod aa80c7c8 2021-02-18T09:31:46 [aat] Add buffer->successful check before buffer->next_glyph()
Behdad Esfahbod bcd10bf2 2021-02-17T13:58:56 [normalize] Add buffer success check before ->next_glyph() Speculative fix for: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=27843
Behdad Esfahbod 505b3fc6 2021-02-17T11:34:47 [harfbuzz.cc] Fix OffsetTable name clash with Mac headers There's no easy way to undo a "using namespace" in our sources, so by the time we get to include hb-coretext.cc from harfbuzz.cc, we already have "using namespace OT" active, which clashes with Mac headers. Error was: $ gcc -O3 -Wall -arch i386 -DHAVE_CORETEXT=1 -c harfbuzz.cc -o harfbuzz.o -std=c++11 /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/TextUtils.h:288:3: error: reference to 'OffsetTable' is ambiguous OffsetTable offsets, ^ /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/IntlResources.h:115:41: note: candidate found by name lookup is 'OffsetTable' typedef OffPair OffsetTable[3]; ^ ./hb-open-file.hh:81:16: note: candidate found by name lookup is 'OT::OffsetTable' typedef struct OffsetTable ^ 1 error generated.
Behdad Esfahbod 6a9f576f 2021-02-17T11:31:32 [coretext] Silence CoreText deprecation warning As suggested by Ned, just ignoring it. warning: 'CTGetCoreTextVersion' is deprecated: first deprecated in macOS 11.0 - Use -[NSProcessInfo operatingSystemVersion] [-Wdeprecated-declarations]
Behdad Esfahbod 8e53c7c1 2021-02-17T11:12:56 [coretext] Fix more CGFloat double-promotion warnings The warning is: warning: implicit conversion increases floating-point precision: 'CGFloat' (aka 'float') to 'double' [-Wdouble-promotion]
Behdad Esfahbod cd08c252 2021-02-16T18:51:43 Fix typo
Khaled Hosny 9c8032cb 2021-02-16T22:00:20 [meson] Don’t build FontConfig subproject from master Pin it to a known working tag instead.
Garret Rieger 5ca353a2 2021-02-12T15:16:59 [subset] fix heap buffer overflow found by fuzzer.
Behdad Esfahbod ae860db8 2021-02-16T12:39:47 Merge pull request #2859 from harfbuzz/override-0b55 [indic] Fix shaping of U+0B55 ORIYA SIGN OVERLINE
David Corbett 751ed68f 2021-02-14T12:47:34 [indic] Fix shaping of U+0B55 ORIYA SIGN OVERLINE Fixes https://github.com/harfbuzz/harfbuzz/issues/2849
Behdad Esfahbod 7a60f4e3 2021-02-12T14:14:17 [subset] Remove debug burden Fixes https://github.com/harfbuzz/harfbuzz/issues/2360
Garret Rieger 00d92763 2020-10-14T14:48:11 Add gpos9 expected files to Makefile.am
Garret Rieger 08a4997f 2020-10-06T13:02:12 [subset] Add subset support for Extension lookups (GPOS 9, GSUB 7).
Behdad Esfahbod bbbea3db 2021-02-11T12:23:33 [minor] Rewrite set operation in OS/2 subsetting This patch could be nicer: https://github.com/harfbuzz/harfbuzz/pull/2572/files Just tiny touchup now.
Behdad Esfahbod cdb9197b 2021-02-11T11:32:49 [khmer] Remove more unused code Prodded by https://github.com/harfbuzz/harfbuzz/pull/2583 These are leftovers from when we forked Khmer shaper from the Indic shaper.
Behdad Esfahbod dfa9d7ac 2021-02-11T11:08:52 [minor] Use serializer->propagate_error() to simplify code
Behdad Esfahbod 5faae826 2021-02-11T10:58:02 [post] Remove unneeded error check
Behdad Esfahbod d7e2a51d 2021-02-11T10:55:03 [minor] Add unlikely() when checking for error
Behdad Esfahbod eb069f39 2021-02-10T19:13:51 [tests] Update expected output of recently-merged gpos5 The merged PR was from before landing this: commit 7a72b20aa2b604053696e731185a17286de73b08 Author: Garret Rieger <grieger@google.com> Date: Thu Sep 24 15:58:48 2020 -0700 [subset] Subset GDEF during layout subsetting tests.
Behdad Esfahbod c7d232ce 2021-02-10T18:13:38 Merge pull request #2701 from googlefonts/Mark-To-Ligature_grieger [subset] GPOS 5 MarkToLigature subsetting support
Behdad Esfahbod 68d57622 2021-02-10T14:56:29 Merge pull request #2853 from harfbuzz/fix-g-ir-scanner [introspection] Fix g-ir-scanner syntax errors
Khaled Hosny 7b9e23f2 2021-02-10T23:37:43 [introspection] Fix g-ir-scanner syntax errors Fixes https://github.com/harfbuzz/harfbuzz/issues/2851
Khaled Hosny 094406b6 2021-02-10T22:49:27 [ci] Disable failing Arch Linux job Some g-ir-scanner failure that does not seem to be related to us. The job does not seem to be testing anything interesting anyway.
Khaled Hosny 554aaa0c 2021-02-10T22:25:16 [build] Fix make distcheck A regression from 7b77ce0507e18fb981a9b865f3eaac0c2ae06044. It was caught by the CI build in the PR, but apparently we are now used to CI failures that they are effectively ignored. Also, yay for multiple build systems.
Behdad Esfahbod 1da75afb 2021-02-10T00:03:30 [minor] Add unlikely()
Behdad Esfahbod 6a3fd94f 2021-02-09T20:49:04 Merge pull request #2699 from googlefonts/gpos_8 [subset] Add a more complex layout subsetting test case and fix the issues it exposed.
Behdad Esfahbod 6e1afac6 2021-02-09T18:48:46 [minor] Rename internal variable To address review comment: https://github.com/harfbuzz/harfbuzz/pull/2699#discussion_r573370781
Behdad Esfahbod 836814a5 2021-02-05T13:41:19 [array] Swap order of args to hb_equal() Prioritizes Key::cmp() over table's cmp.
Behdad Esfahbod 98374ceb 2021-02-05T13:40:10 Conditionalize IntType::cmp() so it never fails to compile Useful with lfind() since that calls hb_equal() which SFINAEs which cmp() to use.
Behdad Esfahbod ed04174a 2021-02-05T13:36:46 Whitespace
Garret Rieger 8f47dd57 2020-11-04T11:05:22 [subset] don't set lookup visited in closure_lookups_context_t::recurse. - Lookup::closure_lookups also checks if the lookups visited and sets the lookup to visited. If we set visited in 'recurse' then Lookup::closure_lookups will fail to recurse into the children of the lookup. - Also when copying ChainRule's skip LookupRecord's that point to lookups which aren't retained. This matches FontTool's behaviour.
Behdad Esfahbod feeff592 2021-02-09T14:59:40 [docs] Add destroy() call to sample
Khaled Hosny 319e5b32 2021-01-01T01:31:19 [manual] Fix font functions section Fixes https://github.com/harfbuzz/harfbuzz/issues/2731
Khaled Hosny 3583fce8 2020-12-31T19:45:11 [manual] Give all chapters & sections pretty links
Khaled Hosny 84d4d9fc 2020-12-31T18:27:10 [manual] We don’t use ucdn library anymore
Khaled Hosny 68d2e1b2 2021-01-21T14:39:19 [meson] Disable benchmark feature by default It downloads a dependency from the internet, and in the same time not used anywhere (one needs to explicitly call ninja benchmark), not even on the CI (not sure if it that would make much sense since it does not seem to ever fail).
Khaled Hosny b6f47af5 2021-01-21T14:34:01 [meson] Report more options in the summary
Behdad Esfahbod 33a0f0b6 2021-02-09T12:55:45 [test] Remove fuzzed test font that triggers virus alert Fixes https://github.com/harfbuzz/harfbuzz/issues/2750
Khaled Hosny 99184fbe 2021-02-03T13:40:39 [ci] Add top level directory to win32 zip file Fixes https://github.com/harfbuzz/harfbuzz/issues/2840
josephshen d9e0244c 2021-02-02T16:04:44 remove duplicate file names
Behdad Esfahbod dad41c07 2021-02-01T13:54:12 [use] Typo
Behdad Esfahbod 63a716c5 2021-01-29T20:36:42 [indic] Use lfind()
Behdad Esfahbod 921b4e46 2021-01-29T20:35:05 [algs] Add hb_equal() Use in hb_array_t::lfind()
Behdad Esfahbod f4ed3bf2 2021-01-29T20:05:38 [indic] Remove categorization of Khmer Ra Khmer goes through its own shaper these days.