src


Log

Author Commit Date CI Message
jfkthame 740fdbcd 2017-04-03T12:22:39 avoid UBSan warning in get_stage_lookups (#450) See https://bugzilla.mozilla.org/show_bug.cgi?id=1336600
Behdad Esfahbod edcf6344 2017-03-24T10:24:52 Blacklist more versions of Padauk Patch from Phil Race.
Khaled Hosny 91570a1e 2017-03-22T23:07:15 Just always use strtod here
Chun-wei Fan 539571c1 2017-02-24T17:58:25 src/hb-common.cc: Fix build on older Visual Studio Visual Studio only supported strtof() from Visual Studio 2013 onwards, so use strtod() instead to do the operation, which should do the same thing, sans going to a double, not a float.
Behdad Esfahbod 47e7a180 2017-03-10T13:23:02 Revert "Fix Context lookup application when moving back after a glyph delete" This reverts commit b9b005f3a44ccf78a45b212b126287b69b9f4b40. This introduced invalid access cases. Revert until I fix correctly.
Behdad Esfahbod 3c080a7a 2017-03-07T18:13:28 Fix buffer serialize of empty buffer Ouch!
Behdad Esfahbod 9ac9af72 2017-03-05T13:51:01 Add TODO item
Behdad Esfahbod 5aec2fb8 2017-03-02T11:46:33 Remove TODO item that is not going to happen
Behdad Esfahbod b9b005f3 2017-03-01T14:27:23 Fix Context lookup application when moving back after a glyph delete This was broken forever, since days that we did not allow moving tape backwards. Works now. Reported by Doug Felt.
Behdad Esfahbod 85630996 2017-02-25T13:30:38 Fix buffer-overrun with Bengali reph positioning code This has no security implications whatsoever since we always keep and extra element at the end of buffer, just in case. Discovered by oss-fuzz CC https://github.com/behdad/harfbuzz/issues/139 Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=660
Dominik Röttsches a657f23c 2017-02-20T21:52:07 Blacklist another instance of Padauk (#419) In https://crbug.com/681813 another instance of Padauk was identified triggering collapsed glyphs. Blacklist this version by patching hb-ot-layout.cc to print out gdef, gsub, and gpos table length, then adding those to the list of blacklisted versions.
jfkthame 44f7d6ec 2017-02-17T03:03:24 Guard against underflow when adjusting length (#421) * Guard against underflow when adjusting length With the fuzz-testcase in mozilla bug 1295299, we end up with a recursed lookup that removes 3 items, when `match_positions[idx]` is 0, which results in (unsigned) `end` wrapping to a huge value. Making `end` a signed int is probably the simplest route to a fix. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1295299. * Add testcase for #421.
jfkthame 45766b67 2017-02-16T17:40:21 [indic] Add support for Grantha marks that may be used in Tamil to th… (#401) * [indic] Add support for Grantha marks that may be used in Tamil to the Indic table. See https://bugzilla.mozilla.org/show_bug.cgi?id=1331339. Testcase: U+0BA4,U+0BC6,U+1133c,U+0BAA,U+1133c,U+0BC6,U+1133c * [indic] Add test for Grantha nukta that is allowed in Tamil by ScriptExtensions.txt
Behdad Esfahbod d4bb52b9 2017-02-09T14:13:25 Unbreak hb-coretext build
Behdad Esfahbod c8dfed8e 2017-02-08T14:36:18 Merge pull request #357 from khaledhosny/graphite-scale [graphite] Fix shaping with varying font sizes
Behdad Esfahbod 7c47474f 2017-02-08T14:33:28 Set LC_ALL instead of LANG when creating harfbuzz.def Hopefully fixes Travis faliure? https://github.com/behdad/harfbuzz/pull/413#issuecomment-278481882 https://travis-ci.org/khaledhosny/harfbuzz/jobs/199785332#L1065
Philip Withnall ffde3c9f 2017-02-08T21:56:57 hb-font: Fix a potentially undefined use of memcmp() (#413) While it’s fine to call memcmp(x, 0, 0) in practice, the C99 standard explicitly says that this is not allowed: even if the length is zero, the pointer arguments must be valid. http://stackoverflow.com/a/16363034 Coverity ID: 141178 Signed-off-by: Philip Withnall <withnall@endlessm.com>
Behdad Esfahbod 73c6dcbb 2017-02-07T16:53:21 Silence Coverity warning Fixes https://github.com/behdad/harfbuzz/issues/408
Behdad Esfahbod 466b3e58 2017-02-03T16:43:25 Shuffle things around a bit
Behdad Esfahbod fc8189b6 2017-02-03T16:17:08 Minor
Behdad Esfahbod d3d36918 2017-02-03T15:42:03 Add dirty-state tracking to hb_face_t
Behdad Esfahbod 2171f48b 2017-02-03T10:58:09 Add dirty-state tracking to hb_font_t
Behdad Esfahbod 95808bad 2017-02-03T10:39:40 Add new API hb_font_set_face() For completeness.
jfkthame 4ec19319 2017-02-02T18:48:23 Add Win10 Anniversary Update version of Tahoma to GDEF blacklist. (#412)
Behdad Esfahbod 1dd630a7 2017-02-01T11:57:21 Minor Fixes https://github.com/behdad/harfbuzz/issues/411
Behdad Esfahbod e888f642 2017-01-26T14:50:14 Route Adlam through Arabic shaper Fixes joined Adlam rendering. Fixes https://github.com/googlei18n/noto-fonts/issues/828
jfkthame 72c75487 2017-01-26T22:35:41 Add Win7 version of himalaya.ttf to the GDEF table blacklist. (#407)
Behdad Esfahbod 22af28a3 2017-01-23T23:42:53 [var] Implement MVAR table Unhooked. Untested.
Behdad Esfahbod 67a19116 2017-01-23T23:21:30 [var] Whitespace
Behdad Esfahbod 79e8e27f 2017-01-23T17:55:31 [var] Hook up advance variations to hb-ot-font Yay, works!
Behdad Esfahbod 60743403 2017-01-23T17:55:16 [var] Fix bug in HVAR/VVAR impl
Behdad Esfahbod bd3b11d9 2017-01-23T17:34:44 [var] Prepare for hooking up advance variations to hb-ot-font
Behdad Esfahbod a4fca9f0 2017-01-23T11:56:08 [var] Implement DeltaSetIndexMap and advance delta fetching Not hooked up to hb-ot-font yet.
Behdad Esfahbod 7b399f73 2017-01-23T11:41:43 [var] Start adding HVAR/VVAR
Behdad Esfahbod b732c53e 2017-01-22T20:31:53 Add LArrayOf<>
Behdad Esfahbod 5e156fa5 2017-01-22T20:28:56 Add LOffsetTo<>
Behdad Esfahbod d6bdbbca 2017-01-22T20:16:51 [var] Remove HB_OT_TAG_fvar/avar We're not going to define public macros for tags for tables. There's little use to those and they are implementation detail.
Behdad Esfahbod a11d9a04 2017-01-22T20:09:47 Minor
Behdad Esfahbod 7a860f65 2017-01-22T19:52:09 [var] Add macros for standard axes
Behdad Esfahbod a484e237 2017-01-22T19:41:33 [var] Implement 'avar' table mapping Untested!
Behdad Esfahbod 5ec96d30 2017-01-22T18:52:00 [var] Adjust API in prep for 'avar' implementation The 'avar' table does not allow random access to axis maps, so change API to avoid quadratic-time implementation. Removed -hb_ot_var_normalize_axis_value(), added +hb_ot_var_normalize_variations() and +hb_ot_var_normalize_coords() instead.
Behdad Esfahbod 8a577aaa 2017-01-22T18:22:40 [var] Stub implementation of avar table
Behdad Esfahbod 7647a05a 2017-01-22T17:47:49 Minor
Behdad Esfahbod d2f249e7 2017-01-22T17:42:33 Stub out doc comments for new symbols
Behdad Esfahbod 5dfd341f 2017-01-22T16:55:40 Minor
Behdad Esfahbod 825e4040 2017-01-22T16:41:45 [hb-ft] Remove use of variable-length array Hopefully also fixes build failure on msvc.
Behdad Esfahbod 47ee34e8 2017-01-21T18:10:08 [var] Hook up variations to FreeType face hb-view correctly renders variations with ft font-funcs now. hb-ot-font needs HVAR implementation.
Behdad Esfahbod bb1e1926 2017-01-21T17:41:37 [var] Rename var_coord to variation Looks much better.
Behdad Esfahbod 64fe92bf 2017-01-21T15:36:35 [var] Remove use of variable-length arrays
Behdad Esfahbod 2491134b 2017-01-21T15:21:50 [var] Add hb_font_set_var_coords()
Behdad Esfahbod 113393ef 2017-01-21T15:12:03 Remove a few unused includes
Behdad Esfahbod 2d40923c 2017-01-21T15:06:15 Minor
Behdad Esfahbod 8b2a5804 2017-01-21T15:05:00 [var] Add hb_font_set_var_coords_design()
Behdad Esfahbod 0dcc7b49 2017-01-21T14:50:22 [var] Minor lifecycle adjustment
Behdad Esfahbod bf0d3a66 2017-01-21T14:48:46 [var] Add hb_font_get_var_coords_normalized()
Behdad Esfahbod b3c0714b 2017-01-20T20:30:03 [var] Add hb_var_coord_t and parsing routines
Behdad Esfahbod 72364103 2017-01-20T20:16:53 Move code around
Behdad Esfahbod 785982bf 2017-01-20T19:57:27 [var] Flesh out some more
Behdad Esfahbod 422c0c36 2017-01-20T19:14:54 [var] Flesh out a bit
Behdad Esfahbod b8376b10 2017-01-20T18:19:28 Minor
Behdad Esfahbod f2e73d37 2017-01-20T17:42:18 [var] Remove over-optimization
Behdad Esfahbod 469926cc 2017-01-20T17:40:46 [var] Change double to float in API
Behdad Esfahbod 55d42fd6 2017-01-19T19:35:48 Start adding hb-ot-var.h and implementation Supports enumerating variation axes, normalizing values, etc.
Behdad Esfahbod 272b5115 2017-01-19T19:33:07 Minor
Khaled Hosny 2452543f 2017-01-18T22:48:13 [ot] Fix automatic fraction for RTL scripts (#405) The numbers for right-to-left scripts are processed also from right to left, so the order of applying “numr” and “dnom” features should be reversed in such case. Fixes https://github.com/behdad/harfbuzz/issues/395
Sascha Brawer 1337428e 2017-01-18T13:51:02 Update language tags to OpenType 1.8.1 (#403) Resolves https://github.com/behdad/harfbuzz/issues/324
Behdad Esfahbod 784d1180 2017-01-11T11:58:13 Fix build with clang
Behdad Esfahbod 1f810daf 2017-01-09T23:50:56 Port math table to hb_lazy_table_loader_t
Behdad Esfahbod ebbcc111 2017-01-09T22:45:25 Add hb_lazy_table_loader_t
Behdad Esfahbod 1af9d924 2017-01-09T22:22:37 Move lazy-loader to more generic place
Behdad Esfahbod ac274331 2017-01-09T22:20:38 In lazy-loading, remember allocation failure
Behdad Esfahbod 29fb0cb7 2017-01-09T21:18:55 Minor
Behdad Esfahbod 93ef684b 2017-01-09T21:11:00 Rename hb-ot-layout-math-table.hh to hb-ot-math-table.hh
Behdad Esfahbod 3b5263b0 2017-01-09T15:49:08 Typo
Behdad Esfahbod 00adf9c8 2017-01-09T00:00:49 Minor Should be enough to get -hangul.cc out of SOURCES in Firefox build: https://dxr.mozilla.org/mozilla-central/source/gfx/harfbuzz/src/moz.build No one else should care!
Behdad Esfahbod 7cf9952e 2017-01-08T23:55:54 [USE] Remove non-canonical decompositions We have had added this in Indic shaper to assist shaping these scripts. In Universal Shaping Engine however, it is up to font designer to decompose them. Hence moving them from Indic shaper to USE was wrong. Fixup for f6ba63b2e8eb577385f70758efdd3b8408c8a9cb Part of fixing https://github.com/behdad/harfbuzz/issues/387
Khaled Hosny b435c7c4 2016-11-11T02:16:39 [graphite] Stop creating unused gr_face It is unused after previous commit, hb_graphite2_font_get_gr_font() makes no sense now so deprecating it.
Khaled Hosny 1b00a3b0 2016-10-30T20:16:41 [graphite] Fix shaping with varying font sizes Shape using design units and scale the output. See https://bugs.documentfoundation.org/show_bug.cgi?id=103403#c7
Behdad Esfahbod 53543f8b 2017-01-05T20:12:32 Ship UCDN and use it by default So we are not relying on version of Unicode data in glib... Fixes https://github.com/behdad/harfbuzz/issues/386 Fixes https://github.com/behdad/harfbuzz/issues/388
Frédéric Wang ae00af4a 2017-01-03T05:55:09 Move math-specific code from hb-ot-layout to hb-ot-math #235 (#384)
Behdad Esfahbod 6cff7539 2016-12-28T13:46:21 Remove Tibetan decomposition rules from Indic shaper The decomposition is very obscure and unlikely to help any fonts. Just remove it since Uniscribe probably doesn't do this either. Fixes https://github.com/behdad/harfbuzz/issues/382
Behdad Esfahbod f6ba63b2 2016-12-28T13:45:32 Port decompositions from Indic to USE shaper Part of https://github.com/behdad/harfbuzz/issues/382
Behdad Esfahbod e678b537 2016-12-26T14:11:59 [indic] Remove Chakma decomposition rule from Indic shaper This is now added to USE: https://github.com/behdad/harfbuzz/pull/383 See: https://github.com/behdad/harfbuzz/issues/381 https://github.com/behdad/harfbuzz/issues/382
jfkthame 49ba6981 2016-12-28T18:00:51 [use] Special-case Chakma split-vowel decomp in the USE shaper. (#383)
Behdad Esfahbod c4ca49d5 2016-12-26T14:52:08 Revert "[indic] Remove redundant Chakma decomposition rule" This reverts commit 805f76fc002d703acfcc4c5727f0b4d1baecefaa. Need to investigate why having this rule (with the reversed order) fixes decomposition as reported by punchcutter: https://github.com/behdad/harfbuzz/issues/381#issuecomment-269237796
Behdad Esfahbod 805f76fc 2016-12-26T14:11:59 [indic] Remove redundant Chakma decomposition rule This was not used BTW since Chakma doesn't go through Indic shaper anymore. See: https://github.com/behdad/harfbuzz/issues/381 https://github.com/behdad/harfbuzz/issues/382
Behdad Esfahbod 3cc48a46 2016-12-26T13:10:31 [indix] Comment
nvelinov 7d1c5d82 2016-12-24T02:46:37 Compilation Error for ASSERT_STATIC on Some Compilers (#380) * this pointer in type definitions is not interpreted as a constant. This rule is not enforced strictly by all compilers, but the Green Hills Software compiler will regard this as an error. * Merging branches for the DEFINE_SIZE_UNION macro Adding check for the existence of static_size field in the tested member.
Behdad Esfahbod e2b87805 2016-12-22T14:40:19 Disable OTL processing for Hebrew if GPOS doesn't have Hebrew subtable New approach to fix this: https://github.com/behdad/harfbuzz/commit/69f9fbc4200442a35484d3c790ae8f4979be5d60 Previous approach was reverted as it was too broad. See context: https://github.com/behdad/harfbuzz/issues/347#issuecomment-267838368 With U+05E9,U+05B8,U+05C1,U+05DC and Arial Unicode, we now (correctly) disable GDEF and GPOS, so we get results very close to Uniscribe, but slightly different since our fallback position logic is not exactly the same: Before: [gid1166=3+991|gid1142=0+737|gid5798=0+1434] After: [gid1166=3+991|gid1142=0@402,-26+0|gid5798=0+1434] Uniscribe: [gid1166=3+991|gid1142=0@348,0+0|gid5798=0+1434]
Behdad Esfahbod 1a0f4aa6 2016-12-22T13:33:54 Revert "Synthesize GDEF glyph class for any glyph that does not have one in GDEF" This reverts commit 69f9fbc4200442a35484d3c790ae8f4979be5d60. See https://github.com/behdad/harfbuzz/issues/347#issuecomment-268873401 Fixes https://github.com/behdad/harfbuzz/issues/347
Behdad Esfahbod 4b4a1b9f 2016-12-21T23:10:43 Fix assert fail with contextual matching As discovered by libFuzzer / Chromium fuzzing. Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=659496 CC https://github.com/behdad/harfbuzz/issues/139
Behdad Esfahbod df98ce5f 2016-12-21T19:27:30 Improve debug output with really deep nesting
Behdad Esfahbod eab418c5 2016-12-21T15:51:28 Avoid infinite loop in CoverageFormat2 iteration with bad fonts Fixes https://github.com/behdad/harfbuzz/issues/363
Behdad Esfahbod 7ed71eb3 2016-12-20T15:01:16 Protect collect_glyphs() and closure() against malicious DDOS fonts Fixes https://github.com/behdad/harfbuzz/issues/363
Mike Hommey 1c98ff87 2016-09-30T18:15:37 Support building with older glib versions It is desirable to be able to build against older versions of glib. fd7a245 changed the configure check to require glib > 2.38 for G_TEST_DIST. Before that, version 2.16 was required, but in fact, since aafe395, G_PASTE is being used, which was introduced in 2.19.1. And since 0ef179e2, hb-glib uses GBytes, which were introduced in 2.31.10. 2.19.1 is rather old, but 2.38 is rather new. For Firefox, building against 2.22 is still supported, although we could probably get away with bumping that to 2.28. Either way, GBytes is not available. Arguably, if you build against a glib that doesn't support GBytes, you're not going to use the hb_glib_blob_create function, so we hide the function when building against such a glib. As for G_TEST_DIST, when building against versions of glib that don't support it, we can fallback to the previous behavior, which, AIUI, was just making the test not work when building in a separate directory.
Volker H. Simonis ad273881 2016-12-14T18:56:17 Minor fixes to pacify Coverity code scan Fixes https://github.com/behdad/harfbuzz/pull/377
ebraminio 1e1825bf 2016-12-17T10:30:40 [dwrite] Provide an experimental API for justification (#279)
Behdad Esfahbod 219cb29c 2016-09-28T17:16:06 Fix build after rebasing opentype-gx branch on top of MATH table
Behdad Esfahbod 0aedfd59 2016-09-28T17:05:43 [GX] Apply 'rvrn' feature before any other feature
Behdad Esfahbod 42c81425 2016-09-13T23:49:46 [GX] Fix build with older FreeType