src/hb-ot-shape-complex-indic.cc


Log

Author Commit Date CI Message
Behdad Esfahbod 71b4c999 2013-10-28T00:20:59 Revert "Zero marks by GDEF for Tibetan" This reverts commit d5bd0590ae2fbc7b0dee86385a565aef00ffb835. The reasoning behind that logic was flawed and made under a misunderstanding of the original problem, and caused regressions as reported by Jonathan Kew in thread titled "tibetan marks" in Oct 2013. Apparently I have had fixed the original problem with this commit: 7e08f1258da229dfaf7e1c4b5c41e5bb83906cb0 So, revert the faulty commit and everything seems to be in good shape.
Behdad Esfahbod 46a863d9 2013-10-27T23:24:50 [indic] Adjust pref reordering logic For Javanese (pref_len == 1) only reorder if it didn't ligate. That's sensible, and what the spec says. For other Indic (pref_len > 1) only reorder if ligated. Doesn't change any test numbers.
Behdad Esfahbod ddce2d8d 2013-10-18T18:07:11 [indic] Improve positioning of post-base bells and whistles Bug 58714 - Kannada u+0cb0 u+200d u+0ccd u+0c95 u+0cbe does not provide same results as Windows8 https://bugs.freedesktop.org/show_bug.cgi?id=58714 Test with U+0CB0,U+200D,U+0CCD,U+0C95,U+0CBF and tunga.ttf. Improves some scripts. Improves Bengali too, but numbers are up because we produce better results than Uniscribe for some sequences now. New numbers: BENGALI: 353724 out of 354188 tests passed. 464 failed (0.131004%) DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%) GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%) GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%) KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%) KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%) MALAYALAM: 1048140 out of 1048334 tests passed. 194 failed (0.0185056%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
Behdad Esfahbod d5bd0590 2013-10-18T16:44:54 Zero marks by GDEF for Tibetan See: http://lists.freedesktop.org/archives/harfbuzz/2013-April/003101.html
Behdad Esfahbod c16012e9 2013-10-18T02:27:00 [indic] Add Javanese support! Seems to be working just fine!
Behdad Esfahbod 9a49351c 2013-10-18T02:14:53 [indic] Swith pref logic to use _hb_glyph_info_substituted() See comments from caveat! Seems to work fine. This is useful for Javanese which has an atomically encoded pre-base reordering Ra which should only be reordered if it was substituted by the pref feature.
Behdad Esfahbod f175aa33 2013-10-18T02:07:44 [indic] Fix compiler warnings
Behdad Esfahbod a1f7b285 2013-10-18T01:09:08 [otlayout] Switch over from old is_a_ligature() to IS_LIGATED Impact should be minimal and positive.
Behdad Esfahbod 3ddf892b 2013-10-18T00:02:43 [otlayout] Renaming
Behdad Esfahbod 8f9ec92d 2013-10-17T19:52:47 [indic] Adjust Javanese base algorithm
Behdad Esfahbod 74f4bbf0 2013-10-17T19:07:53 [indic] Towards supporting atomicly-encoded prebase-reorderings
Behdad Esfahbod efed40b9 2013-10-17T18:50:11 [indic] Minor refactoring of reph handling
Behdad Esfahbod 684fe59f 2013-10-17T18:30:06 [indic] Minor refactoring of would_substitute()
Behdad Esfahbod b5a0f69e 2013-10-17T18:04:23 [indic] Pass zero-context=false to would_substitute for newer scripts For scripts without an old/new spec distinction, use zero-context=false. This changes behavior in Sinhala / Khmer, but doesn't seem to regress. This will be useful and used in Javanese.
Behdad Esfahbod c4e71ff3 2013-10-17T17:04:47 [indic] Clean up Khmer and Sinhala base finding algorithm
Behdad Esfahbod e10453e6 2013-10-17T16:49:06 [indic] Add BASE_POS_LAST_SINHALA Previously we planted this into the mode used for Khmer. There's not really much in common between the two, so separate again.
Behdad Esfahbod 9ac6b01e 2013-10-17T16:27:38 [indic] Adjust Sinhala cluster merging under uniscribe Similar to 190c8f2b60af0851bf692f653c1604cfbf0561a5 but for Sinhala.
Behdad Esfahbod 6b2abdcd 2013-10-17T13:15:43 [indic] Improve clusters in presence of reph
Behdad Esfahbod 42d0f55c 2013-10-17T13:05:05 [indic] Apply calt,clig in the same stage as presentation features Whic means these twp are applied per-syllable now. Apparently in some Khmer fonts the clig interacts with presentation features. Test case: U+1781,U+17D2,U+1789,U+17BB,U+17C6 with Mondulkiri-R.ttf should produce one big ligature.
Behdad Esfahbod ae9a5834 2013-10-17T12:24:55 [indic] Fix pref vs blwf interaction If a glyph can be both blwf and pref, we were wrongly sorting it in the post position instead of below position.
Behdad Esfahbod c7dacac0 2013-10-17T12:20:24 [indic] Don't apply blwf before base under old-spec mode Test case: U+09AC,U+09CD,U+09A6 with Lohit-Bengali 2.5.3.
Behdad Esfahbod 3756efaf 2013-10-16T19:06:29 [indic] Misc harmless fixes! First, we were abusing OT_VD instead of OT_A. Fix that but moving OT_A in the grammar where it belongs (which is different from what the spec says). Also, only allow medial consonants after all other consonants. This doesn't affect any current character. Finally, fix Halant attachment in presence of medial consonants. Again, this currently doesn't affect any sequence. I lied. There's Gurmukhi U+0A75 which is Consonant_Medial. Uniscribe allows one of those in each of these positions: before matras, after matras and before syllable modifiers, and after syllable modifiers! We currently just allow unlimited numbers of it, before matras.
Behdad Esfahbod 28d5daec 2013-10-16T12:32:12 [indic] More granular post-base cluster merging!
Behdad Esfahbod 9cb59d46 2013-10-16T11:34:07 [indic] Fix cluster merging of left matras The merge_clusters there was totally broken.
Behdad Esfahbod 190c8f2b 2013-10-16T11:33:18 [indic] Adjust cluster merging under uniscribe mode for Tamil Apparently Uniscribe Tamil shaper doesn't ship chubby clusters for Tamil. Adjust to that.
Behdad Esfahbod f5299eff 2013-10-15T18:13:07 [indic] Simplify reph logic *Shouldn't* break anything.
Behdad Esfahbod 65a929b1 2013-10-15T18:08:05 [indic] If Malayalam dot-reph formed a ligature, don't move it Rachana-0.6 implements dot-reph by ligation, so we shouldn't move it. Uniscribe doesn't either. Test case: U+0D4E,U+0D1A,U+0D4D,U+0D1A,U+0D4D
Behdad Esfahbod a01cbf6c 2013-10-15T16:37:53 [indic] Harmless reordering of Khmer features!
Behdad Esfahbod eb10233b 2013-10-15T15:26:44 [indic] Apply 'kern' for all scripts except for Khmer in Uniscribe mode Seems to better match Uniscribe. Note: NotoSansTelugu-Regular has kern feature, so this fixes most of the positioning failures there, except for the kern pairs blocked by a (non-)joiner, in which case we (correctly) kern, but Uniscribe doesn't.
Behdad Esfahbod 30145272 2013-10-15T13:47:27 [indic] Don't apply presentation features across syllables More like Uniscribe... We still allow user-defined features to work across syllables, but not pres,blws,abs,psts,etc. This "regressed" Sinhala numbers by 11. These are cases were there's Consonant followed by Ra,Halant,ZWJ at the of text. The Ra,Halant,ZWJ ends up forming reph, which is wrong... But before we were also ligating that reph with the previous consonant. That's even more wrong. That's also what Uniscribe does. Current numbers: BENGALI: 353732 out of 354188 tests passed. 456 failed (0.128745%) DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%) GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%) GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%) KANNADA: 951030 out of 951913 tests passed. 883 failed (0.0927606%) KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%) MALAYALAM: 1048140 out of 1048334 tests passed. 194 failed (0.0185056%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271655 out of 271847 tests passed. 192 failed (0.070628%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
Behdad Esfahbod 3c7b3641 2013-10-15T11:21:01 [indic] Handle Avagraha It can come either at the end(ish!) of the syllable, or independently. When independent, it accepts a few bits and pieces.
Behdad Esfahbod 8acbb6be 2013-10-15T12:15:49 [indic] Some scripts like blwf applied to pre-base characters ...while some don't! Improved Bengali, Devanagari, Gurmukhi, Malayalam. Updated numbers: BENGALI: 353732 out of 354188 tests passed. 456 failed (0.128745%) DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%) GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%) GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%) KANNADA: 951030 out of 951913 tests passed. 883 failed (0.0927606%) KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%) MALAYALAM: 1048134 out of 1048334 tests passed. 200 failed (0.0190779%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271666 out of 271847 tests passed. 181 failed (0.0665816%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
Behdad Esfahbod bdd8873f 2013-08-07T17:58:25 Revert "[Indic] don't apply 'calt' by default in Indic shaper" This reverts commit 952121007c6f6f374e4cf1734ebcfe2d2d71c71c. In light of discussion on the mailing list...
Jonathan Kew 95212100 2013-08-06T10:36:14 [Indic] don't apply 'calt' by default in Indic shaper
Behdad Esfahbod 9245e987 2013-06-26T20:57:58 [Indic] Add Javanese config We should add for other scripts too, send me the virama codepoint and script name...
Behdad Esfahbod a8cf7b43 2013-03-19T05:53:26 [Indic] Futher adjust ZWJ handling in Indic-like shapers After the Ngapi hackfest work, we were assuming that fonts won't use presentation features to choose specific forms (eg. conjuncts). As such, we were using auto-joiner behavior for such features. It proved to be troublesome as many fonts used presentation forms ('pres') for example to form conjuncts, which need to be disabled when a ZWJ is inserted. Two examples: U+0D2F,U+200D,U+0D4D,U+0D2F with kartika.ttf U+0995,U+09CD,U+200D,U+09B7 with vrinda.ttf What we do now is to never do magic to ZWJ during GSUB's main input match for Indic-style shapers. Note that backtrack/lookahead are still matched liberally, as is GPOS. This seems to be an acceptable compromise. As to the bug that initially started this work, that one needs to be fixed differently: Bug 58714 - Kannada u+0cb0 u+200d u+0ccd u+0c95 u+0cbe does not provide same results as Windows8 https://bugs.freedesktop.org/show_bug.cgi?id=58714 New numbers: BENGALI: 353689 out of 354188 tests passed. 499 failed (0.140886%) DEVANAGARI: 707305 out of 707394 tests passed. 89 failed (0.0125814%) GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%) GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%) KANNADA: 951030 out of 951913 tests passed. 883 failed (0.0927606%) KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048102 out of 1048334 tests passed. 232 failed (0.0221304%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271666 out of 271847 tests passed. 181 failed (0.0665816%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
Behdad Esfahbod fb7c182b 2013-03-06T00:53:24 [Indic] Minor
Behdad Esfahbod 8144936d 2013-03-05T20:08:59 [Indic] Work around fonts with broken new-spec tables See comments, and this thread: http://lists.freedesktop.org/archives/harfbuzz/2013-March/002990.html Originally reported here: https://code.google.com/p/chromium/issues/detail?id=96143 Doesn't change test suite numbers.
Behdad Esfahbod 41732f1f 2013-02-27T20:40:54 [Indic] Help compiler put indic_features table in .rodata The overridden "or" operator was preventing the flag expression from being const, and putting the table in .data instead or .rodata.
Behdad Esfahbod 94789fd6 2013-02-26T21:22:37 [Indic] Sort pre-base reordering consonants with post-forms Before, we were marking them as below-form for initial reordering. However, there is a rule that says "post consonants should follow below consonsnts" for base determination purposes. Malayalam has port-form YA/VA, and RA is pre-base. As such, for a sequence like YA,Virama,YA,Virama,RA, the correct base is at index 0. But because the code was seeing RA as a below-base, it was stopping at the second YA as base, instead of jumping it as a post-base. By treating prebase-reordering consonants like post-forms, this is fixed. MALAYALAM went down from 351 to 265. Other numbers didn't change: BENGALI: 353686 out of 354188 tests passed. 502 failed (0.141733%) DEVANAGARI: 707305 out of 707394 tests passed. 89 failed (0.0125814%) GUJARATI: 366262 out of 366457 tests passed. 195 failed (0.0532122%) GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%) KANNADA: 950680 out of 951913 tests passed. 1233 failed (0.129529%) KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048069 out of 1048334 tests passed. 265 failed (0.0252782%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271539 out of 271847 tests passed. 308 failed (0.113299%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
Behdad Esfahbod cfc507c5 2013-02-14T10:40:12 [Indic-like] Disable automatic joiner handling for basic shaping features Not for Arabic, but for Indic-like scripts. ZWJ/ZWNJ have special meanings in those scripts, so let font lookups take full control. This undoes the regression caused by automatic-joiners handling introduced two commits ago. We only disable automatic joiner handling for the "basic shaping features" of Indic, Myanmar, and SEAsian shapers. The "presentation forms" and other features are still applied with automatic-joiner handling. This change also changes the test suite failure statistics, such that a few scripts show more "failures". The most affected is Kannada. However, upon inspection, we believe that in most, if not all, of the new failures, we are producing results superior to Uniscribe. Hard to count those! Here's an example of what is fixed by the recent joiner-handling changes: https://bugs.freedesktop.org/show_bug.cgi?id=58714 New numbers, for future reference: BENGALI: 353892 out of 354188 tests passed. 296 failed (0.0835714%) DEVANAGARI: 707336 out of 707394 tests passed. 58 failed (0.00819911%) GUJARATI: 366262 out of 366457 tests passed. 195 failed (0.0532122%) GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%) KANNADA: 950680 out of 951913 tests passed. 1233 failed (0.129529%) KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1047983 out of 1048334 tests passed. 351 failed (0.0334817%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271539 out of 271847 tests passed. 308 failed (0.113299%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
Behdad Esfahbod ec544866 2013-02-14T11:25:10 Add hb_ot_map_feature_flags_t Code cleanup. No (intended) functional change.
Behdad Esfahbod e7ffcfaf 2013-02-14T11:05:56 Clean-up add_bool_feature
Behdad Esfahbod 1f91c396 2013-02-13T09:38:40 Indent
Behdad Esfahbod a0cb9f33 2013-02-13T09:26:55 [Indic] Improve base finding in final_reordering Fixes 5 Malayalam failures! MALAYALAM: 1048016 out of 1048334 tests passed. 318 failed (0.0303338%)
Behdad Esfahbod f22b7e77 2013-02-13T07:32:46 [Indic] Track base position when reordering things Ouch, how did things ever work without this?! The added test that has a dot-reph as well as a pre-base reordering Ra perfectly demonstrates the bug (tested with Nirmala font from Win8 for example). Testing suggests that Win8 shaper has the *exact* same bug / behavior that we used to have. Odd.
Behdad Esfahbod 85c51ec2 2013-02-12T18:17:39 [Indic] Fix Eyelash Ra with old Devanagari spec
Behdad Esfahbod 63e48bc3 2013-02-12T17:57:49 [Indic] Apply 'blwf' before 'half' This reverts 167b625d988b74572d6b2f646c285b666b650d49. It didn't matter before, but that's going to change with next commit.
Behdad Esfahbod 70d65657 2013-02-12T18:01:21 [Indic] Apply 'vatu' before 'cjct' This essentially reverts 1d6846db9ebf84561bb30a4e48c6c43184914099, but that commit is from way back when. We should be better following the spec order now again.
Behdad Esfahbod bab02d33 2013-02-12T15:26:45 Rename HB_OT_INDIC_OPTIONS env var to HB_OPTIONS The Myanmar shaper now respects the uniscribe-bug-compatibility option too.
Behdad Esfahbod 3a83d33e 2013-02-12T12:14:10 Add South-East Asian shaper Handles Tai Tham, Cham, and New Tai Lue for now.
Behdad Esfahbod 56800027 2013-02-12T09:44:57 Adjust mark advance-width zeroing logic for Myanmar Before, we were zeroing advance width of attached marks for non-Indic scripts, and not doing it for Indic. We have now three different behaviors, which seem to better reflect what Uniscribe is doing: - For Indic, no explicit zeroing happens whatsoever, which is the same as before, - For Myanmar, zero advance width of glyphs marked as marks *in GDEF*, and do that *before* applying GPOS. This seems to be what the new Win8 Myanmar shaper does, - For everything else, zero advance width of glyphs that are from General_Category=Mn Unicode characters, and do so before applying GPOS. This seems to be what Uniscribe does for Latin at least. With these changes, positioning of all tests matches for Myanmar, except for the glitch in Uniscribe not applying 'mark'. See preivous commit.
Behdad Esfahbod 98628cac 2013-02-11T13:36:23 Add Win8-style Myanmar shaper Myanmar failures down from 51% to 0.00204648%! MYANMAR: 1123860 out of 1123883 tests passed. 23 failed (0.00204648%)
Behdad Esfahbod 1df56449 2013-02-11T14:17:54 Minor
Behdad Esfahbod 9621e0ba 2013-02-11T06:58:27 [Indic] Fix bug introduced in 8b217f5ac54aa0dcbba2dd6d59aa89dde33e56c2 Was breaking reph formation logic when the Ra is the only consonant. Devanagari regression fixed. Down to 57 failures again. Ouch.
Behdad Esfahbod ecd454b3 2013-01-08T18:09:46 [Indic] In old-spec shaping, don't move viramas around if seq ends with one For example: u0c9a u0ccd u0c9a u0ccd with Lohit. See: https://bugs.freedesktop.org/show_bug.cgi?id=59118
Behdad Esfahbod 596740db 2012-12-21T19:41:04 [Indic] Insert dottedcircle after a lone Malayalam dot-reph
Behdad Esfahbod 8b217f5a 2012-12-21T15:48:32 [Indic] Reorder Malayalam dot-reph to after base Test sequence is simple: U+0D4E,U+0D15. The doth-reph should be reordered to after the Ka. https://bugzilla.redhat.com/show_bug.cgi?id=799565
Behdad Esfahbod 742c4ee9 2012-12-21T15:35:03 Minor
Behdad Esfahbod b71b0bd9 2012-12-05T19:20:31 [Indic] Add link to Sinhala split matra section of the Sinhala spec
Behdad Esfahbod 0beb66e3 2012-12-05T18:46:04 Fix warnings
Behdad Esfahbod 43b65315 2012-11-16T13:12:35 [Indic] Another try to unbreak Sinhala split matras Just read the comments...
Behdad Esfahbod eba312c8 2012-11-16T12:39:23 Plumbing to get shape plan and font into complex decompose function So we can handle Sinhala split matras smartly... Coming soon.
Behdad Esfahbod 362a990b 2012-11-15T14:57:31 Rename hb_ot_layout_would_substitute_lookup() and hb_ot_layout_substitute_closure_lookup() To match upcoming API.
Behdad Esfahbod f41dc2d3 2012-11-15T10:36:43 Fix undefined behavior in Indic dottedcircle Chromium Issue 158998: Conditional jump in harfbuzz-ng http://code.google.com/p/chromium/issues/detail?id=158998
Behdad Esfahbod 851784f8 2012-11-14T16:24:05 Improve shaper selection
Behdad Esfahbod d469fadc 2012-11-14T15:07:36 [Indic] Exchange abort() for assert()
Behdad Esfahbod 865745b5 2012-11-14T13:48:26 Don't do fallback positioning for Indic and Thai shapers
Behdad Esfahbod dde5506f 2012-11-14T11:37:04 [Indic] Don't move virama with left matra This is important for the Sinhala U+0DDA split matra since it decomposes to U+0DD9,U+0DCA where U+0DD9 is a left matra and U+0DCA is the virama. We don't want to move the virama with the left matra. TEST: U+0D9A,U+0DDA Note that we were already doing this in the Uniscribe bug compatibility mode. We now do it all the time.
Behdad Esfahbod 0736915b 2012-11-13T12:35:35 [Indic] Decompose Sinhala split matras the way old HarfBuzz / Pango did Had to do some refactoring to make this happen... Under uniscribe bug compatibility mode, we still plit them Uniscrie-style, but Jonathan and I convinced ourselves that there is no harm doing this the Unicode way. This change makes that happen, and unbreaks free Sinhala fonts.
Behdad Esfahbod 8173f23f 2012-11-12T18:37:20 [Indic] Add config for Myanmar
Behdad Esfahbod c4be9917 2012-11-12T14:27:33 Typo
Behdad Esfahbod 56be6777 2012-11-12T14:09:40 [Indic] Port 'pref' logic to look into font tables ...instead of using a hardcoded list of Ra characters.
Behdad Esfahbod f2c0f590 2012-11-12T14:02:02 [Indic] Port reph handling logic to look into font features ...instead of using a hardcoded list of Ra characters.
Behdad Esfahbod 6b389ddc 2012-11-12T11:02:56 [Indic] Don't apply 'liga' Uniscribe doesn't. And some fonts abuse this feature to get Indic shaping working in non-complex applications like Adobe's apps. No change in numbers: BENGALI: 353897 out of 354188 tests passed. 291 failed (0.0821598%) DEVANAGARI: 707337 out of 707394 tests passed. 57 failed (0.00805774%) GUJARATI: 366440 out of 366457 tests passed. 17 failed (0.00463902%) GURMUKHI: 60704 out of 60747 tests passed. 43 failed (0.0707854%) KANNADA: 951046 out of 951913 tests passed. 867 failed (0.0910798%) KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048011 out of 1048334 tests passed. 323 failed (0.0308108%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271666 out of 271847 tests passed. 181 failed (0.0665816%) TAMIL: 1091754 out of 1091754 tests passed. 0 failed (0%) TELUGU: 970557 out of 970573 tests passed. 16 failed (0.00164851%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
Behdad Esfahbod 88d3c98e 2012-10-29T16:27:02 [Indic] Position pre-base reordering Ra after Chillus in Malayalam The logic for pre-base reordering follows the left matra logic. We had an exception for Malayalam/Tamil in the left matra repositioning which was not reflected in pre-base reordering. Malayalam failures down from 337 to 323. BENGALI: 353996 out of 354285 tests passed. 289 failed (0.0815727%) DEVANAGARI: 707339 out of 707394 tests passed. 55 failed (0.00777502%) GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%) GURMUKHI: 60769 out of 60809 tests passed. 40 failed (0.0657797%) KANNADA: 951086 out of 951913 tests passed. 827 failed (0.0868777%) KHMER: 299106 out of 299124 tests passed. 18 failed (0.00601757%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048011 out of 1048334 tests passed. 323 failed (0.0308108%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271726 out of 271847 tests passed. 121 failed (0.0445103%) TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%) TELUGU: 970558 out of 970573 tests passed. 15 failed (0.00154548%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
Behdad Esfahbod 166b5cf7 2012-09-07T14:55:07 [Indic] Find syllables before any features are applied With FreeSerif, it seems that the 'ccmp' feature does ligature substituttions. That was then causing syllable match failures. We now find syllables before any features have been applied. Test sequence: U+0D9A,U+0DCA,U+200D,U+0DBB,U+0DCF
Behdad Esfahbod 27bd55bd 2012-09-05T15:11:14 [Indic] Tamil does not have half-forms either The Win7 Tamil font does not realy on this behavior, but the WinXP version does. Handle Tamil like Malayalam: Matras always move to before base. WinXP Tamil failures went down from 168964 (15.4752%) to 167 (0.0152953%) (two orders of magnitude reduction!). Included in this is a minor fixup that actually fixed a few tests with non-Tamil too. Numbers at: BENGALI: 353997 out of 354285 tests passed. 288 failed (0.0812905%) DEVANAGARI: 707339 out of 707394 tests passed. 55 failed (0.00777502%) GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%) GURMUKHI: 60769 out of 60809 tests passed. 40 failed (0.0657797%) KANNADA: 951086 out of 951913 tests passed. 827 failed (0.0868777%) KHMER: 299106 out of 299124 tests passed. 18 failed (0.00601757%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048104 out of 1048416 tests passed. 312 failed (0.0297592%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271747 out of 271847 tests passed. 100 failed (0.0367854%) TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%) TELUGU: 970558 out of 970573 tests passed. 15 failed (0.00154548%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
Behdad Esfahbod b85800f9 2012-08-31T18:12:01 [Indic] Implement dotted-circle insertion for broken clusters No panic, we reeally insert dotted circle when it's absolutely broken. Fixes most of the dotted-circle cases against Uniscribe. (for Devanagari fixes 80% of them, for Khmer 70%; the rest look like Uniscribe being really bogus...) I had to make a decision. Apparently Uniscribe adds one dotted circle to each broken character. I tried that, but that goes wrong easily with split matras. So I made it add only one dotted circle to an entire broken syllable tail. As in: "if there was a dotted circle here, this would have formed a correct cluster." That works better for split stuff, and I like it more.
Behdad Esfahbod 327d14ef 2012-08-31T16:49:34 [Indic] Start adding dotted-circle instrastructure
Behdad Esfahbod 23b0e9d7 2012-08-26T14:30:18 [Indic] Fix switch D'oh. Was working by pure chance :)).
Behdad Esfahbod b5584ee4 2012-08-23T16:26:07 [Indic] For old-spec, match non-zero context Fixes consonant-position with old-spec Malayalam. Uniscribe seem to be doing this. Fixes below-base La (eg. Pa,H,La) with AnjaliNewLipi.ttf. Doesn't regress new-spec or other scripts.
Behdad Esfahbod d9b204d3 2012-08-23T16:22:28 [GSUB] Allow non-zero-context matching in would_apply() To be used in the next patch.
Behdad Esfahbod 6732d62e 2012-08-23T15:19:45 [Indic] Implement pre-base reordering Ra for old-spec Malayalam Fixes Pa,H,Ra sequence with AnjaliNewLipi.ttf.
Behdad Esfahbod 80cd9232 2012-08-23T12:06:14 [Indic] Only apply basic features per-syllable Free up syllables and let features work across syllables for the presentation forms features and GPOS. Fixed: - 1 GURMUKHI test (remains 40) - 12 KHMER tests (remains 18) - 11 SINHALA tests (remains 121) Regresses: - 5 MALAYALAM tests (up to 312) Current numbers: BENGALI: 353996 out of 354285 tests passed. 289 failed (0.0815727%) DEVANAGARI: 707339 out of 707394 tests passed. 55 failed (0.00777502%) GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%) GURMUKHI: 60769 out of 60809 tests passed. 40 failed (0.0657797%) KANNADA: 951086 out of 951913 tests passed. 827 failed (0.0868777%) KHMER: 299106 out of 299124 tests passed. 18 failed (0.00601757%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048104 out of 1048416 tests passed. 312 failed (0.0297592%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271726 out of 271847 tests passed. 121 failed (0.0445103%) TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%) TELUGU: 970558 out of 970573 tests passed. 15 failed (0.00154548%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
Behdad Esfahbod 9f9f04c2 2012-08-11T18:34:13 [OT] Unbreak Thai shaping and fallback Arabic shaping The merger of normalizer and glyph-mapping broke shapers that modified text stream. Unbreak them by adding a new preprocess_text shaping stage that happens before normalizing/cmap and disallow setup_mask modification of actual text.
Behdad Esfahbod a02d8648 2012-08-08T18:04:29 Add check-exported-symbols.sh And misc linking fixes.
Behdad Esfahbod 167b625d 2012-08-05T21:16:26 [Indic] Minor, move 'blwf' after 'half' We don't apply them together anyway. Should not make any difference right now.
Behdad Esfahbod 8ba80428 2012-08-03T18:54:54 [Indic] Fix consonant position font lookup logic Oops. I broken this badly and the test suite did not notice. That worries me. Have to investigate.
Behdad Esfahbod 11b0e20b 2012-08-02T14:21:40 [Indic] Add per-script configuration tables This concludes the Indic shape_plan work. May do for Arabic also...
Behdad Esfahbod 85fc6c48 2012-08-02T12:21:44 [Indic] Move more stuff to the shape_plan Almost done. Need to add per-script static tables.
Behdad Esfahbod 914ffaa4 2012-08-02T11:03:39 [Indic] Move more repeated work into shape_plan
Behdad Esfahbod a8c6da90 2012-08-02T10:46:34 [OT] Add per-complex-shaper shape_plan data Hookup some Indic data to it. More to come.
Behdad Esfahbod 8bb5deba 2012-08-02T10:07:58 [OT] Pipe shape_plan down to pause_callbacks
Behdad Esfahbod 3e38c0f2 2012-08-02T09:44:18 More massaging
Behdad Esfahbod 16c6a27b 2012-08-02T09:38:28 [OT] Port complex_shaper to planner/plan
Behdad Esfahbod 24eacf17 2012-08-02T08:42:11 [Indic] Move consonant-position-setting into initial_reordering()
Behdad Esfahbod afbcc24b 2012-08-02T08:36:40 [GSUB] Wire the font, not just the face, down to substitute() We need the font for glyph lookup during GSUB pauses in Indic shaper. Could perhaps be avoided, but at this point, we don't mean to support separate substitute()/position() entry points (anymore), so there is no point in not providing the font to GSUB.
Behdad Esfahbod 8ef3d532 2012-08-02T07:53:18 [Indic] More refactoring of consonant position peeking in the font To be moved to initial_reordering next...
Behdad Esfahbod 3eb6f81f 2012-08-02T07:37:46 [Indic] Refactor Move all the logic that needs to eventually move into the indic table into hb-ot-shape-complex-indic-private.hh.