Log

Author Commit Date CI Message
Ebrahim Byagowi db96c7f6 2020-08-10T08:23:21 [glyf] protect CompositeGlyph fields Introduce methods instead
ebraminio e5fe363a 2020-08-10T07:39:36 [glyf] Minor, don't pass accelerator_t to points_aggregator_t No need to pass it to aggregator itself
ebraminio 2b9927f7 2020-08-10T06:26:21 [glyf] minor No need to pass glyph_for_gid as a lambda now that we are passing the accelerator itself
Behdad Esfahbod fce64a40 2020-08-08T14:04:54 Minor
Ebrahim Byagowi ffe06c8f 2020-08-08T13:17:34 [glyf] Guard all the public APIs against null pool runs Fixes https://crbug.com/oss-fuzz/24575 and https://crbug.com/oss-fuzz/24737
Ebrahim Byagowi 01ac32aa 2020-08-02T11:35:55 Remove autotools build support
Ryan Schmidt 3d164d58 2020-08-06T20:45:44 Use printf instead of echo -n in autogen.sh "echo -n" is not portable and on some POSIX systems it literally prints "-n".
Ebrahim Byagowi 1f519c25 2020-08-07T01:21:19 [glyf] Optimize retrieval of hmtx/vmtx/gvar This should make glyf/gvar faster as makes it to invoke less table wrapper atomic operations and things. $ meson build -Dexperimental_api=true --buildtype=release && ninja -Cbuild && build/perf/perf "--benchmark_filter=glyf.*- ot -" Before: extents/glyf - ot - SourceSerifVariable 46091 ns 46036 ns 16173 extents/glyf/vf - ot - SourceSerifVariable 4160142 ns 4154913 ns 174 extents/glyf - ot - Comfortaa 25754 ns 25726 ns 27030 extents/glyf/vf - ot - Comfortaa 2627804 ns 2624596 ns 265 extents/glyf - ot - Roboto 33556 ns 33540 ns 18513 draw/glyf - ot - SourceSerifVariable 2716848 ns 2715438 ns 256 draw/glyf/vf - ot - SourceSerifVariable 4602379 ns 4598907 ns 151 draw/glyf - ot - Comfortaa 1659364 ns 1658142 ns 417 draw/glyf/vf - ot - Comfortaa 2845100 ns 2842549 ns 246 draw/glyf - ot - Roboto 1571509 ns 1570060 ns 442 After: extents/glyf - ot - SourceSerifVariable 34738 ns 34713 ns 21332 extents/glyf/vf - ot - SourceSerifVariable 3700510 ns 3698104 ns 187 extents/glyf - ot - Comfortaa 21604 ns 21595 ns 31907 extents/glyf/vf - ot - Comfortaa 2324787 ns 2323440 ns 296 extents/glyf - ot - Roboto 31259 ns 31246 ns 21814 draw/glyf - ot - SourceSerifVariable 2689230 ns 2687589 ns 260 draw/glyf/vf - ot - SourceSerifVariable 4625135 ns 4622036 ns 131 draw/glyf - ot - Comfortaa 1690336 ns 1689454 ns 402 draw/glyf/vf - ot - Comfortaa 2898748 ns 2897074 ns 241 draw/glyf - ot - Roboto 1570911 ns 1570138 ns 440
Ebrahim Byagowi 0907c102 2020-08-07T00:15:32 [gvar] minor
Ebrahim Byagowi 679fac87 2020-07-30T15:29:43 Skip hb_shape if buffer object is immutable
Ebrahim Byagowi 55c41f21 2020-08-06T23:37:43 [glyf] Clamp advance value result Fixes a sanitizer complain https://circleci.com/gh/harfbuzz/harfbuzz/150247 revealed by 02d1ec1
Ebrahim Byagowi 02d1ec16 2020-08-06T22:18:35 [gvar] Don't fail on imprefect gvar No need to fail even if gvar doesn't have that much glyphs
Ebrahim Byagowi ec17b624 2020-08-06T20:16:11 [var] Apply variations on empty glyphs It was ignoring empty glyphs for no good reason, this fixes it. Fixes #2618
Ebrahim Byagowi 5cab55ca 2020-08-06T18:54:58 [gvar] minor
Ebrahim Byagowi 20e42a21 2020-08-04T16:49:27 [docs] minor on TESTING.md
Ebrahim Byagowi 5a2d216f 2020-08-04T15:25:48 [docs] meson related updates on install
Ebrahim Byagowi 34a05320 2020-08-04T15:14:59 [meson] minor note
Ebrahim Byagowi cac483bf 2020-08-03T18:41:49 [docs] Update README.python.md with meson
Ebrahim Byagowi 75efa893 2020-07-30T01:17:42 Remove cmake-config support of HarfBuzz Reverts d38f37b2 as discussed in #2316
Ebrahim Byagowi 97079a7c 2020-08-02T12:34:21 [meson] Pass cpp_eh=none and cpp_rtti=false as default options If we want to support a build with exception handling and RTTI We should reflect that on library(..., link_language: 'c') also so for now it is ok to just set it here to get MSVC support also and we can remove hard coded flags later upon request. One other concern over just relying on it is on when harfbuzz is used as a subproject and the parent project hasn't provided the same options, that should be resolved first I think. Closes #2584
Ebrahim Byagowi 749e2754 2020-08-02T12:21:51 [meson] remove useless note about -fvisibility-inlines-hidden It was put there as current situation of autotools but msys2 is ok with the flag, if something like is needed for other it can handled as a local patch.
Ebrahim Byagowi 903d6a1f 2020-08-02T11:40:47 [perf] Enable ttf-parser build just with experimental_api ttf-parser API is subject to breaking change and we are interested on its hb-draw like API so let's hide it more.
Ebrahim Byagowi cdb7d2b9 2020-08-02T11:26:29 [docs] Update README.python.md with meson
Ebrahim Byagowi 9fd48de6 2020-08-02T11:22:09 [docs] Adopt CONFIG.md with meson
Ebrahim Byagowi b0a4860d 2020-08-02T11:15:15 [docs] Remove packagers related part Covered by https://github.com/harfbuzz/harfbuzz/wiki/Notes-on-migration-to-meson
Ebrahim Byagowi 50151567 2020-08-02T10:43:25 [ci] Disable Travis CI
Ebrahim Byagowi 11bb8aa8 2020-08-02T00:47:21 [meson] limit check-libstdc++ check to 0.55 library(..., link_language: 'c') is introduced in 0.55 but we were relying on this anyway assuming b_asneeded being true on meson. #2614
Ebrahim Byagowi 9d3fbe05 2020-07-30T14:54:00 [meson] Add darwin versions to library() We now have, $ otool -L src/libharfbuzz.dylib src/libharfbuzz.dylib: @rpath/libharfbuzz.0.dylib (compatibility version 0.0.0, current version 0.0.0) And with the change should we get $ otool -L src/libharfbuzz.dylib src/libharfbuzz.dylib: @rpath/libharfbuzz.0.dylib (compatibility version 20700.0.0, current version 20700.0.0)
Garret Rieger 18ab8029 2020-07-31T14:40:49 [ENOMEM] check vector status in cmap subsetting.
Garret Rieger 06dbb6ac 2020-07-31T15:56:14 [ENOMEM] in GSUB ChainContext subsetting check maps for allocation errors.
Garret Rieger fb147779 2020-07-31T14:00:38 [ENOMEM] Check result of vector resize in CBDT subsetting.
Ebrahim Byagowi 8586bad2 2020-07-31T09:28:51 [ci] don't install rustc on linux-ci https://github.com/harfbuzz/harfbuzz/pull/2610/checks?check_run_id=930572217
Ebrahim Byagowi efd716de 2020-07-31T08:58:53 [cff] Check for scalars array resize result Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24504
Garret Rieger 040ed094 2020-07-30T15:14:02 [ENOMEM] popragate packed/packed_map errors to the serializer. Will disable further modifications based on a bad state.
Garret Rieger 7f358a55 2020-07-30T13:57:30 [ENOMEM] unchecked resize in CFF2.
Garret Rieger 32f052b0 2020-07-30T13:45:04 [ENOMEM] Fix several instances of not checking resize in CFF.
Garret Rieger 4cbc7d61 2020-07-30T12:20:31 [ENOMEM] check for unset current in serializer->length().
Ebrahim Byagowi 0d22fb38 2020-07-30T23:18:57 Copy parts of README.md to README Fixes https://github.com/harfbuzz/harfbuzz/issues/2591
Ebrahim Byagowi cac30711 2020-07-30T16:25:42 [meson] minor, use null_dep one more place
Ebrahim Byagowi 4e572c94 2020-07-30T16:19:15 Remove cmake build files As discussed in https://github.com/harfbuzz/harfbuzz/pull/2252
Ebrahim Byagowi 5f9ff04f 2020-06-18T02:33:05 Add comparison against ttf-parser
Ebrahim Byagowi 87f4aada 2020-07-30T15:20:17 [docs] Update TESTING.md with meson
Garret Rieger 15644ee6 2020-07-29T16:37:39 [ENOMEM] fix memory leak if allocation fails during pop_pack().
Garret Rieger 42237adf 2020-07-29T15:18:25 [ENOMEM] make serializer modification operations no-ops if it's in an error state.
Ebrahim Byagowi d1f13014 2020-07-30T02:01:43 [icu] Remove support for versions older than 49 It just doesn't make sense anymore, https://github.com/harfbuzz/harfbuzz/commit/c9e5da8ded390b816613839214fe96137ca0a0a2#r41018112
Ebrahim Byagowi 0b74aaec 2020-07-30T01:47:30 [icu] Remove useless HB_UNUSED tags As https://github.com/harfbuzz/harfbuzz/commit/c9e5da8ded390b816613839214fe96137ca0a0a2#r41018040
Ebrahim Byagowi c9e5da8d 2020-07-30T00:53:40 [icu] Remove support of ICU versions before 42 ICU 42 is released in 2012, see also https://github.com/harfbuzz/harfbuzz/commit/44a3136ae6a28222922da13582bd2dfd3eb823c7#commitcomment-41016353
Garret Rieger 4ba8e3c6 2020-07-29T12:33:42 [ENOMEM] Fix failure to check calloc return. Fixes https://oss-fuzz.com/testcase-detail/6246465148813312.
Garret Rieger d307c24a 2020-07-29T12:23:37 [ENOMEM] check resize() return. Fixes https://oss-fuzz.com/testcase-detail/5641892164009984.
Ebrahim Byagowi 8b63de11 2020-07-29T17:25:00 [docs] Use untouched result of rsvg-convert for HarfBuzz.svg render See also https://github.com/harfbuzz/harfbuzz/commit/1ec77522d838dd751733d3927e3d9589bf298853?short_path=1bb7b85
Ebrahim Byagowi 7bab6087 2020-07-29T08:49:01 [ci] Install meson's master As https://github.com/mesonbuild/meson/issues/7437
Ebrahim Byagowi 58a5961c 2020-07-29T08:44:23 minor spacing tweak
Ebrahim Byagowi 07c43b8c 2020-07-29T08:42:52 minor spacing tweak
Ebrahim Byagowi 5a7cc7fd 2020-07-29T08:33:32 minor spacing tweak
Ebrahim Byagowi 48ad7459 2020-07-29T08:09:08 [ENOMEM] Fix buffer's content check logic So now rest of shape fuzzer also can be enabled. Fixes #2571
Ebrahim Byagowi c33e8006 2020-07-14T19:29:58 [fuzz] Implement failing allocator
Ebrahim Byagowi 44a3136a 2020-07-29T07:03:44 [glib] Default to glib's script type handling 2.29.14 is almost released a decade ago, no need to support archaic glib versions.
Garret Rieger dae32b4f 2020-07-28T18:31:46 [subset] bail out of subsetting if plan allocation fails.
Ebrahim Byagowi d38d6331 2020-07-27T09:19:29 [tests] minor
Ebrahim Byagowi 322426f8 2020-07-27T09:03:35 [tests] Use TTFont of fonttools to avoid temp files
Hamidreza Bayat 08fef158 2020-07-26T17:16:07 Use fonttools's python package instead of cli
Ebrahim Byagowi bec3db49 2020-07-25T13:45:34 [ci] meson-gcc-mingw to crossbuild-win32
Ebrahim Byagowi 24a6f046 2020-07-25T13:18:54 [releasing] unbreak the build Use lower number of parallel jobs as https://circleci.com/gh/harfbuzz/harfbuzz/149413 apparent compiler OOM issue
Ebrahim Byagowi cddfe4ea 2020-07-25T13:09:57 [releasing] Use release buildtype guess will optimize speed and size of the output, non important things anyway for the test only win32 packs
Ebrahim Byagowi a01c7a38 2020-07-25T12:27:31 2.7.0
Evgeniy Reizner b32f2e8b 2020-07-23T11:48:19 Remove unused code from the Khmer shaper.
Ebrahim Byagowi f9ac6ddb 2020-07-22T17:53:04 [meson] Rename 'gtk_doc' option to 'docs'
Ebrahim Byagowi 11ae45f6 2020-07-22T17:52:16 [ci] Don't run cov-analyze https://stackoverflow.com/a/59353318
Ebrahim Byagowi 46ec6db9 2020-07-22T17:30:48 minor
Ebrahim Byagowi 5c46683a 2020-07-22T17:23:22 [fuzz] increase shape fuzzer timeout as https://circleci.com/gh/harfbuzz/harfbuzz/149203
insilications 83c44f69 2020-07-20T17:35:10 [tests] fix PGO build testing Adds 'mangle_path' to IGNORED_SYMBOLS
Ebrahim Byagowi 024fc665 2020-07-20T23:57:27 [ci] disable clang nightly installation they don't like to work apparently for some reason https://circleci.com/gh/harfbuzz/harfbuzz/149164 better to use oss-fuzz docker images, gcr.io/oss-fuzz-base/base-clang, but the fact it uses 16.04 is showstopper for us.
Christoph Reiter d058e56c 2020-07-20T20:50:09 [ci] Update to msys2/setup-msys2@v2 This update introduces better error handling and package caching by default.
Ebrahim Byagowi ae8a71df 2020-07-20T20:16:15 [ci] minor, use --auto-features=enabled
Ebrahim Byagowi 9bb15ee2 2020-07-19T22:24:13 [ci] remove irc notification is just a noise there, yet, done to see if is anyone really wants it let's see how I can bring it back in some other bot
Ebrahim Byagowi f65a8a33 2020-07-19T18:13:48 [ci] run cov-analyze apparently we have to run that also ourselves, let's see
Ebrahim Byagowi ab1079b0 2020-07-18T23:05:50 Merge pull request #2577 from lazka/gha-msvc Use GitHub Actions for msvc bots
Ebrahim Byagowi 05ed1ee0 2020-07-18T23:05:26 [ci] Remove appveyor ci badge As https://github.com/harfbuzz/harfbuzz/pull/2577
Christoph Reiter 93aea76a 2020-07-18T19:32:19 Fix the GHA msvc build Use the 'ilammy/msvc-dev-cmd' action for setting up the msvc env, so we can use powershell everywhere. Remove a directory from PATH which was interfering with the meson build by providing an unrelated pkg-config.exe.
Ebrahim Byagowi d0e2addd 2020-07-18T22:14:52 minor
Ebrahim Byagowi 3a46ae51 2020-07-15T12:46:34 Use GitHub Actions for msvc bots
Ebrahim Byagowi 7e3edfa4 2020-07-18T19:03:36 minor
Qunxin Liu 8e5bc535 2020-07-15T18:54:52 [subset] call collect_mapping only when --gids option is used. collect_mapping is time consuming as it iterates all codepoints in all cmap subtables, only trigger it when necessary
Ebrahim Byagowi 1ebe5bad 2020-07-16T01:45:38 [ci] minor fix
Ebrahim Byagowi e9b71c29 2020-07-16T01:40:48 [ci] cleanup
Ebrahim Byagowi 8cbdb6fa 2020-07-15T13:32:57 [meson] Don't enable benchmark under the conditions ever As we don't want to make headache for packagers as we don't want to enable it when --auto-features=enabled is used.
Ebrahim Byagowi dc981fe9 2020-07-15T13:15:27 [meson] Merge gdi and uniscribe They are the same thing obviously
Christoph Reiter 8e7a9b6e 2020-07-15T09:01:53 msys2-ci: clean up
Christoph Reiter 9a4d590e 2020-07-15T07:38:20 CI: Port MSYS2 jobs from appveyor to github actions
Ebrahim Byagowi 945bcd72 2020-07-15T09:54:32 minor
Ebrahim Byagowi fa0436dd 2020-07-15T09:52:40 [ENOMEM][fuzzer/subset] early return if the result is null I don't see _or_fail APIs idiomatic for the project but since it is there, let's have this
Ebrahim Byagowi 7c433ffd 2020-07-15T09:38:12 Add HB_CUSTOM_MALLOC definition So one can use just HB_CUSTOM_MALLOC instead need for define each of hb_*alloc_impl
Ebrahim Byagowi 60959b08 2020-07-14T20:28:06 [meson] execute find_program('gen-ragel-artifacts.py') only once should rename the script also
Ebrahim Byagowi 5c8e1bd2 2020-07-14T17:47:10 [meson] Don't allow introspection on static library
Ebrahim Byagowi 9566904c 2020-07-14T15:17:17 [morx] minor, mark with unlikely at least just to show this is the unusual path
Ebrahim Byagowi 11d583a9 2020-07-14T06:23:06 [aat] Consume glyph insertion from buffer's max_ops (#2223) Glyph insertion is an expensive operation and we like to have it limited based on buffer's input size which is handled by buffer's max_ops. clusterfuzz-testcase-minimized-harfbuzz_fuzzer-5754958982021120: Before the change: 0.67s user 0.00s system 99% cpu 0.674 total After the change: 0.02s user 0.00s system 98% cpu 0.024 total Which takes much longer on valgrind and tsan bots.
Ebrahim Byagowi 6937092a 2020-07-13T21:32:15 [py] apply lgtm.com python suggestions
Ebrahim Byagowi 2a182128 2020-07-13T20:41:13 [py] minor, comment buffer_add_utf8 call mainly to apply lgtm suggestion, looks better also however, some minor spacing is also applied.
Ebrahim Byagowi 2c1d6994 2020-07-13T20:26:57 [ci] use clang for cov-build to be honest this is done as a let's see what happens move but the background is coverity reveals more things for Firefox project and there should be an interesting reason for it.
Ebrahim Byagowi cdf18e83 2020-07-13T20:07:51 [py] minor, remove unnecessary pass discovered by lgtm